h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-17 21:13:01 +08:00
Code Issues Releases Wiki Activity

Merge pull request #27077 from peppy/log-fire-and-forget-better

Browse Source 
Improve exception logging of unobserved exceptions via `FireAndForget`
This commit is contained in:
Bartłomiej Dach
2024-02-10 13:43:50 +01:00
committed by GitHub
Unverified
parent bd226859fb 0d7e82ab8d
commit 4a516cbccd
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Online/Multiplayer/MultiplayerClientExtensions.cs
+5 -2
View File
@@ -23,9 +23,12 @@ namespace osu.Game.Online.Multiplayer
Debug.Assert(exception != null);
string message = exception.GetHubExceptionMessage() ?? exception.Message;
if (exception.GetHubExceptionMessage() is string message)
// Hub exceptions generally contain something we can show the user directly.
Logger.Log(message, level: LogLevel.Important);
else
Logger.Error(exception, $"Unobserved exception occurred via {nameof(FireAndForget)} call: {exception.Message}");
Logger.Log(message, level: LogLevel.Important);
onError?.Invoke(exception);
}
else