h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-27 07:02:54 +08:00
Code Issues Releases Wiki Activity
53,599 Commits 6 Branches 666 Tags 367 MiB
163c3f9c2d
Commit Graph

8633 Commits

Author SHA1 Message Date
Jai Sharma
d2a49ca266 Use ChatOverlayV2 in message notifier and tests 2022-05-23 21:02:50 +01:00
Jai Sharma
58d39734d0 Integrate ChatOverlayV2 into main game 2022-05-23 21:02:47 +01:00
Dean Herbert
7d93778355
Merge pull request #18290 from jai-x/new-chat-remove-selector-item 
Use dummy channel to show selector and remove `ChannelListSelector`
 2022-05-23 15:49:00 +09:00
Dan Balasescu
7d0470794b
Merge pull request #18353 from frenzibyte/spectator-catch-up-work-alt 
Disallow multi-spectator player clocks from being started/stopped externally
 2022-05-23 13:59:54 +09:00
Dan Balasescu
e3c1c78b17
Merge pull request #18348 from maromalo/mod-key-multiplayer 
Add toggle mod hotkey support in multiplayer room
 2022-05-23 13:45:02 +09:00
Dan Balasescu
f111d33b25
Merge pull request #18339 from peppy/editor-timing 
Add first pieces of editor timing UI
 2022-05-23 11:12:22 +09:00
Bartłomiej Dach
9308d0b012
Merge branch 'master' into mod-key-multiplayer 2022-05-22 19:30:10 +02:00
Bartłomiej Dach
0bef2ca752
Adjust test slightly 
* Import `osuTK.Input` instead of using full qualified name
* Use some more straightforward assertions
 2022-05-22 19:27:20 +02:00
Dean Herbert
eabf578282 Use interface to convey beat sync information 2022-05-22 22:44:54 +09:00
Dean Herbert
d84119ac06
Merge pull request #18343 from frenzibyte/waveform-test-beatmap-failure 
Fix `WaveformTestBeatmap`s potentially providing disposed track
 2022-05-22 21:21:28 +09:00
maromalo
fc25d248ad Test coverage + no virtual 2022-05-21 18:16:29 -03:00
Jai Sharma
efae934e01 Fix slow loading channel test 2022-05-21 17:35:31 +01:00
Jai Sharma
fb06b7658b Merge branch 'master' into new-chat-remove-selector-item 2022-05-21 17:30:06 +01:00
Salman Ahmed
d73afcaf48 Fix existing test coverage false-passing 
Also improves general test coverage to test more realisticly, in order
to produce accurate results.
 2022-05-21 17:12:04 +03:00
Dean Herbert
982856a8b2 Merge branch 'localisable-filter-items' into update-framework 2022-05-21 15:17:51 +09:00
Salman Ahmed
1f17652c1d Fix test failure due to async-loading of content 2022-05-20 19:08:41 +03:00
Salman Ahmed
84a3cee452 Apply rate multiplier outside BPM rounding 2022-05-20 18:04:12 +03:00
Dean Herbert
4633eed78c Merge branch 'master' into localisable-filter-items 2022-05-20 23:55:16 +09:00
Salman Ahmed
de8aedf348 Add failing test case 2022-05-20 17:53:28 +03:00
Dean Herbert
2b3ec53fed Merge branch 'safe-file-writes' into localisable-filter-items 2022-05-20 23:51:24 +09:00
Dean Herbert
c3bfbe8880 Allow BeatSyncedContainer to prefer EditorBeatmap when available 2022-05-20 23:24:57 +09:00
Salman Ahmed
cef99fd020 Disallow transferring track from test WorkingBeatmaps which have local stores 2022-05-20 16:08:31 +03:00
Dean Herbert
2e21d75b10 Move metronome into own class and rename to avoid conflict with mod sounds 2022-05-20 17:30:04 +09:00
Dean Herbert
42179568f3 Initial animation pass on metronome 2022-05-20 17:30:04 +09:00
Dean Herbert
ce7be940e2 Setup basics for control and test 2022-05-20 17:30:04 +09:00
Dan Balasescu
64a371638e
Merge pull request #18236 from peppy/snap-unification 
Add `enum` to snap method as alternative to multiple nested invocations
 2022-05-20 11:35:05 +09:00
Dean Herbert
136ecb45e2 Rename dummy channel and move to a nested class inside the ChannelListing itself 2022-05-19 19:26:14 +09:00
Dean Herbert
16075d2a2f
Merge pull request #18321 from smoogipoo/legacy-catmull 
Fix compatibility issues with legacy Catmull sliders
 2022-05-19 15:42:21 +09:00
Dean Herbert
d187ca2d8c
Merge pull request #18246 from jai-x/new-chat-cache-loaded-channels 
Add drawable channel caching to new chat overlay
 2022-05-19 15:15:47 +09:00
Salman Ahmed
5d3878a737 Add test coverage for slow-loading channels 2022-05-18 22:58:39 +03:00
Dan Balasescu
fe49a7e678 Add failing tests 2022-05-18 17:10:19 +09:00
Dan Balasescu
49340888c0 Fix compile errors 2022-05-18 10:56:42 +09:00
Dean Herbert
1b7ec1be26 Add basic test coverage of new screen 2022-05-17 18:15:14 +09:00
Dean Herbert
218642c300 Update unsafe file write usages 2022-05-16 18:05:27 +09:00
Jai Sharma
ae5b6c3e10 Use dummy channel to show selector and remove ChannelListSelector 
Add dummy channel `DummySelectorChannel` which should be set as the
current channel in the channel manager when the selector in the chat
overlay should be shown.

Refactors the `ChannelListItem` to not show mention pill and close
button when the channel is the dummy selector channel.

Ensure that the `ChannelList` selects the dummy channel on clicking the
selector item.

Removes `ChannelListSelector` as it is no longer needed.

Removes the `setCurrent` parameter from `ChannelManager.JoinChannel`
method as it is no longer needed.
 2022-05-15 20:24:49 +01:00
Dean Herbert
328561f5c8
Merge pull request #18263 from frenzibyte/spotlight-beatmap-badge 
Add support for "spotlight" label in beatmap overlay/listing
 2022-05-15 12:32:20 +09:00
Dean Herbert
b6575c216b Allow selecting all mods at free mod select using ctrl+a 2022-05-15 03:25:14 +09:00
Dean Herbert
282c8aec86
Fix typo in test step 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2022-05-15 03:09:15 +09:00
Dean Herbert
a759cf2dab Add key binding to deselect all mods 
Defaults to `Backspace`.
 2022-05-15 02:51:58 +09:00
Salman Ahmed
d5027cdfbd Add FeaturedInSpotlight property to API beatmapsets 2022-05-14 19:46:13 +03:00
Jai Sharma
bd68ffa805 Fix textbox focus test in ChatOverlayV2 2022-05-14 12:16:00 +01:00
Dean Herbert
a346456daf Add test coverage of new traversal keys 2022-05-14 03:01:42 +09:00
Dean Herbert
c0abce918f Add enum to snap method as alternative to mutliple nested invocations 2022-05-12 16:19:07 +09:00
Dan Balasescu
5f2d9bf04c
Merge pull request #18211 from frenzibyte/audio-adjustment-breakage-alt 
Fix mods potentially adjusting track while not selected
 2022-05-12 15:44:19 +09:00
Salman Ahmed
82c4a5fe9f
Merge branch 'master' into new-chat-visibility-behaviour 2022-05-12 09:04:24 +03:00
Dan Balasescu
678cde3310
Merge pull request #18230 from bdach/mod-overlay/data-flow-refactor 
Restructure data flow in mod select overlay
 2022-05-12 14:40:49 +09:00
Dean Herbert
3d64dc53a6 Merge branch 'master' into audio-adjustment-breakage-alt 2022-05-12 14:18:28 +09:00
Dean Herbert
6ba0760b17
Merge branch 'master' into new-chat-visibility-behaviour 2022-05-12 13:59:35 +09:00
Dan Balasescu
effc92475b
Merge pull request #18227 from frenzibyte/fix-results-screen-test-failure 
Fix intermittent test failures in results screen
 2022-05-12 11:19:13 +09:00
Jai Sharma
c45e8f619b Update ChannelList test scene 2022-05-11 22:52:25 +01:00
Bartłomiej Dach
7ac6073f13
Fix column test scene to work 2022-05-11 22:31:25 +02:00
Bartłomiej Dach
315c67a316
Add failing test case for ruleset without all mod types 2022-05-11 22:03:41 +02:00
Bartłomiej Dach
9b7ff9f2ee
Rename modSelect{Screen -> Overlay}2 variable 2022-05-11 18:05:09 +02:00
Bartłomiej Dach
62f6caf76d
Rename ModSelect{Screen -> Overlay} test scenes 2022-05-11 18:04:39 +02:00
Salman Ahmed
9d30b490ad Fix intermittent test failures in results screen 2022-05-11 18:28:30 +03:00
Salman Ahmed
a97986df1c
Merge branch 'master' into update-libraries 2022-05-11 15:58:45 +03:00
Dean Herbert
fecf92e16f Update libraries to latest versions 2022-05-11 19:54:59 +09:00
Salman Ahmed
d51689e9ae Unfocus textbox when dismissing popover in test scene 2022-05-11 11:25:41 +03:00
Salman Ahmed
f797514bce Add failing test cases 2022-05-11 09:51:59 +03:00
Salman Ahmed
e43ce28ada Remove references of "difficulty point" in sample point test scene 
Fat-fingered.
 2022-05-11 09:51:09 +03:00
Dean Herbert
53259251af
Merge branch 'master' into mod-overlay/rename-new 2022-05-11 10:15:59 +09:00
Dean Herbert
dd316befb4
Merge pull request #18214 from bdach/mod-overlay/delete-old 
Remove old mod overlay code
 2022-05-11 10:09:42 +09:00
Bartłomiej Dach
76c63f1d0a
Rename ModSelect{Screen -> Overlay} in place of removed old design 2022-05-10 22:56:50 +02:00
Bartłomiej Dach
c4c7556fb2
Make remains of TestSceneModSettings non-visual 
As they're not really testing anything visual.
 2022-05-10 22:07:26 +02:00
Bartłomiej Dach
33634cba1e
Remove old mod buttons 2022-05-10 21:58:22 +02:00
Bartłomiej Dach
24c59e2f2f
Remove old user mod select overlay 2022-05-10 21:52:17 +02:00
Bartłomiej Dach
4a3447f59f
Remove old free mod select overlay 2022-05-10 21:45:57 +02:00
Bartłomiej Dach
9cfe2cc310
Move TestCustomisableModRuleset out of TestSceneModSettings 2022-05-10 21:43:57 +02:00
Salman Ahmed
a0f1c48e80 Fix ModTimeRampTest failing due to changes in Update method 2022-05-10 19:24:36 +03:00
Dean Herbert
0eb29d56f2 Rename new test method to be english 2022-05-10 18:06:03 +03:00
Dean Herbert
87f6f74795 Add failing test coverage of adding a file to a detached beatmap across threads 2022-05-10 21:04:30 +09:00
Dean Herbert
9aadc274bf Show first run dialog on first run of the game 2022-05-10 18:21:35 +09:00
Salman Ahmed
14a21e9224 Workaround interface mocks in TestSceneFirstRunSetupOverlay breaking with hot reload 2022-05-10 11:41:41 +03:00
Dean Herbert
a5b454edc7 Remove unnecessary DI caching of SentryLogger 2022-05-10 16:09:16 +09:00
Dan Balasescu
886a4815fa
Merge pull request #18180 from frenzibyte/fix-toolbox-double-tap 
Fix `SettingsToolboxGroup` not clearing transforms before updating autosize
 2022-05-10 13:48:02 +09:00
Salman Ahmed
beb86a7f7c Remove usage of player settings in TestSceneSettingsToolboxGroup 2022-05-09 23:57:27 +03:00
Bartłomiej Dach
38e463d31d
Add failing test case for invalid mod adjustment management 2022-05-09 22:16:04 +02:00
Jai Sharma
ebb64d1f1a Use AddUntilStep to wait for channel to load and become visible 2022-05-09 20:15:43 +01:00
Salman Ahmed
5726cf660f Improve test coverage to use existing ThemeComparisonTestScene 2022-05-09 21:19:34 +03:00
Salman Ahmed
ceb6276d2f Add failing test case 2022-05-09 18:19:29 +03:00
Jai Sharma
9ec8b609a8 Update channel visibility tests to be more correct 2022-05-09 12:11:25 +01:00
Jai Sharma
5f3bea846b Simplify fetching of DrawableChannel 2022-05-09 12:11:25 +01:00
Salman Ahmed
deda1c83e6 Add failing test case 2022-05-09 13:48:51 +03:00
Salman Ahmed
0fe121f48a Move and rename settings toolbox group test scene 2022-05-09 13:25:33 +03:00
Dan Balasescu
a16f2349aa Fix next queued item not selecting after gameplay 2022-05-09 17:55:42 +09:00
Dean Herbert
ab1d46b71c
Merge pull request #17270 from frenzibyte/multiplayer-disable-adaptive-speed 
Disable mod "Adaptive Speed" in multiplayer
 2022-05-09 17:31:47 +09:00
Dan Balasescu
e9cc3ab54a
Merge pull request #18164 from Joehuu/fix-exit-dialog-bad-state 
Fix popup dialog potentially not clicking last button when dismissed
 2022-05-09 17:22:03 +09:00
Salman Ahmed
1677f1d696
Merge branch 'master' into results-screen-scaling 2022-05-09 11:11:55 +03:00
Joseph Madamba
bc839be4d8 Add failing rapid back button exit test 2022-05-08 14:40:29 -07:00
Salman Ahmed
077c77d524 Add method for scaling results screen in tests 2022-05-08 16:00:07 +03:00
Bartłomiej Dach
38c004d734
Add test coverage for hiding mod columns 2022-05-08 14:54:06 +02:00
Bartłomiej Dach
cbd1169495
Move cache declarations of ISamplePlaybackDisabler to interface 2022-05-08 10:38:58 +02:00
Bartłomiej Dach
9ae019eb39
Move ISamplePlaybackDisabler to more general namespace 2022-05-08 10:38:58 +02:00
Bartłomiej Dach
bdea6d8654
Add failing test for mod overlay not closing on entering skin editor 2022-05-07 22:47:19 +02:00
Bartłomiej Dach
a3e61fddcb
Rename skin editor scene library test scene to be more general 2022-05-07 22:43:53 +02:00
Bartłomiej Dach
836de49135
Adjust skin editor scene library test for extensibility 2022-05-07 22:43:47 +02:00
Bartłomiej Dach
5d6d7bb324
Fix incorrect assert in multiplayer song select test scene 2022-05-07 13:15:16 +02:00
Bartłomiej Dach
e7e7486a8e
Merge branch 'mod-overlay/back-button' into mod-overlay/integration 2022-05-07 10:59:30 +02:00
Bartłomiej Dach
9d3e67b10d
Update free mod select/deselect all test after back button addition 2022-05-07 10:25:23 +02:00
Bartłomiej Dach
1c029552d7
Add test coverage for mod select back button 2022-05-07 10:23:49 +02:00
Bartłomiej Dach
e1953c484c
Add test coverage for selecting/deselecting all mods on free mod select 2022-05-07 09:50:08 +02:00
Bartłomiej Dach
35c106efaa
Add test coverage for deselecting all mods on user mod select 2022-05-07 09:29:33 +02:00
Dean Herbert
dd63657dfb
Merge pull request #18065 from huoyaoyuan/code-style 
Enforce code style analysis shipped with .NET SDK
 2022-05-07 14:58:19 +09:00
Bartłomiej Dach
380cd1e036
Add test coverage for lack of customisation on free mod select 2022-05-06 21:35:22 +02:00
Salman Ahmed
f222affe88
Merge branch 'master' into fix-toolbox-expansion 2022-05-06 17:54:14 +03:00
Salman Ahmed
144d33f0d2
Merge branch 'master' into distance-snapping-test 2022-05-06 17:29:27 +03:00
Bartłomiej Dach
e527574ede
Merge branch 'master' into fix-toolbox-expansion 2022-05-06 13:47:36 +02:00
Bartłomiej Dach
19297375e2
Update tests to reflect new expected behaviour 2022-05-06 13:47:13 +02:00
Dean Herbert
98eab9668d
Merge pull request #18119 from bdach/mod-overlay/broken-hover 
Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select
 2022-05-06 20:42:33 +09:00
Dean Herbert
daed42513e Fix outdated test asserts 2022-05-06 18:44:25 +09:00
Bartłomiej Dach
8f217d1e97
Add failing test case for broken hover behaviour 2022-05-06 11:37:50 +02:00
Dean Herbert
32b40bdabf Rename DistanceBetweenTick to be plural 2022-05-06 15:45:36 +09:00
Dean Herbert
060461a431 Add test coverage of multiplayer gameplay exit flow 2022-05-06 15:22:22 +09:00
Dean Herbert
641584a049
Merge branch 'master' into multiplayer-disable-adaptive-speed 2022-05-06 14:00:44 +09:00
Jai Sharma
7ffe3b132f Use BindableFloat in chat height tests 2022-05-05 23:13:43 +01:00
Bartłomiej Dach
a2ab79620a
Update song select exit via click test to match new expectations 2022-05-05 22:16:57 +02:00
Bartłomiej Dach
d296f78dfe
Replace references to old mod select classes in multiplayer match screen test 2022-05-05 22:16:57 +02:00
Bartłomiej Dach
ecc2805099
Replace references to old mod select classes in match song select test 
Also note the change from `songSelect.ChildrenOfType<>()...` to
`this.ChildrenOfType<>()...` - because the new design is registered at
game-level, the mod select is not a child of the song select screen
anymore.
 2022-05-05 22:16:57 +02:00
Bartłomiej Dach
199bdb8e7d
Replace reference to old mod select in multiplayer test 2022-05-05 22:16:56 +02:00
Bartłomiej Dach
17c19063f7
Fix user dim test scene accumulating no fail instances in SelectedMods 
The old design was apparently somehow tolerant of multiple instances of
the same mod in `SelectedMods`, but the new one is not.

Fix the test, because appending to a list of mods that was getting
modified by previous tests is generally not how tests should be
written.
 2022-05-05 22:16:56 +02:00
Bartłomiej Dach
8f65e0e60f
Add failing test coverage for toggling mod overlay with hotkey 2022-05-05 22:16:56 +02:00
Bartłomiej Dach
ac08498f35
Use plum colour scheme in multiplayer to match rest of multiplayer screens 2022-05-05 22:16:54 +02:00
Bartłomiej Dach
407db7ff9d
Replace old mod select overlay with new design 2022-05-05 22:16:54 +02:00
Bartłomiej Dach
8002726c9c
Add test coverage for dismissing customisation area with Escape 2022-05-05 19:17:36 +02:00
Dean Herbert
9d48bb41c9
Merge branch 'master' into new-chat-overlay 2022-05-05 23:12:31 +09:00
Jai Sharma
5657e7f11e Fix chat height saving/loading test 2022-05-05 14:52:03 +01:00
Jai Sharma
9cb52f8879 Add tests for chat height saving/loading 2022-05-05 14:21:26 +01:00
Dean Herbert
5029710de7 Merge branch 'master' into distance-snapping-test 2022-05-05 22:00:40 +09:00
Bartłomiej Dach
a859ca0b89
Merge branch 'master' into playlist-keyboard-traversal 2022-05-05 14:45:58 +02:00
Dan Balasescu
e46f99bdba
Merge branch 'master' into dialog-overlay-thread-woes 2022-05-05 20:57:51 +09:00
Salman Ahmed
8501a41619 Bring back separate bool properties as non-cascading 2022-05-05 14:37:38 +03:00
Dan Balasescu
39d10487b9
Merge branch 'master' into snapping-tidy-distance 2022-05-05 19:55:55 +09:00
Dean Herbert
e7205d8593 Reset all test data before each test method to avoid channels stuck in joined state 2022-05-05 19:09:56 +09:00
Dean Herbert
4efaa41670
Merge branch 'master' into new-chat-overlay 2022-05-05 18:57:00 +09:00
Salman Ahmed
269e15c167 Add test coverage of distance spacing multiplier working with distance snap grid 2022-05-05 18:49:12 +09:00
Dean Herbert
de9b3d33eb Rename misleading DistanceSpacing variable 2022-05-05 17:08:09 +09:00
Dean Herbert
19cf9dc20b Merge branch 'snapping-tidy-distance' 2022-05-05 16:51:32 +09:00
Dean Herbert
977e6d8a80 Add xmldoc for IDistanceSnapProvider and related properties 2022-05-05 16:25:45 +09:00
Dean Herbert
f6fc926f1a Add xmldoc and rename methods in IPositionSnapProvider for legibility 2022-05-05 15:58:21 +09:00
Salman Ahmed
86aa2125fe Add test coverage for multiplayer mod validity methods 2022-05-05 08:13:29 +03:00
Salman Ahmed
a26793cd65 Add missing Test prefix 2022-05-05 06:12:24 +03:00
Salman Ahmed
f28978b856 Handle against playlists which disallow selection 
`SelectedItem.Disabled` is also not checked against in the select-via-click flow inside `DrawableRoomPlaylistItem` (only `AllowSelection` is checked).
 2022-05-05 05:48:35 +03:00
Dean Herbert
a27fcda9f1 Fix failing tests due to CurrentDialog being unexpectedly not set after Push 2022-05-05 01:52:39 +09:00
Salman Ahmed
8f04db5df5 Bring back behaviour of checking incompatibility on gameplay validity 2022-05-04 17:21:19 +03:00
Salman Ahmed
e9ecf26b6a Merge branch 'master' into multiplayer-disable-adaptive-speed 2022-05-04 17:12:03 +03:00
Jai Sharma
1a85e1267b Ensure focus is directed to ChatTextBox from ChatOverlay and add tests 2022-05-04 14:43:40 +01:00
Dean Herbert
e920bbd497
Merge pull request #18081 from bdach/mod-overlay/test-coverage-parity 
Port test coverage from old mod select overlay to new design
 2022-05-04 20:24:50 +09:00
Dean Herbert
cf220f171b Add test coverage of cross-thread transforms if a dialog is pushed too early 2022-05-04 20:23:36 +09:00
Bartłomiej Dach
ec27fa8e85
Add test coverage for keyboard selection 2022-05-04 13:15:10 +02:00
Bartłomiej Dach
6380216263
Nudge click location to avoid placement failures 2022-05-04 11:56:44 +02:00
Bartłomiej Dach
a759e641eb
Enforce composer aspect ratio to avoid depending on ambient window size 2022-05-04 11:56:29 +02:00
Dean Herbert
f899c3e68f Add test coverage of circle placement around editor toolboxes 2022-05-04 17:56:53 +09:00
Huo Yaoyuan
8e96af8ff0 Update indentation to be clearer 2022-05-04 13:43:59 +08:00
Bartłomiej Dach
f5fa41356e
Rewrite mod instance management again to pass tests 2022-05-03 22:31:34 +02:00
Bartłomiej Dach
216dfb7e91
Expand incompatibility test to cover logic more thoroughly 2022-05-03 21:45:40 +02:00
Bartłomiej Dach
970361676b
Fix setting items not creating if mods initially not empty 2022-05-03 21:45:40 +02:00
Bartłomiej Dach
89d8ed8e20
Port existing test coverage 2022-05-03 21:45:39 +02:00
Dean Herbert
4fb66a812f
Merge branch 'master' into sheared-search-textbox 2022-05-03 14:12:59 +09:00
Huo Yaoyuan
5513710b2e Fix IDE0055 2022-05-03 13:09:19 +08:00
Ganendra Afrasya
e6fbb19951 Implement new search textbox design 2022-05-03 11:13:07 +07:00
Dean Herbert
faeefc5e18
Merge pull request #16576 from frenzibyte/osu-distance-spacing 
Add "distance spacing" support in editor for osu! ruleset
 2022-05-03 12:15:18 +09:00
Dean Herbert
53d65e8215
Merge pull request #18021 from frenzibyte/overlay-ruleset-selector-redesign 
Update overlay ruleset selector inline with osu-web design
 2022-05-02 17:53:01 +09:00
Jai Sharma
bcce807311 Fix chat command test as reference equality checks on PM channels doesn't seem to to work 2022-05-01 12:20:54 +01:00
Jai Sharma
de393f735f Implement basic layout and behaviour of new chat overlay 
Provides initial implementation of new chat overlay in component
`ChatOverlayV2`. Contains only the basic functionality required for
a functioning chat overlay according to the new design with the intent
of added the rest of the functionality in subsequent PRs.

Backports existing tests for the current chat overlay except for ones
testing keyboard shortcuts (since they haven't been added) and tab
closing behaviour (since no tabs).
 2022-04-30 23:59:47 +01:00
Dean Herbert
670b51324e Add basic test at top of first run scene to make adjusting UI easier 2022-04-29 23:45:02 +09:00
Dean Herbert
5c04ab18ec
Merge pull request #18011 from frenzibyte/rewind-shift-click 
Allow rewinding random in song select with "Shift + Left Click"
 2022-04-29 23:10:29 +09:00
Salman Ahmed
55c03dc04d Fix silly mistake in ordering and update test colour scheme 2022-04-29 12:40:46 +03:00
Salman Ahmed
5e19bdbf43 Refactor beatmap ruleset selector test scene 2022-04-29 12:23:02 +03:00
Salman Ahmed
fae8d86e15 Fix regressed profile ruleset selector test scene 
Due to the changes in `APIUser`, which change equality to be based on ID.
 2022-04-29 12:20:35 +03:00
Salman Ahmed
856ca96b66 Allow right-clicking to rewind on random button 2022-04-29 10:12:24 +03:00
Dean Herbert
1f1845d69b
Merge branch 'master' into multiplayer-force-start-2 2022-04-29 14:45:40 +09:00
Salman Ahmed
fef94d49f4 Revert "Convert data type of DistanceSpacing to float" 
This reverts commit 7aaa88cac2.
 2022-04-29 08:02:07 +03:00
Dan Balasescu
fc21de8138
Merge pull request #18008 from peppy/add-tutorial 
Add first run "beatmaps" screen
 2022-04-29 13:10:45 +09:00
Dean Herbert
652e022fd6
Merge pull request #17973 from bdach/mod-overlay/dim-columns-offscreen 
Dim offscreen columns on new mod select overlay
 2022-04-29 11:55:27 +09:00
Dean Herbert
a75051cd00 Merge branch 'master' into add-tutorial 2022-04-29 11:25:17 +09:00
Salman Ahmed
294340279e Add inputting test coverage 2022-04-29 04:14:09 +03:00
Bartłomiej Dach
96f6c918a8
Merge branch 'master' into first-run-behaviour-screen 2022-04-29 00:55:30 +02:00
Dean Herbert
b902e69634 Update test expectations based on new screen order 2022-04-28 20:16:32 +09:00
Dean Herbert
3c0bdcaf38 Rename screen, add tests and add stable import step 2022-04-28 19:01:21 +09:00
Dean Herbert
58399a5113 Add tutorial download support and improve the visuals "slightly" 2022-04-28 19:01:21 +09:00
Dean Herbert
99d2d7b805 Add very basic implementation of bundled beatmap downloader 2022-04-28 19:01:21 +09:00
Salman Ahmed
abb88b0907 Move distance spacing application to DistanceSnapGrid 2022-04-28 10:54:38 +03:00
Salman Ahmed
7aaa88cac2 Convert data type of DistanceSpacing to float 2022-04-28 10:24:36 +03:00
Salman Ahmed
2e8372fe90 Minor cleanup 
Just from reading diff.
 2022-04-28 07:14:43 +03:00
Salman Ahmed
71533808e9 Add test case for DistanceSpacingMultiplier in distance snapping test scene 2022-04-28 07:14:43 +03:00
Salman Ahmed
66c730c382 Change distance spacing keybind to Ctrl+Alt 2022-04-27 17:11:23 +03:00
Dean Herbert
d0ccd6f895 Merge branch 'master' into first-run-header 2022-04-27 19:26:02 +09:00
Dean Herbert
20a50ddb6e Add missing OverlayColourProvider in test scene 2022-04-27 18:45:40 +09:00
Dean Herbert
18e6629161 Merge branch 'master' into first-run-behaviour-screen 2022-04-27 16:02:57 +09:00
Bartłomiej Dach
a849bfcf60
Rewrite dim test to pass headless 
Unfortunately neuters the test a touch, but alas.
 2022-04-26 23:11:41 +02:00
Salman Ahmed
8842847b18 Fix wrong result applied 2022-04-27 00:05:49 +03:00
Salman Ahmed
1676c2c3f6 Change boolean argument to HitResult instead 2022-04-27 00:05:15 +03:00
Salman Ahmed
a884f20c65 Add failing test case 2022-04-26 23:27:03 +03:00
Dean Herbert
52a8f3848d Expose font size and add big button test 2022-04-26 18:14:57 +09:00
Salman Ahmed
4638dd97db
Merge branch 'master' into first-run-behaviour-screen 2022-04-26 12:09:32 +03:00
Dean Herbert
6864623bac Add ShearedButton test coverage 2022-04-26 18:03:27 +09:00
Dean Herbert
c52c08fe97 Rename test to increase scope 2022-04-26 17:31:39 +09:00
Dean Herbert
942f4e8ac2 Merge branch 'first-run-show-get-started' into first-run-behaviour-screen 2022-04-26 16:10:16 +09:00
Dean Herbert
d310886c26 Add test coverage of IsPlaying state during fail and pause 2022-04-26 12:09:18 +09:00
Bartłomiej Dach
24a1eb8003
Add test coverage for column dimming behaviour 2022-04-25 23:41:40 +02:00
Dean Herbert
7ac3ba132c Remove unused using statements 2022-04-25 18:55:12 +09:00
Dean Herbert
a0e80cf901 Merge branch 'master' into scene-library-incompatible-mods 2022-04-25 18:54:40 +09:00
Dean Herbert
83970f009c
Merge branch 'master' into settings-filter-regression-fix-2 2022-04-24 17:40:25 +09:00
Dean Herbert
60f513abd9
Merge pull request #17957 from peppy/disable-first-run-temporary 
Disable first run screen from appearing on startup until it is more complete
 2022-04-24 17:37:17 +09:00
Dean Herbert
d0fee3c212
Merge pull request #17950 from Susko3/ButtonSystem-keys 
Allow any key to trigger the osu! cookie in the initial state
 2022-04-24 17:30:22 +09:00
Dean Herbert
1b2467d3ed Disable first run screen from appearing on startup until it is more complete 2022-04-24 16:35:41 +09:00
Dean Herbert
a40d140353
Merge pull request #17956 from frenzibyte/sections-container-pagination 
Fix page up / down in `SectionsContainer` with fixed header skipping content
 2022-04-24 15:36:35 +09:00
Salman Ahmed
70a93c0e7e Move DistanceSpacingMultiplier bindable to its own IDistanceSnapProvider interface 2022-04-24 08:33:00 +03:00
Salman Ahmed
4f8f27a58b Merge branch 'master' into osu-distance-spacing 2022-04-24 05:23:30 +03:00
Salman Ahmed
05736fb84c Add failing test case for navigation via PageUp/PageDown 2022-04-24 01:52:11 +03:00
Salman Ahmed
e8cf4466b0 Make sections container test scene more usable 
Head busted the moment I opened this test scene.

Cleaned it up a bit to make it easier to test changes.
 2022-04-24 01:52:10 +03:00
Salman Ahmed
60e76d62c1 Add failing test cases 2022-04-23 23:16:06 +03:00
Salman Ahmed
6ab188f8f9 Split skin editor scene library test to own file 
Rather than stuffing more random cases to `TestSceneScreenNavigation`.
 2022-04-23 23:15:45 +03:00
Salman Ahmed
daadc3fc21 Simplfiy and share notification dimsiss method across test scenes 
Might as well inline, but I feel like it will require adding the same
comment across all usages, because just `State.Value = Hidden` in an
until step feels off, dunno.
 2022-04-23 23:14:19 +03:00
Susko3
684d88ba75 Add full OsuGame tests 
These tests ensure the expected behaviour is not broken in the future.
 2022-04-23 19:01:55 +02:00
Susko3
cdfef08846 Add tests for shortcut keys 2022-04-23 18:44:50 +02:00
Dean Herbert
d97dc22e79 Add missing dependencies for behaviour screen test 2022-04-23 21:23:41 +09:00
Bartłomiej Dach
98b7b156c7
Merge branch 'master' into first-run-setup-sheared-overlay 2022-04-23 00:32:07 +02:00
Bartłomiej Dach
e246357b36
Merge branch 'master' into sheared-overlay-container-click-away 2022-04-22 22:26:35 +02:00
Salman Ahmed
5120faa830 Merge branch 'master' into mod-overlay/incompatibility-panels-clickable 2022-04-22 22:19:42 +03:00
Salman Ahmed
2961c383f6 Add failing test case 2022-04-22 20:33:37 +03:00
Dan Balasescu
b293d3923c Merge branch 'master' into multiplayer-force-start-2 2022-04-23 01:03:55 +09:00
Dean Herbert
1caee38768 Add first-run "behaviour" screen to allow users a choice of more familiar UX 2022-04-22 18:06:56 +09:00
Dan Balasescu
b1cf917b49
Merge pull request #17823 from peppy/settings-filter-fixes 
Fix incorrect settings state if searching too quickly (during load process)
 2022-04-22 16:38:41 +09:00
Dean Herbert
f735d381a7
Merge branch 'master' into mod-overlay/incompatibility-panels-clickable 2022-04-22 16:26:46 +09:00
Dean Herbert
14e17c8b7b Update TestIncompatibilityDisplay in line with new functionality 2022-04-22 16:22:18 +09:00
Dean Herbert
06594ca0c8 Refine assertion to ensure correct section is current, rather than any section 2022-04-22 15:30:12 +09:00
Dean Herbert
27c7864562
Merge pull request #17917 from bdach/mod-overlay/flaky-free-mod-select-test 
Fix flaky test in free mod select test scene
 2022-04-22 12:54:47 +09:00
Bartłomiej Dach
e9bd87545e
Fix flaky test in free mod select test scene 2022-04-22 00:07:00 +02:00
Bartłomiej Dach
cd898344cb
Add test coverage of new incompatibility behaviour 2022-04-21 23:49:40 +02:00
Bartłomiej Dach
8c6864727e
Merge branch 'master' into first-run-setup 2022-04-21 22:14:57 +02:00
Salman Ahmed
295558b24d
Merge branch 'master' into settings-filter-fixes 2022-04-21 20:06:14 +03:00
Salman Ahmed
6ad10672ee
Merge branch 'master' into update-framework 2022-04-21 19:30:57 +03:00
Dean Herbert
119a81849c Merge branch 'update-framework' into settings-filter-fixes 2022-04-22 00:55:15 +09:00
Dean Herbert
832d37b2c2 Update screen transition events to use new event args 2022-04-22 00:52:44 +09:00
Dan Balasescu
08d250fe58 Rename MatchStarted() -> GameplayStarted() 2022-04-21 22:39:24 +09:00
Dean Herbert
d17c16d904 Merge branch 'master' into first-run-setup 2022-04-21 19:50:26 +09:00
Dean Herbert
f5d24add58 Fix TestSceneSkinnableSound not working under visual tests 
oops
 2022-04-21 16:49:21 +09:00
Dean Herbert
55270df6fc
Merge pull request #17833 from jai-x/new-chat-channel-list 
Implement `ChannelList` for new chat design
 2022-04-21 16:34:35 +09:00
Dean Herbert
0b81ae9de2 Convert to using sheared overlay container 
Add better click-to-dismiss logic for sheader overlays
 2022-04-21 16:28:44 +09:00
Dean Herbert
5c21a55e00 Merge branch 'sheared-overlay-container-click-away' into first-run-setup-sheared-overlay 2022-04-21 16:28:33 +09:00
Dean Herbert
2769d8e8cf Add test coverage of ShearedOverlayContainer 2022-04-21 16:27:27 +09:00
Dean Herbert
7d8cf1bbb6 Merge branch 'master' into first-run-setup 2022-04-21 15:49:39 +09:00
Dean Herbert
5c0e5eb6f4
Merge pull request #17899 from Joehuu/localise-most-strings 
Use existing web localisation for most hardcoded strings
 2022-04-21 14:48:12 +09:00
Dean Herbert
a9163727db Mark selected channel null in test when selector is activated 2022-04-21 13:44:14 +09:00
Joseph Madamba
0146949ad6 Fix failing string comparison tests 2022-04-20 16:52:24 -07:00
Jai Sharma
5319bce772 Revert DI usage of ChannelSelectorState in favour of directly binding BindableBool SelectorActive 2022-04-20 21:05:33 +01:00
Jai Sharma
e596c9d171 Use Bindable<ChannelSelectorState> to control selector active visibility 2022-04-20 19:12:43 +01:00
Dean Herbert
b722ff8dc5 Merge branch 'master' into mod-overlay/extension-points 2022-04-20 23:17:04 +09:00
Dean Herbert
2906af323a Fix incorrectly written string equality logic 2022-04-20 17:51:08 +09:00
Dean Herbert
1032dc235d Rename PopupScreenTitle to ShearedOverlayHeader 2022-04-20 16:01:15 +09:00
Dean Herbert
7e7fa633f0 Use direct localised string reference in test 2022-04-20 14:51:16 +09:00
Dean Herbert
c562004fe9 Add test coverage of only showing on first run 2022-04-19 17:08:38 +09:00
Dean Herbert
6d534046ff Add keyboard traversal support for first run dialog (and tidy up step traversal logic) 2022-04-19 14:57:15 +09:00
Dean Herbert
a8d32a2061 Add test coverage of notification resume flow 2022-04-19 14:53:01 +09:00
Dean Herbert
5fd64a4c78 Add test coverage to ensure we don't leave any screens in the first run overlay 2022-04-19 14:53:01 +09:00
Dean Herbert
9074eb283d Show a notification instead of blocking exit of wizard 2022-04-19 14:53:01 +09:00
Dean Herbert
fb7dc89503 Ensure wizard returns to initial screen after completion 2022-04-19 14:53:01 +09:00
Dean Herbert
ea52fab5b1 Tidy up dependencies and test naming 2022-04-19 14:53:01 +09:00
Dean Herbert
288f759bb4 Add test coverage of navigation 2022-04-19 14:53:01 +09:00
Dean Herbert
e064f2f23e Improve general layout and allow overlay to be displayed without dependencies for now 2022-04-19 14:53:01 +09:00
Dean Herbert
ae07b2b512 Initial setup 2022-04-19 14:53:01 +09:00
Dean Herbert
83e89b3e80 Add unread count to INotificationOverlay and fix toolbar button DI logic 2022-04-19 11:16:45 +09:00
Salman Ahmed
94335c2938 Update further usages to cache/resolve via interface 2022-04-19 00:18:10 +03:00
Dan Balasescu
bb8b94f8ad
Merge branch 'master' into i-notification-overlay 2022-04-19 06:03:56 +09:00
Salman Ahmed
3cbc6cd297 Update further tests to cache using IDialogOverlay 2022-04-18 21:04:22 +03:00
Dean Herbert
043599081b Split out INotificationOverlay to allow for easier testing 2022-04-18 20:14:01 +09:00
Dean Herbert
72a33c0926 Split out step for dialog overlay load wait 2022-04-18 20:06:08 +09:00
Dean Herbert
d86e3abf2c Fix invalid rename 2022-04-18 20:04:38 +09:00
Dean Herbert
e315313266 Split out IDialogOverlay to allow for easier testing 2022-04-18 18:36:26 +09:00
Salman Ahmed
80cce7c3cb Add failing test case 2022-04-18 06:59:58 +03:00
Bartłomiej Dach
4b6d42c7e8
Add assertion covering free mod selection mod validity filter 2022-04-17 23:28:52 +02:00
Bartłomiej Dach
9942b0a946
Add test scene for free mod select screen 2022-04-17 23:28:52 +02:00
Bartłomiej Dach
20c17b8c98
Make base mod select screen abstract 2022-04-17 23:28:51 +02:00
Bartłomiej Dach
15c54b38c1
Merge branch 'master' into fix-popup-dialog-handling-exit-sequence 2022-04-16 19:01:18 +02:00
Jai Sharma
f1dd319fd9 Implement ChannelList for new chat design 
Reference design: https://www.figma.com/file/f8b2dHp9LJCMOqYP4mdrPZ/Client%2FChat?node-id=1%3A297

Adds new component `ChannelList` which makes up the sidebar channel
selector of the new chat design. Contains two separate fill flows for
public and private `ChannelItem` child components.

Exposed bindable `SelectorActive` to indicate current state of the "Add
more channels" button. Requires `Bindable<Channel>` from parent
component.

Renames and updates the `TestSceneChannelListItem` to
`TestSceneChannelList` to make use of new component and having both
tests seemed redundant.
 2022-04-15 15:44:38 +01:00
Dan Balasescu
8a55f9b968
Merge pull request #17302 from peppy/fix-spectator-seeks 
Fix spectator not starting from current player position
 2022-04-15 13:28:49 +09:00
Dan Balasescu
792ee3d171
Merge pull request #17802 from peppy/match-start-control-test-refactor 
Refactor `TestSceneMatchStartControl` to avoid usage of `TestMultiplayerClient`
 2022-04-15 13:28:21 +09:00
Dean Herbert
6081c29ae1 Remove ununsed using statement 2022-04-15 10:18:29 +09:00
Dean Herbert
a0ac316d6e Fix test matching conditions 2022-04-15 01:41:55 +09:00
Dean Herbert
21a5a2fd69 Add failing test coverage of incorrect current section after quick setting search 2022-04-14 20:36:49 +09:00
Dean Herbert
50a478ea5f Add failing test coverage of searching too fast not hiding filtered settings 2022-04-14 20:14:02 +09:00
Dean Herbert
392ce7390e Add test scene covering ScalingContainer delayed animations 2022-04-14 19:04:31 +09:00
Dan Balasescu
9de4d416e2 Merge branch 'master' into fix-spectator-seeks 2022-04-14 18:54:52 +09:00
Dean Herbert
c8db7cf2a8 Reset audio offset before each test run in TestSceneMasterGameplayClockContainer 2022-04-14 18:09:23 +09:00
Dean Herbert
58d5cf4560 Remove unused using statement 2022-04-14 16:37:59 +09:00
Dean Herbert
f48a9ba90a Add test coverage of nested screen stacks not handling dialog dismissal properly 2022-04-14 16:19:34 +09:00
Dan Balasescu
494955aff1 Resolve inspection issues 2022-04-14 13:11:11 +09:00
Dean Herbert
0a7fbcad1e
Merge branch 'master' into match-start-control-test-refactor 2022-04-13 22:26:10 +09:00
Dean Herbert
c77a7b75d3 Tidy things up 2022-04-13 21:12:35 +09:00
Dean Herbert
8b1fd051c6 Fix remaining autostart and gameplay tests 2022-04-13 21:04:15 +09:00
Dean Herbert
c0ad91796d Fix gameplay start flow 2022-04-13 20:57:40 +09:00
Dean Herbert
8a7b37856c Implement IsHost to return correct value for current state 2022-04-13 20:51:05 +09:00
Dean Herbert
4b6a9fbf47 Reimplement beatmap availability test 2022-04-13 20:41:56 +09:00
Dean Herbert
331242d585 Update transfer host logic and simplify local user checks 2022-04-13 20:38:39 +09:00
Dean Herbert
0a5a3415f8 Setup host switching and avoid starting gameplay 2022-04-13 20:28:53 +09:00
Dean Herbert
ca44d2c4dc Setup start/stop requests 2022-04-13 17:36:27 +09:00
Dean Herbert
1f01714ec2 Apply initial structural changes to TestSceneMatchStartControl 2022-04-13 17:36:27 +09:00
Dan Balasescu
3d27d3c536
Merge pull request #17786 from peppy/gameplay-leaderboard-update-totals-mode-change 
Fix multiple issues with gameplay leaderboard (and tests)
 2022-04-13 16:05:35 +09:00
Dan Balasescu
59ff9be316
Merge pull request #17788 from peppy/fix-replay-download-button-tests 
Fix multiple issues in `ReplayDownloadButton` test scene
 2022-04-13 16:00:45 +09:00
Dean Herbert
fbf0e5a45c Remove startFromSkipTarget parameter and update usages that required said behaviour 2022-04-13 14:25:43 +09:00
Dean Herbert
9c68b3edc5 Merge branch 'master' into fix-spectator-seeks 2022-04-13 12:33:41 +09:00
Dan Balasescu
abf7954a9c
Merge pull request #17792 from peppy/multi-match-footer-test-remove 
Fix `MultiplayerMatchFooter` test crash due to missing `PopoverContainer`
 2022-04-13 10:53:27 +09:00
Dan Balasescu
76517cecab
Merge pull request #17789 from peppy/rank-range-pill-test-refactor 
Refactor `TestSceneRankRangePill` to not depend on `TestMultiplayerClient`
 2022-04-13 10:46:00 +09:00
Dean Herbert
d73be7f177
Reword comment to read clearer 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2022-04-13 09:36:44 +09:00
Bartłomiej Dach
63e2a84d7f
Nest one more container to fix popover not being dismissable 2022-04-12 20:54:54 +02:00
Dean Herbert
ef7ab12b40 Fix MultiplayerMatchFooter test crash due to missing PopoverContainer 
Clicking the countdown button would crash. I did consider removing the
test altogether but maybe it'll be useful in the future?
 2022-04-12 23:01:39 +09:00
Dean Herbert
1ebbef88ec Refactor GameplayChatDisplay test scene to not require MultiplayerTestScene inheritance 2022-04-12 22:56:48 +09:00
Dean Herbert
20eca9bf6a Refactor TestSceneRankRangePill to not depend on TestMultiplayerClient 2022-04-12 19:39:24 +09:00
Dean Herbert
45d79c1a73 Ensure previous test score is cleaned up to allow visual test runs to work better 2022-04-12 18:21:40 +09:00
Dean Herbert
e901857610
Merge pull request #17776 from frenzibyte/dangerous-dialog-button-bounds 
Fix dialog dangerous button being clickable at edges
 2022-04-12 15:40:50 +09:00
Dean Herbert
8b1cee75fa Use BindableLong instead of BindableInt for user score tracking 2022-04-12 14:13:07 +09:00
Dean Herbert
22c75a518e Fix headers not getting reset on re-run of test 2022-04-12 12:38:15 +09:00
Dean Herbert
f29e329700 Move user count to a constant to allow easier adjustment 2022-04-12 12:11:51 +09:00
Dean Herbert
577e29351e Ensure players are always on both leaderboard teams 
In a very rare case, the randomisation may cause all users to be on one
team, causing a test failure. The odds make it basically impossible, but
if adjusting the number of users in the test scene this can more readily
be hit.
 2022-04-12 11:46:22 +09:00
Dan Balasescu
94e2a90af2
Merge pull request #17767 from peppy/multiplayer-gameplay-leaderboard-test-improvements 
Refactor multiplayer gameplay leaderboard tests to remove reliance on `Test` implementations
 2022-04-12 11:19:53 +09:00
Dean Herbert
a0e3a2102a Also expand match score component when leaderboard is (in test) 2022-04-12 10:49:57 +09:00
Salman Ahmed
74dfa79f17 Add failing test case 2022-04-11 21:04:55 +03:00
Dean Herbert
4ab6c11079 Add failing test coverage of skin import after exporting from lazer 2022-04-12 00:29:15 +09:00
Dean Herbert
01cec7d3fb Remove unnecessary string literals 2022-04-11 19:37:01 +09:00
Dean Herbert
09d560c93e Add test coverage of spectator requests 2022-04-11 19:27:14 +09:00
Dean Herbert
6a61fd95eb Tidy up base implementation 2022-04-11 19:19:45 +09:00
Dean Herbert
b52f070fdb Update existing multiplayer leaderboard tests to use new mocked implementation 2022-04-11 19:15:57 +09:00
Dean Herbert
0ccac24f76 Split out base implementation of MultiplayerGameplayLeaderboard test 2022-04-11 19:15:46 +09:00
Dan Balasescu
d1de516b11 Fix incorrect cursor parameterisation in test scene 2022-04-11 15:40:28 +09:00
Dean Herbert
779f7390b7 Add test coverage of DrawableRoom actually showing post-retrieval text 2022-04-11 13:44:34 +09:00
Salman Ahmed
34adc1d410 Add quick test coverage 2022-04-08 19:21:37 +03:00
Dan Balasescu
975bb8cc2a
Merge pull request #17703 from peppy/fix-storyboard-fallback-animation-frame-count-weirdness 
Fix `DrawableStoryboardAnimation` to handle skin fallback frame count similar to stable
 2022-04-08 17:01:17 +09:00
Bartłomiej Dach
112096768b
Add test checking incompatibility of multi mods 2022-04-07 22:38:46 +02:00
Bartłomiej Dach
8175741a6c
Merge branch 'master' into fix-storyboard-fallback-animation-frame-count-weirdness 2022-04-07 21:49:32 +02:00
Bartłomiej Dach
04db80848b
Remove unused using directives 2022-04-07 21:24:50 +02:00
Salman Ahmed
5b29ddd2ed Add further test coverage against paths with extensions 2022-04-07 15:05:08 +03:00
Dean Herbert
0674862b6c Fix failing tests 2022-04-07 17:52:08 +09:00
Dan Balasescu
f0698937b7
Merge pull request #17700 from peppy/fix-skin-lookups-extension-specified 
Fix filename lookups on `LegacySkin`s going awry when extension is specified
 2022-04-07 17:03:27 +09:00
Dean Herbert
b7f8716de9 Add test coverage of skin lookups failing when @2x and extension are present 2022-04-07 14:11:38 +09:00
Joseph Madamba
edb556643e Add failing replay button enabled test asserts 2022-04-06 20:43:56 -07:00
Dan Balasescu
c997d0fcf0
Merge pull request #17631 from bdach/mod-overlay/full-screen 
Implement basic layout & behaviour of new mod select screen
 2022-04-07 10:23:49 +09:00
Dean Herbert
065bb60324 Remove unused using statements 2022-04-06 16:05:11 +09:00
Dean Herbert
c2b2d443ed Add more comprehensive assert output to try and discern CI issues 2022-04-06 15:31:12 +09:00
Dean Herbert
d17890ca9a Replace a couple more local test beatmap cases which can instead use TestResources methods 2022-04-06 15:04:15 +09:00
Dean Herbert
220d7bc6db Fix dangerous realm operation in TestSceneMultiplayerMatchSongSelect 
The import process was running on the async load thread, but then
accessed from the access thread later on. This seemed to somehow pass
fine in headless runs, but would fail on visual test execution
(specifically on `TestBeatmapConfirmed()`).
 2022-04-06 14:01:41 +09:00
Dean Herbert
a3695c7e97
Merge branch 'master' into fix-spectator-seeks 2022-04-06 12:58:43 +09:00
Bartłomiej Dach
9c91e6d8f5
Merge branch 'master' into mod-overlay/full-screen 2022-04-05 21:29:40 +02:00
Dean Herbert
3ca365ad7f
Merge branch 'master' into dangerous-delete-actions 2022-04-05 10:55:01 +09:00
CenTdemeern1
b2c822a3b1 Release mouse button 2022-04-04 23:02:07 +02:00
CenTdemeern1
da315f8a61 Make the test hold the button instead of pressing it 2022-04-04 22:44:35 +02:00
Bartłomiej Dach
a1ded66fd8
Fix various breakage in delete local score test scene 2022-04-04 21:59:09 +02:00
Bartłomiej Dach
29b7460cc7
Fix weird test step 2022-04-04 20:05:54 +02:00
Dean Herbert
3ba81f3fdc Fix overlapping variable usage 2022-04-04 15:29:03 +09:00
Dean Herbert
f00dc5e156
Merge pull request #17598 from smoogipoo/playlist-quick-reorder 
Fix playlist refreshing all items on order change
 2022-04-04 14:48:05 +09:00
Bartłomiej Dach
90e44b67ea
Improve robustness of test code 2022-04-03 20:24:32 +02:00
Bartłomiej Dach
a172b194f0
Add testing for different rulesets 2022-04-03 20:12:34 +02:00
Bartłomiej Dach
2921a13609
Add testing for mod bindable state propagation 2022-04-03 20:12:34 +02:00
Bartłomiej Dach
e46c2df409
Add testing for customisation panel show/hide logic 2022-04-03 20:12:33 +02:00
Bartłomiej Dach
293ef44836
Implement new mod select screen 2022-04-03 20:12:33 +02:00
Dean Herbert
969f7e121a
Merge pull request #17545 from jai-x/new-chat-textbox 
Implement `ChatTextBox` for new chat design
 2022-04-03 22:12:12 +09:00
Bartłomiej Dach
6d1844adc3
Use nameof() in test to reference event names 2022-04-03 14:27:37 +02:00
Jai Sharma
94fa5e2ef2 Use Action<string> for event OnChatMessageCommitted & clear textbox internally 2022-04-02 21:58:54 +01:00
Bartłomiej Dach
28ba437d24
Merge branch 'master' into sucess-rate-tooltip 2022-04-02 19:31:45 +02:00
Salman Ahmed
b815f685fc Flip viaConfig conditional branch 2022-04-02 19:28:33 +03:00
Jai Sharma
9e152cd3fd Fix code quality issues 2022-04-02 17:27:44 +01:00
Salman Ahmed
8534dd3463
Simplify TestCase attributes to one Values attribute 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2022-04-02 19:24:16 +03:00
Jai Sharma
2297073b7e Use OnChatMessageCommit & OnSearchTermsChanged events in ChatTextBar 2022-04-02 17:15:19 +01:00
Salman Ahmed
c4635f3c03 Add failing test case 2022-04-02 18:36:32 +03:00
Salman Ahmed
a252c4cad5 Add random pass/play count data in test scene 2022-04-02 18:08:23 +03:00
CenTdemeern1
c103cee1d5 Need to commit the second half again because my Git UI messed up 2022-04-02 04:53:47 +02:00
CenTdemeern1
a1baced777 Change behavior of the display mode test 
I remembered to run InspectCode this time, all good
 2022-04-02 04:45:21 +02:00
CenTdemeern1
ee9696855b Remove hover test 2022-04-02 04:41:05 +02:00
CenTdemeern1
245e452d41 Remove redundant typecast I accidentally left in (Thanks InspectCode) 2022-04-02 04:31:43 +02:00
CenTdemeern1
95ccac50d4 Add display mode changing test 
Yup this is gonna fail horribly
 2022-04-02 04:26:16 +02:00
CenTdemeern1
9350f6f5f8 Add spaces around commas in Vector2 construction 2022-04-02 02:59:07 +02:00
CenTdemeern1
dc744f18ff Trim whitespace 2022-04-02 02:43:51 +02:00
CenTdemeern1
6685c97147 mainContainer -> toolbarClock 2022-04-02 02:43:44 +02:00
CenTdemeern1
b07152a119 Initial attempt at writing a test for the toolbarClock 
I'll add more once I know if this code passes review or not
 2022-04-02 02:35:37 +02:00
Dan Balasescu
6e6271d0c0 Fix "server-side" room playlist not updated 
Remove unused using
 2022-04-01 18:32:10 +09:00
Dan Balasescu
37dea0ff21 Add failing test case 2022-04-01 17:05:11 +09:00
Dean Herbert
058350dfd8 Fix failing test due to incorrect sizing specification 2022-04-01 10:53:16 +09:00
Bartłomiej Dach
1c7b259f8e
Merge branch 'master' into mod-overlay/sheared-toggle 2022-03-31 22:20:20 +02:00
Bartłomiej Dach
e180db145d
Add constructor argument to facilitate fixed width/autosizing 2022-03-31 22:19:08 +02:00
Bartłomiej Dach
b3896257ca
Move shear amount to constant 2022-03-31 22:09:03 +02:00
Dean Herbert
e8a295a61b Add test coverage of textbox focus in settings panels when switching between nested panels 2022-03-31 15:24:21 +09:00
Bartłomiej Dach
3ac0da2da3
Implement sheared toggle button 2022-03-30 22:50:21 +02:00
Bartłomiej Dach
f4184cb6fe
Fix typo in step name 2022-03-30 22:04:55 +02:00
Bartłomiej Dach
9621a7f9cb
Merge branch 'master' into fix-autoplay-mod-user-id 2022-03-30 21:41:45 +02:00
Dan Balasescu
cb1ee05539
Merge pull request #17555 from peppy/remove-source-from-wedge 
Remove song source from main wedge display
 2022-03-30 18:57:25 +09:00
Dean Herbert
bc0b982102 Remove song source from main wedge display 
This was definitely added at someone's request, since I wouldn't have
put it here. But it's displayed below in the details section already and
also not displayed in the updated "wedge" in the new design.

See https://github.com/ppy/osu/discussions/17537 for discussion.
 2022-03-30 17:59:40 +09:00
Dean Herbert
99f141d396
Merge pull request #17546 from frenzibyte/autoplay-cinema-incompatibility 
Mark both "Autoplay" and "Cinema" mods as mutually exclusive
 2022-03-30 16:41:07 +09:00
Dean Herbert
975883da5c Move all usages of client.realm filename to a single const 2022-03-30 13:34:48 +09:00
Dan Balasescu
c311e11496
Merge pull request #17527 from peppy/switch-osu-folder 
Add ability to "migrate" data to another folder which has an existing install
 2022-03-30 13:20:49 +09:00
Salman Ahmed
7495a04990 Ignore EF-to-realm migration tests on ARM architectures 2022-03-30 01:24:37 +03:00
Salman Ahmed
b7ae431252 Add test coverage 2022-03-30 01:08:22 +03:00
Jai Sharma
f049d7cb67 Implement ChatTextBox for new chat design 
Reference design: https://www.figma.com/file/f8b2dHp9LJCMOqYP4mdrPZ/Client%2FChat?node-id=1%3A297

Adds new component `ChatTextBox`.
Exposes `BindableBool` `ShowSearch` to change text input behaviour
between normal and search behaviour.

Adds new component `ChatTextBar`.
Exposes `BindableBool` `ShowSearch` which toggles between showing current
chat channel or search icon.
Additionally binds to child `ChatTextBox` components.
Requires a cached `Bindable<Channel>` instance to be managed by a parent
component.
 2022-03-29 22:33:38 +01:00
Dean Herbert
f762af1344 Add test coverage of migrating to folder with existing data 2022-03-29 23:28:07 +09:00
Dean Herbert
ea9495eb74 Update all existing calls to extension method with correct fallback handling 2022-03-29 16:51:30 +09:00
Dean Herbert
7059e4bf94 Add test coverage for autoplay avatar not being clickable 2022-03-28 23:37:39 +09:00
Dean Herbert
01980effe2
Merge pull request #17449 from smoogipoo/countdown-button-ux 
Improve multiplayer ready button/countdown button UX
 2022-03-27 13:42:10 +09:00
Bartłomiej Dach
b68c3265f6
Merge branch 'master' into clock 2022-03-26 20:55:08 +01:00
Bartłomiej Dach
69cc863611
Fix test failures in skin editor test scene 2022-03-26 19:28:07 +01:00
Dean Herbert
622458e857 Allow scaling display in the test scene 2022-03-26 18:56:28 +09:00
Dean Herbert
999ae88af2 Show game time display in clock 2022-03-26 18:13:20 +09:00