8929 Commits

Author	SHA1	Message	Date
Dean Herbert	c2706ca91b	Also show drain on argon health display test	2024-01-11 00:31:31 +09:00
Dean Herbert	49d13cda6b	Fix failing test by setting health on source of truth	2024-01-10 23:09:43 +09:00
Dean Herbert	f912a1ba31	Merge branch 'master' into health-less-value-changed	2024-01-10 18:03:34 +09:00
Nitrous	aa83ac1896	add test case	2024-01-10 15:53:54 +08:00
wooster0	d5fdd0c0f9	make each test bind the handler only once, depending on its need	2024-01-09 21:44:05 +09:00
wooster0	ea37c70e0b	apply suggestion	2024-01-09 21:34:40 +09:00
wooster0	8ad697ff4c	apply some suggestions/corrections	2024-01-09 21:28:46 +09:00
Dean Herbert	8324b75fa4	Merge pull request #26437 from bdach/song-select-logo-crash ... Fix crash when clicking osu! logo in song select immediately after exiting	2024-01-09 19:40:19 +09:00
Dean Herbert	f1b4c305b0	Change skinnable health test scene to drain	2024-01-09 17:09:19 +09:00
Dean Herbert	79ff767eba	Remove unused using	2024-01-09 14:51:30 +09:00
Dean Herbert	7d57a668ab	Use main page constant in more places	2024-01-09 13:12:54 +09:00
Joseph Madamba	b03813d3b4	Update casing of hardcoded "Main_page" string in tests	2024-01-08 14:37:50 -08:00
Bartłomiej Dach	8a87301c55	Add test for crashing scenario	2024-01-08 21:34:54 +01:00
Bartłomiej Dach	5337d999b5	Merge branch 'master' into disable-intro-track-pause	2024-01-08 12:54:37 +01:00
Bartłomiej Dach	b869be2f46	Fix typo	2024-01-08 12:52:23 +01:00
Bartłomiej Dach	50eba9ebdb	Reduce code duplication in test	2024-01-08 12:52:14 +01:00
Zachary	e2769dbda1	Attempt at creating a test.	2024-01-06 19:29:41 +10:00
Dean Herbert	fbc40ffc65	Merge pull request #26381 from Joehuu/flash-ongoing-operations-dialog ... Flash blocking ongoing operations dialog when trying to force quit	2024-01-05 18:34:06 +09:00
Joseph Madamba	b190333c17	Use repeat step for more delay between the two exits	2024-01-04 09:00:24 -08:00
Dean Herbert	35b9940c4e	Merge pull request #26140 from CaffeeLake/multiplier1x ... Fix mod score multiplier rounding to 1.00x with specific mod combinations	2024-01-04 19:26:49 +09:00
Dean Herbert	085f5acd1a	Fix another rider inspection (why do these keep coming up at random)	2024-01-04 19:26:28 +09:00
Dean Herbert	44d35020d1	Add test coverage of failed multiplayer score	2024-01-04 17:54:52 +09:00
Dean Herbert	b1813b17a2	Few new rider inspection	2024-01-04 16:39:50 +09:00
wooster0	92c4566287	Fix typo	2024-01-04 12:20:05 +09:00
CaffeeLake	c7b0a7ff69	Merge branch 'master' into multiplier1x	2024-01-04 05:04:23 +09:00
StanR	e240443c46	Update LocalUser statistics, add test	2024-01-03 18:15:32 +06:00
StanR	3df7430d2e	Bind UserRankPanel values to Statistics bindable in APIAccess	2024-01-03 14:32:32 +06:00
Bartłomiej Dach	e686a6a1dd	Fix player submission test intermittent failures due to audio playback discrepancy logic kicking in ... See https://github.com/ppy/osu/actions/runs/7384457927/job/20087439457#step:5:133.	2024-01-03 09:17:01 +01:00
StanR	c4be6fa974	Fix code quality, add new cards to the test scene	2024-01-03 00:37:24 +06:00
OliBomby	de14da95fa	Remove other grid types	2024-01-01 15:44:20 +01:00
OliBomby	9796fcff52	Merge position snap grid tests into single file	2024-01-01 15:24:54 +01:00
OliBomby	31d1799480	Create TestSceneCircularPositionSnapGrid.cs	2024-01-01 15:24:54 +01:00
OliBomby	8425c7226c	fix rectangular and triangular grid tests	2024-01-01 15:24:54 +01:00
OliBomby	f223487e1c	improve code	2024-01-01 15:13:10 +01:00
OliBomby	92c3b142a4	Added Triangular snap grid	2024-01-01 15:11:50 +01:00
OliBomby	f3b88c318b	Add rotation to snap grid visual	2024-01-01 15:11:49 +01:00
CaffeeLake	ca0f09733a	Remove unnecessary using directives ... Signed-off-by: CaffeeLake <PascalCoffeeLake@gmail.com>	2023-12-31 23:35:42 +09:00
Salman Ahmed	34acb435b8	Merge branch 'master' into multiplier1x	2023-12-31 16:48:00 +03:00
Salman Ahmed	4a94cfd35d	Fix failing test case	2023-12-31 16:47:12 +03:00
wooster0	0c85fd496f	Don't leave scores screen empty if no scores are present yet ... Addresses https://github.com/ppy/osu/discussions/23787 I originally wanted to set `allowShowingResults` to false if there are no results but because this involves an API request to fetch the scores that would mean all the scores would have to be fetched all at once so that it knows whether to hide or show the "View results" button on a beatmap. Because that would slow things down and be very inefficient, this still allows the user to view the scores screen but if there aren't any scores, it shows a text, which I think is at least for now better than nothing. As for the testing of this, I wasn't sure how to not generate scores only for one specific test so I opted into not using `SetUpSteps` and doing it that way.	2023-12-31 22:42:32 +09:00
Salman Ahmed	68dd103c89	Add failing test cases	2023-12-30 21:33:22 +03:00
Dean Herbert	2b81f4f557	Merge pull request #26221 from bdach/system-title-only-on-top-level-menu ... Do not display system title in inital menu state	2023-12-29 21:13:40 +09:00
Bartłomiej Dach	db78d73fa5	Do not display system title in inital menu state ... Addresses https://github.com/ppy/osu/discussions/26199.	2023-12-29 11:50:30 +01:00
Bartłomiej Dach	9bb0663b3b	Add test coverage of failure case	2023-12-29 10:36:53 +01:00
Bartłomiej Dach	68402bfd11	Add test coverage of failure scenario	2023-12-28 20:39:11 +01:00
Dean Herbert	8e3fe090f3	Merge pull request #26169 from bdach/universal-offset-from-session-plays ... Implement automatic suggestion of global audio offset based on last plays	2023-12-28 22:57:30 +09:00
Bartłomiej Dach	24a80da83f	Merge branch 'master' into universal-offset-from-session-plays	2023-12-28 14:07:46 +01:00
Bartłomiej Dach	bb0737837b	Fix test failing due to querying button position during transform	2023-12-28 13:58:00 +01:00
Dean Herbert	6bc0f02e2d	Fix test initialising dialogs without cleaning up	2023-12-28 20:40:51 +09:00
Dean Herbert	f8347288c1	Add padding around text in dialogs	2023-12-28 20:29:56 +09:00
Dean Herbert	28e220ca50	Update popup dialog design ... Had to be done. I hated the old ones so much. As usual, disclaimer that this is an iterative design and will probably be replaced in the future.	2023-12-28 19:04:35 +09:00
Dean Herbert	bd0e2b4dde	Remove disclaimer screen completely	2023-12-28 17:21:29 +09:00
Dean Herbert	1f2339244e	Add supporter display to main menu	2023-12-28 17:20:01 +09:00
Bartłomiej Dach	d9299a8a55	Implement visual appearance of "system title" message in main menu	2023-12-27 23:07:17 +01:00
Bartłomiej Dach	160342ceed	Implement automatic suggestion of audio offset based on last plays	2023-12-27 21:14:37 +01:00
Bartłomiej Dach	1b7af989ec	Migrate BeatmapOffsetControl to use session static directly	2023-12-27 19:19:27 +01:00
Bartłomiej Dach	53766285ce	Remove remaining hexacons usages	2023-12-27 17:42:18 +01:00
Dean Herbert	901674a130	Move back button inside sidebar to fix weird animation	2023-12-27 13:39:13 +09:00
Bartłomiej Dach	6f672b8cb3	Fix TestSceneKeyBindingPanel failures	2023-12-26 20:36:12 +01:00
Bartłomiej Dach	9ac79782d2	Add visibility toggle step to settings panel test scene	2023-12-26 20:21:15 +01:00
Dean Herbert	03e2463b06	Add test coverage and refactor to better handle equality edge case	2023-12-26 21:21:08 +09:00
Bartłomiej Dach	30b5b36f1d	Fix code quality inspection	2023-12-26 12:20:17 +01:00
Nathan Tran	4e3bdb2b56	Add test coverage	2023-12-26 00:57:06 -08:00
Bartłomiej Dach	32d8ee2d0c	Add test coverage	2023-12-23 13:42:19 +01:00
Dean Herbert	9f34dfa2ba	Add missing using statement	2023-12-23 16:25:52 +09:00
Simon G	01cf4ee15a	add test for length updates	2023-12-22 18:11:37 +01:00
Bartłomiej Dach	81bbdccee7	Rename ScoreInfo.{ -> Client}Version	2023-12-21 12:56:43 +01:00
Dean Herbert	a4baa0a716	Add versioning of local scores ... For any potential future usage	2023-12-21 18:37:15 +09:00
Dean Herbert	0648201844	Cancel test more	2023-12-21 18:17:03 +09:00
Dean Herbert	c5fb4d0f5c	Mark flaky test temporarily	2023-12-21 01:52:40 +09:00
Bartłomiej Dach	64b0534fb8	Merge pull request #25857 from peppy/fix-mod-settings-keyboard-adjust ... Fix mod search textbox having focus while settings are visible	2023-12-19 15:44:17 +01:00
Bartłomiej Dach	d793d1cea1	Add test coverage of desired input handling behaviour	2023-12-19 14:52:16 +01:00
Bartłomiej Dach	e306cc35ba	Merge branch 'master' into fix-song-select-realm-refresh-performance	2023-12-19 14:14:46 +01:00
Dean Herbert	8f5d21dc70	Actually fix realm selection retention regression	2023-12-19 18:10:55 +09:00
Bartłomiej Dach	bf668174ec	Use nunit constraints in test for transparency	2023-12-18 19:02:23 +01:00
Dean Herbert	41485c19cf	Add realm refresh steps in an attempt to stabilise failing test ... I think this is required because there is a higher chance of batched updates with the new structure (and less calls to `BeatmapSetsChanged` which causes re-selection).	2023-12-19 02:08:29 +09:00
Bartłomiej Dach	be16e0e538	Add failing test for adding collection w/ name colliding w/\ default items	2023-12-18 12:47:42 +01:00
Bartłomiej Dach	67a5e01c49	Update assertions in test	2023-12-14 15:19:29 +01:00
Dean Herbert	76653e61cb	Merge pull request #25575 from frenzibyte/collection-dropdown-improve-ux ... Improve handling of beatmap collection changes in `CollectionDropdown`	2023-12-14 18:39:36 +09:00
Bartłomiej Dach	839a080247	Add test coverage for desired mod overlay search box behaviour	2023-12-14 09:52:38 +01:00
Salman Ahmed	31c9489cb9	Fix failing tests	2023-12-13 23:38:19 +03:00
Dean Herbert	c6b1a5f1ee	Merge pull request #25691 from bdach/fix-skin-editor-crash-again ... Fix skin editor crashing in some circumstances when opened in main menu	2023-12-13 22:15:42 +09:00
Dan Balasescu	8c7570525a	Merge pull request #25744 from peppy/adjust-mod-multipliers ... Adjust some mod multipliers for initial leaderboard sanity	2023-12-13 17:56:13 +09:00
Bartłomiej Dach	e865de7a6b	Update test assertions in line with half time mod multiplier changes	2023-12-13 09:25:56 +01:00
Dean Herbert	fdcf87569c	Merge pull request #25711 from smoogipoo/mania-convert-song-select-keycount ... Display osu!mania keycount in song select carousel panels and details	2023-12-13 16:31:25 +09:00
Dean Herbert	eff81be6fd	Fix failing test and add coverage of conversion case	2023-12-13 16:01:52 +09:00
Dean Herbert	c2d3dcdd9c	Fix slider tests and incorrect nullability handling around freehandToolboxGroup	2023-12-13 15:15:49 +09:00
Dean Herbert	5e10f9f899	Fix failing tests due to more textboxes being present with searchable dropdowns	2023-12-13 15:11:47 +09:00
Dean Herbert	343ecc469f	Merge branch 'master' into dropdown-search	2023-12-13 13:58:23 +09:00
Dan Balasescu	8977e74171	Fix editor test not waiting for editor to load	2023-12-13 13:15:49 +09:00
Salman Ahmed	10e8edff67	Merge branch 'master' into dropdown-search	2023-12-12 21:14:01 +03:00
Dean Herbert	ea0ad2a0ef	Merge branch 'master' into online-presence	2023-12-07 17:42:46 +09:00
Dean Herbert	3c29e9162c	Merge pull request #25693 from bdach/online-presence-structure-serialisation ... Simplify user presence structures for serialisability	2023-12-07 17:39:21 +09:00
Dean Herbert	a500f55ec6	Merge pull request #25688 from peppy/match-default-sv ... Change default slider velocity for new beatmaps to match osu!stable	2023-12-07 11:52:16 +09:00
Bartłomiej Dach	86e003aec1	Update currently online display tests	2023-12-06 19:37:35 +01:00
Bartłomiej Dach	602550b9c2	Fix test failures	2023-12-06 19:37:28 +01:00
Bartłomiej Dach	d66fa09320	Simplify UserStatus to be an enumeration type ... There were absolutely no gains from having it be a reference type / class, only complications, especially when coming from the serialisation angle.	2023-12-06 18:52:27 +01:00
Bartłomiej Dach	faf60cec91	Extend test coverage of skin editor open to fail better	2023-12-06 10:11:41 +01:00
Bartłomiej Dach	4585a169b1	Merge pull request #25686 from peppy/fix-song-select-match ... Fix searching at song select matching incorrect ruleset	2023-12-06 09:25:47 +01:00
Dean Herbert	43dc908257	Fix test value getting clobbered due to stupid stuff ... Don't even ask. Just smile and nod.	2023-12-06 15:59:29 +09:00
Dean Herbert	79826dee58	Fix tests which were relying on SliderMultiplier==1	2023-12-06 13:50:10 +09:00
Dean Herbert	4da6d53c72	Merge pull request #25672 from frenzibyte/fix-argon-health-display-2 ... Fix `ArgonHealthDisplay` sometimes behaving weirdly on miss judgements (alternative)	2023-12-06 12:24:39 +09:00
Dean Herbert	8286d3896f	Fix searching at song select matching incorrect ruleset ... Regressed with https://github.com/ppy/osu/pull/25679.	2023-12-06 11:32:26 +09:00
Salman Ahmed	a67df76654	Add test coverage	2023-12-05 22:53:48 +03:00
Salman Ahmed	c55bfc03ee	Move private method	2023-12-05 22:06:53 +03:00
Salman Ahmed	20fd458fac	Perserve miss animation when followed by a hit at same frame	2023-12-05 21:59:28 +03:00
Salman Ahmed	986f4fa407	Add test scenarios for same-frame judgements	2023-12-05 21:59:28 +03:00
Dean Herbert	5a2240838b	Merge branch 'master' into multiplayer-abort	2023-12-05 17:01:54 +09:00
Salman Ahmed	17577a6606	Add visual test case for late miss in argon health display	2023-12-04 23:01:11 +03:00
Bartłomiej Dach	063694f544	Do not attempt to load gameplay scene if current beatmap is dummy	2023-12-04 14:42:51 +01:00
Bartłomiej Dach	43312619e3	Add test coverage for crashing on wrong ruleset	2023-12-04 14:42:51 +01:00
Bartłomiej Dach	7c041df0f1	Add test coverage for crashing on dummy beatmap	2023-12-04 14:42:42 +01:00
Bartłomiej Dach	d3e94cd5bf	Add test coverage for crashing on empty beatmap	2023-12-04 14:42:40 +01:00
Bartłomiej Dach	7deff70b4a	Extract beatmap import steps from gameplay scene switch helper	2023-12-04 13:34:36 +01:00
Dan Balasescu	8587652869	Fix countdown button being enabled	2023-12-04 11:00:11 +09:00
Dan Balasescu	9ccd33a1ec	Add comments to test	2023-12-04 10:20:53 +09:00
Dan Balasescu	c2644a5d5e	Correctly implement button enabled state	2023-12-04 10:18:37 +09:00
Bartłomiej Dach	30a4e77097	Merge branch 'master' into fix-overlapping-chat-links	2023-12-01 14:30:55 +01:00
Dan Balasescu	f3530a79b1	Add test	2023-12-01 21:34:20 +09:00
Bartłomiej Dach	d97ae8df6a	Remove commented out italic code ... It's a holdover from the Exo days (anyone remember those?) and hasn't been relevant for years, so why keep it.	2023-12-01 13:31:11 +01:00
Susko3	c395ae2460	Add failing tests ... They throws `ArgumentOutOfRangeException` on the first drawable Update()	2023-12-01 00:51:20 +01:00
Susko3	7f9ae55f5e	Add passing tests	2023-12-01 00:48:55 +01:00
Susko3	1a33bfbb3a	Enable NRT	2023-12-01 00:37:16 +01:00
Susko3	fba6349c65	Remove unused properties	2023-12-01 00:36:40 +01:00
Susko3	21fedff54f	Check number of links shown	2023-12-01 00:29:37 +01:00
Susko3	7b1ccb38cb	Remove redundant string interpolation	2023-11-30 23:35:10 +01:00
Susko3	0520ac265f	Move to TestCase-based test	2023-11-30 23:34:43 +01:00
Susko3	52ffbcc6db	Move special cases to TestCase'd test	2023-11-30 23:29:22 +01:00
Susko3	3ca3f25492	Extract local method	2023-11-30 23:26:52 +01:00
Susko3	9a32c0368e	Remove redundant linkAmount parameter	2023-11-30 14:38:58 +01:00
Susko3	831fe5b9f2	Use collection assert to ease debugging	2023-11-30 14:36:23 +01:00
Dan Balasescu	295a1b01d6	Adjust catch score grade cutoffs	2023-11-29 19:05:31 +09:00
Bartłomiej Dach	98ab9853ce	Merge branch 'master' into show-spectator-fail-2	2023-11-27 12:24:59 +09:00
Bartłomiej Dach	19639de299	Merge branch 'master' into fix-spectator-quit-2	2023-11-27 11:36:10 +09:00
Bartłomiej Dach	1388e492b1	Merge branch 'master' into chat-drag-improvements	2023-11-27 10:46:55 +09:00
Dean Herbert	9015615336	Update test to work with new drag bar location	2023-11-24 19:45:04 +09:00
Dan Balasescu	289cda71b2	Fix inspections	2023-11-24 15:06:51 +09:00
Dean Herbert	7ceb49fbc0	Add extra test coverage and handle case where still at loading screen	2023-11-24 15:05:39 +09:00
Dean Herbert	ef5dd24589	Update failing test coverage and fix onFail being called too often	2023-11-24 14:44:57 +09:00
Dean Herbert	51e2ce500d	Add test coverage of remote user failing immediately failing locally	2023-11-24 14:38:02 +09:00
Dean Herbert	73ad92189b	Add test coverage of remote player quitting immediately quitting locally	2023-11-24 14:26:09 +09:00
Dean Herbert	e06d79281d	Update tests to work with nested screen	2023-11-24 14:26:09 +09:00
Dean Herbert	dabbdf674b	Rename SoloSpectator to SoloSpectatorScreen	2023-11-24 14:26:08 +09:00
Dean Herbert	a02b6a5bcb	Update menu key shortcut test coverage	2023-11-24 13:18:17 +09:00
Dean Herbert	7e59a1d0be	Apply NRT to ButtonSystem	2023-11-24 13:18:17 +09:00
Dean Herbert	5905ca6492	Add second level menu for skin editors	2023-11-24 13:18:17 +09:00
Dean Herbert	340227a06d	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Dean Herbert	5d367c247c	Merge pull request #25547 from bdach/skin-editor-paste-catching-fire ... Fix skin editor crashing when pasting with nothing in clipboard	2023-11-23 16:15:11 +09:00
Bartłomiej Dach	4edaaa3083	Add test coverage of skin editor copy-paste	2023-11-23 09:55:16 +09:00
Dan Balasescu	30309cdf11	Merge pull request #25415 from Poyo-SSB-forks/unify-ur ... Change unstable rate calculation to account for rate-change mods	2023-11-23 09:53:28 +09:00
Dean Herbert	aa8dc6bd80	Attempt to fix intermittent failures on new tests ... See https://github.com/ppy/osu/pull/25418/checks?check_run_id=18886372597.	2023-11-22 21:46:35 +09:00
Dean Herbert	d86e743745	Merge branch 'master' into login-state-changes-user-profile-overlay	2023-11-22 12:13:49 +09:00
Dean Herbert	21bf288277	Merge pull request #25520 from peppy/context-menu-spacers ... Allow context menus to have visible spacers	2023-11-21 16:56:36 +09:00
Bartłomiej Dach	bf972a04ee	Merge pull request #25409 from Tom94/bspline-sliders ... Add free-hand drawing of sliders to the editor	2023-11-21 16:28:14 +09:00
Bartłomiej Dach	d83b2e24e7	Merge pull request #25371 from RatinFX/open-editor-timestamp ... Implement opening editor timestamp links	2023-11-21 15:48:36 +09:00
Dean Herbert	917a68eac3	Adjust localisablel strings and keys	2023-11-21 15:08:15 +09:00
Dean Herbert	3afaafb1d9	Reorder and simplify private helper methods	2023-11-21 15:05:51 +09:00
Dean Herbert	405ab499e9	Allow context menus to have visible spacers	2023-11-21 14:24:10 +09:00
Stedoss	826c82de47	Add unit test for handling login state in UserProfileOverlay	2023-11-21 01:56:37 +00:00
Bartłomiej Dach	c16afeb347	Fix tests	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	b6e3e42445	Merge branch 'master' into bspline-sliders	2023-11-20 12:03:29 +09:00
Dean Herbert	f7fa9c90d6	Add test coverage of 2FA flow	2023-11-16 18:18:40 +09:00
Dean Herbert	e9d4cf2e24	Setup basic form flow	2023-11-16 18:18:15 +09:00
Dean Herbert	87a76b9ee8	Merge pull request #25478 from Joehuu/fix-comment-markdown ... Fix `CommentMarkdownTextFlowContainer` not inheriting osu! class	2023-11-16 17:39:35 +09:00
Bartłomiej Dach	1e2f1b3ef2	Merge branch 'master' into unload-main-menu-storyboard	2023-11-16 15:46:44 +09:00
Joseph Madamba	dc2d574965	Fix comment markdown image not showing tooltips	2023-11-15 19:50:32 -08:00
Joseph Madamba	2b19cf6ce4	Fix comment markdown style regression	2023-11-15 19:50:32 -08:00
Dean Herbert	7f90db7603	Merge pull request #25472 from bdach/argon-health-folding-in-on-self ... Fix argon health bar folding in on itself when too narrow	2023-11-15 19:02:30 +09:00
Dean Herbert	189fca2eb6	Merge pull request #25339 from joshika39/change-clickable-avatars-tooltip-for-usergrid ... Add `UserGridPanel` as the `ClickableAvatar` tooltip	2023-11-15 18:01:24 +09:00
Bartłomiej Dach	71714f8f6e	Add back test step for testing out argon health bar width	2023-11-15 13:33:14 +09:00
cs	fa976a5aa0	Fix code style/quality issues	2023-11-13 08:25:27 +01:00
Poyo	8c36604e58	Add rate-change UR tests	2023-11-12 11:16:06 -08:00
Poyo	d123ba5bce	Fix broken tests	2023-11-12 11:13:38 -08:00
Dean Herbert	31feeb5ddc	Disable new rider EAP inspection in test class	2023-11-12 17:21:17 +09:00
Bartłomiej Dach	3e8c89e282	Fix one more reference to removed setting	2023-11-12 07:42:41 +09:00
cs	54b8244a18	CI Fixup	2023-11-11 15:02:06 +01:00
Thomas Müller-Höhne	926636cc03	Generalize Bezier curves to BSplines of Nth degree	2023-11-11 13:32:53 +01:00
Bartłomiej Dach	ea556abad8	Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters	2023-11-11 21:28:29 +09:00
Bartłomiej Dach	ee56b4d205	Use barely better assertion fail message in test	2023-11-11 20:56:05 +09:00
Bartłomiej Dach	b7972e3c84	Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters	2023-11-11 20:16:14 +09:00
Bartłomiej Dach	b247b94ecb	Revert test changes ... They were broken because `SerialisedDrawableInfo` is a reference type and as such equality checks will use reference equality rather than member equality.	2023-11-11 19:32:46 +09:00
Bartłomiej Dach	21e1d68b15	Remove unused using directive	2023-11-11 15:52:24 +09:00
Dean Herbert	2e48569982	Improve test comparison logic ... Doesn't really help that much with nunit output, but at least you can breakpoint and see the json kinda.	2023-11-10 20:00:51 +09:00
Bartłomiej Dach	b6dcd7d55f	Fix tests so that they actually assert something	2023-11-10 18:48:45 +09:00
Bartłomiej Dach	ec2200d54f	Remove another reference to bar length	2023-11-10 18:26:08 +09:00
Bartłomiej Dach	c522a703eb	Merge branch 'master' into skin-size-editing	2023-11-10 18:19:27 +09:00
Dean Herbert	35e11c7c63	Rename diagonal scale variable and update xmldoc	2023-11-10 17:55:02 +09:00
Bartłomiej Dach	d0f1326a63	Fix formatting	2023-11-10 17:54:48 +09:00
Bartłomiej Dach	8690b08769	Fix compose select box test failures	2023-11-10 16:08:45 +09:00
Dean Herbert	7fc2050f72	Rename variables and mak seconary tooltip type work again	2023-11-10 11:52:34 +09:00
Salman Ahmed	d3af3c615f	Merge branch 'master' into gameplay-hud-redesign/counters	2023-11-10 01:04:03 +03:00
Salman Ahmed	cc9aeb5307	Add test coverage	2023-11-09 22:57:20 +03:00
Salman Ahmed	d4722a3988	Add failing test case	2023-11-09 17:20:10 +03:00
Joshua Hegedus	4900a91c60	fixed static analysis problems and finished the implementation	2023-11-09 13:27:09 +01:00
Joshua Hegedus	ccb9ff826a	fixed tests	2023-11-09 13:09:59 +01:00
Dean Herbert	02966bc02f	Merge branch 'master' into change-clickable-avatars-tooltip-for-usergrid	2023-11-09 18:19:23 +09:00
Bartłomiej Dach	13b599b9b6	Merge branch 'master' into less-basic-touchscreen-detection	2023-11-09 17:36:48 +09:00
Dean Herbert	5ac285ed2f	Merge pull request #25380 from frenzibyte/fix-create-difficulty-crash ... Fix editor crash when creating a new difficulty in a non-existent beatmap	2023-11-08 18:56:00 +09:00
Dean Herbert	38847c3ac5	Change test to move only on a toggle step	2023-11-08 17:23:01 +09:00
Salman Ahmed	18c71c95cc	Merge branch 'master' into gameplay-hud-redesign/counters	2023-11-08 02:12:37 +03:00
ratinfx	81caa854e6	Separate Test cases by relevant rulesets	2023-11-07 13:02:46 +01:00
ratinfx	aa87e0a44d	HitObject Selection logic and separation for gamemodes ... + moved time_regex into EditorTimestampParser	2023-11-07 01:36:58 +01:00
ratinfx	8e8a88cfaf	Removed nullable line from Test	2023-11-07 00:54:15 +01:00
Salman Ahmed	38d16f620c	Alter test case to comply with new behaviour	2023-11-06 21:55:00 +03:00
Salman Ahmed	944fee56f8	Add failing test case	2023-11-06 21:54:40 +03:00
Andrei Zavatski	9d10d93085	Adjust test scene to see graph flickering	2023-11-06 20:45:52 +03:00
Joshua Hegedus	a01f6187f4	testing the tooltip	2023-11-06 14:52:06 +01:00
Joshua Hegedus	718492a0b7	fixed DRY	2023-11-06 11:29:15 +01:00
Joshua Hegedus	b45d8c785c	fixed review findings	2023-11-06 08:38:34 +01:00
Bartłomiej Dach	adb9ca5a13	Add failing test coverage for incorrect treatment of TD in mod presets	2023-11-06 07:56:09 +01:00
Salman Ahmed	634795e45f	Adjust failing test scenes	2023-11-05 02:50:14 +03:00
Salman Ahmed	1d4f4cf4c3	Merge branch 'master' into gameplay-hud-redesign/counters	2023-11-05 02:02:36 +03:00
Salman Ahmed	58a830fc5b	Revert "Add "Argon" performance points counter" ... This reverts commit 56eeb117ce.	2023-11-05 01:55:54 +03:00
ratinfx	7492d953ae	Moved error checks into Editor ... - Invoke Action on error to Notify user - added some comments	2023-11-04 21:17:58 +01:00
Joshua Hegedus	ec290ae953	added tests	2023-11-04 19:03:23 +01:00
ratinfx	19cdf99df8	Fixed up tests	2023-11-04 12:04:58 +01:00
ratinfx	f867cff8c7	Added OpenEditorTimestamp Tests	2023-11-04 03:42:08 +01:00
Joseph Madamba	3f8baf913b	Add 100 and 1000 key press step to test overflow	2023-11-02 20:49:01 -07:00
Joseph Madamba	e3b3ce6c84	Fix test overflowing on widescreen + add default (triangles) key counter testing	2023-11-02 20:42:28 -07:00
Joseph Madamba	090601b485	Apply peppy's upright key counter attempt diff ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-11-02 20:42:23 -07:00
Bartłomiej Dach	d25b54c06d	Split test into two ... They would fail on CI when written as one, and I don't care why.	2023-11-02 22:14:38 +01:00
Bartłomiej Dach	ef555ed0cf	Fix test failures	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	21a4da463b	Add failing test covering crash scenario	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	29d4d81eaa	Add test scene for basic touchscreen detection scenarios	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	2f6ff893b5	Automatically activate and deactivate touch device mod in song select	2023-11-02 19:45:48 +01:00
Bartłomiej Dach	980c900f43	Add component for game-wide touch detection	2023-11-02 19:32:56 +01:00
Dean Herbert	8c067dc584	Fix mod tests not waiting for presets to finish loading ... See https://github.com/ppy/osu/actions/runs/6692350567/job/18181352850.	2023-10-31 14:53:07 +09:00
Dean Herbert	7ceced7012	Scope TestPauseWithLargeOffset to focus on what matters ... See https://github.com/ppy/osu/actions/runs/6693917410/job/18186111009 This test is to make sure we don't seek before the original pause time, so I've exposed that value precisely to avoid CI woes.	2023-10-31 14:47:04 +09:00
Dean Herbert	d379e553da	Fix back-to-front logging	2023-10-31 14:31:26 +09:00
Dean Herbert	bdd3f2847b	Add an extra storyboard sample to avoid intermittent failures in TestStoryboardSamplesStopOnSkip ... Probably CI running slow timing balls. The point of failure is `waitUntilStoryboardSamplesPlay()` after already testing the important part of the test (that the samples stop on skip) so let's give it another possible point to recover. See https://github.com/ppy/osu/actions/runs/6698399814/job/18201753701.	2023-10-31 14:28:40 +09:00
Dean Herbert	66b84d02cb	Add note about TestGameplayExitFlow failure, and ignore for now ... See: https://github.com/ppy/osu/actions/runs/6695995685/job/18194110641 https://github.com/ppy/osu/actions/runs/6700910613/job/18208272419	2023-10-31 14:27:55 +09:00
Dean Herbert	89444d5544	Fix export test still occasionally failing due to file write in progress ... https://github.com/ppy/osu/actions/runs/6701591401/job/18209826074 Basically, `File.Move` may not be an atomic operation.	2023-10-31 14:00:49 +09:00
Dean Herbert	37ec10d4f5	Fix TestSongSelectScrollHandling not waiting for VolumeOverlay to load ... See https://github.com/ppy/osu/actions/runs/6701786492/job/18210372721.	2023-10-31 13:49:53 +09:00
Dean Herbert	fa220d34de	Merge pull request #25272 from frenzibyte/use-scale-adjust-for-player-max-dimensions-test-scene ... Fix `TestScenePlayerMaxDimensions` texture loading process bottlenecking CI	2023-10-31 13:36:30 +09:00
Dean Herbert	a3dc9a73b1	Revert behaviour changes of MaxDimensions test and ignore instead	2023-10-31 13:36:10 +09:00
Dean Herbert	3060cf1438	Merge pull request #25286 from frenzibyte/search-text-box-select-all ... Automatically select existing search text when opening settings	2023-10-31 12:14:00 +09:00
Bartłomiej Dach	06508d08fe	Delete outdated test	2023-10-30 20:22:41 +01:00
Bartłomiej Dach	b2d3aa982d	Merge branch 'master' into fix-click-through-timeline	2023-10-30 12:52:00 +01:00
Dean Herbert	8828562512	Merge pull request #25277 from Susko3/fix-cut-in-filter-textbox ... Fix cut and copy not working in song select search filter textbox	2023-10-30 18:18:46 +09:00
Dean Herbert	63e6eaf538	Fix failing tests	2023-10-30 18:06:11 +09:00
Dean Herbert	6be02966b9	Add test coverage of failing context menu display	2023-10-30 18:06:11 +09:00
Dean Herbert	caddbacfe8	Merge branch 'master' into gameplay-hud-redesign/counters	2023-10-30 16:35:10 +09:00
Salman Ahmed	c7bc8e6865	Move behaviour to settings search text box only	2023-10-30 06:41:01 +03:00
Salman Ahmed	af10dbb76c	Add test case with many tournament banners	2023-10-30 06:20:01 +03:00
Salman Ahmed	ec9ae12bbd	Update API response model to accept array of tournament banners	2023-10-29 01:43:49 +03:00
Salman Ahmed	31c6973bb6	Add test coverage	2023-10-29 01:03:45 +03:00
Susko3	cfc0520481	Add failing test	2023-10-28 12:13:13 +02:00
Salman Ahmed	a53c0adae0	Remove unused using directive	2023-10-28 06:56:12 +03:00
Salman Ahmed	51b7c97cab	Fix TestScenePlayerMaxDimensions bottlenecking CI	2023-10-28 06:07:49 +03:00
Dean Herbert	5a9d4170e8	Merge pull request #24794 from bdach/score-encoding-cleanup ... Correctly handle multiple online score ID types	2023-10-28 02:29:56 +09:00
Dean Herbert	4ed30342db	Merge pull request #25264 from bdach/quick-retry-f-rank ... Fix quick retry immediately after completion marking score as failed	2023-10-28 02:29:21 +09:00
Bartłomiej Dach	b5cb538004	Add failing test case for skin editor freeze	2023-10-27 14:23:41 +02:00
Bartłomiej Dach	6789a522d6	Rename test to distinguish it from test-to-come	2023-10-27 14:15:30 +02:00
Bartłomiej Dach	32fc19ea0d	Fix results screen test failure	2023-10-27 13:22:17 +02:00
Bartłomiej Dach	96d784e06b	Delete ScoreInfo.HasReplay as no longer needed	2023-10-27 12:39:54 +02:00
Bartłomiej Dach	3944b045ed	Add extra test coverage for marking score as failed	2023-10-27 12:17:03 +02:00
Bartłomiej Dach	7140eee870	Add failing test coverage for quick retry after completion not changing rank	2023-10-27 12:17:03 +02:00
Dean Herbert	a463c37320	Merge pull request #25243 from bdach/song-select-volume-scroll-blocked ... Fix left side of carousel blocking volume adjust hotkeys	2023-10-27 00:23:47 +09:00
Bartłomiej Dach	5d6a58d443	Add failing test scene for scroll handling in song select	2023-10-26 16:24:16 +02:00
Bartłomiej Dach	89fec95b01	Fix cross-test data dependency by recreating slider every time	2023-10-26 12:11:26 +02:00
Bartłomiej Dach	96437c4518	Fix tests specifying float precision for double bindable ... Would cause assignments to `.Value` to become imprecise even if the underlying bindable could represent the value 100% accurately.	2023-10-26 12:06:03 +02:00
Bartłomiej Dach	910d74fdda	Add failing test coverage for double-click on disabled sliders	2023-10-26 11:59:38 +02:00
Salman Ahmed	df80b4dcab	Update "Argon" health display specifications to match design ... Also adds a little white bar next to the display to match with the components below it (score/accuracy/combo counters).	2023-10-26 09:12:05 +03:00
Salman Ahmed	56eeb117ce	Add "Argon" performance points counter	2023-10-26 09:10:10 +03:00
Salman Ahmed	0aa0562dc0	Add "Argon" combo counter	2023-10-26 09:09:55 +03:00
Salman Ahmed	1f36acca1a	Add "Argon" accuracy counter	2023-10-26 09:09:52 +03:00
Salman Ahmed	9ca672d689	Add "Argon" total score counter	2023-10-26 08:58:25 +03:00
Dean Herbert	6934e045df	Fix editor not prompting before saving beatmap for export	2023-10-25 14:39:46 +09:00
Andrei Zavatski	1dbdbd6de6	Merge branch 'master' into comments-image-size	2023-10-23 13:22:31 +03:00
Bartłomiej Dach	dcfd6a0a8a	Remove DistancedHitObjectComposer inheritance from osu! composer	2023-10-19 11:46:30 +02:00
Joseph Madamba	1a3a81c33b	Add slider nub double click revert to default test	2023-10-17 21:41:03 -07:00
Dean Herbert	e081fa48a2	Fix various other inspections	2023-10-17 17:48:51 +09:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Bartłomiej Dach	9b474b656d	Fix key binding panel test failures from introducing placeholder text ... Whoops.	2023-10-13 15:03:41 +02:00
Dean Herbert	6358a5e210	Merge pull request #25105 from bdach/multiple-keys-one-binding ... Disallow binding multiple bindings in a single section to one key	2023-10-13 20:01:33 +09:00
Bartłomiej Dach	5f51b8a7c9	Merge pull request #25097 from peppy/results-screen-progress-fast ... Show results immediately if user hits "back" key after finishing gameplay	2023-10-13 11:54:34 +02:00
Dean Herbert	17b6ebbfbf	Avoid using a bindable in KeyBindingConflictPopover where data is never mutated	2023-10-13 18:40:21 +09:00
Bartłomiej Dach	d5557bbbfb	Merge pull request #25005 from minetoblend/multiplayer-invites ... Add ability to invite players to multiplayer rooms	2023-10-13 11:09:28 +02:00
Dean Herbert	37411f923e	Merge branch 'master' into multiple-keys-one-binding	2023-10-13 15:07:12 +09:00
Dean Herbert	aabed8b6e5	Merge pull request #25093 from Joehuu/mod-switch-tiny-extended-info ... Add extended info support to tiny mod switches	2023-10-13 13:40:24 +09:00
Bartłomiej Dach	f083309e64	Move type back next to exposing class	2023-10-12 20:26:01 +02:00
Bartłomiej Dach	5d637520e7	Add test coverage for key binding conflict resolution	2023-10-12 16:04:46 +02:00
Bartłomiej Dach	f5a6781e5a	Integrate key binding conflict popover into keybindings panel	2023-10-12 16:04:46 +02:00
Bartłomiej Dach	7b6563116a	Implement visual appearance of key binding conflict popover	2023-10-12 16:01:51 +02:00
Bartłomiej Dach	5f0b1d69a5	Prepare KeyBindingRow for accepting external changes	2023-10-12 16:00:20 +02:00
Dean Herbert	fa47309eef	Fix exit key during storyboard outro not progressing to results	2023-10-12 19:31:54 +09:00
Bartłomiej Dach	34bab38e80	Fix judgement counter test failure due to exploiting mania ruleset ... Large ticks are not a thing in mania anymore, so the judgement counter tests began to fail as `LargeTickHit` is no longer a valid hit result in that ruleset.	2023-10-12 11:34:59 +02:00
Dean Herbert	56e27f1c27	Merge branch 'master' into multiplayer-invites	2023-10-12 18:17:15 +09:00
Dean Herbert	e6103fea95	Fix async usage in TestSceneNotificationOverlay	2023-10-12 16:00:36 +09:00
Dean Herbert	3023e44196	Remove unused using statements	2023-10-12 15:52:48 +09:00
Dean Herbert	73b8146729	Update tests in line with new behaviour	2023-10-12 15:42:54 +09:00
Dean Herbert	256c95f045	Add (failing) test coverage of exit/retry during progress to results	2023-10-12 15:42:20 +09:00
Joseph Madamba	418549b48d	Modify some half time mods on test ... For use after support of extended info on `ModSwitchTiny`.	2023-10-11 13:00:39 -07:00
Joseph Madamba	764f641bc9	Add extended info support to tiny mod switches	2023-10-11 12:47:12 -07:00
Bartłomiej Dach	712564ea4f	Enable NRT in KeyBindingsSubsection	2023-10-11 20:03:31 +02:00
Joseph Madamba	6a9f17d97c	Merge remote-tracking branch 'upstream/master' into pr/22237	2023-10-11 09:53:26 -07:00
Joseph Madamba	e32be36d92	Move invalidation issue todo to tests	2023-10-10 22:29:43 -07:00
Joseph Madamba	ba62498478	Add set up steps to reinit drawables with a different relative width	2023-10-10 20:47:15 -07:00
Joseph Madamba	e049a072f8	Update right content to latest design ... - Add more scenarios to test - Future-proof mods display to not overflow	2023-10-10 20:24:25 -07:00
Joseph Madamba	bb3f426b93	Truncate name label and clean up positioning code ... Also adds a test score with a long username.	2023-10-10 18:26:00 -07:00
Joseph Madamba	43c8d51d02	Add draw width statistic to test	2023-10-10 16:47:33 -07:00
Joseph Madamba	39b008b070	Move test scores to a method and add TestResources.CreateTestScoreInfo()	2023-10-10 16:47:33 -07:00
Joseph Madamba	dad03778b7	Fix leaderboard score caching colour provider	2023-10-10 16:47:33 -07:00
Joseph Madamba	c0b8b3509f	Populate dates and add show animation on test	2023-10-10 16:47:33 -07:00
Dean Herbert	4319b22db8	Add failing test coverage of player not pausing track correctly	2023-10-10 17:55:35 +09:00
Bartłomiej Dach	ea400a9db7	Fix cross-test interference ... `TestLastPlayedUpdated` was implicitly relying on running first. `TestGuestScoreIsStoredAsGuest` showing up changed test ordering, causing the former test to fail if it didn't get to run first.	2023-10-10 09:30:51 +02:00
Bartłomiej Dach	08b1a3cbe2	Add failing test case for guest user being looked up in API	2023-10-10 09:18:57 +02:00
Dean Herbert	7c7771afca	Merge pull request #24986 from peppy/health-animates-in-intro ... Add initial animation for health bars	2023-10-07 10:31:34 +09:00
Bartłomiej Dach	a099cc0f36	Merge pull request #25030 from peppy/adjustable-health-bar ... Adjust argon health bar to fit with existing layout	2023-10-06 21:51:18 +02:00
Dean Herbert	1a60e6d76e	Merge branch 'master' into health-animates-in-intro	2023-10-07 00:32:19 +09:00
Dean Herbert	71be3c8f8b	Add ability to adjust health bar settings in test scene	2023-10-06 19:34:27 +09:00
Dean Herbert	db5178e453	Change ArgonHealthDisplay to be relative sized for now	2023-10-06 18:56:39 +09:00
Dean Herbert	1005b7ac85	Fix incorrect test assumption in TestSceneEditorClock ... I don't know what this test was trying to do, but it was wrong. Any offset which is applied should be invisible to the clock's final `CurrentTime` (and to the user).	2023-10-06 16:43:28 +09:00
Dean Herbert	354193c53a	Merge branch 'master' into clock-fix-attempt-2	2023-10-06 16:43:27 +09:00
Bartłomiej Dach	c195fbe76f	Merge branch 'master' into crop-gameplay-textures	2023-10-05 09:35:58 +02:00
Dean Herbert	5a0faaa0b1	Fix TestReplayExport intermittent failure ... The previous fix was not working as it was checking the path for the prefix `_`, not the filename. See https://github.com/ppy/osu/runs/17415814653#r0s2 which clearly shows this.	2023-10-05 14:30:06 +09:00
Bartłomiej Dach	bd71403309	Merge branch 'master' into health-animates-in-intro	2023-10-04 13:53:42 +02:00
Dean Herbert	5a17a86d1d	Merge branch 'master' into clock-fix-attempt-2	2023-10-04 16:57:49 +09:00
Marvin Schürz	5678d90461	Reduce silliness of notification test case	2023-10-04 00:20:38 +02:00
Bartłomiej Dach	844a3b6c1b	Merge pull request #24980 from frenzibyte/gameplay-hud-redesign/health-display ... Implement redesigned health bar display for "Argon" skin	2023-10-03 11:26:21 +02:00
Dean Herbert	e1445fcc65	Adjust health display test scene's background colour to better visualise background fill	2023-10-03 17:17:42 +09:00
Marvin Schürz	e81695bcac	Display avatar in invitation notification	2023-10-02 23:10:51 +02:00
Dean Herbert	622cbc3af7	Adjust test scene to actually make HP bars fit	2023-10-02 16:07:45 +09:00
Salman Ahmed	9e2b8254d9	Add argon-specific health display test scene	2023-10-01 13:26:47 +03:00
Salman Ahmed	776536e816	Add "Argon" health display implementation	2023-10-01 00:56:16 +03:00
Salman Ahmed	869f8e5e1b	Adjust test scene to apply miss judgements as well	2023-10-01 00:21:24 +03:00
Salman Ahmed	314ecec65b	Refactor player max dimensions test scene to actually upscale textures	2023-09-30 01:34:49 +03:00
Bartłomiej Dach	7638ea36a0	Merge branch 'master' into mod-icon-extended	2023-09-28 16:57:17 +02:00
Dean Herbert	b8953e8ce1	Code quality pass	2023-09-28 19:03:34 +09:00
Bartłomiej Dach	afa1815d13	Merge pull request #24929 from peppy/reduce-song-select-debounce ... Reduce delay before loading beatmap after selection change at song select	2023-09-28 10:45:43 +02:00
Dean Herbert	4d5b2477dc	Fix failing song select tack transfer test by using a real track	2023-09-28 15:59:06 +09:00
Dean Herbert	16e752e07d	Add basic structure and test coverage for extended info on mod icon	2023-09-27 19:29:03 +09:00
Dean Herbert	a7237e48aa	Merge branch 'master' into fix-storyboard-skin-textures-lookup	2023-09-27 17:17:51 +09:00
Bartłomiej Dach	12585c9f27	Fix flaky editor beatmap creation test ... Came up as a failure when locally running tests for ppy/osu-framework#6001 - but the test is actually a previously-known flaky that I couldn't reproduce the failure of until the aforementioned PR. This appears to be a simple race; the test scene queries the track length from update thread, but the length is actually set on the audio thread. So it's not unreasonable that given unlucky timing, the length will not be set by `TrackBass` before it is queried. To fix, switch assert to until step. I'm generally not really willing to give this more time of day until this change is proven insufficient.	2023-09-26 16:42:59 +02:00
Dean Herbert	40a548d372	Adjust new test scene to not be super broken	2023-09-26 17:30:49 +09:00
Dean Herbert	990c54519b	Merge branch 'master' into limit-gameplay-sprite-dimensions	2023-09-26 16:40:32 +09:00
Dean Herbert	b1561b650f	Rename test scene, add xmldoc and increase scale factor to something absurdly high	2023-09-26 16:39:36 +09:00
Dean Herbert	2ca1c684bb	Merge branch 'master' into fix-storyboard-skin-textures-lookup	2023-09-26 14:05:27 +09:00
Andrei Zavatski	292273edbe	Add test scene	2023-09-23 06:31:26 +03:00
Joseph Madamba	f7f390195a	Add user covers to centre content	2023-09-22 19:59:40 -07:00
Joseph Madamba	228731493e	Add relative width slider to test	2023-09-22 19:59:40 -07:00
Dean Herbert	c40bd74138	Update usages of GameplayClockContainer not using an adjustable source	2023-09-22 16:22:36 +09:00
Dean Herbert	8367bb6bee	Don't apply decoupling to SpectatorPlayerClocks ... See inline comment for reasoning. It's a bit complicated.	2023-09-22 16:22:35 +09:00
Joseph Madamba	70b16d7246	Merge remote-tracking branch 'upstream/master' into pr/22237	2023-09-21 22:51:23 -07:00
Dean Herbert	3f27be1f33	Replace most usages of DecoupleableInterpolatingFramedClock ... Except `FramedBeatmapClock`, which is the high-effort one.	2023-09-22 12:49:25 +09:00
Bartłomiej Dach	e45d456324	Fix TestFriendScore intermittently failing due to randomness ... If `createRandomScore()` happened to randomly pick the highest total score when called with `friend` as the sole argument, that particular score would not be pink. `GetScoreByUsername()` would arbitrarily pick the first score for the user, so in this particular case where a friend had the number 1 score, the test would wrongly fail. Fix by checking whether any of the 3 added friend scores have received the pink colour. Because there is more than 1 friend score in the test, doing so ensures that at least one of those should eventually become pink (because, obviously, you can't have two scores at number 1).	2023-09-21 21:12:44 +02:00
Bartłomiej Dach	9301a1907a	Rewrite TestFriendScore assertions to constraint model ... Allows to clearly see what the failure is: TearDown : System.TimeoutException : "friend score is pink" timed out: Expected: some item equal to "#FF549A" But was: < "#FFFFFF", "#7FCC33", "#444444" > The #7FCC33 colour is used for the first score on the leaderboard.	2023-09-21 21:05:41 +02:00
Bartłomiej Dach	d73f06fc89	Add test coverage for delete hotkey	2023-09-21 20:01:59 +02:00
Bartłomiej Dach	69ed99dfd5	Merge branch 'master' into mania-edit-disable-sv	2023-09-21 09:13:27 +02:00
Bartłomiej Dach	d7129da8ea	Fix TestSceneDrawableStoryboardSprite not displaying anything	2023-09-20 12:05:23 +02:00
Dean Herbert	c5397bdbb3	Merge branch 'master' into mania-edit-disable-sv	2023-09-20 14:23:07 +09:00
Dean Herbert	1927b524db	Merge branch 'master' into leaderboard-friend-highlight	2023-09-20 14:14:08 +09:00
Dean Herbert	1316403180	Fix inspection in new test scene	2023-09-20 13:02:40 +09:00
Dean Herbert	2f020f8682	Add test coverage of storyboard preferring skin when specified	2023-09-19 20:20:20 +09:00
Dean Herbert	067c487b21	Merge pull request #24450 from cdwcgt/missing-beatmap ... Fetch missing beatmap when importing replay	2023-09-19 18:40:02 +09:00
Dean Herbert	f726c38215	Pass ArchiveReader instead of Stream to simplify resolution code	2023-09-19 17:49:15 +09:00
Salman Ahmed	8e992de763	Fix crash when loading player instance without exiting previous instance	2023-09-19 05:09:01 +03:00
Salman Ahmed	a373d71b3e	Add basic test scene upscaling all skin elements	2023-09-19 03:40:31 +03:00
Salman Ahmed	57dc76b345	Revert "Update GetTexture signature rather than creating new overload" ... This reverts commit 96f12cfbaa.	2023-09-19 03:21:19 +03:00
Bartłomiej Dach	775f96f061	Add very basic visual tests for missing beatmap notification ... The full-stack test using the whole 9 `OsuGameTest` yards is unusable for rapid development. I don't really get how you could ever design anything using it without tossing your computer out the window.	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	06d1a2a316	Merge branch 'beatmap-card-nano' into missing-beatmap	2023-09-18 14:56:06 +02:00
Dean Herbert	f3b6aa5435	Merge pull request #24821 from bdach/scoring-test-scene-osu ... Refactor scoring test scene for ruleset extensibility (and move existing instance to osu! ruleset project)	2023-09-18 19:54:14 +09:00
Bartłomiej Dach	5c2413c06b	Implement nano beatmap card	2023-09-18 11:30:14 +02:00
Bartłomiej Dach	3709861132	Merge pull request #24814 from LukynkaCZE/parse-only-supported-char-uris ... Parse only supported schemes as URIs	2023-09-18 10:20:09 +02:00
Bartłomiej Dach	45751dd1f2	Minimum viable changes for ruleset-specific scoring test scenes	2023-09-15 12:58:29 +02:00
Lukynka CZE	2a18f76b02	add visual test	2023-09-14 17:48:10 +02:00
Dean Herbert	32946413de	Change display text from "difficulty" to "score" multiplier	2023-09-13 20:01:19 +09:00
Dean Herbert	35840bf671	Combine ModCounterDisplay and DifficultyMultiplierDisplay into one class	2023-09-13 18:51:56 +09:00
Bartłomiej Dach	7c65a9de75	Fix Score V1 simulation in scoring test scene incorrectly applying multiplier ... `TestSceneScoring` included a local simulation of stable's Score V1 algorithm. One of the parts of said algorithm is a mysterious "score multiplier", influenced by - among others - the beatmap's drain rate, overall difficulty, circle size, object count, drain length, and active mods. (An implementation of this already exists in lazer source, in `OsuLegacyScoreSimulator`, but more on this later.) However, `TestSceneScoring` had this multiplier in _two_ places, with _two_ distinct values, one of which being 1 (i.e. basically off). Unfortunately, the place that had 1 as the multiplier was the wrong one. Stable calculates the score increase for every hit in two stages; first, it takes the raw numerical value of the judgement, but then applies a combo-based bonus on top of it: scoreIncrease += (int)(Math.Max(0, ComboCounter.HitCombo - 1) * (scoreIncrease / 25 * ScoreMultiplier)); On the face of it, it may appear that the `ScoreMultiplier` factor can be factored out and applied at the end only when returning total score. However, once the above formula is rewritten as: scoreIncrease = scoreIncrease + (int)(Math.Max(0, ComboCounter.HitCombo - 1) * (scoreIncrease / 25 * ScoreMultiplier)); = scoreIncrease * (1 + (Math.Max(0, ComboCounter.HitCombo - 1) / 25 * ScoreMultiplier)) it becomes clear that that assumption is actually _incorrect_, and the `ScoreMultiplier` _must_ be applied to every score increase individually. The above was cross-checked experimentally against stable source on an example test map with 100 objects, and a replay hitting them perfectly.	2023-09-12 21:33:26 +02:00
Bartłomiej Dach	3981e2e957	Only show visible graph values in tooltip	2023-09-12 13:29:02 +02:00
Bartłomiej Dach	15708ee465	Add toggle for showing relative/absolute score values	2023-09-12 13:27:40 +02:00
Bartłomiej Dach	607ceeccb9	Persist visibility state of graphs	2023-09-12 12:19:50 +02:00
Bartłomiej Dach	3cf8082aa7	Add capability to toggle visibility of graph	2023-09-12 12:07:12 +02:00
Bartłomiej Dach	95d15a703e	Improve legibility of scoring test scene ... - Add black background to avoid clashes with background images. - Use sorta-tetradic colours for the four plots.	2023-09-12 11:36:41 +02:00
Dean Herbert	0d7157f727	Merge branch 'master' into map_info_on_mod_settings	2023-09-12 17:16:47 +09:00
Dean Herbert	7e3652284d	Adjust various class naming and add some xmldoc	2023-09-12 17:15:16 +09:00
Dean Herbert	b4bedee49e	Adjust naming of component to give more context	2023-09-12 15:43:59 +09:00
tsrk.	dbc07bc6dc	fix: provide OverlayColourProvider as a dep in tests	2023-09-12 01:34:17 +02:00
Bartłomiej Dach	824416067e	Fix test failure	2023-09-11 20:53:17 +02:00
tsrk.	8c137353b6	feat: integrate previous usernames tooltip to profile overlay	2023-09-11 15:02:19 +02:00
Bartłomiej Dach	f9d4fbee56	Add collapsed state to effect preview panel	2023-09-11 10:16:24 +02:00
Bartłomiej Dach	589f56d20c	Merge branch 'master' into map_info_on_mod_settings	2023-09-11 09:55:54 +02:00
Bartłomiej Dach	53c30dca64	Fix data flow being sometimes incorrect	2023-09-11 09:53:58 +02:00
Bartłomiej Dach	a631fae6df	Add actual testing	2023-09-11 09:19:37 +02:00
Dean Herbert	87ec33bb66	Tidy up test	2023-09-07 14:50:22 +09:00
Joseph Madamba	5ee412cc9a	Use @2x variant of profile badges	2023-09-06 16:17:53 -07:00
cdwcgt	68752f95e5	color friend score to pink	2023-09-06 22:58:03 +09:00
Dean Herbert	1a37543d28	Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity	2023-09-06 19:01:08 +09:00
Bartłomiej Dach	eddb879973	Merge pull request #24722 from peppy/beatmap-status-pill-animation ... Add animation support for beatmap status pills	2023-09-06 09:59:21 +02:00
Bartłomiej Dach	b5e812eb3e	Merge pull request #24723 from bdach/beatmap-carousel-split-missing-status ... Fix status on carousel beatmap set not showing in split difficulty mode	2023-09-06 09:35:38 +02:00
Bartłomiej Dach	b884f1af4a	Assign random statuses to beatmap sets in carousel test ... Just to have visual coverage of the statuses before fixing them not propagating to split difficulty mode.	2023-09-06 08:25:07 +02:00
Dean Herbert	dded7fe6ca	Merge branch 'master' into beatmap-options-popover	2023-09-06 15:16:34 +09:00
Dean Herbert	034c887dcb	Add animation support for beatmap status pills ... To be used in conjunction with https://github.com/ppy/osu/pull/22116	2023-09-06 15:04:25 +09:00
Joseph Madamba	3f92dae55c	Move star rating display and status pill out of reloadable content	2023-09-05 15:20:20 -07:00
Joseph Madamba	676240928e	Move actual star updating to star rating display	2023-09-05 14:57:55 -07:00
Dean Herbert	96f12cfbaa	Update GetTexture signature rather than creating new overload	2023-09-05 18:01:19 +09:00
Dean Herbert	02fefff5e7	Add better testing of options popover	2023-09-05 16:44:46 +09:00
Dean Herbert	340edf68d3	Fix test scene not updating all star counters	2023-09-05 15:59:00 +09:00
Joseph Madamba	9451613391	Rename null beatmap test to indicate there's a background	2023-09-04 21:39:41 -07:00
Joseph Madamba	854bb323cc	Remove weird red edge effect visibility	2023-09-04 21:21:55 -07:00