1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 02:37:25 +08:00
Commit Graph

1101 Commits

Author SHA1 Message Date
Dean Herbert
9dc035757f Fix weird textbox behaviour when entering a random mod seed overflowing int backing 2021-10-08 14:01:36 +09:00
Dean Herbert
2856aef4eb Add exception to catch any incorrect defaults of Bindable<string> 2021-10-08 13:52:38 +09:00
Susko3
3e403cfe03 Add comment explaining the purpose of the empty FilterTerms 2021-10-02 19:16:46 +02:00
Susko3
d55836c0b2 Make ResetButton no longer part of search filtering
The button will now appear if and only if all the bindings in its section are visible (not filtered out by the search)
2021-10-02 15:10:30 +02:00
Dean Herbert
9fa901f6aa Refine RealmContext implementation API 2021-09-30 23:56:38 +09:00
Dean Herbert
50f155e4b9 Move login panel related files to own namespace and tidy up class nesting 2021-09-17 18:34:16 +09:00
Dean Herbert
df786afb24
Merge pull request #14763 from kj415j45/localisation-settings-GlobalAction
Add localisation for Settings-KeyBindings-GlobalActions
2021-09-16 21:08:00 +09:00
kj415j45
51997fa533
Add localisation for GlobalActions 2021-09-16 16:02:04 +08:00
AbstractQbit
f0439ef50b Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect 2021-09-15 13:12:57 +03:00
AbstractQbit
b9193aae6d Make IOsuScreen.AllowTrackAdjustments nullable
Allows for inheriting value from the previous screen if undefined
2021-09-14 17:37:57 +03:00
Dean Herbert
1e09f558d1
Merge pull request #14687 from Emil8250/master
Make "Reset bindings" button wider to accommodate to localisations better
2021-09-13 22:46:06 +09:00
Dean Herbert
caf7ef6519 Add missing screen level mod application settings for some screens
Closes #7480. But based on discussion in there this solution may change.
2021-09-13 15:00:34 +09:00
Dean Herbert
52c69d2f22 Adjust value to not be full width (but allow for more accommodations with localised versions) 2021-09-13 14:17:45 +09:00
Emil Olesen
2888623bdb Extended the width of the ResetSectionButton to be equal to Content.Width. Fixes #14685 2021-09-08 22:02:24 +02:00
Dean Herbert
458cde832d Avoid using SSDQ for validity computation 2021-09-06 14:11:13 +09:00
Dean Herbert
4fb3a1d641 Update check to inflate in the correct direct
Also handles previously unhandled edge cases by comparing all four
corners, instead of only two.
2021-09-05 00:46:29 +09:00
Dean Herbert
66daa553de Fix bounds check running too early causing tablet area to show incorrect validity 2021-09-04 19:34:55 +09:00
Dean Herbert
16beb2c90c Expose more pieces of TabletSettings 2021-09-04 15:35:46 +09:00
Dean Herbert
ae47c5cdb3 Fix bottom area of a settings section not being clickable 2021-08-21 15:08:42 +09:00
Dan Balasescu
0a6b678059
Merge branch 'master' into settings-dim-other-sections 2021-08-20 20:22:22 +09:00
Dean Herbert
139ff2d6e2 Only fade header in when hovering a section
Feels less like the controls are interactive when hovering this way.
2021-08-20 17:40:05 +09:00
Dean Herbert
cff7b1e98f Ensure the correct fade level is applied over all state changes 2021-08-20 17:00:08 +09:00
Bartłomiej Dach
143b8df1b2
Fix backwards warning text presence check 2021-08-19 22:40:35 +02:00
Dean Herbert
6637c64501 Dim all but the current section 2021-08-19 01:27:14 +09:00
Dean Herbert
c0b388cd74 Fix regression in ModSettingsChangeTracker 2021-08-17 17:50:30 +09:00
Dean Herbert
1b49e92e99 Merge branch 'master' into settings-delayed-load 2021-08-17 17:42:23 +09:00
Dean Herbert
212842c537 Fix initial LayoutSettings animation in a more reliable way 2021-08-17 12:38:44 +09:00
Dean Herbert
139e69ed3b
Merge pull request #14343 from frenzibyte/hide-tablet-not-detected-when-disabled
Hide tablet settings content when disabled
2021-08-16 23:31:16 +09:00
Dean Herbert
5f006bd6e8
Merge pull request #14247 from kj415j45/localisation-settings
Add localisation support for most of Settings
2021-08-16 22:20:35 +09:00
Dean Herbert
7e1086d901 Merge branch 'master' into hide-tablet-not-detected-when-disabled 2021-08-16 22:07:45 +09:00
Dean Herbert
568d027013 Simplify weird conditionals 2021-08-16 22:07:41 +09:00
Dean Herbert
8c3eb91059
Merge branch 'master' into localisation-settings 2021-08-16 20:03:06 +09:00
Dean Herbert
e485728109 Add keywords to make finding audio offset adjustments easier in settings 2021-08-16 19:54:45 +09:00
Dean Herbert
230c4eb247 Fade in sidebar buttons after the load has completed 2021-08-16 19:47:41 +09:00
Dean Herbert
b541550ea9 Avoid initial synchronous dropdown population overhead in AudioDevicesSettings 2021-08-16 19:47:41 +09:00
Dean Herbert
8d051d9fa0 Avoid multiple synchronous overheads in SettingsItem 2021-08-16 19:47:41 +09:00
Dean Herbert
c0130da235 Avoid running initial layout transform in LayoutSettings 2021-08-16 19:47:41 +09:00
Salman Ahmed
e39a295c5c Hide tablet settings content when input handler is disabled 2021-08-16 13:45:50 +03:00
Dean Herbert
fc89f2bac4 Revert "Rename element in OsuSettings enum"
This reverts commit c2bbe17562.
2021-08-16 16:56:48 +09:00
kj415j45
887d622c28
Merge branch 'master' into localisation-settings 2021-08-16 15:41:50 +08:00
Dan Balasescu
4d31d07c51
Merge branch 'master' into open-tablet-driver-faq 2021-08-16 13:46:43 +09:00
Salman Ahmed
c8fb796660 Fix settings notice text class tinting everything with yellow 2021-08-14 20:14:28 +03:00
kj415j45
c2bbe17562
Rename element in OsuSettings enum
`ShowProgressGraph` -> `ShowDifficultyGraph`
2021-08-14 22:35:15 +08:00
kj415j45
f87f86e671
Apply suggestions from code review
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-08-14 22:24:57 +08:00
kj415j45
e26ccf786e
code style format 2021-08-14 11:04:38 +08:00
kj415j45
5cfb89f18a
Apply suggestions from code review
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2021-08-14 10:56:52 +08:00
kj415j45
d527eb3d8b
Apply suggestions from code review
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-08-13 17:15:18 +08:00
Salman Ahmed
f43ab323ff Add shared class for notice text in settings 2021-08-13 11:12:44 +03:00
Salman Ahmed
cd842ccef8
Improve message
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-08-13 10:15:50 +03:00
Salman Ahmed
543f6039e2 Display on Windows and Linux only 2021-08-13 09:26:53 +03:00
Salman Ahmed
c5ee8753b4 Notify users to read OpenTabletDriver's FAQ when tablet not detected 2021-08-13 09:20:52 +03:00
kj415j45
ac52b89148
Add Maintenance and Debug SettingsStrings 2021-08-12 12:34:10 +08:00
kj415j45
9d391ad138
Add OnlineSettingsStrings 2021-08-12 12:34:09 +08:00
kj415j45
61502e977a
Add SkinSettingsStrings 2021-08-12 12:34:08 +08:00
kj415j45
31ffaf15d4
Add GameplaySettingsStrings 2021-08-12 12:34:07 +08:00
kj415j45
7adf2bb64c
Add UserInterfaceStrings 2021-08-12 12:34:06 +08:00
kj415j45
03013d0d30
Add InputSettingsStrings
Existed strings files keep no change
2021-08-12 12:34:06 +08:00
kj415j45
b2986e99d3
Add AudioSettingsStrings 2021-08-12 12:34:04 +08:00
kj415j45
078953980e
Add GraphicsSettingsStrings 2021-08-12 12:34:03 +08:00
kj415j45
9a5d4ffd43
Add GeneralSettingsStrings 2021-08-12 12:34:02 +08:00
kj415j45
97041de09f
Preparation for localisation. 2021-08-12 12:34:02 +08:00
Jamie Taylor
9b7bb37244
Add hover+select sounds to some components that are missing them 2021-07-30 21:35:28 +09:00
Dean Herbert
c8944b62ec Update incorrect linked comment 2021-07-26 17:28:58 +09:00
Dean Herbert
075507648a Show warning for linux as well 2021-07-26 17:28:58 +09:00
Dean Herbert
b70bd7689e Add warning about using high precision mouse on macOS 2021-07-26 17:00:06 +09:00
Dean Herbert
af9f910a12 Change WarningText to accept LocalisableString
Can't work just yet, but best to have the flow in place to maintain 100%
localisation on classes which were already localised.
2021-07-26 16:59:29 +09:00
Joseph Madamba
dce47917fd Fix ruleset icons overflowing from settings footer 2021-07-23 19:07:54 -07:00
Bartłomiej Dach
b1087d14f3
Merge branch 'master' into skin-editor-button-access 2021-07-22 22:49:44 +02:00
Bartłomiej Dach
986910a7e4
Annotate dependency as possibly-null 2021-07-22 22:43:35 +02:00
Anton Kovalyov
bfad044b00
Remove unused imports. 2021-07-20 21:57:55 -07:00
Anton Kovalyov
2b0d530075
Eliminate Overlay.KeyBinding namespace and move everything to Settings.Section.Input 2021-07-20 21:18:24 -07:00
Dean Herbert
9c4fbf45e9 Add the ability to enter and exit the skin editor via on-screen buttons 2021-07-20 19:36:12 +09:00
Dean Herbert
7df7137c88 Add localisation support for remaining input settings sections 2021-07-16 23:03:55 +09:00
Dean Herbert
3f3adfe297 Add localisation support for MouseSettings 2021-07-15 13:09:51 +09:00
Dean Herbert
5b91111eda Update SettingsSubsection.Header to accept a LocalisableString 2021-07-15 13:09:51 +09:00
Dean Herbert
687c9aa33d Add tooltip and keywords for "high precision" setting 2021-07-15 12:37:52 +09:00
Bartłomiej Dach
6f89f8e572 Merge branch 'master' into da-mod-refactor 2021-07-10 11:41:54 +02:00
Dean Herbert
fcee69ffe6 Fix ShowsDefaultIndicator not actually being consumed 2021-07-08 17:48:08 +09:00
Bartłomiej Dach
f45418dde7 Replace game-side directory/file selector with framework extensions 2021-07-06 22:11:54 +02:00
Dean Herbert
f7aba7360a
Merge pull request #13654 from Henry-YSLin/fix-invisible-number-box
Refactor `SeedSettingsControl` and `SettingsNumberBox`
2021-06-28 16:07:30 +09:00
Dean Herbert
eeb56970ef Make OutlinedNumberBox private and nested again 2021-06-28 15:24:55 +09:00
Henry Lin
3d19364a71 Use BindValueChanged instead of setting the value in property setter 2021-06-28 11:20:00 +08:00
Henry Lin
0cceef8da5 Moved the string to int? conversion logic into SettingsNumberBox 2021-06-28 11:00:07 +08:00
Henry Lin
3b822cd5cf Refactor SeedSettingsControl and related controls 2021-06-26 11:19:14 +08:00
Bartłomiej Dach
50c27d2635 Update usages of IHasTooltip in line with framework localisation changes 2021-06-25 19:10:04 +02:00
Bartłomiej Dach
cc5145a131 Fix languages with a sub-language part not working properly 2021-06-16 11:10:03 +02:00
Bartłomiej Dach
d298e95df7 Limit maximum height of settings enum dropdowns 2021-06-16 10:25:50 +02:00
Pasi4K5
ef9cb2c958 Rename nested classes 2021-06-12 18:37:31 +02:00
Pasi4K5
b79d57b68c Move OsuSettingsNumberBox into SettingsNumberBox 2021-06-12 17:57:40 +02:00
Pasi4K5
c728f673d6 Rename classes 2021-06-12 17:37:01 +02:00
Pasi4K5
29f3880415 Move classes into SettingsTextBox 2021-06-12 17:34:02 +02:00
Pasi4K5
fe39a47797 Add OsuModSettingsTextBox and OsuModSettingsNumberBox 2021-06-12 00:34:53 +02:00
Dean Herbert
20759657de Rename configuration variables and refactor lots more 2021-06-11 16:37:31 +09:00
Dean Herbert
c00f9ae4b7 Reword settings text 2021-06-11 16:11:37 +09:00
Craftplacer
39c3b08fc7
Merge remote-tracking branch 'upstream/master' into chat-mention 2021-06-05 11:18:06 +02:00
Dean Herbert
98fa5b67d6
Merge branch 'master' into single-bind-reset-button 2021-05-26 17:01:16 +09:00
Dean Herbert
88bdd8a7b7 Update some out of date code pieces 2021-05-26 16:01:21 +09:00
Dean Herbert
52ca2f4797 Merge branch 'master' into chat-mention 2021-05-26 16:00:26 +09:00
Dean Herbert
b13a68592f Merge branch 'master' into localisation-proof-of-concept 2021-05-22 17:07:23 +09:00
Dean Herbert
b0a113a36b Merge branch 'master' into localisation-proof-of-concept 2021-05-21 17:57:54 +09:00
Dean Herbert
2958b9adf4 Merge branch 'master' into import-from-stable-select-location 2021-05-21 17:37:34 +09:00
Dean Herbert
5acb708939 Remove customisation of hit error via standard settings 2021-05-18 15:50:50 +09:00
Dean Herbert
c71d53a0f9 Fix text and button layout 2021-05-18 13:40:26 +09:00
Lucas A
e2018f81f3 Use equality check for nullable types. 2021-05-17 19:54:21 +02:00
Lucas A
5ca4fd5ab4 Block overlays to prevent getting into a bad state. 2021-05-17 13:28:59 +02:00
Lucas A
a38fc1a2e0 Override text header. 2021-05-17 13:04:49 +02:00
Lucas A
db255e6814 Mark StableImportManager as potentially null in tests.
(StableImportManager is added to the DI in OsuGame and not in the OsuGameBase)
2021-05-17 12:55:59 +02:00
Lucas A
bec06cfac7 Reword StableDirectoryLocationDialog header
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-05-17 12:55:58 +02:00
Lucas A
f60dbbfbbd Reword import dialogs.
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-17 12:55:58 +02:00
Lucas A
e15e8068d3 Reword StableDirectoryLocationDialog.
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-17 12:55:58 +02:00
Lucas A
dabe8bd4c7 Fix code inspections and remove now unused code. 2021-05-17 12:55:58 +02:00
Lucas A
481b0a0125 Add StableDirectoryLocationDialog 2021-05-17 12:55:57 +02:00
Lucas A
851e33fd15 Hook up StableImportManager. 2021-05-17 12:55:57 +02:00
Lucas A
5d5b1e1f0e Add StableImportManager 2021-05-17 12:55:56 +02:00
Dean Herbert
baa4089364 Expose method to adjust header text, not whole drawable 2021-05-17 16:41:46 +09:00
Swords
304caf8bdf Adding Requested changed 2021-05-15 11:24:08 +10:00
Swords
1603b92211 Reformatting 2021-05-15 01:30:54 +10:00
Swords
753bdf2083 Fixed formatting 2021-05-15 01:04:15 +10:00
Swords
0725088fde Well it works, just pretty ugly looking. 2021-05-15 01:01:17 +10:00
Lucas A
6f248db519 Merge conditional expression. 2021-05-13 19:31:10 +02:00
Lucas A
0caba57945 Make screen properties local to MigrationSelectScreen. 2021-05-13 19:28:23 +02:00
Lucas A
09a5b9c872 Add XMLDoc to protected members. 2021-05-13 16:28:03 +02:00
Lucas A
eee3cd7c57 Disallow selecting storage root as a valid directory. 2021-05-13 11:14:05 +02:00
Lucas A
d3cc418961 Privatize DirectorySelector. 2021-05-13 11:08:04 +02:00
Lucas A
4bb0e6b7d5 Create InitialPath property. 2021-05-13 11:07:52 +02:00
Lucas A
9a061ad80b Extract directory selection logic of migration screen to DirectorySelectScreen. 2021-05-13 11:07:26 +02:00
smoogipoo
cd25d76dbe Merge branch 'master' into localisation-proof-of-concept 2021-05-08 18:11:07 +09:00
Joseph Madamba
d4658c609b Fix warning text of bg source setting not being updated when user with supporter signs in/out 2021-05-05 22:54:35 -07:00
Dean Herbert
08a45e9fc2 Remove dead code 2021-05-05 16:26:41 +09:00
Dean Herbert
19ffcd00c2 Initialise warning text flow lazily as most items will not use it 2021-05-05 16:26:41 +09:00
Dean Herbert
1288f69fad Rename to WarningText 2021-05-05 16:16:49 +09:00
Dean Herbert
6178f38c95 Reword unlimited frame rate warning a bit 2021-05-05 16:15:06 +09:00
Joseph Madamba
23b9d8c260
Fix alpha not being zero when string is set to empty and use inequality on supporter condition
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-05-04 14:02:12 -07:00
Joseph Madamba
a584213002 Use vertical padding instead of relative height for default button 2021-05-04 09:32:38 -07:00
Joseph Madamba
0a64922738 Add supporter note to background source setting 2021-05-04 01:15:59 -07:00
Joseph Madamba
796bd8e47e Add existing setting notes from stable 2021-05-04 01:15:59 -07:00
Joseph Madamba
acc9258eb2 Implement notes for settings 2021-05-04 01:15:59 -07:00
Dean Herbert
ab2a8b5c89 Fix initial rotation not being set 2021-04-21 16:12:09 +09:00
Dean Herbert
eb20865c02 Show tablet preview with physical tablet counter-rotated for supplied user area selection
Closes https://github.com/ppy/osu/issues/12399.

Rotation animation is intentionally delayed slightly to give a better sense of what is going on (or maybe just look cool).
2021-04-21 15:55:15 +09:00
Dean Herbert
31c8586dac Add localisation support to overlay header title/description 2021-04-21 14:37:29 +09:00
Dean Herbert
623eae1576 Add basic language switching ability 2021-04-20 17:06:01 +09:00
smoogipoo
8293b06c0a Remove obsolete code 2021-04-09 13:56:58 +09:00
Dean Herbert
1dfd08eded Add tablet rotation configuration 2021-03-30 13:01:48 +09:00
Dean Herbert
8dfff999f9 Add rotation slider 2021-03-30 12:40:50 +09:00
Dean Herbert
8a0fcf20ed Move offset settings up for more logical ordering 2021-03-30 12:32:42 +09:00
Bartłomiej Dach
86b569f5f7 Fix typo in identifier 2021-03-20 12:37:51 +01:00
Bartłomiej Dach
d28bed6ed2 Schedule adding transforms on tablet changes
Fixes `InvalidThreadForMutationException`s that pop up when
disconnecting/reconnecting tablets during the game's operation. In those
cases the value change callback executes from  an OpenTabletDriver
thread.
2021-03-20 12:37:48 +01:00
Dean Herbert
63cbac3bd0 Ensure aspect ratio slider gets an initial value 2021-03-19 20:15:29 +09:00
Dean Herbert
6f32c302eb Add checkbox to optionally disable tablet handling 2021-03-19 20:13:51 +09:00
Dean Herbert
86b229b1c9 Increase maximum usable aspect ratio to account for ultrawide monitors 2021-03-19 20:05:18 +09:00
Dean Herbert
fefb007805 Remove no longer relevant comment 2021-03-19 19:01:32 +09:00
Dean Herbert
1e82033c84 Move bindings to LoadComplete to avoid cross-thread issues 2021-03-19 19:01:32 +09:00
Dean Herbert
c624aa9397 Only update tablet values on commit 2021-03-19 19:01:32 +09:00
Dean Herbert
6285dcd1a1 Add arbitrary value to fix FP contains check failures 2021-03-19 19:01:32 +09:00
Dean Herbert
e8c20bdcb1 Add centre crosshair 2021-03-19 19:01:32 +09:00
Dean Herbert
fb7d095e4a Show aspect ratio for current usable area 2021-03-19 19:01:32 +09:00
Dean Herbert
196f95ae54 Update to use new bindables and centered area offset 2021-03-19 19:01:32 +09:00
Dean Herbert
9d0c8902a6 Fix margins and spacing between sub flowed items 2021-03-19 19:01:32 +09:00
Dean Herbert
d422a65900 Fix initial tablet size not being initialised 2021-03-19 19:01:32 +09:00
Dean Herbert
9a6a0f3df5 Add test coverage and better UI handling of no tablet connected scenario 2021-03-19 19:01:32 +09:00
Dean Herbert
bba25a0182 Tidy up draw hierarchy and bindable logic 2021-03-19 19:01:31 +09:00
Dean Herbert
932745e5c4 Fix remaining feedback loops 2021-03-19 19:01:31 +09:00
Dean Herbert
e3bed4c97d Simplify aspect ratio application, add window conforming and direct adjustment 2021-03-19 19:01:31 +09:00
Dean Herbert
43359553c1 Add aspect ratio display and limiting 2021-03-19 19:01:31 +09:00
Dean Herbert
9b70f0ee1f Tidy up visual appearance of settings and add a reset button 2021-03-19 19:01:31 +09:00
Dean Herbert
2dc2cb04c3 Fix bounds check becoming false when using full area 2021-03-19 19:01:31 +09:00
Dean Herbert
464702182d Consume device name 2021-03-19 19:01:31 +09:00
Dean Herbert
94f184d113 Add feedback when area extends beyond tablet size 2021-03-19 19:01:31 +09:00
Dean Herbert
0a6525baee Fix slider bars reloading each time the tablet size is changed 2021-03-19 19:01:31 +09:00
Dean Herbert
926e40925e Add exclude rule to fix dynamic compilations issues with settings sections 2021-03-19 19:01:31 +09:00
Dean Herbert
3b7edf1333 Make tablet display always fit to size of settings area 2021-03-19 19:01:31 +09:00
Dean Herbert
d026c8da85 Initial pass of configuration interface 2021-03-19 19:01:31 +09:00
Dean Herbert
a8cc3a3b44 Implement enable state changes locally for InputHandlers which should be toggleable 2021-03-18 21:17:04 +09:00
Dean Herbert
fccd495f27 Remove obsoleted setting for now 2021-03-17 18:07:51 +09:00
Dean Herbert
3458dcc33a Use whitelist to avoid exposing settings to user that shouldn't be 2021-03-12 18:40:38 +09:00
Dean Herbert
03230edcb1 Update bindings settings to handle the new structure and show all handlers 2021-03-12 18:38:16 +09:00
Dean Herbert
3c21c83cc8 Rename KeyboardSection to BindingSection 2021-03-12 18:36:28 +09:00
Dean Herbert
e7707eee94 Switch RestoreDefaultsValueButton to use HasPendingTasks to avoid tooltip always showing 2021-03-12 15:23:11 +09:00
Salman Ahmed
132fcda089 Force config sensitivity value to local setting bindable
Re-enable the local bindable to update the sensitivity value then change back to whatever state it was in previously.
2021-03-04 17:00:44 +03:00
Dean Herbert
534e16237a Remove unnecessary intial construction of bindable 2021-03-03 20:36:41 +09:00
Dean Herbert
002646370c Move bindable logic in MouseSettings to LoadComplete 2021-03-03 16:47:42 +09:00
Bartłomiej Dach
3b125a26a8 Add test coverage 2021-03-02 19:21:03 +01:00
Bartłomiej Dach
40a28367c6 Fix restore-to-default buttons never showing if initially hidden 2021-03-02 18:50:33 +01:00
Dean Herbert
6372a0265a Fix confine mode dropdown becoming visible again after filtering
Changes from a hidden to a disabled state, with a tooltip explaining
why.

Closes #11851.
2021-03-02 17:44:58 +09:00
Bartłomiej Dach
52e81385a6 Fix restore default button mutating transforms during load 2021-02-27 11:39:18 +01:00
Dean Herbert
8a97e2e28d Update LocalisedString usages to RomanisedString 2021-02-22 19:01:42 +09:00
Dean Herbert
1fd76ea3fb Apply changes to UI components overriding functions with changing signatures 2021-02-22 19:01:42 +09:00
Dean Herbert
9fb41dc0b6 Move property to a better place in the class 2021-02-11 16:41:21 +09:00
Dean Herbert
dddd776802 Add the ability for settings items to have tooltips 2021-02-11 16:38:17 +09:00
Dean Herbert
18e6afbec0 Ensure the item is present before trying to select it 2021-01-29 19:17:12 +09:00
Dean Herbert
1ce383fc20 Merge branch 'master' into fix-skin-dropdown-update-crash 2021-01-29 19:16:20 +09:00
Bartłomiej Dach
3b49b7461e Schedule entire operation for safety
Also removes a redundant list copy.
2021-01-19 19:35:53 +01:00
Bartłomiej Dach
78e590d25d Refactor skin sorting method
* Rename to `sortUserSkins` to convey meaning better.
* Sort in-place instead of slicing the list.
* Change to `void` to avoid misleading users that the method returns
  a new list instance.
* Fix typo in comment.
2021-01-19 18:36:42 +01:00
Bartłomiej Dach
b00c6a1d60 Make first non-default skin index a property
The previous code was very brittle - it was not always updating
properly, and seems to have worked either by a carefully crafted set of
circumstances, or just plain coincidence.

Having this be a get-only property avoids potential error in the future
caused by not updating the index properly, at the expense of an added
linear lookup.
2021-01-19 18:31:37 +01:00
rednir
206a0b8bac Fix firstNonDefault staying as -1 2021-01-19 16:55:50 +00:00
rednir
a880b8d21d Satisfy AppVeyor 2021-01-19 16:11:16 +00:00
rednir
b265d2dab4 Remove another whitespace 2021-01-19 14:16:22 +00:00
rednir
1d4c813ff6 Merge branch 'sort-skins-alphabetically' of https://github.com/rednir/osu into sort-skins-alphabetically 2021-01-19 14:03:31 +00:00
rednir
31e61326e1 Only user skins are sorted 2021-01-19 14:00:17 +00:00
rednir
f1894a8bac fixed itemUpdated() 2021-01-19 12:17:56 +00:00
rednir
0b65c0cd25 Remove whitespace 2021-01-18 20:17:42 +00:00
rednir
da89426a3b Merge branch 'master' of https://github.com/ppy/osu into sort-skins-alphabetically 2021-01-18 20:09:15 +00:00
rednir
7476cb3047 Sort SkinSection in alphabetical order 2021-01-18 19:51:42 +00:00
Dean Herbert
1364de1166
Merge branch 'master' into beatmap-colour-setting 2021-01-18 16:07:46 +09:00
Dean Herbert
5278cad393 Reword setting to make more sense 2021-01-17 22:42:48 +09:00
Dean Herbert
5fd644fc57 Unify variable names 2021-01-17 22:42:48 +09:00
Dean Herbert
b5e784ed42 Fix possibility of crash when selecting a random skin during skin import 2021-01-15 16:34:28 +09:00
Mysfit
5f10bcce02 Added beatmap colour settings checkbox and associated tests. 2021-01-13 00:09:22 -05:00
Salman Ahmed
24c1839739 Add global web setting for allowing explicit content 2021-01-12 11:10:25 +03:00
Dean Herbert
866fb28d6c
Merge pull request #11411 from LavaDesu/feature/discord-presence-toggle
Add ability to toggle discord rich presence
2021-01-07 00:52:38 +09:00
Dean Herbert
15dd7a87a6 Move gameplay preview event binding to LoadComplete 2021-01-06 15:19:12 +09:00
Dean Herbert
d0d2e41b28 Fix display settings binding to configuration bindables in async load 2021-01-05 18:19:28 +09:00
LavaDesu
2e5c67be3f
Add ability to toggle discord rich presence
There are 3 modes: enabled, limited, and disabled.

The limited mode hides identifiable information such as username, rank, and
(if participating in one) multiplayer lobby name.
2021-01-03 10:37:28 +07:00
Dean Herbert
4f02928601 Change sorting to better handle portrait screens 2020-12-22 17:36:56 +09:00
Dean Herbert
3d5783a0ea Improve variable names 2020-12-22 17:34:51 +09:00
Dean Herbert
a1d67f0cf6
Merge branch 'master' into fix-resolution-dropdown 2020-12-22 17:26:53 +09:00
Salman Ahmed
dab5924a63 Fix resolution dropdown not respecting current display changes 2020-12-22 08:02:42 +03:00
Dean Herbert
7c5964fad8 Revert window modes to previous code to correctly apply framework restrictions 2020-12-22 13:04:39 +09:00
Joehu
5b8e35c98c Make settings dropdown abstract 2020-12-19 19:04:14 -08:00
Joehu
b87f89986a Fix selected item not being highlighted on some setting dropdowns 2020-12-19 19:04:13 -08:00
Dean Herbert
26fa010fed Merge branch 'master' into import-screen 2020-12-15 12:37:27 +09:00
ekrctb
f4eb17d398
Update osu.Game/Overlays/Settings/Sections/Input/MouseSettings.cs
Set mouse confine mode at initialization

Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-12-07 16:09:14 +09:00
ekrctb
2469608c10 Fix possible null reference due to bindable change before variable is initialized 2020-12-07 15:19:18 +09:00
Bartłomiej Dach
71edada623 Hide confine setting entirely in fullscreen 2020-12-05 22:15:41 +01:00
PercyDan
60d8102a77
Merge branch 'master' into import-screen 2020-12-04 21:20:14 +08:00
Bartłomiej Dach
7fd385efe6 Remove unused using directive 2020-12-02 20:01:58 +01:00
Leon Gebler
a2a10d4e13 Don't use nameof(MouseHandler) 2020-12-02 19:45:59 +01:00
Leon Gebler
bbde1f6b9c Fix MouseHandler not being ignored when raw input is enabled 2020-12-02 18:56:59 +01:00
Dean Herbert
285e62be9a Bring code in line with SDL2 defaults 2020-12-01 17:47:07 +09:00
Dean Herbert
965cc1f511 Remove unnecessary usings #2 2020-11-30 17:57:25 +09:00
Dean Herbert
fe48b2279c Adjust various paddings and spacings in settings to make them easier to visually parse 2020-11-30 17:50:35 +09:00
Dean Herbert
a3dd22f5c2 Merge branch 'master' into settings-remove-transparency 2020-11-30 17:50:26 +09:00
Dean Herbert
bf2c6dc241 Remove unused usings rider couldn't see 2020-11-30 17:49:55 +09:00
Dean Herbert
a4e061cb11 Remove semi-transparent backgrounds from settings and notifications overlays
I tried also updating the colours to the "new" versions from designs but
they don't match due to colour profile differences (so I'm not yet sure
if they are correct or not) and also don't look great without all the UI
elements also being updated.
2020-11-30 17:19:55 +09:00
Dean Herbert
4e1e45f3e7 Move hold-to-confirm back to UI section 2020-11-30 16:15:35 +09:00
Dean Herbert
55c8aa5d5f Move menu cursor size to UI section 2020-11-30 16:14:15 +09:00
Bartłomiej Dach
e0a84ff1dc Move hold-to-confirm setting back to gameplay section 2020-11-29 22:07:34 +01:00
Bartłomiej Dach
a5c4a8d2e9 Create "User Interface" settings section 2020-11-29 22:07:33 +01:00
PercyDan
579e61eab9
Allow null 2020-11-28 16:31:24 +08:00
PercyDan54
9a3dd12f30
Move to debug settings 2020-11-18 18:15:56 +08:00
Bartłomiej Dach
610ed99ae3 Add null checks to unguarded resolved-as-null fields 2020-11-14 14:52:58 +01:00
Dean Herbert
a2c81a3a52 Add back setting to toggle "always play first combo break" 2020-11-13 13:42:00 +09:00
Dean Herbert
8d38d9cc93 Add hotkey to select random skin 2020-11-11 13:05:03 +09:00
Dean Herbert
6674628bc7 Only include user skins in random choices 2020-11-11 12:03:38 +09:00
Dean Herbert
6b548ef5e4 Split out SkinInfo ID constants and fix random logic 2020-11-11 11:54:40 +09:00
Dean Herbert
a5e13e4d2c Merge branch 'master' into shuffle-skin 2020-11-11 11:34:48 +09:00
Dean Herbert
f0b80d245e Merge branch 'master' into spectator-listing 2020-10-31 16:22:49 +09:00
Max Hübner
4e3fb615d2 Rename "SeasonalBackgrounds" to "SeasonalBackgroundMode" 2020-10-30 15:54:10 +01:00
Max Hübner
76c0a790b4 Add separate Seasonal Backgrounds setting (Always, Sometimes, Never) 2020-10-29 17:28:04 +01:00
Dean Herbert
93fd913876 Add setting to allow automatically downloading during a spectating session 2020-10-28 19:43:06 +09:00
Dean Herbert
9753dab93b Remove IOnlineComponent and change existing components to use bindable flow 2020-10-22 14:19:12 +09:00
Dean Herbert
8273715bde
Merge pull request #9484 from FlashyReese/visible-playfield-boundary 2020-10-20 19:43:41 +09:00
Dean Herbert
80b1f816c7 Merge branch 'master' into hide-hud-during-break-time 2020-10-20 14:19:04 +09:00
Bartłomiej Dach
bca0539735 Move setting to osu! ruleset subsection 2020-10-19 21:05:21 +02:00
Bartłomiej Dach
053c7a69a6 Fix code style issues & compilation failures 2020-10-19 20:22:48 +02:00
Dean Herbert
22bde43106
Merge branch 'master' into visible-playfield-boundary 2020-10-19 18:05:28 +09:00
Dean Herbert
e3b47083fc Add "scoring" as keyword to more easily find score display mode setting 2020-10-19 14:05:41 +09:00
Bartłomiej Dach
c867fb4985
Merge branch 'master' into update-check-improvements 2020-10-08 21:32:26 +02:00
Shane Woolcock
ec12a21088 Merge branch 'master' into confine-during-gameplay
# Conflicts:
#	osu.Game/Overlays/Settings/Sections/Input/MouseSettings.cs
2020-10-07 11:07:00 +10:30
Dean Herbert
b2dad67ade Fix unresolvable dependency in settings test scene 2020-10-06 21:28:59 +09:00
Dean Herbert
e8b34ba4ac
Fix incorrectly committed testing change 2020-10-06 20:57:39 +09:00
Dean Herbert
e64cee10b8 Add obsoleted Bindable property back to SettingsItem for compatibility 2020-10-06 19:07:31 +09:00
Dean Herbert
9d7880afda Make SettingsItem conform to IHasCurrentValue 2020-10-06 17:18:54 +09:00
Dean Herbert
22b0105d62 Show a notification if checking for updates via button and there are none available 2020-10-06 13:00:02 +09:00
Shane Woolcock
4b6f893408 Merge branch 'master' into confine-during-gameplay
# Conflicts:
#	osu.Game/Configuration/OsuConfigManager.cs
#	osu.Game/OsuGame.cs
#	osu.Game/Screens/Play/Player.cs
2020-10-05 10:23:37 +10:30
Dean Herbert
61e62929ee Apply changes in line with framework event logic update 2020-10-01 13:06:01 +09:00
Dean Herbert
937d5870b3 Add a basic file selector with extension filtering support 2020-09-24 20:54:25 +09:00
smoogipoo
1a023d2c88 Fix a few more tests 2020-09-09 16:33:48 +09:00
smoogipoo
4ddf5f054b Rename BeatmapCollectionManager -> CollectionManager 2020-09-09 15:31:08 +09:00
smoogipoo
06328e0000 Add import/deletion progress notifications 2020-09-08 17:59:27 +09:00
smoogipoo
6cc4517600 Merge branch 'master' into collection-database 2020-09-07 20:03:11 +09:00
Yao Chung Hu
96f39dd350 Merge remote-tracking branch 'upstream/master' into visible-playfield-boundary 2020-09-05 01:50:13 -05:00
smoogipoo
345fb9d8e0 Rename classes 2020-09-05 03:55:43 +09:00
Dean Herbert
ab057e6c65 Remove unnecessary string interpolation 2020-09-04 16:28:35 +09:00
Dean Herbert
644f3375ac Also catch exceptions in the construction call 2020-09-04 16:28:19 +09:00
Dean Herbert
a15653c77c Fix potential hard crash if ruleset settings fail to construct 2020-09-04 16:15:57 +09:00
Dean Herbert
f5a73130e1 Fix regression in sidebar button sizing 2020-09-03 16:34:58 +09:00
Dean Herbert
2fac0a180e Adjust toolbar button sizing 2020-09-03 16:34:58 +09:00
smoogipoo
a56f9d6770 Implement collection import 2020-09-03 00:08:33 +09:00
Dean Herbert
d45a1521a1 Update BindableList usages 2020-09-01 11:56:23 +09:00
Shane Woolcock
322d179076 Replace settings item with osu! confine cursor mode 2020-08-16 11:04:28 +09:30
Salman Ahmed
2190e6443a Apply height constraints to all settings dropdown 2020-08-01 10:02:46 +03:00
Dean Herbert
dfcd26be2d
Merge pull request #9439 from Game4all/gameplay-disable-winkey 2020-07-24 19:34:48 +09:00
Dean Herbert
fea6389f69 Hide HUD elements during break time by default 2020-07-22 12:41:06 +09:00
Andrei Zavatski
81d95f8584 Implement UserBrickPanel component 2020-07-18 20:24:38 +03:00
Yao Chung Hu
d40f209f4b Move Playfield Border to OsuPlayfield Ruleset 2020-07-10 07:36:21 -05:00
Yao Chung Hu
321815f535 Add playfield bounds box with toggle and dim slider 2020-07-09 14:01:28 -05:00
Lucas A
022e4b6335 Apply review suggestions. 2020-07-06 11:15:56 +02:00
Lucas A
641ea5b950 Make the disabling of the win key during gameplay a toggleable setting. 2020-06-30 13:12:33 +02:00
Dean Herbert
97067976f7 Add null check 2020-06-15 22:23:06 +09:00
Dean Herbert
53b7057ee0 Don't show update button when updates are not feasible 2020-06-15 22:19:11 +09:00
Dean Herbert
4f809767a5 Disable button while update check is in progress 2020-06-12 18:36:36 +09:00
Craftplacer
101604e741 Redesign classes and generally improve code 2020-06-08 00:39:33 +02:00
Craftplacer
e95ffcb528 Merge remote-tracking branch 'upstream/master' into update-button 2020-06-07 22:51:03 +02:00
Craftplacer
4e56981554 Merge remote-tracking branch 'upstream/master' into update-button
# Conflicts:
#	osu.Game/Overlays/Settings/Sections/General/UpdateSettings.cs
2020-06-07 22:43:53 +02:00
Dean Herbert
f989f1aa00 Change event flow to avoid firing store delete events on update 2020-05-27 16:08:47 +09:00
Dean Herbert
8ab65e4c5d Move implementation into own class 2020-05-24 23:15:24 +09:00
Dean Herbert
c071fe6140 Add the ability to export skins 2020-05-24 13:44:11 +09:00
Dean Herbert
052ad79fc6 Convert dangerous events to IBindables 2020-05-19 16:44:22 +09:00
Dan Balasescu
533010f168
Merge branch 'master' into avoid-host-disable 2020-05-17 15:59:39 +09:00
Dean Herbert
9d3df14179 Remove unused variable 2020-05-16 11:03:27 +09:00
Dean Herbert
c47f02c3b7 Update second instance of disabling bindable 2020-05-16 08:24:02 +09:00
Dean Herbert
aec2520ef4 Avoid disabling a host-level bindable from osu! code 2020-05-15 17:31:06 +09:00
Dean Herbert
155e918ca3 Remove unused parameter 2020-05-14 21:40:28 +09:00
Dean Herbert
42f446faa9 Fix remaining test failure 2020-05-14 21:10:04 +09:00
Dean Herbert
a582611647 Add test coverage 2020-05-14 19:05:35 +09:00
Dean Herbert
4e4a779d68 Improve overall UI 2020-05-14 17:41:55 +09:00
Dean Herbert
0b73063a89 Add basic (working) migration UI 2020-05-14 17:41:55 +09:00
Craftplacer
0d6f531183 Merge branch 'update-button' of https://github.com/Craftplacer/osu into update-button 2020-05-08 02:56:33 +02:00
Craftplacer
ebd1df8c28 Change property name to CanCheckForUpdate 2020-05-08 02:50:58 +02:00
Craftplacer
7f61f27be1
Use null-conditional operator when checking against UpdateManager
Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-05-08 02:33:12 +02:00
Craftplacer
e6ad28a1cb Use property instead of type checking 2020-05-08 02:09:37 +02:00
Craftplacer
a7792070bc Final changes to DI fields and values 2020-05-08 01:08:17 +02:00
Craftplacer
477bd7fa61 Change to Resolved attribute 2020-05-08 00:35:27 +02:00
Craftplacer
72b6bb25a5 Allow nulls and hide if missing dependencies 2020-05-08 00:33:33 +02:00
Craftplacer
92872496b8 Convert to method groups
because Inspector said so.
2020-05-07 23:27:28 +02:00
Craftplacer
c025814f40 Finalize changes 2020-05-07 23:04:18 +02:00
Craftplacer
836efe3f7c Initial commit 2020-05-07 08:07:22 +02:00
Shane Woolcock
9477a5373c
Merge branch 'master' into display-modes 2020-04-28 12:04:20 +09:30
Bartłomiej Dach
a436f8e6d4 Trim other leftover RelativeSizeAxes 2020-04-26 22:54:01 +02:00
Lucas A
801968ed51 Remove un-needed RelativeSizeAxes specifications. 2020-04-26 21:17:40 +02:00
Lucas A
a756486a4d Make settings section icons actual drawables. 2020-04-25 20:35:46 +02:00
Dan Balasescu
ac8a3efc46
Merge branch 'master' into low-hp-red-layer 2020-04-14 14:47:01 +09:00
Endrik Tombak
d9c91fb943 Merge branch 'master' of https://github.com/ppy/osu into no-video-option
 Conflicts:
	osu.Game/Overlays/Direct/PanelDownloadButton.cs
2020-04-13 17:40:28 +03:00
Endrik Tombak
633b969017 Apply review suggestions 2020-04-12 21:57:35 +03:00
Endrik Tombak
df76636ffc Implement "prefer no video" option 2020-04-11 14:08:16 +03:00
Fire937
2201e9b4ae Add stereo shifted hitsound playback support
There is now a setting in the general settings called "Positional
hitsounds". If the setting is enabled, the hitsounds playback will be
shifted according to their position on the beatmap.
2020-04-09 18:12:15 +02:00
Dean Herbert
52c9762651 Remove pointless keywords 2020-04-09 14:36:04 +09:00
Shane Woolcock
2fec8b7b85 Use DisplayModes rather than AvailableResolutions 2020-04-05 13:01:10 +09:30
Lucas A
ab01111c36 Fix merge conflicts. 2020-03-30 17:39:11 +02:00
Lucas A
3cae0cedee Add a game setting to disable the layer 2020-03-30 12:59:39 +02:00
Dean Herbert
5be8934c8c
Merge pull request #8407 from peppy/disable-raw-input
Disable raw input toggle on all but windows
2020-03-27 21:10:02 +09:00
Dean Herbert
6d81da5419
Merge branch 'master' into video-offset 2020-03-25 11:28:59 +09:00
Dean Herbert
3a3df06e0b Fix some pieces of SettingsItem getting dimmed twice when disabled 2020-03-23 13:11:40 +09:00
Dean Herbert
997ce397ef Disable raw input toggle on all but windows 2020-03-23 12:48:05 +09:00
Dean Herbert
729e006c3a
Merge branch 'master' into video-offset 2020-03-21 20:03:46 +09:00
Joehu
f7ea20a926 Limit font weight to bold 2020-03-16 16:32:25 -07:00
voidedWarranties
c27751050b Switch back to strings and update setting labels 2020-03-12 23:29:11 -07:00
voidedWarranties
48282dea8b Remove individual setting to disable videos, fix tests 2020-03-07 22:08:38 -08:00
Andrei Zavatski
6631b07442 Refactor to replace existing panels 2020-03-04 14:58:15 +03:00
Dean Herbert
394b88aa65 Add thread mode dropdown 2020-02-28 22:17:45 +09:00
Dean Herbert
4ad2d0cfb6 Remove deprecated debug setting 2020-02-28 22:17:45 +09:00
Dean Herbert
92f6f0207c Rename LoadingAnimation to LoadingSpinner 2020-02-21 15:33:31 +09:00
recapitalverb
ee14a275a2 Make IAPIProvider instances nullable 2020-02-14 22:02:44 +07:00
recapitalverb
10798aeab3 Fix code formatting 2020-02-14 20:30:27 +07:00
recapitalverb
c753cb46c5 Use [Resolved] wherever possible 2020-02-14 20:14:00 +07:00
Dean Herbert
aa597c1934 Copy documentation across to SettingsSlider 2020-01-29 12:55:07 +09:00
unknown
894642d588 add xmldoc and formatting 2020-01-28 18:04:00 +08:00
unknown
aa264cd2a8 allow tooltip to show as percentage as needed 2020-01-28 12:32:30 +08:00
Dean Herbert
bc75290655 Ensure min and max stars are correctly ordered 2020-01-25 00:11:20 +09:00