Andrei Zavatski
1d549a0c8a
Remove unused using
2020-01-24 10:46:27 +03:00
Andrei Zavatski
738980e3f7
Refactor OsuTabControl.AccentColour
2020-01-24 10:31:47 +03:00
Andrei Zavatski
34ffbcf2ae
Adjust xmldoc
2020-01-24 10:24:44 +03:00
Andrei Zavatski
2b941a0d52
Merge remote-tracking branch 'refs/remotes/ppy/master' into no-control-overlay-headers
2020-01-24 10:18:45 +03:00
Dean Herbert
da65fff48e
Merge remote-tracking branch 'upstream/master' into collapse-graph-option
2020-01-24 13:55:42 +09:00
Dean Herbert
5863576ce4
Add comment as to why counter is zeroes only in Show method
2020-01-24 11:42:33 +09:00
Andrei Zavatski
6493f24547
Add TotalCommentsCounter to CommentsContainer
2020-01-23 15:56:01 +03:00
Andrei Zavatski
0c3120d965
Fix possible crash due to not loaded api
2020-01-23 12:59:53 +03:00
Andrei Zavatski
667fdb907c
Call the method directly rather that trigger a bindable
2020-01-23 12:21:16 +03:00
Dean Herbert
ca94850ce4
Merge branch 'master' into view-comments-via-propery
2020-01-23 17:47:40 +09:00
Dan Balasescu
e988976012
Merge branch 'master' into mod-autoopen
2020-01-23 15:34:19 +09:00
Dean Herbert
8c29093d1c
Merge remote-tracking branch 'smoogipoo/void-joystick-release-returns' into update-framework
2020-01-22 22:58:00 +09:00
Dean Herbert
8a7f7c5e46
Merge remote-tracking branch 'smoogipoo/void-key-up-returns' into update-framework
2020-01-22 22:57:56 +09:00
Dean Herbert
7c62cc3ac3
Merge remote-tracking branch 'smoogipoo/void-mouse-up-returns' into update-framework
2020-01-22 22:57:52 +09:00
Andrei Zavatski
bf2b71f7dd
Cleanup OsuTabControl.AccentColour
2020-01-22 09:36:16 +03:00
smoogipoo
7b2f58eb30
Apply OnRelease method signature refactorings
2020-01-22 13:22:34 +09:00
Andrei Zavatski
14a961c95b
Remove invariance in the OverlayTabItem
2020-01-22 04:41:10 +03:00
ProTheory8
61d7b63914
Readability Improvement
2020-01-21 09:30:11 +05:00
Andrei Zavatski
327d8c213b
Rename Bar to TabControlBar
2020-01-21 06:25:13 +03:00
Andrei Zavatski
8bf19913c0
Add NotNull attribute
2020-01-21 06:03:48 +03:00
Andrei Zavatski
30edd80c8c
Refactor OverlayHeader hierarchy
2020-01-21 06:00:12 +03:00
Andrei Zavatski
178a72f9b8
Make OverlayTabControl inherited from OsuTabControl
2020-01-21 05:24:49 +03:00
ProTheory8
41295bc27c
Difficulty Adjust mod customisation menu opens automatically now
2020-01-20 21:06:36 +05:00
smoogipoo
b62e3addf3
Apply input method signature refactorings
2020-01-20 20:30:25 +09:00
smoogipoo
40f502c6d1
Apply input method signature refactorings
2020-01-20 19:35:37 +09:00
Andrei Zavatski
843feb4e08
Add more xmldoc to ControllableOverlayHeader
2020-01-20 12:26:14 +03:00
smoogipoo
bfb056c612
Apply input method signature refactorings
2020-01-20 18:17:21 +09:00
Andrei Zavatski
17a7a75707
Merge master with conflicts resolved
2020-01-20 08:52:03 +03:00
Andrei Zavatski
11e7c8be3f
Use colour schemes for OverlayRulesetSelector
2020-01-20 08:34:46 +03:00
Andrei Zavatski
6552097866
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector
2020-01-20 08:22:30 +03:00
Dean Herbert
aa0d95cdee
Merge branch 'master' into profile-scores-update-new
2020-01-20 14:15:03 +09:00
Andrei Zavatski
6875b41f74
Remove unnecessary setter
2020-01-20 07:47:49 +03:00
Andrei Zavatski
5f11084aed
Refactor ProfileItemContainer to not use sounds
2020-01-19 22:57:39 +03:00
Andrei Zavatski
8906416294
ProfileItemBackground -> ProfileItemContainer
2020-01-19 22:48:11 +03:00
Andrei Zavatski
22118b7b22
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-scores-update-new
2020-01-19 22:44:40 +03:00
Andrei Zavatski
1b06957566
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-header-web-colours
2020-01-18 23:54:12 +03:00
Dean Herbert
3f2512295c
Merge pull request #7555 from peppy/update-framework
...
Update framework
2020-01-18 15:57:16 +09:00
Andrei Zavatski
e258489bb5
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-header-web-colours
2020-01-18 08:51:10 +03:00
Andrei Zavatski
bab67eb399
CI fix
2020-01-18 04:12:17 +03:00
Andrei Zavatski
16cfb9310b
Naming adjustments
2020-01-18 03:40:31 +03:00
Andrei Zavatski
d5a3d8dbaa
Remove no longer used components
2020-01-18 03:35:47 +03:00
Andrei Zavatski
6e776d02f8
Refactor PaginatedScoreContainer to use new components
2020-01-18 03:33:02 +03:00
Andrei Zavatski
4964505c3e
Implement ProfileWeightedScore component
2020-01-18 03:19:28 +03:00
Andrei Zavatski
4cdaebb42b
Implement ProfileScore component
2020-01-18 02:58:10 +03:00
Andrei Zavatski
59cb93321f
Implement ProfileItemBackground component
2020-01-18 01:36:14 +03:00
McEndu
6579aa144d
Merge branch 'master' into mod-text
2020-01-16 20:11:51 +08:00
smoogipoo
d01cc37968
Fix channel tab control test scene
2020-01-16 18:36:27 +09:00
Andrei Zavatski
476717e181
Make OverlayHeader use colour schemes
2020-01-15 22:41:22 +03:00
Revel
443dedfd07
undo menu item capitalization
2020-01-14 14:54:06 -05:00
Revel
a86fb2113e
fix tooltip capitalization
2020-01-14 14:26:54 -05:00
mcendu
abdebcfddc
switch to changing Mod property
2020-01-14 20:11:32 +08:00
smoogipoo
1367c18d3f
General refactorings
2020-01-14 15:07:25 +09:00
smoogipoo
45dad5a9c7
Merge remote-tracking branch 'origin/master' into rankings-country-filter
2020-01-14 15:00:48 +09:00
smoogipoo
d6bd0b7106
Container -> CompositeDrawable
2020-01-14 14:43:57 +09:00
smoogipoo
33993837b7
Remove participant count (not returned by API)
2020-01-14 14:41:38 +09:00
smoogipoo
05702af905
Remove map count (not returned by API)
2020-01-14 14:37:24 +09:00
smoogipoo
7349c023d1
Cleanup spotlight selection
2020-01-14 14:01:51 +09:00
Andrei Zavatski
90e4def4bd
Remove online stuff out of the selector
2020-01-14 07:07:21 +03:00
Andrei Zavatski
b1c432179b
Merge remote-tracking branch 'refs/remotes/ppy/master' into spotlights_api
2020-01-14 06:45:54 +03:00
Dean Herbert
8059922aa4
Make gradient in NewsArticleCover be effected by hover ( #7509 )
...
Make gradient in NewsArticleCover be effected by hover
2020-01-13 15:34:46 +08:00
Dean Herbert
4ef30f6a05
Merge branch 'master' into spotlights_api
2020-01-13 12:36:13 +08:00
Andrei Zavatski
f1b4fbb844
Make gradient in NewsArticleCover be effected by hover
2020-01-12 17:38:15 +03:00
Craftplacer
7aac6deb71
Merge branch 'master' into api-chat-read
2020-01-11 19:18:50 +01:00
Craftplacer
50e357a799
Change method parameters, add detailed error message and method docs
2020-01-11 17:42:02 +01:00
Dean Herbert
9a9c01bc92
Fix user status dropdown having no padding around items ( #7491 )
...
Fix user status dropdown having no padding around items
2020-01-11 22:04:33 +08:00
Joehu
820f9f2273
Fix default button absorbing drag scroll on settings
2020-01-10 20:16:46 -08:00
Joehu
19033e0ef8
Fix user status dropdown having no padding around items
2020-01-10 19:25:33 -08:00
Andrei Zavatski
9260ea9195
Apply suggestions
2020-01-10 20:46:35 +03:00
Andrei Zavatski
2e627f4b7c
Implement InfoColumn component
2020-01-10 17:30:51 +03:00
Andrei Zavatski
474d7e92d9
Fix incorrect dropdown menu height
2020-01-10 16:41:17 +03:00
Andrei Zavatski
d48b161662
Implement basic SpotlightSelector component
2020-01-10 16:33:00 +03:00
smoogipoo
91735ff367
Update MathUtils namespace usages
2020-01-09 13:43:44 +09:00
Andrei Zavatski
0d9fb065da
Move CountryPill to it's own class
2020-01-09 00:27:22 +03:00
Andrei Zavatski
6cb763a019
Improve animations
2020-01-09 00:06:28 +03:00
Andrei Zavatski
1dbae21f98
Fix crashing test
2020-01-08 19:40:28 +03:00
Andrei Zavatski
1428952377
Implement CountryFilter component for RankingsOverlay
2020-01-08 18:59:13 +03:00
Andrei Zavatski
eb828154ee
Allow any type to be used to create TabControl
2020-01-08 00:41:52 +03:00
Andrei Zavatski
6d8f457161
Merge remote-tracking branch 'refs/remotes/ppy/master' into no-control-overlay-headers
2020-01-08 00:21:36 +03:00
Bartłomiej Dach
e0cfc2f405
Merge branch 'master' into prev-button-revamp
2020-01-07 21:49:53 +01:00
Andrei Zavatski
7dc03a1335
resetComments -> refetchComments
2020-01-07 12:30:06 +03:00
Andrei Zavatski
6adf5ba381
Use nullable long type for id value
2020-01-07 12:29:21 +03:00
Andrei Zavatski
fa0d9f8e9d
Merge remote-tracking branch 'refs/remotes/ppy/master' into view-comments-via-propery
2020-01-07 12:20:56 +03:00
Dean Herbert
fadd53106c
Merge remote-tracking branch 'upstream/master' into medals-fix
2020-01-07 13:39:42 +09:00
Dean Herbert
fd925526e2
Fix medal overlay display
2020-01-07 13:39:30 +09:00
Andrei Zavatski
e0f66928e6
Allow CommentsContainer refetch comments using a method
2020-01-07 01:07:50 +03:00
Andrei Zavatski
031bed15da
Fix comments async loading wasn't really async
2020-01-06 20:56:32 +03:00
Andrei Zavatski
9fb29cc7a7
Move medal loading to LoadComplete
2020-01-04 18:45:34 +03:00
Andrei Zavatski
0a9d14826c
Merge remote-tracking branch 'refs/remotes/ppy/master' into medals-fix
2020-01-04 18:28:17 +03:00
Dean Herbert
a756d5d95d
Fix new account registration attempting to login with email
2020-01-04 14:52:07 +09:00
Craftplacer
7cc388b5ab
Mark channel up to last message as read when switching channels
2020-01-04 00:50:12 +01:00
Andrei Zavatski
264523bc8b
Split ControllableOverlayHeader from base class
2020-01-03 23:22:19 +03:00
Andrei Zavatski
bd5140c3fa
Add missing line breaks
2020-01-03 21:20:31 +03:00
Andrei Zavatski
79a6655e1f
Use bindables for colour updates
2020-01-03 21:02:56 +03:00
Andrei Zavatski
55777c24ce
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector
2020-01-03 20:25:28 +03:00
Dean Herbert
7d79edf335
Merge remote-tracking branch 'upstream/master' into overlay-headers-update-three
2020-01-03 15:35:33 +09:00
Dean Herbert
e8567414c6
Refactor into some kind of sanity
2020-01-03 15:01:42 +09:00
smoogipoo
b54491cc82
Make sure an exception is thrown
2020-01-03 14:16:38 +09:00
Dean Herbert
132b420aaa
Fix changelog overlay hard crashing on no internet connection
2020-01-02 19:19:42 +09:00
Andrei Zavatski
904b068a15
Simplify colour setting for additional elements in OverlayRulesetTabItem
2020-01-02 13:18:18 +03:00
Andrei Zavatski
a5c23e7cf7
Remove underline from breadcrumb display
2020-01-02 11:09:47 +03:00
Dean Herbert
d1d19c2cd9
Move chevron size implementation
2020-01-02 14:26:40 +09:00
Andrei Zavatski
2d6a07e970
Fix OverlayRulesetSelector don't have default colour
2020-01-01 23:14:26 +03:00
Andrei Zavatski
b016238c16
Make ProfileRulesetSelector inherit from OverlayRulesetSelector
2020-01-01 22:55:28 +03:00
Andrei Zavatski
af248457b0
Implement OverlayRulesetSelector
2020-01-01 22:49:04 +03:00
Andrei Zavatski
19e7867aba
Make OverlayHeader non-generic
2019-12-31 18:12:03 +03:00
Andrei Zavatski
3a71abe8ff
Add xmldoc and better parameter naming
2019-12-31 17:52:41 +03:00
Andrei Zavatski
5748b60a06
Make item chevron size virtual
2019-12-30 08:26:49 +03:00
Dean Herbert
9d5d61a64d
Merge branch 'master' into overlay-headers-update-three
2019-12-30 13:42:23 +09:00
Dean Herbert
0eccfc79cc
Remove unused field
2019-12-30 11:51:33 +09:00
Dean Herbert
a03a637728
Merge branch 'master' into add-context-menu-direct-panel
2019-12-30 11:37:02 +09:00
Joehu
bcf7156882
Add context menu on direct panels
2019-12-29 11:19:46 -08:00
Joehu
39d77386a8
Fix context menus not showing on social panels
2019-12-29 10:49:28 -08:00
Andrei Zavatski
cb2b89a2c9
Fix crashing TextSceneMedalOverlay
2019-12-29 03:01:14 +03:00
Andrei Zavatski
ac2280c4ef
Implement BreadcrumbControlOverlayHeader
2019-12-28 04:57:41 +03:00
Andrei Zavatski
f2ff57d6b7
Update design of OverlayHeaderTabControl
2019-12-28 02:50:52 +03:00
Dean Herbert
9478fe5ec3
Revert to using empty container, not null
2019-12-27 13:15:55 +09:00
Andrei Zavatski
04a4821a9f
Make CreateContent a method again
2019-12-27 06:36:41 +03:00
Andrei Zavatski
2d167a5161
Some little size adjustments
2019-12-27 05:53:31 +03:00
Andrei Zavatski
bd6e603be3
Add icon for profile header
2019-12-27 04:01:33 +03:00
Andrei Zavatski
25f6517fba
Update dependency
2019-12-27 03:53:01 +03:00
Andrei Zavatski
e360aa4588
Fix TabControl wasn't on top of everything
2019-12-26 22:16:20 +03:00
Andrei Zavatski
a1c91af095
Update layout of every overlay using OverlayHeader
2019-12-26 22:09:06 +03:00
Andrei Zavatski
647c83e6c8
Add ability to not create content for headers
...
Rather than creating an empty container
2019-12-26 21:21:15 +03:00
Andrei Zavatski
ca3e8db79f
Merge dependency
2019-12-26 21:03:39 +03:00
Dean Herbert
41d99df73c
Merge branch 'master' into allow-ctrl-tabbing-on-more-tab-controls
2019-12-25 20:49:45 +09:00
Joehu
b038c192d1
Rename property to IsSwitchable
2019-12-22 19:47:47 -08:00
Joehu
1342556894
Allow ctrl tabbing navigation to chat and song select leaderboards
2019-12-21 10:48:11 -08:00
Dean Herbert
822903d5db
Update song select statistics when mod changes settings
2019-12-20 18:01:35 +09:00
Dean Herbert
656c584503
Update RestoreDefaultValueButton when default value changes
2019-12-20 13:59:01 +09:00
Dean Herbert
a46602f705
Move cancellation token construction closer to usage
2019-12-19 11:26:22 +09:00
smoogipoo
dd68106d90
Recreate panels only while loading/loaded
2019-12-19 02:21:33 +09:00
smoogipoo
007e2e80c1
Refactor to fix sorting issues
2019-12-19 02:02:57 +09:00
Dan Balasescu
37d7c984bc
Merge branch 'master' into friends-sorting
2019-12-19 01:33:03 +09:00
Dean Herbert
7831e6ed33
Implement NewsArticleCover class ( #7192 )
...
Implement NewsArticleCover class
2019-12-18 16:15:23 +09:00
Lucas A
0a278ef943
Apply review suggestions
2019-12-17 19:23:30 +01:00
Dan Balasescu
3d13fe485d
Merge pull request #7238 from huoyaoyuan/fxcop
...
Apply FxCop at game side
2019-12-17 21:29:52 +09:00
Dan Balasescu
fd2785bab3
Merge branch 'master' into fxcop
2019-12-17 20:14:45 +09:00
Andrei Zavatski
f6cde911e2
Use switch expressions
2019-12-17 13:41:28 +03:00
Andrei Zavatski
bc9177983a
Fix possible null
2019-12-17 12:50:50 +03:00
Andrei Zavatski
023892738a
Integration into overlay
2019-12-17 12:36:44 +03:00
Andrei Zavatski
8cd96acffc
CounterPill implementation
2019-12-17 12:05:35 +03:00
Huo Yaoyuan
40b43b85f1
CA1715: use prefix for generic parameters.
2019-12-17 13:00:25 +08:00
Huo Yaoyuan
09257b0c6d
CA1820: use IsNullOrEmpty.
2019-12-17 13:00:08 +08:00
Huo Yaoyuan
ecfc6dfa3d
CA1825: use Array.Empty.
2019-12-17 12:59:48 +08:00
Joehu
5af363c920
Use default placeholder text on chat channel search box
2019-12-14 12:58:13 -08:00
Lucas A
43720fbf45
Fix CI issues
2019-12-13 18:59:40 +01:00
Lucas A
e05c9426ed
Initial implementation of NewsArticleCover class
2019-12-13 18:50:49 +01:00
Dean Herbert
8052aeb238
Fix potential nullref in disposal logic
2019-12-13 21:36:50 +09:00
Dean Herbert
440a8470e1
Move available mods to global context
...
This also tidies up ModSelectOverlay and setting creation flow in general.
2019-12-13 21:36:50 +09:00
Dean Herbert
a93d57b77e
Merge branch 'master' into lighten-playfield-during-breaks
2019-12-12 11:57:21 +09:00
Dan Balasescu
9963d18d17
Add whitespace
2019-12-11 19:13:04 +09:00
Dan Balasescu
e288706802
Merge branch 'master' into rankings-overlay-refactor
2019-12-11 19:09:29 +09:00
Dean Herbert
5624b9fd3f
Fix US english
2019-12-11 13:19:13 +09:00
Dean Herbert
a37af311d0
Simplify settings update logic
2019-12-11 13:19:02 +09:00
Salman Ahmed
b93bbf81aa
Add lighten background during breaks setting
2019-12-10 15:10:35 +03:00
Dean Herbert
138b83c9ea
Merge branch 'master' into customized-mods
2019-12-10 19:13:32 +09:00
Dean Herbert
efc3b7fc9f
Merge branch 'master' into fix-settings-bindable-logic
2019-12-10 18:30:27 +09:00
Dan Balasescu
bd6a08a21b
Merge branch 'master' into apply-to-track
2019-12-10 16:15:24 +09:00
Huo Yaoyuan
c3518a2b94
Enum constraint for enum dropdown.
2019-12-09 17:45:26 +08:00
Dean Herbert
c39d2f006c
Merge branch 'master' into fix-settings-bindable-logic
2019-12-09 17:55:17 +09:00
Dean Herbert
eb074b7058
Allow mods to apply to track, not clock
2019-12-09 17:44:45 +09:00
Dean Herbert
003eef8595
Fix mod buttons being selected when drag scrolling overlay ( #7099 )
...
Fix mod buttons being selected when drag scrolling overlay
2019-12-09 12:24:48 +09:00
Dean Herbert
ad2ecf4dff
Fix key config search not clearing after pressing escape ( #7105 )
...
Fix key config search not clearing after pressing escape
2019-12-09 12:22:30 +09:00
Joehu
9974fff5cc
Make sub panel back button inherit osu button
2019-12-08 10:51:25 -08:00
Joehu
5cf35869e9
Fix key config search not clearing after pressing escape
2019-12-08 10:40:39 -08:00
Lucas A
88ec0c1486
Add missing async content loading logic to NewsOverlay
2019-12-08 18:49:58 +01:00
Dean Herbert
c2a40c574d
Split out if statement for readability
2019-12-09 02:13:47 +09:00
Joehu
e394b28799
Remove redundant transform
2019-12-08 09:12:32 -08:00
Joehu
463b6c0030
Remove whitespace
2019-12-08 09:04:34 -08:00
Joehu
8956768fe0
Fix mod buttons being selected when drag scrolling overlay
2019-12-08 08:55:45 -08:00
Andrei Zavatski
929be3e9e7
Highlight own score in BeatmapSetOverlay
2019-12-08 12:34:07 +03:00
Dean Herbert
347373a3ba
Fix test failures
2019-12-06 19:04:55 +09:00
Dean Herbert
46d055604a
Customize -> Customise
2019-12-06 18:59:45 +09:00
Dean Herbert
cf0413663d
Merge branch 'settings-source' into customized-mods
2019-12-06 18:05:39 +09:00
Dean Herbert
901eb5d996
Fix incorrect trigger logic
2019-12-06 18:03:50 +09:00
Dean Herbert
9de032e35f
Fix SettingsItem bindable logic
2019-12-06 17:10:06 +09:00
Dean Herbert
a5d5099868
Use SettingsSource for mod cusomisation
2019-12-06 17:09:48 +09:00
Dean Herbert
af35df4077
Add multiple mod testing and update test code style
2019-12-06 15:42:11 +09:00
Dean Herbert
170954bc6e
Merge remote-tracking branch 'upstream/master' into customized-mods
2019-12-06 15:31:20 +09:00
Andrei Zavatski
33737d3d89
Move tests to TestSceneRankingsOverlay due to refactoring
2019-12-05 09:53:25 +03:00
Dean Herbert
6e9157d59c
Standardise request/response handling
2019-12-05 14:29:48 +09:00
Dean Herbert
cd473f207a
Use child set, not Clear/Add
2019-12-05 14:09:33 +09:00
Dean Herbert
5f9b9631ef
Move scope/country restrictions into RankingsOverlay
2019-12-05 14:07:39 +09:00
Andrei Zavatski
f8f144b6c0
Remove pointless ScheduledDelegate
2019-12-05 05:20:22 +03:00
Andrei Zavatski
48732e49b9
Improve async logic
2019-12-05 04:20:13 +03:00
Andrei Zavatski
0560a6637c
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-refactor
2019-12-05 04:11:45 +03:00
Dan Balasescu
19c5848e73
Merge branch 'master' into decouple-legacy-score-info
2019-12-04 11:47:27 +09:00
Dan Balasescu
242e1b0b2e
Merge branch 'master' into add-missing-long-running
2019-12-04 11:29:25 +09:00
Dean Herbert
f0d49d0cdf
Decouple APILegacyScoreInfo from ScoreInfo
2019-12-03 15:31:11 +09:00
Andrei Zavatski
0ac4675546
Implement IEquatable<Country>
2019-12-01 03:52:41 +03:00
Andrei Zavatski
c451542915
Rankings overlay basic implementation
2019-11-30 03:01:07 +03:00
Dean Herbert
c49aeb08c4
Add API methods to perform requests out-of-queue
2019-11-29 20:03:14 +09:00
Dean Herbert
5dbc32f49b
Fix MedalIcon usage
2019-11-29 16:19:57 +09:00
Dean Herbert
e678fe7a77
Move potentially expensive load to BDL
2019-11-29 15:35:33 +09:00
Dean Herbert
2663e5d756
Add some more missing LongRunningLoad flags
2019-11-29 13:52:23 +09:00
Andrei Zavatski
83e3ad9e69
Make Rankings a ctor variable
2019-11-28 20:09:05 +03:00
Dean Herbert
aa9776d51a
seal and compact rows
2019-11-28 19:07:43 +09:00
Andrei Zavatski
8077c86d13
CI fixes
2019-11-27 23:58:31 +03:00
Andrei Zavatski
800bda7e81
Refactor tables to avoid code duplication
2019-11-27 23:35:02 +03:00
Andrei Zavatski
c546df8a80
Refactor API logic
2019-11-27 21:56:22 +03:00
Andrei Zavatski
2135a7fd7b
Don't use repetitive headers in each class
2019-11-27 21:46:41 +03:00
Andrei Zavatski
4cf5968026
Simplify place calculation
2019-11-27 21:39:38 +03:00
Andrei Zavatski
14c471fe5d
Move Rankings property below ctor
2019-11-27 21:37:34 +03:00
Andrei Zavatski
bb3152ac8b
Use string.empty for empty headers
2019-11-27 21:35:03 +03:00
Dean Herbert
e1302d84dd
Use string.Empty
2019-11-28 00:26:10 +09:00
Dean Herbert
4221a0126c
Merge branch 'master' into rankings-tables
2019-11-27 23:26:54 +09:00
Dean Herbert
01a37771bc
Merge branch 'master' into customized-mods
2019-11-27 19:44:32 +09:00
Huo Yaoyuan
c0fe91a84c
Merge branch 'master' into sharpen
2019-11-26 18:21:50 +08:00
Dean Herbert
1fd5ed3c0f
Change login placeholder text to ask for username
2019-11-25 21:35:25 +09:00
Dan Balasescu
92c4e8e4f6
Merge pull request #6911 from peppy/fix-spritetext-usage
...
Fix usage of SpriteText instead of OsuSpriteText
2019-11-25 12:30:45 +09:00
Dean Herbert
22bdc8435d
Increase padding on mod section title ( #6916 )
...
Increase padding on mod section title
2019-11-25 12:28:38 +09:00
Dan Balasescu
9f93727a80
Merge branch 'master' into fix-spritetext-usage
2019-11-25 12:15:05 +09:00
Dan Balasescu
ffd2ba5d7d
Merge branch 'master' into beatmap-overlay-no-supporter-filter
2019-11-25 11:51:10 +09:00
Dean Herbert
b85189f855
Merge remote-tracking branch 'upstream/master' into fix-spritetext-usage
2019-11-25 11:31:12 +09:00
Dean Herbert
45514ff660
Apply fixes
2019-11-25 11:30:55 +09:00
Berkan Diler
fccdbffa93
Use MathF instead of Math- functions when possible
...
MathF-functions are faster than the Math-counterpart and it looks cleaner, so use MathF when we cast to float or int anyway.
2019-11-25 00:45:42 +01:00
Andrei Zavatski
96533631fc
Simplify if/else statement
2019-11-24 01:29:11 +03:00
Andrei Zavatski
29b05e2939
Fix getScores can be fired twice on user change
2019-11-24 00:01:49 +03:00
Andrei Zavatski
2e161f7e99
Hook up the rest of the logic
2019-11-22 22:25:58 +03:00
Andrei Zavatski
aede1b183a
Make ScopeSelector always visible
2019-11-22 22:04:58 +03:00
Andrei Zavatski
d6c9387beb
Implement NotSupporterPlaceholder
2019-11-22 21:55:21 +03:00
Albie Spriddell
4cb09df754
increase padding
2019-11-22 18:23:48 +00:00
Dean Herbert
d0002cc1c2
Update performance logging setting
2019-11-22 19:50:30 +09:00
Dean Herbert
c2e85a2057
Apply CornerExponent fixes
2019-11-22 19:49:20 +09:00
Dean Herbert
b026197859
Add spacing
2019-11-22 18:23:48 +09:00
Dean Herbert
dad2e5c678
Improve legibility of NoScroesPlaceholder
2019-11-22 18:10:44 +09:00
Dean Herbert
16bdf4e6bd
Update english to be more readable
2019-11-22 18:07:56 +09:00
Dean Herbert
0cc1698b6d
Rename incorrectly named container
2019-11-22 18:05:12 +09:00
Andrei Zavatski
da425c93fa
Fix beatmap switch doesn't trigger scores update
2019-11-22 05:08:50 +03:00
Andrei Zavatski
dee9ffc694
Merge master with conflicts resolved
2019-11-22 04:59:46 +03:00
Dean Herbert
e170cd2892
Move private methods below
2019-11-22 10:29:16 +09:00
Dean Herbert
ced0ad404e
Merge branch 'master' into beatmap-mod-selector
2019-11-22 10:17:40 +09:00
Dean Herbert
5da5abdb05
Merge branch 'master' into prev-button-revamp
2019-11-22 02:57:22 +09:00
Dean Herbert
ab42fac43a
Improve naming
2019-11-22 02:38:31 +09:00
Andrei Zavatski
0f1a3d97c8
Naming adjustments
2019-11-21 20:34:19 +03:00
Dean Herbert
a97d760afa
Merge remote-tracking branch 'upstream/master' into menu-background-modes
2019-11-22 02:23:02 +09:00
Andrei Zavatski
c7c8527f5f
Remove OnHighlightedChanged function
2019-11-21 20:22:15 +03:00
Andrei Zavatski
e22a71c6b8
Add visual difference between hovered and selected states
2019-11-21 19:42:07 +03:00
Andrei Zavatski
23fc7b1987
Implement updateHighlighted method
2019-11-21 19:02:24 +03:00
Andrei Zavatski
984ec11a78
Make Ruleset a bindable
2019-11-21 18:56:48 +03:00
Andrei Zavatski
737c2bd1c8
Remove pointless const
2019-11-21 18:50:29 +03:00
Andrei Zavatski
458496206c
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-11-21 18:49:37 +03:00
Huo Yaoyuan
818553027b
Merge branch 'master' into sharpen
2019-11-21 23:42:46 +08:00
Dean Herbert
0d4854ac09
Add News Overlay skeleton and header ( #5726 )
...
Add News Overlay skeleton and header
Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-11-22 00:14:31 +09:00
Dean Herbert
1a6b5e8714
Implement TotalCommentsCounter component for CommentsContainer ( #6867 )
...
Implement TotalCommentsCounter component for CommentsContainer
2019-11-21 23:45:23 +09:00
Dean Herbert
76722534ec
Fix cancel button animating when entering a dialog ( #6825 )
...
Fix cancel button animating when entering a dialog
Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-11-21 23:22:17 +09:00
Dean Herbert
f173961def
Add some extra search keywords to settings ( #6893 )
...
Add some extra search keywords to settings
Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-11-21 22:51:20 +09:00
Dean Herbert
d7cb23a909
Remove redundant keyword
2019-11-21 22:51:00 +09:00
Dean Herbert
8b1fb2d5a1
Standardise keyword specifications
2019-11-21 22:35:15 +09:00
Andrei Zavatski
f066d8434c
Apply suggestions
2019-11-21 00:26:39 +03:00
Andrei Zavatski
6b3010535f
Simplify Keywords usage for SettingsSubsection
2019-11-20 21:03:31 +03:00
Andrei Zavatski
f3d9abc84a
Capitalize Bar for consistency
2019-11-20 19:57:02 +03:00
Andrei Zavatski
7d8252183e
CI fix
2019-11-20 19:42:57 +03:00
Andrei Zavatski
e820ddd3e8
Implement settings keywords
2019-11-20 19:27:34 +03:00
Berkan Diler
6cab517b2d
.NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK.
2019-11-20 13:37:47 +01:00
Huo Yaoyuan
374ef6ff83
Merge branch 'master' into sharpen
2019-11-20 17:30:58 +08:00
Huo Yaoyuan
b1b234c6fb
Use paramref.
2019-11-17 20:49:36 +08:00
Andrei Zavatski
509440ea14
TotalCommentsCounter implementation
2019-11-16 18:02:34 +03:00
Andrei Zavatski
f2862e95e0
CI fix
2019-11-15 12:15:51 +03:00
Andrei Zavatski
e51fd00d58
CI fix
2019-11-15 12:09:31 +03:00
Andrei Zavatski
18f77008db
Update dependency
2019-11-15 12:04:01 +03:00
Andrei Zavatski
9fd225bda7
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-overlay-mod-selector-new
2019-11-15 11:58:05 +03:00
Andrei Zavatski
2592a0489b
Use existing ModNoMod
2019-11-15 11:57:40 +03:00
Andrei Zavatski
1218d41b50
Make Ruleset a property
2019-11-15 11:52:49 +03:00
Andrei Zavatski
b7efc276f1
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-11-15 11:42:32 +03:00
Dean Herbert
813aebca1d
Remove unintentional dependency
2019-11-15 14:51:01 +09:00
Dean Herbert
6d06b444ba
Allow screen to specify whether to apply audio rate adjustments from mods
2019-11-15 13:47:14 +09:00
Dan Balasescu
cd9902cc9f
Merge branch 'master' into commit-on-focus-lost
2019-11-15 08:58:59 +09:00
Huo Yaoyuan
0998afdbdb
Use ReferenceEquals instead of SequenceEqual.
2019-11-14 19:38:08 +08:00
Dean Herbert
bf567e6df5
Make settings textboxes commit on focus lost
2019-11-14 14:19:55 +09:00
Andrei Zavatski
2d3fadc1a8
Don't update mod filter visibility on every beatmap change
2019-11-14 00:38:37 +03:00
Andrei Zavatski
633c497602
Hide content if beatmap has no leaderboard
2019-11-13 17:36:08 +03:00
Huo Yaoyuan
87d40cf8d0
Resolve equals usages.
2019-11-13 22:35:50 +08:00
Andrei Zavatski
d1853ea55b
Fix incorrect formatting for switch/case
2019-11-13 17:29:50 +03:00
Andrei Zavatski
8005ee73af
Trim whitespace
2019-11-13 17:23:46 +03:00
Andrei Zavatski
3f6140db6d
Improve loading animation
2019-11-13 17:18:58 +03:00
Andrei Zavatski
4e90daf212
Implement NoScoresPlaceholder
2019-11-13 16:39:33 +03:00
Andrei Zavatski
2dbee5da79
Update dependency
2019-11-13 16:06:37 +03:00
Andrei Zavatski
6715b25ddd
Apply suggestions
2019-11-13 16:04:15 +03:00
Dean Herbert
f11ad7535d
Merge branch 'master' into rankings-tables
2019-11-13 15:39:13 +09:00
Dean Herbert
230de261c8
Merge branch 'master' into fix-popup-dialog-button
2019-11-13 15:39:08 +09:00
Dean Herbert
0292cea2c4
Merge branch 'master' into beatmap-mod-selector
2019-11-13 15:39:08 +09:00
Dean Herbert
367d12aef9
Merge branch 'master' into beatmap-overlay-mod-selector-new
2019-11-13 15:39:06 +09:00
Dean Herbert
ce60f8262c
Merge branch 'master' into sharpen
2019-11-13 15:38:59 +09:00
Dean Herbert
c751328665
Disable button when not logged in
2019-11-13 12:13:33 +09:00
Andrei Zavatski
5f609b48da
Use local bindable for api.LocalUser
2019-11-13 00:29:28 +03:00
Andrei Zavatski
99ec84ed38
Update dependency
2019-11-13 00:26:19 +03:00
Andrei Zavatski
2719be7769
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-overlay-mod-selector-new
2019-11-13 00:24:40 +03:00
Andrei Zavatski
27f721eec2
Use = instead of += for OnSelectionChanged Action
2019-11-13 00:24:13 +03:00
Andrei Zavatski
3903e59f2f
Add null check for notification overlay
2019-11-13 00:01:13 +03:00
Andrei Zavatski
dfd5c88075
Typo fix
2019-11-13 00:00:08 +03:00
Ganendra Afrasya
8276428efc
Add IsPresent check when dialog popping out
2019-11-12 20:48:26 +07:00
Dean Herbert
da819261e0
Shrink and darken loading layer to better suit button
2019-11-12 21:38:16 +09:00
Dean Herbert
5110ae82a1
Tidy up implementation
2019-11-12 21:38:08 +09:00
Huo Yaoyuan
42a98c5d87
Use constants.
2019-11-12 20:07:01 +08:00
Huo Yaoyuan
ca52d09e81
Enforce expression body for typical simple ones.
2019-11-12 19:56:37 +08:00
Huo Yaoyuan
e5e8e70704
Use pattern matching.
2019-11-12 19:55:19 +08:00
Huo Yaoyuan
bbeab6fa76
Use auto property.
2019-11-12 19:53:25 +08:00
Dean Herbert
58df6930b2
Get error message from server
2019-11-12 19:34:20 +09:00
Dean Herbert
f04d7f733f
Merge remote-tracking branch 'upstream/master' into favourite-beatmap
2019-11-12 19:19:29 +09:00
Dean Herbert
a83c3523ae
Merge branch 'master' into rankings-tables
2019-11-12 18:59:43 +09:00
Andrei Zavatski
a69a4643c9
Simplify LINQ expressions
2019-11-12 08:45:21 +03:00
Andrei Zavatski
fa01e11a6e
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-11-12 08:25:42 +03:00
Dean Herbert
4516da223d
Merge branch 'master' into fix-mod-section-overflow
2019-11-12 11:35:01 +09:00
Andrei Zavatski
0578f91a76
Small logic adjustments
2019-11-11 19:06:46 +03:00
Andrei Zavatski
32cc7b3d4d
CI fix
2019-11-11 19:04:50 +03:00
Andrei Zavatski
c5b64e26a3
Layout adjustment
2019-11-11 18:51:29 +03:00
Andrei Zavatski
5f5d130d1a
Update mod filter visibility on user change
2019-11-11 18:40:57 +03:00
Andrei Zavatski
31191dadf1
Handle mods change
2019-11-11 18:31:42 +03:00
Andrei Zavatski
2cfd54ca0d
Handle scope changing
2019-11-11 18:27:48 +03:00
Andrei Zavatski
00b9229737
Add mod filter to beatmap overlay
2019-11-11 18:21:07 +03:00
Andrei Zavatski
32b2f5e330
Use Bindable for ScoresContainer
2019-11-11 18:10:25 +03:00
Andrei Zavatski
3655f88180
Merge dependency
2019-11-11 17:56:57 +03:00
Andrei Zavatski
4145e25f7b
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-11-11 17:55:10 +03:00
Huo Yaoyuan
ccc8aa6fa4
Apply brace style.
2019-11-11 20:13:13 +08:00
Dean Herbert
9db73d33cc
Remove horizontal padding on toolbar ruleset selector ( #6780 )
...
Remove horizontal padding on toolbar ruleset selector
2019-11-11 10:02:30 +09:00
Andrei Zavatski
93954c8da0
Use BindableList for selected mods
2019-11-10 23:58:07 +03:00
Andrei Zavatski
e3d8e29cdd
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-11-10 23:38:41 +03:00
Dean Herbert
5c47641608
Reorder conditional
2019-11-09 16:23:22 +09:00
Joehu
b675024161
Remove horizontal padding on toolbar ruleset selector
2019-11-08 20:28:24 -08:00
Bartłomiej Dach
70feab8316
Merge branch 'master' into prev-button-revamp
2019-11-06 22:41:33 +01:00
Andrei Zavatski
423e26a4d1
Fix header text could be sticked together
2019-11-06 13:07:25 +03:00
Andrei Zavatski
0f53725005
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-tables
2019-11-06 13:03:34 +03:00
Andrei Zavatski
4330507da8
Use api.IsLoggedIn
2019-11-06 12:46:25 +03:00
Andrei Zavatski
1f3b209a6c
Merge remote-tracking branch 'refs/remotes/ppy/master' into vote-pill-fix
2019-11-06 12:26:41 +03:00
Dean Herbert
09e9ef0e4b
Add background colour to music player ProgressBar ( #6741 )
...
Add background colour to music player ProgressBar
2019-11-06 17:44:08 +09:00
Ganendra Afrasya
02c21a1379
Make progress bar hoverable
2019-11-06 14:11:47 +07:00
Ganendra Afrasya
d985d04857
Add background colour to music player ProgressBar
2019-11-06 14:07:34 +07:00
smoogipoo
0b09fb293e
Fix background being coloured
2019-11-06 15:16:00 +09:00
Dean Herbert
a3d8738cab
Merge branch 'master' into vote-pill-fix
2019-11-06 14:52:06 +09:00
Dean Herbert
4ce3450cfc
Move button implementation to OsuButton
2019-11-06 14:08:52 +09:00
Dean Herbert
44d0791676
Update button usage
2019-11-05 16:26:31 +09:00
unknown
a92b32f6dc
add basic tests
2019-11-05 00:56:09 +08:00
unknown
1216d66a4c
Merge remote-tracking branch 'origin/customized-mods' into customized-mods
2019-11-04 23:21:45 +08:00
Joehu
fe23b9a262
Fix mod section overflowing mod select overlay at higher ui scale
2019-11-03 07:32:47 -08:00
Andrei Zavatski
48385dbdfe
Layout adjustments
2019-11-03 14:31:23 +03:00
Dean Herbert
5127b52c25
Merge remote-tracking branch 'upstream/master' into game-handles-links
2019-11-03 13:04:18 +09:00
Andrei Zavatski
1e73cf1025
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-tables
2019-11-01 21:14:09 +03:00
Dean Herbert
898520935e
Move link handling code to OsuGame
...
This allows for future calls from arguments / associations
2019-11-01 11:40:51 +09:00
Dan Balasescu
54681a6206
Merge branch 'master' into catch-api-request-exceptions
2019-11-01 11:33:23 +09:00
Dean Herbert
ce19b2ed36
Avoid using CreateChildDependencies with a *child* bindable
...
Don't do this.
2019-10-31 17:16:26 +09:00
Dean Herbert
3e3ff81229
Reorder methods
2019-10-31 17:13:00 +09:00
Dean Herbert
4f04abf282
Fix tabs to match design (should not show pinhair line)
2019-10-31 16:54:28 +09:00
Dean Herbert
5d47a2e557
Merge branch 'master' into add-beatmap-ruleset-selector
2019-10-31 16:42:32 +09:00
Dean Herbert
bf45fa6309
Use lambda function expression
2019-10-31 16:24:03 +09:00
Dean Herbert
f8187fa301
Don't rely on masking for bar display
2019-10-31 16:23:10 +09:00
Dean Herbert
923041c3f9
Merge branch 'master' into beatmap-overlay-ruleset-selector
2019-10-31 15:15:52 +09:00
Dean Herbert
0cd912fcd3
Cover all non-APIAccess APIRequest calls with exception handling
2019-10-31 15:04:13 +09:00
Andrei Zavatski
4730453083
Apply suggestions
2019-10-31 02:10:00 +03:00
Andrei Zavatski
d90545227c
Merge remote-tracking branch 'refs/remotes/ppy/master' into vote-pill-fix
2019-10-30 23:49:56 +03:00
Dan Balasescu
4322933470
Merge branch 'master' into signin-ux-improvement
2019-10-30 12:10:52 +09:00
Andrei Zavatski
8ad5ccda68
Test steps rearrangement and condition fix
2019-10-30 04:16:14 +03:00
Andrei Zavatski
2c31492bbe
Fix comment can be voted if user is null
2019-10-30 03:27:06 +03:00
Andrei Zavatski
1502a6c631
Cleanups
2019-10-30 03:09:14 +03:00
Andrei Zavatski
092d16bb64
Dont use binding to set disabled value
2019-10-29 23:43:16 +03:00
Andrei Zavatski
30d9b21b86
Condition simplification
2019-10-29 21:57:20 +03:00
Andrei Zavatski
e287dae64b
Fix VotePill can be activated by the comment sender
2019-10-29 21:25:48 +03:00
Ganendra Afrasya
5c2917d303
Place sign in button inside ShakeContainer
2019-10-30 00:50:04 +07:00
Dean Herbert
54befb6f8f
Remove adjacent day separators
2019-10-29 15:45:41 +09:00
Dean Herbert
b06e70e546
Add failing test showing issue with day separator logic
2019-10-29 15:27:08 +09:00
Dean Herbert
09a6d1184a
Tidy up order of scroll changes
2019-10-29 14:33:05 +09:00
Dean Herbert
d1c6e3f620
Add test for scroll to end when max history is exceeded
2019-10-29 14:32:52 +09:00
Andrei Zavatski
85769982a0
Refactor LoadingButton
2019-10-24 17:49:34 +03:00
Dean Herbert
967551fec0
Renames and xmldoc
2019-10-24 13:10:17 +09:00
Ganendra Afrasya
d22e12d104
Update doc
2019-10-24 10:28:23 +07:00
Ganendra Afrasya
c6d4fc8b24
Apply review
2019-10-24 08:00:45 +07:00
Ganendra Afrasya
224a887773
Merge remote-tracking branch 'origin/master' into prev-button-revamp
2019-10-24 07:44:18 +07:00
Andrei Zavatski
b310fd9d44
Adjust naming inside the LoadingButton
2019-10-23 13:39:42 +03:00
Dean Herbert
40c202c394
Merge branch 'master' into comments-vote-pill
2019-10-23 15:41:54 +09:00
smoogipoo
851773a842
Apply adjustments for framework changes
2019-10-23 14:04:06 +09:00
Joehu
7b7a87afa8
Put back mobile conditional
2019-10-22 19:51:29 -07:00
Joehu
8154cc1b16
Fix registration textboxes always focusing after pressing escape
2019-10-22 14:40:56 -07:00
Dean Herbert
e9aa7f3218
Subclass and use yellow for stand-alone chat display
2019-10-23 00:24:19 +09:00
Dean Herbert
3b4823abe7
Use foreach
2019-10-23 00:17:37 +09:00
Dean Herbert
0ba287a7fd
Rename variable
2019-10-23 00:14:22 +09:00
Dean Herbert
7084aa7b81
Merge branch 'master' into chat-day-separator
2019-10-22 15:48:42 +09:00
Dean Herbert
001eae2c02
Merge remote-tracking branch 'upstream/master' into make-most-textbox-carets-movable
2019-10-22 15:04:16 +09:00
Andrei Zavatski
09b2f11bd5
Remove unused variable
2019-10-22 03:14:20 +03:00
Andrei Zavatski
b1eac6b400
Apply suggested changes
2019-10-22 03:11:19 +03:00
Andrei Zavatski
e9ae838f46
CI fixes
2019-10-22 02:16:52 +03:00
Joehu
f7924d3bad
Rename "FixedSearchTextBox" to "SeekLimitedSearchTextBox"
2019-10-21 16:00:09 -07:00
Andrei Zavatski
2896ed90e2
Fix incorrect date comparison
2019-10-22 01:55:26 +03:00
Andrei Zavatski
bb7af1e39c
Fix some margin/padding issues
2019-10-22 01:45:04 +03:00
Andrei Zavatski
d19041fa53
Implement DaySeparator class
2019-10-22 01:30:37 +03:00
Andrei Zavatski
75f444e431
Basic implementation
2019-10-22 00:44:58 +03:00
Salman Ahmed
eed6f708a2
Merge branch 'master' into beatmap-overlay-ruleset-selector
2019-10-19 04:06:43 +03:00
Andrei Zavatski
266f9a065f
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-vote-pill
2019-10-18 19:25:05 +03:00
Dean Herbert
6b0976ff1e
Remove a weird unicode charcter from file
2019-10-18 16:55:42 +09:00
Andrei Zavatski
9daafb4636
Simplify hover/unhover logic
2019-10-18 03:06:01 +03:00
Joehu
e5b50b5e1f
Fix slider bar regression when using arrows
2019-10-17 13:54:36 -07:00
Andrei Zavatski
22511e41e2
Use received data to set isVoted bindable
2019-10-17 23:20:01 +03:00
Andrei Zavatski
9ee63a8c1a
Apply suggested changes
2019-10-17 16:28:32 +03:00
Andrei Zavatski
a858e713f8
Fix multiple spaces
2019-10-17 15:40:09 +03:00
Andrei Zavatski
6b196a6ce7
CI fixes
2019-10-17 15:24:51 +03:00
Andrei Zavatski
42cd4107a0
Implement CommentVoteRequest and adjust UI
2019-10-17 15:04:30 +03:00
Andrei Zavatski
a437ff74cc
Move VotePill to it's own file
2019-10-17 14:18:31 +03:00
Andrei Zavatski
1f28c00594
UI implementation
2019-10-17 13:10:28 +03:00
Andrei Zavatski
38dcd42d08
Parse voted comments
2019-10-17 12:35:12 +03:00
Ganendra Afrasya
326abc1a55
Apply reviews
2019-10-16 20:11:25 +07:00
Andrei Zavatski
2dac3a6efe
Handle hitting the maximum allowed number of favourited beatmaps
2019-10-16 13:58:29 +03:00
Dean Herbert
4f356f3aeb
Merge branch 'master' into favourite-beatmap
2019-10-16 18:22:09 +09:00
iiSaLMaN
60133ba0c3
Propagate BeatmapSetInfo to tab items with bindable
2019-10-15 23:33:50 +03:00
Andrei Zavatski
2543de22bd
Simplify DeletedChildrenPlaceholder behavior
2019-10-15 12:47:35 +03:00
Andrei Zavatski
7ba15df0c0
Convert to method group
2019-10-15 12:27:32 +03:00
Andrei Zavatski
d321794ef5
Make loadedTopLevelComments a local filed
2019-10-15 12:26:16 +03:00
Andrei Zavatski
96e31b9cca
Add support for deleted comments with message
2019-10-15 12:07:01 +03:00
Andrei Zavatski
213f00556d
Remove onShowDeletedChanged function
2019-10-15 11:30:50 +03:00
Andrei Zavatski
b2885e7b13
Move load() under the ctor
2019-10-15 11:26:58 +03:00
Andrei Zavatski
eb5dad08aa
Remove initial filed
2019-10-15 11:25:58 +03:00
Andrei Zavatski
3c714dc013
APICommentsController -> CommentBundle
2019-10-15 11:20:06 +03:00
Andrei Zavatski
75a2e383f2
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-15 11:19:45 +03:00
Joehu
efc201ec85
Make PlaylistOverlay a VisibilityContainer
2019-10-14 16:40:53 -07:00
Joehu
ccc753a315
Make OverlayContainers with no blocking input VisibilityContainers
2019-10-14 16:27:59 -07:00
Andrei Zavatski
ad32d66365
CI fix
2019-10-15 01:10:23 +03:00
Andrei Zavatski
0fd6b0c852
Use linq expression to count deleted comments
2019-10-15 00:55:33 +03:00
Andrei Zavatski
b84c9dfd84
Use Humanizer.ToQuantity instead of manual parsing
2019-10-15 00:35:44 +03:00
Andrei Zavatski
09621f066e
Childs -> Children
2019-10-15 00:32:21 +03:00
Andrei Zavatski
d4843285db
CI fixes
2019-10-14 17:33:14 +03:00
Andrei Zavatski
139170cdc8
Fix incorrect padding for nested comments
2019-10-14 17:26:12 +03:00
Andrei Zavatski
b53fb0d228
Remove empty line
2019-10-14 17:07:50 +03:00
Andrei Zavatski
a81d5cd819
Handle links in message
2019-10-14 16:56:07 +03:00
Andrei Zavatski
7cd3f5656d
Cleanups
2019-10-14 16:43:43 +03:00
Andrei Zavatski
7ac87494e0
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-14 16:21:34 +03:00
Dean Herbert
f0e9700349
Inline delegate event
2019-10-14 21:49:02 +09:00
Dean Herbert
b7ddf160b4
OnClick should actually handle the event
2019-10-14 21:48:12 +09:00
Dean Herbert
4e6ab1dad3
Tidy up state management via bindable usage
2019-10-14 21:42:07 +09:00
Dean Herbert
7794457550
Remove more constants
2019-10-14 21:36:10 +09:00
Dean Herbert
4822496c13
Fix more naming
2019-10-14 21:34:16 +09:00
Dean Herbert
89f270a19a
SortSelector -> SortTabControl
2019-10-14 21:32:41 +09:00
Dean Herbert
e191c2c50e
Tidy up constants and method naming
2019-10-14 21:32:16 +09:00
Andrei Zavatski
328b4d6863
Cancel request on dispose
2019-10-13 16:22:10 +03:00
Andrei Zavatski
a44cc2e70b
Implement CommentsShowMoreButton
2019-10-13 14:43:30 +03:00
Andrei Zavatski
60954f969d
DeletedChildsPlaceholder refactor
2019-10-13 12:38:50 +03:00
Andrei Zavatski
795ce81468
Use async loading for comment pages
2019-10-13 12:10:01 +03:00
Andrei Zavatski
4d971e49ff
Colours update
2019-10-13 11:50:27 +03:00
Andrei Zavatski
27e3ffd293
Update dependencies
2019-10-13 11:23:49 +03:00
Andrei Zavatski
7f867562ca
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-13 11:15:43 +03:00
Andrei Zavatski
7ffe5ac539
Merge remote-tracking branch 'refs/remotes/ppy/master' into commenst_header
2019-10-12 15:02:12 +03:00
Dan Balasescu
bb7de50697
Merge pull request #6451 from peppy/fix-resume-from-player-audio
...
Fix audio playback position being reset after resuming to song select
2019-10-11 19:44:00 +09:00
Ganendra Afrasya
3008ade8a2
Using enum to determine the action
2019-10-11 16:41:54 +07:00
Dean Herbert
475815df04
Update ranking display to handle new osu-web request format
2019-10-11 13:09:21 +09:00
Ganendra Afrasya
d7fc904381
Make prev button can do restart track
2019-10-11 00:12:36 +07:00
Andrei Zavatski
b45e7246b8
Rename SortCommentsBy to CommentsSortCriteria
2019-10-10 15:56:08 +03:00
Dean Herbert
5eba33e876
Simplify logic and add test coverage for remaining case
2019-10-10 20:12:47 +09:00
Andrei Zavatski
fe7b4037f7
CI fix
2019-10-10 13:24:22 +03:00
Andrei Zavatski
64f62bd2bf
Implement CommentsHeader component
2019-10-10 12:06:25 +03:00
Andrei Zavatski
f6b78ad661
Overall cleanups
2019-10-10 11:43:45 +03:00
Dean Herbert
e66f9adb86
Fix user pause not being cancelled when playing audio
2019-10-10 16:53:03 +09:00
Andrei Zavatski
107d39c3e9
Add DeletedChildsPlaceholder to the bottom of the comments container
2019-10-09 14:10:05 +03:00
Andrei Zavatski
c9d5bea0f1
Remove animations
2019-10-09 13:45:14 +03:00
Andrei Zavatski
7e3c97f496
Implement DeletedChildsPlaceholder component
2019-10-09 13:37:07 +03:00
Andrei Zavatski
b2bd78308d
Handle deleted comments
2019-10-09 12:18:49 +03:00
Andrei Zavatski
ad99a3236f
Handle edited comments
2019-10-09 11:32:17 +03:00
Andrei Zavatski
a0dfbfe148
Handle parent usernames for legacy comments
2019-10-09 11:18:26 +03:00
Andrei Zavatski
0a56b041fd
Implement ShowChildsButton
2019-10-09 11:07:56 +03:00
Andrei Zavatski
4462d454e8
Message padding improvements
2019-10-09 10:34:17 +03:00
Andrei Zavatski
29b0eacc82
Implement SortSelector component
2019-10-08 22:46:42 +03:00
Andrei Zavatski
574170124c
Implement HeaderButton component
2019-10-08 21:38:19 +03:00
Andrei Zavatski
b9ad079bf8
Move CommentsHeader to it's own file
2019-10-08 20:57:55 +03:00
Andrei Zavatski
9ab309fc0e
Use bold font for replies button
2019-10-08 20:44:01 +03:00
Andrei Zavatski
35cfb16c8d
Implement VotePill component
2019-10-08 19:56:43 +03:00
Andrei Zavatski
4230b00110
Rename APIComments to APICommentsController
2019-10-08 19:22:23 +03:00
Andrei Zavatski
341702b91d
Use Bindable for expansion logic
2019-10-08 19:18:46 +03:00
Andrei Zavatski
000e4a563c
Parse parent comments
2019-10-08 19:09:02 +03:00
Andrei Zavatski
3f8fecbc50
Adjust spacing
2019-10-08 16:04:52 +03:00
Andrei Zavatski
9c7e403cf8
Implement replies button
2019-10-08 16:00:34 +03:00
Andrei Zavatski
451a7342ce
Parse child comments
2019-10-08 15:39:03 +03:00
Andrei Zavatski
2564214a72
Fix some padding issues with the big comments
2019-10-08 15:01:18 +03:00
Andrei Zavatski
1c89841949
Move all the logic to it's own namespace
2019-10-08 14:51:12 +03:00
LeNitrous
9375ef5eea
clear settings controls when changing rulesets
2019-10-08 19:42:15 +08:00
Andrei Zavatski
801b5b474e
Add a User property to the comment for easy access
2019-10-08 13:45:13 +03:00
LeNitrous
59b2f02828
initial implementation of customizable mods
2019-10-08 18:34:09 +08:00
Andrei Zavatski
4b1a40daba
Implement temp fix to get the actual message
2019-10-08 13:31:49 +03:00
Andrei Zavatski
70e1d731ad
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api
2019-10-08 12:42:59 +03:00
Dean Herbert
7e4f0c01b8
Avoid excess background updates in playlist overlay ( #6424 )
...
Avoid excess background updates in playlist overlay
2019-10-08 14:11:02 +09:00
Dean Herbert
438408161c
Fix tab controls overflowing right content at max ui scale ( #6411 )
...
Fix tab controls overflowing right content at max ui scale
2019-10-08 11:16:41 +09:00
Dean Herbert
3ec78388e8
Avoid excess background updates in playlist overlay
2019-10-08 11:03:23 +09:00
Joehu
8e6e90eaec
Use fixed numbers for padding instead
2019-10-07 16:11:40 -07:00
Roman Kapustin
e00992dfd8
Remove FollowPlayback setting
2019-10-07 19:44:22 +03:00
Andrei Zavatski
cc6bf2f173
Add IsDeleted property
2019-10-07 18:45:22 +03:00
Andrei Zavatski
aa8df0fa20
Hook up api and implement some visual comments representation
2019-10-07 18:26:07 +03:00
Andrei Zavatski
e772822bd5
Basic implementation
2019-10-07 17:49:20 +03:00
Andrei Zavatski
a7dc9bb582
Add tooltip and remove pink layer
2019-10-07 15:41:05 +03:00
Andrei Zavatski
2d707b2b65
Implement PostBeatmapFavouriteRequest
2019-10-07 15:36:23 +03:00
Joehu
38c1cee5fd
Fix tab controls overflowing
2019-10-06 10:22:55 -07:00
Roman Kapustin
eda4a27b45
Move FollowPlayback setting to User Interface subsection
2019-10-06 15:06:25 +03:00
Roman Kapustin
bdea75b995
Autoscroll playlist on song change
2019-10-05 23:53:05 +03:00
iiSaLMaN
ba1a854701
Use IEnumerable.Where<>() rather than List.FindAll()
...
Saves a whole list allocation
2019-10-05 10:30:32 +03:00
iiSaLMaN
6985249d90
Simplify properties
2019-10-04 21:18:03 +03:00
iiSaLMaN
0c4f248259
Fix CI issues
2019-10-04 18:02:13 +03:00
iiSaLMaN
555c82e9c9
Filter beatmap difficulties by current ruleset
2019-10-04 17:56:42 +03:00
iiSaLMaN
7d5f5d2fd9
Add ruleset selector to the beatmap overlay header
2019-10-04 17:55:33 +03:00
iiSaLMaN
7b414092af
Implement beatmap ruleset selector
2019-10-04 17:35:41 +03:00
Dean Herbert
0dd12990c4
Fix possible nullref in MusicController ( #6379 )
...
Fix possible nullref in MusicController
2019-10-03 20:11:52 +08:00
smoogipoo
6c878cb167
Prevent nullrefs
2019-10-03 19:15:37 +09:00
smoogipoo
662a1a9c2c
Use current
2019-10-03 18:55:53 +09:00
smoogipoo
bcf0b2752e
Fix possible MusicController nullref
2019-10-03 18:48:44 +09:00
Craftplacer
4d4e846296
Merge branch 'master' into muted-notification
2019-10-02 17:31:34 +02:00
Andrei Zavatski
5274f69872
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-tables
2019-10-02 13:00:29 +03:00
Dan Balasescu
2519fd26a9
Merge pull request #6351 from Joehuu/simplify-exit-logic-of-screens
...
Simplify exit logic of screens with textboxes using back button receptor
2019-10-02 18:38:06 +09:00
Dan Balasescu
b161aa22c3
Merge branch 'master' into simplify-exit-logic-of-screens
2019-10-02 18:13:57 +09:00
HDragonHR
faf8fe132e
Change bindable int to float
2019-10-02 12:26:46 +08:00
Ganendra Afrasya
b6dd610af8
Apply reviews
2019-10-01 23:18:03 +07:00
Joehu
5f700f2ae9
Simplify exit logic of screens with textboxes using back button receptor
2019-10-01 08:26:34 -07:00
Craftplacer
4e394e0ed5
Merge branch 'master' into muted-notification
2019-10-01 17:26:11 +02:00
Ganendra Afrasya
208b9a4eba
Add new virtual float for username to timestamp padding
2019-10-01 20:47:53 +07:00
Andrei Zavatski
ff477cd56c
Remove humanized number dependency
2019-10-01 14:12:03 +03:00
Andrei Zavatski
5b09daef1a
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-tables
2019-10-01 13:54:15 +03:00
Dan Balasescu
b4da92e5a6
Merge branch 'master' into bot-profile
2019-10-01 16:26:48 +09:00
Andrei Zavatski
febe0175cd
Small cleanups
2019-09-29 15:27:29 +03:00
Andrei Zavatski
883ee9851a
Update dependencies
2019-09-29 15:02:33 +03:00
Andrei Zavatski
5314f76fda
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-tables
2019-09-29 14:58:58 +03:00
Andrei Zavatski
907f73ef8f
Merge remote-tracking branch 'refs/remotes/ppy/master' into bot-profile
2019-09-29 14:45:36 +03:00
Dean Herbert
740efa5747
Handle potential null case
2019-09-29 12:19:42 +08:00
Dean Herbert
02c1f490f1
Merge branch 'master' into muted-notification
2019-09-28 20:33:32 +08:00
iiSaLMaN
fb9f21237e
Reset track adjustments on resuming from another screen
2019-09-28 04:18:16 +03:00
Andrei Zavatski
bbaf21a69d
Tables implementation
2019-09-27 19:33:52 +03:00
Andrei Zavatski
4908cb826b
Fix line breaks
2019-09-27 09:46:11 +03:00
Andrei Zavatski
475455d7cd
Add missing line breaks
2019-09-27 09:32:46 +03:00
Andrei Zavatski
94eacbca5d
Fix Bot users have all the profile sections in ProfileOverlay
2019-09-27 09:22:25 +03:00
Dean Herbert
ff9033f9ac
Merge remote-tracking branch 'upstream/master' into muted-notification
2019-09-25 16:47:56 +09:00
LeNitrous
b8d147a3b4
introduce main menu background modes
2019-09-24 17:42:06 +08:00
Dan Balasescu
45015fc4ba
Merge branch 'master' into tournament-setup
2019-09-24 17:27:17 +09:00
Andrei Zavatski
5c4dfe0809
Apply suggested change
2019-09-23 17:05:19 +03:00
Andrei Zavatski
ffbab25358
Fix incorrect icon margin in ChangelogOverlay
2019-09-23 16:12:43 +03:00
Craftplacer
9a687ae8e2
Merge branch 'master' into muted-notification
2019-09-23 01:59:37 +02:00
Dean Herbert
b41ac543c5
Allow changing logged in user
2019-09-23 04:46:50 +09:00
Dean Herbert
a76771e696
Add support for "additions" in changelog ( #6177 )
...
Add support for "additions" in changelog
2019-09-21 22:27:18 +09:00
Andrei Zavatski
befdd140f4
Reverse padding changes
2019-09-20 23:50:19 +03:00
Andrei Zavatski
e7118a9272
Use System mod type for NoMod
2019-09-20 23:47:21 +03:00
Lucas A
5663e3e6b3
Fix escaped html strings not being unescaped in changelog entries.
2019-09-19 20:08:14 +02:00
Andrei Zavatski
daa64f1be7
Adjust icon padding
2019-09-19 20:53:06 +03:00
Andrei Zavatski
573da7b1e7
Implement ChangelogEntryType
2019-09-19 20:34:37 +03:00
Andrei Zavatski
0cf4db899f
Few cleanups
2019-09-19 17:03:52 +03:00
Andrei Zavatski
efea8be97d
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-09-19 17:03:00 +03:00
Andrei Zavatski
529a1c3b91
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-09-19 16:46:58 +03:00
Dean Herbert
50d4206c45
Fix exit scenarios
2019-09-19 20:17:58 +09:00
Dean Herbert
ead3ee3b41
Merge branch 'master' into hold-to-press-setting
2019-09-19 20:05:14 +09:00
Dan Balasescu
027d6194f2
Merge branch 'master' into add-hit-lighting
2019-09-19 18:07:29 +09:00
Dean Herbert
39a5a3eebe
Merge remote-tracking branch 'upstream/master' into hold-to-press-setting
2019-09-19 16:26:14 +09:00
Dean Herbert
177a789d79
Add setting to adjust hold-to-confirm activation time
2019-09-19 14:06:25 +09:00
smoogipoo
4b97327b37
Cleanup draggedItem usages and make them more safe
2019-09-19 13:53:52 +09:00
smoogipoo
0644443979
Use resolved attribute for music controller
2019-09-19 13:51:50 +09:00
Andrei Zavatski
647433a8d1
Don't trigger request if there are no avaliable users
2019-09-19 04:09:14 +03:00
Andrei Zavatski
44412f9ddb
Fix local sorting calls an online request
2019-09-19 03:35:56 +03:00
Andrei Zavatski
9a81a44134
Merge remote-tracking branch 'refs/remotes/ppy/master' into friends-sorting
2019-09-19 03:22:53 +03:00
Dean Herbert
91bdece9af
Localise OrderChanged handling and fix callbacks
...
The dragged item's position now only updates after the drag finishes. Local handling changes were required to ignore the bindable remove/add events that are fired as a result.
2019-09-18 13:15:39 +09:00
Dean Herbert
7e791f7cd7
Expose as IBindableList
2019-09-18 13:14:33 +09:00
Dean Herbert
18fd82e83a
Merge remote-tracking branch 'upstream/master' into randomise-song-playback
2019-09-18 13:14:08 +09:00
Dean Herbert
63cc8d4f90
Add hit lighting setting
2019-09-18 02:16:57 +09:00