1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 10:23:21 +08:00
Commit Graph

703 Commits

Author SHA1 Message Date
Dean Herbert
ca7fd57ec2
Merge pull request #9826 from bdach/spinner-rotation-clock-rate 2020-08-11 10:43:55 +09:00
Bartłomiej Dach
cca78235d5 Replace CumulativeRotation with RateAdjustedRotation 2020-08-10 23:02:06 +02:00
Bartłomiej Dach
5d63b5f6a5 Add failing test cases 2020-08-10 23:02:01 +02:00
Bartłomiej Dach
61f1c4fe62 Extract replay-transforming helper test method 2020-08-10 19:51:00 +02:00
dependabot-preview[bot]
d7de8b2916
Bump Microsoft.NET.Test.Sdk from 16.6.1 to 16.7.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.6.1 to 16.7.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.6.1...v16.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-10 17:17:07 +00:00
smoogipoo
5002d69f69 Update inspections 2020-08-07 20:51:56 +09:00
smoogipoo
5c05fe3988 Expose track from MusicController 2020-08-06 16:24:14 +09:00
smoogipoo
6e42b8219c Move track to MusicController, compiles 2020-08-06 16:24:14 +09:00
Dean Herbert
3b15a50f0d Fix unnecessary + character 2020-08-06 12:34:42 +09:00
Dean Herbert
d5324be07d Fix malformed testcase 2020-08-06 12:33:40 +09:00
Dean Herbert
bb73489ae5 Fix very short spinners being impossible to complete 2020-08-05 18:46:58 +09:00
Bartłomiej Dach
efb08aeed3 Switch unnecessary wait steps to asserts 2020-08-02 14:54:41 +02:00
Bartłomiej Dach
f412808331 Check rotation with bigger tolerance to account for damp 2020-08-02 13:26:48 +02:00
Dean Herbert
fb74195d83 Move InputManager implementation to base skinnable test scene class 2020-07-31 10:45:10 +09:00
Dean Herbert
023feaf438 Refactor to centralise implementation into a single component
Turns out this is a better way forward.
2020-07-29 22:31:52 +09:00
Dean Herbert
d01d1ce3f1 Add initial support for spinner disc skinning 2020-07-29 16:25:10 +09:00
Dean Herbert
c3c60334ec Add skinning support to spinner test scene 2020-07-29 15:35:08 +09:00
Dean Herbert
afceab685b
Merge pull request #9688 from peppy/less-spinner-bonus-score
Reduce spinner tick and bonus score
2020-07-28 14:21:48 +09:00
Dean Herbert
dc577aa6fa Fix display of bonus score 2020-07-28 11:22:58 +09:00
Bartłomiej Dach
7ad3101d08 Bring back custom fade-out delay if hit lighting is on 2020-07-27 19:21:01 +02:00
Bartłomiej Dach
bbc7d69524 Add failing test cases 2020-07-27 19:07:21 +02:00
Dean Herbert
06c4fb7171 Update bonus score spec in test 2020-07-27 18:40:53 +09:00
Dean Herbert
0050f6348f
Merge branch 'master' into add-spinner-bonus-score 2020-07-23 23:05:04 +09:00
Dean Herbert
acff270e96 Fix failing test by moving slider closer 2020-07-23 19:14:18 +09:00
Dean Herbert
a4680d7a89 Reduce test range as to not hit spin cat 2020-07-21 19:22:42 +09:00
Dean Herbert
35d53139e7 Merge branch 'master' into add-spinner-bonus-score 2020-07-21 11:21:17 +09:00
Dean Herbert
55d921ef85 Improve feel of animation 2020-07-20 17:22:30 +09:00
smoogipoo
9f7750e615 Add texture wrapping support to skins 2020-07-17 16:54:30 +09:00
Dean Herbert
8411a36a0f
Merge pull request #9545 from smoogipoo/reset-judgement-animation 2020-07-14 07:35:53 +09:00
dependabot-preview[bot]
8087a75c35
Bump NUnit3TestAdapter from 3.15.1 to 3.17.0
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.15.1 to 3.17.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.15.1...V3.17)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-13 17:22:39 +00:00
smoogipoo
53520ec7c4 Add test 2020-07-13 21:21:59 +09:00
Dean Herbert
b68a2d885c Add testability against different background colours / with user input 2020-07-10 14:47:26 +09:00
Dean Herbert
fee19753e1 Fix animations not playing correctly in test scene due to too many calls to OnPressed 2020-07-10 14:47:11 +09:00
Dean Herbert
13618915b7 Don't show cursor guide in gameplay cursor test 2020-07-10 14:46:49 +09:00
Dean Herbert
efb2c2f4ae Rename variable to be more clear on purpose 2020-07-09 12:01:00 +09:00
Bartłomiej Dach
31a1f8b9a7 Add coverage for spinning in both directions 2020-07-08 22:37:45 +02:00
Bartłomiej Dach
37ecab3f2f Add assertions to make spinner tests fail 2020-07-08 21:09:27 +02:00
smoogipoo
b3e200ee7f Re-invert test 2020-06-22 21:00:35 +09:00
smoogipoo
261adfc4e6 Create a local playable beatmap instead 2020-06-22 18:38:41 +09:00
smoogipoo
863666f7c4 Move accuracy heatmap to osu! ruleset, rename, remove magic number 2020-06-19 21:14:31 +09:00
Dean Herbert
0b6e8783d4
Merge branch 'master' into test-scene-create-ruleset 2020-06-12 17:06:27 +09:00
Dean Herbert
7dc19220e5 Apply new resharper formatting fixes 2020-06-09 23:38:54 +09:00
Salman Ahmed
741fa20149
Use CreateRuleset() for editor test scenes as well 2020-06-04 00:47:10 +03:00
Salman Ahmed
611f64fd36
Add base ready-made abstract scene for osu! mod tests 2020-06-03 23:24:00 +03:00
Salman Ahmed
84b40ea2c6
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
# Conflicts:
#	osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
#	osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
#	osu.Game/Tests/Visual/ModTestScene.cs
#	osu.Game/Tests/Visual/OsuTestScene.cs
2020-06-03 22:00:02 +03:00
Dean Herbert
c46bfc2532 Create SnapResult class to hold various snapping results 2020-05-20 21:00:47 +09:00
Dean Herbert
3354d48a38 Change snapping to be screen space coordinate based 2020-05-20 21:00:29 +09:00
smoogipoo
648999a2de Remove all RequiredTypes usages 2020-05-16 18:17:12 +09:00
smoogipoo
efff2bf15d Add HitObject to DefaultsApplied event 2020-05-08 18:49:19 +09:00
dependabot-preview[bot]
03863d901b
Bump Microsoft.NET.Test.Sdk from 16.5.0 to 16.6.1
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.5.0 to 16.6.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.5.0...v16.6.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-27 08:59:09 +00:00
Salman Ahmed
227503c0af
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset 2020-04-23 16:25:33 +03:00
Salman Ahmed
2fa47992dc
Seal the ruleset creation methods and let abstract method take their place
Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers
2020-04-23 13:27:12 +03:00
smoogipoo
8d5732aabd Make placements happen on mouse down 2020-04-23 12:17:11 +09:00
Dean Herbert
5a2129da7c
Merge branch 'master' into allow-cancelling-completion 2020-04-21 11:22:37 +09:00
Dan Balasescu
eb7b04d8bc
Merge branch 'master' into fix-osu-hidden-mod-alt 2020-04-20 17:47:27 +09:00
Salman Ahmed
4c945b5feb Merge remote-tracking branch 'upstream/master' into allow-cancelling-completion 2020-04-20 06:43:30 +03:00
Salman Ahmed
fc6c245de5 Replace all judged event logic with HasCompleted bindable 2020-04-19 05:36:04 +03:00
Salman Ahmed
155bc8b49a Remove ModTestScene ruleset parameter on constructor and use CreateRuleset instead 2020-04-17 11:17:59 +03:00
Salman Ahmed
92df4e3a9e Remove PlayerTestScene constructor and use CreateRuleset method instead 2020-04-17 11:17:51 +03:00
Salman Ahmed
5fa6bcb5a3 Move SkinnableTestScene into using the global CreateRuleset method 2020-04-17 11:17:44 +03:00
smoogipoo
08df9d49e5 Add failing test 2020-04-17 14:12:43 +09:00
smoogipoo
ee5301b887 Fix head/tail circles not getting correct hit windows 2020-04-17 14:12:38 +09:00
Dean Herbert
9dda7da489 Fix spinners being considered the "first object" for increased visibility in hidden 2020-04-16 14:11:38 +09:00
Dean Herbert
63de493c85
Merge branch 'master' into fix-red-point-placement 2020-04-13 20:56:50 +09:00
smoogipoo
9a65aa18d7 Fix connections hidden due to overlapping controlpoints 2020-04-13 16:13:14 +09:00
smoogipoo
bde0b259c1 Improve slider placement test scene 2020-04-13 15:31:54 +09:00
smoogipoo
15a92d1451 Rename test scene 2020-04-10 03:07:44 +09:00
smoogipoo
a2f5a469cf Merge branch 'master' into add-notelock 2020-04-10 01:18:54 +09:00
Dean Herbert
0a340bac5a Ensure the correct (up-to-date) ruleset is retrieved 2020-04-07 16:20:13 +09:00
Dean Herbert
2c840c52a3 Add skinnable test scene per ruleset to better allow dynamic compilation 2020-04-07 16:20:13 +09:00
Bartłomiej Dach
3ff27816be Trim excess newlines 2020-04-05 15:54:50 +02:00
Bartłomiej Dach
25c9674487 Rename method to justify its existence better 2020-04-05 15:54:15 +02:00
Bartłomiej Dach
f9e44ae53e Bring back comment about AlmostEquals 2020-04-05 15:53:56 +02:00
Bartłomiej Dach
7135c99746 Final cleanups 2020-04-05 15:39:32 +02:00
Bartłomiej Dach
c817cc726a Rewrite repeat arrow test 2020-04-05 15:37:31 +02:00
Bartłomiej Dach
cbc546905f Rewrite snaking tests 2020-04-05 15:26:32 +02:00
Bartłomiej Dach
4170c210b2 Centralise hitobject start time calculation 2020-04-05 13:50:27 +02:00
Bartłomiej Dach
d68c45e22b Use ElementAt() where applicable 2020-04-05 13:47:30 +02:00
Endrik Tombak
8d3e228f78 Split and rename tests 2020-04-05 11:22:52 +03:00
Endrik Tombak
0ebb5a81f9 Fix oversight in testing 2020-04-04 15:59:39 +03:00
Endrik Tombak
8eb5eeedc6 Merge branch 'master' of https://github.com/ppy/osu into test-snaking 2020-04-04 15:35:43 +03:00
Endrik Tombak
a8a52e506d Review and style changes 2020-04-04 15:35:35 +03:00
Endrik Tombak
c3f0ef1bd4 Major DRYing of code 2020-04-04 15:10:54 +03:00
Dean Herbert
a3d4212462 Fix weird slider ball sizing 2020-04-02 19:56:33 +09:00
smoogipoo
1ff60b73d7 Refactor tests a bit 2020-03-30 17:01:29 +09:00
smoogipoo
e074c3e5e9 Add additional tests 2020-03-30 16:15:07 +09:00
smoogipoo
b9277165f7 Refactor test to support custom hitobjects 2020-03-30 15:12:12 +09:00
smoogipoo
3f8fbebbb4 Merge branch 'master' into add-notelock 2020-03-30 15:01:39 +09:00
Dan Balasescu
a0b8243f4c
Merge branch 'master' into slider-start-circle 2020-03-30 14:49:17 +09:00
Endrik Tombak
ce2fa23baf Include a test for miss 2020-03-29 17:43:18 +03:00
Endrik Tombak
11826800fb Test slider snaking 2020-03-29 17:00:26 +03:00
Dean Herbert
fb4b334ce2 Add support for legacy skin sliderstartcircle / sliderstartcircleoverlay 2020-03-28 14:10:26 +09:00
杜Nate
9ea0137b01
Merge branch 'master' into spun-out 2020-03-23 18:13:53 +08:00
Dean Herbert
0b728f483f Rename base test class to help avoid incorrect reference 2020-03-23 10:01:33 +09:00
Salman Ahmed
97076325c4 Fix test scenes using framework-testing-specifc test scene 2020-03-23 01:45:13 +03:00
smoogipoo
12a48d2774 Cause all earlier hitobjects to get missed 2020-03-19 19:16:24 +09:00
smoogipoo
f285b43a74 Allow simultaneous hitobjects 2020-03-19 17:45:08 +09:00
Dean Herbert
3489514b65 Fix tests asserting incorrectly 2020-03-19 17:15:53 +09:00
Dean Herbert
08b5ab8ec4 SliderRepeatPoint -> SliderRepeat 2020-03-19 14:42:02 +09:00
Dean Herbert
94c3ffb6e5 Fix slider ticks contributing to accuracy 2020-03-19 14:36:15 +09:00
smoogipoo
80a86102b6 Add test 2020-03-18 17:00:48 +09:00
Dean Herbert
0be423183d Rename data class 2020-03-11 00:36:56 +09:00
Dean Herbert
66a0f3334d
Merge branch 'master' into fix-perfect-judgements 2020-03-10 23:50:57 +09:00
smoogipoo
678f33eea3 Add late miss judgements 2020-03-10 15:45:21 +09:00
smoogipoo
9d5327b1ac Fix osu! shaking instead of missing for early hits 2020-03-10 15:00:23 +09:00
Bartłomiej Dach
d5dda05d98 Merge branch 'master' into fix-perfect-judgements 2020-03-08 14:06:18 +01:00
Bartłomiej Dach
b608764554 Cover area just outside circle in test 2020-03-06 22:09:02 +01:00
Bartłomiej Dach
491840b17d Add failing tests 2020-03-06 21:10:23 +01:00
Dean Herbert
5b8aaba4a6 Merge branch 'master' into fix-perfect-judgements 2020-03-06 00:18:05 +09:00
Dean Herbert
583e2c3f4a Actually check rate is applied 2020-03-06 00:10:05 +09:00
Dean Herbert
2b89fb68f7
Merge branch 'master' into fix-testscene-rate 2020-03-05 23:38:33 +09:00
Dean Herbert
9a12909f09 Test ModDifficultyAdjust is actually taking effect 2020-03-05 11:55:20 +09:00
Dean Herbert
26ce0d05d6 Use autoplay mod rather than local replay provider 2020-03-05 11:33:30 +09:00
Dean Herbert
77fddcd2c2 Merge branch 'less-test-players' into mod-testscene 2020-03-05 11:26:33 +09:00
Dean Herbert
5200633f9f Centralise TestPlayer implementations as much as possible 2020-03-05 11:25:07 +09:00
Dean Herbert
fadebcdc03 Move all sets to object initialiser for code formatting reasons 2020-03-05 10:21:25 +09:00
Dean Herbert
3b19467ead ModTestCaseData -> ModTestData 2020-03-05 10:19:42 +09:00
Dean Herbert
0f1f1d1a6b Remove unused "name" parameter 2020-03-05 10:18:37 +09:00
Dean Herbert
2a581ef247 Remove required types 2020-03-05 10:15:17 +09:00
Dean Herbert
ce3786cfd9 Rename to ModTestScene (is no longer a sandbox) 2020-03-05 10:11:27 +09:00
杜Nate
cf88e3ff19
Merge branch 'master' into spun-out 2020-03-04 17:38:35 +08:00
voidedWarranties
c3f840cc1a Fix Autoplay = false and AllowFail behavior 2020-03-03 17:12:01 -08:00
smoogipoo
5e218697c5 Use stacked positions 2020-03-04 09:46:53 +09:00
smoogipoo
d11d29c1f7 Adjust namespaces 2020-03-03 15:30:53 +09:00
smoogipoo
cc5b44e466 Add test scene 2020-03-03 13:36:55 +09:00
smoogipoo
6d939e9d41 Add failing test scenes 2020-03-02 12:42:48 +09:00
smoogipoo
ce7cbf29ca Move to using test methods for better separation 2020-03-02 12:20:25 +09:00
smoogipoo
239cfddcbb Improve test scenes/cases 2020-03-02 10:50:41 +09:00
smoogipoo
a02c5710ac Rename base class 2020-03-02 10:06:49 +09:00
voidedWarranties
089ec4c792 Test scene for mod development 2020-02-29 21:16:28 -08:00
Dean Herbert
06fcb48d65 Move SkinnableTestScene to main project for consumption by other rulesets 2020-02-17 14:19:39 +09:00
Dean Herbert
884a5fbad4 Fix osu! gameplay cursor not adjusting to mod/convert circle size changes 2020-02-14 14:30:15 +09:00
Bartłomiej Dach
403c03841d Decouple test scene & add assertions 2020-02-10 21:40:21 +01:00
dependabot-preview[bot]
48781e5685 Bump Microsoft.NET.Test.Sdk from 16.4.0 to 16.5.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.4.0...v16.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 08:24:12 +00:00
杜Nate
8d480c794a
Merge branch 'master' into spun-out 2020-02-08 13:54:39 +08:00
mcendu
715608c798 Fix test applying incorrect mod 2020-02-08 10:49:49 +08:00
mcendu
204c2f0bde add tests 2020-02-08 10:16:04 +08:00
Dean Herbert
7460018cd3 Move combo colours to GlobalSkinColours 2020-02-07 14:58:07 +09:00
Dean Herbert
84fcf45aae Make slider tracking match what is on screen 2020-02-03 11:55:14 +09:00
Dean Herbert
9426f786e9 Use slightly closer values 2020-02-03 10:33:56 +09:00
Dean Herbert
2253ed4c0d Move path length to a constant 2020-02-03 10:29:40 +09:00
Dean Herbert
edb4c0f752 Add blank lines for conformity 2020-02-03 10:24:53 +09:00
TheWildTree
017ce3d1ec Merge branch 'fix-follow-circle' of https://github.com/TheWildTree/osu into fix-follow-circle 2020-02-02 21:25:44 +01:00
TheWildTree
162a3713a3 Modify tests to avoid fails in CLI testing 2020-02-02 21:25:35 +01:00
Tree
c7f1d4a8a0
Remove unnecessary newline 2020-02-02 19:29:26 +01:00
TheWildTree
fd7fccbb62 Add tests 2020-02-02 19:16:54 +01:00
Dean Herbert
f8aee122b6 Merge remote-tracking branch 'upstream/master' into exit-all-screens-centrally 2020-01-31 22:09:12 +09:00
Dean Herbert
97c3ce132b Fix incorrect nUnit adapter version causing rider failures 2020-01-31 15:01:37 +09:00
Dean Herbert
e6783b622d Fix incorrectly build tests 2020-01-31 14:56:42 +09:00
smoogipoo
91735ff367 Update MathUtils namespace usages 2020-01-09 13:43:44 +09:00
dependabot-preview[bot]
f91637e7b6
Bump NUnit3TestAdapter from 3.15.1 to 3.16.0
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.15.1 to 3.16.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.15.1...V3.16)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-06 07:41:37 +00:00
Dan Balasescu
8a85875cbf
Merge branch 'master' into add-spinner-bonus-score 2020-01-03 18:08:26 +09:00
Dan Balasescu
c07cfce3b3
Merge branch 'master' into resource-assembly 2020-01-03 17:56:25 +09:00
smoogipoo
8c378dc625 Move EditorBeatmap construction/conversion to Editor 2019-12-30 14:51:14 +09:00
Huo Yaoyuan
1b33581667 Construct DllResourceStore with assemblies 2019-12-28 21:13:18 +08:00
smoogipoo
6069d98ced Remove generic editor beatmap 2019-12-27 19:39:30 +09:00
Dean Herbert
504a55e803
Merge branch 'master' into better-beatmap-conversion 2019-12-25 19:52:06 +09:00
Dean Herbert
3485ef33a7 Rename tests and add missing coverage 2019-12-25 15:05:08 +09:00
Dean Herbert
9090d13e05 Simplify tests 2019-12-25 15:01:05 +09:00
Dean Herbert
04cbdd9c6c Make test easier to visually examine 2019-12-25 14:55:13 +09:00
smoogipoo
c766477abc Fix testcase containing bad hitobject 2019-12-23 19:08:16 +09:00
Salman Ahmed
a6632cf1ef Remove unnecessary skin requester and user-skin providing container 2019-12-21 12:53:05 +03:00
Salman Ahmed
55be4478aa Merge remote-tracking branch 'upstream/master' into fallback-to-skin-combo-colours 2019-12-21 12:36:09 +03:00
Salman Ahmed
8d0dd1497b Add legacy beatmap skin test scene with combo colours tests 2019-12-21 12:30:30 +03:00
Dean Herbert
419656cea4
Merge branch 'master' into add-spinner-bonus-score 2019-12-20 19:55:53 +09:00
Dean Herbert
492a910671 Update missed launch configurations 2019-12-20 19:08:05 +09:00
Huo Yaoyuan
351e826120 Upgrade project targets to netcoreapp3.1 2019-12-20 17:03:54 +08:00
Dean Herbert
d4a4efb734 Tidy up test 2019-12-18 16:07:14 +09:00
Salman Ahmed
f359a79b7e Add test ensuring correct SPM calculation on rewinding 2019-12-18 03:08:05 +03:00
Salman Ahmed
12a02cf6d9 Extend spinner duration a bit
To allow the times sought to be in the spinner time range
2019-12-18 03:07:06 +03:00
Dean Herbert
88ce4c12f0 Merge remote-tracking branch 'upstream/master' into add-spinner-bonus-score 2019-12-17 14:09:28 +09:00
Dean Herbert
6e1f10ad8d Merge remote-tracking branch 'upstream/master' into add-old-skin-to-osu-tests 2019-12-17 13:56:01 +09:00
Dean Herbert
9875fcea99 Add numbers to old skin for better identification 2019-12-17 13:54:25 +09:00
Huo Yaoyuan
c457571da6 Use index and range expressions 2019-12-15 20:17:35 +08:00
Dean Herbert
bc31146560 Mods -> SelectedMods 2019-12-13 21:45:38 +09:00
Dean Herbert
7033974733 Fix test regressions (incorrect from the start) 2019-12-13 20:13:32 +09:00
Salman Ahmed
c6cbf0f28a Add 1.0 skin to osu! ruleset test 2019-12-12 16:27:11 +03:00
Dean Herbert
06352a95be Merge remote-tracking branch 'upstream/master' into add-spinner-bonus-score 2019-12-11 20:02:51 +09:00
smoogipoo
3358ab9f8a Adjust diffcalc test expected value
The difference is caused by the reworked calculateLength() of SliderPath. This comes as a result of the increased accuracy of path lengthenings due to calculating the final position relative to the second-to-last point, rather than relative to the last point.
2019-12-06 15:53:01 +09:00
smoogipoo
3ebbf62b2a Initial game-wide update with the new SliderPath 2019-12-05 19:53:36 +09:00
Huo Yaoyuan
c0fe91a84c Merge branch 'master' into sharpen 2019-11-26 18:21:50 +08:00
Dean Herbert
709ec1404f Centralise End/StartTime retrieval to extension method 2019-11-25 19:09:14 +09:00
Dean Herbert
45514ff660 Apply fixes 2019-11-25 11:30:55 +09:00
Huo Yaoyuan
4cd7d67fe4 Use early return for if-pattern-matching. 2019-11-22 00:02:40 +08:00
Dean Herbert
8d1b11d4bd Add storyboard lead-in tests 2019-11-21 18:50:54 +09:00
Huo Yaoyuan
144812669d Use static local functions. 2019-11-12 19:56:54 +08:00
Huo Yaoyuan
dcfa98414f Use ??=. 2019-11-12 19:56:51 +08:00
Huo Yaoyuan
e5e8e70704 Use pattern matching. 2019-11-12 19:55:19 +08:00
Dean Herbert
b37bf4ea01 Merge remote-tracking branch 'upstream/master' into selection-hitsound-addition 2019-11-12 10:44:53 +09:00
Huo Yaoyuan
ccc8aa6fa4 Apply brace style. 2019-11-11 20:13:13 +08:00
Dan Balasescu
1c1a49011b
Merge branch 'master' into infrastructure 2019-11-08 19:10:49 +09:00
smoogipoo
df31acb294 Fix slider nested hitobject samples not getting updated 2019-11-08 15:43:34 +09:00
smoogipoo
6fc1be64c2 Make hitobject samples a bindable list 2019-11-08 14:04:57 +09:00
dependabot-preview[bot]
f2084df0bb
Bump Microsoft.NET.Test.Sdk from 16.3.0 to 16.4.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.3.0 to 16.4.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.3...v16.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-07 06:19:49 +00:00
Dean Herbert
41a8954b81
Refactor follow points to support dynamic updates (#6721)
Refactor follow points to support dynamic updates

Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-11-06 17:43:58 +09:00
Dean Herbert
ee544e174a Group -> Connection 2019-11-06 16:33:42 +09:00
smoogipoo
b83ceab1c1 Add tests 2019-11-06 16:20:13 +09:00
smoogipoo
020b08b450 Initial implementation of limited distance snap 2019-11-06 15:27:48 +09:00
smoogipoo
d028603769 Rename tests 2019-11-05 22:50:01 +09:00
smoogipoo
f2118b0eba Add automated test cases 2019-11-05 19:31:58 +09:00
smoogipoo
712253ff50 Replace follow point renderer with new implementation 2019-11-05 17:33:02 +09:00
smoogipoo
bfe7309964 Fix nullref 2019-11-05 17:33:02 +09:00
smoogipoo
02a7f92d18 Allow constructing arbitrary hitobject types 2019-11-05 17:33:02 +09:00
smoogipoo
e0ba35db75 Implement binding to hitobjects + refreshing 2019-11-05 17:33:02 +09:00
smoogipoo
c0badf1dce Type to DrawableOsuHitObject 2019-11-05 17:33:02 +09:00
smoogipoo
513ad96adf Cleanup property 2019-11-05 17:33:02 +09:00
smoogipoo
f861d8099c Remove unnecessary class 2019-11-05 17:33:02 +09:00
smoogipoo
c1850b2353 Add some basic tests 2019-11-05 17:33:02 +09:00
smoogipoo
7e60bc7240 Fix groups having 0 size 2019-11-05 17:33:02 +09:00
smoogipoo
861268eb1d Add basic structure for new follow point renderer 2019-11-05 17:33:02 +09:00
smoogipoo
20aeb7aaff Implement multiple selection 2019-10-31 17:25:30 +09:00
smoogipoo
cfdf710676 Add test 2019-10-31 16:51:58 +09:00
Huo Yaoyuan
8d290a3242 Resolve CS0067. 2019-10-30 23:43:13 +08:00
Dean Herbert
8069674824 Merge remote-tracking branch 'upstream/master' into bindable-control-points 2019-10-28 11:52:04 +09:00
Dean Herbert
e987db37ec Add grouping of ControlPoints 2019-10-25 19:52:02 +09:00
smoogipoo
ae011e8ee8 Fix distance snap grid test scenes 2019-10-25 17:25:46 +09:00
smoogipoo
607b4d874a Refactor flow of snapping through HitObjectComposer 2019-10-25 16:40:30 +09:00
smoogipoo
d83b9ef0e4 Rename grid snapping methods 2019-10-24 18:18:04 +09:00
Dean Herbert
fa9690d16c
Merge pull request #6582 from smoogipoo/grid-centre
Show centre point of distance snap grid
2019-10-23 18:28:05 +09:00
Dean Herbert
02efd0e943
Merge pull request #6556 from smoogipoo/fix-slider-stack-change
Fix sliders not moving with stacking changes
2019-10-23 17:48:06 +09:00
smoogipoo
97383b4a37 Show centre point of distance snap grid 2019-10-23 16:58:56 +09:00
smoogipoo
38c2c328ff Rename HitObject -> DrawableObject in selection blueprints 2019-10-21 17:04:56 +09:00
smoogipoo
5f8d46f666 Fix sliders not moving with stacking change 2019-10-21 16:24:06 +09:00
smoogipoo
96649e0a6a Fix selection blueprints not respecting stacking 2019-10-21 15:03:49 +09:00
Dean Herbert
f92331531c Rename grid to DistanceSnap to be more in line with its purpose 2019-10-17 15:32:02 +09:00
iiSaLMaN
a8514ecd0f Add tests ensuring correct spinner ticks score results 2019-10-14 00:43:46 +03:00
iiSaLMaN
c8593f1215 Merge remote-tracking branch 'upstream/master' into add-spinner-bonus-score 2019-10-13 23:04:05 +03:00
smoogipoo
45835f97a1 Split out grids into separate files 2019-10-11 18:41:17 +09:00
smoogipoo
4d32a8aa6b More tests 2019-10-11 18:41:17 +09:00
smoogipoo
6301f837e0 Initial implementation of osu! beat snapping grid 2019-10-11 18:41:17 +09:00
Dean Herbert
5d6648d9c9 Update 2.2 references 2019-10-10 17:45:38 +09:00
Dean Herbert
179cde917b
Merge branch 'master' into rework-selection-updates 2019-10-06 15:00:56 +08:00
smoogipoo
2d0c522398 Remove unused method 2019-10-03 18:43:46 +09:00
Dean Herbert
6268bbcfc8
Merge branch 'master' into beatmap-parsing-fallback-v2 2019-10-03 15:12:21 +08:00
smoogipoo
90ad1c5166 Add more tests for slider selection blueprint 2019-10-01 19:33:27 +09:00
smoogipoo
ba5c9547e1 Add more tests for hitcircle selection blueprint 2019-10-01 19:33:15 +09:00
smoogipoo
a310c4b65f Make selection blueprints a bit more testable 2019-10-01 19:32:47 +09:00
smoogipoo
e4e6634432 Add slider combo change test 2019-09-26 17:39:26 +09:00
smoogipoo
ea76dd6a9e Add test scene for hitcircles and combo changes 2019-09-26 17:18:16 +09:00
iiSaLMaN
c57868795e Remove redundant using directive 2019-09-26 04:38:57 +03:00
iiSaLMaN
d773f0cce1 Override autoplay bool instead of adding it 2019-09-26 04:38:20 +03:00
iiSaLMaN
186ea98217 Wait for track to start running instead 2019-09-26 02:23:18 +03:00
Dan Balasescu
13f922211f
Merge branch 'master' into decrease-disc-rotation-on-rewind 2019-09-24 12:58:27 +09:00
iiSaLMaN
18fd7aa805 Remove redundant using directive 2019-09-24 05:10:06 +03:00
iiSaLMaN
ba679684be Trim whitespaces 2019-09-24 04:59:57 +03:00
iiSaLMaN
143d7ab640 Add test scene for spinner rotation 2019-09-24 04:53:26 +03:00
Dean Herbert
a06cb54732
Merge branch 'master' into beatmap-parsing-fallback-v2 2019-09-20 15:28:08 +09:00
dependabot-preview[bot]
f10b390ca0
Bump Microsoft.NET.Test.Sdk from 16.2.0 to 16.3.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.2.0 to 16.3.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.2.0...v16.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-19 16:32:39 +00:00
Dean Herbert
adc2dfa6c6 Fix HitCircleLongCombo test stacking off-screen 2019-09-18 03:00:17 +09:00
Bartłomiej Dach
a407e267a2 Fix PF/SD legacy mod conversion
Upon investigating an user report in #6091 that indicated that viewing
replays using the Perfect mod would also display the Sudden Death mod
icon despite Perfect being the more restrictive of the two, it turned
out that the logic of importing legacy scores was missing that corner
case. A similar case of Double Time/Nightcore mutual exclusion was
handled, but PF/SD was missed.

Add analogous handling of PF/SD legacy mods for all four rulesets,
and additionally cover a tiny fraction of all cases with unit tests.
The most problematic cases (NC+HD and PF+SD) are covered in all four
basic rulesets.
2019-09-15 22:55:25 +02:00
Bartłomiej Dach
11eda44d34 Migrate decoding to line-buffered reader
Migrate all usages of StreamReader in the context of decoding beatmaps,
storyboards or skins to the new LineBufferedReader.
2019-09-15 01:28:07 +02:00
smoogipoo
e408efff49 Add scaling to the test 2019-09-11 13:40:53 +09:00
smoogipoo
562280ced0 Add cursor trail test scene 2019-09-11 13:30:11 +09:00
iiSaLMaN
c4aee11fe0 Revert renaming changes 2019-09-09 15:35:18 +03:00
smoogipoo
be2d4d0d02 Merge branch 'remove-test-default-skin' into skinned-cursortrail-2 2019-09-09 17:09:17 +09:00
smoogipoo
81bb8d9bc4 Make SkinnabbleTestScene use stored classic skin 2019-09-09 17:05:27 +09:00
smoogipoo
5b692915be Add required type 2019-09-09 17:03:14 +09:00
smoogipoo
74440dcfdc Make the cursors click every so often 2019-09-09 13:01:40 +09:00
smoogipoo
af09ed1b7f Make cursor test scene more automated 2019-09-09 12:48:38 +09:00
iiSaLMaN
3d8b27abfa RotationAbsolute -> BidirectionalRotation 2019-09-08 16:13:36 +03:00
iiSaLMaN
87d10c6a32 Merge remote-tracking branch 'upstream/master' into add-spinner-bonus-score 2019-09-07 14:50:23 +03:00
Dean Herbert
f925e781a9 Refactor HitWindows for legibility 2019-09-06 15:24:14 +09:00
Dean Herbert
bebc3309ce Refactor skin configuration to be infinitely extensible 2019-09-03 17:57:34 +09:00
Dean Herbert
05ed9d3802 Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements 2019-09-03 13:07:58 +09:00
smoogipoo
8302658186 Fix other potential nullref cases that rider missed 2019-09-02 18:31:33 +09:00
smoogipoo
0c73c5acf3 Expose full hitobject rather than hit windows 2019-09-02 17:14:40 +09:00
smoogipoo
f2bdf94a1d Add HitWindows to JudgementResult to indicate timing errors 2019-09-02 16:28:14 +09:00
Dean Herbert
f9fcf1562f Merge remote-tracking branch 'upstream/master' into iskincomponent 2019-09-02 14:21:02 +09:00
dependabot-preview[bot]
2876588193
Bump NUnit3TestAdapter from 3.15.0 to 3.15.1
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.15.0 to 3.15.1.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.15...V3.15.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-08-30 13:36:31 +00:00
Dean Herbert
a15828ab25 Introduce the concept of SkinComponents
Removes reliance on string lookups and better defines elements for introduction into database
2019-08-30 14:55:52 +09:00
Dean Herbert
ae05faa6d2 Fix indentation 2019-08-30 14:54:46 +09:00
Dean Herbert
c3fb4b9099 Fix test failing 2019-08-30 14:51:47 +09:00
Dean Herbert
493fc5d400 Bring back OsuPlayer test 2019-08-30 14:44:36 +09:00
Dean Herbert
22e3ad8b9c Add skinning support to cursor test 2019-08-30 14:09:17 +09:00
Dean Herbert
8b42890644 Fix unnecessary null check 2019-08-28 20:19:19 +09:00
Dean Herbert
01aede3e29 Add comprehensive skin fallback integration testing 2019-08-28 19:57:17 +09:00
Dean Herbert
7ccc409df7 Merge remote-tracking branch 'upstream/master' into add-ruleset-legacy-skin 2019-08-27 18:27:26 +09:00
Dean Herbert
7aeeb65ae7 Tidy up Player's container loading logic
Fixes drawable ruleset being loaded before skin sources are finished, by loading them as a separate operation (to avoid children being loaded first).
2019-08-27 18:27:21 +09:00
Dean Herbert
62641c149d Fx component lookups being incorrect for non-databased legacy skins 2019-08-26 18:20:45 +09:00
Dean Herbert
6e3a63dae8 Update tests 2019-08-26 12:31:51 +09:00
dependabot-preview[bot]
72a644996c
Bump NUnit3TestAdapter from 3.14.0 to 3.15.0
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.14.0 to 3.15.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.14...V3.15)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-08-23 13:41:27 +00:00
Salman Ahmed
f4f15cc803
Merge branch 'master' into add-spinner-bonus-score 2019-08-22 09:48:09 +03:00
iiSaLMaN
dbf4884cbc Adjust test spinner rotation 2019-08-20 21:52:13 +03:00
Dean Herbert
4bffb0df84 Merge branch 'animated-legacy-skins' into animated-slider-ball 2019-08-20 18:14:17 +09:00
Dean Herbert
7d668c81fc Avoid test failures
This is a bit of a workaround (I'm pretty sure these tests are not running correctly on appveyor) but I think it will do for now. Cannot repro failures locally at all.
2019-08-20 18:13:53 +09:00
Dean Herbert
78c7170e86 Don't show judgement type "none" 2019-08-20 17:47:58 +09:00
Dean Herbert
2066a93918 Fix file extension case #2 2019-08-20 17:47:58 +09:00
Dean Herbert
9f0a0b2fcb Fix file extension case #1 2019-08-20 17:47:58 +09:00
Dean Herbert
9fbc8440fc Add actual testing of animations 2019-08-20 17:39:16 +09:00
Dean Herbert
b5cb59faf2 Add default skin sprites and specular/diffuse layer support 2019-08-20 13:19:32 +09:00
Dean Herbert
550311698b Update slider test scene 2019-08-20 13:18:59 +09:00
Dean Herbert
bc49164cc1
Merge branch 'master' into animated-legacy-skins 2019-08-13 00:40:20 +09:00
dependabot-preview[bot]
58e98e53d2
Bump NUnit3TestAdapter from 3.13.0 to 3.14.0
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.13.0 to 3.14.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.13...V3.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-08-09 03:58:06 +00:00
jorolf
167a81f40a add special skin hit "animations" 2019-08-07 18:12:11 +02:00
smoogipoo
bc3a340286 Fix incorrect path position being used for old stacking algorithm 2019-08-07 19:35:39 +09:00
smoogipoo
994c1f21ec Output stacked positions for conversion values 2019-08-07 19:33:20 +09:00
Dean Herbert
431834fc2f Merge remote-tracking branch 'upstream/master' into conversion-test-mods 2019-08-05 09:50:43 +02:00
smoogipoo
f2b940f930 Add tests 2019-08-01 17:31:37 +09:00
smoogipoo
ed4dda1936 Support beatmap conversion tests with mods 2019-08-01 12:49:01 +09:00
jorolf
7b95741dab fix crash and add some tests
- still missing special skin textures
2019-07-31 21:55:56 +02:00