Dean Herbert
90121814f9
Merge branch 'master' into stable-notelock
2023-09-01 17:15:48 +09:00
Dean Herbert
2d88135198
Add automated test coverage for new test
2023-08-31 16:18:53 +09:00
Salman Ahmed
b8df714f56
Remove unused using directives
2023-08-30 21:50:52 +03:00
Salman Ahmed
c91031604c
Add test cases for hitting hit circles with "early fade" behaviour
2023-08-30 21:41:57 +03:00
Bartłomiej Dach
38e3459391
Fix broken assertion
2023-08-24 08:54:38 +02:00
Bartłomiej Dach
7f215f163f
Use reduced hittable range with autopilot active
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
a316036460
Add failing test case for special autopilot hittable range
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
ed2b1a0754
Contain entirety of legacy notelock badness inside the hit policy
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
64b36a73b1
Rename test scene to match tested class
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
48b3f7dced
Add test case covering stacks not shaking
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
9ffc6cdd61
Add test case covering overlapping slider fail case
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
a045cb71fc
Add assertions checking action type taken by legacy hit policy
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
1f3121bdf2
Merge branch 'master' into stable-notelock
2023-08-24 08:52:43 +02:00
Bartłomiej Dach
b777b34cc0
Merge branch 'master' into stable-notelock
2023-08-24 08:43:59 +02:00
Dean Herbert
981e0c1ad7
Rename export test step to better fit purpose
2023-08-24 14:26:26 +09:00
Bartłomiej Dach
052bf2a6e0
Use alternative solution for timing offset woes on export
2023-08-23 13:54:34 +02:00
Bartłomiej Dach
64786aaee8
Adjust test cases slightly to avoid running into hitwindow edge issue
...
Some note lock test cases do not play out correctly when exported out
to stable due to a completely separate issue, namely #11311 .
Adjust the test cases for now to isolate failure vectors.
2023-08-23 10:43:48 +02:00
Bartłomiej Dach
a1b4a56215
Add capability to export ordered object policy test cases for stable crosscheck
2023-08-23 10:43:41 +02:00
Bartłomiej Dach
9fd59b807f
Rewrite TestSceneObjectOrderedHitPolicy to not rely on custom hitwindows
2023-08-22 15:36:36 +02:00
Bartłomiej Dach
ab4d47b594
Rewrite assertions to use nunit constraints
2023-08-22 14:37:58 +02:00
Bartłomiej Dach
c9f611a713
Enable NRT in TestSceneObjectOrderedHitPolicy
2023-08-22 14:30:55 +02:00
Bartłomiej Dach
1d657a8844
Merge branch 'master' into fix-slider-reversing
2023-08-21 09:29:46 +02:00
Bartłomiej Dach
3d52a1267e
Fix test failures via test-local popover containers
2023-08-19 15:08:30 +02:00
OliBomby
4ff58c6818
fix no nodesample test case
2023-08-16 22:10:59 +02:00
Bartłomiej Dach
5219b8a13b
Add test coverage for precise rotation control
2023-08-16 11:37:52 +02:00
Pasi4K5
6346872c39
Improve code readability and add assertion to test scene
2023-08-15 23:27:12 +02:00
Pasi4K5
cd70673463
Fix property name
2023-08-14 22:41:25 +02:00
Pasi4K5
28994166bc
Split up assertions
2023-08-14 22:09:12 +02:00
Pasi4K5
449bee98cc
Code cleanup
2023-08-14 21:56:08 +02:00
Pasi4K5
bbd91e3ee4
Add TestSceneSliderReversal
2023-08-14 14:14:11 +02:00
Bartłomiej Dach
cd416e09f9
Add test scene for checking spinner judgements
2023-07-29 00:49:21 +02:00
Liam DeVoe
15af85226c
adjust test for correct stable notelock
...
stable actually allows for hitobjs to be hit in the middle of sliders, as long as it doesn't interfere with the end time of the slider.
2023-07-19 02:06:29 -04:00
Dean Herbert
b9a66ad7b3
Add test coverage of incorrect selection behaviour
2023-07-19 14:59:22 +09:00
Liam DeVoe
768d7b5e1c
correct implementation of stable notelock
2023-07-17 23:31:21 -04:00
Dean Herbert
547f247669
Fix test to work regardless of screen sizes
2023-07-12 17:41:58 +09:00
Dean Herbert
b20190ed4f
Merge branch 'master' into fix-blueprint-end-placement
2023-07-12 17:38:47 +09:00
Dean Herbert
ca9c31b492
Add test coverage of slider blueprint end placement failing outside playfield
2023-07-11 17:29:28 +09:00
Bartłomiej Dach
2cd5fd5944
Add failing legacy mod conversion test cases
2023-07-09 16:09:25 +02:00
Bartłomiej Dach
e9ecad9839
Add failing test cases covering NaN-timing-point sliders
2023-07-08 23:24:38 +02:00
tsrk
350d722c8d
Merge branch 'master' into hud/kc-skinnable
2023-06-25 15:42:08 +02:00
Bartłomiej Dach
f8d2f2f7e1
Fix more issues discovered by CI that can be fixed game-side
2023-06-24 19:04:05 +02:00
Bartłomiej Dach
d7ae430ec2
Merge branch 'master' into framework-update
2023-06-24 18:47:52 +02:00
Dean Herbert
3585c3f1d5
Apply required nullability changes
2023-06-24 09:58:36 +09:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
Bartłomiej Dach
9bcd86d66d
Fix test failure due to relying on implementation detail
2023-06-19 18:42:30 +02:00
tsrk
cf1ee2ba35
test(TestSceneOsuTouchInput): fix InputTrigger depth
2023-06-18 18:26:08 +02:00
tsrk
c8afd057bd
test(TestSceneOsuTouchInput): simplify draw hierarchy
...
An InputTrigger is considered active as long as
2023-06-18 17:51:17 +02:00
tsrk
b960741ff7
test: adapt touch input test to changes
2023-06-16 18:54:19 +02:00
Bartłomiej Dach
3bf900a4df
Add failing test case for slider scenario
2023-06-10 12:14:08 +02:00
Bartłomiej Dach
2958ce35be
Adjust object snapping test cases to pass with new radius
2023-06-08 13:19:47 +02:00
Dean Herbert
310c54fe28
Add test coverage ensuring positional data is present in hit events
2023-06-01 13:26:47 +09:00
Dean Herbert
e68ba6366c
Update new usages of "soft" to use the new constant
2023-05-24 14:04:10 +09:00
Dean Herbert
83dcd78826
Make HitSampleInfo.Bank non-nullable
2023-05-16 18:12:56 +09:00
Bartłomiej Dach
a45f0b65a1
Merge pull request #23372 from peppy/fix-slider-end-circle-appear-delay
...
Fix fade in delay for first slider end circle being incorrect when snaking disabled
2023-05-03 19:06:39 +02:00
Dean Herbert
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
Dean Herbert
b2b9f2a036
Merge branch 'master' into bubble_mod_implementation_clean
2023-05-02 16:59:55 +09:00
Dean Herbert
e3c51b9652
Add ability to toggle snaking in slider test scene
2023-05-02 16:26:56 +09:00
Dean Herbert
e3c384c6b5
Merge branch 'master' into sample-control-points
2023-05-02 14:38:39 +09:00
Bartłomiej Dach
ff29189e89
Add custom cursor-ripple to cover skinnability in test
2023-05-01 09:33:37 +02:00
Dean Herbert
a4ae9e409b
Implement ripples (legacy and default)
2023-04-30 14:48:03 +09:00
OliBomby
354cd23874
removed all usage of hitobject's DifficultyControlPoint
2023-04-26 18:17:02 +02:00
OliBomby
c6fc180659
remove all test usages of SampleControlPoint
2023-04-26 14:21:52 +02:00
Dean Herbert
b0c09df259
Merge branch 'master' into gameplay/key-counter-abstraction
2023-04-03 15:33:35 +09:00
Dean Herbert
cc408470f4
Add test coverage of second touch moving but not resulting in cursor movement
2023-03-21 16:14:44 +09:00
Dean Herbert
7b34607676
Merge branch 'master' into bubble_mod_implementation_clean
2023-03-16 13:45:22 +09:00
Dean Herbert
42359a9754
Fix previous touch action not being released when it's not a direct touch
2023-03-15 16:43:20 +09:00
Dean Herbert
6c4f596a9a
Make osu! touch input aware of the distance travelled of a non-direct touch
2023-03-15 16:43:20 +09:00
Bartłomiej Dach
f711915e5f
Remove unused using directive
2023-03-07 21:16:30 +01:00
Dean Herbert
28520414aa
Move KeyCounter components to HUD namespace
2023-03-07 16:41:39 +09:00
Dean Herbert
8f6df5ea0f
Merge branch 'master' into gameplay/key-counter-abstraction
2023-03-07 16:09:45 +09:00
tsrk
8c94b77de1
refactor(InputTrigger): move out of KCD
...
I love JetBrains Rider.
2023-02-22 15:05:07 +00:00
Dean Herbert
ee87a29376
Merge pull request #22543 from Cwazywierdo/hitcircle-late-miss-fade
...
Fix hit circle late-miss fading differences compared to stable
2023-02-21 13:56:57 +09:00
MK56
b74c1c8334
Merge branch 'master' into bubble_mod_implementation_clean
2023-02-19 21:36:59 +01:00
Bartłomiej Dach
0611fd4035
Add coverage for classic/hidden interactions
2023-02-19 16:39:25 +01:00
tsrk
6193aeed12
fix(TestSceneOsuTouchInput): missing Value call
2023-02-17 00:13:45 +00:00
tsrk
c61fac578c
style(KeyCounter): rename methods and arguments
...
As for the second suggestion in
https://github.com/ppy/osu/pull/22654#discussion_r1109047998 ,
I went with the first one as only one Trigger actually uses this
argument for rewinding.
2023-02-16 23:15:03 +00:00
tsrk
6340730427
refactor(KeyCounter): remove circularity
2023-02-16 21:59:39 +00:00
Dean Herbert
7afdcb9383
Merge branch 'master' into hide-resume-overlay
2023-02-16 15:42:14 +09:00
tsrk
076eb81b21
refactor: rename trigger classes
...
Makes it better to understand their purpose
2023-02-15 21:46:13 +00:00
tsrk
a644fae364
style(KeyCounter): rename (Un)lit methods to (Un)light
2023-02-15 21:41:41 +00:00
tsrk
157bba7830
refactor: rename Trigger class to InputTrigger
2023-02-15 21:41:36 +00:00
Dean Herbert
5024838f3a
Merge branch 'master' into bubble_mod_implementation_clean
2023-02-15 13:47:18 +09:00
Dean Herbert
9e04a36d86
Move test to a mod test and add more resilient test logic
2023-02-14 15:07:45 +09:00
Pasi4K5
a820c0c8eb
Add TestSceneInstantResume
2023-02-13 23:55:13 +01:00
tsrk
11d0e185b8
refactor: separate impl of KeyCounterDisplay
...
This allows for different layouts of display. Idk, maybe someone would
want to mix both variants? (don't do this please). This commit is mostly
prep for further changes.
2023-02-13 01:36:12 +00:00
Adam
defe1fbf50
Remove '#nullable disable'
2023-02-12 09:25:28 -06:00
Dean Herbert
20f3ab167e
Re-centralise BannedApiAnalysers nuget package
2023-02-11 19:36:40 +09:00
Dean Herbert
86c8675910
Update realm and other dependencies
2023-02-11 13:52:24 +09:00
Adam
6d99e09912
Modify tests
2023-02-09 16:47:43 -06:00
Adam
5cd973fb34
Add test
2023-02-06 19:20:43 -06:00
MK56
c50604f701
Merge branch 'master' into bubble_mod_implementation_clean
2023-01-27 11:58:56 +01:00
Bartłomiej Dach
c4dce30de5
Merge pull request #22412 from peppy/argon-kiai
...
Add very basic kiai flash to argon hit circles
2023-01-26 19:13:58 +01:00
Dean Herbert
13937cf555
Merge branch 'master' into stream-tool-2
2023-01-26 16:08:20 +09:00
Dan Balasescu
9ed0b8ccfa
Merge pull request #22375 from peppy/osu-ruleset-touch-support
...
Add empty space tap-streaming support for osu! ruleset on touchscreen devices
2023-01-26 08:12:12 +09:00
Bartłomiej Dach
73f53328cf
Merge branch 'master' into argon-kiai
2023-01-25 22:21:26 +01:00
Dean Herbert
78cfe2f547
Fix hit circle kiai test scene not always working as expected
2023-01-25 18:46:52 +09:00
Dean Herbert
9499d3a20a
Add support for disabling "hit lighting" with osu! argon skin
2023-01-25 15:50:49 +09:00
Dean Herbert
e4a79d8581
Rename test scene to differentiate from other ruleset touch tests
2023-01-25 15:01:05 +09:00
Dean Herbert
b9ed6a7a7c
Add visual demonstration of streaming that runs a bit faster than other tests
2023-01-23 17:55:04 +09:00
Dean Herbert
b436b7b99b
Add test coverage of more streaming scenarios
2023-01-23 17:39:41 +09:00
Dean Herbert
238a3833e2
Add test coverage of stream scenario with an initial finger down
2023-01-23 17:28:01 +09:00
Dean Herbert
c4d5957ac3
Add empty space tap-streaming support for osu! ruleset on touchscreen devices
2023-01-23 17:07:27 +09:00
Dean Herbert
92dc626734
Merge branch 'master' into osu-ruleset-multi-touch-basic
2023-01-18 13:13:22 +09:00
Bartłomiej Dach
452bf92550
Fix code quality inspection
2023-01-17 18:02:06 +01:00
ekrctb
e65108533a
Reduce number of tested value combination
...
121 combinations took 2min+
2023-01-17 22:12:06 +09:00
Dean Herbert
490f539c43
Add failing test coverage of relax/autopilot scenarios
2023-01-17 15:07:05 +09:00
Dean Herbert
f387a6af57
Apply review feedback to touch test scene
2023-01-17 14:56:07 +09:00
Dean Herbert
6b16d3ee61
Add test expectation for how positional input should be handled
2023-01-16 21:21:00 +09:00
Dean Herbert
ab3d632112
Also add test coverage of positional updates
2023-01-16 21:21:00 +09:00
Dean Herbert
eaaab2e76d
Add test coverage of disabled mouse buttons
2023-01-16 21:21:00 +09:00
Dean Herbert
9c5789848f
Add further coverage of alternating
...
Covers a real failure I discovered.
2023-01-16 21:21:00 +09:00
Dean Herbert
b1c9505ab6
Add touch visualisation to test
2023-01-16 21:21:00 +09:00
Dean Herbert
fd5fac507e
Add test coverage of expected touch to action handling
2023-01-16 21:21:00 +09:00
MK56
f9b42161e3
Merge branch 'master' into bubble_mod_implementation_clean
2023-01-11 14:56:21 +01:00
Joseph Madamba
973fd90af2
Fix parameters with the same default value inspection
2022-12-25 16:15:02 -08:00
mk56-spn
bbb22479a8
Add "ModBubbles" for the osu ruleset.
2022-12-25 23:09:52 +01:00
Bartłomiej Dach
5807d4c43d
Add test coverage for slider transformations
2022-12-07 23:50:01 +01:00
OliBomby
10b5900710
made PathControlPointVisualiser generic
2022-12-07 10:13:40 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
f6e229c24d
"Fix" mod copy failure
2022-11-25 01:15:11 +09:00
maromalo
1911120afe
Merge branch 'master' into long-standard
2022-11-12 09:52:11 -03:00
Dan Balasescu
db25e9e9c8
Merge branch 'master' into combo-colour-brightness-limit
2022-11-11 15:31:28 +09:00
Dean Herbert
1aa0e40f2f
Add "Component" prefix to lookup naming
2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b
Rename ISkinComponent to ISkinLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
ab458320c4
Fix some lingering inspections
2022-11-09 17:46:24 +09:00
maromalo
b7ef9b176d
Make score type consistent
2022-11-06 19:59:27 -03:00
Dean Herbert
e02c477008
Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks
...
Remove nullable disable in the checks.
2022-11-06 18:39:03 +09:00
Bartłomiej Dach
84179fb087
Merge branch 'master' into combo-colour-brightness-limit
2022-11-05 16:48:56 +01:00
andy840119
b0673636ca
Remove nullable disable annotation in the osu ruleset.
2022-11-05 16:49:55 +08:00
Bartłomiej Dach
6c819cba02
Add test coverage for regressed scenarios
2022-11-04 19:46:23 +01:00
Dean Herbert
923d44a769
Update dependencies
2022-11-04 17:00:58 +09:00
Dean Herbert
3ec9686e58
Fix test failures and rename configuration value to match better
2022-11-02 18:15:18 +09:00
Dean Herbert
cd8dc9b17b
Rename "Target" to "Target Practice"
2022-11-01 19:47:20 +09:00
Dan Balasescu
2d829c3beb
Merge pull request #20945 from peppy/fix-misplaced-slider-head
...
Fix slider heads getting misplaced after flipping in editor
2022-10-27 12:51:27 +09:00
Bartłomiej Dach
f787da892b
Merge branch 'master' into grid-momentary-shortcuts
2022-10-26 21:30:24 +02:00
Dean Herbert
614011d612
Update TestSceneObjectOrderedHitPolicy to provide better output
2022-10-26 15:25:50 +09:00
Dean Herbert
cab9a1c012
Add test coverage of distance snap grid failing visually
2022-10-26 13:10:54 +09:00
Dean Herbert
5f10b81af1
Move distance snap grid test cursor behind grid to better visualise centre-points
2022-10-26 13:10:54 +09:00
Dean Herbert
cbcebfa130
Remove switch back to selection tool to simplify test flow
2022-10-26 12:18:56 +09:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts
2022-10-25 22:17:08 +02:00
Dean Herbert
521fbd2ea3
Merge pull request #20345 from mk56-spn/Freeze_frame_implementation
...
Add "Freeze Frame" mod
2022-10-26 01:28:23 +09:00
Dean Herbert
16ef0b09e8
Add test coverage of momentary toggles
2022-10-25 14:36:35 +09:00
Dean Herbert
a9755295e4
Update tests in line with new behaviour
2022-10-25 14:32:08 +09:00
Dean Herbert
3d72ff28c3
Add test scene for "Freeze Frame" mod
2022-10-25 13:25:38 +09:00
Salman Ahmed
f444bb9ba6
Update existing test case
2022-10-20 03:55:53 +03:00
Salman Ahmed
7e9229a117
Merge branch 'master' into no-scope-no-smoke
2022-10-15 16:42:34 +03:00
Salman Ahmed
ba72f13f54
Merge branch 'master' into hide-mouse-on-keyboard-input
2022-10-14 22:26:30 +03:00
Salman Ahmed
b1b97505ac
Fix smoke displayed in "No scope" mod
2022-10-14 22:16:14 +03:00
Dan Balasescu
10aabfc650
Merge pull request #20739 from peppy/settings-toolbox
...
Adjust visuals of settings toolboxes (gameplay loading screen and editor)
2022-10-14 20:31:05 +09:00
Salman Ahmed
516e99df72
Add test coverage for flashlight mod
2022-10-14 02:38:43 +03:00
Dean Herbert
6608ada925
Fix test failures due to missing colour provider dependency
2022-10-13 17:05:11 +09:00
Salman Ahmed
09cc89cfa0
Update existing usages of Cursor to handle null value
2022-10-13 00:17:08 +03:00
D.Headley
83aedb1930
Make mod use new Combo, remove pointless test
2022-10-12 12:42:26 +02:00
OliBomby
b22e201289
Fixed stream convert float precision edge case
2022-10-08 23:43:23 +02:00
MK56
8fe89d5de2
Merge branch 'ppy:master' into Freeze_frame_implementation
2022-10-07 22:23:51 +02:00
Dean Herbert
072b64b8d4
Update all dependencies
2022-10-07 21:16:11 +09:00
Alden Wu
2c0cd9ea52
Add more smoke tests
2022-10-05 19:09:34 -07:00
Alden Wu
eaab0deef3
Fix InspectCode issues
2022-10-03 19:20:51 -07:00
Alden Wu
ccef189b81
Add barebones test for smoke
2022-10-03 18:19:05 -07:00
Dean Herbert
a94b4e402e
Merge branch 'master' into argon-spinner
2022-09-23 14:22:53 +09:00
Pasi4K5
d538295ad5
Add TestSceneOsuModRandom
2022-09-22 23:04:43 +02:00
Salman Ahmed
a771d4031f
Separate triangles-specific test steps to own scene
2022-09-22 21:27:06 +03:00
Dan Balasescu
5dbe73ad0e
Merge pull request #20398 from peppy/fix-missing-notelock-shake
...
Fix "note lock" shake not always animating
2022-09-22 20:07:38 +09:00
Dan Balasescu
4528c1037b
Resolve CI inspections
2022-09-22 19:26:27 +09:00
Dean Herbert
b844d76311
Move Shake logic local to hitcircle/slider
2022-09-22 15:04:20 +09:00
Dean Herbert
4492a26b59
Merge branch 'master' into argon-skin
2022-09-21 13:00:16 +09:00
Dan Balasescu
8bf196d561
Merge pull request #20354 from peppy/default-skin-refactor
...
Rename default skin to make way for new version
2022-09-21 11:48:38 +09:00
Dean Herbert
f6b29d8ebc
Make TestSceneHitCircle show more than one cirle to make testing easier
2022-09-19 12:38:34 +09:00
Dean Herbert
d0b8409de5
Apply more renames
2022-09-18 18:19:00 +09:00
Dean Herbert
41e69fbca6
Remove "default" prefix from naming
2022-09-18 00:15:26 +09:00
Dean Herbert
51841988bf
Rename references to DefaultSkin to have Triangles suffix
2022-09-17 23:57:25 +09:00
Salman Ahmed
fe72237118
Remove unused using
2022-09-16 20:08:50 +03:00
Salman Ahmed
f512106bee
Adjust test scene to match expectations
...
- Adds a scenario where no button is pressed before second hitobject.
- Adjusts press time to not conflict with break start time.
2022-09-16 20:00:44 +03:00
MK56
3fe94b1620
Merge branch 'ppy:master' into Freeze_frame_implementation
2022-09-16 14:29:44 +02:00
Mk-56spn
6db8f51c02
Improve Tests
...
Fix divisor in test
Add Copyright header
2022-09-16 13:45:18 +02:00
Dean Herbert
c7f8f948b9
Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins
2022-09-15 20:18:10 +09:00
Dean Herbert
65d1c40dd5
Remove remaining package references and replace with SQLitePCLRaw direct reference
...
This may require further consideration for test and iOS projects.
2022-09-15 16:58:58 +09:00
Mk-56spn
cb17fb2091
Create Test Scene
2022-09-09 23:13:19 +02:00
Dean Herbert
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
Dean Herbert
a15ea71aed
Merge branch 'master' into fix-merge-crash
2022-08-31 13:28:57 +09:00
Dean Herbert
706ac3e44f
Merge pull request #19982 from OliBomby/fix-illegal-merge
...
Fixed 0 length merge being allowed
2022-08-30 12:28:18 +09:00
Dean Herbert
a215d009fe
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
2022-08-29 15:57:40 +09:00
OliBomby
ff2eac79d1
fix same time merge causing crash
2022-08-27 17:43:32 +02:00
OliBomby
16e0ec2f88
Fixed 0 length merge being allowed
2022-08-27 13:53:50 +02:00
Dean Herbert
90ff0864c0
Merge branch 'master' into no-gameplay-clock-editor-offset
2022-08-26 20:25:21 +09:00
Dean Herbert
69cbc0125b
Merge pull request #19964 from nanashi-1/merge-hitobject-hitsound-fix
...
Fix hitobjects merge feature in editor not adding any hitsounds
2022-08-26 20:05:02 +09:00
Dean Herbert
cb1c4a1bb1
Move sample checks to be inline in other existing tests
2022-08-26 19:18:15 +09:00
Dean Herbert
03dcfed384
Merge branch 'master' into slider-splitter
2022-08-26 19:10:33 +09:00
Dean Herbert
4b72e55770
Fix various test scenes not adding EditorClock to the draw hierarchy
2022-08-26 18:08:43 +09:00
nanashi-1
78717956d5
add visual test
2022-08-26 16:55:18 +08:00
nanashi-1
16fee7ac1c
add visual test
2022-08-25 19:31:47 +08:00
OliBomby
631ea9a3ed
added a gap between objects and made it theoretically possible to retain sample control point
2022-08-23 23:29:59 +02:00
OliBomby
7732fb21d5
fix code quality
2022-08-20 16:09:02 +02:00
OliBomby
614ae815c0
Added tests for making sure flipping and rotating retains perfect control point type
2022-08-20 15:57:39 +02:00
OliBomby
91e6f4c4ee
fix TestPerfectCurveChangeToBezier
2022-08-19 19:31:47 +02:00
OliBomby
d1519343f6
Improved visual tests for slider splitting
2022-08-19 18:29:01 +02:00
OliBomby
89eb0a4079
Added TestScene for slider splitting
2022-08-19 01:10:54 +02:00
Dan Balasescu
5d8d584afb
Fix some backwards asserts
2022-08-18 18:08:46 +09:00
Dean Herbert
a5ac69a554
Update various dependencies
2022-08-17 16:57:56 +09:00
Dean Herbert
615c5cf6ae
Merge branch 'master' into slider-merger
2022-08-17 13:36:15 +09:00
OliBomby
d021218d78
added test for objects which cant be merged
2022-08-16 23:05:35 +02:00
OliBomby
d140e0df14
remove nullable disable annotation
2022-08-15 21:15:23 +02:00
OliBomby
7c2ada9b20
Revert "remove copyright notice from new file"
...
This reverts commit b5e5411348
2022-08-15 21:11:06 +02:00
OliBomby
b5e5411348
remove copyright notice from new file
2022-08-15 18:07:55 +02:00
OliBomby
d261be8734
added visual tests
2022-08-15 17:19:04 +02:00
Dean Herbert
6d78218142
Update usages of GameplayClockContainer.GameplayClock to access properties directly
2022-08-15 18:08:49 +09:00
Dean Herbert
0087935708
Update TestSceneSpinnerRotation to use constraint-based assertions
2022-08-15 18:05:39 +09:00
Dan Balasescu
9f28c4c033
Adjust test values
2022-08-11 19:47:32 +09:00
Dan Balasescu
5a1c05918f
Fix test failures
2022-08-02 20:18:45 +09:00
Dan Balasescu
b4e55f7309
Apply IRenderer changes
2022-08-02 19:50:57 +09:00
andy840119
8fa5765573
Remove nullable disable annotation in the Osu test case.
2022-07-26 23:58:50 +08:00
Dan Balasescu
cfb2adfd27
Merge branch 'master' into velocitychanges
2022-07-19 19:57:47 +09:00
Dan Balasescu
842fe32003
Update test values
2022-07-19 19:57:36 +09:00
Dean Herbert
be3187c3a4
Remove remnant nullable disables
2022-07-13 22:05:56 +09:00
James
886efbcbdf
add test scene for Single Tap mod
2022-07-12 23:18:24 +01:00
Dean Herbert
3d9252e4b8
Merge branch 'master' into osu-mod-repel
2022-07-12 15:19:05 +09:00
Dean Herbert
44d2e001ed
Update various dependencies
2022-07-11 20:16:49 +09:00
Dean Herbert
958c0fb390
Remove Appveyor.TestLogger
2022-07-11 15:01:16 +09:00
Gabe Livengood
b3f23d93e8
Merge branch 'master' into osu-mod-repel
2022-07-06 17:05:09 -04:00
Dan Balasescu
385bd5a1b2
Merge pull request #18965 from peppy/mark-flaky-tests
...
Mark, document and silence remaining flaky tests on standard CI runs
2022-07-03 21:41:14 +09:00
Dean Herbert
cdc4caa8c4
Merge pull request #18945 from goodtrailer/separate-ball-followcircle
...
Separate slider ball and followcircle skinnables into default/legacy classes
2022-07-01 17:54:29 +09:00
Dean Herbert
b597843579
Mark and document remaining flaky tests
2022-07-01 16:17:40 +09:00
Dan Balasescu
6c2d02fefd
Fix tests
2022-06-30 12:37:03 +09:00
goodtrailer
0e0e9968ac
Split ball and followcircle into default/legacy files
2022-06-29 01:23:35 -07:00
Dean Herbert
8cda55e224
Merge pull request #18795 from smoogipoo/full-size-follow-circle
...
Track the full size of the follow circle at all times
2022-06-28 19:20:34 +09:00
Dean Herbert
35745c83b7
Replace dodgy SetUpSteps overriding with usage of HasCustomSteps
2022-06-28 15:19:02 +09:00
Dean Herbert
5a7d339cc8
Centralise and harden editor-ready-for-use check
...
Not only does this combine the check into one location, but it also adds
a check on the global `WorkingBeatmap` being updated, which is the only
way I can see the following failure happening:
```csharp
05:19:07 osu.Game.Tests: osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.TestAddAudioTrack
05:19:07 Failed TestAddAudioTrack [161 ms]
05:19:07 Error Message:
05:19:07 TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
05:19:07 Stack Trace:
05:19:07 --TearDown
05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass7_0.<AddFile>b__0(TModel managed) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36
05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass8_0.<performFileOperation>b__0(Realm realm) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 49
05:19:07 at osu.Game.Database.RealmExtensions.Write(Realm realm, Action`1 function) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\RealmExtensions.cs:line 14
05:19:07 at osu.Game.Database.ModelManager`1.performFileOperation(TModel item, Action`1 operation) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 46
05:19:07 at osu.Game.Database.ModelManager`1.AddFile(TModel item, Stream contents, String filename) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36
05:19:07 at osu.Game.Screens.Edit.Setup.ResourcesSection.ChangeAudioTrack(FileInfo source) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Screens\Edit\Setup\ResourcesSection.cs:line 115
05:19:07 at osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.<TestAddAudioTrack>b__13_0() in C:\BuildAgent\work\ecd860037212ac52\osu.Game.Tests\Visual\Editing\TestSceneEditorBeatmapCreation.cs:line 101
05:19:07 at osu.Framework.Testing.Drawables.Steps.AssertButton.checkAssert()
05:19:07 at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
05:19:07 at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
```
2022-06-27 16:22:01 +09:00
Dean Herbert
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
Dean Herbert
f71f6302fd
Remove unnecessary null casts
2022-06-24 14:50:11 +09:00
Dan Balasescu
043aa82a31
Add test
2022-06-21 18:09:00 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Gabe Livengood
2fe34f188f
shamelessly copy osumodmagnetised
2022-06-09 18:52:10 -04:00
Gabe Livengood
569c39942a
replace easement with easing
2022-06-09 18:26:18 -04:00
Gabe Livengood
e5171aaebf
update tests to match new bindable names
2022-06-07 09:48:53 -04:00
Bartłomiej Dach
a8e1c5ba87
Fix remaining cases of incorrect GameplayState construction in tests
...
Manual attempts to initialise replaced by a new `TestGameplayState`
helper for ease of use.
2022-05-28 15:23:29 +02:00
Gabe Livengood
5d838628d7
add test, fix formatting, expose easing function
2022-05-27 23:15:19 -04:00
Dean Herbert
2e21d75b10
Move metronome into own class and rename to avoid conflict with mod sounds
2022-05-20 17:30:04 +09:00
Dean Herbert
f22ff4e087
Remove editor animation toggling (replaced by overlap markers)
2022-05-12 19:28:56 +09:00
Dean Herbert
fda61943b0
Update distance snap test when cursor at centre of grid to be in line with expectations
2022-05-12 13:11:55 +09:00
Dean Herbert
fecf92e16f
Update libraries to latest versions
2022-05-11 19:54:59 +09:00
Salman Ahmed
b119726b28
Reword test step
2022-05-06 15:38:38 +03:00
Dean Herbert
daed42513e
Fix outdated test asserts
2022-05-06 18:44:25 +09:00
Dean Herbert
9fd98b8060
Also add test coverage of adjsuting the distance spacing multiplier
2022-05-05 18:49:12 +09:00
Dean Herbert
4fe23bced2
Update tests with new assumptions and a better snap implementation
2022-05-05 18:49:12 +09:00
Salman Ahmed
269e15c167
Add test coverage of distance spacing multiplier working with distance snap grid
2022-05-05 18:49:12 +09:00
Dean Herbert
de9b3d33eb
Rename misleading DistanceSpacing variable
2022-05-05 17:08:09 +09:00
Dean Herbert
19cf9dc20b
Merge branch 'snapping-tidy-distance'
2022-05-05 16:51:32 +09:00
Dean Herbert
977e6d8a80
Add xmldoc for IDistanceSnapProvider and related properties
2022-05-05 16:25:45 +09:00
Dean Herbert
f6fc926f1a
Add xmldoc and rename methods in IPositionSnapProvider for legibility
2022-05-05 15:58:21 +09:00
Dean Herbert
faeefc5e18
Merge pull request #16576 from frenzibyte/osu-distance-spacing
...
Add "distance spacing" support in editor for osu! ruleset
2022-05-03 12:15:18 +09:00
Salman Ahmed
fef94d49f4
Revert "Convert data type of DistanceSpacing to float"
...
This reverts commit 7aaa88cac2
2022-04-29 08:02:07 +03:00
Salman Ahmed
723d70be70
Change TestInputSingularWithBreak to reproduce case of pressing before second object
2022-04-29 05:38:14 +03:00
Salman Ahmed
7442ae283c
Tidy up test cases a touch
2022-04-29 05:25:22 +03:00
Salman Ahmed
abb88b0907
Move distance spacing application to DistanceSnapGrid
2022-04-28 10:54:38 +03:00
Salman Ahmed
7aaa88cac2
Convert data type of DistanceSpacing to float
2022-04-28 10:24:36 +03:00
Salman Ahmed
2e8372fe90
Minor cleanup
...
Just from reading diff.
2022-04-28 07:14:43 +03:00
Salman Ahmed
a5defbe496
Keep distance spacing reset to one on test scenes with slider snapping for now
2022-04-28 06:44:50 +03:00
Salman Ahmed
835898dd30
Introduce DistancedHitObjectComposer and supersede OsuToolboxComposite
2022-04-28 06:44:50 +03:00
Salman Ahmed
8ed39009fd
Encapsulate distance spacing control handling to a "distance toolbox composite"
...
Encapsulated in a way which can allow further extensibility for the
right-side area of toolboxes.
2022-04-24 08:33:03 +03:00
Salman Ahmed
70a93c0e7e
Move DistanceSpacingMultiplier bindable to its own IDistanceSnapProvider interface
2022-04-24 08:33:00 +03:00
Salman Ahmed
4f8f27a58b
Merge branch 'master' into osu-distance-spacing
2022-04-24 05:23:30 +03:00
Salman Ahmed
610d61dce9
Fix TestSceneSliderApplication not applying legacy skin transformer
2022-04-23 03:34:05 +03:00
Salman Ahmed
858c8f927f
Attach comment explaining purpose of CallBase
2022-04-20 00:27:02 +03:00
Salman Ahmed
fd20c2bdcd
Change circle/overlay sprite fields to protected for better test assertion
2022-04-20 00:24:28 +03:00
Salman Ahmed
813dc2dd78
Fix wrong prefix for default priority lookup in test
2022-04-19 19:46:29 +03:00
Salman Ahmed
f92a41b6c3
Replace local TestSkin implementation with simplified Moq setups
2022-04-19 08:04:13 +03:00
Salman Ahmed
8d0dd3961e
Add failing test cases
2022-04-19 07:12:07 +03:00
Dean Herbert
ee8451c8ca
Merge branch 'master' into osu-diff-calc-max-combo
2022-04-04 14:20:44 +09:00
Dean Herbert
de625125d6
Rename magnetised mod attraction strength property to match new naming
2022-04-01 13:03:48 +09:00
Dean Herbert
a987cda30d
Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour
...
As proposed in https://github.com/ppy/osu/discussions/17375 .
2022-04-01 12:15:52 +09:00
Dan Balasescu
32e55e7d78
Merge branch 'master' into osu-diff-calc-max-combo
2022-03-31 15:08:08 +09:00
Dean Herbert
0cac935939
Shorten class name of ModCreatedReplayUser
2022-03-31 11:34:23 +09:00
Dean Herbert
4b2c01a8c1
Bring all mod implementations up-to-date
2022-03-29 16:59:03 +09:00
Dean Herbert
5fb51b578f
Update dependencies
...
Mainly for a `Clowd.Squirrel` bump to fix https://github.com/ppy/osu/discussions/17190 .
2022-03-09 19:09:51 +09:00
Bartłomiej Dach
a1786f62d7
Fix test failure due to attempting to set non-present divisor
...
With the latest changes permitting fully custom beat snapping, the 1/3
snap divisor isn't immediately available in editor, requiring a switch
to "triplets" mode first.
2022-02-27 23:10:22 +01:00
Shivam
1a7a160f0a
Update vscode launch.json files for all other projects
2022-02-25 14:28:54 +01:00
Dean Herbert
054ed546e3
Fix intermittent failures in remaining test method
2022-02-23 16:56:50 +09:00
Dean Herbert
a6b6644c2e
Replace LINQ queries with recommendations
2022-02-23 16:22:13 +09:00
Dean Herbert
9e279c3ebc
Fix completely incorrect judgement specification
2022-02-22 14:37:52 +09:00
Dean Herbert
91acc9eec6
Remove checks which are still going to occasionally fail due to pooling
2022-02-22 14:36:08 +09:00
Dean Herbert
0d56693b7a
Fix test not always checking the final bonus value
...
Due to the previous logic not waiting until the spinner had completed,
there could be false negatives as the check runs too early, with a
potential additional bonus spin occurring afterwards.
2022-02-22 14:28:15 +09:00
Dean Herbert
692ddd5f52
Merge branch 'master' into issues/16839-spun-out-rate
2022-02-22 14:04:45 +09:00
Dan Balasescu
567da9214e
Merge branch 'master' into osu-diff-calc-max-combo
2022-02-18 18:35:24 +09:00
Dean Herbert
7307e68e9c
Revert "Merge pull request #16889 from smoogipoo/remove-mod-multiplier"
...
This reverts commit 252b945d3ba1b39a96cf
2022-02-17 13:26:12 +09:00
Dean Herbert
28fcad9281
Update failing test to not account for no-longer-existing multiplier
2022-02-16 17:33:55 +09:00
Salman Ahmed
8b30c847f9
Update outdated bindable casts in tests
2022-02-16 08:39:08 +03:00
Salman Ahmed
0992bec2c8
Change "distance spacing" multipler type to double
...
Avoids losing precision on initial load, causing an unnecessary
hash change in `EditorChangeHandler`.
Resolves test failures in `TestSceneEditorChangeStates`
(https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true ).
2022-02-16 03:28:12 +03:00
Dean Herbert
d79845fb1d
Revert NUnit3TestAdaptor (again)
...
Console output is still broken. See
https://github.com/ppy/osu/runs/5196023462?check_suite_focus=true .
2022-02-15 17:06:34 +09:00
Dean Herbert
60153bb69d
Update nuget packages to highest usable versions
...
EF packages are intentionally pinned to 5.0.14 as higher versions no
longer support `netstandard2.1`, which we require for xamarin projects.
2022-02-15 15:19:23 +09:00
Salman Ahmed
500322ff21
Update failing snap test scenes
2022-02-15 02:21:53 +03:00
Salman Ahmed
528dc03b8c
Expose distance spacing in IPositionSnapProvider for updating distance grid
...
Alternate method is to expose a `SnapDistancesChanged` event in
`IPositionSnapProvider` instead, but I chose this way as an analogue to
`IBeatSnapProvider.BeatDivisor`, which might even make sense to be
exposed as `BindableBeatDivisor` instead of caching that separately.
2022-02-15 02:21:53 +03:00
Kaleb
95b1bffffe
Add test to ensure spinners only complete
...
No bonus or a non-300 judgement
2022-02-14 03:46:36 -05:00
Kaleb
c1777f20e1
Fix Spun Out tests
...
Change 'unaffected by mods' test to use dynamic RPM value instead of a fixed value
2022-02-14 03:11:44 -05:00
Dean Herbert
176bb4a4e2
Update desktop projects to target .NET 6
2022-02-10 17:42:09 +09:00
Dean Herbert
2731d8e3c2
Merge pull request #16701 from LeNitrous/mod-alternate-osu
...
Add "Alternate" mod for osu! ruleset
2022-02-03 10:41:23 +09:00
Dean Herbert
987aa5a21c
Add testing of different strengths
2022-02-02 16:26:00 +09:00
Dean Herbert
6b31e7e9db
Merge branch 'master' into aimassist-mod
2022-02-02 15:18:48 +09:00
Dean Herbert
104256a054
Add test coverage
2022-02-02 15:18:44 +09:00
Bartłomiej Dach
7cdf63c654
Remove unused FindProvider() methods
...
No longer needed since 39f99bf785
2022-02-01 21:53:21 +01:00
Nitrous
e408d8ef0e
rename Frames to ReplayFrames
2022-01-29 23:19:51 +08:00
