h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 20:02:58 +08:00
Code Issues Releases Wiki Activity
69,135 Commits 3 Branches 661 Tags 358 MiB
3e3ee3757c
Commit Graph

645 Commits

Author SHA1 Message Date
Dean Herbert
3ca2c90684 Add test scores in BeatmapLeaderboard test scene with more mods 2022-02-01 16:35:25 +09:00
Dean Herbert
f8939af5e6 Track loading via state as well 2022-01-31 01:12:03 +09:00
Dean Herbert
04dbb5d3c6 Disallow setting "NoScores" externally as it is handled internally 2022-01-30 16:18:19 +09:00
Dean Herbert
acc1199add Consolidate flows of Set operations, either result or error 2022-01-30 16:16:00 +09:00
Dean Herbert
c401629dd8 Also refactor placeholder logic to make more sense 2022-01-30 10:50:32 +09:00
Dean Herbert
06660ff960 Fix null beatmap in test scene 2022-01-30 03:02:56 +09:00
Dean Herbert
d21464ea61 Fix assertions to work in both directions 2022-01-30 02:54:51 +09:00
Dean Herbert
51acf79935 Change test exposure to property instead of method 2022-01-30 02:29:51 +09:00
Dean Herbert
9861c50b33 Remove pointless tests that no longer show anything valid 2022-01-30 00:03:22 +09:00
Dean Herbert
661fec7c8a Make score setter private 2022-01-29 23:58:57 +09:00
Bartłomiej Dach
04d6ca59a3
Merge branch 'master' into song-select-scroll-position-during-delete 2022-01-27 20:46:19 +01:00
Dean Herbert
e872877185
Merge pull request #16648 from peppy/fix-song-select-tests 
Fix song select tests not waiting for beatmap imports to arrive
 2022-01-27 23:00:58 +09:00
Dean Herbert
fae4f8bd8e Move nulling of previous songSelect to SetUpSteps instead 2022-01-27 21:59:44 +09:00
Dean Herbert
831fa44433 Fix song select tests not waiting for beatmap imports to arrive 
After the change to realm, notification fires could take a frame or two.
We aren't accounting for this.

Fixes test failures like
https://github.com/ppy/osu/runs/4963255990?check_suite_focus=true
 2022-01-27 19:35:42 +09:00
Dean Herbert
f2cecad83b Add failing test coverage showing carousel deletions don't keep scroll position 2022-01-27 16:52:02 +09:00
Dean Herbert
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
Dean Herbert
c0ed308016 Use more correct method of deletion in TestScenePlaySongSelect 2022-01-25 17:55:39 +09:00
Dean Herbert
778d2a71b4 Remove Task from the inner-most Import method in RealmArchiveModelImporter 
One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
 2022-01-25 15:30:29 +09:00
Dean Herbert
3e5c9e8436 Fix cases of Access instead of Realm 2022-01-25 12:58:15 +09:00
Dean Herbert
6eb2c28e41 Rename RealmContextFactory to RealmAccess 2022-01-24 20:38:07 +09:00
Dan Balasescu
581873f944
Merge pull request #16497 from peppy/top-local-rank-optimisation 
Rewrite `TopLocalRank` to use realm subscriptions
 2022-01-19 14:22:12 +09:00
Dan Balasescu
3e5d29ed00
Merge pull request #16505 from peppy/remove-base-difficulty-usage 
Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)
 2022-01-19 13:53:55 +09:00
Dean Herbert
201f2d7813 Add comprehensive test coverage for TopLocalRank 2022-01-19 13:48:00 +09:00
Dean Herbert
67bf95bc91 Remove all usage of AuthorString 2022-01-18 23:30:40 +09:00
Dean Herbert
7f65f3a47f Remove all usage of BaseDifficulty (and access Difficulty instead) 2022-01-18 22:57:39 +09:00
Dean Herbert
5dc7425b2c Fix incorrect realm (non-isolated instance) being used in two test scenes 2022-01-17 14:55:23 +09:00
Dean Herbert
9900a3f408 Remove outdated comment 2022-01-14 21:40:35 +09:00
Dean Herbert
289ae7c72f Update one more mismatched test implementation 2022-01-14 21:39:42 +09:00
Dean Herbert
a59dcccab7 Add local ContextFactory caching to all remaining test scenes that create local managers 2022-01-14 19:59:21 +09:00
Dean Herbert
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
Dean Herbert
38cc1ce098 Add missing ruleset in test scores 2022-01-12 18:51:30 +09:00
Dean Herbert
cd88ccab4f Fix TestScenePlaySongSelect failure due to detach clone depth 2022-01-12 17:49:11 +09:00
Dean Herbert
9e2ca583a3 Fix incorrect realm factory isolation in TestScenePlaySongSelect 2022-01-12 17:49:11 +09:00
Dean Herbert
8e79898e26 Fix a couple of minor issues with TestSceneBeatmapRecommendations 2022-01-12 17:49:10 +09:00
Dean Herbert
605898ec53 Add missing "non-null" elements missing from some tests 2022-01-12 17:49:10 +09:00
Dean Herbert
41d90cd0b5 Fix beatmap carousel test failures 2022-01-12 17:49:10 +09:00
Dean Herbert
43c7b0d2c8 Fix unsupported realm operations in multiple tests 2022-01-12 17:49:10 +09:00
Dean Herbert
e74a5022c9 Fix multiple tests via null checks and changing ToLive to Detach 
flow
 2022-01-12 17:00:17 +09:00
Dean Herbert
3811bd8520 Fix some null inspections 2022-01-12 17:00:16 +09:00
Dean Herbert
3152d2d8a0 "Update" BeatmapCarousel 2022-01-12 17:00:16 +09:00
Dean Herbert
00e3af3366 Update model manager and many related classes to get things compiling again 2022-01-12 17:00:00 +09:00
Dean Herbert
4f6a05ce3d Reimplement all query methods 2022-01-12 16:57:27 +09:00
Dean Herbert
53792811b2 more fixes (almost compiles, except ruleset and manager) 2022-01-12 16:57:27 +09:00
Dean Herbert
e6fdd0e969 Miscellaneous fixes that don't fit elsewhere 2022-01-12 16:39:36 +09:00
Dean Herbert
2cb97dd599 Remove unnecessary assigns of EF foreign ID fields in tests 2022-01-12 16:39:36 +09:00
Dean Herbert
37673f4cf8 Update sets of BeatmapSet.Metadata to instead create a Beatmap 2022-01-12 16:39:36 +09:00
Dean Herbert
e6f6558ddf Update mock model usage to set GUIDs instead of ints 2022-01-12 16:39:36 +09:00
Dean Herbert
00177a3ae1 Update usages to new naming 2022-01-06 22:54:43 +09:00
Dean Herbert
73b40e6833 Replace usage of .Result with .WaitSafelyForResult 2022-01-04 11:51:41 +09:00
Dean Herbert
031a40af6a Replace usages of Wait with WaitSafely 2022-01-04 11:51:41 +09:00
Bartłomiej Dach
f492cf84d9
Ensure presence of at least 1 difficulty for each ruleset 2021-12-20 11:34:39 +01:00
Dean Herbert
5c8e317a6e Chooser earlier items in song select tests to avoid potentially not having enough 2021-12-20 17:11:15 +09:00
Dean Herbert
af78a3e99d Fix weird loop logic 2021-12-20 17:09:08 +09:00
Dean Herbert
309290a3c9 Use new method in more places that can benefit from it 2021-12-13 16:56:43 +09:00
Dean Herbert
a73919917c Fix intermittent test failures in TestScenBeatmapInfoWedge due to async load 
https://github.com/ppy/osu/runs/4358685294?check_suite_focus=true

Occurs due to the wedge content also reloading on ruleset change, which
wasn't being accounted for. In a fail case, the content would change
during the "select beatmap" step's async load wait, causing incorrect
results.

51a353e12d/osu.Game/Screens/Select/BeatmapInfoWedge.cs (L70)
 2021-11-30 12:32:09 +09:00
Dan Balasescu
f712aeee01
Merge pull request #15795 from peppy/realm-integration/separate-download-flow 
Split out download logic from main manager classes
 2021-11-25 20:59:23 +09:00
Dean Herbert
a2ab9f457d Move score download logic out of ScoreManager 2021-11-25 17:33:04 +09:00
Dean Herbert
e6cfe44652 Fix occasional test failure due to default value oversight in TestSceneBeatmapCarousel 2021-11-25 16:29:06 +09:00
Dan Balasescu
e176083898
Merge pull request #15781 from peppy/beatmap-set-status 
Rename `BeatmapSetOnlineStatus` to `BeatmapOnlineStatus`
 2021-11-24 19:25:29 +09:00
Dean Herbert
183b95cbc2 Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus 
This variable is used at more than just a set level.
 2021-11-24 18:42:49 +09:00
Dean Herbert
0fe27cc8a1 Replace one more usage 2021-11-24 18:29:33 +09:00
Dean Herbert
7603f7eb36 Fix a few incorrectly updated arguments 2021-11-24 18:14:18 +09:00
Dean Herbert
0c819b9cfb Combine all test data BeatmapSetInfo creation into a single method 2021-11-24 18:07:32 +09:00
Dan Balasescu
74b6c33fab
Merge pull request #15778 from peppy/ruleset-info-id-usage 
Update usages of `RulesetInfo.ID` to use `OnlineID` instead
 2021-11-24 16:55:28 +09:00
Dean Herbert
f283770f34 Update mock RulesetInfo usage to set OnlineID instead of ID 2021-11-24 15:50:26 +09:00
Dean Herbert
44c34ca7b2 Revert changes causing BeatmapSet.Metadata to be expectedly null in some tests 2021-11-24 14:52:08 +09:00
Dean Herbert
8c60f37508 Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment 2021-11-24 13:27:37 +09:00
Dean Herbert
001f7c36f3 Use Equals in carousel tests for better realm compatibility 2021-11-22 17:20:21 +09:00
Bartłomiej Dach
15feb17da8
Change difficulty cache storage type to nullable 
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
 2021-11-20 17:00:50 +01:00
Dean Herbert
a4953b5658 Update some remaining test usage of database ID 2021-11-17 20:56:57 +09:00
Dean Herbert
7c2e79f911 Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
Dean Herbert
4856180912 Use new helper method 2021-11-15 19:19:53 +09:00
Dean Herbert
86b8fd3720 Fix TestSceneBeatmapRecommendations testing with an online ID of 0 2021-11-15 19:19:53 +09:00
Dean Herbert
692e846acd Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
Dean Herbert
6a098a8634 Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
Dean Herbert
51a353e12d Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
Dean Herbert
ebe58cee11 Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface 2021-11-11 17:19:46 +09:00
Dean Herbert
ed07ee8c61 Update all existing usages of AuthorString/AuthorId 
Unfortunately the getters need to be left in place else EF breaks.
 2021-11-04 18:59:37 +09:00
Dean Herbert
b9983add15 Rename User to APIUser and move to correct namespace 2021-11-04 18:21:31 +09:00
Dean Herbert
9c926e5514 Remove BeatmapSetInfo.OnlineInfo and all usages 2021-11-04 15:23:04 +09:00
Bartłomiej Dach
0d65493b56
Mark test usages of Ruleset.CreateInstance() as returning non-null 2021-11-01 12:12:21 +01:00
Dean Herbert
bb9769aa17 Fix null ruleset in another place 2021-10-29 20:12:12 +09:00
Dean Herbert
22c2f48e4d Fix more null rulesets 2021-10-29 19:05:42 +09:00
Dean Herbert
a16c8f1ebc Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet 2021-10-29 18:50:55 +09:00
Dean Herbert
04acc7601c Fix one more missed case 2021-10-29 18:35:15 +09:00
Dean Herbert
07e3ced315 Fix test scene and remove "impossible" nullable coalesce 2021-10-29 18:22:23 +09:00
Dean Herbert
3598adb344 Fix test implementing old version of class 2021-10-29 17:04:56 +09:00
Dean Herbert
2c308f3008 Rename BeatmapMetrics to APIFailTimes 2021-10-25 15:34:41 +09:00
Dean Herbert
20baae9094 Move online metrics out of BeatmapInfo model 2021-10-25 15:32:18 +09:00
Dean Herbert
045dd94a6e Move online metrics out of BeatmapSetInfo model 2021-10-25 15:12:39 +09:00
Dean Herbert
3964e5c448 Fix test failure due to retyped class 2021-10-14 14:11:12 +09:00
smoogipoo
91c286b1ad Fix intermittent TestScenePlaySongSelect test failures 2021-10-12 22:07:57 +09:00
Dean Herbert
94153e8bba Fix TestDifficultyIconSelectingForDifferentRuleset potentially failing due to async load 2021-10-05 18:06:24 +09:00
Dan Balasescu
4bd1083388
Merge pull request #14903 from peppy/importer-returns-live 
Add `ILive<T>` and use as return type of `Import` methods
 2021-10-04 20:16:32 +09:00
smoogipoo
4871db2f86 Merge branch 'master' into importer-returns-live 2021-10-04 19:42:36 +09:00
Dean Herbert
853cf6feaa Rename last remaining BeatmapInfo Beatmap usage 2021-10-04 17:35:53 +09:00
Dean Herbert
ec61c3c5ee Rename all remaining cases 2021-10-03 00:55:29 +09:00
Dean Herbert
973c31132b Rename BeatmapInfo variables which were named beatmap for clarity 2021-10-02 12:45:34 +09:00
Dean Herbert
a2e61883e3 Initial push to use ILive in import process 2021-09-30 22:55:25 +09:00
Dean Herbert
9cf79a80c2 Replace many more calls to CreateAllMods with more specific calls 2021-09-10 12:04:55 +09:00
Dean Herbert
cf633973a9 Refactor exposed mod retrieval methods for better safety 2021-09-10 11:09:13 +09:00
smoogipoo
df7480e68c Fix bindable implementation being synchronous 2021-09-01 20:56:23 +09:00
Bartłomiej Dach
e4a8f72167
Add failing test case 2021-08-22 19:16:43 +02:00
Dean Herbert
7021133029 Merge branch 'master' into temporary-directory-test-storage 2021-08-20 11:54:33 +09:00
Dean Herbert
2758a83d55 Fix TestSettingsMigration's usage of RecycleLocalStorage 2021-08-18 16:39:10 +09:00
Salman Ahmed
eb6c6830bc Add visual test slider for changing star difficulty in beatmap wedge 2021-08-17 05:46:14 +03:00
Dean Herbert
665bd3690a Add a few cases of missing ConfigureAwait calls in tests project 2021-07-30 15:27:24 +09:00
Dean Herbert
78c74e97d1 Change to alternative formatting 2021-07-12 18:08:19 +09:00
Dean Herbert
3642febbb6 Fix one new incorrect formatting inspection from EAP6 2021-07-12 12:35:40 +09:00
Dean Herbert
ec71deec51 Remove some mentions of "lazer" 
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
 2021-07-04 12:41:27 +09:00
Dean Herbert
fcb0b8d825 Add test coverage 2021-06-14 15:06:33 +09:00
Dean Herbert
b06477a1f5 Split out tests into individual test methods 2021-06-14 14:35:24 +09:00
Dean Herbert
b16d10bd95 Provide game-wide resources via IStorageResourceProvider 2021-05-31 18:57:47 +09:00
Dean Herbert
ba80361c4c Fix tests that were previously doing reference comparisons 2021-05-28 18:38:50 +09:00
Dean Herbert
5c44083856 Fix test potentially not waiting for drawable beatmaps to be loaded 2021-05-27 16:12:49 +09:00
Salman Ahmed
db361efecf Add test beatmap difficulty cache with calc. blocking support 2021-05-14 15:53:56 +03:00
Dean Herbert
52ce16f9f1
Merge branch 'master' into player-loader-star-rating 2021-05-10 12:46:10 +09:00
Dean Herbert
9ba412d27e Add the osu! logo to the test scene 
Makes no sense to add a test intended to test visual behaviour with one
of the main elements missing. Not sure how you would be able to test the
flow with the logo's presence.
 2021-05-10 12:44:08 +09:00
Dean Herbert
b7acf9de52 Make test work without manually clicking things 2021-05-10 12:36:56 +09:00
Dean Herbert
2b90bc4f1f Remove unnecessary ruleset switching steps 2021-05-10 12:35:37 +09:00
Dean Herbert
0c973feb53 Tidy up test scene 2021-05-10 12:34:21 +09:00
Joseph Madamba
8964d51de9 Add ability to sort by source in song select 2021-05-09 14:10:38 -07:00
Salman Ahmed
8fba655d2e Allow changing ruleset during test 2021-05-08 23:02:38 +03:00
Salman Ahmed
f701c331f2 Add initial fade in to the metadata display 
Avoids first frame discrepancies from appearing in the test scene, those can be delt with later on, if needed.
 2021-05-08 21:19:46 +03:00
Salman Ahmed
ca55287dd0 Pass empty facade and replace random property with method instead 2021-05-08 18:43:45 +03:00
Salman Ahmed
d9605e8070 Remove test scene description 2021-05-08 18:18:23 +03:00
Salman Ahmed
26c0010fe6 Fix test not handling 0 beatmap sets 2021-05-08 13:03:50 +03:00
Salman Ahmed
dca5efc59a Remove no longer necessary ruleset info requirement 2021-05-08 13:00:39 +03:00
Salman Ahmed
b4801faf32 Pass ruleset info to constructor instead 
Follows the way working beatmap is passed, not sure why mods are passed as a bindable though, don't wanna bother too much with that.
 2021-05-08 11:57:13 +03:00
Salman Ahmed
169a283402 Add visual test scene 2021-05-08 11:47:18 +03:00
Dean Herbert
165f443ab5 Merge branch 'master' into add-missing-author-links 2021-05-07 14:32:44 +09:00
Dean Herbert
fe9ade6754 Rename Container to DisplayedContent 2021-05-06 02:14:04 +09:00
Denrage
b6b9a69601 Removed unnecessary class for wrapping 2021-05-05 18:50:49 +02:00
Dean Herbert
4ef901d08d Remove unnecessary redirection property to Container.Info 2021-05-05 21:07:49 +09:00
Denrage
0dfd0bb59d Refactored background of BeatmapInfoWedge 2021-04-21 15:46:11 +02:00
Denrage
9fba87f67a Moved Info and Background into own container 2021-04-21 15:43:29 +02:00
Denrage
505a117862 splitted updateable part of wedge 2021-04-20 10:37:52 +02:00
Denrage
c73bbf0aa7 Fixed Tests 2021-04-19 19:24:58 +02:00
Dean Herbert
b4c6894d13 Add test coverage for song select footer area 2021-04-07 18:29:31 +09:00
PercyDan54
1ff77754fd
Use OnlineViewContainer 2021-04-02 20:14:31 +08:00
Dean Herbert
aeff9bd853 Add return bool to HandleRequest to better trigger failures 2021-03-23 18:17:29 +09:00
Bartłomiej Dach
a16c0641b2 Revert EF Core to version 2.2 
This reverts commit f3faad74d5, reversing
changes made to 712e7bc7bf.

Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
 2021-03-21 11:05:15 +01:00
smoogipoo
7fa5fd5647 Update usages of config with framework changes 2021-03-17 16:10:16 +09:00
Dean Herbert
fce21f23d6 Add comments marking workarounds required for EFcore 5 2021-03-15 13:29:26 +09:00
Roman Kapustin
c6c616f244 Actualize tests 2021-03-11 21:02:40 +03:00
smoogipoo
01a4815412 Make labels disappear on null beatmap/no hitobjects 2021-02-25 23:36:02 +09:00
Dean Herbert
3802cb29a4 Fix failing tests doing reference comparisons between string and LocalisedString 2021-02-25 17:49:54 +09:00
Dean Herbert
90e8308716 Merge branch 'master' into localisation-refactor-framework 2021-02-25 17:28:55 +09:00
Dean Herbert
1fd76ea3fb Apply changes to UI components overriding functions with changing signatures 2021-02-22 19:01:42 +09:00
Dean Herbert
cdbf8de29d Update other tests which can benefit from using a shorter beatmap 2021-02-22 14:53:32 +09:00
Bartłomiej Dach
924f91ed9b Fix song select test doing the completely wrong thing 2021-01-08 15:56:35 +01:00
Dean Herbert
c6be969e33 Remove unnecessary resolved recommender in test 2020-12-22 14:42:12 +09:00
Endrik Tombak
e792f07084 Add test for recommending current ruleset 2020-12-03 20:07:42 +02:00
Endrik Tombak
48dad61a46 Apply review suggestions 2020-12-03 19:44:12 +02:00
Endrik Tombak
cbbcf36eaa Merge branch 'master' of https://github.com/ppy/osu into present-recommended 2020-12-03 19:38:32 +02:00
Dean Herbert
07e14b1267 Disable unnecessary inspection 2020-12-01 01:37:53 +09:00
Dean Herbert
b401259f84 Add test coverage 2020-12-01 01:19:39 +09:00
Dean Herbert
f8db7a9902 Remove ScrollableContent container from carousel 
This was causing multiple issues with masking and sizing and really
didn't need to exist in the first place. Also not sure why the pool was
nested inside the scroll container, but it isn't any more. Probably for
the best.
 2020-11-26 18:28:54 +09:00
Endrik Tombak
07db977af5 Remove no longer necessary force calculation 
Is no longer necessary because recommender uses bindable state value changes, compared to when the test was written, and runs the state change once on load
 2020-11-21 14:36:43 +02:00
Endrik Tombak
944f3480c2 Merge branch 'master' of https://github.com/ppy/osu into present-recommended 
 Conflicts:
	osu.Game/OsuGameBase.cs
	osu.Game/Screens/Select/DifficultyRecommender.cs
	osu.Game/Screens/Select/SongSelect.cs
 2020-11-21 14:01:01 +02:00
Joehu
ef3c918a3c Simplify input buttons/keys in tests 2020-11-09 14:18:20 -08:00
Bartłomiej Dach
164370bc7d Resolve more CA1805 inspections 2020-11-01 20:51:23 +01:00
Dean Herbert
467bb9b96f
Merge branch 'master' into beatmap-carousel-refactor 2020-10-19 13:17:11 +09:00
Dean Herbert
88ffcb9234 Update EndsWith usages 2020-10-16 12:58:34 +09:00
Dean Herbert
5d11db7753 Locallise ChildItems to DrawableCarouselBeatmapSet for clarity 2020-10-13 19:31:29 +09:00
Dean Herbert
4160feb3da Add test specifically for many panels visible 2020-10-13 17:37:33 +09:00
Dean Herbert
1f0aa974dd Fix failing tests 2020-10-13 17:37:33 +09:00
Dean Herbert
dd8943eb7f Update test scene to fix crash 2020-10-13 17:37:33 +09:00
Dean Herbert
9814e9ba7f Split classes out to reduce loc burder on DrawableCarouselBeatmapSet 2020-10-13 17:37:33 +09:00
Dean Herbert
580ea62710 Temporarily increase test beatmap count for perf testing 2020-10-13 17:37:33 +09:00
Dean Herbert
3143224e5b Refactor how drawable carousel items are constructed 2020-10-13 17:37:33 +09:00
Dean Herbert
dbfaa4a0df Remove beatmap paths from tests where they would result in exceptions 2020-09-15 22:50:44 +09:00
Dean Herbert
d03bfec807
Merge branch 'master' into fix-test-storage-weirdness 2020-09-15 16:54:06 +09:00
Dean Herbert
3242b10187 Change order of dependency caching to promote use of locals 2020-09-15 15:00:04 +09:00
Dean Herbert
15e423157b Fix tests that access LocalStorage before BDL 2020-09-15 14:17:40 +09:00
Joehu
c833f5fcc4 Reorder buttons to match stable 2020-09-14 11:23:41 -07:00
Joehu
c30174cea3 Add manage collections button to beatmap options 2020-09-14 11:21:23 -07:00
Joehu
ce9c63970c Fix button colors in beatmap options test 2020-09-14 11:20:43 -07:00
Joehu
1a8a7ae7f8 Remove hardcoded key param from AddButton 2020-09-14 11:19:18 -07:00
smoogipoo
4061480419 Rename menu item 2020-09-11 16:02:46 +09:00
smoogipoo
6b56c6e83f Rename to CollectionMenuItem 2020-09-09 23:11:19 +09:00
smoogipoo
43525614ad Store raw BeatmapCollection in filter control 2020-09-09 23:10:21 +09:00
smoogipoo
4ddf5f054b Rename BeatmapCollectionManager -> CollectionManager 2020-09-09 15:31:08 +09:00
smoogipoo
4962213cc4 Rename manage collections filter/text 2020-09-08 18:42:55 +09:00
smoogipoo
f581df47c8 Add "New collection..." item to dropdown 2020-09-08 18:25:09 +09:00
smoogipoo
bee450ae1e Fix tests/add placeholder item tests 2020-09-08 17:05:51 +09:00
smoogipoo
c2da3d9c84 Fix button input and tests 2020-09-08 14:36:38 +09:00
smoogipoo
525026e7f0 Fix tests failing due to timings 2020-09-08 13:23:58 +09:00
smoogipoo
ca4423af74 Fix tests 2020-09-08 00:07:12 +09:00
smoogipoo
e37c04cb6d Change back to solid icon 2020-09-08 00:04:03 +09:00
smoogipoo
a1214512bc Add filter control tests 2020-09-07 23:57:49 +09:00
smoogipoo
6cc4517600 Merge branch 'master' into collection-database 2020-09-07 20:03:11 +09:00
smoogipoo
4459287b35 Add filter control test scene 2020-09-02 20:25:12 +09:00
smoogipoo
ed74c39b55 Move UserTopScoreContainer into base leaderboard 2020-08-31 19:54:22 +09:00
Dan Balasescu
69548447a7
Adjust step name 2020-07-13 20:03:07 +09:00
Dean Herbert
cd3500510e Fix carousel tests relying on initial selection being null 2020-07-13 17:05:29 +09:00
Dean Herbert
c36d9d4fc3 Add test coverage 2020-06-25 20:01:29 +09:00
smoogipoo
702bd2b65d Fix potential nullref in test 2020-06-11 13:41:53 +09:00
Dean Herbert
93572fc17d
Merge branch 'master' into present-recommended 2020-06-03 12:31:23 +09:00
smoogipoo
648999a2de Remove all RequiredTypes usages 2020-05-16 18:17:12 +09:00
Dean Herbert
81889e0034 Fix tests potentially selecting a deleted beatmap 2020-05-04 15:20:43 +09:00
Dean Herbert
02b9f51bdd Add failing test 2020-05-04 15:20:43 +09:00
Dean Herbert
a1cd007cad Fix song select tests potentially failing due to difficulty panels not yet displayed 2020-05-04 14:44:53 +09:00
Endrik Tombak
d30e4061cc Add clarifying comment about pp choice 2020-05-01 19:46:49 +03:00
Endrik Tombak
3cf60e6e00 Add failing test 2020-05-01 19:43:18 +03:00
Bartłomiej Dach
2913a81835 Improve test code quality & safety 2020-05-01 16:59:45 +02:00
Endrik Tombak
33a608fd15 Merge branch 'master' of https://github.com/ppy/osu into present-recommended 
 Conflicts:
	osu.Game/Screens/Select/SongSelect.cs
 2020-05-01 11:06:20 +03:00
Dean Herbert
cf4e79cf38 Show loading spinner when carousel is not ready to be displayed 2020-04-30 11:51:06 +09:00
Endrik Tombak
f68a7401b9 Fix comment 2020-04-25 10:37:18 +03:00
Endrik Tombak
e65acc3401 Other review suggestions 2020-04-25 10:36:19 +03:00
Endrik Tombak
e906ec4d92 Fix typo 2020-04-25 10:25:07 +03:00
Endrik Tombak
52416ea90a Use GetRuleset 2020-04-25 10:22:19 +03:00
Endrik Tombak
ce47b7ca93 Unnest in SetUpSteps 2020-04-25 10:21:01 +03:00
Endrik Tombak
657bf5ad86 Merge branch 'master' of https://github.com/ppy/osu into present-recommended 2020-04-25 10:13:57 +03:00
Endrik Tombak
90fa58b3b6 More testing 2020-04-17 19:57:39 +03:00
Dean Herbert
5833a7ac91 Fix presenting new ruleset and beatmap at once causing wedge display desync 2020-04-17 18:56:17 +09:00
Endrik Tombak
da9bd74e2e Very basic testing 2020-04-15 20:19:17 +03:00
Dean Herbert
c0c1f2c023 Add test coverage 2020-04-11 17:17:18 +09:00
Endrik Tombak
35f97dfc75 Style changes 2020-04-09 18:59:18 +03:00
Endrik Tombak
caa404f8fa Remove test for now 2020-04-09 18:48:13 +03:00
Dean Herbert
260de77304
Merge branch 'master' into select-recommended 2020-04-09 15:30:35 +09:00
Endrik
f4c8b6d219
Fix copy paste oversight 2020-03-29 18:55:47 +03:00
Dean Herbert
a72f0f57f6 Refactor tests for readability 2020-03-30 00:05:07 +09:00
Dean Herbert
07c7233b3d Change int div comments 2020-03-29 23:46:28 +09:00
Endrik Tombak
8cab303611 Cover skipDifficulties = false in tests 2020-03-28 21:02:55 +02:00
Endrik Tombak
63f6269eb0 Test both ways 2020-03-28 13:10:20 +02:00
Endrik Tombak
659865b457 Use understandable set id 2020-03-28 13:08:06 +02:00
Endrik Tombak
e707adb773 Increase amount of test sets 2020-03-26 21:16:10 +02:00
Endrik Tombak
902734b75e Add failing test 2020-03-26 20:32:43 +02:00
Endrik Tombak
bbbaaae3ee Write tests 2020-03-26 19:18:16 +02:00
Dan Balasescu
d0c7b49376
Merge branch 'master' into fix-carousel-root-selects-from-nothing 2020-03-23 11:34:04 +09:00
smoogipoo
bf70276496 Fix test re-using the same beatmap sets 2020-03-23 11:12:36 +09:00
Dean Herbert
8136ea561e Fix a couple of broken tests 2020-03-20 15:02:13 +09:00
Dean Herbert
9b60b535e5 Fix selection not occurring when switching from empty ruleset on first load 2020-03-20 15:01:26 +09:00
Dean Herbert
3a50c4bb51 Update tests 2020-03-19 18:58:22 +09:00
Dean Herbert
9bb3a6c677 Merge branch 'master' into click-group-difficulty-icons 2020-03-16 12:01:09 +09:00
Dean Herbert
d6be8eec0c Merge branch 'master' into click-disabled-difficulty-icons 2020-03-16 11:30:57 +09:00
Dan Balasescu
bd05462a7f
Merge branch 'master' into carousel-selection-fallback-improvement 2020-03-16 10:53:10 +09:00
Dan Balasescu
25a35a1370
Merge branch 'master' into always-apply-ruleset-filter 2020-03-16 10:32:36 +09:00
Dean Herbert
de9857ccdc Fix incorrect id reference in test 2020-03-13 11:02:53 +09:00
Dean Herbert
ba0dec891d Update test temporarily 2020-03-13 10:58:36 +09:00
Dean Herbert
bab197553e Update carousel test logic to match new carousel selection behaviour 2020-03-12 19:55:25 +09:00
Dean Herbert
250061ddf5 Fix test failure due to off-screen panel 2020-03-12 19:46:21 +09:00
Dean Herbert
1819a15509 Make test ID assigning simpler 2020-03-12 19:27:54 +09:00
Dean Herbert
db5c8043db Add test covering ruleset change on difficulty icon selection 2020-03-12 18:42:08 +09:00
Dean Herbert
6e11c3014c Allow grouped difficulty icons to be clicked 2020-03-12 18:42:08 +09:00
Dean Herbert
2bcf079386 Update carousel test logic to match new carousel selection behaviour 2020-03-12 18:42:08 +09:00
Dean Herbert
5537b279de Fix failing test occasionally getting wrong ruleset beatmap 2020-03-12 18:39:43 +09:00
Dean Herbert
933a8ffc8a Add test coverage 2020-03-12 17:10:51 +09:00
Dean Herbert
28ac5af91c Fix beatmap carousel tests loading beatmap manager beatmaps in test browser 2020-03-12 16:53:23 +09:00
Dean Herbert
7b368dca35 Add test coverage 2020-03-11 02:59:24 +09:00
Dean Herbert
a047456354 Revert changes to make HitObject abstract 2020-02-25 19:07:15 +09:00
Dean Herbert
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement 
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
 2020-02-23 13:49:06 +09:00
Dean Herbert
cd666166d5
Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select 
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
 2020-02-21 10:24:12 +09:00
smoogipoo
1a689231c2 Support null leaderboard position 2020-02-20 14:51:25 +09:00
voidedWarranties
8c81f1e684 Move CarouselBeatmap access to private, test using indices 2020-02-15 17:51:55 -08:00
voidedWarranties
8e1ecddb1d Add testing 2020-02-14 17:23:24 -08:00
Dean Herbert
333f976580 Fix test finding deleted beatmaps under dotnet-test 2020-02-11 17:47:10 +09:00
Dean Herbert
926cde9afc Fix potential test failures 2020-02-10 18:17:59 +09:00
Dean Herbert
d61516e10c Add failing tests 2020-02-10 16:59:54 +09:00
Dan Balasescu
93952d438f
Merge pull request #7677 from peppy/decouple-mod-select-bindable 
Decouple ModSelectOverlay from global SelectedMods
 2020-02-03 16:27:47 +09:00
Dean Herbert
9183c78319 Fix crash on exiting song select with ctrl-enter autoplay 2020-02-03 16:04:32 +09:00
Bartłomiej Dach
e90ae667b7 Add failing tests 2020-02-01 16:08:24 +01:00
Bartłomiej Dach
a74d22d9e5 Extract beatmap stats test to separate scene 2020-02-01 15:50:33 +01:00
Dean Herbert
ab7bbf38a8 Set default beatmap later in test initialisation 2020-01-31 16:14:55 +09:00
Dean Herbert
5f48affcba Centralise screen exit logic to ScreenTestScene 2020-01-31 14:19:29 +09:00
smoogipoo
f457ecaf83 Fix random test failures 2020-01-29 13:54:12 +09:00
Dean Herbert
fd7f07433d Ensure selection has occurred before storing value 2020-01-27 18:26:44 +09:00
Dean Herbert
1f0aaabf7b Add tests 2020-01-27 12:21:17 +09:00
smoogipoo
bb390b4470 Add test 2020-01-24 19:40:20 +09:00
Dean Herbert
56724d2580
Merge branch 'master' into #7146 2020-01-10 01:08:20 +08:00
Dean Herbert
ab9603b06a Merge remote-tracking branch 'upstream/master' into #7146 2020-01-09 17:08:12 +08:00
smoogipoo
91735ff367 Update MathUtils namespace usages 2020-01-09 13:43:44 +09:00
Lucas A
3bd3ebad49 Move placeholders to a dedicated namespace 2020-01-04 19:56:34 +01:00
Willy Tu
e23c71be80 Update Resolved and Cached attribute issues 2020-01-03 11:34:26 -08:00
Willy Tu
0a4e180ce7 Merge branch 'master' of github.com:ppy/osu into #7146 2020-01-03 11:32:06 -08:00
Dean Herbert
69227d6179 Add asserts 2019-12-22 06:37:18 +09:00
Dean Herbert
725008286f Move test and remove pointless duplicate tests 2019-12-22 06:09:16 +09:00
Dean Herbert
df14f473c2 Split tests out 2019-12-20 19:52:54 +09:00
Willy Tu
6abbd33b51 Fixed CI issues 2019-12-19 21:57:14 -08:00
Willy Tu
8ab26e8889 Update Tests with dependencies on LeaderboardScore. Added its dependency on DialogOverlay for the tests. Added test for deleting individual local score 2019-12-19 21:29:54 -08:00
Dean Herbert
54572b6de9 Update selected mdos references 2019-12-18 16:42:18 +09:00
Dean Herbert
d7eb4f73f4
Merge branch 'master' into update-beatmap-settings 2019-12-16 14:57:57 +09:00
Dean Herbert
bc31146560 Mods -> SelectedMods 2019-12-13 21:45:38 +09:00
unknown
3945e7403a improve tests and refactor AdvancedStats 2019-12-13 09:39:54 +08:00
unknown
ec5b506960 apply mod difficulty settings during song select 2019-12-12 23:41:46 +08:00
Dean Herbert
cdde5d1d69 Fix song select filters not reapplied if in a child screen 
Closes https://github.com/ppy/osu/issues/6980.
 2019-12-10 02:30:23 +09:00
Dean Herbert
f0d49d0cdf Decouple APILegacyScoreInfo from ScoreInfo 2019-12-03 15:31:11 +09:00
Dean Herbert
296fff9243 Merge remote-tracking branch 'upstream/master' into fix-carousel-double-filter 2019-11-15 18:20:36 +09:00
Dean Herbert
b8bb97607b Merge remote-tracking branch 'upstream/master' into fix-mod-retention 2019-11-15 13:46:44 +09:00
Dean Herbert
e81dfcad4c Fix remaining cases of pollution 2019-11-15 11:46:32 +09:00
Dean Herbert
22c3be2c6f Clear count variables on carousel creation 2019-11-15 11:26:01 +09:00
Dean Herbert
1109d201c3 Add failing test 2019-11-14 13:28:13 +09:00
Dean Herbert
2fe068174a Fix unnecessary string interpolation 2019-11-13 19:42:33 +09:00
Dean Herbert
2cd156f3d4 Clean up carousel tests 2019-11-13 19:09:03 +09:00
Dean Herbert
bca1be0bfa Add failing test 2019-11-13 18:54:33 +09:00
Huo Yaoyuan
ccc8aa6fa4 Apply brace style. 2019-11-11 20:13:13 +08:00
Bartłomiej Dach
022cc13952 Add beatmap carousel item sorting stability test 
Add visual test to ensure sorting stability when sorting criteria are
applied in the beatmap carousel.
 2019-10-27 22:55:46 +01:00
smoogipoo
12cd57744b Make RulestStore initialise at construction time 2019-10-15 16:14:06 +09:00
Dan Balasescu
69b9e359bf
Merge branch 'master' into fix-ss-track-playback 2019-10-09 12:26:07 +09:00