OpenSauce04
36108ea841
Moved CheckValidNewAction checks into checkCorrectAction
2023-03-06 11:11:38 +00:00
OpenSauce04
4ae2661f1b
Removed useless null checks
2023-03-06 11:00:37 +00:00
OpenSauce04
ac6c8e600a
Updated a comment for correctness
2023-03-06 10:59:47 +00:00
OpenSauce04
a7be59175d
Made private + renamed Taiko Single Tap tracking variables for better readability
2023-03-06 10:59:22 +00:00
OpenSauce04
50b0fca264
Code formatting
2023-03-03 18:11:29 +00:00
OpenSauce04
865f785f50
Fixed an issue where Taiko's Single Tap could allow alternation under very specific circumstances
2023-03-03 17:13:39 +00:00
OpenSauce04
d4bb08a440
Fixed CodeInspector complaining
2023-02-28 18:38:09 +00:00
OpenSauce04
0a76c8ee7f
Further simplified a type check
2023-02-28 15:41:06 +00:00
OpenSauce04
8851da05f1
Merge branch 'taiko-single-tap' of https://github.com/OpenSauce04/osu into taiko-single-tap
2023-02-28 15:37:54 +00:00
OpenSauce04
616f7b3f64
Simplified a type check
2023-02-28 15:37:46 +00:00
OpenSauce
781da032e9
Merge branch 'master' into taiko-single-tap
2023-02-28 15:22:41 +00:00
OpenSauce04
3aa8c81c5d
Added missing mod incompatabilities
2023-02-28 15:20:53 +00:00
OpenSauce04
7c84a84fbe
Removed TaikoInputBlockingMod, and instead moved code into TaikoModSingleTap
2023-02-28 15:14:03 +00:00
Dean Herbert
044b0604b2
Move OmitFirstBarLine to TimingControlPoint
2023-02-28 19:29:31 +09:00
OpenSauce04
beb04379f9
Inverted an if statement for code clarity
2023-02-27 22:36:09 +00:00
OpenSauce
8d747f2402
Fixed grammar mistake in Taiko Relax mod description
2023-02-27 16:06:33 +00:00
OpenSauce
25ef1f199d
Update description for Taiko Single Tap mod
2023-02-27 15:22:06 +00:00
OpenSauce04
12a2037086
Removed useless TaikoAction check from TaikoInputBlockingMod
2023-02-27 14:39:12 +00:00
OpenSauce04
d823faed08
Remove unused flash_duration const
2023-02-27 14:33:47 +00:00
OpenSauce04
dd9194b976
Code formatting fix
2023-02-27 13:58:40 +00:00
OpenSauce04
12b983495c
Fixed issues caused by branch being stale
2023-02-27 13:40:55 +00:00
OpenSauce04
f2cada4584
Strong drumrolls no longer allow all actions to be used
2023-02-27 13:18:08 +00:00
OpenSauce04
b883c6af34
Renamed all instances of Taiko's InputBlockingMod to TaikoInputBlockingMod
2023-02-27 13:18:08 +00:00
OpenSauce04
715df42a69
Strong hits are now allowed to be hit
2023-02-27 13:18:08 +00:00
OpenSauce04
17a05de107
Initial Taiko single tap implementation (still needs code to allow for Strong hits)
2023-02-27 13:18:08 +00:00
Dean Herbert
da8ab7143b
Merge branch 'master' into maximum-judgement-offset-in-hit-object
2023-02-15 14:48:15 +09:00
Bartłomiej Dach
67b6df3172
Reword ambiguous xmldoc
2023-02-12 13:31:29 +01:00
Dean Herbert
9d09141ab7
Move taiko-specific property out of DrawableHitObject
2023-02-12 16:09:28 +09:00
Dean Herbert
ad8b01b478
Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions
...
Always add to additions soundbank in `convertSoundType`
2023-02-10 17:14:29 +09:00
sw1tchbl4d3
51816b92c6
Add conversion tests
2023-02-09 23:23:58 +01:00
sw1tchbl4d3
2e2ab4081b
Make LargeBonus a valid HitResult in taiko
2023-02-09 21:22:34 +01:00
Dean Herbert
34d1890f1c
Change snapping to only apply to classic mod
2023-02-09 18:22:14 +09:00
OpenSauce
df1355ea4b
Taiko hit objects now snap to hit target
2023-02-08 10:59:08 +00:00
Bartłomiej Dach
11685d427a
Merge branch 'master' into taiko-touch-ddkk-new
2023-02-04 21:54:38 +01:00
Dean Herbert
bc02fb0e32
Remove redundant parameter in DrumSegment constructor
2023-02-03 16:37:35 +09:00
Dean Herbert
ffbaf453f8
Revert misordered drawable order
...
This will completely change the visual appearance of this control... not
sure why it was changed.
2023-02-02 16:25:23 +09:00
Dean Herbert
eb62ba09aa
Completely refactor to match project code standards
2023-02-02 16:23:27 +09:00
Dean Herbert
b182178340
Merge pull request #22325 from sw1tchbl4d3r/sv_scaling
...
Move fixed scroll speed change out of classic mod for taiko
2023-01-25 12:55:43 +09:00
sw1tchbl4d3
d4e5d7a873
Move fixed scroll speed change out of classic mod for taiko
2023-01-21 22:29:28 +01:00
ekrctb
11e1b22bf5
Move MaximumJudgementOffset to HitObject
...
We want to access this property for computing lifetime
2023-01-19 21:23:55 +09:00
Dean Herbert
70cb23bbc9
Merge branch 'master' into mod-accuracy-challenge
2023-01-17 16:46:54 +09:00
OpenSauce04
25a920732f
Addressed code formatting issues
2023-01-12 19:04:37 +00:00
OpenSauce
92def3daf4
Renamed QuarterCircle class to DrumSegment
2023-01-12 18:20:03 +00:00
OpenSauce
f2ec0b2176
Made QuarterCircle property loading less clapped
2023-01-12 18:17:50 +00:00
OpenSauce
927fccb7be
Taiko touch control scheme can now be changed mid-map
2023-01-12 17:55:05 +00:00
OpenSauce
767c3cb523
Revert "getTaikoActionFromDrumSegment and getColorFromTaikoAction are now run from within QuarterCircle constructor"
...
This reverts commit 985b126cba
2023-01-12 17:20:07 +00:00
OpenSauce04
985b126cba
getTaikoActionFromDrumSegment and getColorFromTaikoAction are now run from within QuarterCircle constructor
2023-01-12 16:06:03 +00:00
OpenSauce
026a223129
Cleaner way of getting ForceControlScheme value
...
Co-authored-by: Susko3 <Susko3@protonmail.com>
2023-01-11 20:39:45 +00:00
OpenSauce04
a0ff03def3
Fixed some formatting
2023-01-11 20:06:43 +00:00
OpenSauce
32d1d5a34a
Added tests for new Taiko touch control schemes
2023-01-11 12:04:52 +00:00
OpenSauce
944c6759d9
Fixed right rim being incorrectly layered above right centre
2023-01-10 23:13:22 +00:00
OpenSauce04
ce37760b27
Removed unnecessary coma
2023-01-10 20:05:41 +00:00
OpenSauce04
57467e7b39
Touchscreen drum now uses a 2d array rather than nested switches to get TaikoActions for control scheme
2023-01-10 20:04:57 +00:00
OpenSauce04
2b58862567
Added ArgumentOutOfRangeException throws
2023-01-10 19:31:31 +00:00
OpenSauce04
2800eeac56
Simplified formatting; Removed warning suppressors
2023-01-10 19:23:49 +00:00
OpenSauce04
3c13d64d1e
Merge branch 'taiko-touch-ddkk-new' of https://github.com/OpenSauce04/osu into taiko-touch-ddkk-new
2023-01-10 19:21:06 +00:00
OpenSauce04
edd2084a0e
Replaced all instances of TaikoInput with TaikoAction
2023-01-10 19:21:04 +00:00
OpenSauce
7cb5ca905a
Simplified getColourFromTaikoAction switch case
...
Co-authored-by: Stedoss <29103029+Stedoss@users.noreply.github.com>
2023-01-10 19:17:33 +00:00
OpenSauce
18e114904a
configTouchControlScheme is now read only
...
Co-authored-by: Stedoss <29103029+Stedoss@users.noreply.github.com>
2023-01-10 19:13:10 +00:00
OpenSauce04
21b617062a
Removed an unnecessary newline
2023-01-10 16:24:02 +00:00
OpenSauce04
362c9050df
Fixed OsuColour shenanigans
2023-01-10 15:08:18 +00:00
OpenSauce
b3e620c8e5
Removed unnecessary parameter
2023-01-10 13:07:07 +00:00
OpenSauce
bf555e4579
Removed unnecessary directives that were added automatically and I forgot to remove
2023-01-10 12:44:27 +00:00
OpenSauce
ffd6168a61
Removed unnecessary newlines
2023-01-10 12:13:51 +00:00
OpenSauce
906ea80d52
Further improved method of getting OsuColour
2023-01-10 12:11:33 +00:00
OpenSauce
a8f4f00421
Removed nullable
2023-01-10 12:04:06 +00:00
OpenSauce
4949b44888
Updated touch control scheme setting capitalization to be consistent with the rest of the settings menu
2023-01-10 11:57:21 +00:00
OpenSauce
b694e0d441
Added a comment and fixed some wonky formatting
2023-01-10 11:43:28 +00:00
OpenSauce
e3d14db285
Removed unnecessary QuarterCircle paramenters
2023-01-10 11:38:32 +00:00
OpenSauce
fd054081b8
Better name for touch control scheme config bindable
2023-01-10 11:30:52 +00:00
OpenSauce
3785dd0136
Taiko touch control scheme is now read from settings
2023-01-10 11:26:34 +00:00
OpenSauce
ee80cc988e
Fixed drums not displaying correctly; Fixed typo on a function name
2023-01-10 10:32:00 +00:00
OpenSauce04
46ffded1db
Taiko touch control scheme setting now *almost* works (need to implement getting control scheme from config); Drum display is incorrect
2023-01-10 08:27:21 +00:00
OpenSauce04
85396ba9d4
Added ruleset config stuff for Taiko; Added ruleset settings entry for Taiko touch control scheme
2023-01-09 19:26:43 +00:00
Dean Herbert
07eadba6d3
Merge pull request #21883 from sw1tchbl4d3r/allow_4_3
...
Allow aspect ratios smaller than the default in taiko
2023-01-09 16:30:19 +09:00
Dean Herbert
4a77105e78
Rename LockPlayfieldAspect and add comment explaining the change
2023-01-09 16:28:09 +09:00
Dean Herbert
98483d2a1b
Merge pull request #21638 from Mogiiii/touchscreen-control-disable-mouse
...
Disable touchscreen controls responding to mouse in scrolling gamemodes
2023-01-06 20:39:09 +08:00
sw1tchbl4d3
9021cf7be6
Allow aspect ratios smaller than the default in taiko
2022-12-28 11:42:34 +01:00
Berkan Diler
c7ca4bbba5
Use generic Enum methods
2022-12-26 20:36:39 +01:00
Dean Herbert
5e9fb1063a
Move judgement text creation to base class and tidy things up
2022-12-24 12:22:36 +08:00
Dean Herbert
03603f8b54
Don't show great or higher judgements when using argon "pro" skin
2022-12-24 03:35:44 +08:00
Dean Herbert
727ac00f6d
Combine base class for JudgementPiece
2022-12-24 03:32:13 +08:00
Dean Herbert
d6cae991da
Update netstandard2.1 references to net6.0
2022-12-16 17:16:13 +09:00
Dylan Nantz
ee945c9b58
disable mouse input to touchscreen controls
2022-12-14 10:34:21 -05:00
Dean Herbert
2fd535ea20
Apply same immediate transform logic to TaikoLegacyPlayfieldBackgroundRight to fix it sticking during rewind
2022-12-02 17:33:18 +09:00
Dean Herbert
ebc75d40d2
Switch to using immediate transforms to make rewind handle better
2022-12-02 17:32:57 +09:00
Dean Herbert
47855de6ab
Fix multiple issues with transform handling
2022-12-02 16:55:38 +09:00
Joppe27
a7f4325d3c
Revert hacky fade value and fix test
2022-12-01 12:16:58 +01:00
Joppe27
f9a9ab1d9b
Use BeatSyncedContainer and adjust values to be in line with stable
2022-11-30 19:50:47 +01:00
Joppe27
f3fa39f254
Add legacy taiko kiai glow element
2022-11-30 00:44:20 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
b381b4fd2d
Merge branch 'master' into update-framework
2022-11-24 01:27:58 +09:00
Dean Herbert
23f91ec717
Merge pull request #21379 from Joppe27/taiko-animations-recovered
...
Add taiko hit overlay animations
2022-11-23 15:09:44 +09:00
Bartłomiej Dach
6e9d163c72
Specify canBeNull: true in [Resolved] for now
2022-11-22 20:56:07 +01:00
Bartłomiej Dach
ce7af0df63
Always use current timing point for circle piece animation
...
Using `LifetimeStart` seemed arbitrary and wrong not only in a
compatibility-with-stable sense, but also in a general sanity sense (why
would each object potentially be using a different timing point to
animate?)
2022-11-22 20:39:22 +01:00
Bartłomiej Dach
38f2a27f53
Split animation logic to its own method
...
Also add a guard, to bypass all of it if the foreground layer is not in
fact animatable.
2022-11-22 20:39:05 +01:00
Joppe27
5343f6922c
Add legacy circle piece animations based on combo
2022-11-22 17:22:00 +01:00
Terochi
eff6c7be64
Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.
2022-11-19 16:53:35 +01:00
Dean Herbert
06ce8130c2
Apply changes in line with framework NRT updates
2022-11-18 18:13:15 +09:00
Dean Herbert
45f47cce77
Add basic osu!taiko "argon" swell visual
2022-11-16 16:13:52 +09:00
Dean Herbert
233d45e185
Fix argon swells incorrectly flashing on every hit
2022-11-15 18:28:13 +09:00
Bartłomiej Dach
8b8147c321
Rename {catch -> taiko}Component
2022-11-12 03:05:03 +09:00
Bartłomiej Dach
6a4c97b4f1
Fix code inspection
2022-11-12 02:20:19 +09:00
Bartłomiej Dach
7ef11cab8b
Adjust taiko argon transformer to new naming
2022-11-12 02:10:10 +09:00
Bartłomiej Dach
7379f6fe20
Merge branch 'master' into argon-taiko
2022-11-12 01:56:30 +09:00
Dan Balasescu
fe58329478
Merge pull request #21151 from peppy/taiko-judgement-fixes
...
Fix various issues surrounding hit judgements
2022-11-11 16:41:46 +09:00
Dan Balasescu
8063dcd74a
Merge pull request #21148 from peppy/taiko-barline-separation
...
Move major barline portion to default implementation to allow for further customisation
2022-11-11 16:40:51 +09:00
Dan Balasescu
5bdbf56f43
Merge branch 'master' into taiko-judgement-fixes
2022-11-11 15:48:33 +09:00
Dan Balasescu
1a1a186d22
Merge branch 'master' into taiko-barline-separation
2022-11-11 15:47:06 +09:00
Dan Balasescu
f25a8ee4a6
Merge branch 'master' into taiko-tick-trackiung
2022-11-11 15:41:06 +09:00
Susko3
6303b88e56
Fix NRT causing CI failure
2022-11-10 14:31:24 +01:00
Dan Balasescu
606d42c679
Merge pull request #21184 from peppy/skinnable-things-cleanup
...
Skinnable class naming pass
2022-11-10 12:52:08 +09:00
Dan Balasescu
20520e7290
Merge pull request #21171 from peppy/unpollute-taiko-drawable-hit
...
Remove triangles skin specific implementation from base osu!taiko `DrawableHit`
2022-11-10 12:47:36 +09:00
Dean Herbert
1aa0e40f2f
Add "Component" prefix to lookup naming
2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b
Rename ISkinComponent to ISkinLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
20b8ab324f
Apply nullability to osu!taiko skinning classes
2022-11-09 13:37:06 +09:00
Dean Herbert
30890644a8
Flash piece when hit
2022-11-08 15:31:45 +09:00
Dean Herbert
aa7d0e2c96
Remove triangles skin specific implementation from base DrawableHit
2022-11-08 15:22:00 +09:00
Dean Herbert
01803c3f13
Adjust judgement text to be more visible
2022-11-08 15:08:52 +09:00
Salman Ahmed
3af48352c9
Fix taiko major barlines no longer rendering correctly
2022-11-08 04:05:06 +03:00
Dean Herbert
d57ec4b227
Add argon input drum implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
b15d1bc333
Add argon result display implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
d5c375b139
Add argon hit explosion implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
37cb187d2e
Move strong hit scale to DefaultHitExplosion
2022-11-07 18:32:12 +09:00
Dean Herbert
e2046791c2
Add argon drum roll ticks
2022-11-07 18:32:12 +09:00
Dean Herbert
aa61eb8f4b
Add note about taiko pooling oversight
2022-11-07 18:32:12 +09:00
Dean Herbert
938a8f865b
Adjust transform of taiko drum roll ticks to not scale to 0 (looks bad)
2022-11-07 18:32:12 +09:00
Dean Herbert
f1556c98e3
Add drum roll implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
6636545195
Move taiko argon hit icon to respective centre/rim pieces
2022-11-07 18:32:12 +09:00
Dean Herbert
529e3217cf
Add barline implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
f1a1f29da7
Add hit target implementation
2022-11-07 18:32:12 +09:00
Dean Herbert
421bdd2c1a
Add playfield background implementations
2022-11-07 18:32:12 +09:00
Dean Herbert
bc0e9375af
Add basic argon hits
2022-11-07 18:32:12 +09:00
Dean Herbert
baf8db8de4
Add basic setup for taiko argon skinning
2022-11-07 18:32:12 +09:00
Dean Herbert
2648175275
Merge branch 'taiko-barline-separation' into taiko-fixes-combined
2022-11-07 18:32:09 +09:00
Dean Herbert
688f50e086
Merge branch 'taiko-tick-trackiung' into taiko-fixes-combined
2022-11-07 18:32:07 +09:00
Dean Herbert
564d078517
Fix much brokenness with kiai and justment sizing
2022-11-07 17:19:32 +09:00
Dean Herbert
8745c2f016
Split out taiko DefaultJudgementPiece and move animations across
2022-11-07 17:19:32 +09:00
Dean Herbert
1975385cc7
Move first tick tracking logic inside TickPiece
2022-11-07 15:26:34 +09:00
Dean Herbert
c69a4f9333
Move major barline portion to default implementation to allow for further customisation
...
Of note, this removes the "major" barline triangles from legacy skins. I
think this is more correct, as they did not display in stable.
2022-11-07 14:29:58 +09:00
Dan Balasescu
a2b4e5b658
Merge pull request #20558 from vunyunt/stamina-available-fingers
...
Basic tl-tapping consideration for stamina
2022-11-07 09:55:54 +09:00
Dan Balasescu
819027d61c
Rename to isConvert
2022-11-04 16:17:49 +09:00
Dan Balasescu
993439d30b
Fix missed nullability
2022-11-03 11:28:39 +09:00
Dean Herbert
bfa5d41d89
Fix one more case
2022-11-02 17:39:45 +09:00
Dan Balasescu
5dfaf27722
A bit more cleanup
2022-11-02 17:23:45 +09:00
Dean Herbert
bc3382f373
Apply NRT to many taiko classes
2022-11-02 17:15:25 +09:00
Dean Herbert
910dd3ad01
Move more default classes to correct namespace
2022-11-02 17:15:25 +09:00
Dean Herbert
2407eb063d
Simplify Circle usage in default CentreHitCirclePiece
2022-11-02 17:15:25 +09:00
Dean Herbert
9c758e5425
Move DefaultInputDrum to correct location
2022-11-02 17:15:25 +09:00
Dan Balasescu
5448c0209e
Rename var
2022-11-02 10:14:40 +09:00
Dan Balasescu
9065cb0526
Merge branch 'master' into stamina-available-fingers
2022-11-01 13:05:25 +09:00
Dan Balasescu
4342521bc1
Merge branch 'master' into stamina-available-fingers
2022-10-28 13:07:48 +09:00
Dan Balasescu
707b9eaa50
Remove unnecessary null-forgiving
2022-10-28 13:07:44 +09:00
sw1tchbl4d3
446a9c1b05
Make added effect points inherit previous effect point settings
2022-10-27 23:41:17 +02:00
sw1tchbl4d3
93ffe3d7ad
Revert to first approach
2022-10-27 07:25:50 +02:00
Bartłomiej Dach
974f22dd97
Attempt to make flashlight code slightly more legible
2022-10-25 20:15:19 +02:00
Bartłomiej Dach
e3bc1126d7
Fix invalid flashlight size calculation
...
This regressed in #20714 . One usage of `getSizeFor(0)` was replaced by
`adjustSize(GetSize())`, but another usage of `getSizeFor(Combo.Value)`
was replaced by `adjustSize(Combo.Value)`, which is not correct, since
`adjustSize()` is expecting to receive a combo-based size, rather than a
combo value directly.
2022-10-25 20:03:22 +02:00
Bartłomiej Dach
93e9b4a2c5
Add failing test case
2022-10-25 20:02:28 +02:00
Dean Herbert
995216cced
Merge pull request #20819 from Joppe27/taiko-kiai-flashing
...
Implement taiko hitobject kiai flashing
2022-10-24 15:31:13 +09:00
cdwcgt
f14d871f97
let TaikoSpan show in timeline before placed
2022-10-23 01:32:22 +09:00
cdwcgt
a74e873b98
remove useless using
2022-10-23 01:13:29 +09:00
Dean Herbert
d441e98af7
Adjust kiai flash period in line with stable
2022-10-21 15:34:25 +09:00
cdwcgt
42bb9dc3e3
revert EndPlacement change
2022-10-20 22:17:26 +09:00
Joppe27
d83c398b58
Apply review: changed DelayUntilTransformsFinished to ArmedState check
2022-10-19 23:31:23 +02:00
Joppe27
9b123e7365
Adjust flash intensity and fade values to feel better
2022-10-19 00:51:44 +02:00
Joppe27
003e4247f9
Implement kiai flashing for "triangles" taiko skin
2022-10-18 23:55:40 +02:00
Joppe27
a21acdb5bc
Implement kiai flashing for legacy taiko skins
2022-10-18 23:55:02 +02:00
cdwcgt
d6ed561280
make EndPlacement virtual
2022-10-19 00:31:21 +09:00
cdwcgt
3b1769c54e
Merge branch 'master' into taiko-compose
2022-10-19 00:00:20 +09:00
Dean Herbert
8bf4ca4b53
Add legacy skin fallback when beatmap skin is providing resources
2022-10-12 17:47:20 +09:00
Salman Ahmed
84fdd2e107
Improve flashlight display on break periods
2022-10-11 17:16:57 +03:00
vun
122064d03f
Minor refactoring to reduce amount of looping
2022-10-09 07:09:05 +08:00
Dan Balasescu
bce20e0a59
Merge branch 'master' into adjust-flashlight
2022-10-07 14:45:30 +09:00
Dan Balasescu
5f3b58b7e0
Adjust taiko flashlight to closely match classic
2022-10-07 14:44:45 +09:00
Dan Balasescu
234c6ac799
Pin taiko PP calculator accuracy to osu-stable values
2022-10-05 20:21:15 +09:00
vun
47781a8f94
Fix code inspect issues and SR test cases
2022-10-03 17:31:45 +08:00
vun
25976e1f10
Correct xmldocs
2022-10-03 14:20:01 +08:00
vun
c933b62df6
Correct xmldoc
2022-10-03 14:16:53 +08:00
Jay L
6752655b5a
xml, remove speedbonus cap
2022-10-02 16:08:14 +10:00
Jay L
4b562f782f
decrease finger count
2022-10-02 15:28:39 +10:00
Jay L
a276e40033
reintroduce fl bonus to converts
2022-10-02 09:05:58 +10:00
vun
e6093f94df
Apply nerfs to HD/FL bonuses with converts
2022-09-30 20:56:16 +08:00
vun
02092ede64
Refactor previous and next colour change into TaikoDifficultyHitObjectColour
2022-09-30 11:42:48 +08:00
vun
09a38fec94
Implement mono tl nerf for stamina, disable convert specific nerfs
2022-09-30 09:10:56 +08:00
vun
d84c956af9
Refactor to move first-object detection to evaluation
2022-09-29 15:27:26 +08:00
Dan Balasescu
1890a66b28
Merge pull request #20509 from o-dasher/cleanup-setting-sources
...
Removes unnecessary setting sources specifications
2022-09-28 17:55:42 +09:00
Dan Balasescu
cbed268ac9
Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements
...
Clamp `LifetimeStart` of `HitObject`s to their judgement windows
2022-09-28 17:49:35 +09:00
sw1tchbl4d3
0cffbb7562
Clamp LifetimeStart of HitObject's to their judgement windows
2022-09-27 16:54:24 +02:00
o-dasher
f3e25eacad
Removes unnecessary setting sources specifications
2022-09-27 09:25:58 -04:00
cdwcgt
344015a6e6
do not move timeline when EndPlacement
2022-09-27 20:12:40 +09:00
cdwcgt
9c4ae768f1
show object in timeline before placed
...
just BeginPlacement()
2022-09-27 20:08:32 +09:00
o-dasher
537796c3a1
Cleanup mod bindings
2022-09-25 15:49:22 -04:00
Dean Herbert
c7f8f948b9
Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins
2022-09-15 20:18:10 +09:00
andy840119
3d7367a842
Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.
2022-09-10 11:07:23 +08:00
andy840119
2f91b5c846
Add missing import.
2022-09-10 10:46:10 +08:00
andy840119
e62999fb16
Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch/CatchRuleset.cs
# osu.Game.Rulesets.Osu/OsuRuleset.cs
# osu.Game.Rulesets.Taiko/TaikoRuleset.cs
# osu.Game/Rulesets/Ruleset.cs
2022-09-10 10:40:12 +08:00
Dan Balasescu
a2f8ff825e
Also ignore drum roll strong judgement
2022-09-06 23:26:25 +09:00
Dan Balasescu
792b410c04
Merge branch 'master' into classic_drumrolls
2022-09-06 16:29:45 +09:00
Salman Ahmed
ff4a051c05
Merge branch 'master' into remove-dispose-updates
2022-09-03 16:14:50 +03:00
Dan Balasescu
9645bfe708
Bump difficulty calculator versions
2022-09-02 16:27:25 +09:00
Dean Herbert
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
sw1tchbl4d3
a9aa928ce6
Fix test, make strong hits have LargeBonus judgement
2022-08-30 15:00:46 +02:00
sw1tchbl4d3
b185194d07
Apply comments by smoogi
2022-08-30 14:44:44 +02:00
Dan Balasescu
e3e204001e
Merge pull request #19907 from peppy/ruleset-api-versioning
...
Add ruleset API versioning
2022-08-29 18:50:01 +09:00
Dean Herbert
a215d009fe
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
2022-08-29 15:57:40 +09:00
Dean Herbert
90b9c02ac6
Remove "internal" identifier as unnecessary
2022-08-29 14:01:15 +09:00
Dan Balasescu
85705d97a5
Merge pull request #19853 from Lawtrohux/pp-rescale-effective-misses
...
osu!taiko performance point adjustments & effective misses
2022-08-25 14:43:03 +09:00
Dan Balasescu
8eab36f8c9
Actually fix possible NaN value
2022-08-25 14:02:10 +09:00
Dan Balasescu
136dcee3b5
Merge pull request #19571 from vunyunt/colour-encoding-2
...
Rewrite of the colour skill & refactoring of difficulty calculation within osu!taiko
2022-08-25 13:56:50 +09:00
vun
fb9bb2d42d
Declare Parent as non-nullable
2022-08-24 08:57:13 +08:00
Jay L
3acbcac4d1
fix NaN PP on 0 object count
2022-08-22 19:45:51 +10:00
Dean Herbert
f5710d8000
Add ruleset API versioning
2022-08-22 16:35:08 +09:00
naoei
9386d352b8
Make StatisticItem.Name not nullable
2022-08-20 21:48:35 -04:00
Nao
189a407cb1
Merge branch 'master' into ruleset-localization
2022-08-20 21:39:10 -04:00
Jay L
c1da509119
round numerical value
...
this is painfully annoying me
2022-08-19 23:23:40 +10:00
Jay L
faf143b11a
fix comment
2022-08-19 23:15:38 +10:00
Jay L
b30fba1430
emc attribute
2022-08-19 22:57:40 +10:00
Jay L
fea31cc895
introduce effective misscount, accuracy rescale
2022-08-19 22:57:28 +10:00
vun
f3e1287f04
Remove redundant using statement
2022-08-19 16:19:45 +08:00
vun
684efefb50
Add FirstHitObject as a property of encoding classes
2022-08-19 16:13:36 +08:00
vun
a26de0a10f
Add HitType property to MonoStreak
2022-08-19 16:05:34 +08:00
vun
51176e9577
Naming changes
2022-08-19 15:45:43 +08:00
vun
5dcd4ce7c5
Naming changes
2022-08-19 15:31:03 +08:00
Dan Balasescu
c4dee1cf6d
Merge pull request #19832 from peppy/fix-taiko-span-blueprint-overlay
...
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:57:14 +09:00
Dean Herbert
ad28bfc9b2
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:18:11 +09:00
Dean Herbert
48fac9f8a5
Fix taiko drum rolls with zero length being placeable in editor
...
Addresses https://github.com/ppy/osu/discussions/19808 .
2022-08-18 16:50:36 +09:00
vun
40b1554fea
Change FindRepetitionInterval to start with one previous encoding
2022-08-18 14:12:03 +08:00
Dan Balasescu
8e0049c005
Add back null check
2022-08-15 21:57:41 +09:00
Dan Balasescu
c03e47317a
Fix notes not being added to list
2022-08-15 21:56:03 +09:00
Dan Balasescu
4d4ee05981
Whoops I meant to remove these
2022-08-15 21:56:03 +09:00
Dan Balasescu
78283ce3c5
Remove TaikoDifficultyPreprocessor
2022-08-15 21:43:09 +09:00
Dan Balasescu
21d2998032
Privatise internals of TaikoColourDifficultyPreprocessor
2022-08-15 21:35:57 +09:00
Dan Balasescu
94c6beeaf7
Use ctor in a place that looks visually weird
...
I read through this thinking "why doesn't Previous get assigned to
currentEncoding here? But it's because the initializer runs right after
the ctor and before the "method" returns. So really there's 3 operations
running on one line here - ctor, init, and assignment.
2022-08-15 21:30:46 +09:00
Dan Balasescu
502e31dd37
General refactoring
2022-08-15 21:26:54 +09:00
Dan Balasescu
d686e841c5
Merge branch 'master' into colour-encoding-2
2022-08-15 20:56:50 +09:00
naoei
45e9eda9e7
Localise hit result name
2022-08-14 14:57:02 -04:00
naoei
18ce784ae0
Allow StatisticItem's name param to be nullable
2022-08-14 14:51:35 -04:00
naoei
3e38baca3c
Change ruleset mod description types
2022-08-10 16:09:11 -04:00
sw1tchbl4d3
e0426836c1
Make swells and drumrolls optional by default
2022-08-05 16:30:07 +02:00
Justin
e6761ef6b1
Merge branch 'master' into classic_drumrolls
2022-08-05 12:17:44 +00:00
Dan Balasescu
b4e55f7309
Apply IRenderer changes
2022-08-02 19:50:57 +09:00
andy840119
eb73f9e88c
Remove un-need using.
2022-08-02 10:23:52 +08:00
andy840119
b1d320bf67
Use non-nullable instead in the taiko ruleset.
2022-08-02 00:48:23 +08:00
Salman Ahmed
b32ff68a95
Enable NRT on taiko legacy skin transformer and tests
2022-07-30 09:43:51 +03:00
Salman Ahmed
0940e703b3
Fix normal skin hitsounds prioritised over default taiko hitsounds
2022-07-30 09:15:28 +03:00
Salman Ahmed
e0107fc3dc
Use RequiredParentSizeToFit to handle misc geometry changes
2022-07-29 21:11:43 +03:00
NaiPofo
4e32d510c3
Invalidate flashlightProperties on DrawInfo
2022-07-29 20:08:32 +02:00
為什麼
860e9d42ff
Mark the property as nullable and add some assert check.
2022-07-27 22:31:48 +08:00
為什麼
d766052be4
Remove nullable disable annotation in the Taiko ruleset.
2022-07-27 22:28:13 +08:00
sw1tchbl4d3
0a0f3c93dd
Rename OkResult, rephrase "strong bonus"
2022-07-24 20:55:13 +02:00
Justin
a4f3a0d201
Merge branch 'master' into classic_drumrolls
2022-07-24 18:33:04 +00:00
Dan Balasescu
27ec8f3ae6
Merge pull request #17200 from hongaaronc/master
...
Add basic touch support for osu!taiko
2022-07-22 20:58:42 +09:00
Dean Herbert
7baa1a7e85
Attempt to fix crashing from weird input interactions
2022-07-22 20:19:13 +09:00
vun
fc08d77090
Remove review-specific comment
2022-07-22 18:31:59 +08:00
vun
7d4593eb6d
Fix comments
2022-07-22 18:20:35 +08:00
Dean Herbert
ee5e27638e
Fix method name not matching actual implementation
2022-07-22 18:19:33 +09:00
Dean Herbert
9e5e03af5d
Adjust colours to match default skin for now
2022-07-22 18:16:01 +09:00
Dean Herbert
ec98693cca
Add back standard mouse bindings support and only handle mouse when inside the visible zone
2022-07-22 18:09:19 +09:00
Dean Herbert
4279ac866c
Tidy up unnecessary changes and remove unused classes
2022-07-22 17:58:52 +09:00
Dean Herbert
2d2d98ab6e
Add final design pass
2022-07-22 17:53:25 +09:00
vun
17d418d319
Merge remote-tracking branch 'ppy/master' into colour-encoding-2
2022-07-22 16:31:28 +08:00
vun
6359c1a4fe
Fix outdated comment
2022-07-22 16:31:19 +08:00
Dean Herbert
aeeedc40b4
Add first pass design
2022-07-22 17:17:38 +09:00
Dean Herbert
bd6ff40b43
Combine touch and mouse handling into single path
2022-07-22 17:03:08 +09:00
Dean Herbert
b604eb6262
Simplify implementation
2022-07-22 16:59:09 +09:00
Dean Herbert
7015cf0b1b
Move touch input drum to own file for now
2022-07-22 16:39:26 +09:00
Dean Herbert
c32af3c041
Merge branch 'master' into hongaaronc/master
2022-07-22 15:55:38 +09:00
vun
4433f902ea
Fix and add comments
2022-07-22 10:49:53 +08:00
vun
e4086b058b
Implement stateless colour evaluator and required encoding changes
2022-07-21 19:15:22 +08:00
Dean Herbert
aca19a005e
Add versioning to difficulty calculators
2022-07-21 18:15:25 +09:00
vun
7917a60e3c
Move TaikoDifficultyHitObject creation back to TaikoDifficultyCalculator
2022-07-21 15:45:03 +08:00
Jay L
b7567f7db2
Share sigmoid, Fix Preprocessor XML
2022-07-21 10:52:41 +10:00
Jay L
08dd9c79db
Fix Convert-related nerf
...
This addresses recent player unsatisfaction with converts being underweighted.
2022-07-21 09:55:19 +10:00
Jay L
cb63ec282e
Partial Review changes
2022-07-20 23:33:38 +10:00
Dan Balasescu
7dfc18a0e3
Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings
...
Remove score multiplier on difficulty-increasing mods with customised settings
2022-07-20 20:12:59 +09:00
Dean Herbert
f6e46da117
Merge branch 'master' into taiko-target-classic-position
2022-07-20 19:09:57 +09:00
Salman Ahmed
4210ec6502
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-19 19:21:26 +03:00
Dan Balasescu
471e1b935d
Merge pull request #19181 from taiko-pp-committee/performance-balancing-merge
...
osu!taiko performance points balancing
2022-07-19 21:01:12 +09:00
Salman Ahmed
1051009827
Change bindable properties in all HitObjects to be lazily initialised
2022-07-19 05:39:10 +03:00
Salman Ahmed
28150dc15d
Merge branch 'master' into taiko-target-classic-position
2022-07-18 20:45:29 +03:00
Salman Ahmed
32ba58109b
Remove score multiplier on difficulty-increasing mods with customised settings
2022-07-18 07:29:03 +03:00
Jay L
e82e11ead5
Fix SpeedBonus xml
2022-07-17 14:56:07 +10:00
Jay L
5532f56a30
performance points balancing
2022-07-17 14:10:49 +10:00
vun
a66fd87274
Fix speed bonus comment
2022-07-16 19:48:29 +08:00
vun
8beb5568b8
Fix speed bonus
2022-07-16 19:45:35 +08:00
Jay L
8a17b509d9
Increase SpeedBonus Cap to 600BPM
2022-07-16 21:20:25 +10:00
vunyunt
9994f13031
Merge branch 'ppy:master' into colour-encoding-2
2022-07-15 21:19:49 +08:00
Jay L
c8b7902a63
Reintroduce Convert Nerf, Rescale Multiplier
2022-07-15 22:10:20 +10:00
Jay L
7e3f62a5a5
Codequality parse
2022-07-15 21:07:01 +10:00
vun
45c055bfa1
Move rhythm preprocessing to its own folder
2022-07-14 17:25:21 +08:00
vun
1cb18f8474
Refactor colour encoding to avoid circular dependencies
2022-07-14 16:29:23 +08:00
為什麼
1725a76fa0
Remove the nullable disable annotation for all rulesets.
2022-07-10 10:15:27 +08:00
為什麼
857377e145
Move CreateConvertibleReplayFrame() into legacy ruleset interface because technically only legacy ruleset use it to convert the legacy frame.
...
But seems some of the customized ruleset use it for save the replay frame.
2022-07-10 10:15:27 +08:00
vun
6660379a0e
TAIKO-6 Tweak encoding and parameters, reduce rhythm weight
2022-07-07 16:04:46 +08:00
vun
f6dedc77fb
Fixed encoding logic, parameter adjustments
2022-07-05 17:01:11 +08:00
vun
505a24a68e
Implement new colour encoding and evaluator
2022-07-05 14:41:40 +08:00
andy840119
0a1543c6e8
Use AsNonNull() instead.
2022-07-02 19:48:32 +08:00
andy840119
59c83a3423
Mark as non-null because next object in here will always has value.
2022-07-02 13:33:51 +08:00
andy840119
19721a9bbb
Remove the nullable disable annotation and fix the breaking api.
2022-07-02 13:33:05 +08:00
vun
5f8d21f33d
Per encoding evaluation
2022-07-01 14:27:23 +08:00
