Dean Herbert
58efed4ebe
Merge pull request #30915 from bdach/extension-checks
...
Centralise supported file extensions to one helper class
2024-11-29 20:55:28 +09:00
Bartłomiej Dach
5f092811cb
Use helper in one more place
2024-11-29 09:22:29 +01:00
Bartłomiej Dach
5a9127dfc6
Accidentally a word
2024-11-29 08:46:08 +01:00
Bartłomiej Dach
110e4fbb30
Centralise supported file extensions to one helper class
...
As proposed in
https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837 .
2024-11-29 08:42:45 +01:00
Dean Herbert
b697ddc6db
Simplify the dev footer display
2024-11-29 15:32:35 +09:00
Dean Herbert
276c37bcf7
Update framework
2024-11-29 13:47:56 +09:00
Salman Alshamrani
489d7a30ec
Perform a single Save call rather than doing it in each difficulty
2024-11-28 18:37:13 -05:00
Salman Alshamrani
311f0947e4
Abstractify resource change logic and share between background and audio
2024-11-28 17:57:47 -05:00
Salman Alshamrani
51bcde67aa
Remove no longer required comment
2024-11-28 17:55:15 -05:00
Salman Alshamrani
a8db35ac45
Merge branch 'master' into daily-challenge-tier-thresholds
2024-11-28 17:46:55 -05:00
Salman Alshamrani
932afcde01
Make editor make sense
2024-11-28 17:43:32 -05:00
Jamie Taylor
58cf1c11e4
Improve menu/context-menu sample playback
2024-11-29 06:54:48 +09:00
Huo Yaoyuan
fced254594
Enable selected rules for usage
2024-11-28 22:33:03 +08:00
Bartłomiej Dach
c93c549b05
Fix ready button not disabling on playlist close
2024-11-28 14:17:31 +01:00
Bartłomiej Dach
9926ffd326
Make button a little narrower
2024-11-28 14:06:12 +01:00
Bartłomiej Dach
ac2c4e81c7
Use switch
2024-11-28 14:04:39 +01:00
Bartłomiej Dach
2e6f43a75d
Merge branch 'master' into close-playlists
2024-11-28 14:01:36 +01:00
Huo Yaoyuan
f5a7716509
Apply minor performance rules
2024-11-28 20:41:44 +08:00
Huo Yaoyuan
13d7c6a2d8
Enable recommended rules for maintainability
2024-11-28 20:41:41 +08:00
Huo Yaoyuan
c57ace0b5f
Enable recommended rules for documentation
2024-11-28 20:41:32 +08:00
Bartłomiej Dach
d0e80ce982
Merge pull request #30895 from peppy/watch-replay-reliability
...
Fix watch replay button sometimes not loading the replay on first click
2024-11-28 13:16:40 +01:00
Hiviexd
66093872e8
Adjust daily challenge tier thresholds to match expectations
2024-11-28 12:49:30 +01:00
Bartłomiej Dach
98a156ae2d
Merge pull request #30874 from peppy/chat-order
...
Sort public chat channels alphabetically, private channels based on recent messages
2024-11-28 12:46:14 +01:00
Bartłomiej Dach
c14fe21219
Fix LCA call crashing in actual usage
...
It's not allowed to call `LoadComponentsAsync()` on a background thread:
fd64f2f0d4/osu.Framework/Graphics/Containers/CompositeDrawable.cs (L147)
2024-11-28 11:19:00 +01:00
Dan Balasescu
1575eed5ba
Merge pull request #30893 from peppy/realm-perf-improvements
...
Improve realm update performance
2024-11-28 19:08:22 +09:00
Dan Balasescu
077719903b
Merge pull request #30905 from peppy/fix-multiple-offset-applications
...
Clear previous `LastLocalUserScore` when returning to song select
2024-11-28 18:58:13 +09:00
Bartłomiej Dach
b0958c8d41
Attempt to fix test failures
2024-11-28 10:29:53 +01:00
Dean Herbert
ced8dda1a2
Clear previous LastLocalUserScore when returning to song select
...
This seems like the lowest friction way of fixing
https://github.com/ppy/osu/issues/30885 .
We could also only null this on application, but this feels worse
because
- It would require local handling (potentially complex) in
`BeatmapOffsetControl` if we want to continue displaying the graph and
button after clicking it.
- It would make the session static very specific in usage and
potentially make future usage not possible due to being nulled in only
a very specific scenario.
One might argue that it would be nice to have this non-null until the
next play, but if such a usage comes up I'd propose we rename this
session static and add a new one with that purpose.
2024-11-28 18:01:28 +09:00
Bartłomiej Dach
0d491e3159
Merge branch 'master' into fix-daily-challenge-leaderboard
2024-11-28 09:41:24 +01:00
Dan Balasescu
5d7aafaab3
Merge pull request #30894 from HenintsoaSky/star-fountains-toggle-setting
...
Add a toggle for star fountains during gameplay
2024-11-28 17:35:11 +09:00
Salman Alshamrani
b1d0939142
Add localisation support
2024-11-28 02:37:31 -05:00
Salman Alshamrani
4a1401a33d
Rewrite bindable flow to make more sense
2024-11-28 02:37:27 -05:00
Dean Herbert
70eee8882a
Remove unnecessary null check
2024-11-28 15:42:37 +09:00
Dean Herbert
32b34c1967
Rename container to make more sense
2024-11-28 15:20:51 +09:00
Dean Herbert
4d9d5adbf4
Rename parameter to be more clear
2024-11-28 15:13:59 +09:00
Dean Herbert
e0fdcaf523
Merge pull request #30848 from Joehuu/dicord-fix-beatmap-button-visibility
...
Fix discord "view beatmap" button being shown when editing and hide identifiable information is set
2024-11-28 13:29:09 +09:00
Salman Alshamrani
24c0799680
Move beatmap ID lookup to UesrActivity
2024-11-27 16:54:51 -05:00
Salman Alshamrani
f792b6de00
Fix comment
2024-11-27 06:07:10 -05:00
Salman Alshamrani
4ae3ccfe48
Make BackButtonVisibility in game class private
2024-11-27 06:05:02 -05:00
Salman Alshamrani
efb68e4232
Refactor ResourcesSection to support new form of selection
2024-11-27 05:53:22 -05:00
Salman Alshamrani
b70fb4b0fe
Add FormBeatmapFileSelector for intermediate user-choice step
2024-11-27 05:52:43 -05:00
Dean Herbert
0f73941808
Combine new implementation back into the old one and use everywhere
2024-11-27 17:47:42 +09:00
Dean Herbert
7fdf13911b
Adjust the colour of non-pinned settings groups' headers to be more legible
2024-11-27 17:47:27 +09:00
Dean Herbert
782ce24ca6
Move player settings out of right flow
2024-11-27 17:09:15 +09:00
Dean Herbert
9c707ed341
Rename class and fix padding considerations
2024-11-27 16:47:54 +09:00
Dean Herbert
5ce55e9cb4
Merge branch 'master' into multi-spectator-settings-sidebar
2024-11-27 16:35:05 +09:00
Dean Herbert
4fcc76270a
Ensure events are unbound on disposal as a safety
2024-11-27 15:46:55 +09:00
Dean Herbert
5260a401d4
Use RealmLive in SaveFailedScoreButton
...
This also optimises the manager classes to better support `Live` usage
where the managed object is already in a good state (ie. doesn't require
re-fetching).
2024-11-27 15:25:42 +09:00
Salman Alshamrani
dfbccc2144
Knock some sense into the playlists results screen implementation
...
As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
the existing playlists results screen classes needed some restructuring.
2024-11-27 01:20:43 -05:00
Dean Herbert
aa3d3a6344
Remove unnecessary local subscription in BeatmapCarousel
...
Not sure why I left this around during the refactor. This is 100%
handled by the `DetachedBeatmapStore`.
Removing this subscription reduces overheads by a huge amount for users
with large beatmap databases. My hypothesis is that subscriptions are
more expensive based on **the number of results matching**. This one
matches almost every beatmap so removing it is a large win.
2024-11-27 14:24:57 +09:00
HenintsoaSky
a477bb7bfe
Renaming of 'StarFountainEnabled'
2024-11-27 07:38:33 +03:00
Dean Herbert
573aaf6637
Merge pull request #27128 from frenzibyte/user-statistics-provider
...
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
2024-11-27 13:13:47 +09:00
Salman Alshamrani
9083daf363
Fix epic code failure
...
I wasn't feeling well last night.
2024-11-26 20:04:36 -05:00
Salman Alshamrani
3e1b4f4ac5
Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-11-26 16:52:39 -05:00
HenintsoaSky
80a66085a9
rename and remove again
2024-11-27 00:41:02 +03:00
HenintsoaSky
460471e73f
Rename of the setting
2024-11-27 00:27:22 +03:00
HenintsoaSky
df74a177ae
Add option to disable star fountain in gameplay
2024-11-27 00:13:32 +03:00
Joseph Madamba
9173a74552
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-26 12:13:08 -08:00
Joseph Madamba
f04862ea74
Edit one more word not using british english
2024-11-26 12:11:29 -08:00
Bartłomiej Dach
33c2eb1af7
Merge pull request #30881 from peppy/fix-editor-state-leaking
...
Fix hitobjects' samples getting in bad state when changing selection between objects
2024-11-26 13:54:50 +01:00
Bartłomiej Dach
3e373ae85e
Merge pull request #30868 from peppy/ur-perf-fix
...
Improve performance of UR calculations
2024-11-26 13:54:17 +01:00
Dan Balasescu
4c7976bb93
Remove unused using
2024-11-26 21:11:48 +09:00
Dan Balasescu
af0c6fc51b
Add Room.HasEnded helper method
2024-11-26 21:09:28 +09:00
Bartłomiej Dach
46d1f00590
Fix Beatmap.Countdown not being copied on conversion
2024-11-26 11:39:03 +01:00
Bartłomiej Dach
cf905d0f5c
Merge branch 'master' into beatmap-info-purge
2024-11-26 10:21:16 +01:00
Dean Herbert
bf29e3ae71
Simplify hide code by moving to common method
2024-11-26 18:00:32 +09:00
Dean Herbert
71294c312b
Change point of queueing to avoid loading-from-in-queue
2024-11-26 17:58:50 +09:00
Dean Herbert
98044c108e
Revert "Ensure DrawableMedal loading doesn't ever block on online resources"
...
This reverts commit 8585327858
2024-11-26 17:41:12 +09:00
tsrk.
41c309fb72
chore(MenuTip): update text according to recent changes
...
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-26 09:35:18 +01:00
Dean Herbert
3ecb3b674d
Don't reset state when changing from one selection to another in the editor
...
This was causing state pollution in the new selection. I can't see why
this needs to happen when a selection changes to another.
This fixes https://github.com/ppy/osu/issues/30839 and also the same
issue happening for the new combo toggle.
Tests all seem to pass, and I can't immediately find anything broken,
but YMMV.
2024-11-26 17:33:41 +09:00
Dan Balasescu
d3d111de7d
Merge pull request #30832 from peppy/mania-precise-scroll-speed
...
Allow setting osu!mania scroll speed to single decimal precision
2024-11-26 17:30:56 +09:00
Dean Herbert
1e6c04e98b
Remove debug logging
2024-11-26 16:11:06 +09:00
Salman Alshamrani
42c68ba43e
Add inline comment
2024-11-26 01:28:58 -05:00
Salman Alshamrani
b76460f100
Schedule the thing
...
Queuing up requests on change to `api.LocalUser` is bad because the API
state is updated after `LocalUser` is updated, therefore we have to
schhhhhedullllllllleeeeeeeeeeeeeeee.
2024-11-26 01:26:44 -05:00
Dean Herbert
e3ea38a366
Add setting to allow hold-for-pause to still exist
...
Users have asked for this multiple times since last release.
Not sure on the best default value, but I'm going with the
stable/classic one, at least for the initial release to avoid needing
migrations.
In the future we may reconsider this for new users.
2024-11-26 15:14:19 +09:00
Salman Alshamrani
7201bac60d
Remove DailyChallengePlayer
2024-11-26 01:10:19 -05:00
Salman Alshamrani
c1416f9920
Bring back user-based endpoint for viewing result screen from playlists lounge
2024-11-26 01:10:12 -05:00
Salman Alshamrani
d150aeef2b
Use score-based endpoint everywhere
2024-11-26 01:01:59 -05:00
Dean Herbert
e8fae85e8d
Fix hidden dissmissing logic
2024-11-26 14:45:40 +09:00
Dean Herbert
672dbe6e03
Better control of show/hide of overlay
2024-11-26 14:42:30 +09:00
Dean Herbert
d057dc9a95
Refactor MedalOverlay to be more readable
...
Shouldn't really have any functionality changes, just fixing some old
code that I can't easily parse these days.
2024-11-26 14:19:39 +09:00
Dean Herbert
8585327858
Ensure DrawableMedal loading doesn't ever block on online resources
2024-11-26 14:08:53 +09:00
Salman Alshamrani
dfa21574fd
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-25 23:52:56 -05:00
Dean Herbert
17347563ee
Fix incorrect null handling
2024-11-26 13:25:57 +09:00
Dean Herbert
f708466a9b
Add test coverage
2024-11-26 13:25:55 +09:00
Dean Herbert
d6cf1db0f5
Add basic xmldoc to results class
2024-11-26 12:16:26 +09:00
Dean Herbert
d903d381d5
Rename NextProcessableIndex to EventCount in line with actual functionality
2024-11-26 12:10:34 +09:00
Dean Herbert
9ca17f9b6b
Merge pull request #30748 from stanriders/scale-profile-beatmaps
...
Scale down beatmap cards
2024-11-25 22:53:51 +09:00
Bartłomiej Dach
0a3f3c3210
Add guard against fetching statistics for non-legacy rulesets
2024-11-25 13:14:22 +01:00
Dean Herbert
bbe8f2ec44
Only update unstable rate counter when an applicable hitobject is reached
2024-11-25 21:13:18 +09:00
Dean Herbert
ea68d4b33a
Use class instead of record for lower allocations
2024-11-25 21:13:18 +09:00
Dean Herbert
5668258182
Add incremental processing
2024-11-25 21:13:17 +09:00
Bartłomiej Dach
78c01c1b5a
Merge branch 'master' into beatmap-defaults-match-stable
2024-11-25 12:55:08 +01:00
Dean Herbert
33d725e889
Address unstable rate calculations as a list for marginal gains
2024-11-25 19:44:11 +09:00
Dean Herbert
605fe71f46
Make empty hitwindows readonly static and slightly improve comparison performance
2024-11-25 19:17:32 +09:00
Bartłomiej Dach
1410e8837a
Merge branch 'master' into better-room-status
2024-11-25 09:48:40 +01:00
Dean Herbert
82bdd8fbfc
Merge pull request #30861 from frenzibyte/fix-multiplayer-missing-hold-delay
...
Fix pause shortcut on multiplayer no longer requiring hold
2024-11-25 16:22:56 +09:00
Dean Herbert
876c2e468a
Merge pull request #30858 from frenzibyte/fix-match-settings-overlay-typo
2024-11-25 15:58:17 +09:00
Salman Alshamrani
1468385559
Reset new file states after syncing
2024-11-24 22:38:48 -05:00
tsrk.
cfaf972813
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-24 18:24:43 +01:00
Dean Herbert
c34827a4ed
Merge pull request #30862 from frenzibyte/dont-scare-the-player
...
Don't play fail animation if restarting on fail
2024-11-24 23:11:19 +09:00
tsrk.
8611ed31c2
refactor(MenuTip): add localisation support
...
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-24 14:22:56 +01:00
Dean Herbert
888f02e3a6
Merge pull request #30855 from SupDos/tips-remove-fps
...
Remove FPS shortcut tip
2024-11-24 19:57:08 +09:00
Salman Alshamrani
ae9119eef0
Hide back button when quick-restarting unless load time takes long
2024-11-24 05:40:06 -05:00
Salman Alshamrani
2420793466
Allow controlling back button visibility state from screens
2024-11-24 05:39:43 -05:00
Salman Alshamrani
6d0d7f3e75
Don't play fail animation if restarting on failure
2024-11-24 04:45:48 -05:00
Salman Alshamrani
f3155bfc7d
Fix pause shortcut on multiplayer not delayed
2024-11-24 04:24:31 -05:00
Salman Alshamrani
631bfadd68
Replace event subscription with callback in UserStatisticsWatcher
...
Also no longer cancels previous API requests as there's no actual need to do it.
2024-11-24 04:11:13 -05:00
Salman Alshamrani
3480da22d2
Remove no-op SaveState call
2024-11-24 01:13:39 -05:00
Salman Alshamrani
95a6226413
Only enable button if there are different filenames
2024-11-24 01:11:36 -05:00
Salman Alshamrani
a872f74974
Make sync button only affect changed resource type
2024-11-24 01:02:34 -05:00
Salman Alshamrani
c8b13b726d
Add localisation support
2024-11-24 00:45:17 -05:00
Salman Alshamrani
e348b3a7aa
Only enable button if there are multiple difficulties
2024-11-24 00:34:03 -05:00
Salman Alshamrani
8e20dc7e9d
Add option to update all difficulties with new background/audio file
2024-11-24 00:32:50 -05:00
Salman Alshamrani
871c365fd8
Preserve existing beatmap background/audio files if used elsewhere
2024-11-24 00:32:27 -05:00
Salman Alshamrani
956da0383f
Merge branch 'master' into multiplayer-remove-expired-item-removal
2024-11-23 22:19:21 -05:00
Salman Alshamrani
8f5d513d46
Fix room auto start duration setting applied to the wrong component
2024-11-23 22:16:29 -05:00
Salman Alshamrani
6b78553559
Merge branch 'master' into tips-remove-fps
2024-11-23 20:57:14 -05:00
SupDos
2f096f71d3
Remove FPS shortcut tip
2024-11-24 02:34:30 +01:00
Salman Alshamrani
608bda135a
Merge branch 'master' into fix-song-ticker-contrast
2024-11-23 20:14:33 -05:00
Salman Alshamrani
2f45ebeec8
Remove using directive
2024-11-23 20:13:57 -05:00
Salman Alshamrani
eed02c2ab1
Fix daily challenge results screen beginning score fetch from user highest
2024-11-23 15:45:29 -05:00
Sheppsu
3713bb48b7
expand and contract settings from hover
2024-11-23 01:09:58 -05:00
Salman Alshamrani
c9dc6628fc
Merge branch 'master' into remove-macos-recommendation
2024-11-22 23:14:09 -05:00
Dean Herbert
ce41c000a1
Merge pull request #30812 from smoogipoo/playlist-populate-on-enter
...
Fix joining playlists room sometimes not selecting the first item
2024-11-22 23:57:45 +09:00
Dan Balasescu
5ebaab7e9a
Add localisation
2024-11-22 21:21:04 +09:00
Dan Balasescu
82a63228de
Improve handling of multiplayer room status
2024-11-22 21:21:04 +09:00
Dean Herbert
9930922769
Fix chat channel listing not being ordered to expectations
...
- Public channels (and announcements) are now alphabetically ordered.
- Private message channels are now ordered by most recent activity.
Closes https://github.com/ppy/osu/issues/30835 .
2024-11-22 19:53:26 +09:00
Dean Herbert
c844d65a81
Use TryGetValue wherever possible
...
Rider says so.
2024-11-22 19:11:16 +09:00
Bartłomiej Dach
ead7e99c59
Fix incorrect comment
2024-11-22 11:06:36 +01:00
Dean Herbert
c590bef4c3
Remove legacy default setter for SamplesMatchPlaybackRate now that it's the default
2024-11-22 19:05:29 +09:00
Dean Herbert
086a34f5c0
Merge branch 'master' into beatmap-info-purge
2024-11-22 18:47:32 +09:00
Dean Herbert
e33e0e16e8
Merge branch 'master' into scale-profile-beatmaps
2024-11-22 18:33:37 +09:00
Dean Herbert
04ed954387
Fix song ticker having very bad contrast against bright backgrounds
...
Closes #30814 .
2024-11-22 18:17:55 +09:00
Bartłomiej Dach
8b68859d9d
Fix Room.CopyFrom() skipping a field
...
Was making the close button not display when creating a room anew.
2024-11-22 09:57:57 +01:00
Bartłomiej Dach
cfc38df889
Add close button to playlists footer
2024-11-22 09:57:56 +01:00
Bartłomiej Dach
69c2c988a1
Add extra check to ensure closed rooms can't be closed harder
2024-11-22 09:54:56 +01:00
Dean Herbert
29757ffdf2
Allow setting osu!mania scroll speed to single decimal precision
...
Addresses https://github.com/ppy/osu/discussions/30663 .
2024-11-22 17:36:28 +09:00
Dan Balasescu
39504c348d
Cleanup CopyFrom() method
...
Though the code appears slightly different, it should be semantically
equivalent. APIUser equality is implemented on `Id` and `Host` should
never transition from non-null to null.
2024-11-22 17:22:30 +09:00
Dan Balasescu
e59ac9e7c8
No longer remove expired playlist items from Room model
2024-11-22 17:19:26 +09:00
Bartłomiej Dach
3b2f43012e
Merge branch 'master' into close-playlists
2024-11-22 09:02:41 +01:00
Bartłomiej Dach
479ff7eb41
Merge pull request #30799 from peppy/fix-player-loader-focus-fux
...
Fix beatmap load not continuing when when settings slider is focused
2024-11-22 08:57:10 +01:00
Dean Herbert
a76b4418b9
Change some beatmap default settings to match stable
...
- Countdown should [be off by
default](9a07485638/osu9a07485638/osu
2024-11-22 16:55:37 +09:00
Bartłomiej Dach
512d2c6e3b
Merge branch 'master' into multiplayer-nrt
2024-11-22 08:09:42 +01:00
Bartłomiej Dach
4a129ac0bf
Merge pull request #30766 from Darius-Wattimena/catch-improve-info-on-selected
...
Add snapping info to the catch selected objects inspector
2024-11-22 08:08:33 +01:00
Dean Herbert
6a0ac4c29e
Merge pull request #29640 from smoogipoo/mania-imperfect-ss
...
Make mania award SS even if there are GREAT judgements
2024-11-22 14:42:32 +09:00
Dean Herbert
41addaae9a
Rename variable to imply it is now a function
2024-11-22 13:11:32 +09:00
Salman Alshamrani
5dffc322af
Recreate beatmap every test run in ModTestScene
2024-11-21 17:48:33 -05:00
Dan Balasescu
2a7266cb23
Fix tests
2024-11-22 01:26:35 +09:00
Dan Balasescu
f738fb2a89
Populate rooms as soon as they're joined
2024-11-21 23:48:04 +09:00
Dan Balasescu
84ac3097c2
Populate parameter description
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-21 22:47:46 +09:00
Bartłomiej Dach
74170ea28e
Merge branch 'master' into patch-1
2024-11-21 13:06:19 +01:00
Dan Balasescu
209380cbac
Enable NRT in TestMultiplayerRoomManager
2024-11-21 21:03:12 +09:00
Dan Balasescu
cc59434ea4
Fix crash due to being too forgiving of nulls
...
This one is super duper annoying to test, because we already have e.g.
`TestScenePlaylistsScreen`. The only way to test it would be to use an
`OsuGameTestScene`.
Maybe this is okay?
2024-11-21 20:52:34 +09:00
Dan Balasescu
dc45816566
Fix inspection
2024-11-21 20:41:14 +09:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists
2024-11-21 20:32:09 +09:00
Bartłomiej Dach
0e4d078beb
Merge branch 'master' into catch-improve-info-on-selected
2024-11-21 12:17:54 +01:00
Dean Herbert
033b7c17d5
Add back macOS precheck
2024-11-21 18:13:00 +09:00
Dan Balasescu
7018672275
Fix playlist room status resetting on enter
2024-11-21 18:11:41 +09:00
Dan Balasescu
fe8e9d455a
Add failing test
2024-11-21 18:09:39 +09:00
Cadence Ember
37394a5027
Use consistent decimal places in BeatmapAttributeText
2024-11-21 14:04:42 +13:00
Dean Herbert
2c0140f865
Merge pull request #30798 from frenzibyte/fix-precision
...
Add sane precision values to all settings
2024-11-21 03:00:49 +09:00
Dean Herbert
ae98f63b51
Fix beatmap load not continuing when when settings slider is focused
...
Regressed with recent sliderbar focus changes.
Closes #30716 .
2024-11-21 02:28:35 +09:00
Salman Alshamrani
40b95901e3
Fix more cases of settings with no defined precision values
2024-11-20 12:11:38 -05:00
Salman Alshamrani
1ef02fec06
Fix "positional hitsounds level" setting not specifying a precision constraint
2024-11-20 12:08:57 -05:00
Bartłomiej Dach
a679f0736e
Add ability to close playlists within grace period after creation
2024-11-20 12:36:12 +01:00
Fivoka
7726ca02b0
Changed multiplier from 2 to 3.5
2024-11-20 12:29:29 +01:00
Dean Herbert
6fba6de4dc
Merge branch 'master' into multiplayer-remove-cmc-and-composite
2024-11-20 17:24:55 +09:00
Dean Herbert
03de518484
Fix missing updateRoomPlaylist call
2024-11-20 16:56:22 +09:00
Dean Herbert
50089c027e
Update framework
2024-11-20 16:40:33 +09:00
Dean Herbert
b4077fc8a2
Use !FrameworkEnvironment.UseSDL3 instead of removing warning altogether
2024-11-20 16:28:11 +09:00
Dan Balasescu
53f0befc05
Merge pull request #30402 from peppy/import-paused-visibility
...
Update notification text when import is paused due to gameplay
2024-11-20 16:00:13 +09:00
Dean Herbert
b070a50ac9
Merge pull request #30718 from frenzibyte/initial-key-counter-state
...
Fix key counter not updating activation state on initial load
2024-11-20 15:39:44 +09:00
Dan Balasescu
a5327aa562
Use properties instead of fields
2024-11-19 18:48:30 +09:00
Bartłomiej Dach
273095fd82
Merge pull request #30757 from peppy/fix-scroll-absolute-pos
...
Fix right click scroll at song select not quite matching scrollbar position
2024-11-19 10:40:00 +01:00
Darius Wattimena
16158710f9
Made reading of ReadCurrentDistanceSnap public
2024-11-18 23:49:40 +01:00
Dean Herbert
a529cef28b
Merge pull request #30743 from peppy/collection-scroll-etc
...
Further UX improvements to collection management
2024-11-19 00:32:16 +09:00
Dean Herbert
a2af4cbb50
Fix right click scroll at song select not quite matching scrollbar position
...
Closes https://github.com/ppy/osu/issues/30744 .
2024-11-18 23:54:56 +09:00
Bartłomiej Dach
22b082d968
Fix not being able to scroll to new collection text box when list overflows
2024-11-18 15:28:30 +01:00
Bartłomiej Dach
259e9ecf65
Deactivate new combo toggle on deselecting objects
...
Closes https://github.com/ppy/osu/issues/30713 .
Was a point of discussion doing review:
https://github.com/ppy/osu/pull/30214#discussion_r1798833139
Given it got pointed out immediately for something so minor, I'm
inclined to believe it's a rather undesirable change.
2024-11-18 15:13:32 +01:00
Salman Alshamrani
0b52080a52
Handle logged out user
2024-11-18 06:47:22 -05:00
Salman Alshamrani
74daf85e48
Replace bindable with an event
2024-11-18 06:47:22 -05:00
StanR
4066186b24
Scale beatmap cards down by ~0.8
2024-11-18 14:48:51 +05:00
Sheppsu
7d4062d2ad
remove redundant Scale attribute
2024-11-18 04:04:28 -05:00
StanR
dcf4674c6c
Scale down beatmap cards in profile overlay
2024-11-18 14:01:17 +05:00
Sheppsu
29e7adcd3b
add player settings to multi spectator screen
2024-11-18 03:57:50 -05:00
Dean Herbert
ebc2cc3570
Ensure cleanup tasks are run even on a cancelled / exceptioned import task
2024-11-18 16:51:46 +09:00
Dean Herbert
5ce1f7679b
Add search bar to collection management dialog
2024-11-18 16:32:56 +09:00
Dean Herbert
a570863854
Scroll to new collection in list when adding a new collection
2024-11-18 16:32:56 +09:00
Dean Herbert
e5778eb1fc
Add scrollbar to manage collections dialog
2024-11-18 16:32:56 +09:00
Dan Balasescu
5276f77ebd
Merge pull request #30684 from Joehuu/source-filter
...
Add missing source query filter in song select
2024-11-18 16:06:26 +09:00
Salman Alshamrani
b106833663
Fix more test / component breakage
2024-11-17 20:36:12 -05:00
Salman Alshamrani
caf56afba6
Fix various test failures
2024-11-17 19:13:29 -05:00
Salman Alshamrani
1847b679db
Only update user rank panel display when ruleset matches
...
Nothing behaviourally different, just reduce number of redundant calls.
2024-11-17 18:45:07 -05:00
Salman Alshamrani
07609b6267
Fix UserRankPanel not updating on ruleset change
2024-11-17 18:32:17 -05:00
Salman Alshamrani
28f87407f6
Make DifficultyRecommender rely on the statistics provider
2024-11-17 18:32:17 -05:00
Salman Alshamrani
4a628287e2
Decouple game-wide ruleset bindable and refactor LocalUserStatisticsProvider
...
This also throws away the logic of updating
`API.LocalUser.Value.Statistics`. Components should rely on
`LocalUserStatisticsProvider` instead for proper behaviour and ability
to update on statistics updates.
2024-11-17 18:13:37 -05:00
Salman Alshamrani
6c8a900dcc
Merge branch 'master' into user-statistics-provider
2024-11-17 15:34:56 -05:00
Salman Alshamrani
b014bfea3e
Fix key counter not updating activation state on initial load
2024-11-17 09:56:19 -05:00
Joseph Madamba
ad9acc5a0f
Add hotkey hints to skin editor menus
2024-11-15 23:03:40 -08:00
Joseph Madamba
706f5b3e55
Add missing clone keybinding to skin editor
2024-11-15 23:03:40 -08:00
Joseph Madamba
465cc716d3
Add missing source query filter in song select
2024-11-15 22:53:23 -08:00
Dean Herbert
0a1f589c80
Fix black layer not fading fast enough when exiting quickly from quick restart
2024-11-16 11:52:02 +09:00
Dean Herbert
a5fab23e44
Update framework
2024-11-16 11:49:19 +09:00
Dean Herbert
c852cf9b8e
Remove macOS "borderless" recommendation
...
As of SDL3, this is no longer a thing, and fullscreen should be the
preferred execution mode.
Probably hold off merging this until we're sure that macOS isn't broken
for others in this mode (I had issues locally, such as alt-tabbing being
broken sooo...)
2024-11-15 18:29:01 +09:00
Bartłomiej Dach
21d407680b
Merge pull request #30623 from peppy/fix-flash-transition-player
...
Fix occasional flash when quick exiting / retrying from player
2024-11-15 08:42:43 +01:00
Dan Balasescu
db7def9d34
Remove IDependencyInjectionCandidate interface from Room
2024-11-15 16:05:06 +09:00
Dan Balasescu
1a656d0ec3
Remove CachedModelDependencyContainer usages from online play
2024-11-15 15:59:28 +09:00
Dan Balasescu
bfbae9458a
Remove OnlinePlayComposite
2024-11-15 15:59:28 +09:00
Dan Balasescu
34c0f72dd6
Make Room.Playlist non-bindable
2024-11-15 15:51:01 +09:00
Dan Balasescu
b16edbbf52
Make Room.RecentParticipants non-bindable
2024-11-15 15:25:43 +09:00
Dan Balasescu
dc5337d771
Make Room.UserScore non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
c4f8fd1832
Make Room.DifficultyRange non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
487a010b12
Make Room.PlaylistItemStats non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
80b3e330a6
Make Room.ChannelId non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
6c84e425f8
Make Room.MaxAttempts non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
0ceaafe731
Make Room.Duration & Room.StartDate & Room.EndDate non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
89de4f0f87
Make Room.AutoStartDuration non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
b8bae30b66
Make Room.ParticipantCount & Room.MaxParticipants non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
f001cce24a
Make Room.AutoSkip non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
ec5be6dbc3
Make Room.Password & Room.HasPassword non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
198681e644
Make Room.QueueMode non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
7e3e5208f0
Make Room.Availability non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
5d4838a08b
Make Room.Status non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
81e4cb348f
Make Room.Type non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
bde7b8e610
Make Room.Category non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
8694f7e1cc
Make Room.Host non-bindable
2024-11-15 14:42:17 +09:00
Dan Balasescu
6160df1586
Make Room.Name non-bindable
2024-11-15 14:29:15 +09:00
Dan Balasescu
58aba5439a
Merge pull request #30622 from bdach/not-enough-timed-events
...
Do not show timing distribution graph in offset control if there's not enough timed hits
2024-11-15 11:59:20 +09:00
Dean Herbert
1a31e56d4a
Fix double restart call still existing
2024-11-14 23:59:55 +09:00
Bartłomiej Dach
b94d3d7a64
Merge pull request #30607 from OliBomby/legacy-export-offset
...
Fix timing point truncation causing missnaps on compatibility-exported lazer beatmaps
2024-11-14 15:49:05 +01:00
Bartłomiej Dach
15a474dead
Merge pull request #30613 from shinmorisawa/1hour-song-multi
...
Fix difficulty icon tooltip not displaying duration above 1 hour correctly
2024-11-14 15:43:48 +01:00
Bartłomiej Dach
5d3f55fe4d
Fill out xmldoc
2024-11-14 15:05:46 +01:00
Dean Herbert
d1b5d31ea6
Add explicit parameter in
2024-11-14 22:23:42 +09:00
Dean Herbert
3262b6d989
Refactor to avoid dual-boolean mess
2024-11-14 22:10:45 +09:00
Dean Herbert
afeb138ea0
Fix occasional flash when quick exiting / retrying from player
...
The gist of the issue is that `fadeOut` was being called *twice* in the
quick exit/retry scenarios, causing weirdness with transforms.
I've restructured things to ensure it's only called once.
2024-11-14 21:54:34 +09:00
Bartłomiej Dach
7ee9802923
Merge pull request #30616 from peppy/collection-management-revamp
...
Fix collection management dialog refreshing full display when any change occurs
2024-11-14 13:21:09 +01:00
Bartłomiej Dach
bd1d3cad49
Do not show timing distribution graph in offset control if there's not enough timed hits
...
Intended to address concerns raised in
https://github.com/ppy/osu/pull/30620#issuecomment-2475744164 .
2024-11-14 13:17:03 +01:00
Bartłomiej Dach
d08c8ae482
Merge pull request #30620 from peppy/fix-offset-adjust-crash
...
Fix crash when resetting offset after a play with no hit events
2024-11-14 12:43:47 +01:00
Bartłomiej Dach
1355fa636d
Merge pull request #30603 from peppy/quick-restart-faster-better
...
Make quick restart even faster
2024-11-14 12:30:13 +01:00
Bartłomiej Dach
f9489690cb
Fix code inspection
2024-11-14 11:58:57 +01:00
Dean Herbert
36d48a01c8
Add missing expire call
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-14 19:33:34 +09:00
Dean Herbert
9849a88eef
Adjust transition further to avoid brief "jumpscare" display of metadata
2024-11-14 18:28:27 +09:00
Bartłomiej Dach
88aea70429
Do not permit new combo toggle to remain in indeterminate state on deselect
2024-11-14 10:07:09 +01:00
Bartłomiej Dach
1b279e45cc
Merge branch 'master' into feat/optimize-polygon-tool
2024-11-14 09:54:04 +01:00
Dean Herbert
23167b0221
Merge pull request #30618 from Natelytle/ltca-broke-pp
...
Fix NaN PP counter values while SR is 0
2024-11-14 17:42:05 +09:00
Shin Morisawa
7dff243e6a
use .ToFormattedDuration
2024-11-14 16:59:03 +09:00
Dean Herbert
4957a517aa
Update framework
2024-11-14 16:38:26 +09:00
Shin Morisawa
64e7e44f28
fix issue
2024-11-14 16:33:52 +09:00
Shin Morisawa
53fcb494ff
Merge branch 'ppy:master' into 1hour-song-multi
2024-11-14 16:32:24 +09:00
Bartłomiej Dach
02e4907fb6
Merge pull request #29896 from OliBomby/hs-toggle2
...
Collapse sample point indicators into dots if they cannot be displayed in full
2024-11-14 08:28:11 +01:00
Dean Herbert
7f8eebc510
Merge pull request #30578 from smoogipoo/beatmap-legacy-object-type
...
Simplify convertible hitobject parsing and add `IHasLegacyHitObjectType`
2024-11-14 16:16:44 +09:00
Dean Herbert
88d220f4c5
Fix crash when resetting offset after a play with no hit events
...
Closes https://github.com/ppy/osu/issues/30573 .
2024-11-14 16:03:15 +09:00
Nathen
d0e793a3b3
More correct but not too important
2024-11-14 01:50:05 -05:00
Nathen
2ea2e5f1db
Be doubly careful
2024-11-14 01:47:24 -05:00
Nathen
ce818f59e7
Fix NaN PP values when SR is 0
2024-11-14 01:42:07 -05:00
Dean Herbert
fea6a54432
Fix more tests reading in wrong order
2024-11-14 14:46:58 +09:00
Dean Herbert
17b1888c59
Avoid using newTexst as it doesn't work well with tests
2024-11-14 14:39:05 +09:00
Dean Herbert
ebe9a9f083
Avoid writing changes to realm when collection name wasn't actually changed
2024-11-14 14:39:05 +09:00
Dean Herbert
695f156f5f
Change collection management dialog to handle changes more correctly
2024-11-14 14:39:05 +09:00
Dean Herbert
d37c1bb6d0
Remove redundant null initialisation and apply nullability
2024-11-14 13:37:58 +09:00
Dean Herbert
7670a81181
Merge branch 'master' into bat-max-performance
2024-11-14 13:35:29 +09:00
Dean Herbert
2afd357901
Re-throw OperationCanceledException for consistency?
...
Mostly to see if it breaks anything.
2024-11-14 13:14:35 +09:00
Shin Morisawa
a3da10ff44
fixed said issue
2024-11-14 07:19:18 +09:00
Shin Morisawa
7e96ae6da4
change stuff. (idk what exactly)
2024-11-14 06:58:54 +09:00
OliBomby
b6eff38520
Fix timing point truncation in legacy beatmap export
2024-11-13 14:23:28 +01:00
Dan Balasescu
85d292ae57
Merge pull request #30602 from peppy/increase-idle-time
...
Increase idle time before gameplay loads when hovering controls
2024-11-13 21:21:23 +09:00
Dean Herbert
68945daa40
Add confirmation when pressing 'q' to quit at the main menu
...
Kinda a weird key. I feel like this deserves a confirmation step unlike
mouse clicking the exit button.
Addresses https://github.com/ppy/osu/discussions/30471 .
2024-11-13 19:27:20 +09:00
Dean Herbert
b82f420b52
Merge pull request #30433 from stanriders/fix-userpanel-overflow
...
Fix `UserRankPanel` rank overflowing on 6+ digits
2024-11-13 19:19:30 +09:00
Dean Herbert
54ca705680
Merge branch 'master' into hs-toggle2
2024-11-13 19:15:00 +09:00
Dean Herbert
2dbc275bb8
Make quick restart even faster
2024-11-13 18:11:25 +09:00
Dan Balasescu
60d45d44bb
Merge pull request #30536 from stanriders/add-diffcalc-helpers
...
Add `DifficultyCalculationUtils`
2024-11-13 17:49:40 +09:00
Dean Herbert
2ae8c36d17
Increase idle time before gameplay loads when hovering controls
2024-11-13 17:39:21 +09:00
Dan Balasescu
a2a930aa35
Fix CI issues
2024-11-13 17:15:50 +09:00
Dan Balasescu
5b2568d18b
Fix cases where the bindable is resolved directly
2024-11-13 16:38:49 +09:00
Dan Balasescu
99762da7b8
Make RoomID non-bindable
...
Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.
2024-11-13 16:28:54 +09:00
Dan Balasescu
db025d81ee
Reorder public property vs private field
2024-11-13 15:50:01 +09:00
Dean Herbert
0760451f3f
Merge branch 'master' into user-statistics-provider
2024-11-13 15:21:55 +09:00
Dean Herbert
78084e33af
Merge pull request #30411 from frenzibyte/editor-slider-touch-support-2
...
Fix placing objects via touch in editor not working sometimes
2024-11-13 15:09:57 +09:00
Dean Herbert
19f887e283
Merge branch 'master' into feat/optimize-polygon-tool
2024-11-13 13:59:54 +09:00
Dan Balasescu
f3fd87af7b
Make DrawableMatchRoom structurally match other implementations
2024-11-12 20:32:59 +09:00
Bartłomiej Dach
c25215d2cf
Merge pull request #30579 from peppy/fix-rank-display-song-select
...
Fix top rank display not showing up on beatmaps with many difficulties
2024-11-12 12:26:26 +01:00
Dan Balasescu
72564b5c98
Make CurrentPlaylistItem not a bindable
2024-11-12 18:17:24 +09:00
Dean Herbert
ce86208e09
Merge branch 'master' into import-paused-visibility
2024-11-12 17:02:21 +09:00
Dan Balasescu
678d14aa60
Merge pull request #30534 from Lawtrohux/difficult-strain
...
Globalise `CountDifficultStrains` within StrainSkill
2024-11-12 14:50:18 +09:00
Dean Herbert
8c5785fdf6
Make math more logical
2024-11-11 22:57:26 +09:00
Dean Herbert
ee4d58544d
Update framework (and other common packages)
2024-11-11 21:58:13 +09:00
Bartłomiej Dach
b430ac2214
Merge branch 'master' into song-select-less-semi-opaque
2024-11-11 11:04:48 +01:00
Bartłomiej Dach
d29dd2c223
Remove unused using directives
2024-11-11 11:04:43 +01:00
Bartłomiej Dach
c37e4877e2
Move setting back to timing panel
2024-11-11 10:08:26 +01:00
Dean Herbert
f84ee3996f
Reduce semi-opaque layers at song select
...
I made these changes while working on
https://github.com/ppy/osu/pull/30579 . Basically, it's hard to fix the
ranks not loading while underneath the footer, and the transparency both
looks bad, and is going away in the redesign.
I've chosen values here that are moving *in the direction* of the new
design without overhauling everything.
- I know that there's still some transparency. I did this because it
helps keep all current elements / colours contrasting without too much
effort.
- I completely removed the transparency adjustments on the beatmap
panels. This always looked bad due to being applied per-layer, and I
don't think it added much.
2024-11-11 17:57:23 +09:00
Bartłomiej Dach
0cddb93dda
Move setting to user config
2024-11-11 09:57:17 +01:00
Bartłomiej Dach
a6cdf6df07
Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm
2024-11-11 09:50:00 +01:00
Dean Herbert
e8b69581b7
Fix top rank display not showing up on beatmaps with many difficulties
2024-11-11 17:49:34 +09:00
Dean Herbert
f8ac54d61c
Fix weird local variable typo
2024-11-11 16:59:02 +09:00
Dan Balasescu
8c68db0a36
Remove unused params
2024-11-11 16:10:15 +09:00
Dan Balasescu
7206e97b7b
Add IHasLegacyHitObjectType to ConvertHitObject
2024-11-11 16:10:15 +09:00
Dan Balasescu
e1d93a7d9c
Merge implementations of ConvertHitObjectParser
...
Having these be separate implementations sounded awesome at the time,
but it only ever led to confusion. There's no practical difference if,
for example, catch sees hitobjects with `IHasPosition` instead of
`IHasXPosition`.
2024-11-11 15:09:13 +09:00
Dean Herbert
322df72cce
Merge pull request #30425 from bdach/multiplayer-song-select-wyd
...
Fix multiplayer song select not correctly applying filter sometimes
2024-11-11 14:54:48 +09:00
Dean Herbert
caedbdeccf
Merge pull request #30545 from bdach/fix-restore-storage-not-restoring-storage
...
Fix retry button on storage unavailable dialog not reopening realm if retry succeeds
2024-11-11 14:30:50 +09:00
Joseph Madamba
9acfb3c900
Fix break overlay grades not using localised string
2024-11-09 16:45:18 -08:00
Bartłomiej Dach
091d02b3a8
Fix retry button on storage unavailable dialog not reopening realm if retry succeeds
...
Related: https://github.com/ppy/osu/issues/30539
When starting up the game with a data location that points to an
unavailable external device, a new realm file is created in the default
location. Eventually a popup is shown that informs the user that the
external storage is unavailable, and the user has an option to try the
storage again. The button that invokes said option would check said
storage correctly, but would not do anything about realm, which means
the previously opened empty realm that is placed in the default location
would remain open, which means the retry essentially doesn't work
because the user's stuff isn't there after the retry.
To fix this, take out a `BlockAllOperations()`, which will flush all
open realms, and re-open the realm on the external location if the
custom storage restore succeeds.
2024-11-08 09:28:14 +01:00
StanR
c9d3b6557d
Fix code issues
2024-11-07 21:23:26 +05:00
StanR
78c97d2cd7
Add DifficultyCalculationUtils
2024-11-07 20:36:00 +05:00
Bartłomiej Dach
b0c6042b2a
Fix HUD elements shifting in unintended manner when partially off-screen flipped skin elements are present
...
Closes https://github.com/ppy/osu/issues/30286 .
2024-11-07 14:01:34 +01:00
Jay Lawton
7c3a3c4d10
rename DifficultStrains for clarity
2024-11-07 21:56:42 +10:00
Jay Lawton
2b6a473164
update methods
2024-11-07 21:12:04 +10:00
Dean Herbert
54288c350a
Merge pull request #30525 from smoogipoo/multiplayer-refactor
...
Replace `MultiplayerRoomComposite` with local bindings
2024-11-07 19:53:44 +09:00
Jay Lawton
a5e6da76cb
introduce difficult strains globally
2024-11-07 19:53:53 +10:00
Dean Herbert
c7d0a7dde2
Update xmldoc and make realm transactions more obvious
2024-11-07 18:31:06 +09:00
Dan Balasescu
bd630c189e
Fix tests not working by forgoing beatmap updates
2024-11-07 17:26:10 +09:00
Dean Herbert
da95a1a2f1
Update resources
2024-11-06 18:54:52 +09:00
Dean Herbert
366c0f664f
Merge branch 'master' into ruleset-selection-duck-tweak
2024-11-06 18:54:48 +09:00
Dan Balasescu
788ecc1e7b
Replace MultiplayerRoomComposite with local bindings
2024-11-06 15:31:27 +09:00
Bartłomiej Dach
2699ebb50d
Merge pull request #30505 from peppy/editor-hide-breaks
...
Add ability to hide breaks from timeline
2024-11-06 06:54:49 +01:00
Bartłomiej Dach
23f3890293
Fix effect point scroll speeds below 0.1x not being encoded properly
...
Closes https://github.com/ppy/osu/issues/30472 .
Caused by mismatching bounds between
2bd12e14db/osu.Game/Beatmaps/ControlPoints/EffectControlPoint.cs (L22-L26)2bd12e14db/osu.Game/Beatmaps/ControlPoints/DifficultyControlPoint.cs (L21-L28)
2024-11-05 11:56:19 +01:00
Bartłomiej Dach
2bd12e14db
Merge pull request #30467 from cdwcgt/friend-add
...
Add the ability to add/remove friends in `UserProfileHeader`
2024-11-05 10:25:27 +01:00
cdwcgt
c576fd8448
add AddFriendResponse
2024-11-05 15:55:42 +08:00
Dean Herbert
1fcdf67806
Handle response to get accurate mutual state immediately
2024-11-05 16:20:55 +09:00
Dean Herbert
0087270b7e
Update status and count immediately after friend request completes
2024-11-05 14:53:54 +09:00
Dean Herbert
f21d2de8e8
Merge pull request #30496 from bdach/copy-link-to-score
...
Add context menu option to copy link to an online score
2024-11-05 14:03:47 +09:00
Dean Herbert
9d65d394d3
Add ability to hide breaks from timeline
...
This was another IRL request from a mapper / team member. The rationale
here is that it can be very annoying to map with break time enabled if
you have a large gap in the beatmap you are trying to fill with
hitobjects, as you are placing objects on top of a very gray area.
2024-11-05 12:56:19 +09:00
Bartłomiej Dach
74d5de2d13
Remove redundant initialiser
2024-11-04 14:49:11 +01:00
Bartłomiej Dach
1dee041448
Add search textbox in friends display
...
Random user feature request that made sense to me because the same thing
is in currently online display.
Yes web doesn't have this, but web is in a browser where you can Ctrl-F.
You can't do that in the client.
Design taken out of posterior because I can't be bothered waiting for
design cycles for this.
2024-11-04 14:40:30 +01:00
Bartłomiej Dach
6a1893ff3f
Add context menu option to copy link to an online score
...
I feel like this may become useful soon enough to help diagnose weird
issues.
2024-11-04 13:59:48 +01:00
Bartłomiej Dach
51f26993fa
Extract "copy link" text to common localisation
2024-11-04 13:59:48 +01:00
Bartłomiej Dach
e064965281
Remove weird method
2024-11-04 13:13:23 +01:00
Bartłomiej Dach
00e795cf76
Merge pull request #30484 from peppy/store-scale-origin-mode
...
Remember origin for editor scale/rotation popover
2024-11-04 12:58:06 +01:00
Bartłomiej Dach
cb833007e0
Adjust colours to actually match web
2024-11-04 12:02:20 +01:00
Dean Herbert
c99c82ab08
Merge pull request #30460 from Lawtrohux/t-speed-deviation
...
Implement stamina consideration for Mono (single-coloured) patterns.
2024-11-04 19:38:50 +09:00
Dean Herbert
c4a02b7991
Merge pull request #30489 from iSlodinxOsu/loved
...
Remove `by the beatmap creator` in `PlayerLoaderStrings`
2024-11-04 18:39:21 +09:00
Salman Alshamrani
99518f4a56
Specify type of text input in most TextBox usages
2024-11-04 04:28:17 -05:00
iSlodinx
a49b2eaa3b
Update PlayerLoaderStrings.cs
2024-11-03 18:52:40 +01:00
Dean Herbert
3a3471c202
Remember origin for editor rotation popover
2024-11-03 15:23:55 +09:00
Dean Herbert
b03963ac84
Remember origin for editor scale popover
2024-11-03 15:20:51 +09:00
Bartłomiej Dach
7e3bb763cd
Merge branch 'master' into key-reversion-conflict
2024-11-01 19:40:27 +01:00
Bartłomiej Dach
f5a2674f66
Rewrite fix in a more legible way
...
- Use better param name ("restoring" what bindings? the key information
there is that the *defaults* are being restored)
- Split ugly and not easily understandable (but probably
best-that-can-be-done) conditional out to a method and comment it
appropriately
2024-11-01 19:38:45 +01:00
Bartłomiej Dach
f2afec23f9
Merge branch 'master' into hs-toggle2
2024-11-01 18:44:33 +01:00
Bartłomiej Dach
8f48682d0a
Remove hide sample toggle
...
In line with feedback from
https://github.com/ppy/osu/pull/29896#issuecomment-2378676851 .
2024-11-01 18:44:24 +01:00
Dan Balasescu
ef22b6b1a8
Round to integral units
...
The rounding matches the implementation of `PerformancePointsCounter`.
2024-11-01 22:43:52 +09:00
Bartłomiej Dach
3dc2408965
Merge branch 'master' into bat-max-performance
2024-11-01 13:13:20 +01:00
cdwcgt
1a92e5ad19
remove CreateAPIRelationFromAPIUser
2024-11-01 19:24:58 +08:00
cdwcgt
fbe6077ec2
rename FriendDeleteRequest to DeleteFriendRequest
2024-11-01 19:17:25 +08:00
cdwcgt
21b1c799f3
rename FriendAddRequest to AddFriendRequest
2024-11-01 19:16:56 +08:00
cdwcgt
729c7f11a9
add StringEnumConverter for RelationType
2024-11-01 19:15:20 +08:00
Bartłomiej Dach
1b5d1347aa
Merge branch 'master' into bat-mods
2024-11-01 11:27:06 +01:00
Bartłomiej Dach
5f63950598
Add missing disposal
2024-11-01 11:26:59 +01:00
Dan Balasescu
9766d51559
Store attribute to the database
2024-11-01 16:02:02 +09:00
cdwcgt
9e4c382a61
add tooltips
2024-11-01 14:43:00 +08:00
cdwcgt
3bd116cd65
typo
2024-11-01 14:42:50 +08:00
cdwcgt
29ba13fe77
store follower count locally
2024-11-01 14:06:23 +08:00
cdwcgt
0b2f4facac
add test
2024-11-01 14:05:24 +08:00
cdwcgt
45cc830aee
logic in FollowersButton
2024-11-01 12:54:13 +08:00
cdwcgt
350e1d6332
add ability to shou loading layer and set icon for followersButton
2024-11-01 12:53:57 +08:00
cdwcgt
69b5bd3b50
Fix existing friend logic
2024-11-01 12:53:13 +08:00
cdwcgt
bf53833b7b
add API model and request
2024-11-01 12:52:37 +08:00
Dan Balasescu
372162de5d
Ignore casing when matching mods acronyms
2024-10-31 08:55:42 +09:00
Bartłomiej Dach
7e3564cb4a
Bring back matching by filename when performing online metadata lookups
2024-10-30 10:25:20 +01:00
Luke Knight
0f61e19857
Fixed formatting for InspectCode
2024-10-30 03:02:51 -05:00
Bartłomiej Dach
2b0fd3558f
Remove more no-longer-required checks
...
The scenario that remaining guard was trying to protect against is
obviated by and no longer possible after
776fabd77c
2024-10-30 08:44:23 +01:00
Bartłomiej Dach
0e52797f29
Prefer not deleted models when picking model instances for reuse when importing
...
This fell out while investigating why the issue with online IDs
mismatching in the `.osu` could be worked around by importing the map
three times in total when starting from it not being available locally.
Here follows an explanation of why that "helped".
Import 1:
- The beatmap set is imported normally.
- Online metadata population sees the online ID mismatch and resets it
on the problematic beatmap.
Import 2:
- The existing beatmap set is found, but deemed not reusable
because of the single beatmap having its ID reset to -1.
- The existing beatmap set is marked deleted, and all the IDs of
its beatmaps are reset to -1.
- The beatmap set is reimported afresh.
- Online metadata population still sees the online ID mismatch
and resets it on the problematic beatmap.
Note that at this point the first import *is still physically present
in the database* but marked deleted.
Import 3:
- When trying to find the existing beatmap set to see if it can be
reused, *the one pending deletion and with its IDs reset -
- the remnant from import 1 - is returned*.
- Because of this, `validateOnlineIds()` resets online IDs
*on the model representing the current reimport*.
- The beatmap set is reimported yet again.
- With the online ID reset, the online metadata population check for
online ID mismatch does not run because *the IDs were reset to -1*
earlier.
Preferring undeleted models when picking the model instance for reuse
prevents this scenario.
2024-10-30 08:18:44 +01:00
Bartłomiej Dach
776fabd77c
Only use MD5 when performing metadata lookups
...
Both online and offline using the cache.
The rationale behind this change is that in the current state of
affairs, `TestPartiallyMaliciousSet()` fails in a way that cannot be
reconciled without this sort of change.
The test exercises a scenario where the beatmap being imported has an
online ID in the `.osu` file, but its hash does not match the online
hash of the beatmap. This turns out to be a more frequent scenario than
envisioned because of users doing stupid things with manual file editing
rather than reporting issues properly.
The scenario is realistic only because the behaviour of the endpoint
responsible for looking up beatmaps is such that if multiple parameters
are given (e.g. all three of beatmap MD5, online ID, and filename), it
will try the three in succession:
f6b341813b/app/Http/Controllers/BeatmapsController.php (L260-L266)
2024-10-30 08:12:30 +01:00
Luke Knight
b42fa23e42
Prevent key bind conflict on reversion
2024-10-30 02:04:03 -05:00
Bartłomiej Dach
1a2e323c11
Remove problematic online ID check
2024-10-30 07:40:08 +01:00
Dan Balasescu
904b76b9d7
Merge pull request #30424 from bdach/wtf-wtf-wtf-wtf
...
Do not fall back to beatmap's original ruleset if conversion fails
2024-10-28 17:14:19 +09:00
StanR
86989aa5ce
Fix UserRankPanel rank overflowing on 6+ digits
2024-10-27 13:40:29 +05:00
Salman Alshamrani
979065c421
Reorder code slightly
2024-10-26 23:09:17 -04:00
Salman Alshamrani
0e65655fef
Remove redundant condition in else branch
...
Yep.
2024-10-25 23:15:17 -04:00
Bartłomiej Dach
09582aa653
Merge pull request #30413 from peppy/slider-bar-focus
...
Adjust slider bar implementations to show focused state
2024-10-25 21:51:54 +02:00
Bartłomiej Dach
b78e7d5d9a
Fix multiplayer song select not correctly applying filter sometimes
...
Fixes the root client-side failure causing
https://github.com/ppy/osu/issues/30415 .
Thread of breakage is as follows:
1. `SongSelect` loads the carousel.
At this point, the ruleset is what the ambient ruleset would have
been at the time of pushing song select, so most likely it will
match the current ruleset.
Notably, the carousel is loaded with `AllowSelection == false`.
2. `OnlinePlaySongSelect` sets the ruleset to the one taken from
the relevant playlist item in `LoadComplete()`.
3. At any point between the previous and the next step, the user
changes the ruleset manually.
4. `SongSelect.carouselBeatmapsLoaded()` is ran, which calls
`transferRulesetValue()`, which calls `FilterControl.FilterChanged`.
But at this stage `Carousel.AllowSelection` is still false, so
the filter is not executed, but `pendingFilterApplication` is set
instead.
Unfortunately, the pending filter never gets applied after that.
The only place that checks that flag is `OnEntering()`, which at
this point has already ran.
To fix, move the `pendingFilterApplication` check to `Update()`, which
seems like the most obvious and safe solution.
2024-10-25 21:29:53 +02:00
Bartłomiej Dach
e96d593b1f
Fix redundant array type specification
2024-10-25 19:58:31 +02:00
Bartłomiej Dach
b72a50bbaa
Merge pull request #30387 from peppy/editor-sidebars-always-expanded
...
Keep editor sidebars expanded by default
2024-10-25 19:46:35 +02:00
Jamie Taylor
f5071c205f
Increase ducking duration when selecting Mania ruleset
2024-10-26 01:45:51 +09:00
Bartłomiej Dach
9902c22f5c
Do not fall back to beatmap's original ruleset if conversion fails
...
I don't know why this was ever a good idea, and would say that we want
this to fail *hard* not soft. If things ever get in this state, things
have gone *seriously* wrong elsewhere, and need to be fixed there.
2024-10-25 13:16:24 +02:00
Dean Herbert
68e8819f3b
Fix taiko playfield looking weird with new editor toolbox displays
2024-10-25 17:17:19 +09:00
Salman Alshamrani
fdeb8b907e
Merge branch 'master' into user-statistics-provider
2024-10-25 03:17:37 -04:00
Salman Alshamrani
44dd81363a
Make UserStatisticsWatcher fully rely on LocalUserStatisticsProvider
2024-10-25 03:15:41 -04:00
Dean Herbert
1fc221bb39
Fix focus glow appearing above range slider's nubs
2024-10-25 16:13:02 +09:00
Dean Herbert
c666fa7472
Update framework
2024-10-25 16:09:08 +09:00
Salman Alshamrani
3a57b21c89
Move LocalUserStatisticsProvider to non-base game class and make dependency optional
2024-10-25 02:38:41 -04:00
Salman Alshamrani
2fd495228c
Fix post-merge errors
2024-10-25 02:38:01 -04:00
Salman Alshamrani
701fb565b1
Merge branch 'master' into user-statistics-provider
2024-10-25 01:35:24 -04:00
Salman Alshamrani
1d559b2cad
Remove fade transitions
2024-10-24 16:20:49 -04:00
OliBomby
eb61da4232
only consider hit objects which are visible in timeline for contracted state
2024-10-24 21:22:09 +02:00
Dean Herbert
6e8400a958
Fix gap in ShearedSliderBar when focused
2024-10-24 20:37:38 +09:00
OliBomby
88e88bdc4f
Fix addition banks disabled on reset
2024-10-24 13:17:49 +02:00
OliBomby
5b92a9ff59
Fix enabled state not updating drawable
2024-10-24 13:15:09 +02:00
Dean Herbert
940220b649
Fix big oops
2024-10-24 19:57:39 +09:00
Dean Herbert
6dd1efa013
Adjust slider bar implementations to show focused state
2024-10-24 19:46:20 +09:00
Dean Herbert
787d3dceea
Merge branch 'master' into auto-addition2
2024-10-24 18:40:27 +09:00
Dean Herbert
77bd0e8d70
Add visual disabled state to ternary buttons
2024-10-24 18:36:34 +09:00
Dean Herbert
61f0cfd688
Make flow more async to avoid any chance of deadlocks
2024-10-24 17:56:51 +09:00
Salman Alshamrani
6e9ff49e59
Merge branch 'master' into editor-slider-touch-support-2
2024-10-23 17:02:38 -04:00
Salman Alshamrani
3a4d5af83e
Fix placement blueprints sometimes not behaving correctly with touch input
...
More specifically, this fixes placement blueprints not beginning placement when using touch input while the cursor was previously outside compose area, due to the placement blueprint not existing (removed from the scene by `ComposeBlueprintContainer`).
2024-10-23 16:51:21 -04:00
OliBomby
ddbeb56f0f
Show tooltip on auto normal bank when not usable
2024-10-23 21:25:37 +02:00
Dean Herbert
7b2ca2f388
Merge pull request #30400 from peppy/quote-source-search
...
Quote source text when searching for it via click
2024-10-23 23:50:03 +09:00
Dean Herbert
77d2f35765
Merge pull request #30375 from bdach/fix-broken-playfield-skin-layer-rotation
...
Fix playfield skinning layer no longer correctly rotating with the playfield
2024-10-23 19:50:39 +09:00
Dean Herbert
064aaeb60e
Initialise container earlier to avoid null reference failures
2024-10-23 18:46:20 +09:00
Dean Herbert
c1453cfd0c
Merge pull request #30389 from bdach/fix-looping-samples-not-stopping
...
Fix old looping samples not stopping when replacing a `SkinnableSound`'s `Samples`
2024-10-23 18:39:55 +09:00
Dean Herbert
cb880f7e9b
Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm
2024-10-23 18:20:43 +09:00
