Dan Balasescu
c065f761c7
Merge branch 'master' into legacy-skin-default-fallback
2021-06-02 19:08:52 +09:00
Dean Herbert
e0eb0adb0a
Remove unnecessary bind in ReplayPlayer
2021-06-02 18:32:14 +09:00
Nathan Alo
3c3ef13632
remove fade
2021-06-02 16:28:22 +08:00
Nathan Alo
e66f6e8f91
fix inspect code issues and cleanup code
2021-06-02 16:12:41 +08:00
Nathan Alo
dde64adcb5
add new background type in BackgroundScreenDefault
2021-06-02 15:51:43 +08:00
Nathan Alo
dec18ef826
implement BeatmapBackgroundWithStoryboard
2021-06-02 15:50:58 +08:00
Nathan Alo
5b436ee436
add beatmap with storyboard source
2021-06-02 15:50:33 +08:00
Dean Herbert
5366e7f61e
Merge branch 'master' into remove-hud-component-lookup
2021-06-02 16:10:06 +09:00
Dean Herbert
f8ae70e562
Update existing function type rather than adding an override
2021-06-02 16:04:53 +09:00
Dean Herbert
a15cac6f53
Change the way Score
is initialised in Player
to better lend to population of metadata
2021-06-02 15:44:04 +09:00
Dan Balasescu
47019196f6
Merge branch 'master' into fix-relative-link-resolution
2021-06-02 14:55:38 +09:00
Dean Herbert
ac761bb075
Use string.Empty
instead of arbitrary string
2021-06-02 14:43:35 +09:00
Dean Herbert
4759ac098f
Merge pull request #13293 from smoogipoo/update-dependencies
...
Update dependencies
2021-06-02 14:35:06 +09:00
Dean Herbert
4fd8c9c17b
Merge pull request #13284 from ppy/dependabot/nuget/ppy.LocalisationAnalyser-2021.525.0
...
Bump ppy.LocalisationAnalyser from 2021.524.0 to 2021.525.0
2021-06-02 14:34:37 +09:00
Dean Herbert
45984f035b
Make autoplay tests test via the ReplayPlayer
code path
2021-06-02 11:49:06 +09:00
smoogipoo
d3d8941ec8
Make method internal
2021-06-02 11:11:41 +09:00
Dean Herbert
911256603b
Rewrite comment to hopefully be more informative
2021-06-02 11:10:02 +09:00
smoogipoo
8ee2b3a2d2
Merge branch 'master' into fix-scrolling-lifetime
2021-06-02 11:08:28 +09:00
Dan Balasescu
ac83450791
Merge pull request #13256 from ekrctb/update-lifetime-2
...
Update DHO lifetime on entry lifetime change
2021-06-02 11:07:54 +09:00
Dean Herbert
8a76d97b63
Remove replay logic from DrawableRuleset
(and implement in DrawableEditorRulesetWrapper
)
2021-06-02 11:06:30 +09:00
smoogipoo
51e4b6c860
Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.6' into update-dependencies
2021-06-02 09:21:26 +09:00
smoogipoo
4184cb88f6
Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.6' into update-dependencies
2021-06-02 09:21:09 +09:00
smoogipoo
dc31e2925c
Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.6' into update-dependencies
2021-06-02 09:20:37 +09:00
smoogipoo
e19568c91b
Merge remote-tracking branch 'ppy/dependabot/nuget/Sentry-3.4.0' into update-dependencies
2021-06-02 09:20:33 +09:00
smoogipoo
b0a229da87
Merge remote-tracking branch 'ppy/dependabot/nuget/ppy.LocalisationAnalyser-2021.525.0' into update-dependencies
2021-06-02 09:20:31 +09:00
dependabot[bot]
a758b38278
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore ) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:32 +00:00
dependabot[bot]
a10ef2ba65
Bump Humanizer from 2.8.26 to 2.10.1
...
Bumps [Humanizer](https://github.com/Humanizr/Humanizer ) from 2.8.26 to 2.10.1.
- [Release notes](https://github.com/Humanizr/Humanizer/releases )
- [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md )
- [Commits](https://github.com/Humanizr/Humanizer/compare/v2.8.26...v2.10.1 )
---
updated-dependencies:
- dependency-name: Humanizer
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:31 +00:00
dependabot[bot]
deaa381440
Bump Sentry from 3.3.4 to 3.4.0
...
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet ) from 3.3.4 to 3.4.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases )
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.3.4...3.4.0 )
---
updated-dependencies:
- dependency-name: Sentry
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:30 +00:00
dependabot[bot]
bd8db2ce63
Bump ppy.LocalisationAnalyser from 2021.524.0 to 2021.525.0
...
Bumps [ppy.LocalisationAnalyser](https://github.com/ppy/osu-localisation-analyser ) from 2021.524.0 to 2021.525.0.
- [Release notes](https://github.com/ppy/osu-localisation-analyser/releases )
- [Commits](https://github.com/ppy/osu-localisation-analyser/compare/2021.524.0...2021.525.0 )
---
updated-dependencies:
- dependency-name: ppy.LocalisationAnalyser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:28 +00:00
dependabot[bot]
ea9919e8fe
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.5 to 5.0.6
...
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore ) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:27 +00:00
dependabot[bot]
069baab883
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore ) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-01 19:59:27 +00:00
Dean Herbert
92ffc4627f
Update framework
2021-06-01 23:24:49 +09:00
Dean Herbert
2e2281c7d2
Revert disabling taiko sample tests and fix logic
2021-06-01 18:57:19 +09:00
Dean Herbert
e8aa5c4ecf
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-06-01 18:05:00 +09:00
Dean Herbert
cd139660ab
Merge branch 'master' into legacy-skin-default-fallback
2021-06-01 18:04:54 +09:00
Dean Herbert
3a6d081d82
Remove duplicated taiko fallback
2021-06-01 18:04:49 +09:00
Dean Herbert
ea4644be90
Revert "Fix weird taiko logic failing for weird reasons that probably should not have been a thing"
...
This reverts commit 69c4ccad05
.
2021-06-01 18:04:49 +09:00
Dean Herbert
a837fc9e3b
Remove duplicated taiko fallback
2021-06-01 18:00:24 +09:00
Dean Herbert
f14c0eae99
Fix editor no longer creating autoplay frames
2021-06-01 17:28:41 +09:00
Dean Herbert
df0a5689e4
Revert "Fix weird taiko logic failing for weird reasons that probably should not have been a thing"
...
This reverts commit 69c4ccad05
.
2021-06-01 17:13:13 +09:00
Dean Herbert
3668f1861f
Fix one more null issue
2021-06-01 17:10:09 +09:00
Dean Herbert
ff815cb4b4
Fix incorrect xmldoc
2021-06-01 16:57:41 +09:00
Dean Herbert
289dc00f38
Merge branch 'master' into autoplay-pause-support
2021-06-01 16:50:44 +09:00
Dean Herbert
145e42928b
Fix remaining null checks
2021-06-01 16:49:05 +09:00
Dean Herbert
1f8abcdf6c
Merge branch 'master' into fix-relative-link-resolution
2021-06-01 16:49:02 +09:00
Dean Herbert
6e861a9b7f
Revert incorrect ScoreProcessor
change
2021-06-01 16:39:50 +09:00
Dean Herbert
790f1dacc9
Ensure ScoreProcessor
is still hooked up in special case
2021-06-01 16:24:38 +09:00
Salman Ahmed
7c6400735f
Merge branch 'master' into remove-hud-component-lookup
2021-06-01 10:17:52 +03:00
Salman Ahmed
c090110ae2
Provide cell skin on content creation
2021-06-01 10:16:13 +03:00
Gagah Pangeran Rosfatiputra
b4dd935538
add corner radius and padding
2021-06-01 14:14:12 +07:00
Gagah Pangeran Rosfatiputra
5108dadfbc
use inline code in markdown text flow
2021-06-01 14:03:57 +07:00
Gagah Pangeran Rosfatiputra
1babb05fc7
add OsuMarkdownInlineCode
2021-06-01 14:03:31 +07:00
Dean Herbert
3ba0d29108
Fix incorrect beatmap being parsed down for autoplay generation
2021-06-01 15:44:24 +09:00
Dean Herbert
240f7facba
Add local concessions for autoplay test handling
2021-06-01 15:39:02 +09:00
Dean Herbert
dce24e3d4d
Merge pull request #12950 from gagahpangeran/osu-wiki-overlay
...
Initial implementation of Wiki Overlay
2021-06-01 15:20:56 +09:00
ekrctb
40949f6c1b
Simplify lifetime setter
...
Setting entry lifetime will cause `LifetimeChanged` event and `base.LifetimeStart`/`End` will be modified in the callback.
2021-06-01 14:46:43 +09:00
ekrctb
0f381f7758
Fix wrong code
2021-06-01 14:38:02 +09:00
Dean Herbert
6ef9b346e1
Fix newly found inspections from 2021.1EAP1
2021-06-01 14:33:21 +09:00
ekrctb
86020adf64
Revert invalid code transformation
2021-06-01 14:28:23 +09:00
Dean Herbert
cbf3ef5400
Create replay via the ICreateReplay
interface instead of explicitly ModAutoplay
2021-06-01 14:22:16 +09:00
Dean Herbert
9221213fe5
Fix potential nullref is beatmap load failed
2021-06-01 14:19:23 +09:00
Dean Herbert
14570b6fb1
Merge branch 'master' into autoplay-pause-support
2021-06-01 14:19:21 +09:00
Dean Herbert
a9f4bc6285
Never return a null argument
...
Enable nullable
2021-06-01 14:11:17 +09:00
Dean Herbert
27b7039520
Use constant
2021-06-01 14:02:32 +09:00
Dean Herbert
6e4730652e
Push private methods down
2021-06-01 14:01:08 +09:00
Dean Herbert
3ff97f787a
Localise all URL generation for now to avoid weird Schedule
logic
2021-06-01 13:56:59 +09:00
Dean Herbert
111bfd4d88
Fix relative URLs having a null argument after resolution to LinkDetails
2021-06-01 13:50:20 +09:00
ekrctb
d5714e63b9
Apply code styling suggestions
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-06-01 13:17:30 +09:00
ekrctb
86d1ba7ef2
Remove unused IScrollingHitObject
interface
2021-05-31 23:17:26 +09:00
Dean Herbert
00b3eea840
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-05-31 21:39:04 +09:00
Dan Balasescu
bd7814b487
Merge pull request #13257 from ekrctb/simplify-shoc
...
Multiple `ScrollingHitObjectContainer` logic simplification
2021-05-31 21:31:10 +09:00
Dean Herbert
69c4ccad05
Fix weird taiko logic failing for weird reasons that probably should not have been a thing
2021-05-31 21:29:47 +09:00
Dean Herbert
1161378b6b
Fix incorrect fallback logic in LegacyBeatmapSkin
2021-05-31 21:29:47 +09:00
Dean Herbert
282c5a9177
Fix potential nullref in SkinProvidingContainer
2021-05-31 21:29:47 +09:00
Dean Herbert
3ff9f9c89d
Make FindProvider
non-default
2021-05-31 21:29:47 +09:00
Dean Herbert
8e489754cc
Add ability for LegacySkin
s to customise the fallback provider
2021-05-31 21:29:47 +09:00
Dean Herbert
88ed95e012
Add FindProvider
lookup function
2021-05-31 21:29:47 +09:00
Dean Herbert
1d30791ab0
Add potential pathway for legacy lookups
2021-05-31 21:29:47 +09:00
Dean Herbert
4b27d43e26
Add new parameter for default fallback logic in LegacySkin
2021-05-31 21:29:47 +09:00
ekrctb
ff04942295
Change timing of HitObjectContainer.OnAdd
/OnRemove
...
Now, `OnAdd` is always invoked after the DHO is added to the container.
This change is required by `ScrollingHitObjectContainer` to compute origin adjusted lifetime when origin position is relative to the parent drawable size.
2021-05-31 20:56:25 +09:00
Dan Balasescu
9036b13637
Merge pull request #13260 from peppy/legacy-skin-resource-improvements
...
Allow `LegacyDefaultSkin` to be constructed without extra resource store parameter
2021-05-31 20:49:21 +09:00
Dean Herbert
f60e9cb085
Remove weird override logic in TestCase
methods
2021-05-31 20:00:47 +09:00
Dean Herbert
e78391db7a
Fix usage of DI before it's ready in combo colour tests
2021-05-31 19:58:19 +09:00
Dean Herbert
17fa2426d4
Merge branch 'master' into legacy-skin-resource-improvements
2021-05-31 19:36:09 +09:00
smoogipoo
7f24518004
Fix spectator crashing when converting mania replay frames
2021-05-31 19:24:22 +09:00
smoogipoo
d2d0896298
Expose GameplayBeatmap and GameplayRuleset from Player
2021-05-31 19:22:20 +09:00
Dean Herbert
ebfc24a499
Rename conflicting resources
2021-05-31 19:14:49 +09:00
Dean Herbert
65709ec7d7
Move leagcy resource store construction local to DefaultLegacySkin
2021-05-31 19:14:49 +09:00
Dan Balasescu
46b6f49a92
Merge pull request #13230 from peppy/non-nullable-beatmapset-files
...
Make `BeatmapSet.Files` non-nullable
2021-05-31 19:10:03 +09:00
Dean Herbert
d1ef5483bc
Merge pull request #12826 from frenzibyte/catch-hide-combo-workaround
...
Hide legacy HUD combo counters on osu!catch ruleset
2021-05-31 19:04:25 +09:00
Dean Herbert
b16d10bd95
Provide game-wide resources via IStorageResourceProvider
2021-05-31 18:57:47 +09:00
Dean Herbert
675fe37446
Change check order around to ensure re-fetches which return no results don't nullref
2021-05-31 18:35:18 +09:00
Dean Herbert
d4cb70735d
Merge branch 'master' into non-nullable-beatmapset-files
2021-05-31 18:19:57 +09:00
Dan Balasescu
d8768a8c01
Merge pull request #13254 from peppy/fix-editor-beatmap-creation-test-failure-again
...
Fix bindable lease failure in editor beatmap creation tests
2021-05-31 17:38:19 +09:00
ekrctb
948a14a627
Merge branch 'simplify-shoc' into fix-scrolling-lifetime
...
# Conflicts:
# osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs
2021-05-31 16:50:47 +09:00
ekrctb
86d1225aad
Reset lifetime to initial lifetime when layout is invalidated
2021-05-31 16:47:10 +09:00
ekrctb
6d96846776
Remove scrollLength
caching field
...
It was not clear when the field is updated.
2021-05-31 16:28:02 +09:00
ekrctb
742c5b442b
Remove delay of lifetime update
...
The scheduling is no longer necessary because `OnAdd` is changed to not invoked immediately for non-pooled DHOs.
2021-05-31 16:24:13 +09:00
ekrctb
3cedc0824d
Don't add nested hit objects to the sets
...
Only top-level hit objects are checked for layout computation caching.
Also, lifetime of nested hit objects are not managed by the HitObjectContainer.
2021-05-31 16:20:35 +09:00
ekrctb
56a0a24cba
Make SetInitialLifetime public
2021-05-31 15:33:28 +09:00
Dean Herbert
de0e51a81d
Merge branch 'master' into fix-skin-sample-lookup
2021-05-31 15:27:39 +09:00
Salman Ahmed
4e186b0cf5
ContentVisible
-> HiddenByRulesetImplementation
2021-05-31 09:24:26 +03:00
Salman Ahmed
02d18c7a49
Merge branch 'master' into remove-hud-component-lookup
2021-05-31 09:23:04 +03:00
ekrctb
e25cca6fbe
Update drawable lifetime on entry lifetime change
2021-05-31 14:45:29 +09:00
Dan Balasescu
8c6277f0d8
Merge pull request #13235 from ekrctb/update-lifetime-1
...
Update hit object lifetime on `HitObject.DefaultsApplied`
2021-05-31 14:44:40 +09:00
Dean Herbert
5925beaf21
Fix bindable lease failure in editor beatmap creation tests
2021-05-31 14:24:46 +09:00
Dean Herbert
06bd696cc2
Remove previous
consumption logic in GetWorkingBeatmap
...
This should not be required since the introduction of `workingCache`,
which does the same thing in a more global way.
2021-05-31 14:11:58 +09:00
ekrctb
0c101d2859
Apply comment rewording suggestion
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-05-31 13:41:49 +09:00
smoogipoo
a4dca6f839
Reorder methods around load()
2021-05-31 13:39:18 +09:00
Dan Balasescu
1ba607b3ff
Merge branch 'master' into osu-game-base-cleanup
2021-05-31 13:32:09 +09:00
Salman Ahmed
fb111e23d8
Remove "temporarily"
2021-05-31 07:24:59 +03:00
Gagah Pangeran Rosfatiputra
113f90e92e
add back schedule is CurrentPath setter
2021-05-31 10:49:16 +07:00
smoogipoo
bca8a9ea53
Fix HandleFrame crashing when not playing
2021-05-31 10:02:02 +09:00
Bartłomiej Dach
ab077c6656
Merge branch 'master' into non-nullable-beatmapset-files
2021-05-31 00:10:03 +02:00
Salman Ahmed
3fbd4e276d
Add simple xmldoc
2021-05-31 00:07:29 +03:00
Bartłomiej Dach
78213e09d4
Merge branch 'master' into editor-exit-stability
2021-05-30 23:03:50 +02:00
Salman Ahmed
d12e93bfc6
Add skin traget resetting on setup/teardown steps
2021-05-31 00:02:55 +03:00
Gagah Pangeran Rosfatiputra
3c7f1ae996
Merge branch 'master' into osu-wiki-overlay
2021-05-30 20:27:12 +07:00
Dean Herbert
f3bde258a2
Merge pull request #13232 from ekrctb/initial-lifetime
...
Fix wrong/misleading comment of `InitialLifetimeOffset`
2021-05-30 22:26:47 +09:00
Dean Herbert
f35cf2d846
Merge branch 'master' into main-page-wiki
2021-05-30 21:01:05 +09:00
Salman Ahmed
fb81e5133f
Merge branch 'master' into catch-hide-combo-workaround
2021-05-30 14:16:46 +03:00
Dean Herbert
dac1a98d8a
Merge branch 'master' into fix-skin-sample-lookup
2021-05-30 15:19:47 +09:00
ekrctb
abb77b95b4
Fix comment grammar
2021-05-30 13:06:28 +09:00
Salman Ahmed
53cbf369d7
Fix potential nullref
2021-05-29 21:22:46 +03:00
Salman Ahmed
42618c713f
Merge branch 'master' into legacy-beatmap-skin-hud-fallback
2021-05-29 20:56:05 +03:00
Dean Herbert
4e7d19a3af
Merge branch 'master' into beatmap-skin
2021-05-29 16:51:17 +09:00
Dean Herbert
9b239e308b
Merge branch 'master' into beatmap-skin
2021-05-29 15:36:43 +09:00
ekrctb
265dfe5416
Add test case of DHO setting LifetimeStart in OnApply
2021-05-28 21:51:48 +09:00
ekrctb
43bf734816
Reset lifetime on HitObject.DefaultsApplied
2021-05-28 21:35:26 +09:00
Dean Herbert
8652ac05db
Merge branch 'editor-exit-stability' into non-nullable-beatmapset-files
2021-05-28 18:58:35 +09:00
Dean Herbert
ee5eb9576f
Fix completely wrong conditional logic
2021-05-28 18:38:50 +09:00
ekrctb
1d5e8f4a91
Fix wrong/misleading comment of InitialLifetimeOffset
2021-05-28 17:19:36 +09:00
Dean Herbert
631d217f78
Remove no longer necessary conditional access
2021-05-28 15:42:35 +09:00
Dean Herbert
6268bbea85
Merge branch 'master' into fix-skin-sample-lookup
2021-05-28 14:47:35 +09:00
Dean Herbert
330d61862d
Add a mention of why StartHidden
is required
2021-05-28 14:41:01 +09:00
Dean Herbert
581a86b91a
Revert "Revert "Fix editor tests failing due to empty files being specified""
...
This reverts commit 1af684c4b2
.
2021-05-28 14:33:06 +09:00
Dean Herbert
41733af0ed
Revert "Revert "Make BeatmapSetInfo.Files
non-nullable""
...
This reverts commit 9c4f39e968
.
2021-05-28 14:33:05 +09:00
Dean Herbert
b349ff8693
Revert "Add temporary accounting for tests with null files"
...
This reverts commit e52c0a34f8
.
2021-05-28 14:33:04 +09:00
Dean Herbert
f1b5aced6f
Merge branch 'master' into editor-exit-stability
2021-05-28 14:32:32 +09:00
Dean Herbert
e52c0a34f8
Add temporary accounting for tests with null files
2021-05-28 14:31:26 +09:00
Dean Herbert
9c4f39e968
Revert "Make BeatmapSetInfo.Files
non-nullable"
...
This reverts commit c24712642c
.
2021-05-28 14:15:28 +09:00
Dean Herbert
1af684c4b2
Revert "Fix editor tests failing due to empty files being specified"
...
This reverts commit fdbd421040
.
2021-05-28 14:15:28 +09:00
Dean Herbert
5e8893b203
Update framework
2021-05-28 10:42:13 +09:00
Craftplacer
b3ac67675e
Merge branch 'chat-mention' of github.com:Craftplacer/osu into chat-mention
2021-05-27 21:59:51 +02:00
Craftplacer
13b2b7c148
Fix formatting
2021-05-27 21:58:54 +02:00
Gagah Pangeran Rosfatiputra
854ef0abfd
add simple bound check
2021-05-28 00:55:14 +07:00
Gagah Pangeran Rosfatiputra
ead0e92d7d
use select single node for blurb
2021-05-28 00:50:59 +07:00
Dean Herbert
ce96c58230
Move public members up
2021-05-28 02:46:26 +09:00
Dean Herbert
fe6b1936cb
Move OsuUserInputManager
out from nested class
2021-05-28 02:46:03 +09:00
Dean Herbert
b4c13d837d
Move import logic out to partial class
2021-05-28 02:44:44 +09:00
Dean Herbert
b8edca59eb
General function reorganisation
2021-05-28 02:37:14 +09:00
Dean Herbert
4e49fbf7fb
Switch protected properties to private
where feasible
2021-05-28 02:30:31 +09:00
Dean Herbert
d24a712dd4
Move protected properties to one location and mark setters private
where feasible
2021-05-28 02:27:06 +09:00
Dan Balasescu
7e0a4562c9
Merge branch 'master' into fix-bad-make-current-call
2021-05-28 00:32:51 +09:00
Dan Balasescu
fd7a6db774
Merge pull request #12728 from SleepySwords/single-bind-reset-button
...
Add a reset button to individual keybinds
2021-05-28 00:31:26 +09:00
Dan Balasescu
08c8cd7a66
Merge pull request #12946 from peppy/fix-storyboard-video-widescreen-no-elements
...
Fix storyboard videos not correctly filling the screen
2021-05-28 00:11:04 +09:00
Dan Balasescu
1ffafdd854
Merge branch 'master' into single-bind-reset-button
2021-05-27 23:55:28 +09:00
Dan Balasescu
bc4ccb8a21
Merge pull request #12916 from peppy/fix-taiko-editor-sample-mutations
...
Fix osu!taiko editor operations not always updating the menu/visual state correctly
2021-05-27 23:55:16 +09:00
Dan Balasescu
cb850e07f7
Merge pull request #12963 from peppy/fix-settings-panel-hide-animation
...
Fix settings panel hide animation looking wrong when a sub-panel is visible when hidden
2021-05-27 23:55:00 +09:00
Dan Balasescu
0a3d3bc006
Merge pull request #12958 from peppy/fix-invalid-ssdq-access
...
Fix `BeatmapCarousel` accessing `ScreenSpaceDrawQuad` of non-loaded children
2021-05-27 23:15:06 +09:00
Dan Balasescu
6ddb2062cf
Merge pull request #13214 from peppy/fix-multiplayer-leaderboard-test-failure
...
Fix test failure in `TestSceneMultiplayerGameplayLeaderboard`
2021-05-27 22:44:05 +09:00
Dean Herbert
121dd175e6
Fix test failure in TestSceneMultiplayerGameplayLeaderboard
...
The transfer of users was not accounting for the fact that the
`StartPlay` calls are now scheduled and not necessarily run in time.
2021-05-27 19:57:21 +09:00
Gagah Pangeran Rosfatiputra
e1836cd1b2
add debug assert
2021-05-27 17:12:15 +07:00
Dean Herbert
37ef368738
Move async call out of using
to better define the flow of data
2021-05-27 19:03:59 +09:00
Craftplacer
0b17af81f1
Use Contains instead of IndexOf
...
Co-authored-by: Berkan Diler <b.diler@gmx.de>
2021-05-27 09:48:30 +00:00
Dean Herbert
046087a367
Fix access to AliveChildren
before IsLoaded
2021-05-27 16:58:01 +09:00
Dean Herbert
aa23c4a4b9
Merge branch 'master' into keyboard_shortcuts
2021-05-27 16:30:34 +09:00
Gagah Pangeran Rosfatiputra
c72e258bfb
change for to while in create panels
2021-05-27 14:12:49 +07:00
Gagah Pangeran Rosfatiputra
4fbd43fcae
add inline comment for width 2
2021-05-27 13:24:06 +07:00
Dean Herbert
122bb05aa8
Add a mention that OnApply/OnFree
is performed after ApplyDefaults
2021-05-27 15:20:35 +09:00
Dean Herbert
b13b732e02
Remove incorrect DefaultSkin
usage
2021-05-27 14:50:56 +09:00
Dean Herbert
70a844ac10
Remove allowFallback
parameters completely
2021-05-27 14:50:42 +09:00
Dean Herbert
4fd89faaa4
Fix default skin not having resources or providing samples
2021-05-27 14:09:01 +09:00
Dean Herbert
d66f07fccb
Move text and isFullWidth
parameters to constructor
2021-05-27 14:04:50 +09:00
Salman Ahmed
0c2d3ae0e7
Revert "Move beatmap skin info creation to static method at IBeatmapSkin
"
...
This reverts commit 9806d94b74
.
2021-05-27 05:08:49 +03:00
Gagah Pangeran Rosfatiputra
a7865d3f22
move colour provider to BDL
2021-05-27 08:46:24 +07:00
Craftplacer
a679efac1c
Reduce duplicate notification code by making a base class
2021-05-27 01:00:26 +02:00
Craftplacer
cf39e58ce7
Subscribe to CollectionChanged before binding to JoinedChannels
2021-05-27 01:00:08 +02:00
Craftplacer
d47370bac9
Locally bind to LocalUser
2021-05-27 00:59:29 +02:00
Gagah Pangeran Rosfatiputra
649163e13b
Merge branch 'master' into main-page-wiki
2021-05-26 23:51:49 +07:00
Dean Herbert
f6dee13991
Merge pull request #12948 from gagahpangeran/markdown-wiki
...
Add wiki markdown container
2021-05-27 01:49:32 +09:00
Dean Herbert
735e7b9c74
Pass fetch more action in via ctor to avoid potential nullref
2021-05-26 22:49:39 +09:00
Dean Herbert
9947867e84
Remove unnecessary bindable flow
2021-05-26 22:46:43 +09:00
Dean Herbert
71de541245
Minor spacing / reformatting
2021-05-26 22:35:11 +09:00
Andrei Zavatski
1bde11a07e
Refactor ArticleListing
2021-05-26 15:35:38 +03:00
Gagah Pangeran Rosfatiputra
905364b5fe
add url as argument for link action external
2021-05-26 19:34:34 +07:00
Gagah Pangeran Rosfatiputra
7546611c14
remove unused cached
2021-05-26 19:32:49 +07:00
Gagah Pangeran Rosfatiputra
2344a1a411
use image block in markdown container
2021-05-26 19:22:33 +07:00
Gagah Pangeran Rosfatiputra
62fb09774a
create WikiMarkdownImageBlock
2021-05-26 19:22:21 +07:00
Andrei Zavatski
82d977f80a
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-request
2021-05-26 14:52:42 +03:00
Dean Herbert
7ed4cbf7bf
Fix settings panel hide animation looking wrong when a sub-panel is visible when hidden
2021-05-26 19:25:05 +09:00
Dean Herbert
14a4095140
Merge branch 'master' into beatmap-skin
2021-05-26 18:39:47 +09:00
Dean Herbert
c05dfee220
Simplify default handling flow
2021-05-26 18:28:00 +09:00
Dean Herbert
7c9383b586
Combine RestorableKeyBindingRow
back into KeyBindingRow
2021-05-26 18:17:28 +09:00
Gagah Pangeran Rosfatiputra
db8ccad0b8
Merge branch 'master' into markdown-wiki
2021-05-26 15:25:46 +07:00
Dean Herbert
02806fedb0
Add missing newline
2021-05-26 17:17:02 +09:00
Dean Herbert
17334fd2e6
Inline KeyBindingRow
construction
2021-05-26 17:12:12 +09:00
Gagah Pangeran Rosfatiputra
9c31b8856d
change image url replace implementation
2021-05-26 15:10:09 +07:00
Dean Herbert
49b4a6ea67
Replace local namespace qualifiers with using
2021-05-26 17:07:24 +09:00
Dean Herbert
f8a3a37797
Remove outdated comment
2021-05-26 17:01:47 +09:00
Gagah Pangeran Rosfatiputra
47cbbee4d1
remove CreateNotice method and move implementation to local
2021-05-26 15:01:16 +07:00
Dean Herbert
98fa5b67d6
Merge branch 'master' into single-bind-reset-button
2021-05-26 17:01:16 +09:00
Gagah Pangeran Rosfatiputra
eeb6647bc5
remove schedule in set current path
2021-05-26 14:59:36 +07:00
Dean Herbert
1e77a87fab
Merge pull request #12947 from gagahpangeran/markdown-link
...
Handle link action in `OsuMarkdownLinkText`
2021-05-26 16:56:24 +09:00
Gagah Pangeran Rosfatiputra
02f0e2f212
Merge branch 'markdown-link' into markdown-wiki
2021-05-26 14:55:32 +07:00
Dan Balasescu
34d1d5198f
Merge pull request #12943 from nbvdkamp/fix-zero-area-skin-element-scale-crash
...
Prevent skin editor crash when scaling 0 area drawables
2021-05-26 16:37:58 +09:00
Dean Herbert
88bdd8a7b7
Update some out of date code pieces
2021-05-26 16:01:21 +09:00
Dean Herbert
52ca2f4797
Merge branch 'master' into chat-mention
2021-05-26 16:00:26 +09:00
Gagah Pangeran Rosfatiputra
e02739a136
remove unused colour provider
2021-05-26 13:57:35 +07:00
Gagah Pangeran Rosfatiputra
04f16c0783
Set DocumentUrl
inside CreateChildDependencies
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-26 13:55:16 +07:00
Dean Herbert
b3b39c4c13
Fix BeatmapCarousel
accessing ScreenSpaceDrawQuad
of non-loaded children
...
Fixes failure seen at
https://ci.appveyor.com/project/peppy/osu/builds/39302762/tests .
2021-05-26 15:42:27 +09:00
Dean Herbert
b36b40cb34
Remove unnecessary double specification
2021-05-26 15:20:47 +09:00
Dean Herbert
ba8544f614
Update resources
2021-05-26 14:55:44 +09:00
Dean Herbert
e4780abdfd
Split out base
call from switch
statement
2021-05-26 14:43:59 +09:00
Dean Herbert
d165a75823
Inline request flow to make it easier to understand
2021-05-26 14:37:52 +09:00
Dean Herbert
0f21510b8b
Move code around
2021-05-26 14:29:46 +09:00
Dean Herbert
8ffa7f4a5a
Tidy up code
2021-05-26 14:28:20 +09:00
Dean Herbert
7b09955d59
Remove redundant default bindable value
2021-05-26 14:17:40 +09:00
Dean Herbert
200592114f
Make protected variables private
2021-05-26 14:13:02 +09:00
Swords
07a24d2747
Fixing errors
2021-05-25 23:54:13 +10:00
Swords
9c2dca8229
Removing redundant argument list
2021-05-25 21:53:00 +10:00
Swords
d5feb8353d
Formatting, renaming
2021-05-25 21:37:08 +10:00
Swords
d9f5b578bf
Restore class names
2021-05-25 21:08:40 +10:00
Swords
ce845a9f8d
Apply the rest of requested changes
2021-05-25 21:00:38 +10:00
Dean Herbert
268230c8c4
Merge branch 'master' into fix-taiko-editor-sample-mutations
2021-05-25 19:01:47 +09:00
Dean Herbert
342acadae2
Change LINQ query for better readability
2021-05-25 18:51:51 +09:00
Dean Herbert
871ca8054f
Rename classes as per review feedback
2021-05-25 18:50:33 +09:00
Dean Herbert
7c89dbcd35
Externalise autoplay generation
2021-05-25 18:37:04 +09:00
Dean Herbert
7f9318d976
Expose GameplayBeatmap
to derived Player
classes
2021-05-25 18:36:47 +09:00
Dean Herbert
c2b938a29f
Remove autoplay consideration from Player
2021-05-25 18:09:37 +09:00
Dean Herbert
a3c78674a1
Add new interface for autoplay mods
2021-05-25 18:09:24 +09:00
Gagah Pangeran Rosfatiputra
4c8f19af69
load empty page when fail
2021-05-25 14:47:39 +07:00
Dean Herbert
5ea948aabe
Bypass 640x480 coordinate space for video storyboard elements
...
This allows the `FillMode.Fill` to take up the full space of the
storyboard container.
2021-05-25 16:17:29 +09:00
Dean Herbert
0c55bba220
Allow storyboards to be widescreen if only a video element exists
...
This matches stable behaviour, which will allow videos to display
filling the screen if they are the only thing contained within the
"storyboard".
2021-05-25 16:07:19 +09:00
Dean Herbert
e3507d5453
Move DrawableStoryboard
's aspect application to inside its own class
2021-05-25 16:06:39 +09:00
Dan Balasescu
774611f142
Merge pull request #12933 from peppy/fix-scroll-wheel-gameplay-bindings
...
Disallow using scroll wheel for gameplay bindings
2021-05-25 16:04:18 +09:00
Gagah Pangeran Rosfatiputra
9de07de467
move text flow container inside markdown container
2021-05-25 12:14:07 +07:00
kamp
65649e5a62
Prevent skin editor crash when scaling 0 area drawables
...
Some skinnable drawables can have 0 width or height in certain
cases, leading to division by 0 and a crash when the position is
updated.
2021-05-24 21:36:42 +02:00
Gagah Pangeran Rosfatiputra
728258d93a
add website root url as document url
2021-05-25 00:29:59 +07:00
Dan Balasescu
6263ebf9da
Merge pull request #12495 from peppy/localisation-proof-of-concept
...
Add language selection and general structure for localisation support
2021-05-24 23:33:49 +09:00
Dan Balasescu
3b4fbe22f0
Merge pull request #12928 from Firmatorenio/fix-colour-hitmeter-not-registering-taiko-misses
...
Fix colour hit error meter incorrectly assuming taiko hits were of correct colour
2021-05-24 23:31:54 +09:00
Dan Balasescu
eeda33a453
Merge branch 'master' into localisation-proof-of-concept
2021-05-24 22:56:18 +09:00
Dean Herbert
37f6ceef79
Add test coverage
2021-05-24 21:57:04 +09:00
Dean Herbert
62b6cadb64
Ensure settings rows cannot set an invalid value in the first place
2021-05-24 21:56:41 +09:00
Swords
518999ffab
Renaming files
2021-05-24 22:49:40 +10:00
smoogipoo
fe9abd5b80
Upgrade packages and fix ResX files
2021-05-24 21:37:05 +09:00
Gagah Pangeran Rosfatiputra
02cdd0b2de
use drawable link compiler in markdown link
2021-05-24 19:10:37 +07:00
Swords
441e4e7d56
Formatting
2021-05-24 22:08:34 +10:00
Swords
ca1d1c58ab
RestoreDefaultValueButton implements OsuButton
2021-05-24 21:34:47 +10:00
Firmatorenio
471f17547a
switch determining the hit result by offset to getting it from the judgement directly
2021-05-24 16:49:58 +06:00
Dean Herbert
a00f226ab3
Add assert on storing to database
2021-05-24 18:41:39 +09:00
Dean Herbert
deabce7140
Disallow updating the database to an invalid value
2021-05-24 18:40:56 +09:00
Dean Herbert
57640810b5
Ignore certain banned InputKey
s for gameplay purposes
2021-05-24 18:40:40 +09:00
Salman Ahmed
3585e2900e
Replace unnecessary empty skin implementation with null
2021-05-24 12:28:52 +03:00
Salman Ahmed
7792efb154
Remove no longer used BeatmapSkin
2021-05-24 12:28:06 +03:00
Dan Balasescu
af2a831c83
Merge pull request #12926 from peppy/fix-placement-blueprint-disappearing
...
Fix editor placement ending early if a blueprint becomes alive from a pool
2021-05-24 17:42:18 +09:00
Dan Balasescu
91acf16e52
Merge pull request #12912 from peppy/fix-legacy-combo-counter-positioning
...
Fix legacy combo counter not accounting for song progress bar
2021-05-24 17:26:25 +09:00
Dan Balasescu
7a343c1576
Merge pull request #12915 from peppy/regenerate-replay-less
...
Ensure `RegenerateAutoplay` is only run once per frame
2021-05-24 17:25:42 +09:00
Dan Balasescu
28f91f8d65
Merge pull request #12921 from peppy/fix-hud-offsets-out-of-bounds
...
Limit automatically calculated HUD offsets to keep menu items on screen
2021-05-24 17:25:03 +09:00
Dean Herbert
7961dba1d3
Reorder OrderBy
for legibility
2021-05-24 17:22:55 +09:00
Dean Herbert
f8c6150493
Update framework
2021-05-24 17:11:01 +09:00
Dean Herbert
65c3c0d53f
Merge branch 'master' into localisation-proof-of-concept
2021-05-24 17:10:56 +09:00
Dean Herbert
4fc6ba50b7
Fix editor placement ending early if a blueprint becomes alive from a pool
...
Closes https://github.com/ppy/osu/issues/12630 .
2021-05-24 17:04:02 +09:00
Dean Herbert
68364081f2
Merge pull request #11582 from frenzibyte/mbd-beatmap-set-cover
...
Refactor beatmap set covers into using `ModelBackedDrawable<T>`
2021-05-24 16:30:14 +09:00
Firmatorenio
e5f586f2a6
fix colour hit error meter not pushing misses when wrong colour note is hit in taiko
2021-05-24 13:29:12 +06:00
Dean Herbert
29e1737f0d
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-24 15:51:03 +09:00
Dean Herbert
100e2d14a5
Move call inside conditional
2021-05-24 15:14:55 +09:00
Andrei Zavatski
06fe0563d3
Move GetNewsRequest from ArticleListing to NewsOverlay
2021-05-24 08:26:44 +03:00
smoogipoo
7494ddeef4
Fix DHOs not receiving initial skin changed events
2021-05-24 14:07:40 +09:00
Dean Herbert
a69a1b5211
Fix Player
potentially running MakeCurrent
when already removed from the screen stack
...
Closes #12919 .
2021-05-24 13:53:53 +09:00
Dean Herbert
83981b692e
Also handle items exiting bounds on the opposite side
2021-05-24 13:44:13 +09:00
Dean Herbert
593fea0d5f
Limit automatically calculated HUD offsets to keep menu items on screen
2021-05-24 13:14:18 +09:00
Gagah Pangeran Rosfatiputra
222c34c0a1
fix heading font weight to light
2021-05-23 21:46:41 +07:00
Gagah Pangeran Rosfatiputra
bd1454bdd1
update height to max of its parent height
2021-05-23 21:42:58 +07:00
Gagah Pangeran Rosfatiputra
24960c4fb8
move panel spacing to ctor
2021-05-23 21:31:49 +07:00
Salman Ahmed
d605b6bb8d
Fix HUD overlay components bottom positioning logic accounting for combo
2021-05-23 16:22:51 +03:00
Salman Ahmed
6751d79ce8
Fix oversight in HUD overlay components top positioning logic
2021-05-23 16:22:22 +03:00
Dean Herbert
4c9d72e62a
Ensure EditorBeatmap.Update
is called inside PerformOnSelection
calls
2021-05-23 21:22:35 +09:00
Dean Herbert
bbfd7ea23f
Ensure RegenerateAutoplay
is only run once per frame
2021-05-23 21:20:08 +09:00
Gagah Pangeran Rosfatiputra
10c4ba3a74
add panels to grid content
2021-05-23 19:07:22 +07:00
Gagah Pangeran Rosfatiputra
24fef221e3
change createPanels method to create grid content
2021-05-23 19:07:10 +07:00
Gagah Pangeran Rosfatiputra
8389d90f7e
add GridContainer in wiki main page
2021-05-23 18:52:20 +07:00
Gagah Pangeran Rosfatiputra
4068881096
add bottom margin for paragraph
2021-05-23 18:11:54 +07:00
Gagah Pangeran Rosfatiputra
cd211de729
make panel text bold
2021-05-23 18:10:56 +07:00
Gagah Pangeran Rosfatiputra
512d6d2f7f
centering link inside panel
2021-05-23 18:09:09 +07:00
Gagah Pangeran Rosfatiputra
1e5f34567a
add panel heading main page
2021-05-23 18:07:27 +07:00
Gagah Pangeran Rosfatiputra
365a0b25f2
add IsFullWidth
2021-05-23 18:03:38 +07:00
Gagah Pangeran Rosfatiputra
4d222467cc
initial WikiPanelMarkdownContainer
2021-05-23 18:00:54 +07:00
Gagah Pangeran Rosfatiputra
d9e898a2ee
extract WikiPanelContainer
2021-05-23 17:56:27 +07:00
Gagah Pangeran Rosfatiputra
4a543c2557
add simple panels
2021-05-23 17:49:26 +07:00
Dean Herbert
caa2c5638e
Fix legacy combo counter not accounting for song progress bar
2021-05-23 16:46:57 +09:00
Joseph Madamba
2fd0038154
Fix checkmark being hidden after clicking current waveform opacity setting
2021-05-22 16:42:20 -07:00
Dean Herbert
45c6a9ca91
Merge branch 'refactor-selection-rotate-logic' into fix-flip-logic-discrepancy
2021-05-22 21:17:58 +09:00
Dean Herbert
7d88a19d7f
Remove unnecessary field storage of origin reference
2021-05-22 21:03:40 +09:00
Dean Herbert
34a5b22b79
Merge branch 'master' into refactor-selection-rotate-logic
2021-05-22 20:52:28 +09:00
Dean Herbert
485728ca4e
Merge pull request #12866 from peppy/refactor-selection-scale-logic
...
Add proper scaling support to skin editor
2021-05-22 20:07:03 +09:00
Dean Herbert
b13a68592f
Merge branch 'master' into localisation-proof-of-concept
2021-05-22 17:07:23 +09:00
Dean Herbert
fb5672814d
Add remaining strings for ButtonSystem
2021-05-22 13:56:59 +09:00
Dean Herbert
b6db9ef334
Fill out Japanese localisation via resx
2021-05-22 13:54:52 +09:00
Dean Herbert
2fc53017fc
Generate initial resx files
2021-05-22 13:46:09 +09:00