1
0
mirror of https://github.com/ppy/osu.git synced 2024-10-02 06:27:25 +08:00
Commit Graph

4560 Commits

Author SHA1 Message Date
Dean Herbert
e87f515a4f
Merge pull request #10522 from Morilli/legacyskin-fixes
Add support for ScorePrefix and ScoreOverlap values in legacy skins
2020-10-16 20:54:03 +09:00
Dean Herbert
0437f7e7e9 Delete outdated test scene
Has been replaced by the four new skinnable tests for each component.
2020-10-16 18:22:20 +09:00
Dean Herbert
de60374c88 Remove unused using 2020-10-16 17:26:14 +09:00
Dean Herbert
9837286aea Add test resources 2020-10-16 17:08:46 +09:00
Dean Herbert
c0a1f2158c Add basic component structure for skinnable health displays 2020-10-16 17:08:46 +09:00
Dean Herbert
88ffcb9234 Update EndsWith usages 2020-10-16 12:58:34 +09:00
Dean Herbert
88f74921fb Update with new r# inspections 2020-10-16 12:49:39 +09:00
Dan Balasescu
583fdc3a95
Merge pull request #10510 from peppy/skinnable-accuracy-display
Add legacy skinning support for accuracy display
2020-10-15 21:20:48 +09:00
Dan Balasescu
5d8cf87155
Merge pull request #10511 from peppy/bottom-error-display
Add support for bottom-anchored hit error display
2020-10-15 20:51:09 +09:00
Dan Balasescu
70b050f212
Merge branch 'master' into skinnable-accuracy-display 2020-10-15 20:28:57 +09:00
Dan Balasescu
1ce0e83e59
Merge branch 'master' into skinnable-score-display 2020-10-15 19:16:03 +09:00
Dan Balasescu
93dfbd5d9e
Merge pull request #10505 from peppy/skin-disabler-refactor
Move ISampleDisabler implementation to Player and FrameStabilityContainer
2020-10-15 19:14:52 +09:00
Dean Herbert
70806deba1 Add support for bottom-anchored hit error display 2020-10-15 19:14:02 +09:00
Dan Balasescu
bfffad8fdb
Merge pull request #10504 from peppy/skinnable-combo-counter
Add legacy skinning support for combo counter
2020-10-15 19:11:22 +09:00
Dan Balasescu
5640d33d1a
Merge branch 'master' into skin-disabler-refactor 2020-10-15 18:32:50 +09:00
Dan Balasescu
190f3f36ce
Merge branch 'master' into skinnable-combo-counter 2020-10-15 18:13:00 +09:00
Dean Herbert
b31a3fbabb Add test 2020-10-15 18:11:30 +09:00
Dean Herbert
e1da64398e Add and consume skinnable score counter 2020-10-15 17:14:42 +09:00
Dean Herbert
219cbec6bd Split out DefaultScoreCounter and make ScoreCounter abstract 2020-10-15 16:32:30 +09:00
Dean Herbert
b06f59ffdc Split out test for combo counter specifically 2020-10-15 15:35:33 +09:00
Bartłomiej Dach
c3f1a30447 Merge branch 'master' into mod-customisation-absorb-mouse-input 2020-10-15 00:40:27 +02:00
Bartłomiej Dach
2ca6c4e377 Adjust test step names 2020-10-14 23:24:16 +02:00
Dean Herbert
1684c4f412
Merge pull request #10503 from smoogipoo/fix-mod-combinations
Fix MultiMod difficulty calculator combinations not generating correctly
2020-10-14 23:42:59 +09:00
Dean Herbert
b63303a2a8 Fix tests 2020-10-14 21:40:49 +09:00
smoogipoo
c4fdd35223 Fix same-type incompatibility through multimod 2020-10-14 19:53:37 +09:00
Dean Herbert
e3eaba7b2c Move ISampleDisabler implementation to Player and FrameStabilityContainer 2020-10-14 19:39:48 +09:00
smoogipoo
7d2eeb9795 Fix test names 2020-10-14 19:18:04 +09:00
Dean Herbert
7f5ea57bd4 Clean-up pass (best effort) on LegacyComboCounter 2020-10-14 19:16:34 +09:00
Dean Herbert
9bb8a43bce Combine LegacyComboCounter and ComboCounter classes 2020-10-14 19:16:34 +09:00
Dean Herbert
2fce064e32 Add basic legacy combo counter and updating positioning logic 2020-10-14 19:16:34 +09:00
Dean Herbert
6eb3176776 Add combo incrementing tests to hud overlay test suite 2020-10-14 19:16:34 +09:00
Dean Herbert
375146b489 Make HUDOverlay test scene skinnable 2020-10-14 19:16:34 +09:00
smoogipoo
d7a52e97ff Fix multimod difficulty combinations not generating correctly 2020-10-14 19:03:11 +09:00
smoogipoo
f04aec538f Fix MultiMod throwing exceptions when creating copies 2020-10-14 18:12:19 +09:00
Leon Gebler
28d3295f9f Test Class Fixes 2020-10-13 19:20:15 +02:00
Dean Herbert
5d11db7753 Locallise ChildItems to DrawableCarouselBeatmapSet for clarity 2020-10-13 19:31:29 +09:00
Dean Herbert
4160feb3da Add test specifically for many panels visible 2020-10-13 17:37:33 +09:00
Dean Herbert
1f0aa974dd Fix failing tests 2020-10-13 17:37:33 +09:00
Dean Herbert
dd8943eb7f Update test scene to fix crash 2020-10-13 17:37:33 +09:00
Dean Herbert
9814e9ba7f Split classes out to reduce loc burder on DrawableCarouselBeatmapSet 2020-10-13 17:37:33 +09:00
Dean Herbert
580ea62710 Temporarily increase test beatmap count for perf testing 2020-10-13 17:37:33 +09:00
Dean Herbert
3143224e5b Refactor how drawable carousel items are constructed 2020-10-13 17:37:33 +09:00
Dean Herbert
7e709349b8 Use already available test ruleset 2020-10-13 06:26:14 +09:00
Bartłomiej Dach
25d9b1ecd0 Clarify purpose and construction of extra test 2020-10-12 17:38:22 +02:00
Bartłomiej Dach
82a28d4655 Fix some inaccuracies 2020-10-12 17:34:20 +02:00
Bartłomiej Dach
3224aa7a69 Clarify test math even further 2020-10-12 17:31:46 +02:00
Leon Gebler
7df9282727 CodeAnalysis fixes 2020-10-12 15:58:34 +02:00
Leon Gebler
8768891b12 Add testing for clicking mods through customisation menu 2020-10-12 14:41:05 +02:00
smoogipoo
58194b4a31 Fix incorrect blank lines 2020-10-12 19:36:35 +09:00
smoogipoo
36a8f61d26 Add failing test for implicit segments 2020-10-12 18:58:07 +09:00
smoogipoo
e70d261474 Add failing test 2020-10-12 18:03:41 +09:00
Dean Herbert
16a78b3172
Merge pull request #10478 from bdach/fix-beatmap-difficulty-rating-rounding
Apply rounding when calculating beatmap difficulty rating
2020-10-11 03:36:59 +09:00
Bartłomiej Dach
75b26d0cde Add failing test cases 2020-10-10 18:08:19 +02:00
Bartłomiej Dach
a7c43e17c2 Add test coverage 2020-10-10 15:41:48 +02:00
Bartłomiej Dach
df9c4bf0a5 Improve test xmldoc slightly 2020-10-10 13:01:52 +02:00
Endrik Tombak
d6a3564c01 Merge remote-tracking branch 'origin/score-test' into score-test 2020-10-09 17:39:01 +03:00
Endrik Tombak
a279c38af4 Convert all expectedScore values to int 2020-10-09 17:33:13 +03:00
Endrik Tombak
6e8011a7ee Write xmldoc for TestFourVariousResultsOneMiss 2020-10-09 17:28:59 +03:00
Dan Balasescu
ecfb7e94c5
Merge branch 'master' into fix-editor-batch-handling 2020-10-09 20:06:06 +09:00
Dean Herbert
e618b62ccd Update waveform tests 2020-10-09 19:02:53 +09:00
Dan Balasescu
a6d19cd2d6
Merge pull request #10431 from peppy/fix-distribution-graph-rounding
Fix incorrect timing distribution display due to lack of rounding
2020-10-09 18:12:29 +09:00
Dan Balasescu
4881a13f4b
Merge pull request #10443 from peppy/editor-timeline-tick-display-performance
Improve TimelineTickDisplay performance
2020-10-09 17:53:12 +09:00
Dean Herbert
955836916b Fix timeline tick display test making two instances of the component 2020-10-09 16:45:11 +09:00
Dean Herbert
07558b5bc0 Merge branch 'master' into ruleset-result-types 2020-10-09 13:17:05 +09:00
Dean Herbert
ff5a1937f5 Fix test logic and stabilise rounding direction 2020-10-09 05:04:03 +09:00
Dean Herbert
a5b2c4195e Fix incorrect timing distribution display due to lack of rounding 2020-10-09 04:41:45 +09:00
Dean Herbert
8dddd8aff5
Merge pull request #9883 from swoolcock/confine-during-gameplay
Add "During Gameplay" option for mouse confining
2020-10-08 20:25:27 +09:00
Dean Herbert
7ffab38728 Add test coverage of TransactionalCommitComponent 2020-10-08 18:04:07 +09:00
Bartłomiej Dach
2d070934d9 Add test coverage for empty beatmaps 2020-10-07 21:22:52 +02:00
Endrik Tombak
6113557acc Add back small tick tests 2020-10-07 17:11:48 +03:00
Dean Herbert
1989141968
Merge branch 'master' into tourney-asset-refactor 2020-10-07 21:34:07 +09:00
Lucas A
7f5cf04b2b Fix merge conflicts. 2020-10-07 13:28:49 +02:00
Dean Herbert
6487f58e9a Fix failing tests 2020-10-07 17:52:35 +09:00
Shane Woolcock
f90ac2e76c Ensure we assert after the seek has completed 2020-10-07 18:50:02 +10:30
Shane Woolcock
2e0a9f53c1 Add test coverage 2020-10-07 17:52:39 +10:30
Dan Balasescu
fbb10f6774
Merge branch 'master' into fix-first-hitobject-must-be-combo 2020-10-07 16:21:00 +09:00
Endrik Tombak
5e314c0662 Write new test for small ticks 2020-10-06 22:58:09 +03:00
Endrik Tombak
4c9840ccf1 Apply review suggestions 2020-10-06 22:57:55 +03:00
Endrik Tombak
a31fe5f5ff Temporarily remove SmallTickHit tests 2020-10-06 22:26:18 +03:00
Endrik Tombak
6684a98a32 Also test Classic scoring 2020-10-06 20:24:42 +03:00
Endrik Tombak
879131c675 Also test Goods and Perfects 2020-10-06 20:02:33 +03:00
Endrik Tombak
bdc84c5291 Finish score portion tests for standardised scoring mode 2020-10-06 19:53:24 +03:00
Endrik Tombak
01636d501a Add MinResults test and starts of score portion tests 2020-10-06 18:36:15 +03:00
Dean Herbert
1f2dd13b49 Update tests 2020-10-06 22:10:13 +09:00
Dan Balasescu
50872e3839
Merge pull request #10390 from peppy/editor-setup-sections-container
Split editor setup screen up into sections
2020-10-06 20:07:56 +09:00
Dean Herbert
98fe5f78ee Split setup screen up into sections (and use a SectionContainer) 2020-10-06 17:29:08 +09:00
Dean Herbert
87bf3bdc16 Add the most basic implementation of LabelledSliderBar feasible 2020-10-06 17:26:06 +09:00
Bartłomiej Dach
9eeac759b8 Re-enable and fix gameplay sample playback test 2020-10-05 21:22:32 +02:00
Dan Balasescu
141b8eb766
Merge pull request #10374 from peppy/ignore-failing-test
Temporarily ignore failing gameplay samples test
2020-10-05 20:46:21 +09:00
Dean Herbert
606a08c6ad Temporarily ignore failing gameplay samples test 2020-10-05 20:01:12 +09:00
Dan Balasescu
6d50a1ed7d
Merge branch 'master' into osu-selection-flip-rotate-buttons 2020-10-05 19:17:33 +09:00
Dan Balasescu
2df5ea8ba8
Merge branch 'master' into osu-selection-scaling 2020-10-05 18:47:17 +09:00
Dan Balasescu
12c84df208
Merge pull request #10371 from peppy/fix-gameplay-seek-sample-pausing
Fix seeking in replays not correctly pausing samples
2020-10-05 17:13:43 +09:00
Dan Balasescu
0c93de858e
Merge pull request #10373 from peppy/fix-hitobject-samples-cut-off
Don't stop non-looping samples immediately when pausing
2020-10-05 17:13:11 +09:00
Dean Herbert
d43ea68709
Merge branch 'master' into fix-gameplay-seek-sample-pausing 2020-10-05 16:21:28 +09:00
Dean Herbert
a69b1636be Update tests 2020-10-05 15:18:28 +09:00
Dan Balasescu
39f1ceb2ad
Merge pull request #10366 from peppy/fix-editor-save-new-beatmap
Fix editor persisting new beatmap even when user chooses not to
2020-10-05 14:38:43 +09:00
Dean Herbert
e1c4c8f3d5 Add failing test coverage of gameplay sample pausing (during seek) 2020-10-05 14:27:51 +09:00
Dean Herbert
432ba7cdf9 Add test coverage of exit-without-save 2020-10-04 23:57:35 +09:00
Bartłomiej Dach
ad42ce5639 Add failing test cases 2020-10-04 14:54:51 +02:00
Bartłomiej Dach
a366591d6d
Merge branch 'master' into osu-selection-scaling 2020-10-04 13:28:59 +02:00
Endrik Tombak
d87e4c524c Test HitResultExtensions methods 2020-10-03 14:21:40 +03:00
Dan Balasescu
06b55c6aba
Merge pull request #10326 from peppy/editor-less-autoplay-regeneration
Only regenerate autoplay on editor state change
2020-10-03 20:10:29 +09:00
Dean Herbert
0cb3926e1d Add event on EditorChangeHandler state change 2020-10-02 15:44:34 +09:00
Dean Herbert
d6fe5482d3 Add failing test showing missing control point removal 2020-10-02 15:28:21 +09:00
Dean Herbert
94996f2cc0
Merge branch 'master' into osu-selection-scaling 2020-10-01 21:09:52 +09:00
Dan Balasescu
3a81602d0c
Merge pull request #10286 from peppy/fix-hitobject-sample-stuck-on-future-seek
Fix HitObject samples getting stuck in a playing state on seeking far into the future
2020-10-01 18:08:17 +09:00
Dean Herbert
b7ac779760 Merge branch 'master' into fix-hitobject-sample-stuck-on-future-seek 2020-10-01 16:46:14 +09:00
Dean Herbert
1aff263419 Split out classes and simplify construction of buttons 2020-10-01 16:34:34 +09:00
Dean Herbert
78c5d57074 Add flip event flow and stop passing raw input events to handle methods 2020-10-01 16:25:29 +09:00
smoogipoo
7890319802 Merge branch 'master' into adjust-hit-result-types 2020-10-01 16:19:07 +09:00
smoogipoo
cb6b35116a Merge branch 'master' into scoring-standardisation 2020-10-01 12:28:51 +09:00
Dean Herbert
4b70fe8585 Merge branch 'fix-storyboard-sample-pausing' into fix-hitobject-sample-stuck-on-future-seek 2020-09-30 22:46:09 +09:00
Dean Herbert
367b35bb10 Merge branch 'master' into fix-storyboard-sample-pausing 2020-09-30 22:42:26 +09:00
Dan Balasescu
6dab5c2ceb
Merge branch 'master' into fix-editor-silence-on-seek 2020-09-30 21:33:15 +09:00
Dean Herbert
e760ed8e01 Fix scroll wheel being handled by base test scene 2020-09-30 16:39:02 +09:00
Dean Herbert
1dd354120b Fix beatmap potentially changing in test scene 2020-09-30 16:16:14 +09:00
Dean Herbert
2ef09a8730 Populate test scene with control points 2020-09-30 16:06:58 +09:00
Dean Herbert
414c40d298 Reverse inheritance order of SkinnableSound's pause logic 2020-09-30 15:45:14 +09:00
Dean Herbert
f1298bed79 Combine scale operations and tidy up scale drag handle construction 2020-09-30 15:08:56 +09:00
Dean Herbert
f93c72dd92 Fix non-matching filename 2020-09-29 20:21:13 +09:00
Dean Herbert
265bba1a88 Add test coverage of event handling 2020-09-29 20:08:56 +09:00
Dean Herbert
cd794eaa65 Add basic selection box with drag handles 2020-09-29 20:08:56 +09:00
smoogipoo
f439c1afbc Make osu/taiko/catch use Ok+Great 2020-09-29 17:16:55 +09:00
smoogipoo
4ef7ab2872 Fix tests 2020-09-29 16:33:38 +09:00
smoogipoo
bad48d6d44 Merge branch 'master' into scoring-standardisation 2020-09-29 16:33:38 +09:00
smoogipoo
31fae045fa Update judgement processors with new hit results 2020-09-29 16:33:38 +09:00
Dean Herbert
2f26728cdb Add test coverage of editor sample playback 2020-09-29 15:29:56 +09:00
Dean Herbert
56c8e4dacf Fix failing tests 2020-09-29 14:25:39 +09:00
Dean Herbert
136843c8e4 Make DrawableStoryboardSample a SkinnableSound
Allows sharing pause logic with gameplay samples.
2020-09-29 14:25:39 +09:00
Dean Herbert
d6f3beffb6 Use existing bindable flow instead 2020-09-29 12:50:17 +09:00
Dean Herbert
3cf430f494 Avoid saving state changes if nothing has changed (via binary comparison) 2020-09-28 15:30:51 +09:00
Bartłomiej Dach
8d9945dea8 Change until step to assert for consistency 2020-09-27 11:28:23 +02:00
Bartłomiej Dach
00aea77489 Fix potential instability of overlay activation tests 2020-09-27 11:18:13 +02:00
Lucas A
c5cf0d0410 Fix tests failing. 2020-09-26 21:50:39 +02:00
smoogipoo
9a24346a00 Fix HP drain edgecase potentially causing insta-fails 2020-09-25 23:29:40 +09:00
Dean Herbert
8b255f4579 Fix test failures
The issue was the ArchiveModelManager change; the test local change is
just there because it makes more sense to run for every test in that
scene.
2020-09-25 18:40:22 +09:00
Dan Balasescu
e828cf1607
Merge branch 'master' into editor-load-audio 2020-09-25 14:49:54 +09:00
Dan Balasescu
440adc305d
Merge pull request #10233 from peppy/file-selector
Add a basic file selector with extension filtering support
2020-09-25 14:44:32 +09:00
Dean Herbert
71e1f981fe Merge branch 'file-selector' into editor-load-audio 2020-09-25 12:44:00 +09:00
Dean Herbert
c21745eb07 Fix missing HeadlessTest specification in new test 2020-09-25 12:43:41 +09:00
Dean Herbert
a8c85ed882 Add test for filtered mode 2020-09-25 12:42:37 +09:00
Dean Herbert
1b8b417b85 Merge branch 'master' into file-selector 2020-09-25 12:33:18 +09:00
Dean Herbert
9846d87eb0 Fix misleading step name (and add comment as to its purpose) 2020-09-25 12:25:50 +09:00
Dean Herbert
d602072ee3 Use SingleOrDefault where feasible 2020-09-25 12:24:41 +09:00
Dean Herbert
981585930d Merge branch 'master' into editor-load-audio 2020-09-25 12:24:16 +09:00
Dean Herbert
dc85bcd470
Merge pull request #10229 from smoogipoo/fix-ruleset-disposal
Fix rulesets disposing game-wide texture store
2020-09-24 22:54:45 +09:00
Dean Herbert
dbc522aede Remove weird using 2020-09-24 22:41:52 +09:00
Dean Herbert
94c1cc8ffa Fix test runs under headless 2020-09-24 22:25:04 +09:00
Dean Herbert
011b176244 Add test coverage of audio track changing 2020-09-24 22:00:13 +09:00
Dean Herbert
ea77ea4a08 Add basic testing of new beatmaps persistence 2020-09-24 20:56:35 +09:00
Dean Herbert
937d5870b3 Add a basic file selector with extension filtering support 2020-09-24 20:54:25 +09:00
smoogipoo
d666db3623 Add test 2020-09-24 14:51:42 +09:00
Dean Herbert
eb39f6dbd8 Update failing test to find correct download button 2020-09-24 13:17:03 +09:00
Dean Herbert
fb9d2cb05c
Merge pull request #10218 from peppy/update-framework 2020-09-23 21:45:36 +09:00
Dean Herbert
673a75c46c Fix failing test 2020-09-23 21:06:11 +09:00
Dean Herbert
a1ec167982 Add the ability to toggle new combo state from composer context menu 2020-09-23 16:38:16 +09:00
Salman Ahmed
522e2cdbcd Avoid embedding NUnit Assert inside test steps if possible 2020-09-19 05:56:35 +03:00
Salman Ahmed
1e1422c16a Samples don't get paused... 2020-09-19 05:55:39 +03:00
Salman Ahmed
b3ffd36b65 Use lambda expression instead 2020-09-19 05:55:28 +03:00
Salman Ahmed
6aa84424e4 Merge remote-tracking branch 'upstream/master' into fix-new-samples-starting-while-gameplay-paused 2020-09-19 05:53:04 +03:00
Dean Herbert
3cef93ee27 Centralise import test helper methods 2020-09-18 18:05:33 +09:00
Dan Balasescu
aa2612dd36
Merge branch 'master' into fix-import-tests-waiting 2020-09-18 15:43:33 +09:00
smoogipoo
c7d24203ce Make beatmap conversion support cancellation tokens 2020-09-17 17:40:05 +09:00
Dean Herbert
89a2f20922 Use new CleanRun host class in import tests 2020-09-17 16:12:30 +09:00
Dean Herbert
835c8d74b7 Wait for two update frames before attempting to migrate storage 2020-09-17 16:12:18 +09:00
Dean Herbert
0b289d2e77 Add hostname differentiation to beatmap tests too 2020-09-17 13:07:05 +09:00
Dean Herbert
d2580ebc70 Attempt to fix tests by avoiding clash between import tests names 2020-09-17 13:01:34 +09:00
Dean Herbert
c7e4b192ae
Merge branch 'master' into better-skin-hashing 2020-09-17 12:30:14 +09:00
Dan Balasescu
93269606cd
Merge pull request #10163 from peppy/avoid-test-main-menu-track-change
Pause playback in present tests to avoid track inadvertently changing at menu
2020-09-16 14:56:15 +09:00
Salman Ahmed
105634c099 Add test case ensuring correct behaviour 2020-09-16 01:59:41 +03:00
Dean Herbert
53f9381ad9
Merge branch 'master' into better-skin-hashing 2020-09-16 00:25:33 +09:00
Dean Herbert
dbfaa4a0df Remove beatmap paths from tests where they would result in exceptions 2020-09-15 22:50:44 +09:00
Dean Herbert
e43e12cb2d Pause playback in present tests to avoid track inadvertently changing at menu 2020-09-15 20:17:59 +09:00
Dan Balasescu
8f5115b4e8
Merge branch 'master' into fix-test-storage-weirdness 2020-09-15 19:32:52 +09:00
Dean Herbert
f7c9c80566 Force OsuGameTests to use a unique storage each run 2020-09-15 19:01:32 +09:00
Dan Balasescu
fc15b4546d
Merge pull request #10140 from peppy/editor-clipboard
Editor clipboard support
2020-09-15 17:15:49 +09:00
Dean Herbert
d03bfec807
Merge branch 'master' into fix-test-storage-weirdness 2020-09-15 16:54:06 +09:00
Dean Herbert
7f2ce14f36
Merge pull request #9294 from smoogipoo/morth-taiko-changes 2020-09-15 16:11:17 +09:00
Dan Balasescu
16ae83c499
Merge branch 'master' into editor-clipboard 2020-09-15 16:05:43 +09:00
Dan Balasescu
980511df9b
Merge pull request #10156 from Joehuu/add-collections-to-beatmap-options
Add manage collections button to beatmap options
2020-09-15 15:55:30 +09:00
Dean Herbert
9e73237a90 Fix score present tests potentially succeeding a step when they shouldn't 2020-09-15 15:21:03 +09:00
Dean Herbert
3242b10187 Change order of dependency caching to promote use of locals 2020-09-15 15:00:04 +09:00
Dean Herbert
15e423157b Fix tests that access LocalStorage before BDL 2020-09-15 14:17:40 +09:00
Joehu
c833f5fcc4 Reorder buttons to match stable 2020-09-14 11:23:41 -07:00
Joehu
a09bd787f0 Add failing beatmap options input test 2020-09-14 11:21:39 -07:00
Joehu
c30174cea3 Add manage collections button to beatmap options 2020-09-14 11:21:23 -07:00
Joehu
ce9c63970c Fix button colors in beatmap options test 2020-09-14 11:20:43 -07:00
Joehu
1a8a7ae7f8 Remove hardcoded key param from AddButton 2020-09-14 11:19:18 -07:00
Dean Herbert
be8877b0f4
Merge branch 'master' into better-skin-hashing 2020-09-14 23:32:17 +09:00
Dean Herbert
2b48ae42be Merge branch 'master' into better-skin-hashing 2020-09-14 20:16:33 +09:00
Dean Herbert
70bc0b2bd0 Add back inadvertently removed spacing 2020-09-14 17:52:59 +09:00
Dean Herbert
dafbeda681 Add test coverage for spinners too 2020-09-14 17:48:29 +09:00
Dean Herbert
36a234e5d9 Add slider specific clipboard test 2020-09-14 17:43:27 +09:00
Dean Herbert
6b60888139 Merge branch 'fix-post-convert-json-serialize' into editor-clipboard 2020-09-14 17:38:53 +09:00
Dean Herbert
3e7f70e225 Add failing test covering post-converted json serializing 2020-09-14 17:32:32 +09:00
Dan Balasescu
2c4aa42023
Merge pull request #10149 from Joehuu/fix-mod-select-absorbing-input
Fix mod select overlay absorbing input from toolbar ruleset selector
2020-09-14 17:20:05 +09:00
Dan Balasescu
3118f635f6
Merge branch 'master' into editor-fix-multiple-selection 2020-09-14 16:45:30 +09:00
Dean Herbert
66faae2a6b Add basic clipboards tests 2020-09-14 15:27:16 +09:00
Dean Herbert
0ef4dfc192 Move more logic to base EditorTestScene 2020-09-14 15:27:08 +09:00
Joehu
e328b791df Add failing mod select input test 2020-09-13 11:49:16 -07:00
Dean Herbert
3e37f27a66 Fix regressed tests due to schedule changes 2020-09-13 23:22:19 +09:00
Dean Herbert
0079d94676 Merge branch 'master' into editor-clipboard 2020-09-13 22:30:13 +09:00
Dean Herbert
73dd21c8fc Add failing test 2020-09-11 20:27:07 +09:00
Dean Herbert
948437865b Remove unused code 2020-09-11 16:42:13 +09:00
Dean Herbert
ef77658311 Add coverage of case where skin.ini doesn't specify name/author 2020-09-11 16:29:14 +09:00
Dean Herbert
62e5c9d263 Add test coverage 2020-09-11 16:28:59 +09:00
smoogipoo
4061480419 Rename menu item 2020-09-11 16:02:46 +09:00
Dan Balasescu
54520faa7e
Merge pull request #10082 from EVAST9919/profile-sections-update
Update section headers in ProfileOverlay in line with web
2020-09-11 14:53:17 +09:00
Bartłomiej Dach
97690c818c Add regression test coverage 2020-09-11 00:12:05 +02:00
Bartłomiej Dach
a350802158 Fix wrong mono streak length handling in corner case 2020-09-10 20:50:26 +02:00
Andrei Zavatski
e5d0f3b657 Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-sections-update 2020-09-10 20:23:02 +03:00
smoogipoo
447fd07b4e Fix maps with only bonus score having NaN scores 2020-09-11 01:13:55 +09:00
smoogipoo
d700ae55fb Merge branch 'master' into morth-taiko-changes 2020-09-10 16:34:09 +09:00
Dean Herbert
4faddd0088
Merge branch 'master' into collection-database 2020-09-10 00:07:49 +09:00
Dan Balasescu
75ebfe41e0
Merge pull request #10102 from peppy/editor-prompt-for-save
Prompt to save changes when exiting the editor
2020-09-09 23:56:41 +09:00
smoogipoo
6b56c6e83f Rename to CollectionMenuItem 2020-09-09 23:11:19 +09:00
smoogipoo
43525614ad Store raw BeatmapCollection in filter control 2020-09-09 23:10:21 +09:00
Dean Herbert
af412947b2
Merge branch 'master' into collection-database 2020-09-09 22:59:46 +09:00
Dan Balasescu
53a9804455
Merge branch 'master' into add-editor-tool-icons 2020-09-09 21:21:56 +09:00
Dean Herbert
c6e72dabd3 Add test coverage 2020-09-09 20:04:25 +09:00
Dean Herbert
d3957e6155 Move title specification for settings groups to constructor
Using an abstract property was awkward for this as it is being consumed
in the underlying constructor but could not be dynamically set in time from a
derived class.
2020-09-09 18:50:31 +09:00
Dean Herbert
c9f5005efd Add icons for editor toolbox tools 2020-09-09 18:40:01 +09:00
smoogipoo
b1b99e4d6f Fix tests 2020-09-09 16:04:44 +09:00
smoogipoo
4ddf5f054b Rename BeatmapCollectionManager -> CollectionManager 2020-09-09 15:31:08 +09:00
Dean Herbert
66d3bda962
Merge branch 'master' into collection-database 2020-09-08 23:18:47 +09:00
Dan Balasescu
d09289b1ce
Merge pull request #10063 from frenzibyte/fix-music-controller-regressed
Move OsuGame-dependent music functionalities outside of MusicController
2020-09-08 22:26:35 +09:00
Dean Herbert
379fdadbe5 Add test scene for setup screen 2020-09-08 19:52:56 +09:00
smoogipoo
8e2f5d4ea8 Fix test failures 2020-09-08 19:41:05 +09:00
smoogipoo
4962213cc4 Rename manage collections filter/text 2020-09-08 18:42:55 +09:00
Dean Herbert
e1053c4b6f Revert exposure changes to GlobalActionContainer 2020-09-08 18:36:11 +09:00
Dan Balasescu
68f3a1ea9a
Merge branch 'master' into collection-database 2020-09-08 18:30:01 +09:00
Dean Herbert
072aab90ab Merge branch 'master' into fix-music-controller-regressed 2020-09-08 18:26:15 +09:00
smoogipoo
f581df47c8 Add "New collection..." item to dropdown 2020-09-08 18:25:09 +09:00
smoogipoo
bee450ae1e Fix tests/add placeholder item tests 2020-09-08 17:05:51 +09:00
smoogipoo
c2da3d9c84 Fix button input and tests 2020-09-08 14:36:38 +09:00
smoogipoo
525026e7f0 Fix tests failing due to timings 2020-09-08 13:23:58 +09:00
Dean Herbert
5268eee0fb Avoid requiring sending the calling method for CleanRunHeadlessGameHost 2020-09-08 11:31:42 +09:00
Andrei Zavatski
e39609d3ca Implement PaginatedContainerWithHeader component 2020-09-07 23:08:50 +03:00
Andrei Zavatski
33f14fe7b7 Remove no longer needed test 2020-09-07 22:19:19 +03:00
Andrei Zavatski
3a24cc1aa9 Implement PaginatedContainerHeader component 2020-09-07 22:13:29 +03:00
Dean Herbert
01c0b61b20 Fix incorrect test names 2020-09-08 01:52:31 +09:00
smoogipoo
ca4423af74 Fix tests 2020-09-08 00:07:12 +09:00
smoogipoo
e37c04cb6d Change back to solid icon 2020-09-08 00:04:03 +09:00
smoogipoo
a1214512bc Add filter control tests 2020-09-07 23:57:49 +09:00
smoogipoo
0d5d293279 Add manage collections dialog tests 2020-09-07 22:47:19 +09:00
smoogipoo
ad625ecc7a Add collection IO tests 2020-09-07 22:10:18 +09:00
smoogipoo
98e9c4dc25 General refactorings 2020-09-07 21:08:48 +09:00
smoogipoo
6cc4517600 Merge branch 'master' into collection-database 2020-09-07 20:03:11 +09:00
Dean Herbert
6b50d44dde Merge branch 'master' into editor-new-beatmap 2020-09-07 18:43:16 +09:00
Dean Herbert
4792b44911 Merge branch 'master' into editor-new-beatmap 2020-09-07 18:42:51 +09:00
Dean Herbert
4680728b9c Merge branch 'master' into update-dcc-exclusions 2020-09-07 18:01:44 +09:00
Dan Balasescu
476c325626
Merge branch 'master' into gameplay-disable-overlays 2020-09-07 15:34:02 +09:00
smoogipoo
9ab6d584d3 Merge branch 'master' into editor-new-beatmap 2020-09-07 14:30:41 +09:00
Dan Balasescu
e17ccdfe9f
Merge branch 'master' into combo-colors 2020-09-07 13:55:41 +09:00
Bartłomiej Dach
2b16e25353 Revert unnecessary passing down of tuple in test 2020-09-06 18:44:41 +02:00
Bartłomiej Dach
8b1151284c Simplify overly verbose step names 2020-09-06 18:25:47 +02:00
Bartłomiej Dach
e37a3a84fd Use legible tuple member name 2020-09-06 18:25:47 +02:00
Bartłomiej Dach
f138b92078
Merge branch 'master' into editor-new-beatmap 2020-09-06 18:24:02 +02:00
smoogipoo
345fb9d8e0 Rename classes 2020-09-05 03:55:43 +09:00
smoogipoo
ebd11ae0b7 Add a collection management dialog 2020-09-05 03:52:07 +09:00
smoogipoo
1143d5d992 Update class exclusion for dynamic compilation 2020-09-04 20:41:08 +09:00
Salman Ahmed
0500f24a1d Remove now-redundant test case 2020-09-04 10:24:54 +03:00
Salman Ahmed
314031d56d Add test cases ensuring music actions are handled from a game instance 2020-09-04 10:24:54 +03:00
Salman Ahmed
4d9a06bde9 Expose the global binding container to OsuGameTestScene 2020-09-04 10:24:54 +03:00
smoogipoo
4399f5976c Fix global mods being retained by rooms 2020-09-04 15:20:55 +09:00
Dean Herbert
fba253f131 Take user argument in CreateNew method parameters 2020-09-04 13:17:43 +09:00
Dean Herbert
d3fbc7cc53 Use more direct reference in tests 2020-09-04 13:16:35 +09:00
Dean Herbert
1f2f21e07a Merge branch 'master' into editor-new-beatmap 2020-09-04 13:11:59 +09:00
Lucas A
82e314da59 Fix merge conflicts. 2020-09-03 21:56:47 +02:00
Dan Balasescu
4d9a5f7ba8
Merge branch 'master' into update-icons 2020-09-03 20:19:51 +09:00
Dean Herbert
c9a73926a6 Add basic test coverage 2020-09-03 19:38:01 +09:00
Dean Herbert
7a0c1411b6
Merge branch 'master' into timeshift-leaderboard-topscore 2020-09-03 18:11:04 +09:00
smoogipoo
d387c0cba0 Merge branch 'master' into morth-taiko-changes 2020-09-03 17:35:26 +09:00
Dean Herbert
7bcbac6f45 Move header setting to FullscreenOverlay 2020-09-03 16:34:58 +09:00
Dan Balasescu
84b3604192
Merge branch 'master' into game-overlay-activation-mode 2020-09-03 13:34:22 +09:00
smoogipoo
4459287b35 Add filter control test scene 2020-09-02 20:25:12 +09:00
Dean Herbert
249ae5df1b
Merge branch 'master' into beatmap-track-rework 2020-09-02 15:24:46 +09:00
dependabot-preview[bot]
66c0d12da6
Bump Microsoft.NET.Test.Sdk from 16.7.0 to 16.7.1
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.7.0 to 16.7.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.7.0...v16.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-01 17:19:46 +00:00
Craftplacer
2a7259f7aa Update LegacyBeatmapEncoderTest.cs 2020-09-01 18:15:46 +02:00
Craftplacer
c2ade44656 Change types back 2020-09-01 17:58:06 +02:00
Craftplacer
9835d98942 Merge remote-tracking branch 'upstream/master' into combo-colors 2020-09-01 17:39:35 +02:00
Dan Balasescu
f08e7828da
Merge branch 'master' into beatmap-track-rework 2020-09-01 16:06:38 +09:00
Craftplacer
9b3a48ee5e
Revert "Add marker interface for beatmap skins" 2020-08-31 18:29:46 +02:00
Craftplacer
a893aa8af8 Cut down changes done to LegacyBeatmapEncoderTest 2020-08-31 17:24:24 +02:00
Bartłomiej Dach
0980f97ea2 Replace precision check with absolute equality assert 2020-08-31 16:06:24 +02:00
Bartłomiej Dach
3b22b891d1 Add failing test cases 2020-08-31 14:29:18 +02:00
smoogipoo
ed74c39b55 Move UserTopScoreContainer into base leaderboard 2020-08-31 19:54:22 +09:00
Lucas A
dd093f44d8 Cast base immutable bindable to mutable for testing purposes and make InitialOverlayActivationMode property protected 2020-08-31 11:26:55 +02:00
Dean Herbert
abdb991923 Hide misses from timing distribution graph 2020-08-31 14:15:47 +09:00
Dan Balasescu
261a9c0fda
Merge branch 'master' into fix-replay-download-button-always-being-disabled 2020-08-31 12:40:28 +09:00
Craftplacer
07f6a68179 Update LegacyBeatmapEncoderTest.cs 2020-08-30 21:13:06 +02:00
Craftplacer
db413686bb Add BeatmapSkin to EditorBeatmap 2020-08-30 21:12:45 +02:00
Craftplacer
43d144b7c0 Remove empty argument list 2020-08-30 16:23:00 +02:00
Craftplacer
337037ab3b Make test load actual beatmap's skin configuration 2020-08-30 16:08:52 +02:00
Craftplacer
919d7b7785 Remove redundant call to TestResources 2020-08-30 16:08:13 +02:00
Craftplacer
e428144f73 Use IBeatmapSkin 2020-08-30 11:34:50 +02:00
Craftplacer
00b68b050c Merge remote-tracking branch 'upstream/master' into combo-colors 2020-08-30 10:16:38 +02:00
Dean Herbert
814655770d
Merge branch 'master' into beatmapskin-interface 2020-08-30 12:22:55 +09:00
Bartłomiej Dach
13df0783fe Use Single() instead of First() where applicable 2020-08-29 20:23:22 +02:00
Bartłomiej Dach
e0eece11b1 Fix typo in test name 2020-08-29 20:13:03 +02:00
Lucas A
ad223bc460 Make game bindable immutable. 2020-08-29 19:34:53 +02:00
Joehu
69fae0f412 Add failing replay download button test 2020-08-29 09:30:56 -07:00
Dean Herbert
cd0a73883d
Merge pull request #9945 from smoogipoo/skin-colour-fix-2
Exactly reproduce osu!stable skin colour alphas
2020-08-29 20:06:26 +09:00
Craftplacer
08329aa382 Remove comment again 2020-08-29 11:05:10 +02:00
Craftplacer
1b81415a16 Correct comment 2020-08-29 10:50:25 +02:00
Craftplacer
4cb9e1d443 Initial commit 2020-08-29 10:33:43 +02:00
Craftplacer
da5853e7eb Create a new BeatmapSetInfo when setting files 2020-08-29 10:25:43 +02:00
smoogipoo
436dbafe57 Fix incorrect comparison for mods of different instances 2020-08-28 22:12:17 +09:00
Dan Balasescu
4765f989b6
Merge branch 'master' into unstable-rate 2020-08-28 16:02:13 +09:00
Bartłomiej Dach
ea1f07e311 Simplify/rename SimpleStatisticRow mess 2020-08-27 20:37:10 +02:00
Bartłomiej Dach
37387d7741 Add assertions to existing test to cover bug 2020-08-27 18:18:30 +02:00
Bartłomiej Dach
9d70b4af09 Add failing test case 2020-08-27 18:06:59 +02:00
Bartłomiej Dach
f5e52c80b4 Rename {-> Drawable}SimpleStatisticRow 2020-08-26 19:25:59 +02:00
Dean Herbert
b51db90147 Merge branch 'master' into beatmap-track-rework 2020-08-26 23:20:56 +09:00
Bartłomiej Dach
f09f882cc7 Add component for displaying simple statistics on result screen 2020-08-25 22:51:40 +02:00
Dean Herbert
007d878a19
Merge branch 'master' into fix-slider-path-placement-length-limit 2020-08-25 20:59:23 +09:00
smoogipoo
8dde512657 Merge branch 'master' into skin-colour-fix-2 2020-08-25 19:39:01 +09:00
Dean Herbert
6c7475f085 Fix snapped distances potentially exceeding the source distance
This results in slider placement including "excess" length, where the
curve is not applied to the placed path. This is generally not what we
want.

I considered adding a bool parameter (or enum) to change the
floor/rounding mode, but on further examination I think this is what we
always expect from this function.
2020-08-25 18:58:01 +09:00
Bartłomiej Dach
dbf90551d6 Add coverage for empty metrics case 2020-08-24 20:47:29 +02:00
Bartłomiej Dach
50d5b020b7 Add failing test case 2020-08-24 20:40:45 +02:00
Craftplacer
492be0e016 Fix formatting 2020-08-23 15:23:10 +02:00
Craftplacer
e6646b9877 Resolve review comments 2020-08-23 15:08:02 +02:00
Keijia
6e19521528
Merge branch 'master' into patch2 2020-08-22 18:53:40 +03:00
Keijia
f9fe37a8a5 Added test for "hp" filter keyword 2020-08-22 01:54:01 +03:00
Bartłomiej Dach
809a61afcb Adjust key binding panel tests to not rely on row indices 2020-08-21 23:37:54 +02:00
smoogipoo
356c67f00d Remove outdated/wrong test 2020-08-22 00:55:03 +09:00
Dean Herbert
4239e9f684 Fix storyboard test not actually working due to incorrect track referencing 2020-08-21 18:44:14 +09:00
Dean Herbert
d5cbb589c2 Revert some test scene changes to use Beatmap.Track where relevant 2020-08-21 17:21:08 +09:00
Dean Herbert
70697cf1a0 Restore remaining editor components to use Beatmap.Track 2020-08-21 17:11:29 +09:00
Dean Herbert
0ae460fb8f Avoid beatmap load call in IntroScreen 2020-08-21 15:50:14 +09:00
Dean Herbert
d2c2e8bbe8 Revert some more usage of MusicController back to WorkingBeatmap 2020-08-21 15:17:21 +09:00
Dean Herbert
05b402132e Merge branch 'master' into beatmap-track-rework 2020-08-21 13:25:04 +09:00
Dean Herbert
357fb3a10e Merge branch 'master' into beatmap-track-rework 2020-08-21 12:53:09 +09:00
Bartłomiej Dach
dcce7a2130 Cache local music controller to resolve failure 2020-08-20 21:03:27 +02:00
Bartłomiej Dach
bd4acdce78 Add until step to ensure failure 2020-08-20 21:01:58 +02:00
Dean Herbert
5714c761eb
Merge pull request #9768 from frenzibyte/allow-counter-customize-sprite-text
Allow providing custom sprite text for RollingCounter<T>
2020-08-20 00:14:48 +09:00
Dean Herbert
3e4eae7fe4 Remove unnecessary until step 2020-08-19 19:10:45 +09:00
Dean Herbert
06503597e0 Remove unnecessarily exposed visibility state 2020-08-19 19:09:35 +09:00
Dean Herbert
5737a52fd0 Merge branch 'master' into fix-toolbar-visibility 2020-08-19 19:08:41 +09:00
Dean Herbert
72f16eb186
Merge pull request #9905 from smoogipoo/fix-holdnote-tick-judgement 2020-08-19 19:07:38 +09:00
Salman Ahmed
8f1a71c6b1 Remove counter sprite attributes for not being of any reasonable use 2020-08-19 07:44:45 +03:00
Bartłomiej Dach
6c759f31f1 Add and use limited capacity queue 2020-08-18 20:19:58 +02:00
Lucas A
6aa31dffdb Fix toolbar not respecting current overlay activation mode. 2020-08-18 15:34:56 +02:00
smoogipoo
a4ad0bd174 Ensure 0 score from miss judgements, add test 2020-08-18 19:51:26 +09:00
Dean Herbert
e4303d7943 Fix PlayerLoader test failures due to too many steps 2020-08-18 12:35:23 +09:00
Dean Herbert
93a8bc3d5a Remove local reset method in GameplayClockContainer 2020-08-17 22:36:09 +09:00
Dean Herbert
d9debef156 Add explicit LoadTrack method 2020-08-17 15:38:16 +09:00
Lucas A
589d4eeb52 Remove setting. 2020-08-16 17:18:40 +02:00
Dean Herbert
71f4e753f0 Merge branch 'master' into beatmap-track-rework 2020-08-16 22:35:32 +09:00