15520 Commits

Author	SHA1	Message	Date
Dean Herbert	def1abaeca	Fix some tests not always waiting long enough for beatmap loading ... These used to work because there was a huge blocking load operation, which is now more asynchronous. Note that the change made in `SongSelect` is not required, but defensive (feels it should have been doing this the whole time).	2024-08-29 18:42:43 +09:00
Dean Herbert	1776d38809	Remove loadedTestBeatmaps flag	2024-08-28 23:28:44 +09:00
Dean Herbert	e04b5bb3f2	Tidy up test beatmap loading	2024-08-28 23:28:44 +09:00
Dean Herbert	9123d2cb7f	Fix multiple test failures	2024-08-28 23:28:43 +09:00
Dean Herbert	dd4a1104e4	Always debounce external Filter requests (except for tests) ... The only exception to the rule here was "when screen isn't active apply without debounce" but I'm not sure we want this. It would cause a stutter on returning to song select and I'm not even sure this is a common scenario. I'd rather remove it and see if someone finds an actual case where this is an issue.	2024-08-28 19:13:50 +09:00
Dean Herbert	336abadbd1	Allow running initial filter criteria asynchronously ... This reverts a portion of https://github.com/ppy/osu/pull/9539. The rearrangement in `SongSelect` is required to get the initial filter into `BeatmapCarousel` (and avoid the `FilterChanged` event firing, causing a delayed/scheduled filter application).	2024-08-28 19:13:50 +09:00
Dean Herbert	5ed0c6e91a	Remove song select preloading ... Really unnecessary now.	2024-08-28 19:13:49 +09:00
Dean Herbert	b1f653899c	Fix enumeration over modified collection	2024-08-28 19:13:49 +09:00
Dean Herbert	81b36d897d	Fix null reference in change handling code	2024-08-28 19:13:49 +09:00
Dean Herbert	081c9eb21b	Fix incorrect cancellation / disposal handling of DetachedBeatmapStore	2024-08-28 17:21:19 +09:00
Dean Herbert	4d42274771	Use bindable list implementation	2024-08-28 16:03:37 +09:00
Dean Herbert	466ed5de78	Add basic detached beatmap store	2024-08-28 16:03:37 +09:00
Dean Herbert	eb70a1b72d	Change middle text to only animate initially	2024-08-28 15:57:42 +09:00
Dean Herbert	47a52d10eb	Revert "Add slight parallax to centre content" ... This reverts commit 90d06d4496.	2024-08-28 15:32:59 +09:00
OliBomby	b5b4f915a9	Automatic seek to sample point on right-click	2024-08-27 19:40:33 +02:00
OliBomby	daad476593	Add float comparison leniency just in case	2024-08-27 19:04:16 +02:00
OliBomby	71044a0766	fix difference in sample time calculation	2024-08-27 19:02:40 +02:00
Bartłomiej Dach	a3b0ff4808	Merge branch 'master' into break-overlay-animation	2024-08-27 11:17:56 +02:00
Bartłomiej Dach	321e509f11	Merge pull request #29615 from peppy/break-overlay-improvements ... Add shadow around break overlay middle content to make sure it remains visible	2024-08-27 11:16:08 +02:00
Dean Herbert	90d06d4496	Add slight parallax to centre content	2024-08-27 16:37:27 +09:00
Bartłomiej Dach	8d7053d367	Merge pull request #29560 from peppy/fix-daily-challenge-intro-mod-display ... Fix mod icons potentially showing incorrectly at daily challenge intro	2024-08-27 09:37:11 +02:00
Dean Herbert	6f1664f0a6	Add beat-synced animation to break overlay ... I've been meaning to make the progress bar synchronise with the beat rather than a continuous countdown, just to give the overlay a bit more of a rhythmic feel. Not completely happy with how this feels but I think it's a start? I had to refactor how the break overlay works in the process. It no longer creates transforms for all breaks ahead-of-time, which could be argued as a better way of doing things. It's more dynamically able to handle breaks now (maybe useful for the future, who knows).	2024-08-27 16:34:37 +09:00
Dean Herbert	98faa07590	Apply NRT to BreakOverlay	2024-08-27 15:01:51 +09:00
Dean Herbert	797b020747	Add shadow around break overlay middle content to make sure it remains visible	2024-08-27 15:01:50 +09:00
Dean Herbert	abdbe510b8	Move break overlay (and cursor) further forward in depth ... I didn't really want to move the cursor in front of the HUD, but we face a bit of an impossible scenario otherwise (it should definitely be in front of the break overlay for visibility). So I'll deal with it for now.	2024-08-27 14:52:11 +09:00
Dean Herbert	84bceca778	Assume we can always fetch the ruleset	2024-08-26 15:38:58 +09:00
Dean Herbert	60271fb0f7	Merge pull request #29564 from peppy/skinnable-components-what-2 ... Remove requirement of `base` calls to ensure user skin container layouts are retrieved	2024-08-23 17:52:46 +09:00
OliBomby	2de5ecceb8	Merge remote-tracking branch 'upstream/master' into scroll-speed-std	2024-08-22 20:17:14 +02:00
OliBomby	ad8e7f1897	Fix scroll speed visualisation missing on start kiai effect points ... They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.	2024-08-22 20:17:09 +02:00
OliBomby	998b5fdc12	Add property EditorShowScrollSpeed to Ruleset	2024-08-22 19:53:34 +02:00
OliBomby	adbdb39e9f	move public member to top of file	2024-08-22 19:18:38 +02:00
OliBomby	0db068e423	allow repeating on seek actions	2024-08-22 19:15:53 +02:00
Bartłomiej Dach	bd6943ebc2	Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu ... Allow copying beatmap link in song select carousel context menu	2024-08-22 14:03:39 +02:00
Dean Herbert	58552e9768	Add missing user ruleset to link copying for beatmap panels	2024-08-22 19:18:41 +09:00
Dean Herbert	9a21174582	Move GlobalSkinnableContainers to global scope	2024-08-22 18:46:07 +09:00
Dean Herbert	f37cab0c6e	Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup	2024-08-22 18:39:36 +09:00
Dean Herbert	41756520b1	Rename SkinComponentsContainer to SkinnableContainer	2024-08-22 17:42:50 +09:00
Bartłomiej Dach	df94c22a29	Merge pull request #29545 from peppy/timeline-redesign-in-circles ... Further timeline usability tweaks	2024-08-22 08:39:34 +02:00
Bartłomiej Dach	d33f4837fa	Merge pull request #29532 from bdach/redesign-timing-table-tracking ... Redesign timing table tracking	2024-08-22 08:21:39 +02:00
Dean Herbert	9df12e3d87	Move seek button to left to differentiate mutating operations	2024-08-22 14:15:36 +09:00
Dean Herbert	54e5f1c9f0	Merge pull request #29556 from frenzibyte/kiai-star-bursts ... Add star fountains/bursts when entering kiai mode in gameplay	2024-08-22 14:14:25 +09:00
Dean Herbert	f068b7a521	Move copy-to-url method to OsuGame to centralise toast popup support	2024-08-22 14:03:41 +09:00
Dean Herbert	7f5f3a4589	Fix mod icons potentially showing incorrectly at daily challenge intro ... Prefer using the beatmap's rulesets over the current user selection. Closes https://github.com/ppy/osu/issues/29559.	2024-08-22 13:57:19 +09:00
Salman Ahmed	922814fab3	Fix flag reset on connection dropouts	2024-08-22 06:00:37 +09:00
Dean Herbert	ac5a3a0959	Remove one unused parameter	2024-08-22 02:17:11 +09:00
Dean Herbert	87123d99bf	Move URL implementation to extension methods and share with other usages	2024-08-22 02:08:01 +09:00
Dean Herbert	18a3ab2ffd	Use "link" instead of "URL"	2024-08-22 01:45:43 +09:00
Dean Herbert	a943000579	Merge pull request #29435 from OliBomby/improve-snaps ... Fix timeline snapping ignoring nearby timing points	2024-08-22 01:36:30 +09:00
Dean Herbert	fb5fb78fd3	Move zero marker below control points to avoid common overlap scenario	2024-08-22 01:09:22 +09:00
Dean Herbert	843b10ef34	Add back incorrectly removed control point display toggle	2024-08-22 01:05:47 +09:00
Dean Herbert	2876cb73bd	Merge pull request #28991 from Layendan/master ... Add collection and favourite buttons to results screen	2024-08-21 23:59:26 +09:00
OliBomby	423feadd64	Revert "add arrow indicator" ... This reverts commit 1ce9e97fd4.	2024-08-21 14:12:58 +02:00
Bartłomiej Dach	28d0a24555	Fix the fix ... The more proper way to do this would be to address the underlying issue, which is https://github.com/ppy/osu/issues/29546, but let's do this locally for now.	2024-08-21 12:27:56 +02:00
Salman Ahmed	c92af71029	Add in-gameplay version of kiai star fountains/burst	2024-08-21 17:34:38 +09:00
jkh675	3d5b57454e	Fix null reference	2024-08-21 16:21:49 +08:00
Dean Herbert	fef56cc29e	Remove expanding behaviour of timeline completely	2024-08-21 16:57:52 +09:00
Dean Herbert	7e6490133d	Adjust visuals of tick display (and fine tune some other timeline elements)	2024-08-21 16:46:14 +09:00
Dean Herbert	1a48a6f654	Reduce size of hit objects on timeline	2024-08-21 16:46:13 +09:00
Dean Herbert	3065f808a7	Simplify timing point display on timeline	2024-08-21 16:46:13 +09:00
Dean Herbert	a0002943a1	Adjust centre marker visuals a bit	2024-08-21 16:46:12 +09:00
Bartłomiej Dach	c4f08b42ab	Use colours to distinguish buttons better	2024-08-21 09:05:33 +02:00
OliBomby	1ce9e97fd4	add arrow indicator	2024-08-20 23:38:38 +02:00
OliBomby	ae6d855f8d	Merge remote-tracking branch 'upstream/master' into doubleclick	2024-08-20 23:19:27 +02:00
Salman Ahmed	637c9aeef0	Add DailyChallengeIntroPlayed session static	2024-08-21 03:37:04 +09:00
Salman Ahmed	0d358a1dae	Fix resume overlay appearing behind HUD/skip overlays	2024-08-21 02:53:11 +09:00
jkh675	8e273709f1	Implement copy url in beatmap and beatmap set carousel	2024-08-20 22:48:11 +08:00
Dan Balasescu	5bb94000d3	Merge pull request #29534 from bdach/fix-divisor-crash ... Fix crash on attempting to edit particular beatmaps	2024-08-20 22:06:32 +09:00
Dan Balasescu	44213a34ae	Merge pull request #29508 from peppy/hold-for-menu-sometimes ... Change "hold for menu" button to only show for touch by default	2024-08-20 21:45:50 +09:00
Bartłomiej Dach	bb964e32fa	Fix crash on attempting to edit particular beatmaps ... Closes https://github.com/ppy/osu/issues/29492. I'm not immediately sure why this happened, but some old locally modified beatmaps in my local realm database have a `BeatDivisor` of 0 stored, which is then passed to `BindableBeatDivisor.SetArbitraryDivisor()`, which then blows up. To stop this from happening, just refuse to use values outside of a sane range.	2024-08-20 13:51:58 +02:00
Bartłomiej Dach	c9f1ef5361	Fix incorrect bank set / sample addition logic ... Closes https://github.com/ppy/osu/issues/29361. Typical case of a few early-returns gone wrong leading to `NodeSamples` not being checked correctly.	2024-08-20 12:37:01 +02:00
Dean Herbert	a633fcdb49	Merge branch 'master' into redesign-timing-table-tracking	2024-08-20 19:16:03 +09:00
Bartłomiej Dach	f0ddb6daa4	Merge pull request #29445 from OliBomby/transparent-break ... Make break periods in bottom timeline transparent	2024-08-20 11:46:02 +02:00
Bartłomiej Dach	a33294ac42	Redesign timing table tracking ... - On entering the screen, the timing point active at the current instant of the map is selected. This is the *only* time where the selected point is changed automatically for the user. - The ongoing automatic tracking of the relevant point after the initial selection is *gone*. Even knowing the fact that it was supposed to track the supposedly relevant "last selected type" of control point, I always found the tracking to be fairly arbitrary in how it works. Removing this behaviour also incidentally fixes https://github.com/ppy/osu/issues/23147. In its stead, to indicate which timing groups are having an effect, they receive an indicator line on the left (coloured using the relevant control points' representing colours), as well as a slight highlight effect. - If there is no control point selected, the table will autoscroll to the latest timing group, unless the user manually scrolled the table before. - If the selected control point changes, the table will autoscroll to the newly selected point, *regardless* of whether the user manually scrolled the table before. - A new button is added which permits the user to select the latest timing group. As per the point above, this will autoscroll the user to that group at the same time.	2024-08-20 11:14:42 +02:00
Dean Herbert	bccc797bcb	Move break display to background of summary timeline	2024-08-20 17:45:44 +09:00
Bartłomiej Dach	373ff47a94	Remove dead row attribute classes ... These aren't shown on the control point table since difficulty and sample control points were moved into objects.	2024-08-20 09:53:40 +02:00
Layendan	59ba48bc81	Fix crash if favourite button api request fails	2024-08-19 07:58:20 -07:00
Bartłomiej Dach	7693d4c039	Merge branch 'master' into master	2024-08-19 14:30:20 +02:00
Dean Herbert	6985e2e657	Increase default visibility on touch platforms	2024-08-19 20:32:05 +09:00
Dean Herbert	005b1038a3	Change "hold for menu" button to only show for touch by default	2024-08-19 20:23:25 +09:00
Bartłomiej Dach	24a0a3c47f	Merge pull request #29476 from EVAST9919/buffered-editor-grid ... Improve draw performance of editor grids	2024-08-19 12:44:08 +02:00
Bartłomiej Dach	42675be6cf	Merge branch 'master' into additions	2024-08-19 11:13:43 +02:00
Bartłomiej Dach	32821be046	Make "double ternary button" specific to samples ... We can generalise *when* there is the need to generalise. So far the generalisation only looked like *obfuscation*.	2024-08-19 11:13:29 +02:00
Bartłomiej Dach	55e9bb6a5d	Privatise setter	2024-08-19 10:59:47 +02:00
Dean Herbert	f176383dd0	Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm	2024-08-19 14:30:09 +09:00
Joseph Madamba	6dd08e9a96	Fix beatmap carousel panels not blocking hover of other panels in song select	2024-08-17 11:45:54 -07:00
Andrei Zavatski	3cd5820b5b	Make PositionSnapGrid a BufferedContainer	2024-08-17 10:34:39 +03:00
Andrei Zavatski	f74263db81	Remove extra box in OnlinePlayBackgroundScreen	2024-08-17 01:01:51 +03:00
OliBomby	621c4d65a3	Hide scroll speed in effect row attribute	2024-08-16 14:43:33 +02:00
OliBomby	b253d8ecbf	Hide scroll speed in bottom timeline	2024-08-16 14:43:09 +02:00
OliBomby	5624c1d304	Make break periods in bottom timeline transparent	2024-08-16 13:22:09 +02:00
OliBomby	3a84409546	Use TimingPointAfter for seeking check	2024-08-16 01:36:51 +02:00
Joseph Madamba	c3600467bf	Make collection button test less broken	2024-08-15 11:49:15 -07:00
Dan Balasescu	52c1858bbe	Merge pull request #29428 from peppy/update-editor-menu-items-difficulty-change ... Ensure the "Change Difficulty" menu uses up-to-date difficulty names	2024-08-16 00:44:59 +09:00
Dean Herbert	5710f0f302	Merge pull request #26254 from frenzibyte/mania-combo-counter ... Add argon/classic osu!mania combo counter	2024-08-15 17:56:28 +09:00
Dean Herbert	b5f615882f	Ensure the "Change Difficulty" menu uses up-to-date difficulty names ... Closes https://github.com/ppy/osu/issues/29391.	2024-08-15 17:25:30 +09:00
Dean Herbert	9dc496d6a7	Merge pull request #29415 from Joehuu/difficulty-name-content ... Implement song select v2 difficulty name content component	2024-08-15 15:20:52 +09:00
Salman Ahmed	3a4546d62d	Remove x symbol from argon mania combo counter	2024-08-15 15:08:35 +09:00
Dean Herbert	28ab65243d	Remove daily challenge tooltip from main menu ... Now that we have a nice intro screen for the daily challenge, it's generally thought that we want to "spoil" the beatmap until the intro is shown. Also I was never a huge fan of having a tooltip on a main menu button.. just feels a bit odd.	2024-08-14 20:45:27 +09:00
Joseph Madamba	11bd0c9a61	Inline single-frame layout issue comment instead	2024-08-14 00:41:43 -07:00
Joseph Madamba	c24f1444f9	Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent	2024-08-13 23:26:18 -07:00
Joseph Madamba	2b41f71fd0	Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers	2024-08-13 23:26:17 -07:00
Joseph Madamba	625c6fc7eb	Implement song select v2 difficulty name content component	2024-08-13 23:26:17 -07:00
Dean Herbert	e465049050	Merge branch 'master' into mania-combo-counter	2024-08-14 15:12:00 +09:00
OliBomby	10f2ac6490	fix anti-aliased white leaking out of the button	2024-08-13 22:13:17 +02:00
OliBomby	2abcdd0064	Redesign sample bank toggles	2024-08-13 22:05:01 +02:00
Dean Herbert	16f6e26c2e	Merge pull request #29372 from ArijanJ/song-progress-optional-time ... Add option to hide song progress time/text	2024-08-13 00:57:15 +09:00
Bartłomiej Dach	06c2952fe8	Merge branch 'master' into grids-3	2024-08-12 13:55:35 +02:00
Dean Herbert	b567ab2a39	Fix context menus sometimes not being clickable at song select ... Closes https://github.com/ppy/osu/issues/21602.	2024-08-12 20:31:20 +09:00
Bartłomiej Dach	92bd123ebc	Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam ... Fix daily challenge notification spam	2024-08-12 12:18:38 +02:00
Bartłomiej Dach	96bd374b18	Change notification interval to 30 minutes	2024-08-12 11:24:59 +02:00
Bartłomiej Dach	54a1d79136	Clean up some naming weirdness	2024-08-12 11:23:36 +02:00
Bartłomiej Dach	041c70e4eb	Fix tests	2024-08-12 11:19:02 +02:00
Bartłomiej Dach	306e84c7ac	Move disposal method to more expected location	2024-08-12 10:46:58 +02:00
ArijanJ	fed5b9d747	Fix one more inspectcode warning	2024-08-10 09:45:30 +02:00
ArijanJ	d01e76d9db	Fix double blank line	2024-08-09 23:08:22 +02:00
ArijanJ	2dee8bef7e	Add option to hide song progress time/text	2024-08-09 22:50:37 +02:00
Dean Herbert	df43263e38	Merge branch 'master' into daily-challenge-intro-sfx	2024-08-10 02:22:48 +09:00
Jamie Taylor	c6fa348d82	Add sound design for daily challenge intro animation	2024-08-09 23:05:33 +09:00
Dean Herbert	8fdd94090b	Show object inspector values during placement	2024-08-09 18:02:37 +09:00
Dean Herbert	e146c8e230	Ensure only one daily challenge notification is fired per room	2024-08-09 17:11:11 +09:00
Dean Herbert	52b2d73e04	Only show daily challenge notification if it started within the last 30 minutes	2024-08-09 17:10:18 +09:00
Dean Herbert	161734af95	Simplify argon mania combo counter implementation by sharing with base counter	2024-08-09 15:46:57 +09:00
Dean Herbert	e645651ef4	Merge branch 'master' into mania-combo-counter	2024-08-09 00:19:17 +09:00
Dean Herbert	0cb3b6a1f8	Add back TrySetDailyChallengeBeatmap call for safety	2024-08-08 22:10:26 +09:00
Dean Herbert	8eb0ef1e33	Merge branch 'master' into daily-challenge-intro-audio-auto-download	2024-08-08 22:09:21 +09:00
Dean Herbert	03d543ec99	Fix potential test failure in daily challenge tests ... See https://github.com/ppy/osu/actions/runs/10296877688/job/28500580680.	2024-08-08 16:53:22 +09:00
Dean Herbert	3f3145e109	Start playing music during intro if download finishes early	2024-08-08 15:10:18 +09:00
Dean Herbert	5d66eda982	Add support for automatically downloading daily challenge during the intro display	2024-08-08 15:10:18 +09:00
Dean Herbert	e95d61d4c2	Remove accidental double handling of beatmap availability in DailyChallenge	2024-08-08 15:10:18 +09:00
Dean Herbert	f91a3e9a35	Start playing daily challenge track as part of intro sequence	2024-08-08 15:10:17 +09:00
Dean Herbert	5891780427	Show initial text a bit longer	2024-08-08 14:15:40 +09:00
Dean Herbert	7058fedf42	Merge branch 'master' into daily-challenge-intro-screen-part-2	2024-08-08 14:12:16 +09:00
Dean Herbert	1ee5522a25	Merge branch 'master' into daily-challenge-intro-screen-part-2	2024-08-08 14:08:14 +09:00
Dean Herbert	25dddb694a	And then completely change the animation to a new style	2024-08-08 14:02:43 +09:00
Dean Herbert	f72f5ee7e3	More improvements maybe	2024-08-08 13:29:10 +09:00
Dean Herbert	9bafdeeeff	Improve animation	2024-08-08 13:17:25 +09:00
Dean Herbert	b5a19707d0	Merge branch 'master' into additions	2024-08-08 03:31:11 +09:00
Dean Herbert	8773c2f7eb	Merge pull request #29281 from kstefanowicz/multiplayer-chat-focus-hint ... Add "enter" hint to in-gameplay chatbox placeholder text	2024-08-08 01:29:42 +09:00
Dan Balasescu	a06cb9a0de	Merge pull request #29322 from peppy/daily-challenge-import-improvement ... Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu	2024-08-08 00:42:03 +09:00
Dean Herbert	cfd7f96e76	Add missing exit line causing completely incorrect behaviour	2024-08-07 23:29:24 +09:00
kstefanowicz	775f76f472	Have placeholder text change while focused	2024-08-07 07:47:35 -04:00
Bartłomiej Dach	437812eebe	Merge pull request #29279 from normalid-awa/bugfix/editor/delete-operation-wont-close-the-menu ... Close context menus when deselecting items in editor	2024-08-07 13:25:13 +02:00
Dean Herbert	e52d80a41b	Add more difficulty information and further tweaks to visuals	2024-08-07 19:08:04 +09:00
Dean Herbert	083fe32d20	Improve feel of animation	2024-08-07 19:07:45 +09:00
Salman Ahmed	a0615a8f18	Frenzi's WIP animation	2024-08-07 19:07:45 +09:00
Dean Herbert	cfccd74441	Add daily challenge intro sequence	2024-08-07 19:07:44 +09:00
Dean Herbert	6870311c1e	Remove requirement of specifying animateOnnter in BackgroundScreen ctor	2024-08-07 19:07:44 +09:00
Dean Herbert	3c05b975a0	Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu	2024-08-07 19:07:43 +09:00
Dean Herbert	5a63c25f49	Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu	2024-08-07 14:42:34 +09:00
Dean Herbert	8619bbb943	Fix legacy key counter's background being visible when intended to be hidden	2024-08-06 16:12:00 +09:00
Dan Balasescu	c574551ee0	Simplify caching	2024-08-06 16:02:36 +09:00
Dan Balasescu	b91461e661	Refactor + CI fixes	2024-08-06 15:17:52 +09:00
jkh675	cb877b7675	Close the menu when selecting other object	2024-08-06 13:09:48 +08:00
Dan Balasescu	d637bbf752	Merge pull request #29286 from peppy/middle-click-delete ... Allow object deletion with middle mouse	2024-08-06 13:38:56 +09:00
jkh675	75c0c6a5f9	Make the OsuContextMenu nullable in SelectionHandler	2024-08-05 16:32:49 +08:00
Dean Herbert	c37f617e1d	Adjust song select info icon size slightly ... Not going to PR this it's just a minor tweak.	2024-08-05 17:21:50 +09:00
Dean Herbert	0557b9ab79	Allow placement deletion with middle mouse ... This is in addition to Shift + Right-click. I thik middle mouse feels more natural and is a good permanent solution to this issue. Note that this also *allows triggering the context menu from placement mode*. Until now it's done nothing. This may be annoying to users with muscle memory but I want to make the change and harvest feedback. I think showing the context menu is more correct behaviour (although arguably it should return to placement mode on dismiss?).	2024-08-05 14:25:09 +09:00
Dan Balasescu	136cdcfb29	Merge pull request #29059 from frenzibyte/fix-results-fetching-twice ... Fix results screen fetching scores twice when scrolled to edge	2024-08-05 14:23:47 +09:00
Dan Balasescu	f92e2094c1	Adjust localisation string name + formatting	2024-08-05 12:34:24 +09:00
AkiraTenchi	a5a392e9fc	Update FilterQueryParser.cs ... Add sr as an alias for star rating in the search parameters	2024-08-04 19:48:29 +02:00
kstefanowicz	b0757a13c2	Add "enter" hint to chatbox placeholder text while in-game	2024-08-04 12:32:08 -04:00
jkh675	b32d97b4c0	Remove decreapted property	2024-08-04 21:27:25 +08:00
jkh675	2145368d17	Merge EditorContextMenuContainer into OsuContextMenuContainer	2024-08-04 21:00:43 +08:00
jkh675	7c83d6a883	Cleanup code	2024-08-04 19:56:41 +08:00
jkh675	5d31171fb0	Fix code quality	2024-08-04 19:43:43 +08:00
jkh675	3cc5466774	Refactor the code to follow IoC principle and more flexible	2024-08-04 19:39:06 +08:00
jkh675	27d6c4cecb	Implement on beatmap editor	2024-08-04 19:16:14 +08:00
jkh675	5c5fcd7e7e	Allow key event pass through selection handler	2024-08-04 19:11:21 +08:00
jkh675	1ff0c7cb46	Replace original menu container with custom one	2024-08-04 19:10:49 +08:00
jkh675	83aeb27c73	Replace original menu container to the custom one	2024-08-04 19:08:31 +08:00
jkh675	de6d8e7eb7	Add the custom context menu to handle the key event	2024-08-04 19:07:35 +08:00
Dan Balasescu	7bf96ce49a	Merge pull request #29231 from peppy/timeline-break-behind-objects ... Show breaks behind objects in timeline	2024-08-02 21:28:11 +09:00
Dean Herbert	548fd9cbf9	Show breaks behind objects in timeline ... Closes https://github.com/ppy/osu/issues/29227.	2024-08-01 19:47:44 +09:00
Layendan	19a4cef113	update var names and test logic	2024-08-01 02:52:41 -07:00
Dean Herbert	dab967e6be	Fix insane transform allocations in new leaderboard display	2024-08-01 18:36:33 +09:00
Dean Herbert	2d52bab77b	Always show timing points in timeline when at the timing screen ... Supersedes https://github.com/ppy/osu/pull/29196.	2024-07-31 19:43:08 +09:00
Dean Herbert	e329427d6e	Apply nullability to Timeline	2024-07-31 19:28:32 +09:00
Layendan	36bd83bb80	Update collection state when users add/remove from collection	2024-07-30 15:22:41 -07:00
Dean Herbert	e77489f2a9	Allow notification of new strings	2024-07-31 03:10:36 +09:00
Dean Herbert	bdc465e1c6	Reword notification text slightly	2024-07-31 03:06:35 +09:00
Dean Herbert	d75c170ba1	Merge branch 'master' into daily-challenge/better-messaging	2024-07-30 19:04:48 +09:00
Dean Herbert	d5f9173288	Remove unused local variable	2024-07-30 19:04:43 +09:00
Bartłomiej Dach	1b57a2a136	Show new daily challenge notification globally	2024-07-30 10:36:26 +02:00
Salman Ahmed	621f4dfece	Enforce new line between X/Y coordinate in editor position inspector	2024-07-30 02:45:21 +03:00
Dean Herbert	aa2515763c	Merge pull request #29184 from bdach/daily-challenge/wrong-mods-after-replay ... Fix mods persisting after watching replay from daily challenge screen	2024-07-29 23:23:45 +09:00
Bartłomiej Dach	b46f3c97da	Add notification on daily challenge conclusion & start of new one ... Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day on #general. The notifications are constrained to the daily challenge screen only to not spam users who may not care.	2024-07-29 14:30:10 +02:00
Dean Herbert	7afcd72872	Fix potentially too many scores displaying in breakdown while in gameplay	2024-07-29 20:58:42 +09:00
Dean Herbert	05056f0e8a	Remove no longer required AlwaysPresent definition ... This also reverts commit 7fedfd368c as no-longer-necessary.	2024-07-29 20:43:56 +09:00
Dean Herbert	5a1002c1a0	Ensure score breakdown doesn't spam scores when not visible	2024-07-29 20:43:50 +09:00
Bartłomiej Dach	f1a84a5111	Fix mods persisting after watching replay from daily challenge screen ... Closes https://github.com/ppy/osu/issues/29133. Hope I can be forgiven for no tests. I had a brief try but writing them is going to take hours.	2024-07-29 12:52:30 +02:00
Bartłomiej Dach	cebd38c6eb	Merge pull request #29163 from Joehuu/copy-lb-mods-daily ... Add ability to copy leaderboard mods in daily challenge	2024-07-29 12:09:27 +02:00
Bartłomiej Dach	2ff0a89b4f	Convert into auto-property even more	2024-07-29 10:59:21 +02:00
Bartłomiej Dach	54c904d439	Convert into auto-property	2024-07-29 10:40:29 +02:00
Bartłomiej Dach	aa7f6f81ef	Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily ... Fix daily challenge background clipping when settings/notifications is opened	2024-07-29 10:28:48 +02:00
Joseph Madamba	f6eb9037df	Add ability to copy leaderboard mods in daily challenge	2024-07-27 23:55:56 -07:00
Salman Ahmed	7fedfd368c	Fix score breakdown tooltips appearing in other feeds	2024-07-28 07:22:58 +03:00
Joseph Madamba	bc25e5d706	Remove unnecessary depth and padding set	2024-07-27 19:13:11 -07:00
Joseph Madamba	850bcaef7a	Merge remote-tracking branch 'upstream/master' into pr/28991	2024-07-27 19:09:02 -07:00
Joseph Madamba	334f5fda2d	Remove direct margin set in popover that was causing positioning offset	2024-07-27 19:02:57 -07:00
Joseph Madamba	04b15d0d38	Remove unnecessary ReceivePositionalInputAt ... Results is not even using the new footer.	2024-07-27 19:02:43 -07:00
Joseph Madamba	b4ca07300a	Use same size button for everything	2024-07-27 18:43:54 -07:00
Joseph Madamba	b5ff2dab43	Move some properties/bindables around	2024-07-27 18:42:49 -07:00
Joseph Madamba	aed2b3c7c6	Inherit GrayButton instead ... Also fixes hover highlight.	2024-07-27 18:42:49 -07:00
Joseph Madamba	d55e861b90	Fix daily challenge background clipping when settings/notifications is opened	2024-07-26 16:55:15 -07:00
Dean Herbert	9323f89357	Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge	2024-07-27 02:06:56 +09:00
Dean Herbert	0421e1e9d0	Reduce number spacing a bit more	2024-07-26 23:21:44 +09:00
Dean Herbert	96049807c4	Adjust weight and text in event feed output ... Just some minor adjustments.	2024-07-26 23:20:32 +09:00
Dean Herbert	4fa6a19409	Merge pull request #29108 from bdach/daily-challenge/better-breakdown ... Improve score breakdown on daily challenge	2024-07-26 23:12:04 +09:00
Dean Herbert	47eca0eb37	Merge pull request #29101 from bdach/daily-challenge/fix-preview-track ... Fix preview tracks not stopping playback when suspending/exiting daily challenge screen	2024-07-26 21:52:26 +09:00
Dean Herbert	6f7d05d5a0	Merge pull request #29104 from bdach/daily-challenge/fix-no-audio-adjustments ... Fix daily challenge screen not applying track adjustments from mods	2024-07-26 21:51:58 +09:00
Bartłomiej Dach	0996f9b0b5	Fix code quality	2024-07-26 14:45:39 +02:00
Dean Herbert	1607075e0c	Merge pull request #29099 from bdach/daily-challenge/totals-display ... Implement component for displaying running totals in daily challenge	2024-07-26 21:44:58 +09:00
Dean Herbert	a870722ea6	Adjust easings and reduce character spacing slightly	2024-07-26 21:43:23 +09:00
Bartłomiej Dach	fc0ade2c61	Highlight where local user's best is on the breakdown	2024-07-26 14:32:01 +02:00
Bartłomiej Dach	2caaebb670	Add tooltip with counts to daily challenge score breakdown chart	2024-07-26 13:47:41 +02:00
Dean Herbert	19affa7062	Rename new property to match true usage (per item) ... Also document a bit more.	2024-07-26 20:45:13 +09:00
Bartłomiej Dach	2e37f3b5de	Hook up score totals display to daily challenge screen	2024-07-26 12:34:23 +02:00
Bartłomiej Dach	1abcf16231	Fix daily challenge screen not applying track adjustments from mods ... Closes https://github.com/ppy/osu/issues/29093.	2024-07-26 11:50:43 +02:00
Bartłomiej Dach	f9cfc7d96c	Fix preview tracks not stopping playback when suspending/exiting daily challenge screen ... Closes https://github.com/ppy/osu/issues/29083.	2024-07-26 10:53:12 +02:00
Cameron Brown	17f00ec0a6	Bind the mod select overlay's Beatmap to OsuScreen.Beatmap in constructor ... Suggested by @bdach!	2024-07-26 18:29:50 +10:00
Cameron Brown	a8851950bc	Update the beatmap of Daily Challenge's mods overlay when beatmap is set - #29094	2024-07-26 18:10:11 +10:00
Bartłomiej Dach	174dc91f4b	Implement component for displaying running totals in daily challenge ... Total pass count and cumulative total score, to be more precise.	2024-07-26 09:51:39 +02:00
Bartłomiej Dach	e489ae8f72	Merge pull request #29055 from peppy/event-feed-improvements ... Improve daily challenge event feed	2024-07-26 08:37:47 +02:00
Bartłomiej Dach	09a1fd2cd1	Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button ... Fix daily challenge not showing a replay button in results screen	2024-07-26 08:03:17 +02:00
Bartłomiej Dach	c17cabd981	Adjust alpha for rows for better visibility	2024-07-26 07:44:02 +02:00
Salman Ahmed	c558dfdf13	Reset download state when score is changed	2024-07-26 05:11:54 +03:00
Dean Herbert	c90e04092a	Merge pull request #29068 from bdach/results-statistics-toggle-crash ... Fix crash when toggling extended statistics visibility during results load	2024-07-25 22:49:41 +09:00
Bartłomiej Dach	8dbd4d70ff	Fix crash when toggling extended statistics visibility during results load ... Closes https://github.com/ppy/osu/issues/29066. Initially I fixed this at where the assert is right now: 9790c5a574/osu.Game/Screens/Ranking/ResultsScreen.cs (L333) but because of the weird way that visible state management is done in this screen that made it possible for the extended statistics to be visible *behind* the score panels, without the score panels making way for it. So this is in a way safer, because it prevents the visibility state of the extended statistics from changing in the first place if there is no score selected (yet). This can be also seen in playlists, at least.	2024-07-25 11:45:17 +02:00
Bartłomiej Dach	8d89557ab8	Fix not being able to send chat reports on daily challenge screen ... Something something some people cannot be trusted with a textbox.	2024-07-25 11:11:54 +02:00
Salman Ahmed	615f07d54c	Fix results screen fetching more scores twice	2024-07-25 09:16:09 +03:00
Salman Ahmed	9d5fbb8b4f	Fix target score selection abruptly discarded after opening results screen	2024-07-25 09:01:43 +03:00
Dean Herbert	f1dda4ab1e	Fix too many event rows displaying after spending a long time in gameplay/results	2024-07-25 14:31:22 +09:00
Dean Herbert	c90d345ff9	Scroll content forever rather than aggressively fading	2024-07-25 14:31:21 +09:00
Salman Ahmed	dad8e28446	Fix replay download button not added when no score is selected initially	2024-07-25 07:40:17 +03:00
Dean Herbert	aac98ab6b2	Debounce leaderboard refetches to stop excessive operations after returning from gameplay	2024-07-25 12:58:35 +09:00
Dean Herbert	9ec687caab	Avoid reloading the daily challenge leaderboard when already requested	2024-07-25 12:55:45 +09:00
Dean Herbert	4983e5f33e	Merge pull request #29039 from bdach/multiple-selection-sample-popover ... Make sample popover change properties of all samples in multiple selection	2024-07-24 22:49:20 +09:00
Bartłomiej Dach	1ed7e4b075	Make sample popover change properties of all samples in multiple selection ... Closes https://github.com/ppy/osu/issues/28916. The previous behaviour *may* have been intended, but it was honestly quite baffling. This seems like a saner variant.	2024-07-24 12:15:12 +02:00
Dean Herbert	6e4625609d	Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard ... Fill daily challenge top 50 position numbers client-side	2024-07-24 17:49:51 +09:00
Bartłomiej Dach	788b70469d	Exit daily challenge screen when going offline ... This sort of thing is bound to happen when rewriting screens from scratch without invoking abstract eldritch entities sometimes. Damned if you do, damned if you don't...	2024-07-24 09:15:32 +02:00
Bartłomiej Dach	bf4bf4d39e	Fill daily challenge top 50 position numbers client-side ... Only doing this client-side, because doing this server-side is expensive: https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285	2024-07-24 08:57:11 +02:00
Dean Herbert	aded31bd07	Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt ... Respect pre-empt time when auto-generating breaks	2024-07-24 15:21:12 +09:00
Dean Herbert	aed7ba9508	Change order of application to avoid bias to side with more room to drag ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-07-23 20:56:21 +09:00
Bartłomiej Dach	c3062f96ee	Fix autogenerated breaks not invalidating on change to pre-empt time	2024-07-23 13:38:50 +02:00
Bartłomiej Dach	088e8ad0a2	Respect pre-empt time when auto-generating breaks ... Closes https://github.com/ppy/osu/issues/28703.	2024-07-23 13:30:13 +02:00
Dean Herbert	cc4ed0ff3f	Use non-screen-space coordinates and add time-based drag ramping for better control	2024-07-23 18:59:22 +09:00
Bartłomiej Dach	38fc6f70f6	Add tolerance when drag-scrolling editor timeline ... Closes https://github.com/ppy/osu/issues/28983. While the direct cause of this is most likely mouse confine in full-screen, it shouldn't/can't really be disabled just for this, and I also get this on linux in *windowed* mode. In checking other apps, adding some tolerance to this sort of drag-scroll behaviour seems like a sane UX improvement anyways.	2024-07-23 11:10:18 +02:00
Bartłomiej Dach	dd8be62d07	Merge pull request #28849 from frenzibyte/custom-profile-colour ... Add custom hue support to user profile overlay	2024-07-22 09:41:32 +02:00
Layendan	6a4872faa8	Remove nullable disable	2024-07-21 23:56:47 -07:00
Layendan	6bb562db14	Fix collection popover	2024-07-22 12:22:52 +09:00
Layendan	e4cccb5e31	Fix lint errors	2024-07-22 12:22:52 +09:00
Layendan	a575566638	Add tests	2024-07-22 12:22:51 +09:00
Layendan	c16b7c5c70	Update favorite button	2024-07-22 12:22:51 +09:00
Layendan	3296beb003	Added collection button to result screen	2024-07-22 12:22:50 +09:00
Salman Ahmed	818b60a3d8	Fix pause overlay hiding input from ruleset input manager ... If a key is pressed while the pause overlay is visible, the ruleset input manager will not see it, therefore if the user resumes while the key is held then releases the key, the ruleset input manager will not receive the key up event.	2024-07-19 18:48:35 +03:00
Salman Ahmed	d7651ef387	Add extensive test cases for correct input handling while paused in osu! & non-osu!	2024-07-19 18:48:35 +03:00
Bartłomiej Dach	27000aa8ed	Merge branch 'master' into editor-blah	2024-07-19 13:42:40 +02:00
Dan Balasescu	ad564f31cb	Merge pull request #28947 from peppy/fix-playlist-item-panel ... Fix various visuals of playlist beatmap panels	2024-07-19 20:12:40 +09:00
Dean Herbert	c2cc85e6f0	Use purple again for kiai time specifically	2024-07-19 19:59:38 +09:00
Dean Herbert	c4de2bbb60	Ignore "too many ticks" in timeline (triggers in normal cases)	2024-07-19 19:57:47 +09:00
Dean Herbert	5ee645ac8f	Increase opacity of control points slightly	2024-07-19 19:50:21 +09:00
Dean Herbert	d9297438ba	Merge pull request #28900 from smoogipoo/fix-more-tests ... Fix more test failures	2024-07-19 19:38:52 +09:00
Dean Herbert	f11f01f9b7	Fix various visuals of playlist beatmap panels ... Supersedes https://github.com/ppy/osu/pull/28907. - Fix border being fat - Fix thumbnail not masking correctly - Fix background layer not being correctly fit to the panel - Dim the main background on hover - Minor tweaks to dimming	2024-07-19 19:26:04 +09:00
Dan Balasescu	5af39aad00	Add beatmap name to log string ... Makes it easy to compare this line versus the one in OsuGame.PresentBeatmap(). At the moment it's just GUID which is... not useful!	2024-07-19 19:02:41 +09:00
Dean Herbert	0f29ed618a	Don't attempt to clear the carousel during realm blocking operation	2024-07-19 17:39:47 +09:00
Dean Herbert	0560214d5b	Fix beatmap carousel performance regression with large databases	2024-07-19 17:39:47 +09:00
Bartłomiej Dach	4dd225fdc8	Fix compose blueprint container not unsubscribing from event ... Closes https://github.com/ppy/osu/issues/28938. This is related to reloading the composer on timing point changes in scrolling rulesets. The lack of unsubscription from this would cause blueprints to be created for disposed composers via the `hitObjectAdded()` flow. The following line looks as if a sync load should be forced on a newly created placement blueprint: da4d37c4ad/osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs (L364) however, it is not the case if the parent (`placementBlueprintContainer`) is disposed, which it would be in this case. Therefore, the blueprint stays `NotLoaded` rather than `Ready`, therefore it never receives its DI dependencies, therefore it dies on an `EditorBeatmap` nullref.	2024-07-19 08:32:36 +02:00
Salman Ahmed	a570949459	Fix selection box initialy visible despite no items selected	2024-07-19 03:00:44 +03:00
Salman Ahmed	d61a72b8fb	Explicitly define Hue rather than implicitly provide it by enum value	2024-07-18 00:26:24 +03:00
Layendan	0bc14ba646	Add favourite button to results screen	2024-07-17 12:45:20 -07:00
Bartłomiej Dach	4c1f902969	Do not allow working beatmap to switch to protected beatmap in song select ... Principal fix to https://github.com/ppy/osu/issues/28880.	2024-07-17 11:46:19 +02:00
Bartłomiej Dach	ad2db3f853	Merge pull request #28882 from peppy/update-framework ... Update framework	2024-07-16 12:28:51 +02:00
Dean Herbert	f1325386f0	Fix summary timeline timing points having x position applied twice	2024-07-16 18:32:54 +09:00
OliBomby	ba501a8eb8	fix addition bank toggle can be switched off with selection	2024-07-16 11:30:52 +02:00
Dean Herbert	4ad7d900c1	Fix incorrect editor screen padding	2024-07-16 18:20:33 +09:00
Dean Herbert	1083e71ce6	Fix potential crash when exiting daily challenge screen ... Without the schedule this will potentially run after disposal of the local drawable hierarchy. Closes https://github.com/ppy/osu/issues/28875.	2024-07-16 03:02:04 +09:00
OliBomby	9f02a1f1bf	fix addition on node sample not working	2024-07-14 22:50:15 +02:00
OliBomby	df7a42a00e	fix placement samples	2024-07-14 22:33:23 +02:00
OliBomby	5e86a01e5e	allow hotkeys in sample point piece	2024-07-14 20:59:46 +02:00
OliBomby	952540024e	addition bank toggles in compose	2024-07-14 20:43:16 +02:00
Dean Herbert	eb3f480a2a	Merge pull request #28683 from frenzibyte/footer-v2-integration ... Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`	2024-07-12 22:45:06 +09:00
Dean Herbert	e8f7213b3b	Move logo depth to a forward passing	2024-07-12 22:01:20 +09:00
Bartłomiej Dach	217b01d303	Apply tooltip to bookmark pieces too ... Bookmarks don't show on real beatmaps, but they do show in test scenes (namely `TestSceneEditorSummaryTimeline`). Also does some more changes to adjust the markers to the latest updates to other markers.	2024-07-12 11:12:20 +02:00
Dean Herbert	2453e2fd00	Fix nullability issue	2024-07-12 18:11:23 +09:00
Bartłomiej Dach	5e00995948	Merge branch 'master' into tooltips	2024-07-12 11:01:03 +02:00
Bartłomiej Dach	518dc17518	Merge pull request #28788 from bdach/timeline-redesign ... Redesign editor timelines to address most frequent user complaints	2024-07-12 10:58:59 +02:00
Dean Herbert	4be5d056c5	Reduce opacity of centre marker slightly	2024-07-12 17:23:48 +09:00
Dean Herbert	d2cb07b157	Add a bit more padding between node overlays and hitobjects in timeline	2024-07-12 17:22:36 +09:00
Dean Herbert	2454722601	Add tooltips to summary timeline display	2024-07-12 16:39:41 +09:00
Dean Herbert	275e7aa451	Adjust timeline centre marker visuals and bring in front of ticks	2024-07-12 16:37:03 +09:00
Dean Herbert	ca2fc72959	Adjust timeline centre marker visuals and bring in front of ticks	2024-07-12 16:29:40 +09:00
Dean Herbert	f65ab6736d	Adjust breaks in timeline to be centered with waveform / hitobjects	2024-07-12 15:45:58 +09:00
Dean Herbert	2ad2ae0c16	Add slight offset for timeline BPM display to avoid overlaps	2024-07-12 14:34:01 +09:00
Dean Herbert	9a7a0cdb34	Adjust timeline ticks to add a bit more body back	2024-07-12 14:29:18 +09:00
Dean Herbert	685b19a571	Adjust various visuals of summary timeline in a hope for user acceptance ... .. with a somewhat appealing design.	2024-07-12 13:57:42 +09:00
Dean Herbert	fb4f620c90	Add back BPM and adjust sizing of bottom bar a bit more	2024-07-12 12:34:43 +09:00
Salman Ahmed	d4a4a059d4	Fix footer content not accessible by overlay when overriden by a subclass	2024-07-11 15:31:02 +03:00
Bartłomiej Dach	ccc4d288b2	Merge pull request #28821 from peppy/fix-editor-dim ... Fix editor UI transparency being incorrectly opaque when hovering slider control points	2024-07-11 12:05:10 +02:00
Dean Herbert	95464ebf36	Merge branch 'master' into timeline-redesign	2024-07-11 18:38:17 +09:00
Bartłomiej Dach	6801ccbbc5	Fix editor UI remaining transparent when switching away from compose tab ... Could still happen if using the keyboard F-key shortcuts. In that case the composer becomes non-present, so its `Update()` can't really do anything.	2024-07-11 11:23:09 +02:00