2681 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	4b3b22f046	Merge branch 'master' into beat-divisor-better-defaults	2023-06-08 20:35:03 +02:00
Bartłomiej Dach	b66d1aa33d	Fix code quality inspection	2023-06-08 20:32:16 +02:00
Dean Herbert	c1743dbe1d	Select all text when popover is initially shown ... Depends on https://github.com/ppy/osu-framework/pull/5823.	2023-06-09 02:27:22 +09:00
Bartłomiej Dach	281aae91ec	Merge pull request #23808 from peppy/working-beatmap-get-background ... Refactor `IWorkingBeatmap.Background` to `GetBackground()`	2023-06-08 12:23:07 +02:00
Dean Herbert	a842f79ad4	Refactor IWorkingBeatmap.Background to GetBackground()	2023-06-08 16:19:32 +09:00
Bartłomiej Dach	b3ce7f7b43	Merge branch 'master' into fix-section-container-scroll-attempt-2	2023-06-08 09:19:26 +02:00
Bartłomiej Dach	3c8f387a6c	Remove unused method	2023-06-07 23:38:06 +02:00
Bartłomiej Dach	d9281ac8c7	Remove unused virtual spec	2023-06-07 23:38:06 +02:00
Bartłomiej Dach	9b665d2e1a	Merge branch 'master' into beat-snap-divisor-hotkeys	2023-06-07 23:38:03 +02:00
Dean Herbert	3a01498789	Use existing next/previous methods (and remove looping behaviour)	2023-06-08 01:01:29 +09:00
Bartłomiej Dach	1f4e79d79d	Merge pull request #23711 from timiimit/add-last-edit-time ... Store timestamp of beatmap's last edit time in local database	2023-06-07 16:57:24 +02:00
Dean Herbert	2c89af608a	Add ability to cycle beat snap divisor using hotkeys ... Defaults to Ctrl+Shift+Wheel (as per stable). Closes #23785.	2023-06-07 17:15:15 +09:00
Dean Herbert	7d49f5d7c6	Apply NRT to SectionsContainer	2023-06-07 16:32:29 +09:00
Salman Ahmed	62cb6a98ca	Remove redundant nullable suppression directives	2023-06-07 08:20:41 +03:00
Dean Herbert	22f7fe1d79	Rename variable and ensure timestamp is updated even when not saving	2023-06-06 15:11:31 +09:00
Dean Herbert	3a50e0fb2f	Merge branch 'master' into add-last-edit-time	2023-06-06 15:07:20 +09:00
Bartłomiej Dach	c2d89a32a9	Adjust inline comment	2023-06-01 21:18:00 +02:00
Andrei Zavatski	03eb7c7830	Fix nullability	2023-06-01 21:21:01 +03:00
Andrei Zavatski	949fe32740	Use combined area of children as a mask instead	2023-06-01 15:32:17 +03:00
Dean Herbert	32207d4112	Remember the last used custom divisor when cycling divisor types	2023-06-01 17:11:49 +09:00
Dean Herbert	bcde2cbc73	Apply NRT to BeatDivisorControl	2023-06-01 16:58:14 +09:00
Dean Herbert	f52ed41f10	Use better defaults of 1/4 and 1/6 when cycling types	2023-06-01 16:28:03 +09:00
timiimit	a58426dab6	Use LastEditTime in Editor	2023-05-31 19:07:04 +02:00
Andrei Zavatski	d119447a10	Fix editor timeline hitobjects popping in	2023-05-30 16:41:42 +03:00
Dean Herbert	725734bc03	Merge pull request #23649 from peppy/keep-selection-buttons-on-screen ... Ensure editor selection buttons remain on screen when selection is near edge	2023-05-26 20:51:45 +09:00
Bartłomiej Dach	96fe7cbe54	Merge branch 'master' into sample-set-controls	2023-05-25 21:58:16 +02:00
Bartłomiej Dach	7d8f08c0ea	Fix ComposeBlueprintContainer briefly assigning auto bank ... Seems to have had no consequence due to the way `AutomaticBankAssignment` works (that flag is checked in `PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially every frame), but let's avoid putting it there at all ever.	2023-05-25 21:49:29 +02:00
Bartłomiej Dach	3ad5f8b9c9	Polish a few extreme edge cases	2023-05-25 16:39:54 +02:00
Dean Herbert	949de35664	Ensure selection is reset after immediately deleting objects ... Closes https://github.com/ppy/osu/issues/23518.	2023-05-25 23:20:32 +09:00
Bartłomiej Dach	beeca5a8dd	Use alternative layouting implementation	2023-05-25 16:17:44 +02:00
Dean Herbert	1049257b56	Simplify SelectionHandler's DeselectAll implementation ... We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match	2023-05-25 18:46:31 +09:00
Dean Herbert	1e14b02493	Fix bindable feedback loop	2023-05-25 17:58:38 +09:00
Bartłomiej Dach	578a0e7494	Merge branch 'master' into beat-divisor-visual-improvements	2023-05-24 22:28:26 +02:00
Bartłomiej Dach	6ec4ecfdd7	Mention fallback default in GetDivisorForBeatIndex()	2023-05-24 22:17:51 +02:00
Dean Herbert	b14b1072c2	Allow deselecting any selection in the editor using the Back binding (escape key)	2023-05-24 19:24:14 +09:00
Dean Herbert	3b9e1e8a94	Ensure editor selection buttons remain on screen when selection is near edge ... Addresses https://github.com/ppy/osu/discussions/23599.	2023-05-24 19:16:53 +09:00
Dean Herbert	3a05dffa50	Add "auto" bank selection during placement	2023-05-24 17:11:12 +09:00
Dean Herbert	fc22c75464	Don't use switch for single case statement	2023-05-24 16:14:05 +09:00
Dean Herbert	a9ba16a2be	Update to support non-control-point sample changes	2023-05-24 14:20:38 +09:00
Dean Herbert	298989ffd2	Merge branch 'master' into sample-set-controls	2023-05-24 14:03:04 +09:00
Dean Herbert	561b759bf9	Tidy up implementation and ensure non-solid ticks start at zero alpha	2023-05-24 13:49:29 +09:00
Dean Herbert	8f1f1955df	Merge pull request #66 from Gyoshi/beat-divisor-visual-improvements ... Add ghost ticks to exhibit current divisor on `BeatDivisorControl`	2023-05-24 13:41:48 +09:00
Gyoshi	7fe19d1992	Last instead of Max divisor to match code elsewhere	2023-05-23 18:45:49 +02:00
Gyoshi	c5ef3ae181	Code styling	2023-05-23 18:44:20 +02:00
Gyoshi	b5f8093941	Use RangePadding to align mouse with slider	2023-05-23 18:16:14 +02:00
Gyoshi	7b1e8ede54	Small format	2023-05-23 15:11:27 +02:00
Gyoshi	1b32370c6a	Remove duplicate code by making GetDivisorForBeatIndex method more general	2023-05-23 15:05:38 +02:00
Gyoshi	37a796306d	Small format & comment	2023-05-23 14:30:35 +02:00
Johannes vd Berg	ebda35c3c9	Add ghost ticks to exhibit current divisor on BeatDivisorControl	2023-05-23 12:57:25 +02:00
Bartłomiej Dach	38b4bd8aef	Fix undo not behaving as expected sometimes	2023-05-22 22:45:39 +02:00
Bartłomiej Dach	e0b7539c2a	Fix sample changes not being applied in patcher	2023-05-22 22:45:23 +02:00
Bartłomiej Dach	f253d17a7f	Fix slider velocity changes not being applied in patcher	2023-05-22 22:19:10 +02:00
Bartłomiej Dach	afdddb0195	Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes ... Fix timeline blueprint display not showing correct combo number / colour during placement	2023-05-20 15:02:55 +02:00
Dean Herbert	214d7e07fa	Add TODO regarding failing stack display code	2023-05-17 17:52:17 +09:00
Dean Herbert	9563d4f730	Fix weird purple tint on placement object in timeline	2023-05-17 17:26:19 +09:00
Dean Herbert	87ff28b022	Update beat divisor control to show ticks in more visually correct locations ... As proposed in https://github.com/ppy/osu/discussions/23527.	2023-05-17 16:34:12 +09:00
Dean Herbert	dc51d5ecf3	Rename GetSampleInfo to better describe what method does ... Also add full xmldoc	2023-05-17 14:07:48 +09:00
Dean Herbert	d9ae822966	Fix bank not correctly being assigned when adding sample additions in editor	2023-05-16 18:52:52 +09:00
Dean Herbert	70e248b927	Force placement of in-progress object when changing tools in the editor	2023-05-12 16:06:01 +09:00
Dean Herbert	bdf8a78b42	Add the ability to adjust the beatmap tick rate in the editor	2023-05-09 20:53:20 +09:00
Dean Herbert	2085833a84	Fix missing delegate unsubscribe	2023-05-09 17:08:03 +09:00
Dean Herbert	944da06c10	Rename slider multiplier variable back for now	2023-05-09 16:58:19 +09:00
Dean Herbert	8c44d528e9	Use min/max values from stable	2023-05-08 13:52:16 +09:00
Dean Herbert	a6cb1f90e4	Change difficulty popover inspector display (yet again) ... I think this makes the most sense of the iterations I've tested so far, albeit maybe being a touch too verbose.	2023-05-08 13:43:23 +09:00
Dean Herbert	a91edd68d9	Show post-multiplied velocity in main hit object inspector	2023-05-08 13:42:25 +09:00
Dean Herbert	451af9d1b5	Fix beatmap values not being updated due to a varying data type	2023-05-08 13:23:13 +09:00
Dean Herbert	d9dd35c020	Show base velocity in slider adjustment popover	2023-05-08 13:13:09 +09:00
Dean Herbert	31de4de720	Remove median/mode slider velocity display ... The intention was to give an idea of what the most common velocity of the beatmap is, but in hindsight, because the "base" velocity is being set elsewhere this doesn't make sense. It will/should be 1.0x. Showing this range is still valuable, though.	2023-05-08 13:13:09 +09:00
Dean Herbert	b109ee74a6	Add "base velocity" adjustment to difficulty setup screen	2023-05-08 13:13:09 +09:00
Bartłomiej Dach	65b4b198a4	Merge branch 'master' into export	2023-05-06 20:12:53 +02:00
Bartłomiej Dach	e808a47811	Fix delegate leak	2023-05-05 20:33:27 +02:00
Bartłomiej Dach	f536238554	Use shorter copy	2023-05-05 20:30:50 +02:00
Dean Herbert	b7a287869a	Add display of beatmap slider velocity when adjusting	2023-05-05 15:57:38 +09:00
Dean Herbert	cc70d89bf9	Move editor inspector classes out of ruleset namespace	2023-05-05 15:57:38 +09:00
cdwcgt	4549a865d9	Merge branch 'master' into export	2023-05-04 00:18:01 +09:00
Dean Herbert	6b017ac05f	Merge pull request #23308 from OliBomby/sample-control-points ... Remove SampleControlPoint and DifficultyControlPoint from HitObject	2023-05-03 14:21:51 +09:00
Dean Herbert	8a536c1cdb	Fix non-block namespace usage	2023-05-02 15:09:24 +09:00
OliBomby	1dc34ee25d	fix infinite repeat count when adjusting length of 0 length slider	2023-05-01 15:48:54 +02:00
OliBomby	608fa3cc73	Merge remote-tracking branch 'upstream/master' into sample-control-points	2023-04-30 19:47:03 +02:00
Cootz	607a04ae73	Fix the issue	2023-04-29 10:29:33 +09:00
OliBomby	c44f71a737	remove all regular usage of DifficultyControlPoint	2023-04-26 17:55:38 +02:00
OliBomby	87ca0f5335	Update SamplePointPiece.cs	2023-04-26 13:45:58 +02:00
OliBomby	e4b64bdc3e	clean up code stuff	2023-04-25 19:06:29 +02:00
OliBomby	755ad25dbe	clean code	2023-04-25 18:27:20 +02:00
OliBomby	c23a7b014e	add missing }	2023-04-25 18:17:07 +02:00
OliBomby	065464d90c	Fixed DifficultyPointPiece	2023-04-25 18:12:53 +02:00
Dean Herbert	9f4b1f0f24	Always round editor rotation to integer values	2023-04-20 14:30:01 +09:00
Bartłomiej Dach	73bd0feef5	Fix incorrectly implemented localisation	2023-04-10 15:03:33 +02:00
Bartłomiej Dach	6fec476147	Simplify snap implementation	2023-04-10 14:55:30 +02:00
cdwcgt	ce6a87b4a3	Merge remote-tracking branch 'upstream/master' into export	2023-04-09 15:02:47 +09:00
Dean Herbert	8d2e852ffd	Fix overbearing key down handling	2023-04-08 22:30:36 +09:00
Dean Herbert	a1fc4def1d	Remove redundant method override	2023-04-08 22:18:07 +09:00
Micha Lehmann	3c4a25e53f	Fix tooltip text not resetting when ending an editor rotation	2023-04-08 14:28:52 +02:00
Micha Lehmann	580d5745c0	Add "(snapped)" to the tooltip when snap-rotating in the editor	2023-04-08 14:15:49 +02:00
Dean Herbert	f72dd86b42	Fix code quality issues and avoid updating bindable twice per operation	2023-04-08 10:40:36 +09:00
Micha Lehmann	c827c2810b	Improve editor selection rotation value wrapping ... This fixes two issues the previous algorithm had: 1. A half-turn rotation used to show up as -180°. 2. Rotating more than 180° in one drag event would overwhelm it and cause the value to go outside its range. This comes at the cost of a negligible performance hit, since a division (modulo) is performed instead of just addition/subtraction.	2023-04-08 01:30:29 +02:00
Micha Lehmann	f1de560d57	Snap editor selection rotation when holding shift	2023-04-08 01:30:29 +02:00
Dean Herbert	e31a90e043	Don't cycle selection when more than one items are selected	2023-03-21 21:31:10 +09:00
Dean Herbert	1cf870d956	Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection	2023-03-15 15:16:48 +09:00
Dean Herbert	6546f5968a	Merge branch 'master' into skin-editor-cyclic-selection	2023-03-14 20:43:56 +09:00
Dean Herbert	4f7be332f3	Revert isDraggingBlueprint to field	2023-03-08 19:24:03 +09:00
Dean Herbert	245c3c025c	Refactor endClickSelection to reduce nesting	2023-03-08 19:23:32 +09:00
Bartłomiej Dach	72695f7c90	Merge branch 'master' into omit-barline-in-timing-control-point	2023-03-07 22:46:24 +01:00
Dean Herbert	21bdbb20e6	Add optional support for cyclic selection to BlueprintContainer	2023-03-07 14:22:12 +09:00
mk56-spn	908651cc11	make ResetConfirmDialog properly utilise its parent's logic ... Adjust name of `DeleteAction` to `DangerousAction`	2023-03-05 20:57:26 +01:00
Dean Herbert	6ff1fb6b1a	Adjust sizing to allow for timing point information now being longer than before	2023-03-02 18:57:54 +09:00
Dean Herbert	044b0604b2	Move OmitFirstBarLine to TimingControlPoint	2023-02-28 19:29:31 +09:00
mk56-spn	90227a6496	Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs	2023-02-27 21:57:59 +01:00
Bartłomiej Dach	1ba1298850	Merge branch 'master' into blueprint-improve-visuals	2023-02-19 15:55:30 +01:00
Bartłomiej Dach	d9ca7102f0	Use more generic wording for future-proofing	2023-02-19 15:06:40 +01:00
Maximilian Kruse	723a043c43	naming change from Hitobject to HitObject	2023-02-19 10:18:22 +01:00
Maximilian Kruse	ddd37bb319	Add setting to disable automatic seeking after object placement	2023-02-18 19:43:45 +01:00
cdwcgt	e84e011d5d	Merge branch 'master' into export	2023-02-17 22:15:19 +09:00
Dean Herbert	16d94b4ea2	Improve visuals of skin blueprint	2023-02-17 18:19:46 +09:00
Joseph Madamba	cb51b9e350	Use existing ModdingBeatmap activity	2023-02-12 15:01:50 -08:00
Joseph Madamba	bbeef53569	Add TestingBeatmap activity	2023-02-12 13:11:42 -08:00
Joseph Madamba	afb66d8af4	Make user activity class names more specific	2023-02-12 12:32:17 -08:00
Bartłomiej Dach	a3cc0d23b3	Fix typo in xmldoc	2023-02-11 16:26:32 +01:00
Dean Herbert	6d876fdb9a	Automatically select the closest timing point on entering the timing screen	2023-02-10 17:48:56 +09:00
Dean Herbert	03e623d1d2	Move ControlPointList to own file	2023-02-10 17:37:31 +09:00
Dean Herbert	e162fd56da	Change the way initial state saving works in EditorChangeHandler to be closer to first change	2023-02-07 16:22:51 +09:00
Dean Herbert	e4b17588f5	Add missing xmldoc to new methods in EditorChangeHandler	2023-02-06 14:11:40 +09:00
Dean Herbert	10ab4d572a	Merge branch 'master' into skin-editor-undo-support	2023-02-06 13:46:50 +09:00
Bartłomiej Dach	63f7d326c2	Merge branch 'master' into fix-editor-positional-nudge-undo	2023-02-03 21:31:05 +01:00
Dean Herbert	2cda277c09	Add a basic change handler to the skin editor	2023-02-03 18:57:50 +09:00
Dean Herbert	3345e34544	Move beatmap specific logic out of EditorChangeHandler	2023-02-03 17:53:54 +09:00
Dean Herbert	b437501b0f	Fix beatmap editor positional nudging not being undoable	2023-02-03 17:28:58 +09:00
Dean Herbert	554f14151c	Apply NRT to EditorChangeHandler	2023-02-03 17:13:24 +09:00
Dean Herbert	b19047b90b	Fix skin editor component list having uneven padding	2023-02-03 16:55:51 +09:00
Bartłomiej Dach	7483967157	Merge branch 'master' into SliderEnd-Snap	2023-01-23 21:33:16 +01:00
Bartłomiej Dach	1f40b2daf6	Clean up xmldocs	2023-01-23 21:22:18 +01:00
Wleter	f8d8a627b8	change property name	2023-01-18 22:00:39 +01:00
Wleter	40e99069fc	fix typos and newlines	2023-01-18 21:43:09 +01:00
Wleter	ab78dd0436	add collection of selection points.	2023-01-18 21:34:23 +01:00
Wleter	c9375c056e	revert back name change	2023-01-18 15:54:24 +01:00
Dean Herbert	ecb4727aec	Fix formatting issues	2023-01-18 17:33:14 +09:00
Wleter	788033e1b8	fix unnecessary newline	2023-01-17 21:13:54 +01:00
Wleter	b8e6a2d87b	filter currentEndPointPositions	2023-01-17 20:41:49 +01:00
ansel	00acea59fc	Move some strings to common	2023-01-15 19:37:40 +03:00
ansel	5d2e09137c	Remove text padding in editor menu for now	2023-01-15 14:40:53 +03:00
ansel	8777d5349b	Use existing strings	2023-01-15 14:39:34 +03:00
ansel	87650044bb	Localise create/save dialog	2023-01-15 01:50:47 +03:00
ansel	78e562903d	Localise part of editor	2023-01-15 01:50:47 +03:00
ansel	24df23f420	Localise background header	2023-01-15 01:49:19 +03:00
ansel	76eefc7573	Add support for localisation where it was missing	2023-01-15 01:46:11 +03:00
ekrctb	e610d19d55	Merge branch 'master' into 18469	2023-01-14 19:53:08 +09:00
ansel	f70dedfd17	Enable nullability for design screen	2023-01-14 02:24:48 +03:00
ansel	4b42240fba	Enable nullability for setup screen	2023-01-14 02:24:28 +03:00
ansel	78adaa9b03	Enable nullability for timing screen	2023-01-14 02:23:21 +03:00
Dylan Nantz	6028abff39	Code Quality	2023-01-13 10:16:52 -05:00
Dylan Nantz	5dd0aaccef	Merge branch 'master' of https://github.com/ppy/osu into 18469	2023-01-13 09:54:29 -05:00
Dylan Nantz	e38075c4ef	Use PlacementState to check juice stream placement	2023-01-13 09:37:23 -05:00
ansel	2365b065a4	Enable nullability for editor components	2023-01-12 18:07:54 +03:00
Wleter	98ffcd33c7	Merge branch 'ppy:master' into SliderEnd-Snap	2023-01-10 21:22:13 +01:00
Wleter	88060a3ea0	add snapping for slider's end	2023-01-10 21:21:09 +01:00
Bartłomiej Dach	e08b7c615b	Merge branch 'master' into wcd-length-fix	2023-01-08 19:44:12 +01:00
Bartłomiej Dach	9fd305a970	Merge branch 'master' into editor-bg-refresh	2023-01-08 18:57:04 +01:00
ansel	aaeb43fbb2	Return older file if new one is null	2023-01-07 18:15:57 +03:00
Salman Ahmed	a65466bdac	Merge branch 'master' into previewTime	2023-01-07 15:07:09 +03:00
Salman Ahmed	abca13eb6c	Rewrite visualisation piece to bind once and without potential event leak	2023-01-07 14:40:15 +03:00
Salman Ahmed	904c76e437	Use sane BeatmapInfo for preview time mutation ... `EditorBeatmap.BeatmapInfo` is usually the correct instance for mutating properties that should persist in the database.	2023-01-07 14:23:36 +03:00
ansel	b47cef838c	Nullability	2023-01-07 03:08:02 +03:00
ansel	167ac8b5dd	Fix editor object being requered	2023-01-07 03:03:52 +03:00
ansel	9364c7775d	Refresh background on file change in editor	2023-01-06 19:26:30 +03:00
ansel	e90c698e62	Fix WCD does not take into account start time of control points	2023-01-06 16:35:39 +03:00
Dean Herbert	c0cfa66510	Merge pull request #21754 from Feodor0090/waveform-invalidate ... Reload waveform on track replacement in editor	2023-01-06 19:57:27 +08:00
ansel	c6e2104ec2	Refresh waveforms instead of recreating the whole component	2023-01-06 03:46:49 +03:00
Bartłomiej Dach	b689ad6d80	Fix changing preview point not prompting for save	2023-01-01 19:54:26 +01:00
Bartłomiej Dach	efdd557f3b	Adjust binding logic	2023-01-01 19:45:23 +01:00
Bartłomiej Dach	452ebddfd2	Adjust visual appearance of preview time part ... - Use slightly different hue of green to distinguish from difficulty control points. The colour is still not ideal, but picking a distinctive enough hue is pretty hard. - Place the preview time part at the bottom rather at the top. Not sure why it was at the top; not only could it overlap with the control points, but it also looked quite badly misaligned there when bookmarks were displayed at the bottom.	2023-01-01 19:42:55 +01:00
Bartłomiej Dach	a82f1a6abd	Adjust method naming and copy	2023-01-01 18:50:47 +01:00
Bartłomiej Dach	0e59b55a12	Merge branch 'master' into previewTime	2023-01-01 18:38:19 +01:00
cdwcgt	23c485c763	readonly	2022-12-30 22:59:56 +09:00
cdwcgt	a91da2284d	safe way to pass bindable	2022-12-30 22:58:46 +09:00
Berkan Diler	c7ca4bbba5	Use generic Enum methods	2022-12-26 20:36:39 +01:00
ansel	f25439e359	Move track change subscription to LoadComplete	2022-12-23 01:54:49 +03:00
Salman Ahmed	0cb9b79834	Fix ZoomableScrollContainer potentially not updating content width on setup	2022-12-23 00:56:38 +03:00
Salman Ahmed	30de9ba795	Dispose previous waveform on track reload	2022-12-23 00:35:59 +03:00
ansel	20370bd5ae	Invalidate waveform on track load	2022-12-22 20:49:09 +03:00
ansel	d0645ce151	Rewrite waveform invalidation	2022-12-22 15:59:51 +03:00
ansel	f2e8776529	Bind to clock instead of music controller	2022-12-22 15:35:53 +03:00
ansel	a18ece8610	Listen for track reload in timing screen	2022-12-22 01:24:23 +03:00
ansel	7089bb6c23	Listen for track reload in timeline	2022-12-22 01:23:59 +03:00
ansel	66a02374da	Clear cached waveform on track change in editor	2022-12-22 01:23:24 +03:00
Dean Herbert	4a7d7c6ed9	Use MaxBy in all locations that can and update inspection level to match dotnet-build	2022-12-19 16:47:10 +09:00
Dean Herbert	ba54551313	Merge branch 'master' into guard-url-protocols	2022-12-16 18:23:16 +09:00
Dean Herbert	27c497145f	Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0	2022-12-16 18:16:26 +09:00
cdwcgt	a4d28aff6d	fix typo	2022-12-16 10:48:56 +09:00
cdwcgt	79e27c2d9d	PreviewTimePart will not show if preview time is -1	2022-12-16 10:44:07 +09:00
cdwcgt	f0246df1a9	only get;	2022-12-16 09:58:58 +09:00
cdwcgt	c164744064	Add ability to set preview time	2022-12-16 01:03:30 +09:00
Dean Herbert	b8904fe747	Move ImportParameters to better home	2022-12-13 21:41:26 +09:00
Dean Herbert	cb16d62700	Hook up ImportParameter flow with IModelImporter caller methods	2022-12-13 21:29:32 +09:00
cdwcgt	e02b8cb199	Group export methods into their respective managers	2022-12-11 18:30:24 +09:00
cdwcgt	a1fc33668c	Merge branch 'master' into export	2022-12-09 23:40:26 +09:00
Dean Herbert	5a69656764	Merge pull request #21496 from peppy/fix-zero-length-spinners ... Fix being able to place zero-length spinners	2022-12-02 19:25:00 +09:00
Dan Balasescu	850931120d	Merge pull request #21479 from peppy/fix-wrong-last-hit-object-time ... Fix some components not accounting for final hold notes in osu!mania beatmaps	2022-12-02 18:12:00 +09:00
Dean Herbert	d1296a22ce	Update timeline blueprint's end time logic to better match new blueprint implementation	2022-12-02 17:57:15 +09:00
Dan Balasescu	a39bd634c4	Merge pull request #21405 from LumpBloom7/Editor-DrawableRuleset-Dependencies ... Provide DrawableRulesetDependencies from HitObjectComposer	2022-12-02 17:31:31 +09:00
Dan Balasescu	d684aa75b8	Merge pull request #21477 from peppy/fix-mania-timeline-blueprint-colour ... Fix osu!mania editor timeline showing bright-white blueprints	2022-12-02 16:55:29 +09:00
Dean Herbert	a2db0afe19	Avoid querying GetLastObjectTime twice in editor seek flow	2022-12-02 16:07:24 +09:00
Dean Herbert	8cf89fcb81	Use Highlight1 instead of dull grey	2022-12-02 15:30:47 +09:00
Dean Herbert	896f2d8f74	Fix multiple instances of last hitobject time being calculated incorrectly	2022-12-01 18:04:06 +09:00
Dean Herbert	f34a79b1a9	Set a better default colour for timeline blueprints when no colour information is available	2022-12-01 17:03:53 +09:00
Dean Herbert	bbf023cf68	Fix incorrect culture used when parsing timeline popup textbox content	2022-12-01 16:12:29 +09:00
Derrick Timmermans	5c8fce1c08	Remove extra blank line	2022-11-30 13:05:14 +01:00
Derrick Timmermans	6a61e70766	Expose Ruleset from HitObjectComposer instead	2022-11-30 12:17:58 +01:00
Dean Herbert	4215f4f5d7	Merge branch 'master' into Editor-DrawableRuleset-Dependencies	2022-11-30 17:42:46 +09:00
Dean Herbert	2a3b24d058	Avoid need for implicit null casting	2022-11-30 14:21:04 +09:00
Dean Herbert	0659c84341	Rename method to be more in line with project naming	2022-11-30 14:17:49 +09:00
Jai Sharma	7dbf379351	Don't use verbatim string literals	2022-11-29 18:22:07 +00:00
Derrick Timmermans	70c320b2e8	Provide ruleset dependencies only to Compose Placement Blueprints	2022-11-27 21:43:33 +01:00
Jai Sharma	218c04c174	Code quality	2022-11-27 03:23:08 +00:00
Jai Sharma	6000e14668	Correctly select issue row	2022-11-27 03:08:54 +00:00
Jai Sharma	3c56b9c93a	Add OnRowSelected event to EditorTable	2022-11-27 02:47:54 +00:00
Jai Sharma	792334a190	Move Control Group timing data into it's own component	2022-11-27 02:47:02 +00:00
Jai Sharma	b6d7bec240	Remove #nullable disabled from EditorTable and it's derived classes	2022-11-27 02:45:56 +00:00
Jai Sharma	1a914d0df7	Remove #nullable disable from TimingScreen	2022-11-27 02:43:22 +00:00
Bartłomiej Dach	894ef15e79	Merge branch 'master' into update-framework	2022-11-26 16:19:36 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Bartłomiej Dach	fca3e7e39f	Merge branch 'master' into editor-seek-control-points	2022-11-24 21:53:47 +01:00
Dean Herbert	37f725bfa2	Reverse directionality of up/down traversal keys to match scroll	2022-11-24 13:55:58 +09:00
Bartłomiej Dach	30f9cc46a7	Protect offset and bpm adjustments from null selection too	2022-11-23 17:25:43 +01:00
Dean Herbert	9b9b8a5977	Add ability to seek between control points in editor using down/up arrows ... Matches stable. Addresses #21376.	2022-11-23 15:59:32 +09:00
Dean Herbert	d146f86511	Fix crash when hitting 'T' to tap timing while no timing point is selected	2022-11-23 15:39:56 +09:00
cdwcgt	e37d30a373	refactor based on reviews ... removed LegacyExportManager Separated the method of CreateZip method and the default export method	2022-11-21 18:58:01 +09:00
Bartłomiej Dach	1269afd0c5	Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu ... Hide scroll speed control from effects section on rulesets which don't support it	2022-11-20 16:17:55 +01:00
Salman Ahmed	4b0ba86bd0	Identify scrolling rulesets using temporary DrawableRuleset instances	2022-11-20 04:12:52 +03:00
Bartłomiej Dach	c05c1625f2	Merge branch 'master' into editor-test-play-dont-retain-test-time	2022-11-19 12:09:04 +01:00
Salman Ahmed	60c424837b	Merge branch 'master' into disable-scroll-speed-on-osu	2022-11-19 12:13:45 +03:00
Salman Ahmed	2e3af97892	Remove unused using	2022-11-19 12:13:36 +03:00
Salman Ahmed	290369db47	Hide scroll speed slider on rulesets which don't support it	2022-11-19 06:42:27 +03:00
Salman Ahmed	016de2f5a0	Fix editor not always playing hitsounds with clock offsets applied	2022-11-19 05:15:22 +03:00
cdwcgt	4e457871f3	impossible null and remove storage	2022-11-19 01:03:22 +09:00
cdwcgt	4b29941b47	add LegacyExportManager	2022-11-18 20:00:00 +09:00
Salman Ahmed	90cd386323	Fix timeline potentially scrolling at extents while not dragging	2022-11-18 09:43:16 +03:00
Dean Herbert	a4e713a61f	When returning to the editor after test play, use the original editor time rather than the point of exit	2022-11-17 12:36:24 +09:00
Dean Herbert	bfcd9e0f45	Don't seek to current editor location when location is close to (or before) the first object	2022-11-17 12:32:35 +09:00
Salman Ahmed	7a28a7f2a0	Move IGameplaySettings override to compose screen to keep test mode unaffected	2022-11-17 01:45:16 +03:00
cdwcgt	e1a21e0cf9	create a task to export to avoid block main thread ... Code quality and remove some #nullable disable	2022-11-17 01:08:06 +09:00
Dean Herbert	ee6fffec5f	Fix combo colour normalisation setting not applying to editor test play	2022-11-16 17:54:49 +09:00
Dan Balasescu	db25e9e9c8	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 15:31:28 +09:00
Dan Balasescu	94772a9cda	Merge pull request #21147 from peppy/fix-timeline-editor-crash ... Fix editor hard crash when beatmap file specified out-of-range timeline zoom value	2022-11-10 22:59:55 +09:00
Dan Balasescu	606d42c679	Merge pull request #21184 from peppy/skinnable-things-cleanup ... Skinnable class naming pass	2022-11-10 12:52:08 +09:00
Dan Balasescu	051f7f4c68	Merge pull request #21173 from peppy/toggle-hit-markers ... Add the ability to toggle off hit marker displays in the editor	2022-11-10 12:23:53 +09:00
Dean Herbert	3547c04002	Merge branch 'master' into skinnable-things-cleanup	2022-11-10 12:09:32 +09:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	c908969d9b	Rename ISkinComponent to ISkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	4457648b1c	Fix editor playing too many sounds when user performs a manual seek during playback	2022-11-09 17:42:33 +09:00
Dean Herbert	4448fcb3c8	Override combo colour brightness normalisation setting only in editor	2022-11-08 18:29:10 +09:00