Gagah Pangeran Rosfatiputra
f07d4532d9
move scroll to into action
2021-06-04 23:51:18 +07:00
Gagah Pangeran Rosfatiputra
a431ef6c48
keep colour change when entry is clicked
2021-06-04 23:43:00 +07:00
Gagah Pangeran Rosfatiputra
5febbe4530
rename method add entry
2021-06-04 23:32:42 +07:00
Gagah Pangeran Rosfatiputra
70c64af25e
rename toc entry
2021-06-04 23:31:51 +07:00
Gagah Pangeran Rosfatiputra
8883d5e2d1
use heading block to get title string
2021-06-04 15:28:54 +07:00
Gagah Pangeran Rosfatiputra
6d6c03eafe
use linq to find first literal inline
2021-06-04 14:45:06 +07:00
Gagah Pangeran Rosfatiputra
a706ff63ed
change sprite text to text flow
2021-06-04 12:50:03 +07:00
Gagah Pangeran Rosfatiputra
91e77ee4de
add onclick in toc title
2021-06-04 11:43:49 +07:00
Gagah Pangeran Rosfatiputra
37ff6299c9
add target in toc title
2021-06-04 11:43:32 +07:00
Gagah Pangeran Rosfatiputra
e28b38653b
cache scroll container
2021-06-04 11:43:00 +07:00
Gagah Pangeran Rosfatiputra
4e73d02540
move sidebar into local variable
2021-06-04 11:35:23 +07:00
Gagah Pangeran Rosfatiputra
424d1b4025
add margin padding spacing in toc title
2021-06-04 11:18:08 +07:00
Gagah Pangeran Rosfatiputra
41ec531bab
add subtitle toc
2021-06-04 11:12:42 +07:00
Gagah Pangeran Rosfatiputra
d8d4bf66b3
create TocTitle in WikiSidebar
2021-06-04 11:09:20 +07:00
Gagah Pangeran Rosfatiputra
59dbed6418
create ArticleMarkdownContainer in WikiArticlePage
2021-06-04 11:08:51 +07:00
Gagah Pangeran Rosfatiputra
abb522f084
add missing using
2021-06-04 10:53:48 +07:00
Dan Balasescu
0ba493d598
Merge pull request #13318 from gagahpangeran/error-page-placeholder
...
Add error page placeholder for wiki overlay
2021-06-04 12:20:21 +09:00
Gagah Pangeran Rosfatiputra
b1b305c150
add method AddToc
2021-06-04 10:17:38 +07:00
Gagah Pangeran Rosfatiputra
7e78150144
add basic content wiki sidebar
2021-06-04 10:16:49 +07:00
Dean Herbert
eebd5745a8
Move full stop out of link and reword slightly
2021-06-04 11:44:43 +09:00
Gagah Pangeran Rosfatiputra
458910b744
use WikiArticlePage in WikiOverlay
2021-06-04 09:29:36 +07:00
Gagah Pangeran Rosfatiputra
791a9dd33a
add WikiArticlePage
2021-06-04 09:29:10 +07:00
Gagah Pangeran Rosfatiputra
beb0119dd5
initial wiki sidebar
2021-06-04 09:28:31 +07:00
Gagah Pangeran Rosfatiputra
905472a20b
make NewsSidebar extends OverlaySidebar
2021-06-04 00:12:29 +07:00
Gagah Pangeran Rosfatiputra
076e498a63
create abstract class OverlaySidebar
2021-06-04 00:12:13 +07:00
Gagah Pangeran Rosfatiputra
c5fc155cc0
Change text wording
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-06-03 20:37:27 +07:00
Gagah Pangeran Rosfatiputra
490ce0bbc5
load placeholder page when failed
2021-06-03 19:40:54 +07:00
Dean Herbert
e74fe68c96
Use new platform actions instead of hardcoded keys
2021-06-03 15:04:07 +09:00
Dean Herbert
a91015302e
Replace second usage of new function
2021-06-03 14:56:29 +09:00
Dean Herbert
4a5d8215f3
Merge branch 'master' into keyboard_shortcuts
2021-06-03 14:47:40 +09:00
Dean Herbert
dce24e3d4d
Merge pull request #12950 from gagahpangeran/osu-wiki-overlay
...
Initial implementation of Wiki Overlay
2021-06-01 15:20:56 +09:00
Dean Herbert
27b7039520
Use constant
2021-06-01 14:02:32 +09:00
Dean Herbert
6e4730652e
Push private methods down
2021-06-01 14:01:08 +09:00
Dean Herbert
3ff97f787a
Localise all URL generation for now to avoid weird Schedule
logic
2021-06-01 13:56:59 +09:00
Dean Herbert
06bd696cc2
Remove previous
consumption logic in GetWorkingBeatmap
...
This should not be required since the introduction of `workingCache`,
which does the same thing in a more global way.
2021-05-31 14:11:58 +09:00
Gagah Pangeran Rosfatiputra
113f90e92e
add back schedule is CurrentPath setter
2021-05-31 10:49:16 +07:00
Bartłomiej Dach
78213e09d4
Merge branch 'master' into editor-exit-stability
2021-05-30 23:03:50 +02:00
Gagah Pangeran Rosfatiputra
3c7f1ae996
Merge branch 'master' into osu-wiki-overlay
2021-05-30 20:27:12 +07:00
Dean Herbert
f35cf2d846
Merge branch 'master' into main-page-wiki
2021-05-30 21:01:05 +09:00
Dean Herbert
330d61862d
Add a mention of why StartHidden
is required
2021-05-28 14:41:01 +09:00
Dean Herbert
f1b5aced6f
Merge branch 'master' into editor-exit-stability
2021-05-28 14:32:32 +09:00
Gagah Pangeran Rosfatiputra
854ef0abfd
add simple bound check
2021-05-28 00:55:14 +07:00
Gagah Pangeran Rosfatiputra
ead0e92d7d
use select single node for blurb
2021-05-28 00:50:59 +07:00
Dan Balasescu
1ffafdd854
Merge branch 'master' into single-bind-reset-button
2021-05-27 23:55:28 +09:00
Dan Balasescu
cb850e07f7
Merge pull request #12963 from peppy/fix-settings-panel-hide-animation
...
Fix settings panel hide animation looking wrong when a sub-panel is visible when hidden
2021-05-27 23:55:00 +09:00
Gagah Pangeran Rosfatiputra
e1836cd1b2
add debug assert
2021-05-27 17:12:15 +07:00
Dean Herbert
aa23c4a4b9
Merge branch 'master' into keyboard_shortcuts
2021-05-27 16:30:34 +09:00
Gagah Pangeran Rosfatiputra
c72e258bfb
change for to while in create panels
2021-05-27 14:12:49 +07:00
Gagah Pangeran Rosfatiputra
4fbd43fcae
add inline comment for width 2
2021-05-27 13:24:06 +07:00
Dean Herbert
d66f07fccb
Move text and isFullWidth
parameters to constructor
2021-05-27 14:04:50 +09:00
Gagah Pangeran Rosfatiputra
a7865d3f22
move colour provider to BDL
2021-05-27 08:46:24 +07:00
Gagah Pangeran Rosfatiputra
649163e13b
Merge branch 'master' into main-page-wiki
2021-05-26 23:51:49 +07:00
Dean Herbert
f6dee13991
Merge pull request #12948 from gagahpangeran/markdown-wiki
...
Add wiki markdown container
2021-05-27 01:49:32 +09:00
Dean Herbert
735e7b9c74
Pass fetch more action in via ctor to avoid potential nullref
2021-05-26 22:49:39 +09:00
Dean Herbert
9947867e84
Remove unnecessary bindable flow
2021-05-26 22:46:43 +09:00
Dean Herbert
71de541245
Minor spacing / reformatting
2021-05-26 22:35:11 +09:00
Andrei Zavatski
1bde11a07e
Refactor ArticleListing
2021-05-26 15:35:38 +03:00
Gagah Pangeran Rosfatiputra
7546611c14
remove unused cached
2021-05-26 19:32:49 +07:00
Gagah Pangeran Rosfatiputra
2344a1a411
use image block in markdown container
2021-05-26 19:22:33 +07:00
Gagah Pangeran Rosfatiputra
62fb09774a
create WikiMarkdownImageBlock
2021-05-26 19:22:21 +07:00
Andrei Zavatski
82d977f80a
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-request
2021-05-26 14:52:42 +03:00
Dean Herbert
7ed4cbf7bf
Fix settings panel hide animation looking wrong when a sub-panel is visible when hidden
2021-05-26 19:25:05 +09:00
Dean Herbert
c05dfee220
Simplify default handling flow
2021-05-26 18:28:00 +09:00
Dean Herbert
7c9383b586
Combine RestorableKeyBindingRow
back into KeyBindingRow
2021-05-26 18:17:28 +09:00
Dean Herbert
02806fedb0
Add missing newline
2021-05-26 17:17:02 +09:00
Dean Herbert
17334fd2e6
Inline KeyBindingRow
construction
2021-05-26 17:12:12 +09:00
Gagah Pangeran Rosfatiputra
9c31b8856d
change image url replace implementation
2021-05-26 15:10:09 +07:00
Dean Herbert
49b4a6ea67
Replace local namespace qualifiers with using
2021-05-26 17:07:24 +09:00
Dean Herbert
f8a3a37797
Remove outdated comment
2021-05-26 17:01:47 +09:00
Gagah Pangeran Rosfatiputra
47cbbee4d1
remove CreateNotice method and move implementation to local
2021-05-26 15:01:16 +07:00
Dean Herbert
98fa5b67d6
Merge branch 'master' into single-bind-reset-button
2021-05-26 17:01:16 +09:00
Gagah Pangeran Rosfatiputra
eeb6647bc5
remove schedule in set current path
2021-05-26 14:59:36 +07:00
Dean Herbert
88bdd8a7b7
Update some out of date code pieces
2021-05-26 16:01:21 +09:00
Dean Herbert
52ca2f4797
Merge branch 'master' into chat-mention
2021-05-26 16:00:26 +09:00
Dean Herbert
e4780abdfd
Split out base
call from switch
statement
2021-05-26 14:43:59 +09:00
Dean Herbert
d165a75823
Inline request flow to make it easier to understand
2021-05-26 14:37:52 +09:00
Dean Herbert
0f21510b8b
Move code around
2021-05-26 14:29:46 +09:00
Dean Herbert
8ffa7f4a5a
Tidy up code
2021-05-26 14:28:20 +09:00
Dean Herbert
7b09955d59
Remove redundant default bindable value
2021-05-26 14:17:40 +09:00
Swords
07a24d2747
Fixing errors
2021-05-25 23:54:13 +10:00
Swords
9c2dca8229
Removing redundant argument list
2021-05-25 21:53:00 +10:00
Swords
d5feb8353d
Formatting, renaming
2021-05-25 21:37:08 +10:00
Swords
d9f5b578bf
Restore class names
2021-05-25 21:08:40 +10:00
Swords
ce845a9f8d
Apply the rest of requested changes
2021-05-25 21:00:38 +10:00
Dean Herbert
a249bb9e69
Merge branch 'master' into realm-key-binding-store
2021-05-25 17:18:33 +09:00
Gagah Pangeran Rosfatiputra
4c8f19af69
load empty page when fail
2021-05-25 14:47:39 +07:00
Dan Balasescu
774611f142
Merge pull request #12933 from peppy/fix-scroll-wheel-gameplay-bindings
...
Disallow using scroll wheel for gameplay bindings
2021-05-25 16:04:18 +09:00
Gagah Pangeran Rosfatiputra
9de07de467
move text flow container inside markdown container
2021-05-25 12:14:07 +07:00
Dean Herbert
9563b73ea6
Remove unnecessary using statement
2021-05-25 14:14:00 +09:00
Dean Herbert
df703b68ec
Merge branch 'master' into realm-key-binding-store
2021-05-25 13:41:48 +09:00
Dean Herbert
37f6ceef79
Add test coverage
2021-05-24 21:57:04 +09:00
Dean Herbert
62b6cadb64
Ensure settings rows cannot set an invalid value in the first place
2021-05-24 21:56:41 +09:00
Swords
518999ffab
Renaming files
2021-05-24 22:49:40 +10:00
Swords
441e4e7d56
Formatting
2021-05-24 22:08:34 +10:00
Swords
ca1d1c58ab
RestoreDefaultValueButton implements OsuButton
2021-05-24 21:34:47 +10:00
Dean Herbert
65c3c0d53f
Merge branch 'master' into localisation-proof-of-concept
2021-05-24 17:10:56 +09:00
Dean Herbert
29e1737f0d
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-24 15:51:03 +09:00
Andrei Zavatski
06fe0563d3
Move GetNewsRequest from ArticleListing to NewsOverlay
2021-05-24 08:26:44 +03:00
Gagah Pangeran Rosfatiputra
222c34c0a1
fix heading font weight to light
2021-05-23 21:46:41 +07:00
Gagah Pangeran Rosfatiputra
bd1454bdd1
update height to max of its parent height
2021-05-23 21:42:58 +07:00
Gagah Pangeran Rosfatiputra
24960c4fb8
move panel spacing to ctor
2021-05-23 21:31:49 +07:00
Gagah Pangeran Rosfatiputra
10c4ba3a74
add panels to grid content
2021-05-23 19:07:22 +07:00
Gagah Pangeran Rosfatiputra
24fef221e3
change createPanels method to create grid content
2021-05-23 19:07:10 +07:00
Gagah Pangeran Rosfatiputra
8389d90f7e
add GridContainer in wiki main page
2021-05-23 18:52:20 +07:00
Gagah Pangeran Rosfatiputra
4068881096
add bottom margin for paragraph
2021-05-23 18:11:54 +07:00
Gagah Pangeran Rosfatiputra
cd211de729
make panel text bold
2021-05-23 18:10:56 +07:00
Gagah Pangeran Rosfatiputra
512d6d2f7f
centering link inside panel
2021-05-23 18:09:09 +07:00
Gagah Pangeran Rosfatiputra
1e5f34567a
add panel heading main page
2021-05-23 18:07:27 +07:00
Gagah Pangeran Rosfatiputra
365a0b25f2
add IsFullWidth
2021-05-23 18:03:38 +07:00
Gagah Pangeran Rosfatiputra
4d222467cc
initial WikiPanelMarkdownContainer
2021-05-23 18:00:54 +07:00
Gagah Pangeran Rosfatiputra
d9e898a2ee
extract WikiPanelContainer
2021-05-23 17:56:27 +07:00
Gagah Pangeran Rosfatiputra
4a543c2557
add simple panels
2021-05-23 17:49:26 +07:00
Dean Herbert
b13a68592f
Merge branch 'master' into localisation-proof-of-concept
2021-05-22 17:07:23 +09:00
Dean Herbert
df426b9334
Merge pull request #12852 from timiimit/multi-larger-freemod-overlay
...
Make freemod selection overlay taller in multiplayer room
2021-05-21 18:45:15 +09:00
Dean Herbert
b0a113a36b
Merge branch 'master' into localisation-proof-of-concept
2021-05-21 17:57:54 +09:00
Dean Herbert
abc96057b2
Remove relative height specification and use constant height
2021-05-21 17:55:46 +09:00
Dean Herbert
2958b9adf4
Merge branch 'master' into import-from-stable-select-location
2021-05-21 17:37:34 +09:00
Dean Herbert
1c560a9490
Merge pull request #12869 from EVAST9919/sidebar
...
Add sidebar to news overlay
2021-05-21 16:21:18 +09:00
Dean Herbert
fbe4d7e03c
Improve code quality around cursor and upwards passing of response data
2021-05-21 15:41:31 +09:00
Gagah Pangeran Rosfatiputra
216b87691c
add blurb
2021-05-21 10:04:45 +07:00
Gagah Pangeran Rosfatiputra
49aa0f3a18
initial main page
2021-05-21 10:04:45 +07:00
Gagah Pangeran Rosfatiputra
236124496d
add missing accent colour in control tab item
2021-05-21 01:21:32 +07:00
Andrei Zavatski
40ca94cd7b
Fix incorrect year being passed on first load
2021-05-20 16:04:51 +03:00
Andrei Zavatski
c48b5eebdd
Don't reload the context when clicking selected year button
2021-05-20 15:45:39 +03:00
Andrei Zavatski
bd80cf656a
Merge remote-tracking branch 'refs/remotes/ppy/master' into sidebar
2021-05-20 15:41:08 +03:00
Gagah Pangeran Rosfatiputra
6257504bb6
add padding spacing
2021-05-25 14:37:14 +07:00
Gagah Pangeran Rosfatiputra
ae0949fc14
add main page in wiki overlay
2021-05-25 14:20:04 +07:00
Gagah Pangeran Rosfatiputra
9c824ece1b
handle page change when clicking breadcrumb
2021-05-20 14:00:22 +07:00
Gagah Pangeran Rosfatiputra
1578b0462d
add showParentPage method
2021-05-20 13:58:17 +07:00
smoogipoo
6beeb7f7c4
Rename SpectatorStreamingClient -> SpectatorClient
2021-05-20 15:55:07 +09:00
Dean Herbert
958d51141d
Rename FrontPageDisplay
to ArticleListing
2021-05-20 15:24:01 +09:00
Dean Herbert
9267d23dc2
Make year nullable rather than defaulting to zero
2021-05-20 15:23:49 +09:00
Dean Herbert
d4530313aa
Tidy event parameter naming
2021-05-20 15:15:46 +09:00
Dean Herbert
489caebf59
Move bind LoadComplete
code out of constructor
2021-05-20 15:15:19 +09:00
Dean Herbert
673ca4c2a1
Tidy up content container specification
2021-05-20 14:30:40 +09:00
Dean Herbert
ac8efdeabd
Move private methods down
2021-05-20 14:12:34 +09:00
Dean Herbert
713f69ea55
Tidy up load process
2021-05-20 14:11:42 +09:00
Dean Herbert
80a714a9c4
Merge pull request #12857 from Joehuu/dev-register-no-warning
...
Don't show warning screen when registering on dev server
2021-05-20 14:05:53 +09:00
Dean Herbert
3c201fb8e7
Standardise canBeNull
specification
2021-05-20 13:20:35 +09:00
Joseph Madamba
3da2cdfd05
Fix nullref in test
2021-05-19 14:06:21 -07:00
Gagah Pangeran Rosfatiputra
bc1cad0963
change header breadcrumb when page change
2021-05-20 00:28:26 +07:00
Dean Herbert
363aec8179
Merge branch 'master' into hit-error-skinnable
2021-05-20 01:51:45 +09:00
Andrei Zavatski
d60478851f
Add proper action to YearButton
2021-05-19 15:38:53 +03:00
Andrei Zavatski
e3ed9b8135
Implement sidebar metadata handling in NewsOverlay
2021-05-19 15:36:05 +03:00
Andrei Zavatski
6cc4ffadab
Implement sticky container for sidebar in NewsOverlay
2021-05-19 15:28:12 +03:00
Andrei Zavatski
150ed01c62
Make NewsSidebar scrollable
2021-05-19 15:22:55 +03:00
Andrei Zavatski
16ffedde8a
Add year parameter to GetNewsRequest
2021-05-19 15:17:57 +03:00
Dean Herbert
fc5987bf69
Refactor DialogOverlay
logic to avoid dismissal potentially being unhandled
2021-05-19 16:52:34 +09:00
Dean Herbert
124ac689b8
Add method to PopupDialog
to press the first OK button
2021-05-19 16:51:54 +09:00
Dean Herbert
19a07b0107
IsOpen -> Expanded
2021-05-19 15:49:22 +09:00
Dean Herbert
539e5179fe
Tidy up content and bind event code
2021-05-19 15:49:22 +09:00
Joseph Madamba
4cc573690e
Move OsuGame out of load method
2021-05-18 14:32:56 -07:00
Joseph Madamba
bde7f88eb3
Don't show warning screen when registering on dev server
2021-05-18 14:23:22 -07:00
Andrei Zavatski
d70d37b7f4
Remove convoluted autosize logic in MonthSection
2021-05-18 22:30:36 +03:00
Dean Herbert
5acb708939
Remove customisation of hit error via standard settings
2021-05-18 15:50:50 +09:00
Dean Herbert
0100b88a86
Move private methods down
2021-05-18 14:12:27 +09:00
Dean Herbert
3a5b21c0f5
Update "reset all bindings" button to better match new key binding row widths
2021-05-18 13:47:39 +09:00
Dean Herbert
c71d53a0f9
Fix text and button layout
2021-05-18 13:40:26 +09:00
Bartłomiej Dach
0e91a00a7e
Revert to previous width spec instead of size
2021-05-17 21:18:45 +02:00
Bartłomiej Dach
ef114f2407
Simplify bindable flow in KeyBindingRow
2021-05-17 21:10:05 +02:00
Bartłomiej Dach
30d7768971
Remove now-redundant null check
2021-05-17 20:47:56 +02:00
Bartłomiej Dach
33fe843ba9
Move value change bindings to LoadComplete()
...
Also removes a redundant one from the setter of `Current`. If the set to
current comes with an associated value change, the bind-unbind flow that
`BindableWithCurrent` implements will handle that change anyway.
2021-05-17 20:46:30 +02:00
Lucas A
e2018f81f3
Use equality check for nullable types.
2021-05-17 19:54:21 +02:00
Bartłomiej Dach
d614a47614
Rename variable to better explain purpose
2021-05-17 18:54:17 +02:00
Bartłomiej Dach
7befcf74ff
Split value change callbacks out to separate methods
2021-05-17 18:53:09 +02:00
Lucas A
5ca4fd5ab4
Block overlays to prevent getting into a bad state.
2021-05-17 13:28:59 +02:00
Lucas A
a38fc1a2e0
Override text header.
2021-05-17 13:04:49 +02:00
Lucas A
db255e6814
Mark StableImportManager as potentially null in tests.
...
(StableImportManager is added to the DI in OsuGame and not in the OsuGameBase)
2021-05-17 12:55:59 +02:00
Lucas A
bec06cfac7
Reword StableDirectoryLocationDialog
header
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-05-17 12:55:58 +02:00
Lucas A
f60dbbfbbd
Reword import dialogs.
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-17 12:55:58 +02:00
Lucas A
e15e8068d3
Reword StableDirectoryLocationDialog.
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-17 12:55:58 +02:00
Lucas A
dabe8bd4c7
Fix code inspections and remove now unused code.
2021-05-17 12:55:58 +02:00
Lucas A
481b0a0125
Add StableDirectoryLocationDialog
2021-05-17 12:55:57 +02:00
Lucas A
851e33fd15
Hook up StableImportManager.
2021-05-17 12:55:57 +02:00
Lucas A
5d5b1e1f0e
Add StableImportManager
2021-05-17 12:55:56 +02:00
Andrei Zavatski
555e3e2db3
Delete NewsSideBar.cs
2021-05-17 12:02:33 +03:00
Andrei Zavatski
01090de1fd
Fix filenames does not match contained type
2021-05-17 11:55:55 +03:00
Andrei Zavatski
586c5c7365
Emulate year changes in the test scene
2021-05-17 11:36:53 +03:00
Andrei Zavatski
ab16c32bb1
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-17 11:36:41 +03:00
Dan Balasescu
d75ef160e8
Merge branch 'master' into directory-select-screen
2021-05-17 17:22:03 +09:00
Andrei Zavatski
c0cfbd11dd
Add tooltip and action for PostButton in MonthSection
2021-05-17 11:20:31 +03:00
Andrei Zavatski
5059bfaef9
Use FillFlowContainer in YearsPanel
2021-05-17 11:17:02 +03:00
Andrei Zavatski
e754d2e590
Simplify YearButton
2021-05-17 10:54:45 +03:00
Dean Herbert
baa4089364
Expose method to adjust header text, not whole drawable
2021-05-17 16:41:46 +09:00
Dean Herbert
abeeda5d04
Rewrite YearsPanel
to not be insanely long
2021-05-17 16:24:56 +09:00
Dean Herbert
032f60819d
Rename content container
2021-05-17 16:11:46 +09:00
Dean Herbert
22561cda19
MonthDropdown -> MonthSection
2021-05-17 16:02:21 +09:00
Dean Herbert
50e2b5a327
SideBar -> Sidebar
2021-05-17 16:00:36 +09:00
Gagah Pangeran Rosfatiputra
463774d4f2
add ShowPage method in WikiOverlay
2021-05-19 19:12:16 +07:00
Swords
90f00a7663
Fixes ResotreDefaultValue to use the BindableWithCurrent correctly
2021-05-16 15:01:19 +10:00
Swords
264d8b9b86
Finishing requested changes, and tidy up
2021-05-16 14:48:00 +10:00
Andrei Zavatski
3e1b1c6c3e
Improve statement readability
2021-05-15 19:14:58 +03:00
Andrei Zavatski
e479db9186
Clear transforms in PostsContainer for all children
2021-05-15 19:14:02 +03:00
Swords
50d5af9662
Removed unused method
2021-05-15 12:05:22 +10:00
Swords
d988194dd3
Formatting
2021-05-15 11:40:42 +10:00
Swords
d85f17159f
Formatting
2021-05-15 11:25:56 +10:00
Swords
304caf8bdf
Adding Requested changed
2021-05-15 11:24:08 +10:00
Swords
843da30f9d
Reformatting
2021-05-15 01:52:16 +10:00
Swords
6a52622b3f
Merge branch 'single-bind-reset-button' of https://github.com/holaswords/osu into single-bind-reset-button
2021-05-15 01:31:40 +10:00
Swords
1603b92211
Reformatting
2021-05-15 01:30:54 +10:00
Swords
85174793b1
Merge branch 'master' into single-bind-reset-button
2021-05-15 01:07:32 +10:00
Swords
753bdf2083
Fixed formatting
2021-05-15 01:04:15 +10:00
Swords
0725088fde
Well it works, just pretty ugly looking.
2021-05-15 01:01:17 +10:00
Lucas A
6f248db519
Merge conditional expression.
2021-05-13 19:31:10 +02:00
Lucas A
0caba57945
Make screen properties local to MigrationSelectScreen.
2021-05-13 19:28:23 +02:00
Lucas A
09a5b9c872
Add XMLDoc to protected members.
2021-05-13 16:28:03 +02:00
Andrei Zavatski
38c0ba2d10
Implement current year highlight in YearsPanel
2021-05-13 16:16:19 +03:00
Andrei Zavatski
94543bf000
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-13 16:00:46 +03:00
Lucas A
eee3cd7c57
Disallow selecting storage root as a valid directory.
2021-05-13 11:14:05 +02:00
Lucas A
d3cc418961
Privatize DirectorySelector.
2021-05-13 11:08:04 +02:00
Lucas A
4bb0e6b7d5
Create InitialPath property.
2021-05-13 11:07:52 +02:00
Lucas A
9a061ad80b
Extract directory selection logic of migration screen to DirectorySelectScreen.
2021-05-13 11:07:26 +02:00
Andrei Zavatski
315a2b8314
Refactor MonthDropdown to decouple autosized logic
2021-05-12 20:50:20 +03:00
Andrei Zavatski
20a6903a40
Use GridContainer to distribute buttons in YearsPanel
2021-05-11 23:43:01 +03:00
Andrei Zavatski
f4801c08ff
Refactor MonthDropdown to ensure all the posts are within a given month
2021-05-11 22:34:01 +03:00
Andrei Zavatski
b0297c6324
Fix incorrect no posts handling and add corresponding test
2021-05-11 20:52:11 +03:00
Andrei Zavatski
c2ba16f977
Use relative sizing for MonthDropdown
2021-05-11 16:51:59 +03:00
Andrei Zavatski
1c0b0996cf
Rename DropdownButton to DropdownHeader
2021-05-11 16:42:18 +03:00
Andrei Zavatski
208224cc0d
CI fixes
2021-05-11 16:08:09 +03:00
Andrei Zavatski
01f5c77dac
Add better comments explaining empty actions
2021-05-11 15:56:50 +03:00
Andrei Zavatski
705aad262a
Rename MonthPanel to MonthDropdown
2021-05-11 15:42:40 +03:00
Andrei Zavatski
0a9c3c9413
Move metadata change logic to it's own method
2021-05-11 15:39:50 +03:00
Andrei Zavatski
9603712aa1
Cache metadata in NewsSideBar
2021-05-11 15:33:27 +03:00
Andrei Zavatski
e736240a06
Use lookup instead of dictionary to distribute posts
2021-05-11 15:12:04 +03:00
Andrei Zavatski
711e7ba860
Apply suggestions for MonthPanel
2021-05-11 14:43:23 +03:00
Andrei Zavatski
69f01e82db
Add bottom padding for NewsSideBar content
2021-05-11 14:42:56 +03:00
Andrei Zavatski
82436334b2
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-11 13:52:51 +03:00
Dean Herbert
1bb3c609ae
Centralise implementation of cancel button logic
2021-05-11 18:39:14 +09:00
Andrei Zavatski
220eef0351
Remove overcomplicated date logic in MonthPanel
2021-05-10 17:00:18 +03:00
Andrei Zavatski
0d243be457
CI fixes
2021-05-10 10:07:43 +03:00
Andrei Zavatski
4b97224932
Implement NewsSideBar component
2021-05-10 09:53:52 +03:00
Andrei Zavatski
7971a2ef48
Implement MonthPanel component
2021-05-10 08:47:00 +03:00
smoogipoo
332cb74cad
Fix toolbar queuing ruleset sounds
2021-05-10 13:58:13 +09:00
Andrei Zavatski
7ca3e13712
Implement basic years panel
2021-05-10 07:43:01 +03:00
Susko3
ab6239fd5f
change math for displaying volume "MAX"
2021-05-10 00:51:58 +02:00
Ibby
075350e125
Adding a reset button to individual keybinds
2021-05-09 15:51:17 +10:00
Andrei Zavatski
dde9fd28e6
Hide ShowMore button if there's nothing to load
2021-05-09 04:57:24 +03:00
smoogipoo
cd25d76dbe
Merge branch 'master' into localisation-proof-of-concept
2021-05-08 18:11:07 +09:00
Dean Herbert
165f443ab5
Merge branch 'master' into add-missing-author-links
2021-05-07 14:32:44 +09:00
Dean Herbert
48b834d12a
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-07 13:19:17 +09:00
Salman Ahmed
283488ea53
Use TransformImmediately
instead at beatmap listing search control
...
Applies two changes:
- Use `TransformImmediately` which achieves the same wanted transition behaviour without any issues.
- Move the transition behaviour override into `BeatmapListingSearchControl` in a nested subclass of `UpdateableBeatmapSetCover`.
2021-05-07 03:36:32 +03:00
Joseph Madamba
d4658c609b
Fix warning text of bg source setting not being updated when user with supporter signs in/out
2021-05-05 22:54:35 -07:00
Dean Herbert
08a45e9fc2
Remove dead code
2021-05-05 16:26:41 +09:00
Dean Herbert
19ffcd00c2
Initialise warning text flow lazily as most items will not use it
2021-05-05 16:26:41 +09:00
Dean Herbert
1288f69fad
Rename to WarningText
2021-05-05 16:16:49 +09:00
Dean Herbert
6178f38c95
Reword unlimited frame rate warning a bit
2021-05-05 16:15:06 +09:00
Joseph Madamba
23b9d8c260
Fix alpha not being zero when string is set to empty and use inequality on supporter condition
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-05-04 14:02:12 -07:00
Joseph Madamba
a584213002
Use vertical padding instead of relative height for default button
2021-05-04 09:32:38 -07:00
Joseph Madamba
0a64922738
Add supporter note to background source setting
2021-05-04 01:15:59 -07:00
Joseph Madamba
796bd8e47e
Add existing setting notes from stable
2021-05-04 01:15:59 -07:00
Joseph Madamba
acc9258eb2
Implement notes for settings
2021-05-04 01:15:59 -07:00
Bartłomiej Dach
f52375eed2
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-03 15:58:13 +02:00
Joseph Madamba
cc056088bd
Update profile subsections to use counters instead of missing text in line with web
2021-05-02 14:44:20 -07:00
Joseph Madamba
3e74d61dab
Add best count from api
2021-05-02 13:33:25 -07:00
Joseph Madamba
59cb5f4679
Get recent count from api instead
2021-05-02 13:33:25 -07:00
Gagah Pangeran Rosfatiputra
b78ec8307d
add markdown paragraph with image block
2021-05-02 22:22:22 +07:00
Gagah Pangeran Rosfatiputra
ef707bd099
add WikiMarkdownImage
2021-05-02 22:02:06 +07:00
Gagah Pangeran Rosfatiputra
7a8a37f4a0
load notice box
2021-05-21 16:08:30 +07:00
Gagah Pangeran Rosfatiputra
e23ea00197
add notice box
2021-05-21 16:06:43 +07:00
Gagah Pangeran Rosfatiputra
b3eff65a0c
parse isOutdated and needsCleanup
2021-05-21 16:05:37 +07:00
Gagah Pangeran Rosfatiputra
292f314fee
initial wiki notice container
2021-05-21 16:04:08 +07:00
Gagah Pangeran Rosfatiputra
ce8b2c1e37
add WikiMarkdownContainer
2021-05-17 01:08:02 +07:00
Dean Herbert
2e24b69d62
Merge pull request #12617 from Joehuu/fix-pp-column-approved-maps
...
Fix approved maps not displaying pp column on score table
2021-05-02 13:27:39 +09:00
Joseph Madamba
137be5dc97
Use equality operator instead of null coalescing
...
Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>
2021-05-01 14:14:07 -07:00
Joseph Madamba
786ab163f6
Rename extension and move to bottom of file
2021-04-30 12:40:16 -07:00
Dean Herbert
eeb66a955e
Merge branch 'master' into mbd-beatmap-set-cover
2021-04-30 08:14:33 +09:00
Joseph Madamba
9952a5bfdb
Revert "Fix button being recreated on importing state"
...
This reverts commit c9967f7b74
.
2021-04-29 14:24:29 -07:00
Joseph Madamba
cfbf95b433
Add HasPerformancePoints extension method
2021-04-29 14:11:35 -07:00
Joseph Madamba
243605728d
Fix approved maps not displaying pp column on score table
2021-04-28 11:44:05 -07:00
Dean Herbert
61f3cc9bc2
Fix update method not switched across to using Guid
2021-04-26 17:10:28 +09:00
Joseph Madamba
c9967f7b74
Fix button being recreated on importing state
2021-04-24 08:37:37 -07:00
Joseph Madamba
46c44c576d
Fix beatmap info download button content not scaling on mouse down
2021-04-24 08:23:27 -07:00
Dean Herbert
c0b1c2f39b
Merge branch 'master' into realm-key-binding-store
2021-04-24 02:40:15 +09:00
Gagah Pangeran Rosfatiputra
004cd7c834
add wiki button in main toolbar
2021-04-22 16:16:12 +07:00
Gagah Pangeran Rosfatiputra
25f2c582e7
add ToolbarWikiButton
2021-04-22 16:15:20 +07:00
Jamie Taylor
21f34be19f
Add support for per-ruleset sample playback when switching rulesets (via toolbar)
2021-04-22 14:43:36 +09:00
Dean Herbert
78f274d51a
Merge branch 'master' into realm-key-binding-store
2021-04-22 12:13:23 +09:00
Gagah Pangeran Rosfatiputra
f6a088e699
add request logic in wiki overlay
2021-05-19 19:09:03 +07:00
Dean Herbert
ab2a8b5c89
Fix initial rotation not being set
2021-04-21 16:12:09 +09:00
Dean Herbert
eb20865c02
Show tablet preview with physical tablet counter-rotated for supplied user area selection
...
Closes https://github.com/ppy/osu/issues/12399 .
Rotation animation is intentionally delayed slightly to give a better sense of what is going on (or maybe just look cool).
2021-04-21 15:55:15 +09:00
Dean Herbert
31c8586dac
Add localisation support to overlay header title/description
2021-04-21 14:37:29 +09:00
Dean Herbert
7fc450c620
Fix mod settings blocking input outside its visible area
...
Closes #12502 .
2021-04-20 23:42:56 +09:00
Gagah Pangeran Rosfatiputra
460d656a0e
initial wiki overlay
2021-04-21 16:21:07 +07:00
Dean Herbert
60acd824cb
Add two sample implementations
2021-04-20 17:30:40 +09:00
Dean Herbert
623eae1576
Add basic language switching ability
2021-04-20 17:06:01 +09:00
Denrage
eb977312ed
Added Author link in BeatmapSet Overlay
2021-04-19 16:54:29 +02:00
Gagah Pangeran Rosfatiputra
5117c51105
initial wiki header
2021-04-19 16:24:47 +07:00
Dean Herbert
af79ad537c
Avoid unnecessary debounce triggers on zero-delta scrolls
2021-04-19 00:05:44 +09:00
Dean Herbert
e63edf5b49
Fix volume control displaying on non-vertical scroll events
...
Closes #12475 .
2021-04-19 00:05:44 +09:00
smoogipoo
6f3158e8c8
Increase multiplier to 1.8
2021-04-15 23:24:13 +09:00
smoogipoo
cc84ffe228
Merge branch 'master' into volume-control-acceleration
2021-04-15 23:23:23 +09:00
Dean Herbert
8282f38eb7
Fix volume controls not supporting key repeat
2021-04-14 13:11:24 +09:00
Dean Herbert
89ce8f290f
Add simple acceleration to volume metre adjustments
2021-04-14 12:55:06 +09:00
Salman Ahmed
9f8af03a70
Remove irrelevant change
2021-04-13 09:28:58 +03:00
Salman Ahmed
a664efe12b
Fix history graph tooltips leaking to others
...
Since there was no check about which tooltip content came from which graph, all history graphs use the "Replays Watched" tooltip, as it is the latest created one.
2021-04-13 07:59:14 +03:00
Salman Ahmed
8f84abf348
Display "replays watched" tooltip for replays subsection
2021-04-12 21:51:06 +03:00
smoogipoo
8293b06c0a
Remove obsolete code
2021-04-09 13:56:58 +09:00
Dean Herbert
afc745f999
Merge branch 'master' into rebind-song-select
2021-04-07 17:13:25 +09:00
Dean Herbert
38e95a0e73
Merge branch 'master' into fix-overzealousmouse-button-blocking
2021-04-05 22:07:41 +09:00
Dean Herbert
cc9db90d11
Extract common implementation into private method
2021-04-03 18:58:25 +09:00
Dean Herbert
eb1e850f99
Merge pull request #12254 from smoogipoo/spectator-refactor
...
Move frame-handling spectator logic into abstract base class
2021-04-03 17:23:33 +09:00
PercyDan54
bd7da9eb39
Make beatmap title use unicode
2021-04-03 12:43:17 +08:00
smoogipoo
9e95441aa6
Rename Spectator -> SoloSpectator
2021-04-01 22:08:52 +09:00
Dean Herbert
321ad737b6
Merge branch 'master' into realm-migration-operation-blocking
2021-03-30 22:40:08 +09:00
Dean Herbert
a2f50af424
Fix fall-through scroll redirection
2021-03-30 19:42:40 +09:00
Dean Herbert
491e583819
Merge branch 'master' into realm-migration-operation-blocking
2021-03-30 13:25:40 +09:00
Dean Herbert
015cf5f7eb
Fix tests using wrong ID lookup type
2021-03-30 13:22:48 +09:00
Dean Herbert
1dfd08eded
Add tablet rotation configuration
2021-03-30 13:01:48 +09:00
Dean Herbert
8dfff999f9
Add rotation slider
2021-03-30 12:40:50 +09:00
Dean Herbert
8a0fcf20ed
Move offset settings up for more logical ordering
2021-03-30 12:32:42 +09:00
Dean Herbert
699a317b44
Fix chat scroll sticking visually when scrolling beyond bottom extent
2021-03-29 18:07:47 +09:00
Dean Herbert
f8cea5cae3
Merge branch 'master' into realm-migration-operation-blocking
2021-03-26 17:07:31 +09:00
Max Hübner
aa2c1ee85e
Add new beatmap search filter row "General"
2021-03-25 23:20:10 +01:00
Joehu
16b3f22caf
Fix incorrect trash icon being used on deleted comments counter
2021-03-22 19:32:17 -07:00
Joehu
9bc6cdf042
Fix singular format regression on forum post text
2021-03-21 11:19:07 -07:00
Joehu
e31d583a7f
Add comments count to user profile overlay
2021-03-21 11:16:59 -07:00
Bartłomiej Dach
86b569f5f7
Fix typo in identifier
2021-03-20 12:37:51 +01:00
Bartłomiej Dach
d28bed6ed2
Schedule adding transforms on tablet changes
...
Fixes `InvalidThreadForMutationException`s that pop up when
disconnecting/reconnecting tablets during the game's operation. In those
cases the value change callback executes from an OpenTabletDriver
thread.
2021-03-20 12:37:48 +01:00
Dean Herbert
03592fa696
Merge branch 'master' into realm-migration-operation-blocking
2021-03-19 21:33:26 +09:00
Dean Herbert
63cbac3bd0
Ensure aspect ratio slider gets an initial value
2021-03-19 20:15:29 +09:00
Dean Herbert
6f32c302eb
Add checkbox to optionally disable tablet handling
2021-03-19 20:13:51 +09:00
Dean Herbert
86b229b1c9
Increase maximum usable aspect ratio to account for ultrawide monitors
2021-03-19 20:05:18 +09:00
Dean Herbert
fefb007805
Remove no longer relevant comment
2021-03-19 19:01:32 +09:00
Dean Herbert
1e82033c84
Move bindings to LoadComplete to avoid cross-thread issues
2021-03-19 19:01:32 +09:00
Dean Herbert
c624aa9397
Only update tablet values on commit
2021-03-19 19:01:32 +09:00
Dean Herbert
6285dcd1a1
Add arbitrary value to fix FP contains check failures
2021-03-19 19:01:32 +09:00
Dean Herbert
e8c20bdcb1
Add centre crosshair
2021-03-19 19:01:32 +09:00
Dean Herbert
fb7d095e4a
Show aspect ratio for current usable area
2021-03-19 19:01:32 +09:00
Dean Herbert
196f95ae54
Update to use new bindables and centered area offset
2021-03-19 19:01:32 +09:00
Dean Herbert
9d0c8902a6
Fix margins and spacing between sub flowed items
2021-03-19 19:01:32 +09:00
Dean Herbert
d422a65900
Fix initial tablet size not being initialised
2021-03-19 19:01:32 +09:00
Dean Herbert
9a6a0f3df5
Add test coverage and better UI handling of no tablet connected scenario
2021-03-19 19:01:32 +09:00
Dean Herbert
bba25a0182
Tidy up draw hierarchy and bindable logic
2021-03-19 19:01:31 +09:00
Dean Herbert
932745e5c4
Fix remaining feedback loops
2021-03-19 19:01:31 +09:00
Dean Herbert
e3bed4c97d
Simplify aspect ratio application, add window conforming and direct adjustment
2021-03-19 19:01:31 +09:00
Dean Herbert
43359553c1
Add aspect ratio display and limiting
2021-03-19 19:01:31 +09:00
Dean Herbert
9b70f0ee1f
Tidy up visual appearance of settings and add a reset button
2021-03-19 19:01:31 +09:00
Dean Herbert
2dc2cb04c3
Fix bounds check becoming false when using full area
2021-03-19 19:01:31 +09:00
Dean Herbert
382109c7a2
Make test scene feel more like settings (width-wise)
2021-03-19 19:01:31 +09:00
Dean Herbert
464702182d
Consume device name
2021-03-19 19:01:31 +09:00
Dean Herbert
94f184d113
Add feedback when area extends beyond tablet size
2021-03-19 19:01:31 +09:00
Dean Herbert
0a6525baee
Fix slider bars reloading each time the tablet size is changed
2021-03-19 19:01:31 +09:00
Dean Herbert
926e40925e
Add exclude rule to fix dynamic compilations issues with settings sections
2021-03-19 19:01:31 +09:00
Dean Herbert
3b7edf1333
Make tablet display always fit to size of settings area
2021-03-19 19:01:31 +09:00
Dean Herbert
d026c8da85
Initial pass of configuration interface
2021-03-19 19:01:31 +09:00
Dan Balasescu
d9ec3c327e
Merge branch 'master' into input-handler-configuration
2021-03-18 22:17:48 +09:00
Dean Herbert
a8cc3a3b44
Implement enable state changes locally for InputHandlers which should be toggleable
2021-03-18 21:17:04 +09:00
Bartłomiej Dach
f95ce90c95
Adjust kudosu count formatting
2021-03-17 23:32:08 +01:00
Joehu
08ffe425f9
Update kudosu description color in line with web
2021-03-17 14:46:23 -07:00
Joehu
599c55fca5
Update total kudosu earned description text in line with web
2021-03-17 13:22:00 -07:00
Joehu
6cea74f0fa
Remove available kudosu section from user profile overlay in line with web
2021-03-17 13:21:41 -07:00
Dean Herbert
fccd495f27
Remove obsoleted setting for now
2021-03-17 18:07:51 +09:00
Dean Herbert
249ab8ab3d
Merge branch 'master' into input-handler-configuration
2021-03-17 18:05:14 +09:00
Joehu
393f1fbd3f
Remove skype
2021-03-15 10:07:50 -07:00
Bartłomiej Dach
6438a7ee12
Merge branch 'master' into user-hide-toolbar-forever
2021-03-13 17:31:37 +01:00
Dean Herbert
a227b0a581
Build on xmldoc with rationale
2021-03-13 23:29:47 +09:00
Dean Herbert
e70ba2d005
Remove unnecessary second variable
2021-03-13 23:29:01 +09:00
Dean Herbert
4afbccfcff
Fix initial operation potentially running before DI is completed
2021-03-13 19:30:40 +09:00
Dean Herbert
b13f193c8d
Fix incorrect task being returned for changelog continuations
2021-03-13 19:26:38 +09:00
Joehu
0ba5312a40
Move blocking show logic to UpdateState
2021-03-13 00:05:26 -08:00
Joehu
5999e4ba33
Add xmldoc for hiddenbyuser bool
2021-03-12 20:18:32 -08:00
Joehu
62f2a823f6
Hide toolbar forever when the user hides it
2021-03-12 15:48:50 -08:00
Joehu
6c0734a09f
Handle global action in toolbar instead of osugame
2021-03-12 15:48:49 -08:00
Dean Herbert
3458dcc33a
Use whitelist to avoid exposing settings to user that shouldn't be
2021-03-12 18:40:38 +09:00
Dean Herbert
03230edcb1
Update bindings settings to handle the new structure and show all handlers
2021-03-12 18:38:16 +09:00
Dean Herbert
3c21c83cc8
Rename KeyboardSection to BindingSection
2021-03-12 18:36:28 +09:00
Dean Herbert
e7707eee94
Switch RestoreDefaultsValueButton to use HasPendingTasks to avoid tooltip always showing
2021-03-12 15:23:11 +09:00
Dean Herbert
b1cd01ceb8
Apply ConfigureAwait changes to game side
2021-03-08 14:36:35 +09:00
Dean Herbert
2b1ab3576b
Merge branch 'master' into migrate-country-rank
2021-03-08 11:07:25 +09:00
Salman Ahmed
132fcda089
Force config sensitivity value to local setting bindable
...
Re-enable the local bindable to update the sensitivity value then change back to whatever state it was in previously.
2021-03-04 17:00:44 +03:00
Dan Balasescu
6d4391de15
Merge pull request #11957 from peppy/move-mouse-settings-load-complete
...
Move bindable logic in MouseSettings to LoadComplete
2021-03-03 22:43:24 +09:00
Dean Herbert
534e16237a
Remove unnecessary intial construction of bindable
2021-03-03 20:36:41 +09:00
Dean Herbert
0f5bce70ad
Split confirmation dialog classes apart
2021-03-03 20:34:37 +09:00
Dean Herbert
002646370c
Move bindable logic in MouseSettings to LoadComplete
2021-03-03 16:47:42 +09:00
Dean Herbert
7dce9b04fa
Add a more basic ConfirmDialog implementation
2021-03-03 14:50:45 +09:00
Bartłomiej Dach
3b125a26a8
Add test coverage
2021-03-02 19:21:03 +01:00
Bartłomiej Dach
40a28367c6
Fix restore-to-default buttons never showing if initially hidden
2021-03-02 18:50:33 +01:00
Dean Herbert
6372a0265a
Fix confine mode dropdown becoming visible again after filtering
...
Changes from a hidden to a disabled state, with a tooltip explaining
why.
Closes #11851 .
2021-03-02 17:44:58 +09:00
Salman Ahmed
2609b22d53
Replace usage of CurrentModeRank
in line with API change
2021-03-01 23:07:25 +03:00
Bartłomiej Dach
52e81385a6
Fix restore default button mutating transforms during load
2021-02-27 11:39:18 +01:00
Dean Herbert
3e65dfb9e7
Reduce allocation overhead when notification overlay has visible notifications
2021-02-26 17:11:47 +09:00
Dean Herbert
8004652d27
Merge branch 'master' into optimised-has-flag-checks
2021-02-25 21:24:39 +09:00
Dean Herbert
90e8308716
Merge branch 'master' into localisation-refactor-framework
2021-02-25 17:28:55 +09:00
smoogipoo
dff1d80f39
Update HasFlag usages to HasFlagFast
2021-02-25 15:38:56 +09:00
Dean Herbert
2c8e62ae35
Fix toolbar not completing enough of layout to propagate hotkeys to buttons before initial display
2021-02-25 14:52:51 +09:00
Dean Herbert
e82eaffaed
Flip order back to original for romanisable strings
2021-02-25 14:14:07 +09:00
Dean Herbert
4cdde42228
Remove unnecessary backing field
2021-02-25 14:08:01 +09:00
Dean Herbert
8a97e2e28d
Update LocalisedString usages to RomanisedString
2021-02-22 19:01:42 +09:00
Dean Herbert
1fd76ea3fb
Apply changes to UI components overriding functions with changing signatures
2021-02-22 19:01:42 +09:00
smoogipoo
ccb83ef3a3
Fix checkbox not being updated
2021-02-22 15:47:47 +09:00
Dean Herbert
b68dbbceff
Merge branch 'master' into multiplayer-participant-rank
2021-02-19 13:16:44 +09:00
Dan Balasescu
28550f19e8
Merge branch 'master' into online-overlay-login-placeholder
2021-02-19 10:06:25 +09:00
Dean Herbert
10ec4cd8e0
Revert change to loading layer's default state
2021-02-18 22:38:17 +09:00
Salman Ahmed
a407bfe73b
Privatize UserRanks
and expose a similar CountryRank
field instead
2021-02-18 15:37:52 +03:00
Dean Herbert
990c1b1d6e
Revert accidental removal of newlines
2021-02-18 18:19:57 +09:00
Dean Herbert
0bd1964d8e
Add login placeholder logic to OnlineOverlay
...
A perfect implementation of this would probably leave the filter/header
content visible, but that requires some re-thinking and restructuring to
how the content is displayed in these overlays (ie. the header
component shouldn't be inside the `ScrollContainer` as it is fixed).
Supersedes and closes #10774 .
Closes #933 .
Addresses most pieces of #7417 .
2021-02-18 18:07:24 +09:00
Dean Herbert
c3f66a0c74
Add login placeholder for chat overlay
2021-02-18 17:46:07 +09:00
Salman Ahmed
a845e96b7a
Replace Ranks.Global
completely with a GlobalRank
property
2021-02-17 08:52:04 +03:00
Joehu
e838a5d9f0
Fix comment edited at date not showing tooltip
2021-02-15 19:04:23 -08:00
Dean Herbert
2e646882fa
Merge branch 'master' into non-concurrent-sample-playback
2021-02-15 21:22:21 +09:00
Dean Herbert
de52b8a5ba
Fix test failures in PerformFromScreen tests
2021-02-15 17:14:41 +09:00
smoogipoo
c6ed3efa4a
Merge branch 'master' into non-concurrent-sample-playback
2021-02-15 14:47:32 +09:00
Joehu
982d8e35ed
Fix mod settings showing scrollbar when screen is offset
2021-02-12 10:42:48 -08:00
smoogipoo
d3f0c0730d
Merge branch 'master' into non-concurrent-sample-playback
2021-02-12 17:22:15 +09:00
Dan Balasescu
ca091431f4
Merge pull request #11739 from peppy/settings-item-tooltips
...
Display descriptions in tooltips of mod settings adjustments
2021-02-12 00:18:16 +09:00
Dean Herbert
9fb41dc0b6
Move property to a better place in the class
2021-02-11 16:41:21 +09:00
Dean Herbert
dddd776802
Add the ability for settings items to have tooltips
2021-02-11 16:38:17 +09:00
Dean Herbert
98c5b0220c
Merge pull request #11725 from smoogipoo/freemods-user-settings
...
Add local user customisation for freemod mod settings
2021-02-11 16:02:24 +09:00
Dean Herbert
cbdc189ab2
Merge branch 'new-overlay-sounds' into update-resources
2021-02-11 14:20:23 +09:00
Dean Herbert
e53242c159
Merge branch 'new-toolbar-sounds' into update-resources
2021-02-11 14:20:21 +09:00
Dean Herbert
4ffb7fb753
Merge branch 'osd-toggle-sounds' into update-resources
2021-02-11 14:20:18 +09:00
Dean Herbert
896f318b56
Rename variable for clarity
2021-02-11 14:18:40 +09:00
Dean Herbert
72562070bc
Remove second overload of Close (makes the call structure hard to follow / invoke correctly)
2021-02-11 14:18:00 +09:00
Jamie Taylor
2ee634d173
Create subclass for "Error" notifications to allow them to have a unique pop-in sound
2021-02-11 13:55:43 +09:00
Jamie Taylor
a1ae739a62
Add support for Notification sounds
2021-02-11 13:51:54 +09:00
Jamie Taylor
c12c09ec4d
Move logic to LoadComplete instead
2021-02-11 09:57:14 +09:00
Jamie Taylor
63e6ec1c9f
Add audio feedback for OSD value changes
2021-02-11 09:23:04 +09:00
smoogipoo
822c66033f
Add local-user freemod configuration
2021-02-10 19:56:59 +09:00
Jamie Taylor
4e2ab0bad2
Use a separate sample set for Toolbar buttons
2021-02-10 17:48:36 +09:00
Dean Herbert
9e400acd1a
Merge branch 'master' into fix-mod-settings-fuckery
2021-02-10 17:43:03 +09:00
Jamie Taylor
3eda78c363
Use unique samples for Dialog, NowPlaying, SettingsPanel and WaveOverlay pop-in/pop-out
2021-02-10 16:04:47 +09:00
Dean Herbert
b3b0d97354
Avoid potential feedback from bindable event binds
2021-02-10 15:33:04 +09:00
Dean Herbert
67c1c4c1eb
Copy settings before applying selection
2021-02-10 15:30:17 +09:00
Dean Herbert
435c85a2e7
Avoid executing selection twice on ModSelectOverlay load
2021-02-10 15:13:09 +09:00
Dean Herbert
a39263423c
Fix externally changed settings from being reset when ModSelectOverlay is initialised
2021-02-10 15:12:29 +09:00
Dean Herbert
75bc9f607e
Rename wrongly named method
2021-02-10 14:55:15 +09:00
Dean Herbert
e44667e5e0
Use MinValue instead
...
Co-authored-by: Salman Ahmed <slmanarendo1950@gmail.com>
2021-02-10 11:31:34 +09:00
Andrei Zavatski
d9dcf8a042
Fix incorrect header depth in OnlineOverlay
2021-02-09 20:30:31 +03:00
Dan Balasescu
92599aa02b
Merge branch 'master' into user-beatmap-downloading-states-2
2021-02-09 21:06:09 +09:00
Dan Balasescu
15b3747945
Merge pull request #11716 from peppy/defer-playlist-load
...
Defer playlist load to improve load time of the now playing overlay
2021-02-09 20:59:51 +09:00
Dean Herbert
d8d830db6e
Defer playlist load to improve load time of the now playing overlay
2021-02-09 19:46:57 +09:00
Dean Herbert
1670766633
Avoid unbinding external events
2021-02-09 18:42:15 +09:00
Dean Herbert
178d88bcf1
Change BackgroundColour into a property
2021-02-09 18:32:44 +09:00
Dean Herbert
b5fa950800
Remove unnecessary depth specification
2021-02-09 18:30:05 +09:00
Dean Herbert
3206c7cbae
Merge branch 'master' into overlay-header-refactor
2021-02-09 18:20:07 +09:00
Dean Herbert
8204d360a8
Always reset local user settings when a mod is deselected in ModSelectOverlay
2021-02-09 13:44:42 +09:00
Dean Herbert
f338fa114b
Merge branch 'master' into user-beatmap-downloading-states-2
2021-02-05 18:02:40 +09:00
Dean Herbert
3e750feaa4
Subclass LocalPlayerModSelectOverlay to correctly deselect incompatible mods on free mod selection
2021-02-05 16:42:35 +09:00
Dean Herbert
9e9e382bee
Merge branch 'master' into user-beatmap-downloading-states-2
2021-02-05 15:27:17 +09:00
Dean Herbert
0750c3cb6a
Add back immediate deselection flow to ensure user selections can occur without contention
2021-02-04 23:44:46 +09:00
Dean Herbert
8f2f1a444f
Avoid resetting selection on deselecting incompatibile types
2021-02-04 19:55:09 +09:00
Dean Herbert
bf239f8bef
Flush animation on closing mod overlay
2021-02-04 19:12:37 +09:00
Dean Herbert
a2674f3c3f
Add comments
2021-02-04 18:58:56 +09:00
Dean Herbert
223b858227
Ramp the animation speed
2021-02-04 18:56:40 +09:00
Dean Herbert
f23ca7c7cf
Centralise selection animation logic
2021-02-04 18:10:55 +09:00
Dean Herbert
4bfe3aabdc
Simplify sound debounce logic
2021-02-04 17:06:11 +09:00
smoogipoo
f25535548a
Fix buzzing on select all/deselect all
2021-02-02 21:20:16 +09:00
smoogipoo
643c0605d8
Implement the freemod selection overlay
2021-02-02 21:14:38 +09:00
smoogipoo
8b3a85daa7
Merge branch 'refactor-mod-sections' into freemod-select-overlay
2021-02-02 21:09:51 +09:00
smoogipoo
728f8599b2
Move incompatible mod deselection to SoloModOverlay
2021-02-02 21:06:32 +09:00
smoogipoo
e58ece9e10
Make ModSelectOverlay abstract
2021-02-02 21:06:04 +09:00
smoogipoo
50e92bd0ed
Fix selection not being preserved when IsValidMod changes
2021-02-02 20:50:54 +09:00
smoogipoo
10ceddf3ff
Make IsValidMod adjustable
2021-02-02 20:47:50 +09:00
smoogipoo
75f81bfa06
Add back mod validation
2021-02-02 20:35:41 +09:00
smoogipoo
6d620264f4
Allow mod buttons to not be stacked
2021-02-02 20:27:41 +09:00
smoogipoo
3741f05ab3
Refactor mod sections and make them overridable
2021-02-02 20:11:40 +09:00
Dean Herbert
a76314a876
Use Update instead of UpdateAfterChildren (no need for the latter)
2021-02-02 15:57:17 +09:00
Dean Herbert
bb0753f68d
Use a better method of cancelling user scroll
2021-02-02 15:44:03 +09:00
Dean Herbert
398ab9c2c2
Use UserTrackingScrollContainer instead
2021-02-02 15:29:38 +09:00
Salman Ahmed
5c28c030c8
Unconditionally set "autoscroll" state
2021-02-01 22:08:57 +03:00
Salman Ahmed
15fcabb128
Add documentation to auto-scroll leniency
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-02-01 22:04:44 +03:00
Salman Ahmed
49e62c3a4b
Apply documentation changes
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-02-01 11:02:08 +03:00
Salman Ahmed
e806e5bcd1
Improve robustness of chat auto-scrolling logic
...
Fix auto-scrolling state changing by old messages removal logic
2021-01-31 23:45:49 +03:00
Dean Herbert
18e6afbec0
Ensure the item is present before trying to select it
2021-01-29 19:17:12 +09:00
Dean Herbert
1ce383fc20
Merge branch 'master' into fix-skin-dropdown-update-crash
2021-01-29 19:16:20 +09:00
Bartłomiej Dach
2c08ce05fa
Remove game-local enum [Order] attribute
...
In favour of the newly-added framework one.
2021-01-27 22:29:52 +01:00
Dean Herbert
67014018fc
Merge pull request #11589 from MiraiSubject/osu-mod-icon-fallbacks
...
Allow tournament client to use default mod icons if custom icons are not present
2021-01-26 19:57:21 +09:00
Dean Herbert
a5f3418e56
Avoid tooltip display
2021-01-26 19:11:19 +09:00
Dean Herbert
fedcbf79fa
Merge pull request #11572 from EVAST9919/comment-pill
...
Make VotePill background transparent for own comments
2021-01-26 18:57:00 +09:00
Salman Ahmed
93bb2611d6
Merge branch 'fix-beatmap-listing' into fix-beatmap-listing-2
2021-01-26 09:43:49 +03:00
Dean Herbert
ca0242debe
Tidy up logic to correctly expire in cases where expiry is expected
2021-01-26 15:42:48 +09:00
Salman Ahmed
0d8d0d6852
Apply alternative way of fixing
2021-01-26 01:03:29 +03:00
Salman Ahmed
c317d60169
Add offline test scene for beatmap listing overlay
2021-01-26 00:03:20 +03:00
Salman Ahmed
75d6dbdbb7
Fix beatmap listing placeholder potentially getting disposed
2021-01-26 00:03:20 +03:00
Salman Ahmed
9efce5717f
Fix beatmap listing placeholder disappearing on second time display
2021-01-26 00:03:20 +03:00
Dean Herbert
bb8113fb51
Fix mod select footer not animating correctly on first reveal
2021-01-25 14:47:47 +09:00
Salman Ahmed
acfb2d2980
Refactor beatmap set covers into using ModelBackedDrawable<T>
2021-01-24 00:32:33 +03:00
Andrei Zavatski
e9d10bb6e7
Revert "Minor refactoring"
...
This reverts commit 3d42cc1f91
.
2021-01-22 22:49:49 +03:00
Andrei Zavatski
3d42cc1f91
Minor refactoring
2021-01-22 22:27:26 +03:00
Bartłomiej Dach
360f26c13d
Merge branch 'master' into scroll-to-20
2021-01-22 19:58:36 +01:00
Andrei Zavatski
20161aea6a
Show LoginOverlay if not logged-in when clicking on a pill
2021-01-22 21:47:53 +03:00
Andrei Zavatski
6379381f95
Make VotePill background transparent for own comments
2021-01-22 20:46:20 +03:00
Dean Herbert
d69a4914e0
Add method to block all realm access during migration operation
2021-01-22 17:28:47 +09:00
Dean Herbert
fca6b15d2f
Fix local echo messages remaining permanently dimmed when chatting via multiplayer
2021-01-22 16:05:45 +09:00
Andrei Zavatski
2eba2a9abf
Rename FriendsButton to FollowersButton
2021-01-21 23:40:23 +03:00
Andrei Zavatski
c631354b57
Rename property
2021-01-21 23:39:19 +03:00
Andrei Zavatski
4555b9ff70
Make ProfileHeaderButton height defined
2021-01-21 22:56:12 +03:00
Andrei Zavatski
e87197c7fc
Adjust text size
2021-01-21 22:48:31 +03:00
Andrei Zavatski
343166f158
Make CreateIcon a property
2021-01-21 22:47:44 +03:00
Andrei Zavatski
a7c22ebe88
Implement MappingSubscribersButton component
2021-01-21 22:02:54 +03:00
Andrei Zavatski
2aa1df9ea4
Implement ProfileHeaderStatisticsButton component
2021-01-21 21:38:52 +03:00
Andrei Zavatski
05d3914fee
Rename friends tooltip to followers
2021-01-21 21:26:33 +03:00
Dean Herbert
259f6504fb
Merge branch 'master' into realm-key-binding-store
2021-01-21 15:45:59 +09:00
Dean Herbert
a6516e3be5
Merge branch 'master' into scroll-to-20
2021-01-21 14:28:17 +09:00
Andrei Zavatski
65ece1aa72
Mark OverlayHeader as NotNull in FullscreenOverlay
2021-01-21 07:50:41 +03:00
Dean Herbert
7c4a072568
Merge branch 'master' into scroll-to-20
2021-01-21 13:48:26 +09:00
Andrei Zavatski
da0066e7b0
Merge master with conflicts resolved
2021-01-21 07:30:47 +03:00
Dan Balasescu
c3675293fa
Merge branch 'master' into beatmapset-refactor
2021-01-21 12:38:34 +09:00
Dan Balasescu
95f52ae054
Merge pull request #11536 from rednir/sort-skins-alphabetically
...
Sort SkinSection in alphabetical order
2021-01-20 21:49:31 +09:00
Dan Balasescu
455383c3c0
Merge pull request #11528 from peppy/fix-autoplay-in-multiplayer
...
Fix multiplayer mod select showing autoplay as a choice
2021-01-20 21:49:16 +09:00
Dan Balasescu
12f2067357
Merge branch 'master' into sort-skins-alphabetically
2021-01-20 21:15:16 +09:00
Andrei Zavatski
2ca3ccad06
Move all the content to BeatmapSetHeaderContent drawable
2021-01-20 04:56:46 +03:00
Andrei Zavatski
94fee3800d
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmapset-refactor
2021-01-20 04:32:56 +03:00
Bartłomiej Dach
3b49b7461e
Schedule entire operation for safety
...
Also removes a redundant list copy.
2021-01-19 19:35:53 +01:00
Bartłomiej Dach
78e590d25d
Refactor skin sorting method
...
* Rename to `sortUserSkins` to convey meaning better.
* Sort in-place instead of slicing the list.
* Change to `void` to avoid misleading users that the method returns
a new list instance.
* Fix typo in comment.
2021-01-19 18:36:42 +01:00
Bartłomiej Dach
b00c6a1d60
Make first non-default skin index a property
...
The previous code was very brittle - it was not always updating
properly, and seems to have worked either by a carefully crafted set of
circumstances, or just plain coincidence.
Having this be a get-only property avoids potential error in the future
caused by not updating the index properly, at the expense of an added
linear lookup.
2021-01-19 18:31:37 +01:00
rednir
206a0b8bac
Fix firstNonDefault staying as -1
2021-01-19 16:55:50 +00:00
rednir
a880b8d21d
Satisfy AppVeyor
2021-01-19 16:11:16 +00:00
rednir
b265d2dab4
Remove another whitespace
2021-01-19 14:16:22 +00:00
rednir
1d4c813ff6
Merge branch 'sort-skins-alphabetically' of https://github.com/rednir/osu into sort-skins-alphabetically
2021-01-19 14:03:31 +00:00
rednir
31e61326e1
Only user skins are sorted
2021-01-19 14:00:17 +00:00
rednir
f1894a8bac
fixed itemUpdated()
2021-01-19 12:17:56 +00:00
Dean Herbert
f1a785f407
Merge branch 'master' into realm-key-binding-store
2021-01-19 18:22:34 +09:00
smoogipoo
de9d075f94
Initial sample + samplechannel rework
2021-01-19 17:11:40 +09:00
Andrei Zavatski
f0add0a7cf
Make BeatmapSetOverlay use OverlayHeader
2021-01-19 01:34:37 +03:00
rednir
0b65c0cd25
Remove whitespace
2021-01-18 20:17:42 +00:00
rednir
da89426a3b
Merge branch 'master' of https://github.com/ppy/osu into sort-skins-alphabetically
2021-01-18 20:09:15 +00:00
rednir
7476cb3047
Sort SkinSection in alphabetical order
2021-01-18 19:51:42 +00:00
Andrei Zavatski
c6b0f3c247
Implement TabbableOnlineOverlay component
2021-01-18 21:22:50 +03:00
Dean Herbert
0560eb4120
Reduce final fill alpha of main menu confirm-to-exit
2021-01-18 18:22:21 +09:00
Dean Herbert
0b165dce4b
Fix multiplayer mod select showing autoplay as a choice
2021-01-18 17:50:32 +09:00
Andrei Zavatski
6e34ab5d15
Rename WebOverlay to OnlineOverlay
2021-01-18 11:13:38 +03:00
Andrei Zavatski
b27b18f70f
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-header-refactor
2021-01-18 11:10:55 +03:00
Salman Ahmed
bd44bf8c0b
Extract disabling progress bar user-interactivity
2021-01-18 10:51:39 +03:00
Andrei Zavatski
27ffc98445
Implement WebOverlay component
2021-01-18 10:48:12 +03:00
Dean Herbert
1364de1166
Merge branch 'master' into beatmap-colour-setting
2021-01-18 16:07:46 +09:00
Salman Ahmed
d93a853dfd
Enforce float
type in the download progress path instead
2021-01-17 21:16:48 +03:00
Dean Herbert
5278cad393
Reword setting to make more sense
2021-01-17 22:42:48 +09:00
Dean Herbert
5fd644fc57
Unify variable names
2021-01-17 22:42:48 +09:00
Dean Herbert
addd463d26
Merge branch 'master' into explicit-search-control
2021-01-17 21:44:25 +09:00
Dean Herbert
edb6d3907b
Merge pull request #11472 from frenzibyte/explicit-beatmap-markers
...
Add explicit content markers to beatmap panels and overlay
2021-01-17 21:44:10 +09:00
Bartłomiej Dach
816cc7a59b
Adjust explicit label spacing on beatmap set overlay
2021-01-17 00:35:23 +01:00
Salman Ahmed
adb2605d5d
Enforce double
type in the download progress path
...
Wasn't sure where to exactly put this, or whether to split it, but it's very small change to worry about, so I guess it's fine being here
2021-01-17 00:12:14 +03:00
Dean Herbert
b5e784ed42
Fix possibility of crash when selecting a random skin during skin import
2021-01-15 16:34:28 +09:00
Salman Ahmed
dc8e38cf4d
Remove pointless inline comment
2021-01-15 07:20:13 +03:00
Dean Herbert
2988700bea
Merge branch 'master' into realm-key-binding-store
2021-01-14 16:37:09 +09:00
Dean Herbert
fd582f521c
Reduce lifetime of realm context usage in detach scenario
2021-01-14 16:33:55 +09:00
Dean Herbert
8d071f97fb
Early return
2021-01-14 16:33:03 +09:00
Dean Herbert
e3c5a909e4
Fix known non-null variable
2021-01-14 16:30:57 +09:00
Dean Herbert
8a08d3f4ef
Fix transactions not actually being committed
2021-01-14 16:13:10 +09:00
Salman Ahmed
6281c1086a
Space out explicit marker in beatmap overlay
2021-01-14 05:41:09 +03:00
Salman Ahmed
abf718242b
Make explicit marker font semi-bold
2021-01-14 05:40:43 +03:00
Salman Ahmed
1f12b2bd09
Rename download state Downloaded
to Importing
2021-01-13 18:04:53 +03:00
Salman Ahmed
43daa7c7c0
Use Colour2
of orange theme for explicit pill
2021-01-13 17:07:42 +03:00
Salman Ahmed
e275dd02e0
Create static colour properties for now
2021-01-13 17:07:11 +03:00
Salman Ahmed
9d59d784f8
Add Colour{1-4} properties to OverlayColourProvider
2021-01-13 17:06:44 +03:00
Salman Ahmed
a5f99ed8e6
Merge branch 'explicit-beatmap-markers' into explicit-search-control
2021-01-13 12:53:57 +03:00
Dean Herbert
fcb4a53f37
Rename realm persisted properties to avoid casting necessity
2021-01-13 18:36:37 +09:00
Dean Herbert
9086d75542
Update write usages
2021-01-13 18:36:37 +09:00
Dean Herbert
9d744d629f
Update existing usages to use the main realm context where applicable
2021-01-13 18:36:37 +09:00