Joseph Madamba
c80a25328d
Shorten label to just "matches"
2023-04-17 20:59:41 -07:00
Joseph Madamba
16df92f405
Fix sets not being plural
2023-04-17 20:59:02 -07:00
Dan Balasescu
c0a25144cf
Apply changes to custom ShaderManager
2023-04-18 11:31:56 +09:00
Dean Herbert
c3f3b8db7c
Update resources
2023-04-17 23:09:46 +09:00
Dean Herbert
fbb15fff26
Update framework
2023-04-17 23:03:16 +09:00
Dean Herbert
7aeab174eb
Merge pull request #23185 from bdach/nested-result-revert
...
Invoke `RevertResult` on parent DHO when nested DHO is reverted
2023-04-12 23:08:10 +09:00
Bartłomiej Dach
e72f103c17
Do not look up metadata for locally-modified beatmaps on save
2023-04-11 23:14:35 +02:00
Bartłomiej Dach
db86ced4b4
Invoke RevertResult
on parent DHO when nested DHO is reverted
...
The behaviour described above was removed in
812a4b412a
, thus henceforth
contradicting `RevertResult`'s xmldoc. As it is relied on by some
external rulesets, bring it back to unbreak them.
2023-04-11 18:29:08 +02:00
Joseph Madamba
d0cbe206a9
Revert back to one number with "matching beatmap difficulties" label
2023-04-10 23:37:29 -07:00
Joseph Madamba
f0c8a3202b
Merge remote-tracking branch 'upstream/master' into fix-beatmap-terminology
2023-04-10 23:22:15 -07:00
Dean Herbert
52bb7891f7
Merge branch 'master' into fix-count-not-updating-when-deleting
2023-04-11 09:04:02 +09:00
Joseph Madamba
f80de08f24
Adjust BeatmapSetsChanged
xmldoc
...
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2023-04-10 11:28:23 -07:00
Joseph Madamba
c7dea71793
Use existing BeatmapSetsChanged
action
2023-04-10 11:26:18 -07:00
Dean Herbert
8757276c37
Merge pull request #23156 from Micha-ohne-el/editor-selection-rotation-snapping
...
Add rotation snapping to editor selection
2023-04-11 00:45:44 +09:00
Dean Herbert
52c4703261
Merge pull request #23103 from Joehuu/normalise-overlay-padding
...
Normalise horizontal padding on overlays
2023-04-10 23:48:59 +09:00
Bartłomiej Dach
1f2c96c8e8
Merge branch 'master' into gd-onlinesetoverlay
2023-04-10 15:35:03 +02:00
Bartłomiej Dach
11fd93a2ba
Inline disturbing getGuestMapper()
method
...
Disturbing because name suggests pure method, but it is in fact `void`
and also performs side effects by about the most confusing means
possible.
2023-04-10 15:20:43 +02:00
Bartłomiej Dach
73bd0feef5
Fix incorrectly implemented localisation
2023-04-10 15:03:33 +02:00
Bartłomiej Dach
6fec476147
Simplify snap implementation
2023-04-10 14:55:30 +02:00
Bartłomiej Dach
ead5e9f027
Merge branch 'master' into editor-inspector
2023-04-10 14:29:05 +02:00
Bartłomiej Dach
60358c7203
Perform first inspector text update immediately
...
Provides better and more consistent initial state for the inspector.
2023-04-10 14:13:53 +02:00
Bartłomiej Dach
641415ca32
Unify displayed duration format for single/multiple selection
2023-04-10 14:05:32 +02:00
Joseph Madamba
7f5b99c91b
Fix song select beatmap difficulty count not updating when deleting
2023-04-09 22:12:51 -07:00
Dan Balasescu
15f6bc155e
Add progressive score multiplier for HT
2023-04-10 13:35:48 +09:00
Dan Balasescu
c923482976
Add progressive score multiplier for DT
2023-04-10 13:31:48 +09:00
cdwcgt
dd69089117
code quality
2023-04-09 15:51:31 +09:00
cdwcgt
5d64c1b7bf
exception handling
2023-04-09 15:09:18 +09:00
cdwcgt
ce6a87b4a3
Merge remote-tracking branch 'upstream/master' into export
2023-04-09 15:02:47 +09:00
cdwcgt
fc55b96e77
remove CompletionText
in Constructor
...
this will never used
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2023-04-09 14:27:42 +09:00
cdwcgt
49193a2bdd
CompletionText
...
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2023-04-09 22:25:47 +09:00
cdwcgt
de21b4a2f7
use Live<TModel>
...
Use RealmAccess only when needed
2023-04-09 22:21:15 +09:00
cdwcgt
1f4da35c8d
notification nullable fix
2023-04-09 22:13:53 +09:00
cdwcgt
13b522e825
repair usage of CancellationToken
...
Co-Authored-By: n0099 <n@n0099.net>
2023-04-09 22:09:53 +09:00
Dean Herbert
8d2e852ffd
Fix overbearing key down handling
2023-04-08 22:30:36 +09:00
Dean Herbert
a1fc4def1d
Remove redundant method override
2023-04-08 22:18:07 +09:00
Micha Lehmann
3c4a25e53f
Fix tooltip text not resetting when ending an editor rotation
2023-04-08 14:28:52 +02:00
Micha Lehmann
580d5745c0
Add "(snapped)" to the tooltip when snap-rotating in the editor
2023-04-08 14:15:49 +02:00
Joseph Madamba
a86a968fac
Use public BeatmapSet
to match other usages
2023-04-07 21:16:36 -07:00
Joseph Madamba
ed208ef127
Fix more typos and adjust font size to match web
2023-04-07 21:10:37 -07:00
Dean Herbert
f72dd86b42
Fix code quality issues and avoid updating bindable twice per operation
2023-04-08 10:40:36 +09:00
Micha Lehmann
c827c2810b
Improve editor selection rotation value wrapping
...
This fixes two issues the previous algorithm had:
1. A half-turn rotation used to show up as -180°.
2. Rotating more than 180° in one drag event would overwhelm it
and cause the value to go outside its range.
This comes at the cost of a negligible performance hit,
since a division (modulo) is performed instead of just addition/subtraction.
2023-04-08 01:30:29 +02:00
Micha Lehmann
f1de560d57
Snap editor selection rotation when holding shift
2023-04-08 01:30:29 +02:00
Dean Herbert
0c71fa1bbd
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-06 23:39:57 +09:00
Dean Herbert
ad717d2368
Fix scheduled calls piling up during transactions
2023-04-06 23:39:36 +09:00
Andrei Zavatski
ed565b1e59
Fix SampleStore isn't being disposed
2023-04-06 11:40:04 +03:00
Dean Herbert
e6872629f3
Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable
...
Don't show epilepsy warning when storyboards are disabled
2023-04-06 12:32:38 +09:00
tsrk
809b817e8e
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-05 22:57:36 +02:00
Bartłomiej Dach
ba753a8aac
Merge branch 'master' into update-skinnable-sound-before-playing
2023-04-05 22:56:25 +02:00
Bartłomiej Dach
27055919a3
Merge branch 'master' into fix-old-beatmap-crash-on-load
2023-04-05 21:39:42 +02:00
Bartłomiej Dach
6df7614b9d
Add tests for suppressing epilepsy warning when storyboard disabled
2023-04-05 20:56:50 +02:00
Bartłomiej Dach
e5d57a65c9
Fix incorrect indent
2023-04-05 19:47:25 +02:00
Bartłomiej Dach
432f698697
Merge branch 'master' into gameplay/key-counter-abstraction
2023-04-05 19:45:14 +02:00
Dean Herbert
9c8b25e034
Fix display not always updating when expected by updating on a schedule
2023-04-05 13:45:24 +09:00
Dean Herbert
f07d859532
Optimise how often we update the display
2023-04-04 19:31:33 +09:00
Dean Herbert
3209b09270
Move inspector into own file
2023-04-04 19:17:34 +09:00
Dean Herbert
4aed483005
Tidy up dependency resolution
2023-04-04 19:14:30 +09:00
Dean Herbert
195b5fc3f1
Add view for selections of size != 1
2023-04-04 19:11:48 +09:00
Dean Herbert
b0d5761667
Add object type
2023-04-04 19:05:50 +09:00
Dean Herbert
c356c163fa
Add hit object inspector view
2023-04-04 19:03:45 +09:00
Dean Herbert
f9ebdadfe8
Move right-side editor toolbox to base HitObjectComposer
...
Move right-side editor toolbox to base `HitObjectComposer`
2023-04-04 19:00:56 +09:00
Bartłomiej Dach
1a5707b65f
Merge pull request #22878 from peppy/fix-replay-fail-on-exit
...
Ensure replays don't enter a failed state when exiting gameplay
2023-04-03 22:38:32 +02:00
Bartłomiej Dach
8cc425774b
Merge branch 'master' into fix-replay-fail-on-exit
2023-04-03 21:23:23 +02:00
Bartłomiej Dach
7dfd903b76
Merge branch 'master' into fix-debug-perf-drd
2023-04-03 21:04:18 +02:00
Bartłomiej Dach
b5d9284de2
Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer
...
Fix attempting to show overlay during game intro playing hide sound effects
2023-04-03 20:48:03 +02:00
cdwcgt
9dd30e4b4c
condition fix
2023-04-03 20:24:38 +09:00
cdwcgt
735b48679e
use LinkFlowContainer
directly
2023-04-03 20:09:49 +09:00
cdwcgt
41c01d3929
nullable condition
2023-04-03 20:07:21 +09:00
cdwcgt
51240ed46b
typo
2023-04-03 19:51:22 +09:00
Dean Herbert
7011928d86
Fix abysmal debug performance due to try-catch logic in DrawableRulesetDependencies
2023-04-03 18:04:33 +09:00
Dean Herbert
b0c09df259
Merge branch 'master' into gameplay/key-counter-abstraction
2023-04-03 15:33:35 +09:00
Dean Herbert
43d7386623
Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting
...
Fix beatmap listing sort direction not resetting when changing criteria
2023-04-03 15:32:10 +09:00
Dean Herbert
e4eb736622
Merge pull request #22929 from Joehuu/fix-loading-blocking-overlay-headers
...
Fix beatmap listing filter control being blocked by loading layer
2023-04-03 15:29:38 +09:00
Dean Herbert
a097433cb1
Fix overlay toggle keys working during disabled activation modes
...
Closes #23104 .
2023-04-03 15:03:47 +09:00
Joseph Madamba
247d426c8a
Add horizontal padding to currently playing search textbox
2023-04-02 20:50:18 -07:00
Joseph Madamba
436f1e4ae4
Replace other hardcoded horizontal padding with const
...
- Also add overlay stream item padding const and account for it
2023-04-02 20:50:18 -07:00
Joseph Madamba
af389b1107
Replace all hardcoded 50 horizontal padding with const
2023-04-02 20:50:18 -07:00
Joseph Madamba
7a0edabd5d
Normalise overlay horizontal padding const
2023-04-02 20:24:13 -07:00
Dean Herbert
daf9f19b29
Merge pull request #23098 from Joehuu/update-vote-pill-hover
...
Update comment vote pill in line with web
2023-04-03 12:01:46 +09:00
Dean Herbert
8932668f77
Update framework
2023-04-03 10:31:47 +09:00
Joseph Madamba
63ea17f10e
Update comment vote pill in line with web
2023-04-02 18:17:40 -07:00
Susko3
c3a6a58169
Fix window mode dropdown not showing
2023-04-02 19:23:18 +02:00
Dean Herbert
1e0b64c9e8
Update framework (again)
2023-04-02 23:07:40 +09:00
cdwcgt
d949ef3ca4
make guestMapperContainer
private
...
tests don't use it
2023-04-02 22:53:15 +09:00
cdwcgt
2cf8636366
show guest diff author in BeatmapPicker
2023-04-02 22:25:58 +09:00
Dean Herbert
4c2b7e7788
Fix random inspection showing up only in CI
2023-04-02 21:05:20 +09:00
Dean Herbert
cf5acbf66e
Update usage of SupportedWindowModes
2023-04-02 20:16:14 +09:00
Dean Herbert
0f0dd9f2dc
Update resources
2023-04-02 20:07:33 +09:00
Dean Herbert
7f9bf09e03
Update framework
2023-04-02 20:07:31 +09:00
Dean Herbert
4b294278d6
Merge branch 'master' into fix-ruleset-shader-caching
2023-03-31 20:04:55 +09:00
Dean Herbert
1277c8eb5a
Merge branch 'master' into debug-use-en-localisation-fallbacks
2023-03-31 17:26:56 +09:00
Dan Balasescu
4b7d44c329
Remove unused using
2023-03-31 16:23:56 +09:00
Dan Balasescu
28f31ef379
Adjust comment slightly
2023-03-31 16:23:37 +09:00
Dan Balasescu
d5b8a45541
Always use fallback strings for English
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-03-31 16:20:16 +09:00
Bartłomiej Dach
bfbb5ab96b
Merge branch 'master' into fix-fail-progression-to-results
2023-03-30 21:40:49 +02:00
Dean Herbert
796cd9c916
Rewrite comment explaining early return on checkScoreCompleted
given new usages
2023-03-31 02:36:17 +09:00
Dean Herbert
b25a59fd14
Rename scoreCompleted
-> checkScoreCompleted
to reflect the fact it doesn't always succeed
2023-03-31 02:30:04 +09:00
cdwcgt
5d395e6d37
move to ctor
2023-03-29 22:59:54 +09:00
cdwcgt
19b7036b95
use same same duration
...
negligence in migrating code
2023-03-29 22:56:35 +09:00
cdwcgt
e85c28031e
change weird name
2023-03-29 22:55:25 +09:00
Dean Herbert
72c5c9848f
Always use LocalisableString
fallbacks when deploying debug and viewing english
...
This allows changes to `xxxStrings.cs` files to immediately reflect in
the UI, which is (at least for me) an expectation.
2023-03-29 14:44:43 +09:00
Dean Herbert
c7003434b2
Fix localisation for audio device error containing incorrect newline escaping
2023-03-29 14:33:10 +09:00
Dean Herbert
4dd0c2c7a5
Add assert ensuring we don't ever get to the results screen with an F rank
...
Intentionally an assertion as I want tests to fail, but I don't want
this to cause crashes for an end user if it does happen to occur.
2023-03-29 14:11:58 +09:00
Dean Herbert
a8bb2e33ac
Ensure all preconditions are checked before progressing to results screen after storyboard ends
2023-03-29 14:00:11 +09:00
Dean Herbert
aad540629f
Remove duplicate load rule from ShaderPrecompiler
2023-03-29 12:36:56 +09:00
cdwcgt
46ede27869
add feature to adjust ScalingContainer
background dim
2023-03-28 22:41:24 +09:00
cdwcgt
31df626f0e
disable button when select other reason
2023-03-28 21:32:28 +09:00
cdwcgt
899860dd77
Merge branch 'master' into chat-report
2023-03-28 21:14:11 +09:00
Dean Herbert
8c1df3c8d9
Fix web account registration not bypassing the URL warning
2023-03-28 15:38:19 +09:00
Dean Herbert
0d77ec013a
Fix ruleset-local shader manager not correctly falling back to existing cached shaders
2023-03-28 15:00:49 +09:00
Dean Herbert
5dfac02b11
Preload triangle shader on startup
2023-03-28 14:15:38 +09:00
Dean Herbert
c742b3f0a8
Update DrawableRulesetDependencies
xmldoc to read more correctly
2023-03-28 14:15:19 +09:00
cdwcgt
b065689cf8
Limit the area of popover to DrawableChannel
...
popover may be blocked by textBar
2023-03-27 23:04:45 +09:00
Joseph Madamba
8b30c67580
Fix incorrect song select matching label by showing both beatmap and difficulty count for less ambiguity
2023-03-26 18:08:28 -07:00
Joseph Madamba
76a6f97fbb
Fix wrong definition of a beatmap in first run setup
2023-03-26 17:32:03 -07:00
Joseph Madamba
3e0bbb2432
Fix select beatmap button not highlighting when creating a multiplayer room using keyboard
2023-03-26 16:03:21 -07:00
Dean Herbert
6924dc5c50
Update framework
2023-03-27 02:16:33 +09:00
Dean Herbert
898717231b
Hide vulkan renderer option for now
...
We'll bring it back when it's more stable.
2023-03-27 02:00:10 +09:00
Bartłomiej Dach
292486c25a
Use more resilient restore method
2023-03-26 14:35:00 +02:00
Bartłomiej Dach
f3c174a7f2
Fix test errors due to missing dependencies
2023-03-26 13:52:26 +02:00
Dean Herbert
bab93bed17
Fix string interpolation and use GetDescription
on renderer value
2023-03-26 20:43:28 +09:00
Dean Herbert
ba078e8357
Show "automatic" resolved renderer inline in dropdown instead
2023-03-26 20:29:30 +09:00
Dean Herbert
764361b3d3
Add special case to hide definitely non-working renderers on android
2023-03-26 20:14:33 +09:00
Dean Herbert
e346b02ebf
Add display of current renderer
2023-03-26 20:09:35 +09:00
Dean Herbert
91da546ba2
Merge branch 'master' into add-renderer-selection
2023-03-26 19:33:15 +09:00
Dean Herbert
c803eb8e04
Update framework
2023-03-26 16:14:15 +09:00
Dean Herbert
d31b37e87e
Merge branch 'master' into fix-ubo-not-bound
2023-03-26 16:14:11 +09:00
Joseph Madamba
eaef5ff2a3
Fix now playing playlist not highlighting selected item on initial open
2023-03-25 22:13:51 -07:00
Joseph Madamba
e1906a90eb
Use image@2x
from tournament banner api
2023-03-25 13:08:46 -07:00
Joseph Madamba
450c5cef07
Add comment explaining loading container padding
2023-03-24 18:42:34 -07:00
Terochi
e6f1ec57a9
Bring back and make use of clearPreviousSamples()
2023-03-23 18:46:48 +01:00
Dean Herbert
ab6cfea5c7
Revert old value instead of always using default
...
Co-authored-by: cdwcgt <loginchen@outlook.com>
2023-03-23 11:27:05 +09:00
cdwcgt
26f2d9047d
code style fix
2023-03-23 01:11:44 +09:00
cdwcgt
85a924f078
why
...
merge problem?
2023-03-23 01:02:17 +09:00
cdwcgt
8518d15b8d
use endpoint
2023-03-23 01:00:38 +09:00
Dean Herbert
3050a16bf8
Don't require a restart when selecting Automatic
and startup setting was also automatic
2023-03-22 16:56:36 +09:00
Dean Herbert
aabe86dc26
Limit renderers to those available for the current platform
2023-03-22 16:49:29 +09:00
Dean Herbert
956fabb445
Show restart notice when changing renderer
2023-03-22 16:49:29 +09:00
Dean Herbert
13be709718
Add basic renderer selection
2023-03-22 16:49:29 +09:00
Dean Herbert
ad5bdf6511
Merge branch 'master' into fix-ubo-not-bound
2023-03-22 16:46:39 +09:00
Dean Herbert
9bc6b46e4e
Update framework
2023-03-22 16:36:05 +09:00
Dean Herbert
db227b1798
Merge branch 'master' into chat-report
2023-03-22 16:26:28 +09:00
Joseph Madamba
6f3bb85eaa
Always show down arrow on inactive sort buttons
2023-03-22 00:19:23 -07:00
Dean Herbert
425be20e46
Fix song select search textbox font size incorrectly having increased
2023-03-22 14:17:39 +09:00
Joseph Madamba
d9571b6fc9
Move filter control property setters to load()
2023-03-21 21:31:35 -07:00
Joseph Madamba
74a15d7424
Fix overlay headers being blocked by loading layer
2023-03-21 20:32:26 -07:00
Joseph Madamba
e1fb63e1f3
Move beatmap listing filter control to header
2023-03-21 20:32:26 -07:00
Terochi
1478a26cc0
Addressed changes
2023-03-21 23:15:49 +01:00
Joseph Madamba
3cd01ee621
Fix beatmap listing sort direction not resetting when changing criteria
2023-03-21 15:08:37 -07:00
Joseph Madamba
df3ccdff9f
Add failing beatmap listing sort direction on criteria change test
2023-03-21 15:08:37 -07:00
Bartłomiej Dach
9ff9cd3b7f
Merge branch 'master' into skin-editor-cyclic-selection
2023-03-21 19:49:55 +01:00
Dean Herbert
e31a90e043
Don't cycle selection when more than one items are selected
2023-03-21 21:31:10 +09:00
Dean Herbert
5cb8160eee
Merge pull request #22773 from peppy/show-song-select-visible-beatmap-count
...
Show count of visible beatmaps at song select
2023-03-21 18:22:29 +09:00
Bartłomiej Dach
ea8da69263
Fix importing beatmaps not changing count of visible beatmaps
...
Reproduction steps:
1. Go to song select
2. Open beatmap listing
3. Import a beatmap that would fit the current filter criteria
4. The count of visible beatmaps does not change
Fixed by updating the count on `BeatmapSetsChanged` too.
2023-03-20 20:53:53 +01:00
Bartłomiej Dach
695ee39b87
Privatise setter
2023-03-20 20:30:54 +01:00
Dean Herbert
bec28cc7f1
Merge pull request #22883 from smoogipoo/fix-logo-animation
...
Use custom vertex shader for logo animation
2023-03-20 16:36:43 +09:00
Dean Herbert
8557589a35
Update resources
2023-03-20 15:28:13 +09:00
Joseph Madamba
970df5d88a
Update profile kudosu section in line with web
2023-03-18 19:49:30 -07:00
Dan Balasescu
c08513d590
Actually use custom vertex action
2023-03-17 20:47:11 +09:00
Dan Balasescu
bcd24873d6
Use custom vertex type
2023-03-17 20:37:05 +09:00
Dean Herbert
8bdb89d05d
Update resources
2023-03-17 19:12:43 +09:00
Dan Balasescu
1c3b60b9e6
Use custom vertex shader for logo animation
2023-03-16 23:56:41 +09:00
Salman Ahmed
678e8ed736
Update UBO usages inline with framework changes
2023-03-16 14:06:35 +03:00
Cootz
54f864463c
Merge branch 'master' into BitmapUpdatesOnScore
2023-03-16 13:54:47 +03:00
cdwcgt
d025c441ca
delay mod save after click save or not popover hidden
2023-03-16 19:48:45 +09:00
Dean Herbert
cb9b14b30f
Revert "Merge pull request #22741 from cdwcgt/do-not-fetch-deletePending"
...
This reverts commit 15c44a2817
, reversing
changes made to de2ab05e78
.
2023-03-16 19:48:36 +09:00
cdwcgt
42bcc8bafc
revert mod store
2023-03-16 19:38:15 +09:00
Cootz
556964eae0
Merge branch 'master' into BitmapUpdatesOnScore
2023-03-16 12:16:42 +03:00
Dean Herbert
3b62f87b64
Ensure Player
does not fail a score on exit if a replay is currently loaded
2023-03-16 17:14:20 +09:00
Dean Herbert
15c44a2817
Merge pull request #22741 from cdwcgt/do-not-fetch-deletePending
...
Don't fetch `beatmapset` that already `PendingDelete` when import score
2023-03-16 16:37:18 +09:00
Dean Herbert
cd102da3af
Move matches string inside text box
2023-03-16 16:34:31 +09:00
Dean Herbert
8e6a4559e3
Add xmldoc for new method and reorder methods in SkinReloadableDrawable
2023-03-16 15:58:42 +09:00
Dean Herbert
297e7d6542
Fix Flush
call being run too late in PoolableSkinnableSample
2023-03-16 15:33:30 +09:00
Dean Herbert
89b42ddd98
Don't localise beatmap count string for now
2023-03-16 15:02:38 +09:00
Dean Herbert
7b34607676
Merge branch 'master' into bubble_mod_implementation_clean
2023-03-16 13:45:22 +09:00
Terochi
edc6314634
Drank some coffee and figured out the fix
2023-03-15 10:49:59 +01:00
Dean Herbert
5f9b13a775
Rename Add
/AddRange
methods as they are no longer conflicting with Container
2023-03-15 18:02:41 +09:00
Dean Herbert
9e444af380
Use object initialisers and fix order of initialisation vs add
2023-03-15 18:02:26 +09:00
Terochi
b0f1a69523
Update the pauseLoop sample instantly on skin change
2023-03-15 09:05:34 +01:00
Terochi
a9c349fa6d
Cache any skin changes in SkinReloadableDrawable
to ScheduledDelegate
2023-03-15 09:03:29 +01:00
Dean Herbert
de2ab05e78
Merge pull request #22765 from Joehuu/fix-overlay-sidebar-scroll
...
Fix overlay sidebars not scrolling to end due to parent scroll view
2023-03-15 16:52:59 +09:00
Dean Herbert
0a19b1e9cf
Merge pull request #22860 from rozukke/fix-skin-ini-import
...
Fix import of skins with non-ASCII names that have been previously exported by lazer
2023-03-15 15:36:51 +09:00
Dean Herbert
f8e773ab8e
Merge branch 'master' into fix-overlay-sidebar-scroll
2023-03-15 15:30:50 +09:00
Dean Herbert
1cf870d956
Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection
2023-03-15 15:16:48 +09:00
Terochi
390ad335d0
Reloading samples before playing then when skin change occurs
2023-03-14 21:35:52 +01:00
Terochi
1d5e596615
Update FailAnimation
to use SkinnableSound
2023-03-14 20:44:30 +01:00
Dean Herbert
f91af8fa64
Merge pull request #22750 from smoogipoo/veldrid-renderer
...
Update graphic code in line with framework renderer changes
2023-03-15 00:29:54 +09:00
Dean Herbert
6546f5968a
Merge branch 'master' into skin-editor-cyclic-selection
2023-03-14 20:43:56 +09:00
Dean Herbert
b46fc14e56
Merge pull request #22848 from Rovearix/Fix-Dragging-Preventing-Beatmap-Loading
...
Prevent LoadingLayer from blocking loading
2023-03-14 20:42:10 +09:00
Dean Herbert
d65d09e45f
Change field to const
2023-03-14 20:24:39 +09:00
Dean Herbert
8fd07b51f7
Merge pull request #22842 from LumpBloom7/Fix-argon-progress-bar-oversized-fill
...
Fix argon progress bar fill being oversized
2023-03-14 18:46:25 +09:00
Dean Herbert
4cea29402b
Don't show epilepsy warning when storyboards are disabled
...
I have more thoughts on this warning in general (which will likely see
it removed or moved in the future) but this seems like a quick QOL fix
for now.
As mentioned in https://github.com/ppy/osu/discussions/22861 .
2023-03-14 18:32:26 +09:00
Dean Herbert
0b23809585
Update resources
2023-03-14 17:52:17 +09:00
Dean Herbert
48d11610b3
Update framework
2023-03-14 17:44:51 +09:00
Dean Herbert
969c0e9c9d
Merge branch 'master' into veldrid-renderer
2023-03-14 17:35:38 +09:00
Rovearix
9ac9287dbd
Switched the implementation to set the blockInput flag for the BeatmapMetadataDisplay's LoadingLayer. This prevents the UIEvents from being being handled in this case without modifying the class
2023-03-13 08:07:55 -04:00
Rovearix
ba728bdab1
Changed the event to be the more correct one to block
2023-03-13 07:49:51 -04:00
rozukke
1f7721786b
Perform check to account for non-ASCII characters
2023-03-13 22:01:26 +11:00
Dean Herbert
da947d8661
Gracefully handle beatmaps specifying images using the video storyboard type
2023-03-13 18:24:16 +09:00
Dean Herbert
eb37d740b1
Update supported video filetypes to match osu-stable
2023-03-13 18:24:16 +09:00
Rovearix
c1618a7a16
Prevent elements that are anchored in the center from blocking loading
2023-03-12 10:57:53 -04:00
Joseph Madamba
6e5b1280b7
Fix multiple notice boxes having no spacing
2023-03-11 21:36:29 -08:00
Joseph Madamba
ea88aee41f
Display stub notice in marked wiki articles
2023-03-11 21:36:28 -08:00
Joseph Madamba
0cf69a1084
Make yaml line strings verbatim
2023-03-11 21:36:23 -08:00
Derrick Timmermans
febdca4547
Fix argon progress bar fill being oversized
2023-03-12 02:08:00 +01:00
Terochi
8e8dda3ac0
Big simplifying
2023-03-11 23:29:36 +01:00
Dan Balasescu
e327993d11
Merge pull request #22527 from Terochi/replay-length-extension
...
Replay recording extension until results screen transition
2023-03-11 15:41:32 +09:00
cdwcgt
15f11bb1e8
scorll container and save mod after popover hidden
...
Requires manual handling of many visual effects
2023-03-11 12:31:33 +09:00
cdwcgt
1cd565193e
public CheckCurrentModCanBeSave
2023-03-11 11:39:35 +09:00
cdwcgt
8b0f127ff2
split ModPresetRow
2023-03-11 11:25:52 +09:00
Terochi
b51c41a804
Addressed changes
2023-03-09 20:14:58 +01:00
cdwcgt
f4e2620402
fix test
2023-03-10 00:56:22 +09:00
cdwcgt
ca416175bb
remove useless property
2023-03-09 22:58:44 +09:00
cdwcgt
3d746e8dfb
content Menu
2023-03-09 22:49:33 +09:00
cdwcgt
5a1316f0e5
split save logic
2023-03-09 22:43:06 +09:00
tsrk
d806b85a30
revert: make counters
an IEnumerable
again
...
As suggested by bdach as this would make the last two commits useless
Refs: 5d15426
2023-03-09 10:25:03 +00:00
Dean Herbert
d95bcb10cc
Merge pull request #22744 from EXtremeExploit/groups-badges-list
...
Add group badges to list view
2023-03-09 15:45:46 +09:00
Bartłomiej Dach
ab87f5e0c9
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-08 22:37:09 +01:00
EXtremeExploit
686259a33c
Make support badge in list match groups
2023-03-08 13:57:20 -03:00
Dean Herbert
4f7be332f3
Revert isDraggingBlueprint
to field
2023-03-08 19:24:03 +09:00
Dean Herbert
245c3c025c
Refactor endClickSelection
to reduce nesting
2023-03-08 19:23:32 +09:00
tsrk
5d15426c27
refactor: make Counters
return a Container
2023-03-08 01:52:12 +00:00
tsrk
5b0db94a24
docs: add XMLDoc for methods in KCD
2023-03-08 00:58:54 +00:00
tsrk
44297a7d0a
refactor: make KCD a CompositeDrawable
2023-03-08 00:47:16 +00:00
Bartłomiej Dach
72695f7c90
Merge branch 'master' into omit-barline-in-timing-control-point
2023-03-07 22:46:24 +01:00
Bartłomiej Dach
6c5ccdfd90
Merge branch 'master' into optimise-search
2023-03-07 22:07:29 +01:00
Bartłomiej Dach
12af002c4d
Reorder and add xmldoc to KeyCounter
members
2023-03-07 21:28:42 +01:00
Bartłomiej Dach
98f40b2679
Improve documentation of InputTrigger
2023-03-07 21:22:59 +01:00
Bartłomiej Dach
5213bfa5c9
Merge branch 'master' into make_skin_reset_dangerous
2023-03-07 21:06:44 +01:00
Terochi
8bf84869a5
Fixed errors covered in new tests
2023-03-07 20:39:50 +01:00
Bartłomiej Dach
cfafa8af8c
Merge branch 'master' into hud/player-components
2023-03-07 19:44:12 +01:00
Bartłomiej Dach
7ade525eef
Display corner radius setting as percentage
2023-03-07 19:43:52 +01:00
Cootz
5d41d343fd
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-07 15:46:52 +03:00
Cootz
7107834b9e
Fix truncating bug
2023-03-07 15:43:03 +03:00
Cootz
5191204569
Bring truncating logic back to Export
method
2023-03-07 15:39:43 +03:00
cdwcgt
54564e0557
new design
2023-03-07 21:13:35 +09:00
Dean Herbert
97bee4db89
Fix localisations
2023-03-07 18:07:53 +09:00
Dean Herbert
26ef7c2637
Rename confirmation dialog class to mention revert
not reset
2023-03-07 18:07:46 +09:00
Dean Herbert
55467fcbe3
Update xmldoc for DangerousActionDialog
to match new behaviour
2023-03-07 18:07:46 +09:00
Dean Herbert
dc2945f4f8
Move avatar user loading to BDL also
2023-03-07 17:39:21 +09:00
Dean Herbert
5af41bb1c8
Move filter matching code into own method to simplify early returns
2023-03-07 17:24:17 +09:00
Dean Herbert
5e90b67be0
Move GameplayState
usage to BDL
2023-03-07 17:01:29 +09:00
Dean Herbert
d98199961b
Adjust default sizing to fit a bit better with existing elements
2023-03-07 17:00:10 +09:00
Dean Herbert
f7f1dff647
Fix incorrect case of localisable string for "corner radius"
2023-03-07 16:45:33 +09:00
Dean Herbert
6a7c4d0bf7
Remove NRT
disables in new classes
2023-03-07 16:41:39 +09:00
Dean Herbert
97ba236eb1
Add basic xmldoc to KeyCounter
classes
2023-03-07 16:41:39 +09:00
Dean Herbert
28520414aa
Move KeyCounter
components to HUD
namespace
2023-03-07 16:41:39 +09:00
Dean Herbert
15d65059b5
Tidy up Add
method logic
2023-03-07 16:21:57 +09:00
Dean Herbert
8f6df5ea0f
Merge branch 'master' into gameplay/key-counter-abstraction
2023-03-07 16:09:45 +09:00
Dean Herbert
2cce785fa5
Fix storyboard videos not fading out on completion
...
Closes https://github.com/ppy/osu/issues/22802 .
Stable uses a 1,000 ms fade-in / out. Rather than matching that, I've
stuck with 500ms (what lazer was already using for the fade-in) because
I think it feels better.
Tested using the beatmap linked in the issue thread.
2023-03-07 15:54:35 +09:00
Dean Herbert
21bdbb20e6
Add optional support for cyclic selection to BlueprintContainer
2023-03-07 14:22:12 +09:00
tsrk
fc0e27fb15
style: use normalised CornerRadius
values
2023-03-06 20:11:52 +00:00
tsrk
952814604e
style: fix late night oopsies
2023-03-06 20:06:56 +00:00
cdwcgt
4858d3fd42
Added ability to edit mod presets
2023-03-07 02:00:40 +09:00
Bartłomiej Dach
ec15e2b9cc
Merge branch 'master' into dont-filter-results-on-sort-mode
2023-03-06 17:57:47 +01:00
OliBomby
1fcf41379d
Added maintainability patch by bdach
2023-03-06 16:20:36 +01:00
tsrk
3a240aaa5f
style: use 64 radius
2023-03-06 10:27:59 +00:00
Dean Herbert
87d0bef313
Use nullable comparison helper method instead of manual implementation
2023-03-06 15:16:32 +09:00
tsrk
07bde4990d
feat: implement PlayerAvatar
2023-03-05 23:17:39 +00:00
tsrk
20a610ea6c
style: a NRT pass on UpdateableFlag
2023-03-05 23:15:58 +00:00
tsrk
654eacd449
feat(l10n): localise CornerRadius
2023-03-05 23:10:42 +00:00
tsrk
082bfe3621
refactor: SkinnableAvatar
to PlayerAvatar
2023-03-05 23:09:02 +00:00
mk56-spn
908651cc11
make ResetConfirmDialog
properly utilise its parent's logic
...
Adjust name of `DeleteAction` to `DangerousAction`
2023-03-05 20:57:26 +01:00
OliBomby
b0cd801405
fix code quality
2023-03-04 19:34:22 +01:00
OliBomby
5146f7c978
using array again in GetSearchableTerms
2023-03-04 16:49:46 +01:00
OliBomby
70a925aab1
added extra early-returns
2023-03-04 16:49:33 +01:00
OliBomby
b90c389ff0
using List instead of Span in GetSearchableTerms
2023-03-04 15:42:35 +01:00
Bartłomiej Dach
60cdd3c070
Clear components sidebar unconditionally on every target change
...
Fixes the working layer dropdown lingering after exiting from a
skinnable screen to a non-skinnable one.
2023-03-04 14:10:05 +01:00
Bartłomiej Dach
d233f3a3ab
Show non-skinnable screen placeholder at higher level
2023-03-04 13:49:10 +01:00
Bartłomiej Dach
49e298e304
Accept ISerialisableDrawableContainer
directly in SkinBlueprintContainer
...
An end result of #22674 is that `SkinBlueprintContainer`s are only ever
created by supplying a `SkinComponentsContainer` to them. However,
`SkinBlueprintContainer` still contained remnants of code that suggested
it was designed to handle cases where more than the drawable supplied to
it contained more than one `ISerialisableDrawableContainer`, or even
zero.
The zero path is totally dead right now (because every
`SkinComponentsContainer` is *by necessity* an
`ISerialisableDrawableContainer`), and the more-than-one path is dead
*for now* (and potentially forever?). Therefore, just hard-couple
`SkinBlueprintContainer` to receive a single target container.
2023-03-04 13:33:21 +01:00
Bartłomiej Dach
2f25fb4083
Move NonSkinnableScreenPlaceholder
to outer scope
2023-03-04 13:22:43 +01:00
Bartłomiej Dach
15409b9c15
Fix skin selection not clearing on exit to non-skinnable screen
2023-03-04 13:18:34 +01:00
tsrk
d5ba5eed88
fix(SkinnableAvatar): init avatar.CornerRadius
2023-03-03 23:47:22 +00:00
tsrk
d39b8c7c23
fix(SkinnableAvatar): update outdated interface
2023-03-03 19:35:45 +00:00
EXtremeExploit
edd37a9a7c
cleanup
2023-03-03 16:16:45 -03:00
EXtremeExploit
e23db62386
Do list group'badges in a nicer way
2023-03-03 16:14:19 -03:00
Ruki
e75aa9138b
Merge branch 'ppy:master' into hud/avatar-thing
2023-03-03 20:03:56 +01:00
OliBomby
91d206e8d2
Optimised GetSearchableTerms
...
Reduced memory allocations to 1
2023-03-03 19:21:50 +01:00
Cootz
322f3e86ba
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-03 20:02:09 +03:00
mk56-spn
3bff415909
Change ResetDialogue
text
2023-03-03 15:16:48 +01:00
mk56-spn
2b7111867c
Adjust reversion header text naming.
2023-03-03 15:12:20 +01:00
Dean Herbert
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
Dean Herbert
dc669835e2
Show count of visible beatmaps at song select
2023-03-03 15:28:51 +09:00
Dean Herbert
6ff1fb6b1a
Adjust sizing to allow for timing point information now being longer than before
2023-03-02 18:57:54 +09:00
Joseph Madamba
af540de69b
Fix "talking with" text overflowing when usernames are too long
2023-03-01 22:10:15 -08:00
Joseph Madamba
bb5791a714
Fix overlay sidebars not scrolling to end due to parent scroll view
2023-03-01 21:41:01 -08:00
Dean Herbert
bd11d5d29a
Merge pull request #22743 from Joehuu/scroll-back-to-previous
...
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
Andrei Zavatski
31f58a33ac
Use ColourInfo.Interpolate where possible
2023-02-28 18:47:27 +03:00
Dean Herbert
044b0604b2
Move OmitFirstBarLine
to TimingControlPoint
2023-02-28 19:29:31 +09:00
Dean Herbert
89e20a7962
Update resources
2023-02-28 14:47:51 +09:00
Dean Herbert
bd1460a8d5
Update framework
2023-02-28 14:32:58 +09:00
mk56-spn
90227a6496
Rename DeleteConfirmationDialog.cs
into DangerousActionDialog.cs
2023-02-27 21:57:59 +01:00
mk56-spn
00a00ead22
Make ResetConfirmDialog
inherit from DeleteConfirmationDialog
2023-02-27 21:50:27 +01:00
mk56-spn
1239de6f41
Upper case web using
alias
2023-02-27 21:34:07 +01:00
Bartłomiej Dach
92edb0f868
Merge branch 'master' into skin-editor-depth-changing
2023-02-27 19:24:53 +01:00
mk56-spn
bf1897a98f
Adjust warning text slightly.
2023-02-27 16:08:14 +01:00
EXtremeExploit
d722e09b2c
oops
2023-02-26 21:05:41 -03:00
EXtremeExploit
2b9d13cfee
Add group badges to list view
2023-02-26 20:58:20 -03:00
Joseph Madamba
fa710ae1b0
Rename ScrollToTopButton
to ScrollBackButton
2023-02-26 14:39:34 -08:00
Joseph Madamba
dc00905f8d
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-02-26 14:38:51 -08:00
mk56-spn
ff0d1aa9f7
Make reverting changes to a given skin into a "dangerous action"
2023-02-26 20:38:50 +01:00
cdwcgt
a705698ab6
beatmapset that already deletePending should not be fetched
2023-02-26 21:13:05 +09:00
cdwcgt
1d5c87039e
typo
2023-02-26 15:28:43 +09:00
cdwcgt
e8092bff46
logic fix?
2023-02-26 15:28:24 +09:00
cdwcgt
fdf9544688
cancel handle
2023-02-26 15:28:10 +09:00
cdwcgt
a20e2685be
make static name fix
2023-02-25 20:11:08 +09:00
Dan Balasescu
a44c9d10d7
Fix buffer not being bound
2023-02-25 02:18:42 +09:00
Dan Balasescu
069b77dd23
Update language version
2023-02-25 02:15:56 +09:00
Dan Balasescu
dd9748a25c
Adjust DrawNodes to use UBOs
2023-02-25 01:42:55 +09:00
Terochi
09e7c21b23
Implemented a more complex setting conversion logic + tests
2023-02-24 15:11:22 +01:00
cdwcgt
78201c4649
log to database
2023-02-23 22:17:35 +09:00
cdwcgt
60bdae41b6
make static
2023-02-23 22:17:13 +09:00
Dean Herbert
dc3c1150b8
Set better defaults for SkinBlueprint
transforms
2023-02-23 21:10:15 +09:00
cdwcgt
9e1eb50d9b
use log
2023-02-23 20:21:04 +09:00
cdwcgt
ba345e5591
delete notify post when duplicate export
2023-02-23 20:10:50 +09:00
Dean Herbert
c48aceb055
Fix undo history not being batched correctly for depth change operations
2023-02-23 20:03:36 +09:00
Bartłomiej Dach
d679703fa2
Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
...
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
tsrk
8c94b77de1
refactor(InputTrigger): move out of KCD
...
I love JetBrains Rider.
2023-02-22 15:05:07 +00:00
tsrk
1beec71037
refactor(KeyCounterDisplay): apply suggestions
...
I also took the freedom to add type checking, as we can't limit the
usage of `Add()` since it's a Container. The exception thrown also
advises of using the suggested `AddTrigger()` instead.
2023-02-22 14:58:27 +00:00
Dean Herbert
a8c692a215
Merge pull request #22635 from peppy/use-overlays-container-more
...
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
Dean Herbert
16c8a392a1
Add ability to send selected skin components to front or back
2023-02-22 18:17:20 +09:00
Dean Herbert
6e48860c79
Update in line with framework menu handling changes
2023-02-22 17:13:55 +09:00
Terochi
e321536acc
Small clean up
2023-02-22 07:48:43 +01:00
Terochi
82b07d19f8
Fix of incorrect using
optimization
2023-02-21 21:48:11 +01:00
Bartłomiej Dach
051eb18b33
Merge branch 'master' into skin-editor-layer-select
2023-02-21 21:38:51 +01:00
Bartłomiej Dach
ab97b02235
Remove contradictory remark from xmldoc
2023-02-21 21:05:46 +01:00
Terochi
dd53a70071
Addressed change requests
2023-02-21 21:01:31 +01:00
Bartłomiej Dach
3d2fcb0cca
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 20:53:06 +01:00
tsrk
42a5a06b9d
style(KeyCounter): fields and methods visiblity
2023-02-21 19:10:37 +00:00
tsrk
5bec2d7c52
style(KeyCounter): forwardPlayback
2023-02-21 19:02:56 +00:00
Bartłomiej Dach
ec1bf7b0b2
Merge branch 'master' into skin-editor-clipboard
2023-02-21 19:35:58 +01:00
Terochi
191604340f
Added a way for mod settings to be kept when changing ruleset + test
2023-02-21 19:05:10 +01:00
Cootz
1fa6864500
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-21 18:47:59 +03:00
Cootz
90aa4288d0
Reduce the allowed length by 5 to account for (99) suffix. Move truncating logic to GetFilename
. Update tests.
2023-02-21 18:35:53 +03:00
cdwcgt
d20e1df603
wrong xmldoc
...
because of 6900d0120a
2023-02-21 20:54:06 +09:00
cdwcgt
04dcd661e0
async logic fix
2023-02-21 20:53:02 +09:00
Dean Herbert
9384687d6d
Switch ModMuted
to add its metronome to components rather than overlays
2023-02-21 19:04:06 +09:00
Dean Herbert
1acc536248
Move DrawableRuleset.Audio
to a less generic level
2023-02-21 19:03:52 +09:00
Dean Herbert
af062e7a68
Change placeComponent
to only add to selection, not clear an existing selection
2023-02-21 14:11:18 +09:00
Dean Herbert
5ba6059911
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 13:58:15 +09:00
Dean Herbert
0d229d959b
Remove unnecessary TriggerChange
call
2023-02-21 13:50:19 +09:00
Bartłomiej Dach
6799492596
Merge branch 'master' into skin-editor-layer-select
2023-02-20 21:33:48 +01:00
Bartłomiej Dach
86a7f4dfd0
Do not serialise SkinLayoutInfo.AllDrawables
...
- It is entirely derived from `SkinLayoutInfo.DrawableInfo`, which is
the actual primary thing we want to serialise.
- It will never get read out from any serialised files anyway (corollary
of the previous point - it is a get-only property derived from another).
- It is only used in tests.
All of the three reasons above make serialising the property out to skin
files nothing more than a waste of space.
2023-02-20 20:37:48 +01:00
Bartłomiej Dach
c9999bdeb1
Merge branch 'master' into skin-per-ruleset-layouts
2023-02-20 20:14:38 +01:00
Bartłomiej Dach
43724472c4
Clarify comment to avoid playing pronoun game
2023-02-20 20:09:24 +01:00
Dean Herbert
6382314af1
Merge pull request #22697 from ggliv/tablet-area-drag
...
Allow tablet area to be dragged
2023-02-20 23:37:25 +09:00
Dean Herbert
43d33d45ca
Only add valid placed components to selected collection on paste
2023-02-20 20:02:43 +09:00
Dean Herbert
b68562b033
Make placeComponent
resilient to missing dependencies
2023-02-20 20:00:12 +09:00
Dean Herbert
a9c7edd087
Remove copy pasted comment
2023-02-20 19:57:16 +09:00
Dean Herbert
7a585e1fa1
Merge pull request #22669 from EVAST9919/mod-overlay-triangles
...
Add triangles animation to mod select overlay headers
2023-02-20 19:54:21 +09:00
Dean Herbert
ec12186d63
Remove unnecesasry null check on content
2023-02-20 19:53:04 +09:00