8639 Commits

Author	SHA1	Message	Date
Stedoss	826c82de47	Add unit test for handling login state in UserProfileOverlay	2023-11-21 01:56:37 +00:00
Bartłomiej Dach	c16afeb347	Fix tests	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	b6e3e42445	Merge branch 'master' into bspline-sliders	2023-11-20 12:03:29 +09:00
Dean Herbert	f7fa9c90d6	Add test coverage of 2FA flow	2023-11-16 18:18:40 +09:00
Dean Herbert	e9d4cf2e24	Setup basic form flow	2023-11-16 18:18:15 +09:00
Dean Herbert	87a76b9ee8	Merge pull request #25478 from Joehuu/fix-comment-markdown ... Fix `CommentMarkdownTextFlowContainer` not inheriting osu! class	2023-11-16 17:39:35 +09:00
Bartłomiej Dach	1e2f1b3ef2	Merge branch 'master' into unload-main-menu-storyboard	2023-11-16 15:46:44 +09:00
Joseph Madamba	dc2d574965	Fix comment markdown image not showing tooltips	2023-11-15 19:50:32 -08:00
Joseph Madamba	2b19cf6ce4	Fix comment markdown style regression	2023-11-15 19:50:32 -08:00
Dean Herbert	7f90db7603	Merge pull request #25472 from bdach/argon-health-folding-in-on-self ... Fix argon health bar folding in on itself when too narrow	2023-11-15 19:02:30 +09:00
Dean Herbert	189fca2eb6	Merge pull request #25339 from joshika39/change-clickable-avatars-tooltip-for-usergrid ... Add `UserGridPanel` as the `ClickableAvatar` tooltip	2023-11-15 18:01:24 +09:00
Bartłomiej Dach	71714f8f6e	Add back test step for testing out argon health bar width	2023-11-15 13:33:14 +09:00
cs	fa976a5aa0	Fix code style/quality issues	2023-11-13 08:25:27 +01:00
Poyo	8c36604e58	Add rate-change UR tests	2023-11-12 11:16:06 -08:00
Poyo	d123ba5bce	Fix broken tests	2023-11-12 11:13:38 -08:00
Dean Herbert	31feeb5ddc	Disable new rider EAP inspection in test class	2023-11-12 17:21:17 +09:00
Bartłomiej Dach	3e8c89e282	Fix one more reference to removed setting	2023-11-12 07:42:41 +09:00
cs	54b8244a18	CI Fixup	2023-11-11 15:02:06 +01:00
Thomas Müller-Höhne	926636cc03	Generalize Bezier curves to BSplines of Nth degree	2023-11-11 13:32:53 +01:00
Bartłomiej Dach	ea556abad8	Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters	2023-11-11 21:28:29 +09:00
Bartłomiej Dach	ee56b4d205	Use barely better assertion fail message in test	2023-11-11 20:56:05 +09:00
Bartłomiej Dach	b7972e3c84	Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters	2023-11-11 20:16:14 +09:00
Bartłomiej Dach	b247b94ecb	Revert test changes ... They were broken because `SerialisedDrawableInfo` is a reference type and as such equality checks will use reference equality rather than member equality.	2023-11-11 19:32:46 +09:00
Bartłomiej Dach	21e1d68b15	Remove unused using directive	2023-11-11 15:52:24 +09:00
Dean Herbert	2e48569982	Improve test comparison logic ... Doesn't really help that much with nunit output, but at least you can breakpoint and see the json kinda.	2023-11-10 20:00:51 +09:00
Bartłomiej Dach	b6dcd7d55f	Fix tests so that they actually assert something	2023-11-10 18:48:45 +09:00
Bartłomiej Dach	ec2200d54f	Remove another reference to bar length	2023-11-10 18:26:08 +09:00
Bartłomiej Dach	c522a703eb	Merge branch 'master' into skin-size-editing	2023-11-10 18:19:27 +09:00
Dean Herbert	35e11c7c63	Rename diagonal scale variable and update xmldoc	2023-11-10 17:55:02 +09:00
Bartłomiej Dach	d0f1326a63	Fix formatting	2023-11-10 17:54:48 +09:00
Bartłomiej Dach	8690b08769	Fix compose select box test failures	2023-11-10 16:08:45 +09:00
Dean Herbert	7fc2050f72	Rename variables and mak seconary tooltip type work again	2023-11-10 11:52:34 +09:00
Salman Ahmed	d3af3c615f	Merge branch 'master' into gameplay-hud-redesign/counters	2023-11-10 01:04:03 +03:00
Salman Ahmed	cc9aeb5307	Add test coverage	2023-11-09 22:57:20 +03:00
Salman Ahmed	d4722a3988	Add failing test case	2023-11-09 17:20:10 +03:00
Joshua Hegedus	4900a91c60	fixed static analysis problems and finished the implementation	2023-11-09 13:27:09 +01:00
Joshua Hegedus	ccb9ff826a	fixed tests	2023-11-09 13:09:59 +01:00
Dean Herbert	02966bc02f	Merge branch 'master' into change-clickable-avatars-tooltip-for-usergrid	2023-11-09 18:19:23 +09:00
Bartłomiej Dach	13b599b9b6	Merge branch 'master' into less-basic-touchscreen-detection	2023-11-09 17:36:48 +09:00
Dean Herbert	5ac285ed2f	Merge pull request #25380 from frenzibyte/fix-create-difficulty-crash ... Fix editor crash when creating a new difficulty in a non-existent beatmap	2023-11-08 18:56:00 +09:00
Dean Herbert	38847c3ac5	Change test to move only on a toggle step	2023-11-08 17:23:01 +09:00
Salman Ahmed	18c71c95cc	Merge branch 'master' into gameplay-hud-redesign/counters	2023-11-08 02:12:37 +03:00
ratinfx	81caa854e6	Separate Test cases by relevant rulesets	2023-11-07 13:02:46 +01:00
ratinfx	aa87e0a44d	HitObject Selection logic and separation for gamemodes ... + moved time_regex into EditorTimestampParser	2023-11-07 01:36:58 +01:00
ratinfx	8e8a88cfaf	Removed nullable line from Test	2023-11-07 00:54:15 +01:00
Salman Ahmed	38d16f620c	Alter test case to comply with new behaviour	2023-11-06 21:55:00 +03:00
Salman Ahmed	944fee56f8	Add failing test case	2023-11-06 21:54:40 +03:00
Andrei Zavatski	9d10d93085	Adjust test scene to see graph flickering	2023-11-06 20:45:52 +03:00
Joshua Hegedus	a01f6187f4	testing the tooltip	2023-11-06 14:52:06 +01:00
Joshua Hegedus	718492a0b7	fixed DRY	2023-11-06 11:29:15 +01:00
Joshua Hegedus	b45d8c785c	fixed review findings	2023-11-06 08:38:34 +01:00
Bartłomiej Dach	adb9ca5a13	Add failing test coverage for incorrect treatment of TD in mod presets	2023-11-06 07:56:09 +01:00
Salman Ahmed	634795e45f	Adjust failing test scenes	2023-11-05 02:50:14 +03:00
Salman Ahmed	1d4f4cf4c3	Merge branch 'master' into gameplay-hud-redesign/counters	2023-11-05 02:02:36 +03:00
Salman Ahmed	58a830fc5b	Revert "Add "Argon" performance points counter" ... This reverts commit 56eeb117ce.	2023-11-05 01:55:54 +03:00
ratinfx	7492d953ae	Moved error checks into Editor ... - Invoke Action on error to Notify user - added some comments	2023-11-04 21:17:58 +01:00
Joshua Hegedus	ec290ae953	added tests	2023-11-04 19:03:23 +01:00
ratinfx	19cdf99df8	Fixed up tests	2023-11-04 12:04:58 +01:00
ratinfx	f867cff8c7	Added OpenEditorTimestamp Tests	2023-11-04 03:42:08 +01:00
Joseph Madamba	3f8baf913b	Add 100 and 1000 key press step to test overflow	2023-11-02 20:49:01 -07:00
Joseph Madamba	e3b3ce6c84	Fix test overflowing on widescreen + add default (triangles) key counter testing	2023-11-02 20:42:28 -07:00
Joseph Madamba	090601b485	Apply peppy's upright key counter attempt diff ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-11-02 20:42:23 -07:00
Bartłomiej Dach	d25b54c06d	Split test into two ... They would fail on CI when written as one, and I don't care why.	2023-11-02 22:14:38 +01:00
Bartłomiej Dach	ef555ed0cf	Fix test failures	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	21a4da463b	Add failing test covering crash scenario	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	29d4d81eaa	Add test scene for basic touchscreen detection scenarios	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	2f6ff893b5	Automatically activate and deactivate touch device mod in song select	2023-11-02 19:45:48 +01:00
Bartłomiej Dach	980c900f43	Add component for game-wide touch detection	2023-11-02 19:32:56 +01:00
Dean Herbert	8c067dc584	Fix mod tests not waiting for presets to finish loading ... See https://github.com/ppy/osu/actions/runs/6692350567/job/18181352850.	2023-10-31 14:53:07 +09:00
Dean Herbert	7ceced7012	Scope TestPauseWithLargeOffset to focus on what matters ... See https://github.com/ppy/osu/actions/runs/6693917410/job/18186111009 This test is to make sure we don't seek before the original pause time, so I've exposed that value precisely to avoid CI woes.	2023-10-31 14:47:04 +09:00
Dean Herbert	d379e553da	Fix back-to-front logging	2023-10-31 14:31:26 +09:00
Dean Herbert	bdd3f2847b	Add an extra storyboard sample to avoid intermittent failures in TestStoryboardSamplesStopOnSkip ... Probably CI running slow timing balls. The point of failure is `waitUntilStoryboardSamplesPlay()` after already testing the important part of the test (that the samples stop on skip) so let's give it another possible point to recover. See https://github.com/ppy/osu/actions/runs/6698399814/job/18201753701.	2023-10-31 14:28:40 +09:00
Dean Herbert	66b84d02cb	Add note about TestGameplayExitFlow failure, and ignore for now ... See: https://github.com/ppy/osu/actions/runs/6695995685/job/18194110641 https://github.com/ppy/osu/actions/runs/6700910613/job/18208272419	2023-10-31 14:27:55 +09:00
Dean Herbert	89444d5544	Fix export test still occasionally failing due to file write in progress ... https://github.com/ppy/osu/actions/runs/6701591401/job/18209826074 Basically, `File.Move` may not be an atomic operation.	2023-10-31 14:00:49 +09:00
Dean Herbert	37ec10d4f5	Fix TestSongSelectScrollHandling not waiting for VolumeOverlay to load ... See https://github.com/ppy/osu/actions/runs/6701786492/job/18210372721.	2023-10-31 13:49:53 +09:00
Dean Herbert	fa220d34de	Merge pull request #25272 from frenzibyte/use-scale-adjust-for-player-max-dimensions-test-scene ... Fix `TestScenePlayerMaxDimensions` texture loading process bottlenecking CI	2023-10-31 13:36:30 +09:00
Dean Herbert	a3dc9a73b1	Revert behaviour changes of MaxDimensions test and ignore instead	2023-10-31 13:36:10 +09:00
Dean Herbert	3060cf1438	Merge pull request #25286 from frenzibyte/search-text-box-select-all ... Automatically select existing search text when opening settings	2023-10-31 12:14:00 +09:00
Bartłomiej Dach	06508d08fe	Delete outdated test	2023-10-30 20:22:41 +01:00
Bartłomiej Dach	b2d3aa982d	Merge branch 'master' into fix-click-through-timeline	2023-10-30 12:52:00 +01:00
Dean Herbert	8828562512	Merge pull request #25277 from Susko3/fix-cut-in-filter-textbox ... Fix cut and copy not working in song select search filter textbox	2023-10-30 18:18:46 +09:00
Dean Herbert	63e6eaf538	Fix failing tests	2023-10-30 18:06:11 +09:00
Dean Herbert	6be02966b9	Add test coverage of failing context menu display	2023-10-30 18:06:11 +09:00
Dean Herbert	caddbacfe8	Merge branch 'master' into gameplay-hud-redesign/counters	2023-10-30 16:35:10 +09:00
Salman Ahmed	c7bc8e6865	Move behaviour to settings search text box only	2023-10-30 06:41:01 +03:00
Salman Ahmed	af10dbb76c	Add test case with many tournament banners	2023-10-30 06:20:01 +03:00
Salman Ahmed	ec9ae12bbd	Update API response model to accept array of tournament banners	2023-10-29 01:43:49 +03:00
Salman Ahmed	31c6973bb6	Add test coverage	2023-10-29 01:03:45 +03:00
Susko3	cfc0520481	Add failing test	2023-10-28 12:13:13 +02:00
Salman Ahmed	a53c0adae0	Remove unused using directive	2023-10-28 06:56:12 +03:00
Salman Ahmed	51b7c97cab	Fix TestScenePlayerMaxDimensions bottlenecking CI	2023-10-28 06:07:49 +03:00
Dean Herbert	5a9d4170e8	Merge pull request #24794 from bdach/score-encoding-cleanup ... Correctly handle multiple online score ID types	2023-10-28 02:29:56 +09:00
Dean Herbert	4ed30342db	Merge pull request #25264 from bdach/quick-retry-f-rank ... Fix quick retry immediately after completion marking score as failed	2023-10-28 02:29:21 +09:00
Bartłomiej Dach	b5cb538004	Add failing test case for skin editor freeze	2023-10-27 14:23:41 +02:00
Bartłomiej Dach	6789a522d6	Rename test to distinguish it from test-to-come	2023-10-27 14:15:30 +02:00
Bartłomiej Dach	32fc19ea0d	Fix results screen test failure	2023-10-27 13:22:17 +02:00
Bartłomiej Dach	96d784e06b	Delete ScoreInfo.HasReplay as no longer needed	2023-10-27 12:39:54 +02:00
Bartłomiej Dach	3944b045ed	Add extra test coverage for marking score as failed	2023-10-27 12:17:03 +02:00
Bartłomiej Dach	7140eee870	Add failing test coverage for quick retry after completion not changing rank	2023-10-27 12:17:03 +02:00
Dean Herbert	a463c37320	Merge pull request #25243 from bdach/song-select-volume-scroll-blocked ... Fix left side of carousel blocking volume adjust hotkeys	2023-10-27 00:23:47 +09:00
Bartłomiej Dach	5d6a58d443	Add failing test scene for scroll handling in song select	2023-10-26 16:24:16 +02:00
Bartłomiej Dach	89fec95b01	Fix cross-test data dependency by recreating slider every time	2023-10-26 12:11:26 +02:00
Bartłomiej Dach	96437c4518	Fix tests specifying float precision for double bindable ... Would cause assignments to `.Value` to become imprecise even if the underlying bindable could represent the value 100% accurately.	2023-10-26 12:06:03 +02:00
Bartłomiej Dach	910d74fdda	Add failing test coverage for double-click on disabled sliders	2023-10-26 11:59:38 +02:00
Salman Ahmed	df80b4dcab	Update "Argon" health display specifications to match design ... Also adds a little white bar next to the display to match with the components below it (score/accuracy/combo counters).	2023-10-26 09:12:05 +03:00
Salman Ahmed	56eeb117ce	Add "Argon" performance points counter	2023-10-26 09:10:10 +03:00
Salman Ahmed	0aa0562dc0	Add "Argon" combo counter	2023-10-26 09:09:55 +03:00
Salman Ahmed	1f36acca1a	Add "Argon" accuracy counter	2023-10-26 09:09:52 +03:00
Salman Ahmed	9ca672d689	Add "Argon" total score counter	2023-10-26 08:58:25 +03:00
Dean Herbert	6934e045df	Fix editor not prompting before saving beatmap for export	2023-10-25 14:39:46 +09:00
Andrei Zavatski	1dbdbd6de6	Merge branch 'master' into comments-image-size	2023-10-23 13:22:31 +03:00
Bartłomiej Dach	dcfd6a0a8a	Remove DistancedHitObjectComposer inheritance from osu! composer	2023-10-19 11:46:30 +02:00
Joseph Madamba	1a3a81c33b	Add slider nub double click revert to default test	2023-10-17 21:41:03 -07:00
Dean Herbert	e081fa48a2	Fix various other inspections	2023-10-17 17:48:51 +09:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Bartłomiej Dach	9b474b656d	Fix key binding panel test failures from introducing placeholder text ... Whoops.	2023-10-13 15:03:41 +02:00
Dean Herbert	6358a5e210	Merge pull request #25105 from bdach/multiple-keys-one-binding ... Disallow binding multiple bindings in a single section to one key	2023-10-13 20:01:33 +09:00
Bartłomiej Dach	5f51b8a7c9	Merge pull request #25097 from peppy/results-screen-progress-fast ... Show results immediately if user hits "back" key after finishing gameplay	2023-10-13 11:54:34 +02:00
Dean Herbert	17b6ebbfbf	Avoid using a bindable in KeyBindingConflictPopover where data is never mutated	2023-10-13 18:40:21 +09:00
Bartłomiej Dach	d5557bbbfb	Merge pull request #25005 from minetoblend/multiplayer-invites ... Add ability to invite players to multiplayer rooms	2023-10-13 11:09:28 +02:00
Dean Herbert	37411f923e	Merge branch 'master' into multiple-keys-one-binding	2023-10-13 15:07:12 +09:00
Dean Herbert	aabed8b6e5	Merge pull request #25093 from Joehuu/mod-switch-tiny-extended-info ... Add extended info support to tiny mod switches	2023-10-13 13:40:24 +09:00
Bartłomiej Dach	f083309e64	Move type back next to exposing class	2023-10-12 20:26:01 +02:00
Bartłomiej Dach	5d637520e7	Add test coverage for key binding conflict resolution	2023-10-12 16:04:46 +02:00
Bartłomiej Dach	f5a6781e5a	Integrate key binding conflict popover into keybindings panel	2023-10-12 16:04:46 +02:00
Bartłomiej Dach	7b6563116a	Implement visual appearance of key binding conflict popover	2023-10-12 16:01:51 +02:00
Bartłomiej Dach	5f0b1d69a5	Prepare KeyBindingRow for accepting external changes	2023-10-12 16:00:20 +02:00
Dean Herbert	fa47309eef	Fix exit key during storyboard outro not progressing to results	2023-10-12 19:31:54 +09:00
Bartłomiej Dach	34bab38e80	Fix judgement counter test failure due to exploiting mania ruleset ... Large ticks are not a thing in mania anymore, so the judgement counter tests began to fail as `LargeTickHit` is no longer a valid hit result in that ruleset.	2023-10-12 11:34:59 +02:00
Dean Herbert	56e27f1c27	Merge branch 'master' into multiplayer-invites	2023-10-12 18:17:15 +09:00
Dean Herbert	e6103fea95	Fix async usage in TestSceneNotificationOverlay	2023-10-12 16:00:36 +09:00
Dean Herbert	3023e44196	Remove unused using statements	2023-10-12 15:52:48 +09:00
Dean Herbert	73b8146729	Update tests in line with new behaviour	2023-10-12 15:42:54 +09:00
Dean Herbert	256c95f045	Add (failing) test coverage of exit/retry during progress to results	2023-10-12 15:42:20 +09:00
Joseph Madamba	764f641bc9	Add extended info support to tiny mod switches	2023-10-11 12:47:12 -07:00
Bartłomiej Dach	712564ea4f	Enable NRT in KeyBindingsSubsection	2023-10-11 20:03:31 +02:00
Dean Herbert	4319b22db8	Add failing test coverage of player not pausing track correctly	2023-10-10 17:55:35 +09:00
Bartłomiej Dach	ea400a9db7	Fix cross-test interference ... `TestLastPlayedUpdated` was implicitly relying on running first. `TestGuestScoreIsStoredAsGuest` showing up changed test ordering, causing the former test to fail if it didn't get to run first.	2023-10-10 09:30:51 +02:00
Bartłomiej Dach	08b1a3cbe2	Add failing test case for guest user being looked up in API	2023-10-10 09:18:57 +02:00
Dean Herbert	7c7771afca	Merge pull request #24986 from peppy/health-animates-in-intro ... Add initial animation for health bars	2023-10-07 10:31:34 +09:00
Bartłomiej Dach	a099cc0f36	Merge pull request #25030 from peppy/adjustable-health-bar ... Adjust argon health bar to fit with existing layout	2023-10-06 21:51:18 +02:00
Dean Herbert	1a60e6d76e	Merge branch 'master' into health-animates-in-intro	2023-10-07 00:32:19 +09:00
Dean Herbert	71be3c8f8b	Add ability to adjust health bar settings in test scene	2023-10-06 19:34:27 +09:00
Dean Herbert	db5178e453	Change ArgonHealthDisplay to be relative sized for now	2023-10-06 18:56:39 +09:00
Dean Herbert	1005b7ac85	Fix incorrect test assumption in TestSceneEditorClock ... I don't know what this test was trying to do, but it was wrong. Any offset which is applied should be invisible to the clock's final `CurrentTime` (and to the user).	2023-10-06 16:43:28 +09:00
Dean Herbert	354193c53a	Merge branch 'master' into clock-fix-attempt-2	2023-10-06 16:43:27 +09:00
Bartłomiej Dach	c195fbe76f	Merge branch 'master' into crop-gameplay-textures	2023-10-05 09:35:58 +02:00
Dean Herbert	5a0faaa0b1	Fix TestReplayExport intermittent failure ... The previous fix was not working as it was checking the path for the prefix `_`, not the filename. See https://github.com/ppy/osu/runs/17415814653#r0s2 which clearly shows this.	2023-10-05 14:30:06 +09:00
Bartłomiej Dach	bd71403309	Merge branch 'master' into health-animates-in-intro	2023-10-04 13:53:42 +02:00
Dean Herbert	5a17a86d1d	Merge branch 'master' into clock-fix-attempt-2	2023-10-04 16:57:49 +09:00
Marvin Schürz	5678d90461	Reduce silliness of notification test case	2023-10-04 00:20:38 +02:00
Bartłomiej Dach	844a3b6c1b	Merge pull request #24980 from frenzibyte/gameplay-hud-redesign/health-display ... Implement redesigned health bar display for "Argon" skin	2023-10-03 11:26:21 +02:00
Dean Herbert	e1445fcc65	Adjust health display test scene's background colour to better visualise background fill	2023-10-03 17:17:42 +09:00
Marvin Schürz	e81695bcac	Display avatar in invitation notification	2023-10-02 23:10:51 +02:00
Dean Herbert	622cbc3af7	Adjust test scene to actually make HP bars fit	2023-10-02 16:07:45 +09:00
Salman Ahmed	9e2b8254d9	Add argon-specific health display test scene	2023-10-01 13:26:47 +03:00
Salman Ahmed	776536e816	Add "Argon" health display implementation	2023-10-01 00:56:16 +03:00
Salman Ahmed	869f8e5e1b	Adjust test scene to apply miss judgements as well	2023-10-01 00:21:24 +03:00
Salman Ahmed	314ecec65b	Refactor player max dimensions test scene to actually upscale textures	2023-09-30 01:34:49 +03:00
Bartłomiej Dach	7638ea36a0	Merge branch 'master' into mod-icon-extended	2023-09-28 16:57:17 +02:00
Dean Herbert	b8953e8ce1	Code quality pass	2023-09-28 19:03:34 +09:00
Bartłomiej Dach	afa1815d13	Merge pull request #24929 from peppy/reduce-song-select-debounce ... Reduce delay before loading beatmap after selection change at song select	2023-09-28 10:45:43 +02:00
Dean Herbert	4d5b2477dc	Fix failing song select tack transfer test by using a real track	2023-09-28 15:59:06 +09:00
Dean Herbert	16e752e07d	Add basic structure and test coverage for extended info on mod icon	2023-09-27 19:29:03 +09:00
Dean Herbert	a7237e48aa	Merge branch 'master' into fix-storyboard-skin-textures-lookup	2023-09-27 17:17:51 +09:00
Bartłomiej Dach	12585c9f27	Fix flaky editor beatmap creation test ... Came up as a failure when locally running tests for ppy/osu-framework#6001 - but the test is actually a previously-known flaky that I couldn't reproduce the failure of until the aforementioned PR. This appears to be a simple race; the test scene queries the track length from update thread, but the length is actually set on the audio thread. So it's not unreasonable that given unlucky timing, the length will not be set by `TrackBass` before it is queried. To fix, switch assert to until step. I'm generally not really willing to give this more time of day until this change is proven insufficient.	2023-09-26 16:42:59 +02:00
Dean Herbert	40a548d372	Adjust new test scene to not be super broken	2023-09-26 17:30:49 +09:00
Dean Herbert	990c54519b	Merge branch 'master' into limit-gameplay-sprite-dimensions	2023-09-26 16:40:32 +09:00
Dean Herbert	b1561b650f	Rename test scene, add xmldoc and increase scale factor to something absurdly high	2023-09-26 16:39:36 +09:00
Dean Herbert	2ca1c684bb	Merge branch 'master' into fix-storyboard-skin-textures-lookup	2023-09-26 14:05:27 +09:00
Andrei Zavatski	292273edbe	Add test scene	2023-09-23 06:31:26 +03:00
Dean Herbert	c40bd74138	Update usages of GameplayClockContainer not using an adjustable source	2023-09-22 16:22:36 +09:00
Dean Herbert	8367bb6bee	Don't apply decoupling to SpectatorPlayerClocks ... See inline comment for reasoning. It's a bit complicated.	2023-09-22 16:22:35 +09:00
Dean Herbert	3f27be1f33	Replace most usages of DecoupleableInterpolatingFramedClock ... Except `FramedBeatmapClock`, which is the high-effort one.	2023-09-22 12:49:25 +09:00
Bartłomiej Dach	e45d456324	Fix TestFriendScore intermittently failing due to randomness ... If `createRandomScore()` happened to randomly pick the highest total score when called with `friend` as the sole argument, that particular score would not be pink. `GetScoreByUsername()` would arbitrarily pick the first score for the user, so in this particular case where a friend had the number 1 score, the test would wrongly fail. Fix by checking whether any of the 3 added friend scores have received the pink colour. Because there is more than 1 friend score in the test, doing so ensures that at least one of those should eventually become pink (because, obviously, you can't have two scores at number 1).	2023-09-21 21:12:44 +02:00
Bartłomiej Dach	9301a1907a	Rewrite TestFriendScore assertions to constraint model ... Allows to clearly see what the failure is: TearDown : System.TimeoutException : "friend score is pink" timed out: Expected: some item equal to "#FF549A" But was: < "#FFFFFF", "#7FCC33", "#444444" > The #7FCC33 colour is used for the first score on the leaderboard.	2023-09-21 21:05:41 +02:00
Bartłomiej Dach	d73f06fc89	Add test coverage for delete hotkey	2023-09-21 20:01:59 +02:00
Bartłomiej Dach	69ed99dfd5	Merge branch 'master' into mania-edit-disable-sv	2023-09-21 09:13:27 +02:00
Bartłomiej Dach	d7129da8ea	Fix TestSceneDrawableStoryboardSprite not displaying anything	2023-09-20 12:05:23 +02:00
Dean Herbert	c5397bdbb3	Merge branch 'master' into mania-edit-disable-sv	2023-09-20 14:23:07 +09:00
Dean Herbert	1927b524db	Merge branch 'master' into leaderboard-friend-highlight	2023-09-20 14:14:08 +09:00
Dean Herbert	1316403180	Fix inspection in new test scene	2023-09-20 13:02:40 +09:00
Dean Herbert	2f020f8682	Add test coverage of storyboard preferring skin when specified	2023-09-19 20:20:20 +09:00
Dean Herbert	067c487b21	Merge pull request #24450 from cdwcgt/missing-beatmap ... Fetch missing beatmap when importing replay	2023-09-19 18:40:02 +09:00
Dean Herbert	f726c38215	Pass ArchiveReader instead of Stream to simplify resolution code	2023-09-19 17:49:15 +09:00
Salman Ahmed	8e992de763	Fix crash when loading player instance without exiting previous instance	2023-09-19 05:09:01 +03:00
Salman Ahmed	a373d71b3e	Add basic test scene upscaling all skin elements	2023-09-19 03:40:31 +03:00
Salman Ahmed	57dc76b345	Revert "Update GetTexture signature rather than creating new overload" ... This reverts commit 96f12cfbaa.	2023-09-19 03:21:19 +03:00
Bartłomiej Dach	775f96f061	Add very basic visual tests for missing beatmap notification ... The full-stack test using the whole 9 `OsuGameTest` yards is unusable for rapid development. I don't really get how you could ever design anything using it without tossing your computer out the window.	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	06d1a2a316	Merge branch 'beatmap-card-nano' into missing-beatmap	2023-09-18 14:56:06 +02:00
Dean Herbert	f3b6aa5435	Merge pull request #24821 from bdach/scoring-test-scene-osu ... Refactor scoring test scene for ruleset extensibility (and move existing instance to osu! ruleset project)	2023-09-18 19:54:14 +09:00
Bartłomiej Dach	5c2413c06b	Implement nano beatmap card	2023-09-18 11:30:14 +02:00
Bartłomiej Dach	3709861132	Merge pull request #24814 from LukynkaCZE/parse-only-supported-char-uris ... Parse only supported schemes as URIs	2023-09-18 10:20:09 +02:00
Bartłomiej Dach	45751dd1f2	Minimum viable changes for ruleset-specific scoring test scenes	2023-09-15 12:58:29 +02:00
Lukynka CZE	2a18f76b02	add visual test	2023-09-14 17:48:10 +02:00
Dean Herbert	32946413de	Change display text from "difficulty" to "score" multiplier	2023-09-13 20:01:19 +09:00
Dean Herbert	35840bf671	Combine ModCounterDisplay and DifficultyMultiplierDisplay into one class	2023-09-13 18:51:56 +09:00
Bartłomiej Dach	7c65a9de75	Fix Score V1 simulation in scoring test scene incorrectly applying multiplier ... `TestSceneScoring` included a local simulation of stable's Score V1 algorithm. One of the parts of said algorithm is a mysterious "score multiplier", influenced by - among others - the beatmap's drain rate, overall difficulty, circle size, object count, drain length, and active mods. (An implementation of this already exists in lazer source, in `OsuLegacyScoreSimulator`, but more on this later.) However, `TestSceneScoring` had this multiplier in _two_ places, with _two_ distinct values, one of which being 1 (i.e. basically off). Unfortunately, the place that had 1 as the multiplier was the wrong one. Stable calculates the score increase for every hit in two stages; first, it takes the raw numerical value of the judgement, but then applies a combo-based bonus on top of it: scoreIncrease += (int)(Math.Max(0, ComboCounter.HitCombo - 1) * (scoreIncrease / 25 * ScoreMultiplier)); On the face of it, it may appear that the `ScoreMultiplier` factor can be factored out and applied at the end only when returning total score. However, once the above formula is rewritten as: scoreIncrease = scoreIncrease + (int)(Math.Max(0, ComboCounter.HitCombo - 1) * (scoreIncrease / 25 * ScoreMultiplier)); = scoreIncrease * (1 + (Math.Max(0, ComboCounter.HitCombo - 1) / 25 * ScoreMultiplier)) it becomes clear that that assumption is actually _incorrect_, and the `ScoreMultiplier` _must_ be applied to every score increase individually. The above was cross-checked experimentally against stable source on an example test map with 100 objects, and a replay hitting them perfectly.	2023-09-12 21:33:26 +02:00
Bartłomiej Dach	3981e2e957	Only show visible graph values in tooltip	2023-09-12 13:29:02 +02:00
Bartłomiej Dach	15708ee465	Add toggle for showing relative/absolute score values	2023-09-12 13:27:40 +02:00
Bartłomiej Dach	607ceeccb9	Persist visibility state of graphs	2023-09-12 12:19:50 +02:00
Bartłomiej Dach	3cf8082aa7	Add capability to toggle visibility of graph	2023-09-12 12:07:12 +02:00
Bartłomiej Dach	95d15a703e	Improve legibility of scoring test scene ... - Add black background to avoid clashes with background images. - Use sorta-tetradic colours for the four plots.	2023-09-12 11:36:41 +02:00
Dean Herbert	0d7157f727	Merge branch 'master' into map_info_on_mod_settings	2023-09-12 17:16:47 +09:00
Dean Herbert	7e3652284d	Adjust various class naming and add some xmldoc	2023-09-12 17:15:16 +09:00
Dean Herbert	b4bedee49e	Adjust naming of component to give more context	2023-09-12 15:43:59 +09:00
tsrk.	dbc07bc6dc	fix: provide OverlayColourProvider as a dep in tests	2023-09-12 01:34:17 +02:00
Bartłomiej Dach	824416067e	Fix test failure	2023-09-11 20:53:17 +02:00
tsrk.	8c137353b6	feat: integrate previous usernames tooltip to profile overlay	2023-09-11 15:02:19 +02:00
Bartłomiej Dach	f9d4fbee56	Add collapsed state to effect preview panel	2023-09-11 10:16:24 +02:00
Bartłomiej Dach	589f56d20c	Merge branch 'master' into map_info_on_mod_settings	2023-09-11 09:55:54 +02:00
Bartłomiej Dach	53c30dca64	Fix data flow being sometimes incorrect	2023-09-11 09:53:58 +02:00
Bartłomiej Dach	a631fae6df	Add actual testing	2023-09-11 09:19:37 +02:00
Dean Herbert	87ec33bb66	Tidy up test	2023-09-07 14:50:22 +09:00
Joseph Madamba	5ee412cc9a	Use @2x variant of profile badges	2023-09-06 16:17:53 -07:00
cdwcgt	68752f95e5	color friend score to pink	2023-09-06 22:58:03 +09:00
Dean Herbert	1a37543d28	Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity	2023-09-06 19:01:08 +09:00
Bartłomiej Dach	eddb879973	Merge pull request #24722 from peppy/beatmap-status-pill-animation ... Add animation support for beatmap status pills	2023-09-06 09:59:21 +02:00
Bartłomiej Dach	b5e812eb3e	Merge pull request #24723 from bdach/beatmap-carousel-split-missing-status ... Fix status on carousel beatmap set not showing in split difficulty mode	2023-09-06 09:35:38 +02:00
Bartłomiej Dach	b884f1af4a	Assign random statuses to beatmap sets in carousel test ... Just to have visual coverage of the statuses before fixing them not propagating to split difficulty mode.	2023-09-06 08:25:07 +02:00
Dean Herbert	dded7fe6ca	Merge branch 'master' into beatmap-options-popover	2023-09-06 15:16:34 +09:00
Dean Herbert	034c887dcb	Add animation support for beatmap status pills ... To be used in conjunction with https://github.com/ppy/osu/pull/22116	2023-09-06 15:04:25 +09:00
Joseph Madamba	3f92dae55c	Move star rating display and status pill out of reloadable content	2023-09-05 15:20:20 -07:00
Joseph Madamba	676240928e	Move actual star updating to star rating display	2023-09-05 14:57:55 -07:00
Dean Herbert	96f12cfbaa	Update GetTexture signature rather than creating new overload	2023-09-05 18:01:19 +09:00
Dean Herbert	02fefff5e7	Add better testing of options popover	2023-09-05 16:44:46 +09:00
Dean Herbert	340edf68d3	Fix test scene not updating all star counters	2023-09-05 15:59:00 +09:00
Joseph Madamba	9451613391	Rename null beatmap test to indicate there's a background	2023-09-04 21:39:41 -07:00
Joseph Madamba	854bb323cc	Remove weird red edge effect visibility	2023-09-04 21:21:55 -07:00
Joseph Madamba	e0a9c7e9a9	Fix wedge showing abruptly in test	2023-09-04 14:54:58 -07:00
Joseph Madamba	2df2002735	Move negative corner radius margin to constructor	2023-09-04 12:42:01 -07:00
Joseph Madamba	2fbd67cf26	Merge branch 'master' into beatmap_wedge_clean_ii	2023-09-04 11:24:20 -07:00
Joseph Madamba	5abf271b56	Implement beatmap options popover	2023-09-04 00:53:09 -07:00
cdwcgt	58844092d6	post a notification instead a screen	2023-09-04 16:17:21 +09:00
cdwcgt	dfecddbf5d	Merge branch 'master' into missing-beatmap	2023-09-04 12:41:23 +09:00
Magnus-Cosmos	ae9c901b94	Fix BeatmapInfoWedge tests failing due to BPM	2023-09-03 01:45:22 -04:00
Dean Herbert	0f5eff1230	Merge branch 'master' into mania-edit-disable-sv	2023-09-01 19:08:48 +09:00
Bartłomiej Dach	118c86df34	Fix TestSceneUpdateBeatmapSetButton using random difficulty count	2023-08-28 14:57:00 +02:00
Bartłomiej Dach	6251803868	Add failing test coverage of selection not being retained on song select	2023-08-28 10:05:59 +02:00
Bartłomiej Dach	3a6920c306	Add failing test coverage of beatmap update flow w/ split diffs	2023-08-28 09:51:44 +02:00
Dean Herbert	84f4fab9cf	Adjust test to actually test diff splitting	2023-08-25 18:09:51 +09:00
Dean Herbert	b471ab07a6	Fix typo in test step ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-24 18:30:59 +09:00
Dean Herbert	ba70d48d2c	Fix one more test probably going off-screen	2023-08-24 13:31:33 +09:00
Dean Herbert	4881130cae	Limit set/diff count in test to better fit on screen	2023-08-24 03:32:12 +09:00
Dean Herbert	5eac604f8b	Add coverage of selection retention when difficulties are split out	2023-08-23 19:44:42 +09:00
Dean Herbert	a64381f855	Add test coverage of add/remove when difficulties are split out	2023-08-23 19:43:08 +09:00
Dean Herbert	5555f73e97	Update test to match new behaviour	2023-08-23 19:38:18 +09:00
Dean Herbert	e7d61e0002	Fix star fountain directions not matching stable	2023-08-21 17:59:24 +09:00
Bartłomiej Dach	90bef267c8	Merge pull request #24581 from OliBomby/fix-segment-ends ... Fix `SliderPath.GetSegmentEnds`	2023-08-21 09:29:13 +02:00
Bartłomiej Dach	479c463751	Explain why segment end positions are not recovered in test	2023-08-21 08:29:51 +02:00
Bartłomiej Dach	3d52a1267e	Fix test failures via test-local popover containers	2023-08-19 15:08:30 +02:00
Bartłomiej Dach	2b09594823	Use nunit constraints in test for better debug experience	2023-08-19 14:33:26 +02:00
OliBomby	fbf4d3ac81	Add test	2023-08-18 12:36:34 +02:00
Dan Balasescu	a2fd7707a1	Allow toggling SVs in the editor	2023-08-18 18:55:24 +09:00
Dean Herbert	59a31cc868	Merge pull request #24431 from bdach/slider-with-textbox-instantaneous ... Add instantaneous mode to `SliderWithTextBoxInput`	2023-08-16 20:10:52 +09:00
Bartłomiej Dach	f9ca7f3e0e	Merge pull request #24564 from peppy/multi-spectator-test-improvements ... Add various testing improvements to various tournament components	2023-08-16 12:29:36 +02:00
Bartłomiej Dach	bdf87e43db	Merge branch 'master' into slider-with-textbox-instantaneous	2023-08-16 10:48:45 +02:00
Dean Herbert	26d05afadc	Add more test coverage to multi spectator screen	2023-08-16 17:14:42 +09:00
Dean Herbert	56eb44d15b	Change TestSpectatorClient to provide some better fake data for score / acc	2023-08-16 17:14:42 +09:00
Bartłomiej Dach	4f47b196c1	Merge branch 'master' into fix-unsafe-realm-access	2023-08-16 09:59:17 +02:00
Dean Herbert	a8824c8c8a	Remove flaky test documentation for fixed test	2023-08-16 14:30:10 +09:00
cdwcgt	e7b34cd4da	declare BeatmapSet is not null	2023-08-14 03:43:16 +09:00
Bartłomiej Dach	4152b4e523	Remove duplicated test case	2023-08-12 22:46:18 +02:00
QuantumSno	e9bb9434e9	Merge remote-tracking branch 'origin/leaderboard-toggle' into leaderboard-toggle	2023-08-12 00:19:48 -04:00
QuantumSno	562af8b46d	Updated test TestSceneGameplayChatDisplay.cs. Now uses new default bind for toggle chat (enter)	2023-08-12 00:18:10 -04:00
Bartłomiej Dach	d91798271d	Add test case covering exit block ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2023-08-08 22:06:49 +02:00
Joseph Madamba	d179fe3d96	Add support for changelog entries with url attached	2023-08-03 23:24:37 -07:00
Bartłomiej Dach	dde03b7d46	Merge branch 'master' into playfield-skin-layer	2023-08-03 20:42:15 +02:00
cdwcgt	eef63b41da	fetch missing beatmap when import score with missing beatmap	2023-08-02 17:58:05 +09:00
Dean Herbert	0e510088f9	Ensure background of gameplay is black when storyboard is overriding background display	2023-08-02 15:50:15 +09:00
Bartłomiej Dach	5b6c3321cf	Merge branch 'master' into multi-spectator-flow-fixes	2023-08-01 19:03:48 +02:00
Bartłomiej Dach	bcfc76b469	Add visual-only test coverage for centred player case	2023-08-01 17:41:07 +02:00
Dean Herbert	ed0c7e8880	Add failing test coverage showing crash on multiple StartGameplay invocations	2023-08-01 19:21:58 +09:00
Bartłomiej Dach	049215f2dc	Add test coverage for invalid input scenarios	2023-08-01 01:02:16 +02:00
Bartłomiej Dach	4fb0ff8800	Implement instantaneous SliderWithTextBoxInput mode	2023-08-01 01:02:16 +02:00
Bartłomiej Dach	0b019f1d45	Add test covering desired instantaneous behaviour	2023-08-01 01:01:37 +02:00
Bartłomiej Dach	ca81f23356	Add test covering non-instantaneous behaviour	2023-08-01 01:01:37 +02:00
Dean Herbert	528298bc39	Update test in line with framework changes	2023-08-01 07:17:12 +09:00
Bartłomiej Dach	ebe5dd2ac9	Interface with SelectionRotationHandler via DI rather than explicit passing	2023-07-30 20:21:41 +02:00
Bartłomiej Dach	262f25dce8	Make SelectionRotationHandler a Component	2023-07-30 20:18:33 +02:00
Bartłomiej Dach	821cd08f34	Merge branch 'master' into selection-operations-refactor	2023-07-30 19:29:06 +02:00
Bartłomiej Dach	898913f32a	Merge pull request #24415 from peppy/multi-spectator-improvements ... General visual improvements to mutliplayer spectatator screen	2023-07-30 12:43:26 +02:00
Bartłomiej Dach	e208f38bcb	Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts ... Disallow interacting with the global track state in `Player` and `Editor`	2023-07-30 12:28:53 +02:00
Dean Herbert	feea412bec	Add test with only one player	2023-07-30 14:40:24 +09:00
Bartłomiej Dach	43a51671ac	Fix wrong test step name	2023-07-29 16:12:02 +02:00
Bartłomiej Dach	aca8310cd1	Fix non-compiling test ... To be fair, currently the test is a bit pointless (as it has no reason to be a `SkinnableTestScene`, it gains precisely nothing from it - all that is shown there is some generic components on song select). But that is no worse then `master`, so look away for now.	2023-07-28 23:36:57 +02:00
Dean Herbert	269d4d1cd6	Add test coverage of autoplay restore not working	2023-07-28 14:49:06 +09:00
Bartłomiej Dach	22163020c3	Merge pull request #24367 from peppy/fix-replay-export-from-results ... Fix attempting to export replay from results screen after play not working	2023-07-27 20:47:07 +02:00
Dean Herbert	e702e0a23e	Avoid intercepting temporary files in new test	2023-07-27 17:44:36 +09:00
Bartłomiej Dach	f66093d3cf	Revert failing test to prior assertions too	2023-07-26 21:51:32 +02:00
Bartłomiej Dach	7bc3edb05a	Fix code quality inspection	2023-07-26 20:52:03 +02:00
Dean Herbert	2dace742a3	Add test coverage of score arriving on disk when exporting from results screen after play	2023-07-26 15:21:43 +09:00
Bartłomiej Dach	653f01f4ce	Merge pull request #24359 from peppy/fix-unknown-mod-test-failure ... Fix `TestSceneUnknownMod` failing due to null reference	2023-07-25 22:40:03 +02:00
Bartłomiej Dach	3b9f250c1b	Merge branch 'master' into menu-star-fountains	2023-07-25 21:58:13 +02:00
Bartłomiej Dach	d75e6f78d6	Adjust cyclic selection test to hitcircle lifetime adjustments ... As it turns out, the tightening of hitcircle lifetimes in editor caused the test to fail, since the objects were too far apart and at the starting time of the test, the first object was fully faded out and as such not alive, therefore leading cyclic selection to fail to select it. To fix, bring all three objects closer together time-wise so that this does not happen and the test can continue to exercise its original behaviour.	2023-07-25 18:54:13 +02:00
Dean Herbert	157b1f301b	Rename AllowTrackAdjustments to more understandable ApplyModTrackAdjustments	2023-07-25 20:20:53 +09:00
Dean Herbert	060ad36d60	Add test coverage of music control in editor from external	2023-07-25 20:20:53 +09:00
Dean Herbert	c1d93607e0	Fix TestSceneUnknownMod failing due to null reference	2023-07-25 19:06:13 +09:00
Bartłomiej Dach	21df0e2d60	Migrate test to SelectionRotationHandler	2023-07-23 20:56:22 +02:00
Bartłomiej Dach	2ef843261b	Adjust failing test after metrics changes	2023-07-21 19:08:40 +02:00