1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 09:17:48 +08:00
Commit Graph

11386 Commits

Author SHA1 Message Date
Salman Ahmed
d039b56562 Add test case for running with high number of loops 2024-03-10 09:01:37 +03:00
Salman Ahmed
8a1c5a7547 Adjust time values 2024-03-10 07:23:22 +03:00
Andrei Zavatski
e08651668c Fix TestSceneSkinnableSound failing 2024-03-09 21:55:00 +03:00
Salman Ahmed
82048df9f1 Add basic test scene for asserting storyboard commands behaviour
Pending actual test coverage.
2024-03-09 04:43:10 +03:00
Salman Ahmed
c1649b76d6 Reorder command properties to match general format
I had them shuffled around in the middle of the refactor.
2024-03-08 21:33:53 +03:00
Salman Ahmed
8d3e502262 Merge branch 'master' into storyboard-loops-v2 2024-03-08 20:22:19 +03:00
Dean Herbert
d9cc619693
Merge branch 'master' into argon-pp-counter 2024-03-08 10:32:16 +08:00
Salman Ahmed
fa9b2f0cd5 Add generics to ApplyInitialValue/ApplyTransforms for ability to return custom transform sequences
*sigh*
2024-03-08 03:07:39 +03:00
Salman Ahmed
585ab59768 Apply major refactor to the storyboard commands flow structrure 2024-03-08 01:10:09 +03:00
Bartłomiej Dach
fba44e67a0
Merge pull request #27214 from Givikap120/freemod_mapinfo_fix
Fix mod selection in online-play rooms not accounting for mods of selected item
2024-03-07 12:45:14 +01:00
Bartłomiej Dach
039520d55d
Use slightly nicer parameterisation in test 2024-03-07 09:49:20 +01:00
Bartłomiej Dach
644553d5b4
Merge branch 'master' into freemod_mapinfo_fix 2024-03-07 09:24:44 +01:00
Joseph Madamba
56caf19350 Add visual test for failed S display 2024-03-07 00:10:30 -08:00
Dean Herbert
29a37e3585
Merge pull request #27491 from bdach/f-rank-appearance
Update F rank badge colours to match latest designs
2024-03-06 18:55:20 +08:00
Dan Balasescu
d8003ab8e8
Merge pull request #27489 from bdach/fix-catch-pp-mismatch
Fix catch pp calculator not matching live with respect to miss handling
2024-03-06 19:39:20 +09:00
Dean Herbert
06c7483347
Merge branch 'master' into update-framework 2024-03-06 12:36:05 +08:00
Dean Herbert
85364d25dc
Merge pull request #27276 from bdach/medals
Add flow for displaying achieved medals
2024-03-06 12:31:55 +08:00
Dean Herbert
0696e7de52
Update ImageSharp usages 2024-03-06 12:13:12 +08:00
Salman Ahmed
49b3e81e8a Migrate DefaultPerformancePointsCounter and rename it 2024-03-05 04:35:39 +03:00
Salman Ahmed
b1477c30f2 Add deserialisation test coverage 2024-03-05 04:30:57 +03:00
Salman Ahmed
3ee57cdfba Refactor performance points test scene to support skinning 2024-03-05 03:34:25 +03:00
Salman Ahmed
9543908c7a Fix mod select overlay settings order not always matching panels order 2024-03-04 23:36:45 +03:00
Bartłomiej Dach
405958f73c
Add test scene for drawable ranks 2024-03-04 14:43:53 +01:00
Bartłomiej Dach
af2b80e030
Add failing encode test 2024-03-04 11:48:49 +01:00
Dan Balasescu
6635d9be04
Add countdown display 2024-03-04 16:50:24 +09:00
Andrei Zavatski
4a7635e488 Fix broken tests 2024-03-03 23:04:06 +03:00
Salman Ahmed
17e167cc1e
Merge branch 'master' into hide-beatmap-details 2024-03-01 16:21:03 +03:00
Dean Herbert
c6201ea5de
Remove unused ruleset parameter when testing beatmap in editor 2024-03-01 20:28:52 +08:00
Dean Herbert
59b9d29a79
Fix formatting? 2024-02-29 23:29:50 +08:00
Dean Herbert
4184a5c1ef
Add flag to allow backwards seeks in tests 2024-02-29 23:05:28 +08:00
Bartłomiej Dach
1fb4536220
Merge branch 'master' into disallow-backwards-seeks-gameplay 2024-02-29 08:50:52 +01:00
Bartłomiej Dach
9a1403d22a
Merge pull request #27427 from Detze/feb-29-test-failure
Fix February 29 test failure
2024-02-29 08:49:38 +01:00
Detze
caad89a4dd Fix test failure on leap years 2024-02-29 07:36:35 +01:00
Dean Herbert
5495c2090a
Add test coverage of gameplay only running forwards 2024-02-29 14:15:32 +08:00
Dean Herbert
f44aadaaa8
Merge pull request #27331 from bdach/statistics-updates-in-multi
Show user statistics updates on multiplayer and playlists results screens
2024-02-29 12:26:48 +08:00
Salman Ahmed
8f97f0503f Move away from Solo namespace 2024-02-29 01:21:17 +03:00
Salman Ahmed
de48c51715 Apply renaming in remaining usages 2024-02-29 01:11:08 +03:00
Salman Ahmed
92eb206b49
Merge branch 'master' into spectator-remove-back-button 2024-02-29 00:12:24 +03:00
Salman Ahmed
232ca5778f Improve spectator fail test 2024-02-29 00:09:58 +03:00
Bartłomiej Dach
a5948d38ac
Merge pull request #27380 from frenzibyte/fix-advanced-stats-display
Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps
2024-02-28 18:02:48 +01:00
Joseph Madamba
8e462fbb38 Apply NRT to touched files 2024-02-27 23:58:28 -08:00
Joseph Madamba
e8a1061777 Add test for spectator player exit 2024-02-27 23:24:16 -08:00
Joseph Madamba
dee57c7e72 Refactor test to only allow init of actions 2024-02-27 23:24:16 -08:00
Dean Herbert
31f667224f
Merge branch 'master' into medals 2024-02-28 13:48:57 +08:00
Salman Ahmed
2151e0a294 Improve test coverage 2024-02-26 22:30:09 +03:00
Dean Herbert
fe59a3b9be
Merge branch 'master' into medals 2024-02-26 22:49:55 +08:00
Dean Herbert
d6622c1756
Add test coverage of fast menu keypresses failing to register 2024-02-26 22:24:39 +08:00
Bartłomiej Dach
8966ea2fa3
Add test coverage 2024-02-26 11:59:57 +01:00
Salman Ahmed
b30a6d5224 Adjust existing test coverage 2024-02-25 21:23:14 +03:00
Salman Ahmed
618819ba9f Merge branch 'master' into freemod_mapinfo_fix 2024-02-23 18:34:41 +03:00
Salman Ahmed
771cdf9cd6 Fix TestSceneModEffectPreviewPanel 2024-02-23 18:30:14 +03:00
Salman Ahmed
c1db9d7819 Add test coverage 2024-02-23 18:16:44 +03:00
Bartłomiej Dach
eac4c5f69d
Rename {Solo -> User}StatisticsWatcher et al.
The "solo" prefix is a bit unbecoming now. The updates are not only
for solo.
2024-02-22 20:36:24 +01:00
Bartłomiej Dach
1e53503608
Show user statistics after completing a playlists / multiplayer score 2024-02-22 20:35:50 +01:00
Bartłomiej Dach
0074bdc5a1
Change ResultsScreen constructor boolean params to init-only properties 2024-02-22 20:15:03 +01:00
Bartłomiej Dach
82b2edd4b7
Merge pull request #26769 from EVAST9919/results-clean
Rework `AccuracyCircle` to not use `BufferedContainer`s
2024-02-22 13:46:28 +01:00
Bartłomiej Dach
49b7f0e3a7
Merge pull request #26531 from smallketchup82/multiplayer-difficulty-tooltip
Implement difficulty tooltips for multiplayer lobbies
2024-02-22 12:57:35 +01:00
Bartłomiej Dach
46c8560ca5
Merge branch 'master' into multiplayer-difficulty-tooltip 2024-02-22 12:08:29 +01:00
Bartłomiej Dach
3740064360
Fix test scene not properly setting tooltip type on all icons 2024-02-22 12:05:52 +01:00
Bartłomiej Dach
d06c67ad8f
Substitute two jank interdependent bool flags for single tri-state enums 2024-02-22 12:05:50 +01:00
Bartłomiej Dach
47db317df8
Enable NRT in TestSceneDifficultyIcon 2024-02-22 11:45:57 +01:00
Bartłomiej Dach
6770b73e4e
Merge pull request #27192 from smoogipoo/mod-search-ignore-whitespace
Adjust search terms for mods
2024-02-22 11:41:31 +01:00
Bartłomiej Dach
b08fcbd4e9
Adjust tests to new behaviour 2024-02-22 11:02:49 +01:00
Dean Herbert
8b24c6a905
Merge pull request #27299 from BoudewijnPopkema/27272-clear-remembered-username
Clear stored username/token from config when relevant checkboxes are unticked on login panel
2024-02-22 17:29:36 +08:00
Bartłomiej Dach
2831ff60e1
Add test coverage 2024-02-22 09:39:49 +01:00
Bartłomiej Dach
57bb0b85a1
Merge pull request #27107 from Joehuu/rank-highest-tooltip
Add highest rank tooltip to global rank display
2024-02-22 09:08:22 +01:00
Dean Herbert
fc30abc7b0
Merge branch 'indented-code-block' into update-framework 2024-02-21 21:44:25 +08:00
Bartłomiej Dach
259be976e8
Adjust test to fail 2024-02-21 11:42:34 +01:00
Bartłomiej Dach
e5be8838e6
Fix yet another failure 2024-02-20 18:42:01 +01:00
Bartłomiej Dach
8abcc70b93
Add medal overlay to game 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
b334b78b63
Make medal overlay respect overlay disable via activation mode 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
e4971ae121
Add display queueing when multiple medals are granted in quick succession 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
2e5b61302a
Implement basic medal display flow 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
4911f5208b
Demote medal "overlay" to animation
I need the actual overlay to be doing way more things (receiving the
actual websocket events, queueing the medals for display, handling
activation mode), so the pre-existing API design of the overlay just
will not fly.
2024-02-20 16:31:31 +01:00
Dean Herbert
398eaee5d0
Merge pull request #27238 from bdach/disable-nested-managers-when-skin-editor-open
Disable nested input managers on edited screen when skin editor is open
2024-02-19 19:27:26 +08:00
Bartłomiej Dach
f5666185ab
Merge pull request #27239 from peppy/fix-cached-beatmap
Fix `WorkingBeatmapCache` caching beatmap in wrong state leading to crash
2024-02-19 12:06:45 +01:00
Bartłomiej Dach
444ac5ed4d
Add failing test coverage 2024-02-19 09:59:25 +01:00
Dean Herbert
6b6a6aea54
Apply NRT to LogoTrackingContainer 2024-02-18 23:35:26 +08:00
Dean Herbert
415a65bf59
Add failing tests for beatmap inconsistencies 2024-02-18 19:32:21 +08:00
Dean Herbert
4d4d69521f
Merge pull request #27114 from EVAST9919/judgements-rework
Cache created judgement in `HitObject`
2024-02-18 18:07:58 +08:00
Salman Ahmed
414e55c90e Add visual test case 2024-02-18 01:38:51 +03:00
Joseph Madamba
8169d1ac80 Add twenty star counter in visual test 2024-02-16 22:47:38 -08:00
Andrei Zavatski
060b01eee8 Make CreateJudgement public again and add remarks 2024-02-16 20:24:02 +03:00
Andrei Zavatski
dd32c0a226 Merge branch 'master' into judgements-rework 2024-02-16 20:08:57 +03:00
Salman Ahmed
583e71634f Always bring master/music volume to 50% 2024-02-16 11:20:07 +03:00
Salman Ahmed
6a1d118b21 Adjust tests again 2024-02-16 10:52:27 +03:00
Mike Will
22dafd8e9c fix typo 2024-02-15 18:56:09 -05:00
Salman Ahmed
df40f55c07
Merge branch 'master' into mute_detection 2024-02-16 01:35:02 +03:00
Salman Ahmed
6751f95eb6 Adjust test cases and approximate equality 2024-02-16 01:28:53 +03:00
Dan Balasescu
a037dbf8de
Update test to set Child in more canonical manner 2024-02-15 18:33:48 +09:00
Dean Herbert
409dfd33e7
Merge pull request #27178 from Joehuu/truncate-osu-dropdown-items
Truncate long dropdown menu item text and show tooltip
2024-02-15 16:11:36 +08:00
Joseph Madamba
401bd91dc4 Add visual test showing overflow on dropdown menu items 2024-02-14 22:57:38 -08:00
Dean Herbert
59efd22ba2
Merge branch 'master' into score-statistics-updates-working-2 2024-02-15 02:55:12 +08:00
Bartłomiej Dach
c588b81cee
Merge pull request #27163 from frenzibyte/ignore-soft-deleted-beatmaps-in-notification
Ignore soft-deleted beatmaps when trying to present from notification
2024-02-14 18:07:59 +01:00
Bartłomiej Dach
f7bea00564
Improve test coverage 2024-02-14 16:19:32 +01:00
Bartłomiej Dach
f1d69abdc8
Rename test 2024-02-14 15:59:07 +01:00
Dean Herbert
3da1d05d98
Merge branch 'master' into ignore-soft-deleted-beatmaps-in-notification 2024-02-14 22:56:47 +08:00
Bartłomiej Dach
d7dfc8b88a
Add failing test coverage for empty date filter not parsing 2024-02-14 15:55:57 +01:00
Bartłomiej Dach
1113355753
Merge branch 'master' into add-last-played-filter 2024-02-14 15:36:19 +01:00
Bartłomiej Dach
3f46e1afc3
Merge branch 'master' into comment-mapper-pill 2024-02-14 13:22:36 +01:00
Bartłomiej Dach
d189fa0f69
Rename flag 2024-02-14 11:53:41 +01:00
Dan Balasescu
2981ebe3d5
Fix inspection 2024-02-14 17:13:44 +09:00
Salman Ahmed
c24af5bfeb Add test coverage 2024-02-14 04:17:55 +03:00
Salman Ahmed
a96a66bc9e Add failing test case 2024-02-14 02:04:20 +03:00
Bartłomiej Dach
14052ae1cc
Implement transient stats display on user toolbar button 2024-02-13 14:28:24 +01:00
Bartłomiej Dach
da4ebd0681
Refactor SoloStatisticsWatcher to no longer require explicit subscription callbacks 2024-02-13 13:49:01 +01:00
Dean Herbert
f7a223f328
Merge pull request #27053 from frenzibyte/unranked-pp-placeholder
Add support for displaying "unranked PP" placeholder
2024-02-13 18:59:55 +08:00
Dan Balasescu
833997bf1d
Merge pull request #27143 from bdach/more-stringent-metadata-checks
Use more stringent checks when applying online metadata
2024-02-13 17:10:52 +09:00
Salman Ahmed
5bebe9fe0d Add test case for profile scores made on loved beatmaps 2024-02-12 21:33:18 +03:00
Bartłomiej Dach
5d81d83fb2
Merge branch 'master' into alias-author-creator 2024-02-12 18:02:42 +01:00
Bartłomiej Dach
96711eb185
Add test coverage 2024-02-12 18:02:34 +01:00
Bartłomiej Dach
e5e0b0e385
Add test coverage for correct setting of beatmap set status 2024-02-12 12:08:51 +01:00
Bartłomiej Dach
133e61a1b2
Add another test for even more failure 2024-02-12 12:08:51 +01:00
Bartłomiej Dach
834db989f7
Add more test coverage for more failure 2024-02-12 11:43:41 +01:00
Bartłomiej Dach
80b14f1aae
Add test coverage for beatmap confusion scenarios 2024-02-12 11:43:15 +01:00
Dean Herbert
1df38b54a1
Merge branch 'master' into refactor-metadata-lookup-sources 2024-02-11 20:10:41 +08:00
Bartłomiej Dach
ae5f108f01
Add visual test coverage of user profile info section 2024-02-10 13:08:26 +01:00
Andrei Zavatski
5fa54c8c63 Fix remaining use cases 2024-02-10 14:16:45 +03:00
Dean Herbert
01501f3b82
Merge branch 'master' into refactor-metadata-lookup-sources 2024-02-10 14:43:51 +08:00
Joseph Madamba
c9c39ecb2f Add RankHighest to APIUser 2024-02-09 16:06:16 -08:00
Andrei Zavatski
f03c4a0961 Merge branch 'master' into results-clean 2024-02-06 21:09:23 +03:00
Dan Balasescu
c18cd65081
Merge pull request #26694 from chandler14362/hit-object-result-allocations
Avoid closure allocations when applying hit object results
2024-02-06 17:49:26 +09:00
Andrei Zavatski
fc4234214e Merge branch 'master' into results-clean 2024-02-06 08:03:10 +03:00
Salman Ahmed
b0da0859d8 Add visual test cases 2024-02-05 23:29:24 +03:00
Bartłomiej Dach
c1feccb4cf
Add test coverage for selection behaviour 2024-02-05 19:53:19 +01:00
Bartłomiej Dach
1582536f04
Merge pull request #26924 from EVAST9919/user-card-containers
Rework `UserPanel`s to reduce container nesting
2024-02-05 18:46:42 +01:00
Bartłomiej Dach
3e29a9c334
Merge pull request #26877 from smoogipoo/adjust-default-minresult
Adjust default min result of `SliderTailHit`, remove override
2024-02-05 14:15:38 +01:00
Dean Herbert
cc5e1e0af3
Merge pull request #26957 from smoogipoo/net8
Update to .NET 8 + C# 12
2024-02-05 20:59:31 +08:00
Bartłomiej Dach
39fe078984
Merge branch 'master' into hit-object-result-allocations 2024-02-05 13:24:10 +01:00
Bartłomiej Dach
efe6bb25b1
Refactor result application around again to remove requirement for fields
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-02-05 13:21:01 +01:00
Bartłomiej Dach
ad69259eb8
Merge branch 'master' into fix-results-f-rank 2024-02-05 13:05:37 +01:00
Bartłomiej Dach
989e46c791
Use better test step name 2024-02-05 13:05:28 +01:00
Dean Herbert
c64d414d1b
Merge pull request #26934 from bdach/which-mods-for-pp
Display which mods grant pp
2024-02-04 19:15:11 +08:00
Andrei Zavatski
397def9ceb Move layout specification outside the GradedCircles class 2024-02-04 02:58:15 +03:00
Andrei Zavatski
7b2adc857a Merge branch 'master' into results-clean 2024-02-04 02:41:12 +03:00
Dan Balasescu
8e8ba9e77f
Fix more CI inspections 2024-02-02 21:36:41 +09:00
Bartłomiej Dach
dbd4397bef
Attempt to salvage test by using until step 2024-02-02 13:32:16 +01:00
Dan Balasescu
6e4d52863c
Upgrade to .NET 8 SDK 2024-02-02 21:28:51 +09:00
Bartłomiej Dach
fe0433e6ec
Remove redundant default value assignments 2024-02-02 13:24:59 +01:00
Dan Balasescu
b44f77cee1
Update R# + fix inspections 2024-02-02 21:00:28 +09:00
Mike Will
e4ec8c111b give better volume names to addVolumeSteps 2024-02-02 05:48:57 -05:00
Mike Will
906560f66d Fix mute button test
Lowering the master volume in the previous test meant that the
volume levels would end up being modified.
2024-02-02 04:06:22 -05:00
Mike Will
5d9200b4fe Update tests to reflect new restore target volume 2024-02-02 02:59:02 -05:00
Bartłomiej Dach
091618db1a
Add test coverage of full account creation flow 2024-02-02 07:25:07 +01:00
Mike Will
dfd966e039 Improve silence detection in MutedNotification
Instead of checking the master and music volumes separately to
see if they're <= 1%, check the aggregate of the two volumes to
see if it's <= -60 dB.

When muted notification is activated, restore the aggregate volume
level to -30 dB.
2024-02-02 00:48:42 -05:00
Salman Ahmed
5a1b0004db Add failing test case 2024-02-02 01:26:03 +03:00
Bartłomiej Dach
865f4d76ff
Add unranked indicator to song select footer too 2024-02-01 21:51:41 +01:00
Bartłomiej Dach
966093f7ce
Transform score multiplier display to also show ranked state 2024-02-01 21:32:37 +01:00
Andrei Zavatski
b0f6a87a2b Add stress test in TestSceneDashboardOverlay 2024-02-01 16:22:07 +03:00
Salman Ahmed
6ab8960fdc Add step for toggling skins in results screen test scene 2024-02-01 16:08:48 +03:00
Salman Ahmed
35c3f5e250 Merge branch 'master' into fix-results-f-rank 2024-02-01 15:29:07 +03:00
Dan Balasescu
66aa41e001
Fix tests 2024-01-31 18:04:32 +09:00
Dean Herbert
a1fe5eedd5
Merge pull request #26751 from frenzibyte/fix-multiplayer-fail-freezing-score
Fix score processor no longer applying results when failing in multiplayer match
2024-01-29 19:51:31 +09:00
Dean Herbert
cbbe2f9dc0
Merge pull request #25480 from peppy/2fa
Add two factor authentication flow
2024-01-29 19:14:55 +09:00
Bartłomiej Dach
4c5dacd559
Merge pull request #26770 from peppy/fucking-hitobject-references
Fix `OsuPlayfield` being retained indefinitely after gameplay
2024-01-29 09:40:56 +01:00
Dean Herbert
4a2602a775
Merge branch 'master' into 2fa 2024-01-29 16:57:29 +09:00
Dean Herbert
48fc0545c2
Merge pull request #26724 from bdach/decouple-notification-websocket-from-chat
Decouple notifications websocket handling from chat operations
2024-01-29 16:57:13 +09:00
Bartłomiej Dach
a41ba7c381
Fix more nullable inspections 2024-01-29 08:44:27 +01:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score as nullable
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Dean Herbert
9c55498058
r# says hi 2024-01-29 15:28:14 +09:00
Andrei Zavatski
809ca81b9c Add TestSceneGradedCircles 2024-01-29 05:29:29 +03:00
Salman Ahmed
64b61108ad Move solution to multiplayer flow instead 2024-01-28 00:42:04 +03:00
Salman Ahmed
5f68999893 Fix TestSceneFailJudgement asserts no longer being correct 2024-01-27 23:23:32 +03:00
Salman Ahmed
ea641bb8d2 Rename GameplayState.HasFailed to properly clarify its meaning 2024-01-27 23:23:10 +03:00
Salman Ahmed
d38779f962 Add failing test case 2024-01-27 23:22:56 +03:00
Salman Ahmed
2ccd0e3692 Add visual and failing test cases 2024-01-27 01:45:39 +03:00
Bartłomiej Dach
a2e69d37e8
Add basic testing of failure flow 2024-01-26 11:17:32 +01:00
Dean Herbert
e54502eef1
Add full editor save test coverage 2024-01-26 13:59:32 +09:00
Dean Herbert
a77db5d837
Add failing test coverage of editor metadata not saving 2024-01-26 13:59:32 +09:00
Chandler Stowell
93bd3ce5ae update DrawableHitCircle.ApplyResult to pass this to its callback 2024-01-25 11:25:41 -05:00
Bartłomiej Dach
3d3506b906
Merge branch 'decouple-notification-websocket-from-chat' into 2fa 2024-01-25 14:51:42 +01:00
Bartłomiej Dach
de52f0a80c
Decouple notifications websocket handling from chat operations
This is a prerequisite for https://github.com/ppy/osu/pull/25480.

The `WebSocketNotificationsClient` was tightly coupled to chat specifics
making it difficult to use in the second factor verification flow.
This commit's goal is to separate the websocket connection and message
handling concerns from specific chat logic concerns.
2024-01-25 14:47:29 +01:00
Dean Herbert
d66a2c452f
Merge branch 'master' into multiplayer-difficulty-tooltip 2024-01-25 21:18:16 +09:00
Dean Herbert
baaf33d995
Merge pull request #26689 from myQwil/divisor_cycle
Prevent custom divisor ranges from halting divisor preset cycling
2024-01-25 20:46:16 +09:00
OliBomby
c2d57dc77c Merge remote-tracking branch 'upstream/master' into edit-nodesample 2024-01-25 11:33:29 +01:00
Dean Herbert
f22bfa350a
Add test coverage of hidden scores on accuracy circle 2024-01-25 15:02:44 +09:00
Nguyên Minh Hồ
e1f8bc9692 Rename CanRotate property of SelectionRotationHandler to a more descriptive name 2024-01-25 12:10:50 +07:00
Mike Will
9e1c242713 Prevent custom divisor ranges from halting preset cycling
A custom divisor like 24 or 32 will result in a range containing
many divisors that are already in the `Common` and `Triplets` presets.
When this happens, it can become impossible to cycle between presets,
because the preset can only be changed if the new divisor isn't already
contained within the current preset's range.
2024-01-24 18:31:39 -05:00
Bartłomiej Dach
2f8747776e
Fix nullability inspection 2024-01-24 22:01:59 +01:00
Dean Herbert
b272d34960
Merge pull request #26630 from peppy/s-rank-change
Change S rank to require no miss
2024-01-24 13:27:40 +09:00
Bartłomiej Dach
0d7834af5f
Ensure all remaining test usages of IAPIAccess.Login() also authenticate with second factor 2024-01-23 18:04:41 +01:00
Bartłomiej Dach
d7e957087e
Fix account creation overlay test not clearing second auth factor 2024-01-23 17:00:16 +01:00
Bartłomiej Dach
d0d09a8657
Fix login overlay test not clearing second auth factor 2024-01-23 17:00:14 +01:00
Bartłomiej Dach
2cfaa1c103
Merge branch 'master' into 2fa 2024-01-23 16:51:23 +01:00
Bartłomiej Dach
0b5be3c40c
Remove outdated test
Non-legacy scores *are* subject to upgrades again - albeit it is *rank*
upgrades that they are subject to.
2024-01-23 12:53:16 +01:00
Andrei Zavatski
da992ccc55 Implement per-axis triangles clamping 2024-01-23 04:54:27 +03:00
Bartłomiej Dach
d53fb5a165
Update assertions to match expected behaviour 2024-01-22 20:52:54 +01:00
Bartłomiej Dach
3f31593a19
Add another failing tests covering recomputation of ranks 2024-01-22 20:01:18 +01:00
Bartłomiej Dach
81a02665b6
Adjust existing test to fail 2024-01-22 20:00:00 +01:00
Dean Herbert
83f9118b22
Adjust results screen to handle S->A rank adjustment when misses are present 2024-01-22 21:43:32 +09:00
Dean Herbert
4eba3b5d70
Move BackgroundDataStoreProcessor to better namespace 2024-01-22 21:43:32 +09:00
Dean Herbert
bb1eab5844
Update test in line with new rank definitions always being applied 2024-01-22 21:43:32 +09:00
Dean Herbert
c8521b49cd
Change S rank to require no miss 2024-01-22 21:43:32 +09:00
Dean Herbert
2ab0be7606
Merge pull request #26669 from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA
Fix score submission test failures due to checking audio playback validity (again)
2024-01-22 20:07:51 +09:00
Bartłomiej Dach
9b2740f8a4
Fix score submission test failures due to checking audio playback validity (again)
As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75

In https://github.com/ppy/osu/pull/26484, I went "well if I'm moving the
enabling of validation of playback rate to `SubmittingPlayer` context,
then surely I can remove the local override in the test scene, right?"

Reader: Apparently I did not notice that `FakeImportingPlayer :
TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
the local override in the test scene.

You could probably attempt to conjure up some excuse about deep
inheritance hierarchies here but nah. Really just a failure to read
on my behalf as usual.
2024-01-22 11:15:42 +01:00
Bartłomiej Dach
77ef12ebb0
Merge branch 'master' into frame-stable-catchup-zoom 2024-01-22 10:37:06 +01:00
Dean Herbert
993e733fce
Merge pull request #26598 from frenzibyte/fix-storyboard-sprites-2
Remove handling for non-legacy texture lookup paths in `LegacySkin`
2024-01-22 17:50:55 +09:00
Dean Herbert
f12be60d8d
Make test actually test multiple icons 2024-01-22 17:18:22 +09:00
Bartłomiej Dach
493d495992
Merge pull request #26605 from peppy/simplify-gameplay-pause
Simplify gameplay pause sequence
2024-01-22 08:49:08 +01:00
Dean Herbert
3b7a47aded
Merge branch 'master' into update-framework 2024-01-21 13:49:44 +09:00
Andrei Zavatski
1393f52b2b Rename Masking to ClampToDrawable 2024-01-21 05:20:42 +03:00
Dean Herbert
a69fd8198d
Update framework and other nuget packages
- Moq held back because dicks
- NUnit held back because large API changes (trivial but effort)
- SignalR held back due to api deprecations
2024-01-21 11:00:53 +09:00
OliBomby
9459c66981 fix test 2024-01-20 15:53:08 +01:00
OliBomby
bc0e6baba7 fix test 2024-01-20 01:13:05 +01:00
smallketchup82
87369f8a80 Conform to code style & remove unused imports 2024-01-18 11:16:03 -05:00
Salman Ahmed
22cfc86050 Add failing test case 2024-01-18 14:24:49 +03:00
Dean Herbert
c4e9bcd140
Remove test guarantee of audio time not advancing 2024-01-18 20:06:53 +09:00
Dean Herbert
82e7643df5
Update IPC usages
Of note, I've disabled IPC on visual test runners as we generally don't
use IPC in these cases. Having it set means that the game will not open
while visual tests are open, which has been a complaint from devs in the
past.
2024-01-18 19:45:36 +09:00
smallketchup82
d80a5d44ee Add tests for DifficultyIcon 2024-01-18 03:17:37 -05:00
Dean Herbert
799c74cfe5
Simplify gameplay pause sequence 2024-01-18 14:17:19 +09:00
Dean Herbert
fb4efd992d
Add a fake load to visual test to restore previous testing behaviour 2024-01-18 14:01:37 +09:00
Dean Herbert
c362a93a36
Change frame stable catch-up method to allow for much faster sync 2024-01-18 14:01:37 +09:00
Salman Ahmed
06da7f74de
Merge branch 'master' into fix-storyboard-sprites-2 2024-01-17 18:43:25 +03:00
Dean Herbert
e260e75fac
Merge pull request #26594 from frenzibyte/fix-storyboard-sprites-1
Change legacy beatmap skins to not handle `@2x` textures (to match stable)
2024-01-18 00:40:29 +09:00
Salman Ahmed
ede0a22693 Remove existing test coverage 2024-01-17 16:58:47 +03:00
Salman Ahmed
bcc7dd6af5 Add extended test coverage 2024-01-17 15:58:27 +03:00
Dean Herbert
6a8a45bb13
Merge pull request #26585 from frenzibyte/fix-editor-ux
Fix timing point changes not applying after selecting another one
2024-01-17 19:53:35 +09:00
Dean Herbert
1af5d1434c
Rename test method slightly 2024-01-17 19:53:23 +09:00
Bartłomiej Dach
5cb17bcacf
Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods
Add guard against submitting score with invalid mod instances
2024-01-17 11:39:32 +01:00
Dean Herbert
0ddd89a5b8
Merge pull request #26579 from bdach/accuracy-rank-lazer-score-reimport
Fix incorrect accuracy and rank population when decoding lazer replays
2024-01-17 19:33:26 +09:00
Salman Ahmed
5ad2918a75 Allow disabling high resolution texture lookups in LegacySkin 2024-01-17 12:56:29 +03:00
Dean Herbert
ee18123fc2
Merge pull request #26340 from stanriders/user-rank-card
Add user card with global/country ranks to login overlay
2024-01-17 17:22:33 +09:00
Salman Ahmed
05729706eb Fix android build CI failing
No idea why this is only in android, but okay.
2024-01-17 08:53:28 +03:00
Salman Ahmed
23e5167cb5
Merge branch 'master' into drag-volume-controls 2024-01-17 08:37:34 +03:00
Salman Ahmed
a34d2a3424 Add small volume meter to test feel 2024-01-17 08:28:47 +03:00
Salman Ahmed
f11682d44f Add failing test case 2024-01-17 08:15:01 +03:00
Bartłomiej Dach
1075b87fb8
Add failing test coverage 2024-01-16 22:38:52 +01:00
Salman Ahmed
485195d4c2 Fix submission test not asserting properly 2024-01-16 14:27:40 +03:00
Salman Ahmed
2935bd4809 Add test cases for helper method 2024-01-16 14:27:24 +03:00
Bartłomiej Dach
a3b7943e7d
Merge pull request #26560 from peppy/fix-skin-loss
Fix skin potentially being lost when opening and closing skin editor rapidly
2024-01-16 10:16:30 +01:00
Dean Herbert
0e41d0c9cf
Add failing test coverage of skin getting nuked
This doesn't fail in headless unfortunately.

Run a few times manually to confirm.
2024-01-16 15:22:38 +09:00
Dean Herbert
09e5b2fb46
Add test coverage of incorrect default state for Rank when hidden is applied 2024-01-16 13:21:15 +09:00
Bartłomiej Dach
40f612435d
Merge pull request #26178 from felipemarins/mod-search-text-box-select-all
Make mod search box text be selected when a new mod is selected/deselected
2024-01-15 20:08:02 +01:00
Bartłomiej Dach
a41108057f
Merge pull request #26287 from wooster0/no-scores-yet
Don't leave scores screen empty if no scores are present yet
2024-01-15 19:49:20 +01:00
Bartłomiej Dach
4d39c91972
Merge pull request #26449 from peppy/playlist-room-buttons
Allow interacting with playlist item buttons when not selected
2024-01-15 19:12:01 +01:00
Bartłomiej Dach
c0d4ed4789
Add test coverage of select-all-text-in-search when nothing matched 2024-01-15 19:07:52 +01:00
Bartłomiej Dach
e8394e6f74
Add test coverage 2024-01-15 19:05:33 +01:00
Bartłomiej Dach
988794cf90
Improve test coverage for empty results 2024-01-15 18:49:41 +01:00
Bartłomiej Dach
8a839f64ed
Add failing test coverage for placeholder shown when it shouldn't be 2024-01-15 18:47:46 +01:00
Bartłomiej Dach
d8d1d9264c
Fix test failure 2024-01-15 18:29:51 +01:00
Bartłomiej Dach
91f8144f98
Add test coverage 2024-01-15 14:58:46 +01:00
Bartłomiej Dach
d206acac63
Merge pull request #26540 from peppy/fix-double-counters
De-dupe displayed hits in judgement counter
2024-01-15 14:02:11 +01:00
Bartłomiej Dach
fe8540b441
Merge pull request #26541 from peppy/fix-collection-dropdown-crash
Fix collection dropdown crashing when all collections are deleted at once
2024-01-15 13:28:00 +01:00
Salman Ahmed
d346dd0650 Fix TestModReinstantiation failing due to custom mod being used 2024-01-15 15:01:13 +03:00
Bartłomiej Dach
96c472b870
Remove unused using directive 2024-01-15 12:33:25 +01:00
Bartłomiej Dach
6dee2860d2
Merge branch 'master' into fix-multiplayer-mods-cheesing 2024-01-15 12:19:29 +01:00
Bartłomiej Dach
0a02050a85
Fix test crashing at the end in visual test browser 2024-01-15 12:12:27 +01:00
StanR
b86c883a5d Merge branch 'master' into user-rank-card 2024-01-15 16:37:48 +06:00
Salman Ahmed
494c1be655 Fix blatant error in TestSceneModAccuracyChallenge 2024-01-15 13:30:34 +03:00
Bartłomiej Dach
9da3aeb28b
Merge pull request #26492 from frenzibyte/fix-system-mods-selected-on-free-mods-overlay
Fix touch device mod getting selected as a free mod in playlists
2024-01-15 11:29:37 +01:00