1720 Commits

Author	SHA1	Message	Date
smoogipoo	ff72ccabd8	Rename method	2020-08-25 18:44:32 +09:00
Dean Herbert	940b4acf0d	Merge branch 'master' into fix-hittarget-layering	2020-08-25 15:44:38 +09:00
smoogipoo	ab8d9be095	Move out into a separate method	2020-08-25 15:16:41 +09:00
smoogipoo	723e5cafb6	Fix column potentially added at wrong indices	2020-08-25 14:49:04 +09:00
smoogipoo	018523a43a	Rework to remove cross-class pollutions	2020-08-25 01:21:27 +09:00
smoogipoo	77bf646ea0	Move column lines to background layer	2020-08-24 23:01:06 +09:00
smoogipoo	500cb0ccf5	Fix legacy hit target being layered incorrectly	2020-08-24 22:36:37 +09:00
Dean Herbert	1f717c4b00	Merge branch 'master' into hold-note-freeze	2020-08-23 22:38:48 +09:00
Bartłomiej Dach	891f5cb130	Add padding to mania column borders to match stable	2020-08-21 20:00:20 +02:00
smoogipoo	08078b9513	Rename method to remove "InitialColour" namings	2020-08-22 00:56:29 +09:00
smoogipoo	454564b189	Update mania with legacy colour setters	2020-08-22 00:19:15 +09:00
smoogipoo	b3338347b7	Remove fade on successful hits	2020-08-21 23:56:27 +09:00
smoogipoo	8632c3adf0	Fix hold notes bouncing with SV changes	2020-08-21 23:11:15 +09:00
Dan Balasescu	42ee9b75df	Apply suggestions from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-08-21 19:38:59 +09:00
smoogipoo	aead13628b	Rework freezing to use masking	2020-08-21 17:52:42 +09:00
smoogipoo	37cf7999b1	Merge branch 'master' into hold-note-freeze	2020-08-21 14:39:25 +09:00
smoogipoo	54a2322090	Use Array.Empty<>	2020-08-20 22:51:52 +09:00
smoogipoo	f1e0946603	Remove release samples in invert mod	2020-08-20 22:38:47 +09:00
Dean Herbert	f6ca31688e	Fix incorrect spacing	2020-08-19 21:39:55 +09:00
Dean Herbert	37f40f4a09	Merge branch 'master' into mania-slidertick-lighting	2020-08-19 21:19:25 +09:00
Dean Herbert	74f8e61381	Merge branch 'master' into mania-body-recycling	2020-08-19 20:40:15 +09:00
Dean Herbert	3eac81eb52	Merge pull request #9891 from smoogipoo/mania-mod-invert	2020-08-19 19:12:02 +09:00
Dean Herbert	72f16eb186	Merge pull request #9905 from smoogipoo/fix-holdnote-tick-judgement	2020-08-19 19:07:38 +09:00
Dean Herbert	0184bee44d	Merge branch 'master' into mania-mod-invert	2020-08-19 18:41:32 +09:00
smoogipoo	1d9d885d27	Mask the tail as the body gets shorter	2020-08-19 01:40:26 +09:00
smoogipoo	4d4d9b7356	Add rewinding support	2020-08-19 01:37:31 +09:00
Jihoon Yang	474f245222	Replace nested loop with early return	2020-08-18 08:40:29 -07:00
Jihoon Yang	af8f727721	Disable LegacyHitExplosion for hold notes	2020-08-18 08:28:53 -07:00
smoogipoo	99315a4aa7	Fix incorrect anchors for up-scroll	2020-08-19 00:05:36 +09:00
smoogipoo	988ad378a7	Fix body size + freeze head piece	2020-08-19 00:05:05 +09:00
smoogipoo	da07354f05	Fix some judgements potentially giving wrong score	2020-08-18 19:51:16 +09:00
smoogipoo	385f7cf85d	Implement mania hold note body recycling	2020-08-18 17:56:48 +09:00
Jihoon Yang	138dc5929e	Changed MIN_TIME_RANGE as well	2020-08-18 01:46:41 -07:00
Jihoon Yang	4ddc04793f	Changed MAX_TIME_RANGE instead of the single instance	2020-08-18 01:44:30 -07:00
smoogipoo	d157c42340	Increase density by not skipping objects	2020-08-18 17:40:44 +09:00
Jihoon Yang	628be66653	Updated calculation of mania scroll speed	2020-08-18 01:24:56 -07:00
smoogipoo	e1ed8554a1	Use yinyang icon	2020-08-18 17:23:11 +09:00
smoogipoo	583760100a	Implement mania invert mod	2020-08-18 01:40:55 +09:00
smoogipoo	548ccc1a50	Initial implementation of hold note freezing	2020-08-18 00:29:00 +09:00
Dean Herbert	f139423786	Merge branch 'master' into mania-hitexplosion-pooling	2020-07-30 10:40:29 +09:00
smoogipoo	5df406a035	Add pooling for mania judgements	2020-07-29 16:41:10 +09:00
smoogipoo	00821e7b65	Re-implement support for small ticks	2020-07-29 16:14:19 +09:00
smoogipoo	7f2e554ad4	Fix animations not being reset	2020-07-29 15:52:25 +09:00
smoogipoo	0f1f4b2b5c	Add pooling for mania hit explosions	2020-07-29 15:36:42 +09:00
smoogipoo	375dad0878	Increase PERFECT from 320 to 350 score	2020-07-28 17:59:52 +09:00
smoogipoo	f7cd6e83aa	Adjust mania scoring to be 95% based on accuracy	2020-07-28 17:58:58 +09:00
Dan Balasescu	a640541324	Merge pull request #9612 from peppy/input-handler-updates ... Input handler updates in line with framework changes	2020-07-22 20:30:32 +09:00
Dean Herbert	2c62b23d85	Update naming	2020-07-22 19:53:45 +09:00
smoogipoo	f044c06d08	Fix hold notes accepting presses during release lenience	2020-07-20 22:26:58 +09:00
Dean Herbert	648e414c14	Update InputHandlers in line with framework changes	2020-07-19 11:39:11 +09:00
Dean Herbert	56480d1665	Merge pull request #9538 from LastExceed/mania-fadein	2020-07-17 18:22:13 +09:00
smoogipoo	b3769112fb	Fix mania hold note bodies behaving badly with edge alphas	2020-07-17 17:08:26 +09:00
smoogipoo	8d9e5db641	Use enum values instead of class override	2020-07-16 21:29:39 +09:00
smoogipoo	03a7b8a6ef	Rename	2020-07-16 21:18:24 +09:00
smoogipoo	18d3685023	Pass in content	2020-07-16 21:17:51 +09:00
smoogipoo	967238e269	Add comment explaining scale	2020-07-16 17:47:00 +09:00
smoogipoo	74c7d9e67d	Use WithChild	2020-07-16 17:42:37 +09:00
smoogipoo	02031cea01	Add newline	2020-07-16 17:42:37 +09:00
smoogipoo	84e2e5677a	Add more info to xmldoc	2020-07-16 17:42:37 +09:00
smoogipoo	d546db0ec9	Fix default coverage	2020-07-16 17:35:00 +09:00
smoogipoo	b7f6ae5db9	Make the cover into a container	2020-07-16 17:26:48 +09:00
smoogipoo	1384e61747	Move cover to a separate file, rename	2020-07-16 17:26:34 +09:00
Dean Herbert	5049977395	Merge pull request #9578 from smoogipoo/accuracy-based-mania	2020-07-16 16:12:48 +09:00
smoogipoo	2b39857b8c	Make mania 80% acc 20% combo	2020-07-16 14:10:52 +09:00
smoogipoo	1a6ae3194e	Add test	2020-07-15 19:45:48 +09:00
LastExceed	d2e78d080c	fix naming convention violation	2020-07-15 11:29:13 +02:00
LastExceed	4a2890c054	implement FI by flipping HD upside down	2020-07-15 11:15:47 +02:00
LastExceed	e12f02a634	simplify reversing using rotation	2020-07-15 11:07:30 +02:00
LastExceed	b43b1673cc	fix leftover parameter name	2020-07-15 10:41:34 +02:00
LastExceed	f73fd7ffe9	read scroll direction from IScrollingInfo instead of config	2020-07-14 17:04:09 +02:00
LastExceed	3b7d52da09	rearrange LaneCover members	2020-07-14 16:48:14 +02:00
LastExceed	25fb49d59f	bind laneCover direction to scroll direction	2020-07-14 16:44:29 +02:00
LastExceed	921939f97a	extract coverage updating logic to separate method	2020-07-14 15:12:00 +02:00
LastExceed	fcda4d9f15	move lanecover implementation to ManiaModHidden	2020-07-14 15:06:15 +02:00
LastExceed	fec2594ac6	reverse LaneCover when playing up-scroll	2020-07-14 11:56:31 +02:00
LastExceed	ca39f2aa24	only insert BufferedContainer when using FI	2020-07-13 13:43:32 +02:00
LastExceed	3178217216	remove unnecessary import	2020-07-13 13:14:47 +02:00
LastExceed	4b3cffb246	expose hitObjectContainer in HitObjectArea	2020-07-13 11:55:13 +02:00
LastExceed	bdf680aecb	inline single-use constants	2020-07-12 14:53:40 +02:00
LastExceed	3606febe31	fix case convention violation	2020-07-12 14:23:55 +02:00
LastExceed	1cf8b599a1	implement fadein	2020-07-12 13:57:44 +02:00
LastExceed	06ed5316c4	expose hitObectArea in Column	2020-07-12 13:57:36 +02:00
LastExceed	0e49bf127b	wrap HitObjectContainer in BufferedContainer	2020-07-12 13:57:06 +02:00
Dean Herbert	bd5957bc0a	Add dynamic compilation exclusion rules for ruleset types	2020-07-10 14:49:44 +09:00
Bartłomiej Dach	b37eb63579	Merge branch 'master' into mania-conversion-precision	2020-06-30 20:16:47 +02:00
Bartłomiej Dach	39cfbb67ad	Replace iterated addition with rounding	2020-06-30 20:16:19 +02:00
Dean Herbert	e5a901cec7	Merge branch 'master' into results-screen-statistics-overlapping-transition	2020-06-28 22:14:22 +09:00
Bartłomiej Dach	1551c42c12	Avoid division when slicing node sample list	2020-06-27 17:03:32 +02:00
Bartłomiej Dach	5e92809401	Add failing test case	2020-06-27 16:46:43 +02:00
Bartłomiej Dach	c47f762f24	Update test scene to allow checking samples	2020-06-27 16:45:39 +02:00
Dean Herbert	9119f41604	Merge branch 'master' into results-screen-statistics-overlapping-transition	2020-06-24 18:22:51 +09:00
Bartłomiej Dach	8233f5fbc4	Check skin option in skin transformers	2020-06-22 20:08:32 +02:00
smoogipoo	4d30761ce3	Fix 1M score being possible with only GREATs in mania	2020-06-22 19:52:23 +09:00
smoogipoo	988baad16f	Expand statistics to fill more of the screen	2020-06-22 19:20:43 +09:00
smoogipoo	261adfc4e6	Create a local playable beatmap instead	2020-06-22 18:38:41 +09:00
smoogipoo	33fdd7466c	Merge branch 'master' into results-screen-statistics-overlapping-transition	2020-06-22 15:38:48 +09:00
Bartłomiej Dach	ad85c5f538	Add base legacy skin transformer	2020-06-21 23:06:55 +02:00
Dan Balasescu	9c7031965f	Merge branch 'master' into mania-element-lookup-refactor	2020-06-21 22:36:53 +09:00
Dean Herbert	26f049ab16	Merge pull request #9330 from smoogipoo/reduce-mania-hp-drain ... Reduce mania's HP drain by 20%	2020-06-21 19:58:15 +09:00
smoogipoo	44925b3951	Reduce mania's HP drain by 20%	2020-06-21 18:05:26 +09:00
smoogipoo	19eb6fad7f	Make hold note ticks affect combo score rather than bonus	2020-06-21 17:42:17 +09:00
mcendu	ca555a6a52	rename per-column skin config retrieval to GetColumnSkinConfig ... Removed parameter "index"; all these cases should use extension instead	2020-06-20 14:56:39 +08:00
mcendu	8298a2c8a9	inline stage light lookup and clarify behavior	2020-06-20 14:53:25 +08:00
smoogipoo	486b899e8f	Rename method	2020-06-19 22:11:29 +09:00
smoogipoo	81ad257a17	Add timing distribution to mania ruleset	2020-06-19 21:18:58 +09:00
mcendu	9a0a1ba0df	correct logic of hasKeyTexture determination	2020-06-13 23:12:15 +08:00
mcendu	ffae73a966	let retrievals outside mania skin components use extension ... https://github.com/ppy/osu/pull/9264#discussion_r439730321	2020-06-13 23:07:04 +08:00
mcendu	bd7b7b5017	make all former LegacyManiaElement subclasses use extension method ... Remove LegacyManiaElement	2020-06-13 23:06:25 +08:00
mcendu	308ec6a491	add extension method for mania skin config retrieval	2020-06-13 23:05:57 +08:00
Dean Herbert	8402d4a5f3	Remove newline	2020-06-13 21:18:56 +09:00
mcendu	4eeb22ca18	rename a few variables and fix typo	2020-06-13 18:47:40 +08:00
mcendu	5655e090d1	revert movement of is mania skin check statements	2020-06-13 18:45:06 +08:00
mcendu	aa476835e7	tidy up code	2020-06-13 11:31:34 +08:00
mcendu	7c3e7b65a8	add custom file path support for osu\!mania judgement sprite	2020-06-12 21:22:22 +08:00
Bartłomiej Dach	896177801a	Avoid creating copies of node samples every time	2020-06-05 00:07:27 +02:00
Bartłomiej Dach	c4cae006aa	Correctly slice node sample list when converting	2020-06-04 22:47:39 +02:00
Bartłomiej Dach	ac019bddd6	Only play samples at start of hold note in mania maps	2020-06-04 22:33:34 +02:00
Bartłomiej Dach	35544ede50	Add failing test cases	2020-06-04 22:33:30 +02:00
Dan Balasescu	a8b137bb71	Merge pull request #9123 from peppy/move-setter-to-duration ... Move setter from EndTime to Duration	2020-06-01 16:52:38 +09:00
Dan Balasescu	64d1b4b11b	Merge branch 'master' into move-setter-to-duration	2020-06-01 15:55:48 +09:00
Dean Herbert	b9464a2aa8	Merge branch 'master' into editor-create-composer-fix	2020-06-01 15:38:15 +09:00
smoogipoo	d7e0391b5f	Merge branch 'master' into i-has-curve-with-repeats	2020-06-01 14:27:43 +09:00
Dean Herbert	0ef971be28	Merge branch 'master' into i-has-curve-with-repeats	2020-05-31 22:30:18 +09:00
mcendu	b06017dbf1	supress horizontal scaling of left-and-right stages	2020-05-31 11:28:54 +08:00
Dean Herbert	e8b43e8e1f	Merge branch 'master' into move-setter-to-duration	2020-05-29 16:04:23 +09:00
Dean Herbert	8fa8c561e7	Pass hitobjects as a parameter to CreateBlueprintContainer	2020-05-29 12:20:50 +09:00
Dean Herbert	6be5917eb0	Remove necessity for custom mania interface caching	2020-05-27 23:15:16 +09:00
Dean Herbert	919ff92d15	Remove unused resolved composer	2020-05-27 22:56:12 +09:00
Dean Herbert	cbd563e80b	Rename to IHasDuration	2020-05-27 12:38:39 +09:00
Dean Herbert	6b5b215299	Split out IHasPath from IHasCurve to better define hitobjects	2020-05-26 17:44:47 +09:00
Dan Balasescu	b5de30ef3d	Merge branch 'master' into editor-scrolling-playfield-support	2020-05-26 14:46:58 +09:00
Dean Herbert	0cc6d6d97c	Merge pull request #9033 from smoogipoo/applydefaults-cancellation ... Add cancellation token support to CreateNestedHitObjects()	2020-05-26 12:04:06 +09:00
Dean Herbert	827345ed88	Fix mania offsets	2020-05-25 22:06:02 +09:00
Dean Herbert	e7442ec3a2	Remove need for ManiaSnapResult	2020-05-25 19:33:03 +09:00
Dean Herbert	2c16619ecd	Move time to position conversion to ScrollingHitObjectContainer	2020-05-25 19:32:39 +09:00
Dean Herbert	b8130bd366	Make mania selection blueprint abstract	2020-05-25 19:31:09 +09:00
smoogipoo	bc35bc5efb	Merge branch 'master' into applydefaults-cancellation	2020-05-25 16:45:30 +09:00
Dean Herbert	ce35d09e7d	Fix incorrect alpha application to lines on rewinding	2020-05-22 12:45:37 +09:00
Dean Herbert	d529a2aefa	Remove left-over function	2020-05-22 12:28:01 +09:00
Dean Herbert	b2667bbb02	Move protected implementation down	2020-05-22 11:45:58 +09:00
Dean Herbert	6de2597958	Merge branch 'editor-position-snap' into mania-distance-snap-grid	2020-05-22 11:27:36 +09:00
Dean Herbert	8a105bdbcf	Remove unused ColumnAt method	2020-05-22 11:23:39 +09:00
Dean Herbert	7dd3b3eeb5	Remove unused method	2020-05-21 15:16:59 +09:00
Dean Herbert	a756e6d212	Add xmldoc and remove unnecessary parameter	2020-05-21 15:16:30 +09:00
Dean Herbert	ce8b6b7383	Correctly account for blueprint origins	2020-05-21 15:15:24 +09:00
Dean Herbert	a9a1c00cf1	Move responsibility placement blueprint's StartTime set to within	2020-05-21 14:50:33 +09:00
Dean Herbert	bac78707de	Move more logic to column to both clean things up and fix tests	2020-05-21 14:25:37 +09:00
Dean Herbert	5ad7842b91	Move ScreenSpacePositionAtTime to inside Column implementation	2020-05-21 13:33:02 +09:00
Dean Herbert	94bb59db0d	Merge branch 'editor-position-snap' into mania-distance-snap-grid	2020-05-21 12:50:49 +09:00
Dean Herbert	83a5913b8d	Undo beat snapping related changes	2020-05-21 12:12:21 +09:00
Dean Herbert	69db62b78a	Combine implementation of time-to-position lookup	2020-05-20 21:42:21 +09:00
Dean Herbert	63b5f1a376	Remove unnecessary IRequireHighFrequencyMousePosition	2020-05-20 21:14:20 +09:00
Dean Herbert	e3cec9cf6c	Simplify column assignment	2020-05-20 21:13:08 +09:00
Dean Herbert	7c9fbb6fcf	Split out classes	2020-05-20 21:03:03 +09:00
Dean Herbert	19e2da9c73	Fix down scrolling giving incorrect positioning data	2020-05-20 21:01:29 +09:00
Dean Herbert	26fb779f4d	Move remaining positioning logic local to hold note blueprint	2020-05-20 21:01:29 +09:00
Dean Herbert	2f78866dfb	Move positioning out of mania blueprints	2020-05-20 21:01:29 +09:00
Dean Herbert	62092e3f5b	Propagate mania column in SnapResult	2020-05-20 21:01:29 +09:00
Dean Herbert	82d6549161	Pass down snap result and remove local TimeAt usage	2020-05-20 21:01:29 +09:00
Dean Herbert	970bd86d2e	Remove local TimeAt usage in mania placement	2020-05-20 21:01:29 +09:00
Dean Herbert	23bf0d000e	Implement mania beat snapping support	2020-05-20 21:01:19 +09:00
Dean Herbert	ffb8d48fc3	Fix osu!mania editor placement regressions	2020-05-20 21:01:03 +09:00
Dean Herbert	c46bfc2532	Create SnapResult class to hold various snapping results	2020-05-20 21:00:47 +09:00
Dean Herbert	3354d48a38	Change snapping to be screen space coordinate based	2020-05-20 21:00:29 +09:00
Dean Herbert	0bc3073d49	Fix test failures	2020-05-20 15:01:32 +09:00
Dean Herbert	d31a59b074	Fix logic results in infinite loop on default timing point return	2020-05-20 14:55:36 +09:00
Dean Herbert	4f83bb679b	Merge branch 'master' into mania-distance-snap-grid	2020-05-20 11:44:19 +09:00
Dean Herbert	85156c62ef	Add xmldoc and address some code quality concerns	2020-05-19 23:05:08 +09:00
Dean Herbert	c28a9bdb80	Move load method up	2020-05-19 23:02:20 +09:00
Dean Herbert	a6f3dc53f7	Fix time value not being updated for next timing point	2020-05-19 23:01:36 +09:00
Dean Herbert	d56466e2b9	Add very basic pooling of grid lines	2020-05-19 19:07:35 +09:00
Dean Herbert	406f39e8bf	Construct online visible lines	2020-05-18 21:27:26 +09:00
Dean Herbert	b35b150f38	Simplify colouring logic	2020-05-18 19:48:51 +09:00
Dean Herbert	16e85ae0b1	Remove Grid class	2020-05-18 17:52:04 +09:00
Dean Herbert	d9bb90078b	Move grids to inside columns	2020-05-18 17:47:52 +09:00
Dean Herbert	3e81d6d55f	Merge pull request #9053 from smoogipoo/fix-possible-ppcalc-exception ... Fix possible exceptions in performance calculators	2020-05-18 16:37:33 +09:00
smoogipoo	1865cd0762	Fix possible exceptions in performance calculators	2020-05-18 15:10:59 +09:00
Bartłomiej Dach	76c5be7bc1	Disallow catch-specific judgements in mania	2020-05-17 17:16:22 +02:00
smoogipoo	4719fcc291	Actually use the cancellation token	2020-05-15 18:17:39 +09:00
smoogipoo	98125102a7	Add cancellation token support to CreateNestedHitObjects()	2020-05-15 18:07:41 +09:00
smoogipoo	238d87f976	Add comment about gray usage	2020-05-15 15:56:32 +09:00
smoogipoo	1c6c128d11	Add const	2020-05-15 15:51:54 +09:00
smoogipoo	392d44e1fb	Always fully display one beat	2020-05-15 15:49:50 +09:00
smoogipoo	4cbd51feb9	Fix test errors	2020-05-15 13:08:15 +09:00
smoogipoo	3441ab457d	Fix hitobjects placed at non-beatsnapped times	2020-05-14 20:06:34 +09:00
smoogipoo	0e33494074	Fix flashing when changing beat divisor	2020-05-14 19:58:39 +09:00
smoogipoo	42c3d892cd	Only update alive lines	2020-05-14 19:55:14 +09:00
smoogipoo	91d1b15d5a	Integrate grid with the mania composer	2020-05-14 19:55:07 +09:00
smoogipoo	16585f767e	Add initial beat snap grid implementation	2020-05-14 19:17:24 +09:00
smoogipoo	0ef3bae26a	Expose playfield from IManiaHitObjectComposer	2020-05-14 18:34:51 +09:00
smoogipoo	78f1b230e9	Disable right-click placement in the mania editor	2020-05-13 14:43:50 +09:00
Dean Herbert	064e5004ed	Merge branch 'master' into fix-mania-selection	2020-04-29 17:15:48 +09:00
smoogipoo	4f332ace14	Use 0 length	2020-04-29 14:27:21 +09:00
smoogipoo	0c95d11fdb	Remove unnecessary value change binding	2020-04-29 13:27:33 +09:00
Dan Balasescu	024f10a494	Use non-generic bindable ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-04-29 13:24:31 +09:00
smoogipoo	1aaab40228	Fix mods affecting mania scroll speed	2020-04-28 19:34:02 +09:00
smoogipoo	ff3928465c	Add xmldoc	2020-04-28 18:58:29 +09:00
smoogipoo	db12fafc2c	Update comment	2020-04-28 18:58:29 +09:00
smoogipoo	ff24a15760	Fix vertical drag in down-scroll scenarios	2020-04-28 18:36:24 +09:00
smoogipoo	7d54d4b800	Improve test scene	2020-04-28 18:36:10 +09:00