4654 Commits

Author	SHA1	Message	Date
Dean Herbert	9384687d6d	Switch ModMuted to add its metronome to components rather than overlays	2023-02-21 19:04:06 +09:00
Dean Herbert	1acc536248	Move DrawableRuleset.Audio to a less generic level	2023-02-21 19:03:52 +09:00
Dean Herbert	5ba6059911	Merge branch 'master' into fix-taiko-drum-nested-sample-detection	2023-02-21 13:58:15 +09:00
MK56	b74c1c8334	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-19 21:36:59 +01:00
Bartłomiej Dach	3183f5cee2	Merge branch 'master' into revert-result-in-playfield	2023-02-19 16:33:10 +01:00
Bartłomiej Dach	d9ca7102f0	Use more generic wording for future-proofing	2023-02-19 15:06:40 +01:00
Bartłomiej Dach	aac32a2c9f	Combine config and time checks into one ... Functionally equivalent right now, but the combined variant is more localised to what it actually needs to do, and less error-prone if any new code gets appended to the method.	2023-02-19 13:14:51 +01:00
Maximilian Kruse	f3522c4162	change bindable seekToHitObject to private	2023-02-19 10:18:02 +01:00
Maximilian Kruse	ddd37bb319	Add setting to disable automatic seeking after object placement	2023-02-18 19:43:45 +01:00
Dean Herbert	19d5293ad1	Change early return to also find the earliest nested object	2023-02-17 18:59:31 +09:00
Bartłomiej Dach	3ee046000e	Merge branch 'master' into revert-result-in-playfield	2023-02-16 21:54:29 +01:00
Bartłomiej Dach	b8084a15eb	Revert ResumeOverlay setter accessibility change	2023-02-16 21:26:01 +01:00
Dean Herbert	affa9507a1	Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play	2023-02-16 18:21:33 +09:00
Dean Herbert	ce9ef3bc3c	Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not	2023-02-16 15:47:20 +09:00
Dean Herbert	7afdcb9383	Merge branch 'master' into hide-resume-overlay	2023-02-16 15:42:14 +09:00
tsrk	076eb81b21	refactor: rename trigger classes ... Makes it better to understand their purpose	2023-02-15 21:46:13 +00:00
tsrk	157bba7830	refactor: rename Trigger class to InputTrigger	2023-02-15 21:41:36 +00:00
Dean Herbert	da8ab7143b	Merge branch 'master' into maximum-judgement-offset-in-hit-object	2023-02-15 14:48:15 +09:00
Dean Herbert	5024838f3a	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-15 13:47:18 +09:00
Dean Herbert	5ec5222d8a	Expose and consume OsuInputManager explicitly	2023-02-14 17:36:07 +09:00
Dean Herbert	b42b5f97cf	Use Overlays container rather than KeyBindingInputManager for flashlight	2023-02-14 17:36:07 +09:00
Dean Herbert	970388d4e2	Move Overlays container to accept input and be frame-stable	2023-02-14 17:35:12 +09:00
Dean Herbert	7aaaf7fca2	Combine and attempt to simplify the score import / preparation process further	2023-02-14 16:55:35 +09:00
Dean Herbert	63f3498762	Restructure UseResumeOverlay to correctly handle a value change before BDL load	2023-02-14 15:11:33 +09:00
Pasi4K5	e4b84ebd0b	Add UseResumeOverlay and use it for hiding the ResumeOverlay	2023-02-13 23:51:39 +01:00
tsrk	74a58fb674	refactor: separate things in KeyCounter ... To implement different different sources of input for KeyCounter, it is now possible to create a Trigger class (to inherit) instead of inheriting KeyCounter. This eases the creation of more input sources (like for tests) while allowing to implement different UI variants. That way, if another variant of the key counter needs to implemented (for whathever reason), this can be done by only inheriting KeyCounter and changing how things are arranged visually.	2023-02-13 01:24:27 +00:00
Dean Herbert	9d09141ab7	Move taiko-specific property out of DrawableHitObject	2023-02-12 16:09:28 +09:00
Dean Herbert	ad8b01b478	Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions ... Always add to additions soundbank in `convertSoundType`	2023-02-10 17:14:29 +09:00
Dean Herbert	eccde923e5	Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability ... Improve readability of `AccuracyCircle`	2023-02-10 17:03:46 +09:00
Dean Herbert	1df6fc6311	Use if statements rather than conditional case	2023-02-10 17:03:27 +09:00
Bartłomiej Dach	96c1832af4	Fix grammar in xmldoc ... Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>	2023-02-10 00:07:24 +01:00
sw1tchbl4d3	f0d11f44fc	Always add to additions soundbank in convertSoundType	2023-02-09 22:27:52 +01:00
Dean Herbert	34d1890f1c	Change snapping to only apply to classic mod	2023-02-09 18:22:14 +09:00
ekrctb	258de3b2d8	Store RawTime in JudgementResult	2023-02-09 17:15:37 +09:00
ekrctb	5f0636c330	Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield	2023-02-09 16:47:58 +09:00
Dean Herbert	cf009432cc	Centralise accuracy cutoff constants and add lookup helper methods	2023-02-09 15:41:58 +09:00
Dean Herbert	c691a0d3af	Merge branch 'master' into sheared_slider_implementation_clean_ii	2023-02-06 17:49:33 +09:00
Dean Herbert	a67d5d2a14	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-06 17:24:20 +09:00
Joseph Madamba	191259c050	Use equals instead and update other usage	2023-02-04 19:58:48 -08:00
mk56-spn	3f0ce75bf5	Rename NormalSliderBar.cs to RoundedSliderBar.cs	2023-02-02 17:24:45 +01:00
Dean Herbert	b792dc3af0	Merge pull request #22281 from cdwcgt/editor-check-previewtime ... Add preview time setting check	2023-02-02 15:10:06 +09:00
Dean Herbert	5b3d7a8f26	Fix typo in missing-preview-point message	2023-02-02 14:34:59 +09:00
Dean Herbert	c2cde8361a	Fix message not reading well	2023-02-02 14:33:41 +09:00
Dean Herbert	3a861fd943	Remove multiple cases of excess braces	2023-02-02 14:28:21 +09:00
Dean Herbert	10df64467a	Merge pull request #22430 from peppy/skin-editor-nrt ... Apply NRT to all skin editor classes	2023-02-02 13:57:57 +09:00
cdwcgt	76296eb35a	Consistent with BeatmapsetVerifier	2023-02-01 11:52:14 +08:00
Bartłomiej Dach	c5e1f54185	Fix sample store creation mutating shared resource store	2023-01-30 20:48:52 +01:00
MK56	c50604f701	Merge branch 'master' into bubble_mod_implementation_clean	2023-01-27 11:58:56 +01:00
ekrctb	27578c48f5	Remove JudgementResultEntry ... It is not needed anymore as TimeAbsolute is stored raw.	2023-01-27 19:35:44 +09:00
Dean Herbert	74ab036f3e	Refactor SkinnableSound.Samples to be non-nullable	2023-01-27 19:32:30 +09:00
mk56-spn	3988131475	Rename OsuSliderBar.cs as NormalSliderBar.cs	2023-01-26 12:12:56 +01:00
Dean Herbert	f0406c34fd	Merge branch 'master' into revert-result-in-playfield	2023-01-25 17:35:33 +09:00
Dean Herbert	a966d6c330	Merge pull request #18402 from ggliv/mod-accuracy-challenge ... Add accuracy challenge mod	2023-01-24 16:00:55 +09:00
ekrctb	e1702a8ee9	Fix inspection issue	2023-01-24 15:43:57 +09:00
ekrctb	efef97d5be	Store Result.TimeAbsolute separately from offset ... Calculating from TimeOffset is bad because it loses precision. The result time won't change anymore even If `HitObject.GetEndTime()` changes later.	2023-01-24 15:35:06 +09:00
Gabe Livengood	b46ef67a14	increase min minimum accuracy to 60%	2023-01-24 00:31:46 -05:00
ekrctb	cc87923179	Fix OnRevertResult timing	2023-01-24 14:19:24 +09:00
ekrctb	e66e43e17c	Remove unused code	2023-01-24 14:15:17 +09:00
Pasi4K5	8b47af6503	Remove HidesResumeOverlay and set ResumeOverlay to null in OsuModAutopilot	2023-01-24 00:49:09 +01:00
Bartłomiej Dach	7483967157	Merge branch 'master' into SliderEnd-Snap	2023-01-23 21:33:16 +01:00
Bartłomiej Dach	1f40b2daf6	Clean up xmldocs	2023-01-23 21:22:18 +01:00
cdwcgt	5afb733fb2	change IssueTemplatePreviewTimeConflict's text	2023-01-23 15:26:28 +09:00
Dean Herbert	73f083a316	Refactor how additional points are provided to avoid confusion	2023-01-23 14:13:46 +09:00
Pasi4K5	75a1a2ec2f	Hide ResumeOverlay when OsuModAutopilot is enabled	2023-01-22 03:44:59 +01:00
ekrctb	d8f9b7d02f	Use MaximumJudgementOffset for lifetime	2023-01-19 21:25:21 +09:00
ekrctb	11e1b22bf5	Move MaximumJudgementOffset to HitObject ... We want to access this property for computing lifetime	2023-01-19 21:23:55 +09:00
ekrctb	812a4b412a	Move judgement result revert logic to Playfield ... Previously, some judgement results were not reverted when the source DHO is not alive (e.g. frames skipped in editor). Now, all results are reverted in the exact reverse order.	2023-01-19 19:57:13 +09:00
Wleter	f8d8a627b8	change property name	2023-01-18 22:00:39 +01:00
Wleter	ab78dd0436	add collection of selection points.	2023-01-18 21:34:23 +01:00
Gabe Livengood	150195b887	use extension method to check accuracy impact	2023-01-18 12:24:41 -05:00
Gabe Livengood	e0f3fa1af6	remove this in ruleset assignment	2023-01-18 12:22:27 -05:00
cdwcgt	e5eab72aeb	add check for preview time setting	2023-01-19 01:08:37 +09:00
Dean Herbert	522bb8bcca	Use ComputeAccuracy to get imminent accuracy	2023-01-18 18:08:58 +09:00
Gabe Livengood	0b1e5c0f53	lambdaify function	2023-01-17 10:23:57 -05:00
Dean Herbert	23ea77cb74	Use ScoreProcessor to fetch accuracy rather than calculating manually	2023-01-17 17:03:04 +09:00
Dean Herbert	70cb23bbc9	Merge branch 'master' into mod-accuracy-challenge	2023-01-17 16:46:54 +09:00
Andrei Zavatski	d74a5ef9e6	Use property instead of ctor parameter	2023-01-12 23:26:29 +03:00
Andrei Zavatski	a7ac31fa34	Use IsLegacyRuleset extension method	2023-01-12 23:21:33 +03:00
Andrei Zavatski	a9915d6a64	Make OverlayRulesetSelector display only legacy rulesets	2023-01-12 22:44:41 +03:00
Dan Balasescu	bbec42c00e	Fix incorrect max combo after watching imported legacy replays	2023-01-12 14:18:21 +09:00
MK56	f9b42161e3	Merge branch 'master' into bubble_mod_implementation_clean	2023-01-11 14:56:21 +01:00
Dean Herbert	d1ca4ebd40	Merge pull request #21559 from OliBomby/stream-tool-1 ... Add segment end completions list to SliderPath	2023-01-11 15:31:04 +09:00
Dan Balasescu	d9a6e4b862	Ensure drain lenience of 1.0 completly removes drain	2023-01-11 13:01:11 +09:00
Wleter	98ffcd33c7	Merge branch 'ppy:master' into SliderEnd-Snap	2023-01-10 21:22:13 +01:00
Wleter	e5863fbaf1	add ScreenSpaceEndPoint field	2023-01-10 21:20:09 +01:00
Bartłomiej Dach	6ed474d4fb	Rearrange formula for maximum accuracy ... Feels like it's easier to understand this way. The difference of the maximum scoring values for the entire beatmap and the max values for the part of the beatmap that has already been played represents the act of filling the rest of the unjudged objects with maximum results.	2022-12-30 20:56:54 +01:00
Bartłomiej Dach	8ace635249	Adjust minimum values	2022-12-30 20:55:51 +01:00
Bartłomiej Dach	bb2822a175	xmldoc pass	2022-12-30 20:55:48 +01:00
Bartłomiej Dach	6d42cc5a36	Naming pass	2022-12-30 20:30:58 +01:00
cdwcgt	3c32a50c12	add new accuracy counter display	2022-12-30 21:19:46 +09:00
Berkan Diler	c7ca4bbba5	Use generic Enum methods	2022-12-26 20:36:39 +01:00
mk56-spn	bbb22479a8	Add "ModBubbles" for the osu ruleset.	2022-12-25 23:09:52 +01:00
Bartłomiej Dach	80de5dac66	Fix judgement text never being added to hierarchy	2022-12-24 09:37:40 +01:00
Bartłomiej Dach	f973befcd4	Remove unused resolved member	2022-12-24 09:34:30 +01:00
Dean Herbert	5e9fb1063a	Move judgement text creation to base class and tidy things up	2022-12-24 12:22:36 +08:00
Dean Herbert	727ac00f6d	Combine base class for JudgementPiece	2022-12-24 03:32:13 +08:00
Berkan Diler	08d2fbeb8e	Use new ArgumentNullException.ThrowIfNull throw-helper API	2022-12-22 21:27:59 +01:00
Dean Herbert	4a7d7c6ed9	Use MaxBy in all locations that can and update inspection level to match dotnet-build	2022-12-19 16:47:10 +09:00
Dean Herbert	877413524f	Cherry-picked android changes from #17462	2022-12-19 15:46:54 +09:00
Dean Herbert	27c497145f	Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0	2022-12-16 18:16:26 +09:00
Dean Herbert	5800734589	Merge pull request #21587 from smoogipoo/spectatorstate-maximum-statistics ... Store maximum statistics to spectator state	2022-12-12 20:00:52 +09:00
Dean Herbert	df94af4495	Inline ScoringValues and make some more methods private inside ScoreProcessor	2022-12-12 19:22:09 +09:00
Dan Balasescu	7a54bcac57	Remove unused using	2022-12-12 11:41:07 +09:00
Dan Balasescu	6e41efede8	Simplify dictionary construction	2022-12-12 11:40:47 +09:00
Dan Balasescu	5e8d75bbbf	Remove unused overload	2022-12-12 11:39:03 +09:00
Dean Herbert	85039209f8	Fix parsing of ruleset configuration values being incorrect on some locales ... Closes #21611.	2022-12-12 01:56:36 +09:00
Dan Balasescu	e9998f1690	Store maximum statistics to spectator state	2022-12-09 20:15:07 +09:00
OliBomby	98a312ca96	Fix segmentEnds incorrect on shortened paths	2022-12-07 09:52:09 +01:00
OliBomby	cd46ca31f9	Add segmend end completions to SliderPath	2022-12-07 09:51:22 +01:00
Bartłomiej Dach	81a42dc05d	Fix extended values in difficulty adjust being truncated to 10 on beatmap change	2022-12-06 23:25:48 +01:00
Dan Balasescu	9e64f8dab1	Fix loss of precision when computing accuracy	2022-12-05 19:08:50 +09:00
Dean Herbert	5a69656764	Merge pull request #21496 from peppy/fix-zero-length-spinners ... Fix being able to place zero-length spinners	2022-12-02 19:25:00 +09:00
Dan Balasescu	850931120d	Merge pull request #21479 from peppy/fix-wrong-last-hit-object-time ... Fix some components not accounting for final hold notes in osu!mania beatmaps	2022-12-02 18:12:00 +09:00
Dean Herbert	ba99f1288c	Update IBeatSnapProvider documentation to mention the pre-divided BeatSnap	2022-12-02 17:57:15 +09:00
Dan Balasescu	a39bd634c4	Merge pull request #21405 from LumpBloom7/Editor-DrawableRuleset-Dependencies ... Provide DrawableRulesetDependencies from HitObjectComposer	2022-12-02 17:31:31 +09:00
Dean Herbert	25120060aa	Use new helper method in ModTimeRamp	2022-12-02 16:09:46 +09:00
Dean Herbert	809d02cda0	Fix two implementation oversights	2022-12-02 16:05:14 +09:00
Dean Herbert	d8dd7e7e0f	Fix test failures when no hitobjects are present in a scrolling ruleset	2022-12-01 21:42:03 +09:00
Dean Herbert	896f2d8f74	Fix multiple instances of last hitobject time being calculated incorrectly	2022-12-01 18:04:06 +09:00
Dean Herbert	c5bc071c4b	Merge pull request #21439 from LumpBloom7/Fix-DHO-load-state ... Update DrawableHitObject state based on entry result during LoadComplete	2022-12-01 15:36:36 +09:00
Bartłomiej Dach	2e19e93036	Rename method	2022-11-30 22:54:14 +01:00
Bartłomiej Dach	6ebde9a747	Annotate Playfield.Mods as maybe-null	2022-11-30 20:00:25 +01:00
Derrick Timmermans	6a61e70766	Expose Ruleset from HitObjectComposer instead	2022-11-30 12:17:58 +01:00
Dean Herbert	5ce2d6f54a	Hide the game mouse cursor when playing osu!catch with relax mod	2022-11-30 18:13:53 +09:00
Dean Herbert	bb0237d4a9	Fix nullability inspection on disposal path	2022-11-30 17:49:08 +09:00
Dean Herbert	4215f4f5d7	Merge branch 'master' into Editor-DrawableRuleset-Dependencies	2022-11-30 17:42:46 +09:00
Derrick Timmermans	93ba84e5ff	Fix code style	2022-11-27 21:48:44 +01:00
Derrick Timmermans	70c320b2e8	Provide ruleset dependencies only to Compose Placement Blueprints	2022-11-27 21:43:33 +01:00
Derrick Timmermans	cff3e06ad6	Update state based on result during LoadComplete	2022-11-27 20:57:00 +01:00
Bartłomiej Dach	894ef15e79	Merge branch 'master' into update-framework	2022-11-26 16:19:36 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Dean Herbert	76e9382e0b	Fix triangles showing on ExpandableButtons when in contracted state	2022-11-25 20:18:35 +09:00
Derrick Timmermans	65e5c9a3ae	Dispose DrawableRulesetDependencies in HitObjectComposer	2022-11-25 08:27:22 +01:00
Dean Herbert	f6e229c24d	"Fix" mod copy failure	2022-11-25 01:15:11 +09:00
Dean Herbert	2b2beadd06	Merge branch 'master' into update-framework	2022-11-25 01:00:08 +09:00
Derrick Timmermans	7b620392fe	Provide DrawableRulesetDependencies from HitObjectComposer	2022-11-24 13:13:45 +01:00
Dean Herbert	a2438428a2	Move base call to end	2022-11-24 13:57:43 +09:00
Dean Herbert	b381b4fd2d	Merge branch 'master' into update-framework	2022-11-24 01:27:58 +09:00
Bartłomiej Dach	508f1f488c	Merge branch 'master' into limit-barline-generation-sanity	2022-11-23 17:12:36 +01:00
Dean Herbert	f9d952220f	Fix barlines being misaligned if generation start time is clamped	2022-11-23 18:12:03 +09:00
Dean Herbert	172e798847	Merge pull request #21228 from Terochi/recent-messages-implementation ... Add ability to view chat send history in input box	2022-11-23 14:58:42 +09:00
Dean Herbert	1632df1f4d	Update DifficultyBindable to match new bindable spec	2022-11-22 14:51:19 +09:00
Dean Herbert	40f2da364c	Limit how far before the first hitobject that barlines can be generated	2022-11-21 14:40:25 +09:00
Bartłomiej Dach	0f382590e6	Remove unnecessary #nullable disable	2022-11-20 15:31:51 +01:00
Salman Ahmed	58296bd4f0	Introduce IDrawableScrollingRuleset for editor consumption	2022-11-20 04:11:10 +03:00
Terochi	eff6c7be64	Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.	2022-11-19 16:53:35 +01:00
Dan Balasescu	57b8495c7a	Merge branch 'master' into long-standard	2022-11-18 14:24:04 +09:00
Dan Balasescu	d47c46d144	Compute raw score in-line ... Saves on an allocation (though it seems to only be a ValueType so it shouldn't be a big deal) and a tail-call.	2022-11-18 14:22:28 +09:00
Susko3	56fd1f95b1	Fix FallbackSampleStore.GetAsync fallback logic	2022-11-13 18:47:28 +01:00
maromalo	1911120afe	Merge branch 'master' into long-standard	2022-11-12 09:52:11 -03:00
Dean Herbert	106f1cf90b	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 18:24:39 +09:00
Dan Balasescu	fe58329478	Merge pull request #21151 from peppy/taiko-judgement-fixes ... Fix various issues surrounding hit judgements	2022-11-11 16:41:46 +09:00
Dan Balasescu	5bdbf56f43	Merge branch 'master' into taiko-judgement-fixes	2022-11-11 15:48:33 +09:00
Dan Balasescu	1a1a186d22	Merge branch 'master' into taiko-barline-separation	2022-11-11 15:47:06 +09:00
Dan Balasescu	db25e9e9c8	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 15:31:28 +09:00
maromalo	83a3f1b82e	Add computeRawScore()	2022-11-10 14:15:20 -03:00
Dan Balasescu	606d42c679	Merge pull request #21184 from peppy/skinnable-things-cleanup ... Skinnable class naming pass	2022-11-10 12:52:08 +09:00
Dan Balasescu	051f7f4c68	Merge pull request #21173 from peppy/toggle-hit-markers ... Add the ability to toggle off hit marker displays in the editor	2022-11-10 12:23:53 +09:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	c908969d9b	Rename ISkinComponent to ISkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	bf26dbffc2	Apply nullability to skinning support classes	2022-11-09 13:59:13 +09:00
Dean Herbert	dd4cd3cf8e	Move gameplay configuration to interface to allow editor overriding	2022-11-08 18:25:24 +09:00
Dean Herbert	ada039151b	Add the ability to toggle off hit marker displays in the editor	2022-11-08 18:07:06 +09:00
maromalo	64e6276397	Fix score rounding issue	2022-11-08 01:10:21 -03:00
Dean Herbert	2b72c3833b	Remove unnecessary centering logic in DrawableJudgement	2022-11-07 17:19:32 +09:00
Dean Herbert	c69a4f9333	Move major barline portion to default implementation to allow for further customisation ... Of note, this removes the "major" barline triangles from legacy skins. I think this is more correct, as they did not display in stable.	2022-11-07 14:29:58 +09:00
maromalo	b7ef9b176d	Make score type consistent	2022-11-06 19:59:27 -03:00
Dean Herbert	51078bddf9	Remove unused bindable	2022-11-06 23:34:04 +09:00
Dean Herbert	e02c477008	Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks ... Remove nullable disable in the checks.	2022-11-06 18:39:03 +09:00
Bartłomiej Dach	84179fb087	Merge branch 'master' into combo-colour-brightness-limit	2022-11-05 16:48:56 +01:00
Dean Herbert	566738494f	Merge pull request #20952 from OliBomby/bezier-convert ... Add conversion algorithm for lazer slider curves to work with stable	2022-11-04 16:49:51 +09:00
Dean Herbert	3ec9686e58	Fix test failures and rename configuration value to match better	2022-11-02 18:15:18 +09:00
Dean Herbert	99ba7c29dd	Change range to 0-100% and rename to "normalisation"	2022-11-02 13:47:11 +09:00
Dean Herbert	2f3c80f884	Remove toggle and change method of application to blend with original colour	2022-11-02 13:08:29 +09:00
Dean Herbert	a01602e63c	Merge branch 'master' into combo-colour-brightness-limit	2022-11-02 12:09:27 +09:00
Bartłomiej Dach	ac554c644d	Merge branch 'master' into fix-slider-sv-snap	2022-11-01 13:19:46 +01:00
Dean Herbert	f014acfc8d	Fix DrawableHitObject.AccentColour not being updated if object entry is not attached	2022-11-01 19:34:53 +09:00
Dean Herbert	27af91003b	Merge branch 'master' into combo-colour-brightness-limit	2022-11-01 17:50:26 +09:00
Dean Herbert	29bc653d24	Remove incorrect double multiplication and add missing test coverage	2022-11-01 17:17:54 +09:00
Dean Herbert	2a88409dfe	Fix time snap of sliders not matching when SV is not 1.0x ... This regressed with https://github.com/ppy/osu/pull/20850 because the function was used in other places which expect it to factor slider velocity into the equation. Rather than reverting, I've added a new argument, as based on the method naming alone it was hard to discern whether SV should actually be considered. The reason for the change in #20850 was to avoid the SV coming in from a reference object which may not have a correct SV in the first place. In such cases, passing `false` to the function will give the expected behaviour.	2022-11-01 15:12:58 +09:00
Dean Herbert	706adfb28c	Improve messaging when ruleset load fails	2022-11-01 13:57:34 +09:00
OliBomby	0461303895	Change return type to List	2022-10-31 11:39:41 +01:00
OliBomby	414e21c657	Added xmldoc to public methods	2022-10-31 11:39:14 +01:00
Dean Herbert	94dd4045f1	Remove borrowed framework code	2022-10-31 15:42:17 +09:00
Dean Herbert	31ba77e378	Merge branch 'master' into bezier-convert	2022-10-31 15:41:08 +09:00
andy840119	a1a9238bd1	Use empty string instead of null because issue template not accept null.	2022-10-30 16:31:07 +08:00
andy840119	505ec800da	File name should be nullable.	2022-10-30 16:29:54 +08:00
andy840119	db48a57fa7	Remove nullable disable annotation in some checks class.	2022-10-30 16:28:49 +08:00
andy840119	24c27e62f6	Remove nullable disable annotation in the issue and issue template-related class.	2022-10-30 16:25:15 +08:00
Dean Herbert	42eafe318c	Remove various simple obsoletions	2022-10-28 13:20:58 +09:00
OliBomby	86d5fcc26d	Added tests	2022-10-26 19:30:42 +02:00
OliBomby	77dcd0fae2	Create BezierConverter.cs	2022-10-26 17:21:20 +02:00
Dean Herbert	6b53ea3400	Enable distance snapping when DS value is changed via user interaction	2022-10-26 13:37:01 +09:00
Dean Herbert	7d59bc6e2f	Merge branch 'grid-momentary-shortcuts' into read-current-distance-snap	2022-10-26 13:28:04 +09:00
Dean Herbert	54ae16badc	Move distance snap toggle button implementation to DistancedHitObjectComposer	2022-10-26 13:27:23 +09:00
Dean Herbert	8d9a85e9e5	Fix typos in xmldoc ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-10-26 13:14:12 +09:00
Bartłomiej Dach	48057412f5	Merge branch 'master' into grid-momentary-shortcuts	2022-10-25 22:17:08 +02:00
Bartłomiej Dach	3d31c9bbc5	Merge branch 'master' into beat-snap-divisor-hotkey	2022-10-25 20:32:32 +02:00
Dean Herbert	da93849b80	Rename some pieces and better document SampleBankInfo	2022-10-25 14:55:33 +09:00
Dean Herbert	2b850694fa	Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts	2022-10-25 14:10:45 +09:00
Dean Herbert	d0e6bda9ef	Stop HitObjectComposer from handling Shift+Number keys	2022-10-24 15:19:36 +09:00
Dean Herbert	f516e32949	Improve UI a bit	2022-10-21 23:35:53 +09:00
Dean Herbert	bb921ff9a7	Fix incorrect current DS value when inside a slider	2022-10-21 23:35:47 +09:00
Dean Herbert	f6de366766	Combine display and button into one control	2022-10-21 23:21:07 +09:00
Dean Herbert	645a84b1d6	Display current distance snap and add button to update to use it	2022-10-21 22:58:36 +09:00
Dean Herbert	7dc03097ff	Change distance snap to never account for slider velocity ... This is a nuanced detail that was implemented incorrectly from the outset. When mapping, generally a mapper chooses the distance spacing with no regard to the SV. It has always been common to have a lower or higher distance spacing than SV, but with the way the lazer editor has worked, the SV was multiplied into the distance snap grid display, incorectly changing its spacing depending on the "reference object" (which is usually the previous hitobject chronologically).	2022-10-21 21:51:24 +09:00
Dean Herbert	6cdfddea62	Always enable distance spacing when adusting distance space multiplier	2022-10-21 16:10:55 +09:00
Dan Balasescu	703a8afb11	Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks ... Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself	2022-10-21 12:56:14 +09:00
Dean Herbert	5c13c443ff	Fix incorrect fallback logic ... Regressed when attempting to share implementation of binary search.	2022-10-20 23:08:44 +09:00
Dean Herbert	26860a903e	Refactor implementation to support hitobjects nested multiple levels deep	2022-10-20 22:30:30 +09:00
Dean Herbert	b9f41611a7	Fix bank potentially being overwritten during placement	2022-10-19 21:48:18 +09:00
Dean Herbert	50e24ddd87	Add icon and radio button logic	2022-10-19 21:35:08 +09:00
Dean Herbert	d237c818f6	Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time	2022-10-18 16:15:21 +09:00
Dean Herbert	ec3761ced9	Standardise control point search logic in OverlappingScrollAlgorithm ... Was using a very local algorithm which I cannot guarantee is correct. I'd rather it just use the one used everywhere else.	2022-10-18 16:01:05 +09:00
Dean Herbert	860214c22a	Adjust paddings to feel better now that backgrounds are visible of toolboxes	2022-10-18 14:38:45 +09:00
Dean Herbert	6a7f6c76ff	Fix osu! editor padding being applied to toolboxes ... The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.	2022-10-18 14:32:00 +09:00
Dean Herbert	ccbac08985	Merge pull request #20593 from ekrctb/catch-editor-height ... Allow arbitrary height catch editor	2022-10-18 12:10:49 +09:00
Salman Ahmed	ba72f13f54	Merge branch 'master' into hide-mouse-on-keyboard-input	2022-10-14 22:26:30 +03:00
Dean Herbert	32c3e35762	Change background colour to a lighter tint to avoid clash with slider bars	2022-10-14 19:38:27 +09:00
Dan Balasescu	8a88339e78	Allow combo colour normalisation to be disabled	2022-10-14 14:37:24 +09:00
Dan Balasescu	15db65c037	Extract to struct, add dictionary term	2022-10-14 14:12:53 +09:00
Dean Herbert	4d99c7002b	Add background behind editor toolbox groups	2022-10-13 16:36:19 +09:00
Dan Balasescu	4149235e63	Limit minimum brightness of combo colours	2022-10-13 14:05:33 +09:00
Salman Ahmed	4fb156ef4e	Update xmlodc and add nullability attributes	2022-10-13 00:16:42 +03:00
Salman Ahmed	7a6ecaff0d	Remove default invisible cursor container from rulesets	2022-10-12 17:50:47 +03:00
Salman Ahmed	84fdd2e107	Improve flashlight display on break periods	2022-10-11 17:16:57 +03:00
Salman Ahmed	9b45a9cf76	Rename various cursor symbols ... - `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor` - `MenuCursor` -> `MenuCursorContainer	2022-10-11 16:21:01 +03:00
Dean Herbert	f060e6a780	Implement hold "sliding" samples in osu!mania	2022-10-11 16:31:37 +09:00
Dean Herbert	5a43cb6bb2	Merge pull request #20606 from sw1tchbl4d3r/barline_generator_improvements ... Barline generator improvements	2022-10-11 01:31:30 +09:00
sw1tchbl4d3	5a4196fd51	Make currentEffectPoint non-nullable	2022-10-10 15:34:29 +02:00
sw1tchbl4d3	d389808427	Make effect point search more efficient	2022-10-10 14:00:26 +02:00
sw1tchbl4d3	eae32ca483	Switch DefinitelyBigger to AlmostBigger to account for fp errors	2022-10-10 09:39:40 +02:00
Salman Ahmed	2d4f390372	Remove non-smoke key bindings on "Relax" mod instead	2022-10-09 17:14:16 +03:00
sw1tchbl4d3	63ffaa6929	Respect OmitFirstBarLine effect	2022-10-07 20:38:32 +02:00
sw1tchbl4d3	903c8612c8	Move endTime to next timing point	2022-10-07 20:34:31 +02:00
Dan Balasescu	bce20e0a59	Merge branch 'master' into adjust-flashlight	2022-10-07 14:45:30 +09:00
Dan Balasescu	7385ef3e1b	Extract combo scale to virtual function	2022-10-07 14:26:19 +09:00
ekrctb	9247ff3e0a	Allow changing scrolling speed in catch editor ... Scroll speed is not saved and doesn't affect gameplay. It is purely a feature for a better visualization. It is currently bind to scroll speed increase/decrease. Default F3/F4 crashes with editor shortcuts so it has to be changed.	2022-10-06 18:06:16 +09:00
ekrctb	1cccd03480	Fix scrolling nested hit object lifetime not set	2022-10-04 15:17:14 +09:00
ekrctb	781f5420b0	Add test for scrolling hit object lifetime	2022-10-04 15:17:11 +09:00
ekrctb	5d80950eaf	Compute lifetime from entry in scrolling container	2022-10-04 15:12:28 +09:00
Dan Balasescu	deae7cff60	Adjust flashliht scaling to match classic	2022-10-03 18:38:29 +09:00
Dan Balasescu	0df217d85c	Add ability to adjust flashlight smoothness	2022-10-03 18:24:56 +09:00
Dan Balasescu	1890a66b28	Merge pull request #20509 from o-dasher/cleanup-setting-sources ... Removes unnecessary setting sources specifications	2022-09-28 17:55:42 +09:00
Dan Balasescu	cbed268ac9	Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements ... Clamp `LifetimeStart` of `HitObject`s to their judgement windows	2022-09-28 17:49:35 +09:00
sw1tchbl4d3	0cffbb7562	Clamp LifetimeStart of HitObject's to their judgement windows	2022-09-27 16:54:24 +02:00
o-dasher	f3e25eacad	Removes unnecessary setting sources specifications	2022-09-27 09:25:58 -04:00
Dean Herbert	c4887269f7	Avoid performing a realm write if there are no changes pending in RulesetConfigManager	2022-09-26 14:55:23 +09:00
o-dasher	feadac1f79	Cleanup all other leftover binding instantiation	2022-09-25 16:02:40 -04:00
o-dasher	537796c3a1	Cleanup mod bindings	2022-09-25 15:49:22 -04:00