Dean Herbert
7bd749d0eb
Remove weird shaking
2021-09-14 14:19:55 +09:00
Dean Herbert
e3c56f9ebd
Show error message in popover
2021-09-14 14:14:06 +09:00
Dean Herbert
eaac2bad3d
Fix incorrect child margin specifications
2021-09-14 13:49:02 +09:00
smoogipoo
3df4cbca2c
Reduce precision of difficulty calculator tests
2021-09-14 13:45:10 +09:00
Opelkuh
9fd616c578
Tiny refactor
2021-09-14 00:16:42 +02:00
Opelkuh
224244801f
Remove Particles namespace
2021-09-13 21:44:27 +02:00
Opelkuh
cfcb46034c
Remove ParticleJet
2021-09-13 21:44:23 +02:00
Opelkuh
99eff4f41f
Move cursor particles under OsuCursorContainer
2021-09-13 21:44:22 +02:00
Opelkuh
c2f7b01ca4
Change particle AngularVelocity into StartAngle and EndAngle
2021-09-13 21:44:21 +02:00
Opelkuh
6d68da8ff0
Remove StartScale from ParticleSpewer particles
2021-09-13 21:44:20 +02:00
Opelkuh
db662f8c5c
Add ParticleParent option to ParticleSpewer
2021-09-13 21:44:20 +02:00
Opelkuh
328c9a5dd0
Change ParticleSpewer.Active to a Bindable
2021-09-13 21:44:18 +02:00
Opelkuh
4c753420d3
Fix ParticleSpewer gravity calculation
2021-09-13 21:44:17 +02:00
Opelkuh
714cf33aac
Change ParticleSpewer to use screen space
2021-09-13 21:44:17 +02:00
Opelkuh
1a60ce164e
Add ParticleJet
2021-09-13 21:44:16 +02:00
Bartłomiej Dach
35ee889e5b
Restore clipboard content after difficulty switch
2021-09-13 21:04:27 +02:00
Bartłomiej Dach
79d0f4835e
Add failing tests for preserving clipboard content
2021-09-13 21:03:30 +02:00
Bartłomiej Dach
3fc72271f1
Restore editor clock time after difficulty switch
2021-09-13 20:59:31 +02:00
AbstractQbit
3c75094f43
Move BarHitErrorMeter's icon reorintation to Update()
2021-09-13 19:41:55 +03:00
AbstractQbit
7267602b95
Fix icon orientation for horizontal bar hit error meter
2021-09-13 17:14:39 +03:00
Dean Herbert
1e09f558d1
Merge pull request #14687 from Emil8250/master
...
Make "Reset bindings" button wider to accommodate to localisations better
2021-09-13 22:46:06 +09:00
AbstractQbit
9c1fc2ec65
Tweak filled nub border width value
2021-09-13 14:19:33 +03:00
Dean Herbert
4d2373ffb9
Combine similar value changed calls
2021-09-13 20:08:46 +09:00
Dean Herbert
d999c29d3a
Remove unused GameHost DI in OsuGameTestScene
2021-09-13 19:38:43 +09:00
AbstractQbit
0f5ed81a7a
Fix dimmed checked nub artifact
...
This adds transition that extends nub's border to fill it.
Fill fade can be removed, but combined effect looks nicer imo,
and the fill is still needed because if removed, border
becomes invisible for some reason.
2021-09-13 13:31:13 +03:00
Dean Herbert
aa71e3f3d4
Update nested game tests in line with framework changes
2021-09-13 19:04:13 +09:00
Dan Balasescu
f6c4bbe2c9
Merge pull request #14730 from peppy/add-missing-track-adjustment-defaults
...
Add missing screen level mod application settings for some screens
2021-09-13 15:22:22 +09:00
Dean Herbert
0c646f6dbd
Merge pull request #14694 from nekodex/no-avatar-click-sound
...
Don't play hover/select sounds for UpdatableAvatar unless it's clickable
2021-09-13 15:14:43 +09:00
Dean Herbert
f9c82a9098
Merge pull request #14676 from nekodex/lobby-team-swap
...
Add sound for multiplayer team swaps
2021-09-13 15:01:58 +09:00
Dean Herbert
caf7ef6519
Add missing screen level mod application settings for some screens
...
Closes #7480 . But based on discussion in there this solution may change.
2021-09-13 15:00:34 +09:00
Dean Herbert
52c69d2f22
Adjust value to not be full width (but allow for more accommodations with localised versions)
2021-09-13 14:17:45 +09:00
Dean Herbert
684c39dad0
Update resources
2021-09-13 14:12:37 +09:00
Dean Herbert
7fe0eefb78
Add inline comment regarding team switch sample logic
...
Feels a bit convoluted without this. Don't really have a better
suggestion for now so a comment will do.
2021-09-13 14:12:19 +09:00
Dean Herbert
65fdceee79
Merge branch 'master' into editor-test-scenes-through-loader
2021-09-13 14:02:55 +09:00
Dan Balasescu
d9b4fae4e5
Merge branch 'master' into chat-command
2021-09-13 13:32:44 +09:00
Bartłomiej Dach
5969e2b852
Add TODO comment about lack of in-gameplay support
2021-09-13 00:13:07 +02:00
sh0ckR6
447001931c
Resolve LoungeSubScreen from PasswordEntryPopover
...
This is preferred over passing down the already-resolved LoungeSubScreen
2021-09-12 14:36:11 -04:00
Bartłomiej Dach
1be8cb452f
Make new beatmaps' samples match playback rate by default
2021-09-12 16:57:21 +02:00
Bartłomiej Dach
345cde251d
Add "samples match playback rate" to editor setup screen
2021-09-12 16:54:17 +02:00
Bartłomiej Dach
af7c2b93e6
Add encoding support for SamplesMatchPlaybackRate
2021-09-12 16:47:38 +02:00
Bartłomiej Dach
cd181452be
Add decoding support for SamplesMatchPlaybackRate
2021-09-12 16:45:27 +02:00
Bartłomiej Dach
925b455330
Add "samples match playback rate" setting to beatmap info
2021-09-12 16:40:52 +02:00
Bartłomiej Dach
22fa9a303e
Expose test helper for switching between difficulties
2021-09-12 13:55:48 +02:00
Bartłomiej Dach
f8a681d810
Delegate Editor{Beatmap,Clock} to Editor directly
2021-09-12 13:40:06 +02:00
Bartłomiej Dach
8357efc74f
Make EditorTestScene go through EditorLoader
2021-09-12 13:26:04 +02:00
Bartłomiej Dach
c4627bed6d
Print username in case of generic network failure too
2021-09-12 12:56:36 +02:00
rednir
e511c2ef2b
add comment
2021-09-12 08:50:53 +01:00
sh0ckR6
e018071be4
Remove OnShakeFinish event
2021-09-11 19:50:41 -04:00
sh0ckR6
6cdc842452
Remove placeholder text response
...
Weird UX, doesn't feel right compared to the rest of lazer
2021-09-11 17:42:49 -04:00
sh0ckR6
b8a6925175
Use already-resolved LoungeSubScreen instead of nested delegates
2021-09-11 17:41:07 -04:00
Bartłomiej Dach
b9c127c07e
Improve content transitions in beatmap listing
2021-09-11 22:37:36 +02:00
Davran Dilshat
1b264a2dd0
make user lookup string public
2021-09-11 16:22:29 +01:00
Davran Dilshat
c166f1a06a
change error message based on exception message
2021-09-11 14:18:09 +01:00
Bartłomiej Dach
addba43e7d
Merge branch 'master' into fix-password-popover-back-button
2021-09-11 14:18:25 +02:00
Bartłomiej Dach
0e5659acb2
Remove leftover exception throw
2021-09-11 14:10:29 +02:00
Dean Herbert
94702ee7e3
Fix triangles intro attempting to restart track after it is disposed
2021-09-10 18:23:00 +09:00
Dan Balasescu
f4b1d8b9d1
Merge pull request #14704 from peppy/modicon-imod-support
...
Update `LeaderboardModSelector` to avoid creating mod instances
2021-09-10 16:43:32 +09:00
Davran Dilshat
acb181ff2b
rename alreadyJoinedChannel -> privateChannel
2021-09-10 08:15:43 +01:00
rednir
5ec615c783
display user in error message
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-09-10 08:02:15 +01:00
rednir
84c152e7b6
break when already found user
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-09-10 08:01:38 +01:00
Dean Herbert
309460e505
Merge pull request #14675 from ekrctb/featured-artist-markers
...
Add featured artist markers to beatmap listing and overlay
2021-09-10 14:30:33 +09:00
Jamie Taylor
8d1e43423e
Update calls to use new variable name
2021-09-10 14:18:40 +09:00
Dean Herbert
63116a8889
Merge pull request #14703 from gagahpangeran/supporter-bg
...
Fix supporter promo background colour
2021-09-10 14:11:01 +09:00
Dan Balasescu
2d2c63dde7
Merge branch 'master' into modicon-imod-support
2021-09-10 13:30:05 +09:00
Dan Balasescu
78a83e0903
Merge pull request #14698 from peppy/fix-beatmap-overlay-hide
...
Fix beatmap listing overlay not hiding via keyboard control when scrolled
2021-09-10 13:18:37 +09:00
Dan Balasescu
1d9ad9478e
Merge pull request #14683 from peppy/use-decoupled-clock-triangles-intro
...
Use a decoupled clock for triangles intro to avoid startup freezes on broken audio device
2021-09-10 13:15:58 +09:00
Gagah Pangeran Rosfatiputra
110f495345
move internal children to bdl
2021-09-10 11:11:55 +07:00
Jamie Taylor
85b699182e
Rename variable to be more descriptive
2021-09-10 13:01:54 +09:00
Gagah Pangeran Rosfatiputra
e636692596
change background to background 5
2021-09-10 11:00:55 +07:00
Dean Herbert
212c3c699c
Reword xmldoc slightly
2021-09-10 12:58:12 +09:00
Dan Balasescu
80f49ec5fd
Merge branch 'master' into cached-all-mods
2021-09-10 12:47:22 +09:00
Dean Herbert
28e9329136
Update LeaderboardModSelector to avoid creating mod instances
2021-09-10 12:43:21 +09:00
Dean Herbert
464797fecf
Allow ModIcon to be constructed using an IMod
2021-09-10 12:43:12 +09:00
Dean Herbert
c3531e1361
Move more specification from Mod to IMod
2021-09-10 12:42:53 +09:00
Jamie Taylor
2838a3a961
Rewrite conditional to be more 'balanced'
2021-09-10 12:25:41 +09:00
Gagah Pangeran Rosfatiputra
8acf82944f
use hex colour directly instead of transparency
2021-09-10 10:17:10 +07:00
Dean Herbert
719392de39
Change CreateInstance to use Activator.CreateInstance instead of clone
2021-09-10 12:05:10 +09:00
Gagah Pangeran Rosfatiputra
f329973798
fix supporter promo background colour
2021-09-10 09:37:27 +07:00
Dean Herbert
76e877f160
Disable APIMod/Mod cross equality support
2021-09-10 11:24:56 +09:00
Dean Herbert
cf633973a9
Refactor exposed mod retrieval methods for better safety
2021-09-10 11:09:13 +09:00
Dean Herbert
ce6b022a90
Remove unused IMod specification from APIMod
2021-09-10 10:59:30 +09:00
sh0ckR6
bde092f816
Clear UR bar display on seek with mouse
2021-09-09 20:08:16 -04:00
sh0ckR6
bf0150bab4
Clear UR bar display on keyboard input
2021-09-09 16:21:51 -04:00
Dean Herbert
344bf2ab7c
Allow popovers to be closed via back button press
...
Closes https://github.com/ppy/osu/issues/14669 .
2021-09-10 02:15:37 +09:00
Dean Herbert
46599540b6
Merge pull request #14666 from bdach/fix-score-panel-list-keyboard-nav
...
Fix incorrect keyboard navigation order in score panel list
2021-09-10 02:07:06 +09:00
Dean Herbert
c101d1f205
Fix beatmap listing overlay not hiding via keyboard control when scrolled
...
Closes https://github.com/ppy/osu/issues/14684 .
2021-09-10 01:57:57 +09:00
Dean Herbert
6c18df24ec
Change how UsingThemedIntro is set to improve clarity
2021-09-09 22:04:16 +09:00
Dean Herbert
99b6f0352c
Always start decoupled clock regardless of track source
2021-09-09 22:04:00 +09:00
ekrctb
29f947fa07
Revert ExplicitContentBeatmapPill, don't try to reuse common code
2021-09-09 19:25:30 +09:00
Dean Herbert
9b34ffc302
Undo big oopsie
2021-09-09 17:12:38 +09:00
Dean Herbert
2edb851008
Add ability to lookup mod from a type specification
2021-09-09 16:50:59 +09:00
Dean Herbert
4d0530ca9d
Add new methods to ruleset for quicker mod lookups
2021-09-09 16:46:14 +09:00
Dean Herbert
e66d76d26e
Avoid settings copy if there are no settings
2021-09-09 15:43:55 +09:00
Jamie Taylor
b01cf5c937
Don't play hover/select sounds for UpdatableAvatar unless it's interactable
2021-09-09 15:33:47 +09:00
Dean Herbert
38f4b0ced2
Merge branch 'master' into cache-setting-source
2021-09-09 15:15:21 +09:00
Dean Herbert
41a2e6eeeb
Fix cache not actually caching anything
2021-09-09 14:56:39 +09:00
Dan Balasescu
f36bebd1a4
Merge branch 'master' into custom-style-link-flow-container
2021-09-09 13:31:55 +09:00
ekrctb
52bb02baed
Prefer composite over inheritance for drawable parts
2021-09-09 12:53:39 +09:00
Dan Balasescu
88dd83f6ca
Merge pull request #14686 from Joehuu/volume-meter-select-on-hover
...
Fix volume meter not being highlighted when hovering before show
2021-09-09 12:13:13 +09:00
Dean Herbert
199f5235a3
Merge branch 'master' into fix-score-panel-list-keyboard-nav
2021-09-09 12:12:16 +09:00
Emil Olesen
2888623bdb
Extended the width of the ResetSectionButton to be equal to Content.Width. Fixes #14685
2021-09-08 22:02:24 +02:00
Joseph Madamba
9b05bf3a2c
Fix volume meter not being highlighted when hovering before show
2021-09-08 11:43:59 -07:00
Dean Herbert
ba99a808af
Use a decoupled clock for triangles intro to avoid startup freezes on broken audio device
2021-09-09 01:21:19 +09:00
Dean Herbert
6fc46792d3
Fix test regressions
2021-09-09 00:39:54 +09:00
Dean Herbert
a622a0b660
Use a more traditional method of caching
2021-09-08 23:18:17 +09:00
Dean Herbert
136573982c
Add fade in and fix incorrect wrapper bounds
2021-09-08 20:52:14 +09:00
Dean Herbert
7941240a00
Revert "Load DrawableLoungRooms asynchronously"
...
This reverts commit 0b55bb6913fbf05ebb8ecadfe711084d6797efe0.
2021-09-08 20:52:14 +09:00
Dean Herbert
3e41d8b32e
Reduce initial fade transforms
2021-09-08 20:52:14 +09:00
Dean Herbert
bebb9d7e67
Wrap main content of DrawableRoom
2021-09-08 20:52:14 +09:00
Dean Herbert
037b9cfb59
Load DrawableLoungRooms asynchronously
2021-09-08 20:52:14 +09:00
ekrctb
d417f03a39
Simplify link style customization code
2021-09-08 15:52:54 +09:00
ekrctb
9637326f0c
Allow customizing link style by override in LinkFlowContainer
2021-09-08 15:52:54 +09:00
Jamie Taylor
217ca754ae
Add sound for team swaps
2021-09-08 13:45:05 +09:00
ekrctb
f96be2cab8
Add featured artist marker to beatmap set listing and overlay
2021-09-08 13:27:20 +09:00
Dean Herbert
81c9d831f4
Cache reflection portion of SettingSource lookups
...
Fixes the mod-related overhead portion of https://github.com/ppy/osu/issues/14638 . There's still a significant performance issue that will be addressed separately.
2021-09-08 13:26:11 +09:00
ekrctb
7543f9dfb0
Add featured artist track ID online info
2021-09-08 12:21:24 +09:00
sh0ckR6
b1f91596a7
Give user feedback on password attempt fail
...
Shake the popover
Set the input box's color to red and set the placeholder text to "incorrect password"
2021-09-07 20:05:24 -04:00
sh0ckR6
b8a1ebb786
Hide Popover after failed password attempt
...
Instead of throwing an error, just close the popover and let the user continue
2021-09-07 16:54:21 -04:00
Ethan Ng
d8fe98fe12
Fixed grammatical error in ChangelogSupporterPromo
2021-09-07 14:06:23 -06:00
Bartłomiej Dach
8cc444df5f
Fix incorrect keyboard navigation order in score panel list
2021-09-07 21:14:38 +02:00
Davran Dilshat
255f8a9769
add alias "/msg" (also a command in stable)
2021-09-07 17:25:47 +01:00
Davran Dilshat
b1c89f7618
ignore case when search for already joined channel
2021-09-07 17:22:59 +01:00
Davran Dilshat
be9540e535
fix "key" having wrong url parameter name
2021-09-07 17:17:10 +01:00
rednir
f209222812
Merge branch 'master' into chat-command
2021-09-07 17:09:46 +01:00
Davran Dilshat
f54d5675db
check if user joined requested channel already
2021-09-07 17:06:12 +01:00
Dan Balasescu
87434333d2
Merge pull request #14659 from peppy/update-framework
...
Update framework
2021-09-07 21:03:37 +09:00
Dean Herbert
c43ac8c946
Merge pull request #14660 from ekrctb/search-featured-artists
...
Add "featured artists" filter to beatmap listing
2021-09-07 20:58:13 +09:00
Dean Herbert
fa62c846c5
Merge pull request #14603 from smoogipoo/score-ordering
...
Fix scores not being ordered correctly on leaderboards
2021-09-07 19:18:37 +09:00
Dean Herbert
3d8faea4b0
Simplify nesting of OrderByTotalScoreAsync
2021-09-07 18:52:25 +09:00
Dean Herbert
92f59c10f5
Remove redundant this. in assignment
2021-09-07 17:45:39 +09:00
Dean Herbert
1aa95de530
Merge branch 'master' into score-ordering
2021-09-07 17:45:38 +09:00
ekrctb
5ab2f4b386
Give an orange colour to "featured artists" filter to match web
2021-09-07 17:32:12 +09:00
Dean Herbert
ff87ad6efc
Merge branch 'master' into editor-new-change-diff
2021-09-07 17:13:14 +09:00
Dean Herbert
a42527b8f5
Update framework
2021-09-07 16:46:40 +09:00
Dean Herbert
d922210d2f
Fix TestSceneDeleteLocalScore not properly comparing post-delete scores
2021-09-07 16:46:27 +09:00
Dan Balasescu
49b0998132
Merge branch 'master' into improve-background-screen-ownership-code-quality
2021-09-07 16:46:20 +09:00
ekrctb
b6c80f04b0
Add "featured artists" filter to beatmap search
2021-09-07 16:44:45 +09:00
Dan Balasescu
79fd2d46f6
Merge branch 'master' into test-efficiency
2021-09-07 16:14:12 +09:00
Dan Balasescu
2e0839d880
Merge branch 'master' into update-resources
2021-09-07 15:49:32 +09:00
Dean Herbert
44b1af5ae4
Update resources
2021-09-07 15:28:52 +09:00
Dean Herbert
5b13b566b5
Reduce startup overhead during default key binding handling
2021-09-07 15:19:23 +09:00
smoogipoo
4658577b1d
Factor in total score calculation time in results screen load
2021-09-07 15:19:09 +09:00
Dean Herbert
93da531d13
Improve code around background screen handling to read better
2021-09-07 14:35:33 +09:00
Dean Herbert
9edd010b1d
Fix unnecessary background screen transition
2021-09-07 14:34:54 +09:00
Dean Herbert
7921ad4516
Add loading spinner in case load takes longer than expected
2021-09-07 14:34:47 +09:00
Dean Herbert
ddaa95a1ca
Fix pushEditor function running twice on returning to loader
2021-09-07 14:34:18 +09:00
Dean Herbert
59aa4dabfd
Improve code around background screen handling to read better
2021-09-07 14:33:58 +09:00
smoogipoo
c9325cc419
Fix results screen test scene
2021-09-07 14:15:23 +09:00
Bartłomiej Dach
d13e00ed42
Merge branch 'master' into editor-new-change-diff
2021-09-06 21:42:32 +02:00
Bartłomiej Dach
5b9f37702b
Remove unnecessary delay before pushing editor from loader
2021-09-06 21:32:23 +02:00
Bartłomiej Dach
2d59008f52
Move screen management logic to EditorLoader
2021-09-06 21:30:50 +02:00
Bartłomiej Dach
bd7d6dd35d
Rename method
2021-09-06 21:27:17 +02:00
Bartłomiej Dach
73f742509a
Merge branch 'master' into tablet-area-validity-fix
2021-09-06 21:15:17 +02:00
Dean Herbert
2a5b857f10
Avoid loading unnecessary fonts in headless testing
2021-09-07 00:45:53 +09:00
smoogipoo
20100b8894
Fix a few test failures
2021-09-06 20:20:52 +09:00
smoogipoo
401d38fc05
Fix possible nullref
2021-09-06 19:07:37 +09:00
Dean Herbert
1c4a3c584a
Use correct lookup type to ensure username based lookups always prefer username
2021-09-06 15:04:27 +09:00
Dean Herbert
458cde832d
Avoid using SSDQ for validity computation
2021-09-06 14:11:13 +09:00
Davran Dilshat
5c385e84ea
wrong command name in query message
2021-09-05 21:20:19 +01:00
Davran Dilshat
cb6cee9aea
add /query as alias of /chat
2021-09-05 21:10:08 +01:00
Bartłomiej Dach
d6a47fd99c
Sort difficulties by ruleset and star rating in menu
2021-09-05 21:48:11 +02:00
Bartłomiej Dach
7012a1d934
Fix issues with main menu -> editor loader transition
2021-09-05 21:48:11 +02:00
Bartłomiej Dach
382269b362
Test staying on same difficulty due to unsaved changes
2021-09-05 21:48:10 +02:00
Bartłomiej Dach
c72523bc14
Add basic test for difficulty switching
2021-09-05 21:48:10 +02:00
Bartłomiej Dach
a9403b65b3
Eliminate dependency on OsuGame
2021-09-05 21:48:10 +02:00
Bartłomiej Dach
c397cc2027
Restructure proof of concept
2021-09-05 21:48:09 +02:00
Bartłomiej Dach
fe2520c599
Add intermediary screen to avoid going back to menus
2021-09-05 21:48:09 +02:00
Bartłomiej Dach
7befd030df
Minimal working example of switching difficulties
2021-09-05 21:48:09 +02:00
Bartłomiej Dach
90f0b6874f
Highlight current difficulty in switcher
2021-09-05 21:48:08 +02:00
Bartłomiej Dach
e8fb5d2e66
Add non-functional difficulty switcher to menu
2021-09-05 21:48:08 +02:00
Davran Dilshat
59ca69e41f
add /chat command
2021-09-05 18:16:57 +01:00
Dean Herbert
7c60c6a733
Merge pull request #14571 from rednir/get-user-from-username
...
Add ability to open user profile links with username instead of user ID
2021-09-06 00:15:09 +09:00
Dean Herbert
0e48ae76cb
Merge pull request #14630 from bdach/mode-specific-settings
...
Add ruleset-specific sections to setup screen
2021-09-05 23:58:24 +09:00
Davran Dilshat
b1a995e0bb
revert changes
2021-09-05 15:49:48 +01:00
Davran Dilshat
e78dc1bb4c
more code quality :/
2021-09-05 15:27:28 +01:00
Davran Dilshat
f7369e0d68
create UserIdLookupCache
...
to get user ID when importing scores
2021-09-05 14:47:46 +01:00
Davran Dilshat
e5f886a315
revert unnecessary change
2021-09-05 10:45:38 +01:00
Davran Dilshat
e409f2dc6d
add xmldoc
2021-09-05 10:42:38 +01:00
Davran Dilshat
9aa1564e0d
revert ChannelManager changes
2021-09-05 10:19:04 +01:00
Dean Herbert
e0ee2a5533
Change section title to read better
2021-09-05 13:34:57 +09:00
Dean Herbert
25420af078
Rename method to drop redundant ruleset suffix
2021-09-05 13:34:23 +09:00
Dean Herbert
ab1c64591f
Move sample playback debounce time to central const
2021-09-05 13:25:10 +09:00
Dean Herbert
473e15e8f3
Add debounce to notification sample playback logic
2021-09-05 13:22:37 +09:00
Dean Herbert
1d23ac0f2d
Initial clean up pass on notification logic
2021-09-05 12:54:21 +09:00
Davran Dilshat
ea3be927d7
convert to method group
2021-09-04 20:02:10 +01:00
Davran Dilshat
4c006333e0
add /chat command
2021-09-04 19:42:14 +01:00
Bartłomiej Dach
1a90fb1ef3
Fix cached property being assigned twice
2021-09-04 19:52:42 +02:00
Dean Herbert
4fb3a1d641
Update check to inflate in the correct direct
...
Also handles previously unhandled edge cases by comparing all four
corners, instead of only two.
2021-09-05 00:46:29 +09:00
Dean Herbert
66daa553de
Fix bounds check running too early causing tablet area to show incorrect validity
2021-09-04 19:34:55 +09:00
Dean Herbert
16beb2c90c
Expose more pieces of TabletSettings
2021-09-04 15:35:46 +09:00
Bartłomiej Dach
ce1912781e
Add extension point for ruleset-specific beatmap setup sections
2021-09-02 23:29:14 +02:00
Dean Herbert
7688ea7057
Merge branch 'master' into score-ordering
2021-09-02 19:19:52 +09:00
Dean Herbert
cdd0262ca1
Merge pull request #14598 from smoogipoo/adjust-classic-scoring
...
Make classic scoring a constant multiple of standardised scoring
2021-09-02 19:18:03 +09:00
Dan Balasescu
6c649b7bbe
Merge branch 'master' into no-more-sample-control-points-info
2021-09-02 18:09:05 +09:00
smoogipoo
e2f7aaeb71
Fix 0 score with bonus-only maps
2021-09-02 17:00:13 +09:00
Dean Herbert
b907c2f4f6
Fix osu! judgements getting scaled twice over different durations
2021-09-02 16:31:43 +09:00
smoogipoo
31433c4b89
Apply @spaceman_atlas' quadratic factor
2021-09-02 16:26:17 +09:00
Dean Herbert
f223be0760
Merge branch 'master' into score-ordering
2021-09-02 14:45:59 +09:00
Dan Balasescu
aadef41182
Merge pull request #14601 from peppy/fix-editor-setup-screen-pixel-leakage
...
Fix pixels poking out of the top edge of editor setup screen
2021-09-02 14:03:37 +09:00
Dean Herbert
315bbbea4f
Merge pull request #14612 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.9
...
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.8 to 5.0.9
2021-09-02 13:10:50 +09:00
Dean Herbert
d1e5602a79
Merge pull request #14608 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.9
...
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson from 5.0.8 to 5.0.9
2021-09-02 13:10:46 +09:00
dependabot[bot]
e176babb25
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore ) from 5.0.8 to 5.0.9.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.8...v5.0.9 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-09-02 02:34:24 +00:00
dependabot[bot]
be379051f2
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.8 to 5.0.9
...
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore ) from 5.0.8 to 5.0.9.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.8...v5.0.9 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-09-02 02:34:19 +00:00
dependabot[bot]
8ba00f6737
Bump HtmlAgilityPack from 1.11.34 to 1.11.36
...
Bumps [HtmlAgilityPack](https://github.com/zzzprojects/html-agility-pack ) from 1.11.34 to 1.11.36.
- [Release notes](https://github.com/zzzprojects/html-agility-pack/releases )
- [Commits](https://github.com/zzzprojects/html-agility-pack/compare/v1.11.34...v1.11.36 )
---
updated-dependencies:
- dependency-name: HtmlAgilityPack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-09-02 02:33:56 +00:00
smoogipoo
f14d66aafc
Commit missed line
2021-09-02 10:35:00 +09:00
Dean Herbert
9f13e11c7a
Merge pull request #14607 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.9
...
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack from 5.0.8 to 5.0.9
2021-09-02 03:16:34 +09:00
dependabot[bot]
6f0d1b394d
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore ) from 5.0.8 to 5.0.9.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.8...v5.0.9 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-09-01 17:01:53 +00:00
dependabot[bot]
492209fe13
Bump Sentry from 3.8.3 to 3.9.0
...
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet ) from 3.8.3 to 3.9.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases )
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.8.3...3.9.0 )
---
updated-dependencies:
- dependency-name: Sentry
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-09-01 17:01:49 +00:00
smoogipoo
df7480e68c
Fix bindable implementation being synchronous
2021-09-01 20:56:23 +09:00
smoogipoo
f7c1177cc9
Fix ScorePanelList nullref when scores are added too soon
2021-09-01 20:35:06 +09:00
smoogipoo
ab538dc3dd
Fix param not passed through
2021-09-01 20:30:26 +09:00
Dean Herbert
ef64c05af8
Merge pull request #14533 from frenzibyte/move-incompatibility-icon
...
Move mod incompatibility logic to "local player" mod select overlays
2021-09-01 18:12:27 +09:00
Dean Herbert
9e21f5a59c
Rename LocalPlayer to User in mod select prefixes
2021-09-01 17:22:52 +09:00
Dean Herbert
fb5f3fb9af
Rename button to be more descriptive of its purpose
2021-09-01 17:19:38 +09:00
Dean Herbert
2251bf3bcb
Use lambda spec for method
2021-09-01 17:08:20 +09:00
Dean Herbert
cb66ecdbeb
Merge branch 'master' into simplify-user-graph-tooltips
2021-09-01 17:04:21 +09:00
Dean Herbert
f0b128b6ec
Merge pull request #14592 from frenzibyte/cleanup-tooltips
...
Update remaining tooltip implementations to use generics
2021-09-01 17:03:59 +09:00
Dean Herbert
0319177c5c
Fix pixels poking out of the top edge of editor setup screen
2021-09-01 16:46:19 +09:00
smoogipoo
88fc53200e
Refactor
2021-09-01 15:41:52 +09:00
Dean Herbert
edf29e405b
Merge pull request #14581 from bdach/setup-screen-countdown-settings
...
Add countdown settings to setup screen
2021-09-01 15:35:46 +09:00
smoogipoo
2de076a74b
Merge branch 'adjust-classic-scoring' into score-ordering
2021-09-01 15:06:55 +09:00
Dean Herbert
c70ac5e5c2
Merge branch 'master' into privatise-toolbar-offset
2021-09-01 14:54:15 +09:00
smoogipoo
bd0f385cdb
Make classic scoring a constant multiple of standardised scoring
2021-09-01 14:53:11 +09:00
Dan Balasescu
e715b21ca7
Merge pull request #14586 from peppy/remove-ijsonserializable
...
Remove IJsonSerializable interface
2021-09-01 14:17:32 +09:00
Joseph Madamba
a773a22726
Fix toolbar hiding when clicking home button
2021-08-31 14:29:16 -07:00
Bartłomiej Dach
1e4fa87648
Merge branch 'master' into setup-screen-countdown-settings
2021-08-31 22:43:18 +02:00
Bartłomiej Dach
5dc938cc9f
Update tests to match expectations
2021-08-31 22:41:47 +02:00
Bartłomiej Dach
04773b51bb
Remove countdown toggle transition for now
...
Tricky to get right and the design isn't final as is anyway, so leaving
*something* functioning as a best-effort for now.
2021-08-31 22:41:40 +02:00
Joseph Madamba
7e4ad7d7cf
Fix toolbar blocking scroll input
2021-08-31 13:40:13 -07:00
Joseph Madamba
da3fa9304a
Make toolbar inherit overlay container
2021-08-31 12:39:18 -07:00
Bartłomiej Dach
c246ff141e
Merge branch 'master' into avoid-exception-on-failed-lookup
2021-08-31 21:14:34 +02:00
Bartłomiej Dach
b969398e2d
Merge branch 'master' into adjust-triangle-speed
2021-08-31 20:44:09 +02:00
Salman Ahmed
505824d8ea
Constrain difficulty icon tooltip to internal accessibility"
...
This reverts the reverted commit cd356b8eae
2021-08-31 21:16:17 +03:00
Salman Ahmed
b0d7104650
Convert to class to allow not displaying tooltips
...
With `struct` content, it is never possible to not show a tooltip.
2021-08-31 21:13:24 +03:00
Salman Ahmed
cd356b8eae
Revert "Constrain difficulty icon tooltip to internal accessibility"
...
This reverts commit 4a590a041c
2021-08-31 20:57:47 +03:00
Salman Ahmed
4a590a041c
Constrain difficulty icon tooltip to internal accessibility
2021-08-31 20:57:36 +03:00
Salman Ahmed
3969350c9a
Convert to readonly struct and replace with constructor temporarily
2021-08-31 20:45:32 +03:00
Salman Ahmed
69c23a2371
Explicitly implement tooltips on date drawables to avoid "convert to auto-property" inspections
2021-08-31 20:06:34 +03:00
Salman Ahmed
da7ff4b160
Update remaining tooltip implementations to use generics
2021-08-31 20:01:13 +03:00
Salman Ahmed
208f66cc76
Simplify user graph tooltips logic
...
The same tooltip can be used for the rank graph, the play history graph,
and the replay history graph.
The only difference between those three is the displayed label, which
has now been included as part of the `TooltipContent`, rather than
unnecessarily recreating tooltips just for different sprite texts.
2021-08-31 19:59:38 +03:00
Salman Ahmed
a190801291
Revert no longer required tooltip content changes
2021-08-31 19:36:27 +03:00
Salman Ahmed
9afc482598
Merge branch 'master' into move-incompatibility-icon
2021-08-31 19:27:43 +03:00
Davran Dilshat
9288ca1191
handle api is null
2021-08-31 14:34:45 +01:00
Davran Dilshat
0a87b461d7
fix code quality issues
2021-08-31 14:11:37 +01:00
Davran Dilshat
79f71e5181
get user id when importing scores
2021-08-31 13:56:44 +01:00
smoogipoo
999386da29
Cleanup
2021-08-31 21:47:49 +09:00
smoogipoo
fee94236de
Fix update-thread pauses
2021-08-31 21:36:31 +09:00
smoogipoo
cfcf3d7507
Use synchronous total score retrieval for bindable
2021-08-31 20:43:50 +09:00
smoogipoo
bfcadcc4ac
Revert some changes
2021-08-31 19:18:01 +09:00
smoogipoo
90768a86a6
Adjust classic scoring as a constant multiple over standardised scoring
2021-08-31 18:54:16 +09:00
Dean Herbert
a254624373
Avoid performing beatmap metadata lookups when entering the editor
...
If none of the lookup parameters are available, skip the lookup
completely.
2021-08-31 17:18:05 +09:00
Dean Herbert
d988aa1680
Actually serialise SampleControlPoints along with HitObjects
2021-08-31 15:14:03 +09:00
Dean Herbert
448c58c35d
Remove unnecessary variable discard
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-08-31 15:08:07 +09:00
Dean Herbert
9fa8bee094
Remove outdated TODO
2021-08-31 14:51:19 +09:00
Dean Herbert
ce0d7cce2d
Merge branch 'remove-ijsonserializable' into no-more-sample-control-points-info
2021-08-31 14:40:54 +09:00
Dean Herbert
c25ab6835c
Remove IJsonSerializable interface
...
Was pretty pointless and made it hard to use the custom serialisation
terms arbitrarily in tests.
2021-08-31 14:39:20 +09:00
Dean Herbert
529a9a6ff8
Adjust minimum triangle movement speed to avoid "static" triangles in logo
...
Closes #14584 .
2021-08-31 14:08:23 +09:00
Joseph Madamba
570d36fde7
Make toolbar handle mouse events instead
2021-08-30 20:53:43 -07:00
Bartłomiej Dach
ddf9d2aa6c
Add test coverage
2021-08-30 22:55:58 +02:00
Bartłomiej Dach
b43ee2d61c
Add descriptions to enum members
2021-08-30 22:51:42 +02:00
Bartłomiej Dach
eec9f6d191
Add countdown settings to design section
2021-08-30 22:51:41 +02:00
Bartłomiej Dach
48e56adcfe
Add labelled number box control
2021-08-30 21:52:24 +02:00
Bartłomiej Dach
a6d09b0bb0
Add labelled enum dropdown variant
2021-08-30 21:37:14 +02:00
Bartłomiej Dach
acf38c723a
Move labelled dropdown from tournament to main game
2021-08-30 21:37:08 +02:00
Dean Herbert
a2cff75fc0
Fix editor not cloning control points as expected
2021-08-30 21:55:08 +09:00
Salman Ahmed
6154642075
Merge branch 'master' into local-popover-containers
2021-08-30 15:44:29 +03:00
rednir
8104b15874
remove braces
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-08-30 13:23:33 +01:00
rednir
c789163d01
use user ID overload when its supposed to be used
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-08-30 13:22:12 +01:00
Dan Balasescu
b95da3ca27
Merge pull request #14576 from peppy/update-framework
...
Update framework
2021-08-30 21:09:58 +09:00
Dan Balasescu
c1f77cfa1e
Merge pull request #14577 from Henry-YSLin/status-criteria-parsing
...
Parse partially typed status names in song select filter query
2021-08-30 19:59:41 +09:00
smoogipoo
caa797cbf4
Attempt to reorder score panel list
2021-08-30 19:58:35 +09:00
smoogipoo
e19d81c88c
Fix potential incorrect ordering
2021-08-30 19:41:44 +09:00
smoogipoo
4ebb11472d
Update Leaderboard to reorder scores based on scoring mode
2021-08-30 19:34:34 +09:00
smoogipoo
458ce250f0
Use new ScoreManager method in ScoreTable
2021-08-30 19:34:12 +09:00
smoogipoo
d03950fb37
Move score calculation to ScoreManager
2021-08-30 19:33:09 +09:00
Henry Lin
8137eee527
Reuse value to save enum name
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-08-30 18:05:47 +08:00
smoogipoo
b217dd1a65
Order scores by score
2021-08-30 19:03:16 +09:00
smoogipoo
47061c0210
Trigger refresh on scoring mode change
2021-08-30 18:57:30 +09:00
Henry Lin
04bf667d0d
Parse partially typed enum names in filter query
2021-08-30 17:49:18 +08:00
Dan Balasescu
c4da966ad9
Merge pull request #14575 from peppy/add-legacy-convert-encode-stability-tests
...
Fix multiple conversions of a beatmap to taiko ruleset applying speed multiplier multiple times
2021-08-30 18:47:09 +09:00
Dean Herbert
1aaea7011a
Fix early return causing event loss in case of multiple control points in group
2021-08-30 18:33:05 +09:00
Dean Herbert
015df282fe
Simplify copy operations
2021-08-30 18:32:55 +09:00
Davran Dilshat
1aeae2b8c8
reverse ternary operator
2021-08-30 10:11:41 +01:00
Dean Herbert
4da2dca339
Apply the default SampleControlPoint if not externally provided
...
This is mostly to handle tests for now, as generally this should be
provided by an external source in all other cases.
2021-08-30 17:21:07 +09:00
Dean Herbert
d35c4da906
Add new control point to legacy regeneration logic
2021-08-30 17:14:53 +09:00
Dean Herbert
6ee4a6526c
Don't block sample points from still being added to ControlPointInfo
2021-08-30 17:14:53 +09:00
Dean Herbert
6fd24a5d92
Remove redundant null coalesce
2021-08-30 17:14:53 +09:00
Dean Herbert
ccacf56dd8
Move to legacy namespace
2021-08-30 17:14:53 +09:00
Dean Herbert
7257aae7f2
Move samples to LegacyControlPointInfo
2021-08-30 17:14:53 +09:00
Dean Herbert
da7a871afa
Update inline comment to point to new variable location
...
Co-authored-by: PercyDan <50285552+PercyDan54@users.noreply.github.com>
2021-08-30 16:27:24 +09:00
Dean Herbert
678386f5c4
Fix missed null coalesce
2021-08-30 16:05:56 +09:00
Dean Herbert
fa2bf42188
Update tooltip implementations
2021-08-30 16:05:00 +09:00
Dean Herbert
f64efdc4a9
Merge branch 'update-extension-usages' into update-framework
2021-08-30 16:00:09 +09:00
Dean Herbert
58a052ea1f
Update framework
2021-08-30 16:00:07 +09:00
Dean Herbert
6a6dac609c
Fix instability of taiko double conversion
...
Until now, the taiko speed multiplier was potentially applied more than
once if conversion was run multiple times.
2021-08-30 15:30:18 +09:00
Dean Herbert
ee49305cad
Move taiko legacy speed multiplier to osu.Game project
...
Allows it to be used in local case in `LegacyBeatmapEncoder`.
2021-08-30 15:13:31 +09:00
Dean Herbert
4dd60e3299
Merge branch 'master' into taiko-drum-refacor
2021-08-30 14:12:52 +09:00
Dan Balasescu
7be825f470
Merge pull request #14488 from frenzibyte/multi-spectator-player-leaving
...
Gray out and stop player instances who quit during multi-spectator sessions
2021-08-30 12:04:19 +09:00
Davran Dilshat
90c313e2ad
add methods to get a user from their username
2021-08-29 19:19:55 +01:00
Salman Ahmed
6dc11543ad
Handle (null?) PP in PerformanceTable
2021-08-29 17:20:33 +03:00
