1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-25 22:23:04 +08:00
Commit Graph

9380 Commits

Author SHA1 Message Date
Dean Herbert
eb31fdecee Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change
See https://github.com/ppy/osu-framework/pull/5834
2023-06-18 20:57:32 +09:00
Joseph Madamba
9ae864c219
Fix beatmap info length tooltip not showing actual drain length 2023-06-17 15:00:32 -07:00
Dean Herbert
ce41ef6e5d Move OrderByTotalScore() to an extension method 2023-06-16 15:24:30 +09:00
Joseph Madamba
45e67fbe78
Remove unused load dependency 2023-06-14 08:09:03 -07:00
Joseph Madamba
b54f3a2cba
Normalise source strings to sentence case
The casing of the "caps lock" tooltip wasn't changed in code, as tooltips should be ideally sentence-cased, see https://github.com/ppy/osu/pull/21765#issuecomment-1552378930.
2023-06-14 07:58:55 -07:00
Joseph Madamba
8cecfef2ff
Apply key renaming suggestions 2023-06-14 07:40:26 -07:00
Joseph Madamba
ed95fb5982
Revert blocking password requirement text localisation 2023-06-14 07:30:46 -07:00
Joseph Madamba
874ce4fe71
Merge remote-tracking branch 'upstream/master' into pr/22239 2023-06-14 07:06:55 -07:00
cdwcgt
432b5e2d25
move Inverted and color logic to ChatLine 2023-06-13 15:56:25 +09:00
Dean Herbert
4cdd4561c4 Add a few more search keywords for offset settings
https://github.com/ppy/osu/discussions/23898#discussioncomment-6159206
2023-06-13 14:17:32 +09:00
Bartłomiej Dach
af3fbdbfbe
Merge pull request #23829 from Joehuu/truncating-text-tooltips
Add tooltips to truncated text
2023-06-12 23:43:31 +02:00
cdwcgt
27b99ea923
use { get; init; } 2023-06-13 01:11:19 +09:00
cdwcgt
430938fbb2
allow custom username color for chatLine
user's color (e.g. green for NAT) will be ignore
2023-06-12 22:07:36 +09:00
Cootz
aece548db1
Merge branch 'master' into add-mod-search-option 2023-06-12 13:09:09 +03:00
Dean Herbert
99f93f5185 Add comment mentioning why ShowTooltip is disabled in mod select panels 2023-06-12 15:31:22 +09:00
Dean Herbert
1e774fc017 Refactor implementation to roughly match existing HoverSampleDebounceComponent 2023-06-12 14:35:15 +09:00
Cootz
4819a28791 Move mod overlay statics to SessionStatics 2023-06-11 13:53:17 +03:00
Joseph Madamba
0d51e4f6ce
Fix mod select panels having conflicting tooltips
Going simple with a bool instead of making `TooltipText` init-able, as the current cases will just init `string.Empty`. And not sure if we want custom tooltip text in the future.
2023-06-10 12:24:58 -07:00
Joseph Madamba
61a9c6fd7e
Disable Truncate in OsuSpriteText
Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>
2023-06-10 11:53:45 -07:00
Cootz
502193e1c6 Use debounce constant for select/deselect animation 2023-06-10 13:55:37 +03:00
Cootz
31f370ec9b Add comments for ModSelectOverlayStatics 2023-06-10 13:50:45 +03:00
Cootz
09cd5580e1 Add sample playback time restrictions 2023-06-10 13:13:34 +03:00
Cootz
9224486ec7 Add mod select overlay statics 2023-06-10 12:38:26 +03:00
Cootz
d219b5f77f Reword change focus comment 2023-06-09 17:10:13 +03:00
Cootz
7697dbe4b3 Mod panel don't play sound when hidden 2023-06-09 16:55:19 +03:00
Cootz
036479dd9d
Merge branch 'master' into add-mod-search-option 2023-06-09 16:27:18 +03:00
Cootz
c3b50e1309 Move the multiplier back to TopRight 2023-06-09 16:25:04 +03:00
Joseph Madamba
85fedbd025
Add tooltips to truncated text 2023-06-08 19:44:07 -07:00
Joseph Madamba
519923e843
Remove redundant EllipsisString assign 2023-06-08 19:43:52 -07:00
Bartłomiej Dach
281aae91ec
Merge pull request #23808 from peppy/working-beatmap-get-background
Refactor `IWorkingBeatmap.Background` to `GetBackground()`
2023-06-08 12:23:07 +02:00
Bartłomiej Dach
5162f5c3d8
Fix code quality inspections 2023-06-08 09:20:43 +02:00
Dean Herbert
a842f79ad4 Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
Bartłomiej Dach
b3ce7f7b43
Merge branch 'master' into fix-section-container-scroll-attempt-2 2023-06-08 09:19:26 +02:00
Salman Ahmed
d523785bfc Fix LanguageSettings requiring OsuGame as dependency 2023-06-08 03:27:23 +03:00
Salman Ahmed
1a90f71540 Centralise game language update logic 2023-06-08 02:59:34 +03:00
Dean Herbert
7d49f5d7c6 Apply NRT to SectionsContainer 2023-06-07 16:32:29 +09:00
Salman Ahmed
f23ada1a3f
Merge branch 'master' into disable-in-game-chat-reports 2023-06-07 09:52:46 +03:00
Salman Ahmed
62cb6a98ca Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
Dean Herbert
30f17d5869 Disabling reporting users from in-game chat
Addresses #23684.

Safer alternative to #23698.
2023-06-07 14:03:06 +09:00
Cootz
ba7069df34 Fix SelectAllModsButton state doesn’t update when search term changed 2023-06-06 16:12:31 +03:00
Cootz
71e6f80c40 Add hotkey for switching search bar focus 2023-06-05 15:54:19 +03:00
Cootz
3ebc801484 Move (de)select all mods hotkeys handling to ModSelectOverlay 2023-06-05 13:49:07 +03:00
Cootz
a46f5b90d4 Move focus handling into PopIn 2023-06-04 18:11:44 +03:00
Cootz
32b9e6ec8f Make search bar active by default 2023-06-04 17:02:46 +03:00
Cootz
69b640a185 Remove hotkeys handling from DeselectAllModsButton 2023-06-03 10:47:48 +03:00
Cootz
9d4ba5d64a Remove unnecessary null checks 2023-06-02 12:00:03 +03:00
Cootz
4c7cca101e Rename IsValid to Visible 2023-06-02 11:33:38 +03:00
Cootz
d400387329 Replace IConditionalFilterable with IFilterable 2023-06-02 10:51:33 +03:00
Cootz
325c114c1c Remove redundant xmldocs 2023-06-02 10:39:27 +03:00
Cootz
39489358fa Apply appearance animation to aboveColumnsContent 2023-06-01 14:07:05 +03:00
Cootz
5a1c3aeb7e Fix SearchTerm set causing infinite loop 2023-05-31 19:36:42 +03:00
Dean Herbert
e35623df22 Update to use new Filter method and remove silly ForcedSearchTerm 2023-05-30 13:40:59 +09:00
Cootz
22c6d6c526 Prevent checkbox from toggle on when column have no valid panels 2023-05-29 14:22:40 +03:00
Cootz
e43c233b48 Reword ForcedSearchTerm xmldoc 2023-05-28 13:21:41 +03:00
Cootz
0e5c99b760 Fix search bar showing incorrectly 2023-05-28 13:12:57 +03:00
Cootz
5ff023113f Update xmldoc for ForcedSearchTerm 2023-05-28 10:04:26 +03:00
Bartłomiej Dach
6392c2007c
Merge pull request #23637 from peppy/add-shadow-settings-notifications
Add shadow to notifications and settings overlays to better distinguish from other overlays
2023-05-24 21:34:14 +02:00
Dean Herbert
e5451d1d79 Centralise definition of overlay shadow opacity and reduce slightly 2023-05-24 12:40:35 +09:00
Dean Herbert
02d8e3a11e Mark FullscreenOverlay's shadow effect as Hollow to save on shader overhead 2023-05-23 18:50:14 +09:00
Dean Herbert
6f4e2b37ed Add shadow to notifications and settings overlays to better distinguish from other overlays 2023-05-23 18:50:14 +09:00
Dean Herbert
adf9a596b5 Fix weird state when attempting to enter gameplay skin editor scene from multiplayer
Closes https://github.com/ppy/osu/issues/23626.
2023-05-23 17:58:44 +09:00
Cootz
c3f06ad2db
Merge branch 'master' into add-mod-search-option 2023-05-23 08:55:57 +03:00
Dean Herbert
09c66bea8f
Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area
Fix clicking area of news sidebar post links
2023-05-22 14:17:08 +09:00
Joseph Madamba
7392109bce
Apply same behavioral changes to NewsCard 2023-05-21 19:28:12 -07:00
Joseph Madamba
2279aad360
Apply NRT to NewsCard 2023-05-21 19:27:20 -07:00
Dean Herbert
b3527b92b6 Handle case in tests where current display becomes null 2023-05-22 09:25:44 +09:00
Bartłomiej Dach
6df1d29862
Merge branch 'master' into use-atomic-ReplaceRange 2023-05-21 20:32:59 +02:00
Joseph Madamba
88c112612f
Remove hardcoded website url
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-05-21 10:35:22 -07:00
Cootz
67bf1b4dfe Select/deselect first visible mod when GlobalAction.Select is triggered 2023-05-21 11:05:01 +03:00
Joseph Madamba
8aefb62532
Rename PostButton to PostLink 2023-05-20 16:38:56 -07:00
Joseph Madamba
ec5f0bbf42
Fix clicking area of news sidebar post links
Side effect is that the hover color is yellow and pressing it opens an external dialog, but those are temporary (pending implementation of link underline to make `Light1` hover more readable and set at a higher level and news pages).
2023-05-20 16:32:04 -07:00
Dean Herbert
79e1d978e7 Ensure scroll-to-top button is displayed above all overlay content 2023-05-17 15:42:38 +09:00
Susko3
fec47fa690 Merge branch 'master' into use-atomic-ReplaceRange
This reverts 0dcf1b540e
2023-05-17 06:56:54 +02:00
Susko3
2d7fe68311 Prevent feedback by using atomic .ReplaceRange()
`display.NewValue` will never be null, checked on SDL + osuTK/Android.

On Android it's a 0x0 display, importantly not null.
2023-05-16 21:57:31 +02:00
Bartłomiej Dach
0dcf1b540e
Attempt to preserve old resolution when switching displays 2023-05-16 21:14:09 +02:00
Bartłomiej Dach
88ce627c8e
Avoid bindable/event feedback when changing resolution 2023-05-16 21:02:23 +02:00
Cootz
6647d95ea7 Kill search focus when clicking on ModColumn 2023-05-14 18:32:16 +03:00
Dean Herbert
c0f869e685 Fix some tablet settings being hidden when searching using "area" keyword
As discussed in https://github.com/ppy/osu/discussions/23504.
2023-05-12 14:57:56 +09:00
tsrk
2d45d602a5
feat(settings): more keyword for first run setup 2023-05-11 15:03:42 +01:00
tsrk
c1a85658b7
feat(settings): add "import" as keywords for first run setup 2023-05-11 14:58:17 +01:00
Cootz
ca68850730 fix formatting 2023-05-10 19:43:58 +03:00
Cootz
2467813d81 Block deselect all short key when using the search box 2023-05-09 16:14:42 +03:00
Bartłomiej Dach
2177dbf42a
Merge pull request #23436 from peppy/fix-wiki-error-return-to-main
Fix "Return to main page" link not working on wiki after error
2023-05-08 21:56:29 +02:00
Dan Balasescu
d2380bd840 Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
Dean Herbert
715b735131 Fix "Return to main page" link not working on wiki after error 2023-05-08 15:29:05 +09:00
Cootz
60bad35145 Remove weird update usage when 'deselect all' pressed 2023-05-07 15:34:01 +03:00
Cootz
4d235105d1 Convert ModSearchContainer to block-scoped namespace 2023-05-07 15:14:49 +03:00
Bartłomiej Dach
65b4b198a4
Merge branch 'master' into export 2023-05-06 20:12:53 +02:00
Bartłomiej Dach
3942281d13
Fix back-to-front logic 2023-05-06 15:34:55 +02:00
Bartłomiej Dach
80ac8abaa6
Merge branch 'master' into chat-report 2023-05-06 15:30:44 +02:00
Bartłomiej Dach
1da5e69d5a
Fix API success callback scheduling to dead drawable 2023-05-06 15:27:27 +02:00
Bartłomiej Dach
6b4050ea52
Remove invalid report reason (and add osu-web references) 2023-05-06 15:01:57 +02:00
Bartłomiej Dach
52e5835be6
Document and retouch ReportPopover 2023-05-06 14:52:38 +02:00
Cootz
cbb9f0100e Update PopIn and PopOut filtering. Expose SearchTerm 2023-05-06 11:27:06 +03:00
Cootz
a226caff56 Fix testing 2023-05-06 11:09:44 +03:00
Cootz
7422b5285c Fix wrong filtering in testing 2023-05-05 22:41:30 +03:00
Cootz
ab94b4dce1 Update ModPresetPanel.FilterTerms to account mod names and acronyms 2023-05-05 09:52:09 +03:00
Cootz
54757df51f Fix mod deselect button not working properly when search applied 2023-05-05 09:31:27 +03:00
Dean Herbert
8391e2a538 Move reporting code out of DrawableChatUsername into more correct locations 2023-05-05 14:03:42 +09:00
Bartłomiej Dach
bdd96caaa9
Merge branch 'master' into edit-mods-preset 2023-05-04 18:59:47 +02:00
Cootz
1ac9d900e1 Clear search on ModSelectOverlay.Hide 2023-05-04 19:24:37 +03:00
Dean Herbert
0034124d79 Remove unnecessary content clear 2023-05-04 11:25:10 +09:00
Dean Herbert
26b8c5b852 Fix mod list display not updating after clicking "use current"
This is not a regression from my changes. It was broken before them.
2023-05-04 11:23:51 +09:00
Dean Herbert
49fb5da1a2 Stop passing preset panel to popover 2023-05-04 11:19:09 +09:00
Dean Herbert
b12d139317 Remove dead code 2023-05-04 11:16:52 +09:00
Dean Herbert
99d2616c34 Move drawable construction to load for simplicity 2023-05-04 11:14:51 +09:00
Dean Herbert
be995f1359 Add localisation support for new button string 2023-05-04 11:11:19 +09:00
Dean Herbert
b7abab6d8a More variable improvements 2023-05-04 11:10:05 +09:00
Dean Herbert
0a584f0652 Simplify check logic and improve variable naming 2023-05-04 11:07:09 +09:00
Bartłomiej Dach
59ece64d25
Merge branch 'master' into skin-editor-change-handler-improvement 2023-05-03 19:42:42 +02:00
Bartłomiej Dach
1d4d31e35c
Trim comments
Leaving only the ones that add anything useful and do not restate the
code verbatim.
2023-05-03 19:22:52 +02:00
Bartłomiej Dach
27fabd99fb
Rename variables for legibility
Having `typedComponents` and `typeComponents` next to each other is
asking for trouble.
2023-05-03 19:21:16 +02:00
cdwcgt
4549a865d9
Merge branch 'master' into export 2023-05-04 00:18:01 +09:00
cdwcgt
967e801f9c
code inspect 2023-05-03 23:26:58 +09:00
cdwcgt
debbd376bd
move scrollContent update logic to updateActiveState() 2023-05-03 23:24:14 +09:00
cdwcgt
f4b1264cc9
use button Enable status to ensure preset name is not null 2023-05-03 23:22:46 +09:00
cdwcgt
aa5a026c67
remove local button handle 2023-05-03 23:14:24 +09:00
cdwcgt
c609e6345c
remove Use Current Mods menu item 2023-05-03 23:02:50 +09:00
Cootz
152d2678d5 Fix ModSelectColumn completely disappear from ModSelectOverlay 2023-05-03 14:00:46 +03:00
Dean Herbert
be15d07b17 Tidy up various implementation details 2023-05-03 18:59:39 +09:00
Dean Herbert
b932e4d986 Rename DrawableUsername to DrawableChatUsername and only pass message ID 2023-05-03 18:53:22 +09:00
Dean Herbert
4f55afb60d Merge branch 'master' into chat-report 2023-05-03 18:50:38 +09:00
Joseph Madamba
1c74f6e8ea
Fix regressed button hover fade in 2023-05-02 22:54:42 -07:00
Joseph Madamba
bede1292de
Fix overlay scroll back button not absorbing hover from behind 2023-05-02 22:40:37 -07:00
Dean Herbert
e394b487e0
Merge branch 'master' into edit-mods-preset 2023-05-03 12:06:16 +09:00
Cootz
a6ca049739 Manually implement @bdach prototype 2023-05-02 14:15:33 +03:00
Dean Herbert
4a97c2c105
Merge pull request #23038 from cdwcgt/scale-background-dim
Add feature to adjust `ScalingContainer` background dim
2023-05-02 15:36:52 +09:00
Dean Herbert
ce4a6c38a0
Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight
Fix now playing playlist not highlighting selected item on initial open
2023-05-02 15:36:34 +09:00
Dean Herbert
ab4f66fad3 Minor readability refactors 2023-05-02 14:31:39 +09:00
Dean Herbert
7a840e1d82 Remove unnecessary TransferValue spec 2023-05-02 14:29:26 +09:00
Dean Herbert
7efaa299bd Merge branch 'master' into scale-background-dim 2023-05-02 14:24:54 +09:00
Dean Herbert
736be6a73b Refactor slightly for readability 2023-05-02 14:11:16 +09:00
Dean Herbert
e808e7316b Mark delegate value unused and add comment to avoid future regression 2023-05-02 13:29:30 +09:00
Terochi
4d52ce769b Revert SaveState() calling on initialization 2023-05-01 12:53:58 +02:00
Bartłomiej Dach
7cedbca9be
Merge branch 'master' into multiplier-doesnt-update-with-preset-mod 2023-04-30 17:36:00 +02:00
Bartłomiej Dach
2e3daf0a54
Fix leak of ModSettingChangeTracker instances
The `SelectedMods.BindValueChanged()` callback in `ModSelectOverlay` can
in some instances run recursively. This is most heavily leaned on in
scenarios where `SelectedMods` is updated by an external component. In
such cases, the mod select overlay needs to replace the mod instances
received externally with mod instances which it owns, so that the changes
made on the overlay can propagate outwards.

This in particular means that prior to this commit, it was possible to
encounter the following scenario:

	modSettingChangeTracker?.Dispose();
	updateFromExternalSelection(); // mutates SelectedMods to perform the replacement
	                               // therefore causing a recursive call

		modSettingChangeTracker?.Dispose();
		// inner call continues
		modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);

	// outer call continues
	modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);

This leaks one `modSettingChangeTracker` instance from the inner call,
which is never disposed.

To avoid this, move the disposal to the same side of the recursion that
the creation happens on, changing the call pattern to:

	updateFromExternalSelection(); // mutates SelectedMods to perform the replacement
	                               // therefore causing a recursive call

		modSettingChangeTracker?.Dispose();
		// inner call continues
		modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);

	modSettingChangeTracker?.Dispose();
	// outer call continues
	modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);

which, while slightly wasteful, does not cause any leaks.

The solution is definitely suboptimal, but addressing this properly
would entail a major rewrite of the mod instance management in the mods
overlay, which is probably not the wisest move to make right now.
2023-04-30 17:31:41 +02:00
Terochi
fb4b681cc5 Use Queue instead of Stack 2023-04-30 16:36:01 +02:00
Terochi
8f02bd80f9 Addressed changes 2023-04-30 16:11:52 +02:00
Terochi
949dc1c0f9 Improved logic 2023-04-30 12:05:55 +02:00
Terochi
8ec2154965 Fixed ApplyStateChange to happen in correct order 2023-04-30 02:01:18 +02:00
Terochi
17e4b75dfd Save first state when editing 2023-04-29 20:54:19 +02:00
Terochi
3b0ba4b38b Improved logic for ApplyStateChange for skin editor 2023-04-29 19:52:22 +02:00
Bartłomiej Dach
646d4965b9
Merge branch 'master' into fix-exclusive-fullscreen-detection 2023-04-29 14:39:34 +02:00
_ltn
2d6c0d2900 use of Child instead of Children 2023-04-28 19:24:07 +03:00
Dean Herbert
6929be49b7 Change condition for exclusive fullscreen notice to only show when using the correct renderer
This avoids the notice showing when running on windows, but using the
newer renderers (where the underlying logic hasn't been tested properly
and can result in false-positives).

Supersedes https://github.com/ppy/osu-framework/pull/5759 as a more
correct implementation.
2023-04-28 22:36:30 +09:00
Ethan
ae85e2a3ff Update LoginForm.cs 2023-04-28 19:51:10 +08:00
_ltn
4b0ee392f6 add OsuHoverContainer 2023-04-28 05:48:54 +03:00
_ltn
17730f05bc remove UpdateableCountryText 2023-04-28 05:47:05 +03:00
_ltn
4d144cd5b5 clearing the code 2023-04-28 02:06:13 +03:00
_ltn
092377fdaa moving UpdateableCountryText 2023-04-28 01:47:14 +03:00
_ltn
e9843f2066 replace country text object 2023-04-28 01:16:50 +03:00
Cootz
b795e8ac5a Use ModSearch in ModeSelectOverlay 2023-04-27 17:26:35 +03:00
Cootz
3c6141f233 Add ModSearch 2023-04-27 17:08:29 +03:00
Hy0tic
56ab029a58 fix issue where multipler does not update when adjusting speed for preset mod 2023-04-22 13:30:08 -04:00
Joseph Madamba
776c4cfaad
Ensure selected field is correct in updateSelectionState()
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-04-19 18:34:35 -07:00
Dean Herbert
52c4703261
Merge pull request #23103 from Joehuu/normalise-overlay-padding
Normalise horizontal padding on overlays
2023-04-10 23:48:59 +09:00
Bartłomiej Dach
1f2c96c8e8
Merge branch 'master' into gd-onlinesetoverlay 2023-04-10 15:35:03 +02:00
Bartłomiej Dach
11fd93a2ba
Inline disturbing getGuestMapper() method
Disturbing because name suggests pure method, but it is in fact `void`
and also performs side effects by about the most confusing means
possible.
2023-04-10 15:20:43 +02:00
cdwcgt
ce6a87b4a3
Merge remote-tracking branch 'upstream/master' into export 2023-04-09 15:02:47 +09:00
cdwcgt
de21b4a2f7
use Live<TModel>
Use RealmAccess only when needed
2023-04-09 22:21:15 +09:00
Joseph Madamba
a86a968fac
Use public BeatmapSet to match other usages 2023-04-07 21:16:36 -07:00
Joseph Madamba
ed208ef127
Fix more typos and adjust font size to match web 2023-04-07 21:10:37 -07:00
Bartłomiej Dach
b5d9284de2
Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer
Fix attempting to show overlay during game intro playing hide sound effects
2023-04-03 20:48:03 +02:00
cdwcgt
9dd30e4b4c
condition fix 2023-04-03 20:24:38 +09:00
cdwcgt
735b48679e
use LinkFlowContainer directly 2023-04-03 20:09:49 +09:00
cdwcgt
41c01d3929
nullable condition 2023-04-03 20:07:21 +09:00
cdwcgt
51240ed46b
typo 2023-04-03 19:51:22 +09:00
Dean Herbert
43d7386623
Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting
Fix beatmap listing sort direction not resetting when changing criteria
2023-04-03 15:32:10 +09:00
Dean Herbert
e4eb736622
Merge pull request #22929 from Joehuu/fix-loading-blocking-overlay-headers
Fix beatmap listing filter control being blocked by loading layer
2023-04-03 15:29:38 +09:00
Dean Herbert
a097433cb1 Fix overlay toggle keys working during disabled activation modes
Closes #23104.
2023-04-03 15:03:47 +09:00
Joseph Madamba
247d426c8a
Add horizontal padding to currently playing search textbox 2023-04-02 20:50:18 -07:00
Joseph Madamba
436f1e4ae4
Replace other hardcoded horizontal padding with const
- Also add overlay stream item padding const and account for it
2023-04-02 20:50:18 -07:00
Joseph Madamba
af389b1107
Replace all hardcoded 50 horizontal padding with const 2023-04-02 20:50:18 -07:00
Joseph Madamba
7a0edabd5d
Normalise overlay horizontal padding const 2023-04-02 20:24:13 -07:00
Joseph Madamba
63ea17f10e
Update comment vote pill in line with web 2023-04-02 18:17:40 -07:00
Susko3
c3a6a58169 Fix window mode dropdown not showing 2023-04-02 19:23:18 +02:00
cdwcgt
d949ef3ca4
make guestMapperContainer private
tests don't use it
2023-04-02 22:53:15 +09:00
cdwcgt
2cf8636366
show guest diff author in BeatmapPicker 2023-04-02 22:25:58 +09:00
Dean Herbert
4c2b7e7788 Fix random inspection showing up only in CI 2023-04-02 21:05:20 +09:00
Dean Herbert
cf5acbf66e Update usage of SupportedWindowModes 2023-04-02 20:16:14 +09:00
cdwcgt
5d395e6d37
move to ctor 2023-03-29 22:59:54 +09:00
cdwcgt
e85c28031e
change weird name 2023-03-29 22:55:25 +09:00
cdwcgt
46ede27869
add feature to adjust ScalingContainer background dim 2023-03-28 22:41:24 +09:00
cdwcgt
31df626f0e disable button when select other reason 2023-03-28 21:32:28 +09:00
cdwcgt
899860dd77 Merge branch 'master' into chat-report 2023-03-28 21:14:11 +09:00
Dean Herbert
8c1df3c8d9 Fix web account registration not bypassing the URL warning 2023-03-28 15:38:19 +09:00
cdwcgt
b065689cf8 Limit the area of popover to DrawableChannel
popover may be blocked by textBar
2023-03-27 23:04:45 +09:00
Dean Herbert
898717231b Hide vulkan renderer option for now
We'll bring it back when it's more stable.
2023-03-27 02:00:10 +09:00
Bartłomiej Dach
292486c25a
Use more resilient restore method 2023-03-26 14:35:00 +02:00
Bartłomiej Dach
f3c174a7f2
Fix test errors due to missing dependencies 2023-03-26 13:52:26 +02:00
Dean Herbert
bab93bed17 Fix string interpolation and use GetDescription on renderer value 2023-03-26 20:43:28 +09:00
Dean Herbert
ba078e8357 Show "automatic" resolved renderer inline in dropdown instead 2023-03-26 20:29:30 +09:00
Dean Herbert
764361b3d3 Add special case to hide definitely non-working renderers on android 2023-03-26 20:14:33 +09:00
Dean Herbert
e346b02ebf Add display of current renderer 2023-03-26 20:09:35 +09:00
Joseph Madamba
eaef5ff2a3
Fix now playing playlist not highlighting selected item on initial open 2023-03-25 22:13:51 -07:00
Joseph Madamba
450c5cef07
Add comment explaining loading container padding 2023-03-24 18:42:34 -07:00
Dean Herbert
ab6cfea5c7
Revert old value instead of always using default
Co-authored-by: cdwcgt <loginchen@outlook.com>
2023-03-23 11:27:05 +09:00
cdwcgt
85a924f078 why
merge problem?
2023-03-23 01:02:17 +09:00
cdwcgt
8518d15b8d use endpoint 2023-03-23 01:00:38 +09:00
Dean Herbert
3050a16bf8 Don't require a restart when selecting Automatic and startup setting was also automatic 2023-03-22 16:56:36 +09:00
Dean Herbert
aabe86dc26 Limit renderers to those available for the current platform 2023-03-22 16:49:29 +09:00
Dean Herbert
956fabb445 Show restart notice when changing renderer 2023-03-22 16:49:29 +09:00
Dean Herbert
13be709718 Add basic renderer selection 2023-03-22 16:49:29 +09:00
Dean Herbert
db227b1798 Merge branch 'master' into chat-report 2023-03-22 16:26:28 +09:00
Joseph Madamba
6f3bb85eaa
Always show down arrow on inactive sort buttons 2023-03-22 00:19:23 -07:00
Joseph Madamba
d9571b6fc9
Move filter control property setters to load() 2023-03-21 21:31:35 -07:00
Joseph Madamba
74a15d7424
Fix overlay headers being blocked by loading layer 2023-03-21 20:32:26 -07:00
Joseph Madamba
e1fb63e1f3
Move beatmap listing filter control to header 2023-03-21 20:32:26 -07:00
Joseph Madamba
3cd01ee621
Fix beatmap listing sort direction not resetting when changing criteria 2023-03-21 15:08:37 -07:00
Joseph Madamba
df3ccdff9f
Add failing beatmap listing sort direction on criteria change test 2023-03-21 15:08:37 -07:00
Bartłomiej Dach
9ff9cd3b7f
Merge branch 'master' into skin-editor-cyclic-selection 2023-03-21 19:49:55 +01:00
Joseph Madamba
970df5d88a
Update profile kudosu section in line with web 2023-03-18 19:49:30 -07:00
cdwcgt
d025c441ca delay mod save after click save or not popover hidden 2023-03-16 19:48:45 +09:00
cdwcgt
42bcc8bafc revert mod store 2023-03-16 19:38:15 +09:00
Dean Herbert
f8e773ab8e
Merge branch 'master' into fix-overlay-sidebar-scroll 2023-03-15 15:30:50 +09:00
Dean Herbert
6546f5968a Merge branch 'master' into skin-editor-cyclic-selection 2023-03-14 20:43:56 +09:00
Joseph Madamba
6e5b1280b7
Fix multiple notice boxes having no spacing 2023-03-11 21:36:29 -08:00
Joseph Madamba
ea88aee41f
Display stub notice in marked wiki articles 2023-03-11 21:36:28 -08:00
Joseph Madamba
0cf69a1084
Make yaml line strings verbatim 2023-03-11 21:36:23 -08:00
cdwcgt
15f11bb1e8 scorll container and save mod after popover hidden
Requires manual handling of many visual effects
2023-03-11 12:31:33 +09:00
cdwcgt
1cd565193e public CheckCurrentModCanBeSave 2023-03-11 11:39:35 +09:00
cdwcgt
8b0f127ff2 split ModPresetRow 2023-03-11 11:25:52 +09:00
cdwcgt
f4e2620402 fix test 2023-03-10 00:56:22 +09:00
cdwcgt
ca416175bb remove useless property 2023-03-09 22:58:44 +09:00
cdwcgt
3d746e8dfb content Menu 2023-03-09 22:49:33 +09:00
cdwcgt
5a1316f0e5 split save logic 2023-03-09 22:43:06 +09:00
Bartłomiej Dach
5213bfa5c9
Merge branch 'master' into make_skin_reset_dangerous 2023-03-07 21:06:44 +01:00
Bartłomiej Dach
cfafa8af8c
Merge branch 'master' into hud/player-components 2023-03-07 19:44:12 +01:00
Bartłomiej Dach
7ade525eef
Display corner radius setting as percentage 2023-03-07 19:43:52 +01:00
cdwcgt
54564e0557 new design 2023-03-07 21:13:35 +09:00
Dean Herbert
97bee4db89 Fix localisations 2023-03-07 18:07:53 +09:00
Dean Herbert
26ef7c2637 Rename confirmation dialog class to mention revert not reset 2023-03-07 18:07:46 +09:00
Dean Herbert
55467fcbe3 Update xmldoc for DangerousActionDialog to match new behaviour 2023-03-07 18:07:46 +09:00
Dean Herbert
21bdbb20e6 Add optional support for cyclic selection to BlueprintContainer 2023-03-07 14:22:12 +09:00
cdwcgt
4858d3fd42 Added ability to edit mod presets 2023-03-07 02:00:40 +09:00
mk56-spn
908651cc11 make ResetConfirmDialog properly utilise its parent's logic
Adjust name of `DeleteAction` to `DangerousAction`
2023-03-05 20:57:26 +01:00
Bartłomiej Dach
60cdd3c070
Clear components sidebar unconditionally on every target change
Fixes the working layer dropdown lingering after exiting from a
skinnable screen to a non-skinnable one.
2023-03-04 14:10:05 +01:00
Bartłomiej Dach
d233f3a3ab
Show non-skinnable screen placeholder at higher level 2023-03-04 13:49:10 +01:00
Bartłomiej Dach
49e298e304
Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer
An end result of #22674 is that `SkinBlueprintContainer`s are only ever
created by supplying a `SkinComponentsContainer` to them. However,
`SkinBlueprintContainer` still contained remnants of code that suggested
it was designed to handle cases where more than the drawable supplied to
it contained more than one `ISerialisableDrawableContainer`, or even
zero.

The zero path is totally dead right now (because every
`SkinComponentsContainer` is *by necessity* an
`ISerialisableDrawableContainer`), and the more-than-one path is dead
*for now* (and potentially forever?). Therefore, just hard-couple
`SkinBlueprintContainer` to receive a single target container.
2023-03-04 13:33:21 +01:00
Bartłomiej Dach
2f25fb4083
Move NonSkinnableScreenPlaceholder to outer scope 2023-03-04 13:22:43 +01:00
Bartłomiej Dach
15409b9c15
Fix skin selection not clearing on exit to non-skinnable screen 2023-03-04 13:18:34 +01:00
mk56-spn
2b7111867c Adjust reversion header text naming. 2023-03-03 15:12:20 +01:00
Joseph Madamba
af540de69b
Fix "talking with" text overflowing when usernames are too long 2023-03-01 22:10:15 -08:00
Joseph Madamba
bb5791a714
Fix overlay sidebars not scrolling to end due to parent scroll view 2023-03-01 21:41:01 -08:00
Dean Herbert
bd11d5d29a
Merge pull request #22743 from Joehuu/scroll-back-to-previous
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
mk56-spn
90227a6496 Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs 2023-02-27 21:57:59 +01:00
mk56-spn
00a00ead22 Make ResetConfirmDialog inherit from DeleteConfirmationDialog 2023-02-27 21:50:27 +01:00
mk56-spn
1239de6f41 Upper case web using alias 2023-02-27 21:34:07 +01:00
mk56-spn
bf1897a98f Adjust warning text slightly. 2023-02-27 16:08:14 +01:00
Joseph Madamba
fa710ae1b0
Rename ScrollToTopButton to ScrollBackButton 2023-02-26 14:39:34 -08:00
Joseph Madamba
dc00905f8d
Add ability to scroll back to previous position after scrolling to top via button on overlays 2023-02-26 14:38:51 -08:00
mk56-spn
ff0d1aa9f7 Make reverting changes to a given skin into a "dangerous action" 2023-02-26 20:38:50 +01:00
Dean Herbert
dc3c1150b8 Set better defaults for SkinBlueprint transforms 2023-02-23 21:10:15 +09:00
Dean Herbert
c48aceb055 Fix undo history not being batched correctly for depth change operations 2023-02-23 20:03:36 +09:00
Dean Herbert
16c8a392a1 Add ability to send selected skin components to front or back 2023-02-22 18:17:20 +09:00
Bartłomiej Dach
051eb18b33
Merge branch 'master' into skin-editor-layer-select 2023-02-21 21:38:51 +01:00
Bartłomiej Dach
ec1bf7b0b2
Merge branch 'master' into skin-editor-clipboard 2023-02-21 19:35:58 +01:00
Dean Herbert
af062e7a68 Change placeComponent to only add to selection, not clear an existing selection 2023-02-21 14:11:18 +09:00
Dean Herbert
0d229d959b Remove unnecessary TriggerChange call 2023-02-21 13:50:19 +09:00
Bartłomiej Dach
6799492596
Merge branch 'master' into skin-editor-layer-select 2023-02-20 21:33:48 +01:00
Dean Herbert
6382314af1
Merge pull request #22697 from ggliv/tablet-area-drag
Allow tablet area to be dragged
2023-02-20 23:37:25 +09:00
Dean Herbert
43d33d45ca Only add valid placed components to selected collection on paste 2023-02-20 20:02:43 +09:00
Dean Herbert
b68562b033 Make placeComponent resilient to missing dependencies 2023-02-20 20:00:12 +09:00
Dean Herbert
a9c7edd087 Remove copy pasted comment 2023-02-20 19:57:16 +09:00
Dean Herbert
7a585e1fa1
Merge pull request #22669 from EVAST9919/mod-overlay-triangles
Add triangles animation to mod select overlay headers
2023-02-20 19:54:21 +09:00
Gabe Livengood
c86c1a9029 allow tablet area to be dragged 2023-02-20 00:06:20 -05:00
Bartłomiej Dach
1ba1298850
Merge branch 'master' into blueprint-improve-visuals 2023-02-19 15:55:30 +01:00
Dean Herbert
d7381b762c Also tween origin position 2023-02-19 23:52:21 +09:00
Bartłomiej Dach
ea04c487f2
Merge branch 'master' into blueprint-labels-while-hovering 2023-02-18 15:57:30 +01:00
Bartłomiej Dach
15d209d17e
Merge branch 'master' into CompletionText-LocalisableString 2023-02-18 13:50:58 +01:00
Bartłomiej Dach
fbea3e312f
Merge branch 'master' into skin-editor-improve-toolbox-hover 2023-02-18 10:02:02 +01:00
Bartłomiej Dach
2aa4481f68
Fix toolbox items spontaneously contracting after briefly losing hover
Reproduction scenario:

1. Hover a toolbox item
2. Unhover the item, but do not hover any other item (can be done by
   exiting the toolbox completely to the right)
3. Come back to the item hovered in step (1)
4. The item would spontaneously contract after a second
2023-02-17 22:54:11 +01:00
Bartłomiej Dach
b390fdb8cc
Remove unused field 2023-02-17 21:51:19 +01:00
Andrei Zavatski
ffcca9fd89 Remove awkward width specification 2023-02-17 23:23:58 +03:00
cdwcgt
dbb366e279 CompletionText can be a LocalisableString
I can't find a reason for not doing this, probably this was forgotten in https://github.com/ppy/osu/pull/15440
2023-02-17 22:32:03 +09:00
cdwcgt
e84e011d5d Merge branch 'master' into export 2023-02-17 22:15:19 +09:00
Andrei Zavatski
51940133df Adjust width and add comment 2023-02-17 15:18:45 +03:00
Andrei Zavatski
0838fa636f Make triangles slower 2023-02-17 15:16:00 +03:00
Dean Herbert
0a018514e1 Make skin editor focus only one layer at a time 2023-02-17 19:27:16 +09:00
Dean Herbert
00fcee0c5a Add per-ruleset component toolbox and placement support 2023-02-17 19:27:16 +09:00
Dean Herbert
ba5a87ca04 Add basic target layer selection in skin editor 2023-02-17 19:27:16 +09:00
Dean Herbert
5ed038fbb3 Improve the feel of hovering toolbox component items 2023-02-17 19:26:03 +09:00
Dean Herbert
814080d982 Only show blueprint labels when hovering or selected 2023-02-17 19:23:52 +09:00
Dean Herbert
6c61c5f4a8 Fix selection on the edge of blueprints (in the new inflation area) failing 2023-02-17 18:19:46 +09:00
Dean Herbert
16d94b4ea2 Improve visuals of skin blueprint 2023-02-17 18:19:46 +09:00
Andrei Zavatski
a84f20bf32 Add triangles to ModSelectColumn 2023-02-17 03:09:32 +03:00
Dean Herbert
925deb7ca5 Make skin editor clipboard shared between screens and skins to allow moving elements over 2023-02-15 19:35:37 +09:00
Dean Herbert
bc83b0c264 Fix clipboard changes not batching as undo steps 2023-02-15 19:35:22 +09:00
Dean Herbert
bcf2555545 Fix components having incorrect default positions 2023-02-15 19:34:42 +09:00
Dean Herbert
d653335b6f Add basic skin editor clipboard implementation 2023-02-15 19:28:42 +09:00
Dean Herbert
a92e42bb84 Rename SkinnableTargetContainer to SkinComponentsContainer
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
Dean Herbert
b1cf6d83d8 Move extension methods closer to serialisation classes 2023-02-15 18:37:41 +09:00
Dean Herbert
e61d2d571c Move the lookup type out of ISserialisableDrawableContainer 2023-02-15 18:37:41 +09:00
Dean Herbert
a7b47f6503 Rename ISkinnableTarget to ISerialisableDrawableContainer 2023-02-15 18:37:41 +09:00
Dean Herbert
d159d6b970 Rename ISkinnableDrawable to ISerialisableDrawable 2023-02-15 18:37:41 +09:00
Dean Herbert
856efd9fd9 Rename SkinnableDrawableInfo to SerialisedDrawableInfo 2023-02-15 18:23:19 +09:00
Dean Herbert
9e651a7ca2 Rename SkinnableInfo to SkinnableDrawableInfo 2023-02-15 18:23:17 +09:00
Dean Herbert
6010dde86e Move SkinnableInfo to better namespace 2023-02-15 18:23:10 +09:00
Dean Herbert
679df9bf8b
Merge pull request #22604 from Joehuu/abort-dangerous-dialog-button-on-hover-lost
Add ability to abort dangerous dialog button on hover lost
2023-02-13 20:40:14 +09:00
Joseph Madamba
8d9245c1d4 Make AbortConfirm() virtual and override with filter logic 2023-02-11 12:54:16 -08:00
Joseph Madamba
94d6ab1ec7 Continue confirming when rehovering if mouse is still down 2023-02-10 19:09:30 -08:00
Joseph Madamba
bfd83768c1 Fix skin component previews on toolbox buttons having incorrect size for one frame 2023-02-10 17:58:34 -08:00
Joseph Madamba
d30d054b4c Add ability to abort dangerous dialog button on hover lost 2023-02-10 14:41:44 -08:00
Dean Herbert
28897b6e18
Merge pull request #22566 from Joehuu/profile-tournament-banner
Display tournament banner on user profile
2023-02-09 16:06:36 +09:00
Joseph Madamba
f1decb667e Address todos relating to init-only usages 2023-02-08 17:51:28 -08:00
Joseph Madamba
3b5d573db1 Display tournament banner on user profile 2023-02-08 17:16:09 -08:00
Bartłomiej Dach
0a5c4e04bf
Merge branch 'master' into skin-editor-undo-support 2023-02-08 18:43:59 +01:00
Joseph Madamba
0156ff732f Fix beatmap cards not showing context menu on user profile 2023-02-07 22:56:09 -08:00
Dean Herbert
17ca26ebee Remove unnecessary null check on targetScreen 2023-02-08 15:44:24 +09:00
Dean Herbert
3a3c2e78a1 Merge branch 'master' into skin-editor-undo-support 2023-02-08 15:41:58 +09:00
Dean Herbert
78eae171ed
Merge pull request #22507 from Joehuu/fix-comment-padding
Fix comments having too much padding at the bottom
2023-02-08 15:01:05 +09:00
Dean Herbert
b6809e156b
Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii
Implement a sheared slider for the updated design
2023-02-08 15:01:00 +09:00
Joseph Madamba
277f71d36a Expire reply editor instead of clearing container 2023-02-07 15:15:51 -08:00
Dean Herbert
0320ba770f Handle component changes via ISkinnableTarget.Components rather than inside SkinEditor directly
Seems saner? Maybe?
2023-02-07 16:23:25 +09:00
Dean Herbert
dad348111d Fix holding a selection while changing screens causing a crash 2023-02-07 16:07:33 +09:00
Dean Herbert
71eef238c4 Make OnStateChange non-implemented rather than wrong 2023-02-07 16:04:31 +09:00
Bartłomiej Dach
179db09075
Merge pull request #22531 from peppy/apply-future-rider-inspection
Apply single inspection from newer inspectcode versions
2023-02-06 20:05:49 +01:00
Dean Herbert
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii 2023-02-06 17:49:33 +09:00
Dean Herbert
c078d3a344
Merge pull request #22357 from EXtremeExploit/groups-probationary-badges
Make probationary groups a bit transparent
2023-02-06 17:43:57 +09:00
Dean Herbert
4c868372a2 Correctly handle anchor/origin changes as undo states 2023-02-06 15:05:05 +09:00
Dean Herbert
7445814fc6 Handle changes to SettingSource skin element settings 2023-02-06 14:42:59 +09:00
Dean Herbert
701d21c26f Apply single inspection from newer inspectcode verisons
As found in rider EAPs. Appears as a warning and is annoying me
occasionally.
2023-02-06 13:52:27 +09:00
Dean Herbert
10ab4d572a Merge branch 'master' into skin-editor-undo-support 2023-02-06 13:46:50 +09:00
Joseph Madamba
cb8458cceb
Use linq and alpha instead
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-04 20:11:29 -08:00
Joseph Madamba
4192388b20 Fix expanded beatmap cards getting cut off at the end of profile sections 2023-02-03 21:29:01 -08:00
Bartłomiej Dach
4bd43171e8
Merge branch 'master' into fix-skin-editor-padding-weirdness 2023-02-03 20:28:47 +01:00
Bartłomiej Dach
59656a7286
Merge branch 'master' into skin-editor-dont-show-save-on-no-change 2023-02-03 19:08:33 +01:00
EXtremeExploit
f9809c9481
the comment 2023-02-03 11:48:11 -03:00
Joseph Madamba
461b5c5375 Fix comment cancel button not behaving the same as reply text toggle
- Removed the fading animation as it is awkward right now (needs resizing)
2023-02-03 02:04:19 -08:00
Dean Herbert
2cda277c09 Add a basic change handler to the skin editor 2023-02-03 18:57:50 +09:00
Joseph Madamba
94d2799b90 Fix comments having too much padding at the bottom 2023-02-03 00:47:10 -08:00
Dean Herbert
b19047b90b Fix skin editor component list having uneven padding 2023-02-03 16:55:51 +09:00
Dean Herbert
32207dc9dd Merge branch 'master' into locale/skin-editor-components 2023-02-03 15:24:00 +09:00
Dean Herbert
5ca5f04794 Add parameter hint for optional bool value 2023-02-03 15:18:40 +09:00
Bartłomiej Dach
e937022b09
Merge branch 'master' into middle-click-replay-pause 2023-02-02 20:52:03 +01:00
Bartłomiej Dach
4d46a8f32d
Merge branch 'master' into skin-editor-dont-show-save-on-no-change 2023-02-02 19:36:23 +01:00
Bartłomiej Dach
f7fa9e3927
Remove outdated comment 2023-02-02 18:41:35 +01:00
mk56-spn
3f0ce75bf5 Rename NormalSliderBar.cs to RoundedSliderBar.cs 2023-02-02 17:24:45 +01:00
Dean Herbert
015f4f2b38 Avoid showing skin save message when changing scenes after making no changes 2023-02-02 18:42:37 +09:00
Dean Herbert
9b6d95b3d6 Adjust skin editor pop in/out to be more snappy 2023-02-02 18:33:45 +09:00
Dean Herbert
26efb8e842 Replace white box legacy placeholder with something that visually fits 2023-02-02 18:33:31 +09:00
Dean Herbert
659b78058f Move replay specific key bindings to their own section 2023-02-02 15:25:52 +09:00
Dean Herbert
8dc2e6872e Move skin editor to overlays namespace 2023-02-02 14:00:31 +09:00
Dean Herbert
d54db8de64
Merge branch 'master' into fix-clicking-metadata-relevance-sort 2023-02-01 19:39:13 +09:00
Dean Herbert
524aa9162d Store search parameters as tuple 2023-02-01 19:38:47 +09:00
Joseph Madamba
1a152452f1 Fix incorrect naming of badge header container 2023-01-31 15:16:29 -08:00
Joseph Madamba
0366a8e348 Only call Reset() if lastCategory and lastHasQuery is null 2023-01-31 12:44:44 -08:00
Dean Herbert
5d22f3d879 Improve inline comment 2023-01-31 17:17:21 +09:00
Cootz
b18652b25f CreateSubDirectory removed. Fixes the empty root issue 2023-01-31 10:14:21 +03:00
Cootz
54d5d4e7c6 Fix for the issue 2023-01-31 07:06:26 +03:00
Joseph Madamba
610d2f9dc7 Fix beatmap listing potentially not sorting by relevance when searching via metadata 2023-01-28 12:14:35 -08:00
mk56-spn
091cc155d3 Fix nub naming in OsuCheckbox.cs and associated classes 2023-01-26 16:10:02 +01:00
EXtremeExploit
1de0bed83d
fix comment 2023-01-26 11:09:16 -03:00
mk56-spn
374c3b56f6 Rename Nub.cs to NormalNub.cs 2023-01-26 15:03:11 +01:00
mk56-spn
3988131475 Rename OsuSliderBar.cs as NormalSliderBar.cs 2023-01-26 12:12:56 +01:00
EXtremeExploit
0eaebfd40a
Use Alpha instead of opacity on bg color 2023-01-25 10:22:42 -03:00
Dean Herbert
5c888e0c68
Merge branch 'master' into beatmapSelectionBlur 2023-01-25 16:37:19 +09:00
Dean Herbert
01e280eb6b Add classic default for song select blur setting 2023-01-25 16:32:00 +09:00
Dean Herbert
e333e12b2e Fix typo in settings enum (seriously) 2023-01-25 16:32:00 +09:00
Dean Herbert
3faab66f39 Merge branch 'master' into beatmapSelectionBlur 2023-01-25 16:32:00 +09:00
Dean Herbert
6bf7773532 Increase duration of expansion transition 2023-01-25 14:28:25 +09:00
Dean Herbert
3e91dd2a16 Update spacing along with expanded state 2023-01-25 14:28:25 +09:00
Bartłomiej Dach
f2df36e6a5
Persist cover visibility to user settings
Follows web precedent, wherein the setting is saved to local storage.
2023-01-24 23:30:12 +01:00
Bartłomiej Dach
33e91cf512
Implement cover toggling 2023-01-24 23:06:49 +01:00
Bartłomiej Dach
e74176e5bd
Add cover toggle button 2023-01-24 23:06:46 +01:00
Bartłomiej Dach
ef7812412b
Update top header container appearance 2023-01-24 23:06:44 +01:00
Bartłomiej Dach
ff22a91d52
Move user cover lower down 2023-01-24 23:06:37 +01:00
Bartłomiej Dach
edb9c76edf
Merge pull request #22385 from peppy/touchscreen-settings-keyword
Fix touch input handler settings not matching search for "touchscreen"
2023-01-24 20:50:53 +01:00
Jérémiah DÉCOMBE
acb42f7d12 reusing gameplay background blur loc song select background blur 2023-01-24 10:18:00 +01:00
Dean Herbert
b9291cb116 Change some order and assert for positive visibility before scheduling an operation in changelog overlay 2023-01-24 17:59:25 +09:00
Jérémiah DÉCOMBE
e0a7559d85 variable naming + loc 2023-01-24 09:55:08 +01:00
Joseph Madamba
c6bf755e68 Remove IsPresent override from ChangelogOverlay 2023-01-24 00:22:29 -08:00
Joseph Madamba
df895c4fd6 Always make settings footer build display clickable 2023-01-24 00:21:39 -08:00
Jérémiah DÉCOMBE
7ca2a431e6 changing song select background blur setting to boolean 2023-01-24 09:19:53 +01:00
Dean Herbert
fc558278cc Fix touch input handler settings not matching search for "touchscreen" 2023-01-24 13:37:12 +09:00
Jeremiah DECOMBE
b573e42cc2 BeatmapSelectionBackgroundBlurLevel renamed to SongSelectBackgroundBlurLevel 2023-01-24 00:08:11 +01:00
Jeremiah DECOMBE
f13a5465ba variable naming and loc modifications 2023-01-23 23:07:50 +01:00
Bartłomiej Dach
9f2ed853eb
Merge pull request #22371 from peppy/more-settings-keywords
Add more keywords to settings based on feedback
2023-01-23 20:19:53 +01:00
Jérémiah DÉCOMBE
6daa364779 adding setting to adjust blur of the background of the song select screen 2023-01-23 13:53:31 +01:00
Dean Herbert
432e0a6a37
Merge branch 'master' into level-badge-colour 2023-01-23 15:46:15 +09:00
Dean Herbert
9c2494383f Rename fetch method to be non-plural to match all others 2023-01-23 15:43:52 +09:00
Dean Herbert
7ebd31d42f Add more keywords to settings based on feedback 2023-01-23 15:14:16 +09:00
Dean Herbert
2ed9fe3747 Add support for externally specified keywords in SettingsButtons 2023-01-23 15:10:26 +09:00
EXtremeExploit
8d4889d5ce
Cleanup 2023-01-22 17:42:53 -03:00
EXtremeExploit
e60a089f1a
Set alpha on container instead of children 2023-01-22 15:02:02 -03:00
EXtremeExploit
de5eb63ceb
Fix codefactor 2023-01-22 13:38:13 -03:00
EXtremeExploit
933fc8cc83
Fix comment 2023-01-22 13:33:36 -03:00
EXtremeExploit
64c9654910
Make probationary groups a bit transparent 2023-01-22 13:32:05 -03:00
Bartłomiej Dach
e1acf85bb3
Merge branch 'master' into groups-modes 2023-01-22 10:09:34 +01:00
Bartłomiej Dach
9bde1ef9bf
Privatise setter 2023-01-22 10:09:08 +01:00
Bartłomiej Dach
b98da506c1
Fix code quality inspection 2023-01-22 10:07:47 +01:00
Bartłomiej Dach
88d58e8476
Merge pull request #22337 from Joehuu/fix-comment-editor-sounds
Fix comment editor text boxes not having sound feedback
2023-01-22 09:10:20 +01:00
Dean Herbert
7040743249 Add search keywords for screen scaling sub-settings 2023-01-22 13:47:31 +09:00
EXtremeExploit
2f3971b6fb
Move code to already existing if block 2023-01-22 01:40:00 -03:00
EXtremeExploit
8c208da324
Cleanup 2023-01-22 01:39:01 -03:00
EXtremeExploit
05f77d2cab
Add modes text to groups tooltip 2023-01-22 01:36:53 -03:00
Joseph Madamba
da03abc812 Fix comment editor text boxes not having sound feedback 2023-01-21 17:32:42 -08:00
Dean Herbert
4916a742d5 Immediately focus the textbox when clicking to reply to a comment 2023-01-19 16:08:27 +09:00
Dean Herbert
81e6c3792c Remove unused method 2023-01-19 16:03:46 +09:00
Dean Herbert
07af18b8a7 Remove ReplyCommentEditor into its own class 2023-01-19 16:01:37 +09:00