9380 Commits

Author	SHA1	Message	Date
Dean Herbert	db37de45ac	Allow saving changes to presets in popover using "select" binding	2023-07-13 17:53:26 +09:00
Dean Herbert	f5c472c0fe	Don't hide mod select overlay when pressing select binding with no search	2023-07-13 17:50:07 +09:00
Dean Herbert	94201579f6	Update design of "revert to default" button ... I keep getting feedback that the old design looked like anything *but* a button to revert defaults. Including people clicking it expecting opposite behaviour. This is intended to be a temporary design until we get the full new UI components online (where this is moved to the right-hand-side).	2023-07-13 14:26:03 +09:00
Dean Herbert	1bfe5a18cb	Rename RestoreDefaultValueButton to RevertToDefaultButton ... Because I can't find it every time I search.	2023-07-13 13:46:50 +09:00
Susko3	2dcd790442	Resolve Clipboard via DI	2023-07-11 11:42:31 +02:00
Bartłomiej Dach	6453ab6049	Set chat text box message length limit based on channel	2023-07-09 21:42:13 +02:00
Bartłomiej Dach	e2aaef6663	Merge branch 'master' into no-dismiss-all-progress-notifications	2023-07-08 14:19:57 +02:00
Bartłomiej Dach	cdaf8e4b0f	Flip and rename CompletedOrCancelled to Ongoing	2023-07-08 14:11:58 +02:00
Bartłomiej Dach	3a9b259f8a	Add back removed .ToUpper() case transform	2023-07-08 14:10:05 +02:00
Dean Herbert	0049f3fed4	Merge branch 'master' into more-notification-sounds	2023-07-07 16:39:31 +09:00
Dean Herbert	d72765b6f8	Merge pull request #24114 from peppy/editor-save-local-score-management ... Ensure scores always have the correct linked `BeatmapInfo`	2023-07-07 15:40:54 +09:00
Dean Herbert	d93548f4ea	Add back "clear all" button for progress notifications but only clear cancelled	2023-07-07 13:18:23 +09:00
Dean Herbert	ddd65f5fe7	Merge pull request #24135 from peppy/update-realm ... Bring realm library up-to-date	2023-07-07 10:59:38 +09:00
Bartłomiej Dach	ae2896ba7e	Sprinkle some more null-forgiving operators	2023-07-06 22:08:48 +02:00
Jamie Taylor	a55ba963a9	Don't play 'popout' sample when ProgressNotification completes	2023-07-07 01:51:58 +09:00
Jamie Taylor	d4f5d0c878	Revert "Remove sound from notification closing/hiding" ... This reverts commit 244f3c6098bb27b66f5ff7fb8c76f38f56cfb4cd.	2023-07-07 01:51:57 +09:00
Jamie Taylor	6e2b7f433b	Add a sound for 'cancelling' ProgessNotification	2023-07-07 01:51:57 +09:00
Jamie Taylor	4ff4c3a12e	Remove sound from notification closing/hiding	2023-07-07 01:51:57 +09:00
Jamie Taylor	fdb572fdea	Add more/different notification sounds	2023-07-07 01:51:57 +09:00
Dean Herbert	070b3883ce	Remove the ability to cancel all "in progress" tasks	2023-07-07 00:31:32 +09:00
Dean Herbert	c9fd435402	Fix potential crash when mashing exit key	2023-07-06 17:58:36 +09:00
Dean Herbert	a98a36872e	Bring realm library up-to-date	2023-07-06 13:37:43 +09:00
Dean Herbert	9ff6b3fcd3	Merge branch 'master' into editor-save-local-score-management	2023-07-06 12:28:44 +09:00
Dean Herbert	95a9b532df	Remember state of replay settings visibility	2023-07-06 00:53:37 +09:00
Bartłomiej Dach	e2ddcb2349	Silence a few remaining nullability warnings	2023-07-04 22:39:26 +02:00
Dean Herbert	664294cef4	Fix cancelled progress notifications requiring exit confirmation	2023-07-04 18:39:19 +09:00
Bartłomiej Dach	7b3cb5b410	Merge pull request #24068 from peppy/fix-sign-out-string ... Use more correct localised string source for "sign out" text	2023-07-02 19:20:24 +02:00
Dean Herbert	95c30fe12a	Duplicate sign out string for now	2023-07-03 00:14:26 +09:00
Dean Herbert	5f880397a9	Increase the minimum size of the scroll bar ... Allows easier targetting when there is a lot of content in the scroll view As discussed in https://github.com/ppy/osu/discussions/24095#discussioncomment-6332398.	2023-07-02 00:04:56 +09:00
Dean Herbert	34f53965c4	Never remove significant digits from stsar rating displays ... Closes https://github.com/ppy/osu/issues/24079.	2023-06-29 13:55:04 +09:00
Dean Herbert	b3f2a3ccdf	Use more correct localised string source for "sign out" text	2023-06-28 12:11:40 +09:00
Dean Herbert	1abce098b4	Apply nullability to login form related classes	2023-06-26 13:26:07 +09:00
Dean Herbert	372cef3c0a	Merge branch 'master' into ui-login-spacing-fix	2023-06-26 13:24:26 +09:00
Dean Herbert	8d2dccbda5	Remove pointless zero opacity specification	2023-06-26 13:19:07 +09:00
Dean Herbert	55ab27c5b6	Merge pull request #24022 from frenzibyte/fix-open-user-profile-argument ... Fix `OpenUserProfile` links having multiple argument types	2023-06-26 13:13:05 +09:00
Joseph Madamba	5477ef6bfb	Remove unused usings	2023-06-25 12:58:51 -07:00
Joseph Madamba	ccc4d16096	Remove most custom styling of user dropdown	2023-06-25 12:46:00 -07:00
Joseph Madamba	6ebc2581c2	Normalise login overlay padding/spacing	2023-06-25 12:26:01 -07:00
Joseph Madamba	671f84e32b	Remove unnecessary container	2023-06-25 12:15:03 -07:00
Joseph Madamba	4582faee79	Refactor login panel to not inherit FillFlowContainer	2023-06-25 12:06:02 -07:00
Joseph Madamba	4a3b8c405e	Fix login error text adding unnecessary spacing	2023-06-25 11:57:17 -07:00
Joseph Madamba	442fda3598	Remove using aliases	2023-06-25 11:39:33 -07:00
Joseph Madamba	1058f434d7	Update login overlay background to conform to other overlays	2023-06-25 11:39:32 -07:00
Joseph Madamba	f87ac3f405	Merge remote-tracking branch 'upstream/master' into pr/23331	2023-06-25 10:01:32 -07:00
Bartłomiej Dach	4215ca313f	Add missing using	2023-06-25 14:36:21 +02:00
Dean Herbert	95e8dd2e8e	Don't attempt to access notifications before loaded ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-06-25 21:25:07 +09:00
Bartłomiej Dach	a7202721ff	Merge branch 'master' into no-confirmation-on-update-restart	2023-06-25 13:35:21 +02:00
Salman Ahmed	9a5f033a0f	Change OpenUserProfile argument type to always use IUser	2023-06-24 18:12:35 +03:00
Bartłomiej Dach	e3a89a6273	Fix remaining obvious CI inspections	2023-06-24 16:07:01 +02:00
Bartłomiej Dach	8fdd599b39	Match field NRT annotation in ctor argument	2023-06-24 15:17:14 +02:00
Bartłomiej Dach	354e85a2e1	Trim redundant BDL nullability spec	2023-06-24 14:35:23 +02:00
Dean Herbert	2bda63c2c8	Merge branch 'master' into mass-nrt	2023-06-24 09:59:15 +09:00
Salman Ahmed	c5771912db	Merge branch 'master' into tournament-chatcolor	2023-06-23 22:23:33 +03:00
Salman Ahmed	7a771609f9	Reword and fix typo	2023-06-23 22:20:25 +03:00
Dean Herbert	df5b389629	Manual fixes to reduce warnings to zero	2023-06-24 01:52:53 +09:00
Dean Herbert	0ab0c52ad5	Automated pass	2023-06-24 01:00:03 +09:00
Dean Herbert	1dc7c05c12	Merge branch 'master' into no-confirmation-on-update-restart	2023-06-23 15:33:01 +09:00
Dean Herbert	7fa07805b0	Expose all notifications from INotificationOverlay ... Also fixes `HasOngoingOperations` not actually working.	2023-06-23 15:19:21 +09:00
Dean Herbert	11a97e1bb8	Move confirmation bypass implementation to MainMenu to allow for more correct logic	2023-06-23 14:42:56 +09:00
Dean Herbert	343271751a	Add Schedule to ensure correct thread for UI code	2023-06-23 14:07:33 +09:00
Dean Herbert	ce1579f2fe	Bind to API.State instead of API.User	2023-06-23 14:05:02 +09:00
Bartłomiej Dach	c06b825d9b	Merge branch 'master' into comment-logged-out	2023-06-22 23:19:00 +02:00
Bartłomiej Dach	786deec296	Rename and xmldoc members	2023-06-22 23:00:52 +02:00
Bartłomiej Dach	0ce4d17e30	Merge pull request #23888 from peppy/fix-intro-playing-twice ... Fix music sometimes restarting twice if exiting song select with no beatmap selected	2023-06-22 22:49:15 +02:00
Bartłomiej Dach	a11b3a67fb	Merge branch 'master' into skin-editor-beatmap-skin-disable	2023-06-22 20:30:51 +02:00
Bartłomiej Dach	aea5eb37dc	Remove unused using directive	2023-06-22 20:24:44 +02:00
Dean Herbert	59b1f08d53	Don't require exit confirmation when there are no ongoing operations that could be interrupted	2023-06-21 19:06:28 +09:00
Dean Herbert	c3f772f0da	Add method to queue a restart after app is exited (when supported)	2023-06-21 19:06:28 +09:00
Dean Herbert	cb0f642ad7	Change skin editor flow to always save on toggle ... This also moves the beatmap skin disable toggle to on toggle, in line with review feedback. I've decided to always apply the disable, not just on the `Player` screen. It should be assumed that if a user is in the skin editor they are never going to need access to this anyway.	2023-06-21 16:14:47 +09:00
Dean Herbert	366dd96875	Use bindable lease instead of reimplementing the same thing locally	2023-06-21 16:09:54 +09:00
Liam DeVoe	cc764afe3e	use two separate buttons for posting / login	2023-06-21 00:58:43 -04:00
Liam DeVoe	8460873e61	move commitButton.Text update to appropriate method	2023-06-21 00:37:54 -04:00
Dean Herbert	d7b486e2ac	Disable beatmap skinning when entering the skin editor	2023-06-20 19:18:17 +09:00
Dean Herbert	2e02b4a85b	Apply more correct fix for double-playing menu track	2023-06-20 18:35:51 +09:00
Dean Herbert	7b69b92eab	Allow notifications while the game is paused (or in break time) ... RFC. This is to allow notifications to show at the pause screen (specifically for #23967, where exports are now happening). Not sure about the break time part of this, but might be fine? The toasts are immediately flushed before break time ends.	2023-06-20 16:57:35 +09:00
Liam DeVoe	60eedbafd1	rename GetTextBoxPlaceholder to GetPlaceholderText	2023-06-19 22:05:18 -04:00
Liam DeVoe	f7dde53f9b	use runOnceImmediately instead of duplicating logic	2023-06-19 18:20:16 -04:00
Liam DeVoe	591277e0f9	extract button text properties to methods, show login overlay on click	2023-06-19 18:10:37 -04:00
Liam DeVoe	d5d494f07b	resolve protected API in comments superclass	2023-06-19 17:36:40 -04:00
Liam DeVoe	4a9543092a	disable posting comments when logged out	2023-06-19 17:08:04 -04:00
Joseph Madamba	362fe62b4b	Fix beatmap info not showing individual difficulty bpm	2023-06-19 11:05:29 -07:00
Bartłomiej Dach	ee08ed414c	Document DrawableChatUsername members	2023-06-18 18:46:49 +02:00
Bartłomiej Dach	a2a9823d84	Rename constant	2023-06-18 18:46:49 +02:00
Bartłomiej Dach	dad32817ee	Improve UsernameColour documentation	2023-06-18 18:46:49 +02:00
Bartłomiej Dach	bd174b5193	Revert to non-bindable AccentColour ... Not necessary for now, so let's not incur unnecessary overheads.	2023-06-18 18:46:49 +02:00
Dean Herbert	db445660e7	Avoid resolving realm Live more than once	2023-06-19 01:06:45 +09:00
Dean Herbert	425d3c23f5	Fix some code layout and NRT some classes	2023-06-19 01:03:43 +09:00
Bartłomiej Dach	b4c1266fc5	Add TODO for future support of typical search shortcuts	2023-06-18 15:58:50 +02:00
Bartłomiej Dach	b87acfa66f	Dynamically change placeholder to convey how to activate search	2023-06-18 15:58:50 +02:00
Bartłomiej Dach	75300ca229	Switch search box to initially unfocused ... Done primarily to keep mod hotkeys working without any behavioural changes when mod select is opened.	2023-06-18 15:58:50 +02:00
Bartłomiej Dach	9ba4bf5fb7	Merge branch 'master' into add-mod-search-option	2023-06-18 15:06:21 +02:00
Bartłomiej Dach	d4c9eb013e	Fix bugged initial state of matching filter flag ... Was preventing mod preset panels from refiltering correctly on ruleset change due to the `matchingFilter == value` guard.	2023-06-18 14:51:52 +02:00
Bartłomiej Dach	a49af06e88	Reword comments in ModSelectOverlay	2023-06-18 14:34:33 +02:00
Bartłomiej Dach	28f929dc4d	Remove yet another redundant guard	2023-06-18 14:28:26 +02:00
Bartłomiej Dach	4c78144d10	Remove obvious comment	2023-06-18 14:04:00 +02:00
Bartłomiej Dach	64e96c6d82	Fix duplicate linq and reword comment	2023-06-18 14:03:26 +02:00
Bartłomiej Dach	a1015b4145	Remove duplicated xmldoc and move into relevant region	2023-06-18 13:59:36 +02:00
Bartłomiej Dach	1b4d7db1e6	Remove redundant guard ... `Bindable` has one of those already.	2023-06-18 13:58:25 +02:00
Bartłomiej Dach	c7e8990576	Remove unused property	2023-06-18 13:58:25 +02:00
Bartłomiej Dach	62f01e4f40	Rename ModState members to better convey what's what	2023-06-18 13:58:25 +02:00
Dean Herbert	eb31fdecee	Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change ... See https://github.com/ppy/osu-framework/pull/5834	2023-06-18 20:57:32 +09:00
Joseph Madamba	9ae864c219	Fix beatmap info length tooltip not showing actual drain length	2023-06-17 15:00:32 -07:00
Dean Herbert	ce41ef6e5d	Move OrderByTotalScore() to an extension method	2023-06-16 15:24:30 +09:00
Joseph Madamba	45e67fbe78	Remove unused load dependency	2023-06-14 08:09:03 -07:00
Joseph Madamba	b54f3a2cba	Normalise source strings to sentence case ... The casing of the "caps lock" tooltip wasn't changed in code, as tooltips should be ideally sentence-cased, see https://github.com/ppy/osu/pull/21765#issuecomment-1552378930.	2023-06-14 07:58:55 -07:00
Joseph Madamba	8cecfef2ff	Apply key renaming suggestions	2023-06-14 07:40:26 -07:00
Joseph Madamba	ed95fb5982	Revert blocking password requirement text localisation	2023-06-14 07:30:46 -07:00
Joseph Madamba	874ce4fe71	Merge remote-tracking branch 'upstream/master' into pr/22239	2023-06-14 07:06:55 -07:00
cdwcgt	432b5e2d25	move Inverted and color logic to ChatLine	2023-06-13 15:56:25 +09:00
Dean Herbert	4cdd4561c4	Add a few more search keywords for offset settings ... https://github.com/ppy/osu/discussions/23898#discussioncomment-6159206	2023-06-13 14:17:32 +09:00
Bartłomiej Dach	af3fbdbfbe	Merge pull request #23829 from Joehuu/truncating-text-tooltips ... Add tooltips to truncated text	2023-06-12 23:43:31 +02:00
cdwcgt	27b99ea923	use { get; init; }	2023-06-13 01:11:19 +09:00
cdwcgt	430938fbb2	allow custom username color for chatLine ... user's color (e.g. green for NAT) will be ignore	2023-06-12 22:07:36 +09:00
Cootz	aece548db1	Merge branch 'master' into add-mod-search-option	2023-06-12 13:09:09 +03:00
Dean Herbert	99f93f5185	Add comment mentioning why ShowTooltip is disabled in mod select panels	2023-06-12 15:31:22 +09:00
Dean Herbert	1e774fc017	Refactor implementation to roughly match existing HoverSampleDebounceComponent	2023-06-12 14:35:15 +09:00
Cootz	4819a28791	Move mod overlay statics to SessionStatics	2023-06-11 13:53:17 +03:00
Joseph Madamba	0d51e4f6ce	Fix mod select panels having conflicting tooltips ... Going simple with a bool instead of making `TooltipText` init-able, as the current cases will just init `string.Empty`. And not sure if we want custom tooltip text in the future.	2023-06-10 12:24:58 -07:00
Joseph Madamba	61a9c6fd7e	Disable Truncate in OsuSpriteText ... Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>	2023-06-10 11:53:45 -07:00
Cootz	502193e1c6	Use debounce constant for select/deselect animation	2023-06-10 13:55:37 +03:00
Cootz	31f370ec9b	Add comments for ModSelectOverlayStatics	2023-06-10 13:50:45 +03:00
Cootz	09cd5580e1	Add sample playback time restrictions	2023-06-10 13:13:34 +03:00
Cootz	9224486ec7	Add mod select overlay statics	2023-06-10 12:38:26 +03:00
Cootz	d219b5f77f	Reword change focus comment	2023-06-09 17:10:13 +03:00
Cootz	7697dbe4b3	Mod panel don't play sound when hidden	2023-06-09 16:55:19 +03:00
Cootz	036479dd9d	Merge branch 'master' into add-mod-search-option	2023-06-09 16:27:18 +03:00
Cootz	c3b50e1309	Move the multiplier back to TopRight	2023-06-09 16:25:04 +03:00
Joseph Madamba	85fedbd025	Add tooltips to truncated text	2023-06-08 19:44:07 -07:00
Joseph Madamba	519923e843	Remove redundant EllipsisString assign	2023-06-08 19:43:52 -07:00
Bartłomiej Dach	281aae91ec	Merge pull request #23808 from peppy/working-beatmap-get-background ... Refactor `IWorkingBeatmap.Background` to `GetBackground()`	2023-06-08 12:23:07 +02:00
Bartłomiej Dach	5162f5c3d8	Fix code quality inspections	2023-06-08 09:20:43 +02:00
Dean Herbert	a842f79ad4	Refactor IWorkingBeatmap.Background to GetBackground()	2023-06-08 16:19:32 +09:00
Bartłomiej Dach	b3ce7f7b43	Merge branch 'master' into fix-section-container-scroll-attempt-2	2023-06-08 09:19:26 +02:00
Salman Ahmed	d523785bfc	Fix LanguageSettings requiring OsuGame as dependency	2023-06-08 03:27:23 +03:00
Salman Ahmed	1a90f71540	Centralise game language update logic	2023-06-08 02:59:34 +03:00
Dean Herbert	7d49f5d7c6	Apply NRT to SectionsContainer	2023-06-07 16:32:29 +09:00
Salman Ahmed	f23ada1a3f	Merge branch 'master' into disable-in-game-chat-reports	2023-06-07 09:52:46 +03:00
Salman Ahmed	62cb6a98ca	Remove redundant nullable suppression directives	2023-06-07 08:20:41 +03:00
Dean Herbert	30f17d5869	Disabling reporting users from in-game chat ... Addresses #23684. Safer alternative to #23698.	2023-06-07 14:03:06 +09:00
Cootz	ba7069df34	Fix SelectAllModsButton state doesn’t update when search term changed	2023-06-06 16:12:31 +03:00
Cootz	71e6f80c40	Add hotkey for switching search bar focus	2023-06-05 15:54:19 +03:00
Cootz	3ebc801484	Move (de)select all mods hotkeys handling to ModSelectOverlay	2023-06-05 13:49:07 +03:00
Cootz	a46f5b90d4	Move focus handling into PopIn	2023-06-04 18:11:44 +03:00
Cootz	32b9e6ec8f	Make search bar active by default	2023-06-04 17:02:46 +03:00
Cootz	69b640a185	Remove hotkeys handling from DeselectAllModsButton	2023-06-03 10:47:48 +03:00
Cootz	9d4ba5d64a	Remove unnecessary null checks	2023-06-02 12:00:03 +03:00
Cootz	4c7cca101e	Rename IsValid to Visible	2023-06-02 11:33:38 +03:00
Cootz	d400387329	Replace IConditionalFilterable with IFilterable	2023-06-02 10:51:33 +03:00
Cootz	325c114c1c	Remove redundant xmldocs	2023-06-02 10:39:27 +03:00
Cootz	39489358fa	Apply appearance animation to aboveColumnsContent	2023-06-01 14:07:05 +03:00
Cootz	5a1c3aeb7e	Fix SearchTerm set causing infinite loop	2023-05-31 19:36:42 +03:00
Dean Herbert	e35623df22	Update to use new Filter method and remove silly ForcedSearchTerm	2023-05-30 13:40:59 +09:00
Cootz	22c6d6c526	Prevent checkbox from toggle on when column have no valid panels	2023-05-29 14:22:40 +03:00
Cootz	e43c233b48	Reword ForcedSearchTerm xmldoc	2023-05-28 13:21:41 +03:00
Cootz	0e5c99b760	Fix search bar showing incorrectly	2023-05-28 13:12:57 +03:00
Cootz	5ff023113f	Update xmldoc for ForcedSearchTerm	2023-05-28 10:04:26 +03:00
Bartłomiej Dach	6392c2007c	Merge pull request #23637 from peppy/add-shadow-settings-notifications ... Add shadow to notifications and settings overlays to better distinguish from other overlays	2023-05-24 21:34:14 +02:00
Dean Herbert	e5451d1d79	Centralise definition of overlay shadow opacity and reduce slightly	2023-05-24 12:40:35 +09:00
Dean Herbert	02d8e3a11e	Mark FullscreenOverlay's shadow effect as Hollow to save on shader overhead	2023-05-23 18:50:14 +09:00
Dean Herbert	6f4e2b37ed	Add shadow to notifications and settings overlays to better distinguish from other overlays	2023-05-23 18:50:14 +09:00
Dean Herbert	adf9a596b5	Fix weird state when attempting to enter gameplay skin editor scene from multiplayer ... Closes https://github.com/ppy/osu/issues/23626.	2023-05-23 17:58:44 +09:00
Cootz	c3f06ad2db	Merge branch 'master' into add-mod-search-option	2023-05-23 08:55:57 +03:00
Dean Herbert	09c66bea8f	Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area ... Fix clicking area of news sidebar post links	2023-05-22 14:17:08 +09:00
Joseph Madamba	7392109bce	Apply same behavioral changes to NewsCard	2023-05-21 19:28:12 -07:00
Joseph Madamba	2279aad360	Apply NRT to NewsCard	2023-05-21 19:27:20 -07:00
Dean Herbert	b3527b92b6	Handle case in tests where current display becomes null	2023-05-22 09:25:44 +09:00
Bartłomiej Dach	6df1d29862	Merge branch 'master' into use-atomic-ReplaceRange	2023-05-21 20:32:59 +02:00
Joseph Madamba	88c112612f	Remove hardcoded website url ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-21 10:35:22 -07:00
Cootz	67bf1b4dfe	Select/deselect first visible mod when GlobalAction.Select is triggered	2023-05-21 11:05:01 +03:00
Joseph Madamba	8aefb62532	Rename PostButton to PostLink	2023-05-20 16:38:56 -07:00
Joseph Madamba	ec5f0bbf42	Fix clicking area of news sidebar post links ... Side effect is that the hover color is yellow and pressing it opens an external dialog, but those are temporary (pending implementation of link underline to make `Light1` hover more readable and set at a higher level and news pages).	2023-05-20 16:32:04 -07:00
Dean Herbert	79e1d978e7	Ensure scroll-to-top button is displayed above all overlay content	2023-05-17 15:42:38 +09:00
Susko3	fec47fa690	Merge branch 'master' into use-atomic-ReplaceRange ... This reverts 0dcf1b540e	2023-05-17 06:56:54 +02:00
Susko3	2d7fe68311	Prevent feedback by using atomic .ReplaceRange() ... `display.NewValue` will never be null, checked on SDL + osuTK/Android. On Android it's a 0x0 display, importantly not null.	2023-05-16 21:57:31 +02:00
Bartłomiej Dach	0dcf1b540e	Attempt to preserve old resolution when switching displays	2023-05-16 21:14:09 +02:00
Bartłomiej Dach	88ce627c8e	Avoid bindable/event feedback when changing resolution	2023-05-16 21:02:23 +02:00
Cootz	6647d95ea7	Kill search focus when clicking on ModColumn	2023-05-14 18:32:16 +03:00
Dean Herbert	c0f869e685	Fix some tablet settings being hidden when searching using "area" keyword ... As discussed in https://github.com/ppy/osu/discussions/23504.	2023-05-12 14:57:56 +09:00
tsrk	2d45d602a5	feat(settings): more keyword for first run setup	2023-05-11 15:03:42 +01:00
tsrk	c1a85658b7	feat(settings): add "import" as keywords for first run setup	2023-05-11 14:58:17 +01:00
Cootz	ca68850730	fix formatting	2023-05-10 19:43:58 +03:00
Cootz	2467813d81	Block deselect all short key when using the search box	2023-05-09 16:14:42 +03:00
Bartłomiej Dach	2177dbf42a	Merge pull request #23436 from peppy/fix-wiki-error-return-to-main ... Fix "Return to main page" link not working on wiki after error	2023-05-08 21:56:29 +02:00
Dan Balasescu	d2380bd840	Remove usages of [ExcludeFromDynamicCompile]	2023-05-08 18:12:56 +09:00
Dean Herbert	715b735131	Fix "Return to main page" link not working on wiki after error	2023-05-08 15:29:05 +09:00
Cootz	60bad35145	Remove weird update usage when 'deselect all' pressed	2023-05-07 15:34:01 +03:00
Cootz	4d235105d1	Convert ModSearchContainer to block-scoped namespace	2023-05-07 15:14:49 +03:00
Bartłomiej Dach	65b4b198a4	Merge branch 'master' into export	2023-05-06 20:12:53 +02:00
Bartłomiej Dach	3942281d13	Fix back-to-front logic	2023-05-06 15:34:55 +02:00
Bartłomiej Dach	80ac8abaa6	Merge branch 'master' into chat-report	2023-05-06 15:30:44 +02:00
Bartłomiej Dach	1da5e69d5a	Fix API success callback scheduling to dead drawable	2023-05-06 15:27:27 +02:00
Bartłomiej Dach	6b4050ea52	Remove invalid report reason (and add osu-web references)	2023-05-06 15:01:57 +02:00
Bartłomiej Dach	52e5835be6	Document and retouch ReportPopover	2023-05-06 14:52:38 +02:00
Cootz	cbb9f0100e	Update PopIn and PopOut filtering. Expose SearchTerm	2023-05-06 11:27:06 +03:00
Cootz	a226caff56	Fix testing	2023-05-06 11:09:44 +03:00
Cootz	7422b5285c	Fix wrong filtering in testing	2023-05-05 22:41:30 +03:00
Cootz	ab94b4dce1	Update ModPresetPanel.FilterTerms to account mod names and acronyms	2023-05-05 09:52:09 +03:00
Cootz	54757df51f	Fix mod deselect button not working properly when search applied	2023-05-05 09:31:27 +03:00
Dean Herbert	8391e2a538	Move reporting code out of DrawableChatUsername into more correct locations	2023-05-05 14:03:42 +09:00
Bartłomiej Dach	bdd96caaa9	Merge branch 'master' into edit-mods-preset	2023-05-04 18:59:47 +02:00
Cootz	1ac9d900e1	Clear search on ModSelectOverlay.Hide	2023-05-04 19:24:37 +03:00
Dean Herbert	0034124d79	Remove unnecessary content clear	2023-05-04 11:25:10 +09:00
Dean Herbert	26b8c5b852	Fix mod list display not updating after clicking "use current" ... This is not a regression from my changes. It was broken before them.	2023-05-04 11:23:51 +09:00
Dean Herbert	49fb5da1a2	Stop passing preset panel to popover	2023-05-04 11:19:09 +09:00
Dean Herbert	b12d139317	Remove dead code	2023-05-04 11:16:52 +09:00
Dean Herbert	99d2616c34	Move drawable construction to load for simplicity	2023-05-04 11:14:51 +09:00
Dean Herbert	be995f1359	Add localisation support for new button string	2023-05-04 11:11:19 +09:00
Dean Herbert	b7abab6d8a	More variable improvements	2023-05-04 11:10:05 +09:00
Dean Herbert	0a584f0652	Simplify check logic and improve variable naming	2023-05-04 11:07:09 +09:00
Bartłomiej Dach	59ece64d25	Merge branch 'master' into skin-editor-change-handler-improvement	2023-05-03 19:42:42 +02:00
Bartłomiej Dach	1d4d31e35c	Trim comments ... Leaving only the ones that add anything useful and do not restate the code verbatim.	2023-05-03 19:22:52 +02:00
Bartłomiej Dach	27fabd99fb	Rename variables for legibility ... Having `typedComponents` and `typeComponents` next to each other is asking for trouble.	2023-05-03 19:21:16 +02:00
cdwcgt	4549a865d9	Merge branch 'master' into export	2023-05-04 00:18:01 +09:00
cdwcgt	967e801f9c	code inspect	2023-05-03 23:26:58 +09:00
cdwcgt	debbd376bd	move scrollContent update logic to updateActiveState()	2023-05-03 23:24:14 +09:00
cdwcgt	f4b1264cc9	use button Enable status to ensure preset name is not null	2023-05-03 23:22:46 +09:00
cdwcgt	aa5a026c67	remove local button handle	2023-05-03 23:14:24 +09:00
cdwcgt	c609e6345c	remove Use Current Mods menu item	2023-05-03 23:02:50 +09:00
Cootz	152d2678d5	Fix ModSelectColumn completely disappear from ModSelectOverlay	2023-05-03 14:00:46 +03:00
Dean Herbert	be15d07b17	Tidy up various implementation details	2023-05-03 18:59:39 +09:00
Dean Herbert	b932e4d986	Rename DrawableUsername to DrawableChatUsername and only pass message ID	2023-05-03 18:53:22 +09:00
Dean Herbert	4f55afb60d	Merge branch 'master' into chat-report	2023-05-03 18:50:38 +09:00
Joseph Madamba	1c74f6e8ea	Fix regressed button hover fade in	2023-05-02 22:54:42 -07:00
Joseph Madamba	bede1292de	Fix overlay scroll back button not absorbing hover from behind	2023-05-02 22:40:37 -07:00
Dean Herbert	e394b487e0	Merge branch 'master' into edit-mods-preset	2023-05-03 12:06:16 +09:00
Cootz	a6ca049739	Manually implement @bdach prototype	2023-05-02 14:15:33 +03:00
Dean Herbert	4a97c2c105	Merge pull request #23038 from cdwcgt/scale-background-dim ... Add feature to adjust `ScalingContainer` background dim	2023-05-02 15:36:52 +09:00
Dean Herbert	ce4a6c38a0	Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight ... Fix now playing playlist not highlighting selected item on initial open	2023-05-02 15:36:34 +09:00
Dean Herbert	ab4f66fad3	Minor readability refactors	2023-05-02 14:31:39 +09:00
Dean Herbert	7a840e1d82	Remove unnecessary TransferValue spec	2023-05-02 14:29:26 +09:00
Dean Herbert	7efaa299bd	Merge branch 'master' into scale-background-dim	2023-05-02 14:24:54 +09:00
Dean Herbert	736be6a73b	Refactor slightly for readability	2023-05-02 14:11:16 +09:00
Dean Herbert	e808e7316b	Mark delegate value unused and add comment to avoid future regression	2023-05-02 13:29:30 +09:00
Terochi	4d52ce769b	Revert SaveState() calling on initialization	2023-05-01 12:53:58 +02:00
Bartłomiej Dach	7cedbca9be	Merge branch 'master' into multiplier-doesnt-update-with-preset-mod	2023-04-30 17:36:00 +02:00
Bartłomiej Dach	2e3daf0a54	Fix leak of ModSettingChangeTracker instances ... The `SelectedMods.BindValueChanged()` callback in `ModSelectOverlay` can in some instances run recursively. This is most heavily leaned on in scenarios where `SelectedMods` is updated by an external component. In such cases, the mod select overlay needs to replace the mod instances received externally with mod instances which it owns, so that the changes made on the overlay can propagate outwards. This in particular means that prior to this commit, it was possible to encounter the following scenario: modSettingChangeTracker?.Dispose(); updateFromExternalSelection(); // mutates SelectedMods to perform the replacement // therefore causing a recursive call modSettingChangeTracker?.Dispose(); // inner call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); // outer call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); This leaks one `modSettingChangeTracker` instance from the inner call, which is never disposed. To avoid this, move the disposal to the same side of the recursion that the creation happens on, changing the call pattern to: updateFromExternalSelection(); // mutates SelectedMods to perform the replacement // therefore causing a recursive call modSettingChangeTracker?.Dispose(); // inner call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); modSettingChangeTracker?.Dispose(); // outer call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); which, while slightly wasteful, does not cause any leaks. The solution is definitely suboptimal, but addressing this properly would entail a major rewrite of the mod instance management in the mods overlay, which is probably not the wisest move to make right now.	2023-04-30 17:31:41 +02:00
Terochi	fb4b681cc5	Use Queue instead of Stack	2023-04-30 16:36:01 +02:00
Terochi	8f02bd80f9	Addressed changes	2023-04-30 16:11:52 +02:00
Terochi	949dc1c0f9	Improved logic	2023-04-30 12:05:55 +02:00
Terochi	8ec2154965	Fixed ApplyStateChange to happen in correct order	2023-04-30 02:01:18 +02:00
Terochi	17e4b75dfd	Save first state when editing	2023-04-29 20:54:19 +02:00
Terochi	3b0ba4b38b	Improved logic for ApplyStateChange for skin editor	2023-04-29 19:52:22 +02:00
Bartłomiej Dach	646d4965b9	Merge branch 'master' into fix-exclusive-fullscreen-detection	2023-04-29 14:39:34 +02:00
_ltn	2d6c0d2900	use of Child instead of Children	2023-04-28 19:24:07 +03:00
Dean Herbert	6929be49b7	Change condition for exclusive fullscreen notice to only show when using the correct renderer ... This avoids the notice showing when running on windows, but using the newer renderers (where the underlying logic hasn't been tested properly and can result in false-positives). Supersedes https://github.com/ppy/osu-framework/pull/5759 as a more correct implementation.	2023-04-28 22:36:30 +09:00
Ethan	ae85e2a3ff	Update LoginForm.cs	2023-04-28 19:51:10 +08:00
_ltn	4b0ee392f6	add OsuHoverContainer	2023-04-28 05:48:54 +03:00
_ltn	17730f05bc	remove UpdateableCountryText	2023-04-28 05:47:05 +03:00
_ltn	4d144cd5b5	clearing the code	2023-04-28 02:06:13 +03:00
_ltn	092377fdaa	moving UpdateableCountryText	2023-04-28 01:47:14 +03:00
_ltn	e9843f2066	replace country text object	2023-04-28 01:16:50 +03:00
Cootz	b795e8ac5a	Use ModSearch in ModeSelectOverlay	2023-04-27 17:26:35 +03:00
Cootz	3c6141f233	Add ModSearch	2023-04-27 17:08:29 +03:00
Hy0tic	56ab029a58	fix issue where multipler does not update when adjusting speed for preset mod	2023-04-22 13:30:08 -04:00
Joseph Madamba	776c4cfaad	Ensure selected field is correct in updateSelectionState() ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-04-19 18:34:35 -07:00
Dean Herbert	52c4703261	Merge pull request #23103 from Joehuu/normalise-overlay-padding ... Normalise horizontal padding on overlays	2023-04-10 23:48:59 +09:00
Bartłomiej Dach	1f2c96c8e8	Merge branch 'master' into gd-onlinesetoverlay	2023-04-10 15:35:03 +02:00
Bartłomiej Dach	11fd93a2ba	Inline disturbing getGuestMapper() method ... Disturbing because name suggests pure method, but it is in fact `void` and also performs side effects by about the most confusing means possible.	2023-04-10 15:20:43 +02:00
cdwcgt	ce6a87b4a3	Merge remote-tracking branch 'upstream/master' into export	2023-04-09 15:02:47 +09:00
cdwcgt	de21b4a2f7	use Live<TModel> ... Use RealmAccess only when needed	2023-04-09 22:21:15 +09:00
Joseph Madamba	a86a968fac	Use public BeatmapSet to match other usages	2023-04-07 21:16:36 -07:00
Joseph Madamba	ed208ef127	Fix more typos and adjust font size to match web	2023-04-07 21:10:37 -07:00
Bartłomiej Dach	b5d9284de2	Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer ... Fix attempting to show overlay during game intro playing hide sound effects	2023-04-03 20:48:03 +02:00
cdwcgt	9dd30e4b4c	condition fix	2023-04-03 20:24:38 +09:00
cdwcgt	735b48679e	use LinkFlowContainer directly	2023-04-03 20:09:49 +09:00
cdwcgt	41c01d3929	nullable condition	2023-04-03 20:07:21 +09:00
cdwcgt	51240ed46b	typo	2023-04-03 19:51:22 +09:00
Dean Herbert	43d7386623	Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting ... Fix beatmap listing sort direction not resetting when changing criteria	2023-04-03 15:32:10 +09:00
Dean Herbert	e4eb736622	Merge pull request #22929 from Joehuu/fix-loading-blocking-overlay-headers ... Fix beatmap listing filter control being blocked by loading layer	2023-04-03 15:29:38 +09:00
Dean Herbert	a097433cb1	Fix overlay toggle keys working during disabled activation modes ... Closes #23104.	2023-04-03 15:03:47 +09:00
Joseph Madamba	247d426c8a	Add horizontal padding to currently playing search textbox	2023-04-02 20:50:18 -07:00
Joseph Madamba	436f1e4ae4	Replace other hardcoded horizontal padding with const ... - Also add overlay stream item padding const and account for it	2023-04-02 20:50:18 -07:00
Joseph Madamba	af389b1107	Replace all hardcoded 50 horizontal padding with const	2023-04-02 20:50:18 -07:00
Joseph Madamba	7a0edabd5d	Normalise overlay horizontal padding const	2023-04-02 20:24:13 -07:00
Joseph Madamba	63ea17f10e	Update comment vote pill in line with web	2023-04-02 18:17:40 -07:00
Susko3	c3a6a58169	Fix window mode dropdown not showing	2023-04-02 19:23:18 +02:00
cdwcgt	d949ef3ca4	make guestMapperContainer private ... tests don't use it	2023-04-02 22:53:15 +09:00
cdwcgt	2cf8636366	show guest diff author in BeatmapPicker	2023-04-02 22:25:58 +09:00
Dean Herbert	4c2b7e7788	Fix random inspection showing up only in CI	2023-04-02 21:05:20 +09:00
Dean Herbert	cf5acbf66e	Update usage of SupportedWindowModes	2023-04-02 20:16:14 +09:00
cdwcgt	5d395e6d37	move to ctor	2023-03-29 22:59:54 +09:00
cdwcgt	e85c28031e	change weird name	2023-03-29 22:55:25 +09:00
cdwcgt	46ede27869	add feature to adjust ScalingContainer background dim	2023-03-28 22:41:24 +09:00
cdwcgt	31df626f0e	disable button when select other reason	2023-03-28 21:32:28 +09:00
cdwcgt	899860dd77	Merge branch 'master' into chat-report	2023-03-28 21:14:11 +09:00
Dean Herbert	8c1df3c8d9	Fix web account registration not bypassing the URL warning	2023-03-28 15:38:19 +09:00
cdwcgt	b065689cf8	Limit the area of popover to DrawableChannel ... popover may be blocked by textBar	2023-03-27 23:04:45 +09:00
Dean Herbert	898717231b	Hide vulkan renderer option for now ... We'll bring it back when it's more stable.	2023-03-27 02:00:10 +09:00
Bartłomiej Dach	292486c25a	Use more resilient restore method	2023-03-26 14:35:00 +02:00
Bartłomiej Dach	f3c174a7f2	Fix test errors due to missing dependencies	2023-03-26 13:52:26 +02:00
Dean Herbert	bab93bed17	Fix string interpolation and use GetDescription on renderer value	2023-03-26 20:43:28 +09:00
Dean Herbert	ba078e8357	Show "automatic" resolved renderer inline in dropdown instead	2023-03-26 20:29:30 +09:00
Dean Herbert	764361b3d3	Add special case to hide definitely non-working renderers on android	2023-03-26 20:14:33 +09:00
Dean Herbert	e346b02ebf	Add display of current renderer	2023-03-26 20:09:35 +09:00
Joseph Madamba	eaef5ff2a3	Fix now playing playlist not highlighting selected item on initial open	2023-03-25 22:13:51 -07:00
Joseph Madamba	450c5cef07	Add comment explaining loading container padding	2023-03-24 18:42:34 -07:00
Dean Herbert	ab6cfea5c7	Revert old value instead of always using default ... Co-authored-by: cdwcgt <loginchen@outlook.com>	2023-03-23 11:27:05 +09:00
cdwcgt	85a924f078	why ... merge problem?	2023-03-23 01:02:17 +09:00
cdwcgt	8518d15b8d	use endpoint	2023-03-23 01:00:38 +09:00
Dean Herbert	3050a16bf8	Don't require a restart when selecting Automatic and startup setting was also automatic	2023-03-22 16:56:36 +09:00