Dean Herbert
58df6930b2
Get error message from server
2019-11-12 19:34:20 +09:00
Dean Herbert
f04d7f733f
Merge remote-tracking branch 'upstream/master' into favourite-beatmap
2019-11-12 19:19:29 +09:00
Andrei Zavatski
a69a4643c9
Simplify LINQ expressions
2019-11-12 08:45:21 +03:00
Andrei Zavatski
0578f91a76
Small logic adjustments
2019-11-11 19:06:46 +03:00
Andrei Zavatski
c5b64e26a3
Layout adjustment
2019-11-11 18:51:29 +03:00
Andrei Zavatski
5f5d130d1a
Update mod filter visibility on user change
2019-11-11 18:40:57 +03:00
Andrei Zavatski
31191dadf1
Handle mods change
2019-11-11 18:31:42 +03:00
Andrei Zavatski
2cfd54ca0d
Handle scope changing
2019-11-11 18:27:48 +03:00
Andrei Zavatski
00b9229737
Add mod filter to beatmap overlay
2019-11-11 18:21:07 +03:00
Andrei Zavatski
32b2f5e330
Use Bindable for ScoresContainer
2019-11-11 18:10:25 +03:00
Andrei Zavatski
3655f88180
Merge dependency
2019-11-11 17:56:57 +03:00
Andrei Zavatski
93954c8da0
Use BindableList for selected mods
2019-11-10 23:58:07 +03:00
Andrei Zavatski
e3d8e29cdd
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-11-10 23:38:41 +03:00
Dean Herbert
ce19b2ed36
Avoid using CreateChildDependencies with a *child* bindable
...
Don't do this.
2019-10-31 17:16:26 +09:00
Dean Herbert
3e3ff81229
Reorder methods
2019-10-31 17:13:00 +09:00
Dean Herbert
4f04abf282
Fix tabs to match design (should not show pinhair line)
2019-10-31 16:54:28 +09:00
Dean Herbert
5d47a2e557
Merge branch 'master' into add-beatmap-ruleset-selector
2019-10-31 16:42:32 +09:00
Dean Herbert
bf45fa6309
Use lambda function expression
2019-10-31 16:24:03 +09:00
Dean Herbert
f8187fa301
Don't rely on masking for bar display
2019-10-31 16:23:10 +09:00
Andrei Zavatski
2dac3a6efe
Handle hitting the maximum allowed number of favourited beatmaps
2019-10-16 13:58:29 +03:00
iiSaLMaN
60133ba0c3
Propagate BeatmapSetInfo to tab items with bindable
2019-10-15 23:33:50 +03:00
Andrei Zavatski
a7dc9bb582
Add tooltip and remove pink layer
2019-10-07 15:41:05 +03:00
Andrei Zavatski
2d707b2b65
Implement PostBeatmapFavouriteRequest
2019-10-07 15:36:23 +03:00
iiSaLMaN
ba1a854701
Use IEnumerable.Where<>() rather than List.FindAll()
...
Saves a whole list allocation
2019-10-05 10:30:32 +03:00
iiSaLMaN
6985249d90
Simplify properties
2019-10-04 21:18:03 +03:00
iiSaLMaN
0c4f248259
Fix CI issues
2019-10-04 18:02:13 +03:00
iiSaLMaN
555c82e9c9
Filter beatmap difficulties by current ruleset
2019-10-04 17:56:42 +03:00
iiSaLMaN
7d5f5d2fd9
Add ruleset selector to the beatmap overlay header
2019-10-04 17:55:33 +03:00
iiSaLMaN
7b414092af
Implement beatmap ruleset selector
2019-10-04 17:35:41 +03:00
Andrei Zavatski
e7118a9272
Use System mod type for NoMod
2019-09-20 23:47:21 +03:00
Andrei Zavatski
0cf4db899f
Few cleanups
2019-09-19 17:03:52 +03:00
Andrei Zavatski
529a1c3b91
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-09-19 16:46:58 +03:00
Dean Herbert
43d7615734
Merge remote-tracking branch 'upstream/master' into rankings-scope-selector
2019-09-13 14:07:39 +09:00
Joehu
77ac186cf8
Add spacing to mod icons on leaderboards
2019-09-11 16:08:01 -07:00
Andrei Zavatski
03bd7ca8e7
Implement RankingsScopeSelector
2019-09-10 04:20:32 +03:00
Andrei Zavatski
65869c7ebb
Refactor LeaderboardScopeSelector for more extensibility
2019-09-10 04:04:37 +03:00
Dean Herbert
91e3eeb1c0
Merge branch 'master' into beatmap-mod-selector
2019-09-02 21:35:42 +09:00
Dean Herbert
d4c12881f5
Remove unnecessary over-complication and fix transitions
2019-09-02 13:45:13 +09:00
Dean Herbert
6603cbd74d
No language doesn't mean "Other"
2019-09-02 13:41:14 +09:00
StanR
c1c1c7874b
Nullcheck
2019-08-29 13:25:05 +03:00
StanR
68ee7346b2
Remove usings
2019-08-29 12:49:44 +03:00
StanR
d303083179
Update to match api
2019-08-29 12:29:31 +03:00
StanR
3347ee8170
Merge branch 'master' into beatmapset-genre-language
2019-08-29 09:57:53 +03:00
Dean Herbert
dfdf3f5e96
Merge remote-tracking branch 'upstream/master' into humanizer-fallback
2019-08-28 20:15:32 +09:00
iiSaLMaN
1295ec490f
Fix difficulty icon not wrapping correctly in beatmap set overlay
2019-08-23 17:57:31 +03:00
Dean Herbert
82209aed82
Merge branch 'master' into humanizer-fallback
2019-08-22 17:58:40 +09:00
Dean Herbert
f355cff8bc
Apply reviews
2019-08-15 12:11:54 +09:00
Dean Herbert
bd61642ac6
Merge branch 'master' into beatmap-mod-selector
2019-08-13 00:54:21 +09:00
Dean Herbert
433b701df3
Make line slightly thicker (to display better at low resolutions)
...
Also tidies up code.
2019-08-13 00:21:52 +09:00
Dean Herbert
c0f0fbbaa9
Rename variable and add xmldoc
2019-08-13 00:14:37 +09:00
Andrei Zavatski
1bfb87fcdd
Remove redundant conditional ternary expression
2019-08-12 16:41:35 +03:00
Andrei Zavatski
cf92d6b1b0
Add highlightAll function to avoid duplication
2019-08-12 16:32:04 +03:00
Andrei Zavatski
86c9d5251f
Remove unused function
2019-08-12 16:28:53 +03:00
Andrei Zavatski
b71c776e65
Add web-like hover behavior
2019-08-12 16:20:36 +03:00
Andrei Zavatski
62a91e4aaa
Add the ability to override Highlighted action to the ModIcon
2019-08-12 15:20:21 +03:00
Andrei Zavatski
21af390327
Move binding to LoadComplete
2019-08-12 14:57:16 +03:00
Andrei Zavatski
0070f6b260
Use CompositeDrawable as a parent class
2019-08-12 14:49:08 +03:00
Andrei Zavatski
9c36cb4af4
Use existing AccentColour logic instead of weird BoxColour
2019-08-12 14:33:30 +03:00
Andrei Zavatski
ba49a4c2da
Use existing PageTabControl for layout
2019-08-12 13:16:57 +03:00
Dean Herbert
75cb0d093b
Use description correctly
...
Required for localisation
2019-08-12 16:10:48 +09:00
Andrei Zavatski
87974850dd
Initial implementation
2019-08-07 08:42:43 +03:00
Andrei Zavatski
b064df91a7
Initial implementation
2019-08-07 08:33:55 +03:00
Andrei Zavatski
b9384d7a53
Remove unnecessary null check
2019-08-07 07:00:50 +03:00
Andrei Zavatski
24f9872315
Fix unnecessary scores loading
2019-08-07 06:45:39 +03:00
David Zhao
1956098166
Add a fallback for humanizer localization failure
2019-07-30 14:06:08 +09:00
Dean Herbert
cdf75b4098
Public before private
2019-07-22 22:14:09 +09:00
Andrei Zavatski
075ca3d8ea
CI fix
2019-07-22 14:47:35 +03:00
Andrei Zavatski
3e95cb9145
Use bindable and disable button
2019-07-22 14:35:18 +03:00
Andrei Zavatski
de8ac9a428
Simple implementation
2019-07-21 21:41:07 +03:00
Dean Herbert
2a94b68ecb
Simplify logic
2019-07-20 22:50:17 +09:00
Andrei Zavatski
fa978a47b0
Fix loading animation is no longer present
2019-07-18 15:08:50 +03:00
Joehu
83ffb1d542
Remove unnecessary transforms on top score user section
2019-07-15 14:15:03 -07:00
StanR
1e04fcc6b5
Apply fixes
2019-07-11 17:47:09 +03:00
StanR
cd7c03c13a
Add genre and language sections to beatmapset overlay
2019-07-11 16:44:48 +03:00
Dean Herbert
85f2212ebc
Reduce spacing and font for rank position
2019-07-11 11:32:42 +09:00
Dean Herbert
8f9b8ed5a1
Simplify information propagation logic
2019-07-11 11:17:33 +09:00
Dean Herbert
cc9ee472d6
Move score nulling out of loading property
2019-07-11 11:07:30 +09:00
Dean Herbert
a49bde7ed3
Move protected below public
2019-07-11 10:38:32 +09:00
Andrei Zavatski
953d32366c
Move request inside the ScoresContainer again
2019-07-10 19:40:29 +03:00
Dean Herbert
2285c2b1df
Merge branch 'master' into user-best-score
2019-07-11 00:31:26 +09:00
iiSaLMaN
c3315e805f
Use milliseconds for BasicStats' beatmap length
2019-07-10 16:49:32 +03:00
Andrei Zavatski
a0389c338b
CI fixes
2019-07-09 17:56:08 +03:00
Andrei Zavatski
9907a58ec4
Revert animations and apply suggested changes
2019-07-09 17:38:17 +03:00
Andrei Zavatski
e8b9b1b0bf
visibility logic adjustments
2019-07-09 12:16:58 +03:00
Andrei Zavatski
8d6af1625a
Visibility improvements
2019-07-09 11:40:51 +03:00
Andrei Zavatski
8d46d4a28e
Fix grade layout
2019-07-09 08:09:31 +03:00
Andrei Zavatski
5d81445454
Move api request outside the scores container
2019-07-09 08:05:34 +03:00
Andrei Zavatski
1e5639acee
Add forgotten symbol
2019-07-08 12:10:08 +03:00
Andrei Zavatski
67a6abb96c
Add user top score on selected beatmap
2019-07-08 11:49:33 +03:00
iiSaLMaN
90d5484818
Return BPM back to OnlineInfo
...
Revert commit of "Move BPM out of OnlineInfo"
2019-07-08 09:10:41 +03:00
iiSaLMaN
729f0901f7
Move Length out of OnlineInfo
2019-07-07 20:25:36 +03:00
iiSaLMaN
3ea9629daf
Move BPM out of OnlineInfo
2019-07-07 20:11:44 +03:00
Dean Herbert
23acddcb56
Rename download buttons to avoid ambiguity
2019-07-03 12:02:35 +09:00
Dean Herbert
3294464bc6
Fix typo in variable
2019-06-27 12:47:05 +09:00
Dean Herbert
a5ccfeb18e
Remove unnecessary fill flow
2019-06-27 12:34:22 +09:00
Dean Herbert
be901294f7
Simplify text layout
2019-06-27 12:33:14 +09:00
Dean Herbert
32c3bee71b
Avoid public exposure
2019-06-27 12:11:04 +09:00
Dean Herbert
cc9a7839c9
Fix layout regression
2019-06-27 12:04:01 +09:00
Dean Herbert
375a6f406d
Merge remote-tracking branch 'upstream/master' into not-available-to-download
2019-06-27 11:44:41 +09:00
Dean Herbert
322d92d3e0
Rename class to BeatmapAvailability
2019-06-27 11:40:22 +09:00
iiSaLMaN
9ada4d68b1
Make fields protected and expose them in tests
2019-06-26 22:42:34 +03:00
naoey
f3a84de7b5
Merge remote-tracking branch 'upstream/master' into generic-download-tracking-composite
2019-06-26 18:17:53 +05:30
Salman Ahmed
eaf6f6891d
Rename to DownloadButtonsContainer
2019-06-26 05:22:08 +03:00
Salman Ahmed
f4e765cf99
Merge branch 'master' into not-available-to-download
2019-06-26 05:13:58 +03:00
Dean Herbert
ba2f22be47
Improve loading state of BeatmapSet header
2019-06-25 14:47:29 +09:00
HoLLy
739077ef4f
Only hide UpdateableAvatar/Flag immediately
2019-06-24 18:24:31 +02:00
HoLLy
aed83471f4
Replace Reset with overridden TransformImmediately/TransformDuration
2019-06-24 10:51:45 +02:00
HoLLy
fafec00667
Reset top score avatar before updating it
2019-06-21 16:47:19 +02:00
iiSaLMaN
0cc7a604ed
Update font sizes
2019-06-21 14:18:20 +03:00
iiSaLMaN
a1c58b164c
Merge branch 'master' into not-available-to-download
2019-06-21 14:16:31 +03:00
Dan Balasescu
c79c4641f3
Merge branch 'master' into use-modelbackeddrawable
2019-06-21 14:26:07 +09:00
KingLuigi4932
13578e5c21
Add the null conditional operator back
2019-06-20 19:43:31 +03:00
KingLuigi4932
d754819453
Small changes
2019-06-20 19:09:40 +03:00
Dean Herbert
7482ecb8e7
Fix beatmap set cover goes out of its container ( #5073 )
...
Fix beatmap set cover goes out of its container
2019-06-20 11:21:22 +09:00
Andrei Zavatski
0da8a483c5
Fix scores header is visible even if no scores are loaded
2019-06-19 23:14:53 +03:00
iiSaLMaN
ee2268caba
Enable masking for the beatmap set cover
2019-06-19 21:20:00 +03:00
KingLuigi4932
5f5441c692
Add ShowPlaceholderOnNull in updateable flag + do not show placeholders in some overlays
2019-06-19 20:17:02 +03:00
KingLuigi4932
9f25d3cd72
More changes and improvements
2019-06-19 17:55:36 +03:00
iiSaLMaN
3e285e5dde
Separate beatmap info container from details (avoid overlapping)
2019-06-19 17:47:47 +03:00
iiSaLMaN
15229f3a23
Make header expandable
2019-06-19 17:45:39 +03:00
KingLuigi4932
a6c268ef5c
Move the horizontal margin into the sprite text itself
2019-06-19 15:05:53 +03:00
KingLuigi4932
475b40cc02
Remove empty line
2019-06-19 14:47:29 +03:00
KingLuigi4932
4600336581
Use TextFlowContainer + small changes
2019-06-19 14:43:18 +03:00
KingLuigi4932
6e28294182
Fix another test
2019-06-19 04:27:31 +03:00
KingLuigi4932
3876442143
More simplifies + fix test
2019-06-19 03:37:08 +03:00
KingLuigi4932
a0609f28d7
Revert some changes + simplify BeatmapNotAvailable
2019-06-19 01:43:28 +03:00
iiSaLMaN
5278c5f365
Merge branch 'master' into not-available-to-download
2019-06-19 01:14:32 +03:00
KingLuigi4932
d6a39b8a2a
Fix CI issues + slight change
2019-06-17 22:33:27 +03:00
KingLuigi4932
fec0db8fe1
Merge UpdateableAvatar.cs and Avatar.cs + Rename Avatar to DrawableAvatar
2019-06-17 21:55:07 +03:00
KingLuigi4932
d665f1fe4b
Seperate drawable and updateable flag from Country + Use UpdateableFlag
2019-06-17 20:57:57 +03:00
KingLuigi4932
794ba17a2f
Seperate UpdateableRank from DrawableRank and use it
2019-06-17 20:04:09 +03:00
KingLuigi4932
155f7c7e03
Use OsuTextFlowContainer for multi-lines
2019-06-13 17:32:27 +03:00
smoogipoo
39f9deea96
Add success rate test scene
2019-06-13 18:44:00 +09:00
smoogipoo
6b615d763a
Fix potential nullref
2019-06-13 18:43:51 +09:00
smoogipoo
f2b5f274cf
Add details test scene + fix metrics not getting updated correctly
2019-06-13 18:31:39 +09:00
smoogipoo
7af2d650cd
Fix potential nullref
2019-06-13 18:31:12 +09:00
smoogipoo
dd7335079f
Fix beatmap set overlay not showing ratings
2019-06-13 17:01:57 +09:00
smoogipoo
0a79b444d9
Move metrics to beatmap set
2019-06-13 16:52:49 +09:00
KingLuigi4932
1a50544c94
Add tests for undownloadable / parts-removed beatmapsets
2019-06-12 20:42:52 +03:00
KingLuigi4932
744f32ab35
Fix little bug
2019-06-12 19:11:05 +03:00
naoey
ab27d82cd5
Make beatmap download buttons inherit BeatmapDownloadTrackingComposite
...
- Move DownloadTrackingComposite into the online namespace
2019-06-11 23:01:01 +05:30
KingLuigi4932
130ff56886
Move logic into BeatmapNotAvailable
2019-06-11 12:29:42 +03:00
iiSaLMaN
ae284d1127
Merge branch 'master' into not-available-to-download
2019-06-10 21:39:32 +03:00
KingLuigi4932
70fdd4ba5b
Disable download button + Fix AppVeyor Errors
2019-06-10 21:13:37 +03:00
KingLuigi4932
3202110b80
Add a container for Beatmap Availability
2019-06-10 20:17:44 +03:00
iiSaLMaN
dfbc652803
Use ScoreRank.D instead of F
2019-06-08 19:32:26 +03:00
Dan Balasescu
67ac76aae7
Merge branch 'master' into move-tooltip-text
2019-05-21 15:00:09 +09:00
Dean Herbert
4ac2acbfc0
Fix usages of SpriteText (instead of OsuSpriteText)
2019-05-21 14:13:52 +09:00
Dean Herbert
bc962bf8f0
Move TooltipText to OsuClickableContainer
2019-05-21 13:51:38 +09:00
smoogipoo
d7c09e7dbd
Merge remote-tracking branch 'origin/master' into fix-new-inspections
...
# Conflicts:
# osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
# osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
# osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
# osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
# osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
# osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
# osu.Game/Graphics/OsuFont.cs
# osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
# osu.Game/Overlays/Profile/Header/BadgeContainer.cs
# osu.Game/Overlays/Profile/ProfileHeader.cs
# osu.Game/Screens/Select/PlaySongSelect.cs
# osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
smoogipoo
0603ed9ab7
Fix post-merge errors
2019-04-09 16:27:10 +09:00
smoogipoo
772bef91fa
Merge remote-tracking branch 'Joehuu/master' into drawnode-composability
...
# Conflicts:
# osu.Game.Rulesets.Osu/UI/Cursor/OsuCursorContainer.cs
2019-04-08 23:01:12 +09:00
smoogipoo
15fbb6f176
Use common AddUserLink method
2019-04-05 14:15:36 +09:00
smoogipoo
a6bf076dc7
Adjust green colour
2019-04-04 17:58:34 +09:00
smoogipoo
e13fffaca3
Make ScoreTable use TableContainer
2019-04-04 17:53:23 +09:00
Dean Herbert
84da708d44
Fix nullref
2019-04-03 18:46:08 +09:00
Dean Herbert
cb417ebd77
Player -> User
2019-04-03 18:44:19 +09:00
Dean Herbert
a15a9bd03a
Rewrite updateDisplay logic to not fail on some cases
2019-04-03 18:29:46 +09:00
Dean Herbert
5c3c08566f
DrawableTopScore can be composite
2019-04-03 18:20:03 +09:00
smoogipoo
3b7d26cca8
Remove custom styled text
2019-04-03 17:49:01 +09:00
smoogipoo
3da008d293
Add a bit of padding between the sections
2019-04-03 16:43:56 +09:00
smoogipoo
f8596e055a
Separate into multiple files
2019-04-03 16:38:54 +09:00
smoogipoo
42c915190a
Reorder DrawableTopScore
2019-04-03 16:12:24 +09:00
smoogipoo
e246fad301
Clear table if no scores are provided
2019-04-03 16:09:34 +09:00
smoogipoo
2c18b6df1c
Fix score table using 300/100/50
2019-04-03 16:09:19 +09:00
smoogipoo
d6b15f040a
Improve statistics display
2019-04-03 15:57:36 +09:00
smoogipoo
0cf27e244d
Fix usages of SpriteText and obsolete members
2019-04-03 15:44:14 +09:00
smoogipoo
dff58ab4ed
Initial cleanup pass of DrawableTopScore
2019-04-03 15:41:33 +09:00
smoogipoo
7f425059ae
Adjust transforms
2019-04-03 15:41:22 +09:00
smoogipoo
ab4be3b75f
General refactoring
2019-04-03 15:20:38 +09:00
smoogipoo
0d127c21f1
Merge remote-tracking branch 'Aergwyn/master' into update-beatmap-scores-design
2019-04-03 14:52:13 +09:00
Dean Herbert
f1952c0816
Update font awesome usage
2019-04-02 19:55:24 +09:00
smoogipoo
a56e29347f
Adjust namespaces
2019-04-02 14:51:28 +09:00
Dean Herbert
c39c37a18d
Apply more missed cases
2019-04-01 12:44:46 +09:00
smoogipoo
2967c876ea
Merge remote-tracking branch 'origin/master' into update-beatmap-scores-design
...
# Conflicts:
# osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
# osu.Game/Overlays/BeatmapSet/Scores/DrawableScore.cs
# osu.Game/Overlays/BeatmapSet/Scores/DrawableTopScore.cs
# osu.Game/Overlays/BeatmapSet/Scores/ScoresContainer.cs
2019-03-29 15:11:00 +09:00
Dean Herbert
a71e9fdb0e
Merge branch 'master' into convert-ranking-statistics
2019-03-29 12:42:49 +09:00
Dean Herbert
de80fc0eac
Update icon usage to match framework changes
2019-03-27 19:29:27 +09:00
smoogipoo
012dcc25c9
Rename APIScoreInfo -> APILegacyScoreInfo
2019-03-27 17:08:40 +09:00
smoogipoo
7239ebf5de
Add margin for mods
2019-03-27 13:57:26 +09:00
smoogipoo
adab31fd58
Cleanup + fix up score table layout
2019-03-26 17:38:56 +09:00
smoogipoo
f4aeb390ef
Initial re-layout of score table
2019-03-26 10:21:34 +09:00
smoogipoo
f7016e1d2c
Rename DrawableScore
2019-03-20 17:15:38 +09:00
smoogipoo
41d25c7d19
Fix post-merge errors
2019-03-20 17:15:21 +09:00
smoogipoo
ce57bdb8db
Merge branch 'timed-difficulty-attributes' into update-beatmap-scores-design
...
# Conflicts:
# osu.Game/Overlays/BeatmapSet/Scores/ScoresContainer.cs
2019-03-20 17:12:34 +09:00
Dean Herbert
f0114d776d
Use interface to access API
...
Allows for better testability.
2019-03-13 12:58:18 +09:00
smoogipoo
315788c975
Rename a few classes
2019-03-11 15:11:01 +09:00
smoogipoo
9a05643ec9
Minor refactorings
2019-03-08 17:18:54 +09:00
smoogipoo
a40ffcc692
Apply formatting adjustments
2019-03-08 16:44:39 +09:00
smoogipoo
30c6a7c3c5
Merge remote-tracking branch 'nekodex/master' into update-beatmap-scores-design
...
# Conflicts:
# osu.Game.Tests/Visual/TestCaseBeatmapScoresContainer.cs
# osu.Game/Overlays/BeatmapSet/Scores/ClickableUserContainer.cs
# osu.Game/Overlays/BeatmapSet/Scores/DrawableScore.cs
# osu.Game/Overlays/BeatmapSet/Scores/DrawableTopScore.cs
2019-03-07 18:48:23 +09:00
Jamie Taylor
1f273a4c3a
Use local variables where appropriate
2019-02-28 19:58:48 +09:00
Jamie Taylor
b7f7174055
Refactor BeatmapSetOverlay to use chained bindables instead of accessors to distribute changes
2019-02-28 18:46:28 +09:00
Dean Herbert
0788a7e9f1
Merge branch 'master' into more-inspections
2019-02-28 14:32:57 +09:00
Dean Herbert
42be7857d1
Use expression body for property get/set where possible
2019-02-28 13:58:19 +09:00
Dean Herbert
26d53d06a9
Fix remaining issues
2019-02-28 13:31:40 +09:00
Dean Herbert
367bc53a06
Revert some more instances of 'e' variable names
2019-02-22 20:15:25 +09:00
smoogipoo
d61dfe888e
Fix venera fonts not being correctly specified
2019-02-22 19:42:09 +09:00
Dean Herbert
3015d40f8f
Merge branch 'master' into osu-fontusage
2019-02-22 18:09:23 +09:00
Dean Herbert
3fe4b8fd1c
Update variable names
...
Also cleans up some weird code
2019-02-22 17:51:39 +09:00
Dean Herbert
452caabd40
Apply suggestions from code review
...
Co-Authored-By: smoogipoo <1329837+smoogipoo@users.noreply.github.com>
2019-02-22 17:06:49 +09:00
smoogipoo
d8c55bc729
Adjust namespaces
2019-02-21 19:05:52 +09:00
smoogipoo
bca347427f
Update with framework bindable changes
2019-02-21 18:56:34 +09:00
smoogipoo
4db5531e4b
Replace copy-constructor/method with extension method
2019-02-20 19:32:30 +09:00
smoogipoo
dbfa95b9e7
Made medium the default font weight
2019-02-20 16:52:36 +09:00
smoogipoo
a2aa3ec5cb
Adjust sprite texts in-line with framework changes
2019-02-20 15:03:20 +09:00
EVAST9919
4d489da032
small visual improvements
2019-02-10 04:16:56 +03:00
EVAST9919
04e57d7d3d
Refactor to make things more flexible
2019-02-09 06:23:58 +03:00
EVAST9919
105053e91b
TestCase fix
2019-02-09 00:56:41 +03:00
EVAST9919
107e0a5239
Warning fixes
2019-02-08 20:43:11 +03:00
EVAST9919
bd1f4f9549
Small design fixes
2019-02-08 20:35:07 +03:00
EVAST9919
13c154a0b3
Fix background colour and a bug with removing scores
2019-02-08 20:07:21 +03:00
EVAST9919
7a3ae0f479
update drawable score inline with the latest design
2019-02-08 19:50:02 +03:00
EVAST9919
f43ee6b6a3
update drawable top score inline with the latest design
2019-02-08 19:06:46 +03:00
EVAST9919
9cca11fb0d
Warning fixes
2019-02-06 01:48:43 +03:00
EVAST9919
c85dc1a236
update another scores design
2019-02-05 19:32:33 +03:00
EVAST9919
f560dde157
Add some flow for info containers
2019-02-05 15:26:45 +03:00
EVAST9919
559960036e
update top score design
2019-02-05 14:48:35 +03:00
Dean Herbert
0b8bd520ab
Shake in all cases
2019-01-31 19:15:04 +09:00
Dean Herbert
b89694a969
Fix "importing" state display
2019-01-31 19:09:04 +09:00
Dean Herbert
c54a515b3e
Change where BindValueChange is immediately run
2019-01-31 18:49:54 +09:00
Dean Herbert
327a34f12a
Merge remote-tracking branch 'upstream/master' into download-tracking-component
...
# Conflicts:
# osu.Game/Beatmaps/Drawables/BeatmapSetDownloader.cs
2019-01-31 18:45:09 +09:00
Dean Herbert
8617aaa2a7
Update licence header (and remove year)
2019-01-24 17:43:03 +09:00
Dean Herbert
7d6d7cf457
Merge remote-tracking branch 'upstream/master' into download-tracking-component
...
# Conflicts:
# osu.Game/Overlays/BeatmapSet/Buttons/DownloadButton.cs
2019-01-23 11:06:29 +09:00
Dean Herbert
09553550a3
Remove remaining supporter check
2019-01-23 00:19:39 +09:00
Dean Herbert
21e79f51b1
Remove necessity of BeatmapSetDownloader
2019-01-18 14:28:06 +09:00
Dean Herbert
8848fa8b1b
Improve UX of download buttons on beatmap set overlay
2019-01-18 12:04:49 +09:00
Dean Herbert
b62630ecd2
Centralise download tracking logic so we can show it in multiple scenarios
2019-01-18 11:28:10 +09:00
Dean Herbert
e3308010c0
Merge pull request #3898 from peppy/leaderboard-modularity
...
Leaderboard modularity
2018-12-22 15:36:12 +09:00
smoogipoo
e657f13c15
Separate out Leaderboard into BeatmapLeaderboard
2018-12-22 14:44:36 +09:00
smoogipoo
f47ac35522
Add click to avatar
2018-12-22 14:23:53 +09:00
Dean Herbert
831cd3ed59
ScoreInfo scoreInfo -> ScoreInfo score
2018-11-30 15:18:52 +09:00
smoogipoo
219929eb47
Score -> ScoreInfo
2018-11-28 18:33:01 +09:00
smoogipoo
5fd6e6ca77
Re-namespacing
2018-11-28 16:12:57 +09:00
smoogipoo
f27bd3ef3e
OpenTK -> osuTK
2018-11-20 17:14:59 +09:00
ekrctb
99fc04c8af
Change signature to new event handler
2018-10-02 12:02:47 +09:00
Dean Herbert
37f3035437
Merge remote-tracking branch 'upstream/master' into update-framework
2018-09-20 18:39:48 +09:00
smoogipoo
7b8094d731
Move text size/padding out of constructor
2018-09-20 12:53:45 +09:00
ekrctb
b790e16217
Use Click instead of now removed TriggerOnClick
2018-09-19 11:42:32 +09:00
Dean Herbert
ccd7c1a17d
Cancel request on disposal for safety
2018-09-06 17:04:33 +09:00
Dean Herbert
923acfbeaf
Fix some web requests being run after disposal of their owner
2018-09-05 10:26:54 +09:00
smoogipoo
ec31028f14
Add tooltip
2018-07-31 14:50:57 +09:00
smoogipoo
70338e087a
Disable beatmap download button if not supporter
2018-07-31 14:41:31 +09:00
Dean Herbert
0f37758314
Update framework
2018-07-21 16:21:53 +09:00
Dean Herbert
825941aff1
Use switch with type matching in place of if-else where possible
2018-07-17 14:35:09 +09:00
naoey
2a0b1f3615
Update direct panel download button for new design
...
- Add a download failed event to BeatmapManager
- Make DownloadButton aware of all 3 possible download states
- Change button appearance based on each state
2018-07-03 20:18:09 +05:30
smoogipoo
b2066c5d73
Rework preview tracks to reduce usage complexities
2018-06-21 18:40:27 +09:00
Dan Balasescu
126678c226
Merge branch 'master' into multiple_previews_different_overlays
2018-06-12 19:26:51 +09:00
Dan Balasescu
7de8e1cfc4
Merge branch 'master' into refactor-api
2018-06-11 18:49:15 +09:00
Roman Kapustin
8702a70524
Resolve merge conflicts in DirectOverlay
2018-06-08 21:03:16 +03:00
Dean Herbert
8cc31aca54
Reorganise API requests and response classes
...
They were previously breaking the two-class-per-file rule.
2018-06-08 11:42:35 +09:00
DrabWeb
0fae49ee21
Don't add a 'with Video' subtitle.
2018-06-07 20:47:27 -03:00
Dean Herbert
2e23da1dfa
Merge branch 'master' into beatmap-set-downloader
2018-06-06 20:32:58 +09:00
DrabWeb
188272e15d
Replace OnAlreadyDownloading with returning a bool from Download.
2018-06-06 03:18:42 -03:00
DrabWeb
df4c855aa2
Manage subtitle inside of DownloadButton.
2018-06-06 03:13:37 -03:00
Dean Herbert
00c8d2ff11
Merge branch 'master' into source-link-colour
2018-06-06 08:27:28 +09:00
DrabWeb
61e1358410
Add OnAlreadyDownloading animations.
2018-06-04 21:07:17 -03:00
DrabWeb
01c5060bcf
Move BeatmapSetDownloader to osu.Game.Beatmaps.Drawables
2018-06-04 20:30:54 -03:00
DrabWeb
9377ffb784
Update BeatmapSetOverlay to use BeatmapSetDownloader.
2018-06-04 20:27:34 -03:00
Joehu
7101533926
Remove 'description' field
2018-06-03 08:02:57 -07:00
Joehu
5c713ac2ab
Use default colour in MetadataSection
2018-06-03 07:51:57 -07:00
Joehu
dc2a004c87
Remove link colours for all unlinked text
2018-06-02 12:04:58 -07:00
Dean Herbert
8bde1fd327
Merge branch 'master' into updateable-beatmap-set-cover
2018-06-01 15:20:59 +09:00
Joehu
729f2ec725
Match authorinfo with web
2018-05-31 14:34:47 -07:00
Joehu
b4d621a2cb
Add link colour to beatmap source
2018-05-31 10:21:22 -07:00
DrabWeb
6781b81336
Cleanup.
2018-05-31 05:48:42 -03:00
DrabWeb
bdfb5752cd
Update existing drawables to use UpdateableBeatmapSetCover.
2018-05-28 19:31:20 -03:00
Roman Kapustin
572c3f5189
Stop preview playback when an overlay is popping out
2018-05-25 23:51:05 +03:00
Roman Kapustin
a24589f583
Cleanup external PlayButton.Playing usage
2018-05-25 22:35:15 +03:00
Dean Herbert
1cb7d50407
Add and use default size (smaller than before)
2018-05-25 18:51:57 +09:00
Roman Kapustin
498244a308
Introduce PreviewTrack class
2018-05-25 00:37:53 +03:00
jorolf
b324337fa1
Add icon next to beatmap title/username to open in browser
2018-05-22 15:29:52 +02:00
Dean Herbert
1be2571d33
Make BeatmapSetOverlay accept nulls everywhere
2018-04-18 16:08:45 +09:00
Dean Herbert
32a74f95a5
Normalize all the line endings
2018-04-13 18:26:38 +09:00
TocoToucan
9acea6eab0
Order beatmap difficulty icons correctly
2018-04-12 19:33:30 +03:00
smoogipoo
b97c4e8b44
Fix all possible cases of crossthread import data races
2018-04-09 12:45:44 +09:00
DrabWeb
eb374c5774
Add beatmap set online status and display it in direct panels and the beatmap set overlay.
2018-03-26 21:04:45 -03:00
Dean Herbert
d340509b1d
Move ArchiveReaders to a more global namespace
...
Also moves delete and action logic to a shared implementation
2018-02-15 14:22:39 +09:00
Aergwyn
56619ae926
use ternary expression
2018-01-18 15:53:53 +01:00
Aergwyn
f86cb30e47
prevent negative width on progress bar
2018-01-17 20:35:28 +01:00
Dean Herbert
37d393bca0
Update licence headers
2018-01-05 20:21:19 +09:00
Aergwyn
ccb69d16d9
move HitResult in Scoring namespace to replace HitCount
2017-12-30 21:23:18 +01:00
Aergwyn
138d78309f
add HitCount enum and replace string usage with enum
2017-12-30 18:07:30 +01:00
Aergwyn
f7fe083018
add tooltip to country flags
2017-12-30 14:59:35 +01:00
Dean Herbert
3c1654e5e4
Fix many instances of non-osu-prefixed text classes being used
...
Results in incorrect default formatting.
2017-12-26 00:44:35 +09:00
Dean Herbert
24b3b10942
Move drawable assignment to load, remove depth overrides
2017-12-07 20:44:55 +09:00
Dean Herbert
8c89354b36
Remove extra whitespace
2017-12-07 20:44:38 +09:00
Santeri
898c49c19d
remove unnecessary assignments
2017-11-28 16:14:32 +02:00
Santeri
e9277d8cb1
last directive error...
2017-11-28 00:27:58 +02:00
Santeri
49949bf698
fix minor param/directive errors
2017-11-28 00:20:44 +02:00
Santeri
86de6f8252
derives from trianglebutton rather than osubutton
2017-11-28 00:09:58 +02:00
Santeri
0a8fa2e6de
Merge branch 'master' into header-button-should-derive
2017-11-27 23:16:42 +02:00
Santeri Nogelainen
96f782e75a
fix object reference issue maybe?
2017-11-27 13:51:56 +02:00
Santeri Nogelainen
bf8d15108e
headerbutton now derives from osubutton
2017-11-27 13:39:01 +02:00
Unknown
f6a33b3ea2
fix osu!direct download reloading all panels
...
This fixes the recreation of all panels when a download completes.
Also fixes NullReference when you download without ever opening the details of one Set.
2017-11-25 14:45:57 +01:00
Dean Herbert
5ea3292dc5
Merge remote-tracking branch 'upstream/master' into load-optimization
2017-11-23 20:21:44 +09:00
Dean Herbert
4986ad73f7
Merge remote-tracking branch 'upstream/master' into load-optimization
2017-11-23 18:44:17 +09:00
Dean Herbert
cf4fc05be3
Fix nullref on disposing BeatmapSetOverlay before load
...
Only affects VisualTests
2017-11-23 17:33:46 +09:00
FreezyLemon
2cc2323791
Style changes (removing newline from before second constructor parameter)
2017-11-23 09:12:23 +01:00
Dean Herbert
6e51664544
Merge branch 'master' into beatmap-overlay-download
2017-11-23 17:11:28 +09:00
FreezyLemon
7d428875b8
Changed LoadWrapper back to DelayedLoadWrapper and fixed the implementation (dependent on framework change, delay now in ctor)
2017-11-22 15:46:04 +01:00
FreezyLemon
bf0184c06d
One more small style fix
2017-11-21 19:34:01 +01:00
FreezyLemon
2203a84300
Small fixes and style corrections
2017-11-21 19:16:44 +01:00
FreezyLemon
870807c265
Switched over to the new LoadWrapper class for all delayed loading.
2017-11-21 16:17:33 +01:00
naoey
97c5956083
Make download buttons disappear instead of closing overlay.
...
- Also unbind event handlers
- Remove unused field
2017-11-16 19:17:22 +05:30
Dean Herbert
62358c0b53
Merge branch 'master' into beatmap_scores
2017-11-16 00:45:17 +09:00
naoey
df53b884ea
Removed unused stuff.
2017-11-15 18:00:19 +05:30
naoey
bbe555dc3c
Pass noVideo flag on...
2017-11-15 17:49:41 +05:30
naoey
5aeeb9aac6
Merge remote-tracking branch 'upstream/master' into beatmap-overlay-download
2017-11-15 17:38:38 +05:30
Dean Herbert
fda810eb8f
Remove scrollability from sub-areas in beatmap overaly
...
The areas that are scrollable inside the beatmap overlay make for a very frustrating experience. Let's disable them for now.
2017-11-15 19:02:56 +09:00
EVAST9919
60a2d84e09
Make the x position depends on the avatar size
2017-11-15 10:43:32 +03:00
EVAST9919
093ebb8b17
Apply suggested changes
2017-11-15 10:21:07 +03:00
Dean Herbert
7dd2720b4b
Merge branch 'master' into beatmap_scores
2017-11-15 13:41:38 +09:00
Dean Herbert
6ef60d0b4e
Merge branch 'master' into beatmap-overlay-scores
2017-11-15 13:18:32 +09:00
EVAST9919
fa6d3f9792
Reduce isLoading calls
2017-11-13 18:49:10 +03:00
EVAST9919
d157e6baf1
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap_scores
2017-11-13 16:02:44 +03:00
Unknown
16e48ed187
Hook up download logic with BeatmapSetOverlay download buttons.
...
- Add noVideo option to DownloadBeatmapSetRequest
- Make Download fire an event with new download instead of returning it
2017-11-12 18:41:10 +05:30
EVAST9919
96e99d996b
Add TestCase
2017-11-12 09:01:13 +03:00
EVAST9919
1792075cf9
Loading animation fix
2017-11-12 07:50:01 +03:00
EVAST9919
7c0b13f9ef
CI fixes and minor visual improvements
2017-11-12 07:31:08 +03:00
EVAST9919
569780d37b
Move Api request outside the scores container itself
2017-11-12 07:05:50 +03:00
EVAST9919
36ac002820
Fix incorrect null check
2017-11-11 18:25:16 +03:00
EVAST9919
74bcc61a67
Fix possible overlapping
2017-11-11 07:51:07 +03:00
EVAST9919
057ada0183
Fix nulls
2017-11-11 07:50:40 +03:00
EVAST9919
944bdc1c25
CI fixes
2017-11-11 07:07:41 +03:00
EVAST9919
5bf756c3c6
Add DrawableTopScore
2017-11-11 06:54:52 +03:00
EVAST9919
3261af5200
Add scores container
2017-11-11 03:46:06 +03:00
EVAST9919
c2f3971188
Extend Beatmap Set Response
2017-11-10 03:01:11 +03:00
EVAST9919
b8b5c67cd2
Apply suggestion concerning the BeatmapSetType enum
2017-11-06 21:46:28 +03:00
EVAST9919
ebaef86432
Fix hard crash when opening beatmap with zero playcount in beatmap overlay
2017-11-06 21:28:01 +03:00
Dean Herbert
7bc0ef44f2
Merge branch 'master' into beatmap-preview-fix
2017-10-30 16:22:47 +09:00
Huo Yaoyuan
06fe874594
CI fixes.
2017-10-15 16:53:30 +08:00
Huo Yaoyuan
9b3676c562
Use format string for double instead of Math.Round.
2017-10-15 16:44:15 +08:00
EVAST9919
bd7bc2c0d2
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-preview-fix
2017-10-15 00:14:59 +03:00
EVAST9919
e8f85a08b8
Fix audio preview still playing after closing the beatmap overlay
2017-10-14 05:58:06 +03:00
Dean Herbert
cd722e4abb
Fix beatmap author being stored in two different places
2017-10-14 11:39:55 +09:00
Dean Herbert
abf5418080
Apply some renames and refactoring of loading logic
...
Reduced publicly facing properties where possible. Also fixes a potentially bad state issue when the beatmapset was changed while a load was in progress.
2017-10-13 14:06:34 +09:00
Jorolf
f3ca6cc387
remove redundant stuff
2017-10-06 22:02:33 +02:00
Jorolf
de2181b8f5
Merge branch 'master' of git://github.com/ppy/osu into direct-previews
2017-10-06 21:02:48 +02:00
Jorolf
5a8b8dacbb
move stuff thats duplicated in PreviewButton and DirectPanel to PlayButton
2017-10-06 21:02:00 +02:00
EVAST9919
92c3d722b4
Show mapper's profile when clicking on avatar in BeatmapSetOverlay
2017-09-30 05:41:32 +03:00
Jorolf
2457df8e18
remove unused usings and reset the track to the start when playing again
2017-09-29 23:26:16 +02:00
Jorolf
647304c14b
move logic to DirectPanel and reuse stuff for the PreviewButton
2017-09-29 23:08:30 +02:00
Dean Herbert
5be11f539b
Rename to BeatmapSetOverlay
2017-09-25 17:26:27 +08:00