1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-14 23:37:26 +08:00
Commit Graph

6979 Commits

Author SHA1 Message Date
Davran Dilshat
1aeae2b8c8 reverse ternary operator 2021-08-30 10:11:41 +01:00
Dean Herbert
678386f5c4 Fix missed null coalesce 2021-08-30 16:05:56 +09:00
Dean Herbert
fa2bf42188 Update tooltip implementations 2021-08-30 16:05:00 +09:00
Davran Dilshat
90c313e2ad add methods to get a user from their username 2021-08-29 19:19:55 +01:00
Salman Ahmed
6dc11543ad Handle (null?) PP in PerformanceTable 2021-08-29 17:20:33 +03:00
Salman Ahmed
6aaef7b0be Handle null PP during score set in TopScoreStatisticsSection
Supersedes #14562
Closes #14541
2021-08-29 17:19:17 +03:00
Salman Ahmed
8f3416d853 Assert PP not null when showPerformancePoints is true 2021-08-29 16:03:39 +03:00
Salman Ahmed
e374ef163d Update localisable formattable extensions usages inline with framework change 2021-08-29 15:00:28 +03:00
Joseph Madamba
9a5445bded Fix overlays closing when clicking any empty area of the toolbar instead 2021-08-28 22:25:13 -07:00
Joseph Madamba
38912bfc16 Fix floating overlays not closing when clicking some empty area of the toolbar 2021-08-28 20:38:35 -07:00
Salman Ahmed
589f2863ca Move incompatibility tooltip logic to local player mod select overlays
This one turned out to be a bit more involved, due to tooltips being
shared and having the potential of being used somewhere where it
shouldn't be, due to the same content type matching.

That's the reason I've defined a protected `TargetContentType`, to be
able to separate "local player mod tooltips" and regular mod tooltips
apart.

Definitely unsure about the solution, but that's as far as I can think
of right now.
2021-08-28 02:38:46 +03:00
Salman Ahmed
e527bfd4bf Move incompatibility icon logic to local player mod select overlays 2021-08-28 02:37:46 +03:00
Dan Balasescu
6a916a264f
Merge pull request #14441 from Henry-YSLin/mod-incompatibility-ui
Show mods that are incompatible with the current selection
2021-08-24 16:16:35 +09:00
Dean Herbert
a5f6c287ea Split out pinned comment content to only be constructed when required 2021-08-24 14:43:28 +09:00
Dean Herbert
8cd972a9fe Merge branch 'master' into pinned-comment 2021-08-24 14:37:31 +09:00
Dean Herbert
c3b7ce0b05 Remove stray newline 2021-08-24 14:02:50 +09:00
Dean Herbert
afd01d22d6 Adjust visuals of incompatible icon and move to own class 2021-08-24 14:01:49 +09:00
Dean Herbert
bf0a1167ec Improve update flow and ensure selected mods is read from local context 2021-08-24 13:35:39 +09:00
Dean Herbert
3c9718339c
Merge pull request #14444 from frenzibyte/decouple-ruleset-bindables
Decouple rankings overlay's ruleset selector from the game-wide ruleset bindable
2021-08-24 11:58:13 +09:00
Henry Lin
b8fe03b77f Use Mod.Equals for comparison 2021-08-24 09:50:09 +08:00
Henry Lin
6e3d05c7ce Display an icon to signify incompatibility instead of a red tint 2021-08-24 09:42:53 +08:00
Davran Dilshat
6bea744e34 invalidate scroll position 2021-08-23 17:13:25 +01:00
Salman Ahmed
f8a7e0bdb6 Update rankings overlay ruleset bindable with parent on initial display 2021-08-23 13:50:39 +03:00
Salman Ahmed
d3958eb3fb Revert initial ruleset value logic 2021-08-23 13:28:21 +03:00
Salman Ahmed
f4b69ceb8a Remove unused using embedded in reverted changes 2021-08-23 12:40:20 +03:00
Salman Ahmed
257934a144 Revert "Revert ruleset when not applied filters (includes scope change)"
This reverts commit 9fa39cd34e.
2021-08-23 12:38:30 +03:00
Salman Ahmed
eeeaefbd7d Revert "Store default ruleset value for ability to revert"
This reverts commit cb7c2f713b.
2021-08-23 12:38:24 +03:00
Salman Ahmed
9fa39cd34e Revert ruleset when not applied filters (includes scope change) 2021-08-23 11:11:06 +03:00
Salman Ahmed
cb7c2f713b Store default ruleset value for ability to revert 2021-08-23 11:09:26 +03:00
Salman Ahmed
1d89d757af Fix beatmap ruleset selector selecting initial ruleset 2021-08-23 09:57:05 +03:00
Salman Ahmed
2ba88923b6 Select user preferred ruleset on overlay ruleset selectors initially 2021-08-23 08:58:54 +03:00
Salman Ahmed
45b8bd175c Decouple rankings overlay's ruleset bindable from game-wide bindable 2021-08-22 16:25:35 +03:00
Salman Ahmed
9b1720bd6c Merge branch 'master' into localise-beatmap-set-overlay 2021-08-22 10:53:31 +03:00
Henry Lin
3795030ebb
Merge branch 'master' into mod-incompatibility-ui 2021-08-22 11:14:24 +08:00
Henry Lin
0bbddd297c Remove unused code 2021-08-22 11:05:53 +08:00
Henry Lin
e213562b2a Add a red tint on mods incompatible with the current selection 2021-08-22 11:01:17 +08:00
Henry Lin
ef6faf04be Use FirstOrDefault in TooltipContent 2021-08-22 10:22:18 +08:00
Henry Lin
3d402d9e78 List incompatible mods in tooltip of mod button 2021-08-22 10:13:34 +08:00
Salman Ahmed
216ff07497
Merge branch 'master' into fix-setting-section-clickability 2021-08-21 14:11:55 +03:00
Dean Herbert
ae47c5cdb3 Fix bottom area of a settings section not being clickable 2021-08-21 15:08:42 +09:00
Dean Herbert
36352d1de4 Improve highlighted chat username shadow effect 2021-08-21 14:34:35 +09:00
Dan Balasescu
0a6b678059
Merge branch 'master' into settings-dim-other-sections 2021-08-20 20:22:22 +09:00
Dean Herbert
139ff2d6e2 Only fade header in when hovering a section
Feels less like the controls are interactive when hovering this way.
2021-08-20 17:40:05 +09:00
Dean Herbert
cff7b1e98f Ensure the correct fade level is applied over all state changes 2021-08-20 17:00:08 +09:00
Lucas A
9b4c806855 Apply review suggestions. 2021-08-20 09:47:23 +02:00
Lucas A
0a1c9a6c05 Move DownloadButtonStrings -> CommonStrings 2021-08-20 09:26:38 +02:00
Lucas A
19cc4a14a3 Localise top score mods statistics 2021-08-20 09:22:15 +02:00
Bartłomiej Dach
143b8df1b2
Fix backwards warning text presence check 2021-08-19 22:40:35 +02:00
Lucas A
bf7f0a5d30 Remove double whitespace 2021-08-19 19:02:04 +02:00
Lucas A
ea08d48d27 Remove unecessary localised string due to online view container handling visibility when user is not logged in. 2021-08-18 18:53:35 +02:00
Dean Herbert
6637c64501 Dim all but the current section 2021-08-19 01:27:14 +09:00
Dean Herbert
af0c7ed108 Fix searching in settings not correctly invalidating the scroll position 2021-08-19 01:25:57 +09:00
Dean Herbert
1fdaefef99 Revert unnecessary changes 2021-08-18 12:45:08 +09:00
Dean Herbert
c0b388cd74 Fix regression in ModSettingsChangeTracker 2021-08-17 17:50:30 +09:00
Dean Herbert
1b49e92e99 Merge branch 'master' into settings-delayed-load 2021-08-17 17:42:23 +09:00
Dean Herbert
bc86bafc08 Fix RestoreDefaultValueButton's colour weirdness 2021-08-17 12:48:30 +09:00
Dean Herbert
212842c537 Fix initial LayoutSettings animation in a more reliable way 2021-08-17 12:38:44 +09:00
Dean Herbert
adb4fd5a2b Load only sections content asynchronously, showing the header initially 2021-08-17 12:31:33 +09:00
Dean Herbert
8cba1f197b
Merge branch 'master' into add-supporter-glow-changelog 2021-08-16 23:41:46 +09:00
Dean Herbert
c3a8676932 Simplify size specifications 2021-08-16 23:38:13 +09:00
Dean Herbert
139e69ed3b
Merge pull request #14343 from frenzibyte/hide-tablet-not-detected-when-disabled
Hide tablet settings content when disabled
2021-08-16 23:31:16 +09:00
Dean Herbert
7b74301fa1
Merge pull request #14341 from smoogipoo/fix-preview-track-crash
Fix crashes from preview tracks
2021-08-16 22:21:52 +09:00
Dean Herbert
5f006bd6e8
Merge pull request #14247 from kj415j45/localisation-settings
Add localisation support for most of Settings
2021-08-16 22:20:35 +09:00
Dean Herbert
c978e68742
Merge branch 'master' into add-supporter-glow-changelog 2021-08-16 22:09:52 +09:00
Dean Herbert
7e1086d901 Merge branch 'master' into hide-tablet-not-detected-when-disabled 2021-08-16 22:07:45 +09:00
Dean Herbert
568d027013 Simplify weird conditionals 2021-08-16 22:07:41 +09:00
Lucas A
3325b0cc95 Fix merge conflicts. 2021-08-16 14:50:08 +02:00
Lucas A
a0a9777109 Fix merge conflicts. 2021-08-16 14:50:00 +02:00
Lucas A
1f942d15f8 Localise scoreboard 2021-08-16 13:38:57 +02:00
Dean Herbert
8c3eb91059
Merge branch 'master' into localisation-settings 2021-08-16 20:03:06 +09:00
Dean Herbert
de61cb8e6a Adjust delay slightly 2021-08-16 19:56:20 +09:00
Dean Herbert
e485728109 Add keywords to make finding audio offset adjustments easier in settings 2021-08-16 19:54:45 +09:00
Dean Herbert
230c4eb247 Fade in sidebar buttons after the load has completed 2021-08-16 19:47:41 +09:00
Dean Herbert
c6bd8520a7 Add basic asynchronous loading pattern to SettingsPanel 2021-08-16 19:47:41 +09:00
Dean Herbert
b541550ea9 Avoid initial synchronous dropdown population overhead in AudioDevicesSettings 2021-08-16 19:47:41 +09:00
Dean Herbert
8d051d9fa0 Avoid multiple synchronous overheads in SettingsItem 2021-08-16 19:47:41 +09:00
Dean Herbert
c0130da235 Avoid running initial layout transform in LayoutSettings 2021-08-16 19:47:41 +09:00
Lucas A
7bebbf9f74 Mark format strings as verbatim. 2021-08-16 12:46:41 +02:00
Salman Ahmed
e39a295c5c Hide tablet settings content when input handler is disabled 2021-08-16 13:45:50 +03:00
Dean Herbert
c191b38125 Reduce transform overhead of RestoreDefaultValueButton 2021-08-16 18:55:50 +09:00
smoogipoo
db1a0ebb55 Fix preview track crashes 2021-08-16 18:46:44 +09:00
Dean Herbert
fc89f2bac4 Revert "Rename element in OsuSettings enum"
This reverts commit c2bbe17562.
2021-08-16 16:56:48 +09:00
kj415j45
887d622c28
Merge branch 'master' into localisation-settings 2021-08-16 15:41:50 +08:00
Dan Balasescu
4d31d07c51
Merge branch 'master' into open-tablet-driver-faq 2021-08-16 13:46:43 +09:00
Daniel Kariv
38828b6b82 Updating beatmap details icons
changes the sizing and add yellow circle so the UI will fit more with osu-web style.
2021-08-16 00:40:31 +03:00
Daniel Kariv
f6773522d1 Correct icons in beatmap details
In relation to #13968. Replacing incorrect icons in beatmap details panel to correct ones from BeatmapStatisticsIcon class.
2021-08-16 00:12:27 +03:00
Jacob Van Meter
6472d85aae Added heart_size constant and adjusted the glow radius value
Added heart_size constant and adjusted the glow radius value to be more in line with the website
2021-08-14 21:48:57 -04:00
Jacob Van Meter
71ccd38bb3 Corrected pippi background and promo positioning 2021-08-14 20:36:43 -04:00
Jacob Van Meter
772860232c Removed empty offset and corrected colour 2021-08-14 20:32:38 -04:00
Jacob Van Meter
95943fdb25 Add glow to supporter promo on changelog
Added glow to the supporter promo at the end of the changelog, as it is on the website.
2021-08-14 20:00:26 -04:00
Salman Ahmed
c8fb796660 Fix settings notice text class tinting everything with yellow 2021-08-14 20:14:28 +03:00
kj415j45
c2bbe17562
Rename element in OsuSettings enum
`ShowProgressGraph` -> `ShowDifficultyGraph`
2021-08-14 22:35:15 +08:00
kj415j45
f87f86e671
Apply suggestions from code review
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-08-14 22:24:57 +08:00
kj415j45
e26ccf786e
code style format 2021-08-14 11:04:38 +08:00
kj415j45
5cfb89f18a
Apply suggestions from code review
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2021-08-14 10:56:52 +08:00
Gagah Pangeran Rosfatiputra
9233f396aa
centered thumbtack icon and text 2021-08-14 00:22:01 +07:00
Gagah Pangeran Rosfatiputra
a710bbf6ae
remove background colour for no comment placeholder 2021-08-14 00:03:05 +07:00
Gagah Pangeran Rosfatiputra
6d726bf046
Change spacing
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-08-13 22:54:41 +07:00
Gagah Pangeran Rosfatiputra
cf0e9a1eec
add pinned content section 2021-08-13 19:40:37 +07:00
kj415j45
d527eb3d8b
Apply suggestions from code review
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-08-13 17:15:18 +08:00
Salman Ahmed
f43ab323ff Add shared class for notice text in settings 2021-08-13 11:12:44 +03:00
Dean Herbert
da18c399e2 Remove unnecessary IsPresent override 2021-08-13 16:33:00 +09:00
Dean Herbert
bb36d1614f
Merge branch 'master' into improve-screen-offsetting 2021-08-13 16:23:02 +09:00
Salman Ahmed
cd842ccef8
Improve message
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-08-13 10:15:50 +03:00
Salman Ahmed
543f6039e2 Display on Windows and Linux only 2021-08-13 09:26:53 +03:00
Salman Ahmed
c5ee8753b4 Notify users to read OpenTabletDriver's FAQ when tablet not detected 2021-08-13 09:20:52 +03:00
Gagah Pangeran Rosfatiputra
1859e651b6
add pinned mark in drawable comment 2021-08-13 12:57:30 +07:00
smoogipoo
2850f6ce95 Privatise counter again 2021-08-13 13:24:05 +09:00
smoogipoo
ee034874bb Merge branch 'master' into remove-comments-page 2021-08-13 13:17:13 +09:00
Lucas A
4b4c1448ea Localise success rate metrics. 2021-08-12 19:19:03 +02:00
Lucas A
5f67d991b4 Localise beatmap info. 2021-08-12 19:17:32 +02:00
Dean Herbert
00ca066c39
Merge pull request #14202 from gagahpangeran/changelog-supporter
Add supporter promo section in changelog overlay
2021-08-13 00:33:57 +09:00
Gagah Pangeran Rosfatiputra
66ba24e865
create local link flow container 2021-08-12 20:36:47 +07:00
Gagah Pangeran Rosfatiputra
40db228e91
change to osu text flow container 2021-08-12 19:34:44 +07:00
Dean Herbert
512382987e Add colour provider for multiplayer usage 2021-08-12 19:47:26 +09:00
Gagah Pangeran Rosfatiputra
18684ad21f
remove colour creation in add link 2021-08-12 17:08:54 +07:00
Gagah Pangeran Rosfatiputra
98859b3759
cache pink colour provider
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-08-12 17:06:11 +07:00
Gagah Pangeran Rosfatiputra
8b29f52d9f
update supporter note text
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-08-12 16:54:58 +07:00
kj415j45
ac52b89148
Add Maintenance and Debug SettingsStrings 2021-08-12 12:34:10 +08:00
kj415j45
9d391ad138
Add OnlineSettingsStrings 2021-08-12 12:34:09 +08:00
kj415j45
61502e977a
Add SkinSettingsStrings 2021-08-12 12:34:08 +08:00
kj415j45
31ffaf15d4
Add GameplaySettingsStrings 2021-08-12 12:34:07 +08:00
kj415j45
7adf2bb64c
Add UserInterfaceStrings 2021-08-12 12:34:06 +08:00
kj415j45
03013d0d30
Add InputSettingsStrings
Existed strings files keep no change
2021-08-12 12:34:06 +08:00
kj415j45
b2986e99d3
Add AudioSettingsStrings 2021-08-12 12:34:04 +08:00
kj415j45
078953980e
Add GraphicsSettingsStrings 2021-08-12 12:34:03 +08:00
kj415j45
9a5d4ffd43
Add GeneralSettingsStrings 2021-08-12 12:34:02 +08:00
kj415j45
97041de09f
Preparation for localisation. 2021-08-12 12:34:02 +08:00
Gagah Pangeran Rosfatiputra
fb7ed08bab
move text creation to load method 2021-08-11 12:49:22 +07:00
Gagah Pangeran Rosfatiputra
6d763ca3c7
Merge branch 'master' into changelog-supporter 2021-08-11 10:47:51 +07:00
Gagah Pangeran Rosfatiputra
93408c636b
hide supporter promo section for supporter 2021-08-10 14:56:54 +07:00
Gagah Pangeran Rosfatiputra
3fb2ca4f4a
add border bottom 2021-08-10 14:55:57 +07:00
Gagah Pangeran Rosfatiputra
f7a02219b8
fix font size description 2021-08-10 14:23:15 +07:00
Gagah Pangeran Rosfatiputra
b3fbf52571
add pippi and heart texture 2021-08-10 14:07:20 +07:00
Gagah Pangeran Rosfatiputra
49de8ce1df
fix up some layouting 2021-08-10 13:53:06 +07:00
Gagah Pangeran Rosfatiputra
7c8df57109
add description text 2021-08-10 13:21:23 +07:00
Dean Herbert
3aa72163f2 Add simple download progress display to download buttons on playlist items 2021-08-10 15:14:43 +09:00
Gagah Pangeran Rosfatiputra
a2b4f05ebe
add border radius and shadow 2021-08-10 12:11:21 +07:00
Gagah Pangeran Rosfatiputra
0b41731d0b
initial changelog supporter promo section 2021-08-10 11:43:11 +07:00
Lucas A
bf0d4b6ef1 Localise basic stats. 2021-08-08 19:59:41 +02:00
Salman Ahmed
19a19f915c Adjust settings panel to autosize to zero when hiding it
Previously, when hiding the settings overlay, it remains to have a width
of `56` (sidebar width), this is due to the panel content being placed
next to the sidebar, so therefore the content has to move 400
(PANEL_WIDTH) + 56 (sidebar_width) backwards, for the overlay to have a
width of 0 on hide.
2021-08-07 21:07:08 +03:00
Salman Ahmed
9f3013e2c8 Remove all HorizontalScreenOffset calculations from overlays 2021-08-07 19:30:12 +03:00
Lucas A
fc48696718 Localise detail buttons. 2021-08-07 18:27:55 +02:00
Salman Ahmed
9ac5c9aa2f Fix notification overlay having incorrect initial X 2021-08-07 01:27:54 +03:00
Lucas A
7bbc917f75 Localise beatmap picker. 2021-08-06 23:06:22 +02:00
Salman Ahmed
8dc0650ca7 Add test coverage 2021-08-06 22:56:43 +03:00
Salman Ahmed
ac157f6cef Fix settings panel children not processing transforms while masked away 2021-08-06 22:36:26 +03:00
Salman Ahmed
8e8e0fb8d8 Add placement-dependent horizontal screen offset properties 2021-08-06 18:38:15 +03:00
Salman Ahmed
067ff0e0ad Store last opened settings subpanel rather than relying on LINQ 2021-08-06 18:38:15 +03:00
Jamie Taylor
f1ea830828
Re-add on-click feedback to MonthSection and OsuDropdown headers 2021-08-06 20:58:07 +09:00
Dan Balasescu
5a6636ae5c
Merge pull request #14116 from peppy/update-platform-action-triggers
Update existing test to make use of `ManualInputManager.Keys`
2021-08-04 19:36:39 +09:00
Dean Herbert
9b9dacf3fe Update usages of Drawable.Click() 2021-08-04 17:30:33 +09:00
Gagah Pangeran Rosfatiputra
d22f2ececb
adjust wiki main page font 2021-08-03 22:17:45 +07:00
Dean Herbert
1152e15282 Update new usages of LocalisableEnum 2021-08-03 18:31:59 +09:00
Dean Herbert
8dbcccc350 Merge branch 'master' into localisable-description 2021-08-03 18:29:52 +09:00
kj415j45
404faabbbc
Use direct reference instead 2021-08-03 15:34:21 +08:00
Salman Ahmed
db760b0dbf Merge branch 'master' into localisation-header 2021-08-03 05:16:02 +03:00
Lucas A
73393a5a0d Localise weighting percentage. 2021-07-31 15:56:25 +02:00
Dean Herbert
48b95ae250
Merge pull request #14067 from nekodex/select-sfx-changes
Swap 'select' sample variants and add hover+select sounds to more components
2021-07-31 20:03:08 +09:00
Dean Herbert
858d1f8dd0
Merge pull request #14079 from peppy/fix-timestamp-formatting
Fix beatmap durations over one hour displaying incorrectly
2021-07-31 20:02:54 +09:00
Dean Herbert
081dafc4e4 Update existing inline usages to use new extension method 2021-07-31 16:46:02 +09:00
Dean Herbert
c082498955 Fix some missed instances of verbatim string conversion 2021-07-31 14:29:38 +09:00
Dean Herbert
e6f337a3c8 User verbatim string for ToLocalisableString calls (and rename US spelling) 2021-07-31 14:27:20 +09:00
Salman Ahmed
3409bc6b27 Update mapper usages with LocalisableDescription 2021-07-31 01:47:14 +03:00
Lucas A
c7e9d09ce3 Localise left over numeric value. 2021-07-30 19:08:27 +02:00
Lucas A
652fe6c413 Uppercase sort filter control text. 2021-07-30 19:07:49 +02:00
Lucas A
5381e11880 Revert unintentional change. 2021-07-30 19:06:25 +02:00
Lucas A
8a42d88793 Fix whitespace inspections. 2021-07-30 16:28:18 +02:00
Lucas A
db1ed873e4 Localise ranking tables. 2021-07-30 15:24:10 +02:00
Lucas A
9717281969 Localise rankings Spotlight selector. 2021-07-30 14:53:01 +02:00
Jamie Taylor
9538c4c7f2
Make the news collapsable month sections sound like dropdowns, because they pseudo kinda are 2021-07-30 21:35:28 +09:00
Jamie Taylor
9b7bb37244
Add hover+select sounds to some components that are missing them 2021-07-30 21:35:28 +09:00
Jamie Taylor
c1d8a7e2ad
Add and use 'Submit' select sample variant for particular components 2021-07-30 21:35:28 +09:00
Lucas A
9515a67f57 Localise ranking sort tab control. 2021-07-30 14:35:25 +02:00
Lucas A
fcfa6d5bd1 Localise rankings overlay header. 2021-07-30 14:18:35 +02:00
Bartłomiej Dach
59a33b5d02
Uncouple display logic from text in rankings overlay tables 2021-07-29 22:23:47 +02:00
Henry Lin
89e8296eb1 Reset all types of adjustments in MusicController; Rename AllowRateAdjustments to AllowTrackAdjustments 2021-07-29 15:39:26 +08:00
Bartłomiej Dach
239b38a0ab
Reduce implicit conversions by using default 2021-07-27 21:46:29 +02:00
Lucas A
94877117b9 Apply changes in-line with framework changes. 2021-07-27 18:22:47 +02:00
Gagah Pangeran Rosfatiputra
6631f0de19
add CommentMarkdownHeading 2021-07-26 21:07:35 +07:00
Gagah Pangeran Rosfatiputra
2a6aeb5310
use CommentMarkdownContainer in DrawableContainer 2021-07-26 18:18:55 +07:00
Gagah Pangeran Rosfatiputra
43100c5288
initial CommentMarkdownContainer 2021-07-26 18:18:33 +07:00
Dean Herbert
c8944b62ec Update incorrect linked comment 2021-07-26 17:28:58 +09:00
Dean Herbert
075507648a Show warning for linux as well 2021-07-26 17:28:58 +09:00
Dean Herbert
b70bd7689e Add warning about using high precision mouse on macOS 2021-07-26 17:00:06 +09:00
Dean Herbert
af9f910a12 Change WarningText to accept LocalisableString
Can't work just yet, but best to have the flow in place to maintain 100%
localisation on classes which were already localised.
2021-07-26 16:59:29 +09:00
Dan Balasescu
dbdaddfbcc
Merge pull request #14004 from Joehuu/fix-beatmap-info-mod-overflow
Fix mod selector overflowing from beatmap info overlay
2021-07-25 12:21:29 +09:00
Dan Balasescu
ce30bd8cc7
Merge pull request #14003 from Game4all/localise-profile-overlay-header-stats
Localise profile overlay numeric statistics
2021-07-25 12:20:38 +09:00
Joseph Madamba
f6d4ead32a Fix mod selector overflowing from beatmap info overlay 2021-07-24 15:31:01 -07:00
Lucas A
b0b46eed40
Apply review suggestions.
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-07-24 21:32:26 +02:00
Lucas A
fa68caa892 Fix CI inspections. 2021-07-24 19:34:12 +02:00
Lucas A
eba78317d5 Localise kudosu info stats. 2021-07-24 10:16:47 +02:00
Lucas A
5b55366178 Localise profile header stat buttons. 2021-07-24 10:14:13 +02:00
Lucas A
be26414fe3 Localise user history graph. 2021-07-24 10:13:20 +02:00
Lucas A
6095aa2791 Localise profile line chart. 2021-07-24 10:08:47 +02:00
Lucas A
c92f69467a Localise counter pills. 2021-07-24 10:06:31 +02:00
Lucas A
d23e47c253 Localise level progess bar stats. 2021-07-24 10:03:13 +02:00
Joseph Madamba
dce47917fd Fix ruleset icons overflowing from settings footer 2021-07-23 19:07:54 -07:00
Lucas A
011fad167d Localise rank graph tooltip. 2021-07-23 23:38:31 +02:00
Lucas A
48c21674ed Localise expanded header container. 2021-07-23 23:19:51 +02:00
Lucas A
a3f9d96a8e Localise collapsed header container. 2021-07-23 23:12:22 +02:00
Lucas A
ff3d38de6f Localise accuracy display. 2021-07-23 22:37:08 +02:00
Bartłomiej Dach
b1087d14f3
Merge branch 'master' into skin-editor-button-access 2021-07-22 22:49:44 +02:00
Bartłomiej Dach
986910a7e4
Annotate dependency as possibly-null 2021-07-22 22:43:35 +02:00
Lucas A
00ec229bde Localise stat values according to the current locale. 2021-07-22 19:20:20 +02:00
Dean Herbert
84b67deb4d
Merge pull request #13958 from ByAgenT/refactor-keybindings-overlay
Move and merge Overlays.KeyBinding into Overlays.Settings.Sections.Input
2021-07-22 15:16:04 +09:00
Lucas A
032ced5d16 Localise beatmap explicit content pill. 2021-07-21 13:05:01 +02:00
Dean Herbert
fe9e72d767
Merge pull request #13959 from smoogipoo/fix-beatmaplisting-null-cursor
Fix beatmap listing continually paginating when no more beatmaps are available
2021-07-21 19:55:40 +09:00
ekrctb
1bac471b49 Adapt to PlatformAction type change 2021-07-21 16:12:53 +09:00
smoogipoo
bcd1a3c232 Use existing bool 2021-07-21 16:04:07 +09:00
smoogipoo
0118c3638c Fix beatmap listing continually paginating for null cursors 2021-07-21 15:59:02 +09:00
Anton Kovalyov
bfad044b00
Remove unused imports. 2021-07-20 21:57:55 -07:00
Anton Kovalyov
2b0d530075
Eliminate Overlay.KeyBinding namespace and move everything to Settings.Section.Input 2021-07-20 21:18:24 -07:00
Bartłomiej Dach
1e634d9db0
Adjust user beatmap sections on profile overlay to match web 2021-07-20 21:55:17 +02:00
Dean Herbert
9c4fbf45e9 Add the ability to enter and exit the skin editor via on-screen buttons 2021-07-20 19:36:12 +09:00
Salman Ahmed
51b056bf66 Fix WikiHeader setting string.Empty rather than null on breadcrumb
That's supposed to be fixed already in the base PR, but somehow it
continued to exist here.
2021-07-20 02:37:11 +03:00
Salman Ahmed
456f4e6f1f Move RankingsScope to own file and fix mapper strings 2021-07-20 02:37:11 +03:00
Dean Herbert
e77597c2b6
Merge pull request #13921 from Game4all/localise-profile-overlay
Localise user profile overlay
2021-07-20 00:37:01 +09:00
kj415j45
fe7aa73aad Add localisation for BeatmapSetHeader 2021-07-19 20:45:03 +08:00
kj415j45
48d398b04a Merge 'master' of ppy/osu into localisation-header 2021-07-19 19:46:40 +08:00
kj415j45
765881d8b0 Move strings 2021-07-19 19:27:33 +08:00
kj415j45
57eed88601 symbol renaming
Co-authored-by: frenzibyte <frenzibyte@gmail.com>
2021-07-19 19:27:33 +08:00
kj415j45
5fc1397564 Apply suggestion from code review
Co-authored-by: frenzibyte <frenzibyte@gmail.com>
2021-07-19 19:27:33 +08:00
kj415j45
bf6204f64e Merge https://github.com/kj415j45/osu into localisation-header 2021-07-19 19:24:09 +08:00
Dean Herbert
13cb658d29 Mark identifiers as verbatim strings 2021-07-19 18:15:09 +09:00
Dean Herbert
3c028ce05c Add IDeepCloneable interface and update existing CreateCopy methods to use it 2021-07-19 12:54:17 +09:00
Lucas A
80885301a3 Fix codefactor issues. 2021-07-18 19:36:34 +02:00
Lucas A
9257cd7fad Revert the use of an enum in ProfileHeader. 2021-07-18 19:18:06 +02:00
Lucas A
77807f9e32 Merge branch 'master' into localise-profile-overlay 2021-07-18 19:14:05 +02:00
kj415j45
f80b183777 Add localisation for DashboardOverlayHeader 2021-07-18 02:45:16 +08:00
kj415j45
f588607ed9 Add localisation for BeatmapListingHeader 2021-07-18 02:45:01 +08:00
kj415j45
3b48975f1e Add localisation for RankingOverlayHeader 2021-07-18 02:44:46 +08:00
kj415j45
93e79d122f Move strings together 2021-07-18 02:24:59 +08:00
kj415j45
224c37bdc3 Add localisation for RankingOverlay 2021-07-18 02:24:39 +08:00
kj415j45
53fe61504c Add localisation for ChangelogHeader 2021-07-18 01:35:54 +08:00
kj415j45
1b4bff0d9f Optimize code style
Co-authored-by: frenzibyte <frenzibyte@gmail.com>
Co-authored-by: bdach <dach.bartlomiej@gmail.com>
2021-07-18 01:29:53 +08:00
Lucas A
2c26248042 Localise missing text of PaginatedKudosuHistoryContainer. 2021-07-17 17:36:49 +02:00
Lucas A
28845364a3 Localise score weighting. 2021-07-17 16:52:35 +02:00
Lucas A
77d8f240f8 Use ctor default values. 2021-07-17 16:41:42 +02:00
Lucas A
a7c280508f Throw instead of silently returning. 2021-07-17 16:40:37 +02:00
Lucas A
2545275f71 Partly localise Kudosu section. 2021-07-17 16:29:09 +02:00
Lucas A
148eb890ff Localise Historical section. 2021-07-17 16:24:11 +02:00
Lucas A
2f3ed4a4ab Fix PaginatedProfileSubsection ctor arguments 2021-07-17 16:13:33 +02:00
Lucas A
fbbf8ce5a3 Localise Ranks section. 2021-07-17 15:53:24 +02:00
Lucas A
d17f658985 Localise Recent section. 2021-07-17 15:50:56 +02:00
Lucas A
5bb45c7f84 Localise beatmap section. 2021-07-17 15:45:17 +02:00
Lucas A
d36842aa15 Localise TopHeaderContainer 2021-07-17 15:32:28 +02:00
Lucas A
213e3c0716 Localise DetailHeaderContainer 2021-07-17 15:29:34 +02:00
Lucas A
c6a27e4baa Localise CentreHeaderContainer. 2021-07-17 15:27:40 +02:00
Lucas A
2cfec1dc32 Localise osu!supporter badge. 2021-07-17 15:26:18 +02:00
Lucas A
a0c6945f8f Localise user graph. 2021-07-17 15:25:45 +02:00
Lucas A
306a34a802 Localise level badge tooltip. 2021-07-17 15:21:30 +02:00
kj415j45
0183564810 Merge branch 'localisation-base' of https://github.com/kj415j45/osu into localisation-base 2021-07-17 21:19:14 +08:00
Lucas A
4d276b114b Localise profile header. 2021-07-17 15:18:45 +02:00
Lucas A
d9c7ea2026 Localise profile section titles. 2021-07-17 14:57:05 +02:00
Lucas A
e6b8307b8e Localise ProfileHeader 2021-07-17 14:46:14 +02:00
bdach
7859d02c5b Allow null for breadcrumb control 2021-07-17 20:33:26 +08:00
LiangXiang Shen
6bebb1fdb9
Merge branch 'master' into localisation-base 2021-07-17 19:50:52 +08:00
kj415j45
22ff40fdd5 Fix broken WikiHeader 2021-07-17 19:40:25 +08:00
huoyaoyuan
5b694ad28b Replace string with LocalisableString 2021-07-17 19:37:32 +08:00
kj415j45
51742da89a Add localisation for NewsHeader
Co-authored-by: huoyaoyuan <huoyaoyuan@hotmail.com>
2021-07-17 19:28:27 +08:00
kj415j45
ba9b51c12d Add localisation for WikiHeader
Co-authored-by: huoyaoyuan <huoyaoyuan@hotmail.com>
2021-07-17 19:25:25 +08:00
Dan Balasescu
6eed857d63
Merge branch 'master' into input-settings-localisation 2021-07-16 23:25:25 +09:00
Dan Balasescu
da7e880e46
Merge pull request #13893 from peppy/mouse-settings-localisation
Add localisation coverage of `MouseSettings`
2021-07-16 23:25:12 +09:00
Dean Herbert
7df7137c88 Add localisation support for remaining input settings sections 2021-07-16 23:03:55 +09:00
Gagah Pangeran Rosfatiputra
8541e73fc1
use text flow in markdown image caption 2021-07-16 16:26:15 +07:00
Dean Herbert
3f3adfe297 Add localisation support for MouseSettings 2021-07-15 13:09:51 +09:00
Dean Herbert
5b91111eda Update SettingsSubsection.Header to accept a LocalisableString 2021-07-15 13:09:51 +09:00
Dean Herbert
687c9aa33d Add tooltip and keywords for "high precision" setting 2021-07-15 12:37:52 +09:00
Dan Balasescu
95d767bd0c
Merge branch 'master' into fix-orange-hue 2021-07-14 12:32:45 +09:00
Salman Ahmed
b4961cd12e Revert "Remove duplicated colour definitions"
This reverts commit 9869986c59.
2021-07-14 03:18:13 +03:00
Salman Ahmed
821c1b5335 Update hue of green colour scheme 2021-07-12 19:11:40 +03:00
Salman Ahmed
62a00a82de Revert completely irrelevant changes
This reverts commit b2b966463a.
2021-07-12 19:11:28 +03:00
Salman Ahmed
b2b966463a Update hue of green colour scheme 2021-07-12 19:05:36 +03:00
Salman Ahmed
c96a76df67 Update specified link 2021-07-12 18:21:10 +03:00
Salman Ahmed
1437772711 Update hue of orange colour scheme 2021-07-12 18:11:51 +03:00
Salman Ahmed
9869986c59 Remove duplicated colour definitions 2021-07-12 17:55:29 +03:00
Salman Ahmed
1deaefacb7 Add "basic" lime colour theme 2021-07-12 17:53:15 +03:00
Dean Herbert
d5d7dd0e74
Merge pull request #13701 from frenzibyte/consume-bindable-current-factory
Fix `RestoreDefaultValueButton` not behaving correctly on number types
2021-07-12 14:49:00 +09:00
Salman Ahmed
c44558e3c8 Add back LoadComplete override 2021-07-10 17:57:52 +03:00
Bartłomiej Dach
6f89f8e572 Merge branch 'master' into da-mod-refactor 2021-07-10 11:41:54 +02:00
Dean Herbert
dbfeea9880
Merge pull request #13831 from nekodex/add-dropdown-sound-to-profile
Change profile section expansion button to use dropdown sounds
2021-07-09 11:58:48 +09:00
Jamie Taylor
2eb12a59b7
Rename function to be more accurate 2021-07-09 11:16:47 +09:00
Salman Ahmed
0223c569df Remove no longer necessary method definitions 2021-07-09 00:49:05 +03:00
Salman Ahmed
a7be632770
Improve documentation
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-07-09 00:39:09 +03:00
Bartłomiej Dach
3e21eeb7c2
Merge branch 'master' into fix-mod-select-cross-talk 2021-07-08 19:53:50 +02:00
Salman Ahmed
f5166d8dd5
Merge branch 'master' into consume-bindable-current-factory 2021-07-08 18:13:48 +03:00
Jamie Taylor
8746ef0ba9
Avoid double playback of sample 2021-07-08 20:36:25 +09:00
Jamie Taylor
546f55d341
Change profile section expansion to use dropdown sounds 2021-07-08 20:23:11 +09:00
Jamie Taylor
93eb385dd4
Add sound for switching between volume controls 2021-07-08 20:01:39 +09:00
Dean Herbert
af270cccc4 Fix cross talk between ModSelectOverlays 2021-07-08 17:59:04 +09:00
Dean Herbert
fcee69ffe6 Fix ShowsDefaultIndicator not actually being consumed 2021-07-08 17:48:08 +09:00
Dean Herbert
e612d7568c
Merge pull request #13771 from LumpBloom7/volume-meter-switch
Add ability to navigate between volume meters via Alt+Left/Right arrows
2021-07-07 21:50:44 +09:00
Dean Herbert
7d405f04fb Fix selected volume control not updating correctly on mouse move 2021-07-07 21:17:31 +09:00
Dean Herbert
cbe4114e90 Adjust visuals and make base opacity 100% 2021-07-07 21:07:00 +09:00
Dean Herbert
e42609f092
Merge pull request #8038 from thewildtree/adjust-rankings-overlay
Adjust rankings overlay elements to better match osu-web
2021-07-07 20:24:11 +09:00
Salman Ahmed
28adb43a4a Add detailed explaination for the reason of using old binding method 2021-07-07 09:26:17 +03:00
Dean Herbert
bb58a9412b
Merge branch 'master' into consume-bindable-current-factory 2021-07-07 15:16:02 +09:00
Bartłomiej Dach
f45418dde7 Replace game-side directory/file selector with framework extensions 2021-07-06 22:11:54 +02:00
Derrick Timmermans
07d54d261a
Let selection container handle manual selection changes 2021-07-06 13:24:18 +02:00
Derrick Timmermans
c5a0672277
Use IStateful<SelectionState> instead of ISelected 2021-07-06 12:07:25 +02:00
Derrick Timmermans
d495196b66
Share item cycling logic with GameplayMenuOverlay 2021-07-05 19:22:55 +02:00
PercyDan54
e1c646b9b2
Remove redundant arguments 2021-07-05 23:52:39 +08:00
Derrick Timmermans
3fe875efb2
Add glow to focused meter 2021-07-05 16:38:52 +02:00
Dean Herbert
d119d9a0db Merge branch 'master' into adjust-rankings-overlay 2021-07-05 11:59:26 +09:00
Derrick Timmermans
0527f669cb
Merge branch 'master' into volume-meter-switch 2021-07-04 17:48:26 +02:00
Derrick Timmermans
69803105ef
Fix volume meter requesting focus for any action 2021-07-04 17:19:44 +02:00
Derrick Timmermans
14a861003a
Fix code quality errors 2021-07-04 16:06:28 +02:00
Derrick Timmermans
50c9e17e52
Return focus when using UP/DOWN on unfocused meter 2021-07-04 15:42:26 +02:00
Derrick Timmermans
d0707079b1
Remove unused method 2021-07-04 15:35:51 +02:00
Derrick Timmermans
e151c7ffd0
Let VolumeMeter request focus instead of taking it 2021-07-04 15:35:04 +02:00
Derrick Timmermans
d1553f0864
Implement ability to switch between volume meters 2021-07-04 14:47:07 +02:00
Dean Herbert
149a200f34 Fix volume metre not correctly showing volume when initially zero
Closes https://github.com/ppy/osu/issues/13761.
2021-07-04 14:56:17 +09:00
Bartłomiej Dach
fbe3b447e5 Merge branch 'master' into linkify-metadata 2021-07-03 15:51:08 +02:00
Bartłomiej Dach
6fb8ed4d07 Trim no longer used constant 2021-07-03 15:47:47 +02:00
Bartłomiej Dach
7dae93ad66 Remove unused using directives 2021-07-03 15:23:26 +02:00
Salman Ahmed
83578e7c9d Hold a bound copy reference instead 2021-07-02 23:24:51 +03:00
Salman Ahmed
612ed6353c Resolve RestoreDefaultValueButton issue by internal management 2021-07-02 22:30:26 +03:00
Salman Ahmed
2b366e04fd Revert "Fix RestoreDefaultValueButton not behaving correctly on number types"
This reverts commit bc0ab7dd4f.
2021-07-02 21:06:57 +03:00
Dan Balasescu
4d85df6bbc
Merge branch 'master' into notch-tick-sfx 2021-07-02 20:38:30 +09:00
Dean Herbert
66240d582f
Merge branch 'master' into consume-bindable-current-factory 2021-07-02 20:28:57 +09:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block 2021-07-02 18:19:46 +09:00
Dean Herbert
362816492f Move to more friendly namespace 2021-07-02 18:09:16 +09:00
Dean Herbert
eacf867073 Move shared types into their own classes 2021-07-02 18:05:00 +09:00
Dean Herbert
ecb4982281 Add missing blank lines 2021-07-02 17:51:54 +09:00
Dean Herbert
35f7966922 Merge conditionals in line with other case of same logic 2021-07-02 15:55:36 +09:00
Jamie Taylor
910fe3e9f8 Center pitch randomisation around base pitch 2021-07-02 15:51:23 +09:00
Dean Herbert
bd6664d541 Add note about intentional downward pitch, against expectations 2021-07-02 15:48:16 +09:00
Dean Herbert
13254d51fc Remove usage of bool for initial playback
Also refactors the whole method to generally clean things up. One more
important fix is setting the frequency on the channel before starting
playback, so avoid the frequency potentially being adjusted after the
playback is already started.
2021-07-02 15:48:13 +09:00
Dean Herbert
69b1347730 Tidy up weird bind logic 2021-07-02 15:29:51 +09:00
Jamie Taylor
68c5e6a431
Add audio feedback to changing volume 2021-07-01 20:55:04 +09:00
Dean Herbert
0522500a57 Fix a couple of merge oversights 2021-07-01 19:45:17 +09:00
Dean Herbert
31dbc7798b Merge branch 'master' into linkify-metadata 2021-07-01 19:41:33 +09:00
Dean Herbert
82fd8b13df
Merge pull request #13720 from Game4all/localise-dashboard-friends
Localise friends view in dashboard overlay
2021-07-01 18:20:18 +09:00
Dean Herbert
b00ee67895 Remove excess whitespace 2021-07-01 17:25:47 +09:00
Lucas A
939b2baafe Localise overlay "Scroll to top" button. 2021-06-30 22:19:04 +02:00
Lucas A
8da6ecf6a9 Localise OverlayPanelDisplayStyle tab control. 2021-06-30 21:28:07 +02:00
Lucas A
f2287ba022 Localise friends online status stream control. 2021-06-30 21:16:21 +02:00
Lucas A
285c49be7e Localise dashboard overlay header. 2021-06-30 20:28:27 +02:00
Salman Ahmed
bc0ab7dd4f Fix RestoreDefaultValueButton not behaving correctly on number types 2021-06-29 23:39:46 +03:00
Gagah Pangeran Rosfatiputra
3a002e357a
rename method 2021-06-29 19:28:21 +07:00
Gagah Pangeran Rosfatiputra
d88d264491
prevent image sprite exceed its parent width 2021-06-29 09:49:45 +07:00
Gagah Pangeran Rosfatiputra
e58f690210
centering image sprite 2021-06-28 21:09:00 +07:00
Gagah Pangeran Rosfatiputra
2b8d41c045
add BlockImageContainer
change from AutoSize Both to AutoSize Y and RelativeSize X
2021-06-28 21:04:56 +07:00
Gagah Pangeran Rosfatiputra
1c074ff018
add BlockMarkdownImage
change from AutoSize Both to AutoSize Y and RelativeSize X
2021-06-28 21:04:13 +07:00
Dan Balasescu
8950757b61
Merge pull request #13618 from peppy/fix-realm-state-change-crashes
Fix realm threading issues to make it releaseable
2021-06-28 19:54:49 +09:00
Dean Herbert
f7aba7360a
Merge pull request #13654 from Henry-YSLin/fix-invisible-number-box
Refactor `SeedSettingsControl` and `SettingsNumberBox`
2021-06-28 16:07:30 +09:00
Dean Herbert
0d2bc4fc5f Merge branch 'master' into fix-realm-state-change-crashes 2021-06-28 16:03:58 +09:00
Dean Herbert
f939e2603a Merge branch 'master' into localisable-tooltips 2021-06-28 15:29:42 +09:00
Dean Herbert
eeb56970ef Make OutlinedNumberBox private and nested again 2021-06-28 15:24:55 +09:00