Dean Herbert
d83a53fc94
Remove unused ScreenBreadcrumbControl
...
See https://github.com/ppy/osu-framework/pull/6218#discussion_r1529932798 .
2024-03-20 12:10:05 +08:00
Salman Ahmed
336a6180e5
Expose TRANSITION_LENGTH from tab control
2024-03-07 08:20:20 +03:00
Dean Herbert
29a37e3585
Merge pull request #27491 from bdach/f-rank-appearance
...
Update F rank badge colours to match latest designs
2024-03-06 18:55:20 +08:00
Dean Herbert
06c7483347
Merge branch 'master' into update-framework
2024-03-06 12:36:05 +08:00
Dean Herbert
85364d25dc
Merge pull request #27276 from bdach/medals
...
Add flow for displaying achieved medals
2024-03-06 12:31:55 +08:00
Dean Herbert
b53b752e54
Update usage of MathUtils
2024-03-06 12:13:12 +08:00
Bartłomiej Dach
6080c14dd5
Update F rank badge colours to match latest designs
2024-03-04 14:47:49 +01:00
Bartłomiej Dach
6a3a7cca58
Merge branch 'master' into adjust-carousel-padding
2024-02-28 16:00:43 +01:00
Bartłomiej Dach
c10ba6ece9
Fix right mouse scroll clamping not going along well with padding
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2024-02-28 15:59:22 +01:00
Dean Herbert
31f667224f
Merge branch 'master' into medals
2024-02-28 13:48:57 +08:00
Salman Ahmed
d83aeb73e4
Fix menu cursor tracing rotation while override by gameplay cursor
2024-02-28 01:02:36 +03:00
Dean Herbert
fe59a3b9be
Merge branch 'master' into medals
2024-02-26 22:49:55 +08:00
Dean Herbert
fc30abc7b0
Merge branch 'indented-code-block' into update-framework
2024-02-21 21:44:25 +08:00
Bartłomiej Dach
2e5b61302a
Implement basic medal display flow
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
4f321e242b
Enable NRT in OsuFocusedOverlayContainer
2024-02-20 16:31:31 +01:00
Dean Herbert
6b6a6aea54
Apply NRT to LogoTrackingContainer
2024-02-18 23:35:26 +08:00
Dean Herbert
882f11bf79
Fix logo tracking container being off by one frame
...
This was especially visible at the main menu when running in single thread mode.
2024-02-18 23:19:57 +08:00
Salman Ahmed
91675e0970
Update markdown code block implementation in line with framework changes
2024-02-18 02:00:55 +03:00
Joseph Madamba
7a74eaa2de
Fix star counter decrease animation being delayed when current is over displayed star count
2024-02-16 22:47:38 -08:00
Joseph Madamba
6e8d8b977e
Move ternary inside Math.Max()
2024-02-16 22:47:38 -08:00
Joseph Madamba
3d08bc5605
Truncate long dropdown menu item text and show tooltip
2024-02-14 23:01:51 -08:00
Salman Ahmed
2d65dfbf09
Fix Rider EAP whoopsie
2024-02-12 22:10:36 +03:00
Salman Ahmed
4f0f07d55a
Remove placeholder classes and inline everything
2024-02-12 21:30:10 +03:00
Dan Balasescu
b44f77cee1
Update R# + fix inspections
2024-02-02 21:00:28 +09:00
Bartłomiej Dach
2667cb8b36
Merge pull request #26703 from peppy/smaller-slider-misses
...
Adjust slider tick / end defaults again
2024-01-29 13:51:07 +01:00
Dean Herbert
14067c2e57
Remove unused using statements
2024-01-26 00:39:29 +09:00
Dean Herbert
3f9c2b41f7
Adjust BeatSyncContainer's early animate offset based on source's rate
2024-01-25 21:40:37 +09:00
Dean Herbert
56a9b059e9
Add back ScaleAdjust to triangles
2024-01-25 20:37:50 +09:00
Dean Herbert
8aea6e07c3
Change slider end miss colour to gray
2024-01-25 19:31:57 +09:00
Dean Herbert
45b4edcd23
Merge pull request #26697 from LeNitrous/add/scaled-screenshot
...
Crop screenshots to scaling container
2024-01-25 15:03:56 +09:00
Dean Herbert
69e822f3c5
Refactor crop logic slightly
2024-01-25 14:30:26 +09:00
Dean Herbert
85927e0682
Move configuration retrieval to non-bindable inline for readability
2024-01-25 14:22:27 +09:00
Dean Herbert
0cbba7e011
Apply NRT to ScreenshotManager
2024-01-25 14:18:20 +09:00
Nitrous
b20051fd55
offset crop rectangle to scaling container
2024-01-25 10:35:41 +08:00
Nitrous
30e335233d
Crop screenshot image to scaling container.
2024-01-25 09:27:10 +08:00
Andrei Zavatski
67010fcd03
Reduce allocation overhead in ScoreCounter
2024-01-24 23:45:07 +03:00
Bartłomiej Dach
871683a3dc
Merge pull request #26674 from peppy/use-better-enumerator
...
Reduce enumerator overhead in `GameplayLeaderboard`
2024-01-23 16:31:17 +01:00
Andrei Zavatski
da992ccc55
Implement per-axis triangles clamping
2024-01-23 04:54:27 +03:00
Dean Herbert
02bb506cce
Avoid using .Children for enumeration in other locations
2024-01-23 05:32:11 +09:00
Andrei Zavatski
1393f52b2b
Rename Masking to ClampToDrawable
2024-01-21 05:20:42 +03:00
Andrei Zavatski
e003ecb593
Change default masking value to true
2024-01-21 04:57:48 +03:00
Andrei Zavatski
6ba3546be5
Enable masking in RoundedButton
2024-01-21 02:28:14 +03:00
Andrei Zavatski
45effdb6df
Remove local vertex batching from triangles backgrounds
2024-01-20 08:41:34 +03:00
Andrei Zavatski
42e4c933d3
Fix ConstrainedIconContainer always using masking
2024-01-18 04:06:02 +03:00
Dean Herbert
a66ddc7813
Change rolling counters to use quicker easing types
2024-01-17 18:18:53 +09:00
Andrei Zavatski
7920e93fa9
Rework GlowingSpriteText
2024-01-16 17:43:16 +03:00
Bartłomiej Dach
40f612435d
Merge pull request #26178 from felipemarins/mod-search-text-box-select-all
...
Make mod search box text be selected when a new mod is selected/deselected
2024-01-15 20:08:02 +01:00
Bartłomiej Dach
eecd868d66
Use darker blue for SliderTailHit result
2024-01-14 09:24:50 +01:00
Salman Ahmed
c147ec0a98
Update dropdown disabled state to match with other components
2023-12-29 05:31:13 +03:00
Salman Ahmed
150bf67064
Fix dropdown colour not updating correctly on enabled state changes
2023-12-29 05:30:50 +03:00
Dean Herbert
28e220ca50
Update popup dialog design
...
Had to be done. I hated the old ones so much.
As usual, disclaimer that this is an iterative design and will probably
be replaced in the future.
2023-12-28 19:04:35 +09:00
Felipe Marins
cbfcda7929
Expose SelectAll() method on ShearedSearchTextBox
2023-12-28 00:10:01 -03:00
Bartłomiej Dach
89e2b6358a
Remove hexacons
2023-12-27 17:42:18 +01:00
Bartłomiej Dach
45143a6c17
Implement new icon store
2023-12-27 17:42:17 +01:00
Bartłomiej Dach
13333f7575
Make room for OsuIcon to accept new icons
2023-12-27 15:04:28 +01:00
Dean Herbert
58476d5429
Allow ExpandingContainer to not auto expand on hover
2023-12-27 02:33:02 +09:00
Dean Herbert
c55458e49c
Remove pointless intermediary class
2023-12-27 02:32:47 +09:00
Dean Herbert
d1ba2a4a64
Use orange for non-combo-breaking miss
2023-12-20 20:45:27 +09:00
Dean Herbert
9b383e3276
Add support for showing tick misses
2023-12-20 20:23:19 +09:00
Dean Herbert
c88c25e77f
Merge pull request #25848 from 65-7a/dropdown-search-padding
...
Fix padding on dropdown search bar
2023-12-19 00:36:14 +09:00
65-7a
17f1f8bb43
Fix padding on dropdown search bar
2023-12-19 00:28:23 +11:00
Dean Herbert
62444c3d04
Fix song select's carousel scroll position getting reset on background processing
...
This only happened for users using absolute right-click scroll.
2023-12-18 19:17:59 +09:00
Dean Herbert
0be6743e87
Apply Bindable.Parse refactorings
2023-12-13 14:07:38 +09:00
Dean Herbert
ae8a70ddfc
Merge branch 'drawnode-subtree-draw-cleanup' into dropdown-search
2023-12-13 14:03:46 +09:00
Salman Ahmed
67a9eab741
Update caret layout
2023-12-12 21:21:11 +03:00
Salman Ahmed
f0ddcb22c6
Remove arbitrary margin
2023-12-12 21:21:04 +03:00
Salman Ahmed
ee2e176082
Add osu! dropdown search bar implementation
2023-12-05 22:53:48 +03:00
Salman Ahmed
b8b82f8901
Handle back action in OsuDropdown rather than menu
2023-12-05 22:47:10 +03:00
Salman Ahmed
a0813d18ca
CalculatedTextSize -> FontSize
2023-12-05 22:47:10 +03:00
Dan Balasescu
b56a78c6ec
Adjust with framework changes
2023-12-04 08:51:21 +09:00
Susko3
152c7e513e
Ignore overlapping links instead of crashing
2023-12-01 00:54:13 +01:00
Dean Herbert
340227a06d
Replace all hexacon lookups with strongly typed properties
2023-11-24 13:17:39 +09:00
Dean Herbert
95c00f9666
Add HexaconIcons lookup to allow usage with SpriteIcon
2023-11-24 13:17:39 +09:00
Dean Herbert
405ab499e9
Allow context menus to have visible spacers
2023-11-21 14:24:10 +09:00
Dean Herbert
87a76b9ee8
Merge pull request #25478 from Joehuu/fix-comment-markdown
...
Fix `CommentMarkdownTextFlowContainer` not inheriting osu! class
2023-11-16 17:39:35 +09:00
Bartłomiej Dach
1e2f1b3ef2
Merge branch 'master' into unload-main-menu-storyboard
2023-11-16 15:46:44 +09:00
Joseph Madamba
2b19cf6ce4
Fix comment markdown style regression
2023-11-15 19:50:32 -08:00
Salman Ahmed
bb912bc616
Avoid spinning another load thread on initial storyboard load
2023-11-11 02:57:17 +03:00
Salman Ahmed
080f13e34d
Schedule outside of UnloadStoryboard and fix disposal happening on update thread
2023-11-11 02:56:45 +03:00
Salman Ahmed
59998b507a
Hide background sprite when storyboard finishes loading
2023-11-09 23:23:57 +03:00
Salman Ahmed
e947158969
Remove fade out transition
...
Unnecessary addition from this PR, makes the background fade to ugly black during transition between screens.
2023-11-09 23:03:30 +03:00
Salman Ahmed
768a31b2f5
Fix background crash on a beatmap with no storyboard
2023-11-09 22:57:20 +03:00
Salman Ahmed
bd8409219f
Unload beatmap storyboard background when no longer present
2023-11-09 17:20:11 +03:00
Dean Herbert
626cfae3fe
Merge pull request #25386 from EVAST9919/bar-graph-smooth
...
Ensure `BarGraph`'s draw quad is thick enough
2023-11-08 17:24:37 +09:00
Dean Herbert
6c6baab115
Reword comment to explain why
2023-11-08 16:41:30 +09:00
Andrei Zavatski
b092b0093a
Make sure bar draw quad is thick enough
2023-11-07 17:43:40 +03:00
Bartłomiej Dach
a136f272cf
Just use yellow for system mods
2023-11-06 16:40:57 +01:00
Bartłomiej Dach
6deac9a5a4
Use better colours for system mods
2023-11-06 11:41:23 +01:00
Bartłomiej Dach
3b9c4c9d53
Do not revert to default value when double-clicking disabled slider
...
Closes https://github.com/ppy/osu/issues/25228 .
2023-10-26 12:11:26 +02:00
Jamie Taylor
fbf8f52f7d
Add audio feedback for when keys are pressed during key binding
2023-10-20 21:01:37 +09:00
Joseph Madamba
18e8ca6245
Add ability to revert slider settings to default when double-clicking nub
2023-10-17 21:41:03 -07:00
Dean Herbert
e081fa48a2
Fix various other inspections
2023-10-17 17:48:51 +09:00
Dean Herbert
5341a335a6
Bypass Parent nullability checks for now
2023-10-17 17:48:45 +09:00
Bartłomiej Dach
af89d69fc4
Fix dangerous buttons using different shades of pink
2023-10-13 13:16:24 +02:00
Bartłomiej Dach
041318e3e8
Assign red colour to ComboBreak hit result
...
For a judgement result to show up on the colour hit error meter, it has
to be two things: be scorable, and not be bonus.
`ComboBreak` happens to meet both of those criteria - it impacts score
indirectly via decreasing the combo portion, and isn't bonus. Therefore
it would show up on the colour hit error meter, but because
`OsuColour.ForHitResult()` wasn't handling it explicitly, it was
painting the result in light blue, which isn't ideal for a miss type
judgement. Therefore, use red instead.
There is possibly an argument to be made that this judgement should not
show up on the colour hit error meter at all, but I think it's actually
okay for it to be this way. In any case it doesn't appear to be anything
so major as to warrant blocking the hold note tick removal at this time.
2023-10-11 19:44:46 +02:00
Dean Herbert
f2e56bbb65
Fix publicly-settable bindables
2023-10-06 16:51:24 +09:00
Dean Herbert
d4cf6e100f
Update other usages of OsuIcon.ModBg and remove
2023-09-28 19:03:34 +09:00
Bartłomiej Dach
589f56d20c
Merge branch 'master' into map_info_on_mod_settings
2023-09-11 09:55:54 +02:00
Bartłomiej Dach
c1a2b86f3f
Extract constants properly
2023-09-11 08:29:37 +02:00
Joseph Madamba
2fbd67cf26
Merge branch 'master' into beatmap_wedge_clean_ii
2023-09-04 11:24:20 -07:00
Magnus-Cosmos
40dbf098d2
Use existing localisation for "view profile"
2023-09-02 22:51:08 -04:00
Dean Herbert
bf0f4fddad
Localise non-overridden samples
2023-08-25 01:08:22 +09:00
Dean Herbert
081fb308e1
Merge branch 'master' into new-overlay-sfx
2023-08-24 18:29:00 +09:00
Jamie Taylor
f4415a5bab
Add more detail to comment
2023-08-24 18:20:36 +09:00
Jamie Taylor
7ef5a71e91
Move PopIn/PopOut sample playback from WaveOverlayContainer to WaveContainer (so Multiplayer/Lounge plays the samples)
2023-08-24 18:13:23 +09:00
Jamie Taylor
2e27a476bb
Re-enable sample playback for PasswordEntryPopover and remove sampleJoin playback instead
2023-08-24 18:04:47 +09:00
Dean Herbert
5f040a991b
Fix potential crash when loading menu items due to cross-thread ops
2023-08-21 19:05:20 +09:00
Dean Herbert
fc2fac577f
Inverse and xmldoc ShearedToggleButton sample allowance bool
2023-08-18 17:05:25 +09:00
Jamie Taylor
d10d7b6ea4
Change some component samples to go better with overlay pop-in samples
2023-08-17 18:36:37 +09:00
Jamie Taylor
3d7ba0e18c
Add pop-in/pop-out sfx to more overlays
2023-08-17 18:36:37 +09:00
Jamie Taylor
04a1f6a508
Add panning to certain overlay pop-in/pop-outs
2023-08-17 18:36:37 +09:00
Bartłomiej Dach
19f892687a
Add precise rotation control to osu! editor
2023-08-16 11:37:52 +02:00
Bartłomiej Dach
bdf87e43db
Merge branch 'master' into slider-with-textbox-instantaneous
2023-08-16 10:48:45 +02:00
Bartłomiej Dach
ab1d523528
Fix kiai stars flickering on and off during gameplay
...
Closes #24503 .
The problematic reset of `lastParticleAdded` has been moved to a place
that should hopefully (a) not cause such problems and (b) be much more
explicit about what's happening.
2023-08-15 07:44:05 +02:00
Dean Herbert
34c761946c
Don't completely fade FPS counter out when running at full FPS
...
I've heard multiple times from uses that this is distracting or
confusing.
2023-08-14 23:55:57 +09:00
Dean Herbert
0e510088f9
Ensure background of gameplay is black when storyboard is overriding background display
2023-08-02 15:50:15 +09:00
Dean Herbert
a618ed140e
Move StoryboardReplacesBackground bindable more local to usage
2023-08-02 15:29:18 +09:00
Bartłomiej Dach
4fb0ff8800
Implement instantaneous SliderWithTextBoxInput mode
2023-08-01 01:02:16 +02:00
Bartłomiej Dach
ca81f23356
Add test covering non-instantaneous behaviour
2023-08-01 01:01:37 +02:00
Bartłomiej Dach
2e2b0c4e41
Move SliderWithTextBoxInput to more general namespace
2023-08-01 01:01:36 +02:00
Bartłomiej Dach
3b9f250c1b
Merge branch 'master' into menu-star-fountains
2023-07-25 21:58:13 +02:00
Bartłomiej Dach
f3a95d4c13
Merge branch 'master' into menu-star-fountains
2023-07-19 21:26:41 +02:00
Dean Herbert
5e2a0bd733
Fix spawning edge case when elapsed became unexpectedly negative
2023-07-19 14:10:27 +09:00
Dean Herbert
7fa95f7512
Fix #region
2023-07-19 13:52:43 +09:00
Dean Herbert
2e3d1fe950
Fix regression in time jumping behaviour
2023-07-19 13:38:04 +09:00
Dean Herbert
ccbb30cdda
Fix ParticleSpewer not correctly accounting for lower frame rates (and spawning less particles)
2023-07-18 19:52:45 +09:00
Dean Herbert
1dc293ed61
Allow specifying a custom width for nubs in OsuCheckboxes
2023-07-14 14:24:55 +09:00
Dean Herbert
ded7ec3aa6
Merge branch 'master' into framework-clipboard
2023-07-14 03:32:37 +09:00
Dean Herbert
20e4e2581a
Change IBeatSyncProvider.Clock to always be non-null
2023-07-13 22:13:40 +09:00
Dean Herbert
db37de45ac
Allow saving changes to presets in popover using "select" binding
2023-07-13 17:53:26 +09:00
Susko3
2dcd790442
Resolve Clipboard via DI
2023-07-11 11:42:31 +02:00
Dean Herbert
5f880397a9
Increase the minimum size of the scroll bar
...
Allows easier targetting when there is a lot of content in the scroll view
As discussed in https://github.com/ppy/osu/discussions/24095#discussioncomment-6332398 .
2023-07-02 00:04:56 +09:00
Bartłomiej Dach
df2dcf85b4
Fix wrong disable
2023-06-24 17:07:42 +02:00
Bartłomiej Dach
e3a89a6273
Fix remaining obvious CI inspections
2023-06-24 16:07:01 +02:00
Bartłomiej Dach
2c1a44da89
Revert nullability enable in BeatmapBackground
...
Due to varying expectations in handling of `Beatmap`. Some places allow
or expect null and some don't. Needs to be looked at closer separately.
2023-06-24 15:40:06 +02:00
Dean Herbert
df5b389629
Manual fixes to reduce warnings to zero
2023-06-24 01:52:53 +09:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
Dean Herbert
7c5813c05a
Fix OsuAnimatedButton not flashing when triggered via code
2023-06-20 16:34:22 +09:00
Bartłomiej Dach
b87acfa66f
Dynamically change placeholder to convey how to activate search
2023-06-18 15:58:50 +02:00
Bartłomiej Dach
9ba4bf5fb7
Merge branch 'master' into add-mod-search-option
2023-06-18 15:06:21 +02:00
Dean Herbert
eb31fdecee
Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change
...
See https://github.com/ppy/osu-framework/pull/5834
2023-06-18 20:57:32 +09:00
Dean Herbert
a62b11606e
Attempt to fix NaN fps display
...
The only thing I can see which could cause this is reading from the `drawClock.ElapsedFrameTime` after the `isSpike` read causing a div-by-zero. Reading the values once at the start should avoid this.
2023-06-17 01:32:45 +09:00
Joseph Madamba
874ce4fe71
Merge remote-tracking branch 'upstream/master' into pr/22239
2023-06-14 07:06:55 -07:00
Dean Herbert
8864014af8
Add xmldoc
2023-06-12 15:25:45 +09:00
Joseph Madamba
0d51e4f6ce
Fix mod select panels having conflicting tooltips
...
Going simple with a bool instead of making `TooltipText` init-able, as the current cases will just init `string.Empty`. And not sure if we want custom tooltip text in the future.
2023-06-10 12:24:58 -07:00
Joseph Madamba
61a9c6fd7e
Disable Truncate in OsuSpriteText
...
Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>
2023-06-10 11:53:45 -07:00
Cootz
036479dd9d
Merge branch 'master' into add-mod-search-option
2023-06-09 16:27:18 +03:00
Joseph Madamba
85fedbd025
Add tooltips to truncated text
2023-06-08 19:44:07 -07:00
Bartłomiej Dach
281aae91ec
Merge pull request #23808 from peppy/working-beatmap-get-background
...
Refactor `IWorkingBeatmap.Background` to `GetBackground()`
2023-06-08 12:23:07 +02:00
Dean Herbert
a842f79ad4
Refactor IWorkingBeatmap.Background to GetBackground()
2023-06-08 16:19:32 +09:00
