1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 11:37:28 +08:00

Assign red colour to ComboBreak hit result

For a judgement result to show up on the colour hit error meter, it has
to be two things: be scorable, and not be bonus.

`ComboBreak` happens to meet both of those criteria - it impacts score
indirectly via decreasing the combo portion, and isn't bonus. Therefore
it would show up on the colour hit error meter, but because
`OsuColour.ForHitResult()` wasn't handling it explicitly, it was
painting the result in light blue, which isn't ideal for a miss type
judgement. Therefore, use red instead.

There is possibly an argument to be made that this judgement should not
show up on the colour hit error meter at all, but I think it's actually
okay for it to be this way. In any case it doesn't appear to be anything
so major as to warrant blocking the hold note tick removal at this time.
This commit is contained in:
Bartłomiej Dach 2023-10-11 19:44:46 +02:00
parent 3f29f27cd4
commit 041318e3e8
No known key found for this signature in database

View File

@ -78,6 +78,7 @@ namespace osu.Game.Graphics
case HitResult.SmallTickMiss:
case HitResult.LargeTickMiss:
case HitResult.Miss:
case HitResult.ComboBreak:
return Red;
case HitResult.Meh: