Dean Herbert
9a46e738bd
Fix inspections
2024-02-26 15:45:29 +08:00
Dean Herbert
4c744ccb69
Fix "Use current" snap not working
...
Regressed with https://github.com/ppy/osu/pull/27249 .
I was suspicious of this specific operation at the time but didn't test properly.
2024-02-26 14:11:54 +08:00
Dean Herbert
4421ff975b
Add local function to perform iteration to better explain the "why"
2024-02-26 09:04:39 +08:00
Salman Ahmed
5c049feca1
Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps
2024-02-25 21:18:15 +03:00
Andrei Zavatski
9e3defebda
Remove unused using
2024-02-25 19:05:40 +03:00
Andrei Zavatski
c3fa97d062
Reduce allocations in HitObjectLifetimeEntry
2024-02-25 18:02:42 +03:00
Andrei Zavatski
f948f8ee5c
Fix HUDOverlay allocations
2024-02-25 17:59:20 +03:00
Andrei Zavatski
081aa84718
Simplify last footer button selection
2024-02-25 10:36:15 +03:00
Dean Herbert
e8d2abc4f7
Merge pull request #27364 from EVAST9919/spinner-alloc
...
Reduce osu spinner allocations
2024-02-25 09:36:02 +08:00
Andrei Zavatski
6d2187e079
Reduce allocations in ModSelectOverlay
2024-02-24 22:58:23 +03:00
Andrei Zavatski
3b53ed3c3a
Reduce allocations in ModColumn
2024-02-24 22:44:58 +03:00
Andrei Zavatski
1fb19e7129
Reduce allocations in DrawableSpinner
2024-02-24 20:18:30 +03:00
Dan Balasescu
006416057b
Merge pull request #27144 from cdwcgt/allow-muted-ranked
...
Allow pp for muted mod for any combination of settings
2024-02-25 00:31:37 +09:00
Bartłomiej Dach
f6ceedc7a6
Inline last version which touched ranks when checking for upgrade
2024-02-24 13:55:44 +01:00
Bartłomiej Dach
4bc92a263f
Bump score version
2024-02-24 13:20:42 +01:00
Bartłomiej Dach
e80b08c46f
Fix incorrect standardised score estimation on selected beatmaps
2024-02-24 09:56:58 +01:00
Dean Herbert
05f0b4796c
Merge pull request #27344 from bdach/editor-combo-colours-rotate
...
Fix editor displaying combo colours in effectively incorrect order
2024-02-24 10:44:02 +08:00
Salman Ahmed
d4bc3090e7
Fix incorrect conflict resolution
2024-02-23 18:42:07 +03:00
Salman Ahmed
618819ba9f
Merge branch 'master' into freemod_mapinfo_fix
2024-02-23 18:34:41 +03:00
Salman Ahmed
c1db9d7819
Add test coverage
2024-02-23 18:16:44 +03:00
Bartłomiej Dach
869f0a82de
Use hashset for faster lookup
2024-02-23 15:38:52 +01:00
Salman Ahmed
fdc0636554
General code cleanup
2024-02-23 17:31:54 +03:00
Salman Ahmed
9ce07a96b2
Rewrite mods flow and remove RoomBeatmapAttributesDisplay
2024-02-23 17:30:13 +03:00
Salman Ahmed
323d7f8e2d
Change BeatmapAttributesDisplay retrieval to proper method
2024-02-23 16:59:43 +03:00
Salman Ahmed
918577d530
Compute required mods list once per update
2024-02-23 16:53:41 +03:00
Bartłomiej Dach
f86b7f0702
Enable NRT in EditorBeatmapSkin
2024-02-23 14:52:44 +01:00
Salman Ahmed
f94cd4483c
Avoid relying on game-wide ruleset bindable
2024-02-23 16:50:33 +03:00
Salman Ahmed
ae9c58be30
Remove "multiplayer" references from subclass and move to appropriate place
2024-02-23 16:50:33 +03:00
Bartłomiej Dach
d1d32fc16c
Fix editor displaying combo colours in effectively incorrect order
...
Addresses https://github.com/ppy/osu/discussions/27316 .
Stable lies about the first combo colour being first; in the `.osu`
file it is actually second. It does a thing in editor itself to correct
for this.
https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Edit/Forms/SongSetup.cs#L233-L234
2024-02-23 14:49:46 +01:00
Dean Herbert
157819c199
Materialise realm collection hashes during song select search process
...
Without this, there's a large overhead to do a realm-live `Contains`
search when a collection is selected.
This may also help considerably alleviate
https://github.com/ppy/osu/discussions/27298#discussioncomment-8552508
as we will be performing the native realm search much less.
2024-02-23 11:41:27 +08:00
Brandon
6c8204f9a3
Update delete collections message when none
2024-02-22 19:40:02 -08:00
Brandon
d6beae2ce1
Update delete/restore mod presets message when none
2024-02-22 19:10:15 -08:00
Brandon
01d0ad506d
Merge branch 'master' into delete_none_message
2024-02-22 17:37:26 -08:00
Bartłomiej Dach
eac4c5f69d
Rename {Solo -> User}StatisticsWatcher et al.
...
The "solo" prefix is a bit unbecoming now. The updates are not only
for solo.
2024-02-22 20:36:24 +01:00
Bartłomiej Dach
1e53503608
Show user statistics after completing a playlists / multiplayer score
2024-02-22 20:35:50 +01:00
Bartłomiej Dach
0074bdc5a1
Change ResultsScreen constructor boolean params to init-only properties
2024-02-22 20:15:03 +01:00
Bartłomiej Dach
f9e92c69a8
Merge branch 'master' into fix-skin-editor-init-fail
2024-02-22 14:08:38 +01:00
Bartłomiej Dach
82b2edd4b7
Merge pull request #26769 from EVAST9919/results-clean
...
Rework `AccuracyCircle` to not use `BufferedContainer`s
2024-02-22 13:46:28 +01:00
Bartłomiej Dach
49b7f0e3a7
Merge pull request #26531 from smallketchup82/multiplayer-difficulty-tooltip
...
Implement difficulty tooltips for multiplayer lobbies
2024-02-22 12:57:35 +01:00
Bartłomiej Dach
7861125e7a
Swap AR and OD on tooltips
...
Matches everything else.
2024-02-22 12:11:49 +01:00
Bartłomiej Dach
46c8560ca5
Merge branch 'master' into multiplayer-difficulty-tooltip
2024-02-22 12:08:29 +01:00
Bartłomiej Dach
d06c67ad8f
Substitute two jank interdependent bool flags for single tri-state enums
2024-02-22 12:05:50 +01:00
Bartłomiej Dach
6770b73e4e
Merge pull request #27192 from smoogipoo/mod-search-ignore-whitespace
...
Adjust search terms for mods
2024-02-22 11:41:31 +01:00
Bartłomiej Dach
84fdcd24ef
Remove description from mod search terms
...
Closes https://github.com/ppy/osu/issues/27111 .
2024-02-22 11:02:08 +01:00
Bartłomiej Dach
1a831145ce
Merge branch 'master' into fix-bpm-differences
2024-02-22 10:41:22 +01:00
Dean Herbert
8b24c6a905
Merge pull request #27299 from BoudewijnPopkema/27272-clear-remembered-username
...
Clear stored username/token from config when relevant checkboxes are unticked on login panel
2024-02-22 17:29:36 +08:00
Bartłomiej Dach
81a9908c60
Extract common helper for BPM rounding
2024-02-22 10:27:37 +01:00
Bartłomiej Dach
01f6ab0336
Use more correct implementation
2024-02-22 09:44:59 +01:00
Bartłomiej Dach
a1046f0a86
Revert "clear remembered username when checkbox is unticked"
...
This reverts commit d01421b951
2024-02-22 09:40:27 +01:00
Bartłomiej Dach
57bb0b85a1
Merge pull request #27107 from Joehuu/rank-highest-tooltip
...
Add highest rank tooltip to global rank display
2024-02-22 09:08:22 +01:00
Boudewijn Popkema
d01421b951
clear remembered username when checkbox is unticked
2024-02-21 23:15:37 +01:00
Andrei Zavatski
4cefa8bb8d
Reduce allocations in TimelineBlueprintContainer
2024-02-21 23:13:10 +03:00
Dean Herbert
fc30abc7b0
Merge branch 'indented-code-block' into update-framework
2024-02-21 21:44:25 +08:00
Dean Herbert
9d732bd9b1
Merge branch 'remove-legacy-gl' into update-framework
2024-02-21 21:44:19 +08:00
Dean Herbert
6d32cfb7ee
Update framework
2024-02-21 21:39:33 +08:00
Dean Herbert
fb593470d5
Use DEFAULT instead of INSTANCE or static field
...
Matches other similar comparers.
2024-02-21 21:02:20 +08:00
Bartłomiej Dach
929858226a
Use custom comparer in beatmap carousel for expected sort behaviour
2024-02-21 12:43:18 +01:00
Bartłomiej Dach
59235d6c50
Implement custom comparer for expected carousel sort behaviour
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-02-21 12:43:17 +01:00
Dean Herbert
9c40ff2911
Merge pull request #27278 from EVAST9919/grid-update
...
Apply padding to `GridContainer`s directly where possible
2024-02-21 17:29:21 +08:00
Andrei Zavatski
2543a48ac8
Apply padding to GridContainers directly
2024-02-20 23:18:37 +03:00
Andrei Zavatski
871bdb9cf7
Reduce string allocations in TimeInfoContainer
2024-02-20 20:31:18 +03:00
Bartłomiej Dach
33a0dcaf20
NRT-annotate MedalAnimation and fix possible nullref
2024-02-20 17:59:21 +01:00
Andrei Zavatski
6678c4783b
Fix PlaybackControl string allocations
2024-02-20 19:31:28 +03:00
Bartłomiej Dach
9b938f333d
Fix test failures
2024-02-20 17:25:11 +01:00
Bartłomiej Dach
1db5cd3aba
Move medal overlay to topmost container
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
611e3fe76b
Delay medal display when wanting to show results animation
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
96825915f7
Fix threading failure
...
Implicitly showing the medal overlay fires off some transforms, and the
websocket listener runs on a TPL thread. That's a recipe for disaster,
so schedule the show call.
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
8abcc70b93
Add medal overlay to game
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
b334b78b63
Make medal overlay respect overlay disable via activation mode
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
e4971ae121
Add display queueing when multiple medals are granted in quick succession
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
2e5b61302a
Implement basic medal display flow
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
4f321e242b
Enable NRT in OsuFocusedOverlayContainer
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
4911f5208b
Demote medal "overlay" to animation
...
I need the actual overlay to be doing way more things (receiving the
actual websocket events, queueing the medals for display, handling
activation mode), so the pre-existing API design of the overlay just
will not fly.
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
48bf9680e1
Add new structures for receiving new medal data
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
4a314a8e31
Namespacify data structures used in websocket communications
2024-02-20 16:31:31 +01:00
Givikap120
ed028e8d26
Update MultiplayerModSelectOverlay.cs
2024-02-20 13:13:13 +02:00
Givikap120
8199a49ee2
minor look changes
2024-02-20 13:11:19 +02:00
Givikap120
a4288e7ecc
removed unnecessary changes
2024-02-20 13:00:59 +02:00
Givikap120
54ef397d56
Changed override method
...
now it overrides mods getter instead of calculate fuctions
2024-02-20 12:57:28 +02:00
Dean Herbert
ef413c08f1
Merge pull request #27249 from EVAST9919/editor-alloc
...
Reduce osu editor allocations with many objects selected
2024-02-20 15:06:25 +08:00
Dan Balasescu
40d6e8ce85
Remove legacy OpenGL renderer option, it's now just OpenGL
2024-02-20 15:14:30 +09:00
Dean Herbert
3ea47e64f0
Merge pull request #27258 from Loreos7/storage-error-localisation
...
Localise storage error popup dialog
2024-02-20 13:37:10 +08:00
Joseph Madamba
2ff8667dd2
Revert "Centralise global rank display logic to new class"
...
Also don't show on `LoginOverlay` usage for now.
2024-02-19 12:11:12 -08:00
Andrei Zavatski
c758640311
Reduce allocations in ComposerDistanceSnapProvider
2024-02-19 20:49:56 +03:00
Susko3
24e3fe79a4
Log GlobalStatistics when exporting logs from settings
2024-02-19 17:02:53 +01:00
Mike Will
012d6b7fe1
Change userBeatmapOffsetClock to a FramedOffsetClock
...
Assuming that the global audio offset is set perfectly, such that
any audio latency is fully accounted for, if a specific beatmap
still sounds out of sync, that would no longer be a latency issue.
Instead, it would indicate a misalignment between the beatmap's
track and time codes, the correction for which should be a
virtual-time offset, not a real-time offset.
2024-02-19 09:14:49 -05:00
Dean Herbert
c87bc8b597
Merge pull request #27180 from bdach/better-submission-failure-messaging
...
Add better submission failure messaging
2024-02-19 21:38:23 +08:00
Bartłomiej Dach
ec26ab51d1
Use different wording
2024-02-19 13:56:21 +01:00
Bartłomiej Dach
d7b1e3ba50
Merge pull request #27226 from peppy/no-audio-filter-funny-business
...
Ensure audio filters can't be attached before load (or post-disposal)
2024-02-19 13:01:34 +01:00
Dean Herbert
398eaee5d0
Merge pull request #27238 from bdach/disable-nested-managers-when-skin-editor-open
...
Disable nested input managers on edited screen when skin editor is open
2024-02-19 19:27:26 +08:00
Bartłomiej Dach
f5666185ab
Merge pull request #27239 from peppy/fix-cached-beatmap
...
Fix `WorkingBeatmapCache` caching beatmap in wrong state leading to crash
2024-02-19 12:06:45 +01:00
Bartłomiej Dach
1ca566c6b0
Disable nested input managers on edited screen when skin editor is open
2024-02-19 10:19:25 +01:00
Dean Herbert
7f82f10317
Fix beatmap potentially loading in a bad state
...
Over-caching could mean that a beatmap could load and cause a late
crash. Let's catch it early to avoid such a crash occurring.
2024-02-19 17:18:07 +08:00
Brandon
413b7aab60
Switch to const string
2024-02-18 22:12:03 -08:00
Brandon
c6ca812ea0
Add feedback to delete button even when no-op
2024-02-18 21:52:23 -08:00
maromalo
5a448ce02f
Turn BPMDisplay to RollingCounter<int>
2024-02-18 19:59:56 -03:00
Dean Herbert
998d820666
Ensure audio filters can't be attached before load (or post-disposal)
...
Will probably fix https://github.com/ppy/osu/issues/27225 ?
2024-02-19 00:25:01 +08:00
Dean Herbert
6b6a6aea54
Apply NRT to LogoTrackingContainer
2024-02-18 23:35:26 +08:00
Dean Herbert
882f11bf79
Fix logo tracking container being off by one frame
...
This was especially visible at the main menu when running in single thread mode.
2024-02-18 23:19:57 +08:00
Dean Herbert
415a65bf59
Add failing tests for beatmap inconsistencies
2024-02-18 19:32:21 +08:00
Dean Herbert
4d4d69521f
Merge pull request #27114 from EVAST9919/judgements-rework
...
Cache created judgement in `HitObject`
2024-02-18 18:07:58 +08:00
Dean Herbert
9655e8c48a
Adjust xmldoc slightly
2024-02-18 17:54:29 +08:00
Dean Herbert
715236765a
Merge pull request #27206 from EVAST9919/selection-enumerators
...
Reduce allocations during beatmap selection
2024-02-18 10:02:35 +08:00
Givikap120
24171bd02b
Update MultiplayerModSelectOverlay.cs
2024-02-18 03:34:02 +02:00
Givikap120
a6b63efe7d
Fixed NVika code quality errors
2024-02-18 03:28:24 +02:00
Givikap120
9070e973d3
Update BeatmapAttributesDisplay.cs
2024-02-18 03:16:18 +02:00
Givikap120
4aaf016ee0
quality improvements
2024-02-18 03:15:53 +02:00
Givikap120
6fb3192648
Update BeatmapAttributesDisplay.cs
2024-02-18 03:14:36 +02:00
Givikap120
2df5787dc7
Packed changes into separate class
2024-02-18 03:13:57 +02:00
Salman Ahmed
91675e0970
Update markdown code block implementation in line with framework changes
2024-02-18 02:00:55 +03:00
Givikap120
ed819fde15
Fixed bugs and added ranked status update
2024-02-17 23:01:31 +02:00
Givikap120
cd8ac6a722
Update BeatmapAttributesDisplay.cs
2024-02-17 22:12:15 +02:00
Dean Herbert
6960f87509
Merge pull request #26895 from vmfunc/ordinal-sorting
...
Consider case sensitivity when sorting beatmaps in song select
2024-02-18 04:05:22 +08:00
Dean Herbert
71afb8881a
Merge pull request #27199 from EVAST9919/link-compiler-alloc
...
Fix `DrawableLinkCompiler` allocations
2024-02-18 04:04:34 +08:00
Dean Herbert
520576a0fd
Merge pull request #27193 from bdach/fix-not-working-metadata-hub-cleanup
...
Fix a few issues in metadata hub's disconnection requested flow
2024-02-18 03:46:02 +08:00
Andrei Zavatski
dd82de473a
Revert BeatmapCarousel changes
2024-02-17 22:42:47 +03:00
Dean Herbert
62a7e315bf
Update framework
2024-02-18 03:11:29 +08:00
Andrei Zavatski
22f5a66c02
Reduce allocations during beatmap selection
2024-02-17 15:46:38 +03:00
Joseph Madamba
7a74eaa2de
Fix star counter decrease animation being delayed when current is over displayed star count
2024-02-16 22:47:38 -08:00
Joseph Madamba
6e8d8b977e
Move ternary inside Math.Max()
2024-02-16 22:47:38 -08:00
Andrei Zavatski
b0f334c39e
Fix DrawableLinkCompiler allocations
2024-02-17 00:45:30 +03:00
Andrei Zavatski
060b01eee8
Make CreateJudgement public again and add remarks
2024-02-16 20:24:02 +03:00
Andrei Zavatski
dd32c0a226
Merge branch 'master' into judgements-rework
2024-02-16 20:08:57 +03:00
Bartłomiej Dach
1049be7d72
Add extended xmldoc to DisconnectRequested()
...
Just expounds on what the previous commit message said.
2024-02-16 13:09:36 +01:00
Bartłomiej Dach
b4aa247032
Do not attempt to stop watching user presence when requested to disconnect
...
First of all, this sort of cleanup isn't really the client's
responsibility, and secondly, at the point the client received this
request to disconnect, *none of its requests will be honored anymore*
(currently the only scenario of this if another client has connected
- the server-side concurrency filter will reject this request).
When disconnection is requested, the only valid thing to do with respect
to talking to the server is to stop doing it.
This will be moved server-side in a follow-up change, although I'm not
even strictly sure that's required - I'd like to think signalr would
know to clean up a disconnecting client from all groups they were in.
2024-02-16 13:08:39 +01:00
Bartłomiej Dach
9fa60b169e
Actually disconnect from metadata hub when requested to
...
Nothing in this override, on in the base implementation, would actually
attempt to disconnect.
2024-02-16 12:58:50 +01:00
Bartłomiej Dach
171270d99c
Fix missing RPC method mapping
...
Thanks, signalr.
2024-02-16 12:58:13 +01:00
Dan Balasescu
0fff9d4937
Add non-whitespace search term for mods
2024-02-16 19:17:41 +09:00
Salman Ahmed
583e71634f
Always bring master/music volume to 50%
2024-02-16 11:20:07 +03:00
Salman Ahmed
952c5b0d18
Use Precision.AlmostBigger
2024-02-16 11:13:41 +03:00
Salman Ahmed
9f53185fa9
Revert changes to muted notification action
2024-02-16 10:47:56 +03:00
Salman Ahmed
df40f55c07
Merge branch 'master' into mute_detection
2024-02-16 01:35:02 +03:00
Salman Ahmed
7530b1f362
Adjust comment again
2024-02-16 01:31:52 +03:00
Salman Ahmed
5431781f80
Bring back target volume to 50%
2024-02-16 01:23:26 +03:00
Salman Ahmed
d81b148b09
Remove mention of decibel units in comment
...
Decibels are irrelevant in the volume bindables, as mentioned in PR already.
2024-02-16 01:23:18 +03:00
Salman Ahmed
a9eac5924d
Remove seemingly unnecessary float casts
2024-02-16 01:18:13 +03:00
Dean Herbert
c1d9f53ab4
Merge pull request #27068 from smoogipoo/mania-hd-fi-progression
...
Add progressive coverage for mania's Hidden and FadeIn mods
2024-02-16 01:00:53 +08:00
Dean Herbert
e91d38872d
Update framework
2024-02-15 18:28:59 +08:00
Bartłomiej Dach
898d5ce88b
Show selected submission failure messages even in solo
...
Previously, if a `SubmittingPlayer` instance deemed it okay to proceed
with gameplay despite submission failure, it would silently log all
errors and proceed, but the score would still not be submitted. This
feels a bit anti-user in the cases wherein something is genuinely wrong
with either the client or web, so things like token verification
failures or API failures are now shown as notifications to give the user
an indication that something went wrong at all.
Selected cases (non-user-playable mod, logged out, beatmap is not
online) are still logged silently because those are either known and
expected, or someone is messing with things.
2024-02-15 10:55:08 +01:00
Bartłomiej Dach
95e745c6fb
Use better messaging for selected submission failure reasons
...
These have been cropping up rather often lately, mostly courtesy of
linux users, but not only:
https://github.com/ppy/osu/issues/26840
https://github.com/ppy/osu/issues/27008
https://github.com/ppy/osu/discussions/26962
so this is a proposal for slightly improved messaging for such cases to
hopefully get users on the right track.
The original error is still logged to network log, so there's no
information loss.
2024-02-15 10:51:27 +01:00
Bartłomiej Dach
e10c4c7079
Merge pull request #27176 from peppy/document-classic-mod-no-rank
...
Add inline documentation as to why classic mod is not ranked
2024-02-15 09:22:05 +01:00
Dean Herbert
409dfd33e7
Merge pull request #27178 from Joehuu/truncate-osu-dropdown-items
...
Truncate long dropdown menu item text and show tooltip
2024-02-15 16:11:36 +08:00
Joseph Madamba
3d08bc5605
Truncate long dropdown menu item text and show tooltip
2024-02-14 23:01:51 -08:00
Dean Herbert
9e9297bfb3
Add inline documentation as to why classic mod is not ranked
...
See https://github.com/ppy/osu/pull/27149#issuecomment-1939509941 .
2024-02-15 13:22:54 +08:00
Dean Herbert
728f65b6d3
Merge pull request #27173 from EVAST9919/song-select-sort
...
Reduce allocations during aggregate beatmap sorts in song-select screen
2024-02-15 12:50:16 +08:00
Joseph Madamba
a03835bf1c
Improve comments
2024-02-14 20:13:27 -08:00
Dean Herbert
674ee91bb5
Define aggregate max delegates as static to further reduce allocations
2024-02-15 11:40:50 +08:00
Dean Herbert
80abf6aab3
Avoid some further enumerator allocations
2024-02-15 09:45:24 +08:00
Andrei Zavatski
6e1b4152c0
Redice allocations during aggregate beatmap sort
2024-02-15 00:01:55 +03:00
Dean Herbert
59efd22ba2
Merge branch 'master' into score-statistics-updates-working-2
2024-02-15 02:55:12 +08:00
Dean Herbert
9ec79755fb
Standardise font specs
2024-02-15 02:54:28 +08:00
Dean Herbert
c175e03600
Inline rolling duration variable
2024-02-15 02:53:38 +08:00
Bartłomiej Dach
c588b81cee
Merge pull request #27163 from frenzibyte/ignore-soft-deleted-beatmaps-in-notification
...
Ignore soft-deleted beatmaps when trying to present from notification
2024-02-14 18:07:59 +01:00
Bartłomiej Dach
aae431e8f6
Cancel rolling properly
2024-02-14 16:48:31 +01:00
Bartłomiej Dach
53884f61c3
Apply suggested changes
2024-02-14 16:41:41 +01:00
Bartłomiej Dach
ae9a2661ac
Sprinkle some raw string prefixes
2024-02-14 16:20:47 +01:00
Bartłomiej Dach
414066fd34
Inline problematic function (and rename things to make more sense)
2024-02-14 16:07:42 +01:00
Bartłomiej Dach
a8ae0a032f
Simplify parsing
2024-02-14 15:58:38 +01:00
Dean Herbert
3da1d05d98
Merge branch 'master' into ignore-soft-deleted-beatmaps-in-notification
2024-02-14 22:56:47 +08:00
Bartłomiej Dach
c24328dda3
Abandon date filter if no meaningful time bound found during parsing
2024-02-14 15:56:32 +01:00
Bartłomiej Dach
f0f37df67f
Revert unnecessary change
2024-02-14 15:37:02 +01:00
Bartłomiej Dach
1113355753
Merge branch 'master' into add-last-played-filter
2024-02-14 15:36:19 +01:00
Bartłomiej Dach
2c0a5b7ef5
Fix missing tiny droplet not triggering fail with perfect on
...
Stable does this:
46cd3a10af/osu
2024-02-14 14:21:48 +01:00
Bartłomiej Dach
68247fa022
Fix typo in json property name
...
Would cause the mapper badge to never actually be shown in the real
world.
2024-02-14 13:21:37 +01:00
Bartłomiej Dach
8312f92b4e
Use better value for alignment
2024-02-14 12:24:28 +01:00
Bartłomiej Dach
153024e61b
Increase transition durations slightly
...
Maybe slightly better readability. Dunno.
2024-02-14 10:16:10 +01:00
Bartłomiej Dach
6baa099906
Fix broken delay
2024-02-14 10:12:01 +01:00
Salman Ahmed
4d3b605e04
Add support for displaying "mapper" badges in comments
2024-02-14 04:17:55 +03:00
Salman Ahmed
72c6134dbf
Include commentable object metadata in comments
2024-02-14 04:16:36 +03:00
Salman Ahmed
c4e358044a
Add API models for comment page metadata
2024-02-14 04:16:36 +03:00
Salman Ahmed
5267e0abf7
Move comment author line to separate component
2024-02-14 04:16:36 +03:00
Salman Ahmed
35649d137c
Ignore soft-deleted beatmaps when trying to present from notification
2024-02-14 02:04:20 +03:00
Bartłomiej Dach
eae43f5fd9
Consume SoloStatisticsWatcher updates in toolbar button
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
14052ae1cc
Implement transient stats display on user toolbar button
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
21b9fb95e2
Move SoloStatisticsWatcher to OsuGame
...
Doesn't feel like it needs to be in base, and it being in base was
causing problems elsewhere before.
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
da4ebd0681
Refactor SoloStatisticsWatcher to no longer require explicit subscription callbacks
2024-02-13 13:49:01 +01:00
Bartłomiej Dach
16d893d40c
Fix draining processor failing gameplay on bonus misses and ignore hits
2024-02-13 13:06:19 +01:00
Dean Herbert
f7a223f328
Merge pull request #27053 from frenzibyte/unranked-pp-placeholder
...
Add support for displaying "unranked PP" placeholder
2024-02-13 18:59:55 +08:00
Dan Balasescu
833997bf1d
Merge pull request #27143 from bdach/more-stringent-metadata-checks
...
Use more stringent checks when applying online metadata
2024-02-13 17:10:52 +09:00
Salman Ahmed
2d65dfbf09
Fix Rider EAP whoopsie
2024-02-12 22:10:36 +03:00
Salman Ahmed
4f0f07d55a
Remove placeholder classes and inline everything
2024-02-12 21:30:10 +03:00
Bartłomiej Dach
5d81d83fb2
Merge branch 'master' into alias-author-creator
2024-02-12 18:02:42 +01:00
cdwcgt
1944a12634
allow ModMuted to ranked when setting adjusted
2024-02-12 21:18:31 +09:00
Bartłomiej Dach
138fea8c38
Only apply set-level metadata after all difficulties have been processed
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
87702b3312
Only check online matching when determining whether to save online metadata
...
After https://github.com/ppy/osu/pull/23362 I'm not sure the
`LocallyModified` check is doing anything useful. It was confusing me
really hard when trying to parse this logic, and it can misbehave (as
`None` will also pass the check).
2024-02-12 12:07:20 +01:00
Bartłomiej Dach
4f0ae4197a
Refuse to apply online metadata in the most dodgy scenarios
2024-02-12 11:43:41 +01:00
Salman Ahmed
2ae616a88e
Combine other cases of displaying dash in scores PP
2024-02-12 12:29:33 +03:00
Stoppedpuma
ca0819cf7a
Alias "mapper" as well
2024-02-11 20:28:16 +01:00
Andrei Zavatski
5e692345de
Don't convert pixel data to array
2024-02-11 17:44:54 +03:00
Dean Herbert
1df38b54a1
Merge branch 'master' into refactor-metadata-lookup-sources
2024-02-11 20:10:41 +08:00
Dean Herbert
7dba21fdac
Move init method to bottom of file
2024-02-11 20:05:58 +08:00
tsunyoku
901b82384d
replace linq usage in Previous and Next with more direct computation
2024-02-10 15:42:55 +00:00
Dean Herbert
32bfd875d9
Merge pull request #26930 from Susko3/suggest-update-only-if-available
...
Suggest to update only if the latest release is available for the current platform
2024-02-10 22:08:56 +08:00
Bartłomiej Dach
4a516cbccd
Merge pull request #27077 from peppy/log-fire-and-forget-better
...
Improve exception logging of unobserved exceptions via `FireAndForget`
2024-02-10 13:43:50 +01:00
Bartłomiej Dach
c3f0d3ad5c
Merge branch 'master' into match-profile-icons
2024-02-10 13:08:42 +01:00
Dan Balasescu
bfeb90c1b6
Add additional gameplay metadata to room score request
2024-02-10 17:20:17 +09:00
Stoppedpuma
7c04e8bfba
Alias author to creator
...
Allows "author" to show the results of "creator"
2024-02-10 07:48:24 +01:00
Dean Herbert
01501f3b82
Merge branch 'master' into refactor-metadata-lookup-sources
2024-02-10 14:43:51 +08:00
Joseph Madamba
7b0b39dbaa
Fix total play time tooltip area including label
2024-02-09 16:06:16 -08:00
Joseph Madamba
ffd0d9bb39
Add highest rank tooltip to global rank display
2024-02-09 16:06:16 -08:00
Joseph Madamba
ae89b89928
Centralise global rank display logic to new class
2024-02-09 16:06:16 -08:00
Joseph Madamba
8d1d65a469
Add ContentTooltipText to ProfileValueDisplay
2024-02-09 16:06:16 -08:00
Joseph Madamba
c9c39ecb2f
Add RankHighest to APIUser
2024-02-09 16:06:16 -08:00
Joseph Madamba
ed2362b63d
Fix icon family and weight not transferring to text conversion
2024-02-09 14:31:38 -08:00
Joseph Madamba
666c57da50
Fix profile current location and interests icons not matching web
2024-02-09 14:31:37 -08:00
Andrei Zavatski
c500264306
Cache created judgement in HitObject
2024-02-09 23:20:31 +03:00
Berkan Diler
6adf0ac01e
Use new LINQ Order() instead of OrderBy() when possible
2024-02-08 18:01:00 +01:00
Susko3
7864810fc9
Merge branch 'master' into windows-file-uri-association
2024-02-07 23:10:13 +01:00
Dan Balasescu
dcb195f3c8
Add delayed resume for taiko/catch/mania
2024-02-08 02:16:08 +09:00
Dan Balasescu
7f3646f2d1
Merge pull request #27069 from bdach/populate-legacy-total-score-when-converting
...
Populate `TotalScoreInfo` when converting `SoloScoreInfo` to `ScoreInfo`
2024-02-08 01:33:31 +09:00
Dean Herbert
0d7e82ab8d
Improve exception logging of unobserved exceptions via FireAndForget
...
Coming from https://github.com/ppy/osu/issues/27076 , where the log
output makes finding where the exception arrived for nigh impossible.
2024-02-08 00:25:11 +08:00
Bartłomiej Dach
706a16677c
Use localised string
2024-02-07 13:38:05 +01:00
Bartłomiej Dach
3f51148719
Update resources
2024-02-07 13:37:37 +01:00
Bartłomiej Dach
f22828bc50
Flip ifs to reduce nesting
2024-02-07 13:36:46 +01:00
Bartłomiej Dach
9a3c947319
Remove unnecessary #nullable disable
2024-02-07 13:35:12 +01:00
Dean Herbert
b0bd1a80cf
Merge branch 'master' into hide-ruleset-selector-kudosu
2024-02-07 16:52:05 +08:00
Dean Herbert
b68a1699d4
Merge pull request #27067 from bdach/exponential-backoff
...
Use staggered exponential backoff when retrying in `PersistentEndpointClientConnector`
2024-02-07 16:51:49 +08:00
Dean Herbert
21e5ae5ba9
Minor adjustments
2024-02-07 16:46:59 +08:00
Joseph Madamba
8f59cb7659
Hide ruleset selector when on kudosu ranking
2024-02-06 13:18:22 -08:00
Dan Balasescu
44b1515cc5
Remove LangVersion redefintions
2024-02-07 03:28:40 +09:00
Andrei Zavatski
ff7cd67909
Move all the circles into their own container
2024-02-06 21:14:36 +03:00
Andrei Zavatski
f03c4a0961
Merge branch 'master' into results-clean
2024-02-06 21:09:23 +03:00
Bartłomiej Dach
9314de640f
Populate TotalScoreInfo when converting SoloScoreInfo to ScoreInfo
...
For use in https://github.com/ppy/osu-tools/pull/195 .
2024-02-06 18:30:48 +01:00
Dean Herbert
e055d61e50
Merge pull request #27059 from bdach/grayscale
...
Convert selected legacy skin sprites to grayscale
2024-02-06 22:59:39 +08:00
Dan Balasescu
5bc7befbd4
Add progressive cover to mania HD and FI mods
2024-02-06 23:47:20 +09:00
Bartłomiej Dach
6ffe8e1713
Use staggered exponential backoff when retrying in PersistentEndpointClientConnector
...
There are suspicions that the straight 5s retry could have caused a
situation a few days ago for `osu-server-spectator` wherein it was
getting hammered by constant retry requests. This should make that
a little less likely to happen.
Numbers chosen are arbitrary, but mostly follow stable's bancho retry
intervals because why not. Stable also skips the exponential backoff in
case of errors it considers transient, but I decided not to bother for
now.
Starts off from 3 seconds, then ramps up to up to 2 minutes. Added
stagger factor is 25% of duration, either direction. The stagger factor
helps given that if spectator server is dead, each client has three
separate connections to it which it will retry on (one to each hub).
2024-02-06 15:40:30 +01:00
Bartłomiej Dach
c21af1bf3d
Use more explicit match
...
`taiko-bar-right-glow` is a prefix of `taiko-bar-right`...
2024-02-06 14:53:01 +01:00
Dean Herbert
d784934bce
Merge pull request #26935 from bdach/new-mods-for-pp
...
Allow a few new mods and mod settings for pp
2024-02-06 20:54:20 +08:00
Bartłomiej Dach
8df593a8e6
Allow pp for No Scope
...
Deemed as not affecting difficulty or pp in
https://github.com/ppy/osu/pull/26935#issuecomment-1925644008 ,
so can be treated pretty much as nomod.
2024-02-06 13:04:19 +01:00
Bartłomiej Dach
27b97a3c4d
Convert selected legacy skin sprites to grayscale
...
Matching stable.
Closes https://github.com/ppy/osu/issues/9858 .
I would have liked to apply this in the taiko transformer itself, but
the limited accessibility of texture uploads, and as such the raw image
data, sort of prevents that...
2024-02-06 12:33:37 +01:00
Dan Balasescu
c18cd65081
Merge pull request #26694 from chandler14362/hit-object-result-allocations
...
Avoid closure allocations when applying hit object results
2024-02-06 17:49:26 +09:00
Bartłomiej Dach
86e1e57fab
Merge pull request #27054 from Loreos7/update-related-notifications-localisation
...
Localise update-related process strings
2024-02-06 09:07:58 +01:00
Dan Balasescu
ca36919f10
Merge pull request #26863 from EVAST9919/scrolling-alloc
...
Further reduce allocation overhead in `ScrollingHitObjectContainer`
2024-02-06 15:57:31 +09:00
Andrei Zavatski
fc4234214e
Merge branch 'master' into results-clean
2024-02-06 08:03:10 +03:00
Salman Ahmed
b78c6ed673
Update design of "unprocessed PP" placeholder to match web
2024-02-05 23:29:24 +03:00
Salman Ahmed
6b7ffc240b
Support displaying "unranked PP" placeholder
2024-02-05 23:29:24 +03:00
Salman Ahmed
4be4ed7ab2
Add "ranked" attribute to scores
2024-02-05 23:29:24 +03:00
Bartłomiej Dach
938bbe38b7
Merge pull request #27033 from frenzibyte/fix-rooms-container-something
...
Fix selected room bindable being set to null regardless of the removed room
2024-02-05 21:04:34 +01:00
Bartłomiej Dach
07c257f387
Merge pull request #26942 from Loreos7/import-from-stable-localisation
...
Localise remaining strings on import screen of the first-run setup
2024-02-05 20:01:47 +01:00
Bartłomiej Dach
aff7e1fb8c
Merge pull request #27015 from Loreos7/settings-remaining-strings-localisation
...
Localise remaining strings in settings section
2024-02-05 20:00:42 +01:00
Bartłomiej Dach
f65449375e
Merge branch 'master' into scrolling-alloc
2024-02-05 19:59:47 +01:00
Bartłomiej Dach
951b69d0d5
Merge branch 'master' into fix-rooms-container-something
2024-02-05 19:56:54 +01:00
Bartłomiej Dach
4b5348bbbf
Merge branch 'master' into ur-alloc
2024-02-05 19:14:08 +01:00
Bartłomiej Dach
7b03bebd5f
Move algorithm description to remarks section of xmldoc
2024-02-05 18:57:57 +01:00
Bartłomiej Dach
a5aeb2ff9e
Use better variable names
...
It's not the 1970s. We can spare a few extra letters.
2024-02-05 18:56:20 +01:00
Bartłomiej Dach
c12a7b3edf
Merge branch 'master' into fix-rooms-container-something
2024-02-05 18:51:46 +01:00
Bartłomiej Dach
1582536f04
Merge pull request #26924 from EVAST9919/user-card-containers
...
Rework `UserPanel`s to reduce container nesting
2024-02-05 18:46:42 +01:00
Bartłomiej Dach
462a1c5186
Merge pull request #27021 from frenzibyte/fix-rooms-container-performance
...
Fix multiplayer/playlists lounge screen disposing rooms synchronously
2024-02-05 18:33:13 +01:00
Bartłomiej Dach
26e4b0bacb
Merge branch 'master' into settings-remaining-strings-localisation
2024-02-05 18:07:03 +01:00
Bartłomiej Dach
87381334ff
Use more proper method of formatting
2024-02-05 18:06:51 +01:00
Bartłomiej Dach
2932184d24
Rename localisable string
2024-02-05 18:05:21 +01:00
Dean Herbert
48d42ca7d3
Update framework
2024-02-05 23:58:10 +08:00
Salman Ahmed
7914236516
Add explanatory note
2024-02-05 18:51:30 +03:00
Loreos7
8e82327509
one more dot
2024-02-05 18:45:32 +03:00
Loreos7
4449ccd1d3
bring back missing dot
2024-02-05 18:44:18 +03:00
Salman Ahmed
858f2fc749
Use Clear to trigger async disposal
2024-02-05 18:39:04 +03:00
Bartłomiej Dach
23694c2067
Merge branch 'master' into import-from-stable-localisation
2024-02-05 16:32:12 +01:00
Bartłomiej Dach
148e01327b
Split copy info text into two rather than parameterise
...
I have very low hopes translators would be able to correctly navigate
this otherwise (especially in languages with different word order).
2024-02-05 16:30:04 +01:00
Bartłomiej Dach
fa894bda05
Fix broken spacing
2024-02-05 16:25:44 +01:00
Bartłomiej Dach
9e1a24fdef
Remove pointless enum
2024-02-05 16:20:50 +01:00
Bartłomiej Dach
e4ef2bdeb9
Merge pull request #26734 from Joehuu/fix-edit-mod-preset-button-flow
...
Fix edit mod preset popover buttons overflowing on some languages
2024-02-05 16:10:37 +01:00
Bartłomiej Dach
3e29a9c334
Merge pull request #26877 from smoogipoo/adjust-default-minresult
...
Adjust default min result of `SliderTailHit`, remove override
2024-02-05 14:15:38 +01:00
Dean Herbert
cc5e1e0af3
Merge pull request #26957 from smoogipoo/net8
...
Update to .NET 8 + C# 12
2024-02-05 20:59:31 +08:00
Susko3
01efd1b353
Move WindowsAssociationManager to osu.Desktop
2024-02-05 13:44:12 +01:00
Bartłomiej Dach
39fe078984
Merge branch 'master' into hit-object-result-allocations
2024-02-05 13:24:10 +01:00
Bartłomiej Dach
2976f225e0
Improve xmldoc of state param
2024-02-05 13:22:58 +01:00
Bartłomiej Dach
efe6bb25b1
Refactor result application around again to remove requirement for fields
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-02-05 13:21:01 +01:00
Bartłomiej Dach
ad69259eb8
Merge branch 'master' into fix-results-f-rank
2024-02-05 13:05:37 +01:00
Salman Ahmed
44a594ba05
Simplify playback logic
2024-02-05 01:03:04 +03:00
Salman Ahmed
6f9ee3f526
Fix selected room bindable being set to null regardless of the removed room
2024-02-05 00:37:33 +03:00
Salman Ahmed
9923c1b6e6
Fix multiplayer/playlists lounge screen disposing rooms synchronously
2024-02-04 17:25:58 +03:00
Bartłomiej Dach
83df6297d2
Merge branch 'master' into new-mods-for-pp
2024-02-04 12:20:31 +01:00
Dean Herbert
c64d414d1b
Merge pull request #26934 from bdach/which-mods-for-pp
...
Display which mods grant pp
2024-02-04 19:15:11 +08:00
Andrei Zavatski
4e5c9ddbfe
Rename notch const to spacing
2024-02-04 03:02:39 +03:00
Andrei Zavatski
397def9ceb
Move layout specification outside the GradedCircles class
2024-02-04 02:58:15 +03:00
Andrei Zavatski
7b2adc857a
Merge branch 'master' into results-clean
2024-02-04 02:41:12 +03:00
Susko3
cdcf5bddda
Uninstall associations when uninstalling from squirrel
2024-02-03 17:56:14 +01:00
Andrei Zavatski
e2e3c61c9c
Use AliveEntries where we don't need startTime order
2024-02-03 19:54:08 +03:00
Andrei Zavatski
4aa27482a9
Use SlimReadOnlyDictionaryWrapper for AliveEntries
2024-02-03 19:54:08 +03:00
Susko3
03578821c0
Associate on startup
2024-02-03 17:04:06 +01:00
Susko3
498d93be61
Add way to associate with files and URIs on Windows
2024-02-03 16:59:48 +01:00
Loreos7
24e5c7ed42
fix formatting
2024-02-03 02:02:21 +03:00
Andrei Zavatski
57bc5ee04f
Improve readability
2024-02-03 00:19:04 +03:00
Loreos7
4d324a3057
localise remaining parts of the game settings
2024-02-03 00:08:36 +03:00
Andrei Zavatski
dde7e068a4
Incorporate new unstable rate algo
2024-02-02 22:46:52 +03:00
Mike Will
9a5348598a
Replace aggregate rounding method with a float cast
2024-02-02 14:22:24 -05:00
Mike Will
2ab967f783
Increase precision of aggregate volume rounding
...
It should be large enough to account for true accuracy
but small enough to disregard any hair-thin inaccuracy found
at the very end of the float value.
2024-02-02 13:27:26 -05:00
Bartłomiej Dach
8454f7a991
Merge branch 'master' into net8
2024-02-02 16:27:32 +01:00
Dan Balasescu
50f9c61029
Fix multiplayer tests
2024-02-02 22:34:48 +09:00
Dan Balasescu
8e8ba9e77f
Fix more CI inspections
2024-02-02 21:36:41 +09:00
Loreos7
20504c55ef
localise storage error popup dialog
2024-02-02 15:32:55 +03:00
Dan Balasescu
c8b4ff2b47
Fix compile error (reserved name)
2024-02-02 21:28:51 +09:00
Dan Balasescu
6e4d52863c
Upgrade to .NET 8 SDK
2024-02-02 21:28:51 +09:00
Dan Balasescu
20ae88b0a0
Revert unnecessary changes
2024-02-02 21:05:50 +09:00
Dan Balasescu
b44f77cee1
Update R# + fix inspections
2024-02-02 21:00:28 +09:00
Mike Will
29a2890582
fix code quality error #2
2024-02-02 03:47:19 -05:00
Dan Balasescu
8c107b4925
Merge pull request #26950 from bdach/2fa-in-registration
...
Add 2FA verification screen to registration flow
2024-02-02 17:30:20 +09:00
Mike Will
c60e110976
Try to fix code quality issues raised by workflow
2024-02-02 03:09:19 -05:00
Mike Will
f4a2d5f3f4
Round off inaccuracies in the aggregate volume before evaluating
2024-02-02 02:41:58 -05:00
Mike Will
3122211268
Change silence threshold and target restore volume level
2024-02-02 02:12:46 -05:00
