1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-30 16:07:31 +08:00
Commit Graph

8608 Commits

Author SHA1 Message Date
Dean Herbert
5467097387 Fix adjacent day separators potentially being left behind after pending message resolution 2022-11-23 18:49:51 +09:00
Dean Herbert
172e798847
Merge pull request #21228 from Terochi/recent-messages-implementation
Add ability to view chat send history in input box
2022-11-23 14:58:42 +09:00
Bartłomiej Dach
76bb529cfa
Add test for local echo adding day separator 2022-11-22 16:46:21 +01:00
Alden Wu
a2b505f4c0 Use a direct Lighten instead of >1f Color4 values 2022-11-22 00:31:22 -08:00
Alden Wu
4084a2b066 Highlight ChatLine username on hover 2022-11-21 18:57:59 -08:00
Bartłomiej Dach
8dbe31a172
Merge branch 'master' into higher-aspect-ratio-max 2022-11-21 19:51:39 +01:00
Dean Herbert
981264b011 Avoid crashing when a system audio device provides a null name 2022-11-21 14:51:41 +09:00
Dean Herbert
e53b4321ff Ensure two day separators are not added in a row 2022-11-21 14:01:10 +09:00
Dean Herbert
fa7b45dfb1 Fix chat day separator not being added on pending message resolution
Closes #21316.
2022-11-21 13:52:14 +09:00
Dean Herbert
c7ae837687 Increase maximum aspect ratio for tablet settings to 23:9 / 2.55 2022-11-21 12:45:54 +09:00
Dean Herbert
92aea22cd3
Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-21 12:16:56 +09:00
vegguid
a431b793b9 Added PreferOriginalMetadataLanguage to FirstRunSetup 2022-11-20 23:18:19 +01:00
Bartłomiej Dach
0c671a2a82
Merge branch 'master' into fix-tablet-aspect-ratio-values 2022-11-19 14:32:24 +01:00
Dean Herbert
06ce8130c2 Apply changes in line with framework NRT updates 2022-11-18 18:13:15 +09:00
Dan Balasescu
e4fc14faee
Merge pull request #21270 from peppy/auto-advance-bindings
Auto-advance binding for ruleset key bindings
2022-11-18 16:19:54 +09:00
Dean Herbert
e658efbefa Fix being able to bind two non-modifier keys to the same binding 2022-11-18 15:34:41 +09:00
Dan Balasescu
1b1fed723d
Merge pull request #21269 from peppy/fix-key-bindings-keyword
Move "keybindings" keyword to correct section
2022-11-18 14:05:08 +09:00
Dan Balasescu
551192b413 Refactor a bit for readability 2022-11-18 13:55:37 +09:00
Dan Balasescu
a776622ce0
Merge pull request #21284 from peppy/now-playing-overlay-texture-reduction
Fix `NowPlayingOverlay` loading background texture too early (and permanently)
2022-11-18 12:09:16 +09:00
Dan Balasescu
baa4fd56e2
Merge pull request #21279 from peppy/news-load-unload
Fix news post images never unloading from memory after first display
2022-11-18 11:56:13 +09:00
Dan Balasescu
13fe0d3491
Merge pull request #21278 from peppy/overlay-header-texture-reduction
Avoid loading overlay headers until first open
2022-11-18 11:53:46 +09:00
Dean Herbert
b53f9baf6a Fix NowPlayingOverlay loading background texture too early (and permanently) 2022-11-18 11:21:12 +09:00
Dean Herbert
93c2280754 Fix supporter filters text not being set correctly 2022-11-18 10:35:05 +09:00
Dean Herbert
b37e9c0266 Fix news post images never unloading from memory after first display 2022-11-18 00:01:53 +09:00
Dean Herbert
73e4827d36 Avoid loading overlay headers until first open
Also switches them to use non-atlased target as they won't benefit much
from atlasing.
2022-11-17 23:55:43 +09:00
Dean Herbert
63c1855511 Avoid loading beatmap listing placeholders until required 2022-11-17 23:42:21 +09:00
Dean Herbert
a3e8cc1663 Mark beatmap listing placeholder textures as large 2022-11-17 23:41:35 +09:00
Terochi
3d4962e181 Added functioning tests. 2022-11-17 13:07:06 +01:00
Terochi
6d83af01e2 Moved and renamed MessageHistoryTextBox.cs for better fit. 2022-11-17 13:07:06 +01:00
Dragon
b9590320b7 Moved implementation to ChatRecentTextBox.cs and derived ChatTextBox.cs and StandAloneChatDisplay.cs from it. 2022-11-17 13:07:06 +01:00
Dragon
a1af663682 Implemented previous messages lookup in the ChatTextBox.cs 2022-11-17 13:07:06 +01:00
Dean Herbert
d1b2116400 Auto-advance binding for ruleset key bindings 2022-11-17 15:23:20 +09:00
Dean Herbert
bd2e0dc82b Move "keybindings" keyword to correct section
Without this, things like tablet settings would show when searching for
bindings, even though these settings have nothing to do with key
bindings.
2022-11-17 15:09:42 +09:00
Dean Herbert
bb762d8131 Fix "reset to full area" button not always working correctly 2022-11-16 15:45:26 +09:00
Samaoo
4ff17cb4bd remove unused using directive 2022-11-12 08:52:33 +01:00
Samaoo
7a860fb460 address reviews 2022-11-12 08:49:03 +01:00
Samaoo
268011be9e use MathF 2022-11-11 17:56:50 +01:00
Samaoo
173f557376 fix tablet aspect ratio values 2022-11-11 17:14:34 +01:00
Dan Balasescu
db25e9e9c8 Merge branch 'master' into combo-colour-brightness-limit 2022-11-11 15:31:28 +09:00
Susko3
5b1e39abd5 Fix parsing of Language when using default system locale 2022-11-10 22:56:24 +01:00
Samaoo
be81c658af move tablet area calculations to functions 2022-11-09 20:14:01 +01:00
Samaoo
533a2db5ea fix inaccurate tablet area dimensions when applying aspect ratio 2022-11-09 18:48:47 +01:00
Joseph Madamba
76df61504f
Remove unnecessary timestamp update
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-11-06 19:45:59 -08:00
Joseph Madamba
61ec0ba566 Make chat line timestamp adjust to 24-hour time setting 2022-11-06 19:28:01 -08:00
Joseph Madamba
b977fc8181 Use autosize instead of max width on fixed width timestamps 2022-11-06 19:28:01 -08:00
Dean Herbert
ee68f33e3c
Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again
Fix beatmap cards still potentially showing twice in listing
2022-11-06 18:46:31 +09:00
Bartłomiej Dach
84179fb087
Merge branch 'master' into combo-colour-brightness-limit 2022-11-05 16:48:56 +01:00
Salman Ahmed
ee6f036c44 Add note about using ExceptBy once it's available 2022-11-04 19:35:24 +03:00
Salman Ahmed
ce5aacb760 Filter out duplicated cards using custom equality comparer instead 2022-11-04 19:27:35 +03:00
Joseph Madamba
e11d44d14f Add url clicking support to profile badges 2022-11-03 18:12:32 -07:00
Dean Herbert
f6c376c090 Minor refactoring 2022-11-03 20:29:27 +09:00
Dean Herbert
1edde8f73c Merge branch 'master' into disabled-button-sfx 2022-11-03 20:27:41 +09:00
Jamie Taylor
59bbd9c460
Fix some components using wrong sample set 2022-11-03 17:47:49 +09:00
Jamie Taylor
f1c17129eb
Add support for 'disabled' sample variation to HoverClickSounds 2022-11-03 17:47:49 +09:00
Dean Herbert
56ef519cc2 Move PopoverContainer into OnlineOverlay to ensure correct colours 2022-11-03 15:43:06 +09:00
Dean Herbert
e6c45b8ab5 Merge branch 'master' into comment-report 2022-11-03 15:35:42 +09:00
Dean Herbert
3ec9686e58 Fix test failures and rename configuration value to match better 2022-11-02 18:15:18 +09:00
Dan Balasescu
db34f238c0 Fix inverted condition 2022-11-02 15:47:30 +09:00
Dan Balasescu
e5f53b1ad8 Use Interlocked.Exhange() instead
Increment isn't correct since it returns the post-incremented value. It
also always increments.
2022-11-02 15:18:48 +09:00
Dean Herbert
e761c0395d Fix multiple notifications arriving for imports in edge cases 2022-11-02 14:47:56 +09:00
Dean Herbert
50b6fe4acb Localise new label 2022-11-02 14:01:03 +09:00
Dean Herbert
99ba7c29dd Change range to 0-100% and rename to "normalisation" 2022-11-02 13:47:11 +09:00
Dean Herbert
2f3c80f884 Remove toggle and change method of application to blend with original colour 2022-11-02 13:08:29 +09:00
Dean Herbert
27af91003b Merge branch 'master' into combo-colour-brightness-limit 2022-11-01 17:50:26 +09:00
Joseph Madamba
d56786b5ff Fix toolbar visual bug when toggling clock displays 2022-10-29 15:25:16 -07:00
ansel
9df96aab38 Remove local popover containers 2022-10-28 22:17:45 +03:00
Dean Herbert
f46a9d683a Fix null reference in headless tests 2022-10-28 18:07:25 +09:00
Dean Herbert
f9d2c30c3e Add user toggle for application of safe areas 2022-10-28 14:05:45 +09:00
Dean Herbert
14c7cbde38 Fix toggle mute (and volume meter traversal) handling repeat key presses
Closes #20953.
2022-10-27 11:41:00 +09:00
Joseph Madamba
8505848b1a Scroll beatmap listing to top when searching via tags/source 2022-10-25 18:06:49 -07:00
Salman Ahmed
b0a4cd4f30 Inline content creation in base add method 2022-10-22 03:43:14 +03:00
Salman Ahmed
6c82bc36ed Encapsulate report logic inside button implementation
Avoids complicating the `DrawableComment` class, and allows for isolated
testability.
2022-10-22 02:48:27 +03:00
Salman Ahmed
9b5e35d599 Remove dependency on DrawableComment from report popover and simplify logic
Allows for testing the button and popover in isolation.
2022-10-22 02:47:33 +03:00
Salman Ahmed
081cf1cc47 Adjust comment report popover design 2022-10-22 02:45:31 +03:00
ansel
15aeb4a137 Display text in buttons flow instead of toast 2022-10-21 17:25:41 +03:00
Dean Herbert
447d420c99 Fix adjusting volume via settings playing tick samples twice 2022-10-21 21:03:39 +09:00
Jamie Taylor
7b1edff2b3
Add unique hover/select samples to settings sidebar buttons 2022-10-21 18:06:38 +09:00
ansel
81bdf716ef Change test 2022-10-20 19:56:00 +03:00
ansel
0ef903230c Make report button a separate component 2022-10-20 18:47:42 +03:00
ansel
da4f04ace7 Make dropdown not resize 2022-10-20 18:22:55 +03:00
ansel
635900085c Disable button when there is no text 2022-10-20 18:12:20 +03:00
ansel
ed39481932 Use another string for title 2022-10-20 18:11:35 +03:00
ansel
57320074a0 Fix accidental breakage of changelog layout 2022-10-20 01:24:36 +03:00
Dean Herbert
6b42f1931a Remove autosize easing in SettingsToolboxGroup
It just feels like unnecessary motion.
2022-10-18 15:01:26 +09:00
ansel
3258a41ca3 Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report 2022-10-17 20:41:46 +03:00
ansel
cd77ae062e Localize the button 2022-10-17 20:41:23 +03:00
ansel
797acf334f Show username in popup 2022-10-17 20:41:13 +03:00
Feodor0090
6efe7b5334
Merge branch 'master' into comment-report 2022-10-17 16:08:13 +03:00
ansel
ceb4d624b5 Delete wip form 2022-10-17 13:43:35 +03:00
ansel
ffa22d8a68 Update popover not to use labelled drawables 2022-10-17 13:42:17 +03:00
ansel
d7e5bcbd3c Add popover containers to overlays 2022-10-17 13:41:46 +03:00
ansel
7ed26369a3 Make a new report form, closer to web 2022-10-17 12:41:57 +03:00
Bartłomiej Dach
d0a495717e
Merge branch 'master' into comment-copy-link 2022-10-16 19:56:06 +02:00
ansel
4a8d976cb4 Use api's endpoint 2022-10-16 20:20:34 +03:00
ansel
ba595ab8fa Display toast instead of notification 2022-10-16 19:57:21 +03:00
ansel
9822a092c4 Add localization for enum 2022-10-16 19:50:55 +03:00
Aki
91358f4a6a
Implement tablet button bindings 2022-10-15 15:16:14 +08:00
Feodor0090
fb046e31c1
Merge branch 'master' into comment-report 2022-10-14 16:57:23 +03:00
ansel
dc0aa2295a Add test 2022-10-14 16:51:48 +03:00
ansel
3e9fd4c08c Implement reporting flow 2022-10-14 16:26:25 +03:00
ansel
c65a8a83f3 Add basic UI for reporting 2022-10-14 15:52:09 +03:00
Dean Herbert
32c3e35762 Change background colour to a lighter tint to avoid clash with slider bars 2022-10-14 19:38:27 +09:00
Dean Herbert
2404bb42b9 Use 10% alpha rather than 0% when toolbox is not hovered 2022-10-14 19:33:49 +09:00
Dan Balasescu
8a88339e78 Allow combo colour normalisation to be disabled 2022-10-14 14:37:24 +09:00
ansel
8a47628fe1 Use spacer drawable instead of spacing on links container 2022-10-14 00:04:13 +03:00
ansel
295e6f5a68 Move toast to it's namespace 2022-10-13 23:57:25 +03:00
ansel
34ff072a9b Change text 2022-10-13 22:47:48 +03:00
ansel
a0cca391f6 Add copy link button to comments 2022-10-13 22:18:26 +03:00
Dean Herbert
a93c350ca8 Start settings panels without background visible 2022-10-13 17:11:56 +09:00
Dean Herbert
6608ada925 Fix test failures due to missing colour provider dependency 2022-10-13 17:05:11 +09:00
Dean Herbert
0f4a2a6059 Improve feel of settings toolbox group 2022-10-13 16:36:19 +09:00
Dan Balasescu
4149235e63 Limit minimum brightness of combo colours 2022-10-13 14:05:33 +09:00
Dean Herbert
e43c8e84b0 Use Show instead of Alpha=1 2022-10-12 15:48:42 +09:00
Dean Herbert
47fe4eb0bd Merge branch 'master' into comment-deletion 2022-10-12 15:48:26 +09:00
Dean Herbert
195ece02c6
Merge branch 'master' into update-displays-in-setting 2022-10-12 14:37:49 +09:00
Daniel Källberg
63e651130a Grouped localisation strings 2022-10-11 10:59:07 +02:00
Daniel Källberg
9c611019b3 Toolbar localisation 2022-10-11 09:30:32 +02:00
Dean Herbert
6f6290a21a Use async flow for storing key binding changes to realm 2022-10-11 15:37:22 +09:00
Salman Ahmed
a9aba74351 Add markdown country flag support 2022-10-08 21:50:25 +03:00
ansel
c384093802 Update main test and add failure scenario test 2022-10-08 18:53:41 +03:00
ansel
b697200460 Properly modify comment visual state on deletion 2022-10-08 18:41:08 +03:00
ansel
4e7c30504f Schedule action buttons visibility changes 2022-10-08 17:15:10 +03:00
ansel
abf56c27a1 Do not requere dialog overlay 2022-10-08 17:11:09 +03:00
Joseph Madamba
b27e70ca47 Fix language settings dropdown not updating when changing language in first run setup 2022-10-06 21:11:00 -07:00
Dean Herbert
e9ab465da6
Merge branch 'master' into localisation-settings 2022-10-06 13:22:08 +09:00
Dean Herbert
4f084664ac Merge branch 'master' into comment-deletion 2022-10-05 14:34:50 +09:00
Dean Herbert
75b9bf2cf9
Merge branch 'master' into intel-exclusive-warning 2022-10-04 19:02:01 +09:00
Susko3
efc9bed4f0 Use IWindow.DisplaysChanged to update displays 2022-10-03 23:52:04 +02:00
Susko3
31fefc1ee2 Add nullable annotation to LayoutSettings 2022-10-03 23:23:02 +02:00
Susko3
e98b4b4fbd Make updateDisplayModeDropdowns regular method 2022-10-03 23:14:21 +02:00
ansel
85adfc2df7 Fix DI type 2022-09-28 18:26:36 +03:00
ansel
636befb499 Add visual feedback for deleting process 2022-09-28 17:49:37 +03:00
ansel
ae0d62838b Move API and DO to fields 2022-09-27 22:46:23 +03:00
ansel
58d9509ce6 Apply NRT to Comment 2022-09-27 22:45:05 +03:00
ansel
60ee813e45 Implement delete button 2022-09-27 18:33:16 +03:00
ansel
31a7ba3f91 Add delete button 2022-09-27 18:23:15 +03:00
Dan Balasescu
ec30050f2c
Merge pull request #20502 from peppy/forward-toasts-on-gameplay
Flush toast tray on entering gameplay
2022-09-27 18:35:54 +09:00
Dan Balasescu
5a28174448
Merge pull request #20488 from nanashi-1/toggle-score-overlay
Add toggle for solo gameplay leaderboard
2022-09-27 18:09:55 +09:00
Dean Herbert
461ba64bfa Flush toast tray on entering a no-notification section 2022-09-27 17:32:53 +09:00
Dean Herbert
c61f5403ab Increase delay back slightly on notifications posting after disabled period 2022-09-27 17:32:30 +09:00
Dean Herbert
bac3108aea Remove unnecessary keywords 2022-09-27 14:29:59 +09:00
Dan Balasescu
aa3956cfbb
Merge pull request #20495 from Feodor0090/playlist-overflow-fix
Fix playlist overlay overflowing at high UI scales
2022-09-27 13:53:14 +09:00
nanashi-1
dc051a8b79 add gameplay leaderboard config 2022-09-26 20:08:58 +08:00
Dan Balasescu
e5894ccd6f
Merge pull request #20478 from peppy/fix-progress-notification-fling
Fix progress notifications being able to be flung (and cancelled)
2022-09-26 18:21:12 +09:00
Dan Balasescu
f2eed881bd
Merge pull request #20480 from peppy/fix-drawable-mutation-tablet-settings
Fix potential crash from incorrect drawable mutation in tablet settings display
2022-09-26 18:16:52 +09:00
Dan Balasescu
525de8c140
Merge pull request #20479 from peppy/fix-drawable-mutation-misc
Fix potential crash on game exit due to incorrect scheduling of realm change handler
2022-09-26 18:02:28 +09:00
Dean Herbert
4e9b25d8b0 Move MusicController binds to LoadComplete for added thread safety 2022-09-26 15:42:37 +09:00
Dean Herbert
43c16cb613 Fix potential crash from incorrect drawable mutation in tablet settings display 2022-09-26 15:10:02 +09:00
Dean Herbert
4bd96108c0 Fix crash on game exit due to incorrect scheduling of realm change handler 2022-09-26 14:45:17 +09:00
Dean Herbert
b6dd8168d2 Fix progress notifications being able to be flung 2022-09-26 14:33:12 +09:00
ansel
5d0b2d34c9 Make playlist to always be in screen bounds 2022-09-24 23:35:06 +03:00
ansel
6c8e587344 Move margin value to constant 2022-09-24 21:52:16 +03:00
Dean Herbert
8a7526aaa3
Merge pull request #20344 from frenzibyte/better-tablet-notifications
Improve tablet error/warning notifications messaging
2022-09-22 22:45:27 +09:00
Dan Balasescu
6a0047b7a2 Update location of FullscreenCapability bindable 2022-09-22 21:01:23 +09:00
Dan Balasescu
70bab81282
Merge pull request #20377 from peppy/argon-skin
Add new default "argon" skin
2022-09-22 14:50:43 +09:00
Dan Balasescu
2b8b138079 Add "keybindings" search term to settings 2022-09-21 18:46:28 +09:00
Dean Herbert
4492a26b59
Merge branch 'master' into argon-skin 2022-09-21 13:00:16 +09:00
Dan Balasescu
8bf196d561
Merge pull request #20354 from peppy/default-skin-refactor
Rename default skin to make way for new version
2022-09-21 11:48:38 +09:00
Salman Ahmed
dcfb6a2f06 Fix progress notifications no longer blocking close on click 2022-09-21 00:15:50 +03:00
アズタケ
d22d009fb3 fix review points. items not included in this localization were reverted. 2022-09-20 14:02:11 +09:00
Dean Herbert
bd28c6f96d
Merge branch 'master' into localisation-settings 2022-09-19 23:37:26 +09:00
Dean Herbert
0f7b38f4c3 Add new default skin "argon" 2022-09-19 23:16:46 +09:00
Salman Ahmed
a413c7a3e6
Merge branch 'master' into fix-notification-count 2022-09-19 02:08:20 +03:00
Dean Herbert
41e69fbca6 Remove "default" prefix from naming 2022-09-18 00:15:26 +09:00
Dean Herbert
1c4e02fae8 Explicitly order default skins in dropdown to get correct order 2022-09-18 00:12:43 +09:00
Salman Ahmed
877165eb98 Allow specifying icon colour on simple notifications 2022-09-16 16:21:43 +03:00
アズタケ
81d582c051 fix review points and fine tuning 2022-09-16 21:08:25 +09:00
Dan Balasescu
e95983cdb4
Merge branch 'master' into fix-skin-flow 2022-09-16 20:15:51 +09:00
アズタケ
c0e2ba419e Localize non-localizable setting items 2022-09-16 18:31:02 +09:00
Dean Herbert
38d8d457d9 Add back second completion post attempt for case when notification overlay isn't loaded yet 2022-09-16 17:54:44 +09:00
Dean Herbert
0d24fda4b9 Fire Notification.Closed immediately to ensure off-screen notifications are closed 2022-09-16 16:36:56 +09:00
Dan Balasescu
f86bbaae30
Merge branch 'master' into mods-effect-displays 2022-09-15 21:17:58 +09:00
Salman Ahmed
efebe55d22 Display certain sort criterias based on selected category and query 2022-09-15 04:30:09 +03:00
Salman Ahmed
de7dd29d79 Add "Nominations" and "Updated" sorting criteria in beatmap listing 2022-09-15 03:57:05 +03:00
Joseph Madamba
85e3a681b1 Fix notification overlay toast tray background absorbing input from behind 2022-09-13 21:07:30 -07:00
Dan Balasescu
ef6d60ffe9
Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-14 10:25:24 +09:00
Salman Ahmed
04dbb6fc1b Add inline comment 2022-09-14 00:49:02 +03:00
Dean Herbert
d368f37c3a Remove redundant second Current set operation 2022-09-13 13:50:59 +09:00
Salman Ahmed
07f577a0c6 Fix beatmap listing potentially showing duplicate beatmap cards 2022-09-13 01:39:21 +03:00
ansel
8cbc0502ae Inline CalculateEffect 2022-09-12 15:51:18 +03:00
Dean Herbert
88107108ee Add ability to flick notifications to the right to store for later 2022-09-12 20:20:57 +09:00
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling 2022-09-12 20:09:21 +09:00
Dean Herbert
f31deaef7c Simplify skin bindable flow
Now, nothing touches the configuration apart from `OsuGame`, making
everything else flow better and avoid weird cyclic set bugs.

Closes https://github.com/ppy/osu/issues/20234.
2022-09-12 19:51:50 +09:00
Dan Balasescu
5bd0be14ed
Merge pull request #20259 from peppy/fix-changelog-crash
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 19:47:21 +09:00
Dean Herbert
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
Dean Herbert
d92e000fe6 Fix flinging a notification not correctly running Close 2022-09-12 19:00:03 +09:00
Dean Herbert
4ee3e8f087 Don't play fling animation when activating a notification 2022-09-12 18:57:18 +09:00
Dean Herbert
58c1ea0321 Fix potential crash when opening changelog overlay if entry has no URL 2022-09-12 17:51:15 +09:00
Dean Herbert
d561fcb126 Don't trigger fling animation when Close is triggered by non-user action 2022-09-12 16:54:25 +09:00
Dean Herbert
5a02e1e713 Use padding instead of FillFlow.Spacing to avoid artifact during animation 2022-09-12 16:46:45 +09:00
Dean Herbert
a506178571 Make bounding box shrink faster to allow for rapid flinging 2022-09-12 16:39:46 +09:00
Dan Balasescu
bcbc867694
Merge branch 'master' into mods-effect-displays 2022-09-12 16:35:28 +09:00
Dean Herbert
931049aec1 Merge branch 'master' into notification-dismiss 2022-09-12 16:27:41 +09:00
Dean Herbert
bd3673baa9 Fix being able to drag after already closing a notification 2022-09-12 16:25:32 +09:00
Dean Herbert
8e6b2796eb Merge branch 'master' into notification-fling 2022-09-12 16:19:36 +09:00
Dean Herbert
2476cf8fb3 Adjust movement to look less sudden when snapping back to Y=0 2022-09-12 15:37:48 +09:00
Dean Herbert
e06a0f7300 Fix dragged state not being exposed correctly 2022-09-12 15:21:01 +09:00
Dean Herbert
92beb6cbe7 Hide notification read light when in a toast state
Also adds test coverage of read state and light.
2022-09-12 15:17:45 +09:00
Dean Herbert
60b0b909a5 Move update icon to background to avoid colour collission with progress spinner 2022-09-12 14:58:46 +09:00
Dean Herbert
9ef23c79ce Disallow forwarding during a drag operation 2022-09-11 22:05:44 +09:00
Dean Herbert
a56cadcf90 Ensure drag position is reset when transferred to tray 2022-09-11 22:03:29 +09:00
Dean Herbert
b5a2f7003e Disallow flinging when not in toast state 2022-09-11 21:47:45 +09:00
Dean Herbert
d6f90e3b9f Add basic fling-to-dismiss support 2022-09-11 21:32:22 +09:00
ansel
324a3723a5 Rewrite DMD 2022-09-10 23:23:04 +03:00
ansel
3f93ec8538 Expose counter to inheritors 2022-09-10 23:20:28 +03:00
ansel
667854b034 Make effect display have a built-in counter 2022-09-10 23:18:48 +03:00
Dean Herbert
a9094c6b03 Add test coverage of clicking close button to dismiss 2022-09-10 15:18:32 +09:00
Dean Herbert
efe3b1aa7b Allow dismissing notifications without performing action using middle / right click 2022-09-10 15:10:37 +09:00
ansel
b056cac10a Remove generic and add default implementation for CalculateEffect 2022-09-10 08:34:29 +03:00
andy840119
1398a7e11e Property should accept the nullable state. 2022-09-10 10:46:40 +08:00
Salman Ahmed
5e4e3dfc2c Fix markdown container not rendering certain text correctly 2022-09-10 02:55:20 +03:00
Dean Herbert
6e52dbb266 Update IsDisplayingToasts to check the flow count directly 2022-09-06 17:30:24 +09:00
Dean Herbert
9e3228aa65 Fix completion notification not being posted if completion occurs during NotificationOverlay load 2022-09-06 04:07:49 +09:00
Dean Herbert
510972e3ad Avoid reference counting by using height calculation for IsPresent instead
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.

Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
Dean Herbert
0514c96191 Fix incorrect count tracking when notification is manually disposed 2022-09-05 19:26:40 +09:00
Dean Herbert
229e1a8ef7 Fix notification overlay being present when it doesn't need to 2022-09-05 19:13:58 +09:00
Dean Herbert
f754686521 Remove necessity of AlwaysPresent for ProgressUpdate completion posting 2022-09-05 19:13:58 +09:00
Dean Herbert
0d4ee6bd80 Centralise ability to fetch all toast tray notifications (including animating ones) 2022-09-05 18:42:20 +09:00
Dean Herbert
eca7b8f988 Fix completion notifications not always showing as toasts 2022-09-05 18:39:11 +09:00
Dean Herbert
4fa6707bf0 Set all progress notifications to non-important 2022-09-05 18:29:35 +09:00
Dean Herbert
7eaa4c5ccd Update new usages of Remove / RemoveInternal 2022-09-01 23:05:34 +09:00
Dean Herbert
6a35b233e5 Merge branch 'master' into remove-dispose-updates 2022-09-01 23:03:19 +09:00
Dan Balasescu
afe2862df4
Merge branch 'master' into toast-notification-tray 2022-08-31 16:07:11 +09:00
Dan Balasescu
ccc08b816c
Merge pull request #20030 from peppy/notification-design-update
Update notification overlay design
2022-08-31 16:06:59 +09:00
Dean Herbert
8b9ccc66b7 Update ProgressNotification font spec to match other notifications 2022-08-31 12:49:28 +09:00
Dean Herbert
85442fe032 Adjust dismiss button background colour to avoid conflict with background 2022-08-31 12:48:30 +09:00
Dean Herbert
7c72c6b43f Fix unread count potentially missing notifications in a transforming state 2022-08-31 12:46:43 +09:00
Dean Herbert
0558dae917 Mark toasts as read when closing the overlay for added safety
I'm not sure how the read status will play out going forward so I'm just
adding this to keep things conforming for now.
2022-08-31 12:46:04 +09:00
Dean Herbert
9eb615f942 Fix remaining test failures by strengthening PlayerLoader tests
- Click using `TriggerClick` as notifications move around quite a bit.
- Ensure any notifications from a previous test method are cleaned up.
2022-08-31 01:40:30 +09:00
Dean Herbert
31a9980686 Update remaining test expectations with new behaviour 2022-08-31 00:57:30 +09:00
Dean Herbert
a62ba9e0d9 Remove notification blocking behaviour of first run setup 2022-08-31 00:57:18 +09:00
Dean Herbert
ed11b1ba6f Improve forwarding flow to not use piling delegates 2022-08-31 00:40:53 +09:00
Dean Herbert
224ab29ef4 Don't dismiss toasts while hovered (and adjust timings slightly) 2022-08-30 21:19:51 +09:00
Dean Herbert
403fc18976 Fix notification completion events not being run when overlay not visible 2022-08-30 21:13:43 +09:00
Dean Herbert
a7110666a0 Play notification appear sample immediately 2022-08-30 21:13:43 +09:00
Dean Herbert
95ce78a50c Reduce notification post delay now that it's less important 2022-08-30 21:13:43 +09:00
Dean Herbert
b8300ae60a Add toast notification tray 2022-08-30 21:13:43 +09:00
Dean Herbert
7b006f1f22 Add flash when a new notification is displayed to draw attention 2022-08-30 20:34:27 +09:00
Dean Herbert
60413e3e7b Enable masking for main content to avoid underlap with close button on word wrap failure. 2022-08-30 19:17:41 +09:00
Dean Herbert
6b71b4656d Remove ProgressNotification vertical movement and delay 2022-08-30 19:16:59 +09:00
Dean Herbert
d600058c98 Assert non-null in ProfileHeader to appease r# 2022-08-30 18:09:10 +09:00
Dean Herbert
c846bf20a7 Add background hover and adjust remaining metrics 2022-08-30 18:06:48 +09:00
Dean Herbert
bea12ab3c2 Rename NotificationContent to MainContent 2022-08-30 18:06:48 +09:00
Dean Herbert
09aa3e065d Move colouring to full icon content rather than background 2022-08-30 18:06:48 +09:00
Dean Herbert
0f203531d9 Allow customising the "close" button icon 2022-08-30 18:06:48 +09:00
Dean Herbert
1484ae19f0 Initial design update pass 2022-08-30 18:06:48 +09:00
Dean Herbert
b8fda1a16f Apply NRT to notification classes
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
ansel
545e0bbcef Adjust inheritors and test 2022-08-29 22:49:25 +03:00
ansel
5343c26452 Control colour via Current bindable 2022-08-29 22:48:27 +03:00
ansel
7faeed88b0 Add ability to override width of value area 2022-08-29 22:08:43 +03:00
Dean Herbert
a215d009fe Update Remove/RemoveRange/RemoveAll calls in line with framework changes 2022-08-29 15:57:40 +09:00
Dan Balasescu
423f6f90f2 Remove async calls from ScoreManager 2022-08-29 15:34:08 +09:00
ansel
039f009562 Inherit difficulty multiplier display from ModsEffectDiplay 2022-08-27 20:26:05 +03:00
ansel
3e828c3416 Move base layout from DifficultyMultiplierDisplay to another class 2022-08-27 20:11:38 +03:00
Dean Herbert
6dc859973b
Merge branch 'master' into fix-playlist-overlay-test-failures 2022-08-26 20:25:53 +09:00
Bartłomiej Dach
968f656585
Merge branch 'master' into copyexternalurl-dialog 2022-08-24 21:21:11 +02:00
Dean Herbert
6a0d23cf96 Nest dialog class and apply NRT 2022-08-24 17:39:22 +09:00
Dean Herbert
9f9deef438 Reword slightly 2022-08-24 17:37:41 +09:00
Andrew Hong
9ee26c575d Made button blue 2022-08-24 04:04:44 -04:00
Andrew Hong
b24513038c Add popupdialog button to copy url 2022-08-24 03:35:19 -04:00
Andrew Hong
edd50dc05b Add profile url context menu to user container 2022-08-24 03:07:03 -04:00
Dean Herbert
c840977acb Fix filtering potentially not running after new items added 2022-08-23 20:42:20 +09:00
Dean Herbert
058d67f8e8
Merge pull request #19695 from naoei/ruleset-localization
Change most ruleset-accessible string types to Localisable strings
2022-08-22 16:13:23 +09:00
Dan Balasescu
0815b01b75
Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
2022-08-22 15:44:00 +09:00
Dean Herbert
d199b3b100 Update GetVariantName to also support localisation 2022-08-22 14:51:00 +09:00
Dan Balasescu
e1fa959f0b Fix language change removing mod column bold text 2022-08-22 13:00:47 +09:00
Bartłomiej Dach
aa15e84bea
Adjust rounding in mod select difficulty multiplier to match song select footer
The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
cause the difficulty multiplier to use a different midpoint rounding
strategy than `double.ToString()`, which is the one that the song select
footer relies on. For example, a value of 0.015 would be rounded down
to 0.01 by `double.ToString()`, but rounded up to 0.02
by `BindableDouble`.

Fix the discrepancy by just deleting the `Precision` spec. Since the
value of the bindable would go through `ToLocalisableString(@"N2")`
anyway, it was redundant as is.

Fixes #19889.
2022-08-21 23:15:49 +02:00
Bartłomiej Dach
3d14b14cfe
Use alternative method for checking panel readiness to eliminate bool flag 2022-08-17 21:56:11 +02:00
Bartłomiej Dach
3109066e34
Rename {Requires -> Pending}Configuration 2022-08-16 22:45:24 +02:00
Bartłomiej Dach
6bfdfeb153
Refactor mod panel selection logic to avoid overwriting 2022-08-16 22:41:35 +02:00
Bartłomiej Dach
10daac6752
Only open mod customisation panel on explicit selection of single mod 2022-08-15 20:38:23 +02:00
Bartłomiej Dach
f860bc11ee
Fix several schedule-related issues arising from new column addition 2022-08-15 20:38:16 +02:00
Bartłomiej Dach
5ff2e41a55
Add preset column to mod select test scene 2022-08-15 18:38:37 +02:00
Nao
c940f5abcb
Merge branch 'master' into ruleset-localization 2022-08-14 15:17:44 -04:00
naoei
45e9eda9e7 Localise hit result name 2022-08-14 14:57:02 -04:00
basseX
383afe04f3 Remove not needed override 2022-08-14 15:15:36 +02:00
basseX
932becc4b2 Remove CommentMarkdownTextFlowContainer and rather use base-class OsuMarkdownTextFlowContainer 2022-08-14 10:11:49 +02:00
basseX
b05acb0073 Make CommentMarkdownTextFlowContainer render images 2022-08-13 21:32:24 +02:00
Dean Herbert
b76e5757e1 Fix InSelectedCollection not being applied to newly imported beatmaps 2022-08-12 15:06:34 +09:00
Dean Herbert
5111bad86c Refactor TestScenePlaylistOverlay to use realm for testing
Removes the dual-purpose flow which existed only for testing.
2022-08-12 15:06:34 +09:00
Dan Balasescu
1721a91168
Merge pull request #19661 from peppy/overlay-key-binding-organisation
Reorganise global bindings and split out overlay bindings to make things easier to find
2022-08-10 21:18:28 +09:00
Dan Balasescu
76fea25668
Merge pull request #19646 from its5Q/settings-localisation
Add missing localisation for settings enums
2022-08-10 18:51:52 +09:00
Dan Balasescu
888c4c8e08
Merge pull request #19662 from peppy/startup-correct-username
Use a placeholder user with the correct username during login process
2022-08-10 13:09:37 +09:00
its5Q
abca3d1b2a Prefix common strings for context 2022-08-10 00:35:19 +10:00
Dean Herbert
beb3d41f0c Fix unsafe usage of APIAccess.LocalUser in BeatmapListingOverlay 2022-08-09 17:11:44 +09:00
Dean Herbert
a71c2bbe28 Split overlay toggles into own section in key bindings
Things were getting hard to find..
2022-08-09 17:01:38 +09:00
Dean Herbert
32852e5b21 Fix potentially thread-unsafe LocalUser usage 2022-08-09 16:01:04 +09:00
Dean Herbert
5d8bd1de28 Share localised strings with expanded display message 2022-08-09 15:57:16 +09:00
Dean Herbert
3f8cedff3a Add tooltips showing current connecting status 2022-08-09 15:51:27 +09:00
Dean Herbert
c35b4ef914 Display connecting / failing states on toolbar user display 2022-08-09 15:51:10 +09:00
Bartłomiej Dach
f74fb3491e
Use alternative implementation of preset panel cleanup 2022-08-08 21:08:54 +02:00
Bartłomiej Dach
a0a6e1faee
Fix spurious sample playbacks from already-removed panels 2022-08-08 20:30:55 +02:00
Bartłomiej Dach
f21a51aa24
Simplify mirror copy of task logic in ModColumn 2022-08-08 19:20:50 +02:00
Bartłomiej Dach
00333fb0d2
Change ?? false test to == true for legibility 2022-08-08 19:19:13 +02:00
its5Q
5080d62e77 Add missing localisation for settings enums 2022-08-08 21:51:23 +10:00
Dean Herbert
070d156e89 Simplify task logic in ModPresetColumn 2022-08-08 16:13:52 +09:00
Bartłomiej Dach
7d6efaebbe
Add maintenance settings section for mod presets 2022-08-07 16:20:31 +02:00
Bartłomiej Dach
839409d7ac
Add preset column to solo mod select overlay 2022-08-07 16:20:31 +02:00
Bartłomiej Dach
b318bbd5e6
Allow non-homogenous column types in mod select overlay 2022-08-07 16:20:31 +02:00
Bartłomiej Dach
0287c49ca8
Implement user selection logic for mod presets 2022-08-07 16:20:20 +02:00