7848 Commits

Author	SHA1	Message	Date
Dean Herbert	260cf793fe	Add test coverage of more advanced frame delivery scenarios to TestSceneSpectatorPlayback	2022-02-24 02:28:13 +09:00
Dean Herbert	c94e7e2abe	Add ability to simulate network failures to TestSpectatorClient	2022-02-24 02:23:48 +09:00
Dean Herbert	14c8ce50a0	Prefix all test send methods in TestSpectatorClient with Send	2022-02-24 02:23:48 +09:00
Dean Herbert	5e7dd31f6d	Merge branch 'master' into mod-overlay/switches	2022-02-23 13:49:23 +09:00
Bartłomiej Dach	1a358698fb	Merge branch 'master' into startup-protocol-handling	2022-02-22 22:42:16 +01:00
Dean Herbert	5efffa208a	Add test coverage of beatmap set overlay actually showing requested beatmap	2022-02-22 17:08:09 +09:00
Dean Herbert	347a2346b9	Fix TestSceneEditorSaving not waiting for timeline load ... As seen at https://github.com/ppy/osu/runs/5276431764?check_suite_focus=true.	2022-02-22 15:41:08 +09:00
Bartłomiej Dach	cfc41a0a36	Implement small mod switch	2022-02-22 00:26:35 +01:00
Bartłomiej Dach	5186693dad	Implement tiny mod switch	2022-02-22 00:26:35 +01:00
Bartłomiej Dach	d71e511413	Merge branch 'master' into spotlights-on-top	2022-02-21 23:42:02 +01:00
Bartłomiej Dach	e3ae52360e	Merge branch 'master' into leaderboard-score-timeref	2022-02-21 20:50:00 +01:00
Dean Herbert	98c008b95f	Fix test failures due to order change	2022-02-21 19:48:39 +09:00
Dan Balasescu	46b408be75	Update tests to match new behaviour	2022-02-21 18:19:55 +09:00
Dean Herbert	ab8b502709	Add test coverage of spotlights being at the top of the listing	2022-02-21 18:01:46 +09:00
Dean Herbert	abe1a3990a	Merge branch 'master' into leaderboard-score-timeref	2022-02-21 12:11:10 +09:00
dekrain	15ed9ec4fa	Merge scoreboard and leaderboard implementations together	2022-02-19 20:47:02 +01:00
Dean Herbert	3abbf07fb3	Revert local registrations in test scenes	2022-02-18 16:52:34 +09:00
Dean Herbert	631c23ea3a	Merge branch 'master' into beatmap-decoder-ruleset-store	2022-02-18 16:52:33 +09:00
Dean Herbert	29c5683ba3	Add handling of beatmap links on startup	2022-02-18 16:14:37 +09:00
Dean Herbert	98aaf83177	Add a centralised constant for the osu URL schema protocol	2022-02-18 15:57:37 +09:00
Dean Herbert	bbc4ea1203	Merge branch 'master' into better-new-difficulty-naming	2022-02-17 19:21:33 +09:00
dekrain	f4d1e6f600	Add tests for timerefs	2022-02-17 10:38:29 +01:00
Bartłomiej Dach	e459523afe	Adjust beatmap creation test cases to new behaviour	2022-02-17 00:28:18 +01:00
Bartłomiej Dach	cb9ffc655a	Add tests showing expected behaviour of naming helper	2022-02-17 00:28:13 +01:00
Dean Herbert	5477af08c5	Register an AssemblyRulesetStore in tests which don't use OsuGameBase	2022-02-16 17:21:57 +09:00
Dean Herbert	0138f22c8d	Update existing usages to point to RealmRulesetStore	2022-02-16 17:13:54 +09:00
Dan Balasescu	5dd9771c5f	Remove mod multipliers from being applied to scores	2022-02-16 16:27:27 +09:00
Dean Herbert	7e24b36f26	Merge branch 'master' into remove-playlistitem-beatmap	2022-02-16 14:24:57 +09:00
Dean Herbert	6a08fd57ef	Rename "client" fields in tests to specify whether spectator or multiplayer	2022-02-16 09:52:18 +09:00
Dean Herbert	187870b794	Merge branch 'master' into fix-multi-cache-dependencies	2022-02-16 09:44:37 +09:00
Dean Herbert	954ae60b81	Merge branch 'master' into copy-existing-difficulty	2022-02-16 08:55:12 +09:00
Dan Balasescu	ea5bb46fb8	Merge branch 'master' into net6	2022-02-16 00:40:04 +09:00
Dan Balasescu	f5b34e0313	Fix some test failures due to now-async lookups	2022-02-16 00:01:22 +09:00
Dan Balasescu	bdc3b76df0	Remove beatmap bindable from PlaylistItem	2022-02-15 23:50:08 +09:00
Dan Balasescu	94a974e1c9	Make OnlinePlayBeatmapAvailabilityTracker look up the online beatmap	2022-02-15 23:41:50 +09:00
Dan Balasescu	ccd265ebe7	Handle beatmap lookup requests in TestRoomRequestsHandler	2022-02-15 23:41:50 +09:00
Dan Balasescu	539cbe62c6	Fix incorrect usages of user lookup cache in tests	2022-02-15 21:23:24 +09:00
Dan Balasescu	c48a0dc993	Move UserLookupCache to online play test dependencies	2022-02-15 20:56:46 +09:00
Dean Herbert	a8f09a8676	Merge branch 'master' into remove-playlistitem-ruleset-mods	2022-02-15 17:40:39 +09:00
Dan Balasescu	03106e846c	Fix test failures due to async mod icon loads	2022-02-15 17:15:00 +09:00
Dean Herbert	d79845fb1d	Revert NUnit3TestAdaptor (again) ... Console output is still broken. See https://github.com/ppy/osu/runs/5196023462?check_suite_focus=true.	2022-02-15 17:06:34 +09:00
Dean Herbert	b1cf014dc2	Add test coverage of EF to Realm migration process	2022-02-15 17:00:17 +09:00
Dean Herbert	f03de16ee5	Add a test EF database ... Created on d8a23aad4 (just before skins were migrated to realm). This contains: - 2 beatmap sets (intro and disco prince) - 1 score (set on disco prince using autopilot/DT) - 1 skin (haxwell) - 322 named files (from skin) - 5 named files (from beatmaps) - 270 total file infos	2022-02-15 16:56:00 +09:00
Dan Balasescu	5b765581d8	Fix free mod selection not showing allowed mods	2022-02-15 16:28:15 +09:00
Dan Balasescu	efeba30b9f	Remove ruleset and mod bindables from PlaylistItem	2022-02-15 16:28:15 +09:00
Dean Herbert	60153bb69d	Update nuget packages to highest usable versions ... EF packages are intentionally pinned to 5.0.14 as higher versions no longer support `netstandard2.1`, which we require for xamarin projects.	2022-02-15 15:19:23 +09:00
Bartłomiej Dach	1685e214d3	Adjust test coverage to cover desired copy naming scheme	2022-02-14 19:59:54 +01:00
Dean Herbert	db74a226c0	Fix test regression due to mouse overlapping settings overlay	2022-02-15 02:54:45 +09:00
Dean Herbert	02f58a82fc	Use WaitSafely() in tests where it was not already being used	2022-02-15 02:35:08 +09:00
Dean Herbert	5b30921cbf	Merge branch 'master' into net6	2022-02-14 22:06:35 +09:00
Dean Herbert	b9d9fc56af	Move files to UI namespace	2022-02-14 17:51:39 +09:00
Dean Herbert	80ba06b0e3	Merge branch 'master' into expandable-controls	2022-02-14 16:57:45 +09:00
Bartłomiej Dach	13abc392bd	Add failing test coverage for not copying online properties	2022-02-13 18:54:52 +01:00
Bartłomiej Dach	90c48de9f8	Add failing test coverage for save of copied beatmap keeping old beatmap file	2022-02-13 14:01:23 +01:00
Bartłomiej Dach	1292722a00	Add failing test coverage for correct combo colour copy	2022-02-13 14:01:22 +01:00
Bartłomiej Dach	fd1c8c3614	Add failing test coverage for correct beatmap difficulty copy	2022-02-13 14:01:21 +01:00
Bartłomiej Dach	eb939547a9	Add test coverage for difficulty copy flow	2022-02-13 14:01:21 +01:00
Bartłomiej Dach	0d1171b7fa	Adjust existing test coverage to pass	2022-02-13 14:01:20 +01:00
Dean Herbert	6005daeba8	Fix fire-and-forget async calls to use WaitSafely	2022-02-11 16:02:42 +09:00
Dean Herbert	f012f64fd1	Add test coverage checking carousel panel visual state after ruleset filter change	2022-02-11 15:21:01 +09:00
Dean Herbert	eda213e4de	Merge pull request #16827 from smoogipoo/spectator-state-rework ... Add user state to SpectatorState, allowing multiplayer to continue to results	2022-02-11 01:48:47 +09:00
Dean Herbert	19cb8cb03a	Update tests	2022-02-10 19:35:28 +09:00
Dean Herbert	176bb4a4e2	Update desktop projects to target .NET 6	2022-02-10 17:42:09 +09:00
Dan Balasescu	ffc4c64f7e	Unify namings across the board	2022-02-09 12:10:07 +09:00
Dan Balasescu	4966c4e974	Remove redundant parameter	2022-02-09 11:51:47 +09:00
Dan Balasescu	886d1d2df6	Refactorings	2022-02-08 21:29:43 +09:00
Dan Balasescu	4c76027178	Rename completed state to passed	2022-02-08 20:29:49 +09:00
Dan Balasescu	0d99017178	Add state tests	2022-02-08 20:27:08 +09:00
Dan Balasescu	45b3f472ab	Merge branch 'master' into spectator-state-rework	2022-02-08 19:51:50 +09:00
Dan Balasescu	9c2d57d707	Add failing test	2022-02-08 19:36:16 +09:00
Henry Lin	b31c1513f6	Fix test failure ... The cursor was clicking too far to the right.	2022-02-05 22:41:04 +08:00
Dean Herbert	ee0ff5c33f	Merge pull request #16774 from smoogipoo/fix-broken-test-scene ... Fix test scene broken without being logged in	2022-02-04 23:55:51 +09:00
Dan Balasescu	09728a29ed	Merge branch 'fix-broken-test-scene' into spectator-state-rework	2022-02-04 22:42:10 +09:00
Dean Herbert	98f61415c2	Merge branch 'master' into mvp-safe-area-support	2022-02-04 20:05:35 +09:00
Dean Herbert	002cc7261b	Merge pull request #16773 from smoogipoo/fix-spectator-restart-crash ... Fix crash when gameplay is started while inside multiplayer spectator screen	2022-02-04 19:23:08 +09:00
Dan Balasescu	fa3d1115fa	Remove online api requirement	2022-02-04 19:17:50 +09:00
Dan Balasescu	dd63b1a350	Fix broken spectator playback test scene	2022-02-04 19:12:02 +09:00
Dean Herbert	6457cf8d9b	Fix weird formatting in TestSceneSafeArea	2022-02-04 18:45:40 +09:00
Dan Balasescu	d5269ba05b	Merge branch 'fix-spectator-restart-crash' into spectator-state-rework	2022-02-04 17:59:18 +09:00
Dan Balasescu	b41655d5b9	Fix crash when gameplay starts while in multi-spectator screen	2022-02-04 17:47:41 +09:00
Dean Herbert	1444df4d50	Add test scene for playing with safe areas	2022-02-04 16:39:10 +09:00
Dan Balasescu	63064d682b	Merge pull request #16743 from hlysine/extended-statistics-without-replay ... Allow statistic items in results screen to display without needing to watch a replay	2022-02-04 15:07:52 +09:00
Salman Ahmed	bbef12e72c	Refactor ExpandingControlContainer to no longer rely on controls	2022-02-04 05:45:12 +03:00
Bartłomiej Dach	b7d7e6612e	Merge branch 'master' into new-difficulty-creation-v3	2022-02-03 16:36:18 +01:00
Dan Balasescu	d4ebff6ea1	Add failing test	2022-02-03 23:18:22 +09:00
Dan Balasescu	483977d5c8	Merge branch 'master' into spectator-state-rework	2022-02-03 19:59:07 +09:00
Dean Herbert	b2efce2656	Merge branch 'master' into expandable-controls	2022-02-03 19:23:34 +09:00
Dean Herbert	df9d99f5aa	Merge branch 'master' into extended-statistics-without-replay	2022-02-03 18:59:48 +09:00
Henry Lin	a27d0572ed	Add test cases for manual testing	2022-02-03 17:00:40 +08:00
Dean Herbert	41aa4b8cca	Fix TestSelectingFilteredRuleset failing under visual tests due to using local database	2022-02-03 16:04:05 +09:00
Dean Herbert	6355ac6663	Wait for DialogOverlay load in more tests ... Apparently the previous fix was not enough as this can still be seen failing (https://github.com/ppy/osu/runs/5046718623?check_suite_focus=true). This change is copying from what other tests use seemingly reliably, such as `TestScenePerformFromScreen`)	2022-02-03 15:10:08 +09:00
Bartłomiej Dach	afc48d86df	Add failing test coverage for save after safeties addition	2022-02-02 21:57:10 +01:00
Bartłomiej Dach	87e2e83288	Add test coverage for difficulty name clash cases	2022-02-02 21:55:34 +01:00
Bartłomiej Dach	0d51c015ad	Add basic test coverage for new difficulty creation	2022-02-02 21:55:34 +01:00
Dan Balasescu	fcbba3d948	Rename PlayingUserStates -> WatchingUserStates	2022-02-02 23:11:29 +09:00
Dan Balasescu	589f5e7a31	Update test which has now been resolved	2022-02-02 23:09:38 +09:00
Dan Balasescu	6d3bc005ea	Merge branch 'master' into spectator-state-rework	2022-02-02 18:57:04 +09:00
Dan Balasescu	b5fb3b7dae	Fix crash when selecting swap mod as freemod	2022-02-02 18:42:22 +09:00
Dean Herbert	6d962e7925	Merge pull request #16726 from dekrain/leaderboard-score-tooltip ... Add basic tooltip for leaderboard scores	2022-02-02 13:56:45 +09:00
Dean Herbert	35b7653290	Revert mod flow changes and add visual test coverage showing an overflow case	2022-02-02 09:13:19 +09:00
Bartłomiej Dach	3674ed15ce	Remove unused game host parameter ... No longer used since eeccf836ec.	2022-02-01 21:53:21 +01:00
Bartłomiej Dach	b978010b48	Remove unused allowMissing parameter in audio file check test ... No longer used since 7f95400f46.	2022-02-01 21:53:21 +01:00
Bartłomiej Dach	7cdf63c654	Remove unused FindProvider() methods ... No longer needed since 39f99bf785.	2022-02-01 21:53:21 +01:00
Bartłomiej Dach	75101b1105	Remove unused ruleset ctor params from test beatmap model managers ... No longer used since 00e3af3366.	2022-02-01 21:49:41 +01:00
Dan Balasescu	41007169f7	Give SpectatorState a user state	2022-02-01 21:51:05 +09:00
Dean Herbert	15479ae046	Add test coverage of no header doing nothing	2022-02-01 16:55:28 +09:00
Dean Herbert	3ca2c90684	Add test scores in BeatmapLeaderboard test scene with more mods	2022-02-01 16:35:25 +09:00
Dan Balasescu	781cb9f18d	Move HasPassed/HasFailed into GameplayState	2022-02-01 14:46:24 +09:00
Dan Balasescu	502e6af008	Remove PlayingUsers list from SpectatorClient	2022-02-01 14:42:30 +09:00
Dan Balasescu	0641264a11	Merge branch 'master' into spectator-consistency-frames	2022-02-01 14:35:30 +09:00
Dan Balasescu	4fb565e15f	Reset ScoreProcessor from statistics replay frames	2022-01-31 21:32:56 +09:00
Dan Balasescu	0458d408bb	Add replay statistics frames to FramedReplayInputHandler	2022-01-31 18:53:47 +09:00
Dan Balasescu	4727aeda01	Give last bundled replay frame the frame header	2022-01-31 18:53:47 +09:00
Dan Balasescu	f3d4756c7f	Merge pull request #16713 from frenzibyte/fix-spectator-gcc-state-2 ... Fix multiplayer spectator occasionally rewinding time unexpectedly	2022-01-31 18:33:08 +09:00
Dan Balasescu	62603e78fd	Merge pull request #16714 from frenzibyte/rewrite-hardware-correction-clock ... Rewrite `HardwareCorrectionOffsetClock` to handle seeking on different gameplay rates	2022-01-31 17:32:22 +09:00
Dean Herbert	575d9671bf	Merge pull request #16717 from peppy/fix-dialog-overlay-missing-test-failures ... Fix test failures if `DialogOverlay` is not loaded in time	2022-01-31 17:06:24 +09:00
Dean Herbert	25cbe5a0de	Remove acronym shortening of GameplayClockContainer	2022-01-31 15:23:31 +09:00
Dean Herbert	9001c3a396	Fix test failures if DialogOverlay is not loaded in time ... As seen at https://github.com/ppy/osu/runs/4999391205?check_suite_focus=true, where `DialogOverlay` hasn't loaded in single file yet.	2022-01-31 15:17:07 +09:00
Dean Herbert	c8c0ae5658	Merge branch 'master' into flush-frames-end-play	2022-01-31 15:12:41 +09:00
Dean Herbert	57f793aff0	Rename dictionary and make private for added safety	2022-01-31 15:12:08 +09:00
Dan Balasescu	e9f3e7f5cb	Merge pull request #16703 from peppy/leaderboard-component-fixes ... Rewrite `Leaderboard` component to bring up to current code standards	2022-01-31 14:33:04 +09:00
Salman Ahmed	2b999f9780	Add failing test case	2022-01-31 01:40:07 +03:00
Dean Herbert	f8939af5e6	Track loading via state as well	2022-01-31 01:12:03 +09:00
Dean Herbert	6a21d58325	Avoid test failures on non-triangle intro tests	2022-01-30 18:59:18 +09:00
Dean Herbert	1dbcb5ab63	Add test coverage of intro fail scenario	2022-01-30 18:51:16 +09:00
Dean Herbert	04dbb5d3c6	Disallow setting "NoScores" externally as it is handled internally	2022-01-30 16:18:19 +09:00
Dean Herbert	acc1199add	Consolidate flows of Set operations, either result or error	2022-01-30 16:16:00 +09:00
Dean Herbert	c401629dd8	Also refactor placeholder logic to make more sense	2022-01-30 10:50:32 +09:00
Salman Ahmed	4f4f60248f	Add failing test case	2022-01-30 01:46:10 +03:00
Dean Herbert	06660ff960	Fix null beatmap in test scene	2022-01-30 03:02:56 +09:00
Dean Herbert	d21464ea61	Fix assertions to work in both directions	2022-01-30 02:54:51 +09:00
Dean Herbert	51acf79935	Change test exposure to property instead of method	2022-01-30 02:29:51 +09:00
Dean Herbert	9861c50b33	Remove pointless tests that no longer show anything valid	2022-01-30 00:03:22 +09:00
Dean Herbert	a915b9cd30	Fix occasional failures in TestSceneDeleteLocalScore	2022-01-29 23:58:57 +09:00
Dean Herbert	661fec7c8a	Make score setter private	2022-01-29 23:58:57 +09:00
Dean Herbert	aee93934d5	Rename methods to make more sense (and always run through AddOnce)	2022-01-29 23:58:57 +09:00
Dean Herbert	4c97ed676f	Fix score presentation tests not correctly entering song select before running	2022-01-29 14:46:24 +09:00
Bartłomiej Dach	1253e1ecc1	Replace LINQ Count() invocation with count property access	2022-01-28 20:25:12 +01:00
Dan Balasescu	3037a3a769	Purge final spectator frames before ending play	2022-01-28 22:26:05 +09:00
Dan Balasescu	bda3cdc9a7	Add tests	2022-01-28 19:29:30 +09:00
Dan Balasescu	f021a274d2	Merge pull request #16681 from peppy/fix-delete-local-scores ... Fix delete local scores via "Clear all scores" button crashing the game	2022-01-28 17:01:31 +09:00
Dan Balasescu	b94984bd2d	Merge pull request #16678 from peppy/hold-for-menu-always-fade ... Ensure hold for menu button fades out if the cursor is never moved	2022-01-28 15:55:41 +09:00
Dean Herbert	2453bf5ed0	Add test coverage of the same thing but via "clear all scores" button	2022-01-28 15:54:53 +09:00
Dean Herbert	778eebc94d	Add test coverage of local score import and deletion	2022-01-28 15:50:36 +09:00
Dan Balasescu	32f9299fe0	Remove unused using	2022-01-28 15:26:29 +09:00
Dean Herbert	28c8e07e3f	Ensure hold for menu button fades out if the cursor is never moved ... Closes https://github.com/ppy/osu/discussions/16669.	2022-01-28 14:48:35 +09:00
Dean Herbert	f32d56e213	Bring HoldForMenuButton tests up-to-date in code quality	2022-01-28 14:48:17 +09:00
Bartłomiej Dach	7dc3940dee	Add test coverage for preserving legacy beatmap info defaults	2022-01-27 21:49:26 +01:00
Bartłomiej Dach	04d6ca59a3	Merge branch 'master' into song-select-scroll-position-during-delete	2022-01-27 20:46:19 +01:00
Dean Herbert	e872877185	Merge pull request #16648 from peppy/fix-song-select-tests ... Fix song select tests not waiting for beatmap imports to arrive	2022-01-27 23:00:58 +09:00
Dean Herbert	fae4f8bd8e	Move nulling of previous songSelect to SetUpSteps instead	2022-01-27 21:59:44 +09:00
Dean Herbert	7af23328a4	Merge branch 'master' into ruleset-ordering-fix	2022-01-27 21:46:03 +09:00
Dean Herbert	831fa44433	Fix song select tests not waiting for beatmap imports to arrive ... After the change to realm, notification fires could take a frame or two. We aren't accounting for this. Fixes test failures like https://github.com/ppy/osu/runs/4963255990?check_suite_focus=true	2022-01-27 19:35:42 +09:00
Dean Herbert	a5d422e82c	Merge branch 'master' into ruleset-id-fixes	2022-01-27 17:07:18 +09:00
Dean Herbert	29a4ec949f	Merge pull request #16637 from bdach/editor-changes-not-resetting ... Fix changes to beatmap info made in editor persisting after exit without save	2022-01-27 17:02:42 +09:00
Dean Herbert	f2cecad83b	Add failing test coverage showing carousel deletions don't keep scroll position	2022-01-27 16:52:02 +09:00
Dean Herbert	5637fd64d6	Perform ordering using IComparable instead	2022-01-27 15:59:20 +09:00
Dean Herbert	5288eedd31	Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID	2022-01-27 15:38:03 +09:00
Dean Herbert	714177cce1	Remove pointless constructor in RulesetInfo	2022-01-27 15:37:27 +09:00
Dean Herbert	f30d63107a	Add SortID to RulesetInfo to allow stable ordering of rulesets for display	2022-01-27 15:35:16 +09:00
Bartłomiej Dach	e0616476e2	Fix test gameplay tests failing due to beatmap refetch on suspend	2022-01-26 21:15:49 +01:00
Bartłomiej Dach	4382adad82	Add test coverage for editor changes not resetting after exit without save	2022-01-26 21:15:49 +01:00
Dean Herbert	0c2ed2f9a7	Add failing test coverage of incorrect filter ruleset matching	2022-01-27 01:25:57 +09:00
Derrick Timmermans	6ec9c5c21a	Use default custom ruleset ID	2022-01-26 16:23:00 +01:00
Derrick Timmermans	e712fab299	Add test for custom ruleset conversion filtering	2022-01-26 16:14:07 +01:00
Dan Balasescu	cf9ee43b17	Merge pull request #16608 from peppy/playlist-overlay-optimisations ... Optimise `PlaylistOverlay` and reduce startup overhead of `MusicController`	2022-01-26 20:28:33 +09:00
Dan Balasescu	94d3e2c90c	Merge branch 'master' into fix-out-of-order-events-on-block-fail	2022-01-26 19:08:55 +09:00
Dean Herbert	abe2cccaae	Fix completely invalid method of testing realm migration	2022-01-26 19:03:26 +09:00
Dan Balasescu	cdca1285ab	Merge branch 'master' into playlist-overlay-optimisations	2022-01-26 19:01:33 +09:00
Dan Balasescu	4a51bab9ac	Merge pull request #16622 from peppy/fix-results-score-switch-crash ... Fix crash at results screen when viewing another score panel after playing	2022-01-26 16:59:39 +09:00
Salman Ahmed	a34b8fc4d0	Merge branch 'master' into expandable-controls	2022-01-26 10:36:22 +03:00
Salman Ahmed	eb83b7fe0a	Update existing implementation with changes	2022-01-26 10:18:17 +03:00
Dean Herbert	68ee80c5de	Merge pull request #16623 from frenzibyte/refactor-editor-save-test ... Refactor editor saving test scene for scalability	2022-01-26 15:40:39 +09:00
Dan Balasescu	701f00a4b1	Merge pull request #16609 from peppy/fix-realm-related-failures ... Fix some realm-related test failures	2022-01-26 15:31:18 +09:00
Dean Herbert	91e0d1021f	Merge branch 'master' into fix-out-of-order-events-on-block-fail	2022-01-26 15:21:10 +09:00
Dean Herbert	d0a2818847	Fix incorrect testing	2022-01-26 15:14:43 +09:00
Dean Herbert	9532454e2a	Remove ILive remnants	2022-01-26 15:12:07 +09:00
Dean Herbert	ba46827ac0	Merge branch 'master' into playlist-overlay-optimisations	2022-01-26 15:11:14 +09:00
Dean Herbert	3491b77c8c	Fix ScoreInfo.RealmUser not getting deep cloned correctly ... I'm still not at all happy with the play-to-results flow (with multiple clones), but this will have to do for now.	2022-01-26 14:27:48 +09:00
Salman Ahmed	064468faad	Refactor editor saving test scene for scalability	2022-01-26 07:57:46 +03:00
Dean Herbert	cd71ec0edd	Remove ILive<> interface (and use abstract Live<> instead)	2022-01-26 13:38:56 +09:00
Dean Herbert	dda513dd08	Change PlaylistOverlay to use ILive	2022-01-26 12:19:59 +09:00
Dean Herbert	bdf215c576	Merge branch 'master' into improve-timeline-zoom	2022-01-26 03:40:53 +09:00
Dean Herbert	5085eb6801	Ensure gameplay starts by dismissing any notifications in TestSceneChangeAndUseGameplayBindings	2022-01-26 03:39:01 +09:00
Salman Ahmed	ad18bc4983	Update timeline selection test scene with zoom changes	2022-01-25 18:57:39 +03:00
Dean Herbert	5b82eaf112	Merge branch 'master' into fix-beat-divisor-not-saving	2022-01-25 23:29:37 +09:00
Salman Ahmed	6c69df815a	Update editor test scenes to set working beatmap properly	2022-01-25 15:56:27 +03:00
Salman Ahmed	4d8c5ebb0c	Merge branch 'master' into fix-beat-divisor-not-saving	2022-01-25 12:30:05 +03:00
Salman Ahmed	b2b6672095	Add failing test asserts	2022-01-25 11:56:38 +03:00
Dean Herbert	c0ed308016	Use more correct method of deletion in TestScenePlaySongSelect	2022-01-25 17:55:39 +09:00
Dean Herbert	90a7dd7711	In gameplay bindings test, ensure a selection is made before attempting to enter gameplay	2022-01-25 17:55:33 +09:00
Dean Herbert	ffd7877a1e	Remove synchronization context hacks in realm tests	2022-01-25 17:41:22 +09:00
Dean Herbert	83b0e4572a	Fix test failures	2022-01-25 16:51:21 +09:00
Dan Balasescu	d8270fe14f	Merge pull request #16604 from peppy/less-async-import ... Remove `Task` from the inner-most `Import` method in `RealmArchiveModelImporter`	2022-01-25 16:47:07 +09:00
Dan Balasescu	1c6ad56821	Merge pull request #16595 from peppy/realm-block-timeout-assert-failure ... Fix a failed `BlockAllOperations` leaving update realm in unretrieved state	2022-01-25 16:03:13 +09:00
Dean Herbert	778d2a71b4	Remove Task from the inner-most Import method in RealmArchiveModelImporter ... One of my pending work items for post-realm merge. The lowest-level import task is no longer asynchronous, as we don't want it to span multiple threads to allow easier interaction with realm. Removing the `Task` spec simplifies a heap of usages. Individual usages should decide whether they want to run the import asynchronously, by either using an alternative override or spooling up a thread themselves.	2022-01-25 15:30:29 +09:00
Dean Herbert	ae0fea8e26	Fix compilation issues due to misnamed fild	2022-01-25 15:29:45 +09:00
Dan Balasescu	47a13c2eb0	Merge pull request #16603 from peppy/update-framework ... Update framework	2022-01-25 15:15:49 +09:00
Dean Herbert	35e1c7de7d	Merge branch 'master' into realm-block-timeout-assert-failure	2022-01-25 15:05:11 +09:00
Dean Herbert	bda77fb6b3	Merge branch 'master' into realm-block-timeout-assert-failure	2022-01-25 14:47:34 +09:00
Dean Herbert	56d7d81465	Fix broken test due to SynchronizationContext never running expected work	2022-01-25 14:47:21 +09:00
Dan Balasescu	bfa521bdd2	Merge pull request #16593 from peppy/realm-clean-up ... Clean up realm naming	2022-01-25 14:33:53 +09:00
Dan Balasescu	b2114bd2f0	Merge pull request #16601 from peppy/fix-storage-migration-test-failures ... Fix `TestMigration` failing due to changes in realm migration logic	2022-01-25 14:33:35 +09:00
Dean Herbert	86c844bd58	Update remaining usages of GetSuitableHost in template projects	2022-01-25 14:15:29 +09:00
Dean Herbert	8116806db3	Add test coverage of calling BlockAllOperations a second time after timeout	2022-01-25 14:00:58 +09:00
Dean Herbert	dd2caea694	Update GetSuitableHost usages in line with new HostOptions	2022-01-25 13:52:02 +09:00
Dean Herbert	bbcc149e2e	During import if files are found to be missing, ensure they are restored ... This is one step closer to sanity in terms of physical files. As per the comment I have left in place, we really should be checking file sizes or hashes, but to keep things simple and fast I've opted to just cover the "missing file" scenario for now. Ran into this when testing against a foreign `client.realm` by: - Noticing a beatmap doesn't load - Deleting said beatmap - Downloading via beatmap overlay - Beatmap is restored but still doesn't work Note that I've kept the logic where this will undelete an existing import rather than create one from fresh, as I think that is beneficial to the user (ie. it will still keep any linked scores on restore).	2022-01-25 13:44:54 +09:00
Dean Herbert	d7342880f5	Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications	2022-01-25 13:09:48 +09:00
Dean Herbert	e23b10e6a5	Update remaining cases of clashing variable name in realm.Run(realm..	2022-01-25 13:04:05 +09:00
Dean Herbert	3e5c9e8436	Fix cases of Access instead of Realm	2022-01-25 12:58:15 +09:00
Dean Herbert	2d34831b5f	Fix TestMigration failing due to changes in realm migration logic ... Fixes failures as seen at https://github.com/ppy/osu/runs/4927916031?check_suite_focus=true.	2022-01-25 12:54:40 +09:00
Dean Herbert	f30894840c	Update terminology to realm "instance" rather than "context" ... This matches the terminology used by realm themselves, which feels better.	2022-01-24 20:38:38 +09:00
Dean Herbert	6eb2c28e41	Rename RealmContextFactory to RealmAccess	2022-01-24 20:38:07 +09:00
Dean Herbert	9ff9611296	Merge branch 'master' into realm-stable-subscriptions	2022-01-24 18:25:47 +09:00
Dean Herbert	d7db6fa918	Merge branch 'master' into custom-meter	2022-01-24 15:46:44 +09:00
Dean Herbert	6581e8c2d3	Merge pull request #16549 from Susko3/LoginPanel-flag ... Hide the login panel when clicking the country flag	2022-01-24 15:38:50 +09:00
Dean Herbert	40aa873190	Rename register methods to better explain their purpose	2022-01-24 14:37:36 +09:00
Bartłomiej Dach	e236f5d604	Add failing test coverage for correct beatmap filename generation on save	2022-01-23 20:28:19 +01:00
Dean Herbert	0709a2ac9b	Add test coverage of realm subscription scenarios	2022-01-23 20:28:13 +09:00
Dean Herbert	db86394355	Fix TestResources returning a test BeatmapSetInfo that can't be laoded directly into realm	2022-01-23 20:28:04 +09:00
Salman Ahmed	1ea5a2e6a7	Fix incorrect assert step name	2022-01-23 10:11:12 +03:00
Salman Ahmed	6b35c0fe01	Add test scene for ExpandingControlContainer	2022-01-23 05:41:16 +03:00
Bartłomiej Dach	f39f2c93b5	Add control for arbitrary-numerator time signatures	2022-01-22 20:50:31 +01:00
Bartłomiej Dach	735414bc49	Replace TimeSignatures enum with struct for storage of arbitrary meter	2022-01-22 20:50:31 +01:00
Dean Herbert	6a076a684e	Merge branch 'realm-context-use-update-when-feasible' into realm-stable-subscriptions	2022-01-22 13:14:25 +09:00
Dean Herbert	c9db0181d0	Attempt to fix test failures on windows due to context being held open	2022-01-22 12:24:05 +09:00
Susko3	9b63f15e68	Add failing test	2022-01-21 13:58:30 +01:00
Dean Herbert	1f157d729d	Update existing subscriptions to new style ... Fix missing detach calls in `MusicController`	2022-01-21 20:05:03 +09:00
Dean Herbert	114c9e8c1f	Update all usages of CreateContext to use either Run or Write	2022-01-21 17:27:08 +09:00
Dean Herbert	70cc03fe43	Avoid constructor overhead for realm RealmKeyBinding parameterless constructor	2022-01-20 17:29:07 +09:00
Dan Balasescu	7509b31176	Merge pull request #16519 from peppy/fix-legacy-score-import-classic-mod ... Fix legacy score imports not correctly getting classic mod assigned	2022-01-20 14:28:29 +09:00
Dan Balasescu	4f86a2cb61	Merge pull request #16525 from bdach/beatmap-listing-overflow-and-scrolling ... Improve usability of expanded card content on beatmap listing	2022-01-20 14:14:44 +09:00
Bartłomiej Dach	4cad5890c6	Add test coverage for news sidebar showing wrong headers	2022-01-19 23:12:35 +01:00
Bartłomiej Dach	d925e44b40	Add test coverage for beatmap card expanded content clipping	2022-01-19 22:08:52 +01:00
Bartłomiej Dach	fea4400c03	Remove unused using directive	2022-01-19 18:49:37 +01:00
Dean Herbert	a002dacdce	Add test coverage of various ScoreInfo mod set operations	2022-01-19 14:34:27 +09:00
Dean Herbert	bb6f40d16e	Add test coverage of all mod storages containing classic mod post-import	2022-01-19 14:34:27 +09:00
Dan Balasescu	581873f944	Merge pull request #16497 from peppy/top-local-rank-optimisation ... Rewrite `TopLocalRank` to use realm subscriptions	2022-01-19 14:22:12 +09:00
Dan Balasescu	3e5d29ed00	Merge pull request #16505 from peppy/remove-base-difficulty-usage ... Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)	2022-01-19 13:53:55 +09:00
Dean Herbert	201f2d7813	Add comprehensive test coverage for TopLocalRank	2022-01-19 13:48:00 +09:00
Dan Balasescu	2556f1cb87	Merge branch 'master' into optimise-set-detach-part-2	2022-01-19 13:20:38 +09:00
Dan Balasescu	f6f44029e8	Merge pull request #16507 from peppy/more-ingore-rules ... Add some missing `IgnoredAttributes` to reduce automapper overhead	2022-01-19 12:26:37 +09:00
Bartłomiej Dach	7df18c7767	Merge branch 'master' into playlist-test-coverage	2022-01-18 20:17:48 +01:00
Dean Herbert	96d07e20ed	Revert nunit test adaptor version bump until console output bug is resolved ... Tests have started to output too much log content, causing viewing CI failures to be painfully impossible. Roll back for now. Fix may be related to https://github.com/nunit/nunit3-vs-adapter/issues/941, although we don't use filter.	2022-01-19 02:18:58 +09:00
Dean Herbert	1db2135d70	Update tests to match new behaviour	2022-01-19 01:05:47 +09:00
Dean Herbert	67bf95bc91	Remove all usage of AuthorString	2022-01-18 23:30:40 +09:00
Dean Herbert	7f65f3a47f	Remove all usage of BaseDifficulty (and access Difficulty instead)	2022-01-18 22:57:39 +09:00
Dean Herbert	02baad30d7	Merge branch 'master' into global-bindable-thread-safety	2022-01-18 18:12:00 +09:00
Dan Balasescu	73a1f27ce5	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-18 17:31:37 +09:00
Dean Herbert	3e9e7a8fb6	Fix PLaylistsResultsScreen tests falling over due to missing beatmap	2022-01-18 16:48:27 +09:00