35395 Commits

Author	SHA1	Message	Date
Dean Herbert	e6b449fe0b	Fix case of zero rate calculating a zero true gameplay rate	2022-09-07 19:23:44 +09:00
Dean Herbert	1be3b74ff3	Fix multiplayer spectator not getting gameplay adjustments applied	2022-09-07 19:12:34 +09:00
Dean Herbert	fa15502384	Move full track adjustment flow inside MasterGameplayClockContainer	2022-09-07 19:12:16 +09:00
Dean Herbert	75d0deef72	Apply proposed changes to remove inheritance from MasterGameplayClockContainer	2022-09-07 17:49:05 +09:00
Dan Balasescu	f8e37af2e0	Merge pull request #20171 from peppy/beatmap-carousel-nrt ... Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`	2022-09-07 17:15:00 +09:00
Dean Herbert	68c27522e7	Merge pull request #20158 from smoogipoo/taiko-geki-katu ... Decode taiko Geki/Katu from legacy scores into `LargeBonus`	2022-09-07 17:06:42 +09:00
Dean Herbert	99ef0c95fe	Simplify children assignment	2022-09-07 16:51:51 +09:00
Dean Herbert	5b758afd09	Merge branch 'master' into taiko-geki-katu	2022-09-07 16:22:47 +09:00
Dean Herbert	824e68dab3	Fix VectorScale set to 0 still showing some sprites in storyboard ... This implementation was matching the [framework side implementation of scale](16d1c2d335/osu.Framework/Graphics/Drawable.cs (L973-L976)) but I don't think it's required here. I'm still not sure if the framework implementation is correct, but removing it locally does seem to fix broken storyboard cases. Closes https://github.com/ppy/osu/issues/20155.	2022-09-07 15:39:19 +09:00
Dan Balasescu	dc71abdf56	Merge pull request #20144 from peppy/fix-notification-overlay-presence ... Fix completion toasts sometimes not displaying	2022-09-07 14:55:33 +09:00
Dean Herbert	f3bda4e040	Fix weird edge case of nullability in CarouselRoot ... A bit unfortunately, but it's what we get for having ctor level bindings..	2022-09-07 14:27:25 +09:00
Dean Herbert	e18b524f8e	Fix missing null checks on selectedBeatmap fields in BeatmapCarousel	2022-09-07 14:12:35 +09:00
Dean Herbert	241d33d415	Apply NRT to BeatmapCarousel	2022-09-07 14:07:53 +09:00
Jamie Taylor	cb1d886c9c	Add audio feedback for Esc/Back clearing text from a FocusedTextBox	2022-09-07 13:17:04 +09:00
Acid Chicken (硫酸鶏)	3003fc1061	refactor(osu.Game): improve code quality	2022-09-07 02:29:15 +09:00
Salman Ahmed	90207b6032	Merge branch 'master' into feature/EditorDeleteDiff	2022-09-06 18:48:06 +03:00
Dan Balasescu	7c0e99c5a8	Decode Geki/Katu from legacy taiko scores into LargeBonus	2022-09-07 00:12:34 +09:00
Dean Herbert	66c44f5913	Delegate interface to valid target	2022-09-06 22:26:46 +09:00
Dean Herbert	bc1212f4e6	Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method	2022-09-06 22:26:46 +09:00
Dean Herbert	db15bd56e8	Invalidate working beatmap cache when calling DeleteDifficultyImmediately rather than in editor code	2022-09-06 18:12:47 +09:00
Dean Herbert	579e7e1f17	Fix deleting a difficulty not updating the beatmap set hash	2022-09-06 18:12:47 +09:00
Dean Herbert	a3de5f808e	Fix typo in LoopStartTime addition	2022-09-06 17:46:03 +09:00
Dean Herbert	6e52dbb266	Update IsDisplayingToasts to check the flow count directly	2022-09-06 17:30:24 +09:00
Dean Herbert	677708c5e4	Rewrite logic using a list	2022-09-06 16:58:51 +09:00
Dean Herbert	d667f46830	Refactor alpha check to not overwrite sourced overrides with values from later commands	2022-09-06 16:41:32 +09:00
Dean Herbert	bea42d2862	Handle earliest-alpha-start-time logic in StoryboardSprite itself	2022-09-06 16:16:58 +09:00
Dean Herbert	a5e57b083c	Remove EarliestDisplayTime's input to CommandStartTime	2022-09-06 16:16:58 +09:00
Dean Herbert	9e3228aa65	Fix completion notification not being posted if completion occurs during NotificationOverlay load	2022-09-06 04:07:49 +09:00
Acid Chicken (硫酸鶏)	b109e5de6c	chore(osu.Game): align height of bars on timing distribution graph to basalHeight first and combine their transitions into each one	2022-09-06 00:04:10 +09:00
Dean Herbert	44b456e216	Use gameplay clock's TrueGameplayRate in FrameStabilityContainer?	2022-09-05 23:38:22 +09:00
Dean Herbert	266eb758aa	Use new flow to calcaulate TrueGameplayRate	2022-09-05 23:37:49 +09:00
Dean Herbert	7084aeee05	Add method flow to reset applied adjustments	2022-09-05 23:22:38 +09:00
Dean Herbert	e33486a766	Implement IAdjustableAudioComponent in MasterGameplayClockContainer	2022-09-05 23:20:02 +09:00
Dean Herbert	6296c971f8	Merge pull request #20136 from smoogipoo/fix-cancellation-perf ... Improve performance when cancelling import with debugger attached	2022-09-05 22:03:50 +09:00
Dan Balasescu	b2f30fbf8c	Add countdown exclusivity	2022-09-05 20:13:23 +09:00
Dean Herbert	510972e3ad	Avoid reference counting by using height calculation for IsPresent instead ... The reference counting was to guarantee performance (zero allocations) when the notification overlay was not required, but adds extra complexity. Instead, the toast tray now uses its ongoing height calculation as a metric for presence.	2022-09-05 19:38:09 +09:00
Dean Herbert	0514c96191	Fix incorrect count tracking when notification is manually disposed	2022-09-05 19:26:40 +09:00
Dean Herbert	229e1a8ef7	Fix notification overlay being present when it doesn't need to	2022-09-05 19:13:58 +09:00
Dean Herbert	f754686521	Remove necessity of AlwaysPresent for ProgressUpdate completion posting	2022-09-05 19:13:58 +09:00
Dan Balasescu	2923c10cd8	Rewrite rooms to store multiple active countdowns ... Update test to the new structure	2022-09-05 19:03:26 +09:00
Dean Herbert	0d4ee6bd80	Centralise ability to fetch all toast tray notifications (including animating ones)	2022-09-05 18:42:20 +09:00
Dean Herbert	eca7b8f988	Fix completion notifications not always showing as toasts	2022-09-05 18:39:11 +09:00
Dean Herbert	4fa6707bf0	Set all progress notifications to non-important	2022-09-05 18:29:35 +09:00
Dan Balasescu	87e26e34b8	Merge pull request #20141 from peppy/fix-editor-timeline-sv-display ... Fix incorrect slider length in timeline when non-default velocity is inherited from previous object	2022-09-05 17:51:25 +09:00
Dean Herbert	2bec8b82b3	Fix textbox sample playback potentially crashing if called before load	2022-09-05 16:26:41 +09:00
Dean Herbert	57954bb8f5	Enable nullability on TimelineHitObjectBlueprint	2022-09-05 14:50:43 +09:00
Dan Balasescu	8cbd344330	Improve performance when cancelling import with debugger attached	2022-09-05 11:28:13 +09:00
Dan Balasescu	07d4a025b0	Merge pull request #20109 from frenzibyte/online-play-room-status-inconsistency ... Fix room status dropdown placement inconsistent between multiplayer and playlists	2022-09-05 11:19:56 +09:00
Exanc	4ea7ca4c07	Slight tweak to the StarsSlider ... - MinimumStarsSlider now shows "0" when at it's minimum - Modified and NoResultsPlaceholder the tooltip to stay consistent with the changes	2022-09-05 00:09:20 +02:00
Acid Chicken (硫酸鶏)	7e77c9e8b4	chore(osu.Game): only the first result should be white at zero position on HitEventTimingDistributionGraph	2022-09-05 04:44:27 +09:00
Acid Chicken (硫酸鶏)	b67fd3d880	chore(osu.Game): split transform duration of bars on HitTimingDistributionGraph	2022-09-05 03:45:51 +09:00
Acid Chicken (硫酸鶏)	0af6b3dc0f	chore(osu.Game): colorize bars by OD on HitEventTimingDistributionGraph	2022-09-05 02:02:38 +09:00
Acid Chicken (硫酸鶏)	074d2a7a3a	chore(osu.Game): provide ordering index for HitResult	2022-09-05 02:01:44 +09:00
Acid Chicken (硫酸鶏)	5f0832ead7	refactor(osu.Game): separate OsuColour.ForHitResult by usage	2022-09-05 01:58:57 +09:00
Salman Ahmed	ff4a051c05	Merge branch 'master' into remove-dispose-updates	2022-09-03 16:14:50 +03:00
Salman Ahmed	e8fa872f61	Fix room status dropdown position inconsistent on online-play screens	2022-09-03 16:14:21 +03:00
Salman Ahmed	778d767a12	Revert disposal on SectionsContainer properties	2022-09-03 15:02:57 +03:00
Dean Herbert	bc5340e33a	Merge branch 'master' into fix_progress_bar_info	2022-09-02 18:00:35 +09:00
Dean Herbert	4f18105e9d	Ensure next beatmap selected matches the menu ordering	2022-09-02 17:57:00 +09:00
HiddenNode	7a8fa5c2e4	Fix filenames mismatch	2022-09-02 09:56:00 +01:00
Dean Herbert	840d1c4cd5	Disable delete difficulty menu item when only one difficulty is present	2022-09-02 17:14:48 +09:00
Dean Herbert	9fd8067e11	Tidy up dialog and deletion flow	2022-09-02 17:07:09 +09:00
Dean Herbert	605108c938	Refactor/rename deletion method to read better	2022-09-02 16:59:01 +09:00
Dean Herbert	b388428e1c	Merge branch 'master' into feature/EditorDeleteDiff	2022-09-02 16:48:38 +09:00
Dan Balasescu	b10026993a	Don't serialise has_replay	2022-09-02 16:41:53 +09:00
Dean Herbert	8c50ccc48e	Fix incorrect specification in SectionsContainer	2022-09-02 16:37:39 +09:00
Dean Herbert	d80151756c	Merge pull request #20070 from smoogipoo/replay-and-legacy-id ... Add `has_replay` and `legacy_score_id` to `SoloScoreInfo`	2022-09-02 14:55:29 +09:00
Dean Herbert	23d5e8b286	Fix beat sync components stopping after beatmap change ... Not an amazing fix, but it seems to work and would rather get this in ASAP rather than trying to fix at a framework level. Closes #20059.	2022-09-01 23:46:02 +09:00
Dean Herbert	7eaa4c5ccd	Update new usages of Remove / RemoveInternal	2022-09-01 23:05:34 +09:00
Dean Herbert	c9dec473d3	Update virtual track logic to match framework changes	2022-09-01 23:05:07 +09:00
Dean Herbert	22c18d9a81	Update framework	2022-09-01 23:03:28 +09:00
Dean Herbert	6a35b233e5	Merge branch 'master' into remove-dispose-updates	2022-09-01 23:03:19 +09:00
Dan Balasescu	e1e46ad7aa	Merge pull request #20073 from peppy/fix-tournament-lookup ... Fix tournament population failure when beatmap is not found on server	2022-09-01 22:44:53 +09:00
Dan Balasescu	8b2652702a	Merge pull request #20072 from peppy/fix-seasonal-background-sticking ... Fix seasonal background not being unloaded when changing setting to "Never"	2022-09-01 22:44:43 +09:00
Dean Herbert	d3ae60ec6d	Fix tournament population failure when beatmap is not found on server	2022-09-01 22:03:01 +09:00
Dean Herbert	8866250cff	Fix seasonal background not being unloaded when changing setting to "Never" ... Closes #20065.	2022-09-01 21:42:40 +09:00
Dan Balasescu	a277431266	Add has_replay and legacy_score_id to SoloScoreInfo	2022-09-01 21:10:38 +09:00
Dean Herbert	1524623624	Fix back-to-front filter logic ... Was copied across from a place which was checking for `match` and applied verbatim to a place that was `filter`. Which are polar opposites.	2022-09-01 19:59:27 +09:00
Dean Herbert	db9970b72a	Merge pull request #20047 from smoogipoo/multiplayer-auto-skip ... Add auto skip for multiplayer rooms	2022-09-01 18:47:47 +09:00
Dan Balasescu	d70208fcf1	Default to off	2022-09-01 14:14:22 +09:00
HiddenNode	4a630b5384	Implemented SizePreservingSpriteText	2022-08-31 22:05:06 +01:00
HiddenNode	eb02a9a144	Removed GrowToFItContainer	2022-08-31 22:04:28 +01:00
Dean Herbert	b83ce97d8b	Merge branch 'master' into textbox-invalid-sfx	2022-08-31 22:14:59 +09:00
Dean Herbert	50e8052f07	Update resources	2022-08-31 22:08:20 +09:00
Dan Balasescu	c852c54055	Consume auto skip setting during play	2022-08-31 20:24:15 +09:00
Dan Balasescu	b5ec7d06dd	Add auto-skip setting ... Default to auto skip	2022-08-31 20:24:06 +09:00
Dan Balasescu	837b19ab24	Merge pull request #19919 from khang06/nan-sv ... Emulate osu!stable's NaN slider velocity behavior	2022-08-31 19:06:49 +09:00
Jamie Taylor	212d76a11f	Add audio feedback for invalid textbox input	2022-08-31 17:31:36 +09:00
Jamie Taylor	cc9dc604a0	Refactor feedback sample playback logic	2022-08-31 17:29:57 +09:00
Dan Balasescu	6cadcc206b	Merge pull request #20032 from peppy/toast-notification-tray ... Add toast notification tray	2022-08-31 16:57:37 +09:00
Dan Balasescu	000412c50f	Merge pull request #20014 from peppy/fix-resume-skip-forward ... Fix gameplay skipping forward during resume operation	2022-08-31 16:30:37 +09:00
Dan Balasescu	afe2862df4	Merge branch 'master' into toast-notification-tray	2022-08-31 16:07:11 +09:00
Dan Balasescu	ccc08b816c	Merge pull request #20030 from peppy/notification-design-update ... Update notification overlay design	2022-08-31 16:06:59 +09:00
Dean Herbert	7337d4c1aa	Merge branch 'master' into kps	2022-08-31 15:41:42 +09:00
Dan Balasescu	2bf74d2b38	Merge pull request #20039 from peppy/fix-skip-button-permanent-display ... Fix skip button getting stuck on screen for certain beatmaps	2022-08-31 14:17:39 +09:00
Dean Herbert	cfc7c32aff	Merge pull request #20009 from frenzibyte/fix-back-to-front-comparison ... Adjust weirdly back-to-front fallback comparison in `HitObjectOrderedSelectionContainer`	2022-08-31 14:14:10 +09:00
Dean Herbert	51346e0154	Fix skip button getting stuck on screen for certain beatmaps ... Closes #20034.	2022-08-31 13:22:51 +09:00
Dan Balasescu	1908a2e394	Merge pull request #20025 from peppy/fix-results-sample-glitching ... Fix audio glitching when showing results screen with many scores	2022-08-31 13:10:08 +09:00
Dan Balasescu	cb4fd08f27	Merge pull request #20031 from peppy/fix-replay-file-missing-crash ... Fix crash when attempting to watch a replay when the storage file doesn't exist	2022-08-31 13:06:45 +09:00
Dean Herbert	8b9ccc66b7	Update ProgressNotification font spec to match other notifications	2022-08-31 12:49:28 +09:00
Dean Herbert	85442fe032	Adjust dismiss button background colour to avoid conflict with background	2022-08-31 12:48:30 +09:00
Dean Herbert	7c72c6b43f	Fix unread count potentially missing notifications in a transforming state	2022-08-31 12:46:43 +09:00
Dean Herbert	0558dae917	Mark toasts as read when closing the overlay for added safety ... I'm not sure how the read status will play out going forward so I'm just adding this to keep things conforming for now.	2022-08-31 12:46:04 +09:00
Dean Herbert	3d93e0ded1	Merge branch 'master' into fix-resume-skip-forward	2022-08-31 12:16:15 +09:00
Dean Herbert	9eb615f942	Fix remaining test failures by strengthening PlayerLoader tests ... - Click using `TriggerClick` as notifications move around quite a bit. - Ensure any notifications from a previous test method are cleaned up.	2022-08-31 01:40:30 +09:00
Dean Herbert	31a9980686	Update remaining test expectations with new behaviour	2022-08-31 00:57:30 +09:00
Dean Herbert	a62ba9e0d9	Remove notification blocking behaviour of first run setup	2022-08-31 00:57:18 +09:00
Dean Herbert	ed11b1ba6f	Improve forwarding flow to not use piling delegates	2022-08-31 00:40:53 +09:00
Dean Herbert	224ab29ef4	Don't dismiss toasts while hovered (and adjust timings slightly)	2022-08-30 21:19:51 +09:00
Dean Herbert	403fc18976	Fix notification completion events not being run when overlay not visible	2022-08-30 21:13:43 +09:00
Dean Herbert	a7110666a0	Play notification appear sample immediately	2022-08-30 21:13:43 +09:00
Dean Herbert	95ce78a50c	Reduce notification post delay now that it's less important	2022-08-30 21:13:43 +09:00
Dean Herbert	e9cfaa76c9	Change global overlay ordering so notification toasts display above settings	2022-08-30 21:13:43 +09:00
Dean Herbert	b8300ae60a	Add toast notification tray	2022-08-30 21:13:43 +09:00
Dean Herbert	7b006f1f22	Add flash when a new notification is displayed to draw attention	2022-08-30 20:34:27 +09:00
Dean Herbert	60413e3e7b	Enable masking for main content to avoid underlap with close button on word wrap failure.	2022-08-30 19:17:41 +09:00
Dean Herbert	6b71b4656d	Remove ProgressNotification vertical movement and delay	2022-08-30 19:16:59 +09:00
Dean Herbert	928bce8fcd	Fix crash when attempting to watch a replay when the storage file doesn't exist	2022-08-30 18:18:46 +09:00
Dean Herbert	d600058c98	Assert non-null in ProfileHeader to appease r#	2022-08-30 18:09:10 +09:00
Dean Herbert	c846bf20a7	Add background hover and adjust remaining metrics	2022-08-30 18:06:48 +09:00
Dean Herbert	bea12ab3c2	Rename NotificationContent to MainContent	2022-08-30 18:06:48 +09:00
Dean Herbert	09aa3e065d	Move colouring to full icon content rather than background	2022-08-30 18:06:48 +09:00
Dean Herbert	0f203531d9	Allow customising the "close" button icon	2022-08-30 18:06:48 +09:00
Dean Herbert	1484ae19f0	Initial design update pass	2022-08-30 18:06:48 +09:00
Dan Balasescu	0e68620f70	Merge pull request #20026 from peppy/notifications-nrt ... Apply NRT to notification classes	2022-08-30 17:23:11 +09:00
Dean Herbert	b8fda1a16f	Apply NRT to notification classes ... and tidy things up a bit.	2022-08-30 15:57:10 +09:00
Dan Balasescu	799c015bff	Add LegacyTotalScore to SoloScoreInfo	2022-08-30 15:50:19 +09:00
Dean Herbert	5d41fdfc89	Remove unnecessary usage of DrawableAudioMixer in ScorePanel	2022-08-30 15:05:21 +09:00
HiddenNode	cda7faecf7	Added GrowToFitContent Parameter.	2022-08-29 22:01:24 +01:00
ansel	545e0bbcef	Adjust inheritors and test	2022-08-29 22:49:25 +03:00
ansel	5343c26452	Control colour via Current bindable	2022-08-29 22:48:27 +03:00
ansel	7faeed88b0	Add ability to override width of value area	2022-08-29 22:08:43 +03:00
Dean Herbert	27ad224f13	Remove probably unnecessary Seek on start	2022-08-30 01:21:44 +09:00
Dean Herbert	1bff540381	Remove debug changes	2022-08-29 22:14:07 +09:00
Dan Balasescu	0491addbbd	Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset ... Fix editor not applying offsets	2022-08-29 21:10:29 +09:00
Dan Balasescu	8e42af8e66	Merge pull request #19973 from peppy/no-gameplay-clock-beat-synced-container ... Fix beat synced components not applying offsets	2022-08-29 20:43:26 +09:00
Dean Herbert	82b9e1f0eb	Merge pull request #20011 from smoogipoo/scoring-refactor ... Refactor scoring to remove async methods / simplify	2022-08-29 19:55:27 +09:00
Dean Herbert	75531d2d62	Fix gameplay skipping forward during resume operation	2022-08-29 19:51:16 +09:00
Dan Balasescu	eb3601b7ff	Merge pull request #20013 from peppy/always-reprocess-beatmap-after-update ... Always reprocess beatmaps after a user update request	2022-08-29 18:50:27 +09:00
Dan Balasescu	e3e204001e	Merge pull request #19907 from peppy/ruleset-api-versioning ... Add ruleset API versioning	2022-08-29 18:50:01 +09:00
Dean Herbert	2e3c62296a	Merge branch 'master' into no-gameplay-clock-beat-synced-container	2022-08-29 18:22:54 +09:00
Dean Herbert	3eda284b03	Always reprocess beatmaps after a user update request ... This covers the rare case where metadata may have changed server-side but not the beatmap itself. Tested with the provided user database to resolve the issue. Closes #19976.	2022-08-29 18:17:42 +09:00
Dan Balasescu	07b502f69a	Simplify OrderByTotalScore implementation	2022-08-29 17:58:57 +09:00
Salman Ahmed	f2378d3fde	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-29 11:23:22 +03:00
Dean Herbert	9b830d063f	Merge pull request #20010 from smoogipoo/scoreprocessor-no-rewrite-statistics ... Don't include misses in failed score statistics	2022-08-29 17:07:13 +09:00
Dean Herbert	2dafa041a7	Account for offset being applied to editor clock time in TestSceneEditorClock	2022-08-29 16:42:50 +09:00
Dean Herbert	be5c6232e8	Encapsulate Track inside a FramedClock to avoid mutating operations	2022-08-29 16:29:19 +09:00
Dean Herbert	c50695ea49	Merge branch 'master' into no-gameplay-clock-beat-synced-container	2022-08-29 16:16:59 +09:00
Dean Herbert	105aa01e7d	Update usages of RemoveInternal	2022-08-29 15:57:40 +09:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dan Balasescu	81ac0daba8	Update xmldoc	2022-08-29 15:51:12 +09:00
Dan Balasescu	d75543ad68	Simplify GetMaximumAchievableCombo further	2022-08-29 15:36:10 +09:00
Dan Balasescu	423f6f90f2	Remove async calls from ScoreManager	2022-08-29 15:34:08 +09:00
Dan Balasescu	b2e80ca7f0	Don't include misses in failed score statistics	2022-08-29 15:27:19 +09:00
Salman Ahmed	3ff2058975	Fix back-to-front fallback comparison in HitObjectOrderedSelectionContainer	2022-08-29 09:23:53 +03:00
Dean Herbert	90b9c02ac6	Remove "internal" identifier as unnecessary	2022-08-29 14:01:15 +09:00
Dan Balasescu	c0b13c7e1f	Refactor ScoreProcessor ComputeScore() methods	2022-08-29 13:51:10 +09:00
HiddenNode	62210bce4e	Fixed issues found in UprightAspectMaintainingContainer	2022-08-29 00:08:19 +01:00
its5Q	0cc6a76c17	Fix crash with legacy import from incomplete installs	2022-08-28 14:13:38 +10:00
ansel	039f009562	Inherit difficulty multiplier display from ModsEffectDiplay	2022-08-27 20:26:05 +03:00
ansel	3e828c3416	Move base layout from DifficultyMultiplierDisplay to another class	2022-08-27 20:11:38 +03:00
Dan Balasescu	cf6bb3b030	Merge pull request #19958 from peppy/fix-fail-freq-stuck ... Ensure fail animation sequence isn't run after the player exit sequence has started	2022-08-27 00:58:41 +09:00
Salman Ahmed	764ab9f095	Merge branch 'master' into text-selection-sfx	2022-08-26 17:50:03 +03:00
Dan Balasescu	289b6f1a58	Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures ... Fix intermittent test failures in `TestScenePlaylistOverlay`	2022-08-26 23:36:16 +09:00
Dean Herbert	470bec7949	Move private method down	2022-08-26 23:29:03 +09:00
Dean Herbert	9c64520f8f	Merge pull request #19909 from peppy/framework-ini-in-sentry ... Include framework configuration in sentry output	2022-08-26 23:13:26 +09:00
Dean Herbert	e4100ee3f1	Merge branch 'master' into text-selection-sfx	2022-08-26 22:05:32 +09:00
Dean Herbert	b9d9bf3004	Merge pull request #19938 from frenzibyte/fix-multi-spectator-results-screen ... Fix multi-spectator potentially getting stuck for passed players	2022-08-26 21:53:17 +09:00
Dan Balasescu	17a12807de	Merge branch 'master' into framework-ini-in-sentry	2022-08-26 21:30:07 +09:00
Salman Ahmed	a3e595a9aa	Update comment to include inserted indices	2022-08-26 14:51:19 +03:00
Salman Ahmed	81c0a641b4	Fix selection fallback path not updated to check inserted indices	2022-08-26 14:51:08 +03:00
HiddenNode	24edffcbc4	Moved ScaleMode to UprightAspectMaintainingContainer.cs	2022-08-26 12:47:12 +01:00
Salman Ahmed	f38194fb40	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-26 14:35:19 +03:00
Dean Herbert	6dc859973b	Merge branch 'master' into fix-playlist-overlay-test-failures	2022-08-26 20:25:53 +09:00
Dan Balasescu	35d262fc5d	Merge branch 'master' into no-gameplay-clock-beat-synced-container	2022-08-26 20:25:23 +09:00
Dean Herbert	90ff0864c0	Merge branch 'master' into no-gameplay-clock-editor-offset	2022-08-26 20:25:21 +09:00
Dan Balasescu	91e044542d	Merge pull request #19828 from peppy/no-gameplay-clock-gameplay-offset ... Introduce `FramedBeatmapClock` (and use in gameplay flow)	2022-08-26 20:21:34 +09:00
Dean Herbert	d6359b00ad	Fix filename mismatch	2022-08-26 19:20:36 +09:00
Dean Herbert	cd90536e4b	Remove Track access in Timeline	2022-08-26 18:25:48 +09:00
Dean Herbert	4b72e55770	Fix various test scenes not adding EditorClock to the draw hierarchy	2022-08-26 18:08:43 +09:00
Dean Herbert	12d6d6793c	Move EditorClock processing to Update and always decouple	2022-08-26 18:08:43 +09:00
Dean Herbert	fec744a7fe	Add global FramedBeatmapClock for BeatSyncProvider components	2022-08-26 17:48:21 +09:00
Dean Herbert	31e459364b	Use FramedBeatmapClock in EditorClock	2022-08-26 17:28:58 +09:00
Dean Herbert	ed0843aa84	Reword xmldoc regarding final clock source to read better	2022-08-26 16:46:22 +09:00
Dean Herbert	2c780eab5f	Merge branch 'master' into fix_progress_bar_info	2022-08-26 16:14:21 +09:00
Dean Herbert	a40355186a	Tidy up constructor field initialisation	2022-08-26 16:00:20 +09:00
Dean Herbert	23efec6505	Fix naming and comment typos	2022-08-26 15:57:36 +09:00
Dean Herbert	9862b79b47	Fix typo in long comment	2022-08-26 15:20:09 +09:00
HiddenNode	d98357aa57	Made text inside SongProgressInfo scale.	2022-08-26 01:30:44 +01:00
HiddenNode	29f3724047	Changed UprightUnscaledContainer to UprightUnstretchedContainer.	2022-08-26 01:28:57 +01:00
Dean Herbert	a260d7872d	Update framework	2022-08-25 21:50:10 +09:00
Dean Herbert	a546aa2673	Clamp SpectatorPlayerClock's elapsed calculation to avoid player clocks getting too far ahead	2022-08-25 21:33:33 +09:00
Dean Herbert	ae38c9e58d	Update framework	2022-08-25 19:18:17 +09:00
Dean Herbert	510d9ac79f	Merge branch 'master' into text-selection-sfx	2022-08-25 19:18:14 +09:00
Dan Balasescu	9bca7223f6	Adjust xmldoc to better explain score contribution	2022-08-25 17:16:30 +09:00
Dan Balasescu	e2e10a8f26	Add some explanatory comments to conditions	2022-08-25 17:14:53 +09:00
Dean Herbert	3a17c6df08	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-25 16:24:55 +09:00
Salman Ahmed	6840e906e7	watchedUsers -> watchedUsersRefCounts	2022-08-25 09:50:52 +03:00
Salman Ahmed	eb57ea76ab	Merge branch 'master' into legacy-combo-increase	2022-08-25 09:46:12 +03:00
Dean Herbert	a6ed589db4	Remove guard against RemoveFilters running more than once ... It turns out this is required to remove some filters immediate, and some later. Weird.	2022-08-25 14:47:33 +09:00
Dean Herbert	ad3dd1c700	Fix a couple of oversights regarding track nullability	2022-08-25 14:45:00 +09:00
Dean Herbert	ec60e16439	Apply NRT to FailAnimation	2022-08-25 14:35:42 +09:00
Dean Herbert	8f4a953d11	Ensure fail animation sequence isn't run after the player exit sequence has started	2022-08-25 14:26:42 +09:00
Dean Herbert	4c45f7d938	Ensure FailAnimation can't be Started after filters are already removed	2022-08-25 14:26:20 +09:00
Salman Ahmed	146cc62f00	Merge branch 'master' into maximum-statistics-2	2022-08-25 08:18:44 +03:00
Dan Balasescu	17029f0b92	Ensure clones don't reference to MaximumStatistics	2022-08-25 13:58:58 +09:00
Bartłomiej Dach	968f656585	Merge branch 'master' into copyexternalurl-dialog	2022-08-24 21:21:11 +02:00
Ryuki	5cddc7ed1f	Code cleanup (CPS)	2022-08-24 17:13:23 +02:00
Jamie Taylor	da7f8270da	Fix incorrect cast	2022-08-24 22:31:28 +09:00
Jamie Taylor	dc829334a1	Update for framework-side changes.	2022-08-24 22:19:32 +09:00
Dan Balasescu	e7cbb6c63d	Fix test failures/nullability	2022-08-24 19:53:16 +09:00
Dan Balasescu	c9ff39f8c3	Add HitResult.LegacyComboIncrease	2022-08-24 19:46:41 +09:00
Dan Balasescu	5ec95c9269	Update ScoreProcessor to make use of MaximumStatistics	2022-08-24 19:46:41 +09:00
Dean Herbert	f3847b90fd	Tidy up attach logic	2022-08-24 19:36:01 +09:00
Dean Herbert	5129716612	Merge branch 'master' into kps	2022-08-24 18:18:45 +09:00
Dean Herbert	2af8c4a2ea	Merge pull request #19904 from novialriptide/add-date-created-sort ... Add date submitted sorting	2022-08-24 17:43:28 +09:00
Dean Herbert	6a0d23cf96	Nest dialog class and apply NRT	2022-08-24 17:39:22 +09:00
Dean Herbert	9f9deef438	Reword slightly	2022-08-24 17:37:41 +09:00
Dan Balasescu	cc648a90bc	Actually save maximum statistics	2022-08-24 17:28:41 +09:00
Dan Balasescu	d947a6cb59	Add Realm migration	2022-08-24 17:28:41 +09:00
Dan Balasescu	f70af779a4	Add maximum statistics to ScoreInfo/SoloScoreInfo	2022-08-24 17:28:41 +09:00
Dean Herbert	854121c600	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-24 17:16:04 +09:00
Dean Herbert	0fd6f90848	Merge pull request #19934 from novialriptide/copyexternalurl-user ... Add profile url context menu to user container	2022-08-24 17:14:06 +09:00
Dean Herbert	27b57947e4	Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity	2022-08-24 17:13:14 +09:00
Dean Herbert	5f01f461b3	Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock	2022-08-24 17:13:14 +09:00
Andrew Hong	9ee26c575d	Made button blue	2022-08-24 04:04:44 -04:00
Dean Herbert	af56cd0126	Fix merge breakage	2022-08-24 16:52:36 +09:00
Dean Herbert	5079e0d83d	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-24 16:52:10 +09:00
Salman Ahmed	e378c5b866	Remove no longer necessary switch case	2022-08-24 10:50:40 +03:00
Andrew Hong	ec5fd7ac1d	Remove possible 'System.NullReferenceException'	2022-08-24 03:42:16 -04:00
Khang	adea29c106	Fix test failures	2022-08-24 03:37:33 -04:00
Salman Ahmed	8f4a2b4936	Separate passed/failed states from calling EndGameplay	2022-08-24 10:36:13 +03:00
Andrew Hong	b24513038c	Add popupdialog button to copy url	2022-08-24 03:35:19 -04:00
Andrew Hong	a8867d4245	Merge branch 'master' into add-date-created-sort	2022-08-24 03:23:27 -04:00
Andrew Hong	6344b87b14	Merge branch 'master' into copyexternalurl-user	2022-08-24 03:12:00 -04:00
Dean Herbert	7f9246637a	Simplify MultiSpectatorScreen hierarchy construction	2022-08-24 16:08:48 +09:00
Andrew Hong	edd50dc05b	Add profile url context menu to user container	2022-08-24 03:07:03 -04:00
Dean Herbert	7c1fc4814e	Remove unused CreateMasterGameplayClockContainer method	2022-08-24 16:03:38 +09:00
Dean Herbert	871365bbb0	Inline ReadyToStart action binding for added safety	2022-08-24 16:03:38 +09:00
Dean Herbert	6c50f618a3	Don't use bindable flow for masterState	2022-08-24 16:03:38 +09:00
Dean Herbert	683d49c608	Move MasterClockState handling in to SpectatorSyncManager	2022-08-24 16:03:38 +09:00
Dean Herbert	d33d705684	Make WaitingOnFrames non-bindable	2022-08-24 16:03:38 +09:00
Dean Herbert	d05d8aeb22	Simplify interface implementations	2022-08-24 16:03:38 +09:00
Dean Herbert	2f5be6efca	Tidy up ProcessFrame and privatise const	2022-08-24 16:03:38 +09:00
Dean Herbert	b564c34dbc	Don't process master clock (is a noop)	2022-08-24 16:03:38 +09:00
Salman Ahmed	2fa8b61f3c	Handle completion user state updates during spectating	2022-08-24 10:02:21 +03:00
Salman Ahmed	7e5086c8d7	Fix spectator client not handling multiple watch calls properly	2022-08-24 10:02:21 +03:00
Dean Herbert	b4eede61fb	Use readonly instead of get-only	2022-08-24 15:28:18 +09:00
Dean Herbert	0b271fe4b3	Fix incorrect IsRunning value	2022-08-24 15:27:31 +09:00
Dean Herbert	b6254a1f25	Remove unnecessary casting	2022-08-24 15:23:31 +09:00