h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 18:20:34 +08:00
Code Issues Releases Wiki Activity
42,262 Commits 3 Branches 653 Tags 366 MiB
ca3dfb2498
Commit Graph

26725 Commits

Author SHA1 Message Date
dependabot[bot]
f6234864cc
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.6 to 5.0.7 
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:33 +00:00
dependabot[bot]
fb2d08b9ee
Bump ppy.LocalisationAnalyser from 2021.608.0 to 2021.614.0 
Bumps [ppy.LocalisationAnalyser](https://github.com/ppy/osu-localisation-analyser) from 2021.608.0 to 2021.614.0.
- [Release notes](https://github.com/ppy/osu-localisation-analyser/releases)
- [Commits](https://github.com/ppy/osu-localisation-analyser/compare/2021.608.0...2021.614.0)

---
updated-dependencies:
- dependency-name: ppy.LocalisationAnalyser
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:29 +00:00
dependabot[bot]
e7c7b8512a
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson 
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:25 +00:00
dependabot[bot]
b320528eb5
Bump Humanizer from 2.10.1 to 2.11.10 
Bumps [Humanizer](https://github.com/Humanizr/Humanizer) from 2.10.1 to 2.11.10.
- [Release notes](https://github.com/Humanizr/Humanizer/releases)
- [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md)
- [Commits](https://github.com/Humanizr/Humanizer/compare/v2.10.1...v2.11.10)

---
updated-dependencies:
- dependency-name: Humanizer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:22 +00:00
dependabot[bot]
71867337b6
Bump HtmlAgilityPack from 1.11.33 to 1.11.34 
Bumps [HtmlAgilityPack](https://github.com/zzzprojects/html-agility-pack) from 1.11.33 to 1.11.34.
- [Release notes](https://github.com/zzzprojects/html-agility-pack/releases)
- [Commits](https://github.com/zzzprojects/html-agility-pack/compare/v1.11.33...v1.11.34)

---
updated-dependencies:
- dependency-name: HtmlAgilityPack
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:15 +00:00
dependabot[bot]
e5e468e387
Bump SharpCompress from 0.28.2 to 0.28.3 
Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.28.2 to 0.28.3.
- [Release notes](https://github.com/adamhathcock/sharpcompress/releases)
- [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.28.2...0.28.3)

---
updated-dependencies:
- dependency-name: SharpCompress
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:11 +00:00
dependabot[bot]
c976854e24
Bump Sentry from 3.4.0 to 3.6.0 
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.4.0 to 3.6.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.4.0...3.6.0)

---
updated-dependencies:
- dependency-name: Sentry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:08 +00:00
dependabot[bot]
8ab9ea9926
Bump Realm from 10.2.0 to 10.2.1 
Bumps [Realm](https://github.com/realm/realm-dotnet) from 10.2.0 to 10.2.1.
- [Release notes](https://github.com/realm/realm-dotnet/releases)
- [Changelog](https://github.com/realm/realm-dotnet/blob/master/CHANGELOG.md)
- [Commits](https://github.com/realm/realm-dotnet/compare/10.2.0...10.2.1)

---
updated-dependencies:
- dependency-name: Realm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:03 +00:00
Dean Herbert
48b36e8940
Merge branch 'master' into star-difficulty-range-display 2021-07-01 22:51:42 +09:00
Dean Herbert
153814626c
Merge pull request #13724 from smoogipoo/update-sr-colours 
Update SR colours to match osu-web
 2021-07-01 22:51:23 +09:00
Dean Herbert
f1c11243e9 Update resources 2021-07-01 22:06:59 +09:00
Jamie Taylor
dad28b2826
Update OsuSliderBar to use new notch-tick sample and tweak pitch ramping 2021-07-01 20:55:55 +09:00
Jamie Taylor
68c5e6a431
Add audio feedback to changing volume 2021-07-01 20:55:04 +09:00
smoogipoo
4c95af4b16 Add star rating range display 2021-07-01 20:35:31 +09:00
Dean Herbert
4c1b8bc427 Update disclaimer 2021-07-01 20:23:12 +09:00
Dean Herbert
0522500a57 Fix a couple of merge oversights 2021-07-01 19:45:17 +09:00
Dean Herbert
31dbc7798b Merge branch 'master' into linkify-metadata 2021-07-01 19:41:33 +09:00
smoogipoo
a78d1b4c2e Update SR colours to match osu-web 2021-07-01 19:37:21 +09:00
Dean Herbert
3816c486d5 Guard against a potential startup crash if user's preferred ruleset has a compatibility issue 
Resolves this issue seen at https://github.com/ppy/osu/issues/13722#issuecomment-872088071.
 2021-07-01 19:03:58 +09:00
Dean Herbert
82fd8b13df
Merge pull request #13720 from Game4all/localise-dashboard-friends 
Localise friends view in dashboard overlay
 2021-07-01 18:20:18 +09:00
Dean Herbert
74c63e15be Mark score failed on fail and exit 2021-07-01 17:48:09 +09:00
Dean Herbert
b00ee67895 Remove excess whitespace 2021-07-01 17:25:47 +09:00
Dean Herbert
04b874bb00 Add flow for submitting score on exiting SubmittingPlayer 2021-07-01 17:02:33 +09:00
Dean Herbert
5bc970af0d Make TestPlayer inherit from SoloPlayer for more flexibility in testing 2021-07-01 16:55:33 +09:00
Bartłomiej Dach
583242d96d Add osu!-styled colour picker control 2021-06-30 23:25:50 +02:00
Lucas A
939b2baafe Localise overlay "Scroll to top" button. 2021-06-30 22:19:04 +02:00
Lucas A
8da6ecf6a9 Localise OverlayPanelDisplayStyle tab control. 2021-06-30 21:28:07 +02:00
Lucas A
f2287ba022 Localise friends online status stream control. 2021-06-30 21:16:21 +02:00
Lucas A
285c49be7e Localise dashboard overlay header. 2021-06-30 20:28:27 +02:00
Dean Herbert
00d3baef11 Exit handling flow 2021-06-30 20:23:48 +09:00
Dean Herbert
57a21dfb1c Update framework 2021-06-30 16:11:18 +09:00
Dean Herbert
4a71a4bb21
Merge pull request #13450 from smoogipoo/spectator-start-at-end-2 
Start spectator at the end of gameplay
 2021-06-30 16:09:35 +09:00
Dean Herbert
094cd31361
Merge pull request #13441 from frenzibyte/ruleset-resources-skin 
Provide access to ruleset resources during `ISkinSource` lookups
 2021-06-30 15:26:37 +09:00
Dean Herbert
a019f2cc5c
Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-30 13:49:05 +09:00
Salman Ahmed
bc0ab7dd4f Fix RestoreDefaultValueButton not behaving correctly on number types 2021-06-29 23:39:46 +03:00
Dean Herbert
825181121d
Merge branch 'master' into spectator-start-at-end-2 2021-06-30 01:50:14 +09:00
Dean Herbert
5031707048
Merge pull request #13690 from smoogipoo/fix-action-posting 
Fix commands posted to the wrong channel
 2021-06-30 00:39:02 +09:00
smoogipoo
6dd3c6fe93 Make MultiSpectatorScreen and tests more resillient to timing 2021-06-29 22:45:51 +09:00
Gagah Pangeran Rosfatiputra
3a002e357a
rename method 2021-06-29 19:28:21 +07:00
Dean Herbert
2f1203085b Also add logging of realm block/flush operations 2021-06-29 20:23:25 +09:00
Dean Herbert
9acc5e38bb Add basic logging for osu! storage migration 
When looking into the test failure at https://github.com/ppy/osu/runs/2940065457, it became apparent that we are not showing the migration process anywhere in logs. It's the cause of many issues, and we would want to see this in CI and user logs when occurring.
 2021-06-29 20:23:25 +09:00
smoogipoo
bfdbe3c3fe Fix clocks getting added a second time 2021-06-29 17:29:25 +09:00
smoogipoo
8e04d73b67 Merge branch 'rework-multiplayer-test-scenes' into spectator-start-at-end-2 2021-06-29 17:06:57 +09:00
smoogipoo
ca0eaab8e2 Add test 2021-06-29 16:30:46 +09:00
smoogipoo
7a86686f40 Make nullable 2021-06-29 16:30:40 +09:00
smoogipoo
9132c42f87 Fix actions posted to the wrong channel 2021-06-29 15:58:07 +09:00
smoogipoo
bcdf36e77b Merge branch 'master' into spectator-start-at-end-2 2021-06-29 15:53:58 +09:00
smoogipoo
92fa99700e Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-29 15:39:59 +09:00
smoogipoo
a3b1e1d5fc Check for null ruleset in FilterCriteria 2021-06-29 15:18:40 +09:00
Gagah Pangeran Rosfatiputra
d88d264491
prevent image sprite exceed its parent width 2021-06-29 09:49:45 +07:00
Dan Balasescu
697b07acb1
Merge branch 'master' into fix-beatmap-import-fk-failure 2021-06-29 11:36:31 +09:00
Dan Balasescu
471bf9a752
Merge pull request #13681 from peppy/score-submit-ruleset-id 
Serialise and send ruleset ID as part of score submission
 2021-06-29 11:27:13 +09:00
Dean Herbert
e4ca6a4266 Serialise and send ruleset ID as part of score submission 2021-06-29 01:55:09 +09:00
Gagah Pangeran Rosfatiputra
e58f690210
centering image sprite 2021-06-28 21:09:00 +07:00
Gagah Pangeran Rosfatiputra
2b8d41c045
add BlockImageContainer 
change from AutoSize Both to AutoSize Y and RelativeSize X
 2021-06-28 21:04:56 +07:00
Gagah Pangeran Rosfatiputra
1c074ff018
add BlockMarkdownImage 
change from AutoSize Both to AutoSize Y and RelativeSize X
 2021-06-28 21:04:13 +07:00
Dan Balasescu
a9084db665
Merge pull request #13673 from peppy/import-early-checksum-abort 
Shortcut import process to speed up duplicate imports
 2021-06-28 19:55:09 +09:00
Dan Balasescu
8950757b61
Merge pull request #13618 from peppy/fix-realm-state-change-crashes 
Fix realm threading issues to make it releaseable
 2021-06-28 19:54:49 +09:00
Dan Balasescu
92fcf90768
Merge branch 'master' into import-early-checksum-abort 2021-06-28 19:29:08 +09:00
Salman Ahmed
66fc95c111 Use LastOrDefault instead 2021-06-28 12:43:58 +03:00
Salman Ahmed
7197998a10 Remove resolution to SkinManager and use pattern matching instead 2021-06-28 12:43:13 +03:00
Salman Ahmed
177bfe1234 Merge branch 'master' into ruleset-resources-skin 2021-06-28 11:16:37 +03:00
Dean Herbert
a8597b6213
Merge pull request #13658 from frenzibyte/fix-initial-ruleset-skin-loading 
Fix `RulesetSkinProvidingContainer` being potentially late in setting up skin sources
 2021-06-28 17:03:56 +09:00
Dean Herbert
d4ea73d727 Simplify disposal exceptions 2021-06-28 16:17:09 +09:00
Dean Herbert
f78cedd0e1 Reorder methods and add xmldoc for BlockAllOperations 2021-06-28 16:16:40 +09:00
Dean Herbert
90f0bc87f5 Add safety against double disposal 2021-06-28 16:12:21 +09:00
Dean Herbert
842f033522 Remove no longer necessary exception 2021-06-28 16:11:55 +09:00
Dean Herbert
f7aba7360a
Merge pull request #13654 from Henry-YSLin/fix-invisible-number-box 
Refactor `SeedSettingsControl` and `SettingsNumberBox`
 2021-06-28 16:07:30 +09:00
Dean Herbert
0d2bc4fc5f Merge branch 'master' into fix-realm-state-change-crashes 2021-06-28 16:03:58 +09:00
Salman Ahmed
779a1b322c
Add comment explaining insertion of ruleset skin before default skin 
Co-authored-by: Dean Herbert <pe@ppy.sh>
 2021-06-28 09:38:42 +03:00
Dean Herbert
e4780d4b06 Update framework 2021-06-28 15:29:47 +09:00
Dean Herbert
f939e2603a Merge branch 'master' into localisable-tooltips 2021-06-28 15:29:42 +09:00
Dean Herbert
eeb56970ef Make OutlinedNumberBox private and nested again 2021-06-28 15:24:55 +09:00
Salman Ahmed
f598de4cdb ResourcesSkin -> ResourceStoreBackedSkin 2021-06-28 09:18:29 +03:00
Salman Ahmed
692f24437e Maintain ruleset resources skin across multiple source changes 2021-06-28 09:11:28 +03:00
Dean Herbert
7dd566dc46
Add null check for safety 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2021-06-28 15:08:49 +09:00
Dean Herbert
c281e43cd8 Remove Dispose() special case and add explicit exception to make debugging issues non-deadlock 2021-06-28 15:04:14 +09:00
Dean Herbert
f777741ca7 Simplify instantiation 2021-06-28 14:51:27 +09:00
Dean Herbert
e387feb1d6 Add inline comment mentioning why CreateChildDependencies is being used in this instance 2021-06-28 14:39:55 +09:00
Dean Herbert
fdd6778f36
Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-28 14:35:34 +09:00
Dean Herbert
a3946a1265
Fix typo in newly added xmldoc 
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
 2021-06-28 14:07:21 +09:00
Henry Lin
3d19364a71 Use BindValueChanged instead of setting the value in property setter 2021-06-28 11:20:00 +08:00
Dean Herbert
4d6002ab88 Remove redundant string interpolation (and mark all local logging strings as verbatim) 2021-06-28 12:16:15 +09:00
Henry Lin
0cceef8da5 Moved the string to int? conversion logic into SettingsNumberBox 2021-06-28 11:00:07 +08:00
Dean Herbert
4a557e73a7 Add logging to help understand existing case skips better 2021-06-28 10:42:42 +09:00
Dan Balasescu
9c0840268a
Merge pull request #13598 from JimmyC7834/supporter-only-filter-content 
Add supporter required placeholder in beatmap listing overlay
 2021-06-28 10:27:56 +09:00
Dean Herbert
90b87cbb9e Add back unidirectional online id check 2021-06-28 10:11:27 +09:00
Dean Herbert
9a96cd4a1d Revert "Remove comparison of online beatmap IDs during dedupe checks" 
This reverts commit 15af28d2a0.
 2021-06-28 09:54:18 +09:00
Dean Herbert
a1e8cc5444
Merge pull request #13669 from Naxesss/hitsound-checks 
Add hitsound checks
 2021-06-28 03:13:43 +09:00
Naxess
9f9e96ce9e Add check for spanDuration <= 0 prior to division 2021-06-27 15:40:09 +02:00
Naxess
a4a5325b73 Improve acceptable difference for repeat edges 
Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.
 2021-06-27 15:39:31 +02:00
Dean Herbert
e755dcc34d Add log method for new flow 2021-06-27 20:37:12 +09:00
Dean Herbert
f470b7095d Move private method down in class 2021-06-27 20:36:01 +09:00
Dean Herbert
f216404952 Fix missing undelete call on using existing 2021-06-27 20:22:48 +09:00
Dean Herbert
9120321731 Add comments mentioning shortcomings and avoid potential double check 2021-06-27 19:07:35 +09:00
Dean Herbert
44f875b802 Bypass optimised existing check in SkinManager (due to custom hashing function) 2021-06-27 16:35:13 +09:00
Dean Herbert
e493685c14 Add optimised existing check earlier in import process 2021-06-27 16:34:40 +09:00
Dean Herbert
15af28d2a0 Remove comparison of online beatmap IDs during dedupe checks 2021-06-27 14:48:57 +09:00
Dean Herbert
46f8100f43 Remove overly verbose logging during beatmap imports 2021-06-27 14:29:02 +09:00
Dean Herbert
d1f852d102 Make Populate abstract to avoid unnecessary base call async complexity 2021-06-27 14:29:02 +09:00
Naxess
4cfa0ae5ec Improve precision for repeat edges 2021-06-27 03:26:35 +02:00
Naxess
2cd7eda3c4 Add "or equal to" to volume threshold xmldocs 2021-06-27 02:30:12 +02:00
Naxess
0c0fd291d9 Order hitobjects by endtime 2021-06-27 01:25:03 +02:00
Naxess
4796b1b208 Use local variables for hasHitsound & couldHaveHitsound 2021-06-27 00:04:30 +02:00
Naxess
5bc08ebadb Rename hasHitsounds -> mapHasHitsounds 2021-06-26 23:49:25 +02:00
Naxess
d29e6f4695 Add negligible template to PossibleTemplates 2021-06-26 23:49:06 +02:00
Naxess
1913084342 Use HitSampleInfo.AllAdditions instead of new list 2021-06-26 23:48:28 +02:00
Naxess
f78cc9397e Factor out edge type logic 2021-06-26 20:45:31 +02:00
Naxess
51147405c5 Make || and && priority explicit 2021-06-26 20:44:39 +02:00
Bartłomiej Dach
9061ab0a27 Update/reword comments in listing overlay 2021-06-26 20:42:13 +02:00
Bartłomiej Dach
b56dd7ff25 Fix naming and xmldocs in new beatmap search result structures 2021-06-26 20:35:07 +02:00
Naxess
4b436b774d Add few hitsounds check 2021-06-26 19:20:46 +02:00
Naxess
d8117fa730 Add muted objects check 2021-06-26 19:20:34 +02:00
Gagah Pangeran Rosfatiputra
2b1d3c8e9c
add od filter in search filter 2021-06-26 21:05:01 +07:00
Gagah Pangeran Rosfatiputra
8e1bcc4d6b
add overall difficulty in filter criteria 2021-06-26 21:02:31 +07:00
Salman Ahmed
e8e9fdd533 Dispose ResourcesSkin before clearing skin sources 2021-06-26 12:34:30 +03:00
Salman Ahmed
e5eea503db Remove finalizer logic from ResourcesSkin 2021-06-26 12:21:49 +03:00
Henry Lin
3b822cd5cf Refactor SeedSettingsControl and related controls 2021-06-26 11:19:14 +08:00
Bartłomiej Dach
ea384332c3
Merge branch 'master' into logo-transition-sound 2021-06-25 21:12:48 +02:00
Bartłomiej Dach
50c27d2635 Update usages of IHasTooltip in line with framework localisation changes 2021-06-25 19:10:04 +02:00
aitani9
6bc71590c5 Disable logo click sound when exiting 2021-06-25 09:21:26 -07:00
smoogipoo
c93c615f5e Also fix up interface names 2021-06-25 20:15:30 +09:00
smoogipoo
1ed61b9b98 Fix up dependencies class names 2021-06-25 20:11:38 +09:00
Salman Ahmed
8387acfe15
Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-25 12:22:51 +03:00
smoogipoo
a27a647ae7 Rename RoomDependencies -> OnlinePlayDependencies 2021-06-25 18:07:47 +09:00
smoogipoo
04279e7f5c Add some xmldocs 2021-06-25 18:02:53 +09:00
smoogipoo
c0d2b41d4c Move SpectatorClient into multiplayer dependencies 2021-06-25 17:55:16 +09:00
Dean Herbert
51dd7fc238
Merge pull request #13622 from aitani9/mod-settings-dropdown-height 
Decrease the max dropdown height in mod settings
 2021-06-25 17:42:47 +09:00
smoogipoo
7aefbe3da1 Move UserLookupCache inside dependencies 2021-06-25 17:37:02 +09:00
Dean Herbert
5883922177 Remove mod multiplier completely 2021-06-25 16:36:31 +09:00
Salman Ahmed
f07008a0a2 Fix RulesetSkinProvidingContainer potentially late in setting up skin sources 2021-06-25 10:05:51 +03:00
Dean Herbert
57ae87956a Update execution state change blocking logic in line with framework changes 2021-06-25 15:27:40 +09:00
smoogipoo
81a812e216 Rework MultiplayerTestScene to make use of OnlinePlayTestScene 2021-06-25 15:00:10 +09:00
smoogipoo
aa5d22d04a Remove "test container", make everything go through OnlinePlayTestScene 2021-06-25 13:02:19 +09:00
Henry Lin
31c786e1c3 Use SettingsNumberBox.NumberBox instead of OsuNumberBox 2021-06-25 09:51:34 +08:00
aitani9
93edb25ace Override CreateMenu instead of using a property 2021-06-24 14:32:43 -07:00
aitani9
34ace2553e Revert "Refactor the menu's max height to be a property" 
This reverts commit 9cb9ef5c
 2021-06-24 14:32:00 -07:00
aitani9
62566f2a4a Remove "Score Multiplier" text 2021-06-24 14:29:47 -07:00
Bartłomiej Dach
4fe30ca923 Remove Traditional Chinese (HK) language option 
Due to no actual existing translations it was falling back to Simplified
Chinese instead, making the option actively wrong/confusing.
 2021-06-24 18:32:17 +02:00
smoogipoo
5820793d11 Make TestMultiplayerRoomContainer inherit TestRoomContainer 2021-06-24 21:02:29 +09:00
smoogipoo
9cf2c9ddae Fix incorrect dependency creation 2021-06-24 21:02:21 +09:00
smoogipoo
a21cf87b5f Split room manager and allow overrides 2021-06-24 19:14:05 +09:00
smoogipoo
5115299e9a Merge RoomManagerTestScene into OnlinePlaySubScreenTestScene 2021-06-24 19:09:31 +09:00
Dean Herbert
6922de12c6 Add extra null safety in dispose call 2021-06-24 17:17:12 +09:00
smoogipoo
a7b5c3bed1 Add OnlinePlaySubScreenTestScene 2021-06-24 17:01:28 +09:00
smoogipoo
9287fae5f7 Simplify 2021-06-24 16:54:09 +09:00
smoogipoo
4af119a407 Re-namespace 2021-06-24 16:29:06 +09:00
Salman Ahmed
a98b5618b8 Convert RulesetResourcesSkin to plain ResourcesSkin and pass non-null resources 2021-06-24 10:07:38 +03:00
smoogipoo
c9ec4b9da4 Remove RoomTestScene inheritance from simple test scenes 2021-06-24 16:02:20 +09:00
JimmyC7834
27735eeedb fixed code 2021-06-24 13:45:38 +08:00
Dean Herbert
63ab40ec24 Fix potential deadlocking behaviour (and convert ResetEvent to Semaphore) 2021-06-24 14:37:26 +09:00
Nathan Alo
812624a502 use .Equals() instead 2021-06-24 10:45:20 +08:00
Nathan Alo
564c72bf74 compare directly instead of comparing IDs 2021-06-24 10:10:57 +08:00
Nathan Alo
73590bfca1 Return an empty array when the sender is from system. 2021-06-24 07:20:31 +08:00
aitani9
c8022126dc Add logo sound case for transitioning to song select 2021-06-23 13:39:12 -07:00
Dan Balasescu
3a96f9bd14
Merge pull request #13637 from Game4all/localise-beatmap-listing-ruleset-filter 
Localize beatmap listing ruleset filter `Any` button
 2021-06-24 00:57:48 +09:00
Lucas A
263370e1ff Localize ruleset filter any filter button. 2021-06-23 16:42:14 +02:00
Dean Herbert
b6555c10f8
Merge pull request #13630 from smoogipoo/more-collection-safety 
Make collection database even more safe
 2021-06-23 22:07:52 +09:00
smoogipoo
8a2026e305 Schedule callback instead 2021-06-23 21:26:52 +09:00
smoogipoo
c85edd2b55 Merge branch 'master' into fix-realm-state-change-crashes 2021-06-23 21:20:53 +09:00
Dean Herbert
01a5d998a5 Update framework 2021-06-23 20:29:02 +09:00
Dean Herbert
d148656108 Update in line with framework event structural changes (and add unbind) 2021-06-23 18:08:34 +09:00
Dean Herbert
dcba7bf779 Fix import flow potentially hitting foreign key constraint 2021-06-23 17:34:56 +09:00
Dan Balasescu
b6793aadb4
Merge pull request #13628 from ekrctb/add-IApplicableToBeatmapProcessor 
Add `IApplicableToBeatmapProcessor` mod interface
 2021-06-23 17:08:40 +09:00
Salman Ahmed
d484469906 Handle case where SkinManager sources aren't part of AllSources 
In tests.
 2021-06-23 10:44:23 +03:00
Dean Herbert
28f4c56cd6 Fix minor typo in comment 2021-06-23 16:30:28 +09:00
smoogipoo
e7981eae9b Safeguard load procedure a bit more 2021-06-23 16:14:08 +09:00
Salman Ahmed
53fa229880 Add ruleset resources skin before SkinManager.DefaultSkin 2021-06-23 10:09:25 +03:00
Salman Ahmed
2e6800f586 Enable NRT in RulesetResourcesSkin 2021-06-23 09:52:00 +03:00
Salman Ahmed
0db06c727b Dispose resource stores on finalizer 2021-06-23 09:41:45 +03:00
smoogipoo
0510282dcb Add missing ctor 2021-06-23 15:10:03 +09:00
smoogipoo
5828606c13 Prefer using the backup file if it exists 2021-06-23 15:09:42 +09:00
Dean Herbert
e4d17bd757 Remove commented code 
This will be reverted in a future change, no need to keep it around.
 2021-06-23 15:06:29 +09:00
smoogipoo
c9a203cc11 Move collections db in-place 2021-06-23 15:03:34 +09:00
Dean Herbert
151dfdfb79
Merge pull request #13627 from Joehuu/fix-multiplayer-exit-logic 
Fix multiplayer leave dialog not working on all exit operations
 2021-06-23 14:56:57 +09:00
ekrctb
e1b2c63e09 Add IApplicableToBeatmapProcessor mod interface 2021-06-23 14:46:30 +09:00
Dean Herbert
cb6fbd88c7 Merge branch 'master' into mod-settings-dropdown-height 2021-06-23 14:14:17 +09:00
Dean Herbert
a1da9c5ee3
Merge pull request #13626 from Henry-YSLin/IHasSeed-interface 
Extract `SeedSettingsControl` to `IHasSeed` interface
 2021-06-23 14:10:34 +09:00
Dean Herbert
bae42a8908 Add inline comment explaining why the height is set lower 2021-06-23 14:07:37 +09:00
Dean Herbert
f62b4f2d24
Merge pull request #13617 from ekrctb/catch-editor 
Add "placeholder" (pre-MVP) implementation of osu!catch editor
 2021-06-23 14:00:34 +09:00
Dean Herbert
54084f8a9c Move SeedSettingsControl to own file 2021-06-23 13:40:05 +09:00
smoogipoo
6fd020d91d Remove unnecessary public accessibility 
All interface members are implicitly public.
 2021-06-23 12:00:57 +09:00
Joseph Madamba
49000b9501 Add multiplayer leave navigation tests 2021-06-22 19:30:40 -07:00
ekrctb
0b351c9922 Fix "possible NRE" inspection 2021-06-23 10:57:04 +09:00
ekrctb
eec4457473 Add [CanBeNull] to methods returning null by default 2021-06-23 09:40:07 +09:00
aitani9
59928a7d91 Decrease the max height of dropdown menus in mod settings 2021-06-22 13:32:45 -07:00
aitani9
9cb9ef5c56 Refactor the menu's max height to be a property 2021-06-22 13:31:41 -07:00
Salman Ahmed
ee84364d7c Resolve conflict issues 2021-06-22 20:38:24 +03:00
Salman Ahmed
896c1dc202 Merge branch 'master' into ruleset-resources-skin 2021-06-22 20:36:49 +03:00
Dean Herbert
f03c2bab48 Update event name in line with framework changes 2021-06-22 22:45:13 +09:00
Dan Balasescu
bdc440f11c
Merge pull request #13605 from aitani9/overlay-item-sound-edge 
Empty the space between `OverlayStreamItem`s
 2021-06-22 22:13:39 +09:00
Dean Herbert
4cb9c6a842
Merge pull request #13423 from frenzibyte/transformers-per-skin 
Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`
 2021-06-22 21:24:56 +09:00
Dan Balasescu
e39ce6cc67
Merge pull request #13610 from gagahpangeran/markdown-heading-font-size 
Change osu markdown heading to use actual font size
 2021-06-22 20:58:48 +09:00
Dan Balasescu
c436f9f0fa
Merge pull request #13615 from peppy/mod-utils-check-duplicate-mods 
Ensure duplicate mods cannot be defined
 2021-06-22 20:28:40 +09:00
Dan Balasescu
883b3e56f4
Merge branch 'master' into markdown-heading-font-size 2021-06-22 20:21:25 +09:00
Salman Ahmed
2b1f461d79 Pass empty resource store for FallbackShaderManager base constructor 2021-06-22 12:36:45 +03:00
Dean Herbert
b9a9174168 Remove live realm bindings for now 2021-06-22 18:26:42 +09:00
Dean Herbert
a4b66bec2e Ensure realm contexts are flushed when update thread changes native thread 2021-06-22 18:18:25 +09:00
Salman Ahmed
71e2815e7e
Update and improve code documentation 
Co-authored-by: Dean Herbert <pe@ppy.sh>
 2021-06-22 12:05:17 +03:00
Salman Ahmed
31cbb36a64 Implement FindProvider and AllSources properly on all test ISkinSources 2021-06-22 12:03:14 +03:00
Dean Herbert
804a0433cc Update framework 2021-06-22 17:59:55 +09:00
Dean Herbert
d1aac743ad Merge branch 'master' into ruleset-shaders 2021-06-22 17:59:51 +09:00
Dean Herbert
b8126e3ca8 Update framework 2021-06-22 17:59:24 +09:00
Dean Herbert
c4fde635c6 Ensure duplicate mods cannot be defined 2021-06-22 17:41:20 +09:00
ekrctb
a9c7830252 Fix NRE when hit object blueprint is not implemented 2021-06-22 17:20:13 +09:00
Salman Ahmed
c1284940e1 Fix potentially providing the same skin instance twice in AllSources 2021-06-22 10:49:37 +03:00
Salman Ahmed
d0cdc07b11 Reuse AllSources when looking up on FindProvider 2021-06-22 10:49:21 +03:00
Salman Ahmed
b12adc6073 Remove all test skinning changes in favour of the ISkinSource.AllSources path 2021-06-22 10:48:03 +03:00
Dean Herbert
1fff9a93b9 Merge branch 'master' into skin-editor-closest-anchor 2021-06-22 16:41:51 +09:00
Dean Herbert
4b3165084d Move scoped functionality into local function 2021-06-22 16:40:56 +09:00
Dean Herbert
ffac32a848 Reword xmldoc 2021-06-22 16:40:48 +09:00
Dean Herbert
14bdcef26b Add missing newline 2021-06-22 16:20:09 +09:00
Dean Herbert
0ad189e357 Expose skin sources via ISkinSource and revert to consuming based on hierarchy 2021-06-22 16:19:55 +09:00
Dean Herbert
1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
Henry Lin
fc224c53f4 Remove extra usings 2021-06-22 14:49:37 +08:00
Henry Lin
3745101f32 Extract seed setting control to IHasSeed 2021-06-22 14:43:41 +08:00
JimmyC7834
0d17fb4259 fixed code 2021-06-22 13:53:21 +08:00
Gagah Pangeran Rosfatiputra
5c3129f1a2
add font size in HeadingTextFlowContainer 2021-06-22 12:24:56 +07:00
Gagah Pangeran Rosfatiputra
f89c154e18
change GetFontSizeByLevel to return actual font size 2021-06-22 12:24:25 +07:00
Joseph Madamba
2cdbada87e Fix screen breadcrumb control updating on click 2021-06-21 21:10:24 -07:00
Joseph Madamba
db86098062 Fix dialog not closing after spamming OS window close 2021-06-21 20:23:11 -07:00
Joseph Madamba
9bcd1e6922 Move confirm dialog logic to OnExiting 2021-06-21 20:22:18 -07:00
Joseph Madamba
00b4cf1829 Handle sub screen OnExiting logic on main screen 2021-06-21 20:20:43 -07:00
Salman Ahmed
ec040ff3fc Fix leak due to not properly unbinding SourceChanged event on disposal 2021-06-22 05:05:41 +03:00
Salman Ahmed
caa90bccc6 Fix default skin potentially added twice in RulesetSkinProvidingContainer 2021-06-22 03:45:43 +03:00
Salman Ahmed
627c857da8 Propagate SourceChanged events from SkinManager down in the ruleset skin container 2021-06-22 03:45:24 +03:00
Salman Ahmed
9e5bb146d3 Add xmldoc to SkinManager 
The `<summary>` part comes from `BeatmapManager`, which I believe works correctly here as well, as this does handle the "storage and retrieval" of skins.
 2021-06-22 03:07:31 +03:00
Salman Ahmed
97dbc7f20e Add back SkinManager.DefaultSkin to the ruleset skin lookup sources 2021-06-22 02:54:34 +03:00
Salman Ahmed
d53a43cf3c Isolate RulesetSkinProvidingContainer from falling back to parent skin sources 
For simplicity of lookup order, and which sources are used for the lookup.
 2021-06-22 02:53:22 +03:00
Salman Ahmed
ebe0d43790 Add ability to disallow falling back to parent skins 2021-06-22 02:51:17 +03:00
aitani9
36e459e97e Use margin instead of padding 2021-06-21 13:42:15 -07:00
JimmyC7834
b162da5ee0 minor code change 2021-06-21 15:47:47 +08:00
JimmyC7834
22cc1e1452 fixed code style base on code analysis 2021-06-21 15:31:47 +08:00
JimmyC7834
3367456304 fixed SupporterRequiredDrawable style 2021-06-21 14:30:54 +08:00
JimmyC7834
044c2aa99d Merge branch 'master' of https://github.com/JimmyC7834/osu into supporter-only-filter-content 2021-06-21 14:27:54 +08:00
JimmyC7834
0707642b76 fixed SupporterRequiredDrawable 2021-06-21 14:25:20 +08:00
Joseph Madamba
6fda5e569a Fix beatmap discussion links wrongly leading to beatmap page 2021-06-20 21:37:00 -07:00
Salman Ahmed
11b78ad849 Make TestPlayer skin assigning logic not flaky 2021-06-21 06:46:00 +03:00
Salman Ahmed
5cfd0e3223 Remove implicit LegacySkin check and refactor anything using it 2021-06-21 04:16:58 +03:00
Salman Ahmed
67f0344c0c Add support for loading shaders from ruleset resources 2021-06-20 23:07:44 +03:00
JimmyC7834
d0a8b74823 fixed filter text order 2021-06-20 21:28:57 +08:00
JimmyC7834
996503eb2d fixed filter text display, added visual tests 2021-06-20 21:23:54 +08:00
Dean Herbert
c624ec79b1
Merge pull request #13575 from bdach/realm-on-xamarin 
Add direct references to Realm from Xamarin projects
 2021-06-20 21:51:25 +09:00
JimmyC7834
e7aeba8d03 added more visual tests 2021-06-20 18:28:43 +08:00
JimmyC7834
42fdfbb9a1 added visual tests 2021-06-20 17:17:07 +08:00
smoogipoo
32bd3107e1 Remove high performance GC setting 2021-06-20 17:07:41 +09:00
Bartłomiej Dach
1f383532f2 Move FodyWeavers configuration to solution root 2021-06-20 10:05:49 +02:00
Bartłomiej Dach
46b9fd9ac8 Remove and ignore FodyWeavers schema files 2021-06-20 10:05:42 +02:00
JimmyC7834
27da3dc75a added supporter-only-filter content 2021-06-19 20:54:24 +08:00
Dean Herbert
b6e07ff59c
Merge pull request #13572 from bdach/fix-unsupported-locales 
Fix game crashes due to attempting localisation load for unsupported locales
 2021-06-19 17:09:39 +09:00
Dean Herbert
afcc3e14f4
m 2021-06-19 16:16:29 +09:00
Bartłomiej Dach
b47774b55a Remove Tagalog language for now 
Rationale given in inline comment.
 2021-06-19 08:07:37 +02:00
Bartłomiej Dach
76db87f9cb Try-catch around localisation store registration 
Some platforms (android, older windows versions) will throw exceptions
at runtime when an unsupported `CultureInfo` is attempted to be
instantiated, leading to nasty crashes. Add a preventative try-catch
registration to prevent the crash, and log the errors for visibility.
 2021-06-19 08:02:30 +02:00
Dean Herbert
3f336d88ec
Merge pull request #11461 from peppy/realm-key-binding-store 
Add initial realm database implementation with KeyBindingStore migration
 2021-06-19 02:49:41 +09:00
Dean Herbert
89c27dcb10
Merge pull request #13517 from ekrctb/initial-entry 
Allow setting `Entry` of `PoolableDrawableWithLifetime` (including `DrawableHitObject`)
 2021-06-19 00:03:41 +09:00
Dean Herbert
fa838ba253
Merge pull request #13528 from gagahpangeran/last-lang 
Add remaining non-rtl language
 2021-06-19 00:00:33 +09:00
smoogipoo
acb47b1606 Merge branch 'master' into last-lang 2021-06-18 23:30:59 +09:00
Dean Herbert
b1fd812805
Merge branch 'master' into more-ui-sfx 2021-06-18 23:24:19 +09:00
Dean Herbert
36f0769f83
Merge branch 'master' into inter-font 2021-06-18 22:38:20 +09:00
Dean Herbert
1ec03bf6fa Update resources 2021-06-18 22:25:24 +09:00
Dean Herbert
1f6b4b10ab Update resources 2021-06-18 22:16:15 +09:00
Dean Herbert
390abccb4b Add workaround for dropdowns playing close animation on first display 2021-06-18 22:08:59 +09:00
Jamie Taylor
5ce52b2669
fix ModButton duplicate click sound 2021-06-18 21:41:07 +09:00
Jamie Taylor
6e4fc26e16
replace 'songselect' hover/click sounds with 'button' ones for now 2021-06-18 21:03:46 +09:00
Jamie Taylor
953683044f
fix checkbox sounds not being used for certain checkboxes 2021-06-18 21:00:08 +09:00
Dean Herbert
5897475708
Merge pull request #13552 from peppy/fix-ruleset-dll-rename 
Fix loading a ruleset with an updated internal name causing a potential startup crash
 2021-06-18 20:18:54 +09:00
Dean Herbert
2dadc9d686 Remove unused using statement 2021-06-18 19:39:01 +09:00
Dan Balasescu
846647b5c5
Merge pull request #13549 from peppy/storyboard-outro-logic-refactor 
Separate out storyboard outro logic as much as possible from score completion flow
 2021-06-18 19:38:00 +09:00
Dean Herbert
78c5ccda60 Fix renaming a ruleset DLL causing a startup crash 2021-06-18 19:32:40 +09:00
smoogipoo
42c5a962fb Add xmldoc remark 2021-06-18 19:27:10 +09:00
smoogipoo
36d51d5117 Don't set entry immediately 2021-06-18 19:23:37 +09:00
smoogipoo
36d2199a02 Add exception on Apply() while loading 2021-06-18 19:20:57 +09:00
Jamie Taylor
d462394635
add sound to dropdowns 2021-06-18 19:16:28 +09:00
Jamie Taylor
4feb7c848f
add sound to tab controls 2021-06-18 19:16:00 +09:00
Dan Balasescu
e0f4c792b8
Merge pull request #13546 from peppy/mods-can-specify-self-in-incompatible-list 
Allow mods to specify incompatibility types which they implement themselves
 2021-06-18 19:07:38 +09:00
Dean Herbert
c751e087ca
Merge branch 'master' into skin-editor-closest-anchor 2021-06-18 18:54:07 +09:00
Dean Herbert
36b5414b1d Update comment to hopefully explain a weird conditional better 2021-06-18 17:46:01 +09:00
Dean Herbert
d5a1524eb0 Add missing rulesetID check for global action matching 2021-06-18 17:12:01 +09:00
Dean Herbert
d06e52505a Fix thread safety of KeyBindingStore.GetReadableKeyCombinationsFor 2021-06-18 17:11:39 +09:00
Dean Herbert
c369beeaaa Merge branch 'master' into realm-key-binding-store 2021-06-18 16:52:35 +09:00
Dean Herbert
0bc68a7018 Move xmldoc to method 2021-06-18 16:50:31 +09:00
Dean Herbert
19507e107e Reorder methods to make more sense 2021-06-18 16:46:40 +09:00
Dean Herbert
a7f40dc6d4 Merge branch 'remove-synchronous-prepare-score-method' into storyboard-outro-logic-refactor 2021-06-18 16:45:01 +09:00
Dean Herbert
45122594e5 Remove the synchronous version of PrepareScoreForResults 
Replaces all existing usages with the `async` version.
 2021-06-18 16:24:08 +09:00
Dean Herbert
f3426e38b4 Add note about delay parameter 2021-06-18 16:18:20 +09:00
Dean Herbert
3819a1f03b Remove exit override behaviour 
I don't actually know under what scenario this could have been hit, and
actually caused expected behaviour. Consider that in the scenario I
describe in the comment (which I added yesterday), the user is
requesting a pause or exit which would be "cancelled showing the results
instead". But in such a scenario, `PerformExit` would first be run,
which cancels the `resultsDisplayDelegate` in the first place.

The only special case would be pressing the close button on the window
decoration? Which I don't think should be a special case in the first
place, so I'm just going to remove this for the time being to keep
things simple.
 2021-06-18 16:12:35 +09:00
Dean Herbert
06d1bd971c Default DrawableStoryboard to a completed state to avoid state change on empty storyboards 2021-06-18 16:08:49 +09:00
Dean Herbert
7ef8eac773 Remove unnecessary (and no longer correct) exception 2021-06-18 16:08:31 +09:00
Jamie Taylor
752d0a9f0b
add sound to scroll-to-top button 2021-06-18 16:08:14 +09:00
Dean Herbert
2bf855fcca Move all storyboard outro skip logic out of updateCompletionState 
This method should only be called to trigger the score completion
portion of player progression. The storyboard skip/end logic is now
handled separately in `progressToResults`.
 2021-06-18 15:50:43 +09:00
smoogipoo
5cf2ac78fc Adjust font namespaces 2021-06-18 15:40:35 +09:00
Dan Balasescu
2cd72a92e8
Merge pull request #13499 from ekrctb/fix-mania-editor-crash 
Rewrite mania selection blueprint to use only `HitObject` (no `DrawableHitObject`) for layout
 2021-06-18 15:10:28 +09:00
Dan Balasescu
cdc1c60fab
Merge branch 'master' into fix-mania-editor-crash 2021-06-18 13:49:25 +09:00
Dean Herbert
4de27429bc Change ModSelectOverlay to never deselect the user triggered selection 2021-06-18 13:17:55 +09:00
Dean Herbert
5933e0d2d9 Change CheckCompatibleSet to never deselect the current candidat when checking incompatibility 2021-06-18 13:17:32 +09:00
smoogipoo
97cd1217a4 Move IApplicableToDrawableHitObjects to its own file 2021-06-18 13:06:13 +09:00
Bartłomiej Dach
f282326f9a Move score preparations back below ShowResults check 2021-06-17 19:04:52 +02:00
Bartłomiej Dach
3a1444e75d Fix malformed xmldoc tag 
Oops. Made a typo in the PR suggestion.
 2021-06-17 19:02:56 +02:00
Dean Herbert
9facfe8964
Apply suggestions from code review 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2021-06-18 01:07:54 +09:00
Dean Herbert
e0a3696145
Merge branch 'master' into player-completion-refactoring 2021-06-17 23:51:42 +09:00