10783 Commits

Author	SHA1	Message	Date
Dean Herbert	6be02966b9	Add test coverage of failing context menu display	2023-10-30 18:06:11 +09:00
Bartłomiej Dach	0dfb41b796	Add test coverage for not updating LastPlayed due to newer plays	2023-10-30 09:28:37 +01:00
Dean Herbert	caddbacfe8	Merge branch 'master' into gameplay-hud-redesign/counters	2023-10-30 16:35:10 +09:00
Dean Herbert	96dd7b3333	Update the last played date of a beatmap when importing a replay by the local user	2023-10-30 15:44:16 +09:00
Salman Ahmed	c7bc8e6865	Move behaviour to settings search text box only	2023-10-30 06:41:01 +03:00
Salman Ahmed	af10dbb76c	Add test case with many tournament banners	2023-10-30 06:20:01 +03:00
Salman Ahmed	ec9ae12bbd	Update API response model to accept array of tournament banners	2023-10-29 01:43:49 +03:00
Salman Ahmed	31c6973bb6	Add test coverage	2023-10-29 01:03:45 +03:00
Susko3	cfc0520481	Add failing test	2023-10-28 12:13:13 +02:00
Salman Ahmed	a53c0adae0	Remove unused using directive	2023-10-28 06:56:12 +03:00
Salman Ahmed	51b7c97cab	Fix TestScenePlayerMaxDimensions bottlenecking CI	2023-10-28 06:07:49 +03:00
Bartłomiej Dach	2f9b50172e	Add failing test coverage for video events affecting storyboard time bounds	2023-10-27 22:09:33 +02:00
Dean Herbert	5a9d4170e8	Merge pull request #24794 from bdach/score-encoding-cleanup ... Correctly handle multiple online score ID types	2023-10-28 02:29:56 +09:00
Dean Herbert	4ed30342db	Merge pull request #25264 from bdach/quick-retry-f-rank ... Fix quick retry immediately after completion marking score as failed	2023-10-28 02:29:21 +09:00
Bartłomiej Dach	b5cb538004	Add failing test case for skin editor freeze	2023-10-27 14:23:41 +02:00
Bartłomiej Dach	6789a522d6	Rename test to distinguish it from test-to-come	2023-10-27 14:15:30 +02:00
Bartłomiej Dach	32fc19ea0d	Fix results screen test failure	2023-10-27 13:22:17 +02:00
Bartłomiej Dach	96d784e06b	Delete ScoreInfo.HasReplay as no longer needed	2023-10-27 12:39:54 +02:00
Bartłomiej Dach	3944b045ed	Add extra test coverage for marking score as failed	2023-10-27 12:17:03 +02:00
Bartłomiej Dach	7140eee870	Add failing test coverage for quick retry after completion not changing rank	2023-10-27 12:17:03 +02:00
Dean Herbert	fc25e24397	Merge branch 'master' into score-encoding-cleanup	2023-10-27 18:03:38 +09:00
Bartłomiej Dach	0482c05d7c	Add failing test case	2023-10-26 19:38:52 +02:00
Dean Herbert	a463c37320	Merge pull request #25243 from bdach/song-select-volume-scroll-blocked ... Fix left side of carousel blocking volume adjust hotkeys	2023-10-27 00:23:47 +09:00
Bartłomiej Dach	5d6a58d443	Add failing test scene for scroll handling in song select	2023-10-26 16:24:16 +02:00
Bartłomiej Dach	dbb69419e6	Add test coverage for parsing new online ID	2023-10-26 12:39:07 +02:00
Bartłomiej Dach	89fec95b01	Fix cross-test data dependency by recreating slider every time	2023-10-26 12:11:26 +02:00
Bartłomiej Dach	96437c4518	Fix tests specifying float precision for double bindable ... Would cause assignments to `.Value` to become imprecise even if the underlying bindable could represent the value 100% accurately.	2023-10-26 12:06:03 +02:00
Bartłomiej Dach	910d74fdda	Add failing test coverage for double-click on disabled sliders	2023-10-26 11:59:38 +02:00
Salman Ahmed	841c5bb4bd	Add modified skin for serialisation test coverage	2023-10-26 11:05:00 +03:00
Bartłomiej Dach	2ba02416c2	Revert test changes fully to clean up diff	2023-10-26 09:14:59 +02:00
Bartłomiej Dach	ca4b09f8ef	Merge branch 'master' into score-encoding-cleanup	2023-10-26 09:04:05 +02:00
Salman Ahmed	df80b4dcab	Update "Argon" health display specifications to match design ... Also adds a little white bar next to the display to match with the components below it (score/accuracy/combo counters).	2023-10-26 09:12:05 +03:00
Salman Ahmed	56eeb117ce	Add "Argon" performance points counter	2023-10-26 09:10:10 +03:00
Salman Ahmed	0aa0562dc0	Add "Argon" combo counter	2023-10-26 09:09:55 +03:00
Salman Ahmed	1f36acca1a	Add "Argon" accuracy counter	2023-10-26 09:09:52 +03:00
Salman Ahmed	9ca672d689	Add "Argon" total score counter	2023-10-26 08:58:25 +03:00
Dean Herbert	6934e045df	Fix editor not prompting before saving beatmap for export	2023-10-25 14:39:46 +09:00
Bartłomiej Dach	19be0055d5	Merge pull request #24921 from Pasi4K5/diff-name-search ... Add ability to search for difficulty names using square brackets	2023-10-24 12:07:02 +02:00
Bartłomiej Dach	966decb008	Remove redundant explicit array type specification	2023-10-24 11:25:37 +02:00
Bartłomiej Dach	b4cc12ab5a	Fix formatting	2023-10-24 10:00:58 +02:00
Dean Herbert	fcb366af4d	Add diff= support for more advanced usages	2023-10-24 16:09:05 +09:00
Dean Herbert	6865d8894d	Simplify implementation and remove unsupported test coverage	2023-10-24 16:01:32 +09:00
Dean Herbert	794c3a2473	Add a couple more tests for sanity	2023-10-24 15:22:27 +09:00
Dean Herbert	b16ece32f4	Put tests in more correct place	2023-10-24 15:14:30 +09:00
Dean Herbert	383d715378	Fix incorrectly named test	2023-10-24 14:59:21 +09:00
Andrei Zavatski	1dbdbd6de6	Merge branch 'master' into comments-image-size	2023-10-23 13:22:31 +03:00
Dean Herbert	a26e0bda35	Merge pull request #25179 from bdach/insufficient-sample-point-query-leniency ... Fix insufficient leniency when querying sample points	2023-10-20 20:07:32 +09:00
Bartłomiej Dach	59a1915451	Add failing test case for insufficient sample query leniency	2023-10-20 10:25:28 +02:00
Dean Herbert	686c45e21b	Merge branch 'master' into legacy-tick-test-coverage	2023-10-20 16:41:32 +09:00
Dean Herbert	f36a671eb4	Fix a couple of silly inspections	2023-10-20 15:38:00 +09:00
Bartłomiej Dach	dcfd6a0a8a	Remove DistancedHitObjectComposer inheritance from osu! composer	2023-10-19 11:46:30 +02:00
Dan Balasescu	939b55020c	Merge branch 'master' into legacy-tick-test-coverage	2023-10-18 15:21:31 +09:00
Joseph Madamba	1a3a81c33b	Add slider nub double click revert to default test	2023-10-17 21:41:03 -07:00
Bartłomiej Dach	e927267c4d	Merge pull request #25155 from peppy/fix-new-inspections ... Fix various new rider EAP inspections	2023-10-17 17:04:39 +02:00
Dean Herbert	e081fa48a2	Fix various other inspections	2023-10-17 17:48:51 +09:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Dean Herbert	4885c55ef0	Merge branch 'master' into key-binding-deduplication	2023-10-17 17:17:44 +09:00
Dan Balasescu	d2a3f14d5b	Merge branch 'master' into mania-bonus-refactor	2023-10-17 13:28:04 +09:00
Bartłomiej Dach	3aae07d1ca	Add failing case for two bindings of single action bound to same key	2023-10-16 22:20:26 +02:00
Bartłomiej Dach	9c6166ec3d	Add migration to remove duplicate bindings	2023-10-16 22:20:26 +02:00
Bartłomiej Dach	90c44cee54	Implement method to deduplicate keybindings	2023-10-16 20:51:57 +02:00
Bartłomiej Dach	79273b88f6	Add stub of method to deduplicate bindings (and failing test)	2023-10-16 20:48:52 +02:00
Bartłomiej Dach	e2192806e4	Use ID rather than SoloScoreID ... The latter is apparently not going to be a thing anymore.	2023-10-16 12:02:55 +02:00
Bartłomiej Dach	d5a733d244	Use solo score ID as OnlineID when converting from MultiplayerScore	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	bfcb4f4f2d	Add failing test for legacy online ID decoding	2023-10-16 11:20:02 +02:00
Dean Herbert	7c49843411	Fix various tests	2023-10-16 14:21:33 +09:00
Bartłomiej Dach	9b474b656d	Fix key binding panel test failures from introducing placeholder text ... Whoops.	2023-10-13 15:03:41 +02:00
Dean Herbert	6358a5e210	Merge pull request #25105 from bdach/multiple-keys-one-binding ... Disallow binding multiple bindings in a single section to one key	2023-10-13 20:01:33 +09:00
Bartłomiej Dach	5f51b8a7c9	Merge pull request #25097 from peppy/results-screen-progress-fast ... Show results immediately if user hits "back" key after finishing gameplay	2023-10-13 11:54:34 +02:00
Dean Herbert	17b6ebbfbf	Avoid using a bindable in KeyBindingConflictPopover where data is never mutated	2023-10-13 18:40:21 +09:00
Bartłomiej Dach	d5557bbbfb	Merge pull request #25005 from minetoblend/multiplayer-invites ... Add ability to invite players to multiplayer rooms	2023-10-13 11:09:28 +02:00
Dean Herbert	37411f923e	Merge branch 'master' into multiple-keys-one-binding	2023-10-13 15:07:12 +09:00
Dean Herbert	549a6581b0	Merge branch 'master' into make-realm-key-binding-action-suck-less	2023-10-13 13:53:24 +09:00
Dean Herbert	aabed8b6e5	Merge pull request #25093 from Joehuu/mod-switch-tiny-extended-info ... Add extended info support to tiny mod switches	2023-10-13 13:40:24 +09:00
Bartłomiej Dach	f083309e64	Move type back next to exposing class	2023-10-12 20:26:01 +02:00
Bartłomiej Dach	5d637520e7	Add test coverage for key binding conflict resolution	2023-10-12 16:04:46 +02:00
Bartłomiej Dach	f5a6781e5a	Integrate key binding conflict popover into keybindings panel	2023-10-12 16:04:46 +02:00
Bartłomiej Dach	7b6563116a	Implement visual appearance of key binding conflict popover	2023-10-12 16:01:51 +02:00
Bartłomiej Dach	5f0b1d69a5	Prepare KeyBindingRow for accepting external changes	2023-10-12 16:00:20 +02:00
Bartłomiej Dach	2a0e4c364d	Add method to unmap RealmKeyBinding.Action to actual enum-typed value	2023-10-12 14:17:26 +02:00
Dean Herbert	fa47309eef	Fix exit key during storyboard outro not progressing to results	2023-10-12 19:31:54 +09:00
Bartłomiej Dach	34bab38e80	Fix judgement counter test failure due to exploiting mania ruleset ... Large ticks are not a thing in mania anymore, so the judgement counter tests began to fail as `LargeTickHit` is no longer a valid hit result in that ruleset.	2023-10-12 11:34:59 +02:00
Dean Herbert	56e27f1c27	Merge branch 'master' into multiplayer-invites	2023-10-12 18:17:15 +09:00
Dean Herbert	e6103fea95	Fix async usage in TestSceneNotificationOverlay	2023-10-12 16:00:36 +09:00
Dean Herbert	3023e44196	Remove unused using statements	2023-10-12 15:52:48 +09:00
Dean Herbert	73b8146729	Update tests in line with new behaviour	2023-10-12 15:42:54 +09:00
Dean Herbert	256c95f045	Add (failing) test coverage of exit/retry during progress to results	2023-10-12 15:42:20 +09:00
Dean Herbert	f26e3afd29	Merge pull request #25062 from smoogipoo/remove-hold-note-ticks ... Remove osu!mania hold note ticks	2023-10-12 13:55:50 +09:00
Joseph Madamba	764f641bc9	Add extended info support to tiny mod switches	2023-10-11 12:47:12 -07:00
Bartłomiej Dach	712564ea4f	Enable NRT in KeyBindingsSubsection	2023-10-11 20:03:31 +02:00
Bartłomiej Dach	063623b4e6	Merge branch 'master' into remove-hold-note-ticks	2023-10-11 19:47:51 +02:00
Bartłomiej Dach	66c12e5269	Merge pull request #25083 from peppy/fix-preview-point-incorrect ... Fix default preview point being incorrect on old beatmaps	2023-10-10 19:54:14 +02:00
Dean Herbert	7220ca34f7	Add failing test coverage of incorrect default preview time	2023-10-10 19:13:16 +09:00
Dean Herbert	4319b22db8	Add failing test coverage of player not pausing track correctly	2023-10-10 17:55:35 +09:00
Dan Balasescu	94192644be	Fix tests	2023-10-10 16:54:24 +09:00
Bartłomiej Dach	ea400a9db7	Fix cross-test interference ... `TestLastPlayedUpdated` was implicitly relying on running first. `TestGuestScoreIsStoredAsGuest` showing up changed test ordering, causing the former test to fail if it didn't get to run first.	2023-10-10 09:30:51 +02:00
Bartłomiej Dach	08b1a3cbe2	Add failing test case for guest user being looked up in API	2023-10-10 09:18:57 +02:00
Dan Balasescu	89a3be11cb	Add validation test	2023-10-10 09:56:35 +09:00
Bartłomiej Dach	71c4b138fb	Merge branch 'master' into fix-legacy-score-multipliers-2	2023-10-09 10:53:14 +02:00
Dan Balasescu	b65c70018f	Add test for the result	2023-10-09 12:11:29 +09:00
Dean Herbert	7c7771afca	Merge pull request #24986 from peppy/health-animates-in-intro ... Add initial animation for health bars	2023-10-07 10:31:34 +09:00
Bartłomiej Dach	cfcdbe1c30	Merge pull request #25028 from peppy/bindable-fixes ... Fix some incorrect bindable-related code	2023-10-06 22:31:30 +02:00
Bartłomiej Dach	a099cc0f36	Merge pull request #25030 from peppy/adjustable-health-bar ... Adjust argon health bar to fit with existing layout	2023-10-06 21:51:18 +02:00
Bartłomiej Dach	5ea45e3e96	Rename local variable	2023-10-06 19:43:00 +02:00
Dean Herbert	1a60e6d76e	Merge branch 'master' into health-animates-in-intro	2023-10-07 00:32:19 +09:00
Dean Herbert	71be3c8f8b	Add ability to adjust health bar settings in test scene	2023-10-06 19:34:27 +09:00
Dean Herbert	db5178e453	Change ArgonHealthDisplay to be relative sized for now	2023-10-06 18:56:39 +09:00
Dean Herbert	7227f5c881	Fix a couple of compilation errors	2023-10-06 18:13:02 +09:00
Dean Herbert	f2e56bbb65	Fix publicly-settable bindables	2023-10-06 16:51:24 +09:00
Dean Herbert	f9021bf551	Remove pointless test class in TestSceneStoryboardSamples	2023-10-06 16:43:28 +09:00
Dean Herbert	1005b7ac85	Fix incorrect test assumption in TestSceneEditorClock ... I don't know what this test was trying to do, but it was wrong. Any offset which is applied should be invisible to the clock's final `CurrentTime` (and to the user).	2023-10-06 16:43:28 +09:00
Dean Herbert	354193c53a	Merge branch 'master' into clock-fix-attempt-2	2023-10-06 16:43:27 +09:00
Bartłomiej Dach	c195fbe76f	Merge branch 'master' into crop-gameplay-textures	2023-10-05 09:35:58 +02:00
Dean Herbert	5a0faaa0b1	Fix TestReplayExport intermittent failure ... The previous fix was not working as it was checking the path for the prefix `_`, not the filename. See https://github.com/ppy/osu/runs/17415814653#r0s2 which clearly shows this.	2023-10-05 14:30:06 +09:00
Bartłomiej Dach	bd71403309	Merge branch 'master' into health-animates-in-intro	2023-10-04 13:53:42 +02:00
Dean Herbert	5a17a86d1d	Merge branch 'master' into clock-fix-attempt-2	2023-10-04 16:57:49 +09:00
Dan Balasescu	854b797ab5	Merge branch 'master' into legacy-tick-not-so-legacy-after-all	2023-10-04 10:52:13 +09:00
Marvin Schürz	5678d90461	Reduce silliness of notification test case	2023-10-04 00:20:38 +02:00
Dan Balasescu	a120ea8464	Merge branch 'master' into fix-legacy-score-multipliers-2	2023-10-04 01:19:33 +09:00
Dean Herbert	69ae370e82	Merge branch 'master' into legacy-tick-test-coverage	2023-10-03 19:37:32 +09:00
Bartłomiej Dach	844a3b6c1b	Merge pull request #24980 from frenzibyte/gameplay-hud-redesign/health-display ... Implement redesigned health bar display for "Argon" skin	2023-10-03 11:26:21 +02:00
Dean Herbert	e1445fcc65	Adjust health display test scene's background colour to better visualise background fill	2023-10-03 17:17:42 +09:00
Dean Herbert	b234a453da	Fix legacy beatmap importer not always handling nested paths correctly ... Addresses https://github.com/ppy/osu/discussions/24989.	2023-10-03 16:01:17 +09:00
Marvin Schürz	e81695bcac	Display avatar in invitation notification	2023-10-02 23:10:51 +02:00
Dan Balasescu	b9ab4a2b7c	Update score conversion to consider legacy multiplier	2023-10-02 16:56:15 +09:00
Dean Herbert	622cbc3af7	Adjust test scene to actually make HP bars fit	2023-10-02 16:07:45 +09:00
Salman Ahmed	8d389accf8	Cover "Argon" helath display in skin deserialisation tests	2023-10-01 15:12:24 +03:00
Salman Ahmed	9e2b8254d9	Add argon-specific health display test scene	2023-10-01 13:26:47 +03:00
Salman Ahmed	776536e816	Add "Argon" health display implementation	2023-10-01 00:56:16 +03:00
Salman Ahmed	869f8e5e1b	Adjust test scene to apply miss judgements as well	2023-10-01 00:21:24 +03:00
Salman Ahmed	314ecec65b	Refactor player max dimensions test scene to actually upscale textures	2023-09-30 01:34:49 +03:00
Pasi4K5	c927f90a48	Replace regex with a custom algorithm and update test scene.	2023-09-29 13:46:33 +02:00
Dean Herbert	62bcb62842	Document remaining pieces of LastTick and add back legacy prefix for generation flow	2023-09-29 16:58:17 +09:00
Dean Herbert	81485c548c	Move LegacyLastTickOffset specification to generation code and stop passing everywhere	2023-09-29 14:32:29 +09:00
Bartłomiej Dach	7638ea36a0	Merge branch 'master' into mod-icon-extended	2023-09-28 16:57:17 +02:00
Dan Balasescu	db9113b38e	Merge pull request #24924 from bdach/update-classic-scoring ... Update classic scoring formula to closer match stable score V1	2023-09-28 20:19:23 +09:00
Dean Herbert	b8953e8ce1	Code quality pass	2023-09-28 19:03:34 +09:00
Bartłomiej Dach	afa1815d13	Merge pull request #24929 from peppy/reduce-song-select-debounce ... Reduce delay before loading beatmap after selection change at song select	2023-09-28 10:45:43 +02:00
Dean Herbert	4d5b2477dc	Fix failing song select tack transfer test by using a real track	2023-09-28 15:59:06 +09:00
Bartłomiej Dach	0b9d01075a	Merge branch 'master' into fix-missing-skin-ini-version	2023-09-27 19:33:43 +02:00
Dean Herbert	16e752e07d	Add basic structure and test coverage for extended info on mod icon	2023-09-27 19:29:03 +09:00
Dean Herbert	a7237e48aa	Merge branch 'master' into fix-storyboard-skin-textures-lookup	2023-09-27 17:17:51 +09:00
Dean Herbert	84682b4227	Add test coverage of incorrect version on missing skin.ini	2023-09-27 16:50:01 +09:00
Bartłomiej Dach	12585c9f27	Fix flaky editor beatmap creation test ... Came up as a failure when locally running tests for ppy/osu-framework#6001 - but the test is actually a previously-known flaky that I couldn't reproduce the failure of until the aforementioned PR. This appears to be a simple race; the test scene queries the track length from update thread, but the length is actually set on the audio thread. So it's not unreasonable that given unlucky timing, the length will not be set by `TrackBass` before it is queried. To fix, switch assert to until step. I'm generally not really willing to give this more time of day until this change is proven insufficient.	2023-09-26 16:42:59 +02:00
Dean Herbert	40a548d372	Adjust new test scene to not be super broken	2023-09-26 17:30:49 +09:00
Dean Herbert	990c54519b	Merge branch 'master' into limit-gameplay-sprite-dimensions	2023-09-26 16:40:32 +09:00
Dean Herbert	b1561b650f	Rename test scene, add xmldoc and increase scale factor to something absurdly high	2023-09-26 16:39:36 +09:00
Dean Herbert	2ca1c684bb	Merge branch 'master' into fix-storyboard-skin-textures-lookup	2023-09-26 14:05:27 +09:00
Bartłomiej Dach	72c61c3a6a	Update osu! scoring tests to match updated formulae	2023-09-25 19:16:31 +02:00
Pasi4K5	ab57cbf6f5	Add TestSceneDifficultySearch	2023-09-25 12:53:17 +02:00
Andrei Zavatski	292273edbe	Add test scene	2023-09-23 06:31:26 +03:00
Dean Herbert	c40bd74138	Update usages of GameplayClockContainer not using an adjustable source	2023-09-22 16:22:36 +09:00
Dean Herbert	a3e4d19933	Update tests which were not using an IAdjustableClock as GameplayClockContainer source	2023-09-22 16:22:36 +09:00
Dean Herbert	8367bb6bee	Don't apply decoupling to SpectatorPlayerClocks ... See inline comment for reasoning. It's a bit complicated.	2023-09-22 16:22:35 +09:00
Dean Herbert	3cb928fe6f	Add note about test not calling ProcessFrame	2023-09-22 16:22:35 +09:00
Dean Herbert	59d6e67512	Add missing TestManualClock.Reset implementation for safe measure	2023-09-22 16:22:35 +09:00
Dean Herbert	3f27be1f33	Replace most usages of DecoupleableInterpolatingFramedClock ... Except `FramedBeatmapClock`, which is the high-effort one.	2023-09-22 12:49:25 +09:00
Bartłomiej Dach	e45d456324	Fix TestFriendScore intermittently failing due to randomness ... If `createRandomScore()` happened to randomly pick the highest total score when called with `friend` as the sole argument, that particular score would not be pink. `GetScoreByUsername()` would arbitrarily pick the first score for the user, so in this particular case where a friend had the number 1 score, the test would wrongly fail. Fix by checking whether any of the 3 added friend scores have received the pink colour. Because there is more than 1 friend score in the test, doing so ensures that at least one of those should eventually become pink (because, obviously, you can't have two scores at number 1).	2023-09-21 21:12:44 +02:00
Bartłomiej Dach	9301a1907a	Rewrite TestFriendScore assertions to constraint model ... Allows to clearly see what the failure is: TearDown : System.TimeoutException : "friend score is pink" timed out: Expected: some item equal to "#FF549A" But was: < "#FFFFFF", "#7FCC33", "#444444" > The #7FCC33 colour is used for the first score on the leaderboard.	2023-09-21 21:05:41 +02:00
Bartłomiej Dach	d73f06fc89	Add test coverage for delete hotkey	2023-09-21 20:01:59 +02:00
Bartłomiej Dach	69ed99dfd5	Merge branch 'master' into mania-edit-disable-sv	2023-09-21 09:13:27 +02:00
Bartłomiej Dach	d7129da8ea	Fix TestSceneDrawableStoryboardSprite not displaying anything	2023-09-20 12:05:23 +02:00
Dean Herbert	c5397bdbb3	Merge branch 'master' into mania-edit-disable-sv	2023-09-20 14:23:07 +09:00
Dean Herbert	12611a09f1	Merge branch 'master' into editor/checks/delayed-hitsounds	2023-09-20 14:18:41 +09:00
Dean Herbert	1927b524db	Merge branch 'master' into leaderboard-friend-highlight	2023-09-20 14:14:08 +09:00
Dean Herbert	1316403180	Fix inspection in new test scene	2023-09-20 13:02:40 +09:00
Dean Herbert	aea7f81f1c	Merge pull request #24800 from sw1tchbl4d3r/invalid_bank ... Default to normal bank if invalid sample bank is specified	2023-09-19 22:28:34 +09:00
Bartłomiej Dach	320a9fc171	Replace test with better test	2023-09-19 13:47:46 +02:00
Dean Herbert	2f020f8682	Add test coverage of storyboard preferring skin when specified	2023-09-19 20:20:20 +09:00
Dean Herbert	067c487b21	Merge pull request #24450 from cdwcgt/missing-beatmap ... Fetch missing beatmap when importing replay	2023-09-19 18:40:02 +09:00
Dean Herbert	f726c38215	Pass ArchiveReader instead of Stream to simplify resolution code	2023-09-19 17:49:15 +09:00
Bartłomiej Dach	0ffb906741	Merge pull request #24831 from peppy/update-deps ... Update all dependencies (except for Moq)	2023-09-19 07:50:27 +02:00
Salman Ahmed	8e992de763	Fix crash when loading player instance without exiting previous instance	2023-09-19 05:09:01 +03:00
Salman Ahmed	a373d71b3e	Add basic test scene upscaling all skin elements	2023-09-19 03:40:31 +03:00
Salman Ahmed	57dc76b345	Revert "Update GetTexture signature rather than creating new overload" ... This reverts commit 96f12cfbaa.	2023-09-19 03:21:19 +03:00
Bartłomiej Dach	775f96f061	Add very basic visual tests for missing beatmap notification ... The full-stack test using the whole 9 `OsuGameTest` yards is unusable for rapid development. I don't really get how you could ever design anything using it without tossing your computer out the window.	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	06d1a2a316	Merge branch 'beatmap-card-nano' into missing-beatmap	2023-09-18 14:56:06 +02:00
Dean Herbert	f3b6aa5435	Merge pull request #24821 from bdach/scoring-test-scene-osu ... Refactor scoring test scene for ruleset extensibility (and move existing instance to osu! ruleset project)	2023-09-18 19:54:14 +09:00
Bartłomiej Dach	5c2413c06b	Implement nano beatmap card	2023-09-18 11:30:14 +02:00
Bartłomiej Dach	3709861132	Merge pull request #24814 from LukynkaCZE/parse-only-supported-char-uris ... Parse only supported schemes as URIs	2023-09-18 10:20:09 +02:00
Bartłomiej Dach	a2df123c6d	Add failing test case for fake (but still incorrectly allowed) protocol	2023-09-18 09:19:12 +02:00
Dean Herbert	56b5f52e83	Update all dependencies (except for Moq)	2023-09-16 15:37:31 +09:00
Bartłomiej Dach	45751dd1f2	Minimum viable changes for ruleset-specific scoring test scenes	2023-09-15 12:58:29 +02:00
Bartłomiej Dach	a6fab28461	Merge branch 'master' into no-legacy-difficulty-control-point	2023-09-15 11:14:28 +02:00
Lukynka CZE	2a18f76b02	add visual test	2023-09-14 17:48:10 +02:00
Lukynka CZE	25926af782	add unit test	2023-09-14 17:46:42 +02:00
Bartłomiej Dach	6aff1d4063	Merge branch 'master' into mod-select-difficulty-multiplier-animation	2023-09-14 16:23:30 +02:00
Bartłomiej Dach	44461b4eff	Merge branch 'master' into mod-select-diff-multiplier-visual-matching	2023-09-14 12:12:23 +02:00
Dan Balasescu	753c1c877c	Revert masking SSBO changes	2023-09-13 23:10:13 +09:00
sw1tchbl4d3	8f9cde01aa	Add test	2023-09-13 13:38:13 +02:00
Dean Herbert	32946413de	Change display text from "difficulty" to "score" multiplier	2023-09-13 20:01:19 +09:00
Dean Herbert	35840bf671	Combine ModCounterDisplay and DifficultyMultiplierDisplay into one class	2023-09-13 18:51:56 +09:00
Bartłomiej Dach	7c65a9de75	Fix Score V1 simulation in scoring test scene incorrectly applying multiplier ... `TestSceneScoring` included a local simulation of stable's Score V1 algorithm. One of the parts of said algorithm is a mysterious "score multiplier", influenced by - among others - the beatmap's drain rate, overall difficulty, circle size, object count, drain length, and active mods. (An implementation of this already exists in lazer source, in `OsuLegacyScoreSimulator`, but more on this later.) However, `TestSceneScoring` had this multiplier in _two_ places, with _two_ distinct values, one of which being 1 (i.e. basically off). Unfortunately, the place that had 1 as the multiplier was the wrong one. Stable calculates the score increase for every hit in two stages; first, it takes the raw numerical value of the judgement, but then applies a combo-based bonus on top of it: scoreIncrease += (int)(Math.Max(0, ComboCounter.HitCombo - 1) * (scoreIncrease / 25 * ScoreMultiplier)); On the face of it, it may appear that the `ScoreMultiplier` factor can be factored out and applied at the end only when returning total score. However, once the above formula is rewritten as: scoreIncrease = scoreIncrease + (int)(Math.Max(0, ComboCounter.HitCombo - 1) * (scoreIncrease / 25 * ScoreMultiplier)); = scoreIncrease * (1 + (Math.Max(0, ComboCounter.HitCombo - 1) / 25 * ScoreMultiplier)) it becomes clear that that assumption is actually _incorrect_, and the `ScoreMultiplier` _must_ be applied to every score increase individually. The above was cross-checked experimentally against stable source on an example test map with 100 objects, and a replay hitting them perfectly.	2023-09-12 21:33:26 +02:00
Bartłomiej Dach	3981e2e957	Only show visible graph values in tooltip	2023-09-12 13:29:02 +02:00
Bartłomiej Dach	15708ee465	Add toggle for showing relative/absolute score values	2023-09-12 13:27:40 +02:00
Bartłomiej Dach	607ceeccb9	Persist visibility state of graphs	2023-09-12 12:19:50 +02:00
Bartłomiej Dach	3cf8082aa7	Add capability to toggle visibility of graph	2023-09-12 12:07:12 +02:00
Bartłomiej Dach	95d15a703e	Improve legibility of scoring test scene ... - Add black background to avoid clashes with background images. - Use sorta-tetradic colours for the four plots.	2023-09-12 11:36:41 +02:00
Dean Herbert	0d7157f727	Merge branch 'master' into map_info_on_mod_settings	2023-09-12 17:16:47 +09:00
Dean Herbert	7e3652284d	Adjust various class naming and add some xmldoc	2023-09-12 17:15:16 +09:00
Dean Herbert	b4bedee49e	Adjust naming of component to give more context	2023-09-12 15:43:59 +09:00
tsrk.	dbc07bc6dc	fix: provide OverlayColourProvider as a dep in tests	2023-09-12 01:34:17 +02:00
Bartłomiej Dach	824416067e	Fix test failure	2023-09-11 20:53:17 +02:00
tsrk.	8c137353b6	feat: integrate previous usernames tooltip to profile overlay	2023-09-11 15:02:19 +02:00
Bartłomiej Dach	f9d4fbee56	Add collapsed state to effect preview panel	2023-09-11 10:16:24 +02:00
Bartłomiej Dach	589f56d20c	Merge branch 'master' into map_info_on_mod_settings	2023-09-11 09:55:54 +02:00
Bartłomiej Dach	53c30dca64	Fix data flow being sometimes incorrect	2023-09-11 09:53:58 +02:00
Bartłomiej Dach	a631fae6df	Add actual testing	2023-09-11 09:19:37 +02:00
Bartłomiej Dach	2bb869732e	Delete outdated warning disables	2023-09-07 18:47:01 +02:00
Dean Herbert	b34a36f6ce	Remove all usage of LegacyDifficultyControlPoint	2023-09-07 17:41:57 +09:00
Dean Herbert	87ec33bb66	Tidy up test	2023-09-07 14:50:22 +09:00
Joseph Madamba	5ee412cc9a	Use @2x variant of profile badges	2023-09-06 16:17:53 -07:00
cdwcgt	68752f95e5	color friend score to pink	2023-09-06 22:58:03 +09:00
Dean Herbert	1a37543d28	Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity	2023-09-06 19:01:08 +09:00
Bartłomiej Dach	eddb879973	Merge pull request #24722 from peppy/beatmap-status-pill-animation ... Add animation support for beatmap status pills	2023-09-06 09:59:21 +02:00
Bartłomiej Dach	b5e812eb3e	Merge pull request #24723 from bdach/beatmap-carousel-split-missing-status ... Fix status on carousel beatmap set not showing in split difficulty mode	2023-09-06 09:35:38 +02:00
Bartłomiej Dach	b884f1af4a	Assign random statuses to beatmap sets in carousel test ... Just to have visual coverage of the statuses before fixing them not propagating to split difficulty mode.	2023-09-06 08:25:07 +02:00
Dean Herbert	dded7fe6ca	Merge branch 'master' into beatmap-options-popover	2023-09-06 15:16:34 +09:00
Dean Herbert	034c887dcb	Add animation support for beatmap status pills ... To be used in conjunction with https://github.com/ppy/osu/pull/22116	2023-09-06 15:04:25 +09:00
Joseph Madamba	3f92dae55c	Move star rating display and status pill out of reloadable content	2023-09-05 15:20:20 -07:00
Joseph Madamba	676240928e	Move actual star updating to star rating display	2023-09-05 14:57:55 -07:00
Dean Herbert	96f12cfbaa	Update GetTexture signature rather than creating new overload	2023-09-05 18:01:19 +09:00
Dean Herbert	02fefff5e7	Add better testing of options popover	2023-09-05 16:44:46 +09:00
Dean Herbert	340edf68d3	Fix test scene not updating all star counters	2023-09-05 15:59:00 +09:00
Joseph Madamba	9451613391	Rename null beatmap test to indicate there's a background	2023-09-04 21:39:41 -07:00
Joseph Madamba	854bb323cc	Remove weird red edge effect visibility	2023-09-04 21:21:55 -07:00
Joseph Madamba	e0a9c7e9a9	Fix wedge showing abruptly in test	2023-09-04 14:54:58 -07:00
Joseph Madamba	2df2002735	Move negative corner radius margin to constructor	2023-09-04 12:42:01 -07:00
Joseph Madamba	2fbd67cf26	Merge branch 'master' into beatmap_wedge_clean_ii	2023-09-04 11:24:20 -07:00
Joseph Madamba	5abf271b56	Implement beatmap options popover	2023-09-04 00:53:09 -07:00
cdwcgt	58844092d6	post a notification instead a screen	2023-09-04 16:17:21 +09:00
cdwcgt	dfecddbf5d	Merge branch 'master' into missing-beatmap	2023-09-04 12:41:23 +09:00
Magnus-Cosmos	ae9c901b94	Fix BeatmapInfoWedge tests failing due to BPM	2023-09-03 01:45:22 -04:00
Dean Herbert	0f5eff1230	Merge branch 'master' into mania-edit-disable-sv	2023-09-01 19:08:48 +09:00
tsrk	b3d432b0d5	fix: issue template typo in CheckDelayedHitsounds	2023-08-29 20:15:33 +02:00
Bartłomiej Dach	118c86df34	Fix TestSceneUpdateBeatmapSetButton using random difficulty count	2023-08-28 14:57:00 +02:00
Bartłomiej Dach	6251803868	Add failing test coverage of selection not being retained on song select	2023-08-28 10:05:59 +02:00
Bartłomiej Dach	3a6920c306	Add failing test coverage of beatmap update flow w/ split diffs	2023-08-28 09:51:44 +02:00
Dean Herbert	84f4fab9cf	Adjust test to actually test diff splitting	2023-08-25 18:09:51 +09:00
tsrk	f05659a1c0	test: explicit samples timings	2023-08-25 00:10:21 +02:00
tsrk	a885bf6ebf	feat(editor/checks): check for delayed hitsounds ... I really just borrowed the implementation from MapsetVerifier	2023-08-24 21:05:40 +02:00
Dean Herbert	b471ab07a6	Fix typo in test step ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-24 18:30:59 +09:00
Dean Herbert	ba70d48d2c	Fix one more test probably going off-screen	2023-08-24 13:31:33 +09:00
Dean Herbert	4881130cae	Limit set/diff count in test to better fit on screen	2023-08-24 03:32:12 +09:00
Dean Herbert	5eac604f8b	Add coverage of selection retention when difficulties are split out	2023-08-23 19:44:42 +09:00
Dean Herbert	a64381f855	Add test coverage of add/remove when difficulties are split out	2023-08-23 19:43:08 +09:00
Dean Herbert	5555f73e97	Update test to match new behaviour	2023-08-23 19:38:18 +09:00
Dan Balasescu	e8337c592a	Update framework and apply changes to support masking SSBO	2023-08-22 12:50:13 +09:00
Bartłomiej Dach	99c862f894	Merge branch 'master' into fix-score-import-fail-fail-fail	2023-08-21 17:28:10 +02:00
Dean Herbert	b3e7416972	Rename new flag and update xmldoc to match	2023-08-21 19:36:22 +09:00