37360 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	bf58fe21ce	Merge branch 'master' into beatmap-set-converted-beatmaps	2023-01-16 20:46:41 +01:00
ansel	17aeb0ec19	Localise editor's UI	2023-01-16 19:55:28 +03:00
ansel	6eb5508404	Localise menu bar	2023-01-16 19:39:50 +03:00
ansel	26f3b1dbfe	Localise "revert to default" tooltip	2023-01-16 19:37:47 +03:00
Dean Herbert	4224907f08	Merge pull request #22208 from Feodor0090/editor-loc ... Localise most visible parts of editor	2023-01-16 23:05:17 +09:00
Dean Herbert	988544073c	Merge branch 'master' into ruleset-settings-loc	2023-01-16 13:29:15 +09:00
Dean Herbert	d19b35bd5f	Rename ambiguous translation keys	2023-01-16 13:18:49 +09:00
Joseph Madamba	6a847faea9	Make home string keys more specific	2023-01-15 15:23:26 -08:00
Joseph Madamba	0ff143d4c8	Add argument for play some ruleset string	2023-01-15 15:23:26 -08:00
Joseph Madamba	ae49e724e4	Move converted beatmap icons logic locally	2023-01-15 15:09:25 -08:00
Joseph Madamba	b733f46c6f	Apply NRT to BeatmapPicker	2023-01-15 15:09:25 -08:00
Joseph Madamba	27671f0401	Merge remote-tracking branch 'upstream/master' into pr/20709	2023-01-15 15:08:11 -08:00
Joseph Madamba	85c1932851	Mark Converts as nullable	2023-01-15 12:46:41 -08:00
ansel	6f84641596	Localise osu!mania settings	2023-01-15 23:30:20 +03:00
ansel	9ce7c51b14	Localise osu! settings	2023-01-15 23:29:58 +03:00
ansel	00acea59fc	Move some strings to common	2023-01-15 19:37:40 +03:00
mk56-spn	9a29c9ae26	remove hacky method to check if carousel is null	2023-01-15 15:32:53 +01:00
Dean Herbert	c5775aa452	Merge branch 'master' into song_select_nullability	2023-01-15 22:44:13 +09:00
Dean Herbert	4cf4a66858	Make MusicController a required dependency of SongSelect	2023-01-15 22:43:30 +09:00
Dean Herbert	f7af5a8115	Revert some formatting changes	2023-01-15 22:39:00 +09:00
Salman Ahmed	13c1b8f5a4	Fix intermittent failure in tests with restarting player instances	2023-01-15 16:06:06 +03:00
ansel	5d2e09137c	Remove text padding in editor menu for now	2023-01-15 14:40:53 +03:00
ansel	8777d5349b	Use existing strings	2023-01-15 14:39:34 +03:00
Joseph Madamba	627d1725c3	Fix kudosu wiki link from user profile not linking to in-game overlay	2023-01-14 19:56:51 -08:00
ansel	87650044bb	Localise create/save dialog	2023-01-15 01:50:47 +03:00
ansel	78e562903d	Localise part of editor	2023-01-15 01:50:47 +03:00
ansel	24df23f420	Localise background header	2023-01-15 01:49:19 +03:00
ansel	76eefc7573	Add support for localisation where it was missing	2023-01-15 01:46:11 +03:00
integer	a68d4fe5d1	make expansion to not use scheduler	2023-01-14 21:18:51 +00:00
ansel	1480c691ae	Explain empty string in editor's footer	2023-01-14 23:42:56 +03:00
ansel	c36922dd2c	Use clock to obtain a position for comment insertion	2023-01-14 22:57:51 +03:00
ansel	c2bb0949f5	Take type and id from container directly on submit	2023-01-14 22:57:23 +03:00
ansel	cdf3aafddd	Add check for any drawables in content before looking for placeholder	2023-01-14 22:37:05 +03:00
Bartłomiej Dach	a9facc076f	Fix difficulty creation flow failing for some ruleset combinations ... In current `master`, the difficulty creation flow would retrieve a "reference beatmap" to copy metadata and timing points from using `GetPlayableBeatmap()`. But, importantly, it was calling that method using *the ruleset of the new difficulty* rather than the ruleset of the existing one. This would make the difficulty creation flow fail if the beatmap couldn't be converted between rulesets (like taiko to catch). Fixing to use the reference beatmap's actual ruleset would be trivial, but there's no real reason to do all of that work anyway when a `WorkingBeatmap` is available. Because getting a playable beatmap is not required to copy across metadata and timing points, remove the `GetPlayableBeatmap()` step entirely to fix the bug. Closes #22145.	2023-01-14 19:46:55 +01:00
Joseph Madamba	e7ab543799	Add ability to view converted beatmaps on beatmap set overlay	2023-01-14 10:26:21 -08:00
ansel	88c3eef8e1	Add test case with no existing comments	2023-01-14 20:59:13 +03:00
Dean Herbert	efe6dae672	Merge pull request #22200 from bdach/user-profile/update-design-basics ... Update user profile appearance to closer match web	2023-01-15 02:50:11 +09:00
Dean Herbert	4906f37109	Merge pull request #22181 from frenzibyte/attempt-fix-song-select-test-failure ... Fix intermittent failure in beatmap carousel tests	2023-01-15 02:35:36 +09:00
ansel	fbb674d8e9	Rename parent comment id field	2023-01-14 20:15:19 +03:00
Bartłomiej Dach	67a3ea2c59	Fix wrong date colour of kudosu history items	2023-01-14 17:50:18 +01:00
Bartłomiej Dach	bfca75395b	Adjust colour of top header container	2023-01-14 17:37:33 +01:00
Bartłomiej Dach	6a9d842660	Adjust user profile header detail appearance	2023-01-14 17:37:31 +01:00
Bartłomiej Dach	de077403e9	Adjust visual appearance of profile value displays	2023-01-14 17:37:28 +01:00
Bartłomiej Dach	f80dddbb5e	Rearrange and adjust header components where simple	2023-01-14 17:17:28 +01:00
Bartłomiej Dach	e39eb089ce	Update colouring of some profile section elements	2023-01-14 17:17:26 +01:00
Bartłomiej Dach	5b1111c6b1	Adjust appearance of user profile sections	2023-01-14 17:17:24 +01:00
Bartłomiej Dach	3f81f173fb	Adjust appearance of section navigation	2023-01-14 17:17:21 +01:00
Bartłomiej Dach	49e08c06a6	Adjust general appearance of user profile overlay	2023-01-14 16:59:51 +01:00
Bartłomiej Dach	5e1ea8b34f	Merge branch 'master' into move-overlay-ruleset-selectors	2023-01-14 15:22:14 +01:00
integer	2831db53f7	fix wrong control flow on hover lost	2023-01-14 14:19:02 +00:00
Dean Herbert	2f2ab445c9	Merge pull request #22182 from stanriders/status-icon ... Update status icon design	2023-01-14 21:05:44 +09:00
ekrctb	e610d19d55	Merge branch 'master' into 18469	2023-01-14 19:53:08 +09:00
Dean Herbert	cfc8fd0aa1	Merge pull request #22188 from Feodor0090/nofs-locale ... Localise some notifications	2023-01-14 18:12:54 +09:00
Dean Herbert	a6e7efa62c	Merge pull request #22194 from Feodor0090/more-editor-nrt ... Enable nullability for setup, design and timing editor screens	2023-01-14 18:11:46 +09:00
StanR	e07c0c7c1f	Using	2023-01-14 02:58:18 +03:00
ansel	bb8bcd7248	Move avatar update bind to LoadComplete	2023-01-14 02:50:30 +03:00
ansel	c95d8645f3	Revert "Use existing string" ... This reverts commit f950b624ae.	2023-01-14 02:42:04 +03:00
ansel	9e7ecbf4a1	Adapt to changes in base class	2023-01-14 02:41:11 +03:00
ansel	e9995410e8	Merge branch 'master' into comment-editor-3	2023-01-14 02:32:06 +03:00
StanR	cb4f32e7bd	Use StatusIcon in UserDropdown	2023-01-14 02:31:27 +03:00
ansel	77e8315ee2	Adjust naming	2023-01-14 02:30:10 +03:00
StanR	e2d6e31314	Using	2023-01-14 02:26:26 +03:00
ansel	f70dedfd17	Enable nullability for design screen	2023-01-14 02:24:48 +03:00
ansel	4b42240fba	Enable nullability for setup screen	2023-01-14 02:24:28 +03:00
ansel	78adaa9b03	Enable nullability for timing screen	2023-01-14 02:23:21 +03:00
StanR	660bf748d5	Fix GroupBadge crashing on null group colour	2023-01-14 02:23:08 +03:00
integer	c3c1d77e8e	make PlayerSettingsGroup expand on hover	2023-01-13 23:07:59 +00:00
integer	0b5c89d01f	revert additions to SessionStatics	2023-01-13 23:07:21 +00:00
StanR	85b2154f3a	Set border colour to white	2023-01-14 01:12:17 +03:00
Bartłomiej Dach	ab3d39a940	Merge branch 'master' into comment-editor-1	2023-01-13 22:41:41 +01:00
ansel	d67184bd80	Autoformat code	2023-01-14 00:26:44 +03:00
ansel	f950b624ae	Use existing string	2023-01-14 00:26:35 +03:00
Joseph Madamba	5750d82c0a	Move overlay ruleset selectors to tab control	2023-01-13 12:50:35 -08:00
StanR	2e28f5ed33	Add StatusIcon	2023-01-13 23:18:24 +03:00
ansel	515ada6815	Remove CanBeNull where it's no longer requered	2023-01-13 23:11:50 +03:00
ansel	a41a031909	Localise some notifications	2023-01-13 23:11:25 +03:00
ansel	c62d416680	Add localisation for notification overlay	2023-01-13 22:54:38 +03:00
Salman Ahmed	112cf403ec	Fix intermittent failure in certain beatmap carousel tests	2023-01-13 19:41:44 +03:00
Dylan Nantz	6028abff39	Code Quality	2023-01-13 10:16:52 -05:00
Dylan Nantz	5dd0aaccef	Merge branch 'master' of https://github.com/ppy/osu into 18469	2023-01-13 09:54:29 -05:00
Dylan Nantz	e38075c4ef	Use PlacementState to check juice stream placement	2023-01-13 09:37:23 -05:00
mk56-spn	a6b6fb864e	Make carousel non nullable and ensure pre load usages of methods that reference it are protected against failure	2023-01-13 13:10:29 +01:00
Dean Herbert	11f630d49d	Prefill username and email	2023-01-13 15:42:34 +09:00
Dean Herbert	4d58e6d8d2	Add UI support for redirecting the user to web registration	2023-01-13 15:36:45 +09:00
Dean Herbert	a7327b02a2	Add API level support for error message and redirect during registration flow	2023-01-13 15:32:53 +09:00
Dean Herbert	5658c3a123	Enable NRT on account creation classes	2023-01-13 15:29:25 +09:00
Dean Herbert	6daa37bd3e	Merge pull request #22168 from Joehuu/fix-mute-button-closing-overlays ... Fix mute button not blocking outside overlay closing presses	2023-01-13 12:35:03 +09:00
Joseph Madamba	5a38abe679	Add comment highlighting reason for blocking mouse down	2023-01-12 19:32:53 -08:00
Dean Herbert	55f1c7c49d	Merge pull request #22160 from EVAST9919/ruleset-selector-online ... Don't display custom rulesets in online overlays	2023-01-13 12:16:42 +09:00
Dean Herbert	464c5eaa2f	Fix grammar	2023-01-13 12:16:35 +09:00
Dean Herbert	73189e49ab	Merge pull request #22163 from frenzibyte/fix-intermittent-channel-test-failure ... Fix intermittent failure in silenced user messages test	2023-01-13 11:23:45 +09:00
Dean Herbert	ea4eb6055e	Merge pull request #22169 from Feodor0090/timeline-nullability ... Enable nullability for editor components	2023-01-13 11:21:42 +09:00
mk56-spn	403ca05e5e	Enable nullability for song select	2023-01-13 00:52:14 +01:00
ansel	c554a34eaf	Add "fps" keyword to frame limiter dropdown	2023-01-13 02:11:05 +03:00
Joseph Madamba	a16050534d	Fix mute button not blocking outside overlay closing presses	2023-01-12 14:20:16 -08:00
Andrei Zavatski	d74a5ef9e6	Use property instead of ctor parameter	2023-01-12 23:26:29 +03:00
Andrei Zavatski	a7ac31fa34	Use IsLegacyRuleset extension method	2023-01-12 23:21:33 +03:00
Salman Ahmed	115cb0d297	Fix channel manager test scene not waiting for notifications client connection	2023-01-12 23:14:23 +03:00
Andrei Zavatski	1dae1149cb	Don't display non-legacy rulesets in beatmap listing	2023-01-12 22:52:45 +03:00
Andrei Zavatski	a9915d6a64	Make OverlayRulesetSelector display only legacy rulesets	2023-01-12 22:44:41 +03:00
ansel	0bd1c46c74	Undo sizing changes	2023-01-12 19:48:11 +03:00
ansel	2365b065a4	Enable nullability for editor components	2023-01-12 18:07:54 +03:00
Ruki	4439698867	Update osu.Game/Screens/Play/HUD/ArgonSongProgress.cs	2023-01-12 13:19:03 +01:00
Dean Herbert	d2309feec2	Merge branch 'master' into skin/argon-song-progress-cleaner	2023-01-12 19:49:27 +09:00
Dean Herbert	123c477e00	Merge branch 'master' into ui/segmented-graph	2023-01-12 19:02:49 +09:00
tsrk	bb2ece5c71	refactor(SegmentedGraph): adjust tierCount based on passed Colours	2023-01-12 10:57:12 +01:00
Dean Herbert	c22994c1c6	Merge pull request #22151 from smoogipoo/fix-incorrect-legacy-combo ... Fix incorrect max combo after watching imported legacy replays	2023-01-12 18:55:21 +09:00
tsrk	7cbc03dce6	refactor(SegmentedGraph): use (get/set)ters to expose TierColour	2023-01-12 10:13:16 +01:00
Dean Herbert	4ab2a5cbb4	Merge pull request #22141 from frenzibyte/fix-game-load-order ... Fix game-level components not finishing load before game content	2023-01-12 17:31:13 +09:00
Salman Ahmed	0548ca2aa8	Avoid changing target content midway through code	2023-01-12 09:48:38 +03:00
Dan Balasescu	bbec42c00e	Fix incorrect max combo after watching imported legacy replays	2023-01-12 14:18:21 +09:00
Dean Herbert	7cf58190a9	Merge pull request #22006 from bdach/user-profile/ruleset-switching ... Add ruleset switching to user profile overlay	2023-01-12 13:54:13 +09:00
Dan Balasescu	844fc549e2	Merge pull request #22149 from Joehuu/fix-beatmap-set-lookup-type ... Fix lookup type being incorrect when fetching beatmap set	2023-01-12 13:00:44 +09:00
Dan Balasescu	baf20a6b50	Merge pull request #22136 from peppy/fix-kiai-flash-intensity ... Fix kiai flash opacity on legacy skins being too intense	2023-01-12 12:56:57 +09:00
Joseph Madamba	2076f9fd08	Fix lookup type being incorrect when fetching beatmap set	2023-01-11 19:08:11 -08:00
tsrk	5694487a7b	fix(SegmentedGraph): update graphNeedsUpdate variable during Update() loop	2023-01-12 02:36:35 +01:00
ansel	51e21ee6f0	Make snapped time always positive	2023-01-12 03:38:57 +03:00
tsrk	624e90b213	style: nitpicks	2023-01-11 21:32:12 +01:00
Salman Ahmed	6c52b8339b	Fix game-level components finishing load after content	2023-01-11 22:02:06 +03:00
Bartłomiej Dach	52eabbf224	Merge branch 'master' into user-profile/ruleset-switching	2023-01-11 19:11:40 +01:00
Bartłomiej Dach	e0c2542968	Merge branch 'master' into fix-fail-sound-not-playing	2023-01-11 16:41:48 +01:00
tsrk	6249322a32	fix(SegmentedGraph): solve issue for negatives values	2023-01-11 14:03:36 +01:00
tsrk	e128b9ee5c	fix(SegmentedGraph): make ctor public	2023-01-11 14:03:19 +01:00
Dean Herbert	e9571be4ab	Fix incorrect application layer causing completely discoloured circles	2023-01-11 19:29:17 +09:00
Dean Herbert	a87debab0f	Fix kiai flash opacity on legacy skins being too intense	2023-01-11 19:29:17 +09:00
tsrk	42ff8c75fa	refactor: make class not abstract	2023-01-11 11:22:18 +01:00
tsrk	578d16f2bc	perf: Do not draw sectoins that are less than 1px	2023-01-11 11:11:31 +01:00
MK56	1597bcbb6f	Merge branch 'master' into JudgementCounter	2023-01-11 11:04:37 +01:00
Dean Herbert	08ca62205a	Merge pull request #22123 from stanriders/group-badges ... Implement user group badges	2023-01-11 18:42:50 +09:00
Dean Herbert	2dcc61caf5	Add extra level of nullabiliy checking because NRT is not present	2023-01-11 17:38:08 +09:00
Dean Herbert	df54410075	Fix skin fail sound not correctly playing ... Closes #21719. Tested using skin in issue thread.	2023-01-11 17:31:30 +09:00
Dean Herbert	3b55153609	Merge pull request #22122 from Stedoss/beatmapsetoverlay-fetch-on-login ... Fix `BeatmapSetOverlay` not showing a pending request after logging in	2023-01-11 16:51:52 +09:00
Dean Herbert	b1a13286a3	Remove some redundancies	2023-01-11 16:50:37 +09:00
Dean Herbert	318867f486	Fix previous badges potentially not being cleared if new user has no badges	2023-01-11 16:48:47 +09:00
Dean Herbert	e0d58d51b6	Split out classes into own files and rename GroupInfoContainer to a flow	2023-01-11 16:47:29 +09:00
Dean Herbert	eb398de1a6	Merge pull request #22114 from frenzibyte/fix-overlay-not-blocking-scroll ... Fix game overlays not blocking scroll properly	2023-01-11 16:30:44 +09:00
Dean Herbert	5a5ea2c54a	Merge pull request #22005 from bdach/user-profile/decouple-from-api-user ... Decouple user profile overlay from `APIUser` model	2023-01-11 16:27:00 +09:00
Dean Herbert	b710f86d75	Refactor to use tuples and de-duplicate request code	2023-01-11 16:15:28 +09:00
Dean Herbert	d1ca4ebd40	Merge pull request #21559 from OliBomby/stream-tool-1 ... Add segment end completions list to SliderPath	2023-01-11 15:31:04 +09:00
StanR	5441c02a1a	Implement user group badges	2023-01-11 07:11:38 +03:00
Dan Balasescu	d9a6e4b862	Ensure drain lenience of 1.0 completly removes drain	2023-01-11 13:01:11 +09:00
Joseph Madamba	b5caa1b778	Rename pause gameplay keybind to reflect other behavior	2023-01-10 15:53:41 -08:00
Joseph Madamba	776b60f3b3	Fix manual input manager test scenes not matching game input hierarchy ... Fix popover using on key down Fix popover not expiring when using global action	2023-01-10 15:35:26 -08:00
Stedoss	44de24f153	BeatmapSetOverlay fetch on login state change	2023-01-10 23:30:09 +00:00
ansel	b38cf8c56c	Use empty string as default	2023-01-11 02:26:25 +03:00
tsrk	21073f3601	reafactor: use DrawNode to draw SegmenteddGraph	2023-01-10 22:49:35 +01:00
Wleter	98ffcd33c7	Merge branch 'ppy:master' into SliderEnd-Snap	2023-01-10 21:22:13 +01:00
Wleter	88060a3ea0	add snapping for slider's end	2023-01-10 21:21:09 +01:00
Wleter	e5863fbaf1	add ScreenSpaceEndPoint field	2023-01-10 21:20:09 +01:00
Bartłomiej Dach	62e12277d8	Rename things yet again	2023-01-10 19:30:01 +01:00
Bartłomiej Dach	502478614a	Merge branch 'master' into user-profile/decouple-from-api-user	2023-01-10 19:13:33 +01:00
Salman Ahmed	11648db910	Fix game overlays not blocking scroll properly	2023-01-10 21:01:06 +03:00
Bartłomiej Dach	1eaabb5ca8	Merge branch 'master' into carousel_nullability_disabling_removal	2023-01-10 18:39:42 +01:00
Bartłomiej Dach	aab84d50eb	Remove boxing overhead in CarouselItem comparator	2023-01-10 18:35:06 +01:00
Dean Herbert	23a78e6fad	Combine commit button enabled handling	2023-01-10 23:59:17 +09:00
Dean Herbert	cde45cdd3e	Merge pull request #21739 from integerrr/score-export-date ... Append date to score export filename	2023-01-10 23:33:38 +09:00
Dean Herbert	af458f6f66	Merge pull request #22105 from frenzibyte/improve-score-import-logging ... Improve missing beatmap failure logging on score import	2023-01-10 22:28:38 +09:00
Dean Herbert	a22b7298c6	Adjust english slightly	2023-01-10 22:27:36 +09:00
Salman Ahmed	0d6b9ebc0f	Display number of failing models during batch-import	2023-01-10 13:32:10 +03:00
Salman Ahmed	c6b6d0dcfe	Remove verbose log from notifications feed	2023-01-10 13:31:29 +03:00
Dean Herbert	3210586eb6	Merge pull request #21519 from mk56-spn/variable_BPM_counter ... Add dynamic BPM counter to SkinEditor	2023-01-10 18:43:50 +09:00
Dean Herbert	60eeb4607c	Merge pull request #19528 from Joehuu/fix-op-non-current-onexiting ... Fix online play screen only accounting for current sub screen onexiting blocks	2023-01-10 18:43:19 +09:00
Dean Herbert	74bd1a1dd0	Merge pull request #22104 from frenzibyte/move-stable-import-to-debug ... Move stable import buttons under debug section in favour of first-run "import" screen	2023-01-10 18:27:31 +09:00
Dean Herbert	37d219a8ad	Fix comments, remove fixed width on "bpm" text and adjust baseline adjust slightly	2023-01-10 18:20:39 +09:00
Dean Herbert	85f542c3a8	Make GameplayClock private	2023-01-10 18:15:10 +09:00
Dean Herbert	7177225f9e	Merge pull request #22103 from mk56-spn/bar_visibility_toggle_clean ... Add the ability to toggle the main bar component of `BarHitErrorMeter`	2023-01-10 18:07:47 +09:00
Dean Herbert	3c93d0551c	Move setting up to be in line with other toggle	2023-01-10 18:07:15 +09:00
Dean Herbert	63ce5787e7	Start bars invisible	2023-01-10 18:06:45 +09:00
Dean Herbert	b7e845201f	Fix whitespace around Debug.Assert	2023-01-10 18:03:17 +09:00
Dean Herbert	d53dafa29f	Revert Debug.Assert	2023-01-10 17:52:28 +09:00
Dean Herbert	93038ce496	Use OfType instead of forceful nullability	2023-01-10 17:52:21 +09:00
integer	f971405c8c	append time as well	2023-01-10 00:02:31 +00:00
tsrk	91cde5ffbf	feat(hud/gameplay): implement Argon variant of SongProgress	2023-01-09 21:59:48 +01:00
tsrk	5952cd08a2	feat(hud/gameplay): implement Argon song progress density graph (SegmentedGraph)	2023-01-09 21:58:53 +01:00
tsrk	28d2d766eb	refactor(hud/gameplay/SongProgressInfo): minor changes to text positioning, font and colour	2023-01-09 21:57:32 +01:00
tsrk	f6265197e8	feat(hud/gameplay): Add Argon variant of SongProgressBar	2023-01-09 21:56:29 +01:00
tsrk	0f1fe1d683	refactor(hud/gameplay/SongProgress): Add interface to designate SongProgressBars	2023-01-09 21:48:53 +01:00
Salman Ahmed	e6479b73de	Remove one more unused using directive	2023-01-09 23:43:35 +03:00
ansel	23e4cfb469	Show spinner next to buttons and get rid of EditorCommitButton	2023-01-09 23:37:36 +03:00
tsrk	91eab7985b	feat(ui): Implement a segmented graph	2023-01-09 21:35:27 +01:00
Salman Ahmed	20ed337ea8	Remove unused using directive	2023-01-09 23:25:52 +03:00
Salman Ahmed	f216d7264b	Improve missing beatmap failure logging on score import	2023-01-09 23:06:59 +03:00
mk56-spn	602062f011	Address unclear naming issue	2023-01-09 21:04:51 +01:00
mk56-spn	6abbc7dc28	Further fix nullability	2023-01-09 20:59:28 +01:00
Bartłomiej Dach	98d78b2345	Merge branch 'master' into fix-channel-init-request-pile-up	2023-01-09 20:32:21 +01:00
Bartłomiej Dach	ce8a8b5433	Merge branch 'master' into screenshot-safety	2023-01-09 19:56:06 +01:00
Salman Ahmed	3014b60fd5	Merge branch 'master' into fix-channel-init-request-pile-up	2023-01-09 21:39:52 +03:00
Salman Ahmed	98390ea2a8	Fix condition flipped	2023-01-09 21:33:08 +03:00
Salman Ahmed	dbc19777e0	Move stable import buttons under "debug" section	2023-01-09 21:22:21 +03:00
mk56-spn	d6f60db234	Add the ability to toggle the visibility of the main bar in BarHitErrorMeter.cs	2023-01-09 18:51:51 +01:00
mk56-spn	69260ca3c3	remove unnecessary usages of nullable forgiveness, add asserts for debugging	2023-01-09 18:36:55 +01:00
Bartłomiej Dach	6027e7cc4e	Fix one more missed related symbol	2023-01-09 18:22:49 +01:00
Salman Ahmed	5ee0665eac	Merge branch 'master' into pause-imports-during-gameplay	2023-01-09 20:09:17 +03:00
Salman Ahmed	8a05223591	Check cancellation token if importer was resumed while sleeping	2023-01-09 20:07:46 +03:00
Salman Ahmed	a1fbfe4b8b	Specifiy importer name during pause/resume in logs	2023-01-09 19:53:41 +03:00
Bartłomiej Dach	0026861bd4	Merge branch 'master' into user-profile/decouple-from-api-user	2023-01-09 17:47:59 +01:00
Bartłomiej Dach	4dec3cae57	Rename UserProfileData-related symbols	2023-01-09 17:46:08 +01:00
Bartłomiej Dach	fdf0d4bd62	Rename UserProfile{ -> Data}	2023-01-09 17:37:28 +01:00
Dean Herbert	e35f63c001	Ensure screenshot filenames are unique by locking over file creation	2023-01-10 01:37:16 +09:00
Dean Herbert	811a562608	Don't use bindables to avoid potential cross-usage contamination	2023-01-10 01:10:20 +09:00
Endrik Tombak	44e9fb638c	Merge branch 'master' of https://github.com/ppy/osu into songs-folder-check	2023-01-09 14:53:40 +02:00
Endrik Tombak	f5c8ba420c	Revert message change	2023-01-09 14:53:16 +02:00
Dean Herbert	9d97c1a0bd	Merge branch 'master' into variable_BPM_counter	2023-01-09 19:26:34 +09:00
Dean Herbert	54b2fe9df3	Merge branch 'master' into fix-op-non-current-onexiting	2023-01-09 19:12:42 +09:00
Dean Herbert	07dae7dc21	Merge branch 'master' into overlay-panels-context-menu	2023-01-09 19:04:56 +09:00
Dean Herbert	62ffb4fe78	Pause imports during active gameplay	2023-01-09 18:54:11 +09:00
Endrik Tombak	15eebd1f50	Only show message about Songs folder	2023-01-09 11:47:13 +02:00
Dean Herbert	22d0b34623	Remove flag causing intiialisation to only run once ever	2023-01-09 16:38:37 +09:00
Dean Herbert	13c3d2c254	Fix retry loop for channel initialisation resulting in request pile-up ... Closes #22060.	2023-01-09 16:15:31 +09:00
Dean Herbert	13b00928c8	Rename loading spinner bool to reflect that it has a setter	2023-01-09 15:52:18 +09:00
Dean Herbert	d2f4ffcc5b	Merge branch 'master' into comment-editor-1	2023-01-09 15:52:17 +09:00
Joseph Madamba	c2dd822e4a	Make pause overlay close with pause gameplay action	2023-01-08 14:12:09 -08:00
Joseph Madamba	f6b1dfc7b0	Fix channel listing items overflowing at high ui scaling	2023-01-08 13:27:10 -08:00
Bartłomiej Dach	2803c98612	Merge pull request #22047 from Feodor0090/wcd-length-fix ... Fix `WaveformComparisonDisplay` does not take into account start time of control points	2023-01-08 20:36:35 +01:00
Salman Ahmed	f2609820c1	Merge branch 'master' into fix-player-loader-logo-drag	2023-01-08 21:48:07 +03:00
Bartłomiej Dach	e08b7c615b	Merge branch 'master' into wcd-length-fix	2023-01-08 19:44:12 +01:00
Salman Ahmed	7dd0f892c8	Merge branch 'master' into fix-player-loader-logo-drag	2023-01-08 21:29:03 +03:00
mk56-spn	47fb467012	Remove nullable disabling in carousel	2023-01-08 19:02:48 +01:00
Bartłomiej Dach	9fd305a970	Merge branch 'master' into editor-bg-refresh	2023-01-08 18:57:04 +01:00
Bartłomiej Dach	9b68932eb4	Merge branch 'master' into beatmap-info-nominators	2023-01-08 14:35:07 +01:00
Dean Herbert	750b55d9b7	Update other events to have matching return types (and animate more)	2023-01-08 22:28:19 +09:00
Joseph Madamba	45bae5d424	Add middle mouse to toggle pause replay instead of using pause gameplay keybinds	2023-01-07 11:30:02 -08:00
Joseph Madamba	bae3a6851b	Block hover events behind logo even if action is null	2023-01-07 11:15:51 -08:00
Joseph Madamba	9d32fde592	Mark current nominations and related users as nullable	2023-01-07 11:04:42 -08:00
Joseph Madamba	0f6735564e	Move and rename nomination response model to singular	2023-01-07 10:54:48 -08:00
ansel	aaeb43fbb2	Return older file if new one is null	2023-01-07 18:15:57 +03:00
Salman Ahmed	cfdb0e1806	Merge branch 'master' into previewTime	2023-01-07 16:25:53 +03:00
Dean Herbert	9549aefc33	Merge pull request #22056 from frenzibyte/fix-friends-duplication ... Fix friends list duplicating after connection failure	2023-01-07 21:00:39 +08:00
Salman Ahmed	a65466bdac	Merge branch 'master' into previewTime	2023-01-07 15:07:09 +03:00
Salman Ahmed	abca13eb6c	Rewrite visualisation piece to bind once and without potential event leak	2023-01-07 14:40:15 +03:00
Salman Ahmed	904c76e437	Use sane BeatmapInfo for preview time mutation ... `EditorBeatmap.BeatmapInfo` is usually the correct instance for mutating properties that should persist in the database.	2023-01-07 14:23:36 +03:00
ansel	927773d565	Display submitted comments locally	2023-01-07 04:15:43 +03:00
ansel	b47cef838c	Nullability	2023-01-07 03:08:02 +03:00
ansel	167ac8b5dd	Fix editor object being requered	2023-01-07 03:03:52 +03:00
ansel	58bf7349ee	Fix request	2023-01-07 02:59:32 +03:00
ansel	32e90829e3	Integrate comment editor into container	2023-01-07 02:59:24 +03:00
ansel	768a33bb64	Add request class	2023-01-06 23:31:19 +03:00
ansel	387326db0d	Make commit action abstract	2023-01-06 22:51:57 +03:00
Salman Ahmed	e449d8dda0	Fix friends list duplicating on connection failure	2023-01-06 22:39:46 +03:00
Joseph Madamba	7f970f3cd8	Display nominators on beatmap set overlay	2023-01-06 11:33:39 -08:00
Joseph Madamba	53d7dcefe5	Fix osu! logo not being draggable on player loader	2023-01-06 09:30:25 -08:00
ansel	9364c7775d	Refresh background on file change in editor	2023-01-06 19:26:30 +03:00
ansel	e90c698e62	Fix WCD does not take into account start time of control points	2023-01-06 16:35:39 +03:00
Salman Ahmed	3862184f9c	Merge branch 'master' into improve-filter-tab-item-ux	2023-01-06 15:37:21 +03:00
Dean Herbert	99f2bbe775	Merge pull request #22044 from peppy/filter-tab-item-bold ... Make selected tab items more bold (and add underline)	2023-01-06 20:35:29 +08:00
Salman Ahmed	0ade4d92d1	Fix multiple highlighting issues with beatmap listing tab items	2023-01-06 15:13:31 +03:00
Dean Herbert	f908b25dab	Merge pull request #22033 from frenzibyte/decrease-difficulty-list-fadeout ... Decrease transition duration of extended difficulty list during hide	2023-01-06 20:13:30 +08:00
Salman Ahmed	3d053ac758	Merge branch 'master' into filter-tab-item-bold	2023-01-06 15:11:57 +03:00
Dean Herbert	0ab1418aa6	Merge pull request #22034 from frenzibyte/fix-toolbox-group-animation ... Fix settings toolbox group not animating on expansion	2023-01-06 19:59:31 +08:00
Salman Ahmed	f29f9c17bd	Merge branch 'master' into filter-tab-item-bold	2023-01-06 14:59:11 +03:00
Dean Herbert	c0cfa66510	Merge pull request #21754 from Feodor0090/waveform-invalidate ... Reload waveform on track replacement in editor	2023-01-06 19:57:27 +08:00
Dean Herbert	4319937bc7	Also add an underline to better accent current filters	2023-01-06 20:36:10 +09:00
Dean Herbert	3c74d27deb	Also add an underline to better accent current filters	2023-01-06 20:35:58 +09:00
Dean Herbert	458fe382ed	Make selected tab items more bold	2023-01-06 20:06:41 +09:00
Dean Herbert	938658649e	Merge pull request #22043 from frenzibyte/fix-solo-leaderboard-hyphen ... Fix gameplay leaderboard showing "-" on non-tracked scores	2023-01-06 18:12:00 +08:00
Dean Herbert	464f251c0c	Merge branch 'master' into beatmap-set-link-genre-language	2023-01-06 17:09:06 +08:00
Salman Ahmed	408356d05e	Fix gameplay leaderboard showing "-" on non-tracked scores	2023-01-06 12:06:47 +03:00
ansel	c6e2104ec2	Refresh waveforms instead of recreating the whole component	2023-01-06 03:46:49 +03:00
Salman Ahmed	88148567c0	Merge branch 'master' into fix-playlist-item-regressions	2023-01-05 15:31:27 +03:00
Salman Ahmed	7d8aff8f7e	Fix settings toolbox group not animating on expansion	2023-01-05 14:35:57 +03:00
Salman Ahmed	8da7667b0b	Decrease transition duration of extended difficulty list during hide	2023-01-05 14:22:17 +03:00
Salman Ahmed	8f37e69dc4	Schedule difficulty calculation to avoid performing with incomplete state updates	2023-01-05 12:52:08 +03:00
Salman Ahmed	39221a52da	Fix advanced statistics display using decoupled ruleset bindable for difficulty calculation	2023-01-05 12:52:08 +03:00
Joseph Madamba	5fb6f220e6	Fix playlist items not animating when rearranging	2023-01-03 11:10:02 -08:00
Joseph Madamba	5dfd4180c8	Fix playlist selecting random item when not allowed after deleting	2023-01-03 11:10:02 -08:00
Bartłomiej Dach	4ead7ea33f	Merge branch 'master' into fix-leaderboard-fetch-wrong	2023-01-03 20:01:30 +01:00
Bartłomiej Dach	3d425c93e6	Merge branch 'master' into fix-combo-colour-export	2023-01-03 19:21:24 +01:00
Dean Herbert	beb3b96aca	Harden request equality checks	2023-01-04 01:44:00 +08:00
Dean Herbert	96e81e7f41	Switch on NRT and add IEquatable to GetScoresRequest	2023-01-04 01:41:21 +08:00
Salman Ahmed	4491a5ba9f	Fix editor exporting beatmap combo colours in wrong order	2023-01-03 13:41:08 +03:00
Dean Herbert	ac85433178	Fix default volume control keys not working when chat textbox is focused ... Closes #22004.	2023-01-03 09:44:35 +08:00
Dean Herbert	8f7ae0395a	Fix song select leaderboard potentially showing wrong scores on quick beatmap changes ... Closes #22002.	2023-01-03 00:55:09 +08:00
Bartłomiej Dach	a124c967df	Add proper offline & loading state handling to user profile overlay	2023-01-02 17:23:09 +01:00
Bartłomiej Dach	c759b743dc	Add support for switching rulesets on profile overlay	2023-01-02 17:23:06 +01:00
Bartłomiej Dach	a2e726502f	Add ruleset selector to profile overlay	2023-01-02 17:23:04 +01:00
Bartłomiej Dach	7683ab68b0	Use UserProfile in profile ruleset selector	2023-01-02 17:23:01 +01:00
Bartłomiej Dach	1722f3a125	Add ruleset to UserProfile	2023-01-02 17:22:55 +01:00
Bartłomiej Dach	4dd7727f71	Remove test-specific workaround in overlay	2023-01-02 17:21:14 +01:00
Bartłomiej Dach	d7294ac3e6	Substitute APIUser for UserProfile in overlay	2023-01-02 17:21:09 +01:00
Bartłomiej Dach	608d8ee7d4	Add UserProfile model to be used in user profile overlay ... As `APIUser` implements `IEquatable`, attempting to replace an `APIUser` with another `APIUser` with the same online ID has no effect on the user profile overlay. This is a significant hurdle in implementing support for viewing the profile for different rulesets, as in that case the profile is basically reloaded for the same user, but slightly different data. To facilitate this, wrap `APIUser` in a new `UserProfile` class. This will mean that the equality rules can be changed locally to the user profile overlay without impacting other components that depend on the `APIUser` equality rules. The ruleset that the user profile is being displayed with will eventually be added to `UserProfile`, too.	2023-01-02 17:21:00 +01:00
Joseph Madamba	d79ee29f29	Make replays pause with middle mouse button instead of exiting	2023-01-01 21:01:12 -08:00
Bartłomiej Dach	88e90d5fa0	Enable NRT in user profile overlay	2023-01-01 23:49:11 +01:00
Bartłomiej Dach	b689ad6d80	Fix changing preview point not prompting for save	2023-01-01 19:54:26 +01:00
Bartłomiej Dach	efdd557f3b	Adjust binding logic	2023-01-01 19:45:23 +01:00
Bartłomiej Dach	452ebddfd2	Adjust visual appearance of preview time part ... - Use slightly different hue of green to distinguish from difficulty control points. The colour is still not ideal, but picking a distinctive enough hue is pretty hard. - Place the preview time part at the bottom rather at the top. Not sure why it was at the top; not only could it overlap with the control points, but it also looked quite badly misaligned there when bookmarks were displayed at the bottom.	2023-01-01 19:42:55 +01:00
Bartłomiej Dach	a82f1a6abd	Adjust method naming and copy	2023-01-01 18:50:47 +01:00
Bartłomiej Dach	0e59b55a12	Merge branch 'master' into previewTime	2023-01-01 18:38:19 +01:00
Bartłomiej Dach	2698d58c46	Merge branch 'master' into remember-chat-textbox-per-channel	2023-01-01 17:29:38 +01:00
Dean Herbert	7e39ee3982	Merge pull request #21945 from cdwcgt/acc-UI ... Add new display modes for accuracy counter	2023-01-01 23:20:12 +08:00
Dean Herbert	9a4f0cad2c	Fix incorrect domain root being used for recent activity entries on profile overlay ... Closes https://github.com/ppy/osu/issues/21980.	2023-01-01 17:48:05 +08:00
Dean Herbert	87250ad847	Add search keywords for beatmap colours / hitsound overrides	2023-01-01 14:32:28 +08:00
Bartłomiej Dach	6509d3538c	Fix counter initially rolling down from 100% to 0% in minimum achievable mode	2022-12-30 21:13:41 +01:00
Bartłomiej Dach	7580ab78be	Move binding to LoadComplete()	2022-12-30 21:08:48 +01:00
Bartłomiej Dach	6ed474d4fb	Rearrange formula for maximum accuracy ... Feels like it's easier to understand this way. The difference of the maximum scoring values for the entire beatmap and the max values for the part of the beatmap that has already been played represents the act of filling the rest of the unjudged objects with maximum results.	2022-12-30 20:56:54 +01:00
Bartłomiej Dach	8ace635249	Adjust minimum values	2022-12-30 20:55:51 +01:00
Bartłomiej Dach	bb2822a175	xmldoc pass	2022-12-30 20:55:48 +01:00
Bartłomiej Dach	6d42cc5a36	Naming pass	2022-12-30 20:30:58 +01:00
cdwcgt	d60349c7c6	add description	2022-12-30 23:24:41 +09:00
cdwcgt	8beb168be9	remove nullable disabled	2022-12-30 23:24:20 +09:00
cdwcgt	784fe7ecf2	rename AccType to AccuracyDisplay	2022-12-30 23:06:10 +09:00