Dean Herbert
6399c695e8
Update usages of BufferedContainer in line with framework changes
2021-11-05 15:54:49 +09:00
Salman Ahmed
3a3ec1436b
Re-enable possible null refernece exception inspections and move code
2021-11-05 09:14:50 +03:00
Dean Herbert
9f9ef570ee
Also propagate Status in temporary BeatmapInfo usage
2021-11-05 14:44:58 +09:00
Dean Herbert
b1f1cc0bf3
Perform all user profile displays using an IUser interface
2021-11-05 13:55:34 +09:00
Dean Herbert
ba74dd93b2
Remove weird fetchOnline logic
2021-11-05 13:55:34 +09:00
Salman Ahmed
f528488aa2
Mark as non-null and move current bind to BDL instead
2021-11-05 05:42:19 +03:00
Salman Ahmed
4245af28e1
Disable other false-positive null inspections with comment
2021-11-05 04:50:58 +03:00
Salman Ahmed
36d99a2e34
Move action to private named method to avoid null inspection
2021-11-05 03:51:08 +03:00
Dean Herbert
b9983add15
Rename User to APIUser and move to correct namespace
2021-11-04 18:21:31 +09:00
Dean Herbert
08d94f864f
Update ScoresContainer to not use ToBeatmapInfo
2021-11-04 17:09:53 +09:00
Dean Herbert
5a078da4d9
Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues
2021-11-04 16:50:14 +09:00
Dean Herbert
8f459e6ce8
Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues
2021-11-04 16:44:17 +09:00
Bartłomiej Dach
494d582830
Fix PlaylistItem attempting to read from OsuColour dependency too early
2021-11-02 23:19:45 +01:00
Bartłomiej Dach
e4e8390a8a
Update ScreenEntry colour usage to update correctly on language change
2021-11-02 21:42:03 +01:00
Bartłomiej Dach
d218e7d935
Remove manual romanisation handling in PlaylistItem
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
ed00cd9fc5
Remove simple localisable .ToString() calls
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
11de924704
Use LocalisableStrings where possible to leverage localisable text flow
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
98367fc482
Update usages of GetLocalised{-> Bindable}String
2021-11-02 21:42:01 +01:00
Dean Herbert
47914c49ba
Fix missed null consideration
2021-11-03 04:54:36 +09:00
Dean Herbert
392559ae3e
Fix beatmap download notifications not showing beatmap name correctly
2021-11-03 03:23:41 +09:00
Dean Herbert
caa9d8997b
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 22:59:11 +09:00
Bartłomiej Dach
793c384ecd
Remove unnecessary null-conditional access
2021-11-01 12:02:37 +01:00
Bartłomiej Dach
5dcff7d8b7
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 11:41:20 +01:00
Dean Herbert
b21e0e7efb
Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays
2021-11-01 18:07:51 +09:00
Bartłomiej Dach
f5feed138d
Merge branch 'master' into score-refactor/isolated-serialisation
2021-11-01 09:43:51 +01:00
Dean Herbert
63c9512ab1
Update dashboard components to use APIBeatmapSet
2021-11-01 16:04:01 +09:00
Dean Herbert
b98faf6159
Merge branch 'master' into score-refactor/isolated-serialisation
2021-11-01 15:49:25 +09:00
Dean Herbert
21e0074d3b
Add missing AddInternal call for BeatmapSetHeaderContent's download tracker
2021-11-01 14:43:32 +09:00
Dean Herbert
19feae4a8e
Merge branch 'master' into beatmap-refactor/download-tracker
2021-11-01 13:15:36 +09:00
Bartłomiej Dach
8053b2c320
Merge branch 'master' into score-refactor/isolated-serialisation
2021-10-30 15:07:34 +02:00
Dean Herbert
e9473db77c
Reorder to have video settings next to renderer
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-10-30 20:37:55 +09:00
Opelkuh
4d988340eb
Add hardware acceleration toggle
2021-10-30 01:02:53 +02:00
Dean Herbert
5311fe2d02
Merge branch 'master' into beatmap-refactor/beatmap-overlays
2021-10-29 22:37:29 +09:00
Dean Herbert
a16c8f1ebc
Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet
2021-10-29 18:50:55 +09:00
Dean Herbert
8ad33d43d0
Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays
2021-10-29 18:01:17 +09:00
Dean Herbert
31403daa20
Change DrawableProfileScore to use APIScoreInfo
2021-10-29 15:14:52 +09:00
Dean Herbert
3f030cebf4
Remove local score copying in GetScoresRequest to allow APIScoreInfo.Beatmap to be APIBeatmap
2021-10-29 14:14:25 +09:00
Dean Herbert
817369903a
Rename API score classes
2021-10-29 13:40:56 +09:00
Bartłomiej Dach
6f863ca204
Adjust game-side text flow containers to part-based model
2021-10-29 06:34:08 +02:00
Dean Herbert
3b095e1626
Merge branch 'master' into beatmap-refactor/download-tracker
2021-10-29 11:50:54 +09:00
Dan Balasescu
e5a7589859
Merge pull request #15317 from peppy/beatmap-refactor/uncontested
...
Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`
2021-10-28 17:24:49 +09:00
Dean Herbert
1e1f8c472a
Add icons to various progress notification states
2021-10-28 16:34:12 +09:00
Dean Herbert
7245baba69
Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases
2021-10-28 00:50:45 +09:00
Dean Herbert
746d6a4c16
Fix some oversights and test failures
2021-10-27 23:42:27 +09:00
Dean Herbert
f014ceaead
Update remaining usages of download tracking
2021-10-27 21:00:46 +09:00
Dean Herbert
6339064dbd
Remove old versions of DownloadTrackingComposite
2021-10-27 21:00:46 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Dean Herbert
5e5b86a1f4
Merge pull request #15156 from Susko3/use-ShowFileInNativeExplorer
...
Update usages of `OpenInNativeExplorer` to use `PresentFileExternally` / `PresentExternally`
2021-10-26 15:53:03 +09:00
Dan Balasescu
efe6763226
Merge branch 'master' into move-online-beatmap-metrics
2021-10-26 14:24:40 +09:00
Dean Herbert
53ff0802cb
Merge branch 'master' into use-ShowFileInNativeExplorer
2021-10-26 13:58:30 +09:00
Bartłomiej Dach
6802e9ec10
Remove FixedWidth and add AutoSizeAxes specs to all usages
2021-10-25 20:24:48 +02:00
Dean Herbert
2c308f3008
Rename BeatmapMetrics to APIFailTimes
2021-10-25 15:34:41 +09:00
Dean Herbert
045dd94a6e
Move online metrics out of BeatmapSetInfo model
2021-10-25 15:12:39 +09:00
Bartłomiej Dach
5ab3337a10
Update beatmap set status pill appearance
2021-10-24 20:40:34 +02:00
Susko3
51c5d0aec7
Update to be in line with framework changes
2021-10-24 13:21:41 +02:00
Dean Herbert
c701579c69
Refactor BeatmapMetadataContainer and usages to use interface types
2021-10-22 21:38:50 +09:00
Dean Herbert
69e7810dad
Enable nullable and switch classes to structs
2021-10-21 18:54:36 +09:00
Dean Herbert
32d01f022f
Rename usages which rely on online backing
2021-10-21 16:58:42 +09:00
smoogipoo
2c979d6420
Merge branch 'master' into localise-toasts
2021-10-20 15:04:07 +09:00
Dean Herbert
37841ca3aa
Remove incorrect ToString calls causing localisation to not actually apply
2021-10-20 10:41:34 +09:00
Bartłomiej Dach
80da153697
Recolour a few other existing dropdowns with same hover & selection colours
2021-10-19 22:47:18 +02:00
Bartłomiej Dach
ef03787fe0
Split dropdown accent colour into hover and selection colours
2021-10-19 22:09:51 +02:00
Dean Herbert
c97cfdd978
Merge branch 'master' into localise-toasts
2021-10-19 16:37:14 +09:00
Bartłomiej Dach
6d9d85685f
Fix settings item having zero height
2021-10-18 23:30:38 +02:00
Bartłomiej Dach
88a1b31fae
Remove grid usage in SettingsItem
2021-10-18 22:07:32 +02:00
Bartłomiej Dach
6c3637a62a
Remove grid usage in KeyBindingRow
2021-10-18 22:07:30 +02:00
Bartłomiej Dach
830f49bca6
Remove doubled-up opacity specification
2021-10-18 19:43:48 +02:00
Bartłomiej Dach
2a41e8bd1f
Remove unneeded extra padding from settings number box
2021-10-17 21:50:04 +02:00
Bartłomiej Dach
552fc1dc8a
Adjust key binding rows to accommodate new default value indicator
2021-10-17 21:50:04 +02:00
Bartłomiej Dach
f422ebb281
Adjust SettingsItem to accommodate new default value indicator
2021-10-17 21:50:03 +02:00
Bartłomiej Dach
818f35c35f
Restyle default value indicator
2021-10-17 21:50:03 +02:00
Bartłomiej Dach
ed2f9dd443
Adjust settings slider spacings
2021-10-15 00:31:06 +02:00
Dean Herbert
06249c4ab2
Fix incorrect usages of Scheduler.AddOnce
2021-10-14 17:52:19 +09:00
Bartłomiej Dach
d205483a36
Revert ThemedDropdown-related changes
2021-10-13 21:57:50 +02:00
Bartłomiej Dach
a2f3a7cba8
Add "themed" dropdown variant and use in settings sidebar
2021-10-12 21:58:43 +02:00
Bartłomiej Dach
1fba932e84
Adjust settings dropdown spacings
2021-10-12 21:41:33 +02:00
Dan Balasescu
cabbb1697a
Merge pull request #15054 from peppy/settings-ordering
...
Initial settings usability pass
2021-10-12 22:00:30 +09:00
Dean Herbert
24b87cf655
Change some icons to be more descriptive (still placeholder)
2021-10-12 15:09:59 +09:00
Dean Herbert
59202d27c7
Add some missing labels
2021-10-12 15:09:59 +09:00
Dean Herbert
5ca1d1d12c
Reorder graphics settings and move gameplay related pieces out
2021-10-12 15:09:59 +09:00
Dean Herbert
c4347de57e
Move ruleset settings to own section
2021-10-12 14:58:43 +09:00
Dean Herbert
8285f065c2
Reorganise gameplay settings into more sections
2021-10-12 14:58:43 +09:00
Dean Herbert
1d3d67c5f1
Move gameplay cursor settings to gameplay section
2021-10-12 13:56:10 +09:00
Dean Herbert
a986870a99
Reorder sections to be more in line with how often they are adjusted
2021-10-12 13:41:35 +09:00
Dean Herbert
e058214346
Merge branch 'master' into fix-audio-filter-test-failures
2021-10-12 12:06:12 +09:00
Bartłomiej Dach
ff382259ca
Use rounded buttons in tablet rotation preset settings
2021-10-11 23:17:09 +02:00
Joseph Madamba
4fc84e71cd
Localise more toast related strings
2021-10-11 01:02:26 -07:00
Dean Herbert
484a95229e
Update toast implementations temporarily to expedite getting tests back in line
2021-10-11 16:36:04 +09:00
Joseph Madamba
af9bb6f277
Fix padding of shortcut in toast when widest
2021-10-10 19:37:46 -07:00
Joseph Madamba
7b37b15976
Localise some music action toasts
2021-10-10 19:36:50 -07:00
Joseph Madamba
545cfc7bf1
Localise tracked setting toasts
2021-10-10 19:35:25 -07:00
Bartłomiej Dach
b30dd2d4ed
Use rounded button in settings sidebar
2021-10-10 21:45:41 +02:00
Dean Herbert
49b341daff
Remove HoverTarget shared state update path
...
Felt quite convoluted to follow. Have just duplicated the single shared
line instead.
2021-10-10 11:55:47 +09:00
Dean Herbert
ccc6d8ff40
Improve the animation of the active indicator
2021-10-10 11:34:01 +09:00
Bartłomiej Dach
fe26d8e8df
Share sidebar colouring logic by splitting out SidebarIconButton
2021-10-10 00:34:12 +02:00
Bartłomiej Dach
b8616bf910
Adjust appearance of keybinding subpanel
2021-10-10 00:34:12 +02:00
Bartłomiej Dach
855a74b8a0
Adjust vertical spacings in individual subsections
2021-10-10 00:34:11 +02:00
Bartłomiej Dach
e23a54f1e6
Adjust setting section appearance & spacings
2021-10-10 00:31:01 +02:00
Bartłomiej Dach
4c293b637f
Restyle settings panel header
2021-10-09 23:40:15 +02:00
Bartłomiej Dach
315581f4c8
Adjust horizontal spacing in settings panel
2021-10-09 23:40:15 +02:00
Bartłomiej Dach
f6df93f013
Introduce basic parts of colour scheme to settings sidebar
2021-10-09 23:40:14 +02:00
Dan Balasescu
9be56829c9
Merge pull request #14935 from Susko3/fix-SettingsTextBox-using-null-as-default
...
Fix usages of `SettingsTextBox` having `null` as the default
2021-10-08 18:36:02 +09:00
Dean Herbert
9dc035757f
Fix weird textbox behaviour when entering a random mod seed overflowing int backing
2021-10-08 14:01:36 +09:00
Dean Herbert
2856aef4eb
Add exception to catch any incorrect defaults of Bindable<string>
2021-10-08 13:52:38 +09:00
Dean Herbert
e578046b20
Rename Filter -> AudioFilter
2021-10-07 18:50:08 +09:00
Dean Herbert
0348c6c7e5
Apply some renaming and code quality fixes
2021-10-07 18:49:22 +09:00
Dean Herbert
f98dd1b811
Merge branch 'master' into popup-filter-effect
2021-10-07 18:40:21 +09:00
Jamie Taylor
266e62794e
Tweak cutoff effect for new Q value
2021-10-06 11:52:05 +09:00
Dan Balasescu
4bbff2ebf7
Merge branch 'master' into new-interfaces
2021-10-06 11:38:17 +09:00
Dan Balasescu
9491e5a547
Merge pull request #14954 from peppy/rename-result-response
...
Rename `APIRequest.Result` to `Response`
2021-10-06 10:52:33 +09:00
Bartłomiej Dach
a5b07ce4fe
Fix backwards containment check in chat channel load callback
2021-10-05 20:53:06 +02:00
Dean Herbert
2be44188ef
Add missing null checks
2021-10-05 17:59:38 +09:00
Dean Herbert
d3b9660148
Move common interface implementations to extension methods
2021-10-05 14:41:14 +09:00
Dean Herbert
b41fa41c85
Rename APIRequest.Result to Response
2021-10-05 14:28:56 +09:00
Dean Herbert
853cf6feaa
Rename last remaining BeatmapInfo Beatmap usage
2021-10-04 17:35:53 +09:00
Dan Balasescu
5937a93e2d
Merge pull request #14949 from peppy/login-error-display
...
Show login failure messages on login form
2021-10-04 17:23:11 +09:00
smoogipoo
69c2b7dc59
Merge branch 'master' into rename-beatmap-info-beatmap-fields
2021-10-04 16:03:22 +09:00
Dean Herbert
266b4c7124
Expose login errors from IAPIProvider and show on the login form
2021-10-04 15:40:24 +09:00
Dean Herbert
5aaafce597
Make AuthenticateWithLogin throw instead of return a bool success status
2021-10-04 15:40:00 +09:00
smoogipoo
bc984dff4f
Fix typo
2021-10-04 15:35:28 +09:00
Dean Herbert
c19c2335ec
Remove added schedule due to changing flow
2021-10-04 14:58:54 +09:00
Dean Herbert
c6aba3e78b
Ensure a DrawableChannel is not attempted to be added after disposal
2021-10-04 14:44:16 +09:00
Susko3
3e403cfe03
Add comment explaining the purpose of the empty FilterTerms
2021-10-02 19:16:46 +02:00
Dean Herbert
ec61c3c5ee
Rename all remaining cases
2021-10-03 00:55:29 +09:00
Susko3
d55836c0b2
Make ResetButton no longer part of search filtering
...
The button will now appear if and only if all the bindings in its section are visible (not filtered out by the search)
2021-10-02 15:10:30 +02:00
Dean Herbert
973c31132b
Rename BeatmapInfo variables which were named beatmap for clarity
2021-10-02 12:45:34 +09:00
Jamie Taylor
2a4a376b87
Refactor Filter to behave closer to a Transformable
2021-10-02 01:32:47 +09:00
Dean Herbert
9fa901f6aa
Refine RealmContext implementation API
2021-09-30 23:56:38 +09:00
Jamie Taylor
f55c4ac640
IsLoaded check no longer required
2021-09-29 21:05:46 +09:00
Jamie Taylor
2608d193a9
Refactor Filter component to be more re-usable
2021-09-29 20:30:01 +09:00
Jamie Taylor
94e2dbd7e7
Add a low-pass filter effect to music when certain popup dialogs are shown
2021-09-29 20:30:00 +09:00
Dean Herbert
6b698047ab
Fix DialogOverlay potentially not expiring dialogs as soon as it should
2021-09-23 19:19:03 +09:00
Bartłomiej Dach
ab213e2010
Add missing licence headers
2021-09-19 21:09:03 +02:00
Dean Herbert
50f155e4b9
Move login panel related files to own namespace and tidy up class nesting
2021-09-17 18:34:16 +09:00
Joseph Madamba
2983d54682
Fix wiki main page blurb overflowing at higher ui scale
2021-09-16 17:32:23 -07:00
Dean Herbert
fde7c88999
Merge branch 'master' into update-framework
2021-09-16 22:49:02 +09:00
Dean Herbert
df786afb24
Merge pull request #14763 from kj415j45/localisation-settings-GlobalAction
...
Add localisation for Settings-KeyBindings-GlobalActions
2021-09-16 21:08:00 +09:00
smoogipoo
f9d5abff8a
Update with keybinding changes
2021-09-16 18:26:12 +09:00
kj415j45
51997fa533
Add localisation for GlobalActions
2021-09-16 16:02:04 +08:00
AbstractQbit
f0439ef50b
Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect
2021-09-15 13:12:57 +03:00
AbstractQbit
b9193aae6d
Make IOsuScreen.AllowTrackAdjustments nullable
...
Allows for inheriting value from the previous screen if undefined
2021-09-14 17:37:57 +03:00
Dean Herbert
1e09f558d1
Merge pull request #14687 from Emil8250/master
...
Make "Reset bindings" button wider to accommodate to localisations better
2021-09-13 22:46:06 +09:00
Dan Balasescu
f6c4bbe2c9
Merge pull request #14730 from peppy/add-missing-track-adjustment-defaults
...
Add missing screen level mod application settings for some screens
2021-09-13 15:22:22 +09:00
Dean Herbert
0c646f6dbd
Merge pull request #14694 from nekodex/no-avatar-click-sound
...
Don't play hover/select sounds for UpdatableAvatar unless it's clickable
2021-09-13 15:14:43 +09:00
Dean Herbert
caf7ef6519
Add missing screen level mod application settings for some screens
...
Closes #7480 . But based on discussion in there this solution may change.
2021-09-13 15:00:34 +09:00
Dean Herbert
52c69d2f22
Adjust value to not be full width (but allow for more accommodations with localised versions)
2021-09-13 14:17:45 +09:00
Bartłomiej Dach
b9c127c07e
Improve content transitions in beatmap listing
2021-09-11 22:37:36 +02:00
Dan Balasescu
f4b1d8b9d1
Merge pull request #14704 from peppy/modicon-imod-support
...
Update `LeaderboardModSelector` to avoid creating mod instances
2021-09-10 16:43:32 +09:00
Dean Herbert
309460e505
Merge pull request #14675 from ekrctb/featured-artist-markers
...
Add featured artist markers to beatmap listing and overlay
2021-09-10 14:30:33 +09:00
Jamie Taylor
8d1e43423e
Update calls to use new variable name
2021-09-10 14:18:40 +09:00
Dean Herbert
63116a8889
Merge pull request #14703 from gagahpangeran/supporter-bg
...
Fix supporter promo background colour
2021-09-10 14:11:01 +09:00
Dan Balasescu
2d2c63dde7
Merge branch 'master' into modicon-imod-support
2021-09-10 13:30:05 +09:00
Dan Balasescu
78a83e0903
Merge pull request #14698 from peppy/fix-beatmap-overlay-hide
...
Fix beatmap listing overlay not hiding via keyboard control when scrolled
2021-09-10 13:18:37 +09:00
Gagah Pangeran Rosfatiputra
110f495345
move internal children to bdl
2021-09-10 11:11:55 +07:00
Gagah Pangeran Rosfatiputra
e636692596
change background to background 5
2021-09-10 11:00:55 +07:00
Dean Herbert
28e9329136
Update LeaderboardModSelector to avoid creating mod instances
2021-09-10 12:43:21 +09:00
Gagah Pangeran Rosfatiputra
8acf82944f
use hex colour directly instead of transparency
2021-09-10 10:17:10 +07:00
Gagah Pangeran Rosfatiputra
f329973798
fix supporter promo background colour
2021-09-10 09:37:27 +07:00
Dean Herbert
cf633973a9
Refactor exposed mod retrieval methods for better safety
2021-09-10 11:09:13 +09:00
Dean Herbert
c101d1f205
Fix beatmap listing overlay not hiding via keyboard control when scrolled
...
Closes https://github.com/ppy/osu/issues/14684 .
2021-09-10 01:57:57 +09:00
ekrctb
29f947fa07
Revert ExplicitContentBeatmapPill, don't try to reuse common code
2021-09-09 19:25:30 +09:00
Dean Herbert
4d0530ca9d
Add new methods to ruleset for quicker mod lookups
2021-09-09 16:46:14 +09:00
Dan Balasescu
f36bebd1a4
Merge branch 'master' into custom-style-link-flow-container
2021-09-09 13:31:55 +09:00
ekrctb
52bb02baed
Prefer composite over inheritance for drawable parts
2021-09-09 12:53:39 +09:00
Emil Olesen
2888623bdb
Extended the width of the ResetSectionButton to be equal to Content.Width. Fixes #14685
2021-09-08 22:02:24 +02:00
Joseph Madamba
9b05bf3a2c
Fix volume meter not being highlighted when hovering before show
2021-09-08 11:43:59 -07:00
ekrctb
d417f03a39
Simplify link style customization code
2021-09-08 15:52:54 +09:00
ekrctb
f96be2cab8
Add featured artist marker to beatmap set listing and overlay
2021-09-08 13:27:20 +09:00
Ethan Ng
d8fe98fe12
Fixed grammatical error in ChangelogSupporterPromo
2021-09-07 14:06:23 -06:00
Dean Herbert
c43ac8c946
Merge pull request #14660 from ekrctb/search-featured-artists
...
Add "featured artists" filter to beatmap listing
2021-09-07 20:58:13 +09:00
Dean Herbert
1aa95de530
Merge branch 'master' into score-ordering
2021-09-07 17:45:38 +09:00
ekrctb
5ab2f4b386
Give an orange colour to "featured artists" filter to match web
2021-09-07 17:32:12 +09:00
ekrctb
b6c80f04b0
Add "featured artists" filter to beatmap search
2021-09-07 16:44:45 +09:00
Bartłomiej Dach
73f742509a
Merge branch 'master' into tablet-area-validity-fix
2021-09-06 21:15:17 +02:00
Dean Herbert
458cde832d
Avoid using SSDQ for validity computation
2021-09-06 14:11:13 +09:00
Dean Herbert
7c60c6a733
Merge pull request #14571 from rednir/get-user-from-username
...
Add ability to open user profile links with username instead of user ID
2021-09-06 00:15:09 +09:00
Dean Herbert
ab1c64591f
Move sample playback debounce time to central const
2021-09-05 13:25:10 +09:00
Dean Herbert
473e15e8f3
Add debounce to notification sample playback logic
2021-09-05 13:22:37 +09:00
Dean Herbert
1d23ac0f2d
Initial clean up pass on notification logic
2021-09-05 12:54:21 +09:00
Dean Herbert
4fb3a1d641
Update check to inflate in the correct direct
...
Also handles previously unhandled edge cases by comparing all four
corners, instead of only two.
2021-09-05 00:46:29 +09:00
Dean Herbert
66daa553de
Fix bounds check running too early causing tablet area to show incorrect validity
2021-09-04 19:34:55 +09:00
Dean Herbert
16beb2c90c
Expose more pieces of TabletSettings
2021-09-04 15:35:46 +09:00
Dean Herbert
f223be0760
Merge branch 'master' into score-ordering
2021-09-02 14:45:59 +09:00
Dean Herbert
ef64c05af8
Merge pull request #14533 from frenzibyte/move-incompatibility-icon
...
Move mod incompatibility logic to "local player" mod select overlays
2021-09-01 18:12:27 +09:00
Dean Herbert
9e21f5a59c
Rename LocalPlayer to User in mod select prefixes
2021-09-01 17:22:52 +09:00
Dean Herbert
fb5f3fb9af
Rename button to be more descriptive of its purpose
2021-09-01 17:19:38 +09:00
Dean Herbert
2251bf3bcb
Use lambda spec for method
2021-09-01 17:08:20 +09:00
Dean Herbert
cb66ecdbeb
Merge branch 'master' into simplify-user-graph-tooltips
2021-09-01 17:04:21 +09:00
Dean Herbert
f0b128b6ec
Merge pull request #14592 from frenzibyte/cleanup-tooltips
...
Update remaining tooltip implementations to use generics
2021-09-01 17:03:59 +09:00
smoogipoo
88fc53200e
Refactor
2021-09-01 15:41:52 +09:00
smoogipoo
2de076a74b
Merge branch 'adjust-classic-scoring' into score-ordering
2021-09-01 15:06:55 +09:00
Dean Herbert
c70ac5e5c2
Merge branch 'master' into privatise-toolbar-offset
2021-09-01 14:54:15 +09:00
Joseph Madamba
7e4ad7d7cf
Fix toolbar blocking scroll input
2021-08-31 13:40:13 -07:00
Joseph Madamba
da3fa9304a
Make toolbar inherit overlay container
2021-08-31 12:39:18 -07:00
Salman Ahmed
b0d7104650
Convert to class to allow not displaying tooltips
...
With `struct` content, it is never possible to not show a tooltip.
2021-08-31 21:13:24 +03:00
Salman Ahmed
3969350c9a
Convert to readonly struct and replace with constructor temporarily
2021-08-31 20:45:32 +03:00
Salman Ahmed
69c23a2371
Explicitly implement tooltips on date drawables to avoid "convert to auto-property" inspections
2021-08-31 20:06:34 +03:00
Salman Ahmed
da7ff4b160
Update remaining tooltip implementations to use generics
2021-08-31 20:01:13 +03:00
Salman Ahmed
208f66cc76
Simplify user graph tooltips logic
...
The same tooltip can be used for the rank graph, the play history graph,
and the replay history graph.
The only difference between those three is the displayed label, which
has now been included as part of the `TooltipContent`, rather than
unnecessarily recreating tooltips just for different sprite texts.
2021-08-31 19:59:38 +03:00
Salman Ahmed
a190801291
Revert no longer required tooltip content changes
2021-08-31 19:36:27 +03:00
Salman Ahmed
9afc482598
Merge branch 'master' into move-incompatibility-icon
2021-08-31 19:27:43 +03:00
smoogipoo
999386da29
Cleanup
2021-08-31 21:47:49 +09:00
smoogipoo
fee94236de
Fix update-thread pauses
2021-08-31 21:36:31 +09:00
smoogipoo
bfcadcc4ac
Revert some changes
2021-08-31 19:18:01 +09:00
Joseph Madamba
570d36fde7
Make toolbar handle mouse events instead
2021-08-30 20:53:43 -07:00
smoogipoo
e19d81c88c
Fix potential incorrect ordering
2021-08-30 19:41:44 +09:00
smoogipoo
458ce250f0
Use new ScoreManager method in ScoreTable
2021-08-30 19:34:12 +09:00
smoogipoo
b217dd1a65
Order scores by score
2021-08-30 19:03:16 +09:00
smoogipoo
47061c0210
Trigger refresh on scoring mode change
2021-08-30 18:57:30 +09:00
Davran Dilshat
1aeae2b8c8
reverse ternary operator
2021-08-30 10:11:41 +01:00
Dean Herbert
678386f5c4
Fix missed null coalesce
2021-08-30 16:05:56 +09:00
Dean Herbert
fa2bf42188
Update tooltip implementations
2021-08-30 16:05:00 +09:00
Davran Dilshat
90c313e2ad
add methods to get a user from their username
2021-08-29 19:19:55 +01:00
Salman Ahmed
6dc11543ad
Handle (null?) PP in PerformanceTable
2021-08-29 17:20:33 +03:00
Salman Ahmed
6aaef7b0be
Handle null PP during score set in TopScoreStatisticsSection
...
Supersedes #14562
Closes #14541
2021-08-29 17:19:17 +03:00
Salman Ahmed
8f3416d853
Assert PP not null when showPerformancePoints is true
2021-08-29 16:03:39 +03:00
Salman Ahmed
e374ef163d
Update localisable formattable extensions usages inline with framework change
2021-08-29 15:00:28 +03:00
Joseph Madamba
9a5445bded
Fix overlays closing when clicking any empty area of the toolbar instead
2021-08-28 22:25:13 -07:00
Joseph Madamba
38912bfc16
Fix floating overlays not closing when clicking some empty area of the toolbar
2021-08-28 20:38:35 -07:00
Salman Ahmed
589f2863ca
Move incompatibility tooltip logic to local player mod select overlays
...
This one turned out to be a bit more involved, due to tooltips being
shared and having the potential of being used somewhere where it
shouldn't be, due to the same content type matching.
That's the reason I've defined a protected `TargetContentType`, to be
able to separate "local player mod tooltips" and regular mod tooltips
apart.
Definitely unsure about the solution, but that's as far as I can think
of right now.
2021-08-28 02:38:46 +03:00
Salman Ahmed
e527bfd4bf
Move incompatibility icon logic to local player mod select overlays
2021-08-28 02:37:46 +03:00
Dan Balasescu
6a916a264f
Merge pull request #14441 from Henry-YSLin/mod-incompatibility-ui
...
Show mods that are incompatible with the current selection
2021-08-24 16:16:35 +09:00
Dean Herbert
a5f6c287ea
Split out pinned comment content to only be constructed when required
2021-08-24 14:43:28 +09:00
Dean Herbert
8cd972a9fe
Merge branch 'master' into pinned-comment
2021-08-24 14:37:31 +09:00
Dean Herbert
c3b7ce0b05
Remove stray newline
2021-08-24 14:02:50 +09:00
Dean Herbert
afd01d22d6
Adjust visuals of incompatible icon and move to own class
2021-08-24 14:01:49 +09:00
Dean Herbert
bf0a1167ec
Improve update flow and ensure selected mods is read from local context
2021-08-24 13:35:39 +09:00
Dean Herbert
3c9718339c
Merge pull request #14444 from frenzibyte/decouple-ruleset-bindables
...
Decouple rankings overlay's ruleset selector from the game-wide ruleset bindable
2021-08-24 11:58:13 +09:00
Henry Lin
b8fe03b77f
Use Mod.Equals for comparison
2021-08-24 09:50:09 +08:00
Henry Lin
6e3d05c7ce
Display an icon to signify incompatibility instead of a red tint
2021-08-24 09:42:53 +08:00
Davran Dilshat
6bea744e34
invalidate scroll position
2021-08-23 17:13:25 +01:00
Salman Ahmed
f8a7e0bdb6
Update rankings overlay ruleset bindable with parent on initial display
2021-08-23 13:50:39 +03:00
Salman Ahmed
d3958eb3fb
Revert initial ruleset value logic
2021-08-23 13:28:21 +03:00
Salman Ahmed
f4b69ceb8a
Remove unused using embedded in reverted changes
2021-08-23 12:40:20 +03:00
Salman Ahmed
257934a144
Revert "Revert ruleset when not applied filters (includes scope change)"
...
This reverts commit 9fa39cd34e
2021-08-23 12:38:30 +03:00
Salman Ahmed
eeeaefbd7d
Revert "Store default ruleset value for ability to revert"
...
This reverts commit cb7c2f713b
2021-08-23 12:38:24 +03:00
Salman Ahmed
9fa39cd34e
Revert ruleset when not applied filters (includes scope change)
2021-08-23 11:11:06 +03:00
Salman Ahmed
cb7c2f713b
Store default ruleset value for ability to revert
2021-08-23 11:09:26 +03:00
Salman Ahmed
1d89d757af
Fix beatmap ruleset selector selecting initial ruleset
2021-08-23 09:57:05 +03:00
Salman Ahmed
2ba88923b6
Select user preferred ruleset on overlay ruleset selectors initially
2021-08-23 08:58:54 +03:00
Salman Ahmed
45b8bd175c
Decouple rankings overlay's ruleset bindable from game-wide bindable
2021-08-22 16:25:35 +03:00
Salman Ahmed
9b1720bd6c
Merge branch 'master' into localise-beatmap-set-overlay
2021-08-22 10:53:31 +03:00
Henry Lin
3795030ebb
Merge branch 'master' into mod-incompatibility-ui
2021-08-22 11:14:24 +08:00
Henry Lin
0bbddd297c
Remove unused code
2021-08-22 11:05:53 +08:00
Henry Lin
e213562b2a
Add a red tint on mods incompatible with the current selection
2021-08-22 11:01:17 +08:00
Henry Lin
ef6faf04be
Use FirstOrDefault in TooltipContent
2021-08-22 10:22:18 +08:00
Henry Lin
3d402d9e78
List incompatible mods in tooltip of mod button
2021-08-22 10:13:34 +08:00
Salman Ahmed
216ff07497
Merge branch 'master' into fix-setting-section-clickability
2021-08-21 14:11:55 +03:00
Dean Herbert
ae47c5cdb3
Fix bottom area of a settings section not being clickable
2021-08-21 15:08:42 +09:00
Dean Herbert
36352d1de4
Improve highlighted chat username shadow effect
2021-08-21 14:34:35 +09:00
Dan Balasescu
0a6b678059
Merge branch 'master' into settings-dim-other-sections
2021-08-20 20:22:22 +09:00
Dean Herbert
139ff2d6e2
Only fade header in when hovering a section
...
Feels less like the controls are interactive when hovering this way.
2021-08-20 17:40:05 +09:00
Dean Herbert
cff7b1e98f
Ensure the correct fade level is applied over all state changes
2021-08-20 17:00:08 +09:00
Lucas A
9b4c806855
Apply review suggestions.
2021-08-20 09:47:23 +02:00
Lucas A
0a1c9a6c05
Move DownloadButtonStrings -> CommonStrings
2021-08-20 09:26:38 +02:00
Lucas A
19cc4a14a3
Localise top score mods statistics
2021-08-20 09:22:15 +02:00
Bartłomiej Dach
143b8df1b2
Fix backwards warning text presence check
2021-08-19 22:40:35 +02:00
Lucas A
bf7f0a5d30
Remove double whitespace
2021-08-19 19:02:04 +02:00
Lucas A
ea08d48d27
Remove unecessary localised string due to online view container handling visibility when user is not logged in.
2021-08-18 18:53:35 +02:00
Dean Herbert
6637c64501
Dim all but the current section
2021-08-19 01:27:14 +09:00
Dean Herbert
af0c7ed108
Fix searching in settings not correctly invalidating the scroll position
2021-08-19 01:25:57 +09:00
Dean Herbert
1fdaefef99
Revert unnecessary changes
2021-08-18 12:45:08 +09:00
Dean Herbert
c0b388cd74
Fix regression in ModSettingsChangeTracker
2021-08-17 17:50:30 +09:00
Dean Herbert
1b49e92e99
Merge branch 'master' into settings-delayed-load
2021-08-17 17:42:23 +09:00
Dean Herbert
bc86bafc08
Fix RestoreDefaultValueButton's colour weirdness
2021-08-17 12:48:30 +09:00
Dean Herbert
212842c537
Fix initial LayoutSettings animation in a more reliable way
2021-08-17 12:38:44 +09:00
Dean Herbert
adb4fd5a2b
Load only sections content asynchronously, showing the header initially
2021-08-17 12:31:33 +09:00
Dean Herbert
8cba1f197b
Merge branch 'master' into add-supporter-glow-changelog
2021-08-16 23:41:46 +09:00
Dean Herbert
c3a8676932
Simplify size specifications
2021-08-16 23:38:13 +09:00
Dean Herbert
139e69ed3b
Merge pull request #14343 from frenzibyte/hide-tablet-not-detected-when-disabled
...
Hide tablet settings content when disabled
2021-08-16 23:31:16 +09:00
Dean Herbert
7b74301fa1
Merge pull request #14341 from smoogipoo/fix-preview-track-crash
...
Fix crashes from preview tracks
2021-08-16 22:21:52 +09:00
Dean Herbert
5f006bd6e8
Merge pull request #14247 from kj415j45/localisation-settings
...
Add localisation support for most of Settings
2021-08-16 22:20:35 +09:00
Dean Herbert
c978e68742
Merge branch 'master' into add-supporter-glow-changelog
2021-08-16 22:09:52 +09:00
Dean Herbert
7e1086d901
Merge branch 'master' into hide-tablet-not-detected-when-disabled
2021-08-16 22:07:45 +09:00
Dean Herbert
568d027013
Simplify weird conditionals
2021-08-16 22:07:41 +09:00
Lucas A
3325b0cc95
Fix merge conflicts.
2021-08-16 14:50:08 +02:00
Lucas A
a0a9777109
Fix merge conflicts.
2021-08-16 14:50:00 +02:00
Lucas A
1f942d15f8
Localise scoreboard
2021-08-16 13:38:57 +02:00
Dean Herbert
8c3eb91059
Merge branch 'master' into localisation-settings
2021-08-16 20:03:06 +09:00
Dean Herbert
de61cb8e6a
Adjust delay slightly
2021-08-16 19:56:20 +09:00
Dean Herbert
e485728109
Add keywords to make finding audio offset adjustments easier in settings
2021-08-16 19:54:45 +09:00
Dean Herbert
230c4eb247
Fade in sidebar buttons after the load has completed
2021-08-16 19:47:41 +09:00
Dean Herbert
c6bd8520a7
Add basic asynchronous loading pattern to SettingsPanel
2021-08-16 19:47:41 +09:00
Dean Herbert
b541550ea9
Avoid initial synchronous dropdown population overhead in AudioDevicesSettings
2021-08-16 19:47:41 +09:00
Dean Herbert
8d051d9fa0
Avoid multiple synchronous overheads in SettingsItem
2021-08-16 19:47:41 +09:00
Dean Herbert
c0130da235
Avoid running initial layout transform in LayoutSettings
2021-08-16 19:47:41 +09:00
Lucas A
7bebbf9f74
Mark format strings as verbatim.
2021-08-16 12:46:41 +02:00
Salman Ahmed
e39a295c5c
Hide tablet settings content when input handler is disabled
2021-08-16 13:45:50 +03:00
Dean Herbert
c191b38125
Reduce transform overhead of RestoreDefaultValueButton
2021-08-16 18:55:50 +09:00
smoogipoo
db1a0ebb55
Fix preview track crashes
2021-08-16 18:46:44 +09:00
Dean Herbert
fc89f2bac4
Revert "Rename element in OsuSettings enum"
...
This reverts commit c2bbe17562
2021-08-16 16:56:48 +09:00
kj415j45
887d622c28
Merge branch 'master' into localisation-settings
2021-08-16 15:41:50 +08:00
Dan Balasescu
4d31d07c51
Merge branch 'master' into open-tablet-driver-faq
2021-08-16 13:46:43 +09:00
Daniel Kariv
38828b6b82
Updating beatmap details icons
...
changes the sizing and add yellow circle so the UI will fit more with osu-web style.
2021-08-16 00:40:31 +03:00
Daniel Kariv
f6773522d1
Correct icons in beatmap details
...
In relation to #13968 . Replacing incorrect icons in beatmap details panel to correct ones from BeatmapStatisticsIcon class.
2021-08-16 00:12:27 +03:00
Jacob Van Meter
6472d85aae
Added heart_size constant and adjusted the glow radius value
...
Added heart_size constant and adjusted the glow radius value to be more in line with the website
2021-08-14 21:48:57 -04:00
Jacob Van Meter
71ccd38bb3
Corrected pippi background and promo positioning
2021-08-14 20:36:43 -04:00
Jacob Van Meter
772860232c
Removed empty offset and corrected colour
2021-08-14 20:32:38 -04:00
Jacob Van Meter
95943fdb25
Add glow to supporter promo on changelog
...
Added glow to the supporter promo at the end of the changelog, as it is on the website.
2021-08-14 20:00:26 -04:00
Salman Ahmed
c8fb796660
Fix settings notice text class tinting everything with yellow
2021-08-14 20:14:28 +03:00
