1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 06:17:23 +08:00
Commit Graph

17792 Commits

Author SHA1 Message Date
Liam DeVoe
cda1efef0b move overridability to SettingDescription method 2020-03-20 16:34:36 -04:00
Liam DeVoe
7bdbdd25f8 Revert "use SettingSource to define IconTooltip format"
This reverts commit 5a6d8f1932.
2020-03-20 16:05:12 -04:00
Liam DeVoe
3d95592130
use var for list declaration
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-03-20 14:37:31 -04:00
Liam DeVoe
52469fccbe
Merge branch 'master' into show-mod-settings-tooltip 2020-03-20 13:41:04 -04:00
Liam DeVoe
9e3bff3b97 oops, missed a newline 2020-03-20 13:36:16 -04:00
Liam DeVoe
9dc8146811 fix style issues 2020-03-20 13:21:44 -04:00
Liam DeVoe
5a6d8f1932 use SettingSource to define IconTooltip format 2020-03-20 12:47:17 -04:00
OctopuSSX
157f05c3e5
Update osu.Game/Users/Drawables/DrawableAvatar.cs
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2020-03-20 14:35:27 +03:00
OctopuSSX
b813c0aff1
Don't open profile if it's Autoplay 2020-03-20 14:26:26 +03:00
Dean Herbert
9b60b535e5 Fix selection not occurring when switching from empty ruleset on first load 2020-03-20 15:01:26 +09:00
Dean Herbert
e64a100e8b
Merge branch 'master' into fix-carousel-restore-previous-selection 2020-03-20 13:03:18 +09:00
Dean Herbert
be4a97c289 Correctly bypass last selected when it is filtered 2020-03-20 13:01:24 +09:00
Dan Balasescu
2b5d4a7cb7
Merge branch 'master' into fix-invalid-push-from-player 2020-03-19 22:31:41 +09:00
Dean Herbert
43c1f27f24 Update framework 2020-03-19 20:19:50 +09:00
Dean Herbert
8f9e97b4cc Fix carousel not remembering last selection correctly 2020-03-19 18:07:39 +09:00
Dean Herbert
855f0a4253 Fix bracket style 2020-03-19 14:38:49 +09:00
Dean Herbert
17c3455b36 Fix potentially invalid push in player while already exiting 2020-03-19 14:10:59 +09:00
Liam DeVoe
18bf7c913b show mod settings in ModIcon tooltip 2020-03-18 23:43:26 -04:00
Liam DeVoe
e59d7fee26 fix comment grammar 2020-03-18 23:42:14 -04:00
Dean Herbert
c50784da93 Show 'D' rank badge on accuracy circle 2020-03-19 11:58:52 +09:00
Fuewburvpoa
648e9fa21f
Merge branch 'master' into MyBranch 2020-03-18 21:18:17 +02:00
Dean Herbert
90e1f6efbf
Merge pull request #8341 from smoogipoo/score-panel-scrolling
Make score panel scroll if off-screen
2020-03-18 19:00:48 +09:00
Dean Herbert
7cece7ce1b
Merge pull request #8339 from smoogipoo/update-rank-colours
Update rank badge colours
2020-03-18 18:59:45 +09:00
Dean Herbert
25983cfe0e
Merge pull request #8340 from smoogipoo/results-date-played
Add date played to score panel
2020-03-18 18:55:26 +09:00
Dean Herbert
6c45694f01
Merge pull request #8338 from smoogipoo/colourise-hit-statistics
Colourise results screen hit statistics
2020-03-18 18:55:10 +09:00
smoogipoo
1d211cb563 Make score panel scroll if off-screen 2020-03-18 18:28:42 +09:00
smoogipoo
63531a8564 Add date played to score panel 2020-03-18 17:59:44 +09:00
smoogipoo
b91dc15dbf Update rank badge colours 2020-03-18 17:37:03 +09:00
smoogipoo
66558ca8c5 Colourise hit result statistics 2020-03-18 17:26:17 +09:00
smoogipoo
5f09c70f75 Move judgement colours to OsuColour 2020-03-18 17:21:36 +09:00
Dan Balasescu
e1e0c40020
Merge branch 'master' into fix-perfect-display 2020-03-18 17:04:52 +09:00
Dean Herbert
ed419216f0
Merge pull request #8323 from skielred/acc-circle-use-osucolour
Re-use colors defined for each rank in result screen accuracy circle
2020-03-18 16:29:24 +09:00
Dean Herbert
fdcb60706b Use TryGetValue to make tests happy 2020-03-18 15:49:24 +09:00
Dean Herbert
44cfed8af1 Fix perfect display showing when misses are present 2020-03-18 15:03:01 +09:00
Dan Balasescu
514e72bffb
Merge branch 'master' into update-loader-animation 2020-03-18 11:36:29 +09:00
Dan Balasescu
27f7808a86
Merge pull request #8320 from recapitalverb/fix-mapper-alignment
Fix mapper info alignment in score panel
2020-03-18 10:59:05 +09:00
Joehu
3c07f73c7b Fix results' beatmap title and artist language setting being swapped 2020-03-17 17:32:58 -07:00
Fuewburvpoa
6c825eb744
Update osu.Game/Screens/Edit/Compose/Components/BeatDivisorControl.cs
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-03-18 00:04:03 +02:00
Fuewburvpoa
bee8e22d18 Fix BeatDivisorControl allow to select value outside of VALID_DIVISORS 2020-03-17 22:27:11 +02:00
Andrei Zavatski
e951979a12 Remove assert from online test 2020-03-17 22:34:46 +03:00
Andrei Zavatski
4d376636c3 Merge remote-tracking branch 'refs/remotes/ppy/master' into friends-layout-split 2020-03-17 22:12:48 +03:00
recapitalverb
139ae2bc1e Use existing variables instead 2020-03-18 01:24:58 +07:00
Tina
100c9d422f Re-use colors defined for each rank in result screen accuracy circle 2020-03-17 18:55:30 +01:00
recapitalverb
431571dfa0 Check nulls 2020-03-18 00:15:43 +07:00
recapitalverb
d18b21ba32 Use local variable for metadata instead 2020-03-17 23:23:51 +07:00
recapitalverb
99409fb7d1 Fix mapper info alignment in score panel 2020-03-17 23:02:39 +07:00
recapitalverb
592d8cbd13 Fix mapper name in score panel 2020-03-17 22:45:28 +07:00
Dean Herbert
dd3a6c5673 Use working beatmap to retrieve metadata for now 2020-03-17 23:13:31 +09:00
Dean Herbert
27cc68152d Fix potentially missing metadata on local score display 2020-03-17 22:54:02 +09:00
Dean Herbert
24b944fc8e Make footer buttons wider 2020-03-17 22:24:28 +09:00
Dean Herbert
48cbec7a31 Add scroll view because 2020-03-17 22:21:16 +09:00
Dean Herbert
2d6dcb3ba9 Merge branch 'master' into results-screen 2020-03-17 22:03:36 +09:00
Dean Herbert
b27bb4aeae Merge branch 'master' into results-middle-content 2020-03-17 21:37:23 +09:00
Dean Herbert
75695938e2
Merge branch 'master' into results-top-content 2020-03-17 20:42:02 +09:00
Dean Herbert
3b9c64b76f
Merge branch 'master' into results-scorepanel 2020-03-17 20:06:11 +09:00
Dean Herbert
01fd52e9d8
Merge branch 'master' into update-framework 2020-03-17 19:23:42 +09:00
Dean Herbert
8396fcfd35
Merge pull request #8304 from smoogipoo/results-circle
Implement a circle that displays the user's accuracy
2020-03-17 18:59:40 +09:00
Dean Herbert
7a6a7c28c1
Merge pull request #8305 from smoogipoo/fix-score-population
Fix replay scores not being populated via player
2020-03-17 18:59:20 +09:00
Dean Herbert
df119eb95a Adjust animations 2020-03-17 18:04:38 +09:00
Dean Herbert
f06c170d63 Display SS badge earlier (when entering virtual ss area) 2020-03-17 18:04:15 +09:00
smoogipoo
6f569d1485 Fix colour conflicts for expert-plus 2020-03-17 18:01:46 +09:00
smoogipoo
3628814e4e Merge branch 'fix-score-population' into results-screen 2020-03-17 17:48:39 +09:00
smoogipoo
86a336d585 Add back retry overlay 2020-03-17 17:45:25 +09:00
smoogipoo
1c4296f5e7 Implement the new results screen 2020-03-17 17:43:16 +09:00
smoogipoo
afed01d781 Merge branch 'results-middle-content' into results-screen 2020-03-17 17:35:40 +09:00
smoogipoo
946746f5f5 Merge branch 'results-top-content' into results-screen 2020-03-17 17:35:34 +09:00
smoogipoo
6f801e1695 Add xmldoc 2020-03-17 17:35:14 +09:00
smoogipoo
2ee480f1d8 Add xmldocs / cleanup 2020-03-17 17:34:16 +09:00
smoogipoo
1521f25c96 Implement middle panel contents 2020-03-17 17:25:24 +09:00
smoogipoo
3792d3645f Merge branch 'add-back-black-font' into results-middle-content 2020-03-17 17:18:41 +09:00
smoogipoo
e56d0f2eea Add black font weighting 2020-03-17 17:16:10 +09:00
smoogipoo
19106daf8b Merge branch 'results-circle' into results-middle-content 2020-03-17 17:09:15 +09:00
smoogipoo
7cc1a6040f Implement top panel contents 2020-03-17 17:01:38 +09:00
smoogipoo
05789e6fe4 Implement the score panel 2020-03-17 16:59:34 +09:00
Dean Herbert
d322c8c2d7 Update framework 2020-03-17 16:47:23 +09:00
smoogipoo
daa5e63d0d Fix replay scores not being populated via player 2020-03-17 16:42:55 +09:00
smoogipoo
dca2e1d816 Implement the accuracy circle 2020-03-17 16:37:56 +09:00
smoogipoo
e586249db7 Expose GetRankName from DrawableRank 2020-03-17 16:25:51 +09:00
smoogipoo
d77b0acd90 Move rank colour to OsuColour 2020-03-17 16:25:41 +09:00
smoogipoo
9e7c388202 Expose Spacing and UseFullGlyphHeight 2020-03-17 16:24:49 +09:00
Andrei Zavatski
4ac740b12b Remove APIFriend 2020-03-17 08:51:54 +03:00
Dean Herbert
5e3668b2ea
Merge pull request #8260 from smoogipoo/add-workingbeatmap-timeout
Add beatmap loading timeout to prevent runaway loading scenarios
2020-03-17 11:17:35 +09:00
Joehu
f7ea20a926 Limit font weight to bold 2020-03-16 16:32:25 -07:00
Andrei Zavatski
d9d812a8fe Fix status icon flash on first status change 2020-03-17 02:10:20 +03:00
Andrei Zavatski
f816479ff8 Simplify order by rank 2020-03-17 02:03:57 +03:00
Andrei Zavatski
bd84980aa6 Simplify order by last visit 2020-03-17 01:56:10 +03:00
Andrei Zavatski
da97a02e66 Remove pointless flag 2020-03-17 01:53:53 +03:00
Andrei Zavatski
6a151b8e75 Add online test 2020-03-17 01:50:19 +03:00
Andrei Zavatski
6ec01a67af Use cast in SocialOverlay 2020-03-17 01:38:45 +03:00
Andrei Zavatski
544dfe7dd3 Implement FriendsLayout component 2020-03-16 09:42:21 +03:00
Dan Balasescu
0245bab7c6
Merge branch 'master' into user-cards-update 2020-03-16 14:27:21 +09:00
smoogipoo
58fc947be3 Privatise some setters 2020-03-16 14:06:42 +09:00
Dan Balasescu
e835f88c0c
Merge pull request #8255 from peppy/fix-carousel-scroll-while-import
Fix carousel scrolling being inoperable during beatmap import
2020-03-16 12:50:45 +09:00
Dan Balasescu
3e65f13c67
Merge branch 'master' into fix-carousel-scroll-while-import 2020-03-16 12:06:50 +09:00
Dean Herbert
9bb3a6c677 Merge branch 'master' into click-group-difficulty-icons 2020-03-16 12:01:09 +09:00
Dan Balasescu
7e5f6c4e7f
Merge pull request #8247 from peppy/click-disabled-difficulty-icons
Add the ability to click filtered difficulty icons
2020-03-16 11:56:37 +09:00
smoogipoo
9c5423734a Throw timeout exceptions instead 2020-03-16 11:33:26 +09:00
Dean Herbert
d6be8eec0c Merge branch 'master' into click-disabled-difficulty-icons 2020-03-16 11:30:57 +09:00
Dan Balasescu
f390c1995d
Apply comment suggestions
Co-Authored-By: Dean Herbert <pe@ppy.sh>
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-03-16 11:29:28 +09:00
Dan Balasescu
e03b29947a
Merge branch 'master' into correct-trail-animation-frame 2020-03-16 11:16:56 +09:00
Dan Balasescu
bd05462a7f
Merge branch 'master' into carousel-selection-fallback-improvement 2020-03-16 10:53:10 +09:00
Dan Balasescu
25a35a1370
Merge branch 'master' into always-apply-ruleset-filter 2020-03-16 10:32:36 +09:00
Dan Balasescu
12293bea1d
Merge branch 'master' into fix-chat-tabs 2020-03-16 09:57:01 +09:00
TheWildTree
acd280c855 Add System channel type and use it for the ChannelSelectorTab 2020-03-15 22:13:26 +01:00
Bartłomiej Dach
8952eb2a01 Merge branch 'master' into correct-trail-animation-frame 2020-03-15 15:24:26 +01:00
Dean Herbert
340d362d69 Appease inspectcode 2020-03-15 03:51:30 +09:00
Dean Herbert
12b7727af6 Update framework 2020-03-15 03:25:01 +09:00
Dean Herbert
4e8e222996 Merge branch 'master' into fix-carousel-scroll-while-import 2020-03-15 03:24:19 +09:00
Dean Herbert
0b788065b4 Update resources package 2020-03-15 01:00:25 +09:00
Dean Herbert
cd604785a8 Ignore italics specification for now 2020-03-15 00:38:27 +09:00
Dean Herbert
62ce503126 Fix changelog alignment and italics usage 2020-03-15 00:36:21 +09:00
Dean Herbert
735396c6d6 Merge branch 'master' into torus 2020-03-14 23:40:55 +09:00
Dean Herbert
cd0f1c98ba Update framework 2020-03-14 16:17:14 +09:00
Dean Herbert
fcbf83cd74
Merge pull request #8217 from smoogipoo/limit-max-slider-length
Add more sane limit for maximum slider length
2020-03-14 15:08:39 +09:00
TheWildTree
8991e88039 Fix active tab closing behaviour 2020-03-13 18:34:51 +01:00
TheWildTree
097bd37e37 Fix SelectorTab crashing tests after a reload
For some reason, the default channel type (Public) caused the channel manager to attempt to connect to an API, which was null at that time, after hot reloading the test environment (via dynamic compilation). Changing the channel type seems to fix that.
2020-03-13 18:34:51 +01:00
voidedWarranties
c27751050b Switch back to strings and update setting labels 2020-03-12 23:29:11 -07:00
smoogipoo
c33ca6e99c Decorate usages with exception management 2020-03-13 14:28:11 +09:00
smoogipoo
f7c036726a Add beatmap loading timeout 2020-03-13 13:52:40 +09:00
Dean Herbert
c45f9cafd4 Add medium -> regular fallback for torus 2020-03-13 13:43:48 +09:00
Dean Herbert
288470c313 Remove exo specification completely 2020-03-13 13:43:48 +09:00
Dean Herbert
ae112cf14f Reorder torus loading to provide regular as default 2020-03-13 13:43:48 +09:00
Dean Herbert
4a774d02e0 Remove exo font loading 2020-03-13 13:43:37 +09:00
Dean Herbert
8fb41e4c67
Merge pull request #8219 from smoogipoo/remove-unlimited-timingpoints
Remove unlimited timing points in difficulty calculation
2020-03-13 12:34:02 +09:00
Dean Herbert
ac70fcc544 Change logic to be more resilient by identifying user scroll events 2020-03-13 12:30:27 +09:00
Dean Herbert
5f8d180b5e Fix carousel scrolling being inoperable during beatmap import 2020-03-13 11:51:26 +09:00
Dean Herbert
04f1da04db Remove incorrect xmldoc from SelectBeatmap function 2020-03-13 10:52:08 +09:00
Dean Herbert
3f8b454ff4
Reword comment to match new filtering behaviour
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-03-13 10:01:28 +09:00
Bartłomiej Dach
d24fa18bc2
Merge branch 'master' into video-offset 2020-03-12 19:58:45 +01:00
Kelvin
c8ea922577
Update osu.Game/Skinning/LegacySkinExtensions.cs
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2020-03-12 04:18:57 -07:00
Kelvin
317bb5d0a4 Fallback on invalid AnimationFramerate for legacy skins 2020-03-12 03:55:45 -07:00
Dean Herbert
08dc4a0e8b
Merge pull request #8216 from smoogipoo/video-start-from-zero
Apply osu!-side video sprite changes
2020-03-12 19:46:46 +09:00
Dean Herbert
a69fabbd1f Update framework 2020-03-12 18:58:07 +09:00
Dean Herbert
604ce37064 Merge remote-tracking branch 'upstream/master' into video-start-from-zero 2020-03-12 18:57:53 +09:00
Dean Herbert
ca9cfbe51d Move selection fallback logic out of BeatmapCarousel to SongSelect 2020-03-12 18:42:08 +09:00
Dean Herbert
6e11c3014c Allow grouped difficulty icons to be clicked 2020-03-12 18:42:08 +09:00
Dean Herbert
ce5d01ed19 Allow filtered difficulty icons to be clicked 2020-03-12 18:42:08 +09:00
Dan Balasescu
1b5cb3893a
Merge branch 'master' into fix-carousel-test-loading-beatmaps 2020-03-12 18:14:27 +09:00
Dean Herbert
fc058f8896 Remove unnecessary this. prefix 2020-03-12 18:03:18 +09:00
Dean Herbert
933a8ffc8a Add test coverage 2020-03-12 17:10:51 +09:00
Dean Herbert
28ac5af91c Fix beatmap carousel tests loading beatmap manager beatmaps in test browser 2020-03-12 16:53:23 +09:00
Dean Herbert
63edcddaf1 Apply ruleset filter in all cases (even when bypassing filter for selection purposes) 2020-03-12 15:06:26 +09:00
Dean Herbert
fd21e87670 Disable adjusting volume via "select next" and "select previous" as fallbacks 2020-03-12 11:28:45 +09:00
smoogipoo
40ab860ab5 Remove unused using 2020-03-11 18:23:30 +09:00
smoogipoo
9667934ed9 Remove unlimited timing points in difficulty calculation 2020-03-11 18:17:32 +09:00
smoogipoo
758bb3711f Add more sane limit for maximum slider length 2020-03-11 18:07:11 +09:00
smoogipoo
8eb8572c73 Apply osu!-side video sprite changes 2020-03-11 18:00:39 +09:00
smoogipoo
424f9afbf4 Fix incorrect offset with custom clock 2020-03-11 17:55:20 +09:00
Dan Balasescu
35ae8aa29f
Merge pull request #8108 from EVAST9919/friends-update-streams
Implement FriendsOnlineStatusControl component
2020-03-11 15:35:23 +09:00
Dan Balasescu
1d556bfc5f
Merge branch 'master' into video-offset 2020-03-11 15:13:18 +09:00
smoogipoo
ae7245a51b Refactor + fix fade in too late 2020-03-11 15:11:54 +09:00
voidedWarranties
6de244389b Use OffsetClock instead of ManualClock 2020-03-10 22:50:20 -07:00
Dan Balasescu
e6685c88fc
Merge pull request #8205 from peppy/always-scroll-to-selection
Fix changing ruleset at song select not scrolling the current selection back into view
2020-03-11 14:38:57 +09:00
Dean Herbert
6f7a6a5a59
Merge pull request #8133 from peppy/better-filter-bypass
Reapply filters on next change after a forced beatmap display
2020-03-11 14:36:28 +09:00
Dan Balasescu
c3fd8e294a
Merge pull request #8211 from peppy/new-disclaimer
Update text on disclaimer screen (and add tips)
2020-03-11 14:24:58 +09:00
Dan Balasescu
d3c0deb381
Merge branch 'master' into friends-update-streams 2020-03-11 14:09:27 +09:00
Dan Balasescu
f8f8e3628f
Merge branch 'master' into always-scroll-to-selection 2020-03-11 13:38:28 +09:00
Dan Balasescu
9119e32f63
Merge branch 'master' into better-filter-bypass 2020-03-11 13:37:55 +09:00
Dean Herbert
93aec4e692
Improve english
Co-Authored-By: Dan Balasescu <smoogipoo@smgi.me>
2020-03-11 13:23:26 +09:00
Dean Herbert
ec88f7a712 Update tests and delay push animation until loader is done disappearing 2020-03-11 13:20:31 +09:00
Dean Herbert
4012e878b0 Update loader look 2020-03-11 13:05:33 +09:00
Dean Herbert
638a9a24aa Initial disclaimer updates 2020-03-11 13:03:27 +09:00
Dan Balasescu
afcbc5b789
Merge branch 'master' into fix-cross-thread-operation 2020-03-11 12:45:18 +09:00
Dean Herbert
ed837d3115 Use framework extension method for FromHex 2020-03-11 10:18:41 +09:00
Dean Herbert
a2d3f20409
Merge branch 'master' into better-filter-bypass 2020-03-11 02:55:14 +09:00
Dean Herbert
53e083f329
Merge branch 'master' into show-loved-pp 2020-03-11 01:08:13 +09:00
Dean Herbert
0be423183d Rename data class 2020-03-11 00:36:56 +09:00
Dean Herbert
66a0f3334d
Merge branch 'master' into fix-perfect-judgements 2020-03-10 23:50:57 +09:00
Dean Herbert
dbfbcca29c
Merge pull request #8195 from smoogipoo/fix-storyboard-crashes
Fix crashes on some storyboards
2020-03-10 22:28:35 +09:00
Dean Herbert
ad7cda8735 Fix download failures causing a non-safe drawable change 2020-03-10 20:11:06 +09:00
Dean Herbert
8294dd0b71 Fix changing ruleset at song selectnot scrolling the current selection back into view 2020-03-10 19:59:49 +09:00
smoogipoo
e6858bf130 Fix crashes on some storyboards 2020-03-10 11:58:33 +09:00
Dean Herbert
059af2a986 Update framework 2020-03-10 10:43:06 +09:00
voidedWarranties
5aa99d8b34 Hide background image when video is present 2020-03-09 16:04:23 -07:00
Dean Herbert
c1ac800473
Merge pull request #8186 from Joehuu/fix-textbox-backspace-animation
Fix textbox characters not animating when typing/backspacing
2020-03-09 14:03:33 +09:00
Joehu
3903423a37 Fix textbox characters not animating when typing/backspacing 2020-03-08 19:43:53 -07:00
Dan Balasescu
a04b651fea
Merge pull request #8170 from peppy/tournament-base-changes
Apply tournament client usability changes
2020-03-09 10:15:10 +09:00
Dan Balasescu
ae42c32c86
Merge pull request #8182 from Game4all/fix-hit-error-ticks-outside-bounds
Fix hit error ticks getting out of the hit error meter
2020-03-09 09:45:48 +09:00
Dan Balasescu
2eb8f245da
Merge branch 'master' into tournament-base-changes 2020-03-09 09:24:46 +09:00
Dan Balasescu
5b8035052f
Merge branch 'master' into fix-hit-error-ticks-outside-bounds 2020-03-09 09:16:51 +09:00
Dan Balasescu
0c868f54bc
Merge branch 'master' into score-counter-flexibility 2020-03-09 08:56:39 +09:00
voidedWarranties
4624582703 Revert position offset change for separate pull 2020-03-08 14:40:36 -07:00
voidedWarranties
22dd93a4f6 Code quality, read position offsets 2020-03-08 14:02:39 -07:00
Dean Herbert
460bd993ca
Merge pull request #8047 from TheWildTree/adjust-most-played
Adjust most played beatmaps section to better match osu-web
2020-03-09 02:20:02 +09:00
Lucas A
0953751d24 Clamp relative position of judgement ticks in range [0;1] 2020-03-08 15:51:57 +01:00
Bartłomiej Dach
c803de2b49 Fix player instantiation
Since ModTestScene.CreatePlayer would apply mods in addition to
instantiating the player, overriding it could lead to mistakenly also
overriding the code that was supposed to set up the test via
currentTestData.

Make ModTestScene.CreatePlayer sealed, which ensures that mod &
autoplay changes are applied, and expose ModTestScene.CreateModPlayer
instead which has the expected semantics.
2020-03-08 14:18:45 +01:00
Bartłomiej Dach
cc5cae4db9 Do not transition to result screen 2020-03-08 14:08:49 +01:00
Bartłomiej Dach
d5dda05d98 Merge branch 'master' into fix-perfect-judgements 2020-03-08 14:06:18 +01:00
Dean Herbert
0102aaf32a Move chat expand/contract logic local to tournament 2020-03-08 18:11:57 +09:00
Dean Herbert
979988235d Increase flexibility of StarCounter component 2020-03-08 15:56:22 +09:00
Dean Herbert
aed52179f0 Fix weird reverse logic 2020-03-08 15:32:22 +09:00
voidedWarranties
48282dea8b Remove individual setting to disable videos, fix tests 2020-03-07 22:08:38 -08:00
voidedWarranties
76c832518f Render video as a part of the storyboard 2020-03-07 21:32:03 -08:00
voidedWarranties
d68d7edea3 Start background video playback based on provided offset 2020-03-07 14:08:13 -08:00
Andrei Zavatski
e886c155e6 Adjust text size values 2020-03-07 04:05:17 +03:00
Andrei Zavatski
66f40f7f6e Merge remote-tracking branch 'refs/remotes/ppy/master' into user-cards-update 2020-03-07 04:01:36 +03:00
Dean Herbert
3295f8657a Restore clamp behaviour 2020-03-06 22:44:11 +09:00
Dean Herbert
fa8e7adf07 Merge branch 'master' into fix-testscene-rate 2020-03-06 22:40:02 +09:00
Dan Balasescu
28c665e7a6
Merge branch 'master' into add-load-delay-for-avatars 2020-03-06 22:09:47 +09:00
Dean Herbert
16cc49daa0 Update framework 2020-03-06 18:47:31 +09:00
Dean Herbert
a59c3d997d Refactor implementation to better match what already existed 2020-03-06 18:00:17 +09:00
Dean Herbert
90dbb90470 Merge branch 'master' into disable-keycounter-breaks 2020-03-06 17:53:10 +09:00
Dean Herbert
8ff3370273 Add a short load delay for avatars to avoid unnecessary fetching 2020-03-06 16:27:38 +09:00
Bartłomiej Dach
5b0846cb69 Handle hover explicitly 2020-03-05 23:15:53 +01:00
Bartłomiej Dach
bd1dbea6f4 Centralise background colour updates 2020-03-05 23:10:14 +01:00
Bartłomiej Dach
f5e6f92ac6 Merge branch 'master' into adjust-most-played 2020-03-05 22:37:09 +01:00
Dean Herbert
c3ad08f230 Remove wild writeline 2020-03-06 02:18:35 +09:00
Dean Herbert
ebc86c1075 Fix random test failure 2020-03-06 02:14:16 +09:00
Dean Herbert
e3509c742c Track time in a simpler way in TrackVirtualManual 2020-03-06 02:03:19 +09:00
Dean Herbert
ece263131b Update to follow new naming/structure 2020-03-06 00:36:05 +09:00
Dean Herbert
5b8aaba4a6 Merge branch 'master' into fix-perfect-judgements 2020-03-06 00:18:05 +09:00
Dean Herbert
2b89fb68f7
Merge branch 'master' into fix-testscene-rate 2020-03-05 23:38:33 +09:00
Dean Herbert
0477ef6c13 Force a selection after filtering to ensure correct difficulty is selected 2020-03-05 21:45:19 +09:00
Dean Herbert
332f56a7f8 Fix nullref in tests 2020-03-05 20:34:24 +09:00
Dean Herbert
371a543645 Update framework 2020-03-05 20:25:38 +09:00
Dean Herbert
e085aa8c1d Merge branch 'master' into better-filter-bypass 2020-03-05 20:19:08 +09:00
Dan Balasescu
aafdfbca1f
Merge pull request #8129 from peppy/fix-dummy-track-completion-feedback
Fix DummyWorkingBeatmap's track completion attempting to change game-wide beatmap
2020-03-05 17:57:57 +09:00
smoogipoo
0c1775b522 Fix incorrect condition and add test 2020-03-05 17:12:14 +09:00
Dan Balasescu
f12a515ca5
Merge branch 'master' into mod-testscene 2020-03-05 17:10:24 +09:00
Dan Balasescu
f7777ecb01
Merge pull request #8142 from peppy/add-star-difficulty-max-migration
Fix song select max displayable star difficulty getting stuck at wrong maximum
2020-03-05 17:10:10 +09:00
smoogipoo
9307caa3bf Fix typos 2020-03-05 16:58:07 +09:00
Dan Balasescu
f0fd2a86e3
Merge branch 'master' into add-star-difficulty-max-migration 2020-03-05 16:30:38 +09:00
Dan Balasescu
5368f5214b
Merge branch 'master' into less-test-players 2020-03-05 16:30:38 +09:00
Dean Herbert
5b8037ea7d Add note about early migration return on non-release transitions 2020-03-05 15:36:36 +09:00
Dean Herbert
507af4fa72 Add comment about rationale behind always updating version in config 2020-03-05 15:35:27 +09:00
Dean Herbert
d3786a9382 Merge branch 'centralise-update-managers' into add-star-difficulty-max-migration 2020-03-05 15:07:20 +09:00
Dean Herbert
a311ace626 Add migration test 2020-03-05 15:07:00 +09:00
Dean Herbert
1e1e8cbcb5 Always update version 2020-03-05 14:46:38 +09:00
Dean Herbert
1e6710020e Remove minor version for now 2020-03-05 13:46:25 +09:00
Dean Herbert
74b5e76c0e Fix dependency initialisation ordering 2020-03-05 13:39:55 +09:00
Dean Herbert
6477a7b73e Centralise creation of UpdateManagers 2020-03-05 13:34:04 +09:00
Dean Herbert
7229131d36 Fix song select max displayable star difficulty getting stuck at wrong maximum 2020-03-05 13:18:42 +09:00
Dean Herbert
e78c238ecd
Merge pull request #8131 from recapitalverb/fix-searchable-list-padding
Fix searchable list padding
2020-03-05 12:23:33 +09:00
Dean Herbert
26ce0d05d6 Use autoplay mod rather than local replay provider 2020-03-05 11:33:30 +09:00
Dean Herbert
77fddcd2c2 Merge branch 'less-test-players' into mod-testscene 2020-03-05 11:26:33 +09:00
Dean Herbert
5200633f9f Centralise TestPlayer implementations as much as possible 2020-03-05 11:25:07 +09:00
Dean Herbert
fadebcdc03 Move all sets to object initialiser for code formatting reasons 2020-03-05 10:21:25 +09:00
Dean Herbert
3b19467ead ModTestCaseData -> ModTestData 2020-03-05 10:19:42 +09:00
Dean Herbert
0f1f1d1a6b Remove unused "name" parameter 2020-03-05 10:18:37 +09:00
Dean Herbert
ce3786cfd9 Rename to ModTestScene (is no longer a sandbox) 2020-03-05 10:11:27 +09:00
Andrei Zavatski
6b44021f4d Change username text size back to 20 2020-03-05 03:33:14 +03:00
Andrei Zavatski
6b1fdcf9a2 Minor adjustments 2020-03-05 02:38:30 +03:00
Andrei Zavatski
13752ffe9d Revisit UserGridPanel layout 2020-03-05 02:31:19 +03:00
Andrei Zavatski
2e996eeb7e Refactor displayStatus function and add comments 2020-03-05 02:10:38 +03:00
Andrei Zavatski
22d43c26aa Adjust some text values 2020-03-05 02:00:46 +03:00
Andrei Zavatski
06b2c70a04 Simplify alignment setting for status message 2020-03-05 01:45:49 +03:00
Andrei Zavatski
d297bf6957 Adjust background presentation 2020-03-05 01:41:55 +03:00
TheWildTree
997be65be2 Improve colouring logic 2020-03-04 21:19:26 +01:00
Andrei Zavatski
bd03dd9b70 Adjust class naming 2020-03-04 23:08:58 +03:00
Andrei Zavatski
63219a2357 Adjust properties naming 2020-03-04 23:06:16 +03:00
Andrei Zavatski
55a0586b13 Move exception handling below all the cases 2020-03-04 23:03:02 +03:00
Andrei Zavatski
8849f25069 Merge remote-tracking branch 'refs/remotes/ppy/master' into friends-update-streams 2020-03-04 22:59:56 +03:00
TheWildTree
5628c5102d Remove old scores before adding new ones 2020-03-04 20:01:15 +01:00
TheWildTree
9aacc3f5ae Replace Scores property with DisplayScores method
Also adds null checks to prevent crashes in tests.
2020-03-04 19:24:52 +01:00
Dean Herbert
f8776a0be4 Display all difficulties from overriding selection 2020-03-04 22:59:49 +09:00
Andrei Zavatski
0b98bcc856 Fix incorrect click action 2020-03-04 15:22:08 +03:00
Andrei Zavatski
6631b07442 Refactor to replace existing panels 2020-03-04 14:58:15 +03:00
Dean Herbert
a62550b323 Reapply filters on next change after a forced beatmap display 2020-03-04 20:14:18 +09:00
Andrei Zavatski
1bdbe7c823 Merge remote-tracking branch 'refs/remotes/ppy/master' into user-cards-update 2020-03-04 13:43:28 +03:00
Andrei Zavatski
e7e759cc92 Merge remote-tracking branch 'refs/remotes/ppy/master' into user-cards-update 2020-03-04 13:15:51 +03:00
Dean Herbert
38d91ccd0d Add comment regarding no-longer-required schedule 2020-03-04 19:11:35 +09:00
Dean Herbert
bac35b2a68 Handle beatmap track changing in a saner way 2020-03-04 19:11:35 +09:00
Andrei Zavatski
8a437e1b54 Add ability to send pm via context menu 2020-03-04 12:42:21 +03:00
Andrei Zavatski
15e47d8432 Implement layout for UserGridCard 2020-03-04 12:20:49 +03:00
Dan Balasescu
fa7f8de4e3
Merge branch 'master' into beatmap-status 2020-03-04 18:11:59 +09:00
recapitalverb
a1dc595006 Change scroll container padding 2020-03-04 15:46:35 +07:00
recapitalverb
184d10a75a Revert "Reduce social overlay/direct overlay paddings"
This reverts commit cb11292181.
2020-03-04 15:45:22 +07:00
mcendu
eaa77bce14 Use ToString().ToLowerInvariant()
* https://github.com/ppy/osu/pull/8128#issuecomment-594360083
2020-03-04 16:43:35 +08:00
Dean Herbert
7464a486d9 Fix DummyWorkingBeatmap's track completion attempting to change game-wide beatmap 2020-03-04 16:35:45 +09:00
Andrei Zavatski
6ea3af1951 Implement layout for UserListCard 2020-03-04 10:35:43 +03:00
杜Nate
fbd0dfd71b
add blank lines 2020-03-04 14:55:51 +08:00
mcendu
416b9e4e6f fix beatmap status display 2020-03-04 14:28:18 +08:00
Andrei Zavatski
b7d34b399d Adjust background presentation for UserListCard 2020-03-04 09:10:51 +03:00
Andrei Zavatski
1b5222f396 Baisc UserListCard implementation 2020-03-04 08:53:14 +03:00
Andrei Zavatski
f425233527 Basic UserCard implementation 2020-03-04 08:41:21 +03:00
Dan Balasescu
6f5d2da03e
Merge branch 'master' into add-torus-font 2020-03-04 13:56:30 +09:00
Dan Balasescu
aa17a64a0e
Apply missed xmldoc suggestion 2020-03-04 12:47:01 +09:00
Dean Herbert
e9b0770f64
Apply suggestions from code review
Co-Authored-By: Dan Balasescu <smoogipoo@smgi.me>
2020-03-04 12:44:44 +09:00
Dean Herbert
75968fb4ba Update resources once more 2020-03-04 11:50:22 +09:00
Dean Herbert
4294ed4b64 Better align fonts to weights 2020-03-04 11:45:19 +09:00
voidedWarranties
c3f840cc1a Fix Autoplay = false and AllowFail behavior 2020-03-03 17:12:01 -08:00
Andrei Zavatski
e2ed13b392 Trim whitespace 2020-03-04 00:40:10 +03:00
Andrei Zavatski
6fca3e5a46 Remove functions with get-only properties 2020-03-04 00:39:12 +03:00
Andrei Zavatski
17f2baf600 Remove GetWidth function 2020-03-04 00:35:32 +03:00
Andrei Zavatski
4d5445b5dc Rename Amount to Count 2020-03-04 00:31:06 +03:00
Andrei Zavatski
c22f61b2b1 Move colour selection to the FriendsOnlineStatusItem 2020-03-04 00:28:47 +03:00
Andrei Zavatski
83dad93b6d Make Populate() accept list of users 2020-03-03 18:08:51 +03:00
Andrei Zavatski
160d64eecf FriendsOnlineStatusControl basic implementation 2020-03-03 17:37:01 +03:00
Andrei Zavatski
c0f7a83f6f Fix featured stream item width 2020-03-03 17:10:25 +03:00
Andrei Zavatski
937d9da43b Implement OverlayUpdateStreamControl component 2020-03-03 17:01:58 +03:00
Dean Herbert
db56fb5759 Fix venera font usage 2020-03-03 22:28:47 +09:00
Andrei Zavatski
8dcdd6db6f Rename UpdateStream components to ChangelogUpdateStream 2020-03-03 16:20:36 +03:00
Dean Herbert
740eb9ff53
Merge pull request #8090 from peppy/fix-volume-bninding-handling
Add SelectPrevious and SelectNext bindings / Change volume bindings to be truly global
2020-03-03 18:58:49 +09:00
Dean Herbert
08756186e9 Update resources 2020-03-03 18:35:28 +09:00
Dean Herbert
f1f4f1ffbd Add torus font 2020-03-03 18:17:51 +09:00
Dan Balasescu
e77cefeabe
Merge branch 'master' into fix-volume-bninding-handling 2020-03-03 16:32:18 +09:00
smoogipoo
cb11292181 Reduce social overlay/direct overlay paddings 2020-03-03 16:06:31 +09:00
smoogipoo
2e4adc056f Fix potential deadlock during gameplay tests 2020-03-03 13:42:05 +09:00
Dean Herbert
7a71a48892
Merge branch 'master' into mod-testscene 2020-03-03 13:40:20 +09:00
smoogipoo
a1aecd4c39 Fix TrackVirtualManual not respecting rate adjustments 2020-03-03 13:01:28 +09:00
smoogipoo
1e26df64b6 Fix constructor test failures 2020-03-03 12:58:07 +09:00
smoogipoo
90c2f7bd89 Fail tests by default 2020-03-03 12:13:36 +09:00
Dan Balasescu
3ef490689e
Merge branch 'master' into changelog-stream-area-refactor 2020-03-03 11:52:03 +09:00
naoey
3d344a076d
Add test for disabled keycounter, don't discard change event values 2020-03-03 06:17:25 +05:30
Dean Herbert
769b7582e3
Merge branch 'master' into dependabot/nuget/Sentry-2.1.0 2020-03-02 20:24:28 +09:00
Dean Herbert
69b4713731 Refactor everything so I can read the code 2020-03-02 20:16:58 +09:00
Dean Herbert
23068034b1 Rename bool and make property for legibility 2020-03-02 19:51:06 +09:00
Dean Herbert
df4de4a090
Merge branch 'master' into changelog-stream-area-refactor 2020-03-02 19:48:04 +09:00
Dean Herbert
e890e45420 Fix Ctrl+Enter behaviour regression 2020-03-02 19:44:25 +09:00
Dean Herbert
48f2f615cd
Merge branch 'master' into fix-volume-bninding-handling 2020-03-02 19:28:36 +09:00
Dean Herbert
81191a3d20 Handle SelectPrevious/SelectNext locally to volume meter when hovered 2020-03-02 18:59:55 +09:00
Dean Herbert
e608d807f4 Handle SelectPrevious / SelectNext as volume change operations if nothing else handled game-wide 2020-03-02 18:59:38 +09:00
Dean Herbert
6989738710 Change default global bindings for volume changing to include the alt key prefix 2020-03-02 18:59:05 +09:00
Dean Herbert
88583b5c79 Remove any existing bindings to increase/decrease volume 2020-03-02 18:56:41 +09:00
Dean Herbert
ed516f05c2 Forward any unhandled scroll events to volume overlay 2020-03-02 18:56:09 +09:00
Dean Herbert
3404b09010 Bring database snapshot in line with specs 2020-03-02 18:55:52 +09:00
Dean Herbert
489bf16bea Add SelectNext and SelectPrevious global actions 2020-03-02 18:55:28 +09:00
Dean Herbert
ee73f3e2b2 Change matching mode for global actions to better discern similar binds 2020-03-02 18:54:00 +09:00
dependabot-preview[bot]
5432371c74
Bump Sentry from 2.0.3 to 2.1.0
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 2.0.3 to 2.1.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/2.0.3...2.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-02 08:42:12 +00:00
Dean Herbert
89399b177c Update framework 2020-03-02 16:41:00 +09:00
Dean Herbert
dc79c11b6a Merge branch 'master' into layout-rework 2020-03-02 16:36:48 +09:00
smoogipoo
6d051d9e42 Fix perfect mod failure cases 2020-03-02 13:25:56 +09:00
smoogipoo
6fb52e5370 Fix custom rulesets not being testable 2020-03-02 13:25:36 +09:00
smoogipoo
cd43a0c9e8 Better check for failing state 2020-03-02 13:24:07 +09:00
smoogipoo
e801ad514b Fix ruleset nullref 2020-03-02 13:24:02 +09:00
smoogipoo
6d939e9d41 Add failing test scenes 2020-03-02 12:42:48 +09:00
smoogipoo
ce7cbf29ca Move to using test methods for better separation 2020-03-02 12:20:25 +09:00
smoogipoo
239cfddcbb Improve test scenes/cases 2020-03-02 10:50:41 +09:00
smoogipoo
5c15704c81 Improve abstract structure for testability 2020-03-02 10:28:39 +09:00
smoogipoo
a02c5710ac Rename base class 2020-03-02 10:06:49 +09:00
voidedWarranties
089ec4c792 Test scene for mod development 2020-02-29 21:16:28 -08:00
naoey
bca58ddb42
Make KeyCounter stop counting during breaks 2020-02-29 21:18:43 +05:30
TheWildTree
4d19278df4 Remove using directive 2020-02-29 15:43:48 +01:00
TheWildTree
f661806513 Move checking logic out of ScoreTable 2020-02-29 15:29:00 +01:00
Dean Herbert
a332b6980b Update framework 2020-02-29 14:28:26 +09:00
Dean Herbert
f18a1cde53 Fix crash when reaching results screen on single threaded execution mode 2020-02-29 08:39:27 +09:00
Andrei Zavatski
5dff7f0955 Adjust horizontal padding 2020-02-29 02:21:52 +03:00
Andrei Zavatski
3c8ccf3c7d Merge remote-tracking branch 'refs/remotes/ppy/master' into changelog-stream-area-refactor 2020-02-29 02:17:37 +03:00
TheWildTree
d71b516902 Check beatmap ranking status instead of the pp value 2020-02-28 21:58:37 +01:00
TheWildTree
5838af39c1 Add background colour customization to ProfileItemContainer 2020-02-28 21:09:49 +01:00
TheWildTree
036f155afe Adjust colours in DrawableMostPlayedBeatmap 2020-02-28 21:09:31 +01:00
Dean Herbert
7fdc274d03
Merge pull request #8029 from smoogipoo/better-room-participants
Implement new multiplayer participants retrieval
2020-02-28 22:40:03 +09:00
Dean Herbert
394b88aa65 Add thread mode dropdown 2020-02-28 22:17:45 +09:00
Dean Herbert
4ad2d0cfb6 Remove deprecated debug setting 2020-02-28 22:17:45 +09:00
Dean Herbert
7b9937b851 Update framework 2020-02-28 22:15:39 +09:00
Andrei Zavatski
377ae3e685 Make a separate if section for all highlighted case 2020-02-28 12:48:06 +03:00
Andrei Zavatski
8fdf859375 Merge remote-tracking branch 'refs/remotes/ppy/master' into changelog-stream-area-refactor 2020-02-28 12:15:09 +03:00
Dean Herbert
276f6da483
Merge branch 'master' into better-room-participants 2020-02-28 16:42:31 +09:00
Dan Balasescu
5118d57a7a
Merge branch 'master' into settingsource-dropdown 2020-02-28 16:42:24 +09:00
Dean Herbert
37aac9c214
Merge pull request #8028 from smoogipoo/add-beatmap-cover-load-delay
Add delay for loading multiplayer beatmap covers
2020-02-28 16:42:21 +09:00