Dean Herbert
6985e2e657
Increase default visibility on touch platforms
2024-08-19 20:32:05 +09:00
Dean Herbert
005b1038a3
Change "hold for menu" button to only show for touch by default
2024-08-19 20:23:25 +09:00
Bartłomiej Dach
24a0a3c47f
Merge pull request #29476 from EVAST9919/buffered-editor-grid
...
Improve draw performance of editor grids
2024-08-19 12:44:08 +02:00
Joseph Madamba
6dd08e9a96
Fix beatmap carousel panels not blocking hover of other panels in song select
2024-08-17 11:45:54 -07:00
Andrei Zavatski
3cd5820b5b
Make PositionSnapGrid a BufferedContainer
2024-08-17 10:34:39 +03:00
Andrei Zavatski
f74263db81
Remove extra box in OnlinePlayBackgroundScreen
2024-08-17 01:01:51 +03:00
OliBomby
621c4d65a3
Hide scroll speed in effect row attribute
2024-08-16 14:43:33 +02:00
OliBomby
b253d8ecbf
Hide scroll speed in bottom timeline
2024-08-16 14:43:09 +02:00
OliBomby
5624c1d304
Make break periods in bottom timeline transparent
2024-08-16 13:22:09 +02:00
OliBomby
3a84409546
Use TimingPointAfter for seeking check
2024-08-16 01:36:51 +02:00
Joseph Madamba
c3600467bf
Make collection button test less broken
2024-08-15 11:49:15 -07:00
Dan Balasescu
52c1858bbe
Merge pull request #29428 from peppy/update-editor-menu-items-difficulty-change
...
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
2024-08-16 00:44:59 +09:00
Dean Herbert
5710f0f302
Merge pull request #26254 from frenzibyte/mania-combo-counter
...
Add argon/classic osu!mania combo counter
2024-08-15 17:56:28 +09:00
Dean Herbert
b5f615882f
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
...
Closes https://github.com/ppy/osu/issues/29391 .
2024-08-15 17:25:30 +09:00
Dean Herbert
9dc496d6a7
Merge pull request #29415 from Joehuu/difficulty-name-content
...
Implement song select v2 difficulty name content component
2024-08-15 15:20:52 +09:00
Salman Ahmed
3a4546d62d
Remove x symbol from argon mania combo counter
2024-08-15 15:08:35 +09:00
Dean Herbert
28ab65243d
Remove daily challenge tooltip from main menu
...
Now that we have a nice intro screen for the daily challenge, it's
generally thought that we want to "spoil" the beatmap until the intro is
shown.
Also I was never a huge fan of having a tooltip on a main menu button..
just feels a bit odd.
2024-08-14 20:45:27 +09:00
Joseph Madamba
11bd0c9a61
Inline single-frame layout issue comment instead
2024-08-14 00:41:43 -07:00
Joseph Madamba
c24f1444f9
Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent
2024-08-13 23:26:18 -07:00
Joseph Madamba
2b41f71fd0
Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers
2024-08-13 23:26:17 -07:00
Joseph Madamba
625c6fc7eb
Implement song select v2 difficulty name content component
2024-08-13 23:26:17 -07:00
Dean Herbert
e465049050
Merge branch 'master' into mania-combo-counter
2024-08-14 15:12:00 +09:00
Dean Herbert
16f6e26c2e
Merge pull request #29372 from ArijanJ/song-progress-optional-time
...
Add option to hide song progress time/text
2024-08-13 00:57:15 +09:00
Bartłomiej Dach
06c2952fe8
Merge branch 'master' into grids-3
2024-08-12 13:55:35 +02:00
Dean Herbert
b567ab2a39
Fix context menus sometimes not being clickable at song select
...
Closes https://github.com/ppy/osu/issues/21602 .
2024-08-12 20:31:20 +09:00
Bartłomiej Dach
92bd123ebc
Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam
...
Fix daily challenge notification spam
2024-08-12 12:18:38 +02:00
Bartłomiej Dach
96bd374b18
Change notification interval to 30 minutes
2024-08-12 11:24:59 +02:00
Bartłomiej Dach
54a1d79136
Clean up some naming weirdness
2024-08-12 11:23:36 +02:00
Bartłomiej Dach
041c70e4eb
Fix tests
2024-08-12 11:19:02 +02:00
Bartłomiej Dach
306e84c7ac
Move disposal method to more expected location
2024-08-12 10:46:58 +02:00
ArijanJ
fed5b9d747
Fix one more inspectcode warning
2024-08-10 09:45:30 +02:00
ArijanJ
d01e76d9db
Fix double blank line
2024-08-09 23:08:22 +02:00
ArijanJ
2dee8bef7e
Add option to hide song progress time/text
2024-08-09 22:50:37 +02:00
Dean Herbert
df43263e38
Merge branch 'master' into daily-challenge-intro-sfx
2024-08-10 02:22:48 +09:00
Jamie Taylor
c6fa348d82
Add sound design for daily challenge intro animation
2024-08-09 23:05:33 +09:00
Dean Herbert
8fdd94090b
Show object inspector values during placement
2024-08-09 18:02:37 +09:00
Dean Herbert
e146c8e230
Ensure only one daily challenge notification is fired per room
2024-08-09 17:11:11 +09:00
Dean Herbert
52b2d73e04
Only show daily challenge notification if it started within the last 30 minutes
2024-08-09 17:10:18 +09:00
Dean Herbert
161734af95
Simplify argon mania combo counter implementation by sharing with base counter
2024-08-09 15:46:57 +09:00
Dean Herbert
e645651ef4
Merge branch 'master' into mania-combo-counter
2024-08-09 00:19:17 +09:00
Dean Herbert
0cb3b6a1f8
Add back TrySetDailyChallengeBeatmap call for safety
2024-08-08 22:10:26 +09:00
Dean Herbert
8eb0ef1e33
Merge branch 'master' into daily-challenge-intro-audio-auto-download
2024-08-08 22:09:21 +09:00
Dean Herbert
03d543ec99
Fix potential test failure in daily challenge tests
...
See https://github.com/ppy/osu/actions/runs/10296877688/job/28500580680 .
2024-08-08 16:53:22 +09:00
Dean Herbert
3f3145e109
Start playing music during intro if download finishes early
2024-08-08 15:10:18 +09:00
Dean Herbert
5d66eda982
Add support for automatically downloading daily challenge during the intro display
2024-08-08 15:10:18 +09:00
Dean Herbert
e95d61d4c2
Remove accidental double handling of beatmap availability in DailyChallenge
2024-08-08 15:10:18 +09:00
Dean Herbert
f91a3e9a35
Start playing daily challenge track as part of intro sequence
2024-08-08 15:10:17 +09:00
Dean Herbert
5891780427
Show initial text a bit longer
2024-08-08 14:15:40 +09:00
Dean Herbert
7058fedf42
Merge branch 'master' into daily-challenge-intro-screen-part-2
2024-08-08 14:12:16 +09:00
Dean Herbert
1ee5522a25
Merge branch 'master' into daily-challenge-intro-screen-part-2
2024-08-08 14:08:14 +09:00
Dean Herbert
25dddb694a
And then completely change the animation to a new style
2024-08-08 14:02:43 +09:00
Dean Herbert
f72f5ee7e3
More improvements maybe
2024-08-08 13:29:10 +09:00
Dean Herbert
9bafdeeeff
Improve animation
2024-08-08 13:17:25 +09:00
Dean Herbert
8773c2f7eb
Merge pull request #29281 from kstefanowicz/multiplayer-chat-focus-hint
...
Add "enter" hint to in-gameplay chatbox placeholder text
2024-08-08 01:29:42 +09:00
Dan Balasescu
a06cb9a0de
Merge pull request #29322 from peppy/daily-challenge-import-improvement
...
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu
2024-08-08 00:42:03 +09:00
Dean Herbert
cfd7f96e76
Add missing exit line causing completely incorrect behaviour
2024-08-07 23:29:24 +09:00
kstefanowicz
775f76f472
Have placeholder text change while focused
2024-08-07 07:47:35 -04:00
Bartłomiej Dach
437812eebe
Merge pull request #29279 from normalid-awa/bugfix/editor/delete-operation-wont-close-the-menu
...
Close context menus when deselecting items in editor
2024-08-07 13:25:13 +02:00
Dean Herbert
e52d80a41b
Add more difficulty information and further tweaks to visuals
2024-08-07 19:08:04 +09:00
Dean Herbert
083fe32d20
Improve feel of animation
2024-08-07 19:07:45 +09:00
Salman Ahmed
a0615a8f18
Frenzi's WIP animation
2024-08-07 19:07:45 +09:00
Dean Herbert
cfccd74441
Add daily challenge intro sequence
2024-08-07 19:07:44 +09:00
Dean Herbert
6870311c1e
Remove requirement of specifying animateOnnter in BackgroundScreen ctor
2024-08-07 19:07:44 +09:00
Dean Herbert
3c05b975a0
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu
2024-08-07 19:07:43 +09:00
Dean Herbert
5a63c25f49
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu
2024-08-07 14:42:34 +09:00
Dean Herbert
8619bbb943
Fix legacy key counter's background being visible when intended to be hidden
2024-08-06 16:12:00 +09:00
Dan Balasescu
c574551ee0
Simplify caching
2024-08-06 16:02:36 +09:00
Dan Balasescu
b91461e661
Refactor + CI fixes
2024-08-06 15:17:52 +09:00
jkh675
cb877b7675
Close the menu when selecting other object
2024-08-06 13:09:48 +08:00
Dan Balasescu
d637bbf752
Merge pull request #29286 from peppy/middle-click-delete
...
Allow object deletion with middle mouse
2024-08-06 13:38:56 +09:00
jkh675
75c0c6a5f9
Make the OsuContextMenu nullable in SelectionHandler
2024-08-05 16:32:49 +08:00
Dean Herbert
c37f617e1d
Adjust song select info icon size slightly
...
Not going to PR this it's just a minor tweak.
2024-08-05 17:21:50 +09:00
Dean Herbert
0557b9ab79
Allow placement deletion with middle mouse
...
This is in addition to Shift + Right-click.
I thik middle mouse feels more natural and is a good permanent solution
to this issue.
Note that this also *allows triggering the context menu from placement
mode*. Until now it's done nothing. This may be annoying to users with
muscle memory but I want to make the change and harvest feedback. I
think showing the context menu is more correct behaviour (although
arguably it should return to placement mode on dismiss?).
2024-08-05 14:25:09 +09:00
Dan Balasescu
136cdcfb29
Merge pull request #29059 from frenzibyte/fix-results-fetching-twice
...
Fix results screen fetching scores twice when scrolled to edge
2024-08-05 14:23:47 +09:00
Dan Balasescu
f92e2094c1
Adjust localisation string name + formatting
2024-08-05 12:34:24 +09:00
AkiraTenchi
a5a392e9fc
Update FilterQueryParser.cs
...
Add sr as an alias for star rating in the search parameters
2024-08-04 19:48:29 +02:00
kstefanowicz
b0757a13c2
Add "enter" hint to chatbox placeholder text while in-game
2024-08-04 12:32:08 -04:00
jkh675
b32d97b4c0
Remove decreapted property
2024-08-04 21:27:25 +08:00
jkh675
2145368d17
Merge EditorContextMenuContainer into OsuContextMenuContainer
2024-08-04 21:00:43 +08:00
jkh675
7c83d6a883
Cleanup code
2024-08-04 19:56:41 +08:00
jkh675
5d31171fb0
Fix code quality
2024-08-04 19:43:43 +08:00
jkh675
3cc5466774
Refactor the code to follow IoC principle and more flexible
2024-08-04 19:39:06 +08:00
jkh675
27d6c4cecb
Implement on beatmap editor
2024-08-04 19:16:14 +08:00
jkh675
5c5fcd7e7e
Allow key event pass through selection handler
2024-08-04 19:11:21 +08:00
jkh675
1ff0c7cb46
Replace original menu container with custom one
2024-08-04 19:10:49 +08:00
jkh675
83aeb27c73
Replace original menu container to the custom one
2024-08-04 19:08:31 +08:00
jkh675
de6d8e7eb7
Add the custom context menu to handle the key event
2024-08-04 19:07:35 +08:00
Dan Balasescu
7bf96ce49a
Merge pull request #29231 from peppy/timeline-break-behind-objects
...
Show breaks behind objects in timeline
2024-08-02 21:28:11 +09:00
Dean Herbert
548fd9cbf9
Show breaks behind objects in timeline
...
Closes https://github.com/ppy/osu/issues/29227 .
2024-08-01 19:47:44 +09:00
Layendan
19a4cef113
update var names and test logic
2024-08-01 02:52:41 -07:00
Dean Herbert
dab967e6be
Fix insane transform allocations in new leaderboard display
2024-08-01 18:36:33 +09:00
Dean Herbert
2d52bab77b
Always show timing points in timeline when at the timing screen
...
Supersedes https://github.com/ppy/osu/pull/29196 .
2024-07-31 19:43:08 +09:00
Dean Herbert
e329427d6e
Apply nullability to Timeline
2024-07-31 19:28:32 +09:00
Layendan
36bd83bb80
Update collection state when users add/remove from collection
2024-07-30 15:22:41 -07:00
Dean Herbert
e77489f2a9
Allow notification of new strings
2024-07-31 03:10:36 +09:00
Dean Herbert
bdc465e1c6
Reword notification text slightly
2024-07-31 03:06:35 +09:00
Dean Herbert
d75c170ba1
Merge branch 'master' into daily-challenge/better-messaging
2024-07-30 19:04:48 +09:00
Dean Herbert
d5f9173288
Remove unused local variable
2024-07-30 19:04:43 +09:00
Bartłomiej Dach
1b57a2a136
Show new daily challenge notification globally
2024-07-30 10:36:26 +02:00
Salman Ahmed
621f4dfece
Enforce new line between X/Y coordinate in editor position inspector
2024-07-30 02:45:21 +03:00
Dean Herbert
aa2515763c
Merge pull request #29184 from bdach/daily-challenge/wrong-mods-after-replay
...
Fix mods persisting after watching replay from daily challenge screen
2024-07-29 23:23:45 +09:00
Bartłomiej Dach
b46f3c97da
Add notification on daily challenge conclusion & start of new one
...
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.
The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
2024-07-29 14:30:10 +02:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay
2024-07-29 20:58:42 +09:00
Dean Herbert
05056f0e8a
Remove no longer required AlwaysPresent definition
...
This also reverts commit 7fedfd368c
2024-07-29 20:43:56 +09:00
Dean Herbert
5a1002c1a0
Ensure score breakdown doesn't spam scores when not visible
2024-07-29 20:43:50 +09:00
Bartłomiej Dach
f1a84a5111
Fix mods persisting after watching replay from daily challenge screen
...
Closes https://github.com/ppy/osu/issues/29133 .
Hope I can be forgiven for no tests. I had a brief try but writing them
is going to take hours.
2024-07-29 12:52:30 +02:00
Bartłomiej Dach
cebd38c6eb
Merge pull request #29163 from Joehuu/copy-lb-mods-daily
...
Add ability to copy leaderboard mods in daily challenge
2024-07-29 12:09:27 +02:00
Bartłomiej Dach
2ff0a89b4f
Convert into auto-property even more
2024-07-29 10:59:21 +02:00
Bartłomiej Dach
54c904d439
Convert into auto-property
2024-07-29 10:40:29 +02:00
Bartłomiej Dach
aa7f6f81ef
Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily
...
Fix daily challenge background clipping when settings/notifications is opened
2024-07-29 10:28:48 +02:00
Joseph Madamba
f6eb9037df
Add ability to copy leaderboard mods in daily challenge
2024-07-27 23:55:56 -07:00
Salman Ahmed
7fedfd368c
Fix score breakdown tooltips appearing in other feeds
2024-07-28 07:22:58 +03:00
Joseph Madamba
bc25e5d706
Remove unnecessary depth and padding set
2024-07-27 19:13:11 -07:00
Joseph Madamba
850bcaef7a
Merge remote-tracking branch 'upstream/master' into pr/28991
2024-07-27 19:09:02 -07:00
Joseph Madamba
334f5fda2d
Remove direct margin set in popover that was causing positioning offset
2024-07-27 19:02:57 -07:00
Joseph Madamba
04b15d0d38
Remove unnecessary ReceivePositionalInputAt
...
Results is not even using the new footer.
2024-07-27 19:02:43 -07:00
Joseph Madamba
b4ca07300a
Use same size button for everything
2024-07-27 18:43:54 -07:00
Joseph Madamba
b5ff2dab43
Move some properties/bindables around
2024-07-27 18:42:49 -07:00
Joseph Madamba
aed2b3c7c6
Inherit GrayButton instead
...
Also fixes hover highlight.
2024-07-27 18:42:49 -07:00
Joseph Madamba
d55e861b90
Fix daily challenge background clipping when settings/notifications is opened
2024-07-26 16:55:15 -07:00
Dean Herbert
9323f89357
Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge
2024-07-27 02:06:56 +09:00
Dean Herbert
0421e1e9d0
Reduce number spacing a bit more
2024-07-26 23:21:44 +09:00
Dean Herbert
96049807c4
Adjust weight and text in event feed output
...
Just some minor adjustments.
2024-07-26 23:20:32 +09:00
Dean Herbert
4fa6a19409
Merge pull request #29108 from bdach/daily-challenge/better-breakdown
...
Improve score breakdown on daily challenge
2024-07-26 23:12:04 +09:00
Dean Herbert
47eca0eb37
Merge pull request #29101 from bdach/daily-challenge/fix-preview-track
...
Fix preview tracks not stopping playback when suspending/exiting daily challenge screen
2024-07-26 21:52:26 +09:00
Dean Herbert
6f7d05d5a0
Merge pull request #29104 from bdach/daily-challenge/fix-no-audio-adjustments
...
Fix daily challenge screen not applying track adjustments from mods
2024-07-26 21:51:58 +09:00
Bartłomiej Dach
0996f9b0b5
Fix code quality
2024-07-26 14:45:39 +02:00
Dean Herbert
1607075e0c
Merge pull request #29099 from bdach/daily-challenge/totals-display
...
Implement component for displaying running totals in daily challenge
2024-07-26 21:44:58 +09:00
Dean Herbert
a870722ea6
Adjust easings and reduce character spacing slightly
2024-07-26 21:43:23 +09:00
Bartłomiej Dach
fc0ade2c61
Highlight where local user's best is on the breakdown
2024-07-26 14:32:01 +02:00
Bartłomiej Dach
2caaebb670
Add tooltip with counts to daily challenge score breakdown chart
2024-07-26 13:47:41 +02:00
Dean Herbert
19affa7062
Rename new property to match true usage (per item)
...
Also document a bit more.
2024-07-26 20:45:13 +09:00
Bartłomiej Dach
2e37f3b5de
Hook up score totals display to daily challenge screen
2024-07-26 12:34:23 +02:00
Bartłomiej Dach
1abcf16231
Fix daily challenge screen not applying track adjustments from mods
...
Closes https://github.com/ppy/osu/issues/29093 .
2024-07-26 11:50:43 +02:00
Bartłomiej Dach
f9cfc7d96c
Fix preview tracks not stopping playback when suspending/exiting daily challenge screen
...
Closes https://github.com/ppy/osu/issues/29083 .
2024-07-26 10:53:12 +02:00
Cameron Brown
17f00ec0a6
Bind the mod select overlay's Beatmap to OsuScreen.Beatmap in constructor
...
Suggested by @bdach!
2024-07-26 18:29:50 +10:00
Cameron Brown
a8851950bc
Update the beatmap of Daily Challenge's mods overlay when beatmap is set - #29094
2024-07-26 18:10:11 +10:00
Bartłomiej Dach
174dc91f4b
Implement component for displaying running totals in daily challenge
...
Total pass count and cumulative total score, to be more precise.
2024-07-26 09:51:39 +02:00
Bartłomiej Dach
e489ae8f72
Merge pull request #29055 from peppy/event-feed-improvements
...
Improve daily challenge event feed
2024-07-26 08:37:47 +02:00
Bartłomiej Dach
09a1fd2cd1
Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button
...
Fix daily challenge not showing a replay button in results screen
2024-07-26 08:03:17 +02:00
Bartłomiej Dach
c17cabd981
Adjust alpha for rows for better visibility
2024-07-26 07:44:02 +02:00
Salman Ahmed
c558dfdf13
Reset download state when score is changed
2024-07-26 05:11:54 +03:00
Dean Herbert
c90e04092a
Merge pull request #29068 from bdach/results-statistics-toggle-crash
...
Fix crash when toggling extended statistics visibility during results load
2024-07-25 22:49:41 +09:00
Bartłomiej Dach
8dbd4d70ff
Fix crash when toggling extended statistics visibility during results load
...
Closes https://github.com/ppy/osu/issues/29066 .
Initially I fixed this at where the assert is right now:
9790c5a574/osu.Game/Screens/Ranking/ResultsScreen.cs (L333)
2024-07-25 11:45:17 +02:00
Bartłomiej Dach
8d89557ab8
Fix not being able to send chat reports on daily challenge screen
...
Something something some people cannot be trusted with a textbox.
2024-07-25 11:11:54 +02:00
Salman Ahmed
615f07d54c
Fix results screen fetching more scores twice
2024-07-25 09:16:09 +03:00
Salman Ahmed
9d5fbb8b4f
Fix target score selection abruptly discarded after opening results screen
2024-07-25 09:01:43 +03:00
Dean Herbert
f1dda4ab1e
Fix too many event rows displaying after spending a long time in gameplay/results
2024-07-25 14:31:22 +09:00
Dean Herbert
c90d345ff9
Scroll content forever rather than aggressively fading
2024-07-25 14:31:21 +09:00
Salman Ahmed
dad8e28446
Fix replay download button not added when no score is selected initially
2024-07-25 07:40:17 +03:00
Dean Herbert
aac98ab6b2
Debounce leaderboard refetches to stop excessive operations after returning from gameplay
2024-07-25 12:58:35 +09:00
Dean Herbert
9ec687caab
Avoid reloading the daily challenge leaderboard when already requested
2024-07-25 12:55:45 +09:00
Dean Herbert
4983e5f33e
Merge pull request #29039 from bdach/multiple-selection-sample-popover
...
Make sample popover change properties of all samples in multiple selection
2024-07-24 22:49:20 +09:00
Bartłomiej Dach
1ed7e4b075
Make sample popover change properties of all samples in multiple selection
...
Closes https://github.com/ppy/osu/issues/28916 .
The previous behaviour *may* have been intended, but it was honestly
quite baffling. This seems like a saner variant.
2024-07-24 12:15:12 +02:00
Dean Herbert
6e4625609d
Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard
...
Fill daily challenge top 50 position numbers client-side
2024-07-24 17:49:51 +09:00
Bartłomiej Dach
788b70469d
Exit daily challenge screen when going offline
...
This sort of thing is bound to happen when rewriting screens from
scratch without invoking abstract eldritch entities sometimes. Damned if
you do, damned if you don't...
2024-07-24 09:15:32 +02:00
Bartłomiej Dach
bf4bf4d39e
Fill daily challenge top 50 position numbers client-side
...
Only doing this client-side, because doing this server-side is
expensive:
https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285
2024-07-24 08:57:11 +02:00
Dean Herbert
aded31bd07
Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt
...
Respect pre-empt time when auto-generating breaks
2024-07-24 15:21:12 +09:00
Dean Herbert
aed7ba9508
Change order of application to avoid bias to side with more room to drag
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-07-23 20:56:21 +09:00
Bartłomiej Dach
c3062f96ee
Fix autogenerated breaks not invalidating on change to pre-empt time
2024-07-23 13:38:50 +02:00
Bartłomiej Dach
088e8ad0a2
Respect pre-empt time when auto-generating breaks
...
Closes https://github.com/ppy/osu/issues/28703 .
2024-07-23 13:30:13 +02:00
Dean Herbert
cc4ed0ff3f
Use non-screen-space coordinates and add time-based drag ramping for better control
2024-07-23 18:59:22 +09:00
Bartłomiej Dach
38fc6f70f6
Add tolerance when drag-scrolling editor timeline
...
Closes https://github.com/ppy/osu/issues/28983 .
While the direct cause of this is most likely mouse confine in
full-screen, it shouldn't/can't really be disabled just for this,
and I also get this on linux in *windowed* mode.
In checking other apps, adding some tolerance to this sort of
drag-scroll behaviour seems like a sane UX improvement anyways.
2024-07-23 11:10:18 +02:00
Bartłomiej Dach
dd8be62d07
Merge pull request #28849 from frenzibyte/custom-profile-colour
...
Add custom hue support to user profile overlay
2024-07-22 09:41:32 +02:00
Layendan
6a4872faa8
Remove nullable disable
2024-07-21 23:56:47 -07:00
Layendan
6bb562db14
Fix collection popover
2024-07-22 12:22:52 +09:00
Layendan
e4cccb5e31
Fix lint errors
2024-07-22 12:22:52 +09:00
Layendan
a575566638
Add tests
2024-07-22 12:22:51 +09:00
Layendan
c16b7c5c70
Update favorite button
2024-07-22 12:22:51 +09:00
Layendan
3296beb003
Added collection button to result screen
2024-07-22 12:22:50 +09:00
Salman Ahmed
818b60a3d8
Fix pause overlay hiding input from ruleset input manager
...
If a key is pressed while the pause overlay is visible, the ruleset input manager will not see it, therefore if the user resumes while the key is held then releases the key, the ruleset input manager will not receive the key up event.
2024-07-19 18:48:35 +03:00
Salman Ahmed
d7651ef387
Add extensive test cases for correct input handling while paused in osu! & non-osu!
2024-07-19 18:48:35 +03:00
Bartłomiej Dach
27000aa8ed
Merge branch 'master' into editor-blah
2024-07-19 13:42:40 +02:00
Dan Balasescu
ad564f31cb
Merge pull request #28947 from peppy/fix-playlist-item-panel
...
Fix various visuals of playlist beatmap panels
2024-07-19 20:12:40 +09:00
Dean Herbert
c2cc85e6f0
Use purple again for kiai time specifically
2024-07-19 19:59:38 +09:00
Dean Herbert
c4de2bbb60
Ignore "too many ticks" in timeline (triggers in normal cases)
2024-07-19 19:57:47 +09:00
Dean Herbert
5ee645ac8f
Increase opacity of control points slightly
2024-07-19 19:50:21 +09:00
Dean Herbert
d9297438ba
Merge pull request #28900 from smoogipoo/fix-more-tests
...
Fix more test failures
2024-07-19 19:38:52 +09:00
Dean Herbert
f11f01f9b7
Fix various visuals of playlist beatmap panels
...
Supersedes https://github.com/ppy/osu/pull/28907 .
- Fix border being fat
- Fix thumbnail not masking correctly
- Fix background layer not being correctly fit to the panel
- Dim the main background on hover
- Minor tweaks to dimming
2024-07-19 19:26:04 +09:00
Dan Balasescu
5af39aad00
Add beatmap name to log string
...
Makes it easy to compare this line versus the one in
OsuGame.PresentBeatmap(). At the moment it's just GUID which is... not
useful!
2024-07-19 19:02:41 +09:00
Dean Herbert
0f29ed618a
Don't attempt to clear the carousel during realm blocking operation
2024-07-19 17:39:47 +09:00
Dean Herbert
0560214d5b
Fix beatmap carousel performance regression with large databases
2024-07-19 17:39:47 +09:00
Bartłomiej Dach
4dd225fdc8
Fix compose blueprint container not unsubscribing from event
...
Closes https://github.com/ppy/osu/issues/28938 .
This is related to reloading the composer on timing point changes in
scrolling rulesets. The lack of unsubscription from this would cause
blueprints to be created for disposed composers via the
`hitObjectAdded()` flow.
The following line looks as if a sync load should be forced on a newly
created placement blueprint:
da4d37c4ad/osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs (L364)
2024-07-19 08:32:36 +02:00
Salman Ahmed
a570949459
Fix selection box initialy visible despite no items selected
2024-07-19 03:00:44 +03:00
Salman Ahmed
d61a72b8fb
Explicitly define Hue rather than implicitly provide it by enum value
2024-07-18 00:26:24 +03:00
Layendan
0bc14ba646
Add favourite button to results screen
2024-07-17 12:45:20 -07:00
Bartłomiej Dach
4c1f902969
Do not allow working beatmap to switch to protected beatmap in song select
...
Principal fix to https://github.com/ppy/osu/issues/28880 .
2024-07-17 11:46:19 +02:00
Bartłomiej Dach
ad2db3f853
Merge pull request #28882 from peppy/update-framework
...
Update framework
2024-07-16 12:28:51 +02:00
Dean Herbert
f1325386f0
Fix summary timeline timing points having x position applied twice
2024-07-16 18:32:54 +09:00
Dean Herbert
4ad7d900c1
Fix incorrect editor screen padding
2024-07-16 18:20:33 +09:00
Dean Herbert
1083e71ce6
Fix potential crash when exiting daily challenge screen
...
Without the schedule this will potentially run after disposal of the
local drawable hierarchy.
Closes https://github.com/ppy/osu/issues/28875 .
2024-07-16 03:02:04 +09:00
Dean Herbert
eb3f480a2a
Merge pull request #28683 from frenzibyte/footer-v2-integration
...
Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`
2024-07-12 22:45:06 +09:00
Dean Herbert
e8f7213b3b
Move logo depth to a forward passing
2024-07-12 22:01:20 +09:00
Bartłomiej Dach
217b01d303
Apply tooltip to bookmark pieces too
...
Bookmarks don't show on real beatmaps, but they do show in test scenes
(namely `TestSceneEditorSummaryTimeline`).
Also does some more changes to adjust the markers to the latest updates
to other markers.
2024-07-12 11:12:20 +02:00
Dean Herbert
2453e2fd00
Fix nullability issue
2024-07-12 18:11:23 +09:00
Bartłomiej Dach
5e00995948
Merge branch 'master' into tooltips
2024-07-12 11:01:03 +02:00
Bartłomiej Dach
518dc17518
Merge pull request #28788 from bdach/timeline-redesign
...
Redesign editor timelines to address most frequent user complaints
2024-07-12 10:58:59 +02:00
Dean Herbert
4be5d056c5
Reduce opacity of centre marker slightly
2024-07-12 17:23:48 +09:00
Dean Herbert
d2cb07b157
Add a bit more padding between node overlays and hitobjects in timeline
2024-07-12 17:22:36 +09:00
Dean Herbert
2454722601
Add tooltips to summary timeline display
2024-07-12 16:39:41 +09:00
Dean Herbert
275e7aa451
Adjust timeline centre marker visuals and bring in front of ticks
2024-07-12 16:37:03 +09:00
Dean Herbert
ca2fc72959
Adjust timeline centre marker visuals and bring in front of ticks
2024-07-12 16:29:40 +09:00
Dean Herbert
f65ab6736d
Adjust breaks in timeline to be centered with waveform / hitobjects
2024-07-12 15:45:58 +09:00
Dean Herbert
2ad2ae0c16
Add slight offset for timeline BPM display to avoid overlaps
2024-07-12 14:34:01 +09:00
Dean Herbert
9a7a0cdb34
Adjust timeline ticks to add a bit more body back
2024-07-12 14:29:18 +09:00
Dean Herbert
685b19a571
Adjust various visuals of summary timeline in a hope for user acceptance
...
.. with a somewhat appealing design.
2024-07-12 13:57:42 +09:00
Dean Herbert
fb4f620c90
Add back BPM and adjust sizing of bottom bar a bit more
2024-07-12 12:34:43 +09:00
Salman Ahmed
d4a4a059d4
Fix footer content not accessible by overlay when overriden by a subclass
2024-07-11 15:31:02 +03:00
Bartłomiej Dach
ccc4d288b2
Merge pull request #28821 from peppy/fix-editor-dim
...
Fix editor UI transparency being incorrectly opaque when hovering slider control points
2024-07-11 12:05:10 +02:00
Dean Herbert
95464ebf36
Merge branch 'master' into timeline-redesign
2024-07-11 18:38:17 +09:00
Bartłomiej Dach
6801ccbbc5
Fix editor UI remaining transparent when switching away from compose tab
...
Could still happen if using the keyboard F-key shortcuts. In that case
the composer becomes non-present, so its `Update()` can't really do
anything.
2024-07-11 11:23:09 +02:00
Bartłomiej Dach
f1fa34e5d5
Merge pull request #28800 from peppy/file-mounting-v3
...
Add ability to edit beatmap content externally
2024-07-11 10:47:36 +02:00
Dean Herbert
c139478aa2
Merge pull request #28805 from frenzibyte/select-all-on-focus
...
Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general)
2024-07-11 17:33:30 +09:00
Dean Herbert
7b0c1e3498
Also apply to timing textboxes
2024-07-11 16:54:27 +09:00
Bartłomiej Dach
cc0d7e9981
Add error logging on failure to begin/end external edit
2024-07-11 09:54:12 +02:00
Bartłomiej Dach
ac467cf73a
Set locally modified state for all externally modified beatmap(sets) that could not be mapped to online
2024-07-11 09:44:33 +02:00
Dean Herbert
fe421edd8f
Fix editor UI transparency being incorrectly opaque when hovering slider control points
...
As mentioned at
https://github.com/ppy/osu/pull/28787#issuecomment-2221150025 .
2024-07-11 16:41:21 +09:00
Dean Herbert
b5bb94e4ec
Merge branch 'master' into file-mounting-v3
2024-07-11 15:54:54 +09:00
Dan Balasescu
00cab0ec0a
Merge pull request #28809 from bdach/mania-timeline-zooms-composer
...
Match mania editor playfield time range with timeline zoom
2024-07-11 15:41:26 +09:00
Dean Herbert
bdbdc3592e
Move full export async flow inside screen and add error handling
2024-07-11 14:27:12 +09:00
Dean Herbert
599a765fd1
Add confirmation before saving for external edit
2024-07-11 12:20:33 +09:00
Dean Herbert
cd6b0e875a
Simplify save dialogs
2024-07-11 12:15:17 +09:00
Dean Herbert
b0d6c8ca6d
Abort operation on save failure
2024-07-11 11:42:06 +09:00
Bartłomiej Dach
4901fece26
Merge branch 'master' into fix-dialog-overflow
2024-07-10 18:20:18 +02:00
Bartłomiej Dach
55b4dd9b99
Adjust punctuation
2024-07-10 18:17:10 +02:00
Bartłomiej Dach
92dc125d39
Match mania editor playfield time range with timeline zoom
2024-07-10 17:36:39 +02:00
Dean Herbert
b58ba5f5f1
Just give in to silly code quality inspection
2024-07-10 23:02:19 +09:00
Salman Ahmed
bb9a2b705e
Remove unnecessary math min
2024-07-10 16:29:28 +03:00
Salman Ahmed
7d667ac46b
Fix confirm exit dialog overflowing from too many ongoing operations
2024-07-10 16:06:53 +03:00
Bartłomiej Dach
c8a64c5950
Remove setup screen controls that do nothing useful
...
Before I go with a hammer to redesign these, I want to remove stuff that
does nothing first.
Hard-breaks API to allow rulesets to specify an enumerable of custom
sections rather than two specific weird ones.
For specific rulesets:
- osu!:
- Stack leniency slider merged into difficulty section.
- osu!taiko:
- Approach rate and circle size sliders removed.
- Colours section removed.
- osu!catch:
- No functional changes.
- osu!mania:
- Special style toggle merged into difficulty section.
- Colours section removed.
2024-07-10 14:53:16 +02:00
Salman Ahmed
ce93455aa8
Extend behaviour to sample edit popover
2024-07-10 15:16:10 +03:00
Dean Herbert
b6741ee4ea
Fix back-to-front exit blocking conditionals
2024-07-10 20:00:34 +09:00
Dean Herbert
75344f9c5c
Fix break overlay progress bar becoming a pancake near end of break
2024-07-10 19:28:37 +09:00
Dean Herbert
1381b3c0c5
Merge pull request #28801 from bdach/break-generation-caching
...
Improve performance of automatic break regeneration
2024-07-10 19:21:16 +09:00
Bartłomiej Dach
b881c25b17
Pool summary timeline break visualisations to reduce allocations
2024-07-10 11:42:28 +02:00
Bartłomiej Dach
343090e3b1
Do not regenerate breaks unless meaningful change to object start/end times is detected
...
Tangentially found when profiling https://github.com/ppy/osu/pull/28792 .
For reproduction, import https://osu.ppy.sh/beatmapsets/972#osu/9007 ,
move any object on the playfield, and observe a half-second freeze
when ending the drag.
2024-07-10 11:42:25 +02:00
Dean Herbert
aa16c72e06
Add test coverage of external editing
2024-07-10 18:34:47 +09:00
Dean Herbert
3beca64cc5
Attempt to stay on correct difficulty
2024-07-10 18:34:46 +09:00
Dean Herbert
27ab54882b
Add loading segments and tidy things up
2024-07-10 18:34:46 +09:00
Dean Herbert
74aa05fa6e
Improve UX and styling of external edit screen
2024-07-10 18:34:45 +09:00
Dean Herbert
118162c631
Add sub screen to limit user interactions
2024-07-10 18:34:45 +09:00
Dean Herbert
d3c66e2404
Add basic flow for mounting beatmaps for external editing
2024-07-10 18:29:51 +09:00
Salman Ahmed
337f05f9a4
Fix loading (but not showing) a sheared overlay hiding displayed footer content
...
Identified by tests. See https://github.com/ppy/osu/actions/runs/9869382635/job/27253010485 & https://github.com/ppy/osu/actions/runs/9869382635/job/27253009622 .
This change also prevents the initial `PopOut` call in overlays from calling `clearActiveOverlayContainer`, since it's not in the update thread and it's never meant to be called at that point anyway (it's supposed to be accompanied by a previous `PopIn` call adding the footer content).
2024-07-10 11:56:35 +03:00
Salman Ahmed
002679ebb0
Ask for VisibilityContainer explicitly
2024-07-10 11:14:22 +03:00
Bartłomiej Dach
95783bd6c2
Merge pull request #28789 from peppy/fix-deletes-reappearing
...
Fix deleted beatmap sets potentially reappearing due to pending update requests
2024-07-10 09:14:10 +02:00
Dean Herbert
9a88281ab0
Merge branch 'master' into footer-v2-integration
2024-07-10 15:33:05 +09:00
Dean Herbert
4fe3f39d22
Merge pull request #28682 from frenzibyte/footer-v2-overlay-content
...
Add implementation for `ScreenFooter` to house footer content of sheared overlays
2024-07-10 15:08:00 +09:00
Dean Herbert
cd9973b6f9
Merge pull request #28740 from bdach/daily-challenge/better-results
...
Improve results displays in daily challenge screen
2024-07-10 14:17:21 +09:00
Dean Herbert
f281019358
Rename method to match provided argument
2024-07-10 14:00:15 +09:00
Joseph Madamba
8c81ba3357
Fix preview track persisting to play after leaving multi/playlists room
2024-07-09 14:36:24 -07:00
