Piggey
f5d85f5774
make ExportStorage protected
2022-11-30 10:51:42 +01:00
Dean Herbert
5ce2d6f54a
Hide the game mouse cursor when playing osu!catch with relax mod
2022-11-30 18:13:53 +09:00
Dean Herbert
bb0237d4a9
Fix nullability inspection on disposal path
2022-11-30 17:49:08 +09:00
Dean Herbert
4215f4f5d7
Merge branch 'master' into Editor-DrawableRuleset-Dependencies
2022-11-30 17:42:46 +09:00
Dean Herbert
b1ce93e7bf
Add fallback stable sort to avoid any change of misordered local messages
2022-11-30 16:55:39 +09:00
Dean Herbert
f7b7b58718
Adjust colour and tween to feel better
2022-11-30 16:20:01 +09:00
Dean Herbert
24ee363563
Only hover when hovering actual text
2022-11-30 16:18:36 +09:00
Dean Herbert
80b0e4a99d
Rename Colour to avoid conflict with Drawable.Colour
2022-11-30 16:15:50 +09:00
Dean Herbert
7fca5ee28d
Move DrawableUsername into own file
...
It's too large at this point to be a nested class.
2022-11-30 16:15:50 +09:00
Dean Herbert
9ab4664fcc
Merge branch 'master' into chat-profile-highlight-v2
2022-11-30 16:15:48 +09:00
Dean Herbert
b7f0310070
Merge pull request #21353 from peppy/no-initial-presence
...
Stop requesting messages as part of initial chat presence
2022-11-30 16:15:23 +09:00
Dean Herbert
6524914dbd
Merge branch 'master' into chat-profile-highlight-v2
2022-11-30 16:00:52 +09:00
Dean Herbert
78f70dae75
Merge pull request #21420 from cdwcgt/NowPlaying
...
Show mods, ruleset and unicode metadata in "now playing" chat command
2022-11-30 15:57:52 +09:00
Dean Herbert
2d8854cbac
Change message comparator to always use timestamp comparison if either message has a missing Id
2022-11-30 15:46:58 +09:00
Dean Herbert
9e34fe360a
Ensure all LocalMessages get a timestamp
2022-11-30 15:46:36 +09:00
Dean Herbert
c84f011bb7
Improve ToString output of Message
2022-11-30 15:46:14 +09:00
Dean Herbert
b29054d30d
Merge pull request #21434 from jai-x/control-point-scroll-into-view
...
Ensure currently selected control point will scroll into view
2022-11-30 15:14:14 +09:00
Dean Herbert
d5301c75c1
Merge pull request #21460 from EVAST9919/triangles-v2-remove-texture
...
Remove texture usage in TrianglesV2 component
2022-11-30 15:13:08 +09:00
Dean Herbert
8bf5d6884d
Add ruleset to now playing string
2022-11-30 14:47:16 +09:00
Dean Herbert
b453eecebe
Ensure empty pieces do not result in whitespace between elements
2022-11-30 14:43:21 +09:00
Dean Herbert
2df6ccf33e
Tidy up code
2022-11-30 14:31:54 +09:00
Dean Herbert
b5c514a8f0
Make incoming Channel target non-nullable
2022-11-30 14:30:20 +09:00
Dean Herbert
69bf0df179
Merge branch 'master' into NowPlaying
2022-11-30 14:27:37 +09:00
Dean Herbert
2a3b24d058
Avoid need for implicit null casting
2022-11-30 14:21:04 +09:00
Dean Herbert
0659c84341
Rename method to be more in line with project naming
2022-11-30 14:17:49 +09:00
Dean Herbert
63ba40ff39
Merge branch 'master' into control-point-scroll-into-view
2022-11-30 14:12:19 +09:00
Dan Balasescu
fcd7c27bc2
Merge pull request #21451 from peppy/update-framework
...
Update framework
2022-11-30 13:39:08 +09:00
Dan Balasescu
3f4d8b39ca
Update package again
2022-11-30 12:55:45 +09:00
Andrei Zavatski
2eaefcad30
Remove unused renderer
2022-11-30 04:56:07 +03:00
Andrei Zavatski
3b13ca1167
Remove texture from TrianglesV2
2022-11-30 04:09:46 +03:00
Jai Sharma
7dbf379351
Don't use verbatim string literals
2022-11-29 18:22:07 +00:00
Dean Herbert
08a403cb33
Merge pull request #21428 from mk56-spn/RangeSlider_implementation
...
Refactor star "DifficultyRangeFilterControl" into generic range slider
2022-11-29 16:08:13 +09:00
Dean Herbert
56a694fb04
Add automated test coverage of simple scenarios for RangeSlider
2022-11-29 15:10:21 +09:00
Dean Herbert
61c702c02e
Add new IDependencyInjectionCandidate interface to non-drawable cached classes
2022-11-29 14:45:26 +09:00
Dean Herbert
b5b79e09e4
Remove unnecessary CQ disable
2022-11-29 14:45:08 +09:00
Bartłomiej Dach
8f78d6179b
Fix multiple issues with settings items unhiding on search
2022-11-29 14:41:49 +09:00
Bartłomiej Dach
24deb5f5f4
Remove all unnecessary usage of IHasFilterableChildren
2022-11-29 14:40:52 +09:00
Dean Herbert
96e19d4d84
Update framework
2022-11-29 14:36:23 +09:00
Dan Balasescu
198303513b
Merge pull request #21450 from Feodor0090/comments-btns-loc
...
Add missing localization in `DrawableComment`
2022-11-29 13:47:46 +09:00
ansel
16962d9a57
Localize deleted string
2022-11-29 07:02:02 +03:00
ansel
a4819e5c9c
Localize actions
2022-11-29 07:01:52 +03:00
Alden Wu
8ec4dd046e
Fix InspectCode errors
2022-11-28 18:06:44 -08:00
Alden Wu
0cb7c94c21
Merge branch 'master' of https://github.com/ppy/osu into chat-profile-highlight-v2
2022-11-28 17:59:15 -08:00
Alden Wu
c2d8ffc225
Refactor ChatLine username drawable creation
2022-11-28 17:50:12 -08:00
Andrei Zavatski
3e277a92e9
Fix incorrect texel size calculation
2022-11-29 03:21:59 +03:00
Andrei Zavatski
ba1717c2ca
Don't draw 0 thickness triangles
2022-11-29 02:36:27 +03:00
Derrick Timmermans
93ba84e5ff
Fix code style
2022-11-27 21:48:44 +01:00
Derrick Timmermans
70c320b2e8
Provide ruleset dependencies only to Compose Placement Blueprints
2022-11-27 21:43:33 +01:00
Derrick Timmermans
cff3e06ad6
Update state based on result during LoadComplete
2022-11-27 20:57:00 +01:00
mk56-spn
db7f429e39
Fix partial class issues and adjust test slightly
2022-11-27 10:44:05 +01:00
mk56-spn
0aba119056
Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation
...
# Conflicts:
# osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs
# osu.Game/Screens/Select/DifficultyRangeFilterControl.cs
2022-11-27 10:40:29 +01:00
Jai Sharma
218c04c174
Code quality
2022-11-27 03:23:08 +00:00
Jai Sharma
6000e14668
Correctly select issue row
2022-11-27 03:08:54 +00:00
Jai Sharma
3c56b9c93a
Add OnRowSelected event to EditorTable
2022-11-27 02:47:54 +00:00
Jai Sharma
792334a190
Move Control Group timing data into it's own component
2022-11-27 02:47:02 +00:00
Jai Sharma
b6d7bec240
Remove #nullable disabled from EditorTable and it's derived classes
2022-11-27 02:45:56 +00:00
Jai Sharma
1a914d0df7
Remove #nullable disable from TimingScreen
2022-11-27 02:43:22 +00:00
cdwcgt
e16f8a4410
Merge branch 'master' into NowPlaying
2022-11-27 08:48:49 +08:00
cdwcgt
02e3ebe1a0
DifficultyIncrease use + and other all -
...
mod.Name to mod.Acronym
2022-11-27 09:44:09 +09:00
cdwcgt
653875bbb4
only post mod when ingame
2022-11-27 09:41:41 +09:00
cdwcgt
8ecb4aa30b
better method name
2022-11-27 09:41:08 +09:00
Bartłomiej Dach
fd16e5992b
Merge branch 'master' into triangles-fix
2022-11-26 19:28:55 +01:00
Dean Herbert
d1eedd081c
Update resources
2022-11-27 02:46:11 +09:00
Andrei Zavatski
7ab5136e12
Compute texel size in the DrawNode
2022-11-26 20:05:34 +03:00
Bartłomiej Dach
c42720acd4
Temporarily disable "partial class with one part" inspection
2022-11-26 18:05:08 +01:00
Bartłomiej Dach
212d78865a
Add a few more missing partial specs
2022-11-26 16:30:52 +01:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework
2022-11-26 16:19:36 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
a1c559ae05
Update framework
2022-11-27 00:00:12 +09:00
mk56-spn
92ed2ed4ef
Refactor star "DifficultyRangeFilterControl" into generic range slider class
2022-11-26 12:19:08 +01:00
Bartłomiej Dach
ca0597b38e
Merge branch 'master' into dont-change-ruleset-convert
2022-11-25 19:23:36 +01:00
Bartłomiej Dach
73176a1315
Merge branch 'master' into triangle-button-v2
2022-11-25 18:35:59 +01:00
Bartłomiej Dach
bbbc1d0428
Darken colour of playlists create button
...
To match d0c4637683
2022-11-25 18:23:28 +01:00
cdwcgt
13f86f3e53
Merge branch 'master' into NowPlaying
2022-11-25 23:22:52 +09:00
cdwcgt
a2ea7a3f58
show selected mod and use ILocalisedBindableString in np
2022-11-25 23:20:44 +09:00
Dean Herbert
5ada9efa60
Update outdated comment regarding colour choices
2022-11-25 22:10:20 +09:00
Dean Herbert
76e9382e0b
Fix triangles showing on ExpandableButtons when in contracted state
2022-11-25 20:18:35 +09:00
Dean Herbert
d0c4637683
Lighten colour of multiplayer create game button
2022-11-25 20:18:21 +09:00
Dean Herbert
b0f14d4963
Clamp AimCount to ensure at least one triangle is spawned
2022-11-25 20:14:21 +09:00
Dean Herbert
4cb068ceb9
Change AimCount to not consider height
2022-11-25 20:10:04 +09:00
Dean Herbert
25410c9962
Avoid changing ruleset when presenting a beatmap if it can be converted
...
Closes #21415 .
2022-11-25 19:48:01 +09:00
Derrick Timmermans
65e5c9a3ae
Dispose DrawableRulesetDependencies in HitObjectComposer
2022-11-25 08:27:22 +01:00
Bartłomiej Dach
fca3e7e39f
Merge branch 'master' into editor-seek-control-points
2022-11-24 21:53:47 +01:00
Dean Herbert
f6e229c24d
"Fix" mod copy failure
2022-11-25 01:15:11 +09:00
Dean Herbert
2b2beadd06
Merge branch 'master' into update-framework
2022-11-25 01:00:08 +09:00
Derrick Timmermans
7b620392fe
Provide DrawableRulesetDependencies from HitObjectComposer
2022-11-24 13:13:45 +01:00
Dean Herbert
6ad432b311
Use RoundedButton in more places
2022-11-24 16:33:01 +09:00
Dean Herbert
53b03df93d
Combine TriangleButton and RoundedButton classes
2022-11-24 16:26:57 +09:00
Dean Herbert
bea2acc60e
Remove local specifications of triangle colouring
2022-11-24 16:18:15 +09:00
Dean Herbert
4fbca4037c
Update existing triangle buttons to use RoundedButton
2022-11-24 16:18:15 +09:00
Dean Herbert
40f706155f
Update RoundedButton to have new triangles design
2022-11-24 16:18:15 +09:00
Dean Herbert
44a71741e4
Merge pull request #21225 from EVAST9919/triangles-v2
...
Implement TrianglesV2 component
2022-11-24 16:15:25 +09:00
Dean Herbert
8914a871c1
Merge pull request #21065 from C0D3-M4513R/beatmap-info
...
Add Beatmap Information elements
2022-11-24 15:22:04 +09:00
Dean Herbert
2e277ef40a
Update resources
2022-11-24 15:18:49 +09:00
Dean Herbert
a2438428a2
Move base call to end
2022-11-24 13:57:43 +09:00
Dean Herbert
37f725bfa2
Reverse directionality of up/down traversal keys to match scroll
2022-11-24 13:55:58 +09:00
C0D3 M4513R
4b44f31b5e
Use LocaliseableStings in BeatmapAttributeText
2022-11-23 21:02:43 +01:00
Bartłomiej Dach
2f67199b1c
Merge branch 'master' into fix-missing-day-separator
2022-11-23 18:40:44 +01:00
Bartłomiej Dach
60422be9af
Merge branch 'master' into fix-editor-tap-timing-crash
2022-11-23 17:51:50 +01:00
Dean Herbert
b381b4fd2d
Merge branch 'master' into update-framework
2022-11-24 01:27:58 +09:00
Dean Herbert
3acf15c7b8
Update framework
2022-11-24 01:26:49 +09:00
Bartłomiej Dach
30f9cc46a7
Protect offset and bpm adjustments from null selection too
2022-11-23 17:25:43 +01:00
Bartłomiej Dach
508f1f488c
Merge branch 'master' into limit-barline-generation-sanity
2022-11-23 17:12:36 +01:00
Dean Herbert
5467097387
Fix adjacent day separators potentially being left behind after pending message resolution
2022-11-23 18:49:51 +09:00
Dean Herbert
f9d952220f
Fix barlines being misaligned if generation start time is clamped
2022-11-23 18:12:03 +09:00
Dean Herbert
774f70e380
Simplify class structure
2022-11-23 16:56:40 +09:00
Dean Herbert
0749a7bb07
Simplify attribute assignment
2022-11-23 16:53:36 +09:00
Dean Herbert
0f034606fd
Use LocalisableDescription from BeatmapOnlineStatus enum instead of locally defined
2022-11-23 16:49:51 +09:00
Dean Herbert
a8af83e62a
Move label initialisation out of ctor
2022-11-23 16:49:39 +09:00
Dean Herbert
27473262af
Rename attributes in enum to match better with user expectations
2022-11-23 16:45:46 +09:00
Dean Herbert
b89689a34a
Rename class and reword settings text/tooltips to avoid clashing with other naming
2022-11-23 16:31:50 +09:00
Dean Herbert
a9192c32ea
Merge branch 'master' into beatmap-info
2022-11-23 16:10:12 +09:00
Dean Herbert
9b9b8a5977
Add ability to seek between control points in editor using down/up arrows
...
Matches stable. Addresses #21376 .
2022-11-23 15:59:32 +09:00
Dean Herbert
d146f86511
Fix crash when hitting 'T' to tap timing while no timing point is selected
2022-11-23 15:39:56 +09:00
Dean Herbert
172e798847
Merge pull request #21228 from Terochi/recent-messages-implementation
...
Add ability to view chat send history in input box
2022-11-23 14:58:42 +09:00
Bartłomiej Dach
8dbc38e17a
Remove unused setter
2022-11-22 20:14:22 +01:00
Bartłomiej Dach
76bb529cfa
Add test for local echo adding day separator
2022-11-22 16:46:21 +01:00
Dean Herbert
de163b2bb5
Change song select to only allow volume adjusting if alt is held while scrolling
2022-11-22 19:48:55 +09:00
Alden Wu
a2b505f4c0
Use a direct Lighten instead of >1f Color4 values
2022-11-22 00:31:22 -08:00
Dean Herbert
1632df1f4d
Update DifficultyBindable to match new bindable spec
2022-11-22 14:51:19 +09:00
Dan Balasescu
985781bc3b
Merge pull request #21356 from peppy/standardise-broken-storyboard-paths
...
Add support for storyboards with incorrect path specifications (`\\` instead of `\`)
2022-11-22 14:33:51 +09:00
Alden Wu
4084a2b066
Highlight ChatLine username on hover
2022-11-21 18:57:59 -08:00
Bartłomiej Dach
8dbe31a172
Merge branch 'master' into higher-aspect-ratio-max
2022-11-21 19:51:39 +01:00
Bartłomiej Dach
c0f65d83b3
Merge branch 'master' into hide-no-spin-bonus
2022-11-21 19:14:54 +01:00
Bartłomiej Dach
206aece77b
Merge branch 'master' into avoid-null-audio-device-name-crahs
2022-11-21 16:37:13 +01:00
Bartłomiej Dach
7944d9cefa
Merge pull request #21304 from EVAST9919/beatmap-bar
...
Rework BarGraph to use Quads
2022-11-21 16:24:18 +01:00
Terochi
d81ef541bc
Variant 5: cannot change history, edit resets index
2022-11-21 10:17:28 +01:00
Terochi
7dc7729ac2
Variant 4: cannot change history, empty text/everything selected resets index (current with bug fix)
2022-11-21 10:11:26 +01:00
C0D3 M4513R
93ab1c9432
Merge branch 'master' into beatmap-info
2022-11-21 09:01:24 +00:00
Terochi
58288275a6
Variant 3: cannot change history, cannot reset index (the "default")
2022-11-21 09:43:36 +01:00
Terochi
672e1cd45b
Variant 2: edit changes history, cannot reset index (similar to stable)
2022-11-21 09:41:29 +01:00
Terochi
8f942f130b
Variant 1: edit changes history, empty text resets index
2022-11-21 09:36:31 +01:00
Andrei Zavatski
ec8532951c
Make Thickness property auto
2022-11-21 10:32:19 +03:00
Dean Herbert
2774c1ea49
Merge pull request #21215 from jai-x/triangles-bundled-beatmap
...
Add winner of Triangles mapping competition as a bundled beatmap
2022-11-21 16:22:23 +09:00
Andrei Zavatski
14a4de36f4
Expose thickness property
2022-11-21 10:20:35 +03:00
Dean Herbert
3da21e596a
Add support for storyboards with incorrect path specifications (\\ instead of \)
...
Closes https://github.com/ppy/osu/issues/21204 .
2022-11-21 16:12:01 +09:00
Dean Herbert
462a213ffc
Add TODO note about handling initial silences
2022-11-21 15:23:04 +09:00
Dean Herbert
efd73ea9da
Rename method to suit better
2022-11-21 15:22:57 +09:00
Dean Herbert
5c640d15a0
Stop requesting messages as part of initial chat presence
2022-11-21 15:17:54 +09:00
Dean Herbert
9a330c3cdb
Apply nullability and clean up conditionals
2022-11-21 15:02:45 +09:00
Dean Herbert
a07b033d22
Merge branch 'master' into triangles-v2
2022-11-21 14:55:01 +09:00
Dean Herbert
981264b011
Avoid crashing when a system audio device provides a null name
2022-11-21 14:51:41 +09:00
Dean Herbert
40f2da364c
Limit how far before the first hitobject that barlines can be generated
2022-11-21 14:40:25 +09:00
Dean Herbert
93a189603a
Hide spinner ticks / bonus from results screen when not applicable to score
2022-11-21 14:20:36 +09:00
Dean Herbert
4a79141824
Merge pull request #21338 from RATCM/fix-leaderboard-filter
...
Match leaderboard filter behaviour to web
2022-11-21 14:01:55 +09:00
Dean Herbert
e53b4321ff
Ensure two day separators are not added in a row
2022-11-21 14:01:10 +09:00
Dean Herbert
fa7b45dfb1
Fix chat day separator not being added on pending message resolution
...
Closes #21316 .
2022-11-21 13:52:14 +09:00
Dean Herbert
dfa92b3de9
Merge pull request #21326 from bdach/fix-phantom-beatmap-sets
...
Fix phantom beatmap sets appearing on carousel after delete/update
2022-11-21 13:25:14 +09:00
Dean Herbert
c7ae837687
Increase maximum aspect ratio for tablet settings to 23:9 / 2.55
2022-11-21 12:45:54 +09:00
Dean Herbert
92aea22cd3
Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup
...
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-21 12:16:56 +09:00
vegguid
a431b793b9
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-20 23:18:19 +01:00
Andrei Zavatski
18c79dfda3
Move all the logic into BarsInfo class
2022-11-20 23:00:13 +03:00
RATCM
f5fbb7c8de
Changed comments
2022-11-20 19:27:40 +01:00
RATCM
d20a357c0e
Fixed ordering bug
2022-11-20 19:24:51 +01:00
RATCM
9040dfbd4e
Match leaderboard filter behaviour to web
2022-11-20 17:39:46 +01:00
Bartłomiej Dach
1269afd0c5
Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu
...
Hide scroll speed control from effects section on rulesets which don't support it
2022-11-20 16:17:55 +01:00
Bartłomiej Dach
0f382590e6
Remove unnecessary #nullable disable
2022-11-20 15:31:51 +01:00
Bartłomiej Dach
33b2fe46d9
Add xmldoc to HistoryTextBox
2022-11-20 12:29:47 +01:00
Bartłomiej Dach
7b274083d3
Fix phantom beatmap sets appearing on carousel after delete/update
...
Regressed in c40c70509e
2022-11-20 10:08:34 +01:00
Andrei Zavatski
36141cb2a4
Make BarsInfo a class
2022-11-20 05:14:07 +03:00
Salman Ahmed
4b0ba86bd0
Identify scrolling rulesets using temporary DrawableRuleset instances
2022-11-20 04:12:52 +03:00
Salman Ahmed
58296bd4f0
Introduce IDrawableScrollingRuleset for editor consumption
2022-11-20 04:11:10 +03:00
Andrei Zavatski
fcb52ee237
Make BarsInfo a readonly struct
2022-11-20 02:28:07 +03:00
Andrei Zavatski
fbfcf49ea6
Remove readonly modifier from struct fields
2022-11-20 02:13:54 +03:00
Andrei Zavatski
2cb966b47c
Rework BarsInfo struct
2022-11-20 01:48:54 +03:00
Andrei Zavatski
6c62cfb830
Store barBreadth as a separate float
2022-11-19 23:40:02 +03:00
Andrei Zavatski
67ee9f3915
Naming adjustments
2022-11-19 23:34:55 +03:00
Andrei Zavatski
f1201454b7
Use value tuples
2022-11-19 23:29:50 +03:00
Andrei Zavatski
6f449a583e
Handle empty values as a separate case
2022-11-19 23:27:48 +03:00
Terochi
eff6c7be64
Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.
2022-11-19 16:53:35 +01:00
Bartłomiej Dach
0c671a2a82
Merge branch 'master' into fix-tablet-aspect-ratio-values
2022-11-19 14:32:24 +01:00
Bartłomiej Dach
c05c1625f2
Merge branch 'master' into editor-test-play-dont-retain-test-time
2022-11-19 12:09:04 +01:00
Salman Ahmed
60c424837b
Merge branch 'master' into disable-scroll-speed-on-osu
2022-11-19 12:13:45 +03:00
Salman Ahmed
2e3af97892
Remove unused using
2022-11-19 12:13:36 +03:00
Andrei Zavatski
0239103b6b
Fix BeatmapOverlay crashing test scene
2022-11-19 11:33:14 +03:00
Andrei Zavatski
05992d3aa8
CI fix
2022-11-19 10:23:37 +03:00
Andrei Zavatski
9b8f98735c
Use struct for bars description
2022-11-19 10:16:58 +03:00
Andrei Zavatski
7d02cbafed
Merge branch 'master' into beatmap-bar
2022-11-19 09:58:10 +03:00
Andrei Zavatski
11f5fddc1f
Remove redundant returns
2022-11-19 09:57:52 +03:00
Dean Herbert
130f776427
Merge pull request #21267 from peppy/catch-file-enumeration-errors
...
Catch and gracefully handle file/directory enumeration failures during stable import
2022-11-19 15:38:40 +09:00
Salman Ahmed
290369db47
Hide scroll speed slider on rulesets which don't support it
2022-11-19 06:42:27 +03:00
Salman Ahmed
016de2f5a0
Fix editor not always playing hitsounds with clock offsets applied
2022-11-19 05:15:22 +03:00
Andrei Zavatski
e8ca9f5dc5
Rework BarGraph to use Quads
2022-11-19 00:22:57 +03:00
Salman Ahmed
1be8c6bd9c
Fix "perform from screen" not considering screen load state
2022-11-18 17:23:10 +03:00
Dawid Sośnia
9ad484a0f4
Merge branch 'ppy:master' into gameplay-leaderboard-fix
2022-11-18 12:11:22 +01:00
Dean Herbert
06ce8130c2
Apply changes in line with framework NRT updates
2022-11-18 18:13:15 +09:00
Dean Herbert
95908ec023
Update framework
2022-11-18 18:13:00 +09:00
Dan Balasescu
e4fc14faee
Merge pull request #21270 from peppy/auto-advance-bindings
...
Auto-advance binding for ruleset key bindings
2022-11-18 16:19:54 +09:00
Dan Balasescu
9d33a6568e
Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding
...
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 16:19:38 +09:00
Dan Balasescu
d8e99d811d
Merge pull request #21293 from frenzibyte/fix-timeline-extent-scrolling
...
Fix timeline potentially scrolling at extents while not dragging
2022-11-18 16:19:30 +09:00
Dean Herbert
d59befc9d3
Fix initial visual state of positions before sort runs
2022-11-18 16:08:27 +09:00
Dean Herbert
aff218dfd5
Redirect through validity function rather than overriding Sort
2022-11-18 16:03:40 +09:00
Dean Herbert
20af8217f4
Tidy up bindable flow
2022-11-18 15:50:41 +09:00
Dean Herbert
e4f522aad1
Fix inspections / typos
2022-11-18 15:47:37 +09:00
Dean Herbert
d17c091d63
Move constant to a better location
2022-11-18 15:47:31 +09:00
Dean Herbert
3faa7f5f74
Merge branch 'master' into gameplay-leaderboard-fix
2022-11-18 15:44:30 +09:00
Salman Ahmed
90cd386323
Fix timeline potentially scrolling at extents while not dragging
2022-11-18 09:43:16 +03:00
Dean Herbert
bab5be8dee
Merge pull request #21290 from smoogipoo/multiplayer-test-debug
...
Add some debugging for multiplayer test failures
2022-11-18 15:39:33 +09:00
Dean Herbert
e658efbefa
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 15:34:41 +09:00
Dan Balasescu
c2a127dc68
Merge pull request #21289 from peppy/fix-triangle-button-flash
...
Fix triangle button flash effect looking incorrect
2022-11-18 15:26:43 +09:00
Dan Balasescu
219d049edf
Merge pull request #21140 from maromalo/long-standard
...
Standardise scores to `long` type
2022-11-18 15:26:33 +09:00
Dan Balasescu
cc434c9113
Merge pull request #21288 from peppy/fix-no-network-slow-gameplay-load
...
Fix entering gameplay while network connection is in a bad state taking too long
2022-11-18 15:24:31 +09:00
Dan Balasescu
7e9d2ecaf5
Merge pull request #21287 from peppy/fix-null-ref-persistent-endpoint-connector
...
Fix potential incorrect connection state resulting in null reference
2022-11-18 15:08:33 +09:00
Dan Balasescu
b0faa009c1
Add some debugging for multiplayer test failures
2022-11-18 14:52:11 +09:00
Dean Herbert
5fc0d45675
Fix triangle button flash effect looking incorrect
2022-11-18 14:30:59 +09:00
Dan Balasescu
57b8495c7a
Merge branch 'master' into long-standard
2022-11-18 14:24:04 +09:00
Dan Balasescu
d47c46d144
Compute raw score in-line
...
Saves on an allocation (though it seems to only be a ValueType so it
shouldn't be a big deal) and a tail-call.
2022-11-18 14:22:28 +09:00
Dean Herbert
964ceddf83
Fix API queue only being flushed once while in a failing state
2022-11-18 14:21:37 +09:00
Dean Herbert
e4d134a820
Reduce time waited on a score submission token from 60 to 30s
2022-11-18 14:07:40 +09:00
Dan Balasescu
1b1fed723d
Merge pull request #21269 from peppy/fix-key-bindings-keyword
...
Move "keybindings" keyword to correct section
2022-11-18 14:05:08 +09:00
Dan Balasescu
551192b413
Refactor a bit for readability
2022-11-18 13:55:37 +09:00
Dean Herbert
a5d22195f2
Fix potential incorrect connection state resulting in null reference
2022-11-18 13:45:46 +09:00
Dean Herbert
1ff1738988
Merge pull request #21244 from nanashi-1/beatmapoptions-disabled
...
Disable certain beatmap option buttons when there are no beatmaps selected
2022-11-18 12:55:07 +09:00
Dan Balasescu
a776622ce0
Merge pull request #21284 from peppy/now-playing-overlay-texture-reduction
...
Fix `NowPlayingOverlay` loading background texture too early (and permanently)
2022-11-18 12:09:16 +09:00
Dan Balasescu
c34dd27674
Merge pull request #21276 from peppy/eager-triangles-disposal
...
Eagerly dispose of triangles intro textures to avoid holding for full length of game session
2022-11-18 11:58:39 +09:00
Dan Balasescu
baa4fd56e2
Merge pull request #21279 from peppy/news-load-unload
...
Fix news post images never unloading from memory after first display
2022-11-18 11:56:13 +09:00
Dan Balasescu
13fe0d3491
Merge pull request #21278 from peppy/overlay-header-texture-reduction
...
Avoid loading overlay headers until first open
2022-11-18 11:53:46 +09:00
Dean Herbert
b53f9baf6a
Fix NowPlayingOverlay loading background texture too early (and permanently)
2022-11-18 11:21:12 +09:00
Dean Herbert
93c2280754
Fix supporter filters text not being set correctly
2022-11-18 10:35:05 +09:00
Dawid Sośnia
0dbf491872
Merge branch 'master' into gameplay-leaderboard-fix
2022-11-17 22:06:51 +01:00
Piggey
eb691266c1
cleanup
2022-11-17 21:50:39 +01:00
Dean Herbert
b37e9c0266
Fix news post images never unloading from memory after first display
2022-11-18 00:01:53 +09:00
Dean Herbert
73e4827d36
Avoid loading overlay headers until first open
...
Also switches them to use non-atlased target as they won't benefit much
from atlasing.
2022-11-17 23:55:43 +09:00
Dean Herbert
63c1855511
Avoid loading beatmap listing placeholders until required
2022-11-17 23:42:21 +09:00
Dean Herbert
a3e8cc1663
Mark beatmap listing placeholder textures as large
2022-11-17 23:41:35 +09:00
Dean Herbert
20d87fbed4
Eagerly dispose of triangles intro textures to avoid holding for full length of game session
2022-11-17 23:05:34 +09:00
Piggey
fa00fc5c6d
change scoresType to be a bindable
2022-11-17 13:27:56 +01:00
Dragon
a25c94d567
Replacing structure to use LimitedCapacityQueue.cs
2022-11-17 13:07:06 +01:00
Dragon
a9747d367c
Cleaning up
2022-11-17 13:07:06 +01:00
Terochi
0100c01b82
Implemented finite limit of stored history.
2022-11-17 13:07:06 +01:00
Terochi
5253f5309e
Added more tests for new features
2022-11-17 13:07:06 +01:00
Terochi
44c3e71746
Reversed indexing
2022-11-17 13:07:06 +01:00
Terochi
3d4962e181
Added functioning tests.
2022-11-17 13:07:06 +01:00
Terochi
6d83af01e2
Moved and renamed MessageHistoryTextBox.cs for better fit.
2022-11-17 13:07:06 +01:00
Dragon
b9590320b7
Moved implementation to ChatRecentTextBox.cs and derived ChatTextBox.cs and StandAloneChatDisplay.cs from it.
2022-11-17 13:07:06 +01:00
Dragon
a1af663682
Implemented previous messages lookup in the ChatTextBox.cs
2022-11-17 13:07:06 +01:00
Piggey
dea2a6ed8d
override sort() function in SoloGameplayLeaderboard
2022-11-17 12:12:36 +01:00
nanashi-1
4773979e52
add condition
2022-11-17 16:15:34 +08:00
Dean Herbert
d1b2116400
Auto-advance binding for ruleset key bindings
2022-11-17 15:23:20 +09:00
Dean Herbert
bd2e0dc82b
Move "keybindings" keyword to correct section
...
Without this, things like tablet settings would show when searching for
bindings, even though these settings have nothing to do with key
bindings.
2022-11-17 15:09:42 +09:00
Dan Balasescu
5ceb7ecc41
Remove unused using
2022-11-17 13:56:27 +09:00
Dean Herbert
1050d7da34
Use more generic exception type (issue reported AggegateException)
2022-11-17 13:36:16 +09:00
Dean Herbert
adab9f0e48
Catch and gracefully handle file/directory enumeration failures during stable import
...
Closes https://github.com/ppy/osu/issues/21214 .
2022-11-17 13:34:42 +09:00
Dean Herbert
a4e713a61f
When returning to the editor after test play, use the original editor time rather than the point of exit
2022-11-17 12:36:24 +09:00
Dean Herbert
bfcd9e0f45
Don't seek to current editor location when location is close to (or before) the first object
2022-11-17 12:32:35 +09:00
Dan Balasescu
bdfc317a8e
Merge pull request #21255 from peppy/fix-full-area-reset
...
Fix "reset to full area" button not always working correctly
2022-11-17 11:13:06 +09:00
Dan Balasescu
b23b5ebce9
Merge pull request #21257 from peppy/fix-test-mode
...
Fix combo colour normalisation setting not applying to editor test play
2022-11-17 10:44:44 +09:00
Salman Ahmed
87b4fee10f
Remove leftover constant
2022-11-17 04:05:21 +03:00
Salman Ahmed
55beaf5d93
Revert buttons order change
2022-11-17 04:05:15 +03:00
Salman Ahmed
039ab83a46
Disable beatmap options button when none selected
2022-11-17 04:00:23 +03:00
Salman Ahmed
0e46614c57
Revert beatmap option button state changes
2022-11-17 03:57:01 +03:00
Salman Ahmed
c1673771eb
Merge branch 'master' into fix-full-area-reset
2022-11-17 01:57:56 +03:00
Salman Ahmed
7a28a7f2a0
Move IGameplaySettings override to compose screen to keep test mode unaffected
2022-11-17 01:45:16 +03:00
Andrei Zavatski
13cf3fc40c
Make SpawnRatio public
2022-11-16 15:17:50 +03:00
Andrei Zavatski
cc4f05f3d3
Replace Scale with SpeedMultiplier
2022-11-16 15:12:57 +03:00
Andrei Zavatski
109aa37dd8
Apply fixes from original Triangles
2022-11-16 15:02:09 +03:00
Andrei Zavatski
d94c624ee4
Merge branch 'master' into triangles-v2
2022-11-16 14:53:32 +03:00
Dean Herbert
ee6fffec5f
Fix combo colour normalisation setting not applying to editor test play
2022-11-16 17:54:49 +09:00
Dean Herbert
bb762d8131
Fix "reset to full area" button not always working correctly
2022-11-16 15:45:26 +09:00
nanashi-1
5d8d8ffce5
fix naming
2022-11-16 10:09:51 +08:00
nanashi-1
55edd6c907
add space
2022-11-16 09:58:49 +08:00
nanashi-1
1fb8357e93
change disabledAlpha from readonly to const
2022-11-16 09:58:32 +08:00
nanashi-1
9101ad0cbd
fixed naming
2022-11-16 09:42:40 +08:00
Dean Herbert
52ecd894db
Move equilateral triangle ratio to constant
2022-11-15 22:20:08 +09:00
nanashi-1
5973bb1956
AddButton now returns the button
2022-11-15 20:57:31 +08:00
nanashi-1
1186ed3e32
add disable
2022-11-15 20:56:18 +08:00
nanashi-1
e8d170e772
disable certain options when no beatmap is selected
2022-11-15 20:55:55 +08:00
Andrei Zavatski
f27a5f977d
Improve triangles distribution
2022-11-15 11:49:53 +03:00
Andrei Zavatski
c7dc6db124
Fix incorrect number of added triangles
2022-11-15 11:32:05 +03:00
Andrei Zavatski
ebff844334
Reset triangles on scale change
2022-11-15 11:06:28 +03:00
Dean Herbert
489dca79a1
Remove upper limit for pooling
2022-11-15 12:31:25 +09:00
Dean Herbert
308ed1abd1
Fix number of judgements shown potentially exceeding upper limit
2022-11-15 12:31:25 +09:00
Dean Herbert
59a8603728
Ensure flowing animation starts correctly from zero
2022-11-15 12:04:40 +09:00
Dean Herbert
aef6ee23eb
Apply pooling support to ColourHitErrorMeter
2022-11-15 12:04:40 +09:00
Dean Herbert
a86b50d62a
Apply nullability to BarHitErrorMeter
2022-11-15 11:33:27 +09:00
Dean Herbert
576f462f59
Add pooling support to BarHitErrorMeter
2022-11-15 11:33:27 +09:00
Dan Balasescu
e43593a164
Merge pull request #21227 from Susko3/fix-FallbackSampleStore-async-fallback-logic
...
Fix `FallbackSampleStore.GetAsync` fallback logic
2022-11-14 10:17:42 +09:00
Susko3
56fd1f95b1
Fix FallbackSampleStore.GetAsync fallback logic
2022-11-13 18:47:28 +01:00
Joseph Madamba
4578a96813
Fix beatmap card expanded content not blocking clicks from behind
2022-11-13 08:18:44 -08:00
Andrei Zavatski
81c9ea98e2
Implement TrianglesV2 component
2022-11-13 15:31:48 +03:00
Dean Herbert
efe42f701a
Merge branch 'master' into only-rounded-shader
2022-11-13 16:34:48 +09:00
Dean Herbert
236cc0bdaf
Update resources
2022-11-13 16:21:28 +09:00
Dean Herbert
887b6832c9
Update framework
2022-11-13 16:15:30 +09:00
Dean Herbert
eae8530722
Fix SkinnableSprite lookups broken in lazer-first skins
...
Regressed with removal of local `GetTexture` calls in e19ba65f91
2022-11-13 12:46:21 +09:00
Jai Sharma
c5cb4e4e7d
Add winner of Triangles mapping competition as a bundled beatmap
...
https://osu.ppy.sh/home/news/2022-10-06-results-triangles
2022-11-12 17:48:40 +00:00
Dean Herbert
f343ba6111
Add xmldoc for chat ack request
2022-11-13 00:10:06 +09:00
Dean Herbert
22d8a1160e
Fix last silence ID being updated too often, causing most silences to be missed
2022-11-13 00:10:06 +09:00
Dean Herbert
143c946128
Simplify ack re-perform flow
2022-11-12 23:02:37 +09:00
Dean Herbert
bfb939cbd0
Expand on why call needs to be made every 10 minutes
2022-11-12 22:24:27 +09:00
Dean Herbert
6a3665a6fd
Remove excess logging on WebSocketNotificaitonsClient
2022-11-12 22:09:27 +09:00
maromalo
1911120afe
Merge branch 'master' into long-standard
2022-11-12 09:52:11 -03:00
Dean Herbert
ace4099079
Update ack code after incorrect merge
2022-11-12 21:41:10 +09:00
Thomas Müller-Höhne
9ef43ebd83
Fix compilation after framework-side PR updates
2022-11-12 21:24:12 +09:00
Dean Herbert
dde09d409b
Merge branch 'master' into chat-silences
2022-11-12 21:00:56 +09:00
Thomas Müller-Höhne
fa8e38d9d6
Target rounded fragment shader
...
Compatibility with osu-framework change https://github.com/ppy/osu-framework/pull/5512
2022-11-12 17:18:23 +09:00
Samaoo
4ff17cb4bd
remove unused using directive
2022-11-12 08:52:33 +01:00
Samaoo
7a860fb460
address reviews
2022-11-12 08:49:03 +01:00
Samaoo
268011be9e
use MathF
2022-11-11 17:56:50 +01:00
Samaoo
173f557376
fix tablet aspect ratio values
2022-11-11 17:14:34 +01:00
Dean Herbert
19876ca0fb
Merge branch 'master' into websocket-chat-2
2022-11-11 23:53:42 +09:00
Dean Herbert
151dd7c62f
Fix one more reverted change
2022-11-11 22:21:38 +09:00
Dean Herbert
0af4bdaf5c
Add back removed configuration elements
2022-11-11 18:29:15 +09:00
Dean Herbert
106f1cf90b
Merge branch 'master' into combo-colour-brightness-limit
2022-11-11 18:24:39 +09:00
Dean Herbert
392d4e778e
Change default beatmap listing key binding to Ctrl+B
2022-11-11 17:10:46 +09:00
Dan Balasescu
fe58329478
Merge pull request #21151 from peppy/taiko-judgement-fixes
...
Fix various issues surrounding hit judgements
2022-11-11 16:41:46 +09:00
Dan Balasescu
5bdbf56f43
Merge branch 'master' into taiko-judgement-fixes
2022-11-11 15:48:33 +09:00
Dan Balasescu
1a1a186d22
Merge branch 'master' into taiko-barline-separation
2022-11-11 15:47:06 +09:00
Dan Balasescu
db25e9e9c8
Merge branch 'master' into combo-colour-brightness-limit
2022-11-11 15:31:28 +09:00
Bartłomiej Dach
88195d3984
Merge branch 'master' into improve-ui-control-sound-sync
2022-11-11 07:29:37 +01:00
Dan Balasescu
6ac19615fa
Fix test failure
2022-11-11 14:55:41 +09:00
Bartłomiej Dach
63270c8619
Merge branch 'master' into improve-ui-control-sound-sync
2022-11-11 05:50:28 +01:00
Susko3
5b1e39abd5
Fix parsing of Language when using default system locale
2022-11-10 22:56:24 +01:00
maromalo
83a3f1b82e
Add computeRawScore()
2022-11-10 14:15:20 -03:00
Dean Herbert
86862b1f29
Merge pull request #21164 from Susko3/fix-default-24h-time-format
...
Fix `Prefer24HourTime` default value being wrong
2022-11-11 00:16:47 +09:00
Dan Balasescu
94772a9cda
Merge pull request #21147 from peppy/fix-timeline-editor-crash
...
Fix editor hard crash when beatmap file specified out-of-range timeline zoom value
2022-11-10 22:59:55 +09:00
Dan Balasescu
fd88c92d5a
Merge pull request #21144 from peppy/fix-storyboard-end-start-time
...
Fix incorrect handling of storyboard events with `end_time` before `start_time`
2022-11-10 22:53:45 +09:00
Dean Herbert
1f8824a754
Update framework
2022-11-10 16:14:40 +09:00
Dean Herbert
bc6da2bbaf
Merge branch 'master' into fix-default-24h-time-format
2022-11-10 16:14:37 +09:00
Dean Herbert
4c6ab27ae4
Merge pull request #21192 from Samaoo/fix-tablet-area-dimensions
...
Fix inaccurate tablet area dimensions when applying aspect ratio
2022-11-10 14:14:11 +09:00
Dan Balasescu
606d42c679
Merge pull request #21184 from peppy/skinnable-things-cleanup
...
Skinnable class naming pass
2022-11-10 12:52:08 +09:00
Dan Balasescu
46d4fc0279
Merge pull request #21167 from peppy/fix-storyboard-variables
...
Fix some issues with storyboard variables
2022-11-10 12:46:52 +09:00
Dan Balasescu
dddbc7496a
Merge pull request #21168 from peppy/fix-storyboard-extension-lookup
...
Fix sprites not displaying in storyboard if filename extension is missing in script
2022-11-10 12:31:00 +09:00
Dan Balasescu
051f7f4c68
Merge pull request #21173 from peppy/toggle-hit-markers
...
Add the ability to toggle off hit marker displays in the editor
2022-11-10 12:23:53 +09:00
Dean Herbert
3547c04002
Merge branch 'master' into skinnable-things-cleanup
2022-11-10 12:09:32 +09:00
Dan Balasescu
f90010628c
Merge pull request #21185 from peppy/fix-editor-sample-spam
...
Fix editor playing too many sounds when user performs a manual seek during playback
2022-11-10 12:05:16 +09:00
Dan Balasescu
040d7ee247
Merge pull request #21183 from peppy/skinnable-nullability
...
Apply nullability considerations to all skin related classes
2022-11-10 11:50:41 +09:00
Joseph Madamba
2b81f3048c
Merge branch 'master' into close-side-overlays-when-main-overlay
2022-11-09 12:48:57 -08:00
Samaoo
be81c658af
move tablet area calculations to functions
2022-11-09 20:14:01 +01:00
Piggey
0011f4e7be
fix comment lol
2022-11-09 19:59:04 +01:00
Piggey
4fbc240aa1
Merge remote-tracking branch 'origin/gameplay-leaderboard-fix' into gameplay-leaderboard-fix
2022-11-09 19:53:56 +01:00
Piggey
ab53fb17d3
change displayed text from #? to -
2022-11-09 19:53:36 +01:00
Samaoo
533a2db5ea
fix inaccurate tablet area dimensions when applying aspect ratio
2022-11-09 18:48:47 +01:00
C0D3 M4513R
a57c824092
Merge branch 'master' into beatmap-info
2022-11-09 14:47:08 +00:00
Dean Herbert
e19ba65f91
Remove LookupName from base ISkinComponentLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
1aa0e40f2f
Add "Component" prefix to lookup naming
2022-11-09 17:46:43 +09:00
Dean Herbert
e75c3b3f94
Rename SkinnableTarget to GlobalSkinLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b
Rename ISkinComponent to ISkinLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
ab458320c4
Fix some lingering inspections
2022-11-09 17:46:24 +09:00
Dean Herbert
4457648b1c
Fix editor playing too many sounds when user performs a manual seek during playback
2022-11-09 17:42:33 +09:00
Dean Herbert
d4251271d8
Apply nullability to SkinnableDrawable
2022-11-09 13:59:13 +09:00
Dean Herbert
bf26dbffc2
Apply nullability to skinning support classes
2022-11-09 13:59:13 +09:00
Dawid Sośnia
9549e55ef8
Merge branch 'ppy:master' into gameplay-leaderboard-fix
2022-11-08 20:04:13 +01:00
Piggey
d48c56818f
change positionText to display "#?" if tracked score is being 51st on the leaderboard
2022-11-08 20:02:21 +01:00
Dean Herbert
4448fcb3c8
Override combo colour brightness normalisation setting only in editor
2022-11-08 18:29:10 +09:00
Dean Herbert
dd4cd3cf8e
Move gameplay configuration to interface to allow editor overriding
2022-11-08 18:25:24 +09:00
Dean Herbert
ada039151b
Add the ability to toggle off hit marker displays in the editor
2022-11-08 18:07:06 +09:00
Dean Herbert
9650ae1329
Limit editor background dim to 75% maximum
2022-11-08 17:20:37 +09:00
Dean Herbert
349d262c18
Remove commented unbind
2022-11-08 17:19:48 +09:00
Dean Herbert
b166e477c2
Merge branch 'master' into editor-background
2022-11-08 17:18:34 +09:00
Dean Herbert
b9374cae55
Hide settings/notifications regardless of IsPresent state of new overlay
2022-11-08 14:38:02 +09:00
