341 Commits

Author	SHA1	Message	Date
Endrik Tombak	cbbcf36eaa	Merge branch 'master' of https://github.com/ppy/osu into present-recommended	2020-12-03 19:38:32 +02:00
Dean Herbert	07e14b1267	Disable unnecessary inspection	2020-12-01 01:37:53 +09:00
Dean Herbert	b401259f84	Add test coverage	2020-12-01 01:19:39 +09:00
Dean Herbert	f8db7a9902	Remove ScrollableContent container from carousel ... This was causing multiple issues with masking and sizing and really didn't need to exist in the first place. Also not sure why the pool was nested inside the scroll container, but it isn't any more. Probably for the best.	2020-11-26 18:28:54 +09:00
Endrik Tombak	07db977af5	Remove no longer necessary force calculation ... Is no longer necessary because recommender uses bindable state value changes, compared to when the test was written, and runs the state change once on load	2020-11-21 14:36:43 +02:00
Endrik Tombak	944f3480c2	Merge branch 'master' of https://github.com/ppy/osu into present-recommended ... Conflicts: osu.Game/OsuGameBase.cs osu.Game/Screens/Select/DifficultyRecommender.cs osu.Game/Screens/Select/SongSelect.cs	2020-11-21 14:01:01 +02:00
Joehu	ef3c918a3c	Simplify input buttons/keys in tests	2020-11-09 14:18:20 -08:00
Bartłomiej Dach	164370bc7d	Resolve more CA1805 inspections	2020-11-01 20:51:23 +01:00
Dean Herbert	467bb9b96f	Merge branch 'master' into beatmap-carousel-refactor	2020-10-19 13:17:11 +09:00
Dean Herbert	88ffcb9234	Update EndsWith usages	2020-10-16 12:58:34 +09:00
Dean Herbert	5d11db7753	Locallise ChildItems to DrawableCarouselBeatmapSet for clarity	2020-10-13 19:31:29 +09:00
Dean Herbert	4160feb3da	Add test specifically for many panels visible	2020-10-13 17:37:33 +09:00
Dean Herbert	1f0aa974dd	Fix failing tests	2020-10-13 17:37:33 +09:00
Dean Herbert	dd8943eb7f	Update test scene to fix crash	2020-10-13 17:37:33 +09:00
Dean Herbert	9814e9ba7f	Split classes out to reduce loc burder on DrawableCarouselBeatmapSet	2020-10-13 17:37:33 +09:00
Dean Herbert	580ea62710	Temporarily increase test beatmap count for perf testing	2020-10-13 17:37:33 +09:00
Dean Herbert	3143224e5b	Refactor how drawable carousel items are constructed	2020-10-13 17:37:33 +09:00
Dean Herbert	dbfaa4a0df	Remove beatmap paths from tests where they would result in exceptions	2020-09-15 22:50:44 +09:00
Dean Herbert	d03bfec807	Merge branch 'master' into fix-test-storage-weirdness	2020-09-15 16:54:06 +09:00
Dean Herbert	3242b10187	Change order of dependency caching to promote use of locals	2020-09-15 15:00:04 +09:00
Dean Herbert	15e423157b	Fix tests that access LocalStorage before BDL	2020-09-15 14:17:40 +09:00
Joehu	c833f5fcc4	Reorder buttons to match stable	2020-09-14 11:23:41 -07:00
Joehu	c30174cea3	Add manage collections button to beatmap options	2020-09-14 11:21:23 -07:00
Joehu	ce9c63970c	Fix button colors in beatmap options test	2020-09-14 11:20:43 -07:00
Joehu	1a8a7ae7f8	Remove hardcoded key param from AddButton	2020-09-14 11:19:18 -07:00
smoogipoo	4061480419	Rename menu item	2020-09-11 16:02:46 +09:00
smoogipoo	6b56c6e83f	Rename to CollectionMenuItem	2020-09-09 23:11:19 +09:00
smoogipoo	43525614ad	Store raw BeatmapCollection in filter control	2020-09-09 23:10:21 +09:00
smoogipoo	4ddf5f054b	Rename BeatmapCollectionManager -> CollectionManager	2020-09-09 15:31:08 +09:00
smoogipoo	4962213cc4	Rename manage collections filter/text	2020-09-08 18:42:55 +09:00
smoogipoo	f581df47c8	Add "New collection..." item to dropdown	2020-09-08 18:25:09 +09:00
smoogipoo	bee450ae1e	Fix tests/add placeholder item tests	2020-09-08 17:05:51 +09:00
smoogipoo	c2da3d9c84	Fix button input and tests	2020-09-08 14:36:38 +09:00
smoogipoo	525026e7f0	Fix tests failing due to timings	2020-09-08 13:23:58 +09:00
smoogipoo	ca4423af74	Fix tests	2020-09-08 00:07:12 +09:00
smoogipoo	e37c04cb6d	Change back to solid icon	2020-09-08 00:04:03 +09:00
smoogipoo	a1214512bc	Add filter control tests	2020-09-07 23:57:49 +09:00
smoogipoo	6cc4517600	Merge branch 'master' into collection-database	2020-09-07 20:03:11 +09:00
smoogipoo	4459287b35	Add filter control test scene	2020-09-02 20:25:12 +09:00
smoogipoo	ed74c39b55	Move UserTopScoreContainer into base leaderboard	2020-08-31 19:54:22 +09:00
Dan Balasescu	69548447a7	Adjust step name	2020-07-13 20:03:07 +09:00
Dean Herbert	cd3500510e	Fix carousel tests relying on initial selection being null	2020-07-13 17:05:29 +09:00
Dean Herbert	c36d9d4fc3	Add test coverage	2020-06-25 20:01:29 +09:00
smoogipoo	702bd2b65d	Fix potential nullref in test	2020-06-11 13:41:53 +09:00
Dean Herbert	93572fc17d	Merge branch 'master' into present-recommended	2020-06-03 12:31:23 +09:00
smoogipoo	648999a2de	Remove all RequiredTypes usages	2020-05-16 18:17:12 +09:00
Dean Herbert	81889e0034	Fix tests potentially selecting a deleted beatmap	2020-05-04 15:20:43 +09:00
Dean Herbert	02b9f51bdd	Add failing test	2020-05-04 15:20:43 +09:00
Dean Herbert	a1cd007cad	Fix song select tests potentially failing due to difficulty panels not yet displayed	2020-05-04 14:44:53 +09:00
Endrik Tombak	d30e4061cc	Add clarifying comment about pp choice	2020-05-01 19:46:49 +03:00
Endrik Tombak	3cf60e6e00	Add failing test	2020-05-01 19:43:18 +03:00
Bartłomiej Dach	2913a81835	Improve test code quality & safety	2020-05-01 16:59:45 +02:00
Endrik Tombak	33a608fd15	Merge branch 'master' of https://github.com/ppy/osu into present-recommended ... Conflicts: osu.Game/Screens/Select/SongSelect.cs	2020-05-01 11:06:20 +03:00
Dean Herbert	cf4e79cf38	Show loading spinner when carousel is not ready to be displayed	2020-04-30 11:51:06 +09:00
Endrik Tombak	f68a7401b9	Fix comment	2020-04-25 10:37:18 +03:00
Endrik Tombak	e65acc3401	Other review suggestions	2020-04-25 10:36:19 +03:00
Endrik Tombak	e906ec4d92	Fix typo	2020-04-25 10:25:07 +03:00
Endrik Tombak	52416ea90a	Use GetRuleset	2020-04-25 10:22:19 +03:00
Endrik Tombak	ce47b7ca93	Unnest in SetUpSteps	2020-04-25 10:21:01 +03:00
Endrik Tombak	657bf5ad86	Merge branch 'master' of https://github.com/ppy/osu into present-recommended	2020-04-25 10:13:57 +03:00
Endrik Tombak	90fa58b3b6	More testing	2020-04-17 19:57:39 +03:00
Dean Herbert	5833a7ac91	Fix presenting new ruleset and beatmap at once causing wedge display desync	2020-04-17 18:56:17 +09:00
Endrik Tombak	da9bd74e2e	Very basic testing	2020-04-15 20:19:17 +03:00
Dean Herbert	c0c1f2c023	Add test coverage	2020-04-11 17:17:18 +09:00
Endrik Tombak	35f97dfc75	Style changes	2020-04-09 18:59:18 +03:00
Endrik Tombak	caa404f8fa	Remove test for now	2020-04-09 18:48:13 +03:00
Dean Herbert	260de77304	Merge branch 'master' into select-recommended	2020-04-09 15:30:35 +09:00
Endrik	f4c8b6d219	Fix copy paste oversight	2020-03-29 18:55:47 +03:00
Dean Herbert	a72f0f57f6	Refactor tests for readability	2020-03-30 00:05:07 +09:00
Dean Herbert	07c7233b3d	Change int div comments	2020-03-29 23:46:28 +09:00
Endrik Tombak	8cab303611	Cover skipDifficulties = false in tests	2020-03-28 21:02:55 +02:00
Endrik Tombak	63f6269eb0	Test both ways	2020-03-28 13:10:20 +02:00
Endrik Tombak	659865b457	Use understandable set id	2020-03-28 13:08:06 +02:00
Endrik Tombak	e707adb773	Increase amount of test sets	2020-03-26 21:16:10 +02:00
Endrik Tombak	902734b75e	Add failing test	2020-03-26 20:32:43 +02:00
Endrik Tombak	bbbaaae3ee	Write tests	2020-03-26 19:18:16 +02:00
Dan Balasescu	d0c7b49376	Merge branch 'master' into fix-carousel-root-selects-from-nothing	2020-03-23 11:34:04 +09:00
smoogipoo	bf70276496	Fix test re-using the same beatmap sets	2020-03-23 11:12:36 +09:00
Dean Herbert	8136ea561e	Fix a couple of broken tests	2020-03-20 15:02:13 +09:00
Dean Herbert	9b60b535e5	Fix selection not occurring when switching from empty ruleset on first load	2020-03-20 15:01:26 +09:00
Dean Herbert	3a50c4bb51	Update tests	2020-03-19 18:58:22 +09:00
Dean Herbert	9bb3a6c677	Merge branch 'master' into click-group-difficulty-icons	2020-03-16 12:01:09 +09:00
Dean Herbert	d6be8eec0c	Merge branch 'master' into click-disabled-difficulty-icons	2020-03-16 11:30:57 +09:00
Dan Balasescu	bd05462a7f	Merge branch 'master' into carousel-selection-fallback-improvement	2020-03-16 10:53:10 +09:00
Dan Balasescu	25a35a1370	Merge branch 'master' into always-apply-ruleset-filter	2020-03-16 10:32:36 +09:00
Dean Herbert	de9857ccdc	Fix incorrect id reference in test	2020-03-13 11:02:53 +09:00
Dean Herbert	ba0dec891d	Update test temporarily	2020-03-13 10:58:36 +09:00
Dean Herbert	bab197553e	Update carousel test logic to match new carousel selection behaviour	2020-03-12 19:55:25 +09:00
Dean Herbert	250061ddf5	Fix test failure due to off-screen panel	2020-03-12 19:46:21 +09:00
Dean Herbert	1819a15509	Make test ID assigning simpler	2020-03-12 19:27:54 +09:00
Dean Herbert	db5c8043db	Add test covering ruleset change on difficulty icon selection	2020-03-12 18:42:08 +09:00
Dean Herbert	6e11c3014c	Allow grouped difficulty icons to be clicked	2020-03-12 18:42:08 +09:00
Dean Herbert	2bcf079386	Update carousel test logic to match new carousel selection behaviour	2020-03-12 18:42:08 +09:00
Dean Herbert	5537b279de	Fix failing test occasionally getting wrong ruleset beatmap	2020-03-12 18:39:43 +09:00
Dean Herbert	933a8ffc8a	Add test coverage	2020-03-12 17:10:51 +09:00
Dean Herbert	28ac5af91c	Fix beatmap carousel tests loading beatmap manager beatmaps in test browser	2020-03-12 16:53:23 +09:00
Dean Herbert	7b368dca35	Add test coverage	2020-03-11 02:59:24 +09:00
Dean Herbert	a047456354	Revert changes to make HitObject abstract	2020-02-25 19:07:15 +09:00
Dean Herbert	ffc7eaa3f2	Fix hitobjects with unknown lifetimes by enforcing non-null judgement ... We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward CreateJudgement() must be implemented and return a non-null judgement. This fixes BananaShower and JuiceStreams in osu!catch. This also makes HitObject abstract and cleans up convert HitObject implementations.	2020-02-23 13:49:06 +09:00
Dean Herbert	cd666166d5	Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select ... Allow selecting/playing a specific difficulty using the beatmapset difficulty icons	2020-02-21 10:24:12 +09:00
smoogipoo	1a689231c2	Support null leaderboard position	2020-02-20 14:51:25 +09:00
voidedWarranties	8c81f1e684	Move CarouselBeatmap access to private, test using indices	2020-02-15 17:51:55 -08:00
voidedWarranties	8e1ecddb1d	Add testing	2020-02-14 17:23:24 -08:00
Dean Herbert	333f976580	Fix test finding deleted beatmaps under dotnet-test	2020-02-11 17:47:10 +09:00
Dean Herbert	926cde9afc	Fix potential test failures	2020-02-10 18:17:59 +09:00
Dean Herbert	d61516e10c	Add failing tests	2020-02-10 16:59:54 +09:00
Dan Balasescu	93952d438f	Merge pull request #7677 from peppy/decouple-mod-select-bindable ... Decouple ModSelectOverlay from global SelectedMods	2020-02-03 16:27:47 +09:00
Dean Herbert	9183c78319	Fix crash on exiting song select with ctrl-enter autoplay	2020-02-03 16:04:32 +09:00
Bartłomiej Dach	e90ae667b7	Add failing tests	2020-02-01 16:08:24 +01:00
Bartłomiej Dach	a74d22d9e5	Extract beatmap stats test to separate scene	2020-02-01 15:50:33 +01:00
Dean Herbert	ab7bbf38a8	Set default beatmap later in test initialisation	2020-01-31 16:14:55 +09:00
Dean Herbert	5f48affcba	Centralise screen exit logic to ScreenTestScene	2020-01-31 14:19:29 +09:00
smoogipoo	f457ecaf83	Fix random test failures	2020-01-29 13:54:12 +09:00
Dean Herbert	fd7f07433d	Ensure selection has occurred before storing value	2020-01-27 18:26:44 +09:00
Dean Herbert	1f0aaabf7b	Add tests	2020-01-27 12:21:17 +09:00
smoogipoo	bb390b4470	Add test	2020-01-24 19:40:20 +09:00
Dean Herbert	56724d2580	Merge branch 'master' into #7146	2020-01-10 01:08:20 +08:00
Dean Herbert	ab9603b06a	Merge remote-tracking branch 'upstream/master' into #7146	2020-01-09 17:08:12 +08:00
smoogipoo	91735ff367	Update MathUtils namespace usages	2020-01-09 13:43:44 +09:00
Lucas A	3bd3ebad49	Move placeholders to a dedicated namespace	2020-01-04 19:56:34 +01:00
Willy Tu	e23c71be80	Update Resolved and Cached attribute issues	2020-01-03 11:34:26 -08:00
Willy Tu	0a4e180ce7	Merge branch 'master' of github.com:ppy/osu into #7146	2020-01-03 11:32:06 -08:00
Dean Herbert	69227d6179	Add asserts	2019-12-22 06:37:18 +09:00
Dean Herbert	725008286f	Move test and remove pointless duplicate tests	2019-12-22 06:09:16 +09:00
Dean Herbert	df14f473c2	Split tests out	2019-12-20 19:52:54 +09:00
Willy Tu	6abbd33b51	Fixed CI issues	2019-12-19 21:57:14 -08:00
Willy Tu	8ab26e8889	Update Tests with dependencies on LeaderboardScore. Added its dependency on DialogOverlay for the tests. Added test for deleting individual local score	2019-12-19 21:29:54 -08:00
Dean Herbert	54572b6de9	Update selected mdos references	2019-12-18 16:42:18 +09:00
Dean Herbert	d7eb4f73f4	Merge branch 'master' into update-beatmap-settings	2019-12-16 14:57:57 +09:00
Dean Herbert	bc31146560	Mods -> SelectedMods	2019-12-13 21:45:38 +09:00
unknown	3945e7403a	improve tests and refactor AdvancedStats	2019-12-13 09:39:54 +08:00
unknown	ec5b506960	apply mod difficulty settings during song select	2019-12-12 23:41:46 +08:00
Dean Herbert	cdde5d1d69	Fix song select filters not reapplied if in a child screen ... Closes https://github.com/ppy/osu/issues/6980.	2019-12-10 02:30:23 +09:00
Dean Herbert	f0d49d0cdf	Decouple APILegacyScoreInfo from ScoreInfo	2019-12-03 15:31:11 +09:00
Dean Herbert	296fff9243	Merge remote-tracking branch 'upstream/master' into fix-carousel-double-filter	2019-11-15 18:20:36 +09:00
Dean Herbert	b8bb97607b	Merge remote-tracking branch 'upstream/master' into fix-mod-retention	2019-11-15 13:46:44 +09:00
Dean Herbert	e81dfcad4c	Fix remaining cases of pollution	2019-11-15 11:46:32 +09:00
Dean Herbert	22c3be2c6f	Clear count variables on carousel creation	2019-11-15 11:26:01 +09:00
Dean Herbert	1109d201c3	Add failing test	2019-11-14 13:28:13 +09:00
Dean Herbert	2fe068174a	Fix unnecessary string interpolation	2019-11-13 19:42:33 +09:00
Dean Herbert	2cd156f3d4	Clean up carousel tests	2019-11-13 19:09:03 +09:00
Dean Herbert	bca1be0bfa	Add failing test	2019-11-13 18:54:33 +09:00
Huo Yaoyuan	ccc8aa6fa4	Apply brace style.	2019-11-11 20:13:13 +08:00
Bartłomiej Dach	022cc13952	Add beatmap carousel item sorting stability test ... Add visual test to ensure sorting stability when sorting criteria are applied in the beatmap carousel.	2019-10-27 22:55:46 +01:00
smoogipoo	12cd57744b	Make RulestStore initialise at construction time	2019-10-15 16:14:06 +09:00
Dan Balasescu	69b9e359bf	Merge branch 'master' into fix-ss-track-playback	2019-10-09 12:26:07 +09:00
Dean Herbert	8ebccfe31f	Add comprehensive audio state tests	2019-10-08 17:03:13 +09:00
Dean Herbert	f284d096b7	Fix ignored song select test	2019-10-08 16:37:47 +09:00
Dean Herbert	46d6c5ec3b	Add failing test	2019-10-07 15:17:03 +09:00
Dean Herbert	62c4c1266e	Move private functions to bottom	2019-10-07 15:17:03 +09:00