smoogipoo
0c1775b522
Fix incorrect condition and add test
2020-03-05 17:12:14 +09:00
Dan Balasescu
f12a515ca5
Merge branch 'master' into mod-testscene
2020-03-05 17:10:24 +09:00
Dan Balasescu
f7777ecb01
Merge pull request #8142 from peppy/add-star-difficulty-max-migration
...
Fix song select max displayable star difficulty getting stuck at wrong maximum
2020-03-05 17:10:10 +09:00
smoogipoo
9307caa3bf
Fix typos
2020-03-05 16:58:07 +09:00
Dan Balasescu
f0fd2a86e3
Merge branch 'master' into add-star-difficulty-max-migration
2020-03-05 16:30:38 +09:00
Dan Balasescu
5368f5214b
Merge branch 'master' into less-test-players
2020-03-05 16:30:38 +09:00
Dean Herbert
5b8037ea7d
Add note about early migration return on non-release transitions
2020-03-05 15:36:36 +09:00
Dean Herbert
507af4fa72
Add comment about rationale behind always updating version in config
2020-03-05 15:35:27 +09:00
Dean Herbert
d3786a9382
Merge branch 'centralise-update-managers' into add-star-difficulty-max-migration
2020-03-05 15:07:20 +09:00
Dean Herbert
a311ace626
Add migration test
2020-03-05 15:07:00 +09:00
Dean Herbert
1e1e8cbcb5
Always update version
2020-03-05 14:46:38 +09:00
Dean Herbert
1e6710020e
Remove minor version for now
2020-03-05 13:46:25 +09:00
Dean Herbert
74b5e76c0e
Fix dependency initialisation ordering
2020-03-05 13:39:55 +09:00
Dean Herbert
6477a7b73e
Centralise creation of UpdateManagers
2020-03-05 13:34:04 +09:00
Dean Herbert
7229131d36
Fix song select max displayable star difficulty getting stuck at wrong maximum
2020-03-05 13:18:42 +09:00
Dean Herbert
e78c238ecd
Merge pull request #8131 from recapitalverb/fix-searchable-list-padding
...
Fix searchable list padding
2020-03-05 12:23:33 +09:00
Dean Herbert
26ce0d05d6
Use autoplay mod rather than local replay provider
2020-03-05 11:33:30 +09:00
Dean Herbert
77fddcd2c2
Merge branch 'less-test-players' into mod-testscene
2020-03-05 11:26:33 +09:00
Dean Herbert
5200633f9f
Centralise TestPlayer implementations as much as possible
2020-03-05 11:25:07 +09:00
Dean Herbert
fadebcdc03
Move all sets to object initialiser for code formatting reasons
2020-03-05 10:21:25 +09:00
Dean Herbert
3b19467ead
ModTestCaseData -> ModTestData
2020-03-05 10:19:42 +09:00
Dean Herbert
0f1f1d1a6b
Remove unused "name" parameter
2020-03-05 10:18:37 +09:00
Dean Herbert
ce3786cfd9
Rename to ModTestScene (is no longer a sandbox)
2020-03-05 10:11:27 +09:00
Andrei Zavatski
6b44021f4d
Change username text size back to 20
2020-03-05 03:33:14 +03:00
Andrei Zavatski
6b1fdcf9a2
Minor adjustments
2020-03-05 02:38:30 +03:00
Andrei Zavatski
13752ffe9d
Revisit UserGridPanel layout
2020-03-05 02:31:19 +03:00
Andrei Zavatski
2e996eeb7e
Refactor displayStatus function and add comments
2020-03-05 02:10:38 +03:00
Andrei Zavatski
22d43c26aa
Adjust some text values
2020-03-05 02:00:46 +03:00
Andrei Zavatski
06b2c70a04
Simplify alignment setting for status message
2020-03-05 01:45:49 +03:00
Andrei Zavatski
d297bf6957
Adjust background presentation
2020-03-05 01:41:55 +03:00
TheWildTree
997be65be2
Improve colouring logic
2020-03-04 21:19:26 +01:00
Andrei Zavatski
bd03dd9b70
Adjust class naming
2020-03-04 23:08:58 +03:00
Andrei Zavatski
63219a2357
Adjust properties naming
2020-03-04 23:06:16 +03:00
Andrei Zavatski
55a0586b13
Move exception handling below all the cases
2020-03-04 23:03:02 +03:00
Andrei Zavatski
8849f25069
Merge remote-tracking branch 'refs/remotes/ppy/master' into friends-update-streams
2020-03-04 22:59:56 +03:00
TheWildTree
5628c5102d
Remove old scores before adding new ones
2020-03-04 20:01:15 +01:00
TheWildTree
9aacc3f5ae
Replace Scores property with DisplayScores method
...
Also adds null checks to prevent crashes in tests.
2020-03-04 19:24:52 +01:00
Dean Herbert
f8776a0be4
Display all difficulties from overriding selection
2020-03-04 22:59:49 +09:00
Andrei Zavatski
0b98bcc856
Fix incorrect click action
2020-03-04 15:22:08 +03:00
Andrei Zavatski
6631b07442
Refactor to replace existing panels
2020-03-04 14:58:15 +03:00
Dean Herbert
a62550b323
Reapply filters on next change after a forced beatmap display
2020-03-04 20:14:18 +09:00
Andrei Zavatski
1bdbe7c823
Merge remote-tracking branch 'refs/remotes/ppy/master' into user-cards-update
2020-03-04 13:43:28 +03:00
Andrei Zavatski
e7e759cc92
Merge remote-tracking branch 'refs/remotes/ppy/master' into user-cards-update
2020-03-04 13:15:51 +03:00
Dean Herbert
38d91ccd0d
Add comment regarding no-longer-required schedule
2020-03-04 19:11:35 +09:00
Dean Herbert
bac35b2a68
Handle beatmap track changing in a saner way
2020-03-04 19:11:35 +09:00
Andrei Zavatski
8a437e1b54
Add ability to send pm via context menu
2020-03-04 12:42:21 +03:00
Andrei Zavatski
15e47d8432
Implement layout for UserGridCard
2020-03-04 12:20:49 +03:00
Dan Balasescu
fa7f8de4e3
Merge branch 'master' into beatmap-status
2020-03-04 18:11:59 +09:00
recapitalverb
a1dc595006
Change scroll container padding
2020-03-04 15:46:35 +07:00
recapitalverb
184d10a75a
Revert "Reduce social overlay/direct overlay paddings"
...
This reverts commit cb11292181
.
2020-03-04 15:45:22 +07:00
mcendu
eaa77bce14
Use ToString().ToLowerInvariant()
...
* https://github.com/ppy/osu/pull/8128#issuecomment-594360083
2020-03-04 16:43:35 +08:00
Dean Herbert
7464a486d9
Fix DummyWorkingBeatmap's track completion attempting to change game-wide beatmap
2020-03-04 16:35:45 +09:00
Andrei Zavatski
6ea3af1951
Implement layout for UserListCard
2020-03-04 10:35:43 +03:00
杜Nate
fbd0dfd71b
add blank lines
2020-03-04 14:55:51 +08:00
mcendu
416b9e4e6f
fix beatmap status display
2020-03-04 14:28:18 +08:00
Andrei Zavatski
b7d34b399d
Adjust background presentation for UserListCard
2020-03-04 09:10:51 +03:00
Andrei Zavatski
1b5222f396
Baisc UserListCard implementation
2020-03-04 08:53:14 +03:00
Andrei Zavatski
f425233527
Basic UserCard implementation
2020-03-04 08:41:21 +03:00
Dan Balasescu
6f5d2da03e
Merge branch 'master' into add-torus-font
2020-03-04 13:56:30 +09:00
Dan Balasescu
aa17a64a0e
Apply missed xmldoc suggestion
2020-03-04 12:47:01 +09:00
Dean Herbert
e9b0770f64
Apply suggestions from code review
...
Co-Authored-By: Dan Balasescu <smoogipoo@smgi.me>
2020-03-04 12:44:44 +09:00
Dean Herbert
75968fb4ba
Update resources once more
2020-03-04 11:50:22 +09:00
Dean Herbert
4294ed4b64
Better align fonts to weights
2020-03-04 11:45:19 +09:00
voidedWarranties
c3f840cc1a
Fix Autoplay = false and AllowFail behavior
2020-03-03 17:12:01 -08:00
Andrei Zavatski
e2ed13b392
Trim whitespace
2020-03-04 00:40:10 +03:00
Andrei Zavatski
6fca3e5a46
Remove functions with get-only properties
2020-03-04 00:39:12 +03:00
Andrei Zavatski
17f2baf600
Remove GetWidth function
2020-03-04 00:35:32 +03:00
Andrei Zavatski
4d5445b5dc
Rename Amount to Count
2020-03-04 00:31:06 +03:00
Andrei Zavatski
c22f61b2b1
Move colour selection to the FriendsOnlineStatusItem
2020-03-04 00:28:47 +03:00
Andrei Zavatski
83dad93b6d
Make Populate() accept list of users
2020-03-03 18:08:51 +03:00
Andrei Zavatski
160d64eecf
FriendsOnlineStatusControl basic implementation
2020-03-03 17:37:01 +03:00
Andrei Zavatski
c0f7a83f6f
Fix featured stream item width
2020-03-03 17:10:25 +03:00
Andrei Zavatski
937d9da43b
Implement OverlayUpdateStreamControl component
2020-03-03 17:01:58 +03:00
Dean Herbert
db56fb5759
Fix venera font usage
2020-03-03 22:28:47 +09:00
Andrei Zavatski
8dcdd6db6f
Rename UpdateStream components to ChangelogUpdateStream
2020-03-03 16:20:36 +03:00
Dean Herbert
740eb9ff53
Merge pull request #8090 from peppy/fix-volume-bninding-handling
...
Add SelectPrevious and SelectNext bindings / Change volume bindings to be truly global
2020-03-03 18:58:49 +09:00
Dean Herbert
08756186e9
Update resources
2020-03-03 18:35:28 +09:00
Dean Herbert
f1f4f1ffbd
Add torus font
2020-03-03 18:17:51 +09:00
Dan Balasescu
e77cefeabe
Merge branch 'master' into fix-volume-bninding-handling
2020-03-03 16:32:18 +09:00
smoogipoo
cb11292181
Reduce social overlay/direct overlay paddings
2020-03-03 16:06:31 +09:00
smoogipoo
2e4adc056f
Fix potential deadlock during gameplay tests
2020-03-03 13:42:05 +09:00
Dean Herbert
7a71a48892
Merge branch 'master' into mod-testscene
2020-03-03 13:40:20 +09:00
smoogipoo
a1aecd4c39
Fix TrackVirtualManual not respecting rate adjustments
2020-03-03 13:01:28 +09:00
smoogipoo
1e26df64b6
Fix constructor test failures
2020-03-03 12:58:07 +09:00
smoogipoo
90c2f7bd89
Fail tests by default
2020-03-03 12:13:36 +09:00
Dan Balasescu
3ef490689e
Merge branch 'master' into changelog-stream-area-refactor
2020-03-03 11:52:03 +09:00
naoey
3d344a076d
Add test for disabled keycounter, don't discard change event values
2020-03-03 06:17:25 +05:30
Dean Herbert
769b7582e3
Merge branch 'master' into dependabot/nuget/Sentry-2.1.0
2020-03-02 20:24:28 +09:00
Dean Herbert
69b4713731
Refactor everything so I can read the code
2020-03-02 20:16:58 +09:00
Dean Herbert
23068034b1
Rename bool and make property for legibility
2020-03-02 19:51:06 +09:00
Dean Herbert
df4de4a090
Merge branch 'master' into changelog-stream-area-refactor
2020-03-02 19:48:04 +09:00
Dean Herbert
e890e45420
Fix Ctrl+Enter behaviour regression
2020-03-02 19:44:25 +09:00
Dean Herbert
48f2f615cd
Merge branch 'master' into fix-volume-bninding-handling
2020-03-02 19:28:36 +09:00
Dean Herbert
81191a3d20
Handle SelectPrevious/SelectNext locally to volume meter when hovered
2020-03-02 18:59:55 +09:00
Dean Herbert
e608d807f4
Handle SelectPrevious / SelectNext as volume change operations if nothing else handled game-wide
2020-03-02 18:59:38 +09:00
Dean Herbert
6989738710
Change default global bindings for volume changing to include the alt key prefix
2020-03-02 18:59:05 +09:00
Dean Herbert
88583b5c79
Remove any existing bindings to increase/decrease volume
2020-03-02 18:56:41 +09:00
Dean Herbert
ed516f05c2
Forward any unhandled scroll events to volume overlay
2020-03-02 18:56:09 +09:00
Dean Herbert
3404b09010
Bring database snapshot in line with specs
2020-03-02 18:55:52 +09:00
Dean Herbert
489bf16bea
Add SelectNext and SelectPrevious global actions
2020-03-02 18:55:28 +09:00
Dean Herbert
ee73f3e2b2
Change matching mode for global actions to better discern similar binds
2020-03-02 18:54:00 +09:00
dependabot-preview[bot]
5432371c74
Bump Sentry from 2.0.3 to 2.1.0
...
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet ) from 2.0.3 to 2.1.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases )
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/2.0.3...2.1.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-02 08:42:12 +00:00
Dean Herbert
89399b177c
Update framework
2020-03-02 16:41:00 +09:00
Dean Herbert
dc79c11b6a
Merge branch 'master' into layout-rework
2020-03-02 16:36:48 +09:00
smoogipoo
6d051d9e42
Fix perfect mod failure cases
2020-03-02 13:25:56 +09:00
smoogipoo
6fb52e5370
Fix custom rulesets not being testable
2020-03-02 13:25:36 +09:00
smoogipoo
cd43a0c9e8
Better check for failing state
2020-03-02 13:24:07 +09:00
smoogipoo
e801ad514b
Fix ruleset nullref
2020-03-02 13:24:02 +09:00
smoogipoo
6d939e9d41
Add failing test scenes
2020-03-02 12:42:48 +09:00
smoogipoo
ce7cbf29ca
Move to using test methods for better separation
2020-03-02 12:20:25 +09:00
smoogipoo
239cfddcbb
Improve test scenes/cases
2020-03-02 10:50:41 +09:00
smoogipoo
5c15704c81
Improve abstract structure for testability
2020-03-02 10:28:39 +09:00
smoogipoo
a02c5710ac
Rename base class
2020-03-02 10:06:49 +09:00
voidedWarranties
089ec4c792
Test scene for mod development
2020-02-29 21:16:28 -08:00
naoey
bca58ddb42
Make KeyCounter stop counting during breaks
2020-02-29 21:18:43 +05:30
TheWildTree
4d19278df4
Remove using directive
2020-02-29 15:43:48 +01:00
TheWildTree
f661806513
Move checking logic out of ScoreTable
2020-02-29 15:29:00 +01:00
Dean Herbert
a332b6980b
Update framework
2020-02-29 14:28:26 +09:00
Dean Herbert
f18a1cde53
Fix crash when reaching results screen on single threaded execution mode
2020-02-29 08:39:27 +09:00
Andrei Zavatski
5dff7f0955
Adjust horizontal padding
2020-02-29 02:21:52 +03:00
Andrei Zavatski
3c8ccf3c7d
Merge remote-tracking branch 'refs/remotes/ppy/master' into changelog-stream-area-refactor
2020-02-29 02:17:37 +03:00
TheWildTree
d71b516902
Check beatmap ranking status instead of the pp value
2020-02-28 21:58:37 +01:00
TheWildTree
5838af39c1
Add background colour customization to ProfileItemContainer
2020-02-28 21:09:49 +01:00
TheWildTree
036f155afe
Adjust colours in DrawableMostPlayedBeatmap
2020-02-28 21:09:31 +01:00
Dean Herbert
7fdc274d03
Merge pull request #8029 from smoogipoo/better-room-participants
...
Implement new multiplayer participants retrieval
2020-02-28 22:40:03 +09:00
Dean Herbert
394b88aa65
Add thread mode dropdown
2020-02-28 22:17:45 +09:00
Dean Herbert
4ad2d0cfb6
Remove deprecated debug setting
2020-02-28 22:17:45 +09:00
Dean Herbert
7b9937b851
Update framework
2020-02-28 22:15:39 +09:00
Andrei Zavatski
377ae3e685
Make a separate if section for all highlighted case
2020-02-28 12:48:06 +03:00
Andrei Zavatski
8fdf859375
Merge remote-tracking branch 'refs/remotes/ppy/master' into changelog-stream-area-refactor
2020-02-28 12:15:09 +03:00
Dean Herbert
276f6da483
Merge branch 'master' into better-room-participants
2020-02-28 16:42:31 +09:00
Dan Balasescu
5118d57a7a
Merge branch 'master' into settingsource-dropdown
2020-02-28 16:42:24 +09:00
Dean Herbert
37aac9c214
Merge pull request #8028 from smoogipoo/add-beatmap-cover-load-delay
...
Add delay for loading multiplayer beatmap covers
2020-02-28 16:42:21 +09:00
Dean Herbert
1ba9539d48
Merge pull request #8027 from smoogipoo/remove-multi-workarounds
...
Remove workarounds for CreateRoomRequest shortcomings
2020-02-28 16:40:33 +09:00
Dean Herbert
cd28208284
Merge pull request #8026 from smoogipoo/fix-triangles-logo-background
...
Hide logo background when exiting with the triangles intro
2020-02-28 16:40:01 +09:00
voidedWarranties
f486db48de
Add labels and fix dropdown bindable values
2020-02-27 17:30:06 -08:00
Andrei Zavatski
f9aa6b9c07
Remove fadeContainer and adjust fade condition
2020-02-27 15:33:01 +03:00
Andrei Zavatski
a8c31c31ad
Move padding outside of the UpdateStreamBadgeArea
2020-02-27 14:47:31 +03:00
Andrei Zavatski
d92e93ed31
Move background creation out from UpdateStreamBadgeArea
2020-02-27 14:39:10 +03:00
Andrei Zavatski
32dc4501c1
Fix incorrect RepliesButton presentation
2020-02-27 14:16:35 +03:00
smoogipoo
b3220476d7
Rename methods
2020-02-27 20:05:12 +09:00
smoogipoo
dd2bd5c19d
Add delay for loading multiplayer beatmap covers
2020-02-27 20:01:23 +09:00
smoogipoo
085968dd7f
Rename recent participants
2020-02-27 20:00:53 +09:00
smoogipoo
22862256c1
Increase time between polls
2020-02-27 19:42:19 +09:00
smoogipoo
fe10a64137
Improve participants list transforms
2020-02-27 19:37:07 +09:00
smoogipoo
97c07281d8
Make ParticipantsList use the new participants property
2020-02-27 19:24:13 +09:00
smoogipoo
99442ec9c3
Implement single-room multiplayer room polling
2020-02-27 19:23:50 +09:00
smoogipoo
ffa8a50c6b
Make User IEquatable
2020-02-27 19:21:59 +09:00
smoogipoo
3f5c4633bc
Remove workarounds for CreateRoomRequest shortcomings
2020-02-27 16:41:00 +09:00
smoogipoo
101a587641
Disable triangles in triangles intro
2020-02-27 15:51:55 +09:00
smoogipoo
7ad6ad0bb0
Remove hacks that bypassed layout shortcomings
2020-02-27 13:32:23 +09:00
Dean Herbert
c06db5a54a
Remove legacy DrawableHitObject state management
2020-02-27 11:28:29 +09:00
TheWildTree
397e35d0a0
Hide pp column if map is loved or qualified
2020-02-26 21:36:52 +01:00
Andrei Zavatski
54d83eff94
Use OverlayColourProfider for VotePill component
2020-02-26 19:35:20 +03:00
Dean Herbert
ed2bdd7106
Fix stutter when showing game HUD after being hidden for a while
2020-02-26 20:45:57 +09:00
smoogipoo
da89798765
Merge remote-tracking branch 'origin/master' into layout-rework
2020-02-26 15:06:40 +09:00
smoogipoo
334ec7bbd4
Apply further framework changes
2020-02-26 15:06:30 +09:00
smoogipoo
fab49fb1ba
Slightly increase HP awarded for 100s
2020-02-26 12:18:46 +09:00
Dan Balasescu
1dbc92eed1
Merge branch 'master' into changelog-retouch
2020-02-26 11:23:31 +09:00
Dan Balasescu
6e8a9fdd2d
Merge branch 'master' into beatmapset-comments
2020-02-26 10:45:56 +09:00
Dan Balasescu
37e9c2a683
Merge branch 'master' into user-list-toolbar
2020-02-26 10:11:21 +09:00
Dan Balasescu
92bbd71e60
Merge branch 'master' into chart-button-rankings
2020-02-26 09:10:39 +09:00
Lucas A
535a7989d6
Open rankings overlay on spotlights page.
2020-02-25 20:57:15 +01:00
Dean Herbert
d77420d58b
Merge pull request #7977 from peppy/expose-editor-save-to-mobil
...
Expose save option in editor to non-desktop platforms
2020-02-25 21:24:38 +09:00
Dean Herbert
9557a2cd96
Use object initialiser
2020-02-25 20:52:33 +09:00
Dean Herbert
d564440fe7
Merge branch 'master' into fix-barline-lifetimes
2020-02-25 20:41:04 +09:00
Dan Balasescu
ff063b229b
Merge pull request #7973 from peppy/fix-dho-lifetimes-via-judgements
...
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
2020-02-25 20:38:29 +09:00
Dean Herbert
e44ddbeb40
Merge pull request #7989 from peppy/update-framework
...
Update framework
2020-02-25 20:37:03 +09:00
Dean Herbert
61af80c1af
Merge pull request #7982 from EVAST9919/comments-crash-fix
...
Fix potential crash when clicking on show more button in comments
2020-02-25 20:14:58 +09:00
Dean Herbert
b872f782e7
Update framework
2020-02-25 20:04:39 +09:00
Dean Herbert
36079236e6
Remove pointless comment
...
Co-Authored-By: Dan Balasescu <smoogipoo@smgi.me>
2020-02-25 19:22:51 +09:00
Dean Herbert
29e2e17144
Merge branch 'master' into fix-dho-lifetimes-via-judgements
2020-02-25 19:07:57 +09:00
Dean Herbert
a047456354
Revert changes to make HitObject abstract
2020-02-25 19:07:15 +09:00
Dean Herbert
d6046abe70
Only expose save for now
2020-02-25 18:59:16 +09:00
Andrei Zavatski
c1455be855
Add tests
2020-02-25 10:29:03 +03:00
smoogipoo
f71c45cb1b
Remove shallPropagate
2020-02-25 11:30:33 +09:00
Andrei Zavatski
d8413c558b
Use fully qualified name for enum item description in CommentsHeader
2020-02-24 23:41:34 +03:00
Andrei Zavatski
a020566b1e
Add HoverClickSounds
2020-02-24 23:37:46 +03:00
Bartłomiej Dach
4cbb2a2f59
Move comment to more pertinent place
2020-02-24 21:30:27 +01:00
Andrei Zavatski
fe1f2858c1
Refactor to avoid duplicated code
2020-02-24 23:10:37 +03:00
smoogipoo
6c28fd21c7
osu-side changes
2020-02-24 20:52:15 +09:00
Andrei Zavatski
7bc9a9b3d8
Implement OverlayPanelDisplayStyleControl and UserListToolbar components
2020-02-24 07:28:33 +03:00
Andrei Zavatski
b0b52146ea
Fix crash when clicking on ShowMore button
2020-02-24 05:53:33 +03:00
Andrei Zavatski
0cfe1ac823
Implement UserSortTabControl component
2020-02-24 05:47:21 +03:00
Bartłomiej Dach
71c34a36ed
Use pattern matching instead of .(Has)?Value
2020-02-23 14:46:42 +01:00
Dean Herbert
575946d923
Expose save and export options in editor to non-dekstop platforms
2020-02-23 20:47:14 +09:00
Dean Herbert
be08e69862
Merge branch 'fix-dho-lifetimes-via-judgements' into fix-barline-lifetimes
2020-02-23 14:30:23 +09:00
Dean Herbert
401bf1c928
Remove unnecessary checks on NotNull attributes
2020-02-23 14:30:08 +09:00
Dean Herbert
0e29d3c4a2
Correctly expire bar lines in osu!taiko and osu!mania
2020-02-23 13:50:05 +09:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Andrei Zavatski
74c7e29108
Apply suggestions
2020-02-23 01:22:37 +03:00
Dean Herbert
0c3286fa5e
Merge branch 'judgement-line-performance' into follow-point-performance
2020-02-23 05:36:22 +09:00
Dean Herbert
560cf21b12
Add lenience to comparison
...
Noticed that they could still stack up on maps with hitcircles at the same point in time (centipede).
2020-02-23 05:29:17 +09:00
Dean Herbert
4949977d7e
Merge branch 'judgement-line-performance' into follow-point-performance
2020-02-23 05:14:21 +09:00
TheWildTree
beb18006da
Show 0 pp if map is loved
2020-02-22 21:04:00 +01:00
Dean Herbert
aaa888a7c1
Adjust spin duration to make rotation more variable
2020-02-23 05:00:38 +09:00
Dean Herbert
8dbcdebd28
Use LoadingLayer at player loading screen
2020-02-23 05:00:08 +09:00
Dean Herbert
e8ebb31517
Expire old judgement lines if too many exist
2020-02-23 03:53:51 +09:00
Dean Herbert
3daa49f1bd
Clean up old judgement lines if too many are already present
2020-02-23 03:39:12 +09:00
Dean Herbert
5aa5a1bbdd
Reduce transform time of judgement lines (visually looks almost the same)
2020-02-23 03:36:15 +09:00
Lucas A
c9d600b69c
Show RankingsOverlay when clicking on charts button
2020-02-22 11:55:34 +01:00
Andrei Zavatski
63006e8672
Refactor to avoid visual inconsistency for beatmaps with no leaderboard
2020-02-22 03:40:59 +03:00
Andrei Zavatski
894b50f955
Basic implementation of BeatmapSetCommentsContainer
2020-02-22 03:24:50 +03:00
Andrei Zavatski
44ddc585da
Remove unused usings
2020-02-21 18:40:42 +03:00
Andrei Zavatski
8593642a04
Adjust StreamBadgeArea
2020-02-21 18:12:23 +03:00
Andrei Zavatski
c49074dde3
Adjust comments placement
2020-02-21 17:29:51 +03:00
Andrei Zavatski
48a9b465ef
Adjust icons colour
2020-02-21 17:22:46 +03:00
Andrei Zavatski
491906d534
Adjust ChangelogListing appearance
2020-02-21 17:19:49 +03:00
Andrei Zavatski
70eb2ed09e
Adjust ChangelogBuild appearance
2020-02-21 17:11:29 +03:00
Andrei Zavatski
e9f69d2c23
Adjust date for ChangelogSingleBuild
2020-02-21 16:55:12 +03:00
Andrei Zavatski
3fdf8dc386
Recolour main background
2020-02-21 16:41:52 +03:00
Dean Herbert
66bd888227
Merge pull request #7930 from EVAST9919/changelog-comments
...
Add CommentsContainer to ChangelogOverlay
2020-02-21 21:20:35 +09:00
Dean Herbert
db1e5abad7
Merge pull request #7786 from EVAST9919/subcomments-alter-new
...
Add ability to load long comment trees in CommentsContainer
2020-02-21 21:18:33 +09:00
Dean Herbert
33812d6b53
Merge pull request #7932 from peppy/use-loading-inbeatmap-listing
...
Use new loading layer in beatmap listing overlay
2020-02-21 20:37:48 +09:00
Dean Herbert
a97355b02d
Merge pull request #7936 from peppy/add-linux-basic-update-support
...
Add simple updater support for linux AppImages
2020-02-21 20:02:14 +09:00
Dean Herbert
22a28751d0
Merge branch 'master' into use-loading-inbeatmap-listing
2020-02-21 19:59:04 +09:00
smoogipoo
7fd71d9b6c
Adjust conditional
2020-02-21 19:50:16 +09:00
Dan Balasescu
d6b6edce02
Merge branch 'master' into centralise-loading-animations
2020-02-21 19:48:50 +09:00
smoogipoo
4c083e0e7e
Add back orphaning as a fail-safe
2020-02-21 19:41:25 +09:00
smoogipoo
05ff4de944
Remove the concept of orphaning and refactor
2020-02-21 19:30:51 +09:00
smoogipoo
4c3468f40e
Reorder file
2020-02-21 19:30:45 +09:00
smoogipoo
4fd420e61d
Rename method
2020-02-21 19:30:39 +09:00
smoogipoo
a7b5117d88
Fix attempting to add parent comments twice
2020-02-21 19:30:33 +09:00
smoogipoo
1cd84754c8
Add back parent-child linking
2020-02-21 19:27:32 +09:00
smoogipoo
db78b95228
Remove duplicated api request
2020-02-21 19:27:25 +09:00
smoogipoo
957b33b141
Fix included comment properties not being set correctly
2020-02-21 19:27:17 +09:00
Dean Herbert
cf08e036b3
Merge pull request #7817 from EVAST9919/ingame-rankings
...
Make RankingsOverlay available in-game
2020-02-21 19:24:37 +09:00
Dean Herbert
f9d7e7c6b8
Add simple updater support for linux AppImages
2020-02-21 19:16:08 +09:00
Dean Herbert
81f9103f9c
Bind with global ruleset for now
2020-02-21 18:54:48 +09:00
Dean Herbert
556131cd5f
Merge branch 'master' into ingame-rankings
2020-02-21 18:51:54 +09:00
Dean Herbert
514160e4bb
Update framework
2020-02-21 18:38:25 +09:00
smoogipoo
41c6d2f2e7
Merge remote-tracking branch 'origin/master' into subcomments-alter-new
2020-02-21 17:02:58 +09:00
smoogipoo
37e295e4be
Refactor orphaning to better follow osu-web specification
2020-02-21 17:02:48 +09:00
Dean Herbert
0b589eff45
Merge branch 'centralise-loading-animations' into use-loading-inbeatmap-listing
2020-02-21 17:01:13 +09:00
Dean Herbert
e7ac37715f
Don't handle non-positional input
2020-02-21 16:31:16 +09:00
Dean Herbert
2bda310fa7
Use new loading layer in beatmap listing overlay
2020-02-21 16:13:24 +09:00
Dean Herbert
dacbbb5eee
Add a maximum size to ensure things don't get out of hand
2020-02-21 16:11:09 +09:00
Dean Herbert
b94f937f7e
Fill in missing xmldoc
2020-02-21 15:35:40 +09:00
Dean Herbert
92f6f0207c
Rename LoadingAnimation to LoadingSpinner
2020-02-21 15:33:31 +09:00
Dean Herbert
623b78d675
Combine all loading animation implementations
2020-02-21 15:32:46 +09:00
Andrei Zavatski
da41f4cd3f
Add CommentsContainer to ChangelogOverlay
2020-02-21 08:02:40 +03:00
smoogipoo
5acaf9b371
Privatise setter
2020-02-21 12:33:49 +09:00
smoogipoo
2cb218c9c4
Merge remote-tracking branch 'origin/master' into comment-editor
2020-02-21 12:27:34 +09:00
dependabot-preview[bot]
0f088cc2c2
Bump ppy.osu.Game.Resources from 2020.219.0 to 2020.221.0
...
Bumps [ppy.osu.Game.Resources](https://github.com/ppy/osu-resources ) from 2020.219.0 to 2020.221.0.
- [Release notes](https://github.com/ppy/osu-resources/releases )
- [Commits](https://github.com/ppy/osu-resources/compare/2020.219.0...2020.221.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-21 03:10:48 +00:00
Dean Herbert
cd666166d5
Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
...
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
2020-02-21 10:24:12 +09:00
Dean Herbert
db4fe4f728
Merge branch 'master' into adjust-beatmap-overlay
2020-02-21 09:52:44 +09:00
Dean Herbert
4fb4c03956
Merge pull request #7779 from Malox10/hoverable-timestamps
...
Add tooltips with precise dates to beatmap set overlay
2020-02-21 09:48:22 +09:00
Dean Herbert
6c21cc3926
Adjust easing type to match in disposal clause
...
Co-Authored-By: Dan Balasescu <smoogipoo@smgi.me>
2020-02-21 08:55:12 +09:00
Dan Balasescu
7adedcb7b9
Fix typo
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-02-21 08:34:51 +09:00
Dean Herbert
3380dbbd71
Improve visual appearance of ProcessingOverlay
2020-02-20 19:49:22 +09:00
Dean Herbert
4a3f281855
Make buttons purple
2020-02-20 18:56:14 +09:00
Dean Herbert
a0b578082e
Make ready button also have triangles
2020-02-20 18:56:00 +09:00
Dean Herbert
e7fca689b1
Change text on playlist add button to be nicer
2020-02-20 18:56:00 +09:00
Dean Herbert
76c57a695b
Change create room button colouring to match design
2020-02-20 18:56:00 +09:00
Dean Herbert
a94a6eb94e
Merge pull request #7900 from smoogipoo/room-inspector-redesign
...
Update the multiplayer room inspector design
2020-02-20 18:55:03 +09:00
Dean Herbert
973093b522
Fix non-selectable playlist items not forwarding clicks to children
2020-02-20 18:32:34 +09:00
Dean Herbert
063fe191ef
Add back missing using
2020-02-20 18:15:40 +09:00
Dean Herbert
e25e9b6164
Merge branch 'master' into multiplayer-header-background
2020-02-20 18:04:02 +09:00
Dean Herbert
a11862ba0d
Improve transition between multiplayer screens (and share constants)
2020-02-20 18:03:53 +09:00
Dean Herbert
927115a085
Merge branch 'master' into room-inspector-redesign
2020-02-20 17:41:16 +09:00
Dean Herbert
e48166858c
Merge branch 'master' into overlined-display-refactor
2020-02-20 17:38:04 +09:00
Dean Herbert
8c8e756149
Merge pull request #7896 from peppy/combo-colour-independence
...
Move DrawableHitObject accent colour update duties to ruleset
2020-02-20 17:01:58 +09:00
Dean Herbert
5c16dbbea9
Merge pull request #7919 from smoogipoo/null-leaderboard-position
...
Support null leaderboard position
2020-02-20 16:27:24 +09:00
Dean Herbert
5970c102b4
Change API to be easier to understand
2020-02-20 15:17:49 +09:00
Dean Herbert
5aea599c5e
Merge branch 'master' into combo-colour-independence
2020-02-20 15:05:15 +09:00
smoogipoo
d79ca97fe9
Make beatmap scores also support null position
2020-02-20 15:04:12 +09:00
Dan Balasescu
eb8a56055f
Merge pull request #7910 from EVAST9919/rankings-clickable-countries
...
Make country names in RankingsOverlay clickable
2020-02-20 15:00:01 +09:00
Dan Balasescu
474d0635cf
Merge pull request #7913 from TheWildTree/highlight-full-combo
...
Highlight max combo on beatmap leaderboards
2020-02-20 14:53:55 +09:00
smoogipoo
1a689231c2
Support null leaderboard position
2020-02-20 14:51:25 +09:00
smoogipoo
17b669fdf7
Refactor to detail the sizing mode setting
2020-02-20 14:32:16 +09:00
Dan Balasescu
51f03d0f07
Adjust comment
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-02-20 14:28:38 +09:00
Dan Balasescu
bf5c34a014
Merge branch 'master' into rankings-clickable-countries
2020-02-20 14:21:44 +09:00
Dan Balasescu
ae12097a46
Merge branch 'master' into highlight-full-combo
2020-02-20 14:02:24 +09:00
smoogipoo
00d8be9235
Adjust height transition
2020-02-20 13:48:34 +09:00
Andrei Zavatski
1935a14288
Adjust animations to be much smoother
2020-02-20 05:08:42 +03:00
Andrei Zavatski
a8c735b66d
Change default category value
2020-02-20 04:19:50 +03:00
Andrei Zavatski
5d8445676d
Merge remote-tracking branch 'refs/remotes/ppy/master' into new-direct-gen-three
2020-02-20 04:15:09 +03:00
Andrei Zavatski
66ea794935
Add debounce to the querying
2020-02-20 02:54:35 +03:00
Andrei Zavatski
7550685a61
DrawableErrorHandler -> NotFoundDrawable
2020-02-20 02:43:13 +03:00
TheWildTree
84d6a8ae2a
Add null check
2020-02-19 19:42:56 +01:00
TheWildTree
7ea67aa672
Highlight max combo on beatmap leaderboards
2020-02-19 17:58:59 +01:00
TheWildTree
23c9782f50
Add maxCombo to APIBeatmap
2020-02-19 17:58:41 +01:00
TheWildTree
62227ad856
Add MaxCombo to BeatmapInfo
2020-02-19 17:58:10 +01:00
Andrei Zavatski
edef84d9c3
CI fixes
2020-02-19 19:15:18 +03:00
Andrei Zavatski
2ef3c78736
Remove query binding duplicate
2020-02-19 18:19:15 +03:00
Andrei Zavatski
237be50e37
Implement DrawableErrorHandler component
2020-02-19 18:17:02 +03:00
Andrei Zavatski
0c78c8cb4f
Update resources
2020-02-19 17:44:15 +03:00
Andrei Zavatski
8fcfb73d72
Implement BeatmapListingOverlay
2020-02-19 17:40:54 +03:00
Dean Herbert
3457d341b2
Merge branch 'master' into fix-async-playlist-enumeration
2020-02-19 23:38:39 +09:00
Andrei Zavatski
255c8d3a13
Adjust SearchBeatmapSetsRequest for new usage
2020-02-19 17:33:48 +03:00
Andrei Zavatski
01202f09be
Expand SearchBeatmapSetsResponse
2020-02-19 17:32:43 +03:00
Andrei Zavatski
1442f5e0db
Use DirectSortCriteria for BeatmapListingSortTabControl
2020-02-19 17:30:26 +03:00
Andrei Zavatski
98654586de
Implement BeatmapListingHeader component
2020-02-19 17:28:14 +03:00
Andrei Zavatski
7b0c3281c2
Make country names clickable
2020-02-19 16:49:39 +03:00
Andrei Zavatski
378aaf82c1
Fix error when first Show call has been triggered by ShowCountry
2020-02-19 16:32:54 +03:00
Andrei Zavatski
146758862a
Remove no longer needed null check
2020-02-19 16:25:06 +03:00
Andrei Zavatski
5d813bf421
Merge remote-tracking branch 'refs/remotes/ppy/master' into ingame-rankings
2020-02-19 16:23:18 +03:00
smoogipoo
f53349ac9d
Reduce size of participants tiles
2020-02-19 19:54:48 +09:00
smoogipoo
3338241632
Add back filter control background, adjust opacity
2020-02-19 19:48:34 +09:00
smoogipoo
e966689044
Add beatmap background to multiplayer
2020-02-19 19:42:25 +09:00