1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-23 20:07:26 +08:00
Commit Graph

28798 Commits

Author SHA1 Message Date
Dan Balasescu
df5a76ad9d
Merge pull request #15041 from peppy/realm-file-store
Add realm `FileStore`
2021-10-13 13:54:56 +09:00
Dean Herbert
26a1e40d24 Fix storyboard outro during fail test not being lenient enough 2021-10-13 13:48:57 +09:00
Dean Herbert
ae4dcbd829 Improve PlayerLoader audio and visual transitions 2021-10-13 13:26:20 +09:00
Dean Herbert
b37096f440 Avoid using bindable for AudioFilter cutoff
It doesn't play nicely with screen exiting, as it is automatically
unbound during the exit process. Easiest to just avoid using this for
now.
2021-10-13 13:25:55 +09:00
smoogipoo
cf10239e70 Add a few nullabilities and DCC excludes 2021-10-13 12:51:46 +09:00
Dean Herbert
f69a56a26a Add test coverage of startup import sequence 2021-10-13 12:19:10 +09:00
Dean Herbert
94de24075e Ensure startup imports trigger notifications 2021-10-13 12:18:56 +09:00
Bartłomiej Dach
7c5bd2db7b
Allow using ThemedDropdown even if OverlayColourProvider not available
This is to accommodate `SettingsDropdown` usages without an available
`OverlayColourProvider`, such as mod settings controls and tournament
client usages.
2021-10-12 23:12:16 +02:00
Bartłomiej Dach
7139c832b0
Add support for changing scrollbar accent colour & use in themed dropdown 2021-10-12 22:20:07 +02:00
Bartłomiej Dach
a2f3a7cba8
Add "themed" dropdown variant and use in settings sidebar 2021-10-12 21:58:43 +02:00
Bartłomiej Dach
1fba932e84
Adjust settings dropdown spacings 2021-10-12 21:41:33 +02:00
Bartłomiej Dach
5ddb7f74e2
Adjust default dropdown dimensions & spacings 2021-10-12 21:41:29 +02:00
Bartłomiej Dach
3ceee176e6
Merge branch 'master' into frame-stability-container-direction-flip 2021-10-12 18:34:04 +02:00
Dean Herbert
e468bfb31c
Merge branch 'master' into realm-file-store 2021-10-12 23:11:02 +09:00
Dan Balasescu
cabbb1697a
Merge pull request #15054 from peppy/settings-ordering
Initial settings usability pass
2021-10-12 22:00:30 +09:00
Dan Balasescu
60ba1987ba
Merge pull request #15050 from peppy/fix-cross-thread-list-manipulation-skin-source-provider
Fix cross-thread list manipulation in `SkinProvidingContainer`
2021-10-12 21:59:49 +09:00
Dan Balasescu
7bb401b974
Merge pull request #15040 from peppy/realm-test-game-host
Update realm tests to run inside a `GameHost` to allow running on update thread
2021-10-12 21:16:06 +09:00
Dan Balasescu
f76b58e843
Merge pull request #15055 from peppy/fix-taiko-convert-woes
Fix `BeatmapConverter` not cloning deeply enough
2021-10-12 21:07:39 +09:00
Dan Balasescu
f01e995cd9
Merge branch 'master' into fix-cross-thread-list-manipulation-skin-source-provider 2021-10-12 20:59:17 +09:00
Dean Herbert
427bf4ef0a
Merge branch 'master' into fix-audio-filter-test-failures 2021-10-12 19:42:18 +09:00
Dean Herbert
e6cd0a8371 Remove unused using statements 2021-10-12 17:17:40 +09:00
Dean Herbert
1373cc02d7 Shallow clone BeatmapInfo during conversion process to avoid overwriting fields 2021-10-12 16:43:56 +09:00
Bartłomiej Dach
b79cf0b58b Add failing coverage for conversion not altering original beatmap 2021-10-12 16:43:56 +09:00
Dean Herbert
6fec821a17 Update framework 2021-10-12 16:20:13 +09:00
Dean Herbert
c66e50ac55 Remove temporary logging 2021-10-12 16:19:58 +09:00
Dean Herbert
76c64751de Remove RealmBeatmap.Clone for the time being (incorrectly implemented) 2021-10-12 16:18:12 +09:00
Dean Herbert
0df9ab3eec Fix migration blocking code running on the wrong thread 2021-10-12 16:04:09 +09:00
Dean Herbert
ce128476ae Remove public setter of RealmFileStore.Storage 2021-10-12 15:46:32 +09:00
Dean Herbert
129416835f
Remove stray string.Empty specification
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-10-12 15:40:12 +09:00
Dean Herbert
24b87cf655 Change some icons to be more descriptive (still placeholder) 2021-10-12 15:09:59 +09:00
Dean Herbert
59202d27c7 Add some missing labels 2021-10-12 15:09:59 +09:00
Dean Herbert
5ca1d1d12c Reorder graphics settings and move gameplay related pieces out 2021-10-12 15:09:59 +09:00
Dean Herbert
c4347de57e Move ruleset settings to own section 2021-10-12 14:58:43 +09:00
Dean Herbert
8285f065c2 Reorganise gameplay settings into more sections 2021-10-12 14:58:43 +09:00
Dan Balasescu
8291d74b68
Merge pull request #15053 from peppy/remove-button-drop-shadow
Remove drop shadow from `RoundedButton`
2021-10-12 14:04:41 +09:00
Dean Herbert
1d3d67c5f1 Move gameplay cursor settings to gameplay section 2021-10-12 13:56:10 +09:00
Dean Herbert
a986870a99 Reorder sections to be more in line with how often they are adjusted 2021-10-12 13:41:35 +09:00
Dean Herbert
e982f485c7 Remove drop shadow from RoundedButton
As per @arflyte's spec, this should not have been there in the first
place.
2021-10-12 13:17:49 +09:00
Dean Herbert
d7cbacc5a0 Rename OnSourceChanged and expand on xmldoc to mention that it doesn't fire SourceChanged 2021-10-12 13:04:48 +09:00
Dean Herbert
a849e7343e Add lock to ensure no threading shenanigans 2021-10-12 13:04:24 +09:00
Dean Herbert
077dcf5cd9 Add missing documentation for SourceChanged 2021-10-12 12:50:28 +09:00
Dean Herbert
e058214346
Merge branch 'master' into fix-audio-filter-test-failures 2021-10-12 12:06:12 +09:00
Gagah Pangeran Rosfatiputra
81246a110c
add OpenChangelog in OsuGame.HandleLink 2021-10-12 09:57:47 +07:00
Gagah Pangeran Rosfatiputra
6c84cf6658
add ShowChangelogListing and ShowChangelogBuild 2021-10-12 09:57:47 +07:00
Gagah Pangeran Rosfatiputra
80722c7dc7
change changelogOverlay to field in OsuGame 2021-10-12 09:57:47 +07:00
Gagah Pangeran Rosfatiputra
47c7701e47
handle changelog link in message formatter 2021-10-12 09:57:47 +07:00
Dean Herbert
39a3482458 Replace Add/Reset methods with single Set method 2021-10-12 11:55:07 +09:00
Gagah Pangeran Rosfatiputra
e0c54e3207
add OpenChangelog link action 2021-10-12 09:37:11 +07:00
Dean Herbert
df83f0db08 Fix cross-thread list manipulation in SkinProvidingContainer 2021-10-12 11:28:11 +09:00
Dean Herbert
1550a3b470 Rethrow exception after logging to make tracking on CI easier 2021-10-12 11:11:55 +09:00
Dean Herbert
82f7f99f37 Refactor to use scoped using (and also correctly dispose TagLib portion) 2021-10-12 10:46:26 +09:00
Dan Balasescu
696193198a
Merge pull request #15049 from bdach/settings-panel-rounded-buttons
Update appearance of buttons in settings sidebar
2021-10-12 09:32:52 +09:00
Naxesss
f2f97602f2 Dispose of video resource later
We need the Stream to stay open here because `StreamFileAbstraction` uses it later in the block.
2021-10-12 00:40:39 +02:00
Naxesss
d4779f06cf Rework CloseStream 2021-10-12 00:30:00 +02:00
Naxesss
47b4d03145 Dispose of Streams when used 2021-10-12 00:13:38 +02:00
Naxesss
ce69dd3588 Use Prescan flag for audio length check 2021-10-11 23:57:23 +02:00
Bartłomiej Dach
ff382259ca
Use rounded buttons in tablet rotation preset settings 2021-10-11 23:17:09 +02:00
Bartłomiej Dach
56eae703fe
Avoid changing frame stable clock direction if time hasn't changed between frames 2021-10-11 21:39:48 +02:00
Naxesss
8f093b9a11 Use TagLib instead of ManagedBass 2021-10-11 13:56:26 +02:00
Naxesss
f0cd18a721 Only check each video file once 2021-10-11 13:55:50 +02:00
Naxesss
6aa054b5fa Change to non-BASS error template 2021-10-11 13:53:23 +02:00
Dean Herbert
22e90076fb Add temporary logging 2021-10-11 18:05:45 +09:00
Joseph Madamba
e0557e849b Join combinations with "/" instead 2021-10-11 01:11:41 -07:00
Joseph Madamba
4fc84e71cd Localise more toast related strings 2021-10-11 01:02:26 -07:00
Dan Balasescu
7c21190b35
Merge branch 'master' into fix-audio-filter-test-failures 2021-10-11 16:43:17 +09:00
Dan Balasescu
c251a3016e
Merge pull request #15039 from peppy/manager-code-quality
Fix a couple of code quality issues with new manager interface usage
2021-10-11 16:42:04 +09:00
Dean Herbert
484a95229e Update toast implementations temporarily to expedite getting tests back in line 2021-10-11 16:36:04 +09:00
Dean Herbert
b4092549c0 Update framework 2021-10-11 16:35:36 +09:00
Dean Herbert
bae404f742 Update framework 2021-10-11 16:17:15 +09:00
Dean Herbert
68078bd5bd Merge branch 'master' into localise-toasts 2021-10-11 16:17:10 +09:00
Dean Herbert
43aacb3831 Fix two different skins displaying at the same time when rapidly switching 2021-10-11 16:11:15 +09:00
Dean Herbert
0daa836ecc Add realm RulesetStore
Not yet used in game.
2021-10-11 15:57:33 +09:00
Dean Herbert
b01d82b3fd Add RealmLive implementation 2021-10-11 15:36:41 +09:00
Dean Herbert
03bf88ae81 Add realm FileStore and test coverage 2021-10-11 15:26:16 +09:00
Dean Herbert
6ca415da9f Add basic realm models
Only the file related ones are really required outside of tests, but
seems like as good an opportunity as ever to get the rest of the models
into the game project.
2021-10-11 15:25:04 +09:00
Dean Herbert
f43badabf4 Add back update thread verification in RealmContextFactory 2021-10-11 15:20:12 +09:00
Dean Herbert
c7675be3ef Fix typo in IModelImporter's xmldoc 2021-10-11 15:12:51 +09:00
Dean Herbert
6b35ccae95 Fix some cases where interface specifications can be used but weren't 2021-10-11 15:06:24 +09:00
Dean Herbert
3d6602b8df Ensure FailAnimation is disposed synchronously to avoid test failures 2021-10-11 14:05:31 +09:00
Joseph Madamba
4b01c23c11 Track ui scale setting 2021-10-10 19:55:02 -07:00
Joseph Madamba
af9bb6f277 Fix padding of shortcut in toast when widest 2021-10-10 19:37:46 -07:00
Joseph Madamba
7b37b15976 Localise some music action toasts 2021-10-10 19:36:50 -07:00
Joseph Madamba
545cfc7bf1 Localise tracked setting toasts 2021-10-10 19:35:25 -07:00
Joseph Madamba
cce4a41c5d Add "disabled" common string 2021-10-10 19:33:45 -07:00
Dean Herbert
a16ffd2976
Merge pull request #14999 from smoogipoo/fix-score-async
Fix intermittent playlist results screen test failures
2021-10-11 10:44:04 +09:00
Dean Herbert
2eb29ed0de
Merge pull request #15021 from peppy/tournament-comma-separators
Use comma separator for tournament score displays
2021-10-11 10:43:34 +09:00
Bartłomiej Dach
b30dd2d4ed
Use rounded button in settings sidebar 2021-10-10 21:45:41 +02:00
Bartłomiej Dach
21ee24ea6d
Add rounded button variant 2021-10-10 21:45:41 +02:00
Dean Herbert
794b4c46cf Split score counter class into two distinct classes to simplify usages 2021-10-10 17:56:32 +09:00
Dean Herbert
06cce0119c Use localisable format string for comma separator mode 2021-10-10 17:41:16 +09:00
Dean Herbert
6d6de5b677 Remove redundant tuple naming 2021-10-10 16:50:55 +09:00
Dean Herbert
446f091d32 Use comma separator for tournament score displays 2021-10-10 16:06:12 +09:00
Dean Herbert
49a878dc20 Fix comma separator support not actually working 2021-10-10 16:06:05 +09:00
Dan Balasescu
8884091422
Merge pull request #15014 from joseph-ireland/remove-initial-strain
Change initial strain value in skills from 1 to 0
2021-10-10 15:56:20 +09:00
smoogipoo
4475697a9c Add score id key 2021-10-10 15:47:39 +09:00
smoogipoo
c49d0a5013 Rewrite query to be easier to understand 2021-10-10 15:43:24 +09:00
Dean Herbert
49b341daff Remove HoverTarget shared state update path
Felt quite convoluted to follow. Have just duplicated the single shared
line instead.
2021-10-10 11:55:47 +09:00
Dean Herbert
ccc6d8ff40 Improve the animation of the active indicator 2021-10-10 11:34:01 +09:00
Bartłomiej Dach
fe26d8e8df
Share sidebar colouring logic by splitting out SidebarIconButton 2021-10-10 00:34:12 +02:00
Bartłomiej Dach
b8616bf910
Adjust appearance of keybinding subpanel 2021-10-10 00:34:12 +02:00
Bartłomiej Dach
855a74b8a0
Adjust vertical spacings in individual subsections 2021-10-10 00:34:11 +02:00
Bartłomiej Dach
e23a54f1e6
Adjust setting section appearance & spacings 2021-10-10 00:31:01 +02:00
Bartłomiej Dach
4c293b637f
Restyle settings panel header 2021-10-09 23:40:15 +02:00
Bartłomiej Dach
315581f4c8
Adjust horizontal spacing in settings panel 2021-10-09 23:40:15 +02:00
Bartłomiej Dach
f6df93f013
Introduce basic parts of colour scheme to settings sidebar 2021-10-09 23:40:14 +02:00
smoogipoo
bc37cb6f43 Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-08 18:41:17 +09:00
Dan Balasescu
9be56829c9
Merge pull request #14935 from Susko3/fix-SettingsTextBox-using-null-as-default
Fix usages of `SettingsTextBox` having `null` as the default
2021-10-08 18:36:02 +09:00
Dan Balasescu
67cfe3412e
Merge branch 'master' into random-seed-max-input-length 2021-10-08 15:38:42 +09:00
smoogipoo
b82ed3f167 Fix potential blocking operation on OrderByTotalScoreAsync()
In reality this wouldn't be a long process, but the blocking is really
noticeable if you add a Task.Delay(1000) in GetTotalScoreAsync().
2021-10-08 14:23:54 +09:00
Dean Herbert
9dc035757f Fix weird textbox behaviour when entering a random mod seed overflowing int backing 2021-10-08 14:01:36 +09:00
Dean Herbert
2856aef4eb Add exception to catch any incorrect defaults of Bindable<string> 2021-10-08 13:52:38 +09:00
Dean Herbert
436ead421a Move low pass fail effect to FailAnimation 2021-10-08 12:27:04 +09:00
Dean Herbert
da96cc73d8 Fix dual specification of SuspensionHandler and move fields around slightly 2021-10-07 23:40:47 +09:00
Dean Herbert
9bf29503fb Rename remaining usage 2021-10-07 20:57:14 +09:00
Dean Herbert
310d7965b6 Merge branch 'master' into more-filter-effects 2021-10-07 20:52:38 +09:00
Dan Balasescu
f8e50731b7
Merge pull request #14991 from peppy/intro-tests-no-menu-load
Allow intro screens to be created without loading a `MainMenu`
2021-10-07 20:48:54 +09:00
Dean Herbert
ef64c64f0b
Merge branch 'master' into popup-filter-effect 2021-10-07 18:56:07 +09:00
Dean Herbert
e578046b20 Rename Filter -> AudioFilter 2021-10-07 18:50:08 +09:00
Dean Herbert
0348c6c7e5 Apply some renaming and code quality fixes 2021-10-07 18:49:22 +09:00
Dan Balasescu
bece807857
Merge pull request #14980 from peppy/difficulty-move-to-beatmap
Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across
2021-10-07 18:43:44 +09:00
Dean Herbert
f98dd1b811
Merge branch 'master' into popup-filter-effect 2021-10-07 18:40:21 +09:00
Jamie Taylor
f6458aa26d
Add filter effect to collection management dialog 2021-10-07 17:56:11 +09:00
Jamie Taylor
cc209f0f2d
Add filter effect to fail sequence 2021-10-07 17:55:30 +09:00
Jamie Taylor
5c48340520
Add filter effect to beatmap loading 2021-10-07 17:55:21 +09:00
Dean Herbert
ee66414e4f Move difficulty copy inside context retrieval 2021-10-07 17:49:13 +09:00
Dan Balasescu
0e0779e45b
Merge pull request #14988 from peppy/remove-gameplay-mod-bindable-storage
Remove local overridden storage of `Mods` in `Player`
2021-10-07 17:36:23 +09:00
Joseph Ireland
185bb9c122 change initial strain from 1 to 0 to allow simpler implementations 2021-10-07 09:30:18 +01:00
Dean Herbert
d3efec3c04 Remove unnecessary clone operations 2021-10-07 17:22:10 +09:00
Dean Herbert
7dd7d35fc8 Remove unnecessary difficulty copy operation 2021-10-07 17:19:34 +09:00
Dean Herbert
0df409c050 Move difficulty copy to BeatmapModelManager.Save 2021-10-07 17:16:45 +09:00
Dan Balasescu
d50443fdf2
Merge branch 'master' into difficulty-move-to-beatmap 2021-10-07 16:50:10 +09:00
Dean Herbert
d0001f760d Group applicable comment above new addition 2021-10-07 16:50:05 +09:00
Dean Herbert
f88d898960 Allow intro screens to be created without loading a MainMenu 2021-10-07 16:38:22 +09:00
Dean Herbert
290c9755e2 Always use circles intro for OsuGame tests
The triangles intro tracks video time, which is not adjusted based on
the game's playback rate (ie. it runs in realtime even for headless
tests).

Maybe we want to make the triangles video adjust its rate along with
tests?
2021-10-07 15:55:29 +09:00
Dean Herbert
a57b080f10 Avoid showing the disclaimer in game tests
No real performance gain, but this is handy to bypass when actually
using one of these tests to test something.
2021-10-07 15:55:15 +09:00
Dean Herbert
5f129ae33c Remove local overridden storage of Mods in Player
Not required and only causing headaches. Accessing mods should now be
done via `GameplayState`.

Closes #14912.
2021-10-07 14:53:39 +09:00
Dean Herbert
9705c7b546 Use cloned mods in one more place 2021-10-06 21:30:30 +09:00
Dean Herbert
433e7cd403 Fix rate mods not working if pp counter is displayed 2021-10-06 21:26:30 +09:00
Jamie Taylor
99fb86878e
Only detach filter on disposal if attached 2021-10-06 18:31:56 +09:00
Jamie Taylor
bd0c986144
Add asserts to ensure correct state when attaching/detaching the filter 2021-10-06 17:34:24 +09:00
Dean Herbert
4ca97bc60a
Merge branch 'master' into difficulty-move-to-beatmap 2021-10-06 16:14:21 +09:00
Dean Herbert
3803f2f462 Fix leaderboard potentially displaying the wrong scores
Closes #14762.

This class is ugly. I think the whole process should be clened up once
we have correctly-scheduled `SynchronizationContext`s. There's not much
saving it as long as all these interdispersed `Schedule`s around
required.
2021-10-06 16:07:29 +09:00
Dean Herbert
222997f2b9 Copy difficulty settings back out to BeatmapInfo on editor changes 2021-10-06 15:19:26 +09:00
Dean Herbert
0ab8dcc2a0 Fix taiko weird difficulty multiplier failing on double convert 2021-10-06 15:18:06 +09:00
Dean Herbert
b339c149d8 Copy BaseDifficulty to Beatmap<T> and move all write operations across 2021-10-06 15:10:45 +09:00
Dan Balasescu
e6aa05a4a4
Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags
Fix dragging on an editor file selection text box causing repeated popover display
2021-10-06 13:52:08 +09:00
Dan Balasescu
80c8612630
Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation
Fix changes not being reflected immediately after exiting the editor
2021-10-06 13:51:21 +09:00
Dean Herbert
d9849bcf49 Fix dragging on an editor file selection text box causing repeated popover display
Local fix and no tests as this is a pretty weird usage of `TextBox`.
We'll probably want to change it to not use a textbox eventually.

Closes #14969.
2021-10-06 13:15:05 +09:00
Dean Herbert
90fdaf18c0 Fix PushAndConfirm potentially failing if new screen quickly pushes a child screen 2021-10-06 12:55:04 +09:00
Dean Herbert
8ffaa491e7 Fix BeatmapModelManager not receiving WorkingBeatmapCache 2021-10-06 12:55:04 +09:00
Dean Herbert
007b33cd88 Add missing methods to interfaces 2021-10-06 12:55:04 +09:00
Dean Herbert
ffbb7a9b1a
Remove incorrect csproj change
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-10-06 12:22:32 +09:00
Dan Balasescu
e837a3511d
Merge branch 'master' into beatmap-difficulty-more-interface-usage 2021-10-06 12:18:51 +09:00
Jamie Taylor
266e62794e
Tweak cutoff effect for new Q value 2021-10-06 11:52:05 +09:00
Dan Balasescu
4bbff2ebf7
Merge branch 'master' into new-interfaces 2021-10-06 11:38:17 +09:00
Jamie Taylor
df182ba92b
Set fQ to recommended value from BASS developer to prevent filter calculations from overflowing when approaching nyquist 2021-10-06 11:29:03 +09:00
Dan Balasescu
9491e5a547
Merge pull request #14954 from peppy/rename-result-response
Rename `APIRequest.Result` to `Response`
2021-10-06 10:52:33 +09:00
Dan Balasescu
007e5f174c
Merge pull request #14959 from peppy/add-screen-test-debug
Add various logging output in an atttempt to figure multiplayer test failure
2021-10-06 10:11:50 +09:00
Dean Herbert
4f59fc15a5 Mark BeatmapSet as nullable for the time being 2021-10-06 05:54:37 +09:00
Dean Herbert
4d5696959b
Remove unnecessary access modifier in interface
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-10-06 05:52:28 +09:00
Dean Herbert
1f6a31355c
Remove unused using statement
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-10-06 05:30:49 +09:00
Dean Herbert
5a4474e1b2 Fix incorrect DI retrieval in ReplayDownloadButton 2021-10-06 05:29:00 +09:00
Dean Herbert
c23acb8f05
Merge pull request #14967 from bdach/fix-accidental-json-property-rename
Fix "most played beatmap" request breakage after property rename
2021-10-06 05:00:12 +09:00
Bartłomiej Dach
baa8baaa1e
Fix "most played beatmap" request breakage after property rename 2021-10-05 21:17:19 +02:00
Bartłomiej Dach
a5b07ce4fe
Fix backwards containment check in chat channel load callback 2021-10-05 20:53:06 +02:00
Bartłomiej Dach
12da27cde7
Add test coverage for loading process on channel join 2021-10-05 20:52:40 +02:00
Dean Herbert
6f7b8293af
Merge pull request #14919 from smoogipoo/realtime-pp-display
Implement real-time PP counter
2021-10-05 20:50:03 +09:00
Dean Herbert
98fef6ece2 Handle judgement reverts with actual display updates 2021-10-05 19:08:30 +09:00
Dean Herbert
5c62d3b6cb
Merge pull request #14907 from peppy/remove-local-realm-thread-switch-handling
Remove local handling of realm when switching thread modes
2021-10-05 19:00:19 +09:00
Dean Herbert
e6efdae7c9 Add various logging output in an atttempt to figure multiplayer test failure 2021-10-05 18:53:20 +09:00
Dean Herbert
bd84a8b749 Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage 2021-10-05 18:21:21 +09:00
Dean Herbert
2be44188ef Add missing null checks 2021-10-05 17:59:38 +09:00
Dean Herbert
0859c336de Also dim counter during initial calculation phase 2021-10-05 17:24:36 +09:00
Dean Herbert
1e4da81120 Fix import notifications not showing correct text 2021-10-05 17:14:09 +09:00
Dean Herbert
f64226ded6 Fix display not displaying correctly after initial load 2021-10-05 17:10:32 +09:00
Dean Herbert
599d82e383 Avoid returning a live IEnumerable 2021-10-05 17:01:07 +09:00
Dean Herbert
fa7f11d906 Add easing to rolling counter value 2021-10-05 16:51:49 +09:00
Dean Herbert
565e888f58 Tidy up attribute retrieval code 2021-10-05 16:40:07 +09:00
smoogipoo
45b63cbad9 Remove unnecessary dependency 2021-10-05 16:03:25 +09:00
Dean Herbert
676df55a0e Fade display out during rewind (as the value displayed is no longer valid) 2021-10-05 15:39:29 +09:00
Dean Herbert
81a13566bc Adjust default location slightly, fix alignment of "pp" subtext 2021-10-05 15:28:03 +09:00
Dean Herbert
b6af93d434 Apply some code quality refactoring 2021-10-05 15:14:49 +09:00
Dean Herbert
7176dc95e5 Revert Player.Score to protected 2021-10-05 14:55:40 +09:00
Dean Herbert
e19be8ebe4 Make GameplayState.Score immutable 2021-10-05 14:55:40 +09:00
Dean Herbert
a5aa32811a Remove null check suppression and add non-null fallback 2021-10-05 14:49:59 +09:00
Dean Herbert
d3b9660148 Move common interface implementations to extension methods 2021-10-05 14:41:14 +09:00
Dean Herbert
b41fa41c85 Rename APIRequest.Result to Response 2021-10-05 14:28:56 +09:00
smoogipoo
5624dd9af6 Fix incorrect CancellationToken usage
Apparently I wrote the BDL system and don't know how this works. I
believe you need `CancellationToken?` or CanBeNull=true, however that doesn't actually
play well when actually using the token in code...
2021-10-05 12:07:41 +09:00
smoogipoo
593da79bbc Further asyncify load process 2021-10-05 11:26:13 +09:00
smoogipoo
d120678e30 Fix redundant default value 2021-10-04 21:13:14 +09:00
smoogipoo
d1e7191f94 Pass score into GameplayState 2021-10-04 20:59:51 +09:00
smoogipoo
0b0316e27e Fix missing CanBeNull 2021-10-04 20:59:31 +09:00
Dean Herbert
57c5be39d3 Merge branch 'master' into remove-local-realm-thread-switch-handling 2021-10-04 20:52:44 +09:00
Dean Herbert
1d99bc280f Merge branch 'master' into new-interfaces 2021-10-04 20:42:40 +09:00
smoogipoo
1837e1bf3c Share rounding with PerformanceStatistic 2021-10-04 20:35:53 +09:00
smoogipoo
fb63e5ed87 Add todo 2021-10-04 20:35:26 +09:00
smoogipoo
221cc1747c Drop "default" prefix 2021-10-04 20:34:28 +09:00
smoogipoo
5aae673240 Use GameplayState 2021-10-04 20:33:54 +09:00
smoogipoo
2e3450b3f5 Make Mods readonly 2021-10-04 20:20:24 +09:00
smoogipoo
031c5a441e Merge branch 'master' into realtime-pp-display 2021-10-04 20:19:37 +09:00