Dean Herbert
4bd96108c0
Fix crash on game exit due to incorrect scheduling of realm change handler
2022-09-26 14:45:17 +09:00
Dean Herbert
b6dd8168d2
Fix progress notifications being able to be flung
2022-09-26 14:33:12 +09:00
ansel
5d0b2d34c9
Make playlist to always be in screen bounds
2022-09-24 23:35:06 +03:00
ansel
6c8e587344
Move margin value to constant
2022-09-24 21:52:16 +03:00
Dean Herbert
8a7526aaa3
Merge pull request #20344 from frenzibyte/better-tablet-notifications
...
Improve tablet error/warning notifications messaging
2022-09-22 22:45:27 +09:00
Dan Balasescu
6a0047b7a2
Update location of FullscreenCapability bindable
2022-09-22 21:01:23 +09:00
Dan Balasescu
70bab81282
Merge pull request #20377 from peppy/argon-skin
...
Add new default "argon" skin
2022-09-22 14:50:43 +09:00
Dan Balasescu
2b8b138079
Add "keybindings" search term to settings
2022-09-21 18:46:28 +09:00
Dean Herbert
4492a26b59
Merge branch 'master' into argon-skin
2022-09-21 13:00:16 +09:00
Dan Balasescu
8bf196d561
Merge pull request #20354 from peppy/default-skin-refactor
...
Rename default skin to make way for new version
2022-09-21 11:48:38 +09:00
Salman Ahmed
dcfb6a2f06
Fix progress notifications no longer blocking close on click
2022-09-21 00:15:50 +03:00
アズタケ
d22d009fb3
fix review points. items not included in this localization were reverted.
2022-09-20 14:02:11 +09:00
Dean Herbert
bd28c6f96d
Merge branch 'master' into localisation-settings
2022-09-19 23:37:26 +09:00
Dean Herbert
0f7b38f4c3
Add new default skin "argon"
2022-09-19 23:16:46 +09:00
Salman Ahmed
a413c7a3e6
Merge branch 'master' into fix-notification-count
2022-09-19 02:08:20 +03:00
Dean Herbert
41e69fbca6
Remove "default" prefix from naming
2022-09-18 00:15:26 +09:00
Dean Herbert
1c4e02fae8
Explicitly order default skins in dropdown to get correct order
2022-09-18 00:12:43 +09:00
Salman Ahmed
877165eb98
Allow specifying icon colour on simple notifications
2022-09-16 16:21:43 +03:00
アズタケ
81d582c051
fix review points and fine tuning
2022-09-16 21:08:25 +09:00
Dan Balasescu
e95983cdb4
Merge branch 'master' into fix-skin-flow
2022-09-16 20:15:51 +09:00
アズタケ
c0e2ba419e
Localize non-localizable setting items
2022-09-16 18:31:02 +09:00
Dean Herbert
38d8d457d9
Add back second completion post attempt for case when notification overlay isn't loaded yet
2022-09-16 17:54:44 +09:00
Dean Herbert
0d24fda4b9
Fire Notification.Closed immediately to ensure off-screen notifications are closed
2022-09-16 16:36:56 +09:00
Dan Balasescu
f86bbaae30
Merge branch 'master' into mods-effect-displays
2022-09-15 21:17:58 +09:00
Salman Ahmed
efebe55d22
Display certain sort criterias based on selected category and query
2022-09-15 04:30:09 +03:00
Salman Ahmed
de7dd29d79
Add "Nominations" and "Updated" sorting criteria in beatmap listing
2022-09-15 03:57:05 +03:00
Joseph Madamba
85e3a681b1
Fix notification overlay toast tray background absorbing input from behind
2022-09-13 21:07:30 -07:00
Dan Balasescu
ef6d60ffe9
Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards
...
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-14 10:25:24 +09:00
Salman Ahmed
04dbb6fc1b
Add inline comment
2022-09-14 00:49:02 +03:00
Dean Herbert
d368f37c3a
Remove redundant second Current set operation
2022-09-13 13:50:59 +09:00
Salman Ahmed
07f577a0c6
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-13 01:39:21 +03:00
ansel
8cbc0502ae
Inline CalculateEffect
2022-09-12 15:51:18 +03:00
Dean Herbert
88107108ee
Add ability to flick notifications to the right to store for later
2022-09-12 20:20:57 +09:00
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling
2022-09-12 20:09:21 +09:00
Dean Herbert
f31deaef7c
Simplify skin bindable flow
...
Now, nothing touches the configuration apart from `OsuGame`, making
everything else flow better and avoid weird cyclic set bugs.
Closes https://github.com/ppy/osu/issues/20234 .
2022-09-12 19:51:50 +09:00
Dan Balasescu
5bd0be14ed
Merge pull request #20259 from peppy/fix-changelog-crash
...
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 19:47:21 +09:00
Dean Herbert
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
...
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
Dean Herbert
d92e000fe6
Fix flinging a notification not correctly running Close
2022-09-12 19:00:03 +09:00
Dean Herbert
4ee3e8f087
Don't play fling animation when activating a notification
2022-09-12 18:57:18 +09:00
Dean Herbert
58c1ea0321
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 17:51:15 +09:00
Dean Herbert
d561fcb126
Don't trigger fling animation when Close is triggered by non-user action
2022-09-12 16:54:25 +09:00
Dean Herbert
5a02e1e713
Use padding instead of FillFlow.Spacing to avoid artifact during animation
2022-09-12 16:46:45 +09:00
Dean Herbert
a506178571
Make bounding box shrink faster to allow for rapid flinging
2022-09-12 16:39:46 +09:00
Dan Balasescu
bcbc867694
Merge branch 'master' into mods-effect-displays
2022-09-12 16:35:28 +09:00
Dean Herbert
931049aec1
Merge branch 'master' into notification-dismiss
2022-09-12 16:27:41 +09:00
Dean Herbert
bd3673baa9
Fix being able to drag after already closing a notification
2022-09-12 16:25:32 +09:00
Dean Herbert
8e6b2796eb
Merge branch 'master' into notification-fling
2022-09-12 16:19:36 +09:00
Dean Herbert
2476cf8fb3
Adjust movement to look less sudden when snapping back to Y=0
2022-09-12 15:37:48 +09:00
Dean Herbert
e06a0f7300
Fix dragged state not being exposed correctly
2022-09-12 15:21:01 +09:00
Dean Herbert
92beb6cbe7
Hide notification read light when in a toast state
...
Also adds test coverage of read state and light.
2022-09-12 15:17:45 +09:00
Dean Herbert
60b0b909a5
Move update icon to background to avoid colour collission with progress spinner
2022-09-12 14:58:46 +09:00
Dean Herbert
9ef23c79ce
Disallow forwarding during a drag operation
2022-09-11 22:05:44 +09:00
Dean Herbert
a56cadcf90
Ensure drag position is reset when transferred to tray
2022-09-11 22:03:29 +09:00
Dean Herbert
b5a2f7003e
Disallow flinging when not in toast state
2022-09-11 21:47:45 +09:00
Dean Herbert
d6f90e3b9f
Add basic fling-to-dismiss support
2022-09-11 21:32:22 +09:00
ansel
324a3723a5
Rewrite DMD
2022-09-10 23:23:04 +03:00
ansel
3f93ec8538
Expose counter to inheritors
2022-09-10 23:20:28 +03:00
ansel
667854b034
Make effect display have a built-in counter
2022-09-10 23:18:48 +03:00
Dean Herbert
a9094c6b03
Add test coverage of clicking close button to dismiss
2022-09-10 15:18:32 +09:00
Dean Herbert
efe3b1aa7b
Allow dismissing notifications without performing action using middle / right click
2022-09-10 15:10:37 +09:00
ansel
b056cac10a
Remove generic and add default implementation for CalculateEffect
2022-09-10 08:34:29 +03:00
andy840119
1398a7e11e
Property should accept the nullable state.
2022-09-10 10:46:40 +08:00
Salman Ahmed
5e4e3dfc2c
Fix markdown container not rendering certain text correctly
2022-09-10 02:55:20 +03:00
Dean Herbert
6e52dbb266
Update IsDisplayingToasts to check the flow count directly
2022-09-06 17:30:24 +09:00
Dean Herbert
9e3228aa65
Fix completion notification not being posted if completion occurs during NotificationOverlay load
2022-09-06 04:07:49 +09:00
Dean Herbert
510972e3ad
Avoid reference counting by using height calculation for IsPresent instead
...
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.
Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
Dean Herbert
0514c96191
Fix incorrect count tracking when notification is manually disposed
2022-09-05 19:26:40 +09:00
Dean Herbert
229e1a8ef7
Fix notification overlay being present when it doesn't need to
2022-09-05 19:13:58 +09:00
Dean Herbert
f754686521
Remove necessity of AlwaysPresent for ProgressUpdate completion posting
2022-09-05 19:13:58 +09:00
Dean Herbert
0d4ee6bd80
Centralise ability to fetch all toast tray notifications (including animating ones)
2022-09-05 18:42:20 +09:00
Dean Herbert
eca7b8f988
Fix completion notifications not always showing as toasts
2022-09-05 18:39:11 +09:00
Dean Herbert
4fa6707bf0
Set all progress notifications to non-important
2022-09-05 18:29:35 +09:00
Dean Herbert
7eaa4c5ccd
Update new usages of Remove / RemoveInternal
2022-09-01 23:05:34 +09:00
Dean Herbert
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
Dan Balasescu
afe2862df4
Merge branch 'master' into toast-notification-tray
2022-08-31 16:07:11 +09:00
Dan Balasescu
ccc08b816c
Merge pull request #20030 from peppy/notification-design-update
...
Update notification overlay design
2022-08-31 16:06:59 +09:00
Dean Herbert
8b9ccc66b7
Update ProgressNotification font spec to match other notifications
2022-08-31 12:49:28 +09:00
Dean Herbert
85442fe032
Adjust dismiss button background colour to avoid conflict with background
2022-08-31 12:48:30 +09:00
Dean Herbert
7c72c6b43f
Fix unread count potentially missing notifications in a transforming state
2022-08-31 12:46:43 +09:00
Dean Herbert
0558dae917
Mark toasts as read when closing the overlay for added safety
...
I'm not sure how the read status will play out going forward so I'm just
adding this to keep things conforming for now.
2022-08-31 12:46:04 +09:00
Dean Herbert
9eb615f942
Fix remaining test failures by strengthening PlayerLoader tests
...
- Click using `TriggerClick` as notifications move around quite a bit.
- Ensure any notifications from a previous test method are cleaned up.
2022-08-31 01:40:30 +09:00
Dean Herbert
31a9980686
Update remaining test expectations with new behaviour
2022-08-31 00:57:30 +09:00
Dean Herbert
a62ba9e0d9
Remove notification blocking behaviour of first run setup
2022-08-31 00:57:18 +09:00
Dean Herbert
ed11b1ba6f
Improve forwarding flow to not use piling delegates
2022-08-31 00:40:53 +09:00
Dean Herbert
224ab29ef4
Don't dismiss toasts while hovered (and adjust timings slightly)
2022-08-30 21:19:51 +09:00
Dean Herbert
403fc18976
Fix notification completion events not being run when overlay not visible
2022-08-30 21:13:43 +09:00
Dean Herbert
a7110666a0
Play notification appear sample immediately
2022-08-30 21:13:43 +09:00
Dean Herbert
95ce78a50c
Reduce notification post delay now that it's less important
2022-08-30 21:13:43 +09:00
Dean Herbert
b8300ae60a
Add toast notification tray
2022-08-30 21:13:43 +09:00
Dean Herbert
7b006f1f22
Add flash when a new notification is displayed to draw attention
2022-08-30 20:34:27 +09:00
Dean Herbert
60413e3e7b
Enable masking for main content to avoid underlap with close button on word wrap failure.
2022-08-30 19:17:41 +09:00
Dean Herbert
6b71b4656d
Remove ProgressNotification vertical movement and delay
2022-08-30 19:16:59 +09:00
Dean Herbert
d600058c98
Assert non-null in ProfileHeader to appease r#
2022-08-30 18:09:10 +09:00
Dean Herbert
c846bf20a7
Add background hover and adjust remaining metrics
2022-08-30 18:06:48 +09:00
Dean Herbert
bea12ab3c2
Rename NotificationContent to MainContent
2022-08-30 18:06:48 +09:00
Dean Herbert
09aa3e065d
Move colouring to full icon content rather than background
2022-08-30 18:06:48 +09:00
Dean Herbert
0f203531d9
Allow customising the "close" button icon
2022-08-30 18:06:48 +09:00
Dean Herbert
1484ae19f0
Initial design update pass
2022-08-30 18:06:48 +09:00
Dean Herbert
b8fda1a16f
Apply NRT to notification classes
...
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
ansel
545e0bbcef
Adjust inheritors and test
2022-08-29 22:49:25 +03:00
ansel
5343c26452
Control colour via Current bindable
2022-08-29 22:48:27 +03:00
ansel
7faeed88b0
Add ability to override width of value area
2022-08-29 22:08:43 +03:00
Dean Herbert
a215d009fe
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
2022-08-29 15:57:40 +09:00
Dan Balasescu
423f6f90f2
Remove async calls from ScoreManager
2022-08-29 15:34:08 +09:00
ansel
039f009562
Inherit difficulty multiplier display from ModsEffectDiplay
2022-08-27 20:26:05 +03:00
ansel
3e828c3416
Move base layout from DifficultyMultiplierDisplay to another class
2022-08-27 20:11:38 +03:00
Dean Herbert
6dc859973b
Merge branch 'master' into fix-playlist-overlay-test-failures
2022-08-26 20:25:53 +09:00
Bartłomiej Dach
968f656585
Merge branch 'master' into copyexternalurl-dialog
2022-08-24 21:21:11 +02:00
Dean Herbert
6a0d23cf96
Nest dialog class and apply NRT
2022-08-24 17:39:22 +09:00
Dean Herbert
9f9deef438
Reword slightly
2022-08-24 17:37:41 +09:00
Andrew Hong
9ee26c575d
Made button blue
2022-08-24 04:04:44 -04:00
Andrew Hong
b24513038c
Add popupdialog button to copy url
2022-08-24 03:35:19 -04:00
Andrew Hong
edd50dc05b
Add profile url context menu to user container
2022-08-24 03:07:03 -04:00
Dean Herbert
c840977acb
Fix filtering potentially not running after new items added
2022-08-23 20:42:20 +09:00
Dean Herbert
058d67f8e8
Merge pull request #19695 from naoei/ruleset-localization
...
Change most ruleset-accessible string types to Localisable strings
2022-08-22 16:13:23 +09:00
Dan Balasescu
0815b01b75
Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation
...
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
2022-08-22 15:44:00 +09:00
Dean Herbert
d199b3b100
Update GetVariantName to also support localisation
2022-08-22 14:51:00 +09:00
Dan Balasescu
e1fa959f0b
Fix language change removing mod column bold text
2022-08-22 13:00:47 +09:00
Bartłomiej Dach
aa15e84bea
Adjust rounding in mod select difficulty multiplier to match song select footer
...
The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
cause the difficulty multiplier to use a different midpoint rounding
strategy than `double.ToString()`, which is the one that the song select
footer relies on. For example, a value of 0.015 would be rounded down
to 0.01 by `double.ToString()`, but rounded up to 0.02
by `BindableDouble`.
Fix the discrepancy by just deleting the `Precision` spec. Since the
value of the bindable would go through `ToLocalisableString(@"N2")`
anyway, it was redundant as is.
Fixes #19889 .
2022-08-21 23:15:49 +02:00
Bartłomiej Dach
3d14b14cfe
Use alternative method for checking panel readiness to eliminate bool flag
2022-08-17 21:56:11 +02:00
Bartłomiej Dach
3109066e34
Rename {Requires -> Pending}Configuration
2022-08-16 22:45:24 +02:00
Bartłomiej Dach
6bfdfeb153
Refactor mod panel selection logic to avoid overwriting
2022-08-16 22:41:35 +02:00
Bartłomiej Dach
10daac6752
Only open mod customisation panel on explicit selection of single mod
2022-08-15 20:38:23 +02:00
Bartłomiej Dach
f860bc11ee
Fix several schedule-related issues arising from new column addition
2022-08-15 20:38:16 +02:00
Bartłomiej Dach
5ff2e41a55
Add preset column to mod select test scene
2022-08-15 18:38:37 +02:00
Nao
c940f5abcb
Merge branch 'master' into ruleset-localization
2022-08-14 15:17:44 -04:00
naoei
45e9eda9e7
Localise hit result name
2022-08-14 14:57:02 -04:00
basseX
383afe04f3
Remove not needed override
2022-08-14 15:15:36 +02:00
basseX
932becc4b2
Remove CommentMarkdownTextFlowContainer and rather use base-class OsuMarkdownTextFlowContainer
2022-08-14 10:11:49 +02:00
basseX
b05acb0073
Make CommentMarkdownTextFlowContainer render images
2022-08-13 21:32:24 +02:00
Dean Herbert
b76e5757e1
Fix InSelectedCollection not being applied to newly imported beatmaps
2022-08-12 15:06:34 +09:00
Dean Herbert
5111bad86c
Refactor TestScenePlaylistOverlay to use realm for testing
...
Removes the dual-purpose flow which existed only for testing.
2022-08-12 15:06:34 +09:00
Dan Balasescu
1721a91168
Merge pull request #19661 from peppy/overlay-key-binding-organisation
...
Reorganise global bindings and split out overlay bindings to make things easier to find
2022-08-10 21:18:28 +09:00
Dan Balasescu
76fea25668
Merge pull request #19646 from its5Q/settings-localisation
...
Add missing localisation for settings enums
2022-08-10 18:51:52 +09:00
Dan Balasescu
888c4c8e08
Merge pull request #19662 from peppy/startup-correct-username
...
Use a placeholder user with the correct username during login process
2022-08-10 13:09:37 +09:00
its5Q
abca3d1b2a
Prefix common strings for context
2022-08-10 00:35:19 +10:00
Dean Herbert
beb3d41f0c
Fix unsafe usage of APIAccess.LocalUser in BeatmapListingOverlay
2022-08-09 17:11:44 +09:00
Dean Herbert
a71c2bbe28
Split overlay toggles into own section in key bindings
...
Things were getting hard to find..
2022-08-09 17:01:38 +09:00
Dean Herbert
32852e5b21
Fix potentially thread-unsafe LocalUser usage
2022-08-09 16:01:04 +09:00
Dean Herbert
5d8bd1de28
Share localised strings with expanded display message
2022-08-09 15:57:16 +09:00
Dean Herbert
3f8cedff3a
Add tooltips showing current connecting status
2022-08-09 15:51:27 +09:00
Dean Herbert
c35b4ef914
Display connecting / failing states on toolbar user display
2022-08-09 15:51:10 +09:00
Bartłomiej Dach
f74fb3491e
Use alternative implementation of preset panel cleanup
2022-08-08 21:08:54 +02:00
Bartłomiej Dach
a0a6e1faee
Fix spurious sample playbacks from already-removed panels
2022-08-08 20:30:55 +02:00
Bartłomiej Dach
f21a51aa24
Simplify mirror copy of task logic in ModColumn
2022-08-08 19:20:50 +02:00
Bartłomiej Dach
00333fb0d2
Change ?? false test to == true for legibility
2022-08-08 19:19:13 +02:00
its5Q
5080d62e77
Add missing localisation for settings enums
2022-08-08 21:51:23 +10:00
Dean Herbert
070d156e89
Simplify task logic in ModPresetColumn
2022-08-08 16:13:52 +09:00
Bartłomiej Dach
7d6efaebbe
Add maintenance settings section for mod presets
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
839409d7ac
Add preset column to solo mod select overlay
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
b318bbd5e6
Allow non-homogenous column types in mod select overlay
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
0287c49ca8
Implement user selection logic for mod presets
2022-08-07 16:20:20 +02:00
Bartłomiej Dach
b1dcd7821c
Automatically toggle preset panels if selected mods match
2022-08-07 15:30:20 +02:00
Dean Herbert
4a95638756
Merge branch 'master' into mod-overlay/delete-preset
2022-08-07 12:34:25 +09:00
Dean Herbert
5946124278
Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog
...
Unify implementations of deletion dialogs
2022-08-07 12:18:03 +09:00
Bartłomiej Dach
9b3183b2b4
Implement mod preset deletion flow
2022-08-06 21:58:55 +02:00
Bartłomiej Dach
a0d093be5c
Extract common implementation of delete dialog
2022-08-06 21:04:12 +02:00
Bartłomiej Dach
ab1b38242f
Reorder enum cases to match web order
2022-08-06 18:34:30 +02:00
Bartłomiej Dach
6a9c30c47a
Fix some more wrong icon colours
2022-08-06 18:34:00 +02:00
Bartłomiej Dach
2ba127b6fc
Fix wrong icon for approval event
2022-08-06 18:30:49 +02:00
Bartłomiej Dach
f1e0dd2da3
Match approval type-dependent icon appearance with web
2022-08-06 18:29:24 +02:00
Bartłomiej Dach
f3ecd73e0b
Add references to web source in recent activity icon
2022-08-06 18:23:15 +02:00
LukynkaCZE
3000d9b9c6
Inline everything in RecentActivityIcon
2022-08-06 07:16:34 +02:00
LukynkaCZE
bd27995c71
Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section
2022-08-06 05:55:51 +02:00
Dean Herbert
6823282604
Fix PlayButton potentially not disposing an unused PreviewTrack during load
2022-08-05 14:15:27 +09:00
Bartłomiej Dach
ca1b4689cb
Automatically focus name textbox upon add preset popover open
2022-08-03 21:26:35 +02:00
Bartłomiej Dach
159d3b032c
Rename locals for legibility
2022-08-03 21:23:31 +02:00
Bartłomiej Dach
82d3fbd51b
Split AddPresetPopover to separate file
2022-08-03 21:22:55 +02:00
Bartłomiej Dach
add2971eb4
Implement preset creation flow with test coverage
2022-08-02 22:05:54 +02:00
Bartłomiej Dach
7251389e43
Add localisations for add preset button
2022-08-02 22:05:34 +02:00
Bartłomiej Dach
059a465fe8
Add border to popover for better visual contrast
2022-08-02 22:03:33 +02:00
Bartłomiej Dach
1b3074d098
Implement popover for creating mod presets
2022-08-02 22:03:33 +02:00
Bartłomiej Dach
085080576a
Add button for creating new mod presets
2022-08-02 22:03:32 +02:00
Dean Herbert
34ffc51c51
Avoid clearing chat overlay textbox when pressing "back" key binding
...
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.
Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395 .
2022-08-02 13:56:03 +09:00
notmyname
6686b09549
Hide F rank from beatmap overlay
2022-08-01 18:54:00 +02:00
Salman Ahmed
2a127c6ef8
Merge branch 'master' into fix-tags-overflow
2022-08-01 12:40:43 +03:00
Gutyina Gergő
c65747d1b8
Use masking instead of scrollable container to prevent tags overflow
2022-08-01 10:36:53 +02:00
Dean Herbert
2f60f91a0e
Fix editor potentially using a track post-disposal
...
This changes the editor to track the current track as it is *loaded* by
`MusicController`, rather than haphazardly following the current global
`WorkingBeatmap` (with a potentially unloaded track) or relying on local
immediate-load behaviour (as implemented in `ResourcesSection`).
2022-08-01 16:53:49 +09:00
Bartłomiej Dach
85f77abee1
Fix code quality inspection about ambiguous equality
2022-07-31 23:53:46 +02:00
Bartłomiej Dach
345f103119
Migrate mod preset column to use realm
2022-07-31 23:53:45 +02:00
Gutyina Gergő
98214beb6c
Prevent overflow on beatmap info using scrollable container
2022-07-31 21:24:41 +02:00
Dan Balasescu
aa03df905f
Merge pull request #19441 from peppy/test-working-beatmap-unfuck
...
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
Dean Herbert
a21aee4e9c
Reduce calls to LoadTrack by implicitly running on test/dummy classes
2022-07-28 18:11:40 +09:00
Dean Herbert
ca68574473
Make NotificationOverlay dependency optional in CollectionSettings
2022-07-28 14:35:27 +09:00
Dean Herbert
ad482b8afc
Tidy up naming of collection dropdowns
2022-07-28 13:57:21 +09:00
Dean Herbert
438067a18b
Convert realm data propagation to more correctly use Live<T>
...
wip
2022-07-27 19:35:09 +09:00
Dean Herbert
41393616d8
Replace BeatmapCollection with RealmBeatmapCollection
2022-07-27 19:35:09 +09:00
Dean Herbert
9c543fef48
Remove CollectionManager
2022-07-27 18:45:33 +09:00
Dean Herbert
c30e8047ab
Merge pull request #19375 from novialriptide/contextmenu-external-beatmap
...
Add ContextMenu to beatmap external link
2022-07-26 19:06:10 +09:00
Dean Herbert
1539fa704b
Always allow selecting the top-most button using the select binding
2022-07-26 17:46:23 +09:00
Andrew Hong
003aec86ae
Rearrange sizeaxes
2022-07-26 04:27:22 -04:00
Dean Herbert
ee0c67e114
Add ability to make cursor show even during touch input
...
I completely disagree with this from a UX perspective, but it's come up
so often that I figure we should just let users bone themselves.
2022-07-26 14:08:00 +09:00
Andrew Hong
a8e315abf0
Refactor
2022-07-25 17:16:33 -04:00
LukynkaCZE
a7c92fe5d6
Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section
2022-07-25 14:56:00 +02:00
Andrew Hong
fcf767e28b
Add contextmenu to beatmap external link
2022-07-25 04:07:33 -04:00
Salman Ahmed
4d90e6bbac
Flip method to read better
2022-07-25 10:03:06 +03:00
Salman Ahmed
e402e919ab
Display placeholder for user profile scores
2022-07-25 09:40:20 +03:00
Salman Ahmed
f54cee0270
Display placeholder for leaderboard top scores
2022-07-25 09:18:04 +03:00
Salman Ahmed
91d1c9686c
Separate unprocessed PP placeholder to own class
2022-07-25 09:07:51 +03:00
Salman Ahmed
54eb2b98a9
Display exclamation triangle on scores with unprocessed PP
2022-07-25 07:30:57 +03:00
Salman Ahmed
3beb1da3de
Merge branch 'master' into beatmap-overlay-null-pp
2022-07-25 07:18:03 +03:00
Bartłomiej Dach
446485f804
Move localisation string to common location
2022-07-24 23:30:52 +02:00
Bartłomiej Dach
8af9cfbe40
Add readonly modifier
2022-07-24 23:29:18 +02:00
Bartłomiej Dach
6a67d76d7c
Add basic mod preset column implementation
2022-07-24 16:39:04 +02:00
Bartłomiej Dach
b2f8934117
Extract base mod select column presentation logic
2022-07-24 16:39:03 +02:00
Salman Ahmed
7c477e6f22
Fix beatmap overlay leaderboard not handling null PP scores properly
2022-07-24 04:20:49 +03:00
LukynkaCZE
1aa0d49d81
Code Quality
2022-07-23 12:27:24 +02:00
LukynkaCZE
9db06fafd0
Fix code formatting
2022-07-23 12:16:11 +02:00
LukynkaCZE
33b442d5d0
Add missing icons to UserProfileRecentSection
2022-07-23 12:06:30 +02:00
Salman Ahmed
2829a7e836
Merge branch 'master' into beatmap-overlay-modded-stats
2022-07-23 10:38:13 +03:00
Salman Ahmed
661c79baf6
Add explanatory comment
2022-07-23 10:16:11 +03:00
Adam Baker
06462c13dd
Overwrite IBindable<ReadOnlyList<Mod>> cache in BeatmapSetOverlay
...
Implement fix as suggested
2022-07-22 23:15:24 -05:00
Adam Baker
d451bc8fda
Revert commits
...
This reverts commit 28586c704dd9d35bb847
2022-07-22 22:25:49 -05:00
Bartłomiej Dach
f3ceabc53f
Rename ModSelect{Overlay -> }Panel
2022-07-22 19:17:22 +02:00
Adam Baker
d9d35bb847
Set BeatmapSetHeaderContent details to not show modded values
2022-07-22 05:43:56 -05:00
Bartłomiej Dach
a3090003de
Add tooltip showing contents of mod preset
2022-07-21 23:29:21 +02:00
Bartłomiej Dach
bdff7f1ef4
Implement basic appearance of mod preset panels
2022-07-21 23:29:21 +02:00
Bartłomiej Dach
6cd18fad99
Fix code inspections after base panel class extraction
2022-07-21 23:29:08 +02:00
Bartłomiej Dach
d796b7d53c
Extract base mod select overlay panel presentation logic
2022-07-21 22:37:00 +02:00
Dan Balasescu
7dfc18a0e3
Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings
...
Remove score multiplier on difficulty-increasing mods with customised settings
2022-07-20 20:12:59 +09:00
Dean Herbert
62133fa069
Merge pull request #19246 from frenzibyte/fix-wiki-navigation
...
Fix wiki overlay not handling path redirection properly
2022-07-20 20:08:11 +09:00
Salman Ahmed
5e933cb466
Improve comment wording
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-07-20 09:43:32 +03:00
Salman Ahmed
474c1a8a7a
Fix wiki overlay not handling path redirection properly
2022-07-20 09:06:11 +03:00
Salman Ahmed
6ce6f6f7df
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-20 08:57:43 +03:00
Salman Ahmed
1270abdf42
Highlight perfect slider tick/end values in beatmap info leaderboards
2022-07-20 00:53:10 +03:00
Salman Ahmed
4210ec6502
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-19 19:21:26 +03:00
Salman Ahmed
89653b74c7
Only add setting tracker when customisation is permitted
2022-07-19 19:21:16 +03:00
Salman Ahmed
b5c7d07ba8
Merge branch 'master' into fix-user-profile-overlay
2022-07-18 10:27:33 +03:00
Dean Herbert
a7f19cc796
Merge pull request #19137 from frenzibyte/country-enum
...
Replace `Country` class with enumeration
2022-07-18 16:12:24 +09:00
Salman Ahmed
e4d11febc5
Remove no longer necessary fallback
2022-07-18 09:47:40 +03:00
Salman Ahmed
84c1c26a7f
Merge branch 'master' into fix-user-profile-overlay
2022-07-18 09:45:25 +03:00
Salman Ahmed
018da74fe8
Replace default with CountryCode.Unknown
2022-07-18 08:54:35 +03:00
Salman Ahmed
100c53f9ef
Country -> CountryCode
2022-07-18 08:40:34 +03:00
Salman Ahmed
eddae7b143
Fix mod overlay and footer not updating multiplayer on settings change
2022-07-18 07:38:56 +03:00
Salman Ahmed
b33f8aa0fc
Fix "Start Chat" on multiplayer/playlist chat not opening overlay
2022-07-18 06:45:00 +03:00
Salman Ahmed
7e4ce89981
Include mod settings in profile score mod icons
2022-07-18 04:03:18 +03:00
tsunyoku
a5d7075ef1
simplify beatmap metadata logic in DrawableProfileScore
2022-07-17 18:10:47 +01:00
Dean Herbert
4e8bf1da52
Don't sent ruleset configuration failures to sentry
2022-07-18 01:23:46 +09:00
tsunyoku
7a6666996f
rename item to model in CreateDrawableItem
2022-07-17 14:50:53 +01:00
tsunyoku
486fbd2531
create instance of BeatmapInfo for use in ScoreBeatmapMetadataContainer
2022-07-17 14:47:04 +01:00
tsunyoku
7135329c8c
remove `PaginatedProfileScoreSubsectio, revert profile score drawables
2022-07-17 14:22:27 +01:00
tsunyoku
3a8b5d48b9
update PaginatedScoreContainer to use new class and format
2022-07-17 14:09:14 +01:00
tsunyoku
ef4237c4ac
create special subsection class for paginated profile scores
2022-07-17 14:08:31 +01:00
tsunyoku
e8d88e29c6
change DrawableProfileScore and DrawableProfileWeightedScore to take SoloScoreInfo and APIBeatmap instead of APIScore
2022-07-17 14:08:04 +01:00
Salman Ahmed
4968859e69
Rename placeholder display flag property to make sense
2022-07-16 06:07:53 +03:00
Salman Ahmed
e62049f4a9
Update various usages of Country inline with new enum
2022-07-16 05:04:24 +03:00
Salman Ahmed
838e9ec12e
Merge branch 'master' into placeholder-fixes
2022-07-15 20:22:25 +03:00
Dean Herbert
cf38b15332
Merge pull request #19124 from frenzibyte/song-select-metadata-search
...
Change clicking source/tags on song select to filter instead of searching online
2022-07-15 19:16:31 +09:00
Dean Herbert
437e01427c
Fix beatmap listing not entering correct search mode when arriving before LoadComplete
2022-07-15 17:53:44 +09:00
Dan Balasescu
c1dd1cfead
Merge pull request #19082 from peppy/api-solo-score-model
...
Add and consume `SoloScoreInfo`
2022-07-15 15:20:18 +09:00
