Dean Herbert
abb32b3256
Merge branch 'master' into custom-data-directory
2020-05-08 10:05:11 +09:00
Dean Herbert
5e65bda8d8
Add test coverage
2020-05-07 22:12:24 +09:00
Dean Herbert
4ac5ed71f4
Remove redundant string interpolation
2020-05-07 21:48:57 +09:00
Dean Herbert
90e17853a8
Update tests in line with framework changes
2020-05-07 18:12:11 +09:00
Dan Balasescu
0eae8d078b
Merge branch 'master' into master
2020-05-05 13:33:29 +09:00
alex
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
Dean Herbert
6621d363da
Add basic custom data directory support
2020-05-04 17:01:05 +09:00
Dean Herbert
81889e0034
Fix tests potentially selecting a deleted beatmap
2020-05-04 15:20:43 +09:00
Dean Herbert
02b9f51bdd
Add failing test
2020-05-04 15:20:43 +09:00
Dean Herbert
a1cd007cad
Fix song select tests potentially failing due to difficulty panels not yet displayed
2020-05-04 14:44:53 +09:00
Dan Balasescu
5767bcb8d7
Merge branch 'master' into add-interval-list
2020-05-04 02:00:14 +09:00
Bartłomiej Dach
8118747732
Make PeriodTracker actually immutable
2020-05-02 01:33:33 +02:00
Joehu
700214d249
Truncate beatmap title and artist on score panel
2020-04-30 22:13:38 -07:00
Dean Herbert
d470e092a3
Merge branch 'master' into fix-overlapping-object-undoredo
2020-05-01 10:45:29 +09:00
smoogipoo
c96bc5c51c
Fix undo/redo behaving poorly with simultaneous objects
2020-04-30 20:39:41 +09:00
Dean Herbert
cf4e79cf38
Show loading spinner when carousel is not ready to be displayed
2020-04-30 11:51:06 +09:00
Salman Ahmed
6fa9feb15c
Merge remote-tracking branch 'upstream/master' into add-interval-list
2020-04-29 05:14:40 +03:00
Salman Ahmed
6e76e5900a
Rename is-in-any check method to a more legible name
2020-04-29 05:11:44 +03:00
Salman Ahmed
587f946dc6
Adjust, simplify and make the test code more flexible to some degree
2020-04-29 05:11:43 +03:00
Dean Herbert
31c3fd86b9
Avoid using internal EF methods in tests
2020-04-28 16:22:00 +09:00
Dan Balasescu
e915f22516
Merge branch 'master' into schedule-music-controller-operations
2020-04-28 14:09:56 +09:00
Dean Herbert
19fe15887a
Merge pull request #8860 from Joehuu/fix-mod-sel-score-multi-being-off-screen
...
Fix score multiplier being cut off in mod select at higher ui scales
2020-04-28 13:52:56 +09:00
Dean Herbert
0d752dc7b8
Remove redundant initialisation
2020-04-28 12:55:57 +09:00
Dean Herbert
743a92bbbe
Use a local database for now playing test
2020-04-28 12:42:08 +09:00
Dean Herbert
81e73acb1a
Fix tests failing when not run in certain order
2020-04-28 12:21:27 +09:00
Dan Balasescu
4fff08d241
Remove unused using
2020-04-28 12:19:39 +09:00
Dean Herbert
62be138aa9
Avoid calls on MusicController executing before it may have finished loading
2020-04-28 11:46:08 +09:00
dependabot-preview[bot]
03863d901b
Bump Microsoft.NET.Test.Sdk from 16.5.0 to 16.6.1
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.5.0 to 16.6.1.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.5.0...v16.6.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-27 08:59:09 +00:00
Joehu
7731d45f13
Remove unnecessary usings
2020-04-26 20:30:56 -07:00
Joehu
8a47a615db
Remove unranked label from footer
2020-04-26 19:29:22 -07:00
Salman Ahmed
f0ebbb1807
Rewrite toolbar test scene and add test cases
2020-04-25 09:54:37 +03:00
Dean Herbert
131f011239
Merge branch 'master' into all-ruleset-encoders
2020-04-24 11:32:48 +09:00
Dean Herbert
ff82de69e7
Merge branch 'master' into fix-testbeatmap-rulesetid
2020-04-24 10:58:50 +09:00
Salman Ahmed
227503c0af
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
2020-04-23 16:25:33 +03:00
Salman Ahmed
2fa47992dc
Seal the ruleset creation methods and let abstract method take their place
...
Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers
2020-04-23 13:27:12 +03:00
Salman Ahmed
e3a3144236
Rename editor tests namespace from "Editor" to "Editing"
2020-04-23 11:07:55 +03:00
smoogipoo
40f11ed15c
Resolve broken test scene
2020-04-23 10:37:05 +09:00
smoogipoo
7796593b2c
Merge branch 'master' into fix-testbeatmap-rulesetid
2020-04-23 10:35:08 +09:00
Dean Herbert
dd9ceed802
Merge branch 'master' into all-ruleset-encoders
2020-04-22 22:51:42 +09:00
smoogipoo
08982e0e00
Ensure editor tests wait for load to complete
2020-04-22 19:49:21 +09:00
smoogipoo
e1142b424d
Fix test failures
2020-04-22 18:14:21 +09:00
Dean Herbert
223c822e57
Merge branch 'master' into all-ruleset-encoders
2020-04-22 13:04:16 +09:00
Dean Herbert
aaa0f908d5
Merge pull request #8818 from smoogipoo/fix-beatmap-encoder
...
Fix beatmap encoder by enabling untested test cases
2020-04-22 13:03:56 +09:00
Dean Herbert
360c9f8e38
Add test coverage and handle null creator
2020-04-22 09:19:34 +09:00
smoogipoo
ee278a2e1b
Add taiko/catch/mania sample beatmaps
2020-04-22 09:06:04 +09:00
smoogipoo
21949ac499
Add osu! test beatmap
2020-04-22 09:04:44 +09:00
smoogipoo
1e7e7417ed
Fix testing relying on control point order
2020-04-22 09:04:44 +09:00
smoogipoo
8ea76244a2
Fix only single beatmap being tested
2020-04-22 09:04:44 +09:00
smoogipoo
9713d90388
Always apply beatmap converter/processor
2020-04-22 09:04:44 +09:00
smoogipoo
e9a2e92adf
Fix incorrect beatmap comments
2020-04-22 09:04:44 +09:00
Dean Herbert
ed9663985b
Rename panels
2020-04-21 20:55:33 +09:00
Dean Herbert
9b9b710ded
Move and rename remaining direct classes
2020-04-21 16:41:07 +09:00
Dean Herbert
1cec0575b7
Remove unused classes and replace overlay in game
2020-04-21 16:38:47 +09:00
Dean Herbert
c3b36d8f20
Merge pull request #7924 from EVAST9919/beatmap-listing-expanded
...
Implement sorting by genre and language in BeatmapListingOverlay
2020-04-21 16:34:59 +09:00
Dean Herbert
aa153290a9
Merge pull request #8815 from smoogipoo/fix-controlpoint-decode
...
Fix control point overriding working incorrectly
2020-04-21 16:18:50 +09:00
Dean Herbert
c2ed6491a9
Move and shorten enum names
2020-04-21 15:39:15 +09:00
Dean Herbert
89320b510c
Apply class renaming
2020-04-21 15:13:19 +09:00
smoogipoo
72fb34f82c
Fix overriding control points incorrectly
2020-04-21 14:19:05 +09:00
Dean Herbert
3b0099c687
Refactor tests
2020-04-21 12:26:43 +09:00
Dean Herbert
5a2129da7c
Merge branch 'master' into allow-cancelling-completion
2020-04-21 11:22:37 +09:00
Dean Herbert
cf41b90193
Merge branch 'master' into dashboard-overlay-new
2020-04-20 18:25:47 +09:00
Dan Balasescu
477d519df3
Merge branch 'master' into beatmap-listing-expanded
2020-04-20 17:18:18 +09:00
Dan Balasescu
dd7c6a83bd
Merge branch 'master' into fix-song-select-desync
2020-04-20 15:23:19 +09:00
Dean Herbert
f26c080512
Merge branch 'master' into dashboard-overlay-new
2020-04-20 15:19:03 +09:00
Dan Balasescu
ddc5489fc9
Merge pull request #8801 from peppy/add-np-command
...
Add /np (now playing) command support in chat
2020-04-20 14:07:39 +09:00
Dean Herbert
f56b85ce27
Merge branch 'master' into fix-song-select-desync
2020-04-20 12:54:32 +09:00
Salman Ahmed
2c012b9af1
Use AddUntilStep whenever possible
...
Avoid redundant usage
2020-04-20 06:43:18 +03:00
Salman Ahmed
e12e3391fb
Base wait steps duration on the delay used for results display
...
With `* 2` for safety of not potentially going to the next step and the delegate not executed yet.
2020-04-20 06:42:33 +03:00
Dean Herbert
2444dd42d0
Remove not-implemented-exception
2020-04-20 09:57:46 +09:00
Dean Herbert
f3fee73441
Fix DatabasedKeyBindingContainer not using defaults for non-databased ruleset
2020-04-20 09:35:00 +09:00
Dean Herbert
e4d4040afb
Rename test to match other classes
2020-04-19 16:57:47 +09:00
Dean Herbert
1dd471dfcc
Add /np (now playing) command support in chat
2020-04-19 15:13:25 +09:00
Salman Ahmed
65a8860a65
Add test cases to ensure no regression in "cancelling completion"
2020-04-19 06:01:09 +03:00
Dean Herbert
5833a7ac91
Fix presenting new ruleset and beatmap at once causing wedge display desync
2020-04-17 18:56:17 +09:00
Salman Ahmed
92df4e3a9e
Remove PlayerTestScene constructor and use CreateRuleset method instead
2020-04-17 11:17:51 +03:00
Dan Balasescu
4e22e569f5
Merge branch 'master' into timing-equivalence
2020-04-17 17:12:38 +09:00
Andrei Zavatski
894598eb22
Replace SocialOverlay with DashboardOverlay
2020-04-16 12:05:51 +03:00
Andrei Zavatski
29bea4e11c
Implement OverlayView component
2020-04-16 11:42:21 +03:00
Andrei Zavatski
ef0da9e3e8
Basic overlay layout implementation
2020-04-16 11:01:36 +03:00
Dean Herbert
86e8aaa2f4
Merge branch 'master' into beatmap-listing-expanded
2020-04-16 16:15:40 +09:00
Dean Herbert
5ec8d49241
Merge pull request #8764 from smoogipoo/disable-undo-redo
...
Disable undo/redo menu items when they can't be performed
2020-04-16 13:47:23 +09:00
smoogipoo
9e2be6f2f4
Remove bindable to promote one-way access
2020-04-16 13:25:08 +09:00
Dean Herbert
4eefe47ce3
Merge branch 'master' into fix-0-customsampleset
2020-04-16 11:20:31 +09:00
Dean Herbert
06e25091f6
Fix typo
2020-04-16 10:44:08 +09:00
smoogipoo
e8c955ed9b
Add CanUndo/CanRedo bindables
2020-04-15 16:17:17 +09:00
smoogipoo
102c1d9095
Add disabled state to menu items
2020-04-15 16:17:17 +09:00
smoogipoo
72707a9973
Fix OS-dependent substring
2020-04-15 13:54:23 +09:00
Dean Herbert
c0a1aae63a
Merge branch 'master' into beatmap-listing-expanded
2020-04-15 13:26:16 +09:00
smoogipoo
10486a0ad2
Fix potential dependency-related issues
2020-04-14 23:10:14 +09:00
smoogipoo
64d44dedcd
Make testscene headless
2020-04-14 22:39:51 +09:00
smoogipoo
00d564d29c
Add tests
2020-04-14 21:18:28 +09:00
Dean Herbert
ecd40072c4
Merge pull request #8312 from Game4all/low-hp-red-layer
...
Fade playfield to red when player health is low
2020-04-14 18:33:51 +09:00
smoogipoo
59728ffebd
Fix up/improve test scene
2020-04-14 15:24:34 +09:00
smoogipoo
3c5fb79823
Mark dummy api test scene as headless
2020-04-14 14:51:09 +09:00
Dan Balasescu
ac8a3efc46
Merge branch 'master' into low-hp-red-layer
2020-04-14 14:47:01 +09:00
Dan Balasescu
33f7e429a8
Merge pull request #8444 from LittleEndu/select-recommended
...
Make beatmap carousel select recommended difficulties
2020-04-14 14:25:17 +09:00
Dan Balasescu
eb968d2bdb
Merge branch 'master' into timing-equivalence
2020-04-14 14:02:02 +09:00
Dan Balasescu
948e225e12
Merge branch 'master' into select-recommended
2020-04-14 13:59:03 +09:00
Dan Balasescu
d965baa4bd
Merge branch 'master' into dummy-api-request-support
2020-04-14 13:42:42 +09:00
Dean Herbert
68c25c38a7
Merge branch 'master' into no-video-option
2020-04-14 11:36:31 +09:00
Bartłomiej Dach
06407a1081
Merge branch 'master' into fix-classic-scoring
2020-04-14 02:13:45 +02:00
Bartłomiej Dach
3e48c26bc2
Add failing tests
2020-04-14 01:09:58 +02:00
Endrik Tombak
d9c91fb943
Merge branch 'master' of https://github.com/ppy/osu into no-video-option
...
Conflicts:
osu.Game/Overlays/Direct/PanelDownloadButton.cs
2020-04-13 17:40:28 +03:00
Dean Herbert
89d8063588
Add support for Perform/PerformAsync
2020-04-13 21:35:35 +09:00
Dean Herbert
2388799acf
Limit upper number of editor beatmap states saved to 50
2020-04-13 20:37:46 +09:00
Dean Herbert
ef5e88dd82
Merge pull request #8696 from smoogipoo/editor-undo-redo
...
Add undo/redo support to the Editor
2020-04-13 19:12:47 +09:00
Dean Herbert
dd949a3fe0
Fix test writer flush happening too late
2020-04-13 17:52:04 +09:00
Dean Herbert
6aab19413c
Rename differ to patcher, add xmldoc
2020-04-13 17:20:20 +09:00
Dean Herbert
bb53f96c71
Store states as byte[] instead of Streams
2020-04-13 17:18:50 +09:00
Andrei Zavatski
29dd225205
Make button protected
2020-04-13 10:45:15 +03:00
Dean Herbert
0c60dbe796
Merge branch 'master' into editor-undo-redo
2020-04-13 16:03:53 +09:00
Andrei Zavatski
bdce79ed5b
Fix incorrect test step name
2020-04-13 09:57:05 +03:00
Andrei Zavatski
0eaff00787
Fix typo in test
2020-04-13 09:45:49 +03:00
Dean Herbert
39b5c9f396
Merge branch 'master' into overlay-scroll-container
2020-04-13 15:44:20 +09:00
Dean Herbert
72fb466a0b
Merge branch 'master' into present-from-overlay
2020-04-13 15:01:24 +09:00
Andrei Zavatski
99fa145847
Add test for potential failing case
2020-04-13 08:38:34 +03:00
Andrei Zavatski
b4800dd461
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container
2020-04-13 08:09:17 +03:00
Endrik Tombak
633b969017
Apply review suggestions
2020-04-12 21:57:35 +03:00
Endrik Tombak
1cf240b5ff
Test new predicate behaviour
2020-04-12 20:04:25 +03:00
TheWildTree
07dc277321
Remove unused changelog comments class
2020-04-12 14:55:42 +02:00
Dean Herbert
25f36e87a6
Merge branch 'master' into overlay-scroll-container
2020-04-12 12:34:41 +09:00
Dean Herbert
c96df97586
Add support for non-generic requests
2020-04-11 18:02:49 +09:00
Dean Herbert
415adecdf6
Add support for Result fetching
2020-04-11 18:02:43 +09:00
Dean Herbert
832822858c
Add basic request / response support
2020-04-11 17:48:23 +09:00
Dean Herbert
c0c1f2c023
Add test coverage
2020-04-11 17:17:18 +09:00
Salman Ahmed
e10c973aa6
Add test cases for behaviour of ruleset dependencies caching on tests
2020-04-11 04:24:34 +03:00
Salman Ahmed
b7ed17dfbd
Throw if interval with reversed values added
...
May reduce in subtle bugs.
2020-04-10 15:49:06 +03:00
smoogipoo
41caa37856
Add tests
2020-04-10 13:29:49 +09:00
Salman Ahmed
9a29797a5b
Use IntervalList<double> for tracking break periods
2020-04-09 23:00:16 +03:00
Salman Ahmed
38ee5f3103
Add tests covering most cases of interval list checking
2020-04-09 22:57:54 +03:00
Andrei Zavatski
518acf03e9
Remove BeatmapSearchSmallFilterRow component
2020-04-09 19:41:35 +03:00
Andrei Zavatski
474dae368f
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-listing-expanded
2020-04-09 19:30:28 +03:00
Andrei Zavatski
b6d8e487d2
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-listing-expanded
2020-04-09 19:18:59 +03:00
smoogipoo
e208251fc6
Wait for timeline to also load
2020-04-09 23:18:43 +09:00
smoogipoo
2e33d38cd7
Merge branch 'master' into editor-undo-redo
2020-04-09 22:02:28 +09:00
smoogipoo
ed4ce54ac3
Add tests
2020-04-09 21:56:36 +09:00
Dean Herbert
cc0bcea6e5
Merge pull request #8693 from smoogipoo/editorbeatmap-update-cleanup
...
Cleanup handling of hitobject updates
2020-04-09 21:32:58 +09:00
smoogipoo
ecd7ce4b98
Fix test scene
2020-04-09 21:00:23 +09:00
smoogipoo
86243d463f
Add legacy beatmap diffing
2020-04-09 20:48:59 +09:00
smoogipoo
fde5cd34b2
Merge branch 'editorbeatmap-update-cleanup' into editor-undo-redo
2020-04-09 20:36:57 +09:00
smoogipoo
ee6ea08cf8
Cleanup handling of hitobject updates
2020-04-09 20:16:44 +09:00
Andrei Zavatski
134feefa14
Remove bindable
2020-04-09 13:10:09 +03:00
Andrei Zavatski
2d3ea95469
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container
2020-04-09 13:06:22 +03:00
Dean Herbert
e10576325c
Merge branch 'master' into update-overlay-headers
2020-04-09 16:29:34 +09:00
Dean Herbert
53b2f58eda
Merge branch 'master' into overlay-scroll-container
2020-04-09 15:05:49 +09:00
Dean Herbert
1c72afe8c4
Move fading test to top for convenience
2020-04-09 14:52:40 +09:00
Dean Herbert
6db22366e2
Add new tests and tidy up existing tests
2020-04-09 14:47:48 +09:00
Dean Herbert
947745d87e
Change fail effect to be less distracting
2020-04-09 14:34:23 +09:00
Dean Herbert
0e2d5213ce
Merge branch 'master' into low-hp-red-layer
2020-04-09 13:53:57 +09:00
Alchyr
3d975f30a3
Merge branch 'timing-equivalence' of https://github.com/Alchyr/osu into timing-equivalence
2020-04-08 01:45:53 -07:00
Alchyr
65823fb2e1
Use redundancy test
2020-04-08 01:42:35 -07:00
smoogipoo
2ddea018cf
Fix hidden notes due to 0 minimum width
2020-04-08 17:15:59 +09:00
Bartłomiej Dach
65db64e13e
Add failing test cases
2020-04-07 22:41:20 +02:00
Dean Herbert
f0443bca3c
Merge pull request #8643 from smoogipoo/fix-legacy-version
...
Make version-less skins fallback to version 1.0
2020-04-07 21:28:06 +09:00
Dan Balasescu
5758a9fa4d
Merge branch 'master' into fix-results-star-display-alignment
2020-04-07 12:28:33 +09:00
smoogipoo
5dfa2a2bad
Fix step namings
2020-04-07 11:50:40 +09:00
smoogipoo
a4208f35c4
Make versionless skins fallback to version 1.0
2020-04-06 19:36:17 +09:00
smoogipoo
8438ee7e07
Improve testing
2020-04-06 19:35:27 +09:00
Salman Ahmed
c902ba4086
Add test cases for HP draining not applied before a break and after it
2020-04-05 21:46:07 +03:00
Salman Ahmed
0eaea8ef9d
Create a constructor for break period
...
For simple construction of break periods (e.g. filling a method with an array of break periods inside a test case)
2020-04-05 21:29:03 +03:00
Joehu
493b654011
Remove horizontal margin from mod display
...
Can skew center alignment on fill flow containers.
Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.
2020-04-03 11:30:02 -07:00
Dan Balasescu
05e2ca0b68
Merge pull request #8590 from peppy/fix-intro-test-scene
...
Fix dynamic recompilation in intro test scenes
2020-04-03 19:40:46 +09:00
Dean Herbert
8cb0eb9b12
Fix dynamic recompilation in intro test scenes
2020-04-03 15:08:06 +09:00
Will Kennedy
877bd7837a
Changed variable names
2020-04-02 22:02:57 -04:00
Will Kennedy
c042e709a5
Fix GetDecoder getting fallback decoder too often
2020-04-02 20:43:54 -04:00
smoogipoo
a77933f5e0
Add support for parsing mania skin colours
2020-04-02 17:56:12 +09:00
Lucas A
1562612f41
Update visual tests and remove unessecary XMLDoc tag
2020-04-01 15:12:31 +02:00
Andrei Zavatski
e26fbd5ed8
Remove overcomplicated stuff
2020-03-31 13:45:59 +03:00
Dean Herbert
db59d0530e
Remove test coverage of scale down
2020-03-31 14:15:25 +09:00
Dean Herbert
1fce7cce01
Remove ScaleDownToFit as it was not implemented without enough safety
2020-03-31 13:50:04 +09:00
Lucas A
ab01111c36
Fix merge conflicts.
2020-03-30 17:39:11 +02:00
Andrei Zavatski
2dc81bbcfa
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container
2020-03-30 13:37:25 +03:00
Dean Herbert
35647d59a6
Add failing test
2020-03-30 19:09:05 +09:00
smoogipoo
1ce4f7c854
Add tests
2020-03-30 17:37:08 +09:00
Dan Balasescu
03cd9aa060
Merge branch 'master' into spun-out
2020-03-30 12:31:53 +09:00
Dan Balasescu
113bbe8c4d
Merge pull request #8488 from peppy/fix-autoplay-results-display
...
Fix auto mod results screen not displaying correctly
2020-03-30 11:01:16 +09:00
Dean Herbert
d99b445720
Move non-headless tests to correct namespace
2020-03-30 10:00:28 +09:00
Dean Herbert
98a700ef3a
Attempt to fix tests by skipping one break at a time
2020-03-30 00:58:06 +09:00
Endrik
f4c8b6d219
Fix copy paste oversight
2020-03-29 18:55:47 +03:00
Dean Herbert
a72f0f57f6
Refactor tests for readability
2020-03-30 00:05:07 +09:00
Dean Herbert
07c7233b3d
Change int div comments
2020-03-29 23:46:28 +09:00
Dean Herbert
653480b2f8
Add regression test
2020-03-29 23:29:46 +09:00
Dean Herbert
b259708915
Merge branch 'master' into spun-out
2020-03-29 13:24:48 +09:00
Endrik Tombak
8cab303611
Cover skipDifficulties = false in tests
2020-03-28 21:02:55 +02:00
Endrik Tombak
63f6269eb0
Test both ways
2020-03-28 13:10:20 +02:00
Endrik Tombak
659865b457
Use understandable set id
2020-03-28 13:08:06 +02:00
Endrik Tombak
0a69647efe
Merge remote-tracking branch 'origin/traversal-is-broken' into rewrite-select-next
2020-03-28 13:06:37 +02:00
Dean Herbert
3cc574e62d
Merge branch 'master' into overlay-scroll-container
2020-03-28 16:46:01 +09:00
Dean Herbert
e9dc545429
Merge branch 'master' into fix-no-break-info
2020-03-28 12:39:37 +09:00
Dean Herbert
a317ef65b8
Remove default for argument
2020-03-28 12:18:28 +09:00
Bartłomiej Dach
15fb1a099e
Modify assert to avoid false failures
...
In headless tests it was possible for TestInstantLoad() to erroneously
fail. There were two scenarios in which LoadingSpinner could be null:
1. If the test runner was quick enough, the assert could end up running
even before Loader.OnEntering() had even had a chance to, meaning
that the spinner was never even actually assigned to or instantiated
at that point in time.
2. Even if Loader.OnEntering() had managed to run, there was also
a possibility that the spinner itself wasn't loaded at the point
of checking the assertion. As the spinner is accessed through
ChildrenOfType(), which only checks InternalChildren and ignores
all currently-loading drawables, it would therefore return null.
As null != 0, both of these cases would actually fail the test (this is
best seen running headless, preferably with a [Repeat] attribute
attached).
To resolve, allow the spinner to be null at the point of asserting and
duplicate the assertion step at the end. This weakens the test, as case
(1) should probably be waited for and case (2) could be solved with
exposition as protected in the base, but when attempting to wait for
the loader itself to be loaded there were also cases where the
appropriate until step would take so much time that the spinner would
actually become visible in line with the delayed display logic, so this
is a best-effort attempt to address both points without radical
changes.
2020-03-28 00:43:57 +01:00
Bartłomiej Dach
46af4bce32
Cover regression in autoplay test
2020-03-27 19:42:45 +01:00
Andrei Zavatski
7b24cc325f
Implement OverlayScrollContainer component
2020-03-27 20:57:57 +03:00
Dean Herbert
6ecfeb8cc3
Merge pull request #8455 from Game4all/handle-novideo-beatmaps
...
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
Lucas A
6788b7f9cd
Add test for loading storyboards with missing video file.
2020-03-27 12:07:47 +01:00
Endrik Tombak
e707adb773
Increase amount of test sets
2020-03-26 21:16:10 +02:00
Endrik Tombak
902734b75e
Add failing test
2020-03-26 20:32:43 +02:00
TheWildTree
9a30ff5a00
Fix code quality issues
2020-03-26 16:11:58 +01:00
Lucas A
00c1ff993a
Fix merge conflicts.
2020-03-26 15:48:18 +01:00
Lucas A
c1ac57e70f
Add back visual tests and add easing to alpha fade.
2020-03-26 12:14:44 +01:00
