Gyoshi
921d7e4d89
More fitting tests for new layout
2023-05-23 18:16:10 +02:00
Bartłomiej Dach
2ce150ba2b
Add failing test case for sample undo
2023-05-22 22:23:05 +02:00
Bartłomiej Dach
843d2903d2
Add failing test case for slider velocity undo
2023-05-22 22:18:15 +02:00
Dean Herbert
ec2b9165d5
Adjust BeatDivisorControl
test to show control mmuch larger
2023-05-17 16:33:58 +09:00
Dean Herbert
ebce39cd1c
Add test coverage of failing sample bank transfer
2023-05-16 18:52:52 +09:00
Dean Herbert
8528fcaedc
Rename editor sample adjustment test scene to increase scope of tests
2023-05-16 18:52:52 +09:00
Dean Herbert
83dcd78826
Make HitSampleInfo.Bank
non-nullable
2023-05-16 18:12:56 +09:00
Bartłomiej Dach
a99bf0fc5a
Add test coverage
2023-05-14 12:29:24 +02:00
Bartłomiej Dach
9a327d95b8
Add test coverage
2023-05-14 11:24:24 +02:00
Dean Herbert
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
Dean Herbert
e42b0cc5b1
Merge pull request #23370 from peppy/fix-editor-playfield-padding
...
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
Bartłomiej Dach
95badb9455
Adjust composer tests to new screen layout
...
`TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
attempting to cover the case of the user clicking a toolbox button which
was in front of the playfield, and ensure that the click did not result
in a placement. However, since the paddings in
67f83f246b
were added, it is impossible
for a toolbox button to be in front of the playfield in the collapsed
state, which the test was relying on.
The test scenario is still however relevant in the case of the toolbox
being expanded, as in that state the toolbux buttons may very well end
up being in front of the playfield, and they still should not result in
a hitobject being placed. To ensure that this is the case, add a few
extra test steps ensuring that the toolbox is expanded first before
trying to retrieve an overlapping button.
2023-05-02 18:45:45 +02:00
Dean Herbert
e3c384c6b5
Merge branch 'master' into sample-control-points
2023-05-02 14:38:39 +09:00
Dean Herbert
983a8f7dfe
Merge branch 'master' into fix-reverse-crash
2023-05-02 13:14:34 +09:00
Dean Herbert
87db891143
Adjust test to reliabily fail
2023-05-02 13:12:11 +09:00
Bartłomiej Dach
1fb4c814f4
Remove no longer needed API call mocking
...
The online ID will be reset unconditionally after any local change is
made to any beatmap. That behaviour no longer depends on online lookups
succeeding or failing.
This may change at a later date when beatmap submission is integrated
into lazer - the idea is that online IDs would get re-populated on local
beatmaps once they are submitted to web.
2023-05-01 19:08:41 +02:00
Bartłomiej Dach
8ab3a87b13
Add failing test case covering online ID reset on save
...
This test scene passes at e58e1151f3
and
fails at current master, due to an inadvertent regression caused by
e72f103c17
.
As it turns out, the online lookup flow that was causing UI thread
freezes when saving beatmaps in the editor, was also responsible for
resetting the online ID of locally-modified beatmaps if online lookup
failed.
2023-05-01 18:17:35 +02:00
OliBomby
dbb2a8980b
add test
2023-05-01 15:56:23 +02:00
OliBomby
354cd23874
removed all usage of hitobject's DifficultyControlPoint
2023-04-26 18:17:02 +02:00
OliBomby
c44f71a737
remove all regular usage of DifficultyControlPoint
2023-04-26 17:55:38 +02:00
OliBomby
9f8d7bccba
fix usings
2023-04-26 17:34:02 +02:00
OliBomby
c6fc180659
remove all test usages of SampleControlPoint
2023-04-26 14:21:52 +02:00
Dean Herbert
13937cf555
Merge branch 'master' into stream-tool-2
2023-01-26 16:08:20 +09:00
naoey
a1b5c9d910
Don't transfer MD5 hashes in collections when copying beatmaps
...
Fixes #22306 .
Changes beatmap saving so that by default it does not transfer
the hashes in collections, and only transfers them when saving the same
difficulty in the editor.
Issue seems to have been introduced in https://github.com/ppy/osu/pull/20641 .
2023-01-22 01:14:18 +09:00
Dean Herbert
a1152fa0db
Merge pull request #22147 from Feodor0090/forbid-negative-snap
...
Forbid negative time snap in editor
2023-01-17 17:35:45 +09:00
Bartłomiej Dach
3102044d00
Add failing test for new difficulty creation
2023-01-14 18:46:14 +01:00
ansel
e8029e6390
Fix unrelated tests
2023-01-12 03:39:27 +03:00
Salman Ahmed
abca13eb6c
Rewrite visualisation piece to bind once and without potential event leak
2023-01-07 14:40:15 +03:00
Bartłomiej Dach
656bf12b3d
Add all possible timeline elements to test for demonstrative purposes
2023-01-01 19:42:46 +01:00
Bartłomiej Dach
a82f1a6abd
Adjust method naming and copy
2023-01-01 18:50:47 +01:00
Bartłomiej Dach
0e59b55a12
Merge branch 'master' into previewTime
2023-01-01 18:38:19 +01:00
Salman Ahmed
a665013626
Add failing test case
2022-12-23 00:56:38 +03:00
cdwcgt
a4d28aff6d
fix typo
2022-12-16 10:48:56 +09:00
cdwcgt
79e27c2d9d
PreviewTimePart
will not show if preview time is -1
2022-12-16 10:44:07 +09:00
cdwcgt
984f0b5fa9
Add test for set preview point
2022-12-16 01:35:54 +09:00
OliBomby
10b5900710
made PathControlPointVisualiser generic
2022-12-07 10:13:40 +01:00
Jai Sharma
8dcd1a2067
Add test to verify selected timing point will be scrolled into view
2022-11-27 02:48:15 +00:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework
2022-11-26 16:19:36 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Bartłomiej Dach
fca3e7e39f
Merge branch 'master' into editor-seek-control-points
2022-11-24 21:53:47 +01:00
Dean Herbert
37f725bfa2
Reverse directionality of up/down traversal keys to match scroll
2022-11-24 13:55:58 +09:00
Bartłomiej Dach
cf5f5a4de3
Extend tap timing control test coverage in no point selected case
2022-11-23 17:25:34 +01:00
Bartłomiej Dach
06449b62f1
Add test coverage for crash scenario
2022-11-23 16:11:57 +01:00
Dean Herbert
9b9b8a5977
Add ability to seek between control points in editor using down/up arrows
...
Matches stable. Addresses #21376 .
2022-11-23 15:59:32 +09:00
Bartłomiej Dach
1269afd0c5
Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu
...
Hide scroll speed control from effects section on rulesets which don't support it
2022-11-20 16:17:55 +01:00
Salman Ahmed
793d5b117e
Fix timing screen test scene not creating editor beatmap properly
2022-11-20 15:20:35 +03:00
Bartłomiej Dach
d587f29351
Update tests to reflect desired behaviour
2022-11-18 21:03:30 +01:00
Dean Herbert
0e502de8b4
Rename field to match usage
2022-11-02 18:04:42 +09:00
Dean Herbert
c3eb0c6330
Merge branch 'master' into editor-background
2022-11-02 17:43:38 +09:00
Dean Herbert
2a88409dfe
Fix time snap of sliders not matching when SV is not 1.0x
...
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.
Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.
The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
cdwcgt
6991195d69
let editor dim different from gameplay dim
2022-10-26 15:22:57 +09:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts
2022-10-25 22:17:08 +02:00
Bartłomiej Dach
bcdf24b972
Merge branch 'master' into add-editor-object-clone
2022-10-25 21:33:52 +02:00
Dean Herbert
8e4f5381e3
Add top level test coverage of editor shortcuts
2022-10-25 12:03:46 +09:00
Dean Herbert
1b42f5ec6e
Add test coverage of BeatDivisorControl
key bindings
2022-10-25 11:51:31 +09:00
Dean Herbert
4d4f6e25ba
Rename to "clone" instead of "duplicate"
2022-10-25 11:43:23 +09:00
Dean Herbert
da74690ec9
Add test coverage of clone operations
2022-10-25 11:38:58 +09:00
Dean Herbert
bea136ce50
Adjust test assert ordering to read better
2022-10-19 23:59:40 +09:00
Dean Herbert
579d5b51eb
Add and consume sample bank constants
2022-10-19 20:47:58 +09:00
Salman Ahmed
ba72f13f54
Merge branch 'master' into hide-mouse-on-keyboard-input
2022-10-14 22:26:30 +03:00
Dean Herbert
6608ada925
Fix test failures due to missing colour provider dependency
2022-10-13 17:05:11 +09:00
Salman Ahmed
9b45a9cf76
Rename various cursor symbols
...
- `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
- `MenuCursor` -> `MenuCursorContainer
2022-10-11 16:21:01 +03:00
ekrctb
0ade049252
Add test for selected hit object blueprint
2022-10-06 14:02:49 +09:00
ekrctb
2a7476cc4a
Add test for timeline drag selection
2022-10-05 23:29:45 +09:00
Drison64
c075d3de08
Create a test and a check if initial zoom value of ZoomableScrollContainer is in range
2022-09-17 22:43:40 +02:00
Dean Herbert
608c893b23
Add basic test guarantees
2022-09-13 15:03:13 +09:00
OliBomby
a1f4724685
moved the location of the tests
2022-09-13 01:38:29 +02:00
andy840119
e62999fb16
Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch/CatchRuleset.cs
# osu.Game.Rulesets.Osu/OsuRuleset.cs
# osu.Game.Rulesets.Taiko/TaikoRuleset.cs
# osu.Game/Rulesets/Ruleset.cs
2022-09-10 10:40:12 +08:00
Dean Herbert
579e7e1f17
Fix deleting a difficulty not updating the beatmap set hash
2022-09-06 18:12:47 +09:00
Dean Herbert
dc02b59a05
Add extra coverage to tests
...
Also fixes a potential failure due to test beatmap having two difficulties with same name.
2022-09-02 17:57:20 +09:00
Dean Herbert
65baf73d97
Add test scene
2022-09-02 16:50:28 +09:00
Dean Herbert
e9463f3c19
Test editor ComposeScreen
tests not adding beatmap to hierarchy
...
Makes it hard to test anything because `EditorBeatmap`'s `Update` method
updates whether a beatmap has timing or not (enabling the placement
controls).
Also adds a basic timing point to allow for better testing.
2022-08-31 14:07:56 +09:00
Dean Herbert
2dafa041a7
Account for offset being applied to editor clock time in TestSceneEditorClock
2022-08-29 16:42:50 +09:00
Dean Herbert
9c9238d6e8
Fix TimelineTestScene
's beatmap getting overwritten by EditorClockTestScene
2022-08-26 18:38:52 +09:00
Dean Herbert
4b72e55770
Fix various test scenes not adding EditorClock
to the draw hierarchy
2022-08-26 18:08:43 +09:00
Dean Herbert
553ae4781f
Remove unnecessary local implementation in TestScenePlaybackControl
2022-08-17 19:21:54 +09:00
Dean Herbert
4ef4d66f49
Add some extra initial state checks to TestSceneEditorSeekSnapping
2022-08-17 19:21:46 +09:00
Dean Herbert
58146598c8
Update TestSceneEditorClock
to use constraint-based assertions
2022-08-15 18:08:05 +09:00
Dan Balasescu
2de9e5f40f
Fix test failure
2022-08-09 20:23:45 +09:00
Dean Herbert
1270ee9624
Update multiple tests to use new assert output for easier to understand failures
2022-08-09 19:19:54 +09:00
Dean Herbert
7c952f8069
Add more test coverage of locally-modified state change
2022-08-05 14:25:10 +09:00
Dean Herbert
bacbf5b7f0
Update existing test expectations
2022-08-03 20:20:06 +09:00
Dean Herbert
2519706ad6
Add test coverage of editor crash
2022-08-01 16:53:49 +09:00
Salman Ahmed
bc2b629ee7
Let tests wait until track load before testing zoom
2022-07-25 12:07:50 +03:00
Salman Ahmed
123930306b
Refactor ZoomableScrollContainer
to allow setting up zoom range and initial zoom after load
2022-07-25 12:07:50 +03:00
Salman Ahmed
93175eaf6e
Re-enable timeline zoom test and remove flaky attribute
2022-07-25 11:39:23 +03:00
Dan Balasescu
0226b358ee
Disable timeline test for now
2022-07-25 13:20:33 +09:00
Dean Herbert
e20458421a
Update flaky timeline zoom test to output something useful
2022-07-22 16:05:20 +09:00
Dean Herbert
2e86e7ccee
Add extra steps to TestExitWithoutSave
to guarantee track type
2022-07-13 19:41:46 +09:00
為什麼
079fcf13a6
Add missing import.
2022-07-12 09:41:03 +08:00
andy
3dbd0c9055
Update osu.Game.Tests/Visual/Editing/TimelineTestScene.cs
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-07-12 09:37:16 +08:00
Joseph Madamba
6220650ea3
Fix dialog overlay not loading in time for headless test
2022-07-11 02:29:56 -07:00
為什麼
8e1ed1c621
Mark CreateHitObjectComposer() accept null.
...
And add the null check in the test case.
2022-07-10 10:15:27 +08:00
Joseph Madamba
5fcc4bf713
Add failing sample playback disabled check
2022-07-09 12:10:18 -07:00
Dean Herbert
c53dd4a703
Fix editor saving not updating BeatmapSetInfo
's hash
2022-07-08 02:33:14 +09:00
Dean Herbert
dd5b127fb5
Update various tests to enable NRT to avoid new inspection failures
2022-07-07 17:51:49 +09:00
Dan Balasescu
385bd5a1b2
Merge pull request #18965 from peppy/mark-flaky-tests
...
Mark, document and silence remaining flaky tests on standard CI runs
2022-07-03 21:41:14 +09:00
Dean Herbert
b597843579
Mark and document remaining flaky tests
2022-07-01 16:17:40 +09:00
Dean Herbert
98938821e5
Merge branch 'master' into beatmap-update-flow
2022-06-30 16:44:17 +09:00
Bartłomiej Dach
8171deec49
Attempt to fix editor navigation test failures again
...
First of all, stop relying that `InputManager` will successfully press
the gameplay test button, because it won't if it's obscured by the
notification overlay. Closing the overlay in a loop doesn't work because
there's a chance that a notification is posted, then all overlays are
closed, then another notification is posted, and so the button still
isn't clickable. Instead, use the `TestGameplay()` method directly.
Secondly, the notifications will still block `EditorPlayerLoader` from
transitioning to `EditorPlayer`. Here we have no other choice than to
aggressively dismiss notifications every spin of the relevant until
step and hope we eventually progress to `EditorPlayer`.
2022-06-29 22:45:56 +02:00