45172 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	e458f540ac	Adjust formatting	2024-12-19 14:54:57 +01:00
Bartłomiej Dach	7d1473c5d0	Simplify expand/contract code	2024-12-19 14:52:27 +01:00
Bartłomiej Dach	772ac2d326	Fix mod display not fading out after start of play ... This was very weird on master - `ModDisplay` applied a fade-in on the `iconsContainer` that lasted 1000ms, and `HUDOverlay` would stack another 200ms fade-in on top if a replay was loaded. Moving that first fadeout to a higher level broke fade-out because transforms got overwritten.	2024-12-19 14:48:18 +01:00
Bartłomiej Dach	b99b3a5bfd	Merge branch 'master' into tournament-hide-mp-commands	2024-12-19 13:10:45 +01:00
Bartłomiej Dach	6dc681f0e9	Annotate virtual as potentially nullable	2024-12-19 12:50:48 +01:00
Dean Herbert	dedf8ad093	Update resources	2024-12-19 17:42:00 +09:00
mini	c7354d9c41	Apply type inheritance check	2024-12-19 09:21:49 +01:00
Dean Herbert	47d81e7dee	Fix null inspections on GameplayChatDisplay	2024-12-17 19:10:09 +09:00
Dean Herbert	09fc30e377	Hide !mp commands from tournament streaming chat	2024-12-16 17:39:27 +09:00
Dean Herbert	d97ea78136	Change beat snap divisior adjust defaults to be Ctrl+Scroll instead of Ctrl+Shift+Scroll ... Matches stable. - [ ] Depends on https://github.com/ppy/osu/pull/31146, else this will adjust the global volume.	2024-12-16 15:22:30 +09:00
Dean Herbert	bdd417c1a1	Move "global" scroll-adjusts-volume to a per-screen component-based implementation	2024-12-16 15:21:07 +09:00
Bartłomiej Dach	d72a0b04b8	Merge pull request #31084 from NicholasChin28/mania-profile-overlay-tooltip ... Add missing mania tooltip overlay for 4k and 7k	2024-12-16 14:22:41 +09:00
Dean Herbert	85ada3275b	Skip the pause cooldown when in intro / break time ... Had a quick look at adding test coverage in `TestScenePause` but the setup to get into either of these states seems a bit annoying..	2024-12-16 14:14:30 +09:00
Bartłomiej Dach	8a2f161619	Merge pull request #31139 from peppy/settings-sensitivity ... Expose high precision mouse toggle when searching for "sensitivity" and other keywords	2024-12-16 13:40:32 +09:00
Bartłomiej Dach	9652c5a7ca	Merge pull request #31110 from peppy/timing-current-point-indicator ... Change the way "current" points are hinted on timing screen	2024-12-16 13:27:06 +09:00
Bartłomiej Dach	ecb7a809f2	Revert "Fix text anchor for mania tooltip" ... This reverts commit c0b6e784a5. The change affects editor and other stuff and I'm not sure it's correct. It's not like client needs to match the appearance really. It already doesn't in many places.	2024-12-16 13:18:47 +09:00
Bartłomiej Dach	cfdb959cf6	Split actual methods & fix completely broken localisation ... Localisable strings cannot be plainly interpolated or joined. That is a lossy operation that loses data.	2024-12-16 13:16:52 +09:00
Bartłomiej Dach	8d1d026f56	Clean up model ... - Properly annotate things as nullable - Remove weird passthrough property (more on that later)	2024-12-16 13:14:21 +09:00
Dean Herbert	a8948628e6	Expose high precision mouse toggle when searching for "sensitivity" and other keywords	2024-12-16 13:12:21 +09:00
Bartłomiej Dach	573d709fae	Merge pull request #31109 from peppy/fix-editor-timing-undo-redo ... Fix adjusting control point offset after undo/redo causing catastrophic failure	2024-12-16 12:40:22 +09:00
Bartłomiej Dach	98e8d0b497	Merge branch 'master' into timing-current-point-indicator	2024-12-16 12:22:14 +09:00
Bartłomiej Dach	1058abb4ab	Fix code quality	2024-12-16 12:22:06 +09:00
Bartłomiej Dach	a6e00d6eac	Implement ability to mark beatmap as played ... Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1. Would you believe it that this button that has been there for literal years never did anything? Implemented at a per-beatmap level. Also additionally added to context menu (at @peppy's suggestion), and also copy reworded from "Delete from unplayed" to "Mark as played" because double negation hurt my tiny brain.	2024-12-16 10:49:19 +09:00
Nicholas Chin	e2edd9e0d5	Fix code quality issues	2024-12-15 13:53:33 +08:00
Nicholas Chin	153e6c0c22	Use Count comparison instead of Any	2024-12-14 08:29:32 +08:00
Dean Herbert	c93b6dba2b	Merge pull request #31108 from peppy/quick-retry-for-replays ... Allow using "quick retry" shortcut in more cases from results screen	2024-12-13 08:18:59 -08:00
Nicholas Chin	c0b6e784a5	Fix text anchor for mania tooltip	2024-12-13 21:58:23 +08:00
Dean Herbert	9025103b8b	Reword comment to hopefully be more understandable	2024-12-13 20:02:17 +09:00
Dean Herbert	da840e3fac	Change the way "current" points are hinted on timing screen ... I actually thought things were bugged with the previous display method, since the hinting was very similar to the hover colour/state. I've adjusted this to hopefully give users a better idea of what this is intending to show them.	2024-12-13 19:45:18 +09:00
Dean Herbert	64555debc2	Fix adjusting control point offset after undo/redo causing catastrophic failure ... Closes https://github.com/ppy/osu/issues/31098. Low effort fix because it was already half broken. The test was testing in isolation but in actual editor usage it wasn't working as expected.	2024-12-13 19:33:51 +09:00
Dan Balasescu	35c70ceb18	Merge pull request #31106 from peppy/player-settings-fix-overlap-skins ... Fix player settings overlay cog overlapping skin elements	2024-12-13 19:30:39 +09:00
Dean Herbert	4b0cdd761d	Add note about player settings overlay button	2024-12-13 18:58:20 +09:00
Dan Balasescu	f84c67babd	Merge pull request #31101 from Joehuu/recommended-diff-beatmap-listing ... Add recommended difficulty numerical value near filter in beatmap listing	2024-12-13 18:57:16 +09:00
Dean Herbert	d00bc4bdd1	Also allow using "quick retry" for other replays	2024-12-13 18:14:45 +09:00
Dean Herbert	0e0d96829f	Fix "quick retry" hotkey not working for autoplay	2024-12-13 18:08:29 +09:00
Dean Herbert	a796af9511	Fix player settings overlay cog overlapping skin elements ... This brings it down to be in line with the flowing elements that usually do their best to not get in the way. Decided against putting it in the `HUDOverlay` flow for simplicity. It will work fine until it doesn't.	2024-12-13 17:28:15 +09:00
Dean Herbert	1e809c7f16	Fix player settings overlay appearing while in skin editor	2024-12-13 17:18:34 +09:00
Dan Balasescu	2930db5d6e	Merge pull request #31073 from bdach/filter-playing-rooms ... Add ability to filter out currently playing rooms	2024-12-13 17:03:30 +09:00
Dan Balasescu	7bb1a5118e	Unbind event on disposal	2024-12-13 16:39:16 +09:00
Dan Balasescu	62a1a5883a	Merge branch 'master' into recommended-diff-beatmap-listing	2024-12-13 16:38:07 +09:00
Dean Herbert	313de33986	Adjust padding to avoid wrapping on checkbox text	2024-12-13 15:42:30 +09:00
Joseph Madamba	38b3d5fc00	Update recommended difficulty for osu!taiko	2024-12-12 16:17:57 -08:00
Joseph Madamba	f7364de01a	Add test and null protections	2024-12-12 15:23:00 -08:00
Joseph Madamba	92e07b4f99	Add recommended difficulty numerical value near filter in beatmap listing	2024-12-12 15:23:00 -08:00
Joseph Madamba	e95dc2b308	Add FormatStarRating() method util	2024-12-12 15:23:00 -08:00
Joseph Madamba	3035e8435d	Apply NRT to incoming changed files	2024-12-12 15:22:58 -08:00
Nicholas Chin	a22f3416d6	Replace switch expression with LocalisableDescription attribute for variant display ... Use existing localisation strings from BeatmapsStrings instead of CommonStrings for consistent localisation handling	2024-12-12 22:39:21 +08:00
Bartłomiej Dach	0328708889	Store value of toggle to setting	2024-12-12 15:17:39 +09:00
Bartłomiej Dach	61ee830588	Adjust copy	2024-12-12 15:17:39 +09:00
Bartłomiej Dach	d8d5a00f3b	Merge branch 'master' into filter-playing-rooms	2024-12-12 13:06:22 +09:00
Bartłomiej Dach	88241d5b95	Merge pull request #30838 from smoogipoo/better-room-status ... Improve multiplayer room status handling	2024-12-12 13:05:59 +09:00
Dean Herbert	862b41c38e	Move BeatmapInfoWedgeV2 to correct namespace	2024-12-12 12:53:05 +09:00
Nicholas Chin	26f15def70	Add missing mania tooltip overlay for 4k and 7k	2024-12-11 23:15:05 +08:00
Dean Herbert	e8c0e27cc0	Adjust in line with upstream changes	2024-12-11 18:17:59 +09:00
Dean Herbert	0aa17a905b	Increase timed update frequency and add inline comment	2024-12-11 18:08:34 +09:00
Dean Herbert	a3998fbd52	Merge branch 'master' into better-room-status	2024-12-11 18:06:55 +09:00
Bartłomiej Dach	4e4a99decc	Merge pull request #31076 from peppy/beatmap-store-interface ... Access beatmap store via abstract base class	2024-12-11 17:48:32 +09:00
Dean Herbert	2a4f596f90	Merge branch 'master' into ios-beatmap-export	2024-12-10 23:59:15 -08:00
Dean Herbert	02c52e41bd	Merge pull request #31039 from frenzibyte/ios-temporary-export-storage ... Use temporary storage for file exports on iOS	2024-12-10 23:53:40 -08:00
Dean Herbert	a868c33380	Remove BeatmapCarousel testing backdoor	2024-12-11 16:28:51 +09:00
Dean Herbert	c94b393e30	Access beatmap store via abstract base class ... The intention here is to make things more testable going forward. Specifically, to remove the "back-door" entrance into `BeatmapCarousel` where `BeatmapSets` can be set by tests and bypas/block realm retrieval.	2024-12-11 16:28:51 +09:00
Dean Herbert	bab9b9c937	Remove no-longer-correct comment	2024-12-11 16:28:50 +09:00
Dean Herbert	de31a48beb	Some Carousel classes can be abstract	2024-12-11 16:28:50 +09:00
Bartłomiej Dach	c4374c7315	Merge branch 'master' into medal-display-fix	2024-12-11 15:52:38 +09:00
Salman Alshamrani	e0aec6f907	Revert unnecessary complexity	2024-12-11 01:03:55 -05:00
Bartłomiej Dach	89e3c551ff	Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files ... Allow choosing different background/audio files for individual difficulties	2024-12-11 14:12:58 +09:00
Bartłomiej Dach	b37a06c0fe	Hide "show playing rooms" toggle when in filter mode it doesn't make sense with	2024-12-11 13:24:54 +09:00
Bartłomiej Dach	3352571f2a	Add ability to filter out currently playing rooms ... Addresses https://osu.ppy.sh/community/forums/topics/2013293?n=1.	2024-12-11 13:24:08 +09:00
Bartłomiej Dach	637fe07b31	Rename Room{Status -> Mode}Filter ... I need the "status" term free for an upcoming change. And web calls this parameter "mode" as well: 642e973f91/app/Models/Multiplayer/Room.php (L184-L199) so it works in my head.	2024-12-11 12:36:42 +09:00
Salman Alshamrani	e6e79cbd11	Merge branch 'master' into silly-thing	2024-12-10 03:00:53 -05:00
Dean Herbert	bbaa542d4a	Add note about expensive operation	2024-12-10 16:45:26 +09:00
Dean Herbert	3cac583754	Rewrite resource changing code to be more legible (to my eye)	2024-12-10 16:45:26 +09:00
Dean Herbert	48bf2fa001	Merge pull request #30960 from bdach/bookmarks ... Implement basic bookmark support in editor	2024-12-09 23:42:04 -08:00
Bartłomiej Dach	7fcfebf4b4	Use Alt-{Left,Right} as default bindings for bookmark navigation	2024-12-10 14:59:19 +09:00
Dean Herbert	d69f5fd4cf	Avoid beatmap lookup per bar in logo visualisation ... Just noticed in passing.	2024-12-10 14:45:36 +09:00
Dean Herbert	92dfcae6eb	Adjust bad grammar	2024-12-10 14:35:09 +09:00
Dean Herbert	7ec2d91e14	Merge branch 'master' into editor-multiple-background-audio-files	2024-12-10 14:19:55 +09:00
Bartłomiej Dach	1febed66cf	Fix top score statistics section total score display being terminally broken ... Closes https://github.com/ppy/osu/issues/31038. If you don't realise why this does anything, realise this: the drawable creation callback runs for every created sprite text in the text flow. ANd the created sprite texts are split by whitespace. And Russian / Ukrainian / Polish etc. use spaces as thousands separators. So on those languages the first encountered part of the score would duplicate itself to the remaining parts. I'm actively convinced it was _more difficult_ to produce what was in place in `master` than to do it properly. Why did `TextColumn` even have `LocalisableString Text` and `Bindable<string> Current` next to each other?????	2024-12-09 23:51:57 +09:00
Salman Alshamrani	0c0dcb1e15	Use temporary storage for exported files on iOS	2024-12-09 08:16:37 -05:00
Salman Alshamrani	e9868c6318	Enable exporting beatmaps in iOS	2024-12-09 07:47:28 -05:00
Dan Balasescu	1b8d9370aa	Merge pull request #30973 from frenzibyte/copy-effect-points ... Preserve effect point specifications when creating blank difficulties	2024-12-09 16:13:52 +09:00
Bartłomiej Dach	459533aba6	Merge branch 'master' into bookmarks	2024-12-07 22:22:04 +09:00
Endrik Tombak	b04f5ab6e4	Fix IPC not working in release	2024-12-07 14:13:14 +02:00
Thomas Müller	0a00f7a7c2	Implement skinnable mod display ... Also makes the mod display initialization sequence (start expanded, then unexpand) controlled by HUDOverlay rather than mod display itself. This enabled different treatment depending on whether the mod display is viewed in the skin editor or in the player. Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-12-07 12:06:33 +09:00
Dean Herbert	b9f1fef250	Update framework	2024-12-07 10:46:03 +09:00
Dean Herbert	e22f3b7d05	Merge branch 'master' into named-pipe	2024-12-07 10:42:55 +09:00
Dean Herbert	5849a69a86	Merge pull request #30921 from huoyaoyuan/netcore-analyzer ... Set up-to-date .NET code quality analyzers	2024-12-06 17:29:09 -08:00
Salman Alshamrani	5cb6b86b1c	Fix reference effect point getting mutated	2024-12-06 05:47:41 -05:00
Dan Balasescu	8dda5aada8	Populate default LegacyType value on convert hitobjects ... Normally not an issue, but some tests create their own hitobjects deriving from `ConvertHitObject`.	2024-12-06 17:47:14 +09:00
Dan Balasescu	8b456e1379	Always convert mania spinners ... A big part of these changes is refactoring, which is somewhat necessary because it was previously implemented as two separate pathways which in-fact need to be joined at the hip when handling spinners. I've chosen to use `IHasLegacyHitObjectType` here because there's no other flag that allows us to tell `ConvertHold` apart from `ConvertSpinner`.	2024-12-06 16:40:28 +09:00
Dean Herbert	69014550b5	Remove unnecessary null checks	2024-12-06 12:48:06 +09:00
Dean Herbert	49f4b0e6ef	Update resources	2024-12-05 21:07:13 +09:00
Dean Herbert	84a85000af	Update framework	2024-12-05 21:07:08 +09:00
Dean Herbert	8d0e1f9d18	Merge branch 'master' into improve-menu-sample-playback	2024-12-05 21:07:03 +09:00
Huo Yaoyuan	d92ea910cf	Merge branch 'master' into netcore-analyzer	2024-12-05 17:18:56 +08:00
Dean Herbert	3d6e766b32	Merge pull request #30976 from frenzibyte/hide-some-settings ... Hide debug settings in release builds	2024-12-05 00:24:26 -08:00
Salman Alshamrani	1b1e7b63e9	Clean up code slightly	2024-12-05 02:48:51 -05:00
Dean Herbert	791416c8f1	Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score ... Fix score no longer being saved when quick-restarting after pass	2024-12-04 23:48:18 -08:00
Salman Alshamrani	7c1be5eca2	Remove unnecessary localisations	2024-12-05 02:45:43 -05:00
Salman Alshamrani	7ab16a55e5	Make debug section only visible on debug builds	2024-12-05 02:42:08 -05:00
Salman Alshamrani	f83ec721fb	Move latency certifier and import files button outside debug section	2024-12-05 02:42:08 -05:00
Dean Herbert	72aa65206d	Merge pull request #30965 from Susko3/use-GetLocalisedString ... Use `LocalisationManager.GetLocalisedString()` instead of bindable hack	2024-12-04 23:34:32 -08:00
Salman Alshamrani	a7586c52d0	Merge branch 'master' into results-screen-quick-retry-transition	2024-12-04 06:31:14 -05:00
Salman Alshamrani	fa87df6c6a	Move non-current handling to PerformExit ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2024-12-04 04:55:55 -05:00
Salman Alshamrani	8e0f6fc12d	Re-encode difficulties on resource change	2024-12-04 04:36:00 -05:00
Salman Alshamrani	60d91bada8	Merge branch 'master' into editor-multiple-background-audio-files	2024-12-04 04:31:15 -05:00
Salman Alshamrani	e3abbf1177	Copy effect points across on blank difficulty creation	2024-12-04 02:32:00 -05:00
Dan Balasescu	ad4df82593	Improve multiplayer listing search by making it fuzzy	2024-12-04 16:26:36 +09:00
Dean Herbert	a4d58648e2	Fix quick retry transition from results screen	2024-12-04 14:31:39 +09:00
Dean Herbert	296fa69edd	Add "buttons" as a search term for key bindings	2024-12-04 14:30:59 +09:00
Susko3	837744b0aa	Use LocalisationManager.GetLocalisedString() instead of bindable hack ... Made possible by https://github.com/ppy/osu-framework/pull/6377.	2024-12-03 23:29:39 +00:00
Bartłomiej Dach	d60b7f4798	Implement basic bookmark support in editor	2024-12-03 15:14:22 +01:00
Bartłomiej Dach	808934581f	Move bookmarks out of BeatmapInfo ... Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...	2024-12-03 14:17:14 +01:00
Dan Balasescu	f09d8f097a	Merge pull request #30953 from peppy/notification-while-chedcking-for-updates ... Show an ongoing operation when checking for updates	2024-12-03 17:27:10 +09:00
Dean Herbert	75781e3436	Update usages of IPC in line with framework changes	2024-12-03 16:34:23 +09:00
Dan Balasescu	be05f2a1c2	Merge pull request #30929 from timschumi/rate-change-ready ... Account for rate changing mods when disabling the "Ready" button	2024-12-03 16:30:16 +09:00
Dean Herbert	457957d3b8	Refactor check-update flow to better handle unobserved exceptions	2024-12-03 14:23:10 +09:00
Dean Herbert	2ceb3f6f85	Show an ongoing operation when checking for updates ... Addresses https://github.com/ppy/osu/discussions/30950.	2024-12-03 13:43:20 +09:00
Tim Schumacher	e920cfa187	Move rate-changing TODO to a common place in CalculateRateWithMods	2024-12-02 23:49:51 +01:00
Huo Yaoyuan	7ece8ec1dc	Update for suggestions	2024-12-03 00:03:59 +08:00
Huo Yaoyuan	68f4fa5a57	Turn off CA1507	2024-12-03 00:00:31 +08:00
Bartłomiej Dach	b505ecc7ba	Do not deselect objects when control-clicking without hitting anything ... As per feedback in https://discord.com/channels/90072389919997952/1259818301517725707/1310270647187935284.	2024-12-02 13:51:43 +01:00
Bartłomiej Dach	6c0ccc5ebe	Merge pull request #30863 from frenzibyte/improve-back-button-display ... Delay back button appearance when performing a quick restart	2024-12-02 11:49:45 +01:00
Bartłomiej Dach	52b8753a12	Merge pull request #30749 from Sheppsu/multi-spectator-settings-sidebar ... Add player settings to multi spectator screen	2024-12-02 11:34:57 +01:00
Dean Herbert	5b2558cec2	Merge pull request #28473 from bdach/beatmap-info-purge ... Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`	2024-12-02 16:19:12 +09:00
Dean Herbert	23522b02d8	Use local instead of field for local only usage	2024-12-01 19:53:57 +09:00
Dean Herbert	6afe083ec9	Fix settings showing up during gameplay	2024-12-01 18:44:26 +09:00
Dean Herbert	ddac71628d	Merge branch 'master' into multi-spectator-settings-sidebar	2024-12-01 18:33:46 +09:00
Salman Alshamrani	53dce83b56	Fix restarting no longer working from results screen ... Thanks to tests for pointing that out :blobsweat:	2024-12-01 02:13:20 -05:00
Salman Alshamrani	9140893249	Fix score no longer being saved when quick-restarting after pass	2024-11-30 23:36:02 -05:00
Tim Schumacher	164b809c89	Document ready button enable state with some comments	2024-11-30 23:02:22 +01:00
Tim Schumacher	f4e155bfa6	Account for rate changing mods when disabling the "Ready" button	2024-11-30 16:01:32 +01:00
Dean Herbert	1e2e364cd3	Stop loudly logging backwards seek bug to sentry ... Several users have reported stutters when this happens. It's potentially from the error report overhead. We now know that this is a BASS level issue anyway, so having this logging is not helpful.	2024-11-30 21:01:22 +09:00
Huo Yaoyuan	fa3c95c296	Merge branch 'master'	2024-11-30 01:07:08 +08:00
Bartłomiej Dach	e92aa36f47	Merge pull request #30918 from peppy/expose-more-migration-helper-methods ... Expose more migration helper methods	2024-11-29 14:55:45 +01:00
Dean Herbert	f56b2b9aef	Merge pull request #30793 from bdach/close-playlists ... Add ability to close playlists within grace period after creation	2024-11-29 22:37:32 +09:00
Dean Herbert	a719693d10	Fix one remaining method call	2024-11-29 21:21:05 +09:00
Dean Herbert	0e1b62ef85	Expose more migration helper methods ... For use in https://github.com/ppy/osu-queue-score-statistics/pull/305. Some of these might look a bit odd, but I personally still prefer having them all in one central location.	2024-11-29 21:10:30 +09:00
Dean Herbert	58efed4ebe	Merge pull request #30915 from bdach/extension-checks ... Centralise supported file extensions to one helper class	2024-11-29 20:55:28 +09:00
Bartłomiej Dach	5f092811cb	Use helper in one more place	2024-11-29 09:22:29 +01:00
Bartłomiej Dach	5a9127dfc6	Accidentally a word	2024-11-29 08:46:08 +01:00
Bartłomiej Dach	110e4fbb30	Centralise supported file extensions to one helper class ... As proposed in https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.	2024-11-29 08:42:45 +01:00
Dean Herbert	b697ddc6db	Simplify the dev footer display	2024-11-29 15:32:35 +09:00
Dean Herbert	276c37bcf7	Update framework	2024-11-29 13:47:56 +09:00
Salman Alshamrani	489d7a30ec	Perform a single Save call rather than doing it in each difficulty	2024-11-28 18:37:13 -05:00
Salman Alshamrani	311f0947e4	Abstractify resource change logic and share between background and audio	2024-11-28 17:57:47 -05:00
Salman Alshamrani	51bcde67aa	Remove no longer required comment	2024-11-28 17:55:15 -05:00
Salman Alshamrani	a8db35ac45	Merge branch 'master' into daily-challenge-tier-thresholds	2024-11-28 17:46:55 -05:00
Salman Alshamrani	932afcde01	Make editor make sense	2024-11-28 17:43:32 -05:00
Jamie Taylor	58cf1c11e4	Improve menu/context-menu sample playback	2024-11-29 06:54:48 +09:00
Huo Yaoyuan	fced254594	Enable selected rules for usage	2024-11-28 22:33:03 +08:00
Bartłomiej Dach	c93c549b05	Fix ready button not disabling on playlist close	2024-11-28 14:17:31 +01:00
Bartłomiej Dach	9926ffd326	Make button a little narrower	2024-11-28 14:06:12 +01:00
Bartłomiej Dach	ac2c4e81c7	Use switch	2024-11-28 14:04:39 +01:00
Bartłomiej Dach	2e6f43a75d	Merge branch 'master' into close-playlists	2024-11-28 14:01:36 +01:00
Huo Yaoyuan	f5a7716509	Apply minor performance rules	2024-11-28 20:41:44 +08:00
Huo Yaoyuan	13d7c6a2d8	Enable recommended rules for maintainability	2024-11-28 20:41:41 +08:00
Huo Yaoyuan	c57ace0b5f	Enable recommended rules for documentation	2024-11-28 20:41:32 +08:00
Bartłomiej Dach	d0e80ce982	Merge pull request #30895 from peppy/watch-replay-reliability ... Fix watch replay button sometimes not loading the replay on first click	2024-11-28 13:16:40 +01:00
Hiviexd	66093872e8	Adjust daily challenge tier thresholds to match expectations	2024-11-28 12:49:30 +01:00
Bartłomiej Dach	98a156ae2d	Merge pull request #30874 from peppy/chat-order ... Sort public chat channels alphabetically, private channels based on recent messages	2024-11-28 12:46:14 +01:00
Bartłomiej Dach	c14fe21219	Fix LCA call crashing in actual usage ... It's not allowed to call `LoadComponentsAsync()` on a background thread: fd64f2f0d4/osu.Framework/Graphics/Containers/CompositeDrawable.cs (L147) and in this case the event that causes the LCA call is dispatched from a websocket client, which is not on the update thread, so scheduling is required.	2024-11-28 11:19:00 +01:00
Dan Balasescu	1575eed5ba	Merge pull request #30893 from peppy/realm-perf-improvements ... Improve realm update performance	2024-11-28 19:08:22 +09:00
Dan Balasescu	077719903b	Merge pull request #30905 from peppy/fix-multiple-offset-applications ... Clear previous `LastLocalUserScore` when returning to song select	2024-11-28 18:58:13 +09:00
Bartłomiej Dach	b0958c8d41	Attempt to fix test failures	2024-11-28 10:29:53 +01:00
Dean Herbert	ced8dda1a2	Clear previous LastLocalUserScore when returning to song select ... This seems like the lowest friction way of fixing https://github.com/ppy/osu/issues/30885. We could also only null this on application, but this feels worse because - It would require local handling (potentially complex) in `BeatmapOffsetControl` if we want to continue displaying the graph and button after clicking it. - It would make the session static very specific in usage and potentially make future usage not possible due to being nulled in only a very specific scenario. One might argue that it would be nice to have this non-null until the next play, but if such a usage comes up I'd propose we rename this session static and add a new one with that purpose.	2024-11-28 18:01:28 +09:00
Bartłomiej Dach	0d491e3159	Merge branch 'master' into fix-daily-challenge-leaderboard	2024-11-28 09:41:24 +01:00
Dan Balasescu	5d7aafaab3	Merge pull request #30894 from HenintsoaSky/star-fountains-toggle-setting ... Add a toggle for star fountains during gameplay	2024-11-28 17:35:11 +09:00
Salman Alshamrani	b1d0939142	Add localisation support	2024-11-28 02:37:31 -05:00
Salman Alshamrani	4a1401a33d	Rewrite bindable flow to make more sense	2024-11-28 02:37:27 -05:00
Dean Herbert	70eee8882a	Remove unnecessary null check	2024-11-28 15:42:37 +09:00
Dean Herbert	32b34c1967	Rename container to make more sense	2024-11-28 15:20:51 +09:00
Dean Herbert	4d9d5adbf4	Rename parameter to be more clear	2024-11-28 15:13:59 +09:00
Dean Herbert	e0fdcaf523	Merge pull request #30848 from Joehuu/dicord-fix-beatmap-button-visibility ... Fix discord "view beatmap" button being shown when editing and hide identifiable information is set	2024-11-28 13:29:09 +09:00
Salman Alshamrani	24c0799680	Move beatmap ID lookup to UesrActivity	2024-11-27 16:54:51 -05:00
Salman Alshamrani	f792b6de00	Fix comment	2024-11-27 06:07:10 -05:00
Salman Alshamrani	4ae3ccfe48	Make BackButtonVisibility in game class private	2024-11-27 06:05:02 -05:00
Salman Alshamrani	efb68e4232	Refactor ResourcesSection to support new form of selection	2024-11-27 05:53:22 -05:00
Salman Alshamrani	b70fb4b0fe	Add FormBeatmapFileSelector for intermediate user-choice step	2024-11-27 05:52:43 -05:00
Dean Herbert	0f73941808	Combine new implementation back into the old one and use everywhere	2024-11-27 17:47:42 +09:00
Dean Herbert	7fdf13911b	Adjust the colour of non-pinned settings groups' headers to be more legible	2024-11-27 17:47:27 +09:00
Dean Herbert	782ce24ca6	Move player settings out of right flow	2024-11-27 17:09:15 +09:00
Dean Herbert	9c707ed341	Rename class and fix padding considerations	2024-11-27 16:47:54 +09:00
Dean Herbert	5ce55e9cb4	Merge branch 'master' into multi-spectator-settings-sidebar	2024-11-27 16:35:05 +09:00
Dean Herbert	4fcc76270a	Ensure events are unbound on disposal as a safety	2024-11-27 15:46:55 +09:00
Dean Herbert	5260a401d4	Use RealmLive in SaveFailedScoreButton ... This also optimises the manager classes to better support `Live` usage where the managed object is already in a good state (ie. doesn't require re-fetching).	2024-11-27 15:25:42 +09:00
Salman Alshamrani	dfbccc2144	Knock some sense into the playlists results screen implementation ... As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint, the existing playlists results screen classes needed some restructuring.	2024-11-27 01:20:43 -05:00
Dean Herbert	aa3d3a6344	Remove unnecessary local subscription in BeatmapCarousel ... Not sure why I left this around during the refactor. This is 100% handled by the `DetachedBeatmapStore`. Removing this subscription reduces overheads by a huge amount for users with large beatmap databases. My hypothesis is that subscriptions are more expensive based on **the number of results matching**. This one matches almost every beatmap so removing it is a large win.	2024-11-27 14:24:57 +09:00
HenintsoaSky	a477bb7bfe	Renaming of 'StarFountainEnabled'	2024-11-27 07:38:33 +03:00
Dean Herbert	573aaf6637	Merge pull request #27128 from frenzibyte/user-statistics-provider ... Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset	2024-11-27 13:13:47 +09:00
Salman Alshamrani	9083daf363	Fix epic code failure ... I wasn't feeling well last night.	2024-11-26 20:04:36 -05:00
Salman Alshamrani	3e1b4f4ac5	Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2024-11-26 16:52:39 -05:00
HenintsoaSky	80a66085a9	rename and remove again	2024-11-27 00:41:02 +03:00
HenintsoaSky	460471e73f	Rename of the setting	2024-11-27 00:27:22 +03:00
HenintsoaSky	df74a177ae	Add option to disable star fountain in gameplay	2024-11-27 00:13:32 +03:00
Joseph Madamba	9173a74552	Merge branch 'master' into xxx-add-localisation-support-for-menu-tip	2024-11-26 12:13:08 -08:00
Joseph Madamba	f04862ea74	Edit one more word not using british english	2024-11-26 12:11:29 -08:00
Bartłomiej Dach	33c2eb1af7	Merge pull request #30881 from peppy/fix-editor-state-leaking ... Fix hitobjects' samples getting in bad state when changing selection between objects	2024-11-26 13:54:50 +01:00
Bartłomiej Dach	3e373ae85e	Merge pull request #30868 from peppy/ur-perf-fix ... Improve performance of UR calculations	2024-11-26 13:54:17 +01:00
Dan Balasescu	4c7976bb93	Remove unused using	2024-11-26 21:11:48 +09:00
Dan Balasescu	af0c6fc51b	Add Room.HasEnded helper method	2024-11-26 21:09:28 +09:00
Bartłomiej Dach	46d1f00590	Fix Beatmap.Countdown not being copied on conversion	2024-11-26 11:39:03 +01:00
Bartłomiej Dach	cf905d0f5c	Merge branch 'master' into beatmap-info-purge	2024-11-26 10:21:16 +01:00
Dean Herbert	bf29e3ae71	Simplify hide code by moving to common method	2024-11-26 18:00:32 +09:00
Dean Herbert	71294c312b	Change point of queueing to avoid loading-from-in-queue	2024-11-26 17:58:50 +09:00
Dean Herbert	98044c108e	Revert "Ensure DrawableMedal loading doesn't ever block on online resources" ... This reverts commit 8585327858.	2024-11-26 17:41:12 +09:00
tsrk.	41c309fb72	chore(MenuTip): update text according to recent changes ... Signed-off-by: tsrk. <tsrk@tsrk.me>	2024-11-26 09:35:18 +01:00
Dean Herbert	3ecb3b674d	Don't reset state when changing from one selection to another in the editor ... This was causing state pollution in the new selection. I can't see why this needs to happen when a selection changes to another. This fixes https://github.com/ppy/osu/issues/30839 and also the same issue happening for the new combo toggle. Tests all seem to pass, and I can't immediately find anything broken, but YMMV.	2024-11-26 17:33:41 +09:00
Dan Balasescu	d3d111de7d	Merge pull request #30832 from peppy/mania-precise-scroll-speed ... Allow setting osu!mania scroll speed to single decimal precision	2024-11-26 17:30:56 +09:00
Dean Herbert	1e6c04e98b	Remove debug logging	2024-11-26 16:11:06 +09:00
Salman Alshamrani	42c68ba43e	Add inline comment	2024-11-26 01:28:58 -05:00
Salman Alshamrani	b76460f100	Schedule the thing ... Queuing up requests on change to `api.LocalUser` is bad because the API state is updated after `LocalUser` is updated, therefore we have to schhhhhedullllllllleeeeeeeeeeeeeeee.	2024-11-26 01:26:44 -05:00
Dean Herbert	e3ea38a366	Add setting to allow hold-for-pause to still exist ... Users have asked for this multiple times since last release. Not sure on the best default value, but I'm going with the stable/classic one, at least for the initial release to avoid needing migrations. In the future we may reconsider this for new users.	2024-11-26 15:14:19 +09:00
Salman Alshamrani	7201bac60d	Remove DailyChallengePlayer	2024-11-26 01:10:19 -05:00
Salman Alshamrani	c1416f9920	Bring back user-based endpoint for viewing result screen from playlists lounge	2024-11-26 01:10:12 -05:00
Salman Alshamrani	d150aeef2b	Use score-based endpoint everywhere	2024-11-26 01:01:59 -05:00
Dean Herbert	e8fae85e8d	Fix hidden dissmissing logic	2024-11-26 14:45:40 +09:00
Dean Herbert	672dbe6e03	Better control of show/hide of overlay	2024-11-26 14:42:30 +09:00
Dean Herbert	d057dc9a95	Refactor MedalOverlay to be more readable ... Shouldn't really have any functionality changes, just fixing some old code that I can't easily parse these days.	2024-11-26 14:19:39 +09:00
Dean Herbert	8585327858	Ensure DrawableMedal loading doesn't ever block on online resources	2024-11-26 14:08:53 +09:00
Salman Alshamrani	dfa21574fd	Merge branch 'master' into xxx-add-localisation-support-for-menu-tip	2024-11-25 23:52:56 -05:00
Dean Herbert	17347563ee	Fix incorrect null handling	2024-11-26 13:25:57 +09:00
Dean Herbert	f708466a9b	Add test coverage	2024-11-26 13:25:55 +09:00
Dean Herbert	d6cf1db0f5	Add basic xmldoc to results class	2024-11-26 12:16:26 +09:00
Dean Herbert	d903d381d5	Rename NextProcessableIndex to EventCount in line with actual functionality	2024-11-26 12:10:34 +09:00
Dean Herbert	9ca17f9b6b	Merge pull request #30748 from stanriders/scale-profile-beatmaps ... Scale down beatmap cards	2024-11-25 22:53:51 +09:00
Bartłomiej Dach	0a3f3c3210	Add guard against fetching statistics for non-legacy rulesets	2024-11-25 13:14:22 +01:00
Dean Herbert	bbe8f2ec44	Only update unstable rate counter when an applicable hitobject is reached	2024-11-25 21:13:18 +09:00
Dean Herbert	ea68d4b33a	Use class instead of record for lower allocations	2024-11-25 21:13:18 +09:00
Dean Herbert	5668258182	Add incremental processing	2024-11-25 21:13:17 +09:00
Bartłomiej Dach	78c01c1b5a	Merge branch 'master' into beatmap-defaults-match-stable	2024-11-25 12:55:08 +01:00
Dean Herbert	33d725e889	Address unstable rate calculations as a list for marginal gains	2024-11-25 19:44:11 +09:00
Dean Herbert	605fe71f46	Make empty hitwindows readonly static and slightly improve comparison performance	2024-11-25 19:17:32 +09:00
Bartłomiej Dach	1410e8837a	Merge branch 'master' into better-room-status	2024-11-25 09:48:40 +01:00
Dean Herbert	82bdd8fbfc	Merge pull request #30861 from frenzibyte/fix-multiplayer-missing-hold-delay ... Fix pause shortcut on multiplayer no longer requiring hold	2024-11-25 16:22:56 +09:00
Dean Herbert	876c2e468a	Merge pull request #30858 from frenzibyte/fix-match-settings-overlay-typo	2024-11-25 15:58:17 +09:00
Salman Alshamrani	1468385559	Reset new file states after syncing	2024-11-24 22:38:48 -05:00
tsrk.	cfaf972813	Merge branch 'master' into xxx-add-localisation-support-for-menu-tip	2024-11-24 18:24:43 +01:00
Dean Herbert	c34827a4ed	Merge pull request #30862 from frenzibyte/dont-scare-the-player ... Don't play fail animation if restarting on fail	2024-11-24 23:11:19 +09:00
tsrk.	8611ed31c2	refactor(MenuTip): add localisation support ... Signed-off-by: tsrk. <tsrk@tsrk.me>	2024-11-24 14:22:56 +01:00
Dean Herbert	888f02e3a6	Merge pull request #30855 from SupDos/tips-remove-fps ... Remove FPS shortcut tip	2024-11-24 19:57:08 +09:00
Salman Alshamrani	ae9119eef0	Hide back button when quick-restarting unless load time takes long	2024-11-24 05:40:06 -05:00
Salman Alshamrani	2420793466	Allow controlling back button visibility state from screens	2024-11-24 05:39:43 -05:00
Salman Alshamrani	6d0d7f3e75	Don't play fail animation if restarting on failure	2024-11-24 04:45:48 -05:00
Salman Alshamrani	f3155bfc7d	Fix pause shortcut on multiplayer not delayed	2024-11-24 04:24:31 -05:00
Salman Alshamrani	631bfadd68	Replace event subscription with callback in UserStatisticsWatcher ... Also no longer cancels previous API requests as there's no actual need to do it.	2024-11-24 04:11:13 -05:00
Salman Alshamrani	3480da22d2	Remove no-op SaveState call	2024-11-24 01:13:39 -05:00
Salman Alshamrani	95a6226413	Only enable button if there are different filenames	2024-11-24 01:11:36 -05:00
Salman Alshamrani	a872f74974	Make sync button only affect changed resource type	2024-11-24 01:02:34 -05:00
Salman Alshamrani	c8b13b726d	Add localisation support	2024-11-24 00:45:17 -05:00