Bartłomiej Dach
7f52ae8837
Fix code quality inspection
2024-09-18 15:30:56 +02:00
Bartłomiej Dach
f6195c5515
Add to existing selection when dragging with control pressed
...
Closes https://github.com/ppy/osu/issues/29023 .
2024-09-18 15:18:13 +02:00
Bartłomiej Dach
12bd516a57
Shuffle playback order in global playlist by default
...
RFC. Closes https://github.com/ppy/osu/issues/18169 .
Implements the given proposal of keeping the current stable order but
adding a shuffle facility to the now playing overlay, and enabling it by
default.
There are more changes I want to make here but I'd like this to get
discussion first, because I am likely to continue putting this sort of
selection logic into `MusicController` and I just want to confirm nobody
is going to have a problem with that.
In particular this is not sharing the randomisation implementation with
beatmap carousel because it doesn't generalise nicely (song select cares
about the particular *beatmap difficulties* selected to rewind properly,
while the music controller only cares about picking a *beatmap set*).
2024-09-18 14:19:55 +02:00
Bartłomiej Dach
cf9f8c7f66
Merge pull request #29916 from peppy/fix-song-select-crash-selection-after-loading
...
Fix occasional song select crash when entering gameplay
2024-09-18 11:44:59 +02:00
Bartłomiej Dach
d506d8a150
Implement TabbableContentContainer for slider control
2024-09-18 11:32:55 +02:00
Bartłomiej Dach
093d9ab076
Keep slider bar looking active when dragging outside of its bounds
2024-09-18 11:30:52 +02:00
Bartłomiej Dach
0bab755be3
Add missing xmldoc
2024-09-18 11:25:23 +02:00
Bartłomiej Dach
95e26e6fd8
Make slider bar instantaneous by default (and fix broken implementation)
2024-09-18 11:23:00 +02:00
Dean Herbert
ac507a3ba5
Remove unused parameter in applyActiveCriteria
2024-09-18 17:22:09 +09:00
Dean Herbert
743d509241
Also ensure filter is applied when returning to song select
2024-09-18 17:22:08 +09:00
Dean Herbert
c192a6a1d5
Fix song select crashes due to attempting to clear selection after load has already begun
2024-09-18 16:12:34 +09:00
Dean Herbert
8f49876fe7
Re-sync judgement counter display after replay frame reset
2024-09-18 15:28:11 +09:00
Dean Herbert
c46e9cbce3
Tidy up JudgementCounter classes
2024-09-18 15:28:10 +09:00
Dean Herbert
2d993645af
Add test coverage of judgements not being synced when resuming a replay
2024-09-18 15:28:10 +09:00
Joseph Madamba
fd6b3b6b36
Fix searching by clicking title/artist in beatmap overlay not following original language setting
2024-09-17 22:34:06 -07:00
Dean Herbert
76c5e743d7
Remove opacity from old style dropdown menus
...
These aren't used in many places, but we've since moved away from
opacity in UI elements like this, so let's just nuke it here for
legibility.
Addresses https://github.com/ppy/osu/discussions/29906 .
2024-09-18 13:49:27 +09:00
Bartłomiej Dach
1b17231da4
Implement "form" slider bar control
2024-09-17 11:40:57 +02:00
Dean Herbert
d34e8ea69e
Update framework
2024-09-16 16:15:09 +09:00
OliBomby
30096c1c71
clean up code
2024-09-14 17:26:04 +02:00
kongehund
385eb5eed5
Rewrite GetConvexHull
2024-09-14 16:32:51 +02:00
Dean Herbert
5ea7061d5a
Merge pull request #29712 from bdach/editor/setup-screen-checkbox
...
Implement "form" check box control
2024-09-14 02:26:59 +09:00
Dean Herbert
562a5006ea
Change log output to only output when matches are found (in line with other methods)
2024-09-14 02:19:52 +09:00
Bartłomiej Dach
a4f6d4a300
Backpopulate missing ranked/submitted dates using new local metadata cache
...
People keep asking why https://github.com/ppy/osu/pull/29553 didn't fix
their databases (as stated in the PR, it didn't intend to), so this
should do it for them.
2024-09-13 16:00:49 +02:00
Bartłomiej Dach
7f71ef4547
Only allow seek to next/previous object via keybinding if there is no selection
2024-09-13 15:14:09 +02:00
Bartłomiej Dach
929ea87975
Revert to checkbox on right
2024-09-13 14:53:59 +02:00
Bartłomiej Dach
652a590611
Attempt to address design concerns
2024-09-13 09:59:20 +02:00
Dean Herbert
77c3cb6504
Update framework
2024-09-12 14:38:51 +09:00
Dean Herbert
a8365202d9
Merge pull request #29841 from bdach/replay-analysis-mod-woes
...
Fix several issues in interactions between playfield-altering mods and the replay analysis feature
2024-09-12 13:52:09 +09:00
Bartłomiej Dach
4a39873e2a
Fix replay analysis overlay not rotating with Barrel Roll enabled
...
Closes https://github.com/ppy/osu/issues/29839 .
2024-09-11 15:54:30 +02:00
Bartłomiej Dach
b78ef81bf1
Fix Flashlight not appearing on top of bubbles from Bubbles mod
...
Inadvertently regressed in 44d0dc6113
2024-09-11 15:54:07 +02:00
apollo-dw
a7e1d35f64
Update osu.Game/Rulesets/Difficulty/DifficultyAttributes.cs
...
Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-09-11 12:29:17 +01:00
Bartłomiej Dach
0e663d1801
Revert default combo counter code to pre-abstractification (and nuke eldritch abstract entity)
2024-09-11 11:44:59 +02:00
Bartłomiej Dach
f0e2b803de
Merge pull request #29766 from SchiavoAnto/29761-fix-blocked-info
...
Fix timing points being blocked by buttons in the editor
2024-09-08 18:37:59 +02:00
Bartłomiej Dach
7ec2e0e866
Refactor layout code to be a bit less haphazard
...
Visually the same, functionally much saner.
2024-09-08 16:30:09 +02:00
Bartłomiej Dach
f5c5614eef
Resolve existing colour provider instead of re-caching own one
2024-09-08 16:29:53 +02:00
Bartłomiej Dach
cefbc76490
Fix selection being dropped when changing carousel sort mode from difficulty sort
...
Closes https://github.com/ppy/osu/issues/29738 .
This "regressed" in https://github.com/ppy/osu/pull/29639 , but if I
didn't know better, I'd go as far as saying that this looks like a .NET
bug, because the fact that PR broke it looks not sane.
The TL;DR on this is that before the pull in question, the offending
`.Contains()` check that this commit modifies was called on a
`List<BeatmapSetInfo>`. The pull changed the collection type to
`BeatmapSetInfo[]`. That said, the call is a LINQ call, so all good,
right?
Not really. First off, the default overload resolution order means that
the previous code would call `List<T>.Contains()`, and not
`Enumerable.Contains<T>()`. Then again, why would that matter? In both
cases `T` is still `BeatmapSetInfo`, right? Well... about that...
It is difficult to tell for sure what precisely is happening here,
because of what looks like runtime magic. The end *symptom* is that the
old code ended up calling `Array<BeatmapSetInfo>.IndexOf()`, and the new
code ends up calling... `Array<object>.IndexOf()`.
So while yes, `BeatmapSetInfo` implements `IEquatable` and
the expectation would be that `Equals<BeatmapSetInfo>()` should be
getting called, the type elision to `object` means that we're back to
reference equality semantics, because that's what
`EqualityComparer.Default<object>` is.
A five-minute github search across dotnet/runtime yields this:
c4792a228e/src/coreclr/vm/array.cpp (L984-L990)
2024-09-08 16:06:35 +02:00
schiavoanto
2e6f17f253
Fixed wrong OverlayColourScheme
2024-09-08 16:04:10 +02:00
schiavoanto
cf23c6668c
Added background color to hide beatmap background
2024-09-08 15:59:23 +02:00
Dean Herbert
4a6266efcf
Merge pull request #29714 from Crystallized21/total-participation-tooltip
...
Add Total Participation stat to users profile Daily Challenge Tooltip
2024-09-08 22:42:02 +09:00
Bartłomiej Dach
7f814d3106
Fix incorrect tiers being used for tooltip total participation display
...
Compare: 95e4561a54
2024-09-08 14:26:50 +02:00
Ianlucht
cd94d6e2bc
fixed if statement format
2024-09-07 14:01:38 -06:00
Ianlucht
e6f81abc3b
cleaned up whitespace
2024-09-07 13:57:12 -06:00
Ianlucht
170737b68f
added DailyChallengeIntro to notification
2024-09-07 13:48:14 -06:00
Ianlucht
958bfde51d
added DailyChallengeIntro to notification
2024-09-07 13:46:42 -06:00
schiavoanto
2bc6547d49
Code quality fix: added type
2024-09-07 16:23:23 +02:00
schiavoanto
32de8e9b2d
Fixed ControlPointTable items being blocked by buttons
2024-09-07 16:15:00 +02:00
Dean Herbert
4c6eb89530
Fix beatmap difficulties not being split out on first load
...
Closes https://github.com/ppy/osu/issues/29728 .
2024-09-07 22:14:03 +09:00
Dean Herbert
7f687d545d
Merge pull request #29715 from bdach/fix-stall-on-empty-replay-import-attempt
...
Fix stall when attempting to import replay after hitting nothing
2024-09-07 22:01:31 +09:00
Dean Herbert
10ef5a6d6d
Update framework
2024-09-07 21:46:43 +09:00
Dan Balasescu
02eb6835e3
Merge pull request #29745 from Ianlucht/fix-beatmap-artist-and-title-search-to-include-double-quotes-resolves#29708
...
Double-quote in beatmap listing when searching by artist/title
2024-09-07 18:42:27 +09:00
Dan Balasescu
ac6cce5911
Refactor to string interpolation
2024-09-07 17:40:33 +09:00
Dan Balasescu
6fb5c10f19
Merge pull request #29742 from SchiavoAnto/29736-results-collections-overflow
...
Fix collections overflowing in the results screen
2024-09-07 17:37:11 +09:00
Bruno Heredia
3b81ad4cbf
Fix scroll speed slider defaulting to 0.01
2024-09-07 01:44:40 -03:00
Ianlucht
581f190856
fixed issues with search by adding the double quotation marks in the BeatmapSetHeaderContents links.
2024-09-06 16:31:48 -06:00
schiavoanto
ed044d5b85
Fix proposal for #29736
2024-09-06 22:58:18 +02:00
Bartłomiej Dach
4e9ad1388f
Fix stall when attempting to import replay after hitting nothing
2024-09-06 13:16:58 +02:00
Michael Bui
a31ea24c6d
show stats on all rulesets
2024-09-06 23:05:04 +12:00
Michael Bui
362b4bbc56
Hide daily challenge stats if there are no plays
2024-09-06 23:01:05 +12:00
Michael Bui
ab8771900a
change colour
2024-09-06 22:04:10 +12:00
Michael Bui
34a9d60c19
revert back to axes.both
2024-09-06 22:02:35 +12:00
Michael Bui
f59895aa34
take out drawable
2024-09-06 21:54:41 +12:00
Michael Bui
15f73a3dfb
show participation count in tooltip
2024-09-06 21:52:42 +12:00
Bartłomiej Dach
2c19b7994c
Implement "form" check box control
2024-09-06 11:45:13 +02:00
Dean Herbert
04d133832f
Merge pull request #29711 from smoogipoo/add-played-acronyms
...
Add 'yes'/'no' acronyms to the `played=` filter
2024-09-06 18:08:37 +09:00
Dan Balasescu
6913d75792
Add 'yes'/'no' acronyms to the played= filter
2024-09-06 18:04:39 +09:00
Bartłomiej Dach
9f834ca1a2
Silence beatmap retrieval failures from results screen favourite button
...
As reported (very poorly) in
https://github.com/ppy/osu/pull/28991#issuecomment-2331854970 .
I believe this is a total edge case and is mostly visible on dev due to
some beatmaps existing on `osu.ppy.sh` and not on `dev.ppy.sh`, but I
tend to agree in general that these types of failures should not be
firing very loud error notifications; logging to network and disabling
the button with a tooltip adjustment should be enough.
2024-09-06 10:29:23 +02:00
Bartłomiej Dach
925710d9b3
Merge pull request #29702 from peppy/fix-offset-control-wrong-order
...
Fix beatmap offset control not working correctly when calibrating from quitting gameplay
2024-09-06 09:39:14 +02:00
Dean Herbert
36a30cf077
Add note about using hard links in the future
2024-09-06 16:01:47 +09:00
Fabep
584d4a9abf
Merge branch 'master' into ModCustomisationHeaderColor
2024-09-05 12:44:26 +02:00
Dean Herbert
9802b59459
Merge pull request #29693 from bdach/editor/setup-screen-textbox
...
Implement "form" text box control
2024-09-05 19:31:02 +09:00
Dean Herbert
37f61b26ea
Fix offset adjust control not correctly applying changes after song select quit
...
This is an interesting scenario where we arrive at a fresh
`BeatmapOffsetControl` but with a reference score (from the last play).
Our best assumption here is that the beatmap's offset hasn't changed
since the last play, so we want to use it for the `lastPlayBeatmapOffset`.
But due to unfortunate order of execution, `Current.Value` was not yet
initialised.
2024-09-05 19:04:52 +09:00
Dean Herbert
c51503cfee
Merge pull request #29695 from peppy/fail-t-request-on-null-response
...
Trigger request failure on receiving a null response for a typed `APIRequest`
2024-09-05 18:31:54 +09:00
Bartłomiej Dach
3a3a912ebc
Merge pull request #29701 from peppy/fix-gc-fuck-fuck-fuck
...
Fix high performance session potentially getting stuck after multiplayer spectator
2024-09-05 11:24:54 +02:00
Bartłomiej Dach
49b14ad579
Merge branch 'master' into editor/setup-screen-textbox
2024-09-05 11:22:10 +02:00
Bartłomiej Dach
e1b763ff0d
Apply review suggestions wrt border appearance
2024-09-05 11:21:59 +02:00
Dean Herbert
446c8109b7
Merge pull request #27334 from Sheppsu/replay-analysis-settings
...
Add a replay analysis overlay
2024-09-05 17:43:00 +09:00
Dean Herbert
86a06c7e10
Fix high performance session potentially getting stuck after multiplayer spectator
2024-09-05 17:19:53 +09:00
Dean Herbert
6fc60908c0
Trigger request failure on receiving a null response for a typed APIRequest
2024-09-05 01:00:23 +09:00
Fabep
17760afa60
Changed ModCustomisationHeader to inherit from OsuClickableContainer.
...
ModCustomisationHeader changes color depending on state.
2024-09-04 15:29:48 +02:00
Bartłomiej Dach
b7a56c8a45
Implement "form" text box control
2024-09-04 14:09:50 +02:00
Bartłomiej Dach
6f99d839b0
Make struct readonly
2024-09-04 12:41:02 +02:00
Dean Herbert
0e85110ee2
Merge pull request #29690 from peppy/update-framework
...
Update framework
2024-09-04 19:39:47 +09:00
Dean Herbert
ca09028b06
Merge pull request #29616 from peppy/break-overlay-animation
...
Add beat-synced animation to break overlay
2024-09-04 19:39:35 +09:00
Bartłomiej Dach
130802e480
Add hotkey hints to editor menus
2024-09-04 12:16:54 +02:00
Bartłomiej Dach
0c4f5bcdaa
Decouple editor main menu items from DrawableOsuMenuItem
...
It didn't ever really make sense for it to be sharing the implementation
details of that (e.g. colouring of primary/dangerous actions), and with
the hotkey display things got outright hacky, so I'm decoupling it
entirely.
2024-09-04 12:16:52 +02:00
Dean Herbert
cc3d220f6f
Allow settings to be added to replay HUD from ruleset
2024-09-04 19:00:23 +09:00
Dean Herbert
a417fec234
Move analysis container implementation completely local to osu! ruleset
2024-09-04 19:00:22 +09:00
Bartłomiej Dach
3acc5fe5a0
Integrate hotkey display into drawable menu items
2024-09-04 11:58:10 +02:00
Bartłomiej Dach
3c6c49187a
Implement component for displaying hotkeys
2024-09-04 11:57:09 +02:00
Bartłomiej Dach
3531f646f2
Refactor DrawableOsuMenuItem to remove a hack
2024-09-04 11:55:43 +02:00
Dean Herbert
cb9d1d49a2
Update resources
2024-09-04 18:01:06 +09:00
Dean Herbert
045096b08a
Update framework
2024-09-04 18:00:48 +09:00
Dean Herbert
7cd24ba58e
Disallow mistimed firing of beat sync for break overlay for now
...
It doesn't work well with pause/resume.
2024-09-04 18:00:32 +09:00
Dean Herbert
0e16508fd6
Merge branch 'master' into replay-analysis-settings
2024-09-04 17:52:19 +09:00
Bartłomiej Dach
ef1add3ebb
Merge pull request #29680 from peppy/multiplayer-spectator-auto-download
...
Add automatic downloading support when spectating a multiplayer room
2024-09-04 10:29:35 +02:00
Dean Herbert
9abaa87d8f
Merge pull request #29626 from Fabep/master
...
Mod customization header/panel changes
2024-09-04 17:28:11 +09:00
Dean Herbert
86309f4b46
Revert "Woopsie! I accidentally added one too many semi-colons, so I moved it here into the commit instead ;"
...
This reverts commit 582ffcfc97e3457d8501
2024-09-04 17:25:41 +09:00
Dan Balasescu
337a30f3b0
Merge pull request #29688 from peppy/fix-song-select-allocs
...
Fix per-frame allocations in `BeatmapCarousel`
2024-09-04 17:16:10 +09:00
Sheppsu
c89597b060
fix config mistake
2024-09-04 03:37:52 -04:00
Dean Herbert
1017a124ab
Merge pull request #28743 from smallketchup82/velopack
...
Migrate update framework to Velopack
2024-09-04 16:09:36 +09:00
Dean Herbert
dfe11dc68a
Use for with exposed IReadOnlyList rather than making internal container public
2024-09-04 15:25:36 +09:00
Dean Herbert
97a51af5a0
Fix one more unnecessary enumerator allocation
2024-09-04 15:22:31 +09:00
Dean Herbert
421f245c31
Fix per-frame allocations in BeatmapCarousel
2024-09-04 14:31:59 +09:00
Dean Herbert
6c89c4eed6
Fix rewind causing weirdness with progress bar animation
2024-09-03 18:50:57 +09:00
Sheppsu
a549cdd5b9
persist analysis settings
2024-09-03 04:49:50 -04:00
Sheppsu
a2b15fcdee
rework code logic to make more sense
...
analysis container creates settings and the settings items are created more nicely
also removed use of localized strings because that can be done separately
2024-09-03 00:59:42 -04:00
Fabep
582ffcfc97
Woopsie! I accidentally added one too many semi-colons, so I moved it here into the commit instead ;
2024-09-02 19:17:07 +02:00
Fabep
e3457d8501
Mod customisation header's color is now based on the state of the panel rather than the hover of the container.
2024-09-02 19:14:08 +02:00
Bartłomiej Dach
d99b2312cd
Merge branch 'master' into Fabep/master
2024-09-02 14:35:44 +02:00
Dean Herbert
7b13943377
Handle changes to the automatic download setting immediately
2024-09-02 19:20:05 +09:00
Dean Herbert
872d14ed88
Fix incorrect handling of ordered playlist items
2024-09-02 19:18:43 +09:00
Dan Balasescu
5d09aaae27
Merge pull request #29446 from OliBomby/last-anchor
...
Fix path control points losing curve type on save/reload or undo
2024-09-02 18:40:19 +09:00
Bartłomiej Dach
5211e606b5
Fix mod customisation header being non-functional on mobile
...
As expected the previous touch handling would prevent the header from
working entirely when click handling was removed from the header.
2024-09-02 11:33:43 +02:00
Dean Herbert
6227e4f848
Apply NRT to MultiplayerSpectateButton
2024-09-02 16:37:38 +09:00
Dean Herbert
38a62eed44
Add automatic downloading support when spectating a multiplayer room
2024-09-02 16:37:38 +09:00
Sheppsu
1ed94e598a
Merge branch 'master' into replay-analysis-settings
2024-09-01 19:32:25 -04:00
Dean Herbert
e79604cc13
Merge pull request #29542 from frenzibyte/show-daily-challenge-intro-once-per-session
...
Show daily challenge intro screen once per session
2024-09-01 21:27:16 +09:00
Dean Herbert
f7da7193ff
Update framework
2024-09-01 19:10:08 +09:00
Andrei Zavatski
837fa1b8dc
Use FastCircle for kiai visualisation
2024-08-31 17:32:24 +03:00
Andrei Zavatski
501ea68a21
Merge branch 'master' into fast-circle
2024-08-31 17:31:30 +03:00
Dan Balasescu
d5b52152f4
Merge branch 'master' into velopack
2024-08-31 15:44:21 +09:00
Dean Herbert
6b8b49e4f1
Simplify scroll speed point display code now that it only serves one purpose
2024-08-31 13:14:56 +09:00
Andrei Zavatski
225418dbb3
Rework kiai handling in summary timeline
2024-08-31 01:59:40 +03:00
Andrei Zavatski
f5a2b5ea03
Use FastCircle in demanding places in the editor
2024-08-30 17:45:26 +03:00
Dean Herbert
a09c6e2a25
Merge pull request #29656 from peppy/provide-api-earlier
...
Provide API context earlier to api requests in order to fix missing schedules
2024-08-30 23:15:28 +09:00
Bartłomiej Dach
4811481483
Merge pull request #29639 from peppy/detached-beatmap-cache
...
Improve song select load and reload with large beatmap databases
2024-08-30 15:00:20 +02:00
Bartłomiej Dach
8ffd4aa82c
Fix NRT inspections
2024-08-30 13:41:34 +02:00
Dean Herbert
7b6e62283f
Fix beatmap not being detached on hide/unhide
...
The explicit detach call was removed from `updateBeatmapSet`, causing
this to occur. We could optionally add it back (it will be a noop in all
cases though).
2024-08-30 18:50:08 +09:00
Dean Herbert
de208fd5c3
Add very basic error handling for failed beatmap detach
2024-08-30 18:50:03 +09:00
Dean Herbert
2033a5e157
Add disposal of ManualResetEventSlim
2024-08-30 18:50:02 +09:00
Dean Herbert
1b9942cb30
Mark BeatmapSets as internal
2024-08-30 18:44:04 +09:00
Dean Herbert
291dd5b101
Remove TODO
2024-08-30 18:37:27 +09:00
Dean Herbert
2d745fb67e
Apply NRT to APIRequest
2024-08-30 18:35:31 +09:00
Dean Herbert
dd7133657d
Fix weird test critical failure if exception happens too early in execution
...
Noticed in passing.
```
Exit code is 134 (Unhandled exception. System.NullReferenceException:
Object reference not set to an instance of an object.
at osu.Game.OsuGameBase.onExceptionThrown(Exception ex) in
/Users/dean/Projects/osu/osu.Game/OsuGameBase.cs:line 695
at osu.Framework.Platform.GameHost.abortExecutionFromException(Object
sender, Exception exception, Boolean isTerminating)
at osu.Framework.Platform.GameHost.unobservedExceptionHandler(Object
sender, UnobservedTaskExceptionEventArgs args)
at System.Threading.Tasks.TaskExceptionHolder.Finalize())
```
2024-08-30 18:35:31 +09:00
Dean Herbert
07611bd8f5
Use IAPIProvider interface and correctly support scheduling from DummyAPIAccess
2024-08-30 18:35:31 +09:00
Dean Herbert
5836f497ac
Provide API context earlier to api requests in order to fix missing schedules
...
Closes https://github.com/ppy/osu/issues/29546 .
2024-08-30 18:10:36 +09:00
Fabian Bech Persson
363fc0d5da
Merge branch 'master' into master
2024-08-30 11:06:54 +02:00
Dan Balasescu
ae0931cfc3
Merge pull request #29653 from peppy/fix-multiplayer-event-leak
...
Fix event leak in `Multiplayer` implementation
2024-08-30 16:58:27 +09:00
Dean Herbert
a71bc3a24a
Merge pull request #28737 from OliBomby/doubleclick
...
Add more ways to seek to sample points
2024-08-30 16:22:50 +09:00
Dean Herbert
3bc42db3a6
Fix event leak in Multiplayer implementation
...
Very likely closes #29088 . It's the only thing I could find odd in the
memory dump.
2024-08-30 16:14:19 +09:00
Dean Herbert
60c1e0fa72
Merge pull request #29440 from OliBomby/spacebar-resume
...
Allow play/pause with spacebar while placing hitobjects
2024-08-30 12:58:41 +09:00
OliBomby
ba0c4df2a9
Merge remote-tracking branch 'upstream/master' into doubleclick
2024-08-29 19:34:18 +02:00
OliBomby
8fe7ab131c
dont seek on right-click, only on keyboard request
2024-08-29 19:34:14 +02:00
Dan Balasescu
4e8fb0dcab
Merge branch 'master' into scroll-speed-std
2024-08-30 00:41:05 +09:00
Dean Herbert
dd675fef45
Merge pull request #29644 from smoogipoo/unplayed-filter-query-2
...
Adjust `played` song select filter to accept a boolean value
2024-08-29 23:52:37 +09:00
Dean Herbert
c013974790
Merge branch 'master' into detached-beatmap-cache
2024-08-29 22:49:11 +09:00
Dan Balasescu
fec8fa46fa
Merge pull request #29533 from bdach/fix-sample-bank-stuff-again
...
Fix incorrect bank set / sample addition logic
2024-08-29 21:36:26 +09:00
Dan Balasescu
fde790c014
Rework played filter to a boolean value
2024-08-29 20:59:48 +09:00
Dean Herbert
d1d2591b67
Fix realm changes being applied before detach finishes
2024-08-29 18:42:43 +09:00
Dean Herbert
def1abaeca
Fix some tests not always waiting long enough for beatmap loading
...
These used to work because there was a huge blocking load operation,
which is now more asynchronous.
Note that the change made in `SongSelect` is not required, but defensive
(feels it should have been doing this the whole time).
2024-08-29 18:42:43 +09:00
Joseph Madamba
ef443b0b5d
Hide pinned comment replies initially to match web
2024-08-28 23:05:15 -07:00
Dean Herbert
1776d38809
Remove loadedTestBeatmaps flag
2024-08-28 23:28:44 +09:00
Dean Herbert
e04b5bb3f2
Tidy up test beatmap loading
2024-08-28 23:28:44 +09:00
Dean Herbert
9123d2cb7f
Fix multiple test failures
2024-08-28 23:28:43 +09:00
Bartłomiej Dach
d49cd717d6
Merge pull request #29576 from peppy/allow-seek-in-more-places
...
Allow seeking via music controller overlay on more screens
2024-08-28 12:23:09 +02:00
Dean Herbert
dd4a1104e4
Always debounce external Filter requests (except for tests)
...
The only exception to the rule here was "when screen isn't active apply
without debounce" but I'm not sure we want this. It would cause a
stutter on returning to song select and I'm not even sure this is a
common scenario.
I'd rather remove it and see if someone finds an actual case where this
is an issue.
2024-08-28 19:13:50 +09:00
Dean Herbert
336abadbd1
Allow running initial filter criteria asynchronously
...
This reverts a portion of https://github.com/ppy/osu/pull/9539 .
The rearrangement in `SongSelect` is required to get the initial filter
into `BeatmapCarousel` (and avoid the `FilterChanged` event firing,
causing a delayed/scheduled filter application).
2024-08-28 19:13:50 +09:00
Dean Herbert
5ed0c6e91a
Remove song select preloading
...
Really unnecessary now.
2024-08-28 19:13:49 +09:00
Dean Herbert
c2c1dccf2d
Detach beatmap sets asynchronously
2024-08-28 19:13:49 +09:00
Dean Herbert
b1f653899c
Fix enumeration over modified collection
2024-08-28 19:13:49 +09:00
Dean Herbert
81b36d897d
Fix null reference in change handling code
2024-08-28 19:13:49 +09:00
Dean Herbert
081c9eb21b
Fix incorrect cancellation / disposal handling of DetachedBeatmapStore
2024-08-28 17:21:19 +09:00
Fabep
6adaf6a41f
Changed ModCustomisationPanelState names
2024-08-28 10:09:47 +02:00
OliBomby
cadbb0f27a
change sample seek keybind to ctrl shift
2024-08-28 09:57:13 +02:00
Fabep
be0e2efda2
Removed on click event for expanding the Mod Customisation Header.
2024-08-28 09:51:17 +02:00
Dean Herbert
4d42274771
Use bindable list implementation
2024-08-28 16:03:37 +09:00
Dean Herbert
466ed5de78
Add basic detached beatmap store
2024-08-28 16:03:37 +09:00
Dean Herbert
eb70a1b72d
Change middle text to only animate initially
2024-08-28 15:57:42 +09:00
Dean Herbert
47a52d10eb
Revert "Add slight parallax to centre content"
...
This reverts commit 90d06d4496
2024-08-28 15:32:59 +09:00
OliBomby
b5b4f915a9
Automatic seek to sample point on right-click
2024-08-27 19:40:33 +02:00
OliBomby
1117fd56a1
change default seek hotkeys
2024-08-27 19:40:18 +02:00
OliBomby
daad476593
Add float comparison leniency just in case
2024-08-27 19:04:16 +02:00
OliBomby
71044a0766
fix difference in sample time calculation
2024-08-27 19:02:40 +02:00
Bartłomiej Dach
a3b0ff4808
Merge branch 'master' into break-overlay-animation
2024-08-27 11:17:56 +02:00
Bartłomiej Dach
321e509f11
Merge pull request #29615 from peppy/break-overlay-improvements
...
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 11:16:08 +02:00
Dean Herbert
90d06d4496
Add slight parallax to centre content
2024-08-27 16:37:27 +09:00
Bartłomiej Dach
8d7053d367
Merge pull request #29560 from peppy/fix-daily-challenge-intro-mod-display
...
Fix mod icons potentially showing incorrectly at daily challenge intro
2024-08-27 09:37:11 +02:00
Dean Herbert
6f1664f0a6
Add beat-synced animation to break overlay
...
I've been meaning to make the progress bar synchronise with the beat
rather than a continuous countdown, just to give the overlay a bit more
of a rhythmic feel.
Not completely happy with how this feels but I think it's a start?
I had to refactor how the break overlay works in the process. It no
longer creates transforms for all breaks ahead-of-time, which could be
argued as a better way of doing things. It's more dynamically able to
handle breaks now (maybe useful for the future, who knows).
2024-08-27 16:34:37 +09:00
Dean Herbert
98faa07590
Apply NRT to BreakOverlay
2024-08-27 15:01:51 +09:00
Dean Herbert
797b020747
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 15:01:50 +09:00
Dean Herbert
abdbe510b8
Move break overlay (and cursor) further forward in depth
...
I didn't really want to move the cursor in front of the HUD, but we face
a bit of an impossible scenario otherwise (it should definitely be in
front of the break overlay for visibility).
So I'll deal with it for now.
2024-08-27 14:52:11 +09:00
Dean Herbert
84bceca778
Assume we can always fetch the ruleset
2024-08-26 15:38:58 +09:00
clayton
70d08b9e97
Increase mod icon acronym font weight
2024-08-25 20:42:57 -07:00
clayton
2bb72762ad
Use more contrasting color for mod icon foreground
2024-08-25 20:42:34 -07:00
Salman Ahmed
b54487031a
Add DailyChallengeButton for intro played flag reset logic
2024-08-24 22:19:17 +09:00
Jonas Brandstötter
89a4025c01
Fix Daily Challenge play count using a different colour than osu-web
2024-08-24 11:21:28 +02:00
Dean Herbert
885d832e98
Fix deserialise failing with some old skins
2024-08-23 20:44:45 +09:00
Dean Herbert
1e39af8ac5
Add a bit of logging around medal awarding
...
Might help with https://github.com/ppy/osu/issues/29119 .
2024-08-23 19:49:24 +09:00
Dean Herbert
2a479a84dc
Remove conditional inhibiting seek when beatmap change is not allowed
...
In testing I can't find a reason for this to exist. Blaming back shows
that it existed before we had `AllowTrackControl` and was likely being
used as a stop-gap measure to achieve the same thing. It's existed since
over 6 years ago.
Let's give removing it a try to fix some usability concerns?
Closes https://github.com/ppy/osu/issues/29563 .
2024-08-23 18:21:31 +09:00
Dean Herbert
60271fb0f7
Merge pull request #29564 from peppy/skinnable-components-what-2
...
Remove requirement of `base` calls to ensure user skin container layouts are retrieved
2024-08-23 17:52:46 +09:00
Dean Herbert
48cfd77ee8
Component -> Lookup
2024-08-23 14:48:50 +09:00
OliBomby
2de5ecceb8
Merge remote-tracking branch 'upstream/master' into scroll-speed-std
2024-08-22 20:17:14 +02:00
OliBomby
ad8e7f1897
Fix scroll speed visualisation missing on start kiai effect points
...
They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.
2024-08-22 20:17:09 +02:00
OliBomby
998b5fdc12
Add property EditorShowScrollSpeed to Ruleset
2024-08-22 19:53:34 +02:00
OliBomby
adbdb39e9f
move public member to top of file
2024-08-22 19:18:38 +02:00
OliBomby
0db068e423
allow repeating on seek actions
2024-08-22 19:15:53 +02:00
Bartłomiej Dach
bd6943ebc2
Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu
...
Allow copying beatmap link in song select carousel context menu
2024-08-22 14:03:39 +02:00
Dean Herbert
46d55d5e61
Remove remaining early base lookup calls which were missed
2024-08-22 20:13:28 +09:00
Bartłomiej Dach
b3e961f6c5
Merge pull request #29562 from peppy/remove-migration-leftover-message
...
Remove "leftover files" notification when migration partly fails
2024-08-22 12:32:44 +02:00
Dean Herbert
58552e9768
Add missing user ruleset to link copying for beatmap panels
2024-08-22 19:18:41 +09:00
Dean Herbert
1435fe24ae
Remove requirement of base calls to ensure user skin container layouts are retrieved
2024-08-22 19:14:30 +09:00
Bartłomiej Dach
a32a817305
Merge pull request #29512 from peppy/toolbar-pp-change-weird
...
Fix toolbar PP change showing `+0` instead of `0`
2024-08-22 12:08:12 +02:00
Dean Herbert
b57b8168a6
Rename Target lookup to Component
2024-08-22 19:00:28 +09:00
Dean Herbert
9a21174582
Move GlobalSkinnableContainers to global scope
2024-08-22 18:46:07 +09:00
Dean Herbert
36b4013fa6
Rename GameplaySkinComponentLookup -> SkinComponentLookup
2024-08-22 18:46:03 +09:00
Dean Herbert
f37cab0c6e
Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
2024-08-22 18:39:36 +09:00
Bartłomiej Dach
1859e173f2
Fix EVEN MORE code quality inspections!
2024-08-22 11:16:24 +02:00
Bartłomiej Dach
9997271a6a
Fix more code quality inspections
2024-08-22 10:49:24 +02:00
Dean Herbert
41756520b1
Rename SkinComponentsContainer to SkinnableContainer
2024-08-22 17:42:50 +09:00
Bartłomiej Dach
9020739f36
Remove unused using directives
2024-08-22 10:05:45 +02:00
Dean Herbert
67f0ea5d7d
Fix flooring causing delta to not work as expected
2024-08-22 16:22:00 +09:00
Dean Herbert
b3be04aff1
Remove "leftover files" notification when migration partly fails
...
People were deleting files they shouldn't, causing osu! to lose track of
where the real user files are.
For now let's just keep things simple and not let the users know that
some files got left behind. Usually the files which are left behind are
minimal and it should be fine to leave this up to the user.
Closes https://github.com/ppy/osu/issues/29505 .
2024-08-22 16:09:11 +09:00
Bartłomiej Dach
df94c22a29
Merge pull request #29545 from peppy/timeline-redesign-in-circles
...
Further timeline usability tweaks
2024-08-22 08:39:34 +02:00
Dean Herbert
7e483bbee3
Merge pull request #29541 from frenzibyte/fix-mod-customisation-dragging-outside
...
Keep mod customisation panel open when dragging outside
2024-08-22 15:28:32 +09:00
Bartłomiej Dach
d33f4837fa
Merge pull request #29532 from bdach/redesign-timing-table-tracking
...
Redesign timing table tracking
2024-08-22 08:21:39 +02:00
Dean Herbert
066c34e950
Merge pull request #29553 from bdach/local-cache-updates
...
Add support for retrieving submit/rank date from local metadata cache in version 2
2024-08-22 14:55:43 +09:00
Dean Herbert
9df12e3d87
Move seek button to left to differentiate mutating operations
2024-08-22 14:15:36 +09:00
Dean Herbert
54e5f1c9f0
Merge pull request #29556 from frenzibyte/kiai-star-bursts
...
Add star fountains/bursts when entering kiai mode in gameplay
2024-08-22 14:14:25 +09:00
Dean Herbert
f068b7a521
Move copy-to-url method to OsuGame to centralise toast popup support
2024-08-22 14:03:41 +09:00
Dean Herbert
7f5f3a4589
Fix mod icons potentially showing incorrectly at daily challenge intro
...
Prefer using the beatmap's rulesets over the current user selection.
Closes https://github.com/ppy/osu/issues/29559 .
2024-08-22 13:57:19 +09:00
Salman Ahmed
922814fab3
Fix flag reset on connection dropouts
2024-08-22 06:00:37 +09:00
Salman Ahmed
1efa6b7221
Merge if branches
2024-08-22 05:40:43 +09:00
Salman Ahmed
fc02b4b942
Alter NRT usage
2024-08-22 05:39:57 +09:00
Dean Herbert
ac5a3a0959
Remove one unused parameter
2024-08-22 02:17:11 +09:00
Dean Herbert
87123d99bf
Move URL implementation to extension methods and share with other usages
2024-08-22 02:08:01 +09:00
Dean Herbert
18a3ab2ffd
Use "link" instead of "URL"
2024-08-22 01:45:43 +09:00
Dean Herbert
a943000579
Merge pull request #29435 from OliBomby/improve-snaps
...
Fix timeline snapping ignoring nearby timing points
2024-08-22 01:36:30 +09:00
Dean Herbert
fb5fb78fd3
Move zero marker below control points to avoid common overlap scenario
2024-08-22 01:09:22 +09:00
Dean Herbert
843b10ef34
Add back incorrectly removed control point display toggle
2024-08-22 01:05:47 +09:00
Dean Herbert
2876cb73bd
Merge pull request #28991 from Layendan/master
...
Add collection and favourite buttons to results screen
2024-08-21 23:59:26 +09:00
Bartłomiej Dach
5f88435d96
Add support for retrieving submit/rank date from local metadata cache in version 2
...
Closes https://github.com/ppy/osu/issues/22416 .
2024-08-21 15:42:22 +02:00
OliBomby
423feadd64
Revert "add arrow indicator"
...
This reverts commit 1ce9e97fd4
2024-08-21 14:12:58 +02:00
Bartłomiej Dach
28d0a24555
Fix the fix
...
The more proper way to do this would be to address the underlying issue,
which is https://github.com/ppy/osu/issues/29546 , but let's do this
locally for now.
2024-08-21 12:27:56 +02:00
OliBomby
eefd7cf083
add back protection against perfect curve segments with > 3 points
2024-08-21 12:03:15 +02:00
Salman Ahmed
c92af71029
Add in-gameplay version of kiai star fountains/burst
2024-08-21 17:34:38 +09:00
jkh675
3d5b57454e
Fix null reference
2024-08-21 16:21:49 +08:00
Dean Herbert
fef56cc29e
Remove expanding behaviour of timeline completely
2024-08-21 16:57:52 +09:00
Dean Herbert
7e6490133d
Adjust visuals of tick display (and fine tune some other timeline elements)
2024-08-21 16:46:14 +09:00
Dean Herbert
1a48a6f654
Reduce size of hit objects on timeline
2024-08-21 16:46:13 +09:00
Dean Herbert
3065f808a7
Simplify timing point display on timeline
2024-08-21 16:46:13 +09:00
Dean Herbert
a0002943a1
Adjust centre marker visuals a bit
2024-08-21 16:46:12 +09:00
Bartłomiej Dach
c4f08b42ab
Use colours to distinguish buttons better
2024-08-21 09:05:33 +02:00
OliBomby
8d72ec8bd6
move timing point binary search back inline
2024-08-21 01:50:52 +02:00
OliBomby
09ca190b8d
re-implement ConvexHull 100% original
2024-08-21 00:10:15 +02:00
OliBomby
1ce9e97fd4
add arrow indicator
2024-08-20 23:38:38 +02:00
OliBomby
ae6d855f8d
Merge remote-tracking branch 'upstream/master' into doubleclick
2024-08-20 23:19:27 +02:00
Salman Ahmed
637c9aeef0
Add DailyChallengeIntroPlayed session static
2024-08-21 03:37:04 +09:00
Salman Ahmed
b7599dd1f8
Keep mod customisation panel open when dragging a drawable
2024-08-21 03:23:23 +09:00
Salman Ahmed
0d358a1dae
Fix resume overlay appearing behind HUD/skip overlays
2024-08-21 02:53:11 +09:00
jkh675
8e273709f1
Implement copy url in beatmap and beatmap set carousel
2024-08-20 22:48:11 +08:00
