Dean Herbert
a23de0b188
Avoid accessing WorkingBeatmap.Beatmap every update call
...
Notice in passing.
Comes with overheads that can be easily avoided. Left a note for a
future (slightly more involved) optimisation.
2025-02-03 16:30:31 +09:00
Dan Balasescu
9033a4d480
Remove unused using
2025-02-03 14:20:56 +09:00
Dan Balasescu
210fa14759
Play sound via results screen instead
2025-02-03 14:15:46 +09:00
Dean Herbert
6a18d18feb
Fix null handling when no items are populated but a selection is made
2025-02-03 02:39:45 +09:00
Dean Herbert
9c34819ff4
Add test coverage for grouped selection
2025-02-03 02:39:45 +09:00
Dean Herbert
645c26ca19
Simplify keyboard traversal logic
2025-02-03 02:24:27 +09:00
Dean Herbert
d74939e6e9
Fix backwards traversal of groupings and allow toggling groups without updating selection
2025-02-03 02:24:27 +09:00
Dean Herbert
764f799dcb
Improve selection flow using early exit and invalidation
2025-02-03 02:24:27 +09:00
Dean Herbert
d5dc55149d
Add initial difficulty grouping support
2025-02-03 02:24:27 +09:00
Dean Herbert
3cde11ab77
Re-enable masking by default
2025-02-03 02:24:26 +09:00
Dean Herbert
f65be009a3
Merge pull request #31747 from bdach/do-not-reset-online-info-on-save
...
Do not reset online information when saving beatmap
2025-02-02 22:24:56 +09:00
Dean Herbert
cf3a379b1c
Merge pull request #31368 from frenzibyte/mobile-fix-mania
...
Improve osu!mania playability on mobile devices
2025-02-01 14:49:46 +09:00
Dean Herbert
334b578fb6
Merge pull request #31733 from bdach/bss/abstract-out-wizard
...
Abstract out `WizardOverlay` for multi-step wizard type screens
2025-02-01 14:10:35 +09:00
Bartłomiej Dach
7ef8616703
Fix broken user-facing messaging when beatmap hash mismatch is detected
2025-01-31 12:22:05 +01:00
Bartłomiej Dach
c3981f1097
Do not reset online info on beatmap save
2025-01-31 12:21:42 +01:00
Bartłomiej Dach
8718483c70
Avoid moving already placed objects temporally when "limit distance snap to current time" is active
2025-01-31 09:51:13 +01:00
Bartłomiej Dach
20280cd195
Do not double up first control point of path
2025-01-31 09:01:42 +01:00
Dan Balasescu
cf2d0e6911
Fix results screen sounds persisting after exit
2025-01-31 16:22:37 +09:00
Bartłomiej Dach
b4f63da048
Move control point double-up logic to LegacyBeatmapExporter
...
Done for two reasons:
- During review it was requested for the logic to be moved out of
`BezierConverter` as `BezierConverter` was intended to produce
"lazer style" sliders with per-control-point curve types,
as a future usability / code layering concern.
- It is also relevant for encode-decode stability. With how the logic
was structured between the Bezier converter and the legacy beatmap
encoder, the encoder would leave behind per-control-point Bezier curve
specs that stable ignored, but subsequent encodes and decodes in lazer
would end up multiplying the doubled-up control points ad nauseam.
Instead, it is sufficient to only specify the curve type for the
head control point as Bezier, not specify any further curve types
later on, and instead just keep the double-up-control-point for new
implicit segment logic which is enough to make stable cooperate
(and also as close to outputting the slider exactly as stable would
have produced it as we've ever been)
2025-01-30 15:28:47 +01:00
Bartłomiej Dach
d3b233b08f
Merge pull request #31732 from KareVulli/fix-timeline-selection
...
Fix stacked objects selection order on editor timeline
2025-01-30 14:31:42 +01:00
Bartłomiej Dach
749704344c
Move implicit slider path segment handling logic to Bezier converter
...
The logic in `LegacyBeatmapEncoder` that was supposed to handle
the lazer-exclusive feature of supporting multiple slider segment types
in a single slider was interfering rather badly with the Bezier
converter. Generally it was a bit difficult to follow, too.
The nice thing about `BezierConverter` is that it is *guaranteed* to
only output Bezier control points. In light of this, the same double-up-
-the-control-point logic that was supposed to make multiple slider
segment types backwards-compatible with stable can be placed in
the Bezier conversion logic, and be *much* more understandable, too.
2025-01-30 14:03:51 +01:00
Dean Herbert
8a887abe51
Merge pull request #31663 from nekodex/friend-notification-samples
...
Add unique samples for friend online/offline notifications
2025-01-30 19:45:30 +09:00
Bartłomiej Dach
d8c63a443f
Merge pull request #31685 from frenzibyte/two-factor-authentication-code
...
Do not display autocorrect suggestions in two factor verification code text box
2025-01-30 11:15:09 +01:00
Dean Herbert
5f2532932e
Merge branch 'master' into friend-notification-samples
2025-01-30 18:29:26 +09:00
Bartłomiej Dach
31c4461fbb
Abstract out WizardOverlay for multi-step wizard type screens
...
To be used in the editor, for the beatmap submission wizard.
I've recently been on record for hating "abstract" as a rationale to do
anything, but seeing this commit ~3 months after I originally made it,
it still feels okay to do for me in this particular case. I think the
abstraction is loose enough, makes sense from a code reuse and UX
consistency standpoint, and doesn't seem to leak any particular
implementation details. That said, it is both a huge diffstat and also
potentially controversial, which is why I'm PRing first separately.
2025-01-30 09:39:08 +01:00
Marvin Helstein
ec99fc1141
Move ApplySelectionOrder override from EditorBlueprintContainer to ComposeBlueprintContainer
2025-01-30 10:27:36 +02:00
Dan Balasescu
48b1c7398e
Merge pull request #31655 from bdach/deabstractify-editor-snap
...
Refactor editor object snapping to remove bad abstractions
2025-01-30 01:38:42 +09:00
Dan Balasescu
7750468e31
Merge pull request #31726 from peppy/room-settings-button
...
Make multiplayer change room settings more obvious as to what it does
2025-01-30 00:42:00 +09:00
Dan Balasescu
007bf87a6b
Merge pull request #31723 from peppy/fix-unstable-rate-incrementatl
...
Fix incremental unstable rate calculation not matching expectations
2025-01-29 23:54:59 +09:00
Dan Balasescu
ca7a36d3d6
Remove unused usings
2025-01-29 23:32:44 +09:00
Bartłomiej Dach
75ef67e959
Merge branch 'master' into two-factor-authentication-code
2025-01-29 13:15:30 +01:00
Dean Herbert
bc930e8fd3
Minimal clean-up to get things bearable
...
I plan to do a full refactor of `RoomSubScreen` at first opportunity.
2025-01-29 20:02:04 +09:00
Dean Herbert
e8d0d2a1d9
Combine more methods to simplify flow futher
2025-01-29 19:56:37 +09:00
Dean Herbert
a6814d1a8a
Make multiplayer change room settings more obvious as to what it does
...
"Edit" felt really weird.
2025-01-29 19:48:04 +09:00
Dean Herbert
07bff22200
Fix delay before difficulty panel displays fully
2025-01-29 19:30:57 +09:00
Bartłomiej Dach
d87720da1b
Merge branch 'master' into fix-editor-textbox-regressions
2025-01-29 11:25:16 +01:00
Dean Herbert
facc9a4dc3
Fix reference hashsets getting emptied before used
2025-01-29 19:15:28 +09:00
Dean Herbert
c70ff11085
Remove new bindables from RoomSubScreen
2025-01-29 19:06:14 +09:00
Dean Herbert
05200e8970
Add missing partial
2025-01-29 19:05:28 +09:00
Dean Herbert
d3f9804ef1
Combine more methods to simplify flow
2025-01-29 18:45:02 +09:00
Dean Herbert
9db8e0b7ac
Merge branch 'master' into friend-notification-samples
2025-01-29 17:43:56 +09:00
Dean Herbert
bf40f071eb
Code quality pass
2025-01-29 17:43:49 +09:00
Dean Herbert
4c83ef83ee
Update resources
2025-01-29 17:34:03 +09:00
Dean Herbert
fd1d90cbd9
Update framework
...
Update framework
2025-01-29 17:32:05 +09:00
Dean Herbert
d8ec3b77e4
Fix incremental unstable rate calculation not matching expectations
...
The `EventCount` variable wasn't factoring in that some results do not
affect unstable rate. It would therefore become more incorrect as the
play continued.
Closes https://github.com/ppy/osu/issues/31712 .
2025-01-29 17:11:12 +09:00
Dean Herbert
a3685da250
Merge branch 'master' into enable-sentry-caching
2025-01-29 11:55:23 +09:00
Bartłomiej Dach
b84a9f7820
Merge pull request #31711 from peppy/change-friend-notification-icons
...
Change friend online notifications' icon and colours
2025-01-28 15:38:27 +01:00
Dean Herbert
a3a08832b4
Add keywords to make lighten-during-breaks setting discoverable to stable users
...
See https://github.com/ppy/osu/discussions/31671 .
2025-01-28 21:31:51 +09:00
Dean Herbert
017d38af3d
Change friend online notifications' icon and colours
...
The previous choices made it seem like potentially destructive actions
were being performed. I've gone with neutral colours and more suiting
icons to attempt to avoid this.
---
Addresses concerns in
https://github.com/ppy/osu/discussions/31621#discussioncomment-11948377 .
I chose this design even though it wasn't the #1 most popular because I
personally feel that using green/red doesn't work great for these.
2025-01-28 21:29:17 +09:00
Dean Herbert
6d39ee2918
Merge pull request #31696 from bdach/do-not-bundle-explicit-beatmaps
...
Do not bundle explicit beatmaps
2025-01-28 20:39:21 +09:00
Dan Balasescu
a863230983
Merge pull request #31697 from bdach/corrupt-mp3s-should-not-crash-game
...
Catch and display user-friendly errors regarding corrupted audio files
2025-01-28 14:00:01 +09:00
Bartłomiej Dach
bb8f58f6d6
Work around rare sharpcompress failure to extract certain archives
...
Closes https://github.com/ppy/osu/issues/31667 .
See https://github.com/ppy/osu/issues/31667#issuecomment-2615483900 for
explanation.
For whatever it's worth, I see rejecting this change and telling
upstream to fix it as an equally agreeable outcome, but after I spent an
hour+ tracking this down, writing this diff was nothing in comparison.
2025-01-27 12:28:53 +01:00
Dan Balasescu
fc73037d9f
Add pill displaying current freestyle status
2025-01-27 18:46:45 +09:00
Dan Balasescu
ca979d3542
Adjust xmldocs
2025-01-27 18:32:12 +09:00
Bartłomiej Dach
be9c96c041
Fix infinite loop when switching audio tracks fails on an existing beatmap
...
Bit ugly, but appears to work in practice...
2025-01-27 10:27:06 +01:00
Bartłomiej Dach
01ae1a58f1
Catch and display user-friendly errors regarding corrupted audio files
...
Addresses lack of user feedback as indicated by
https://github.com/ppy/osu/issues/31693 .
2025-01-27 10:25:22 +01:00
Bartłomiej Dach
e24af4b341
Add inline comments for sets that are not marked FA but should be
2025-01-27 09:40:53 +01:00
Bartłomiej Dach
836a9e5c25
Remove explicit beatmap set from list of bundled beatmap sets
2025-01-27 09:40:20 +01:00
Salman Alshamrani
4d7b071027
Specifiy second-factor authentication code text box with Code type
2025-01-25 23:58:56 -05:00
Salman Alshamrani
c18128e974
Remove OrientationManager and the entire mobile namespace
2025-01-25 20:01:18 -05:00
Salman Alshamrani
bb7daae080
Simplify orientation locking code magnificently
2025-01-25 19:12:43 -05:00
Salman Alshamrani
ffc37cece0
Avoid extra unnecessary DI
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2025-01-25 19:12:42 -05:00
Salman Alshamrani
dac7d21302
Be explicit on nullability in RequiresPortraitOrientation
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2025-01-25 19:12:36 -05:00
Jamie Taylor
79df094f17
Add unique samples for friend online/offline notifications
2025-01-24 23:20:04 +09:00
Bartłomiej Dach
092c7b4253
Merge branch 'master' into beatmap-carousel-v2-split-panels
2025-01-24 15:16:23 +01:00
Bartłomiej Dach
55ab3c72f6
Remove unused field
2025-01-24 15:15:50 +01:00
Dean Herbert
82c5f37c2c
Remove selection animation on set panel
2025-01-24 22:45:08 +09:00
Bartłomiej Dach
7845c5cfb7
Merge pull request #31645 from peppy/offset-adjust-more-lenience
...
Make offset adjust more lenient
2025-01-24 14:01:25 +01:00
Bartłomiej Dach
daec91f61d
Refactor further to avoid weird non-virtual common method
2025-01-24 13:14:31 +01:00
Dean Herbert
a94681158d
Merge pull request #31623 from Layendan/room-context-menu
...
Add view in browser context menu functionality to multiplayer/playlist rooms
2025-01-24 20:31:49 +09:00
Dean Herbert
da762384f8
Fix breakage from reordering co-reliant variable sets (and guard against it)
2025-01-24 20:20:18 +09:00
Dean Herbert
175eb82ccf
Split out beatmaps and set panels into two separate classes
2025-01-24 20:10:41 +09:00
Dean Herbert
0164a2e4dc
Move pool item preparation / cleanup duties to Carousel
2025-01-24 20:10:41 +09:00
Bartłomiej Dach
269ade178e
Fix tests
2025-01-24 11:59:07 +01:00
Bartłomiej Dach
32d341a468
Remove IPositionSnapProvider
2025-01-24 11:59:07 +01:00
Bartłomiej Dach
a6987f5c95
Remove dependence of placement blueprints on IPositionSnapProvider
2025-01-24 11:59:07 +01:00
Bartłomiej Dach
15b6e28ebe
Remove dependence of blueprint containers on IPositionSnapProvider
2025-01-24 11:59:05 +01:00
Bartłomiej Dach
2d46da1520
Merge pull request #31634 from peppy/beatmap-carousel-v2-selection
...
Add selection support to beatmap carousel v2
2025-01-24 11:43:17 +01:00
Dean Herbert
9366bfbf0d
Move activation drawable flow portion to ICarouselPanel
2025-01-24 18:40:48 +09:00
Dean Herbert
92429b2ed9
Adjust comments on ICarouselPanel to imply external use
2025-01-24 18:34:04 +09:00
Dean Herbert
17b1739ae4
Combine countless update methods all called together into a single method
2025-01-24 18:00:05 +09:00
Dean Herbert
1bfb4d4c2b
Merge branch 'master' into multiplayer-free-style
2025-01-24 17:23:35 +09:00
Dean Herbert
721b2dfbba
Fix average button not correctly becoming disabled where it previously would
2025-01-24 17:17:34 +09:00
Dean Herbert
56a611b47e
Merge branch 'master' into mobile-fix-mania
2025-01-24 17:03:00 +09:00
Dean Herbert
28a59f4e29
Move line to correct location
2025-01-24 16:45:14 +09:00
Dean Herbert
05b1002e9d
Adjust layout and code quality slightly
2025-01-24 15:57:13 +09:00
Dean Herbert
8f8a6455b4
Bypass offset disallowed status when handling realm callbacks
...
Hopefully don't need to overthink this one.
2025-01-24 15:49:47 +09:00
Dean Herbert
ee78e1b223
Add safeties against attempting to apply previous play while offset adjust is not allowed
...
This should theoretically not be possible, but while we are sharing this
control's implementation between gameplay and non-gameplay usages, let's
ensure nothing weird can occur.
2025-01-24 15:49:47 +09:00
Dean Herbert
fb10996951
Consume GameplayStartTime for more lenient offset adjustments
2025-01-24 15:30:02 +09:00
Dean Herbert
5cc8181bad
Expose GameplayStartTime in IGameplayClock
2025-01-24 15:29:49 +09:00
Layendan
d326f23576
Remove unused method
2025-01-23 15:39:18 -07:00
Layendan
b0a7237fd6
Fix formatting
2025-01-23 15:37:30 -07:00
Layendan
13c64b59af
Inherit menu items from parent class
2025-01-23 15:36:20 -07:00
Dean Herbert
f4270ab3b9
Simplify selection handling logic
2025-01-23 23:58:51 +09:00
Dean Herbert
d5369d3508
Add regions to BeatmapCarousel
2025-01-23 23:53:09 +09:00
Dean Herbert
0716b73d2a
ActivateSelection -> TryActivateSelection
2025-01-23 22:44:39 +09:00
Dean Herbert
2feab31426
Adjust inline commentary based on review feedback
2025-01-23 22:41:20 +09:00
Dean Herbert
ffca90779f
Fix sort direction being flipped
2025-01-23 18:51:24 +09:00
Dean Herbert
2f94456a06
Add selection and activation flow
2025-01-23 18:51:24 +09:00
Dean Herbert
ecef5e5d71
Add set-difficulty tracking in BeatmapCarouselFilterGrouping
...
Rather than tracking inside individual items, let's just maintain a
single dictionary which is refreshed every time we regenerate filters.
2025-01-23 18:48:44 +09:00
Dean Herbert
980f6cf18e
Make CarouselItem sealed and remove BeatmapCarouselItem concept
...
Less abstraction is better. As far as I can tell, we don't need a custom
model for this. If there's any tracking to be done, it should be done
within `BeatmapCarousel`'s implementation (or a filter).
2025-01-23 18:48:44 +09:00
Dean Herbert
c67c0a7fc0
Move Selected status to drawables
...
Basically, I don't want bindables in `CarouselItem`. It means there
needs to be a bind-unbind process on pooling. By moving these to the
drawable and just updating every frame, we can simplify things a lot.
2025-01-23 18:48:43 +09:00
Dean Herbert
ded1d9f019
displayedCarouselItems -> carouselItems
2025-01-23 15:58:35 +09:00
Dean Herbert
d526835627
Only show loading when doing a user triggered filter
2025-01-23 15:51:54 +09:00
Dean Herbert
6ac2dbc818
Reorder carousel methods into logical regions
2025-01-23 15:50:57 +09:00
Layendan
f673d16a1f
Fix formatting
2025-01-22 11:42:11 -07:00
Dean Herbert
bf23c67603
Merge pull request #31509 from bdach/local-metadata-cache-corruption
...
Refetch local metadata cache if corruption is detected
2025-01-23 02:43:14 +09:00
Dan Balasescu
11e84f325c
Merge pull request #31616 from bdach/fix-new-combo-button-crash
...
Fix crash from new combo colour selector when there are no combo colours present
2025-01-22 20:48:02 +09:00
Bartłomiej Dach
3da220b8f6
Fix crash from new combo colour selector when there are no combo colours present
...
Closes https://github.com/ppy/osu/issues/31615 .
2025-01-22 11:39:32 +01:00
Dean Herbert
218720bca5
Merge pull request #31588 from minetoblend/feature/paste-snapped
...
Snap to beat divisor when pasting hitobjects in editor
2025-01-22 18:38:12 +09:00
Dean Herbert
6ceb348cf6
Adjust code again to avoid weird throw mishandling
2025-01-22 18:24:01 +09:00
Dan Balasescu
63e6b0e050
Merge pull request #31603 from peppy/input-amendments
...
Tidy up various input handling anomalies
2025-01-22 18:05:06 +09:00
Bartłomiej Dach
2623d8dcac
Merge pull request #31604 from peppy/fix-song-select-right-click-handling
...
Fix song select right click handling
2025-01-22 10:00:03 +01:00
Dean Herbert
26ef23c9a9
Remove outdated ef related catch-when usage
2025-01-22 17:04:30 +09:00
Dean Herbert
910c0022e3
Adjust code style slightly
2025-01-22 17:03:01 +09:00
Dean Herbert
9e023340b0
Mark friend notifications as non-important
2025-01-22 16:41:27 +09:00
Dean Herbert
4cf4b8c73d
Switch IsImportant to init property isntead of virtual
2025-01-22 16:41:26 +09:00
Dean Herbert
fde2b22bbc
Add transient flag for notifications which shouldn't linger in history
2025-01-22 16:41:26 +09:00
Layendan
2a5a2738e1
Add context menu to open in browser to rooms
2025-01-21 12:45:23 -07:00
Dean Herbert
459847cb80
Perform client side validation that the selected beatmap and ruleset have valid online IDs
...
This is local to playlists, since in multiplayer the validation is
already provided by `osu-server-spectator`.
2025-01-21 19:51:55 +09:00
Dan Balasescu
8f8246278a
Merge pull request #31527 from bdach/spectator-list-ready
...
Show spectating users during gameplay
2025-01-21 18:54:11 +09:00
Dean Herbert
f88102610d
Add tooltips explaining multiplayer mod selection buttons
2025-01-21 18:35:59 +09:00
Bartłomiej Dach
0265a29000
Move bindings to LoadComplete()
2025-01-21 10:02:16 +01:00
Dean Herbert
c68a0bc7e3
Merge branch 'master' into multiplayer-free-style
2025-01-21 17:49:21 +09:00
Dean Herbert
704c2ea0cc
Merge pull request #31026 from frenzibyte/ios-system-file-import
...
Add special handling for file import button on iOS
2025-01-21 17:33:03 +09:00
Dean Herbert
6c27e87714
Add back explicit right click handling of carousel absolute scrolling
2025-01-21 17:24:42 +09:00
Dean Herbert
66be9f2d1b
Remove right click default for absolute scroll
2025-01-21 17:24:41 +09:00
Dean Herbert
b6e7b43b11
Remove unnecessary input blocking
...
This was already done by `OverlayContainer`.
2025-01-21 16:40:36 +09:00
Dean Herbert
aeca91cde2
Fix main menu osu logo being activated by function keys and escape
2025-01-21 16:40:21 +09:00
Dean Herbert
9a12f48dcc
Fix ComposeBlueprintContainer handling nudge keys when it can't nudge
2025-01-21 16:40:16 +09:00
Dean Herbert
3a37817ab2
Don't block Popover escape handling (just let it work in addition to GlobalAction.Back)
2025-01-21 16:39:45 +09:00
Salman Alshamrani
3f51626f07
Simplify code immensely
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2025-01-21 02:20:51 -05:00
Dean Herbert
0a97fb6359
Merge pull request #31586 from minetoblend/feature/metronome-decimals
...
Display up to 2 decimal places for bpm in timing screen metronome
2025-01-21 16:13:10 +09:00
Dean Herbert
a7c9f84a93
Adjust visuals slightly
2025-01-21 15:14:39 +09:00
Salman Alshamrani
f133042936
Fix silly mistake
2025-01-21 01:14:18 -05:00
Dean Herbert
748e631976
Merge branch 'master' into ios-system-file-import
2025-01-21 14:22:56 +09:00
Dean Herbert
46ff9d1aad
Fix beat snap grid being lines not being corectly centered to time
...
This was pointed out as an issue in the osu!taiko editor, but actually
affects all rulesets. Has now been fixed everywhere.
---
Closes https://github.com/ppy/osu/issues/31548 .
osu!mania could arguable be consdiered "more correct" with the old
display, but I don't think it's a huge deal either way (subjective at
best).
2025-01-21 14:20:56 +09:00
Dean Herbert
6b524aba60
Enable sentry caching to avoid sentry writing outside of game directory
...
See https://github.com/ppy/osu/discussions/31412 . Probably safe enough.
2025-01-20 23:45:39 +09:00
Rudi Herouard
89586d5ab2
Fix settings in replay hiding when dragging a slider
2025-01-20 13:43:45 +01:00
Dean Herbert
c20b836d9c
Merge pull request #31543 from bdach/daily-challenge-completion-marker
...
Add completion marker to daily challenge profile counter
2025-01-20 19:29:35 +09:00
Dean Herbert
cf032e5e7f
Merge pull request #31547 from bdach/editor/precise-move
...
Add precise movement tool to osu! editor
2025-01-20 19:29:22 +09:00
Salman Alshamrani
2b5ea4e6e0
Fix recent editor textbox regressions
2025-01-20 03:17:01 -05:00
Dean Herbert
dcdb8d13a9
Always select text when an editor slider-textbox is focused
2025-01-20 16:17:39 +09:00
Dean Herbert
7fd4adc7ec
Merge pull request #31583 from turbedi/cleanup
...
Remove redundant ToArray() calls in Osu/ManiaHitObjectComposer
2025-01-20 15:48:46 +09:00
Dean Herbert
04ba686be5
Add basic animation
2025-01-20 15:47:47 +09:00
Dean Herbert
c4509bbe12
Merge pull request #31539 from Rudicito/seek-in-replay-scaled-by-replay-speed
...
Seek in replay scaled by replay speed
2025-01-20 15:15:50 +09:00
Dean Herbert
525e16ad1d
Fix one more new inspection in EAP 2025
2025-01-20 15:00:35 +09:00
Marvin Schürz
e386c9e373
Apply snapping when pasting hitobjects
2025-01-20 01:25:22 +01:00
Marvin Schürz
8f33b4cc61
Add comment
2025-01-20 01:14:21 +01:00
Marvin Schürz
3532ce1636
Olibomby insisted on it being like this so i concede
2025-01-20 01:07:13 +01:00
Marvin Schürz
a6ca9ba9fb
Display up to 2 decimal places in MetronomeDisplay
2025-01-20 00:51:43 +01:00
CloneWith
72e1b2954c
Don't highlight friends' scores under beatmap's friend score leaderboard
2025-01-20 00:21:10 +08:00
Dean Herbert
e753e3ee2f
Update framework (except android)
2025-01-18 00:40:32 +09:00
Bartłomiej Dach
ebca2e4b4f
Implement precise movement tool
...
As mentioned in one of the points in
https://github.com/ppy/osu/discussions/31263 .
2025-01-17 14:28:57 +01:00
Bartłomiej Dach
b79e937d2d
Fix code quality
2025-01-17 13:34:16 +01:00
Bartłomiej Dach
3c4bfc0a01
Merge spectator list classes into one skinnable
2025-01-17 11:23:14 +01:00
Bartłomiej Dach
a67a68c596
Remove unnecessary masking spec
...
It was clipping the daily challenge completion checkmark, and it
originates in some veeeeery old code where the profile overlay looked
and behaved very differently (0fa0271878
2025-01-17 10:40:26 +01:00
Bartłomiej Dach
b215073957
Add completion marker to daily challenge profile counter
2025-01-17 10:26:59 +01:00
Dean Herbert
43b54623d9
Add required padding on either side of panels so selection can remain centered
2025-01-17 18:08:20 +09:00
Dean Herbert
54f9cb7f68
Add overlapping spacing support
2025-01-17 18:07:54 +09:00
Dean Herbert
a1c5fad6d4
Add curvature to new carousel implementation
2025-01-17 18:07:54 +09:00
Dean Herbert
6bbfd362b8
Merge branch 'master' into user-panel-status
2025-01-17 17:37:09 +09:00
Dean Herbert
a8456ce9ac
Merge pull request #31513 from smoogipoo/remove-status-from-apiuser
...
Remove `Status` and `Activity` bindables from `APIUser`
2025-01-17 17:36:47 +09:00
Dean Herbert
66a72bffa8
Merge branch 'remove-status-from-apiuser' into user-panel-status
2025-01-17 17:32:39 +09:00
Dean Herbert
c8b38f05d5
Add note about the visibility logic because it tripped me up
2025-01-17 17:14:06 +09:00
Dean Herbert
f59762f0cb
Playing -> PlayingState
2025-01-17 17:11:40 +09:00
Dan Balasescu
88829d5321
Merge pull request #31535 from peppy/beatmap-carousel-v2-right-click-scroll
...
Refactor absolute scrolling at song select
2025-01-17 17:02:14 +09:00
Dean Herbert
41c603b56f
Fix double-retrieval of user presence from dictionary in online display
2025-01-17 16:41:02 +09:00
Dean Herbert
311f08b962
Update TestMetadataClient to correctly set local user state in line with changes
2025-01-17 16:29:02 +09:00
Dean Herbert
3bb4b0c2b8
Rename fields from State to Presence when presence is involved
2025-01-17 16:25:48 +09:00
Bartłomiej Dach
7d026761fc
Merge pull request #31533 from peppy/fix-gameplay-offset-adjust-limitations
...
Fix gameplay offset adjustment limits not being enforced
2025-01-17 08:21:24 +01:00
Dan Balasescu
79fff136a9
Merge branch 'master' into beatmap-carousel-v2-right-click-scroll
2025-01-17 16:12:52 +09:00
Dan Balasescu
626be9d780
Return local user state where appropriate
2025-01-17 16:01:11 +09:00
Dan Balasescu
fe5b807e7d
Merge branch 'remove-status-from-apiuser' into user-panel-status
2025-01-17 15:59:39 +09:00
Dan Balasescu
a51938f4e9
Separate the local user state
2025-01-17 15:59:34 +09:00
Dan Balasescu
5425d62186
Merge branch 'master' into remove-status-from-apiuser
2025-01-17 15:42:40 +09:00
Rudi Herouard
5fc277aa7f
Seek in replay scaled by replay speed
2025-01-16 21:53:56 +01:00
Bartłomiej Dach
5c799d733f
Bind to playing state via GameplayState instead to fix more tests
2025-01-16 15:25:56 +01:00
Bartłomiej Dach
1f1e940ada
Restore virtual modifier to fix tests (and mark for posterity)
2025-01-16 15:13:16 +01:00
Bartłomiej Dach
0c54853710
Merge branch 'spectator-list-visuals' into spectator-list-ready
2025-01-16 15:13:04 +01:00
Bartłomiej Dach
81f54507dd
Fix potential index accounting mistake when creating spectator list with spectators already present
...
Noticed by accident, but if the `BindCollectionChanged()` callback fires
immediately in `LoadComplete()` when set up and there are spectators
present already, then `NewStartingIndex` in the related event is -1:
b03f83de36/src/libraries/System.ObjectModel/src/System/Collections/Specialized/NotifyCollectionChangedEventArgs.cs (L84-L92)
2025-01-16 14:29:41 +01:00
Bartłomiej Dach
e3b780d0fb
Merge branch 'master' into spectator-list-visuals
2025-01-16 14:07:53 +01:00
Dean Herbert
a6057a9f54
Move absolute scroll support local to carousel and allow custom bindings
2025-01-16 20:47:59 +09:00
Dan Balasescu
94db39317b
Add xmldoc
2025-01-16 20:43:22 +09:00
Dan Balasescu
65b88ab365
Use MetadataClient for local user status
2025-01-16 20:34:45 +09:00
Dan Balasescu
be892e2baa
Merge branch 'remove-status-from-apiuser' into user-panel-status
2025-01-16 20:34:37 +09:00
Dean Herbert
1c2621d88e
Add support to CarouselV2 for right mouse button scrolling
2025-01-16 20:27:38 +09:00
Dean Herbert
56b450c4a6
Remove setting for right-mouse scroll (make it always applicable)
2025-01-16 20:27:38 +09:00
Bartłomiej Dach
6b921fc4e4
Merge pull request #31471 from peppy/beatmap-carousel-v2
...
Add basic framework for carousel displays (aka `BeatmapCarouselV2`)
2025-01-16 12:21:53 +01:00
Dan Balasescu
8400726887
Move bindables to OsuConfigManager & SessionStatics
2025-01-16 19:33:42 +09:00
Dean Herbert
e47244989a
Adjust animations a bit
...
Removed autosize duration stuff because it looks weird when the list is
shown from scratch where users are already fully populated in it.
2025-01-16 19:23:54 +09:00
Dean Herbert
32906aefde
Add gradient on final spectator if more than list capacity are displayed
2025-01-16 19:05:19 +09:00
Dean Herbert
996798d2df
Avoid list width changing when spectator count changes
2025-01-16 19:02:14 +09:00
Dean Herbert
cde8e7b82e
Fix idle/hover colour handling weirdness in OsuHoverContainer
2025-01-16 18:54:51 +09:00
Dean Herbert
42e5cb58b7
Merge branch 'master' into mobile-fix-mania
2025-01-16 18:08:46 +09:00
Dean Herbert
1d240eb405
Fix gameplay limitations for adjusting offset not actually being applied
2025-01-16 18:05:59 +09:00
Dan Balasescu
fd75ae2614
Merge branch 'remove-status-from-apiuser' into user-panel-status
2025-01-16 17:16:43 +09:00
Dan Balasescu
c1f0c47586
Allow setting of DummyAPIAccess status
2025-01-16 17:06:54 +09:00
Dan Balasescu
b54d959263
Expose as IBindable from IAPIProvider, writes via config
2025-01-16 17:05:18 +09:00
Dan Balasescu
409ea53ad9
Send beatmap_id when creating score
2025-01-16 15:51:53 +09:00
Dan Balasescu
46e9da7960
Fix style display refreshing on all room updates
2025-01-16 15:34:25 +09:00
Shawn Presser
6008c3138e
Typo fix
2025-01-15 19:29:41 -06:00
Bartłomiej Dach
99c7e164dc
Add skinnable spectator list to default skins
2025-01-15 14:29:53 +01:00
Bartłomiej Dach
12b2631e5e
Add a skinnable variant of spectator list & hook it up to online data
2025-01-15 14:29:53 +01:00
Bartłomiej Dach
43fc48a3f3
Add client methods allowing users to be notified of who is watching them
2025-01-15 14:18:01 +01:00
Bartłomiej Dach
582c5180b9
Implement spectator list display
...
- First step for https://github.com/ppy/osu/issues/22087
- Supersedes / closes https://github.com/ppy/osu/pull/22795
Roughly uses design shown in
https://github.com/ppy/osu/pull/22795#issuecomment-1579936284 with some
modifications to better fit everything else, and some customisation
options so it can fit better on other skins.
2025-01-15 14:17:53 +01:00
Dean Herbert
e22dc09149
Update framework
2025-01-15 20:42:46 +09:00
Dan Balasescu
2763cb0b4e
Fix inspection
2025-01-15 17:14:16 +09:00
Dean Herbert
6027947657
Move animation handling to Carousel implementation to better handle add/removes
...
With the animation logic being external, it was going to make it very
hard to apply the scroll offset when a new panel is added or removed
before the current selection.
There's no real reason for the animations to be local to beatmap
carousel. If there's a usage in the future where the animation is to
change, we can add more customisation to `Carousel` itself.
2025-01-15 17:01:07 +09:00
Dan Balasescu
8985a38734
Display up-to-date online status in user panels
2025-01-15 16:55:25 +09:00
Bartłomiej Dach
614243fef4
Merge pull request #31506 from peppy/fix-storyboard-break-overhead
...
Fix stutter on intensive storyboards when entering break time with 100% background dim
2025-01-15 08:23:58 +01:00
Dean Herbert
0b764e6372
Fix substring of GetHashCode potentially failing
2025-01-15 16:18:34 +09:00
Dan Balasescu
b9f3a1de6a
Merge pull request #31523 from Rudicito/apply-offset-when-same-audio
...
Apply beatmap offset to all difficulties only if they have the same audio
2025-01-15 14:20:16 +09:00
Dean Herbert
ef7982fbfa
Merge pull request #31446 from EVAST9919/new-combo-editor
...
Fix performance degradation while trying to place object with a new combo in the editor.
2025-01-15 12:56:06 +09:00
Rudi Herouard
57a9911b22
Apply beatmap offset on every beatmap set difficulty if they have the same audio
2025-01-15 04:12:54 +01:00
Dan Balasescu
b7a9b77efe
Make config the definitive status value
2025-01-15 00:01:19 +09:00
Dan Balasescu
20108e3b74
Remove Status and Activity bindables from APIUser
...
As for the tests, I'm (ab)using the `IsOnline` state for the time being
to restore functionality.
2025-01-14 23:45:30 +09:00
Dan Balasescu
ad14720714
Merge pull request #31508 from peppy/api-startup-state
...
Fix replays not correctly pre-importing beatmap when arriving from a cold start
2025-01-14 22:43:08 +09:00
Dean Herbert
0e20c0e307
Merge pull request #31473 from bdach/colorhax
...
Add combo colour override control to editor
2025-01-14 20:52:15 +09:00
Dean Herbert
e871f02350
Fix inspections that don't show in rider
2025-01-14 20:43:03 +09:00
Dean Herbert
91fa2e70d8
Revert name change
2025-01-14 20:41:18 +09:00
Dean Herbert
3523a2fe61
Merge branch 'master' into api-startup-state
2025-01-14 20:39:05 +09:00
Dan Balasescu
f2b7984e5a
Merge pull request #31507 from peppy/api-startup-user
...
Ensure API starts up with `LocalUser` in correct state
2025-01-14 20:36:55 +09:00
Dean Herbert
900237c1ed
Add loading overlay and refine filter flow
2025-01-14 20:23:53 +09:00
Dean Herbert
cc8941a94a
Add animation and depth control
2025-01-14 20:12:09 +09:00
Plextora
31d7c6a22e
Merge branch 'master' into colour-for-friend-lb
2025-01-14 05:57:44 -05:00
Dean Herbert
7e8a80a0e5
Add difficulty, artist and title sort examples
...
Also:
- Adds hinting at grouping and header status of items
- Passes through criteria and prepare for grouping tests.
- Makes `Filters` list `protected` because naming clash with `Filter()`
on `BeatmapCarousel`.
2025-01-14 19:52:48 +09:00
Bartłomiej Dach
b0c0c98c5d
Refetch local metadata cache if corruption is detected
...
Addresses one of the points in https://github.com/ppy/osu/issues/31496 .
Not going to lie, this is mostly best-effort stuff (while the refetch is
happening, metadata lookups using the local source *will* fail), but I
see this as a marginal scenario anyways.
2025-01-14 11:20:52 +01:00
Dean Herbert
d97a3270a5
Split out BeatmapCarousel classes and drop V2 suffix
2025-01-14 19:18:02 +09:00
Dean Herbert
8d41eda91a
Merge branch 'master' into beatmap-carousel-v2
2025-01-14 19:06:52 +09:00
Dean Herbert
3ddff19337
Fix potential nullref due to silly null handling and too much OOP
2025-01-14 19:03:58 +09:00
Dean Herbert
b4d054fdc0
Merge pull request #31444 from smoogipoo/friend-presence-2
...
Add notifications for when friends go online or offline
2025-01-14 18:58:19 +09:00
Bartłomiej Dach
459577cc32
Merge pull request #31474 from peppy/scroll-container-double-precision
...
Update game `ScrollContainer` usage in line with framework changes
2025-01-14 10:56:55 +01:00
Dean Herbert
55ae0403d8
Ensure API state is Connecting immediately on startup when credentials are present
...
Currently, there's a period where the API is `Offline` even though it is
about to connect (as soon as the `run` thread starts up).
This can cause any `Queue`d requests to fail if they arrive too early.
To avoid this, let's ensure the `Connecting` state is set as early as
possible.
2025-01-14 18:18:53 +09:00
Dan Balasescu
156207d347
Remove unused using
2025-01-14 17:54:40 +09:00
Dan Balasescu
51c7c218bf
Simplify operations on local list
2025-01-14 17:52:26 +09:00
Bartłomiej Dach
92cc45dc05
Merge branch 'text-input-properties' into scroll-container-double-precision
2025-01-14 09:51:48 +01:00
Dean Herbert
f6073d4ac0
Ensure API starts up with LocalUser in correct state
...
I noticed in passing that in a very edge case scenario where the API's
`run` thread doesn't run before it is loaded into the game, something
could access it and get a guest `LocalUser` when the local user actually
has a valid login.
Put another way, the `protected HasLogin` could be `true` while
`LocalUser` is `Guest`.
I think we want to avoid this, so I've moved the initial set of the
local user earlier in the initialisation process.
If this is controversial in any way, the PR can be closed and we can
assume no one is ever going to run into this scenario (or that it
doesn't matter enough even if they did).
2025-01-14 17:43:43 +09:00
Bartłomiej Dach
8211c4ee98
Merge branch 'master' into colorhax
2025-01-14 08:56:52 +01:00
Bartłomiej Dach
8ffd254719
Adjust initialisation code to start with combo colour picker hidden
2025-01-14 08:54:46 +01:00
Dean Herbert
3c913c9f6d
Merge branch 'master' into colour-for-friend-lb
2025-01-14 16:34:05 +09:00
Dean Herbert
904a08af26
Update textbox usage in line with framework changes
2025-01-14 16:29:56 +09:00
Dean Herbert
2c57cd59a5
Update framework
2025-01-14 16:26:56 +09:00
Dean Herbert
77db355809
Ensure storyboards are still updated even when dim is 100%
...
This avoids piled-up overhead when entering break time. It's not great,
but it is what we need for now to avoid weirdness.
2025-01-14 16:22:10 +09:00
Bartłomiej Dach
8968ab19d9
Merge branch 'master' into fix-skin-editor-undo
2025-01-13 12:39:51 +01:00
Bartłomiej Dach
fc069e060c
Only show colour on new combo selector button if overridden
...
As proposed in
https://discord.com/channels/188630481301012481/188630652340404224/1327309179911929936 .
2025-01-13 12:38:28 +01:00
Salman Alshamrani
c1ac27d658
Fix failing tests
...
- Caches `DrawableRuleset` in editor compose screen for mania playfield adjustment container (because it's used to wrap the blueprint container as well)
- Fixes `ManiaModWithPlayfieldCover` performing a no-longer-correct direct cast with a naive-but-working approach.
2025-01-12 22:56:40 -05:00
Salman Alshamrani
f718696102
Allow landscape orientation on tablet devices in osu!mania
2025-01-12 02:34:36 -05:00
Salman Alshamrani
f121b03a78
Merge branch 'master' into mobile-fix-mania
2025-01-12 02:00:49 -05:00
Dean Herbert
cf55fe16ab
Generic type instead of raw object?
2025-01-11 01:43:47 +09:00
