h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-31 15:03:21 +08:00
Code Issues Releases Wiki Activity

Adjust inline commentary based on review feedback

Browse Source
This commit is contained in:
Dean Herbert 2025-01-23 22:41:20 +09:00
parent eaea053c7d
commit 2feab31426
No known key found for this signature in database
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Screens/SelectV2/Carousel.cs
View File

@ -366,8 +366,8 @@ namespace osu.Game.Screens.SelectV2
Debug.Assert(selectionItem != null);
// As a second special case, if we're group selecting backwards and the current selection isn't
// a group, base this selection operation from the closest previous group.
// As a second special case, if we're group selecting backwards and the current selection isn't a group,
// make sure to go back to the group header this item belongs to, so that the block below doesn't find it and stop too early.
if (isGroupSelection && direction < 0)
{
while (!carouselItems[selectionIndex].IsGroupSelectionTarget)
@ -423,8 +423,8 @@ namespace osu.Game.Screens.SelectV2
currentSelection = currentKeyboardSelection = new Selection(model);
HandleItemSelected(currentSelection.Model);
// ensure the selection hasn't changed in the handling of selection.
// if it's changed, avoid a second update of selection/scroll.
// `HandleItemSelected` can alter `CurrentSelection`, which will recursively call `setSelection()` again.
// if that happens, the rest of this method should be a no-op.
if (currentSelection.Model != model)
return;