Salman Ahmed
20f193c1c2
Fix screen offsetting not handling scaled game instances
...
By using `Content` instead, now the logic will get the X of the settings
overlay at the `Content` space, which can be scaled in the
`ScalingMode.Everything` mode.
And in the case of `ScalingMode.ExcludeOverlays`, a subcontainer
somewhere inside `Content` that's holding the screen stack would be scaled,
but `Content` won't be affected which is what we want in that case.
2021-08-21 04:16:12 +03:00
Endrik Tombak
058d2d2a49
Use nekodex's regex from osu-web
2021-08-20 23:01:06 +03:00
Endrik Tombak
8745fe9e34
Change editor timestamp regex to not match non-editor ones
2021-08-20 22:32:04 +03:00
Dean Herbert
d3dba296d6
Update resources
2021-08-20 23:47:35 +09:00
Dan Balasescu
0c936aec4b
Merge branch 'master' into temporary-directory-test-storage
2021-08-20 22:09:42 +09:00
smoogipoo
f85d3665d8
Cleanups
2021-08-20 21:45:24 +09:00
smoogipoo
5192ee3b57
Fix initial display in room background
2021-08-20 21:40:35 +09:00
smoogipoo
5c8ca32ea4
Simplify lounge implementation
2021-08-20 21:33:21 +09:00
smoogipoo
b1a732b9b7
Remove selectedRoom from OnlinePlayScreen
2021-08-20 21:28:48 +09:00
smoogipoo
ceb07826d7
Merge branch 'master' into remove-current-room
2021-08-20 21:10:41 +09:00
smoogipoo
9458cd5a31
Make DrawableMatchRoom background load instantly
2021-08-20 21:07:51 +09:00
smoogipoo
b190020c4b
Block lounge background screen from exiting
2021-08-20 21:02:25 +09:00
Dan Balasescu
0aea39f5f1
Merge branch 'master' into temporary-directory-test-storage
2021-08-20 20:41:54 +09:00
Dan Balasescu
0a6b678059
Merge branch 'master' into settings-dim-other-sections
2021-08-20 20:22:22 +09:00
Dean Herbert
77149044a5
Allow intro screen to retrieve beatmap even if rulesets is not loaded
2021-08-20 19:43:48 +09:00
smoogipoo
d304e283e4
Don't deselect online room when joined
2021-08-20 18:14:59 +09:00
smoogipoo
c22c6f3a49
Initial room background implementation
2021-08-20 18:14:12 +09:00
Dean Herbert
591ba8cb09
Ensure the final scroll target is used when checking for whether too far down
2021-08-20 17:56:35 +09:00
smoogipoo
258ba4674c
Fix background overflows
2021-08-20 17:50:49 +09:00
Dean Herbert
03e6ca5ba9
Adjust scroll behaviour to feel better
2021-08-20 17:40:56 +09:00
Dean Herbert
2d19f37dc6
Add missing new method in UserTrackingScrollContainer for scrolling into view
2021-08-20 17:40:41 +09:00
Dean Herbert
139ff2d6e2
Only fade header in when hovering a section
...
Feels less like the controls are interactive when hovering this way.
2021-08-20 17:40:05 +09:00
smoogipoo
3d96da84e6
Set a default background
2021-08-20 17:05:46 +09:00
smoogipoo
8524937c82
Move screenstack up a level
2021-08-20 17:02:55 +09:00
Dean Herbert
c7266c74a0
Always prefer clicked section when present
2021-08-20 17:00:20 +09:00
Dean Herbert
cff7b1e98f
Ensure the correct fade level is applied over all state changes
2021-08-20 17:00:08 +09:00
Lucas A
9b4c806855
Apply review suggestions.
2021-08-20 09:47:23 +02:00
Lucas A
0a1c9a6c05
Move DownloadButtonStrings -> CommonStrings
2021-08-20 09:26:38 +02:00
smoogipoo
610a162271
Merge branch 'master' into remove-current-room
2021-08-20 16:23:36 +09:00
Lucas A
19cc4a14a3
Localise top score mods statistics
2021-08-20 09:22:15 +02:00
Dan Balasescu
54bc532f0d
Merge branch 'master' into fix-messagepack-union
2021-08-20 16:01:04 +09:00
Dean Herbert
659ec0c1b8
Merge pull request #14403 from Joehuu/fix-nub-glow
...
Fix nub glow color not having 0 alpha when being set
2021-08-20 15:07:30 +09:00
Dan Balasescu
dcff30ed6e
Merge branch 'master' into fix-login-as-guest
2021-08-20 14:06:28 +09:00
Dean Herbert
98357d51da
Merge pull request #14323 from minetoblend/editor-seek
...
Prevent seeking before mp3 start time while editor is playing
2021-08-20 13:28:20 +09:00
Joseph Madamba
284c871e39
Fix glow color potentially being set incorrectly when glowing
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-08-19 20:33:19 -07:00
Dean Herbert
da8eba9996
Return early to avoid updating state and failure count in fail cases
2021-08-20 12:11:41 +09:00
Joseph Madamba
1e02d61b85
Fix nub glow color not having 0 alpha when being set
2021-08-19 20:06:49 -07:00
Dan Balasescu
c95bf735fe
Merge branch 'master' into multiplayer-chat
2021-08-20 11:54:42 +09:00
Dean Herbert
2825e15fd4
Update framework
2021-08-20 11:54:37 +09:00
Dean Herbert
7021133029
Merge branch 'master' into temporary-directory-test-storage
2021-08-20 11:54:33 +09:00
Dan Balasescu
580136a5e9
Merge branch 'master' into fix-lounge-loading
2021-08-20 10:51:30 +09:00
Bartłomiej Dach
143b8df1b2
Fix backwards warning text presence check
2021-08-19 22:40:35 +02:00
Lucas A
bf7f0a5d30
Remove double whitespace
2021-08-19 19:02:04 +02:00
Dean Herbert
e25592f325
Merge branch 'master' into fix-lounge-loading
2021-08-19 20:01:47 +09:00
Dean Herbert
2b0f2a6db9
Merge pull request #14355 from frenzibyte/mod-settings-difficulty-cache
...
Update star difficulty bindables on mod settings change
2021-08-19 20:00:48 +09:00
Dean Herbert
a6b7ca1a4c
Ensure all request failures are correctly handled during login
2021-08-19 19:55:14 +09:00
Dean Herbert
b09105e5a7
Merge pull request #14381 from smoogipoo/match-subscreen-redesign
...
Update layout of multiplayer room screens
2021-08-19 19:36:21 +09:00
Dean Herbert
a65cd36a5f
Move some constants to consts
2021-08-19 19:19:46 +09:00
Dean Herbert
fcf7394d3c
Merge pull request #14385 from rednir/limit-match-settings-textbox
...
Limit length of multiplayer match settings textboxes
2021-08-19 19:13:32 +09:00
smoogipoo
44e157447c
Initial rework of backgrounds
2021-08-19 19:10:54 +09:00
Dean Herbert
8fce5911a9
Adjust spacing and padding of footer buttons
2021-08-19 19:08:46 +09:00
Dean Herbert
16aecfe934
Start free mod selection area hidden on screen display
2021-08-19 19:02:54 +09:00
Dean Herbert
be77498044
Move chat to right column in multiplayer match screen
2021-08-19 19:02:31 +09:00
Dean Herbert
675e2e34ba
Add padding between beatmap panel and edit button
2021-08-19 19:02:05 +09:00
Dean Herbert
4afc808ffc
Remove horizontal transitions for now
...
They look bad with the current toolbar implementation. We can probably
add them back once the toolbar is moved to the lounge.
2021-08-19 18:29:59 +09:00
smoogipoo
023f3fb70e
Use BackgroundScreen for multiplayer backgrounds
2021-08-19 18:19:31 +09:00
smoogipoo
493f47787b
Disable condition for the time being
2021-08-19 18:18:42 +09:00
Dean Herbert
4d1582d721
Play settings hide animation if visible when exiting RoomSubScreen
2021-08-19 18:14:45 +09:00
Dean Herbert
bc025efce5
Add commenting regarding workaround to avoid potential omission in the future
2021-08-19 17:42:44 +09:00
Dean Herbert
2b5a42e063
Add missing union specification for MatchUserRequest
2021-08-19 17:42:26 +09:00
Dean Herbert
f95c6f0de5
Switch multiplayer back to messagepack
2021-08-19 17:42:13 +09:00
Dean Herbert
fa01e4fad2
Add workaround for SignalR union serialisation
2021-08-19 17:41:50 +09:00
smoogipoo
6b6d52c23b
Add dependency container to RoomSubScreen
2021-08-19 16:53:07 +09:00
smoogipoo
4d1897c6b4
Remove unnecessary resolve into ListingPollingComponent
2021-08-19 16:52:54 +09:00
smoogipoo
00be7f4cca
Make RoomsContainer/DrawableRoom not resolve via DI
2021-08-19 16:52:54 +09:00
smoogipoo
3a1154c00e
Pass room into SelectionPollingComponent
2021-08-19 16:41:21 +09:00
smoogipoo
c31af96f1d
Pass room into RoomSettingsOverlay
2021-08-19 16:41:21 +09:00
smoogipoo
1fd746524d
Remove realtime room category, fix end-date showing for realtime
2021-08-19 16:09:28 +09:00
smoogipoo
6469eaa427
Fix background not updated in room
2021-08-19 15:52:51 +09:00
Salman Ahmed
6bfae25cda
Apply 5px vertical spacing on fill flow
...
Regressed, was margin { bottom = 5f } from the star rating display
creation method, which I've partly inlined.
2021-08-19 08:30:29 +03:00
Dean Herbert
6d00ea3375
Allow toggling focus via binding
2021-08-19 14:19:59 +09:00
Salman Ahmed
25e6317e7f
Use animated star display in beatmap info wedge and synchronise bar
2021-08-19 07:18:02 +03:00
Salman Ahmed
6d57a240ac
Add animation support for the star rating display
2021-08-19 07:17:43 +03:00
Salman Ahmed
072560ba3e
Remove leftover unused using
2021-08-19 07:17:43 +03:00
Salman Ahmed
102320f8ae
Merge branch 'master' into mod-settings-difficulty-cache
2021-08-19 06:35:13 +03:00
Salman Ahmed
5fc29328cf
Remove unused using
...
Uh.....
2021-08-19 06:30:23 +03:00
Salman Ahmed
b984780d6a
Merge branch 'master' into fix-lounge-loading
2021-08-19 06:26:15 +03:00
Salman Ahmed
49bc3a8250
Refactor playlists room manager to handle dummy API requests
2021-08-19 06:25:47 +03:00
Salman Ahmed
f4ae587a33
Extract room request handling logic to its own class
2021-08-19 06:24:06 +03:00
Salman Ahmed
0e2f3dff4d
Fix rooms scroll container not masking properly due to padding
2021-08-19 05:09:49 +03:00
Salman Ahmed
ffbe8ddfa4
Refactor lounge sub screen layout for better loading screen appearance
2021-08-19 04:23:12 +03:00
Bartłomiej Dach
2e1df7bee4
Merge branch 'master' into settings-dim-other-sections
2021-08-18 23:32:30 +02:00
Bartłomiej Dach
2e43f38d8a
Merge branch 'master' into settings-delayed-load
2021-08-18 22:53:34 +02:00
Bartłomiej Dach
07951fe18c
Merge branch 'master' into limit-match-settings-textbox
2021-08-18 21:17:16 +02:00
Davran Dilshat
43cbd10a38
change limit to be on actual usage site
2021-08-18 18:30:50 +01:00
Lucas A
ea08d48d27
Remove unecessary localised string due to online view container handling visibility when user is not logged in.
2021-08-18 18:53:35 +02:00
Davran Dilshat
61675eefe0
Add length limit to match settings textboxes
2021-08-18 17:36:57 +01:00
Dean Herbert
6637c64501
Dim all but the current section
2021-08-19 01:27:14 +09:00
Dean Herbert
e87accafc8
Fix current section logic not accounting for hidden sections
2021-08-19 01:26:33 +09:00
Dean Herbert
a0374d4a67
Adjust centre point slightly to make dim feel better
2021-08-19 01:26:11 +09:00
Dean Herbert
af0c7ed108
Fix searching in settings not correctly invalidating the scroll position
2021-08-19 01:25:57 +09:00
smoogipoo
d40023bcc1
Hide border by default
2021-08-18 21:09:34 +09:00
smoogipoo
e9221f0126
Cleanup unnecessary implementation
2021-08-18 21:00:11 +09:00
smoogipoo
eadf02933a
Split lounge-specific implementation from DrawableRoom
2021-08-18 20:56:44 +09:00
smoogipoo
63af67f61b
Cleanup around footers
2021-08-18 20:25:48 +09:00
Salman Ahmed
8172ffc401
Fix lounge sub screen loading layer displaying in the background
2021-08-18 13:12:58 +03:00
Dean Herbert
fc3fa4f241
Merge branch 'master' into settings-delayed-load
2021-08-18 18:51:25 +09:00
Dean Herbert
1faf789f0e
Allow expanding chat using key binding even when it is hidden
2021-08-18 18:25:21 +09:00
Dean Herbert
365c1bccc6
Fix multiplayer channel being unintentionally left after gameplay session
2021-08-18 18:24:20 +09:00
Salman Ahmed
d2df09432f
Center the star rating display text rather than left
2021-08-18 11:49:33 +03:00
Salman Ahmed
5e91ec73e3
Handle star rating range display sizing
2021-08-18 11:36:27 +03:00
Dean Herbert
2099298444
Disallow clicking on chat textbox during gameplay
2021-08-18 17:30:50 +09:00
smoogipoo
9220d17202
Adjust paddings/spacings
2021-08-18 17:28:20 +09:00
Dean Herbert
9d2664cbb1
Merge branch 'master' into star-rating-display-v2
2021-08-18 17:22:33 +09:00
Salman Ahmed
74d6c26520
Refactor star rating display layout with flexibility in mind
2021-08-18 11:03:35 +03:00
smoogipoo
6dc96fdb83
Disable edit button in playlists
2021-08-18 16:56:42 +09:00
Dean Herbert
4725b802b0
Share OsuGameTestScene with implementations across template projects
2021-08-18 16:53:32 +09:00
Dean Herbert
2758a83d55
Fix TestSettingsMigration's usage of RecycleLocalStorage
2021-08-18 16:39:10 +09:00
smoogipoo
87a5922f0e
Remove participants from playlists screen
2021-08-18 16:26:45 +09:00
smoogipoo
66e11fe75e
Initial integration of playlists with the new structure
2021-08-18 16:09:15 +09:00
smoogipoo
568f1fd345
Fix initial RoomId state not being handled correctly
2021-08-18 16:09:00 +09:00
Dean Herbert
dc44cc0eb3
Update scenarios to use new TestRunHeadlessGameHost where feasible
2021-08-18 16:01:56 +09:00
smoogipoo
90a1be2e61
Move paddings up one level
2021-08-18 15:54:33 +09:00
smoogipoo
744b6749d1
Resolve room settings layout issues
2021-08-18 15:29:01 +09:00
smoogipoo
228ad98b39
Remove extra corner radius on DrawableRoom
2021-08-18 15:27:23 +09:00
smoogipoo
f3bc9c3e45
Merge branch 'master' into match-subscreen-redesign
2021-08-18 15:19:29 +09:00
smoogipoo
c5268c9a99
Simplify by reusing same room panel
2021-08-18 15:19:24 +09:00
Salman Ahmed
1ae4a1910a
Cache mod settings rather than fetching everytime
2021-08-18 09:17:42 +03:00
smoogipoo
704af94d39
Add edit button to room panel
2021-08-18 15:13:10 +09:00
smoogipoo
0853554c24
Fix settings overlay not being initially visible
2021-08-18 15:11:52 +09:00
smoogipoo
c66abf85f7
Remove match header
2021-08-18 14:04:44 +09:00
Dean Herbert
5441fab692
Avoid scheduling focus operation when not required
2021-08-18 12:45:14 +09:00
Dean Herbert
1fdaefef99
Revert unnecessary changes
2021-08-18 12:45:08 +09:00
Dean Herbert
5671820d92
Update framework
2021-08-18 10:35:34 +09:00
Salman Ahmed
8c5d99ab21
Override CreateInstance() in osu! bindable subclasses
...
Three bindables are left which don't have this overriden due to them
already not having a value-only constructor and not supporting
`GetBoundCopy()` properly:
- `BeatmapDifficultyCache.BindableStarDifficulty`.
- `TotalScoreBindable`
- `TotalScoreStringBindable`
I could add support for them by passing the required data to them, as
they seem to be able to have that shared, but I'm hesitant to support
something which was already broken and never used, not sure.
2021-08-18 04:19:58 +03:00
Nathan Alo
eaca331170
apply suggestions
2021-08-18 08:13:53 +08:00
Bartłomiej Dach
e3b00c6c7a
Merge branch 'master' into reduce-skin-lookup-overhead
2021-08-17 23:08:52 +02:00
Bartłomiej Dach
58ecee543a
Trim redundant default argument value
2021-08-17 23:00:10 +02:00
Dan Balasescu
eaf7bd72fc
Merge branch 'master' into multiplayer-chat
2021-08-17 20:08:01 +09:00
Dan Balasescu
d8e9845d00
Merge pull request #14360 from peppy/improve-timeline-tick-visibility
...
Improve visibility of repeat ticks / drag areas on timeline
2021-08-17 20:06:49 +09:00
smoogipoo
47d4a2e97f
Make SettingsOverlay protected
2021-08-17 20:05:26 +09:00
Dean Herbert
d66f7cb6b5
Fix tests by allowing retrieval with files where required
2021-08-17 19:21:22 +09:00
Dean Herbert
5c59818b03
Merge branch 'master' into reduce-skin-lookup-overhead
2021-08-17 19:05:14 +09:00
smoogipoo
590d814881
Move RoomSettingsOverlay to RoomSubScreen
2021-08-17 18:24:04 +09:00
Dean Herbert
f16468b706
Improve visibility of repeat ticks / drag areas on timeline
2021-08-17 18:17:55 +09:00
smoogipoo
6840ec6716
Actually show the room in the sub screen
2021-08-17 17:58:24 +09:00
Dean Herbert
c0b388cd74
Fix regression in ModSettingsChangeTracker
2021-08-17 17:50:30 +09:00
Dean Herbert
1b49e92e99
Merge branch 'master' into settings-delayed-load
2021-08-17 17:42:23 +09:00
Dean Herbert
4a65888cfc
Merge branch 'master' into multiplayer-chat
2021-08-17 17:34:23 +09:00
Dean Herbert
ef9bfece13
Merge branch 'master' into multi-polling-request-refactor
2021-08-17 17:31:25 +09:00
Dean Herbert
3b5fc6d10f
Ensure updateLoadingLayer is run at least once
2021-08-17 17:18:23 +09:00
Dean Herbert
9eb16fa61d
Move poll allowance logic based on signalr connection inside polling component
2021-08-17 17:16:21 +09:00
smoogipoo
5d72c5911a
Rename MatchSettingsOverlay and related classes
...
Because "match" is a multiplayer-only concept.
2021-08-17 17:14:28 +09:00
smoogipoo
6416e64e06
Adjust sizings and paddings
2021-08-17 17:13:25 +09:00
smoogipoo
4b198d14eb
Initial refactor of RoomSubScreen
2021-08-17 17:05:20 +09:00
Dean Herbert
8a1651e830
Reorganise methods in PollingComponent
2021-08-17 17:04:32 +09:00
Dean Herbert
a901fca54a
Merge branch 'master' into multi-polling-request-refactor
2021-08-17 16:23:46 +09:00
Dan Balasescu
b1efc6d763
Merge branch 'master' into local-user-play-info
2021-08-17 16:23:44 +09:00
Dean Herbert
6ee6a46894
Remove unnecessary public prefix in interface specification
2021-08-17 16:22:14 +09:00
Dean Herbert
124f149cb5
Add key binding to focus chat input
2021-08-17 16:17:31 +09:00
Dean Herbert
30eee363dc
Add chat display during multiplayer gameplay
2021-08-17 16:17:31 +09:00
Dean Herbert
b82f92d7b8
Adjust background colours of textbox in chat display
2021-08-17 16:16:49 +09:00
Dean Herbert
35b9f84c00
Expose StandAloneChatDisplay.Textbox
2021-08-17 16:16:49 +09:00
Dean Herbert
0d283aa6a3
Expose LocalUserPlaying from Player
2021-08-17 16:16:49 +09:00
Dean Herbert
82eddeffef
Add LocalUserPlayInfo interface to convey common information about player status
2021-08-17 16:15:47 +09:00
Salman Ahmed
3a7b9bf096
Fix MatchSettingsOverlay not resetting focus on hide properly
2021-08-17 08:56:49 +03:00
Dan Balasescu
66e33b3704
Merge pull request #14263 from frenzibyte/hide-player-settings-overlay
...
Hide non-interactive elements on multi-spectator players
2021-08-17 14:07:19 +09:00
smoogipoo
f4b7ee5c7f
Merge branch 'master' into hide-player-settings-overlay
2021-08-17 13:44:33 +09:00
smoogipoo
081524b6c8
Privatise setters
2021-08-17 13:44:21 +09:00
smoogipoo
1e2c0031d7
Remove unused usings
2021-08-17 13:34:44 +09:00
Dean Herbert
bc86bafc08
Fix RestoreDefaultValueButton's colour weirdness
2021-08-17 12:48:30 +09:00
Dean Herbert
212842c537
Fix initial LayoutSettings animation in a more reliable way
2021-08-17 12:38:44 +09:00
Dean Herbert
adb4fd5a2b
Load only sections content asynchronously, showing the header initially
2021-08-17 12:31:33 +09:00
Salman Ahmed
b419ea716b
Refactor beatmap info wedge to not fully refresh on star difficulty change
...
Makes it look awkward when changing difficulty via mod settings for
example.
Now the changes should instead only affect the displayed components which consume it
directly.
2021-08-17 05:46:06 +03:00
Salman Ahmed
32ba525555
Track changes to mod settings in beatmap difficulty cache with 100ms debouncing
2021-08-17 05:46:05 +03:00
Salman Ahmed
0291cd5ae2
Consider mod equality in difficulty cache lookup rather than acronym
2021-08-17 04:27:43 +03:00
Salman Ahmed
060ba0692d
Add hash code support for Mod
2021-08-17 04:27:04 +03:00
smoogipoo
f2340c6dac
Privatise mutable list
2021-08-17 09:48:33 +09:00
smoogipoo
b672d4b936
Refactor RequestHandlingMultiplayerRoomManager to avoid confusion
2021-08-17 09:43:37 +09:00
smoogipoo
1e282432c9
Fix password in a better way
2021-08-17 09:40:25 +09:00
smoogipoo
c4a42c4db0
Fix BasicTestRoomManager overriding rooms
2021-08-17 09:36:59 +09:00
smoogipoo
352949069a
Move filter to LoungeSubScreen
2021-08-17 09:36:43 +09:00
smoogipoo
97d5b80834
Fix joining with incorrect password
2021-08-17 09:18:21 +09:00
smoogipoo
6320768a67
Merge branch 'master' into multi-polling-request-refactor
2021-08-17 08:44:56 +09:00
Xexxar
61045bd087
adjusted code comments
2021-08-16 22:36:14 +00:00
Xexxar
ae076c9a4e
merged latest ppy/master
2021-08-16 22:20:12 +00:00
Xexxar
176b3e7533
changed decay system to allow for customizing the currentStrain
2021-08-16 22:14:29 +00:00
Marvin Schürz
78f9f4a230
Move time clamp to Seek/transformSeekTo methods
2021-08-16 20:39:09 +02:00
Dean Herbert
4bf22db4ff
Attempt to reduce skin lookup overhead where file access is not required
2021-08-17 00:23:30 +09:00
Dean Herbert
8cba1f197b
Merge branch 'master' into add-supporter-glow-changelog
2021-08-16 23:41:46 +09:00
Dean Herbert
c3a8676932
Simplify size specifications
2021-08-16 23:38:13 +09:00
Dean Herbert
cb122eaf25
Merge pull request #14342 from frenzibyte/fix-difficulty-adjust-controls
...
Fix difficuly adjust settings controls not raising `SettingsChanged` events
2021-08-16 23:34:30 +09:00
Dean Herbert
139e69ed3b
Merge pull request #14343 from frenzibyte/hide-tablet-not-detected-when-disabled
...
Hide tablet settings content when disabled
2021-08-16 23:31:16 +09:00
Dean Herbert
7b74301fa1
Merge pull request #14341 from smoogipoo/fix-preview-track-crash
...
Fix crashes from preview tracks
2021-08-16 22:21:52 +09:00
Dean Herbert
5f006bd6e8
Merge pull request #14247 from kj415j45/localisation-settings
...
Add localisation support for most of Settings
2021-08-16 22:20:35 +09:00
Dean Herbert
c978e68742
Merge branch 'master' into add-supporter-glow-changelog
2021-08-16 22:09:52 +09:00
Dean Herbert
7e1086d901
Merge branch 'master' into hide-tablet-not-detected-when-disabled
2021-08-16 22:07:45 +09:00
Dean Herbert
568d027013
Simplify weird conditionals
2021-08-16 22:07:41 +09:00
Lucas A
3325b0cc95
Fix merge conflicts.
2021-08-16 14:50:08 +02:00
Lucas A
a0a9777109
Fix merge conflicts.
2021-08-16 14:50:00 +02:00
Lucas A
1f942d15f8
Localise scoreboard
2021-08-16 13:38:57 +02:00
Dean Herbert
8c3eb91059
Merge branch 'master' into localisation-settings
2021-08-16 20:03:06 +09:00
Dean Herbert
de61cb8e6a
Adjust delay slightly
2021-08-16 19:56:20 +09:00
Dean Herbert
e485728109
Add keywords to make finding audio offset adjustments easier in settings
2021-08-16 19:54:45 +09:00
Dean Herbert
230c4eb247
Fade in sidebar buttons after the load has completed
2021-08-16 19:47:41 +09:00
Dean Herbert
c6bd8520a7
Add basic asynchronous loading pattern to SettingsPanel
2021-08-16 19:47:41 +09:00
Dean Herbert
b541550ea9
Avoid initial synchronous dropdown population overhead in AudioDevicesSettings
2021-08-16 19:47:41 +09:00
Dean Herbert
8d051d9fa0
Avoid multiple synchronous overheads in SettingsItem
2021-08-16 19:47:41 +09:00
Dean Herbert
237d3e656b
Remove initial transform overhead of Nub
2021-08-16 19:47:41 +09:00
Dean Herbert
92ad66c86c
Remove transform overhead from OsuDropdown on initial display
2021-08-16 19:47:41 +09:00
Dean Herbert
c0130da235
Avoid running initial layout transform in LayoutSettings
2021-08-16 19:47:41 +09:00
Lucas A
7bebbf9f74
Mark format strings as verbatim.
2021-08-16 12:46:41 +02:00
Salman Ahmed
e39a295c5c
Hide tablet settings content when input handler is disabled
2021-08-16 13:45:50 +03:00
Dean Herbert
3ad7688eaf
Merge pull request #14339 from peppy/revert-breaking-config-rename
...
Revert "Rename element in OsuSettings enum"
2021-08-16 19:18:22 +09:00
Dean Herbert
cecb312e77
Ensure TakeFocus does not crash when not yet loaded
2021-08-16 18:55:50 +09:00
Dean Herbert
c191b38125
Reduce transform overhead of RestoreDefaultValueButton
2021-08-16 18:55:50 +09:00
Salman Ahmed
855fff1486
Fix DifficultyAdjustSettingsControl.SliderControl not following up with the current pattern
...
This was causing any `ValueChanged` event bind (such as the one in
`SettingsItem` to invoke `SettingsChanged`) to be overwritten when
`Current` is set afterwards.
2021-08-16 12:47:58 +03:00
smoogipoo
db1a0ebb55
Fix preview track crashes
2021-08-16 18:46:44 +09:00
Dean Herbert
1c7cbc8621
Add missing readonly keyword to new bindable
2021-08-16 17:14:13 +09:00
Dean Herbert
8555a465ac
Merge pull request #14318 from bdach/editor-colours-save
...
Add support for saving edited combo colours and displaying them in composer
2021-08-16 17:07:53 +09:00
Dean Herbert
71fab416d8
Add a note against OsuSetting
2021-08-16 16:59:59 +09:00
Dean Herbert
fc89f2bac4
Revert "Rename element in OsuSettings enum"
...
This reverts commit c2bbe17562
2021-08-16 16:56:48 +09:00
Dean Herbert
8d45f86bd3
Rename variable to better reflect its purpose
2021-08-16 16:48:40 +09:00
Dean Herbert
ae8a1adae8
Allow seeking via Player.Seek even if disabled
2021-08-16 16:47:57 +09:00
kj415j45
887d622c28
Merge branch 'master' into localisation-settings
2021-08-16 15:41:50 +08:00
Dean Herbert
d0faa91bb1
Merge pull request #14338 from frenzibyte/fix-participant-panel-assuming-not-null
...
Fix few cases where `MultiplayerRoomUser.User` is assumed to not be null
2021-08-16 16:31:24 +09:00
Dean Herbert
838bcc51b2
Avoid new bindable requirement
2021-08-16 16:27:19 +09:00
Dean Herbert
81480ac4fc
Use PlayerConfiguration to convey no-seek state
2021-08-16 16:16:02 +09:00
Salman Ahmed
7fe6f6dd14
Fix kick button action asserting and using User.User.ID rather than User.UserID
2021-08-16 09:47:23 +03:00
Salman Ahmed
79cd062784
Let TeamDisplay take the full MultiplayerRoomUser rather than the underlying User
2021-08-16 09:47:23 +03:00
Salman Ahmed
f82ed64aa7
Fix participant panel null user test no longer functioning properly
...
I guess the changes that involved `MultiplayerTestScene` having a test
user lookup cache caused this test case to false-pass silently.
Added an explicit assert which ensures the added user indeed has a null
`User` value.
2021-08-16 09:07:00 +03:00
Dan Balasescu
4d31d07c51
Merge branch 'master' into open-tablet-driver-faq
2021-08-16 13:46:43 +09:00
smoogipoo
08d347f10b
Merge branch 'master' into multi-polling-request-refactor
2021-08-16 13:12:08 +09:00
smoogipoo
b6a2020c59
General refactorings from PR review
2021-08-16 13:09:04 +09:00
smoogipoo
81f9442471
Inline update/addRoom in usage sites
2021-08-16 13:04:06 +09:00
Salman Ahmed
554b09ac1b
Fix SkinnableTargetsContainer blocked from processing scheduled tasks
2021-08-16 06:57:45 +03:00
smoogipoo
76a8d4329f
Make TestRoomManager update existing room
2021-08-16 12:43:09 +09:00
Dan Balasescu
989d337532
Merge branch 'master' into auto-restart
2021-08-16 12:34:04 +09:00
Dan Balasescu
bc8e9d9ea8
Merge pull request #14329 from peppy/fix-new-lounge-performance
...
Cache buffered background to fix multiplayer lounge performance
2021-08-16 12:04:45 +09:00
Dan Balasescu
444453c9e2
Merge branch 'master' into fix-mark-read-local-message
2021-08-16 11:28:57 +09:00
Dean Herbert
f0fe79b568
Remove buffered container workarounds for now
2021-08-16 11:04:21 +09:00
Dean Herbert
d35886ef19
Reduce frame buffer render scale for blurred background
2021-08-16 11:03:49 +09:00
Nathan Alo
c56b34d2da
apply code inspection fixes
2021-08-16 07:06:23 +08:00
Dean Herbert
e8e387b549
Cache buffered background to fix multiplayer lounge performance
...
Consider this a request for comment. It's the cleanest solution I can
come up with without dropping either the blur, or use of
`ModelBackedDrawable`.
Intended to resolve https://github.com/ppy/osu/issues/14276 .
2021-08-16 08:04:54 +09:00
Bartłomiej Dach
e744629a41
Fix broken obsoletion message
2021-08-16 01:01:56 +02:00
Nathan Alo
cc3468b4ab
apply suggestions
...
- make `UserActivity.InGame` and derive that to `InSoloGame` and `InMultiplayerGame`
- rename `SoloGame` to `InSoloGame`
- rename `MultiplayerGame` to `InMultiplayerGame`
2021-08-16 06:32:33 +08:00
Daniel Kariv
38828b6b82
Updating beatmap details icons
...
changes the sizing and add yellow circle so the UI will fit more with osu-web style.
2021-08-16 00:40:31 +03:00
Daniel Kariv
f6773522d1
Correct icons in beatmap details
...
In relation to #13968 . Replacing incorrect icons in beatmap details panel to correct ones from BeatmapStatisticsIcon class.
2021-08-16 00:12:27 +03:00
Bartłomiej Dach
6108451449
Retrieve separated skin instance from working beatmap for editing
2021-08-15 21:18:09 +02:00
Bartłomiej Dach
81280dfd25
Use editable skin structure in combo colour picker
2021-08-15 21:18:08 +02:00
Bartłomiej Dach
0d64da8c63
Add skin providing container responding to beatmap skin edits
2021-08-15 21:18:08 +02:00
Bartłomiej Dach
df43e758ee
Add editable beatmap skin
2021-08-15 21:18:07 +02:00
emu1337
29a22bd11f
added rhythm multiplier for strain sections
2021-08-15 20:48:00 +02:00
Bartłomiej Dach
7c88a1c6de
Add a way to change custom combo colours via IHasComboColours
...
`IHasComboColours` was already mutable (via a strange
`AddComboColours()` method) and exposing a straight list is easier to
work with. `IHasCustomColours` is also similarly externally mutable (in
a way which is not easily removable).
2021-08-15 20:06:06 +02:00
Opelkuh
7d7c5c06f0
Fix code formatting
2021-08-15 16:02:25 +02:00
Opelkuh
2f9f1ba862
Add test for ChannelManager.MarkChannelAsRead
2021-08-15 15:44:23 +02:00
Bartłomiej Dach
3648e0ca26
Merge branch 'master' into auto-restart
2021-08-15 15:04:50 +02:00
Marvin Schürz
d287db7961
Clamping seekTime to beatmap length
2021-08-15 14:48:56 +02:00
Nathan Alo
2cc096101e
trim whitespace
2021-08-15 18:56:24 +08:00
Dan Balasescu
f49c9673cc
Merge pull request #14286 from kj415j45/readability-settings-rename
...
Rename element in OsuSettings enum
2021-08-15 18:13:10 +09:00
Jacob Van Meter
6472d85aae
Added heart_size constant and adjusted the glow radius value
...
Added heart_size constant and adjusted the glow radius value to be more in line with the website
2021-08-14 21:48:57 -04:00
Opelkuh
7d6f7ac75e
Fix mark channel as read error
2021-08-15 02:57:11 +02:00
Jacob Van Meter
71ccd38bb3
Corrected pippi background and promo positioning
2021-08-14 20:36:43 -04:00
Jacob Van Meter
772860232c
Removed empty offset and corrected colour
2021-08-14 20:32:38 -04:00
Jacob Van Meter
95943fdb25
Add glow to supporter promo on changelog
...
Added glow to the supporter promo at the end of the changelog, as it is on the website.
2021-08-14 20:00:26 -04:00
Salman Ahmed
c8fb796660
Fix settings notice text class tinting everything with yellow
2021-08-14 20:14:28 +03:00
Salman Ahmed
2ddf28346a
PlayerSettingsGroups -> PlayerSettings
2021-08-14 19:58:20 +03:00
LiangXiang Shen
246a8882ce
Update translation key
2021-08-15 00:23:14 +08:00
Bartłomiej Dach
498462dfd0
Fix room null-check racing against async schedule
2021-08-14 17:44:41 +02:00
Nathan Alo
4ed06a1021
apply suggestions
2021-08-14 22:39:12 +08:00
kj415j45
c2bbe17562
Rename element in OsuSettings enum
...
`ShowProgressGraph` -> `ShowDifficultyGraph`
2021-08-14 22:35:15 +08:00
kj415j45
f87f86e671
Apply suggestions from code review
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-08-14 22:24:57 +08:00
Nathan Alo
a553942a7f
update InitialActivity on multiplayer Player and SongSelect
2021-08-14 13:20:36 +08:00
Dean Herbert
b8c63eb1cb
Merge branch 'master' into multiplayer-kick-support-events
2021-08-14 14:08:34 +09:00
Dean Herbert
e6b3aba6e1
Fix incorrectly directed call in TestMultiplayerClient
2021-08-14 14:08:29 +09:00
Dean Herbert
a10ba17b64
Merge pull request #14250 from peppy/leaderboard-limit-player-count
...
Add ability for gameplay leaderboard scroll when too many users are displayed
2021-08-14 14:08:18 +09:00
kj415j45
e26ccf786e
code style format
2021-08-14 11:04:38 +08:00
kj415j45
5cfb89f18a
Apply suggestions from code review
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2021-08-14 10:56:52 +08:00
Bartłomiej Dach
e2cc96097f
Unify match score display formatting
...
Commas are already applied on the multiplayer leaderboard, as well as
the results screen.
2021-08-13 23:57:51 +02:00
Bartłomiej Dach
00317c0e30
Round when totalling up team scores instead of truncating
...
Matches score handling in `ScoreManager`.
2021-08-13 23:44:07 +02:00
Bartłomiej Dach
8f3fedade3
Merge branch 'master' into multiplayer-team-vs-results
2021-08-13 21:30:44 +02:00
Gagah Pangeran Rosfatiputra
9233f396aa
centered thumbtack icon and text
2021-08-14 00:22:01 +07:00
Gagah Pangeran Rosfatiputra
a710bbf6ae
remove background colour for no comment placeholder
2021-08-14 00:03:05 +07:00
Gagah Pangeran Rosfatiputra
6d726bf046
Change spacing
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-08-13 22:54:41 +07:00
smoogipoo
0e66a05963
Hide left border of beatmap wedge
2021-08-13 22:29:22 +09:00
smoogipoo
1c0ffd4621
Merge branch 'master' into multi-polling-request-refactor
2021-08-13 22:24:01 +09:00
smoogipoo
155e9e16a5
Refactorings
2021-08-13 22:09:47 +09:00
smoogipoo
d57508853e
Merge branch 'master' into multi-polling-request-refactor
2021-08-13 22:04:31 +09:00
smoogipoo
1fcb1cdb10
Add todo
2021-08-13 22:01:47 +09:00
smoogipoo
44b3e3bfac
Merge branch 'master' into fix-playlists-cross-ruleset-entry
2021-08-13 21:58:15 +09:00
Gagah Pangeran Rosfatiputra
cf0e9a1eec
add pinned content section
2021-08-13 19:40:37 +07:00
Gagah Pangeran Rosfatiputra
480d5ffa5d
add pinned comment to users setter in comment bundle
2021-08-13 19:40:37 +07:00
smoogipoo
c71a581106
Fix exception when leaving match
2021-08-13 18:24:19 +09:00
smoogipoo
1f992e67f3
Fix listing polling rate when entering room
2021-08-13 18:17:25 +09:00
kj415j45
d527eb3d8b
Apply suggestions from code review
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-08-13 17:15:18 +08:00
smoogipoo
1bae7173d3
Fix initial multiplayer poll
2021-08-13 18:14:02 +09:00
smoogipoo
6a46105b5e
Fix incorrect dependency
2021-08-13 18:12:32 +09:00
smoogipoo
83935540ca
Add selection polling component to PlaylistsRoomSubScreen
2021-08-13 18:11:52 +09:00
Dan Balasescu
62970108df
Merge pull request #14269 from peppy/remove-unnecessary-delimiters
...
Fix searches at song select with '!' or ',' not matching as expected
2021-08-13 18:00:11 +09:00
Dean Herbert
72268d3e8a
Merge pull request #14150 from frenzibyte/improve-screen-offsetting
...
Improve overlay screen offsetting logic to be position-based
2021-08-13 17:59:41 +09:00
smoogipoo
7cbf4c48ed
Fix multiplayer polling when not connected
2021-08-13 17:59:18 +09:00
smoogipoo
8910781bcd
Move listing polling component to LoungeSubScreen
2021-08-13 17:39:09 +09:00
Salman Ahmed
f43ab323ff
Add shared class for notice text in settings
2021-08-13 11:12:44 +03:00
Dean Herbert
5a60b39643
Remove unnecessary delimiters from song select filter splitting
2021-08-13 16:42:58 +09:00
Dean Herbert
93b97e5110
Adjust ratio to match previous behaviour
2021-08-13 16:35:22 +09:00
Dean Herbert
da18c399e2
Remove unnecessary IsPresent override
2021-08-13 16:33:00 +09:00
Dean Herbert
c1d67976e6
Rename const, add xmldoc and make protected
2021-08-13 16:29:36 +09:00
Dean Herbert
bb36d1614f
Merge branch 'master' into improve-screen-offsetting
2021-08-13 16:23:02 +09:00
Dean Herbert
db52549152
Move below everything rather than proxying (works better with new design)
2021-08-13 16:20:53 +09:00
Dean Herbert
6a95fa0278
Merge branch 'master' into fix-loading-screen-depth
2021-08-13 16:20:38 +09:00
