1936 Commits

Author	SHA1	Message	Date
Dean Herbert	807c1ecd1f	Refactor recommendation iteration code to read better	2020-12-22 14:57:32 +09:00
Dean Herbert	8cc2ed3fae	Move from OsuGameBase to OsuGame ... Also moves to a more suitable namespace.	2020-12-22 14:28:27 +09:00
Dean Herbert	85518b4d99	Enforce non-null for BeatmapManager WorkingBeatmap resources	2020-12-22 12:06:10 +09:00
Dean Herbert	a97a2b2a66	Add nullability to BeatmapManager's GameHost reference	2020-12-22 12:03:25 +09:00
Dean Herbert	10c2745682	Add region specifications around implicit interface implementations	2020-12-22 12:01:09 +09:00
Dean Herbert	a5bcf1dc20	Expose resources to skin via interface (and share common pieces with beatmap)	2020-12-21 15:18:52 +09:00
Dean Herbert	0ffbe12fcc	Expose resources to beatmaps in a saner way	2020-12-21 14:22:34 +09:00
Dean Herbert	7c804be4d3	Rename textureStore to make its purpose more clear	2020-12-21 14:06:33 +09:00
Dean Herbert	a35060ea7a	Add a simple cache-busting query string to online.db retrieval ... As we are finally pushing updates for this database, this adds a minimum level of guarantee that a client will request a new version (without having to worry about multiple levels of server-side caching).	2020-12-11 17:56:02 +09:00
smoogipoo	2150cf1c52	Rename parameters	2020-12-02 10:55:48 +09:00
smoogipoo	5760e1c1fc	Make HitSampleInfo immutable	2020-12-01 15:37:51 +09:00
Dean Herbert	25af091409	Fix storyboard animations of very old beatmaps playing too slow ... Closes https://github.com/ppy/osu/issues/10772.	2020-11-12 17:03:43 +09:00
Dean Herbert	6cc0bf17a9	Add explicit lock object and some xmldoc for clarity	2020-11-10 14:31:52 +09:00
smoogipoo	66ea1572c7	Fix unsafe list manipulation in BeatmapDifficultyCache	2020-11-10 01:10:00 +09:00
Dan Balasescu	a2877fb00a	Merge pull request #10730 from peppy/fix-patcher-no-object-crash ... Fix legacy patcher crash on no objects present	2020-11-09 18:51:00 +09:00
Bartłomiej Dach	6d4bb4316c	Fix difficulty retrieval for online-sourced beatmaps	2020-11-08 00:12:25 +01:00
Dean Herbert	c5b6908e71	Always write [HitObjects] to file ... I think this is expected. If not, there's an alternative solution.	2020-11-08 00:18:27 +09:00
Dean Herbert	c1c3d37720	Remove non-null assert	2020-11-06 17:24:28 +09:00
Dean Herbert	f51cb0dd14	Add ruleset fallback logic into cache lookup class	2020-11-06 16:58:53 +09:00
Dean Herbert	c5b172d0dd	Remove synchronous lookup path from BeatmapDifficultyCache	2020-11-06 14:53:15 +09:00
Dean Herbert	b69ada64e8	Update BeatmapDifficultyCache to use base implementation logic	2020-11-06 14:31:21 +09:00
Dean Herbert	517a656899	Move StarDifficulty to own file	2020-11-06 13:51:25 +09:00
Dean Herbert	74ca2faa31	Remove unused using	2020-11-06 13:48:06 +09:00
Dean Herbert	0103b12575	Add basic base class to begin to standardise function across caching components	2020-11-06 13:26:39 +09:00
Dean Herbert	5113d4af8f	Rename BeatmapDifficultyManager to BeatmapDifficultyCache	2020-11-06 13:14:29 +09:00
Dean Herbert	ab9e0aac58	Merge pull request #10258 from Game4all/results-dynamic-pp-calc	2020-11-02 15:40:55 +09:00
Dean Herbert	73b290aca3	Merge branch 'master' into results-dynamic-pp-calc	2020-11-02 14:47:33 +09:00
Dean Herbert	3adf451e82	Handle changes via SamplePoints list for simplicity	2020-11-02 14:40:40 +09:00
Bartłomiej Dach	3090b6ccb5	Resolve CA2249 inspections ... "Use `string.Contains` instead of `string.IndexOf` to improve readability"	2020-11-01 18:54:44 +01:00
Bartłomiej Dach	ca5de22ca5	Resolve CA1834 inspection ... "Use `StringBuilder.Append(char)` instead of `StringBuilder.Append(string)` when the input is a constant unit string"	2020-11-01 18:50:13 +01:00
Dean Herbert	89797d7a57	Merge pull request #9786 from Wieku/storyboard-skin-sprites ... Allow storyboard elements to load textures from skins	2020-10-23 17:16:55 +09:00
Dean Herbert	9753dab93b	Remove IOnlineComponent and change existing components to use bindable flow	2020-10-22 14:19:12 +09:00
Bartłomiej Dach	e2552d4c36	Merge branch 'master' into storyboard-skin-sprites	2020-10-20 23:01:54 +02:00
Bartłomiej Dach	cdd56ece87	Read UseSkinSprites when decoding storyboards	2020-10-20 22:49:56 +02:00
Dan Balasescu	bd4e0e1a60	Merge branch 'master' into epilepsy-warning	2020-10-20 17:43:37 +09:00
Dan Balasescu	13060b8575	Merge branch 'master' into beatmap-carousel-less-diffcalc-stutter	2020-10-20 14:26:16 +09:00
Bartłomiej Dach	fd4bab85cf	Merge branch 'master' into epilepsy-warning	2020-10-20 01:06:46 +02:00
Bartłomiej Dach	1238e6c30f	Add flag value to database ... Unfortunately required, as loadBeatmaps() refreshes the decoded beatmap with the database-stored values, which can end up overwriting the decoded ones.	2020-10-20 00:46:08 +02:00
Bartłomiej Dach	a9f27a71a2	Fix code formatting issues	2020-10-19 23:53:41 +02:00
Bartłomiej Dach	ba818e3ae0	Merge branch 'master' into results-dynamic-pp-calc	2020-10-19 21:41:07 +02:00
smoogipoo	dfbc0965e4	Merge branch 'master' into peppy/skinnable-health-display	2020-10-16 23:17:17 +09:00
Berkan Diler	fe3a23750c	Use char overloads for string methods	2020-10-16 11:52:29 +02:00
Dean Herbert	e89c5c3b3c	Add dynamic compile exceptions to fix skin test scenes	2020-10-16 17:08:46 +09:00
Dean Herbert	88ffcb9234	Update EndsWith usages	2020-10-16 12:58:34 +09:00
Dean Herbert	cc41845f56	Add missing string function ordinal specifications	2020-10-16 12:49:31 +09:00
Dean Herbert	07e6609e6d	Disable difficulty calculation for set-level difficulty icons	2020-10-14 14:16:22 +09:00
Bartłomiej Dach	1af17fbd5e	Merge branch 'master' into fix-early-break-cull	2020-10-13 18:02:08 +02:00
Bartłomiej Dach	7117fd0fba	Add xmldoc and nullability annotations	2020-10-12 21:44:04 +02:00
Bartłomiej Dach	779e6e10a7	Split ctors to avoid passing fields one by one	2020-10-12 21:43:14 +02:00
smoogipoo	ccf7e2c49a	Fallback to default ruleset star rating if conversion fails	2020-10-12 16:31:42 +09:00
smoogipoo	379971578d	Remove culling notice from HasEffect	2020-10-12 15:28:16 +09:00
Bartłomiej Dach	8af78656e4	Add precision tolerance to difficulty rating range checks	2020-10-10 18:15:52 +02:00
smoogipoo	d536a1f75e	Fix breaks being culled too early	2020-10-09 21:04:56 +09:00
Lucas A	7f5cf04b2b	Fix merge conflicts.	2020-10-07 13:28:49 +02:00
Dean Herbert	afe3d3989a	Force first hitobject to be a NewCombo in BeatmapProcessor preprocessing step	2020-10-06 22:10:13 +09:00
Dan Balasescu	783a463772	Merge branch 'master' into colourise-control-point-table	2020-10-05 20:47:06 +09:00
Dan Balasescu	051ea7eda9	Merge pull request #10329 from peppy/editor-file-drop-support ... Add drag-drop support in editor setup screen for audio and background images	2020-10-05 20:05:41 +09:00
Dean Herbert	2ed43c14f8	Merge branch 'master' into editor-file-drop-support	2020-10-05 17:48:06 +09:00
Dean Herbert	365a38e92f	Merge branch 'master' into dynamic-difficulty-icon	2020-10-05 17:37:01 +09:00
Dean Herbert	50eca202f4	User IEnumerable for HandledExtensions	2020-10-02 16:17:10 +09:00
Dean Herbert	f501c88b46	Fix individual control points not being removed from group when group is removed	2020-10-02 15:28:21 +09:00
smoogipoo	40c153e705	Use component instead of drawable	2020-10-01 21:39:40 +09:00
smoogipoo	62b55c4c9c	Use static method, add xmldoc + link to wiki	2020-10-01 20:50:47 +09:00
Dean Herbert	e96e30a19d	Move control point colour specifications to common location and use for formatting timing screen table	2020-10-01 19:29:34 +09:00
smoogipoo	2213db2088	Use the given ruleset by default	2020-10-01 00:59:41 +09:00
smoogipoo	fde00d3431	Make DifficultyIcon support dynamic star rating	2020-10-01 00:53:25 +09:00
smoogipoo	917e8fc3ba	Add difficulty rating to StarDifficulty	2020-10-01 00:53:01 +09:00
Lucas A	2766cf73b4	Reuse BeatmapDifficultyManager cache for beatmap difficulty attributes.	2020-09-29 18:32:02 +02:00
Lucas A	ddede85704	Split performance calculation to its own class.	2020-09-27 12:44:29 +02:00
Lucas A	84cc6068f5	Remove unnecessary XMLDoc comment and remove unecessary implicit null parm	2020-09-27 09:25:01 +02:00
Lucas A	4d94bf3163	Rename CalculateScorePerformance -> CalculatePerformance	2020-09-25 19:16:33 +02:00
Lucas A	77a9d92f42	Add dynamic pp calculation to score panels for local scores	2020-09-25 19:15:40 +02:00
Lucas A	4d743f64f5	Add a method to calculate asynchronously performance on a beatmap.	2020-09-25 18:17:01 +02:00
Dean Herbert	50ba320a51	Expand available file operations in ArchiveModelManager	2020-09-25 13:16:30 +09:00
smoogipoo	de5ef8a471	Rework to support obsoletion	2020-09-17 21:37:32 +09:00
smoogipoo	e71991a53c	Add default token	2020-09-17 18:37:48 +09:00
smoogipoo	c7d24203ce	Make beatmap conversion support cancellation tokens	2020-09-17 17:40:05 +09:00
smoogipoo	be2d34d5dc	Merge branch 'master' into score-recalc	2020-09-09 21:31:31 +09:00
Dean Herbert	5b93752065	Merge pull request #10103 from smoogipoo/disable-online-lookups-tests ... Disable online beatmap lookups in tests	2020-09-09 21:21:04 +09:00
smoogipoo	aeae009512	Disable online beatmap lookups in tests	2020-09-09 20:12:40 +09:00
smoogipoo	117c7ec6b2	Merge branch 'master' into score-recalc	2020-09-09 14:38:36 +09:00
Dean Herbert	2cd07b2d3c	Fix editor crash on saving more than once ... I'm fixing this in the simplest way possible as this kind of issue is specific to EF core, which may cease to exist quite soon. Turns out the re-retrieval of the beatmap set causes concurrency confusion and wasn't actually needed in my final iteration of the new beatmap logic.	2020-09-09 12:48:12 +09:00
Dean Herbert	6b50d44dde	Merge branch 'master' into editor-new-beatmap	2020-09-07 18:43:16 +09:00
Dean Herbert	4680728b9c	Merge branch 'master' into update-dcc-exclusions	2020-09-07 18:01:44 +09:00
smoogipoo	9ab6d584d3	Merge branch 'master' into editor-new-beatmap	2020-09-07 14:30:41 +09:00
Dan Balasescu	e17ccdfe9f	Merge branch 'master' into combo-colors	2020-09-07 13:55:41 +09:00
Bartłomiej Dach	f138b92078	Merge branch 'master' into editor-new-beatmap	2020-09-06 18:24:02 +02:00
smoogipoo	1143d5d992	Update class exclusion for dynamic compilation	2020-09-04 20:41:08 +09:00
Dean Herbert	25e142965d	Strongly type and expose default beatmap information icon implementations for other rulesets	2020-09-04 15:01:32 +09:00
Dean Herbert	fba253f131	Take user argument in CreateNew method parameters	2020-09-04 13:17:43 +09:00
Dean Herbert	f14a82e3a9	Remove unnecessary conversion	2020-09-04 13:13:53 +09:00
Dean Herbert	cd253ab055	Further tweaks to get closer to design originals	2020-09-04 13:05:39 +09:00
Dean Herbert	9d2dff2cb8	Add scale to allow legacy icons to display correctly sized	2020-09-04 12:55:39 +09:00
Dean Herbert	d32b77f045	Add missing extension to filename ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2020-09-03 21:33:25 +09:00
Dean Herbert	1c1c583d3b	Fix regression in file update logic (filename set too early)	2020-09-03 19:31:40 +09:00
Dean Herbert	a555407f37	Fix various test failures due to missing beatmap info in empty beatmap	2020-09-03 19:25:18 +09:00
Dean Herbert	72cb65c22f	Update and add missing beatmap statistic icons to info wedge	2020-09-03 17:52:22 +09:00
Dean Herbert	d849f7f2b5	Use the local user's username when saving a new beatmap	2020-09-03 13:20:23 +09:00
Dean Herbert	e337e6b3b0	Use a more correct filename when saving	2020-09-03 13:20:23 +09:00
Dean Herbert	faf9b0a528	Fix hard crash when trying to retrieve a beatmap's track when no file is present	2020-09-03 13:20:23 +09:00
Dean Herbert	e032844570	Start with a fresh beatmap when entering editor from main menu	2020-09-03 13:20:23 +09:00
Craftplacer	c2ade44656	Change types back	2020-09-01 17:58:06 +02:00
Craftplacer	9835d98942	Merge remote-tracking branch 'upstream/master' into combo-colors	2020-09-01 17:39:35 +02:00
Dan Balasescu	f08e7828da	Merge branch 'master' into beatmap-track-rework	2020-09-01 16:06:38 +09:00
Craftplacer	9b3a48ee5e	Revert "Add marker interface for beatmap skins"	2020-08-31 18:29:46 +02:00
Craftplacer	fb37a14d57	Update LegacyBeatmapEncoder.cs	2020-08-31 17:24:03 +02:00
Craftplacer	1484e78654	Update xmldoc	2020-08-31 17:24:00 +02:00
Craftplacer	eafa97af17	Revert changes done to SkinConfiguration and IHasCustomColours	2020-08-31 17:23:42 +02:00
Dan Balasescu	bd2f863b56	Merge branch 'master' into legacy-mirror-mod-replays	2020-08-31 12:41:17 +09:00
Craftplacer	7e668fc31a	Update osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs ... Co-authored-by: Salman Ahmed <email@iisalman.me>	2020-08-30 16:11:49 +02:00
Craftplacer	1fdf8e6200	Fix xmldoc in LegacyBeatmapEncoder	2020-08-30 16:07:58 +02:00
Craftplacer	e428144f73	Use IBeatmapSkin	2020-08-30 11:34:50 +02:00
Craftplacer	00b68b050c	Merge remote-tracking branch 'upstream/master' into combo-colors	2020-08-30 10:16:38 +02:00
Dean Herbert	814655770d	Merge branch 'master' into beatmapskin-interface	2020-08-30 12:22:55 +09:00
Dean Herbert	cd0a73883d	Merge pull request #9945 from smoogipoo/skin-colour-fix-2 ... Exactly reproduce osu!stable skin colour alphas	2020-08-29 20:06:26 +09:00
Bartłomiej Dach	658a1d159f	Add legacy flag value for mirror mod	2020-08-29 11:45:59 +02:00
Craftplacer	82acb3506c	Add and change xmldocs	2020-08-29 11:07:28 +02:00
Craftplacer	4cb9e1d443	Initial commit	2020-08-29 10:33:43 +02:00
smoogipoo	436dbafe57	Fix incorrect comparison for mods of different instances	2020-08-28 22:12:17 +09:00
smoogipoo	43c61e5830	Re-query beatmap difficulty before computing	2020-08-28 22:08:28 +09:00
smoogipoo	4d15f0fe52	Implement basic score recalculation	2020-08-28 19:16:46 +09:00
Craftplacer	e6646b9877	Resolve review comments	2020-08-23 15:08:02 +02:00
Dean Herbert	b72f06fef6	Centralise and clarify LoadTrack documentation	2020-08-22 19:42:34 +09:00
smoogipoo	88d50b6c47	Remove alpha mangling from LegacyDecoder	2020-08-22 00:15:37 +09:00
Dean Herbert	d2c2e8bbe8	Revert some more usage of MusicController back to WorkingBeatmap	2020-08-21 15:17:21 +09:00
Dean Herbert	526f06be4c	Add back track loaded bool in WorkingBeatmap	2020-08-21 13:53:37 +09:00
Dean Herbert	357fb3a10e	Merge branch 'master' into beatmap-track-rework	2020-08-21 12:53:09 +09:00
Dean Herbert	083bcde3cf	Fix beatmap transfer not working	2020-08-18 13:01:35 +09:00
smoogipoo	583760100a	Implement mania invert mod	2020-08-18 01:40:55 +09:00
Dean Herbert	d9debef156	Add explicit LoadTrack method	2020-08-17 15:38:16 +09:00
Dean Herbert	71f4e753f0	Merge branch 'master' into beatmap-track-rework	2020-08-16 22:35:32 +09:00
Craftplacer	1448c9e381	Merge remote-tracking branch 'upstream/master' into combo-colors	2020-08-15 23:01:38 +02:00
Craftplacer	c4a7fac760	Add required parameters and other various changes	2020-08-15 22:03:24 +02:00
Dean Herbert	c3757a4660	Fix beatmap covers not being unloaded in most overlays ... Eventually we'll probably want something smarter than this, but for the time being this helps stop runaway memory usage.	2020-08-14 19:22:26 +09:00
smoogipoo	91e28b849d	Fix incorrect BeatmapManager construction	2020-08-13 00:29:23 +09:00
Craftplacer	8ffaa49839	Handle additional null case	2020-08-12 06:40:21 +02:00
Craftplacer	139c0c75f8	Add documentation for constructor	2020-08-12 06:40:21 +02:00
smoogipoo	b66f303e71	Add annotation	2020-08-12 00:48:45 +09:00
smoogipoo	faff0a70c4	Privatise BMWB	2020-08-11 13:48:57 +09:00
smoogipoo	338c01fa43	Remove track store reference counting, use single instance stores	2020-08-11 13:16:06 +09:00
Craftplacer	78692dc684	Initial commit	2020-08-10 05:21:10 +02:00
smoogipoo	e87f50f74f	Rename method	2020-08-07 22:31:41 +09:00
smoogipoo	b6fb7a0d39	Fix possibly setting null track	2020-08-07 22:05:58 +09:00
smoogipoo	f53672193e	Fix track stores being kept alive	2020-08-06 17:48:07 +09:00
smoogipoo	86ae61c6b7	Re-implement store transferral in BeatmapManager	2020-08-06 16:24:14 +09:00
smoogipoo	6e42b8219c	Move track to MusicController, compiles	2020-08-06 16:24:14 +09:00
smoogipoo	4648362214	Safeguard against potential finalise-before-initialised	2020-07-29 11:30:25 +09:00
smoogipoo	a57b6bdc18	Remove cancellation of linked tokens	2020-07-29 11:29:38 +09:00
smoogipoo	fa25f8aef9	Dispose update scheduler	2020-07-28 17:23:35 +09:00
smoogipoo	96f68a3251	Reorder method	2020-07-28 16:53:07 +09:00